[00:00:54] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [00:05:31] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/73449 [00:08:59] New patchset: Ori.livneh; "Rename 'parse' to 'parser' to touch repo for git-deploy" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73906 [00:09:20] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73906 [00:11:35] New patchset: Ori.livneh; "Revert "Rename 'parse' to 'parser' to touch repo for git-deploy"" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73907 [00:11:43] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73907 [00:13:14] New patchset: Kaldari; "Don't construct titles like User:User:Hoo in JS" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73883 [00:14:10] Change merged: jenkins-bot; [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73883 [00:17:07] mwalker: Yep, I think you were right! I updated everything and now the only errors seem to be ones I've caused :P [00:18:18] awesome! :) [00:23:42] greg-g, the way that you are saying 'SUL will be enabled' is incredibly misleading [00:24:18] I believe CentralAuth was deployed in something like 2008 [00:24:39] The way it works is changing, but SUL isn't being 'enabled' [00:41:02] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73911 [00:41:51] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73912 [00:42:02] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73912 [00:42:16] Going to do my LD now, an hour late [00:42:23] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73911 [00:50:07] New patchset: MarkTraceur; "First iteration" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [00:50:31] New review: MarkTraceur; "Much better - use wfRunHook to let extensions register via a hook." [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [01:00:25] New review: Adamw; "(1 comment)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [01:04:57] New patchset: Spage; "Fix $wgDebugLogFile location." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73914 [01:05:47] New patchset: Mwalker; "Redoing Logging to Make it Less Stupid" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [01:13:35] New review: Parent5446; "Responded to inline." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [01:17:50] Argh, CSS. What's the stupid incantation for floating two divs next to each other? float: left; display: inline-block; or something? [01:18:21] New patchset: Mwalker; "Force STOMP Reconnections on Selector Change" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/73880 [01:18:23] New review: Mwalker; "(1 comment)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/73880 [01:18:28] New patchset: Mwalker; "Force STOMP Reconnections on Selector Change" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/73880 [01:18:28] New patchset: Mattflaschen; "Add GuidedTour" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73915 [01:21:26] Krenair: oh? that's basically how csteip wrote it up [01:23:34] New patchset: MarkTraceur; "Redesign and add more information" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73916 [01:26:02] New review: Mattflaschen; "Works for me, but I had to rebase on top of the GuidedTour change. Probably, Puppet was confused be..." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/73914 [01:26:40] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [01:26:49] New patchset: MarkTraceur; "Work with the newer versions of BetaFeatures" [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [01:27:19] New review: MarkTraceur; "Forgive my questionable screenshot." [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [01:27:47] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/73880 [02:04:18] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [02:25:19] New patchset: MarkTraceur; "Work with the newer versions of BetaFeatures" [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [02:52:27] New patchset: Legoktm; "If the local user has the bot userright, mark the edit as bot." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [02:53:15] New patchset: Legoktm; "If the local user has the bot userright, mark the edit as bot." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [02:55:20] New patchset: MZMcBride; "If the local user has the bot userright, mark the edit as bot." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [02:55:56] Elsie: thanks :) [02:57:23] New patchset: MZMcBride; "If the local user has the bot userright, mark the edit as bot." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [02:57:31] No problem. [03:11:14] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #168: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/168/ [03:20:57] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #113: FAILURE in 9 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/113/ [03:23:32] New review: CSteipp; "Looks ok, and working fine in my testing. Messages are escaped multiple times (< inside the warning ..." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/73895 [03:23:43] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/73895 [03:25:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #113: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/113/ [03:27:16] New patchset: MarkTraceur; "First iteration" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [03:27:57] New patchset: MarkTraceur; "Redesign and add more information" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73916 [03:30:38] Elsie / legoktm: what's the difference between 'bot' and 'markbotedits'? [03:31:12] for example, in includes/WikiPage.php:2852, I see: if ( $bot && ( $guser->isAllowedAny( 'markbotedits', 'bot' ) ) ) { [03:31:42] I believe 'bot' is an historical artifact. [03:32:13] Oh, no. [03:32:20] https://en.wikipedia.org/wiki/Special:ListGroupRights [03:32:27] According to that, markbotedits is just for rollback. [03:32:54] The "bot" user right affects whether to treat a user as a bot for the purposes of RecentChanges, Watchlist, etc. [03:33:24] OK. So legoktm's change (73918) is correct not to check 'markbotedits' -- it's not relevant there. [03:33:32] Correct. [03:33:59] When admins do a mass-rollback, they have the option to set &bot=1. [03:34:08] New patchset: MarkTraceur; "Add beta preferences section and more" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73920 [03:34:12] Which then changes every rollback link to mark the edit as automated/bot. [03:34:26] There may also be some dark magic that allows an admin to set any arbitrary edit as a bot edit. [03:34:50] Bots themselves can choose to flag their own edits as bot or not (some deliberately expose their edits for extra review). [03:35:12] And then of course there's http://botornot.wikimedia.org in which you can choose which bot is more sexually attractive. [03:36:13] I admit, I clicked. [03:37:02] We don't have many good Easter eggs on that domain. [03:39:32] New review: Ori.livneh; "Looks good to me." [mediawiki/extensions/TranslationNotifications] (master) C: 1; - https://gerrit.wikimedia.org/r/73918 [03:40:23] I'd +2, but I don't maintain that extension, and Siebrand is prompt in responding to review requests. [03:40:25] New review: Mattflaschen; "See inline comments, in addition to this" [mediawiki/extensions/PronunciationRecording] (master) C: -1; - https://gerrit.wikimedia.org/r/73017 [03:40:30] http://coffee.wikimedia.org [03:40:44] Yeah, he should be awake in a few hours. [03:41:15] > [03:41:16] # TODO: this is not a human-usable site, can be killed (along with its DNS record) [03:41:20] # sometime in 2013 [03:41:22] > [03:41:42] Re: http://wlm.wikimedia.org [03:52:38] New patchset: MarkTraceur; "Don't display empty preference sections" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [03:59:39] New review: MarkTraceur; "We need to change the commit message, and I need to run one more test, but otherwise it's ready to go!" [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/66561 [04:04:39] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [04:06:10] New review: MarkTraceur; "It looks like, when I disable the preference, the description form doesn't have any descriptions by ..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [04:15:25] Elsie: you can write to ops-requests@rt.wikimedia.org and request that the domain be killed [04:18:44] Yeah, or Bugzilla presumably. CBA, though. [04:18:57] New review: Mattflaschen; "Looks good" [mediawiki/extensions/Annotator] (master) C: 2; - https://gerrit.wikimedia.org/r/71364 [04:19:05] Change merged: jenkins-bot; [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [04:21:05] Change merged: KarenEddy; [mediawiki/extensions/BiblioPlus] (master) - https://gerrit.wikimedia.org/r/72685 [04:21:26] New review: EBernhardson; "Looks good, there is a small amount of code that is no longer used and can be removed." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/72672 [04:22:50] What's the point in having a joke coffee.wikimedia.org domain if it just redirects to https://en.wikipedia.org/wiki/Hyper_Text_Coffee_Pot_Control_Protocol . [04:23:01] It should implement it. :) [04:23:12] First I heard of that [04:31:40] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/73612 [04:33:43] ori-l: Thanks. I worked hard on the commit message for you :P [04:36:27] New patchset: Spage; "support CentralAuthPostLoginRedirect hook" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [04:41:07] New review: Spage; "I'm certain this doesn't work, just getting a patch for a labs machine." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/73922 [04:43:16] New patchset: Santhosh; "Support explicit plural forms at client side l10n" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73567 [04:45:33] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73921 [04:48:54] New review: Mattflaschen; "It would be good to also change onBeforeWelcomeCreation to work the same way. That would allow gett..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73922 [04:48:55] New review: MarkTraceur; "Good point, sec." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [04:49:34] New patchset: Pastakhov; "Refactoring, compiler is used instead of the interpreter (version 1.0.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [04:51:24] New review: Pastakhov; "add numbers, operators + - * / and negative" [mediawiki/extensions/Foxway] (master) C: -2; - https://gerrit.wikimedia.org/r/72073 [05:01:54] New patchset: MarkTraceur; "Don't display empty preference sections" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [05:35:25] New patchset: Legoktm; "Prevent Special:Contributions from indicating that an IP address is autoblocked" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73923 [06:04:49] New review: Ori.livneh; "(1 comment)" [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/73914 [06:06:53] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73915 [06:13:40] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [06:20:01] New review: Physikerwelt; "To my mind the only open issue is:" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [06:22:00] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [07:04:13] New review: Nikerabbit; "Looks good, but only metawiki should use publishHere, not all Wikimedia wikis like the commit messag..." [mediawiki/extensions/TranslationNotifications] (master) C: -1; - https://gerrit.wikimedia.org/r/73918 [07:09:21] Nikerabbit: if a user on wikidata sends a notification to other wikidatans, wont that use publishHere tool? [07:09:33] too* [07:10:21] legoktm: it the extension is installed there [07:10:33] it is [07:11:12] I was about to update the commit message but then feared it was too much nitpicking :) [07:11:52] well, that's still about 8 wikis, not all of them [07:12:05] New patchset: Nemo bis; "If the local user has the bot userright, mark the edit as bot." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [07:13:09] I think ^ works. thanks Nemo_bis :) [07:17:49] is zuul/jenkins stuck or just slow? [07:18:59] impaatient, just a min [07:19:53] there is nothing in https://integration.wikimedia.org/zuul/ [07:20:21] bug 44210 was more relevant for the commit btw [07:22:09] Nikerabbit, I like the Archipelago style at https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example ;) [07:23:16] Change merged: jenkins-bot; [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/73918 [07:23:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73567 [07:26:29] New patchset: Ori.livneh; "Add skipThenUpdateDisplay public method and use it for shouldSkip." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673 [07:26:49] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673 [07:27:28] moarning [07:28:19] hi hashar [07:28:48] I am still sleeping, don't tell anyone [07:29:00] * hashar realize he does have to actually show up at work to pretend he is working. [07:29:51] ori-l: nice to see some activity on fluoride :-] [07:30:30] :) [07:30:35] thought I have no idea how the event logging instance in beta is setup nor how to have fluoride to subscribe on the event stream :D [07:31:07] oh, they're not really related, and in fact i spun it out of the eventlogging module.. i just used a similar pattern [07:31:40] namely whenever i need to work with some udp stream the first thing i do is just put in place a tiny daemon that converts it into a zeromq publisher [07:31:51] running on the same port number, but tcp [07:32:13] instantly you get buffering to handle disconnects gracefully and the ability to consume the stream from multiple programs [07:32:44] ahh [07:33:21] and the zeromq api is designed to look like the unix (bsd) socket api, so the client code looks almost identical [07:35:02] the publisher keeps a small buffer for each subscriber, and subscribers are known by a socket_id, which is just a byte array [07:35:37] so you can actually use that to upgrade code without losing data [07:35:43] poor man's erlang/otp [07:36:24] anyways i shouldn't talk so loudly if you are still sleeping :P [07:36:57] New patchset: Pastakhov; "Refactoring, compiler is used instead of the interpreter (version 1.0.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [07:36:58] yeah I guess it is too early for me to catch even half of those principles :-] [07:39:00] New patchset: Hashar; "standalone phpunit for Ask and Diff" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65467 [07:40:02] enh, i must be explaining it badly [07:40:31] New review: Pastakhov; "Add all assignment operators, operator mod, fix for multiple operations with the same priority after..." [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [07:41:37] ori-l: any way to catch udp patckets into zeromq via udp? I wrote some cute mini-loggers that do UDP [07:43:42] don't want to have TCP-associated state [07:45:30] saper: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEventLogging.git/580067d4494e7e72e4854e3688e953866a0dc5ac/server%2Fbin%2Feventlogging-forwarder ? [07:45:54] New patchset: Hashar; "operations-puppet-spec" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73928 [07:46:29] ori-l: thanks [07:46:41] New patchset: Ori.livneh; "Fix $wgDebugLogFile location." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73914 [07:46:41] New patchset: Ori.livneh; "Expand explanatory comment on GS & GT roles" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73929 [07:47:07] New review: Hashar; "The very lame job is https://integration.wikimedia.org/ci/job/operations-puppet-spec/ but it obviou..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73928 [07:47:18] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73914 [07:48:08] ori-l: you probably explain it well, it is just that I have barely slept for the last few days :D [07:50:00] New review: Ori.livneh; "Looks OK, but needs a manual rebase." [mediawiki/extensions/GuidedTour] (master) C: 1; - https://gerrit.wikimedia.org/r/64981 [07:50:34] New patchset: Pastakhov; "Refactoring, compiler is used instead of the interpreter (version 1.0.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [07:51:44] New review: Pastakhov; "add operators &, |, ^, <<, >>, and, xor, or" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [08:12:38] New patchset: Ori.livneh; "Add 'udp-zmq-forwarder' script, imported from EventLogging" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73930 [08:28:44] New patchset: Mwjames; "SMW\PropertyDisparityFinder to eleminate scope creep in SMW\ParserData (Part 1)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [08:29:28] New patchset: Mwjames; "SMW\PropertyDisparityFinder to eliminate scope creep in SMW\ParserData (Part 1)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73931 [08:29:38] New patchset: Siebrand; "Disable default web font for language code "ml" again." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73932 [08:34:13] New patchset: Ori.livneh; "Add 'udp-zmq-forwarder' script, imported from EventLogging" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73930 [08:34:39] New patchset: Nikerabbit; "Disable default web font for language code "ml" again." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73932 [08:36:27] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73930 [08:36:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73932 [08:37:42] New patchset: Hashar; "standalone phpunit for Ask and Diff" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65467 [08:39:29] New review: Hashar; "demo job for the Diff extension: https://integration.wikimedia.org/ci/job/phpcomponent-Diff-phpunit/" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65467 [08:45:36] New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73935 [08:51:53] New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73936 [08:59:13] hey hashar [08:59:44] gerrit (via ssh) seems very slow atm. what's up? [09:00:33] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73935 [09:02:37] DanielK_WMDE_: I don't know. Nikerabbit and I are suffering from the same thing. hashar said "WFM" 25 minutes ago. [09:03:42] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73936 [10:40:28] New patchset: Hashar; "remove mediawiki-core-merge" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73944 [10:40:59] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73944 [10:41:43] ori-l: hmm I'm trying to event log a click of a link that goes to a different page... and of course it doesn't work because the browser navigates away... what should I do? [10:42:10] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70646 [10:46:39] andre__: hey! that bug (campaigns migration script) is for wmf11, so no deployment has started [10:46:41] for it. yet [10:51:12] New patchset: Hashar; "remove all -merge jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73947 [11:01:19] YuviPanda_, ufff? That was so not clear from the bug description :-/ [11:01:29] andre__: it mentions wmf11 in the comments [11:01:33] not wmf10 [11:01:58] I'm stupid. :) [11:02:01] YuviPanda_, thanks for clarifying [11:02:02] heh [11:02:32] andre__: heh, an off by one error :D [11:12:37] New patchset: Esanders; "Use fixed position for notifications" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73948 [11:36:40] New patchset: Nikerabbit; "Log settings-open event" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73949 [11:38:11] New review: Nikerabbit; "Need help to figure out how to log only one event when opened from preferences. Currently it logs tw..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73949 [11:40:17] New patchset: Nikerabbit; "Log login-click event" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73950 [11:41:51] New review: Nikerabbit; "Doesn't actually work because browser navigates away before this is done." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73950 [11:43:30] New patchset: Santhosh; "[WIP] Content editable support" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71602 [11:54:22] New patchset: SuchABot; "Add YuviPanda to Credits" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/73951 [12:03:23] New patchset: Nikerabbit; "Log no-search-results event" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73953 [12:03:59] New review: Nikerabbit; "jquery.uls doesn't currently expose the noresults callback from jquery.languagefilter." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73953 [12:17:31] New patchset: Thaiphan; "Fix issue with images not being uploaded" [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/73737 [12:23:55] New patchset: Matthias Mullie; "Fix auto-archive script" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/73954 [12:40:11] New review: Krinkle; "This breaks when there are more notifications that fit on the height of the screen. Unlike OS X Noti..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73948 [12:40:48] New review: Krinkle; "Note that I fully support going with fixed position, it makes perfect sense and it is a severe UX bu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73948 [12:48:22] New review: Krinkle; "I'm not saying it makes sense, but that's how it was. It probably filtered out certain things like t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [12:49:30] New patchset: Krinkle; "Add "(No differences)" on a empty diff" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [12:52:50] New patchset: Mwjames; "(Bug 51435) SMW\NamespaceExaminer return false instead of an Exception" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73956 [12:55:18] New patchset: Krinkle; "diff: Display "(No differences)" instead of an empty diff" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [12:55:55] New review: Krinkle; "* Added release notes." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/73014 [13:03:35] New review: Krinkle; "Looks like these messages where changed somehow, they didn't always have the $1 parameters." [mediawiki/extensions/InlineCategorizer] (master) - https://gerrit.wikimedia.org/r/73719 [13:07:18] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355 [13:07:23] New review: Matthias Mullie; "Works great." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/70112 [13:08:36] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73956 [13:19:56] New patchset: Mwjames; "SMW\CompatibilityTestCase to pass tests on MW 1.19.7 as well" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73959 [13:24:50] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73959 [13:34:02] New patchset: Hashar; "merge conflict" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70646 [13:43:57] New review: Matmarex; "Dupe of my patch at https://gerrit.wikimedia.org/r/#/c/72322/ , and fails completely on IE6 which do..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73948 [13:46:01] New review: Matmarex; "This should be doable with some tricks https://bugzilla.wikimedia.org/show_bug.cgi?id=50870#c3 , but..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [13:46:56] New patchset: Helder.wiki; "Use fixed position for notifications" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73948 [13:47:38] New review: Hashar; "Timo, I removed the -merge job for mediawiki/core, that seems to work properly ( https://gerrit.wiki..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73947 [13:50:18] New patchset: Amire80; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [13:50:41] hoo: ping. Just had idea of a new bug relating to my AbuseFilter-changeset [13:51:20] I'm here ;) [13:52:31] New review: Shirayuki; "Thanks." [mediawiki/extensions/InlineCategorizer] (master) - https://gerrit.wikimedia.org/r/73719 [13:53:52] se4598 ^ [13:54:43] hoo: Do the new global filters also run over this codepath. I suppose it would show a "wrong" ID (the remote one?). But I would call this then rather a bug for global filters than on my change. [13:55:18] You probably would get something like global-123, yes [13:55:23] but we can't change this [13:55:48] these IDs aren't supposed to be human readable, but unique identifiers [13:56:15] hoo: are they prefixed?, just throught this is some int autoincrement-column or so [13:56:41] se4598: Global filters are prefixed with global- on non-central wikis [13:56:55] then theres no bug :) [13:57:18] although the function parameter docu is wrong [13:57:42] typical ... [14:06:34] New patchset: Anomie; "Export information about external image settings via siteinfo API." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73199 [14:07:10] New review: Anomie; "That'll work. We'll see if anyone complains about the growing size of the 'general' section." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/73199 [14:11:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73199 [14:19:09] New review: Krinkle; "Note that I fully support going with fixed position, it makes perfect sense and it is a severe UX bu..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72322 [14:29:23] New patchset: Krinkle; "Remove all -merge jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73947 [14:34:14] New patchset: Zfilipin; "Scenario: Visual editor does not appear if user is not logged in" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73967 [14:41:28] New patchset: Hashar; "HTCPPurge() early exit on socket error" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71596 [14:44:02] New patchset: Hashar; "$wgHTCPMulticastRouting rename + multi hosts support" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597 [14:44:46] New patchset: Cscott; "PHP code style clean up for ApiQuerySiteinfo.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73973 [14:45:22] New review: Cscott; "This added a code style error (2 blank lines in a row) which I've fixed in I3c628eab101ee97d0182ee2d..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73199 [14:48:52] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73947 [15:00:48] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73975 [15:18:03] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73975 [15:21:55] New patchset: Anomie; "Hooks to tie OAuth in with User rights and the API" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73977 [15:27:15] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/73973 [15:31:00] New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73973 [15:31:12] New patchset: Cscott; "PHP code style clean up for ApiQuerySiteinfo.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73973 [15:49:35] New review: Umherirrender; "Changes looks good to me. Thanks for that." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [15:50:14] gwicke: could you review https://gerrit.wikimedia.org/r/66300 when you get a chance today? [15:50:56] whoops, wrong room. that's a parsoid patch. [15:59:58] hashar: ping [16:00:02] pong [16:00:21] joining hangout [16:01:49] Public Service Announcement: IRC Office Hour on bug management and Bugzilla starting now in #wikimedia-office [16:09:41] New review: Brion VIBBER; "panda for the win!" [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/73951 [16:09:47] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/73951 [16:18:18] New patchset: SuchABot; "Do not crash when trying to upload multiple files" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73979 [16:21:39] New review: Anomie; "Seems sensible. Also, I note that [[mw:HTML5]] seems to be out of date, as support for setting $wgHT..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/72981 [16:21:41] New patchset: SuchABot; "[WIP] Initial move to Holo Light than Holo Dark" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [16:21:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72981 [16:31:47] New review: Hashar; "related https://bugzilla.wikimedia.org/show_bug.cgi?id=42961" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72314 [16:36:49] New patchset: SuchABot; "Added new launcher icons" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73748 [16:39:18] New review: Esanders; "How likely is it there will be more notifications than the height of the screen? Yes it needs to be ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [16:47:15] New review: Brion VIBBER; "A few notes after a brief look:" [apps/android/commons] (master) C: -1; - https://gerrit.wikimedia.org/r/73981 [17:12:55] New review: Brion VIBBER; "On Nexus One / Gingerbread, the share-activity lets me scroll down to the title and description but ..." [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [17:13:57] New review: Cmcmahon; "Amir, can you verify that when you press CONTROL-M *manually* at the appropriate place in test2wiki ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [17:15:08] ^demon: there's no way to attach photos to gerrit reviews other than uploading them somewhere else and posting a link, is there? [17:16:55] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73929 [17:17:19] <^demon> brion: No, but that's a good feature request :) [17:17:48] <^demon> The comments are already "parsed" for a semi-markdown format, so it wouldn't be impossible. [17:17:58] New patchset: Ori.livneh; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [17:18:09] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [17:19:40] *nod* [17:20:13] github seems to use a similar markup, and has a cute behavior where you can drag-and-drop files and it uploads, then inserts the appropriate markup into your comment to load the image [17:20:19] mainly just need a place to stash em [17:21:36] <^demon> Yeah. I'll file an enhancement request. [17:22:23] squee :D [17:22:24] thx [17:23:17] <^demon> https://code.google.com/p/gerrit/issues/detail?id=2015 filed. [17:29:22] here's a fun one for y'all [17:29:38] in extensions/CoreEvents/CoreEvents.php, we find the following code: [17:29:44] if ( !empty( $_SERVER[ 'HTTP_USER_AGENT' ] ) ) { [17:29:44] $event[ 'userAgent' ] = $_SERVER[ 'HTTP_USER_AGENT' ]; [17:29:45] } [17:29:58] despite the check, I get events with "userAgent":null [17:30:09] but... and here's the best part. only from frwiki. [17:31:09] ori-l: is it consistent, like some kind of weird bot? [17:32:10] hmmm. maybe! let me try and correlate it. i do notice now that they're all API edits. [17:33:01] i was going to attribute it to https://en.wikipedia.org/wiki/Diff%C3%A9rance [17:34:42] brion: yes, all from the same bot. [17:34:45] huh. [17:34:55] it may not be sending a user-agent [17:35:08] wouldn't the empty check take care of that? [17:35:25] you'd think... [17:37:32] <^demon> ori-l, brion: What does $event['userAgent'] get set to when the thing *is* empty? [17:37:48] it's just unset [17:37:58] <^demon> Hrm :\ [17:38:48] legoktmmmmm: Finished your Buddhist monk training? [17:38:54] Heh :P [17:38:59] :D [17:38:59] freenode wont let me nick to "legoktm" [17:48:33] New review: Brian Wolff; "Not this commit, but CategorySlideShowHooks::onCategoryPageView uses $wgUser without declaring "glob..." [mediawiki/extensions/CategorySlideShow] (master) - https://gerrit.wikimedia.org/r/73917 [17:50:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73923 [17:53:22] New review: Brian Wolff; "(1 comment)" [mediawiki/extensions/BetaFeatures] (master) C: -1; - https://gerrit.wikimedia.org/r/73903 [17:53:34] New review: Matmarex; "Personally I'd consider notifications "overflowing" below the screen better than overflowing in more..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [17:55:41] New review: MZMcBride; "I agree with Ed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [17:56:07] * Elsie pets MatmaRex. [17:56:57] hi Elsie [17:57:03] Hi. :-) [17:57:10] MatmaRex: Want a fun design bug? :D [17:57:19] It involves section headers. [17:57:24] New review: Anomie; "It appears that Parsoid has a copy of parserTests.txt, using rawhtml. Is changing that here going to..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73111 [17:58:06] do i look like i do? :P [17:58:13] bring it, but no promises [17:58:34] New review: Brian Wolff; "(Just +1 instead of +2 since its dependant on other changes)" [mediawiki/extensions/BetaFeatures] (master) C: 1; - https://gerrit.wikimedia.org/r/73916 [17:58:36] i really didn't feel like doing stuff last few days. i have a huge list of movies that need watchin', you know. :D [17:58:51] New review: GWicke; "@Anomie: We are syncing up with core regularly, so I don't expect issues." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73111 [17:59:10] and a few books that need readin' and games that need playin', too. [17:59:13] MatmaRex: https://www.mediawiki.org/wiki/Requests_for_comment/Clickable_section_anchors [17:59:28] New review: Anomie; "Ok then." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/73111 [17:59:32] New patchset: CSteipp; "Script to delete private data" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/45696 [18:00:09] Elsie: that ain't a bug. [18:00:18] and ugh, no brackets for this, please [18:00:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=16691 [18:00:43] i think the symbol on hover is pretty common UI feature nowadays [18:01:39] also, why did you mess with [edit] links there? [18:01:59] Where? [18:02:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73111 [18:02:11] I think the idea was to demonstrate in context. [18:02:24] Though now [edit] links are [edit | edit source] or whatever. [18:02:39] well, everywhere on https://www.mediawiki.org/wiki/Requests_for_comment/Clickable_section_anchors#Proposed_implementations . [18:02:53] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [18:02:56] ah, this is using the old .editsection class [18:03:33] * MatmaRex fixes it [18:05:35] doned [18:06:14] Anyway, if you have any interest... :-) [18:06:28] I'm still not sure how a hover approach would work on devices that don't really like hovering. [18:07:03] New patchset: CSteipp; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [18:07:15] New patchset: Cscott; "Code style cleanups to parserTest.inc and NewParserTest.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73986 [18:07:15] it probably wouldn't :D [18:07:38] And some people don't really seem to like to see icons pop up on scroll. [18:07:50] There have been complaints about [edit] --> [edit | edit source] doing that. [18:08:06] "edit source" is large. "#" is tiny. [18:08:06] New review: Cscott; "The code style build failure is not due to this patch." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73111 [18:08:28] I think we'd use a link symbol or a paragraph symbol. [18:08:31] But yeah, I agree. [18:08:45] but yeah, it might make sense to just show it all the time [18:08:49] Wouldn't doing this in JS be like five minutes of work? [18:09:24] yeah. [18:09:42] I'll start the timer. [18:09:46] New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73794 [18:09:46] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73794 [18:11:45] Yippie, build fixed! [18:11:45] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #169: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/169/ [18:13:07] Elsie: http://pastebin.com/TaEaX1h5 [18:13:11] Yippie, build fixed! [18:13:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #191: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/191/ [18:14:10] yeah, around five minutes. :D [18:15:01] :D [18:16:40] New patchset: Aaron Schulz; "Make it easier to override the DB used for a Pager subclass" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73988 [18:16:42] ^demon: ^ [18:16:51] New review: Brian Wolff; "Is the idea here that someone would go to Special:BetaFeatures to enable a feature, then Special:Pre..." [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73920 [18:17:43] MatmaRex: Threw that on the talk page for now. [18:20:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73988 [18:20:38] New patchset: Aaron Schulz; "Use self-releasing (for reuse) DB connections" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73989 [18:20:46] csteipp: ^ [18:21:06] MatmaRex: Missed context but I wrote a gadget for '#' links a few months ago, it's on mw.org [18:21:23] https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Clickable_section_anchors [18:21:23] still very hacky but stable enough for me to have it enabled by default [18:21:32] (for myself that is, not for everyone) [18:21:45] New patchset: Alex Monk; "Don't trigger event when user rights change is cross-wiki" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73990 [18:21:48] MediaWiki:Gadget-vector-headanchor.js [18:22:01] https://www.mediawiki.org/wiki/MediaWiki:Gadget-vector-headanchor.js [18:22:29] https://www.mediawiki.org/wiki/Talk:Requests_for_comment/Clickable_section_anchors#Implementation_.282.29 [18:22:33] (link powered by said gadget) [18:23:40] Yippie, build fixed! [18:23:40] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #114: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/114/ [18:24:26] hm, neat. but that github's icon looks really stupid to me in general :) [18:24:43] also, stuffing things in left margin is nice when you have a large margin there [18:24:57] it's hardcoded for dimensions of vector-hd [18:25:13] even on vector-hd it looks reather crowded [18:25:37] http://cl.ly/image/452y3h1O2P2b [18:25:58] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73921 [18:26:07] yes,i'm looking at the same thing, and it's rather crowded to me :) [18:26:38] imo there should be 1em of margin, just like with the editsection links, and then the icon would have to bleed out to the sidebar [18:26:38] Yeah, I don't love that layout. [18:26:55] which looks like it would be difficult to get right [18:26:55] showing '#' everywhere seems more crowded [18:26:59] Yippie, build fixed! [18:27:00] and is about the same size as this icon [18:27:00] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #114: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/114/ [18:27:01] New review: Yuvipanda; "(Note: Gerrit sucks. grr)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73981 [18:27:10] it's also light-grey :) [18:27:23] I agree it shouldn't be black [18:27:44] be sure to give it plenty of padding to be easier to click (on the entire height of the header, not just the line height of the smaller font in the ) [18:27:44] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [18:27:49] I think it should only display when needed. [18:27:55] New review: MarkTraceur; "What's the alternative? The section should be contained in a fieldset, it just shouldn't have a lege..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [18:28:00] <^demon> Krinkle: You should make it orange. Orange is my favorite color. [18:28:12] yeah, what i did was a five-minute mockup :) [18:28:41] <^demon> "Why did you pick orange?" "Same reason we went with a unicorn" "Oh...Chad opened his mouth again?" "Yep" [18:28:51] orange is awesome. [18:29:00] csteipp: The only extra change in AbuseFilter is "Avoid wgUser in AbuseFilterHooks edit handlers" - is that OK to go to wmf9 and wmf10 as well? [18:29:00] ^demon: Did I ever tell you about my cousin who thought he was an orange? [18:29:01] wait, the unicorn not being pink is ^demon's fault!?! [18:29:27] ^demon: Well, we would have put him a way, except we needed the juice. [18:29:29] James_F: It should, yes... no message changes, just some slight refactoring [18:29:34] https://integration.wikimedia.org/cover/mediawiki-core/master/php/ <-- is that right? [18:29:40] http://www.imdb.com/title/tt0620809/quotes?item=qt0524242 [18:29:47] hoo: Hello, Chris. Your nick has changed. ;-) [18:30:05] :D [18:30:06] GorillaWarfare: looks very much likely at a glance :P [18:30:14] MatmaRex: :< [18:30:19] I wasn't around until just now [18:30:21] but, hm, slightly low after all [18:31:09] GorillaWarfare: No, I think something broke in the coverage output. It wasn't like that a few weeks ago [18:31:13] hoo: No worries. :-) [18:31:22] Krinkle: That would be reassuring [18:31:57] a lot of the code comes from simpler times when Wikipedias were running whatever brion coded up last evening and is not really well-tested (nor well-testable) :D [18:32:27] :) [18:32:43] * MatmaRex looks at EditPage.php [18:33:43] don't look at EditPage.php [18:33:45] it will drive you mad [18:35:01] i have already embraced the madness [18:35:12] it drove brion made enough that now he spends most time writing Java and Objective-C :) [18:35:12] i made patches to the Parser after all [18:35:52] anonymous inner classes! [18:36:06] anonymous static inner classes! [18:36:30] brion: we should actually go through our code and make sure we don't have anything non-static inner class that could be static. That leaks memory... [18:36:47] MatmaRex: Feel like refactoring EditPage.php to use the APIs like proper code instead of direct hooks? :_) [18:37:00] git rm EditPage.php [18:37:06] If only. [18:37:07] James_F: haha, good one. :P [18:37:23] MatmaRex: I'm going to get it done at some point. If not you, someone else will get the glory. ;-) [18:38:12] it works, let's not touch it. features are waiting to be added! :D [18:38:28] EditPage rewrite is something for 2.0 ;) [18:38:44] New patchset: Cscott; "Code style cleanups to Sanitizer.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73991 [18:39:01] MatmaRex: So, next month [18:39:03] ;-) [18:39:17] New review: Cscott; "The build failure is because of code style issues which weren't caused by this patch." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72981 [18:39:17] New patchset: Aaron Schulz; "Cleaned up special pages and directories" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73798 [18:39:27] James_F: you should hire him for a summer to do that :) [18:39:28] !2.0 | James_F [18:39:34] YuviPanda: i think most of the anon inner classes are event handler,s which should be pretty safe as those should get discarded [18:39:41] but yeah we should do code hygienic :D [18:39:45] gah, don't tell me wm-botis on strike again. [18:40:24] brion: true, but if we aren't using the parent's 'this' in the inner class, we should declare them as static, because otherwise the parent class's instance might live longer than they have to. but yeah, minor issue [18:40:32] !yss | MatmaRex [18:40:36] hmm, looks like [18:40:37] *nod* [18:41:42] hm, with hashar not around, is there anyone i can bug about jenkins? [18:41:52] it's failing for no good reason, it seems [18:41:53] New review: Brion VIBBER; "should work, recommend follow-up code hygiene per comments on github" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73979 [18:42:44] petan: ^^^^ [18:42:53] brion: "should work +2" :D [18:43:17] <^demon> EditPage is my favorite class! [18:43:19] * ^demon hides from the mob [18:43:28] YuviPanda: Aren't you busy in the Mobile team? 'Cos I'd be happy to steal you. ;-) [18:43:39] James_F: Didn't you get the memo, I sortof suck :P [18:43:52] YuviPanda: I certainly didn't get that memo. Quite the reverse. :-) [18:43:55] James_F: but yeah, mobile and toollabs have me all [18:44:46] Yippie, build fixed! [18:44:48] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #163: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/163/ [18:45:58] Krinkle: BTW, is there that code coverage prettiness for VE/non-MW-core? [18:46:59] New review: Parent5446; "You should be able to just return the raw . Remember that they're all hidden, so it's not lik..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [18:50:36] is there a flag/config/something i can switch so MediaWiki shows me nested exceptions (e.g. when something catches an exception and rethrows it as a new type, to output all exceptions ). Maybe it does, but i'm just getting the top level exception [18:51:35] New review: Yuvipanda; "Because brion forgot to hit submit :)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73979 [18:51:36] Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73979 [18:53:29] New patchset: Spage; "Better explanation and instructions" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/73994 [18:57:14] Anyone have any idea why this test is failing? I'm nto really sure where it's getting the actual/expected arrays of files from. http://pastebin.com/2X4iXqaG [19:01:23] New patchset: Cscott; "Code style cleanups to parserTest.inc and NewParserTest.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73986 [19:06:05] James_F|Away: It isn't a core specific program, but it is currently only ran for core. [19:06:12] It is however php/phpunit specific. [19:06:18] So not interesting for VE at this point. [19:06:50] code coverage is something that goes deeply into the nature of the test framework and the programming language, so it's not going to be re-uable in anyway for qunit and/or js. [19:07:01] There is however an open issue for integrating with JSCover [19:07:23] James_F|Away: you can cc yourself on https://bugzilla.wikimedia.org/show_bug.cgi?id=48365 if you're interested. [19:26:48] New patchset: SuchABot; "Bump Version number and Update CHANGELOG" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73996 [19:28:12] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73996 [19:31:27] New review: Parent5446; "(1 comment)" [mediawiki/extensions/AWS] (master) C: 1; - https://gerrit.wikimedia.org/r/73737 [19:41:49] ori-l: I just updated my mediawiki-vagrant to master, and then https://dpaste.de/UUq7T/raw/ :/ [19:42:51] New patchset: Alex Monk; "Don't trigger event when user rights change is cross-wiki" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73990 [19:42:59] legoktm: both superm401 and YuviPanda ran into the same issue, but now i forget what the solution was [19:43:06] pinging them to see if they remember [19:43:13] ok, thanks [19:45:01] legoktm: ori-l I... destroyed and rebuilt my vagrant :D [19:45:03] legoktm, not really. [19:45:05] superm401: didn't, IIRC [19:45:14] heh [19:45:21] YuviPanda, I have a few times, not sure if due to that issue. [19:45:23] that works, i dont really have anything important [19:45:28] I never was able to update Guest Additions due to a separate issue. [19:45:31] just $ vagrant destroy? [19:45:33] legoktm: oooh [19:45:35] legoktm, first try halt [19:45:38] legoktm: I remember! [19:45:38] vagrant halt [19:45:42] Wait for it to finish [19:45:43] legoktm: I had to run the update-guest-addons [19:45:43] vagrant up. [19:45:46] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73998 [19:45:48] legoktm: and then it won't do anything [19:45:57] legoktm: and I went to /tmp, found the guest addons folder, and ran the script manually as sudo [19:46:01] that is what fixed it for me [19:46:01] superm401: i've done that already :P [19:46:03] YuviPanda: ok [19:46:07] will try that [19:46:08] legoktm, ah, sorry. [19:46:09] ok [19:50:44] thanks superm401 & YuviPanda [19:50:58] legoktm: let us know how you fare [19:51:19] Installing the Window System drivers ...fail! [19:51:19] (Could not find the X.Org or XFree86 Window System.) [19:51:29] there's a note above telling you to disregard that :) [19:51:38] there's no elegant way to suppress that output [19:51:58] Hm, I never saw that note. [19:52:05] lemme halt and up now [19:53:17] New patchset: Alex Monk; "Don't trigger event when user rights change is cross-wiki or global" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73990 [19:54:22] ori-l: yippe it worked :D [19:54:35] thanks YuviPanda and superm401 [19:54:39] woo [19:55:12] legoktm, don't think I did anything, but you're welcome. :) [19:55:31] legoktm, so you just needed to install Guest Additions manually, not destroy? [19:55:38] yes [19:55:44] i ran update-guest-additions [19:55:47] then cd /tmp [19:55:50] became root [19:55:58] legoktm: <3 if you note this on https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Troubleshooting [19:56:20] ok :P [19:56:26] ori-l, is there an open bug for the Guest Additions script not working? [19:56:33] New patchset: Mwalker; "(Bug 51465) No Longer Filtering Mobile Devices" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/73999 [19:56:35] i don't think so [19:56:51] i didn't realize it still wasn't working for you [19:57:09] it didnt work for me, i had to call it manually [19:57:36] ori-l: never worked for me either [19:58:02] ..... [19:58:03] lies! [19:58:06] damn it [19:58:11] superm401: can you file a bug? [19:58:21] * YuviPanda flies a bug [19:58:22] ori-l, sure. [19:58:27] Or not. [19:58:31] Go ahead, YuviPanda [19:58:39] superm401: no go ahead, I was just flying one [19:58:48] and being useless :) also doing an app release. [19:59:05] Alright, will do [19:59:12] Heh, filing. [20:00:21] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73998 [20:00:42] ori-l: https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant%2FTroubleshooting&diff=737006&oldid=705588 [20:03:50] thank youuuu :) [20:03:59] np! [20:03:59] New review: Mattflaschen; "Thank you very much." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/73994 [20:16:43] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/73999 [20:32:00] New patchset: Mwalker; "Merge branch 'master' into wmf_deploy" [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/74049 [20:32:46] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/74049 [20:33:39] Krinkle: bawolff asked a good question in a patchset - how are we to know whether all the modules on the page have had a chance to register with mw.hook by the time we call the hook? [20:34:25] marktraceur: You don't need to because mw.hook has memory. [20:34:32] This is part of the design. [20:35:04] Krinkle: But this particular hook calls fire() and then expects the side effects to be there right away [20:35:07] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74050 [20:35:08] https://gerrit.wikimedia.org/r/#/c/67885/15/resources/mediawiki.page/mediawiki.page.gallery.js [20:35:11] Near the bottom [20:35:53] marktraceur: Well, then that code is wrong. [20:36:03] Heh. [20:36:06] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74050 [20:36:07] mw.hook usage needs to account for async [20:36:12] both immediate and later. [20:37:06] and also part of the principle is that there is no callback for that, because if it is temporary (e.g. something in a dialog, where the dialog can be closed) you shouldn't use mw.hook but instead emit events on your own object and require that other code depends on your module [20:37:30] Hm. [20:37:36] I'll make a note. [20:38:15] e.g. at any time you can add something to mw.hook and it will run with the latest data or it will be hold until there is dat. [20:38:20] Oh, no, I know what he can do [20:38:30] He can just make the resolved bit a callback [20:38:51] New patchset: Hashar; "BookManagerV2 triggered v1 jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74054 [20:39:45] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74054 [20:39:54] New patchset: Cscott; "Code style cleanup for ApiQuerySiteinfo.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73973 [20:41:06] New review: MarkTraceur; "Coupla issues in PHP and pretty heavy JS review." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67885 [20:43:56] New review: Hashar; "issue detected by Raymond l10nbot https://gerrit.wikimedia.org/r/#/c/74008/" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/74054 [20:44:23] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [20:44:54] New review: Hashar; "recheck" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74008 [20:45:55] New review: Krinkle; "Too many modes and modes should have more semantic names (not contain "hover" or "lines")." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67885 [20:46:19] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [20:53:19] csteipp: Final list of things to go for AbuseFilter in wmf9 and wmf10 is https://gist.github.com/Krinkle/6011120 - everything look OK? [20:53:43] New patchset: MarkTraceur; "Don't display empty preference sections" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73921 [20:56:32] James_F: Should be ok. The refactoring patch "9062371 - Avoid wgUser in AbuseFilterHooks edit handlers" should be fine [20:56:38] * James_F nods. [20:56:57] csteipp: And the ones for wmf9 but already in wmf10 are OK to bring forward? [20:56:58] Although it's an extra variable, so the safe thing would be exclude... but it's small enough we could revert if it causes problems [20:57:19] csteipp: They most look like things that only actually affect meta (global AF display stuff)? [20:57:55] James_F: Yeah, I think all those are pretty safe [20:58:14] csteipp: Kk. [20:58:21] csteipp: If it all goes wrong I'll get Roan to fix. [20:58:30] Sounds fine to me :) [21:02:56] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73990 [21:06:06] New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73977 [21:06:58] New patchset: MarkTraceur; "First iteration" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [21:07:30] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73798 [21:07:43] New review: MarkTraceur; "{{done}}" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [21:09:57] New patchset: MarkTraceur; "First iteration" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [21:10:09] New review: MarkTraceur; "Forgot the aliases file, sorry." [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [21:12:30] New review: Helder.wiki; "If the bottommost ones have autoHide, you may not be able to see them if you are reading the others..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [21:15:14] Yippie, build fixed! [21:15:14] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #81: FIXED in 7 min 0 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/81/ [21:15:46] New review: CSteipp; "Looks ok, and my test client still works fine with this" [mediawiki/extensions/OAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/73989 [21:18:25] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #70: FAILURE in 3 min 11 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/70/ [21:18:51] New review: Daniel Friesen; "Has everyone completely forgotten my demo video and the original specs of mw.notification?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [21:20:11] New patchset: Ori.livneh; "Enable I/O APIC" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74061 [21:20:44] New review: Ori.livneh; "Totally untested." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74061 [21:21:53] New patchset: CSteipp; "Add MWOAuthServer::getServer()" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74062 [21:22:00] New review: AlephNull; "I'm not sure what I need to do to get this patch +2'd. I'd very much like this to go out with the ne..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [21:36:10] legoktm, how did you get past "Vagrant assumes that this means the command failed ... mount -t vboxsf -o uid=`id -u vagrant`,gid=`id -g www-data` /vagrant /vagrant" [21:36:20] I know at one point you successfully updated guest additions. [21:36:32] At that point, the VM is technically running, so vagrant ssh should work [21:36:59] legoktm, wow, never occurred to me that it would be running in a clean enough state to ssh into. [21:37:08] Yeah :P [21:37:53] legoktm, thanks. :) [21:37:58] np [21:52:18] New review: Mattflaschen; "I haven't tested, but the code looks clear to me." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [21:54:24] New review: MarkTraceur; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844 [22:00:03] New patchset: CSteipp; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [22:01:31] New patchset: Mattflaschen; "Tweak warning about X." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74073 [22:04:46] New review: Krinkle; "This is a bug fix in the Parser, definitely up for release notes please." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66092 [22:11:21] New review: Parent5446; "Haven't tested, but looks good now." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/73921 [22:12:11] New patchset: Mattflaschen; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [22:13:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73760 [22:14:17] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74062 [22:15:21] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73977 [22:16:08] New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74074 [22:18:42] New patchset: Cmcmahon; "Basic test for Hotcat gadget test2wiki only for now" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74075 [22:18:44] csteipp: I guess you have to press submit for https://gerrit.wikimedia.org/r/#/c/73989/ manually [22:19:25] <^demon> You can't press submit, it's not a clean merge. [22:19:33] <^demon> Hence, "Can Merge: No" [22:19:44] New patchset: Mollywhite; "Code cleanup" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74076 [22:20:41] * AaronSchulz wishes the UI was better [22:21:01] Gerrit is a perfect UI. [22:22:02] <^demon> Elsie: Heh, you haven't seen the work they've done revamping change pages :p [22:22:15] New patchset: Aaron Schulz; "Use self-releasing (for reuse) DB connections" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73989 [22:22:19] ^demon: Link? :-) [22:23:19] New review: Aaron Schulz; "Rebased" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73989 [22:23:42] <^demon> Elsie: Compare https://gerrit-review.googlesource.com/#/c2/47870/ (new) and https://gerrit-review.googlesource.com/#/c/47870/ (old) [22:23:59] <^demon> Definitely needs polish. I can't decide if I like the approach though. [22:24:03] New patchset: Himeshi; "Added parsing of the {{{section}}} tag." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [22:24:23] Oh my. [22:24:32] New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74077 [22:24:42] Does that mean they're removing unified diffs? [22:25:01] <^demon> Doubt it. This is still a work in progress with about a dozen known flaws. [22:25:16] only a dozen? Sounds production quality for Gerrit! :D [22:25:17] Does Google use Gerrit internally? [22:25:30] I'm shocked that they can't devote some fucking design resources to it. [22:25:46] heh [22:25:47] Elsie: they use it for android [22:25:50] Elsie: not for other things [22:26:09] Ehh, all right. [22:26:15] (Do we know what they use internally?) [22:26:16] well, and for gerrit, of course :D [22:26:21] New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74062 [22:26:22] #inception [22:26:34] <^demon> Elsie: Magic secret sauce we're not allowed to see :) [22:26:59] I should really spend some more time on the github bot at least this weekend. So much easier... [22:27:24] <^demon> As long as nobody makes me start using github :) [22:27:32] Not a fan? [22:27:33] that's the idea, yeah :) [22:27:45] Elsie: [[Stockholm Syndrome]] [22:27:50] I generally like GitHub. It has basic features like search. [22:27:52] YuviPanda: :D [22:27:58] And it has a usable user interface. [22:28:11] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73989 [22:28:27] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74062 [22:28:30] YuviPanda: I actually find gerrit to be nicer than github [22:28:30] And it doesn't ever say "Working...". [22:28:30] I like their review interface a lot. Especially the 'this comment is outdated' display. Gerrit is 'hunt and peck each patchset!' [22:28:50] Gerrit's collapse logic is simply drunk. [22:29:00] Ryan_Lane: you can't see the comments you are replying to (not inline) when replying to them [22:29:01] It's awful to try to read old comments. [22:29:03] if you are used to gerrit, then move to github you realize that their model actually sucks [22:29:04] <^demon> YuviPanda: That actually came up yesterday. "I think Chad's developed some stockholm syndrome towards gerrit. This probably isn't healthy." [22:29:06] New patchset: Mollywhite; "Code cleanup" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74076 [22:29:25] Gerrit isn't as awful if you've used it for a while. [22:29:36] Ryan_Lane: the model differences exist, and yes, I too think that for a project like ours Gerrit's is better in general. Doesn't make the UI any less awful. [22:29:37] But some of its... quirks are so readily apparent that it's physically painful. [22:29:44] ^ [22:29:45] you need to do all the same kind of bullshit in github you do in gerrit [22:30:12] you can see the comment you are replying to while replying to it. and it is in general much faster (at least on my connections) [22:30:15] As I've written previously, Gerrit seems to actively discourage discussion and collaboration, though. [22:30:22] also I thought the monthly github vs gerrit flamewar was over [22:30:28] Which is a _huge_ negative. [22:30:46] YuviPanda: The flame burns bright. [22:31:01] Though I thought it was more Phabricator v. Gerrit. Or [anything] v. Gerrit. [22:31:02] Elsie: you can help by contributing to the bot, y'know :) It lives on toollabs... [22:31:10] Gerrit is enterprise-grade... very difficult to kill. [22:31:36] What's it written in? [22:31:46] Elsie: python [22:31:55] Fair enough! [22:31:56] Elsie: http://github.com/yuvipanda/SuchaBot [22:32:21] needs README, etc [22:32:23] I guess [22:32:38] https://github.com/yuvipanda/SuchABot/commit/6cb675a494c8313b9287b163889577ad3cf1597b [22:32:41] Hehhhhhh. [22:33:04] currently needs to be ported to a different GitHub API wrapper since the current one is too clever for its own good [22:33:09] (and also doesn't support OAuth) [22:33:27] Elsie: heh :) Easy to make that run forever. feels dirty though [22:33:33] Super dirty. [22:33:36] yeah [22:33:45] Elsie: well, but they are never supposed to end [22:34:06] except if you don't you end up with pull requests with hundreds of changes [22:34:28] Ryan_Lane: don't what? [22:35:19] Ryan_Lane: you mean like https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/3? :D [22:35:36] Ryan_Lane: that got merged too, as https://gerrit.wikimedia.org/r/#/c/70446/ [22:39:46] Elsie: either way, let me know if you want to help. I really think it'll make it easier for a lot more people to contribute if they can use GitHub than Gerrit. mediawiki.org/wiki/User:Yuvipanda/G2G is how it is supposed to work... [22:42:32] Wooo [22:42:40] wutf? [22:42:55] freenode... [22:43:05] * YuviPanda pats freenode [22:44:02] em [22:44:13] they kicked everyone with that domain or what? [22:44:20] *domains [22:45:03] Aaand we're back. [22:47:50] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73615 [22:51:27] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74062 [22:54:17] New patchset: Cmcmahon; "Basic test for Hotcat gadget test2wiki only for now" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74075 [22:55:04] New patchset: Cmcmahon; "Basic test for Hotcat gadget test2wiki only for now" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74075 [22:58:15] New patchset: Cmcmahon; "Basic test for Hotcat gadget test2wiki only for now" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74075 [23:00:33] Change merged: Aaron Schulz; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [23:02:49] New patchset: Krinkle; "Update AbuseFilter submodule to latest master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74086 [23:02:50] New patchset: Aaron Schulz; "Made MWOAuthManageMyGrantsPager page on ID instead of access token" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/74087 [23:02:58] csteipp: ^ [23:03:05] that also unbreaks a bunch of special pages ;) [23:03:46] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74077 [23:05:03] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #82: FAILURE in 4 min 12 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/82/ [23:05:41] New patchset: Krinkle; "Update AbuseFilter submodule to latest master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74088 [23:07:59] New review: Ori.livneh; "Thanks" [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/74073 [23:08:25] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74073 [23:09:19] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74074 [23:10:42] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74088 [23:12:05] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74086 [23:12:16] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [23:16:55] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [23:27:57] New patchset: Mollywhite; "Whitespace cleanup, changing lists to use ordered list." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742 [23:29:14] New review: Mattflaschen; "I didn't destroy and re-create, but I enabled IO APIC manually, and it worked (after I resolved the ..." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/74061 [23:30:46] New review: Ori.livneh; "> Willing to +2." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/74061 [23:38:12] New review: MarkTraceur; "I guess we could just add more preferences to the betafeatures special page...maybe in subpages? I'l..." [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73920 [23:40:19] New review: Mwjames; "This is no code review." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [23:47:51] New patchset: Mollywhite; "Add .jshintrc file for this extension." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74090 [23:49:31] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/74090 [23:50:26] New review: Bsitu; "Thanks for catching this glitch! It looks like Gmail strips out the text-indent property, I can pro..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [23:51:50] New patchset: Plavi; "Removed page-object gem deprecation warnings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/74091 [23:54:12] New patchset: Krinkle; "Update VisualEditor submodule to latest master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/74092 [23:54:19] New review: Aaron Schulz; "Summary typo" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67229 [23:55:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72473 [23:56:21] New patchset: Mollywhite; "Whitespace cleanup, changing lists to use ordered list." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742 [23:56:56] New patchset: Krinkle; "Update VisualEditor submodule to latest master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/74093