[00:17:38] Hello, is anyone here familiar with the Scribunto extension? [00:19:30] anomie is [00:22:54] really it's just this: http://www.mediawiki.org/wiki/Extension_talk:Scribunto#Script_error:_Lua_error:_Internal_error:_The_interpreter_has_terminated_with_signal_.2211.22._30014 [00:23:28] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [00:24:38] Mastergalen: "signal 11" would tend to indicate that the standalone Lua interpreter crashed. Are you able to execute the interpreter manually? (whichever one is being used on your platform) [00:27:50] how would I execute the interpreter manually? [00:28:04] running CentOS 6 (64 bit) [00:28:18] Just run "lua" on the console :D [00:29:36] lol did that already, thought I would need to run one of the binaries provided [00:29:41] Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio [00:30:03] Mastergalen, hoo: "lua" will run the version installed in probably /usr/bin. Scribunto is probably using /path/to/mediawiki/extensions/Scribunto/engines/LuaStandalone/binaries/lua5_1_5_linux_64_generic/lua [00:30:19] oh, we're shipping own binaries :P [00:30:55] Mastergalen: Of course, you could set $wgScribuntoEngineConf['luastandalone']['luaPath'] = '/usr/bin/lua' to use the OS-provided one, as long as it's 5.1. [00:31:10] (that would be in your LocalSettings.php) [00:32:21] New patchset: Shirayuki; "Fix parameters for messages" [mediawiki/extensions/InlineCategorizer] (master) - https://gerrit.wikimedia.org/r/73719 [00:33:18] oh look at that [00:33:37] works changing the luaPath :D [00:34:01] awesome, thanks for your help [00:36:13] Mastergalen: You're welcome. [00:42:12] no point shipping our own binaries if they just segfault [00:45:01] Just tested it on my CentOs 6.4 server, the 64 bit binary runs [00:45:37] (on Scribuntu master) [00:49:16] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [01:00:23] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [01:17:17] New patchset: Tim Starling; "Reduce Lilypond memory usage" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/73720 [01:23:52] New review: Tim Starling; "This was sitting around in my working copy, uncommitted, since November 2012. I'm not sure now why I..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/73720 [01:27:37] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/65557 [01:44:52] New review: Tim Starling; "Longer cache lifetime was an explicit and deliberate part of the migration from {{CURRENTHOUR}} etc...." [mediawiki/extensions/ParserFunctions] (master) C: -1; - https://gerrit.wikimedia.org/r/73188 [01:46:56] New patchset: Jforrester; "Add more specific class to cite errors" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/73096 [01:58:20] A friend of mine went to Colombia and brought me back coffee he bought in the market. I just made a batch, and it's absolutely disgusting... now I'm trying to figure out if it's just bad coffee, or if I so totally got used to crap coffee, that I can't recognize good one anymore. [01:59:00] Oops, that was actually supposed to be posted on another window. [01:59:11] * James_F grins at mooeypoo. [01:59:21] But.. uh.. enjoy! [02:03:41] New review: Ryan Lane; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [02:14:43] New patchset: Alex Monk; "(bug 16214) Create GlobalBlocking API module." [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/47539 [02:18:11] New patchset: Alex Monk; "(bug 16214) Create GlobalBlocking API module." [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/47539 [02:28:24] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:29:07] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [02:38:03] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [03:12:36] New patchset: Shirayuki; "Give grep a chance to find the usages" [mediawiki/extensions/MassEditRegex] (master) - https://gerrit.wikimedia.org/r/73726 [03:21:45] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [03:36:24] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [03:54:31] New patchset: KartikMistry; "Update UnifrakturMaguntia font to latest version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73731 [04:12:16] New review: Santhosh; "Does not work for Bold, Italic variants. The resources/js/ext.uls.webfonts.repository.js not updated..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73152 [04:16:55] New patchset: Bsitu; "(bug 51303) Do not send duplicate thanks notification" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73732 [04:18:30] New patchset: Bsitu; "(bug 51303) Do not send duplicate thanks notification" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73732 [04:19:07] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [04:26:52] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73506 [04:30:23] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [05:02:29] New patchset: KartikMistry; "Add free and open licensed font for Urdu script" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [05:13:54] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73156 [05:17:00] New patchset: KartikMistry; "Update UnifrakturMaguntia font to latest version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73731 [05:20:57] New patchset: KartikMistry; "Add free and open licensed font for Urdu script" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [05:22:38] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [05:32:40] New patchset: Ori.livneh; "Bump $wgMaxShellMemory to 512MB; drop ctag generation" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73733 [05:33:48] New review: Ori.livneh; "Note to self: spin ctag support into an optional role if people miss it." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/73733 [05:33:51] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73733 [05:36:30] Project browsertests-test2.wikipedia.org-linux-firefox build #412: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/412/ [06:02:57] hello [06:04:15] New patchset: KartikMistry; "Update UnifrakturMaguntia font to latest version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73731 [06:06:12] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73731 [06:50:40] New patchset: Raimond Spekking; "Remove title case" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73712 [06:52:20] New review: Raimond Spekking; "Would give +2 for Siebrand changes but +1 only because I tweaked the patch set a bit" [mediawiki/extensions/OAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/73712 [07:44:02] New review: Siebrand; "Given the comment on PS1 not being yours, I'd just go ahead, and +2, Raimond :)." [mediawiki/extensions/OAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/73712 [07:48:21] New review: Raimond Spekking; "♦" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73712 [07:48:21] Change merged: Raimond Spekking; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73712 [07:48:45] New patchset: J; "Optional SVG mode with PNG fallback" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [08:40:28] New patchset: Nikerabbit; "Add explicit GENDER for log entries" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73713 [08:44:25] YuviPanda: hey [08:45:55] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/OAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/73713 [08:50:34] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73615 [09:02:51] New review: Esanders; "Timo, you seem to have a much better idea of the requirements. Can you add a patchset to bring it up..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [09:43:50] New patchset: Hashar; "update VisualEditor to latest master" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/73736 [09:44:35] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/73736 [09:59:16] New patchset: Thaiphan; "Fix issue with images not being uploaded" [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/73737 [10:03:16] New patchset: Netbrain; "Added a toggle fullscreen button to Maps." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/73738 [10:05:04] New patchset: Pastakhov; "Refactoring, compiler is used instead of the interpreter (version 0.6.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [10:09:25] New review: Netbrain; "Answered your comments." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66379 [10:15:13] New review: Pastakhov; "Add variables support ( testRun_echo_variables_11 )" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/72073 [10:19:41] New patchset: Krinkle; "Allow postEdit hook to be triggered asynchronously" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [10:26:11] New patchset: Krinkle; "Allow postEdit hook to be triggered asynchronously" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [10:28:41] New review: Krinkle; "* Documented in commit message what was already done (moving of click handler, changing from DOM to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [10:29:43] New review: Krinkle; "* Fixed interpretation of message as text instead of html when using the default from undefined->mw...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [10:47:21] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/73738 [10:52:36] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/73613 [10:53:37] New review: Siebrand; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73713 [10:58:27] New patchset: Nikerabbit; "Help links for ime selector menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [10:59:18] New review: Nikerabbit; "Depends on https://github.com/wikimedia/jquery.ime/pull/214" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [11:01:05] New review: Siebrand; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [11:02:05] New patchset: Nikerabbit; "Help links for input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73403 [11:05:36] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73403 [11:07:07] New patchset: Nikerabbit; "Help links for input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73403 [11:08:25] New patchset: Nikerabbit; "Help links for input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73403 [11:08:42] New patchset: Nikerabbit; "Help links for ime selector menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [11:10:34] New patchset: Nikerabbit; "Help links for ime selector menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [11:14:12] New review: Esanders; "Won't +2 as I wrote the test fixes, but looks fine to me." [mediawiki/extensions/Cite] (master) C: 1; - https://gerrit.wikimedia.org/r/73096 [11:28:06] New review: Nikerabbit; "Ouch that should be fixed soon. I will lift my -1, but I'd like to have both issues fixed soon, pref..." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73713 [11:56:51] New patchset: SuchABot; "Added new launcher icons" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73748 [12:06:00] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73734 [12:34:11] kaulen (bugzilla) being rebooted in 5 mins. [12:45:27] bugzilla back up [13:00:02] New patchset: Amire80; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73749 [13:01:23] New review: Zfilipin; "Chris has recently wrote and implemented a lot of ULS scenarios, based on this scenarios. Could you ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [13:01:37] New review: Zfilipin; "Chris has recently wrote and implemented a lot of ULS scenarios, based on this scenarios. Could you ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [13:05:05] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73750 [13:12:54] New patchset: Nikerabbit; "Help links for ime selector menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [13:23:00] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73749 [13:23:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73403 [13:24:13] New patchset: Amire80; "Help links for ime selector menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73734 [13:25:59] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73744 [13:27:25] New review: Hashar; "deployed" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73744 [13:28:13] New patchset: Amire80; "Remove jquery.i18n code that the ULS extension overrides" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73395 [13:33:50] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73395 [13:56:05] manybubbles: hey there [13:56:13] manybubbles: sorry for the solr reboot in labs earlier :( [13:56:25] hashar: no, you did the right thing. It can take it. [13:56:36] so there is some script that loads the XML dump inside solr [13:56:41] and solr itself use a mysql backend ? [13:56:45] hashar: I worked out a way for it to resume getting smashed when the time comes. [13:57:15] or are you loading the content from the tools mysql replication of the prod database ? [13:57:15] hashar: nah- the script that loads data into solr/elasticsearch needs it already in mysql [13:57:41] hashar: I've been told I can't use the replication because it doesn't have text. [13:57:52] ahh [13:57:59] so you get a sql dump of the enwiki text table ? [13:58:17] hashar: something better/worse [13:58:44] hashar: the dumps in /public/datasets actually contain enough for me. [13:58:54] hashar: just the most current text is all I need [13:59:22] and mwdumper turns those into sql.... here, let me post what I'm doing on a wiki... [14:00:20] ahh I can see enwiki-20130604-page.sql.gz 950MB [14:00:34] so I am wondering whether ionice would help lower the stress on the nfs server [14:02:01] though the /public/datasets is on labstore1 while the /home of tools and beta are on labstore3 mmh [14:06:01] hashar: page.sql.gz isn't really what I need either... [14:06:12] :-D [14:07:13] you said mysqld cause the load, would it make sense to batch the insert and sleep() between them to lower the i/O ? [14:07:24] hashar: the big problem is getting a useful copy of the text table which mwdumper provides. the other sql files'll be useful though [14:08:13] hashar: I could certainly do some of that but then it'd take weeks instead of days. I wonder if I can cut the stress down more while still getting _somewhere_ though [14:09:48] hashar: there - I've cut down the number of concurrent inserts from 4 to 1 and added a sleep. this will hopefully not stress anything at all [14:10:09] another possibility would be to use ionic on mysqld [14:11:08] something like : ionice -p `pidof mysqld` --class idle --classdata 7 [14:11:12] that might help [14:12:11] though that might not really work since the mysqld is on its own instance and probably knows nothing about the other I/O being done on the nfs server :( [14:12:57] hashar: that is what I'm getting by reading ionice's man page [14:13:21] lets follow up on -labs :-) [14:13:34] New patchset: Rachel99; "WIP : Enter internal link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73753 [14:29:56] New review: Hashar; "Sounds good :-)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/73611 [14:36:00] New review: Hashar; "I have update the job mwext-ParserHooks-testextensions-master" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/73593 [14:36:02] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73593 [14:36:23] New patchset: Rachel99; "WIP : Enter internal link" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73753 [14:37:33] New patchset: Hashar; "Make mwext-Wikibase-testextensions-master voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73534 [14:46:16] New review: Hashar; "Double checked with Denny over IRC. Deploying." [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/73534 [14:46:16] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73534 [14:47:00] New patchset: Anomie; "(bug 24068) Add protection level to ApiQueryFlagged" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/47216 [14:59:29] New patchset: Umherirrender; "Do not parse param of newsectionsummary on new section preview" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73519 [14:59:48] hi mooeypoo [15:02:16] hey sumanah ! [15:02:27] how are you :) [15:04:20] I'm okay! how are you doing? [15:04:38] New patchset: Hashar; "set ansicolor colormap to vga" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71805 [15:04:50] New review: Hashar; "Upstream change merged." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71805 [15:05:44] Pretty good :) started a required summer course, which is a little meh, but I guess worth it, seeing the result was being able to do GSoC :) [15:05:52] New review: Umherirrender; "But having a real language can have side effects." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73448 [15:07:44] mooeypoo: :) I'm glad [15:07:50] (that you can do GSoC) [15:07:57] mooeypoo: when does the summer course end? [15:10:34] Aועודא 15אי [15:10:40] That is to say August 15th [15:10:56] :) [15:11:38] switching he/en faux pas [15:11:50] no prob, I find it amusing :) [15:12:07] hehe yeah, it happens a lot lately [15:14:58] It's good this was a short answer, and that I noticed. [15:15:06] New review: Anomie; "(1 comment)" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/73615 [15:15:13] Sometimes I only notice after typing 2-3 sentences. *that's* annoying. [15:22:10] I bet [15:22:18] hi rachel99, hope you had a good weekend [15:22:45] sumanah: I did, thank you. How about yourself? [15:23:19] chrismcmahon, hi! Did you see the emails from Earl? [15:23:51] hi qgil, not yet (I took half of Friday off, I'm still catching up) [15:25:13] qgil: reading now [15:25:56] rachel99: I did! I got to see some old friends. [15:26:16] ok chrismcmahon please reply to him. He's Ruby & Cucumber savvy, came to the previous workshop in SF (he was sitting next to S Page approx) [15:26:33] chrismcmahon, and he is offering to help [15:26:37] qgil: yes, I spoke with him. [15:28:26] Sounds fun. I didn't do too much this weekend, aside from the usual household chores, gardening, etc. [15:29:16] sumanah: However, a few weeks ago I got to meet some other OPW interns in Boston, mulhern and Teri Yu. It was great to meet them. [15:30:07] Oh that's great, rachel99! are you going to do that again, and regularly? [15:31:04] rachel99: ! hi! I sent you an email a while back, but I have a feeling something went poopoo with it (proably my fault, I've been having issues with my net at the time) [15:31:21] I'm not sure about regularly.. as Teri lives a few hours away in Northhampton. She was here for a conference. I'm hoping we could do it again at the end of the summer, though. [15:32:01] mooeypoo: No, I don't thing I got it.. when did you send it? [15:32:58] rachel99: bah, a while ago, I was apologizing for not properly answering the previous tasks we talked about pre-GSoC. [15:34:38] New patchset: Jeroen De Dauw; "Move inclusion of the Composer autoloader to after inclusion of DefaultSettings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73760 [15:34:40] mooeypoo: oh, I don't think I got that message. [15:36:05] mooeypoo: Is there anything you want me to work on/test regarding those tasks? I'm sure you're real busy with your SoC project now. [15:36:36] New review: Hashar; "I should maybe ask Jenkins plugin to add an option that would let us select the global default color..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71805 [15:38:07] and I am off again, see you in 2 hours and a bunch [15:43:08] New patchset: Anomie; "API: Fix prop=imageinfo iicontinue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73762 [15:57:43] New patchset: Raimond Spekking; "Consistency tweaks in preparation for adding extension to translatewiki.net" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/73766 [16:04:57] New review: Anomie; "Oh, no Jenkins here?" [mediawiki/extensions/FlaggedRevs] (master); V: 2 - https://gerrit.wikimedia.org/r/47216 [16:05:01] Change merged: Anomie; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/47216 [16:08:33] New review: Parent5446; "This makes the bucket names the same as the zone names, which we can't do since AWS buckets are univ..." [mediawiki/extensions/AWS] (master) C: -1; - https://gerrit.wikimedia.org/r/73737 [16:09:14] New review: Luis Felipe Schenone; "Thanks!" [mediawiki/extensions/Hovergallery] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73766 [16:12:01] New patchset: Siebrand; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [16:13:28] New review: Siebrand; "PS9:" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [16:49:13] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [16:57:19] New patchset: J; "Delete transcodes on FileDeleteComplete hook" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/73776 [17:05:09] New patchset: RobH; "RT 5254 enabling pagination of comments in style.css" [wikimedia/communications/WP-Victor] (master) - https://gerrit.wikimedia.org/r/73779 [17:06:38] New patchset: RobH; "RT 5254 enabling pagination of comments in style.css" [wikimedia/communications/WP-Victor] (master) - https://gerrit.wikimedia.org/r/73779 [17:07:30] New review: RobH; "whats the worst this could do eh?" [wikimedia/communications/WP-Victor] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73779 [17:07:30] Change merged: RobH; [wikimedia/communications/WP-Victor] (master) - https://gerrit.wikimedia.org/r/73779 [17:09:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73762 [17:10:48] New patchset: CSteipp; "Allow local wiki to act as central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [17:11:12] greg-g: is that 'create a bug if you need a maintenance script run' thing documented somewhere? :) [17:11:41] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [17:12:43] YuviPanda: Not sure if it's explicit there, but it's in the same vein as "how to request a configuration change" on meta [17:13:05] New patchset: RobH; "Revert "RT 5254 enabling pagination of comments in style.css"" [wikimedia/communications/WP-Victor] (master) - https://gerrit.wikimedia.org/r/73780 [17:13:11] RoanKattouw: ah, okay. let me read that [17:13:21] New review: RobH; "reverting old change" [wikimedia/communications/WP-Victor] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73780 [17:13:21] Change merged: RobH; [wikimedia/communications/WP-Victor] (master) - https://gerrit.wikimedia.org/r/73780 [17:13:25] :) [17:15:59] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/73776 [17:38:54] New patchset: Mollywhite; "Bug 51256: Load primary CSS separately from JavaScript." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73784 [17:46:23] New review: Anomie; "Looks good, and works correctly when I adjusted the oauth test wikis to the necessary configuration ..." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/73549 [17:53:05] New patchset: Anomie; "Better handle when $wgCentralAuthLoginWiki is not set on all wikis" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [17:53:28] New patchset: Anomie; "Better handle when $wgCentralAuthLoginWiki is not set on all wikis" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [17:54:03] New review: Anomie; "Gerrit has a summary editor but it doesn't wrap lines? Lame." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/73549 [17:54:08] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [17:59:36] New patchset: Ryan Lane; "Add API for Service Group info and refactor project api" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/73790 [18:00:41] New patchset: Nischayn22; "Autocenter on Polygons and other shapes." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/36700 [18:01:27] New review: Nischayn22; "Corrected getBounds() for Rectangles in PS6" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/36700 [18:10:12] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: 1; - https://gerrit.wikimedia.org/r/73615 [18:10:33] New patchset: CSteipp; "Better handling when $wgCentralAuthLoginWiki is not set on all wikis" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [18:13:47] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/73530 [18:14:45] Krinkle: https://gerrit.wikimedia.org/r/#/c/65557/ <— mind a follow-up review? [18:15:16] I believe I've fixed all your issues, excluding proxy/bind (which I'll do a follow-up change for) [18:15:48] k [18:15:52] thanks :) [18:20:40] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/36700 [18:21:44] Yippie, build fixed! [18:21:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #167: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/167/ [18:31:53] Yippie, build fixed! [18:31:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #112: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/112/ [18:36:18] Yippie, build fixed! [18:36:19] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #112: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/112/ [18:37:02] New review: Tychay; "LGTM. Would be nicer in the future to have a commit message that mentions the default charset in the..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/71747 [18:37:04] Change merged: Tychay; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71747 [18:39:42] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [18:41:52] Yippie, build fixed! [18:41:52] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #150: FIXED in 9 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/150/ [18:43:03] New patchset: Aaron Schulz; "Various code cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73794 [18:43:36] csteipp: I'm going to fix the specials/ dir [18:43:53] AaronSchulz: Ah, thanks! [18:46:30] New review: Siebrand; "(1 comment)" [mediawiki/extensions/OAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/73794 [18:46:32] csteipp: also, should it be Special:MWOAuth ? [18:46:53] New patchset: Adamw; "Ensure that times go into the db in UTC, regardless of global or user timezone settings." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73118 [18:47:39] AaronSchulz: I can go either way. It's a little redundant, but it might make things easier for other developers to start looking at the code [18:47:47] New review: Siebrand; "Merging this now. Patch set https://gerrit.wikimedia.org/r/#/c/73794/ contains fixes for the incorre..." [mediawiki/extensions/OAuth] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73713 [18:48:00] csteipp: it would match the others [18:48:09] In that case it's fine [18:48:17] though they don't have MW in the actual name though [18:48:21] just in the code [18:48:37] I'll just rename the class [18:51:22] csteipp: oh, actually they do have MW in the visible name [19:00:49] @notify sumanah [19:00:49] I'll let you know when I see sumanah around here [19:04:56] New review: Krinkle; "JS looks good. Don't know openstack backend to say anything useful about that, I assume you know it ..." [mediawiki/extensions/OpenStackManager] (master) C: 1; - https://gerrit.wikimedia.org/r/65557 [19:07:11] New review: TheDJ; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) C: -1; - https://gerrit.wikimedia.org/r/69896 [19:13:09] greg-g: is lightning deploy window open today? I need to get a small change in SUL deployed soonish... [19:25:36] New patchset: Aaron Schulz; "Cleaned up special pages and directories" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73798 [19:40:03] csteipp: yep [19:41:42] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [19:45:07] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [19:48:51] Is VE getting deployed today or something? [19:49:41] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [19:54:30] hey sumanah [19:54:38] hi YuviPanda [19:54:48] sumanah: thought you might like https://github.com/wikimedia/puppet-cdh4/pull/17#issuecomment-20992169, which is a comment a random volunteer left after he was able to get stuff merged in our gerrit repo via github :) [19:55:00] awwww [19:55:12] I need to spend time on it though, haven't worked on it this month :( [19:55:22] cute pic [19:55:36] Eeeeeeee [19:55:38] indeed :) [19:55:57] been smiling every time I look at that :) [20:07:21] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [20:11:15] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [20:14:21] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73857 [20:15:23] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73857 [20:15:31] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73858 [20:15:39] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73858 [20:16:42] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [20:17:44] New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017 [20:17:58] New patchset: Aaron Schulz; "Various code cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73794 [20:19:42] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [20:40:08] New patchset: Krinkle; "Add mwext-check-jobs for mwext-BookManagerv2" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73861 [20:41:27] New review: Helder.wiki; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291 [20:42:43] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [20:43:06] New patchset: Krinkle; "Enable jobs for mwext-BookManagerv2" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73862 [20:43:53] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73861 [20:45:03] New patchset: Kaldari; "Warn if you try to link to a disambiguation page" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [20:45:13] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73862 [20:47:26] New patchset: Kaldari; "Warn if you try to link to a disambiguation page" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [20:48:22] Change merged: jenkins-bot; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [20:48:43] GorillaWarfare: Deploying now (https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=77491&oldid=77490), should be all set now. [20:49:13] Krinkle: Thanks so much! [20:58:28] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [20:58:41] New review: Se4598; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291 [20:59:55] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [21:04:48] New patchset: Ori.livneh; "Export 'drive' in factory.py" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73864 [21:05:29] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73864 [21:05:48] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [21:13:29] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [21:13:59] New patchset: Ori.livneh; "Interpret spaces in input pattern string liberally" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73866 [21:14:00] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73866 [21:15:48] New patchset: Mwalker; "Remove ContributionTracking Tests and Update DB" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [21:17:09] New patchset: Mwalker; "Remove ContributionTracking Tests and Update DB" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [21:20:22] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [21:21:29] New review: MarkTraceur; "WITH RESERVATIONS" [mediawiki/extensions/ContributionTracking] (master) C: 2; - https://gerrit.wikimedia.org/r/73527 [21:21:39] Change merged: jenkins-bot; [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [21:44:20] New patchset: Ori.livneh; "Fix typo in parameter name; have reader decode JSON" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73870 [21:44:23] New review: Kaldari; "I believe this change caused bug 51399." [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/64883 [21:44:41] Change merged: Ori.livneh; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73870 [21:50:59] doh [21:56:50] New patchset: Kaldari; "Reverting change I6d2fa445 to fix regression." [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73871 [21:57:20] Change merged: jenkins-bot; [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73871 [21:57:54] New review: Kaldari; "Reverted in change Ib06ac943" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/64883 [22:00:28] Is Kaldari here? [22:00:34] If so, under which nick? :P [22:01:12] He's in -tech. [22:01:19] And -operations. [22:01:23] hoo: "kaldari", creatively. ;-) [22:01:46] Oh, just -tech and -mobile. I imagine he'll be in -operations shortly, though. [22:10:40] New patchset: Aaron Schulz; "database: added DBConnRef wrapper to manage calling reuseConnection()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72244 [22:11:24] TimStarling: does https://gerrit.wikimedia.org/r/#/c/72244/ seem OK? [22:13:33] bawolff: been trying to con more people into rviewing your patch, ori-l and superm401 were interested. hopefully this can get merged at some point :) [22:13:37] ( brion too) [22:13:43] thanks :) [22:14:04] the random in category, I mean [22:14:13] Hmmm. [22:14:16] Didn't Brad review it? [22:14:44] it's un +2'd as of now [22:15:02] YuviPanda: Which changeset is it? [22:15:15] moment [22:15:17] https://gerrit.wikimedia.org/r/#/c/71997/ [22:15:23] https://gerrit.wikimedia.org/r/#/c/71997/ [22:15:23] New patchset: Mwalker; "Force STOMP Reconnections on Selector Change" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/73880 [22:15:42] Brad did take a look, his comment was somewhat neutral. In essence he said that the method wasn't really that random [22:15:48] YuviPanda: You saw Anomie's comment on patchset 4? [22:15:52] Right. [22:16:15] and he wouldn't be wrong [22:16:52] but /me thinks its still useful notwithstanding [22:17:13] me too, considering what we have is... nothing [22:17:31] Bad docs are worse than no docs. [22:17:35] we can more accurately call it 'give me a page in this category that is probably not the last page I saw from the category via the same method' [22:17:44] these aren't docs :) [22:17:44] A not-random feature called random is probably worse than no random feature. [22:17:50] No kidding. [22:18:12] Indeed, calling it something that is not 'RandomInCategory' would be nice. [22:18:16] I'm not sure what to call it though [22:18:31] SomewhatRandom [22:19:31] legit [22:19:40] Special:Random isn't precisely random either (but its a lot better than what my patch does) [22:20:07] I'm still not sure what's wrong with a schema change. [22:20:44] People have been talking about doing that for literally multiple years [22:21:22] We could always do the schema change approach later on, after the users rise up and complain that Special:RandomInCategory isn't remotely random [22:21:49] yeah, and we don't have to change the name then :) [22:22:08] Hmmmm. Perfect is the enemy of the good, indeed. But I'm still not sure this approach moves us in the right direction. [22:22:12] I dunno. [22:22:46] New patchset: Hoo man; "Don't construct titles like User:User:Hoo in JS" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73883 [22:23:15] we currently have no way, and with this we'll have. looks like the correct direction to me... [22:23:58] New review: Mattflaschen; "Reply. I think the code is doing what's intended, but I am open to suggestions on clearer terminolo..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [22:25:21] New patchset: Kaldari; "Update WikiLove to master" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73884 [22:25:54] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73884 [22:26:24] greg-g: I can haz LD? [22:27:54] New patchset: Mwalker; "Redoing Logging to Make it Less Stupid" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [22:28:07] New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/73750 [22:28:11] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73750 [22:28:33] csteipp / anomie, thanks for admin on project Oauth. I don't see w2-oauth.wiktionary.wmflabs.org in the list of machines, do you know which instance it's on? [22:29:18] spagewmf: Everything is running off the oauth-apache1 instance. We never set up a cache later or a separate IP to make use of the oauth-apache2 instance [22:31:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [22:35:34] ^demon: Game to make me some repositories? [22:36:08] * marktraceur adds to request page [22:36:56] <^demon> marktraceur: Will in a bit, still playing catch-up [22:37:34] KK [22:38:14] Both added, thanks much [22:38:39] * bawolff should add one too [22:39:16] New review: Mattflaschen; "It would have been good to say *what* parser in the commit message." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/73866 [22:39:54] New review: Anomie; "This looks like it should work. Haven't tested it though." [mediawiki/extensions/WikiLove] (master) C: 1; - https://gerrit.wikimedia.org/r/73883 [22:42:29] New review: Mwalker; "It seems like we still might want to change the EoY email subject line; but I can wait for that to b..." [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/72669 [22:42:30] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72669 [22:43:17] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73543 [22:43:58] New review: Mwalker; "Hah; thanks for that :)" [wikimedia/fundraising/crm] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73547 [22:43:58] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73547 [22:44:19] New review: Hoo man; "That's a feature which (AFAIS) isn't being used anywhere within the extension so this shouldn't be t..." [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73883 [22:45:36] New patchset: Spage; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [22:45:49] James_F: Is that some kind of urgent? (Will it help I fix it now) [22:46:07] New patchset: Ori.livneh; "Import mwerrors ganglia metric module" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73891 [22:46:14] hoo: Yeah, it would be awesome if you could fix now. [22:46:23] Ok, I guess I can do taht [22:46:30] hoo: Right now VE can't actually report /what/ the AbuseFilter warning was, just that you got one. :-( [22:46:48] anomie|away & csteipp: thanks, I'm in on oauth-apache1. I'm going to update its Extension:CentralAuth with 73449 (^the above was just a rebase) and Extension:GettingStarted patch [22:46:57] That name actually is misleading [22:47:09] (the Status class function name) [22:47:44] New review: Ori.livneh; "Code was reviewed when committed to operations/puppet in I55450783d." [mediawiki/tools/fluoride] (master) C: 2; - https://gerrit.wikimedia.org/r/73891 [22:48:14] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69527 [22:48:39] Stupid technology [22:50:44] New patchset: Ori.livneh; "Import mwerrors ganglia metric module" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73891 [22:53:18] New patchset: Ori.livneh; "Import mwerrors ganglia metric module" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73891 [22:54:43] New patchset: CSteipp; "Update CentralAuth to master - fix SUL regression" [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73893 [22:59:31] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf10) - https://gerrit.wikimedia.org/r/73893 [23:00:29] New patchset: Hoo man; "Really parse the API warning in the APIEditBeforeSave hook" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/73895 [23:00:44] AaronSchulz: I wonder if Tyler has actually benchmarked that or if he is just pulling numbers out of the air [23:01:14] New patchset: Hoo man; "Really parse the API warning in the APIEditBeforeSave hook" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/73895 [23:01:51] New patchset: Ori.livneh; "Import mwerrors ganglia metric module" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73891 [23:02:19] James_F: Change is in gerrit ;) [23:02:27] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73891 [23:03:43] GorillaWarfare: how goes things? [23:04:01] hoo: You're awesome. :-) [23:04:27] mwalker: It goes [23:04:29] Trying to test things [23:04:36] I noticed that :) [23:04:46] * GorillaWarfare nods [23:05:10] anything I can do to help that process? [23:05:30] Well I'm trying to run PHPUnit right now [23:06:01] And I'm getting "...................PHP Fatal error: Call to undefined method Block::getBlocksForIPList() in /var/www/wiki/tests/phpunit/includes/BlockTest.php on line 349" [23:06:23] is your master fully updated? [23:06:28] er; core [23:06:30] on master [23:06:32] fully updated [23:06:43] I guess I haven't checked [23:07:10] might also do a submodule update --init --recursive just to pick up anything else that's changed [23:07:19] Kay, I'll give it a shot [23:09:45] if it's still not working you can try pinging marktraceu* about it; he's really good with it; or if you can catch him, hashar [23:12:23] New review: Thaiphan; "1. You never actually declare $containerPaths so you're really just pulling Line 96 out of nowhere." [mediawiki/extensions/AWS] (master) C: 1; - https://gerrit.wikimedia.org/r/73737 [23:13:19] mwalker: Sounds good [23:15:29] New patchset: Mwalker; "DataValidator can use boss's methods" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64323 [23:15:46] New review: Adamw; "Great. I only found one obvious bug!" [wikimedia/fundraising/PaymentsListeners] (master) C: -1; - https://gerrit.wikimedia.org/r/69834 [23:15:54] New review: Aaron Schulz; "Well resolveContainerName() was intended for both validation/encoding. Returning null tells the rest..." [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/73737 [23:17:55] New review: Tim Starling; "My benchmarking indicates ~1.4us additional overhead, which seems acceptable given the context." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/72244 [23:18:22] New patchset: Mwalker; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038 [23:20:10] New review: Mattflaschen; "Depends on corresponding change to GuidedTour (https://gerrit.wikimedia.org/r/#/c/72677/)" [mediawiki/extensions/GettingStarted] (master) C: -2; - https://gerrit.wikimedia.org/r/72682 [23:20:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72244 [23:23:00] New review: Adamw; "aggravated nitpicks" [wikimedia/fundraising/PaymentsListeners] (master) C: -1; - https://gerrit.wikimedia.org/r/69839 [23:26:31] New patchset: Kaldari; "Adding getter method for QuickTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [23:27:53] New review: Brion VIBBER; "Seems to work more or less as expected. :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [23:32:51] New review: Helder.wiki; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [23:32:56] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/72834 [23:35:24] New review: Adamw; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72635 [23:36:59] New patchset: Kaldari; "Adding getter method for QuickTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [23:42:27] New patchset: MarkTraceur; "First iteration" [mediawiki/extensions/BetaFeatures] (master) - https://gerrit.wikimedia.org/r/73903 [23:45:01] New patchset: Adamw; "Ensure that times go into the db in UTC, regardless of global or user timezone settings." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73118 [23:45:13] New review: Thaiphan; "Oh okay, fair enough. The configuration is still all over the place but. As far as I can tell, $conf..." [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/73737 [23:48:45] New review: Kaldari; "PageTriage calls $.wikiLove.openDialog() with a custom list of recipients, but it looks like the rec..." [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/73883 [23:55:54] New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73794 [23:57:49] New patchset: Ori.livneh; "Rename 'metric_module' to 'ganglia'; move parsing files to 'parse'" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73905 [23:58:14] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/73905