[00:11:08] New review: Mattflaschen; "OKFN only has special handling for 3 HTTP response codes (see https://github.com/okfn/annotator/blob..." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [00:11:16] New patchset: Hoo man; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [00:12:48] New review: GWicke; "Yeah, although a one-second timeout can always be overridden by a minimum timeout setting. In Parsoi..." [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/73188 [00:13:05] New review: Hoo man; "Addressed Anomie's comments (aguprop should work correctly now)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [00:27:52] New patchset: Kaldari; "Adding getter method for QuickTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [00:34:48] New patchset: Kaldari; "Adding getter method for QuickTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73548 [00:44:09] New patchset: CSteipp; "Allow local wiki to act as central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [00:57:21] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72889 [01:05:22] New patchset: Mwjames; "\SMW\Setup + \SMW\HooksExtender, create testable hooks instantiation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [01:08:36] New review: Daniel Friesen; "If you're going to go this far I think this method could use behaviour just like Python's dict.get m..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73548 [01:09:50] New review: Mwjames; "What ever this means ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [01:11:57] New review: Mwjames; ".PHP Fatal error: Using $this when not in object context in /srv/ssd/jenkins-slave/workspace/mwext-..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [01:23:43] New patchset: Mwjames; "\SMW\Setup + \SMW\HooksExtender, create testable hooks instantiation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [01:25:44] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73529 [01:55:32] New patchset: Mwjames; "\SMW\Setup + \SMW\HooksExtender, create testable hooks instantiation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [02:05:20] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [03:20:24] New patchset: Mattflaschen; "Add support for VisualEditor" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [03:21:04] New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [03:25:46] New patchset: Mwjames; "\SMW\Setup + \SMW\HooksExtender, create testable hooks instantiation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73551 [03:50:39] New review: Bsitu; "I'd like this to be merged before deploying Echo HTML patch. An enwiki article may contain non-asci..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71747 [03:51:05] New patchset: Mattflaschen; "Add support for VisualEditor" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [06:27:13] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [06:36:06] New patchset: KartikMistry; "Add free and open licensed font for Urdu script" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [07:23:36] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) C: -1; - https://gerrit.wikimedia.org/r/73144 [07:34:34] New review: Mattflaschen; "Updated on toro. Removing -2, since the only remaining blocker is Guiders, which Jenkins will enforce." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [07:36:04] New review: Mattflaschen; "Updated on toro." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [08:02:51] New patchset: Mattflaschen; "Add support for VisualEditor" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [08:03:44] New review: Mattflaschen; "7 -> 8 is just whitespace." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [08:17:39] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/73561 [08:35:20] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72720 [09:18:55] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [09:22:52] New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [09:25:57] New review: Krinkle; "Maybe next time provide a link (in the commit message) to which version of which upstream this is from." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72967 [09:29:01] New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [09:35:36] New review: Mattflaschen; "Patch set 9 incorporates Krinkle's suggestions." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682 [09:46:58] New patchset: Rjain; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [09:50:22] Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73128 [09:53:18] New patchset: Ori.livneh; "Add 'mediawiki-vagrant' plug-in and 'paste-puppet' sub-command" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73563 [10:03:19] New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [10:16:01] New patchset: Rjain; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361 [10:41:18] Hey guys [10:41:36] Is it possible to add custom button to Visual editor [10:41:42] from other extension? [10:45:52] (replied on #mediawiki) [10:46:49] MatmaRex: thanks [11:25:59] New patchset: Santhosh; "Support explicit plural forms at client side l10n" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73567 [12:22:45] New patchset: Kghbln; "Translation update by the SMW community" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [12:38:20] New patchset: Kghbln; "Translation update by the SMW community" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [12:38:53] New review: Mormegil; "I am afraid this change caused another problem to appear. See https://bugzilla.wikimedia.org/show_bu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/38532 [12:42:07] New review: Kghbln; "Hmm, cannot really figure out why the bot is failing on me." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [12:43:31] New review: Kghbln; "This should probably not only go into master but also into 1.9.x if the change gets approved" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [12:56:04] New patchset: Kghbln; "Amended system messages" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/73571 [13:57:05] New patchset: Kghbln; "Amending a system message" [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/73572 [15:37:11] New patchset: Krinkle; "Add release notes 8dcf1e6205" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73576 [15:37:22] New review: Krinkle; "Fixed in I02c8fc0782f8c20c8ac." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72886 [15:40:29] New review: Krinkle; "Why is this marked as dependant on Iedaebefc139ecd7a? Both the files changed and the subject of the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41364 [15:41:25] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/45944 [15:41:40] New review: Matmarex; "By accident, and because nobody cared.:)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41364 [15:42:57] New patchset: Krinkle; "Change how Vector's tabs behave on small resolutions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [15:43:14] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [15:43:48] New patchset: Jarry1250; "Use
    ,
  • in search suggestions instead of endless
    s." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41364 [16:59:22] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [17:23:41] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/73572 [17:26:10] New review: Mwjames; "Fails because of " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [17:26:29] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [17:26:45] New patchset: Jeroen De Dauw; "Translation update by the SMW community" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/73570 [17:42:19] Hello. In Spanish Wikipedia, #babel extension adds automatic categories to users. How can we achieve the same automatic categorization on other projects. We want it on Spanish Wikinews and Spanish Wikivoyage. [17:55:31] siglar: file a bug :) [17:56:20] MatmaRex: Thank you. But I don't know how. [18:12:36] New patchset: Euvl; "Added lingo support for ApprovedRevs. To enable feature use" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/73577 [18:13:25] New patchset: Euvl; "Added lingo support for ApprovedRevs. To enable feature use $wgLingoEnableApprovedRevs" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/73577 [18:14:36] siglar, ¿qué clase de categorización quieres? [18:14:42] ¿la misma que #babel? [18:19:34] Hola, Platonides. Sí, exactamente esa. [18:22:26] ¿babel no está activo en esas wikis? [18:22:46] Sí, pero no añade categorías. [18:22:58] ah, entonces se trata de configurarlo [18:23:36] ¿Cómo se configura? [18:23:48] hay que abrir un bug [18:24:35] Mi experiencia en Bugzilla es nula. Acabo de crear una cuenta :) [18:25:04] ¿mismos nombres de categorías que en eswiki? [18:25:26] mmh.. no [18:25:50] son Wikipedia:Wikipedistas con nivel básico/intermedio/avanzado/experto/profesional/nativo de %wikiname% [18:26:17] ¿cuál es el equivalente a Wikipedistas? [18:26:21] ¿Wikinoticieros? [18:26:32] Wikirreporteros [18:26:36] Wikirreporteros [18:26:53] Aunque ya existen las categorías Usuario en, Usuario es, etc. [18:27:04] https://es.wikinews.org/wiki/Categor%C3%ADa:Usuarios_por_idiomas [18:28:09] también se pueden usar categorías del tipo: "Usuario en-3" [18:28:36] que parece ser lo que está usándose en wikinews [18:29:00] Ciertamente [18:29:04] y la categoría principal sería Usuarios_por_idiomas, entonces [18:29:12] Sí :) [18:29:26] bueno, pues en el bug dices eso :) [18:29:51] Ah, bien. Procedo, entonces. Gracias, Platonides :) [18:31:28] dame un grito cuando lo hayas creado [18:32:25] Bien. [18:34:18] is there any one who can do an enhancement ? [18:44:41] Platonides, hecho: https://bugzilla.wikimedia.org/show_bug.cgi?id=51297 [18:50:57] New review: Yurik; "Thanks !!!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72886 [18:52:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73576 [18:53:29] code done, now it needs someone to approve it [18:54:44] you should reply to the question posted by odder [18:55:01] either with community consensus or by convincing him that you are already using those categories :P [18:56:22] Buscaré el consenso, entonces. [19:03:14] New patchset: Euvl; "Added lingo support for ApprovedRevs. To enable feature use" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/73577 [19:04:04] New patchset: Euvl; "Added lingo support for ApprovedRevs. To enable feature use $wgLingoEnableApprovedRevs" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/73577 [19:07:02] Platonides, ya le pregunté a la comunidad de Wikinoticias. Le preguntaré a la de Wikiviajes antes de solicitar algo más. Muchas gracias por tu ayuda. [19:32:48] * James_F notes that BetaLabs /still/ isn't updating from master for VisualEditor. :-( [20:37:33] New patchset: Jeroen De Dauw; "Rem empty test" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73579 [20:37:33] New patchset: Jeroen De Dauw; "Add dependeny on param-processor to composer.json" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73580 [20:38:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73579 [20:38:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73580 [20:41:09] New patchset: Jeroen De Dauw; "Add min stability flag in composer.json" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73581 [20:41:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73581 [20:45:01] New patchset: Jeroen De Dauw; "Doc improvements" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73582 [20:45:09] New patchset: Jeroen De Dauw; "Doc improvements" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73582 [20:45:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73582 [21:14:35] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [21:15:59] Change merged: Aaron Schulz; [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/73183 [21:32:00] New version of the Flow prototype up at http://unicorn.wmflabs.org/flow/ [21:33:29] New patchset: Jeroen De Dauw; "Make Processor constructor public" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/73583 [21:35:23] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73549 [21:35:58] New patchset: Jeroen De Dauw; "Add default value in ProcessingResult constructor" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/73584 [21:36:42] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/73583 [21:36:50] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/73584 [21:49:20] New patchset: Ori.livneh; "Add 'mediawiki-vagrant' plug-in and 'paste-puppet' sub-command" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73563 [21:50:08] New patchset: Jeroen De Dauw; "Added HookRegistrantTest" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73586 [21:50:08] New patchset: Jeroen De Dauw; "Added FunctionRunnerTest" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73587 [21:50:30] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73563 [21:50:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73586 [21:51:20] New patchset: Jeroen De Dauw; "Added FunctionRunnerTest." [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73587 [21:55:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73587 [22:12:42] New patchset: Jeroen De Dauw; "Fix binding to parser API" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73588 [22:13:06] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73588 [22:19:18] New patchset: Jeroen De Dauw; "Added missing return" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73589 [22:19:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73589 [22:21:27] New patchset: Jeroen De Dauw; "Fix test" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73590 [22:21:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73590 [22:40:42] JeroenDeDauw: I would suggest you to not merge before making sure it's fine [22:42:29] JeroenDeDauw: I don't want to clamp down on your extension, just want to give you a friendly pointer; jenkins is there for your benifit [22:42:43] AzaToth: what are you talking about? [22:42:52] mediawiki/extensions/ParserHooks [22:42:57] AzaToth: I make sure stuff works before I push it to gerrit [22:43:16] doesn't looke like that ヾ [22:43:55] JeroenDeDauw: for example https://gerrit.wikimedia.org/r/#/c/73589/ jenkins says V-1, you say V+2,C+2 [22:44:33] AzaToth: yeah, Jenkins is currently given a false negative [22:44:41] ok [22:45:40] and "Added missing return", "Fix test" are not something that was missing in the previous commits? [22:46:31] hmm, does jenkins give false positives for all php unit tests, or is it just your extensions that have false positives? [22:47:10] AzaToth: I'm not sure what is going on here, but it looks like I'm running into a bug in the PHPUnit mocking API [22:47:21] oh [22:47:42] AzaToth: "Added missing return" - that code unfortunately has no test coverage yet, I am in the process of adding tests for code added quite a while back [22:48:16] AzaToth: "Fix test" - you are right, I submitted broken code here. I probably ran the wrong test group locally or something, as normally I should have cought this [22:48:41] ah [22:48:42] AzaToth: FYI: I am doing TDD, I'm the one that made sure these tests are run on Jenkins, and I also have them run on TravisCI [22:48:54] I see [22:48:58] And I'm all for continuous deployability [22:49:05] So no need to lecture me on the subject :) [22:49:28] New patchset: Jeroen De Dauw; "Attempt to get rid of weird PHPUnit issue" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73591 [22:50:52] lolwtf [22:51:02] JeroenDeDauw: well; normally you let other people code review your commits in gerrit [22:51:26] AzaToth: except that people do not review my comments to this extension in a reasonable amount of time [22:51:34] They'll just sit there for months [22:51:39] I cannot work like that clearly [22:51:41] that sucks [22:52:02] If I get some people that review these, it'd keep them on gerrit for actual CR [22:52:10] This is what I do for several other projects where there are reviewers [22:52:20] But for a lot of extensions there just are none [22:52:24] you keep them on gerrit? ツ [22:52:53] ? [22:53:05] As in, I do not CR them myself [22:53:14] ah, I thought you typed "I'd keep them on gerrit" [22:53:27] "CR them myself" basically being getting around the fact I cannot directly push, which is silly for projects where there are no reviewers [22:53:47] hmm, you don't have admin rights to your extension? [22:54:03] i.e. you are not owner? [22:54:07] AzaToth: I do, though there is some global thing set up that prevents pushes to master [22:54:16] that's a right [22:54:17] This got added a month or two back [22:54:44] Perhaps I'm wrong, but my understanding is that now extension owners are no loneger able to do this [22:56:54] there [22:57:02] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/73592/ [22:57:56] JeroenDeDauw: force push might be a bit too much [22:58:15] AzaToth: oh, interesting [22:58:57] JeroenDeDauw: you should yourself be able to go in under Access and add the permissions you want [22:59:01] AzaToth: thats great news then - I was wondering what I was going to do when I'm done with the 1.0.x branch of SubPageList and want to merge it into master - I'd really not want to submit 100 already merged commits to gerrit for that :p [22:59:07] force push is a bit dangerous though [22:59:17] heh [22:59:27] AzaToth: how is it dangerous? It allows overiding? [22:59:50] JeroenDeDauw: there is the permission "Push Merge Commit" [23:00:27] JeroenDeDauw: normal push is fine, it just bypass the review; force push means you can push away commits already pushed [23:00:40] i.e. it allows you to revrite the history on target [23:00:50] Right [23:01:05] AzaToth: who are you btw? Have we met? [23:01:10] that's only needed to remove sensitive information that accidentally ended up in the repo [23:01:16] I'm me, and we've never met afaik [23:01:47] just saw you spammed the poor thing out of gerrit-wm ツ [23:02:45] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ParserHooks,access btw [23:03:45] New patchset: Jeroen De Dauw; "Attempt to get rid of weird PHPUnit issue" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73591 [23:04:32] AzaToth: well, nice to make your acquaintance then [23:04:58] This PHPUnit issue is odd... [23:05:02] Not doing anything special [23:05:06] Done this 100s of times [23:05:10] Not failing locally [23:05:19] But failing on TravisCI, which is running the tests in the same way [23:05:24] With the same PHPUnit version [23:05:25] wtf [23:06:42] New patchset: Jeroen De Dauw; "Attempt to get rid of weird PHPUnit issue" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73591 [23:09:15] * JeroenDeDauw facepalms [23:11:38] New patchset: Jeroen De Dauw; "Add dependencies for ParserHooks library" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73593 [23:17:05] New patchset: Jeroen De Dauw; "Added automatic loading of dependencies" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73595 [23:17:21] New patchset: Jeroen De Dauw; "Added automatic loading of dependencies" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73595 [23:17:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73595 [23:20:06] Hey helderwiki. I saw your bug report about the CSS loading from client side... does that mean I should call addModuleStyles and addModuleScripts? [23:21:12] GorillaWarfare: no [23:21:39] GorillaWarfare: you should split your CSS in two parts - the bits critical for viewing thecontent, and the bits which are only needed when JS is enabled [23:21:54] GorillaWarfare: and addModulesStyle() thefirst part, and addModule() thesecond part. [23:22:16] (or, i guess you could just addModuleStyles() everything, but tha wouldn't be nice.) [23:24:13] Okay, thank you :) [23:44:31] GorillaWarfare: sorry, MatmaRex was faster than me :-) [23:46:56] New patchset: Jeroen De Dauw; "Add README file" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73596 [23:46:56] New patchset: Jeroen De Dauw; "Added COPYING file" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73597 [23:46:56] New patchset: Jeroen De Dauw; "Add usage notes to readme file" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73598 [23:47:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73596 [23:47:24] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73597 [23:47:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73598 [23:48:40] New patchset: Jeroen De Dauw; "Remove newline in readme" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73599 [23:50:08] New patchset: Jeroen De Dauw; "Bump to 1.0 release" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73600 [23:50:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73599 [23:50:34] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73600 [23:57:04] New patchset: Jeroen De Dauw; "Add MW as dependency in readme" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73601 [23:57:21] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/73601