[00:08:34] New patchset: Mwalker; "Matt 'Cleaned up' GatewayFormChooser aka Went Crazy" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73356 [00:09:50] New patchset: Mwalker; "Matt 'Cleaned up' GatewayFormChooser aka Went Crazy" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73356 [00:25:53] New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672 [00:59:08] AaronSchulz: ping [01:02:44] New review: Katie Horn; "Cleaner, yes... but I may have to circle around and rename value_appears_in() eventually, now that i..." [mediawiki/extensions/DonationInterface] (deploy-payments_1.22); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73356 [01:02:44] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73356 [01:16:50] New patchset: Mwalker; "Allow the Form Chooser to know about Currencies :)" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73375 [01:19:07] New review: Katie Horn; "Yay!" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73375 [01:19:08] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73375 [01:20:36] New patchset: Mwalker; "Adyen is a CC type" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73376 [01:21:31] New patchset: Mwalker; "Adyen is a CC type" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73376 [01:23:15] New patchset: Mwalker; "Adyen is a CC type" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73376 [01:25:20] Change merged: Katie Horn; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73376 [01:27:18] New patchset: Mwalker; "Matt 'Cleaned up' GatewayFormChooser aka Went Crazy" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73378 [01:27:19] New patchset: Mwalker; "Allow the Form Chooser to know about Currencies :)" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73379 [01:28:17] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73379 [01:28:17] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73378 [01:30:58] New patchset: Mwalker; "Updating DonationInterface to Master for Adyen :)" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73380 [01:31:12] Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73380 [01:48:40] New review: PleaseStand; "document.write() seems to have been used in r72180 (see https://www.mediawiki.org/w/index.php?title=..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73177 [02:07:24] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [02:10:17] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [02:10:32] New patchset: Mwalker; "Log & Show an Error if There is No Form" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73381 [02:12:15] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73381 [02:14:43] New patchset: Mwalker; "More DI Wonderfulness for Adyen" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73382 [02:14:58] Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73382 [02:32:07] New patchset: Mwalker; "Coerce values to null and log banner" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73383 [02:33:15] New review: Mwalker; "I'll plus 2 this if you want me to; otherwise I'll give people a chance to look." [mediawiki/extensions/BookManagerv2] (master) C: 1; - https://gerrit.wikimedia.org/r/73150 [02:33:46] New review: Katie Horn; "(1 comment)" [mediawiki/extensions/DonationInterface] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73383 [02:33:46] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73383 [02:38:11] New patchset: Mwalker; "And... more updates! We no co-erce and log banners" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73384 [02:38:35] Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73384 [02:42:45] New review: Mattflaschen; "Code is clear, and works locally." [mediawiki/extensions/GuidedTour/guiders] (master) C: 2; - https://gerrit.wikimedia.org/r/72241 [02:43:05] Change merged: Mattflaschen; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72241 [02:50:42] New patchset: Mwalker; "Ok; Don't Sub Currencies..." [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73385 [02:54:25] New review: Katie Horn; "Tested out on my local, works for the problem cases." [mediawiki/extensions/DonationInterface] (deploy-payments_1.22); V: 2 C: 2; - https://gerrit.wikimedia.org/r/73385 [02:54:25] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/73385 [03:01:05] New patchset: Mwalker; "Trying again..." [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73386 [03:01:22] Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/73386 [03:10:04] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/72362 [03:10:48] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #180: FAILURE in 9 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/180/ [03:10:55] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #160: FAILURE in 9 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/160/ [03:20:55] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #105: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/105/ [03:25:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #105: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/105/ [03:35:12] New patchset: Legoktm; "Add array to specify global-only actions, restrict to global editors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/48120 [03:36:32] New patchset: Legoktm; "Add array to specify global-only actions, restrict to global editors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/48120 [03:37:44] New review: Legoktm; "PS3/4: I merged the two if blocks together, but I'm not sure if how I arranged all the parentheses f..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/48120 [03:41:17] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #154: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/154/ [04:10:04] New review: Mattflaschen; "Tested successfully and looks good. Minor suggestions, neither of which are blockers." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [04:15:07] New review: Mollywhite; "Thanks! I think I'll give it another day or so for any other feedback, since I'm so new and since th..." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [04:28:35] is there a way to specify a code block in a gerrit comment? [04:34:58] nbm [04:35:00] nvm* [04:35:05] Preceding spaces. [04:35:18] Though there may also be a wrapper tag, I'm not sure. [04:54:37] Project browsertests-en.wikipedia.org-linux-chrome build #181: FAILURE in 4 min 17 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/181/ [04:58:43] Project browsertests-en.wikipedia.org-linux-firefox build #170: FAILURE in 4 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/170/ [05:03:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #44: FAILURE in 5 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/44/ [05:05:30] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #142: FAILURE in 5 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/142/ [05:08:10] ori-l: Can you think of any interesting Gerrit reports? [05:08:55] um, I think I had an idea a while back that I meant to tell you about, but I forgot. I'll see if I can recall it. [05:09:13] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #142: FAILURE in 5 min 22 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/142/ [05:09:14] K. [05:09:17] https://www.mediawiki.org/wiki/Talk:Gerrit/Navigation#Code_review_activity [05:09:20] Those were mine. [05:09:24] Those three. [05:11:46] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #146: FAILURE in 6 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/146/ [05:16:34] New patchset: Aaron Schulz; "Created $wgMWOAuthGrantPermissions and related functions" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73389 [05:16:41] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #134: FAILURE in 7 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/134/ [05:19:06] New review: Mattflaschen; "Some minor things, in addition to what Tyler said. It's coming along well." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/71364 [05:21:25] #p-personal li a:hover { [05:21:25] background-color: white; [05:21:32] Has that always been that way... [05:21:34] I just noticed. [05:21:53] New patchset: Mattflaschen; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [05:21:56] New patchset: Legoktm; "(bug 18660) Add GlobalBlocking as an AbuseFilter action" [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/48121 [05:23:32] New review: Mattflaschen; "13 is the same as 12, except for one last file's permissions." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/71364 [05:26:29] New review: Legoktm; "Addressed all of Hoo's comments, but when I try testing this the block isn't going though. Will try ..." [mediawiki/extensions/GlobalBlocking] (master) C: -1; - https://gerrit.wikimedia.org/r/48121 [05:29:29] New review: Mattflaschen; "A few small issues." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72360 [05:32:31] New patchset: Mattflaschen; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [05:33:30] New review: Mattflaschen; "6 is just a rebase. See 5 for the reviews." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72360 [06:20:51] New review: Mattflaschen; "Why don't we take this as an opportunity to set up the repo?" [mediawiki/extensions/PronunciationRecording] (master) C: -1; - https://gerrit.wikimedia.org/r/73017 [06:26:17] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/73152 [06:37:51] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [06:41:47] New review: Santhosh; "(1 comment)" [mediawiki/extensions/PronunciationRecording] (master) C: -1; - https://gerrit.wikimedia.org/r/73017 [06:46:20] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/73091 [06:47:25] Change merged: Siebrand; [mediawiki/extensions/Bootstrap] (master) - https://gerrit.wikimedia.org/r/73077 [06:48:24] New review: Siebrand; "Thanks." [mediawiki/extensions/Campaigns] (master) C: 2; - https://gerrit.wikimedia.org/r/73089 [06:48:28] Change merged: jenkins-bot; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/73089 [06:49:28] New review: Siebrand; "Thanks." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/71290 [06:52:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71290 [06:54:05] New review: Siebrand; "This is a pretty big body of code that has been going through review for the past (over) 4 months. I..." [mediawiki/extensions/UIFeedback] (master) - https://gerrit.wikimedia.org/r/50004 [06:58:08] New review: Siebrand; "My +1 should have been -1 per my previous comment." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/24211 [06:58:49] New review: Siebrand; "Ping?" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/53518 [06:59:45] Change merged: Siebrand; [mediawiki/extensions/FlashPlayer] (master) - https://gerrit.wikimedia.org/r/73099 [07:00:16] Change merged: Siebrand; [mediawiki/extensions/HaloTripleStoreConnector] (master) - https://gerrit.wikimedia.org/r/73101 [07:00:31] Change merged: Siebrand; [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/73102 [07:00:43] Change merged: Siebrand; [mediawiki/extensions/SMWHalo] (master) - https://gerrit.wikimedia.org/r/73103 [07:03:01] Change merged: Siebrand; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73125 [07:04:08] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67301 [07:07:34] Change merged: jenkins-bot; [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/65348 [07:12:56] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [07:28:01] New review: Mattflaschen; "There are few comments you could consider nice to haves. For example, although some of the lines in..." [mediawiki/extensions/UIFeedback] (master) - https://gerrit.wikimedia.org/r/50004 [07:47:50] New patchset: Himeshi; "Added parsing of the {{{section}}} tag." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [07:47:51] New patchset: Himeshi; "Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms into review/himeshi/GSoC" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/73391 [07:49:33] New review: Hashar; "deployed :)" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/73352 [07:49:34] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73352 [07:50:06] crashed :/ [08:41:35] New review: Raimond Spekking; "i18nreview" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [08:45:53] New review: Nemo bis; "Hashar, I copied the list to https://translatewiki.net/wiki/Translating:MediaWiki/Credits" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [08:58:37] New review: Hashar; "Yeah https://translatewiki.net/wiki/Translating:MediaWiki/Credits sounds better to me. Then people c..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [09:03:29] New review: Nemo bis; "OMG I didn't think of people wasting time adding self to it, I'll protect it immediately – it woul..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [09:08:17] New patchset: Santhosh; "Remove jquery.i18n code that the ULS extension overrides" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73395 [09:50:58] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) C: -1; - https://gerrit.wikimedia.org/r/73150 [10:16:03] Project _debug-free-style build #116: STILL FAILING in 44 sec: https://wmf.ci.cloudbees.com/job/_debug-free-style/116/ [10:30:29] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [10:38:17] Project _debug-browsertests-template build #189: FAILURE in 42 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/189/ [11:46:16] New review: Jeroen De Dauw; "Barring security issues, I agree with siebrand on perhaps merging this. The code might not be up to ..." [mediawiki/extensions/UIFeedback] (master) - https://gerrit.wikimedia.org/r/50004 [11:46:41] New patchset: Rjain; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [11:48:31] New patchset: Rjain; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [11:57:14] New review: Krinkle; "They were separate things, sorry:" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945 [12:33:17] New review: Hoo man; "Usually one hook is run (eg. page edit via the UI) but on action=edit edits both are run." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945 [12:52:37] New review: Zfilipin; "Karima, do you need help with this commit? For start, the commit message does not say what the commi..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71917 [13:10:11] New review: Umherirrender; "$('table.diff').text() give you also things out of the header like "revison as of" and so on. That b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [13:29:01] santhosh: I sent a pull request of sorts :) [13:29:08] not too useful, I know. still... [13:54:14] New patchset: Nikerabbit; "Help links for input settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73403 [14:38:27] New patchset: Nilesh; "Corrected package names in xml config files" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73409 [14:38:27] New patchset: Nilesh; "Back to using TranslatingClientRecommender as usual" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73410 [14:39:30] Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73409 [14:40:03] Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73410 [15:05:08] New patchset: Hoo man; "Parse the undelete-search-prefix message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73415 [15:08:31] New review: Nischayn22; "Code style" [mediawiki/extensions/SemanticForms] (master) C: -1; - https://gerrit.wikimedia.org/r/72051 [15:08:41] New patchset: Krinkle; "Make mwext-WikibaseQuery-testextensions-master non-voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73416 [15:08:46] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [15:09:22] New review: Krinkle; "(not sure whether you wanted it or not, let me know if so, will leave it open here so you can easily..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73416 [15:12:22] New patchset: Himeshi; "Added parsing of the {{{section}}} tag." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [15:14:50] @notify kaldari [15:14:50] I'll let you know when I see kaldari around here [15:15:11] hm, or is anybody else who deals with Notifications around? [15:16:04] New patchset: Mollywhite; "Page numbers should not be required" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73417 [15:16:16] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73417 [15:19:43] New patchset: Anomie; "Add User::isEveryoneAllowed function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73418 [15:52:44] New review: Anomie; "You still have the problem where specifying multiple values for agugroup will return multiple rows f..." [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/23177 [15:54:47] New patchset: Cscott; "Export information about external image settings via siteinfo API." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73199 [15:57:03] New patchset: Aaron Schulz; "Added preferences link to ManageMyGrants page and made some cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73422 [15:58:26] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73416 [15:58:46] New patchset: Krinkle; "Make mwext-WikibaseQuery-testextensions-master voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73423 [15:59:53] New patchset: Cmcmahon; "Fixed "uninitialized constant" error message" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72977 [16:00:04] New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/72977 [16:00:05] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72977 [16:07:05] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [16:12:52] New review: Anomie; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [16:25:47] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73423 [16:28:03] New patchset: Mollywhite; "Whitespace cleanup, changing lists to use ordered list." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742 [16:30:37] New review: Cscott; "Patch set 5 should satisfy anomie. Since the filters are prefix matches, then if $..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73199 [16:49:21] thedj: bonk [16:49:36] thedj: http://bug-attachment.wikimedia.org/attachment.cgi?id=12827 this will stop working on next deployment due to unrelated changes i merged [16:49:50] thedj: which reoder this prefs tab and happen to kill this heading [16:49:56] (it'll be in next tech news) [16:50:54] !technews [16:51:05] !technews is https://meta.wikimedia.org/wiki/Tech/News [16:51:05] You are not authorized to perform this, sorry [16:51:09] whaaa. [16:51:11] @trusted [16:51:11] I trust: petan|wk.*wikimedia/Petrb (2admin), .*@mediawiki/Krinkle (2admin), .*@wikimedia/Krinkle (2admin), [16:51:31] mediawiki/Krinkle doesn't exist, don't trust him. [16:51:40] !technews [16:51:40] https://meta.wikimedia.org/wiki/Tech/News [16:51:44] meh. [16:51:48] i just added it on #mediawiki [16:51:51] but this is dumb. [16:51:53] hehe [16:51:58] and petan's not here. [16:56:14] Krinkle: i filed https://bugzilla.wikimedia.org/show_bug.cgi?id=51246 , btw. [17:02:27] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73418 [17:05:40] New patchset: Platonides; "Fix class name: s/PerissionsError/PermissionsError/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73432 [17:07:45] New review: Aaron Schulz; "heh" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/73432 [17:08:23] heh. [17:08:38] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73389 [17:10:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73432 [17:17:21] New patchset: GWicke; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73433 [17:42:46] New patchset: Cmcmahon; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72720 [17:43:00] New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/72720 [17:48:55] New patchset: Mwjames; "SMW\ApiAsk + SMW\ApiAskArgs fix bug 51091, add unit tests, and improve code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72889 [17:51:10] Nikerabbit: You around? [17:51:50] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73433 [18:03:36] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/73437 [18:04:11] New patchset: Aaron Schulz; "Added preferences link to ManageMyGrants page and made some cleanups" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73422 [18:04:59] csteipp: minor rebase on https://gerrit.wikimedia.org/r/#/c/73422/ [18:06:49] New patchset: Reedy; "Removed $wgOldChangeTagsIndex" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73440 [18:08:22] New patchset: Reedy; "Removed $wgOldChangeTagsIndex" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/73441 [18:08:40] I'm trying to figure out how to correctly pass in parameters for a message of the form "{{PLURAL:$1|Author|Authors}}: $2" [18:08:42] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73422 [18:08:58] ->numParams( $array ) seems to be passing each member of the array in as $1, $2, etc. [18:10:00] GorillaWarfare: ->numParams( count( $array ) ) ? [18:10:19] GorillaWarfare: ->numParams( count( $array ) )->params( $wgLang->commaList( $array ) ), rather [18:10:29] Oh.. [18:10:31] * GorillaWarfare tries that [18:10:39] assuming i understood what you mean [18:11:01] and you probably shouldn't be using $wgLang, but $this->getLanguage() or something [18:12:05] MatmaRex: Thank you! That works perfectly :) [18:15:14] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [18:18:15] New patchset: Kaldari; "Adding hook handler for creating human-friendly relative timestamp" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/45499 [18:21:30] GorillaWarfare: wassup [18:22:09] New patchset: Platonides; "Remove unused globals." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73444 [18:26:08] New patchset: Dan-nl; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [18:26:31] Nikerabbit: I had a question about the wfMessage formatting, but MatmaRex answered it :) [18:27:15] Nikerabbit: marktraceur wanted me to ask you if you knew how to i18nize an indefinite list, though. [18:28:16] GorillaWarfare: MatmaRex answered [18:28:22] 's good [18:28:34] Nevermind :P [18:29:44] New patchset: Bsitu; "(bug 51005) Add secondary link to the archive page" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73447 [18:36:56] New patchset: Umherirrender; "TypeError: window.navigator.userLanguage is undefined" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73448 [18:38:02] New review: Umherirrender; "Untested" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73448 [18:38:33] New review: Karima Rafes; "Sorry for the name of this commit" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71917 [18:51:50] New patchset: CSteipp; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [19:05:04] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [19:06:01] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [19:08:17] New patchset: CSteipp; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [19:11:03] Change merged: Anomie; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/73441 [19:11:32] New review: Anomie; "I see that use of this variable in operations/mediawiki-config was removed in I8d66415f and in Flagg..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/73440 [19:14:01] New patchset: Nilesh; "Refactored recommender classes and servlets to load TranslatingClientRecommender one time only" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73452 [19:14:01] New patchset: Nilesh; "Removed custom idmigrator package" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73453 [19:14:02] New patchset: Nilesh; "Organized (and removed unnecessary) package imports" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73454 [19:14:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73440 [19:15:45] Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73452 [19:17:17] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [19:20:39] Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73453 [19:22:39] kaldari had the same question some time ago [19:23:41] AaronSchulz: I see you're a 'crat on testwiki. https://test.wikipedia.org/wiki/Wikipedia:Requests/Permissions/Anomie please? [19:24:36] sec [19:25:21] Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/73454 [19:25:57] anomie: done [19:26:01] thanks [19:28:35] New patchset: Anomie; "Update protection handling for core change I6bf650a3" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/71537 [19:31:21] New patchset: Matmarex; "HistoryPager: Remove superfluous join condition" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73457 [19:32:31] New review: Matmarex; "One good thing to come of bug 51254 is that I noticed this while investigating it ;)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73457 [19:35:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73444 [19:40:19] New patchset: Himeshi; "Added parsing of the {{{section}}} tag." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [19:50:17] New patchset: GWicke; "Update Parsoid once more" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73458 [19:53:52] New patchset: CSteipp; "Fix header parsing" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73459 [19:54:25] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73458 [19:56:45] New patchset: Ori.livneh; "Move Vagrant helpers to lib/mediawiki_vagrant.rb" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73460 [19:56:46] New patchset: Ori.livneh; "Logrotate >1MB files in /vagrant/logs" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73461 [19:57:57] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73460 [19:58:04] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73461 [20:04:42] New patchset: Ori.livneh; "Ensure path added to $: is canonical" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73462 [20:04:55] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73462 [20:15:00] -- Rollup table to pull a LIST of tags simply without ugly GROUP_CONCAT [20:15:00] -- that only works on MySQL 4.1+ [20:15:01] Hah [20:17:01] Reedy: http://en.wikipedia.org/wiki/Subquery#Subqueries ;) [20:17:45] New patchset: Spage; "Stop uls-previous-languages cookie varying by path" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73506 [20:20:04] Change merged: Ori.livneh; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62315 [20:26:19] New patchset: CSteipp; "Allow extensions to change the SUL redirect" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [20:31:55] 6 Warning: Parameter 1 to Language::findVariantLink() expected to be a reference, value given in /usr/local/apache/common-local/php-1.22wmf9/includes/StubObject.php on line 79 [20:37:46] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=47335 [20:40:17] anomie: around? [20:40:44] hoo: For about 20 minutes. What's up? [20:40:46] New patchset: Umherirrender; "Do not parse param of newsectionsummary on new section preview" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73519 [20:41:17] anomie: You broke unit tests with your User class patch [20:41:30] going to upload a patch in a second and I want it merged tonight :P [20:41:33] not on Monday [20:42:18] hoo: Oh? Which tests? [20:42:29] New patchset: Hoo man; "Don't cache in User::isEveryoneAllowed in unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73520 [20:42:30] anomie: Wikibase API permission tests [20:42:38] they depend on changing the globals [20:42:52] anomie: https://gerrit.wikimedia.org/r/73520 [20:43:58] New patchset: Hoo man; "Don't cache in User::isEveryoneAllowed during unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73520 [20:45:23] New review: Catrope; "Does this commit preserve the synchonousity of the top queue? Basically, modules loaded in the top q..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73177 [20:45:32] hoo: Looks good to me at first glance, I've seen that done elsewhere. [20:45:47] Yes, I've done the same in the User class at another place :P [20:46:16] * anomie waits for Jenkins... [20:47:43] thanks, anomie :) [20:47:45] New review: Matmarex; "In short, no. But it would make sense to me to make the top queue non-blocking, as the critical star..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/73177 [20:48:05] hoo: np [20:48:45] RoanKattouw: re ^^ - i think you were the person who wrote that :P [20:48:54] IIRC it was Timo [20:48:58] but i don't have the commit sha1 handy [20:48:59] I *think* [20:49:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73520 [20:50:56] New review: Catrope; "The top queue is designed to be blocking, to prevent flash-of-unstyled-content issues and other things." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73177 [20:51:32] I didn't write that [20:51:36] MatmaRex: One of the things the top queue is supposed to be for is loading CSS to prevent FOUC, or adding a class to the body to prevent FOUC [20:51:42] OK now I need to read the comment :) [20:51:58] I don't quite recall what else the top queue needs to be blocking for, but since Krinkle invented the concept he probably knows [20:52:33] CSS can and imo usually should be loaded with tags unless it somehow depends on JSalso executing [20:52:34] I think Krinkle wrote "Document.write is synchronous, so this is called when it's done" and I wrote "FIXME: that's a lie" [20:52:38] but anyway, thisis far from critical [20:52:55] doc.write is blocking page parsing, it doesn't always execute the script synchronous, but that's a separate issue that is essentially moot [20:53:03] (I would never write document.write with a capital D anyway, not even at the beginning of sentence) [20:53:04] i've got a couple of other changes to review which actually can be merged now, if you feel like looking at some ;) [20:53:22] it is synchronous in cases where we use it right [20:53:46] it is aysnchrnous when we use it wrong, and in those cases the browser is Firefox or Opera where it blanks the entire page, so it being async is an issue could case less about [20:54:14] when it is used from the primary page context where it doesnt' e.g. blank the page in Firefox/Opera (e.g. not called from an already async script) then it is fully synchronous [20:54:30] Roan wrote that "Lie" comment when we discovered the bug in Firefox [20:56:14] If you want to get rid of the top queue is blocking entirely, that's an interesting idea we can investigate later, but please file a bug about it. I'm not doing to discuss that in some arbitrary commit in Gerrit or right now on IRC :) [20:56:33] Overal it sounds good, and could be done as a project together with making the bottom queue asycnc from the top of the body instead of bottom. [20:56:41] yep, this will need some thinking-about [20:56:47] Which we tried last year and went pretty well, but then caused other issues. [20:59:17] Yeah [20:59:31] We'll need to think about this and experiment [20:59:45] But I suppose there's no huge rush on it, is there? [21:01:14] not at all, i think, now that ULS has a workaround [21:01:28] and nothing else is doing these sorts of thing, and in particular not in the top queue [21:04:54] Oh, is ULS moving stuff outside of the top queue? [21:05:15] New review: Mattflaschen; "Thanks for fixing all those issues. There are a couple small spelling problems. I also noticed 401..." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/71364 [21:05:19] New patchset: CSteipp; "Add util function to detect Authorization header" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73522 [21:05:22] Last I checked (which admittedly was like two weeks ago), they were loading pretty much everyone of their modules and their dog in the top queue [21:05:26] *every one [21:05:29] i think they still do [21:05:41] but ori came up with a convoluted fix that makes it not blankpages anymore :) [21:05:46] :) [21:06:03] (basically deferring the mw.loader.using to after document ready, iirc) [21:11:34] New patchset: CSteipp; "Add util function to detect Authorization header" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73522 [21:16:00] csteipp I'm checking out 73449, have questions [21:18:02] Krinkle: ping? [21:18:31] Yippie, build fixed! [21:18:32] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #62: FIXED in 3 min 14 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/62/ [21:18:51] mwalker: pong [21:19:15] do you know anything about automated build testing? specifically where the LocalSettings.php file for that is configured? [21:20:07] What do you mean by "automated build testing"? Do you mean our phpunit test in Jenkins on every gerrit patch set? [21:20:16] yep [21:20:16] that one [21:20:32] I'm trying to understand how it gets bootstrapped [21:20:36] it is generated by the installer (core:/maintenance/install.php) [21:20:46] and then we append a few config settings to it later [21:20:58] * Krinkle finds links [21:21:23] mwalker: https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/macro.yaml#L190-L220 [21:21:37] awesome! [21:21:46] That's where the install happens [21:21:59] For extensions we also add this: https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/macro.yaml#L222-L236 [21:22:48] 0.o where does the {dependencies} variable come from? [21:23:35] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/mediawiki-extensions.yaml#L81-L96 [21:23:46] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/mediawiki-extensions.yaml#L414-L426 [21:24:01] https://github.com/wikimedia/integration-jenkins/blob/master/tools/extensions-loader.php [21:24:05] https://github.com/wikimedia/integration-jenkins/blob/master/tools/fetch-mw-ext [21:24:37] ok; nifty [21:30:33] spagewmf: what's up? [21:33:16] New review: Jeroen De Dauw; "Placing such switches in the code based on if tests are running or not is bad..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73520 [21:33:24] csteipp, I'm trying to figure out if I can set it up locally, looking for documentation of $wgCentralAuthLoginWiki , puzzling out the redirect from each wiki /start back to /checkLoggedIn... [21:34:00] csteipp: I'll trade your explanation for on-wiki doc :) [21:34:43] spagewmf: Ugh, sadly setting up a local centralauth wikis is a little complex. I do need to document it. [21:35:08] Do you have multiple wikis in centralauth already? Or is that what you're trying to setup> [21:35:26] spagewmf: I have experience setting it up myself [21:35:31] but not a central login wiki yet [21:36:19] The central login wiki part is actually easy :) [21:36:51] I still need to set this up myself... kind of didn't manage to catch up with that :P [21:37:27] Just define $wgCentralAuthLoginWiki='enwiki'; $wgCentralAuthSilentLogin = true; $wgCentralAuthUseOldAutoLogin = false; [21:37:30] csteipp I wanted to test the SUL change locally with GettingStarted, but it sounds complicated. Is this set up for the beta labs cluster? Then when 73449 gets approved we can try Special:GS with the hook on beta enwiki [21:37:38] (where 'enwiki' is the name of one wiki) [21:38:06] csteipp will that work if the only wiki is 'myTestWiki'? I'll try it! [21:38:22] spagewmf: http://w1-oauth.wikipedia.wmflabs.org/wiki/Main_Page [21:38:45] spagewmf: hmm.... I never tried it like that, but it should actually work [21:44:26] New patchset: Rachel99; "WIP ve internal links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/73524 [21:48:35] New review: Hoo man; "Certainly that's true, but I don't see a better way without negatively affecting the performance here." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73520 [22:03:01] csteipp, http://www.mediawiki.org/wiki/Extension:CentralAuth/CentralAuthPostLoginRedirect amirite ? :-) [22:05:12] spagewmf: Looks good. stickHTTPS is specific to wgSecureLogin (if they want SSL) [22:05:22] And $type will be "signup" or "login" [22:05:37] New patchset: Ori.livneh; "Tolerate null class list in Roles.yaml" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73526 [22:07:57] New review: Mattflaschen; "Looks better. There are a couple issues still here." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [22:08:00] Change merged: Ori.livneh; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73526 [22:08:30] Zaran: should be fixed; can you 'git pull' and try to re-run 'vagrant provision'? [22:08:56] New patchset: Mattflaschen; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [22:09:38] New review: Mattflaschen; "See patch set 8." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72360 [22:09:46] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73459 [22:10:28] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73522 [22:12:46] actually csteipp, looking at the code it seems users will only be redirected if wgCentralAuthSilentLogin is true. Will you be setting that true along with wgCentralAuthLoginWiki when you enable the new SUL on enwiki? [22:14:54] RoanKattouw: you haven't been getting echo notifications from my vagrant instance, have you? [22:15:13] I just realized that it may be sending notifications, since I have an ldap dump [22:16:50] I don't think so [22:17:08] ok. good :) [22:23:28] New review: Mattflaschen; "Some initial notes." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72361 [22:29:01] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [22:31:08] New review: GWicke; "We would love to have more precise timeout information for transclusion fragments in Parsoid. Could ..." [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/73188 [22:32:11] New patchset: Kaldari; "Making header widths consistant on archive page in Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73528 [22:32:42] New review: Kaldari; "Trivial styling changes" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/73528 [22:32:54] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73528 [22:34:45] New review: Spage; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73449 [22:39:41] New patchset: Kaldari; "Render dates as headings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73529 [22:39:42] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [22:40:26] spagewmf: Yes [22:41:14] spagewmf: $wgCentralAuthSilentLogin = true; $wgCentralAuthUseOldAutoLogin = false; [22:45:54] New patchset: Ryan Lane; "getCanonicalName fixes and single domain stability" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/73530 [22:48:42] New review: Brian Wolff; "We could look at what data is being output, and use the most precise piece of information being outp..." [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/73188 [22:49:42] New patchset: Bsitu; "(bug 48568) Bust IE browser ajax cache + some API clenaup" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73531 [22:52:53] New patchset: Yuvipanda; "Do not record IP of registered users" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/73532 [22:53:29] YuviPanda: ahem? [22:57:21] hoo: I've no idea what I just did there, except that it kicks out recording ip address of registered users (I think). Untested. Not sure if that is wanted, or if I'm ripping out a feature, or anything at all. Feel free to abandon, -2 if I'm missing something obvious [22:57:42] New review: Yuvipanda; "Untested. Not sure if that is wanted, or if I'm ripping out a feature, or anything at all. Feel free..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/73532 [22:57:46] there, I added that as a comment too [22:57:51] YuviPanda: That certainly needs a broad consensus with the admin tools team [22:58:20] We already talked about that in a small circle and yes, we certainly need a solution, but I'm not sure that's right one [22:58:38] Personally I'd prefer to save the data but throw it away after n days [22:59:17] hoo: true, in which case feel free to abandon :) A friend poked me to see if I could help, and I thought i can write up the simplest thing I know. [22:59:38] (friend -> Ironholds, in this case) [22:59:55] Well... I think we can leave it open for (as I would like to see what csteipp and James_F think about it) [23:00:04] hoo: okay! [23:00:12] I'll be happy to fix followup comments, etc on it [23:00:28] k :) [23:00:30] or help in any way I can. [23:00:42] Yeah, we shouldn't be dumping the data forever. [23:01:06] James_F: doesn't CheckUser already have it? [23:01:15] hmm, not for rejected edits [23:01:16] YuviPanda: Not for non-saved edits. [23:01:18] Yeah. [23:01:46] James_F: We should autprune it in a sane way [23:01:56] or hook up to checkuser and leave the hard work to it [23:02:09] hoo: Oh, I agree. [23:02:14] hoo: Feel like doing that? :-D [23:02:33] New patchset: Jeroen De Dauw; "Make mwext-Wikibase-testextensions-master voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73534 [23:02:55] :D My to do list is rather long atm... maybe if it's simple, but there's just so much stuff I want to do [23:03:04] I should clone myself at least a few times :P [23:03:17] hoohoohoo! [23:03:33] There's already Hoo clone on enwiki :D [23:03:36] New review: CSteipp; "Stewards would like a way to correlate CheckUser with AbuseFilter hits." [mediawiki/extensions/AbuseFilter] (master) C: -2; - https://gerrit.wikimedia.org/r/73532 [23:04:10] thanks, Chris [23:04:14] ori-l: sorry I got distracted by something else [23:04:24] the commit did fix my problem! [23:04:41] hoo: csteipp abandoned it. [23:04:52] nah, he -2ed [23:05:01] hoo: yeah, *I* abandoned it :P [23:05:27] ori-l: would you mind explaining me what happened, and what's the purpose of this Roles.yaml file [23:05:29] there's no point in leaving it open after that, clearly I missed a lot of things there. [23:05:36] gerrit-wm seems to not tell us that :P [23:05:37] I could use some insight on puppet [23:05:49] hoo: indeed [23:05:52] hoo: was expecting it to [23:06:23] hoo: csteipp James_F either way, apologies for the noise. Got over-eager, I guess :) Carry on... [23:06:40] Zaran: sure, give me a minute [23:07:00] YuviPanda: Thanks for bringing that up again, I think it kind of fell of the schedule [23:07:31] hoo: :) let me know if there's anything I could do. Just trying to poke my nose in random places so I don't get silo'd into one area... [23:09:02] YuviPanda: But I appreciate the help! Want to join the admin tools team?? You could work on AbuseFilter all the time... :) [23:09:38] Well, you could start with reviewing my changes [23:10:35] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [23:11:31] csteipp: any particular bug you want to point me to? :) [23:11:51] hoo: I'm reviewing/testing https://gerrit.wikimedia.org/r/#/c/72563/2 right now [23:11:59] \o/ [23:12:44] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [23:14:52] YuviPanda: I would suggest https://bugzilla.wikimedia.org/show_bug.cgi?id=18110 [23:15:28] New review: Bsitu; "The date heading from 'load more' needs to be updated too" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/73529 [23:19:20] New review: Yuvipanda; "filterEdit doesn't seem to be used anywhere else, so lgtm." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/72563 [23:19:22] hoo: ^ [23:19:28] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72563 [23:19:34] :)) [23:20:11] hoo: I'll look at the others later. [23:20:18] helderwiki: I'll look at that later too :) [23:20:20] Thanks :) [23:20:27] I'm off to sleep now, since it's 5AM [23:20:36] great :-) [23:20:48] oh.. [23:20:52] And we need to find a way to restrict global filters to certain wikis/ disable them... I'm no longer a fan of just having a wikiset var from CentralAuth [23:21:02] I think we need a local interface for that :/ [23:21:41] CentralNotice has that, doesn't it? [23:21:49] Or WikiSets? [23:22:29] Elsie: Yeah... including wikisets was our first idea, but that would require hacking the filter rule itself, which isn't nice... [23:22:56] I don't know how CentralNotice works these days, there ahve been a lot of changes since I last looked at the source [23:23:08] New patchset: Jeroen De Dauw; "Add docs to readme file" [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73536 [23:23:33] Zaran: OK, I can explain now if you like [23:23:53] * YuviPanda heads to sleep. Good night everyone. [23:24:04] good night YuviPanda [23:24:08] I know I'm asking for a lot here, but does anyone want to give me a code review? https://gerrit.wikimedia.org/r/#/c/73530/ :) [23:24:20] New patchset: Jeroen De Dauw; "1.0 release" [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73537 [23:24:27] (you'll understand why I say I'm asking for a lot when you see which extension it is) [23:24:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73536 [23:24:32] ori-l: I'm still here :) [23:24:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73537 [23:25:26] good night, YuviPanda... nice to see a new face with admin tools :) [23:25:29] Zaran: OK, so based on you mentioning site.pp I presume you had some exposure to using that to manage roles [23:26:07] ori-l: yes I�have (I wanted to add the proofreadpage role, which I have written btw if you remember) [23:26:25] Basically, I wanted to keep that, but also provide something easy for people who don't want to start figuring out what Puppet is about [23:26:33] because it's largely orthogonal to being a MediaWiki developer [23:26:43] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [23:26:59] so I exploited a feature of puppet called 'ENCs' or external node classifiers [23:27:22] it's used for people who have other types of asset/server management things in place [23:27:45] you basically give puppet the path to an executable, and at the start of each puppet run, puppet runs it and passes the node name as a parameter [23:28:13] puppet expects the output to be a yaml document that enumerates additional classes (if any) to apply to the host [23:28:20] anyways, long story short, i wrote a small python script that acts like a trivial ENC [23:28:41] and that provides the ability to manage roles by commenting or uncommenting lines in Roles.yaml [23:28:42] New patchset: Mwalker; "Make testing a little bit more friendly" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/73527 [23:29:05] i screwed up by making the parsing be strict, but the idea was that this would be more approachable than having people edit puppet manifests [23:29:06] ori-l: any reason you didn't go with hiera? [23:29:11] New patchset: Kaldari; "Render dates as headings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/73529 [23:29:31] Ryan_Lane: i looked at it first and it's obviously a better solution for the use-case, but [23:29:56] it wasn't bundled with the default puppet 2.7, so to use it you have to manipulate the image or add a shell provisioner job that upgrades puppet [23:30:02] ah [23:30:02] ugh [23:30:36] ori-l: just to make sure I understand correctly: which file should we be editing now if we want to add a role? [23:31:04] do you mean add a role as in 'define a new role and potentially commit it to the repo' or just enable an existing optional role which is disabled by default? [23:31:32] sorry, I mean enable [23:31:43] the yaml file is easiest [23:32:44] I understand the rational behind not having people having to put their hands into puppet [23:32:51] you can do it in site.pp, but then git considers it an uncommitted local change so it gets in your way if you want to 'git pull' changes [23:33:00] but it seems to me that you just added one "level of indirection" with this yaml file [23:33:22] you can create your own manifest file by plopping it in puppet/manifests/manifests.d/, all puppet files in that folder are both git-ignored and auto-loaded by puppet [23:34:34] ugh, i need to fix my fix. that's what i get for rushing. [23:35:27] New patchset: Ori.livneh; "Fix path reference to YAML file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73540 [23:36:07] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73540 [23:36:15] Zaran: could you give that a shot? [23:36:37] not just to test the bug, but in general to see if it does indeed feel like another layer or if it helps things at all [23:37:06] I think if it wasn't broken when you initially tried it you might have formed a different impression [23:37:31] but if you have other suggestions I'd be very happy for the feedback [23:38:55] ori-l: ok let me try [23:40:52] New patchset: Jeroen De Dauw; "Added authors section to readme" [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73542 [23:42:51] ori-l: it works, but I just hope that people won't get confused by having to different places they can edit (which are not synchronized) [23:42:58] s/to/two [23:43:11] would there be any way of having sites.pp reflect the Roles.yaml file [23:43:14] and vice versa ? [23:43:43] I'm sorry if my question is very naive, but I don't know anything about puppet [23:43:55] so that probably doesn't make much sense [23:44:06] no, you're asking good questions and i'm glad that someone is being inquisitive :) it's good for development. [23:45:16] sorry, have to go for a bit, but i'll respond later [23:45:25] ori-l: sure [23:45:28] Zaran: could you file a bug, maybe, about the potential for confusion? [23:45:35] that'll give me a way to follow up [23:45:58] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72979 [23:46:21] ori-l: ok, I will do that now, and then I will probably go to bed, but I will be interested in reading your response [23:46:24] New patchset: Adamw; "Isolate translation, templating and sending of email as a new drupal module, wmf_communication" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72669 [23:46:39] ori-l: do you want me to submit the bug on github or on bugzilla ? [23:49:25] New patchset: Adamw; "typo in otherwise annoying code" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73543 [23:49:30] New patchset: Jeroen De Dauw; "Added some links to readme" [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73544 [23:49:34] Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73542 [23:49:39] ori-l: sorry, the answer to this question is in the README... [23:49:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/73544 [23:50:25] New patchset: Adamw; "unbreak unit test fixture: real currency and no invalid ctid" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73545 [23:50:58] New patchset: Adamw; "Logging in the STOMP dequeue loop" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73546 [23:51:52] New patchset: Adamw; "field should not be required" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73547 [23:53:58] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69961