[00:00:59] New patchset: SuchABot; "Increase Volley disk cache to 16MB" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73128 [00:20:41] greg-g: Emergency deployment upcoming to fix a bug in today's VE LD [00:21:50] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [00:22:24] New patchset: Catrope; "Update VE to master to pick up 9938186" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73133 [00:22:37] New review: CSteipp; "PS10: Updated the easy stuff. I'll rebase and integrate Aaron's work a little more." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [00:22:54] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73133 [00:23:00] New patchset: Catrope; "Update VE to master to pick up 9938186" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73134 [00:23:06] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73134 [01:27:47] New patchset: RAN1; "Fixed communitytwitter-logged-in-as message." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73137 [01:46:42] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [02:36:34] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73137 [02:39:00] any parsoid developers around? [02:39:19] TimStarling: Depending on what you need I might count [02:39:21] something is wrong with ParsoidCacheUpdateJob on enwiki [02:39:24] But the real Parsoid devs aren't around [02:39:32] $ mwscript showJobs.php --wiki=enwiki --group [02:39:35] ParsoidCacheUpdateJob: 33587 queued; 153 claimed (11 active, 142 abandoned) [02:39:51] :( [02:40:14] I'm not at all familiar with the Job code in Parsoid, unfortunately, that's Gabriel's baby [02:40:20] gwicke_away: ---^^ [02:40:22] it could be normal, I don't really know much about that job, but the abandoned count seems high, and there are a lot of jobs queued [02:40:35] Yeah that's a looong queue [02:40:37] there weren't 33k jobs queued yesterday, there were zero [02:40:44] I don't know what the criteria for abandonment are [02:40:56] probably throwing an exception or PHP fatal [02:41:08] Oh that kind of abandoned [02:41:13] I thought it was about deduplication [02:41:32] Hmm so is there a limit on how many jobs can be claimed, or is it on how many are active [02:41:47] Because if those 142 abandoned jobs are taking up space, that would explain why throughput is a lot lower [02:42:17] I'm just refreshing my memory [02:42:38] in JobQueueRedis, a job is claimed for a certain period of time [02:43:05] when it completes successfully, it is removed from the claimed queue [02:44:26] when a timeout occurs, i.e. the job wasn't completed successfully, the retry count is incremented and the job is returned to the queue [02:46:07] that timeout (claimTTL) is one hour [02:46:25] maxTries is 3 [02:47:07] so after 3 attempts lasting 1 hour each, the job is moved to te abandoned list [02:47:48] then after 1 week, the job is removed from the abanoned list [02:48:26] so "142 abandoned" implies 142 jobs have had triple-failures in the last week [02:48:48] c.f. refreshLinks: [02:48:49] refreshLinks: 211 queued; 10 claimed (7 active, 3 abandoned) [02:49:01] it has 3 in the last week, presumably due to OOMs [02:49:10] Hmm [02:50:48] New review: Spage; "Looks pretty good, mostly comment suggestions." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [02:51:12] TimStarling: I'm not familiar with this corner of Parsoid at all, so I suggest you send an email to Gabriel. He left a couple of hours ago, he should be back in ~13 hours [03:04:10] New review: Spage; "(1 comment)" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673 [03:04:47] there's only 28 parsoid job runner processes [03:05:58] so surely a lot of the claimed jobs must have exited [03:14:35] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #158: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/158/ [03:22:30] New review: Subramanya Sastry; "The only thing I am unclear is (for both core and Parsoid) is if the html tags used in wikitext impl..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72981 [03:36:21] New patchset: Spage; "Don't show position arrow if no attachTo found" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72241 [03:41:18] Anyone around for a quick PHP question? [03:41:33] Well, I guess I'll just ask [03:41:40] In Python, you can do [03:41:52] a, b = [1, 2] [03:41:59] And you'll end up with a=1, b=2 [03:42:08] Can you do that in PHP? I forget what it's called, so it's hard to Google.. [03:42:17] try ##php [03:42:25] GorillaWarfare, I think that's list [03:43:07] GorillaWarfare, yep: [03:43:09] list($a, $b) = array(3, 4); [03:43:40] superm401: Awesome, that's exactly what I was looking for! :) [03:43:47] Thanks a lot [03:43:57] GorillaWarfare, glad to help [03:49:47] New review: Spage; "Thanks!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [03:54:23] New patchset: Spage; "Form improvements when creating another's account" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841 [04:00:20] New patchset: Legoktm; "Check for the "noanalytics" userright rather than hardcoded groups." [mediawiki/extensions/googleAnalytics] (master) - https://gerrit.wikimedia.org/r/73140 [04:12:58] New review: Cscott; "I don't think there's any change in the semantics. I was just making a somewhat arbitrary decision n..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72981 [04:50:11] Yippie, build fixed! [04:50:11] Project browsertests-en.wikipedia.org-linux-chrome build #179: FIXED in 4 min 5 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/179/ [04:53:56] New review: Yuvipanda; "(1 comment)" [mediawiki/extensions/googleAnalytics] (master) C: 2; - https://gerrit.wikimedia.org/r/73140 [05:01:22] New patchset: Mattflaschen; "Document additional methods" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/73141 [05:09:35] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673 [05:11:06] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #132: FAILURE in 6 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/132/ [05:12:20] New review: Yuvipanda; "lego tested, works." [mediawiki/extensions/googleAnalytics] (master); V: 2 - https://gerrit.wikimedia.org/r/73140 [05:12:21] Change merged: Yuvipanda; [mediawiki/extensions/googleAnalytics] (master) - https://gerrit.wikimedia.org/r/73140 [05:12:30] New patchset: Mattflaschen; "Add skipThenUpdateDisplay public method and use it for shouldSkip." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673 [05:21:48] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [06:05:21] New patchset: Mattflaschen; "Persist Redis so the guest can be safely halted" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73142 [06:06:18] New review: Rtdwivedi; "Code-Review: -1" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/72933 [06:23:52] New review: Ori.livneh; "(1 comment)" [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/73142 [06:33:47] New patchset: Ori.livneh; "Make GettingStarted role's redis instance persist" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73142 [06:34:16] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/73142 [07:06:18] New review: Siebrand; "Please update message documentation when significantly updating messages. As $1 is a username and ca..." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73137 [07:06:29] New review: Siebrand; "See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73137 [07:43:42] New patchset: Mollywhite; "Adding a "link" property to each section entry." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73143 [07:44:28] Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73143 [07:49:32] New review: Nikerabbit; "Why was no message documentation added? Translators can have problems understanding the specific mea..." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990 [08:04:43] New patchset: Ori.livneh; "Add mw.hooks for toolbarSectionStart & toolbarSectionsComplete" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/73144 [08:42:38] New review: Hashar; "I am not sure why you duplicate the Debian directory in the 'gerrit' repository. Isn't it enough to ..." [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [08:44:00] New patchset: Hashar; "Run tests for WikibaseQuery" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72760 [08:44:33] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72760 [08:45:25] New patchset: Hashar; "Added Serialization component" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72761 [08:48:07] New patchset: Hashar; "Added Serialization component" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72761 [08:49:21] New review: Hashar; "listed updated jobs in commit message." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/72761 [08:49:21] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72761 [08:50:55] New patchset: Hashar; "Run tests for Serialization extension" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762 [08:50:59] New patchset: Hashar; "Run tests for Serialization extension" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762 [08:51:22] New patchset: Hashar; "whitelist Wikidata GSOC students" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945 [08:52:05] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762 [08:52:42] New patchset: Hashar; "whitelist Wikidata GSOC students" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945 [08:52:56] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945 [08:56:21] Reedy: hey there :-] [08:57:07] Reedy: what do you think about deploying jenkins jobs yourself ? Such as the jobs for the Disambiguator ext https://gerrit.wikimedia.org/r/#/c/73126/ [09:00:46] New patchset: Hashar; "Add Disambiguator extension" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73126 [09:01:03] New review: Siebrand; "It's better to change MediaWiki default namespace at https://translatewiki.net/wiki/Special:Advanced..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/58687 [09:03:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58687 [09:05:29] New review: Siebrand; "Thanks a lot for this." [mediawiki/extensions/LiquidThreads] (master) C: 2; - https://gerrit.wikimedia.org/r/58285 [09:05:40] Change merged: jenkins-bot; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/58285 [09:07:06] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72851 [09:09:50] New review: Siebrand; "This doesn't merge in the current state. Please rebase." [mediawiki/extensions/OAuth] (master); V: -1 - https://gerrit.wikimedia.org/r/72242 [09:10:08] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [09:11:16] New review: Siebrand; "Adding -1 to indicate there's an open question." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/58668 [09:12:31] New patchset: Siebrand; "Use {{int:}} syntax to ensure consistent UI text" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/50362 [09:14:44] New review: Siebrand; "Merging despite failing tests, as they are not related to this change." [mediawiki/extensions/Maps] (master); V: 2 - https://gerrit.wikimedia.org/r/72337 [09:16:12] Change merged: Siebrand; [mediawiki/extensions/Push] (master) - https://gerrit.wikimedia.org/r/72342 [09:17:11] New review: Siebrand; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/72344 [09:17:36] Change merged: jenkins-bot; [mediawiki/extensions/SemanticPageSeries] (master) - https://gerrit.wikimedia.org/r/72345 [09:17:54] Change merged: Siebrand; [mediawiki/extensions/SideBarMenu] (master) - https://gerrit.wikimedia.org/r/72346 [09:18:55] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/72341 [09:19:11] Change merged: jenkins-bot; [mediawiki/extensions/OATHAuth] (master) - https://gerrit.wikimedia.org/r/72340 [09:26:08] New review: Hashar; "Sam, ping me online to have it deployed. Meanwhile you can have a look at the basic guide at https:/..." [integration/jenkins-job-builder-config] (master) C: -1; - https://gerrit.wikimedia.org/r/73126 [09:30:06] New review: Raimond Spekking; "JsonSchema.i18n.php cannot be added to translatewiki.net because the messages keys are dupe of JsonS..." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72774 [09:30:24] New review: Nikerabbit; "I18n is good." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/72841 [09:31:13] New review: Nikerabbit; "Meant +1 for i18n, -1 for code style nitpicks." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72841 [09:35:41] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [09:40:26] New review: Mollywhite; "This file is a duplicate of the EventLogging file, and I have no intentions of changing its contents..." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72774 [09:49:19] New review: Raimond Spekking; "No problem for now." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72774 [09:49:50] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [10:01:46] New patchset: Shirayuki; "Fix spellings & Remove "successfully"" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72242 [10:04:06] New patchset: Shirayuki; "Fix spellings & Remove "successfully"" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72242 [10:05:44] New patchset: Krinkle; "mwext: Add Disambiguator (mwext-check-jobs template)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73153 [10:08:30] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [10:09:21] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73153 [10:09:30] New review: Shirayuki; "Done." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72242 [10:11:28] New patchset: Krinkle; "Enable jshint/phplint jobs for mwext-Disambiguator" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73154 [10:12:31] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73154 [10:13:29] New review: Mollywhite; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [10:14:17] New review: Matthias Mullie; "Should not yet be merged: metrics scripts currently depend on this data. I've contacted Dario to cha..." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/71854 [10:14:22] New review: Krinkle; "This change was not deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72760 [10:14:40] New review: Krinkle; "This change was not deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762 [10:14:54] New review: Krinkle; "This change was not deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945 [10:15:16] hashar: ^^^ [10:15:27] Are those OK for deploymet? [10:15:53] They're showing up in git log ..origin on gallium [10:15:57] Blocking https://gerrit.wikimedia.org/r/73154 right now [10:17:10] I'll wait a few minutes, then I'll revert them and deploy the change I intended to deploy [10:18:19] hey [10:18:40] Krinkle: let me check [10:18:55] Krinkle: oops [10:18:59] Krinkle: yeah you can deploy them [10:19:05] since I forgot to rebase : ( [10:19:25] k [10:19:38] I have warned the wikidata folks about it :-] You can proceed [10:19:40] sorry about that [10:19:43] New review: Krinkle; "Deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72760 [10:19:50] New review: Krinkle; "Deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762 [10:19:55] New review: Krinkle; "Deployed." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945 [10:21:38] hashar: there's an untracked file ./e from June 26 in /etc/zuul/wikimedia. [10:21:52] non-empty [10:22:17] ohh [10:22:26] seems to contain output of git log-nice or something like that [10:22:32] yeah I have deleted it [10:22:34] k [10:22:35] thx [10:22:35] must have done some > e [10:30:19] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [10:30:29] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [10:32:57] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [10:33:23] Change merged: Siebrand; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/72337 [10:37:06] Nikerabbit: Thanks for your review :) As you can tell I'm a bit new to PHP, haha [10:39:45] lunch time [10:40:02] GorillaWarfare: no problem [10:40:24] GorillaWarfare: do ask for clarifications, I'm terse by default [10:40:44] Nikerabbit: Thanks, I will [10:40:58] I've looked through and I'm making the changes; I think I understand everything [10:41:43] I'm awful about the trailing spaces/tabs... Do you have a way of not accidentally committing them? "Not adding them in the first place" doesn't seem to be a possibility for me.. [10:43:33] New patchset: Shirayuki; "Fix spelling (permissions)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72344 [10:44:51] GorillaWarfare: many editors have settings to show or even remove them [10:44:54] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677 [10:47:34] Hmm, I'll poke at my vimrc some more maybe [11:00:47] New patchset: KartikMistry; "Add free and open licensed font for Urdu script" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [11:01:49] y [11:13:38] Nikerabbit: For the changes to the qqq messages, should they be something like "Label in the navigation bar metadata dropdown" or something? [11:19:49] New patchset: KartikMistry; "Add free and open licensed font for Urdu script" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73156 [11:22:01] GorillaWarfare: it's a big vague... is there a documentation page or a screenshot or link to page where they are shown? [11:22:19] I can make a screenshot, sure. What do I do with the screenshot? [11:22:56] GorillaWarfare: you can upload it to translatewiki.net or commons and reference it with normal [[Image:Foo.jpg]] syntax in qqq [11:24:00] Nikerabbit: Okay. That should be the description for a lot of those messages... do I just keep paste it every time, or..? [11:24:57] GorillaWarfare: yeah this gets somewhat complicated [11:25:30] GorillaWarfare: it is also possible, if you have/create account on translatewiki.net, to create a template there and use that in qqq to avoid repeating the same thing many times [11:25:44] Oh, that's clever [11:25:45] Okay [11:30:41] Just testing: can you access https://docs.google.com/forms/d/1RFUa2zBAOolw78W-ozJPoYlR2lYbrAOYvOZYgjaAYQg/viewform ? [11:35:15] qgil: yes [11:35:36] Nikerabbit, thank you! [11:36:23] qgil: does it handle multiple affiliations? [11:36:57] Nikerabbit, yes, just explain. By now a human (or two) will go through that data [11:37:02] okay [11:37:13] I'm probably nightmare since I do all my contributions with single account [11:37:33] Nikerabbit, but wait, there must be a way to compute what contributions go where... [11:37:39] yeah, this is what I wanted to say :) [11:37:51] there isn't [11:37:58] "from 9am to 4pm in EET time... " ;) [11:38:02] joking [11:38:16] well, there is so much math and computers can do [11:39:13] mostly volunteer before I started working for WMF, mostly WMF after that but not only [11:39:29] New patchset: Mollywhite; "Bug 50957: Populate navbar from JSON block." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73150 [11:39:32] but yeah this is not the place to do process that [11:39:44] New patchset: Raimond Spekking; "Add i18n file" [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73160 [11:39:57] Yeah, you are not the only case for sure. Let's have some data, which will be better than no data. Then we can see how to fine tune and improve [11:43:15] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [11:47:25] qgil: "contributors in the past 12 months to Wikimedia Git OR Bugzilla OR mailing lists" [11:47:31] but the form asks nothing about ML [11:51:08] New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [12:01:55] Nemo_bis, oops [12:04:11] Nemo_bis, added the field. Thank you! [12:14:41] siebrand, you win! Then again you work at the Language team... Seriously: thank you, I have been writing "handlers" wrong for a long time and nobody corrected me before. [12:22:21] New patchset: Helder.wiki; "Remove old username" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/73165 [12:33:58] qgil: ;) [12:37:12] New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933 [12:37:15] New patchset: Helder.wiki; "Remove old username" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/73167 [12:41:18] New review: Nikerabbit; "Thanks a lot for making this patch. Also works for me." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/72614 [12:41:35] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614 [12:58:22] New patchset: Hoo man; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [13:02:28] New patchset: Rjain; "Added the read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [13:06:33] New patchset: KartikMistry; "Add Canadian Syllabic font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/73152 [13:18:39] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70646 [13:31:48] qgil: on the bright side, search confirms I only received 3 emails ever before this with that typo from you ;) [13:32:45] Heh. [13:32:58] Nemo_bis, you mean emails from me, with the same typo? [13:33:15] yes [13:33:25] one of which I didn't read [13:33:30] Is there a mail client extension for typo stalking? So that you can get an aggregate list of users and their fav. typos? :D [13:33:44] Nemo_bis, good that this time someone corrected me :) [13:34:09] hoo: sure, you can use Thunderbird [13:34:18] Thunderbird can do anything! [13:34:24] Indeed [13:34:31] With enough RAM, anything is possible! [13:34:35] haha [13:34:42] Haven't used that in a while... am back on Evolution now :P [13:34:59] hoo: install ImportExport tools, export with the appropriate format, run LibreOffice's spellchecker [13:35:03] Microsoft Outlook 2011 for Mac. [13:35:15] I know wikimedians who use Eudora [13:39:40] hashar: I'd be happy doing it if I knew how/there was instructions :) [13:40:35] Reedy: hi :-) [13:40:39] Reedy: we do have some! [13:50:36] qgil: no problem. It wasn't about winning. I will try to help you if there is a chance of being misunderstood. Spies have handlers :) [13:50:55] :) [13:52:37] New review: Reedy; "Awesome, looks like Jenkins gave up on this" [mediawiki/tools/release] (master); V: 2 - https://gerrit.wikimedia.org/r/70828 [13:52:37] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/70828 [14:08:07] anomie, ping [14:10:39] qgil: also, question re: affiliation. I guess a lot of people who work for the WMF still do things that they needn't at 'work', and I guess this is not going to be possible tot rack [14:10:41] *track [14:11:37] YuviPanda, in regular companies, employees keep a distintion of email addresses between work and other to make things clear. [14:12:11] YuviPanda, the WMS is quite strict asking employees to have different wiki usernames for editing, but there is no policy for tech contributions [14:12:12] yurik: pong [14:12:27] YuviPanda, then it's up to you to decide how to get organized. :) [14:12:43] I don't think *anyone* uses different Gerrit accounts or wikitech accounts [14:12:48] hey anomie, what are your reservations about the api versioning patch? How could we move it forward [14:13:09] YuviPanda, I know, I'm just explaining/. [14:13:35] qgil: I understand, was just wondering if you had some super-clever plan in mind :) [14:13:59] YuviPanda, my plan so far is get some data since it's better than no data. :) [14:14:34] agreed [14:14:37] YuviPanda, then we will see how concerning that point is. [14:14:44] right [14:15:15] qgil: can we file bugs against it on bugzilla? (I wanted to file one about excluding bots) [14:15:19] * YuviPanda goes to look for a component [14:15:31] YuviPanda, wait! :) [14:16:19] YuviPanda, we decided to use GitHub to deal with the inital fine tuning, since there are many little one-time bugs. [14:16:34] YuviPanda, then e will evaluate whether this is worth a Bugzilla component [14:16:43] qgil: ah, [14:16:48] so I can file them at GitHUb? [14:16:50] *GitHub [14:17:15] I'm okay with waiting for a while until the dust settles down too [14:17:17] if that'll be easier :) [14:17:43] YuviPanda, https://github.com/Bitergia/mediawiki-dashboard/issues?labels=resolved&state=open [14:18:00] YuviPanda, yes, the one about the bots, I filed yesterday and it has been fixed today. Will go to production tomorrow. [14:18:07] ah wonderful [14:18:14] will file any other if I come across them [14:18:19] thanks for doing this, qgil :) [14:18:22] YuviPanda, thanks! [14:18:40] I've been using the 'streak' metric from github as a means of 'racing' against legoktm, perhaps I can use this at some point :) [14:20:02] yurik: The same reservations I had when we talked about it in Amsterdam: I'm not convinced that the problems it solves are worth the maintenance problems it introduces. The majority of changes we want to make can be done easily enough by introducing temporary behavior-selecting parameters. And I note your actual implementation (unless you've changed it since I last looked) doesn't even satisfy one of your own goals, as it makes it so that every ti [14:20:02] me a new version of a module is made then all clients will have to be changed to explicitly use that new version (because "action=foo" is interpreted as "action=foo~0", not "action=foo~") [14:21:22] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [14:24:11] anomie, I don't think I want action=foo === action=foo~ - this breaks backward compatibility, so that's not an issue. The second patch automatically treats path_info as "main~1", but that's all. What I do want is to have an easy global (per module) way to switch defaults and output structure. And having an extra parameter or having a version is identical as far as code maintenance [14:25:22] the versions make this change more structured and common across all modules as opposed to each module having some magic params [14:27:31] New review: Anomie; "You do have a point on the definition of "useless". I guess the question then is whether we want to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73034 [14:27:43] New patchset: Hoo man; "(bug 16860) Add api for getting all global user" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [14:29:58] New review: Hoo man; "Simplified, optimized queries (we don't really want to send 5k user ids to the database server, do w..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/23177 [14:32:16] yurik: But having just the one "version" on the module means that if a client needs features in version 4 but is not ready for version 3, it's impossible to resolve. And having versions with an implicit guarantee that "foo~2" will never change until it is removed breaks when changes in other areas require changes in the API. But we went over all that in Amsterdam, I don't have time to repeat it all again now. [14:37:45] anomie, i am not sure i follow what you just wrote - if there is one version - nothing is changed. A new feature can be added at any point. We DID go over this and I think I explained the reasoning and you seemed to have agreed, hence I am a bit surprised now after implementation. Any added functionality to the module does not change version either. ONLY when the module 's author wants to... [14:37:47] ...produce breaking changes (remove param/change param's meaning/change output structure), does versioning COULD come into play. [14:50:01] New review: Anomie; "Code looks sensible enough. Other reviewers would be good though." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70040 [14:58:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72372 [14:58:32] New patchset: Hashar; "operations/debs/python-voluptuous no more exists" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73174 [15:00:30] New patchset: Hashar; "operations/debs/python-voluptuous no more exists" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73174 [15:02:47] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73174 [15:12:16] chrismcmahon: Does anyone know if there is there a problem on test2? I am getting error message servers are experiencing technical difficulties. [15:12:38] rachel99: yep, deploying new code right now [15:13:09] chrismcmahon: Ok, that explains it. I will try again later. [15:13:40] see #wikimedia-operations rachel99, Reedy is logging progress there [15:14:31] New patchset: Matmarex; "mw.loader: Rip out broken code path from addScript()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73177 [15:14:31] chrismcmahon: Ok, I will log into that channel [15:14:31] New patchset: Matmarex; "mw.loader: Remove remnants of synchronous loading mode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73178 [15:14:32] New patchset: Matmarex; "mw.loader: Explicitly use $( document ).ready instead of $" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73179 [15:15:17] New review: Yaron Koren; "Hi - I finally tested this out. Overall this looks good! I have a few comments:" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [15:17:35] anomie, how could we discuss this - i would really like to move forward on many things, and this patch is the cornerstone. Considering that this approach has been outlined in RFC for the past half a year and discussed ad infinitum, I am a bit reluctant to change the course now [15:23:53] New review: Matmarex; "Oh please, just tell me this is a random failure and that running QUnit tests doesn't actually depen..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73177 [15:27:03] where is hashar when i need him. D: [15:27:03] @notify hashar [15:27:04] I'll let you know when I see hashar around here [15:27:42] Krinkle: or if you're not busy, please glance at this ^ and tell me that the QUnit tests in jenkins don't actually depend on document.write() being used [15:27:54] Jenkins has got nothing to do with it [15:28:05] in our continuous integration* [15:28:11] document.write is the only way we can do blocking top queue right now [15:28:15] that has always been that way [15:28:26] I don't know why you think we don't use non-async [15:29:00] If it works locally, you're doing something wrong. [15:29:13] heh. [15:29:33] I'm not saying I like it, but it is certainly part of the design right now [15:30:21] New review: Umherirrender; "This change set changed the function getDiff, not getDiffBody. getDiff already returned a non empty ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014 [15:30:22] critical modules are loaded using