[00:00:03] <YuviPanda>	 but not too tedious
[00:00:07] <marktraceur>	 YuviPanda: That sounds like a lot of work actually, if it's all i18ned to 200+ languages
[00:00:18] <YuviPanda>	 marktraceur: ? what does?
[00:00:49] <YuviPanda>	 marktraceur: instead of labelPage being some_page_something_something_$1, it is now going to be {{int:<some-interface-page-name>}}
[00:01:05] <marktraceur>	 Ah.
[00:01:31] <YuviPanda>	 marktraceur: this is strictly *better* since it is parsed, so can haz links, etc. previous behavior was unparsed
[00:02:00] <YuviPanda>	 idk why the label field existed previously at all, but many things about UW remain a mystery....
[00:02:00] <marktraceur>	 Indeed
[00:02:24] <marktraceur>	 YuviPanda: "That's UploadWizardUploadInterface, Simba. You must never go there.
[00:02:31] <YuviPanda>	 "
[00:02:57] <marktraceur>	 `
[00:02:59] <marktraceur>	 Anyway
[00:03:39] <YuviPanda>	 so I want to get rid of the labelPage paradigm, forever and now.
[00:03:42] <marktraceur>	 That doesn't sound too bad
[00:03:53] <YuviPanda>	 sweet. I'll just stash this thing and remove my -1 then :)
[00:04:00] <marktraceur>	 *nod*
[00:05:08] <gerrit-wm>	 New review: Yuvipanda; "After discussion with MarkTraceur, Backwards Compatibility in this case can be ignored." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[00:05:10] <gerrit-wm>	 New patchset: Mattflaschen; "Check namespace in isAppropriateArticle." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72872
[00:05:22] <YuviPanda>	 marktraceur: done!
[00:05:25] <marktraceur>	 YuviPanda: "Ignored" is a strong term
[00:05:36] <gerrit-wm>	 New patchset: Kaldari; "Adding hook handler for creating human-friendly relative timestamp" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/45499
[00:05:36] <YuviPanda>	 marktraceur: it was qualified with 'in this case'
[00:05:42] <marktraceur>	 Mmmkay.
[00:06:22] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72671
[00:08:23] <gerrit-wm>	 New patchset: Mattflaschen; "Check namespace in isAllowedArticle." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72872
[00:10:04] <gerrit-wm>	 New review: Ori.livneh; "Can you help me understand the rationale?" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72700
[00:10:27] <gerrit-wm>	 New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[00:10:48] <TimStarling>	 AaronSchulz: actually, gvim has autocomplete at CTRL-N
[00:10:58] <TimStarling>	 maybe I should press it instead of copy/pasting all the time
[00:11:36] <gerrit-wm>	 New review: Ori.livneh; "Good catch." [mediawiki/extensions/GettingStarted] (master) C: 2;  - https://gerrit.wikimedia.org/r/72872
[00:12:10] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72872
[00:12:53] <YuviPanda>	 TimStarling: SuperTab is a fairly nice completion plugin that Works For Me, and YCM is supposedly much better (and fairly new).
[00:13:59] <gerrit-wm>	 New review: Mattflaschen; "I added it since:" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72700
[00:16:24] <gerrit-wm>	 New review: CSteipp; "Looks sane and useful. Logic is pretty much identical to the existing in LogPage.php." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72245
[00:16:53] <gerrit-wm>	 New patchset: Tim Starling; "Add --list parameter to showJobs.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72067
[00:19:16] <gerrit-wm>	 New patchset: Parent5446; "Added fallback information to LocalisationCache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72866
[00:19:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72245
[00:19:52] <gerrit-wm>	 New review: Tim Starling; "PS4:rebase on top of Aaron's solution for consistency." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72067
[00:20:15] <TimStarling>	 AaronSchulz: ^
[00:20:18] <YuviPanda>	 marktraceur: the folks running campaigns (on commons) are also okay with hand migrating things.
[00:21:34] <gerrit-wm>	 New patchset: Spage; "Hide benefits column on narrower screens." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72877
[00:24:10] <gerrit-wm>	 New patchset: Parent5446; "Complete usage of message fallback chain" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72867
[00:28:45] <gerrit-wm>	 New patchset: Parent5446; "Complete usage of message fallback chain" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72867
[00:29:27] <gerrit-wm>	 New patchset: Ori.livneh; "Add ParserFunctions role" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72700
[00:29:36] <gerrit-wm>	 New review: Ori.livneh; "OK!" [mediawiki/vagrant] (master) C: 2;  - https://gerrit.wikimedia.org/r/72700
[00:30:33] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72067
[00:31:46] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72700
[00:32:25] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[00:38:32] <gerrit-wm>	 New review: Mattflaschen; "Besides ensuring Guiders is internally consistent in how it handles this, this allows GuidedTour to ..." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673
[00:38:35] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[00:39:03] <gerrit-wm>	 New review: Helder.wiki; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564
[00:40:00] <gerrit-wm>	 New review: Ori.livneh; "Reedy, your patchset doesn't rebase cleanly; could you update it?" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62315
[00:44:32] <gerrit-wm>	 New patchset: Parent5446; "Complete usage of message fallback chain" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72867
[00:53:54] <gerrit-wm>	 New patchset: SuchABot; "Enable use of wikitext in field labels" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[00:56:28] <YuviPanda>	 I think this is a first
[00:56:32] <YuviPanda>	 Gerrit just crashed my browser
[00:56:58] <YuviPanda>	 jesus fucking christ, why do I even bother.
[00:57:39] <gerrit-wm>	 New patchset: Yuvipanda; "Enable use of wikitext in field labels & header/thanks pages" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[01:07:33] <gerrit-wm>	 New patchset: SuchABot; "Fix for 'download' on media detail page on Honeycomb" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/72879
[01:10:33] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/72879
[01:20:30] <gerrit-wm>	 New patchset: Ori.livneh; "Perform strict and verbose validation of optional 'Roles.yaml' file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[01:24:44] <gerrit-wm>	 New patchset: Spage; "Form improvements when creating another's account" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841
[01:29:07] <gerrit-wm>	 New patchset: Krinkle; "jquery.client: Detect Opera 15" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[01:31:24] <gerrit-wm>	 New patchset: Krinkle; "jquery.client: Add detection for Opera 15" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[01:33:19] <gerrit-wm>	 New review: Krinkle; "The use of "Chrome" in their UA is somewhat appropriate since they are Chromium based (not WebKit or..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[01:33:46] <gerrit-wm>	 New review: Krinkle; "Added release notes" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72467
[01:35:47] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[01:35:48] <gerrit-wm>	 New patchset: Krinkle; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[01:38:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[01:41:16] <gerrit-wm>	 New patchset: Ori.livneh; "Perform strict and verbose validation of optional 'Roles.yaml' file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[01:41:17] <gerrit-wm>	 New patchset: Ori.livneh; "git-fetch remote commits, but no more than once a week" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72882
[01:41:41] <gerrit-wm>	 New patchset: Hoo man; "Don't create default object from empty value in AbuseFilterHooks" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72883
[01:42:58] <gerrit-wm>	 New patchset: Ori.livneh; "Perform strict and verbose validation of optional 'Roles.yaml' file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[01:43:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[01:43:54] <gerrit-wm>	 New patchset: Ori.livneh; "git-fetch remote commits, but no more than once a week" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72882
[01:44:01] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72882
[01:49:38] <gerrit-wm>	 New review: Krinkle; "For the record, similar patches for the ua-parser project (which we were considering at some point a..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[01:50:20] <gerrit-wm>	 New patchset: Tim Starling; "jobqueue: avoid exceptions due to races in redis job listing functions" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72884
[01:52:49] <gerrit-wm>	 New patchset: Dan-nl; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405
[01:54:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72884
[01:58:59] <gerrit-wm>	 New patchset: Tim Starling; "Add --list parameter to showJobs.php" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72885
[01:59:03] <gerrit-wm>	 New patchset: Spage; "Form improvements when creating another's account" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841
[01:59:45] <gerrit-wm>	 New review: Ori.livneh; "...and bug 51085, which is currently causing fatals in prod." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/37648
[02:03:45] <gerrit-wm>	 New patchset: Yurik; "API DebugToolbar's debugLog format cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72886
[02:04:58] <gerrit-wm>	 New patchset: Ori.livneh; "Pass required Title object to getIndexDataForPage" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/72887
[02:05:42] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72885
[02:08:16] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/72887
[02:10:20] <TimStarling>	 oh charming
[02:10:31] <gerrit-wm>	 New review: Krinkle; "See also https://github.com/tobie/ua-parser/commit/99bc530d6192b650f7f7a5a16770242250d9430b" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[02:11:01] <gerrit-wm>	 New patchset: Ori.livneh; "Update ProofreadPage to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72888
[02:11:16] <TimStarling>	 git pull in /a/common/php-1.22wmf8 pulled in updated to ContributionReporting, ContributionTracking, DonationInterface and ParserFunctions
[02:11:30] <TimStarling>	 I thought git submodule update was required for that
[02:12:54] <ori-l>	 you can set fetch.recurseSubmodules
[02:13:08] <ori-l>	 in git config
[02:13:41] <TimStarling>	 it says it only updated in the range e89936e..7f5bd40
[02:13:49] <TimStarling>	 and that range doesn't have those submodule updates
[02:15:03] <TimStarling>	 so maybe it was previously updated and the submodule updates somehow weren't done
[02:16:00] <gerrit-wm>	 New patchset: Hoo man; "Refactor AbuseFilterView::canEdit* functions" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[02:16:11] <TimStarling>	 there's nothing about recursion in .git/config
[02:16:33] <TimStarling>	 or in ~/.gitconfig
[02:18:02] <gerrit-wm>	 New review: Shirayuki; "Thanks. You're right." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/72357
[02:18:17] <TimStarling>	 or in .git/modules/extensions/ContributionReporting/config
[02:18:17] <gerrit-wm>	 New review: Hoo man; "Changed so that the AbuseFilterView::canEdit* functions no longer require a User object as parameter..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[02:18:36] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72888
[02:19:02] <TimStarling>	 what are you doing?
[02:19:20] <ori-l>	 i checked /etc/gitconfig
[02:19:59] <TimStarling>	 I mean why are you updating ProofreadPage?
[02:20:02] <TimStarling>	 is this a deployment window?
[02:20:10] <ori-l>	 no, but it's causing fatals in prod
[02:22:15] <ori-l>	 and the fix is straightforward. is that inappropriate?
[02:22:40] <TimStarling>	 it's ok as long as you talk to someone about it
[02:22:56] <TimStarling>	 and as long as you're not even thinking of running scap or anything similar right now
[02:22:59] <ori-l>	 well, it's not entirely credible of me to say so now, but i really was about to
[02:23:09] <ori-l>	 since i saw you were in the process of deploying something
[02:23:25] <ori-l>	 i would have said something regardless.
[02:24:09] <TimStarling>	 I am trying to deploy code which is not even used by web requests or cron jobs
[02:24:33] <TimStarling>	 and I am trying to avoid doing unknown updates to critical extensions in the process
[02:25:19] <ori-l>	 I'll just revert and defer the update to some other time, then
[02:25:34] <TimStarling>	 just leave it for now
[02:25:54] <TimStarling>	 I'm happy to deploy that change as long as I can review the diff
[02:26:14] <ori-l>	 it's https://gerrit.wikimedia.org/r/#/c/72887/
[02:27:09] <ori-l>	 (thanks)
[02:27:34] <TimStarling>	 you shouldn't have self-reviewed that
[02:28:26] <gerrit-wm>	 New patchset: Mwjames; "SMW\ApiAsk + SMW\ApiAskArgs fix bug 51091, add unit tests, and improve code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72889
[02:30:14] <ori-l>	 OK; accepted. Why not, though?
[02:31:47] <ori-l>	 Never mind; I get it.
[02:31:49] <TimStarling>	 you should only self-review when there is some reason for doing so
[02:32:27] <TimStarling>	 e.g. zombie apocalypse, everyone else's brains have turned to mush
[02:32:59] <Elsie>	 That's a repo-dependent rule, though, right?
[02:33:24] <TimStarling>	 sure, for repos that are not going to be deployed to WMF you can do what you like
[02:33:29] <Elsie>	 Self-reviews or self-merges are fairly common in some repos.
[02:33:39] <Elsie>	 Heh, it's the Wikimedia operations repo I was thinking of.
[02:33:45] <ori-l>	 OK, you're right. I thought it was trivial enough but it isn't so trivial that it wouldn't have benefitted from a sanity check from someone else.
[02:33:56] <ori-l>	 And the fatals are being served to bots, so it's not as urgent as all that.
[02:34:19] <ori-l>	 Sorry. What would you like to do about it now? I can either revert the change and seek review or just let it sit.
[02:34:35] <TimStarling>	 I'm going to review it
[02:35:10] <TimStarling>	 actually I had read the git pull output incorrectly, it only fetched those submodules, it didn't check them out
[02:35:38] <gerrit-wm>	 New patchset: Mwjames; "Rename ApiSMWInfo to keep commit history" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72890
[02:38:43] <gerrit-wm>	 New patchset: Mwjames; "Rename ApiSMWInfo to keep commit history" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72890
[02:41:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72890
[02:47:07] <gerrit-wm>	 New patchset: Mwjames; "SMW\ApiAsk + SMW\ApiAskArgs fix bug 51091, add unit tests, and improve code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72889
[02:47:59] <TimStarling>	 ori-l: this is the diff you are pushing out: http://p.defau.lt/?izj8w3QKyBhQoNmTcjI5Sw
[02:48:19] <TimStarling>	 it's not exactly a one-line change
[02:49:45] <ori-l>	 well, it's not exactly not a one-line change, either; the other lines are i18n commits, and we have enough confidence in those to have them merged automatically
[02:51:25] <TimStarling>	 it means it needs to be updated with scap, not sync-file
[02:51:46] <TimStarling>	 so we have to hope that the bugs are fixed this time and that the site won't go down for 40 minutes
[02:54:25] <ori-l>	 I wouldn't have scapped; I would have updated the submodule but only synced ProofreadPage.body.php.
[02:55:15] <ori-l>	 ..as you did
[02:55:37] <TimStarling>	 no, I ran scap, it's in progress
[02:56:22] <TimStarling>	 it's better to do it now, while we are here and know what's going on, than to leave it for the next shift
[02:57:00] <TimStarling>	 you don't want to be in a situation where running scap with no file changes will take the site down, that's a very difficult situation to debug
[02:57:17] <ori-l>	 I know; but (rightly or wrongly) I've special-cased i18n changes in the past.
[03:02:46] <ori-l>	 It isn't as obviously bad as bypassing review, so if you're very serious about it (not deploying i18n updates which do not introduce or remove message keys), please say so, because it doesn't seem especially bad. scapping is really major.
[03:03:16] <TimStarling>	 I am serious about not leaving unscapped changes in /a/common on tin
[03:03:32] <TimStarling>	 do not do that
[03:03:55] <ori-l>	 OK.
[03:09:17] <gerrit-wm>	 New patchset: Mwjames; "SMW\ApiAsk + SMW\ApiAskArgs fix bug 51091, add unit tests, and improve code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72889
[03:11:36] <wmf-selenium-bot>	 Yippie, build fixed!
[03:11:36] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #176: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/176/
[03:26:16] <gerrit-wm>	 New patchset: Mwjames; "SMW\SerializerCompositor divide responsibility [WIP]" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72891
[03:26:52] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #101: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/101/
[03:41:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72886
[03:50:27] <gerrit-wm>	 New patchset: Mattflaschen; "Add support for VisualEditor." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[03:50:48] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:56:44] <gerrit-wm>	 New patchset: Mwjames; "SMW\SerializerCompositor divide responsibility [WIP]" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72891
[03:56:55] <gerrit-wm>	 New review: Mattflaschen; "Updated on toro" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:57:26] <gerrit-wm>	 New review: Mattflaschen; "The update adds conditions to ensure the tours show only on wikitext or VE flows as appropriate." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:58:03] <gerrit-wm>	 New review: Mattflaschen; "Updated on toro to support new showConditionally values for wikitext and VE flows." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[04:57:38] <gerrit-wm>	 New review: Mattflaschen; "Two comments about the create class.  Please move that work to https://gerrit.wikimedia.org/r/#/c/71..." [mediawiki/extensions/Annotator] (master) C: -1;  - https://gerrit.wikimedia.org/r/72360
[05:05:42] <gerrit-wm>	 New review: Mattflaschen; "You're making good progress.  There are some small comments.  Also, as noted at https://gerrit.wikim..." [mediawiki/extensions/Annotator] (master) C: -1;  - https://gerrit.wikimedia.org/r/71364
[05:07:05] <gerrit-wm>	 New review: Mattflaschen; "Oh, also, you should be able to fix the permissions (at least on GNU/Linux), with:" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364
[05:11:33] <gerrit-wm>	 New review: Hiong3-eng5; "Great! It works. Besides the tabs, looks good :)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72263
[05:16:31] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #130: FAILURE in 7 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/130/
[05:23:07] <gerrit-wm>	 New review: Mattflaschen; "Tested locally." [mediawiki/extensions/ConfirmEdit] (master) C: 2;  - https://gerrit.wikimedia.org/r/71102
[05:23:14] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/71102
[05:29:21] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour/guiders] (master) C: -1;  - https://gerrit.wikimedia.org/r/72241
[05:34:45] <gerrit-wm>	 New patchset: Hiong3-eng5; "fixed broken Console due to WikiDataGlobals change" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72894
[05:36:39] <gerrit-wm>	 New patchset: Hiong3-eng5; "fixed broken Console due to WikiDataGlobals change" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72894
[06:03:35] <gerrit-wm>	 New patchset: Alex Monk; "Warn if you try to link to a disambiguation page" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564
[06:45:34] <gerrit-wm>	 New patchset: Alex Monk; "(bug 16214) Create GlobalBlocking API module." [mediawiki/extensions/GlobalBlocking] (master) - https://gerrit.wikimedia.org/r/47539
[06:52:13] <gerrit-wm>	 New patchset: Siebrand; "Basic support for Apache Cocoon i18n format" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/70602
[06:52:14] <gerrit-wm>	 New patchset: Siebrand; "Update 'translate-manage-intro-other'" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/72897
[07:09:29] <gerrit-wm>	 New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896
[07:37:04] <gerrit-wm>	 New review: Ori.livneh; "This change really confuses me. An ideal API for checking if some work should be skipped and then ac..." [mediawiki/extensions/GuidedTour/guiders] (master) C: -1;  - https://gerrit.wikimedia.org/r/72673
[07:37:24] <gerrit-wm>	 New review: Acrida; "Works great!" [mediawiki/extensions/BiblioPlus] (master) C: 1;  - https://gerrit.wikimedia.org/r/72685
[07:44:19] <gerrit-wm>	 New review: Nemo bis; "Mark, after a month situation is unchanged, could you please lift your -2 to allow at least small im..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65649
[07:45:09] <gerrit-wm>	 New patchset: Nemo bis; "(bug 46534) Rename uz File namespace to Fayl" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58687
[07:45:52] <p858snake|l>	 Nemo_bis: you could just push a new PS over top >.>
[07:45:59] <gerrit-wm>	 New patchset: Nemo bis; "Remove unused lqt_rc CSS classes" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/67595
[07:48:53] <Nemo_bis>	 p858snake|l: not worth it, people with +2 right on that repo probably can also delete a -2 if they wish
[07:48:53] <hashar>	 hello
[07:48:58] <Nemo_bis>	 hi
[07:57:10] <gerrit-wm>	 New patchset: Nemo bis; "Threads moved to a watched page don't trigger notif." [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/58285
[09:00:15] <gerrit-wm>	 New review: Physikerwelt; "Maybe we could formulate a task... so that I know what I have" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[09:00:20] <gerrit-wm>	 Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72719
[09:12:10] <gerrit-wm>	 New patchset: Nilesh; "Naive version of wikiparser scripts now working well; assigns no relative weights to data points" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72901
[09:12:10] <gerrit-wm>	 New patchset: Nilesh; "Added mysql connector/j maven dependency" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72902
[09:31:24] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72457
[09:32:01] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72626
[09:34:19] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72627
[09:35:36] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72901
[09:39:29] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72902
[09:57:19] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Update readme file" [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/72914
[09:57:31] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/72914
[10:05:08] <gerrit-wm>	 New patchset: Ori.livneh; "Notify user if fresh upstream commits are available" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72915
[10:13:57] <gerrit-wm>	 New review: Ori.livneh; "This could get obnoxious. If you're an end-user and found the behavior sufficiently annoying to trac..." [mediawiki/vagrant] (master) C: 2;  - https://gerrit.wikimedia.org/r/72915
[10:14:00] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72915
[10:16:09] <gerrit-wm>	 New patchset: Nilesh; "Added custom IDMigrator classes to fix REST API problems with negative IDs" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72917
[10:17:20] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72917
[10:27:26] <gerrit-wm>	 New patchset: Siebrand; "Update 'translate-manage-intro-other'" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/72897
[10:28:05] <gerrit-wm>	 New review: Siebrand; "+2 per Raimond, with dependency on an unmerged change removed." [mediawiki/extensions/Translate] (master) C: 2;  - https://gerrit.wikimedia.org/r/72897
[10:28:58] <gerrit-wm>	 New patchset: Nilesh; "Refactored java package structure" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72922
[10:29:33] <gerrit-wm>	 New patchset: Matmarex; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[10:29:33] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/72897
[10:35:58] <gerrit-wm>	 Change merged: Nilesh; [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72922
[10:39:01] <gerrit-wm>	 New patchset: Matmarex; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[10:39:30] <gerrit-wm>	 New patchset: Ori.livneh; "Typo fix in misc/manifests/init.pp" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72924
[10:43:07] <gerrit-wm>	 New patchset: Matmarex; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[10:46:38] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72924
[11:34:06] <gerrit-wm>	 New review: Kipcool; "Will solve LCASE => LOWER later" [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72262
[11:34:06] <gerrit-wm>	 Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72262
[11:36:02] <gerrit-wm>	 Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72263
[11:36:39] <gerrit-wm>	 Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/72894
[11:44:55] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72833
[11:46:17] <gerrit-wm>	 New patchset: Hashar; "mw-ext-LinkedWiki jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72333
[11:46:20] <gerrit-wm>	 New patchset: Hashar; "mw-ext-LinkedWiki jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72333
[11:48:54] <gerrit-wm>	 New patchset: Hashar; "triggers for mw/ext/LinkedWiki" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72930
[11:49:10] <gerrit-wm>	 New review: Hashar; "Jobs generated" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72333
[11:49:23] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72333
[11:49:44] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72930
[11:50:38] <gerrit-wm>	 New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/LinkedWiki] (master) - https://gerrit.wikimedia.org/r/72931
[11:55:45] <hoo>	 cd
[11:55:50] <hoo>	 woops
[12:03:05] <gerrit-wm>	 New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933
[12:09:29] <gerrit-wm>	 New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933
[12:18:05] <gerrit-wm>	 New patchset: Rtdwivedi; "Addition of code that will be used for setting up of editing system in PHP instead of JS." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72933
[13:03:26] <se4598_2>	 mlitn: Hi, as far as i see your account is the only one who got his sysop rights removed (but dunno by whom, can't find it in the local or meta logs)
[13:08:36] <se4598_2>	 mlitn: Also it's a bit strange that I can't find them (the Aft5) in the sysop list <https://de.wikipedia.org/w/index.php?title=Spezial:Benutzer&offset=&limit=500&username=&group=sysop> but in the single user list with sysop <https://de.wikipedia.org/w/index.php?title=Spezial%3ABenutzer&username=Aft5hide&group=&limit=1>
[13:12:41] <gerrit-wm>	 New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621
[13:22:13] <gerrit-wm>	 New patchset: Matmarex; "jquery.suggestions: Use document width instead of <body> width for position calculation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72937
[13:24:04] <hexmode>	 lost all my .git files because I trusted a gnome app to back stuff up
[13:24:18] <hexmode>	 man... re-cloning takes a long time
[13:25:46] <mlitn>	 se4598_2: can you check again now?
[13:27:41] <Nemo_bis>	 mlitn: how have you removed the flag?
[13:28:20] <mlitn>	 Special:UserRights
[13:29:11] <Nemo_bis>	 that's not so correct, sysop flag is removed from Meta
[13:29:30] <se4598_2>	 mlitn: Aft5monitor, Aft5hide, Fabrice Florin (WMF) ok, but Mlitn has now "userrights" on dewiki
[13:30:16] <se4598_2>	 don't know that this group exists O.o
[13:30:21] <Nemo_bis>	 me neither
[13:30:38] <Nemo_bis>	 I thought he was in Staff group
[13:31:49] <hoo>	 Nemo_bis: He's not... he probably just database cheated the rights...
[13:32:39] <Nemo_bis>	 he said the contrary just above
[13:32:42] <mlitn>	 Nemo_bis: I had initially removed the userrights from DB (left no log entries), so then re-did it via Special:UserRights
[13:32:51] <Nemo_bis>	 ah
[13:33:04] <mlitn>	 so how should I actually do that from meta ^^?
[13:33:14] <gerrit-wm>	 New patchset: MaxSem; "Update GeoData to master tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72941
[13:33:23] <Nemo_bis>	 asking someone with userrights-interwiki permission to do it
[13:33:27] <se4598_2>	 that could explan the mismatch between the two lists (on the same special page?)
[13:33:33] <Nemo_bis>	 usually a steward, or someone in global Staff group
[13:33:46] <Nemo_bis>	 https://toolserver.org/~pathoschild/globalgroups/
[13:33:56] <se4598_2>	 mlitn: or https://meta.wikimedia.org/wiki/Steward_requests/Permissions
[13:34:08] <mlitn>	 ok great, thanks :)
[13:34:46] <Nemo_bis>	 hm, pathos' tool seems to be truncating something
[13:35:53] <Nemo_bis>	 is userrights-interwiki implied by userrights?
[13:36:16] <Nemo_bis>	 https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions/steward
[13:36:20] <hoo>	 Nemo_bis: not that I know of
[13:36:21] <Nemo_bis>	 sigh, I'm getting confused :)
[13:47:55] <gerrit-wm>	 New patchset: Aude; "whitelist Wikidata GSOC students" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72945
[13:50:41] <gerrit-wm>	 New patchset: Hashar; "triggers for mw/ext/timeline" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72946
[13:50:51] <Nikerabbit>	 YuviPanda: hmm you there?
[13:51:01] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72946
[13:51:14] <YuviPanda>	 Nikerabbit: sortof. leaving in a bit. emailed y'day about not being there for today's meeting
[13:51:46] <Nikerabbit>	 YuviPanda: that's okay, do you remember what time it is?
[13:51:57] <YuviPanda>	 in 40 minutes
[13:52:09] <Nikerabbit>	 YuviPanda: ah great
[13:52:14] <YuviPanda>	 :)
[13:54:17] <Nikerabbit>	 YuviPanda: oh I only now noticed the email
[13:54:38] <YuviPanda>	 Nikerabbit: tch tch
[13:54:54] <gerrit-wm>	 New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/72948
[13:56:18] <Nikerabbit>	 YuviPanda: from or to me I mean
[13:56:37] <YuviPanda>	 Nikerabbit: ?
[13:56:41] <YuviPanda>	 i... am confused?
[13:56:48] <Nikerabbit>	 YuviPanda: yes you ddidn't get the email
[13:56:57] <YuviPanda>	 oh you sent one?
[13:57:20] <se4598_2>	 Nemo_bis: The log is crap: Thats in the rights log: 15:22, 10 July 2013 Mlitn (Talk (A) | contribs) changed group membership for Benutzer:Mlitn from confirmed user and administrator to confirmed user
[13:57:42] <se4598_2>	 Nemo_bis And thats on my watchlist: 	15:22 . . Mlitn (Talk (A) | contribs) changed group membership for Benutzer:Mlitn from confirmed user, steward, administrator and userrights to confirmed user and userrights ‎
[13:58:05] <Nemo_bis>	 se4598_2: normal log view doesn't show global rights
[13:58:53] <Nemo_bis>	 no, that's not the point
[13:59:04] <gerrit-wm>	 New review: Hashar; "recheck" [mediawiki/extensions/timeline] (master) - https://gerrit.wikimedia.org/r/72948
[14:00:32] <Nemo_bis>	 probably watchlist just dumps whatever DB contains while log only allows proper content
[14:00:44] <mlitn>	 se4598_2: Nemo_bis: that's because I had to do it rather hacky; (via DB) first give myself steward permissions to be able to remove my own sysop permissions via Special:UserRights. After that, I removed that steward permissions again & updated to log to make it no longer say I'm steward
[14:00:46] <Nemo_bis>	 which doesn't include rights changed via shell
[14:00:56] <Nemo_bis>	 yes :)
[14:06:20] <se4598_2>	 yep, thats hacky :) still in general not so elegant from user's point of view that the entries differ
[14:06:44] <gerrit-wm>	 New patchset: Hashar; "perlint job and jobs for timeline extension" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72951
[15:14:45] <gerrit-wm>	 New review: J; "Since I made many changes in the updated patch, It would be good for someone else to review it befor..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243
[15:16:25] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Serialization] (master) - https://gerrit.wikimedia.org/r/72964
[15:23:24] <gerrit-wm>	 New patchset: MarkAHershberger; "* Includes the latest extensions. * Add a cleaner way to generate the per-version extensions. * Make it possible to add other extensions as for the Semantic Bundle. * Make diff creation a little smaller by excluding whitespace differences." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/72966
[15:24:11] <gerrit-wm>	 New review: Matmarex; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/40329
[15:24:44] <MatmaRex_>	 Dereckson: ^
[15:27:28] <gerrit-wm>	 New patchset: Amire80; "Update jquery.webfonts from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72967
[15:28:44] <gerrit-wm>	 New review: Anomie; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: 1;  - https://gerrit.wikimedia.org/r/72724
[15:33:28] <gerrit-wm>	 New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[15:33:51] <gerrit-wm>	 New review: Anomie; "Seems simple enough." [mediawiki/extensions/AbuseFilter] (master) C: 2;  - https://gerrit.wikimedia.org/r/72883
[15:33:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72883
[15:34:18] <gerrit-wm>	 New patchset: Hoo man; "Refactor AbuseFilterView::canEdit* functions" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[15:34:58] <gerrit-wm>	 New review: Hoo man; "Make use of User::isAllowedAny" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[15:44:25] <gerrit-wm>	 New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/UrlGetParameters] (master) C: -1;  - https://gerrit.wikimedia.org/r/25734
[15:45:04] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72967
[15:58:42] <gerrit-wm>	 New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364
[16:20:55] <gerrit-wm>	 New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[16:26:53] <gerrit-wm>	 New patchset: J; "use distinct variables for memckey and transcode key" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/72976
[16:34:40] <gerrit-wm>	 New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[16:39:28] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72765
[16:40:42] <liangent>	 petan: the bot died again?
[16:49:55] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/72976
[16:50:17] <gerrit-wm>	 New patchset: Zfilipin; "Fixed "uninitialized constant" error message" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72977
[16:54:33] <gerrit-wm>	 New patchset: Yaron Koren; "New version: 2.5.3" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72978
[16:55:12] <gerrit-wm>	 New review: CSteipp; "Looks good overall to me. Are we going to start producing smw tarballs?" [mediawiki/tools/release] (master) C: 1;  - https://gerrit.wikimedia.org/r/72966
[16:55:33] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72978
[16:59:40] <gerrit-wm>	 New review: CSteipp; "As requested by MF-W. Thanks!" [mediawiki/extensions/AbuseFilter] (master) C: 2;  - https://gerrit.wikimedia.org/r/72813
[16:59:50] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72813
[17:01:26] <gerrit-wm>	 New patchset: Matthias Mullie; "Improve oversight request email" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72979
[17:01:26] <hoo>	 \o/
[17:07:54] <gerrit-wm>	 New review: CSteipp; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72856
[17:08:08] <gerrit-wm>	 New patchset: Cscott; "Fix incorrect escaping of nested <em>, <strong>, <q>, <ruby>, and <bdo>" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72981
[17:11:18] <gerrit-wm>	 New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72856
[17:11:49] <hoo>	 csteipp: I would really like to have that in the deploy... filtering for global filters has been asked for a few times
[17:12:02] <hoo>	 and the API should do that 100% equally to the special page
[17:16:46] <gerrit-wm>	 New review: CSteipp; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72856
[17:17:16] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72856
[17:18:02] <hoo>	 :)
[17:18:05] <gerrit-wm>	 New patchset: Matmarex; "Show small explanation next to lists of tags" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72984
[17:19:02] <gerrit-wm>	 New review: Matmarex; "Addressed Krinkle's comments in dependent patchset https://gerrit.wikimedia.org/r/72984 . (Should I ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72317
[17:26:03] <OrenBochman>	 anyone know d3,js ?
[17:26:54] <sumanah>	 OrenBochman: I think Dan Andreescu in #wikimedia-analytics is good at those
[17:27:26] <OrenBochman>	 thanks
[17:27:35] <gerrit-wm>	 New patchset: Yuvipanda; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835
[17:29:06] <gerrit-wm>	 New review: MarkAHershberger; "for now the smw bundle is more of a proof of concept.  I've talked a little with the SMW devs about ..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/72966
[17:41:22] <gerrit-wm>	 New patchset: SuchABot; "Enable use of wikitext in field labels" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[17:49:43] <gerrit-wm>	 New review: Brion VIBBER; "A few inline notes. Some old field names still remain, schema isn't fully updated, and there's some ..." [mediawiki/extensions/UploadWizard] (master) C: -1;  - https://gerrit.wikimedia.org/r/72869
[17:51:24] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[17:53:53] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[17:54:55] <gerrit-wm>	 New review: Yuvipanda; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[17:55:47] <gerrit-wm>	 New patchset: Aaron Schulz; "Added Special:MWOAuthManageMyGrants page" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990
[17:56:29] <gerrit-wm>	 New review: Krinkle; "Though it is may not be listed in api.php documentation, I would consider this to some degree a brea..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72886
[17:58:47] <OrenBochman>	 sumanah: do you know if mike rubio is on irc ?
[17:59:08] <gerrit-wm>	 New patchset: Amire80; "Update from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72992
[18:00:09] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72992
[18:00:36] <sumanah>	 OrenBochman: sorry, I do not know
[18:04:41] <gerrit-wm>	 New patchset: SuchABot; "Enable use of wikitext in field labels" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[18:04:47] <gerrit-wm>	 New patchset: Kaldari; "Exclude redirects from Special:DisambiguationPageLinks" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/72995
[18:06:19] <gerrit-wm>	 New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[18:15:47] <Reedy>	 http://blog.jetbrains.com/phpstorm/2013/07/phpstorm-7-early-access-program-started/
[18:15:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[18:15:56] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72998
[18:17:35] <mooeypoo>	 sumanah: heyhey you happen to be around?
[18:17:43] <sumanah>	 mooeypoo: I do, gimme 3 min
[18:20:50] <wmf-selenium-bot>	 Yippie, build fixed!
[18:20:50] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #102: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/102/
[18:21:27] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73001
[18:21:52] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72998
[18:22:12] <gerrit-wm>	 New review: Brion VIBBER; "Seems to work in my testing. :)" [mediawiki/extensions/UploadWizard] (master) C: 1;  - https://gerrit.wikimedia.org/r/72869
[18:25:19] <wmf-selenium-bot>	 Yippie, build fixed!
[18:25:20] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #102: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/102/
[18:26:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73001
[18:28:08] <gerrit-wm>	 New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master) C: 2;  - https://gerrit.wikimedia.org/r/72990
[18:28:13] <sumanah>	 hi mooeypoo!
[18:30:32] <gerrit-wm>	 New patchset: Aaron Schulz; "Added Special:MWOAuthManageMyGrants page" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990
[18:30:45] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #140: FAILURE in 9 min 55 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/140/
[18:31:40] <sumanah>	 mooeypoo: back in a few min.
[18:32:29] <mooeypoo>	 sumanah: no worries, solved my issue
[18:32:51] <gerrit-wm>	 New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360
[18:35:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/71117
[18:36:46] <sumanah>	 mooeypoo: great :D
[18:42:52] <wmf-selenium-bot>	 Yippie, build fixed!
[18:42:52] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #151: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/151/
[18:56:31] <gerrit-wm>	 New patchset: Kaldari; "Optimizing Special:DisambiguationPages query to avoid filesort" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/73008
[18:59:38] <gerrit-wm>	 New patchset: Kaldari; "Optimizing Special:DisambiguationPages query to avoid filesort" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/73008
[19:01:19] <gerrit-wm>	 New review: Matmarex; "Nitpicks. Fix them and I'll merge with clean conscience ;)" [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72841
[19:07:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72317
[19:08:47] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72984
[19:09:15] <gerrit-wm>	 New patchset: MarkTraceur; "Adding DonationInterface test runner" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71727
[19:13:03] <gerrit-wm>	 New patchset: Matmarex; "Release notes for Ic2ae58c7, If21eaed4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73011
[19:13:13] <gerrit-wm>	 New patchset: Adamw; "force renewal of stomp connection before dequeuing." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73012
[19:13:16] <gerrit-wm>	 New review: Matmarex; "Release notes: https://gerrit.wikimedia.org/r/73011" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72317
[19:13:20] <gerrit-wm>	 New review: Matmarex; "Release notes: https://gerrit.wikimedia.org/r/73011" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72984
[19:15:29] <gerrit-wm>	 New review: Katie Horn; "...yep. That'll totally do it." [wikimedia/fundraising/crm] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/73012
[19:15:29] <gerrit-wm>	 Change merged: Katie Horn; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73012
[19:15:34] <gerrit-wm>	 New patchset: Matmarex; "Release notes for Ic2ae58c7, If21eaed4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73011
[19:17:16] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[19:17:31] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[19:17:56] <marktraceur>	 Oh excellent.
[19:18:18] <gerrit-wm>	 New patchset: MarkTraceur; "Revert "Dummy commit for Jenkins to trip on"" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73013
[19:18:43] <marktraceur>	 Effing Jenkins.
[19:18:43] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73013
[19:34:08] <gerrit-wm>	 New patchset: Umherirrender; "Add "(No differences)" on a empty diff" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014
[19:35:54] <gerrit-wm>	 New review: Matmarex; "Qqq please. :)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/73014
[19:43:17] <gerrit-wm>	 New review: Brion VIBBER; "+2 per marktraceur per YuviPanda" [mediawiki/extensions/UploadWizard] (master) C: 2;  - https://gerrit.wikimedia.org/r/72869
[19:43:24] <YuviPanda>	 woo
[19:43:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[19:43:51] <brion>	 UGH the webchat on freenode sucks. my regular client isn't connecting from the office
[19:47:03] <gerrit-wm>	 New patchset: SuchABot; "Remove unused code" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/73016
[19:50:47] <gerrit-wm>	 New patchset: Umherirrender; "Add "(No differences)" on a empty diff" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014
[19:51:15] <gerrit-wm>	 New review: Umherirrender; "Patch set 2: Added qqq" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73014
[19:51:23] <gerrit-wm>	 New review: Brion VIBBER; "wfm" [mediawiki/extensions/UploadWizard] (master) C: 2;  - https://gerrit.wikimedia.org/r/73016
[19:51:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/73016
[19:52:35] <gerrit-wm>	 New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017
[19:54:23] <gerrit-wm>	 Change merged: Jforrester; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73011
[19:56:11] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-chrome build #178: FAILURE in 4 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/178/
[19:56:31] <James_F>	 MatmaRex_: ^^^ Merged your release notes.
[19:56:40] <MatmaRex_>	 James_F: thanks
[19:56:48] <James_F>	 MatmaRex_: No problem. :-)
[19:57:12] <James_F>	 MatmaRex_: Of course, changes in VE that depend on wmf10 being deployed everywhere make me sad. :-(
[19:58:14] <mutante>	 MaxSem: re. m.wikimediafoundation. that change would make it 301 Moved Permanently http://en.wikipedia.org/
[19:58:35] <MatmaRex_>	 James_F: meh, i wouldn't say that depends on those core changes. they're just good-to-haves
[19:58:42] <MaxSem>	 o_0
[19:59:02] <James_F>	 MatmaRex_: Removing "Tag:" before the core change arrives to put it back in would be bad.
[19:59:06] <MatmaRex_>	 James_F: or you could backport those :)
[19:59:16] <mutante>	 MaxSem: because:
[19:59:18] <James_F>	 MatmaRex_: Yeah, but… eh.
[19:59:19] <MatmaRex_>	 James_F: the en.wp tags are inconsistent anyway
[19:59:25] <mutante>	 MaxSem:  # Send anything else that matched the ServerAlias to en.wikipedia.org
[19:59:26] <MatmaRex_>	 probably no one would notice that :P
[19:59:28] <James_F>	 MatmaRex_: I've got enough for Roan to work on without that too.:-)
[19:59:36] <MaxSem>	 ugh
[20:00:23] <MaxSem>	 mmm, then regex fun with lookbehinds, mutante?
[20:01:11] <mutante>	 MaxSem: in DNS. m.wikimediafoundation.org is  CNAME  m.wikimedia.org
[20:01:30] <MaxSem>	 :facepalm:
[20:01:34] <mutante>	 MaxSem: what is the goal? what should it do
[20:02:01] <MaxSem>	 mutante, same stuff as other mobile subdomains, eg m.mediawiki.org
[20:04:39] <gerrit-wm>	 New review: Krinkle; "I didn't verify this instant, but I recall something (at least in VE) where we assume an empty strin..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/73014
[20:10:26] <gerrit-wm>	 New patchset: Jforrester; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[20:14:38] <wmf-selenium-bot>	 Yippie, build fixed!
[20:14:39] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #143: FIXED in 6 min 11 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/143/
[20:17:12] <mutante>	 MaxSem: seems to me it's a change in mobile-frontend.inc.vcl.erb then. if (req.http.host == "m.mediawiki.org") {  ..  both m.mediawiki and m.wikimediafoundation are m.wikimedia.org
[20:17:12] <mutante>	 and wikimediafoundation doesn't appear in the frontend template. mediawiki does
[20:18:21] <MaxSem>	 mutante, at least the current redirect from m.wmf.org is served by apache
[20:19:12] <gerrit-wm>	 New patchset: Rahul21; "Pronunciation Recording Tool" [mediawiki/extensions/PronunciationRecording] (master) - https://gerrit.wikimedia.org/r/73017
[20:19:58] <marktraceur>	 Krinkle: So, Jenkins/Zuul question. I want to make sure a new jenkins job catches failures, but it's set to nonvoting because it doesn't work yet...how would you test this without causing Jenkins to fail patches in the meantime?
[20:20:37] <wmf-selenium-bot>	 Yippie, build fixed!
[20:20:37] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #131: FIXED in 7 min 52 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/131/
[20:22:05] <MaxSem>	 mutante, oh -got what you mean
[20:23:33] <gerrit-wm>	 New patchset: SuchABot; "Make thumbnails load faster by loading smaller Thumbnails" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73021
[20:24:17] <gerrit-wm>	 New review: Anomie; "Oh, I guess we don't have Jenkins on this extension yet?" [mediawiki/extensions/Disambiguator] (master); V: 2 - https://gerrit.wikimedia.org/r/73008
[20:24:26] <gerrit-wm>	 Change merged: Anomie; [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/73008
[20:25:01] <gerrit-wm>	 New review: Krinkle; ":O" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/73008
[20:25:42] <gerrit-wm>	 New patchset: Reedy; "Clean-up: delete modifications for old Bugzilla versions" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62315
[20:26:14] <gerrit-wm>	 New patchset: Matmarex; "Make the table on Special:Tags sortable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73023
[20:27:24] <gerrit-wm>	 New review: Reedy; "Done. Are we ok to merge this before it needs re-doing again? ;)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62315
[20:30:35] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73023
[20:33:35] <Krinkle>	 MatmaRex_: I recall recent changes to the table sorter but either I forgot or we made a mistake in it no longer detecting numbers from strings
[20:33:49] <Krinkle>	 (loaded tablesorter on Special:tags from console) -> http://cl.ly/image/0v422v1t2x2D
[20:34:06] <Krinkle>	 6,000 , 512, 4,500, 16,000
[20:34:12] <Krinkle>	 that's not good
[20:34:52] <MatmaRex_>	 Krinkle: hm, maybe the " changes" part is throwing it off?
[20:35:11] <MatmaRex_>	 there's a bug report about "natural sorting" i made like, last year
[20:35:58] <gerrit-wm>	 New review: Anomie; "Straightforward enough, and the query isn't any more ugly than it was already." [mediawiki/extensions/Disambiguator] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72995
[20:35:58] <gerrit-wm>	 Change merged: Anomie; [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/72995
[20:36:07] <MatmaRex_>	 or wgSeparatorTransformTable is somehow wrong for English
[20:36:22] <Krinkle>	 MatmaRex_: in addition to natural sorting it also needs to account for formatnum ( . / ,) and apply it only to the first word
[20:36:53] <MatmaRex_>	 Krinkle: it currently understands formatnum thanks to wgSeparatorTransformTable, i think
[20:36:57] <Krinkle>	 or alternatively, have it undo formatnum and then just parseFloat. it has built-in support to stop looking after the first non-numerical character
[20:37:35] <Krinkle>	 anomie: Populating jenkins-job-builder steps for Disambiguator now
[20:37:47] <anomie>	 Krinkle: Great, thanks
[20:37:49] <MatmaRex_>	 maybe i'll add data-sort-value to that table?
[20:37:57] <Krinkle>	 we shouldn't be merging things without even knowing whether basic php syntax lints
[20:38:22] <Krinkle>	 MatmaRex_: That's not a solution imho, this should be covered in core, e.g. regular tables in articles will have this
[20:38:42] <anomie>	 I figure the syntax lints for the two I just merged since the changes were so simple to completely test locally
[20:39:21] <MatmaRex_>	 Krinkle: yeah, but i won't be implementing that natural sorting thing this week :P
[20:40:43] <Krinkle>	 MatmaRex_: natural sort is for things like a10 after a9. This shouldn't be covered by that (and probably wouldn't even fix this)
[20:41:18] <Krinkle>	 I'll check later this week to ensure this isn't a regression
[20:41:29] <Krinkle>	 either way we should try to get it done before 1.22 release
[20:41:45] <MatmaRex_>	 well, i respectfully disagree :) it would fix this as well if done right
[20:41:52] <MatmaRex_>	 or actually, if not done extremely wrong, really
[20:42:29] <Krinkle>	 how so? should natural sort also understand locale/formatnum?
[20:42:39] <MatmaRex_>	 yes?
[20:42:49] <Krinkle>	 this is just plain sorting of numbers post-normalisation for locale
[20:43:59] <Krinkle>	 if the implied sort type is number instead of string, natsort won't run
[20:44:05] <Krinkle>	 shouldn't I guess, right?
[20:44:25] <Krinkle>	 Though I suppose we could merge string/numer sorting in favour of just natsort
[20:45:01] <gerrit-wm>	 New patchset: SuchABot; "Make thumbnails load faster by loading smaller Thumbnails" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73021
[20:45:01] <GorillaWarfare>	 mwalkerz: You around?
[20:45:25] <mwalkerz>	 yep yep
[20:45:42] <MatmaRex_>	 Krinkle: i debugged this and tablesorter doesn't detect that column as a numeric one
[20:45:43] <GorillaWarfare>	 I'm about to commit a patch to use local image files for the navbar icons, instead of URLs
[20:45:57] <Krinkle>	 MatmaRex_: obviously
[20:45:59] <MatmaRex_>	 yes, "normal" sorting should go
[20:46:04] <GorillaWarfare>	 But I want to make sure the license for the images is clear... what's the best way of doing that?
[20:46:08] <MatmaRex_>	 then i don't see what is the issue?
[20:46:10] <GorillaWarfare>	 marktraceur said you'd know ;)
[20:46:24] <MatmaRex_>	 tablesorter already handles formatnum
[20:46:30] <MatmaRex_>	 both for separator transforms and digit transforms
[20:46:43] <MatmaRex_>	 i don't see how it would be notable harder to do in a natural sort
[20:46:50] <MatmaRex_>	 notably*
[20:46:55] <Krinkle>	 MatmaRex_: but only on fields that contain only numbers? (sans the separators) or only on fields in columns that are in entirety number only?
[20:47:10] <MatmaRex_>	 Krinkle: /^([-+−]?[0-9][0-9,]*(\.[0-9,]*)?(E[-+−]?[0-9][0-9,]*)?|[-+−]?[0123456789,.]+[\s\xa0]*%?)$/i
[20:47:21] <MatmaRex_>	 that regex is dynamically generated based on the transforms
[20:47:27] <Krinkle>	 I mean, is that the reason it doesn't consider "6,123 changes" a number field
[20:47:33] <MatmaRex_>	 that regex is the reason
[20:47:37] <MatmaRex_>	 it has a $
[20:47:40] <MatmaRex_>	 so it doesn;t match. :)
[20:47:54] <mwalkerz>	 GorillaWarfare: there really isn't a good method right now... eventually we will register resources in PHP that Special:Version can pick up, but it's not quite ready. However; if you put it into a LICENSE or COPYING file legally our bases are mostly covered
[20:48:01] <MatmaRex_>	 so yes, it only numeric-sorts number-only columns
[20:48:17] <Krinkle>	 makes sense I guess, if two fields contain the same number + some text you'll want to have the string for decision making beyond just the parsed number
[20:48:33] <GorillaWarfare>	 mwalkerz: Okay. Nitpicky, but mention it in a LICENSE/COPYING file in the main extension directory, or in the images subdirectory?
[20:48:38] <marktraceur>	 That wasn't nearly as complicated or amusing as I thought it would be
[20:48:46] <mwalkerz>	 GorillaWarfare: main extension directory
[20:48:49] <GorillaWarfare>	 marktraceur: Sorry to disappoint :P
[20:48:53] <Krinkle>	 as a tie breaker, and would be picked up by natural sort as long as natural sort is given the string value sans locale separators
[20:48:55] <GorillaWarfare>	 mwalkerz: Alright, sounds good :)
[20:49:03] <Krinkle>	 which right now we only do for number columns
[20:49:10] <Krinkle>	 alrighty, sounds good
[20:49:22] <MatmaRex_>	 yeeees. i think.
[20:49:32] <MatmaRex_>	 i'll ping you when i implement it. ;)
[20:49:32] <Krinkle>	 as a quick fix we could apply the separator-undo/normalisation to all fields unconditionally
[20:49:47] <Krinkle>	 so that it sorts as "6123 changes" using regular string sort
[20:49:51] <Krinkle>	 meh, that wouldn't change a thign
[20:50:34] <gerrit-wm>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[20:53:56] <gerrit-wm>	 New patchset: Reedy; "Update VE to master" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/73031
[20:54:33] <marktraceur>	 Krinkle: Any thoughts re: Jenkins?
[20:54:40] <gerrit-wm>	 Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/73031
[20:54:59] <Krinkle>	 marktraceur: what?
[20:55:05] <marktraceur>	 ...
[20:55:25] <marktraceur>	 2013-07-10 - 13:18:57  <marktraceur> Krinkle: So, Jenkins/Zuul question. I want to make sure a new jenkins job catches failures, but it's set to nonvoting because it doesn't work yet...how would you test this without causing Jenkins to fail patches in the meantime?
[20:56:16] <Krinkle>	 marktraceur: would creating and pushing it as non-voting not work for you in that case?
[20:56:23] <Krinkle>	 (and activate it in zuul)
[20:56:43] <marktraceur>	 Krinkle: No, because if I push a test change that breaks the tests, I don't want Jenkins to merge it, which it would if the tests are non-voting
[20:57:06] <marktraceur>	 Krinkle: See https://gerrit.wikimedia.org/r/#/c/73013/
[20:57:36] <Krinkle>	 wait, so you have a job that doesn't work and you don't want it to hold back merge, but when it fails (how?) you do want it to do exactly that?
[20:59:39] <mutante>	 brion: -mquin(~mquin@freenode/staff/mquin)- [Global Notice] Services are now back but may be lagged for a little while ..
[21:00:49] <marktraceur>	 Krinkle: For specific commits, yeah.
[21:01:08] <marktraceur>	 Maybe this doesn't make sense and I need to think up a different method.
[21:01:22] <Krinkle>	 marktraceur: Ah, for specific commits? You mean test-test commits to see if it works, before enabling. Not real commits, right?
[21:01:30] <marktraceur>	 Something like that, yeah.
[21:01:47] <Krinkle>	 Well, in that case you just enable it with non-voting and look at the jenkins job yourself
[21:02:06] <marktraceur>	 Krinkle: But if it's not voting, and the other tests pass, it merges the commit.
[21:02:07] <Krinkle>	 before you do CR+2, of course
[21:02:19] <marktraceur>	 It doesn't run without +2...
[21:02:27] <marktraceur>	 Maybe there needs to be another pipeline
[21:02:37] <Krinkle>	 Then you need to submit it from an account that is allowed to run the test pipeline
[21:02:44] <Krinkle>	 (gerrit account, the author that submits the patch)
[21:02:54] <Krinkle>	 like we do in core and virtually anywhere else the stuff is set up correctly
[21:03:01] <marktraceur>	 "Correctly"
[21:03:08] <marktraceur>	 Krinkle: I'll try to figure out what I did wrong
[21:03:25] <Krinkle>	 I don't know of any repo atm where the "real" tests only run on gate. that's wrong. They should run for every patch set.
[21:03:36] <Krinkle>	 contents of "test" pipeline should be equal 1:1 to gate-and-submit
[21:03:50] <marktraceur>	 Krinkle: I just wrote the pipeline for DonationInterface, so I probably just cocked it up
[21:04:02] <Krinkle>	 and "check" pipeline must only contain a subset of that that is safe to run for untrusted code (e.g. static linting etc.)
[21:04:28] <Krinkle>	 yeah, sounds like you might have a "check"-pipeline and "gate-and-submit" pieline without a test pieline
[21:04:39] <Krinkle>	 pipeline*
[21:05:03] <marktraceur>	 Sounds correct
[21:05:05] * marktraceur  fixes

[21:06:08] <gerrit-wm>	 New patchset: MarkTraceur; "Add 'test' pipeline for DI." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:06:20] <marktraceur>	 Which means I get to deploy to gallium again, woo
[21:07:06] <Krinkle>	 outdated copy mr :)
[21:07:25] <gerrit-wm>	 New patchset: Anomie; "API: Allow extensions to specify "useless" query pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73034
[21:07:26] <gerrit-wm>	 New patchset: Anomie; "Mark DisambiguationPages as "useless" for the API" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/73035
[21:07:40] <gerrit-wm>	 New review: Krinkle; "Change 'check-only' to 'check', don't run both." [integration/zuul-config] (master) C: -1;  - https://gerrit.wikimedia.org/r/73033
[21:07:47] <gerrit-wm>	 New patchset: Krinkle; "Add 'test' pipeline for DI." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:07:52] <gerrit-wm>	 New patchset: Cmcmahon; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[21:08:11] <Krinkle>	 (did a automated rebase)
[21:08:24] <gerrit-wm>	 New review: Brion VIBBER; "Seems to do what we want. :)" [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/73021
[21:08:24] <gerrit-wm>	 Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73021
[21:08:24] <Krinkle>	 (since the repo is fast-forward only)
[21:08:26] <marktraceur>	 Krinkle: check-only got copied from AbuseFilter, I think
[21:08:41] <brion>	 \o/
[21:09:28] <gerrit-wm>	 New patchset: MarkTraceur; "Add 'test' pipeline for DI." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:09:32] <marktraceur>	 Fixed though
[21:09:35] <marktraceur>	 Krinkle: ^^
[21:09:38] <Krinkle>	 readthemanual :) Zuul is very fragile in that it doesn't ever complain about anything (other than syntax errors), if we could we would make it scream and jump up and down if a project has > 1 pipeline and one of them is check-only.
[21:09:58] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/UrlGetParameters] (master) - https://gerrit.wikimedia.org/r/25734
[21:09:59] <Krinkle>	 the doc on top for the pipeline should mention this roughly
[21:10:11] <Krinkle>	 ('check' vs. 'check-only')
[21:10:15] <marktraceur>	 Hm.
[21:10:28] <Krinkle>	 lgtm.
[21:10:51] <gerrit-wm>	 New patchset: Krinkle; "Add 'test' pipeline for DonationInterface" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:11:02] <gerrit-wm>	 New review: Krinkle; "(removed dot from commit title)." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:11:26] <marktraceur>	 Aw, dot.
[21:11:57] <Krinkle>	 title/sentence
[21:13:05] <gerrit-wm>	 New review: Anomie; "\o/" [mediawiki/extensions/CentralAuth] (master) C: 2;  - https://gerrit.wikimedia.org/r/72657
[21:13:13] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[21:13:47] <marktraceur>	 Krinkle: Does it um...does it merge automatically?
[21:14:21] <Krinkle>	 yes
[21:14:26] <gerrit-wm>	 New review: CSteipp; "Minor stuff" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990
[21:14:42] * marktraceur  waits

[21:14:49] <Krinkle>	 you need to CR+2
[21:15:00] <Krinkle>	 patch has been revised and cancelled the pipeline, twice
[21:15:07] <marktraceur>	 Oh, thought you did
[21:15:14] <Krinkle>	 nope
[21:15:30] * marktraceur  +2s, waits

[21:15:47] <marktraceur>	 ...it v+2'd, but no merge
[21:16:17] <Krinkle>	 "Starting gate-and-submit jobs. https://integration.wikimedia.org/zuul/ "
[21:16:27] <Krinkle>	 weird
[21:17:23] <Krinkle>	 it's not going to now
[21:17:25] <gerrit-wm>	 New patchset: Nemo bis; "Get rid of the arcane "Enter one of the pieces of data" language" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73036
[21:17:30] <Krinkle>	 it finished when it left the V+2 comment
[21:17:37] <Krinkle>	 I don't know why it didnt
[21:18:11] * Krinkle  tries

[21:18:49] <gerrit-wm>	 New review: Brion VIBBER; "Seems to pass tests, let's do it!" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72469
[21:18:53] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[21:19:23] <marktraceur>	 Krinkle: Hah. This amuses me.
[21:20:09] <gerrit-wm>	 Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/73033
[21:20:16] <Krinkle>	 well fuck it
[21:20:22] <marktraceur>	 Heh.
[21:20:33] <brion>	 hm jenkins build of apps-android-commons broke: https://integration.wikimedia.org/ci/job/apps-android-commons-build/68/console
[21:20:36] <brion>	 permission error?
[21:20:36] <marktraceur>	 I can deploy it, unless you've already done so
[21:20:36] <Krinkle>	 I think I know what it is
[21:20:40] <Krinkle>	 I haven't
[21:20:42] <Krinkle>	 go ahead
[21:20:54] <Krinkle>	 (I assume you know [[mw:CI/Z]])
[21:21:25] <marktraceur>	 Yup
[21:21:26] <Krinkle>	 I think I know what it is. jenkins-bot doesn't have permission on that repo to submit
[21:22:23] <marktraceur>	 Hah.
[21:23:13] <brion>	 funky
[21:24:28] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[21:27:38] <YuviPanda>	 hashar: https://integration.wikimedia.org/ci/job/apps-android-commons-build/68/console 'permission denied'? :)
[21:28:00] <YuviPanda>	 hashar: be off, we can look at this later :)
[21:28:04] <hashar>	 YuviPanda: can you fill a bug for it please ?
[21:28:11] <YuviPanda>	 hashar: will do
[21:28:18] <YuviPanda>	 brion: i'll file the bug
[21:28:33] <hashar>	 I know the root cause
[21:28:37] <hashar>	 job runs as jenkins-slave
[21:28:46] <hashar>	 the target destination most probably belong to user 'jenkins'
[21:28:48] <hashar>	 hence perm denied
[21:28:53] <hashar>	 easy fix, but for tomorrow :-]
[21:28:58] <hashar>	 sorry :(
[21:29:03] <hashar>	 have a good night!
[21:30:49] <gerrit-wm>	 New patchset: Nemo bis; "Remove period from bootstrap-desc for consistency" [mediawiki/extensions/Bootstrap] (master) - https://gerrit.wikimedia.org/r/73077
[21:31:15] <YuviPanda>	 brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=51137
[21:32:47] <gerrit-wm>	 New patchset: Nemo bis; "Remove period from campaigns-desc for consistency" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/73089
[21:33:04] <gerrit-wm>	 New review: Matmarex; "Heh." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/73036
[21:33:42] <marktraceur>	 MatmaRex_ ... he's a man of few words ...
[21:34:47] <MatmaRex_>	 marktraceur: what else is to say here? although maybe "Lol" would have been more appropriate given the contents of message this changed :P
[21:34:55] <gerrit-wm>	 New review: Brian Wolff; "This wasn't the original intention for the useless parameter (I believe). I think The original inten..." [mediawiki/extensions/Disambiguator] (master) C: -1;  - https://gerrit.wikimedia.org/r/73035
[21:35:24] <gerrit-wm>	 New patchset: Nemo bis; "Make cirrussearch-desc less redundant" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/73091
[21:35:29] <marktraceur>	 MatmaRex_: 'twasn't criticism, that was totally the thing to say there
[21:35:45] <MatmaRex_>	 :)
[21:37:07] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73036
[21:37:27] <gerrit-wm>	 New patchset: Nemo bis; "Add missing period to communitytwitter-unknown-error" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73093
[21:40:17] <gerrit-wm>	 New review: Brian Wolff; "I first of all don't like this definition of useless. The existing pages blacklisted aren't duplicat..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73034
[21:40:18] <gerrit-wm>	 New patchset: Nemo bis; "Add label to Special:RecentChanges link" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73094
[21:42:29] <hoo>	 Nemo_bis: {{int:}} works there?
[21:46:02] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[21:46:02] <gerrit-wm>	 New review: Krinkle; "We have release notes for jquery.client gaining support for Opera 15, I suppose we should have them ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[21:48:46] <gerrit-wm>	 New patchset: Trevor Parscal; "Add more specific class to cite errors" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/73096
[21:49:34] <gerrit-wm>	 New review: Catrope; "Fails parser tests" [mediawiki/extensions/Cite] (master) C: -1;  - https://gerrit.wikimedia.org/r/73096
[21:50:05] <Nemo_bis>	 hoo: it's now supported even in JS and should be among the most basic parsing allowed, but right, I should check better
[21:50:24] <hoo>	 Nemo_bis: I'm about to check myself, don't bother it
[21:50:35] <Nemo_bis>	 ah good
[21:50:40] <Nemo_bis>	 especially as firefox crashed
[21:50:45] <hoo>	 :D
[21:50:59] <hoo>	 mine usually only gets terribly slow :P
[21:53:46] <Nemo_bis>	 hoo: sometimes it rebels against LQT I believe
[21:53:54] <hoo>	 :D
[21:54:52] <hoo>	 anyhow... it works like a charm
[21:55:10] <gerrit-wm>	 New review: Hoo man; "Works like a charm... thanks :)" [mediawiki/extensions/CentralAuth] (master) C: 2;  - https://gerrit.wikimedia.org/r/73094
[21:55:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/73094
[21:58:24] <YuviPanda>	 mwalkez: cool uzer name :)
[21:58:50] <mwalkez>	 check! :) got some bling on today
[21:59:01] <mwalkez>	 aka... freenode wouldn't let me use mwalker for some reason
[21:59:14] <YuviPanda>	 mwalkez: :D
[21:59:29] <gerrit-wm>	 New patchset: SuchABot; "Do not leak a TypedArray instance" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73097
[22:01:10] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/73097
[22:01:59] <Nemo_bis>	 mwalkez: /msg nickserv release mwalker ?
[22:02:09] <mwalkez>	 tried
[22:02:11] <mwalkez>	 it's not a ghost issue
[22:02:13] <Reedy>	 /msg nickserv smite mwalker
[22:02:43] <Nemo_bis>	 nasty reedy
[22:02:48] <Nemo_bis>	 oh, that worked
[22:02:50] <mwalker>	 transient ghost issue maybe
[22:03:07] <mwalker>	 it happens a lot with netsplits
[22:03:07] <mwalker>	 *shrugs*
[22:03:27] <Nemo_bis>	 there are scripts to take care of it, of course
[22:03:38] <gerrit-wm>	 New patchset: MarkTraceur; "Adding DonationInterface test runner" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71727
[22:03:44] <gerrit-wm>	 New patchset: Cmcmahon; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[22:04:41] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[22:05:01] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/FlashPlayer] (master) - https://gerrit.wikimedia.org/r/73099
[22:05:13] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Flow] (master) - https://gerrit.wikimedia.org/r/73100
[22:05:27] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/HaloTripleStoreConnector] (master) - https://gerrit.wikimedia.org/r/73101
[22:05:39] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/73102
[22:05:55] <mutante>	 :)
[22:06:03] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/SMWHalo] (master) - https://gerrit.wikimedia.org/r/73103
[22:07:07] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:08:19] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/FlashPlayer] (master) - https://gerrit.wikimedia.org/r/73108
[22:09:21] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73109
[22:09:30] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:10:36] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:14:14] <gerrit-wm>	 New patchset: Cscott; "Add wgAllowExternalImages option to parser tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/73111
[22:15:23] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:17:00] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:17:08] * marktraceur  is getting tired of this.

[22:17:24] <marktraceur>	 OK at least that's working now.
[22:21:12] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:24:07] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:24:07] <gerrit-wm>	 New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73109
[22:24:39] <gerrit-wm>	 New review: Catrope; "Change looks good though, and shouldn't cause issues with #iferror" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/73096
[22:27:09] <gerrit-wm>	 New review: Cloudyks; "Initial .gitreview/.gitignore" [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73109
[22:27:33] <gerrit-wm>	 New patchset: RAN1; "Add missing period to communitytwitter-unknown-error" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73093
[22:27:53] <gerrit-wm>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/73038
[22:28:23] <gerrit-wm>	 New review: Cloudyks; "Initial .gitreview/.gitignore" [mediawiki/extensions/PushToWatch] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/73109
[22:28:24] <gerrit-wm>	 Change merged: Cloudyks; [mediawiki/extensions/PushToWatch] (master) - https://gerrit.wikimedia.org/r/73109
[22:34:34] <hoo>	 Nemo_bis: Katie (aude) probably knows about that... I haven't been part in that process yet... I don't even know whether my components in Wikibase will work there (in fact, I doubt they will)
[22:35:12] <hoo>	 and I'm not sure we have a way to get localized wiki group names yet
[22:35:31] <gerrit-wm>	 New review: RAN1; "It's a minor grammatical change, go for submission." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/73093
[22:35:32] <gerrit-wm>	 Change merged: RAN1; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/73093
[22:50:39] <gerrit-wm>	 New patchset: Mollywhite; "Bug 50759: Use local image files instead of URLs." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73117
[22:51:49] <gerrit-wm>	 New review: Spage; "FWIW I like it, particularly using "may" for fixes.  On balance I think naming the starting page Get..." [mediawiki/extensions/GettingStarted] (master) C: 1;  - https://gerrit.wikimedia.org/r/72868
[22:52:36] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/73117
[22:55:50] <gerrit-wm>	 New review: Swalling; "Comments in line. Some of this is a very good idea, other parts give me pause." [mediawiki/extensions/GettingStarted] (master) C: -1;  - https://gerrit.wikimedia.org/r/72868
[22:56:17] <gerrit-wm>	 New patchset: Adamw; "Ensure that times go into the db in UTC, regardless of global or user timezone settings." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73118
[23:02:55] <csteipp>	 greg-g: Could I get into the lightning deploy?
[23:02:59] <csteipp>	 (today)
[23:03:30] <greg-g>	 csteipp: yessir
[23:03:54] <csteipp>	 Cool. Anyone else using it?
[23:04:34] * RoanKattouw  raises hand

[23:04:38] <RoanKattouw>	 I can go last though
[23:05:09] <csteipp>	 RoanKattouw: Go ahead.. I'll be a couple minutes before I can start
[23:05:31] <RoanKattouw>	 Well me too, and more than a couple
[23:05:46] <csteipp>	 hah. ok, i'll go ahead in a few
[23:05:53] <RoanKattouw>	 When I say "I can go last" what I mean is "someone please go before me so I have more time"
[23:05:54] <RoanKattouw>	 ;)
[23:06:09] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[23:06:50] <marktraceur>	 ori-l_: So I have oracle-java8-installer.preseed.erb in puppet/templates/ but I'm getting "Could not retrieve information from environment production source(s) puppet:////oracle-java8-installer.preseed at /tmp/vagrant-puppet/manifests/preseed.pp:15"
[23:07:29] <marktraceur>	 I guess because I misunderstand how the puppet:/// scheme works
[23:08:45] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73120
[23:09:07] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73121
[23:09:46] <gerrit-wm>	 New patchset: Adamw; "Ensure that times go into the db in UTC, regardless of global or user timezone settings." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/73118
[23:10:59] <RoanKattouw>	 csteipp: Ping me when you're done
[23:12:11] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #68: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/68/
[23:18:37] <gerrit-wm>	 New patchset: CSteipp; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73122
[23:22:18] <gerrit-wm>	 Change merged: Reedy; [mediawiki/extensions/Flow] (master) - https://gerrit.wikimedia.org/r/73100
[23:24:21] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73122
[23:28:21] <gerrit-wm>	 New patchset: Aaron Schulz; "Added Special:MWOAuthManageMyGrants page" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990
[23:29:18] <AaronSchulz>	 csteipp: ^
[23:30:13] <Ryan_Lane>	 what a special page name :)
[23:30:47] <csteipp>	 RoanKattouw: I'm done
[23:32:25] <RoanKattouw>	 csteipp: Thanks :)
[23:33:55] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/73120
[23:34:03] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/73121
[23:35:01] <gerrit-wm>	 New patchset: Reedy; "Fix PHP Parse errors" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/73125
[23:35:59] <RoanKattouw>	 Reedy: No jenkins in that repo?
[23:36:12] <Reedy>	 No idea
[23:36:26] <Reedy>	 Presumably not..
[23:37:26] <Reedy>	 Slightly worrying if that's how the author is distributing it
[23:39:47] <gerrit-wm>	 New review: CSteipp; "Thanks!" [mediawiki/extensions/OAuth] (master) C: 2;  - https://gerrit.wikimedia.org/r/72990
[23:45:50] <csteipp>	 Hmm... Did I really break something? https://gerrit.wikimedia.org/r/#/c/73122/
[23:47:53] <gerrit-wm>	 New patchset: Reedy; "Add Disambiguator extension" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/73126
[23:48:34] <hoo>	 csteipp: that php code style... nobody cares about that really
[23:48:52] <Reedy>	 lol
[23:49:54] <gerrit-wm>	 Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72990
[23:50:26] <csteipp>	 hoo: cool :) That was the first time I'd seen it
[23:52:24] <Ryan_Lane>	 Krinkle|detached: I think I've fixed all issues you identified in this change: https://gerrit.wikimedia.org/r/#/c/65557/