[00:02:41] <gerrit-wm>	 New patchset: Mollywhite; "Fixing scoping issue." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72665
[00:03:17] <gerrit-wm>	 New review: Mollywhite; "Bugfix" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72665
[00:03:17] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72665
[00:06:25] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[00:09:07] <gerrit-wm>	 New review: Brian Wolff; "I'm doubtful this is more efficient. Also it causes $dir to be leaked to global scope" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[00:17:16] <gerrit-wm>	 New review: Ori.livneh; "Doesn't work well. 'git rev-list HEAD...origin/master --count' outputs the distance between the two ..." [mediawiki/vagrant] (master) C: -1;  - https://gerrit.wikimedia.org/r/72662
[00:20:41] <gerrit-wm>	 New patchset: Ori.livneh; "Correct invocation of 'enumerate-roles'" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72667
[00:21:01] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72667
[00:22:54] <gerrit-wm>	 New patchset: Adamw; "Move translated email capabilities into a new module, wmf_email" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72669
[00:24:24] <ori-l>	 GorillaWarfare: I just ran across https://meta.wikimedia.org/wiki/Schema:BookManagerv2 today -- looks really interesting and cool.
[00:26:21] <gerrit-wm>	 New review: CSteipp; "I may have a couple updates, but works for now. Thanks!" [mediawiki/extensions/OAuth] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72243
[00:26:22] <gerrit-wm>	 Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72243
[00:27:11] <gerrit-wm>	 New review: Mollywhite; "Why should the <p> tags be replaced with an ordered list?" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71655
[00:27:49] <gerrit-wm>	 New review: Mollywhite; "Hm, not worth it then?" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[00:28:14] <YuviPanda>	 ori-l: btw, GorillaWarfare is also sortof duplicating the JsonContent / JsonSchema stuff :)
[00:28:17] <YuviPanda>	 hmm
[00:28:19] <YuviPanda>	 you already know that
[00:28:20] <YuviPanda>	 I think?
[00:28:25] <ori-l>	 very vaguely
[00:28:34] <YuviPanda>	 right.
[00:31:25] <marktraceur>	 MatmaRex: re: collapsible patch, did you test?
[00:31:34] <gerrit-wm>	 New review: Ori.livneh; "$dir is way less efficient. __DIR__ is evaluated at compile time, before the script even begins exec..." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[00:35:49] <gerrit-wm>	 New review: Helder.wiki; "For semantic reasons: the content of the menu is a *list* of chapters, so it should be represented a..." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71655
[00:37:40] <MatmaRex>	 marktraceur: not really, i have merely proven it correct :P
[00:37:54] <MatmaRex>	 marktraceur: you can test on your watchlist if you have "enhanced RC" enabled
[00:38:18] <MatmaRex>	 just try keyboard-navigating the arrows, and ensure you're not using Opera, becayuse it;s smarter and does that without accessibility attributes
[00:39:06] <marktraceur>	 Righto
[00:39:50] <marktraceur>	 MatmaRex: /whois marktraceur appears to still say fsf/member/mtraceur, so I'm going to go with "wouldn't be using opera", but I'm happy with this patch
[00:39:51] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: avoid exceptions due to races in redis job listing functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72671
[00:39:53] <marktraceur>	 Sooo happy
[00:40:25] <marktraceur>	 Oh, sorry, fsf/member/marktraceur
[00:40:31] <marktraceur>	 I forget sometimes what they gave me
[00:40:42] <bawolff>	 FOR FREEDOM!!!!1111 :P
[00:41:02] <YuviPanda>	 still better than me getting yuvipandan
[00:41:03] <gerrit-wm>	 New review: MarkTraceur; "<3 MatmaRex." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72371
[00:41:17] <MatmaRex>	 marktraceur: you know, some time ago i was wondering what the hell are those attributes actually for when browsers can figure out what is actionable anyway
[00:41:21] <gerrit-wm>	 New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[00:41:24] <MatmaRex>	 turned out that these "browsers" are really just OPera
[00:41:32] <marktraceur>	 MatmaRex: *nod* indeed
[00:41:35] <MatmaRex>	 you can keyboard-navigate everything, and i love it
[00:41:47] <marktraceur>	 MatmaRex: And if they loved us they'd be less stupid and share, but sadly, no.
[00:41:49] <YuviPanda>	 we need vim keybindings
[00:41:52] <MatmaRex>	 oh hey, thanks for the merge
[00:41:57] <marktraceur>	 Vimperator! Vimperator everywhere!
[00:42:26] <marktraceur>	 $out->addModule( 'vimperator' )
[00:44:13] <MatmaRex>	 marktraceur: you know, with Opera moving to Blink now, i'mwondering of Presto will be getting open-sourced
[00:44:18] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72371
[00:44:43] <MatmaRex>	 they're remarkably cool guys, so this seems quite likely for me, sooner or later
[00:45:04] <marktraceur>	 MatmaRex: I mean, they could be cooler by not subjugating their users at *all*
[00:45:07] <marktraceur>	 But yeah
[00:45:11] <marktraceur>	 Runner-up, totally
[00:45:24] <YuviPanda>	 hmm, we should have vim keybindings for everything
[00:45:30] * YuviPanda  remembers trying to type / to search y'day

[00:45:32] <MatmaRex>	 marktraceur: Opera already has a bunch of open-source stuff, too
[00:45:46] <marktraceur>	 YuviPanda: No really. Vimperator.
[00:45:48] <MatmaRex>	 like theDragonfly debugger
[00:45:48] <MatmaRex>	 https://github.com/operasoftware/
[00:45:56] <YuviPanda>	 too slow to my liking, tho
[00:45:58] <marktraceur>	 "a bunch" !== "all"
[00:46:04] <MatmaRex>	 YuviPanda: Opera does that, btw.
[00:46:04] <bawolff>	 Mozilla also has a lot of open source stuff too :P
[00:46:08] <marktraceur>	 YuviPanda: Actually, FF does that too
[00:46:09] <MatmaRex>	 YuviPanda: / == Ctrl+F
[00:46:16] <marktraceur>	 So does Microsoft.
[00:46:17] <bawolff>	 lynx does that too
[00:46:22] <YuviPanda>	 MatmaRex: no, I mean, / to focus on wiki's searchbox
[00:46:25] <MatmaRex>	 but Opera was probably first :P
[00:46:28] <marktraceur>	 They're *great* at open-sourcing things. And Google!
[00:46:47] <marktraceur>	 Facebook...Twitter...
[00:46:59] <marktraceur>	 I bet even Netflix has token "Open Source" projects
[00:47:03] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to email digest" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72672
[00:47:09] <marktraceur>	 Fie, I say, fie on them.
[00:47:19] * MatmaRex  hides from evangelists

[00:47:24] <YuviPanda>	 Android is a pretty neat 'Open Source' project. It doesn't pretend to be 'Free'
[00:47:47] <YuviPanda>	 MatmaRex: have you received into your storage devices the message of our lord and saviour RMS?
[00:48:10] <marktraceur>	 YuviPanda: Naw, don't bother with 'im, he's not interested. Besides, RMS isn't right about everything.
[00:48:21] <MatmaRex>	 YuviPanda: i'm afraid my storage devices are incompatible :P most of the stuff i use happens to only be free as in beer, not as in freedom
[00:48:21] <gerrit-wm>	 New patchset: Mwalker; "(FR #987) Fix Luhn Check for Odd Numbered Cards" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72661
[00:48:37] <marktraceur>	 Frankly I don't know why people point at RMS all the time - his arguments (when they make sense) stand on their own
[00:48:42] <YuviPanda>	 MatmaRex: I am typing this from an OS X machine, so...
[00:49:03] <YuviPanda>	 MatmaRex: I... was making a follow up joke on MatmaRex's original 'evangelist' joke
[00:49:06] <gerrit-wm>	 New patchset: Mwalker; "(FR #987) Fix Luhn Check for Odd Numbered Cards" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72661
[00:49:18] <YuviPanda>	 agree that discussing a person than his arguments is counterproductive
[00:49:18] <MatmaRex>	 :D
[00:49:22] <gerrit-wm>	 New review: Ori.livneh; "> mw.hook can be fired multiple times. Though this code doesn't do that, if that were to happen thes..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[00:49:33] <MatmaRex>	 YuviPanda: i think you've got your tab=completion wrong between me and marktraceur
[00:49:42] <marktraceur>	 Hee.
[00:49:42] <MatmaRex>	 :D
[00:49:46] <YuviPanda>	 MatmaRex: ah, right.
[00:50:14] <YuviPanda>	 Henceforth it shall be decreed that no two persons who might converse at the same time have the same two first characters in their nicks!
[00:50:19] <gerrit-wm>	 New patchset: Mwalker; "(FR #987) Fix Luhn Check for Odd Numbered Cards" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72661
[00:50:37] <YuviPanda>	 and anyone in violation shall be punished with a metric ton of false pings!
[00:51:02] <marktraceur>	 MatmaRex: I get this *all* the time in #wikipedia-en when people are trying to reach....someone else
[00:51:15] <marktraceur>	 Mareklug?
[00:51:26] <marktraceur>	 Or...something
[00:51:47] <MatmaRex>	 marktraceur: haha, he's a pl.'pedian too. :P
[00:51:53] <YuviPanda>	 heh, you and mareklug should be on rather opposite ends of the FOSS spectrum :)
[00:51:58] <marktraceur>	 Coolio.
[00:52:08] <MatmaRex>	 YuviPanda: what about yurik and you?!?
[00:52:12] <marktraceur>	 YuviPanda: That sorta applies to 99% of the world
[00:52:26] <YuviPanda>	 MatmaRex: we're also on the same team, at the WMF.
[00:53:02] <YuviPanda>	 marktraceur: heh, true
[00:53:04] <MatmaRex>	 ah. well that explains it, carry on. :P
[00:53:45] <YuviPanda>	 MatmaRex: however, I'm a lot more noisy on IRC, while he gets more actual work done, so we don't have that much of a problem
[00:53:55] <YuviPanda>	 MatmaRex: and how does 'that explain it'?
[00:54:43] <MatmaRex>	 not at all, i was lamely attempting to joke. :P
[00:55:11] <YuviPanda>	 whooshed right past me, that one.
[00:55:50] <YuviPanda>	 hmm, I'm waiting for vagrant to come back up so I can test a (hopefully final) 1 line patch before I head to sleep
[00:57:30] <TimStarling>	 AaronSchulz: you really want to insist on use of closures for https://gerrit.wikimedia.org/r/#/c/72067/ ?
[01:04:09] <gerrit-wm>	 New patchset: Mattflaschen; "Add skipIfNeeded public method and use it for shouldSkip." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673
[01:04:43] <gerrit-wm>	 Change merged: Adamw; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72661
[01:04:46] <ori-l>	 superm401: I'm waiting for quickShouldSkip :P
[01:05:07] <superm401>	 ori-l, is that a reference to quickUserCan? :)
[01:08:28] <ori-l>	 superm401: i'd say there's a 60-70% chance that it was
[01:09:01] <superm401>	 skipIfYouLikeDoubleDutch
[01:09:10] <ori-l>	 heheh
[01:11:25] <bawolff>	 I like how the doc comment says "Refresh metadata in memcached, but don't touch thumbnails or squid"
[01:11:57] <bawolff>	 And the function then goes on to delete all the thumbnails of any non-current version and purge them in squid
[01:19:41] <gerrit-wm>	 New patchset: Ori.livneh; "Allow 'www-data' group to write to the upload folder" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72674
[01:20:38] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72674
[01:24:36] <gerrit-wm>	 New review: Ori.livneh; "Krinkle, would you prefer if I used a a generic $.Callbacks('memory once') object, scoped to the mod..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[01:25:35] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[01:27:44] <gerrit-wm>	 New patchset: Mattflaschen; "Add skipIfNeeded public method and use it for shouldSkip." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673
[01:29:44] <YuviPanda>	 marktraceur: i'm off to sleep now. night.
[01:41:27] <gerrit-wm>	 New patchset: Mattflaschen; "Add support for VisualEditor." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[01:46:04] <gerrit-wm>	 New patchset: Tim Starling; "Release notes for null edit/forcelinkupdate change" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72678
[01:46:55] <gerrit-wm>	 New patchset: Mattflaschen; "Add support for VisualEditor." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[01:47:23] <gerrit-wm>	 New review: Tim Starling; "> Thanks. Release notes?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72064
[01:47:34] <gerrit-wm>	 New patchset: Ori.livneh; "Use 'mw.hook' to queue events until EL has loaded" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[01:48:07] <gerrit-wm>	 New patchset: Ori.livneh; "Use $.Callbacks to queue events until EL has loaded" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[01:48:43] <gerrit-wm>	 New review: Tim Starling; "Self-merge, since if I wait an hour, there will be a conflict." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72678
[01:49:27] <gerrit-wm>	 New patchset: Tim Starling; "Don't queue refreshLinks jobs on null edit" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72679
[01:50:10] <gerrit-wm>	 New review: Ori.livneh; "PS3 uses $.Callbacks instead. As for the garbage-collection of unprocessed events that linger in que..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[01:51:27] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72678
[01:54:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72679
[02:00:32] <gerrit-wm>	 New patchset: Ori.livneh; "Shorter Windows and VirtualBox version detection" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72662
[02:01:07] <gerrit-wm>	 New review: Ori.livneh; "Self-merge, since if I wait an hour, there will be a conflict. (Just kidding.)" [mediawiki/vagrant] (master) C: 2;  - https://gerrit.wikimedia.org/r/72662
[02:01:09] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72662
[02:06:06] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[02:07:23] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[02:09:27] <gerrit-wm>	 New patchset: Ori.livneh; "$settings_dir mode to 0755; comment tweak" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72680
[02:09:41] <gerrit-wm>	 New review: Kaldari; "MaxSem: I refactored the workflow logic. It now figures out which pages to look up images for and wh..." [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[02:10:44] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[02:11:20] <gerrit-wm>	 New review: Kaldari; "The last couple patches were just whitespace fixes :P" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[02:21:47] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[02:23:28] <gerrit-wm>	 New patchset: Mattflaschen; "Add support for VisualEditor." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[02:24:28] <gerrit-wm>	 New review: Mattflaschen; "Depends on https://gerrit.wikimedia.org/r/72676, the supporting change to VisualEditor." [mediawiki/extensions/GuidedTour] (master) C: -2;  - https://gerrit.wikimedia.org/r/72677
[02:25:16] <gerrit-wm>	 New review: Mattflaschen; "It also depends on the Guiders change, https://gerrit.wikimedia.org/r/72673 , which is also what Jen..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[02:33:51] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[02:43:46] <gerrit-wm>	 New review: Mattflaschen; "On Toro for testing." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/72673
[02:44:17] <gerrit-wm>	 New review: Mattflaschen; "On Toro for testing." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[02:47:38] <gerrit-wm>	 New review: Mattflaschen; "On Toro for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:05:48] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:19:23] <gerrit-wm>	 New patchset: Mattflaschen; "Add support for VisualEditor." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/72677
[03:21:52] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[03:27:42] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[04:02:12] <gerrit-wm>	 New patchset: KarenEddy; "Critical Update: Fixes an infinite loop in an xml parsing function." [mediawiki/extensions/BiblioPlus] (master) - https://gerrit.wikimedia.org/r/72685
[04:08:30] <gerrit-wm>	 New patchset: Tim Starling; "Don't queue refreshLinks jobs on null edit" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72686
[04:13:02] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72686
[04:20:49] <gerrit-wm>	 New review: KarenEddy; "Thanks for your interest in this extension. I have actually already submitted a patch for this probl..." [mediawiki/extensions/BiblioPlus] (master) C: -2;  - https://gerrit.wikimedia.org/r/72517
[05:11:43] <mooey>	 eh, anyone around for a quick gerrit-review question?
[05:39:09] <gerrit-wm>	 New review: Siebrand; "Removing myself as reviewer; I'm not familiar with the code, and would like to focus on L10n and i18..." [mediawiki/extensions/BiblioPlus] (master) - https://gerrit.wikimedia.org/r/72685
[05:41:49] <gerrit-wm>	 New review: Siebrand; "Don't understand why you're adding hidden parameters. Chances of anyone finding out they are there a..." [mediawiki/extensions/AbuseFilter] (master) C: 1;  - https://gerrit.wikimedia.org/r/71291
[05:42:34] <gerrit-wm>	 Change merged: Siebrand; [mediawiki/extensions/Mpdf] (master) - https://gerrit.wikimedia.org/r/72339
[05:43:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72647
[05:43:56] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/72338
[05:44:43] <gerrit-wm>	 New review: Siebrand; "yay :)" [mediawiki/extensions/EducationProgram] (master) C: 2;  - https://gerrit.wikimedia.org/r/72334
[05:45:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72334
[05:45:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72088
[05:45:45] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/72332
[05:46:12] <gerrit-wm>	 Change merged: Siebrand; [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/70594
[05:47:01] <gerrit-wm>	 Change merged: Siebrand; [mediawiki/extensions/Premoderation] (master) - https://gerrit.wikimedia.org/r/70598
[05:47:48] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70800
[05:53:07] <gerrit-wm>	 New review: Siebrand; "Are you sure all the use cases are covered, Raimond? prefs-editing needs to be fed into JavaScript, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58668
[06:01:33] <Jasper_Deng>	 Krenair, lazyktm: this might seem like a dumb question, but how do I search for a global filter in a local abuse log? For example, http://www.mediawiki.org/wiki/Special:AbuseLog?wpSearchUser=&wpSearchFilter=global+filter+72&wpSearchTitle= doesn't work.
[06:02:40] <Jasper_Deng>	 and with the hell is with http://www.mediawiki.org/wiki/Special:AbuseLog/18673 ?
[06:03:17] * Jasper_Deng  will send them to Bugzilla if no-one else knows about them

[07:03:29] <gerrit-wm>	 New patchset: Siebrand; "Disable default web font for language code "ml"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72690
[07:07:54] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72690
[07:17:26] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72680
[07:32:01] <hashar>	 hello
[07:36:28] <ori-l>	 hi hashar
[07:49:26] <qgil>	 hello from EU   :)
[07:51:07] <hashar>	 arhgh
[07:51:13] <hashar>	 I forgot to write my monthly status report
[07:51:51] <qgil>	 you still have 20 days for the next one
[07:52:07] <hashar>	 the June one :/
[07:52:35] <hashar>	 between my 110 bugs and 3 pages long gerrit dashboard
[07:52:41] <hashar>	 I feel a bit overwhelmed :-D
[07:53:45] <qgil>	 "Fixed 110 bugs and merged 3 pages long gerrit changesets"
[07:54:09] <qgil>	 anyway, I won distract you more  :)
[08:01:50] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72531
[08:03:05] <gerrit-wm>	 New review: Hashar; "Deployed, pinged addshore to let him know about it." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72531
[08:05:41] <gerrit-wm>	 New patchset: Hashar; "jobs for mw/ext/WikibaseQuery" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72538
[08:08:18] <gerrit-wm>	 New review: Hashar; "deployed, will do the zuul triggers" [integration/jenkins-job-builder-config] (master) C: 2;  - https://gerrit.wikimedia.org/r/72538
[08:08:20] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72538
[08:12:24] <gerrit-wm>	 New review: Hashar; "Zuul configuration had already be done with https://gerrit.wikimedia.org/r/#/c/68696/ . Looks like I..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72538
[08:13:49] <gerrit-wm>	 New review: Hashar; "I have regenerated all the jobs since WikibaseQuery ones were not published in Jenkins ( https://ger..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68696
[08:16:08] <gerrit-wm>	 New patchset: Shirayuki; "Fix messages, names and spellings" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/72242
[08:19:51] <gerrit-wm>	 New review: TheDJ; "I'm not sure if it's a good idea to do this check this late. Perhaps we should just not make the Lat..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362
[08:34:19] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72693
[08:38:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72693
[08:45:39] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72697
[08:49:43] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72697
[08:50:24] <se4598_2>	 siebrand: are you there so you can tell me how to better communicate the msg-parameters (re gerrit 71291)?
[09:03:10] <gerrit-wm>	 New patchset: Physikerwelt; "new Feature: Create dumpswith MathnML" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72699
[09:06:30] <gerrit-wm>	 New patchset: Physikerwelt; "new Feature: Create dumps with MathML" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72699
[09:07:44] <gerrit-wm>	 Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72699
[09:09:11] <gerrit-wm>	 New patchset: Mattflaschen; "Add ParserFunctions role." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72700
[09:10:18] <gerrit-wm>	 New review: Physikerwelt; "any updates here?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301
[09:13:25] <gerrit-wm>	 New patchset: Siebrand; "Revert "Disable default web font for language code "ml""" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72701
[09:13:54] <gerrit-wm>	 New patchset: Siebrand; "Revert "Disable default web font for language code "ml""" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72701
[09:14:15] <gerrit-wm>	 New review: Physikerwelt; "I was thinking of smaller wiki installations..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362
[09:14:27] <gerrit-wm>	 New patchset: Mattflaschen; "Add tour for VisualEditor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72682
[09:18:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72701
[09:22:32] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72703
[09:26:02] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72704
[09:26:55] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72703
[09:30:38] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72704
[09:37:30] <gerrit-wm>	 New review: Matmarex; "Hm, alright, I won't complain then. Let's get this deployed if it works, then fix the code bug and r..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/72614
[09:40:08] <gerrit-wm>	 New review: Physikerwelt; "... and there are a lot of them..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362
[09:58:50] <gerrit-wm>	 New review: Matmarex; "-1 for now per the bug; this needs a couple of dependencies sorted out to not be really annoying for..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/49082
[10:53:25] <gerrit-wm>	 New review: Daniel Kinzler; "I agree that the list of extension functions is rather useless. It's a remnant from the days before ..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/71355
[11:01:39] <gerrit-wm>	 New review: Nikerabbit; "Isn't the i18n message unused now?" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/71355
[11:05:26] <gerrit-wm>	 New review: Daniel Kinzler; "looks good, but havn't tested" [mediawiki/extensions/WikimediaMessages] (master) C: 1;  - https://gerrit.wikimedia.org/r/50362
[11:54:15] <gerrit-wm>	 New patchset: Krinkle; "Remove list of functions added in wgExtensionFunctions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355
[12:09:10] <gerrit-wm>	 New patchset: Hoo man; "Don't trigger filter hits for nonexisting filter 0" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72716
[12:12:29] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove list of functions added in wgExtensionFunctions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355
[12:13:50] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove list of functions added in wgExtensionFunctions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355
[12:14:05] <gerrit-wm>	 New review: Jeroen De Dauw; "@Nikerabbit: removed now :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355
[12:14:59] <gerrit-wm>	 New patchset: Hashar; "Add a script to unit test puppet modules." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/72215
[12:15:21] <gerrit-wm>	 New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72259
[12:17:36] <gerrit-wm>	 New patchset: Matmarex; "tablesorter: Keyboard accessibility for sort headers." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72259
[12:18:31] <gerrit-wm>	 New review: Matmarex; "I poked the code per my own comments and expanded the commit message." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72259
[12:18:43] <gerrit-wm>	 New review: Hashar; "fixed a pep8 issue." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/72215
[12:32:39] <gerrit-wm>	 New patchset: Matmarex; "jquery.makeCollapsible: Togglers keyboard accessibility" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72719
[12:36:21] <gerrit-wm>	 New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72720
[12:50:23] <gerrit-wm>	 New review: Hashar; "The rake wrapper in operations/puppet.git is https://gerrit.wikimedia.org/r/72721  . You can give it..." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/72215
[12:50:46] <aude>	 Reedy: around?
[12:51:33] <aude>	 or AaronSchulz?
[12:52:08] <aude>	 we need help to "expire" some js in the caches
[12:52:48] <aude>	 Wikibase/lib/resources/wikibase.ui.SiteLinksEditTool.js (my best guess)
[12:53:00] <aude>	 if anyone can help with that.... :)
[12:58:56] <hashar>	 aude: isn't resource loader supposed to handle that for us ?
[12:59:17] <aude>	 hashar: it's stuck somewhere sometimes
[12:59:22] <aude>	 somehow
[12:59:30] <hashar>	 :/
[12:59:36] <hashar>	 I have no idea how to clear the RL cache myself
[12:59:37] <aude>	 if i log out, i randomly get pages where i can't edit the site links
[12:59:44] <aude>	 i think you can touch that file
[12:59:51] <aude>	 somehow it magically works sometimes
[12:59:53] <hashar>	 ah we can try that
[12:59:56] <aude>	 yes
[13:00:09] <aude>	 with debug=true, things work
[13:02:20] <hashar>	 aude touched and syncing
[13:02:25] <aude>	 thanks
[13:03:36] <hashar>	 aude done
[13:03:44] <aude>	 ok, thanks
[13:03:45] <hashar>	 aude: I am not sure whether it is going to fix up anything
[13:03:53] <aude>	 it sometimes does the trick
[13:10:11] <aude>	 hashar: still seems to occur although randomly :(
[13:10:26] <hashar>	 there is some cache that can be cleaned but I have no idea how it works
[13:10:27] <aude>	 if i figure out another file to try, we can ask
[13:10:32] <aude>	 reedy might know
[13:10:41] <aude>	 but think this is what he usually tries
[13:11:26] * aude  unable to reproduce the problem on my computer

[13:12:00] <gerrit-wm>	 New review: AzaToth; "any re-review?" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485
[13:14:23] <AzaToth>	 !r 72333 | hashar
[13:14:23] <wm-bot>	 hashar: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/72333
[13:15:12] <hashar>	 hmm ?
[13:15:47] <AzaToth>	 hashar: the Author of LinkedWiki wanted it
[13:15:50] <AzaToth>	 also
[13:15:55] <AzaToth>	 !b 50876 | hashar
[13:15:55] <wm-bot>	 hashar: https://bugzilla.wikimedia.org/50876
[13:15:58] <AzaToth>	 is related
[13:16:20] <hashar>	 ah cucumber
[13:16:40] <hashar>	 I should lower that priority with something along the side of :  I have no clue about cucumber :-]
[13:16:41] <AzaToth>	 heh
[13:16:47] <AzaToth>	 it's karina btw
[13:17:24] <AzaToth>	 hashar: http://cukes.info/
[13:17:45] <AzaToth>	 hashar: it's "behavour driven developement with elegance and joy"
[13:17:53] <AzaToth>	 ±spelling
[13:18:09] * AzaToth  can never spell behaviour correctly

[13:19:16] <hashar>	 AzaToth: https://bugzilla.wikimedia.org/show_bug.cgi?id=50876#c1
[13:19:34] <hashar>	 I have zero idea what is needed to run the tests
[13:19:56] <AzaToth>	 hashar: http://i.imgur.com/FoyJXa6.png
[13:19:57] <hashar>	 if you get all the commands  + required packages, we can get the job wrapper written in jenkins job builder
[13:19:59] <hashar>	 and packages installed
[13:20:13] <hashar>	 but I am not going to do it myself.  Too many things to complete before my vacations :-]
[13:20:31] <AzaToth>	 hashar: fyi, qa-browsertest is using cucumber
[13:22:20] <AzaToth>	 hashar: anyway, that was just what karina wanted
[13:22:36] <AzaToth>	 she has both php tests and cucumber tests
[13:24:24] <AzaToth>	 hashar: also MobileFrontend has cucumber tests
[13:24:57] <hashar>	 I guess they don't care about tests do they ? : D
[13:25:02] <AzaToth>	 hehe
[13:25:45] <AzaToth>	 hashar: anyway... debian-glue
[13:25:56] <hashar>	 that might get done eventually
[13:26:03] <hashar>	 need slaves to be able to access the Zuul git repositories
[13:26:10] <hashar>	 I got an apache patches for it somewhere in gerrit
[13:26:22] <hashar>	 have yet to test it out though
[13:26:37] <AzaToth>	 ok
[13:26:54] <hashar>	 that one https://gerrit.wikimedia.org/r/#/c/71968/
[13:26:55] <hashar>	 :D
[13:27:17] <hashar>	 when a patchset arrive, Zuul will attempt to merge it on the tip of the branch
[13:27:30] <hashar>	 which craft a new merge commit which is then used as a parameter to trigger Jenkins jobs
[13:27:39] <hashar>	 so Jenkins jobs on slaves need to be able to fetch the change
[13:27:56] <hashar>	 unless I have Zuul to push it is references back in Gerrit :-]
[13:28:34] <AzaToth>	 why try to merge?
[13:28:49] <AzaToth>	 makes no sense to do a merge in this context
[13:29:36] <AzaToth>	 better just to import the commit and reset the branch to the commit
[13:30:27] <gerrit-wm>	 New patchset: Physikerwelt; "Fix last commit add MathDump.php file" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72722
[13:30:53] <gerrit-wm>	 Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72722
[13:31:22] <AzaToth>	 hashar: does zuul has any documentation anywhere?
[13:38:33] <hashar>	 sorry
[13:38:49] <hashar>	 AzaToth: I am trying to proceed some pages longs emails :-]
[13:38:58] <hashar>	 I guess I will do that later tonight when it is colder hehe
[13:38:59] <hashar>	 so zuul
[13:39:10] <hashar>	 Upstream doc is at http://ci.openstack.org/zuul/
[13:39:20] <hashar>	 the principe is described at http://ci.openstack.org/zuul/gating.html
[13:39:40] <hashar>	 we have a basic doc https://www.mediawiki.org/wiki/Continuous_integration/Zuul
[13:39:46] <hashar>	 mainly to deploy change
[13:39:57] <hashar>	 I have yet to write a doc about our own layout configuration  though
[13:46:30] <gerrit-wm>	 New review: Daniel Kinzler; "Still:" [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/71355
[13:53:59] <gerrit-wm>	 New patchset: Hoo man; "Refactor AbuseFilterView::canEdit* functions" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72724
[14:07:13] <gerrit-wm>	 New review: Anomie; "Code looks like it will probably work, haven't tested it though. In my opinion it's still doing thin..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[14:08:37] <hoo|away>	 anomie: Could you maybe review https://gerrit.wikimedia.org/r/72716 and try to get it deployed today? I don't want to see many more broken log entries...
[14:09:14] <anomie>	 hoo|away: I'll try to take a look
[14:09:19] <hoo|away>	 :)
[14:09:22] <hoo|away>	 Away for now
[14:14:18] <AzaToth>	 hashar: okai
[14:14:49] <AzaToth>	 hashar: just reply TL;DR. on too long emails
[14:15:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71856
[14:31:23] <hashar>	 AzaToth: yeah sorry need to handle them
[14:31:38] <hashar>	 AzaToth: regarding cucumber, if you find how to have them running using a clean Precise instance that would be nice
[14:32:05] <hashar>	 AzaToth: like:  packages dependencies:  php-cucumber,   to run it use the command:  cd tests; php cucumber --junit-log junit.xml   or something along that
[14:32:15] <hashar>	 AzaToth: then it is almost trivial to craft the job in Jenkins Job Builder
[14:32:23] <hashar>	 I will be happy to help
[14:32:39] <hashar>	 but can't really find out all the requirements myself :-]
[14:33:16] <AzaToth>	 so you think we should use php-cucumber instead of normal cucumber (ruby)?
[14:34:18] <hashar>	 i have no idea :-]
[14:34:24] <hashar>	 I just made that up hehe
[14:35:17] <AzaToth>	 there aint any php-cucumber
[14:35:25] <AzaToth>	 it's just cucumber
[14:35:51] <AzaToth>	 normally they reside in a "features" directory, but here people have used "tests"
[14:36:03] <AzaToth>	 but it's just to type "cucumber tests"
[14:36:38] <AzaToth>	 http://packages.ubuntu.com/precise/cucumber
[14:37:21] <gerrit-wm>	 New review: Matthias Mullie; "Let's see. Apparently, Mail_mime's default charset is ISO-8859-1. Since those characters will map th..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/71747
[14:44:07] <sumanah>	 hey chrismcmahon
[14:44:19] <chrismcmahon>	 hi sumanah
[14:47:20] <gerrit-wm>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[14:47:24] <AzaToth>	 hashar: test -d junit || mkdir junit && cucumber --format junit --out junit --strict
[14:48:09] <hashar>	 AzaToth: add it to the bug please :-]
[14:48:44] <AzaToth>	 ok
[14:48:48] <hashar>	 we even have some cucumber version in Precise http://packages.ubuntu.com/search?keywords=cucumber :D
[14:49:00] <AzaToth>	 jupp
[14:49:06] <AzaToth>	 so it's plausable
[14:49:29] <AzaToth>	 dunno if we should take care if people uses "tests" instead of default "features"
[14:50:22] <AzaToth>	 this is the result for example in junit format above: http://paste.debian.net/15165/
[14:50:37] <hashar>	 Junit for the win
[14:54:23] <lazyktm>	 hoo|away: ping
[14:54:46] <lazyktm>	 hoo|away: on https://meta.wikimedia.org/wiki/Special:AbuseLog?wpSearchUser=&wpSearchFilter=72&wpSearchTitle=&wpSearchWiki= the GAF links to the wrong article
[14:54:51] <gerrit-wm>	 New review: Daniel Kinzler; "@Anomie: so, what do you suggest?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61390
[15:19:13] <hoo|away>	 lazyktm: Wrong artice, are you sure?
[15:19:23] <lazyktm>	 sorry, i meant wrong site
[15:19:34] <lazyktm>	 as in the link goes to meta rather than on mw.o
[15:19:49] <hoo|away>	 lazyktm: WORKSFORME
[15:19:53] <lazyktm>	 er
[15:19:55] <lazyktm>	 03:18, 9 July 2013: User:MinervaZ5 (www.mediawiki.org) triggered an abuse filter, performing the action "edit" on User:MinervaZ5. Actions taken: Tag; Filter description: Global test filter against Ntsamr
[15:20:11] <lazyktm>	 on User:MinervaZ5 <-- that link is on meta
[15:20:20] <hoo|away>	 probably a rights issue, worksofrme
[15:20:20] <lazyktm>	 it should link to mw:User:MinervaZ5
[15:20:27] <hoo|away>	 going to have a look later
[15:20:33] <lazyktm>	 hmmm
[15:20:33] <lazyktm>	 ok
[15:29:52] <anomie>	 hoo|away: In that !g 72716, do both arrays use numeric keys? Or is it something like the local one uses numeric and the global one uses "G1", "G2", and so on?
[15:31:38] <anomie>	 hoo|away: Never mind, I tracked down the answer myself.
[15:33:10] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72716
[15:35:43] <anomie>	 hoo|away: If you want to get that backported, work with greg-g to schedule a timeslot. I can help with the actual deploying if necessary.
[15:50:44] <qgil>	 chrismcmahon, did sumanah say wikimedia-dev?
[15:51:08] <chrismcmahon>	 qgil not sure, I figure we will hear...
[15:52:05] <zeljkof>	 chrismcmahon: are we talking with sumana here now?
[15:53:13] <qgil>	 zeljkof, in theory yes
[15:53:17] <qgil>	 oops
[15:54:04] <marktraceur>	 YuviPanda: array_replace_sanely, eh? What sane person did you get to write that for you? :)
[15:54:09] <qgil>	 zeljkof, in theory yes
[15:54:20] <YuviPanda>	 marktraceur: sleep deprived me from... some hours ago :)
[15:54:24] <marktraceur>	 Aha.
[15:54:34] <qgil>	 zeljkof, if you are on 3G you might want to e.g. turn on your Twitter to have something pulling the connection regularly  :)
[15:54:54] <YuviPanda>	 marktraceur: also clearly any re-implementation of PHP inbuilt functions can have a _sanely suffix added by default without question :D
[15:55:06] <marktraceur>	 *nod* truth
[15:55:29] <YuviPanda>	 it simply treats assoc arrays and arrays differently.
[15:55:39] <zeljkof>	 qgil: I have to leave soon, so I will not be online for long
[15:56:00] <qgil>	 hi sumanah
[15:56:05] <zeljkof>	 qgil: and for some reason, my IRC client gets disconnected every few minutes
[15:56:08] <sumanah>	 hey chrismcmahon zeljkof qgil I'll be there in a sec, sorry, was talking with Greg about gadgets & aiutomated testing
[15:56:34] <qgil>	 zeljkof, because probably you need tomething pulling that 3G conection frequently, e.g. twitter in the background
[15:56:39] <qgil>	 or typing here
[15:57:01] <marktraceur>	 YuviPanda: I'm sure when I get to the implementation I'll have more things to yell at you for
[15:57:03] <greg-g>	 hoo: heya, didn't see the scrollback that anomie references, what's up?
[15:57:17] <zeljkof>	 the app that manages the usb device says I am connected for the last 5 hours
[15:57:17] <hoo>	 hi greg-g
[15:57:22] <YuviPanda>	 marktraceur: the deletions to insertions ratio was 3:1, now it is closer to 3:2 :(
[15:57:33] <marktraceur>	 *shrug* still deletions
[15:57:41] <YuviPanda>	 not as cool!
[15:57:44] <zeljkof>	 qgil: you think it disconnects if there is no network activity
[15:57:49] <zeljkof>	 ?
[15:57:55] <hoo>	 Yesterday we started testing global AbuseFilters an triggered a bug which produces invalid log entries... long story short, I need to deploy AbuseFilter
[15:58:01] <YuviPanda>	 marktraceur: also I'm going to go away for about 30 mins now, to shower and stuff. brb
[15:58:06] <marktraceur>	 YuviPanda: Don't worry, we'll delete a bunch of JavaScript later and it'll be great
[15:58:08] <qgil>	 zeljkof, think so, yes. From my stats playing chess on 3G  ;)
[15:58:14] <YuviPanda>	 marktraceur: true that!
[15:58:14] <sumanah>	 ok, am back, qgil zeljkof chrismcmahon :)
[15:58:20] <sumanah>	 qgil: I'm sitting in your chair :)
[15:58:24] <qgil>	 :)
[15:58:41] <qgil>	 AaronSchulz, wanted it... Anyway, to the point
[15:58:50] <greg-g>	 hoo: has csteip taking a look at it? what's the changeset?
[15:59:01] <sumanah>	 anyway. So, http://lists.wikimedia.org/pipermail/analytics/2013-July/000706.html - we see that Analytics can probably get us our gadget/bot usage survey earlier than October
[15:59:16] <hoo>	 greg-g: https://gerrit.wikimedia.org/r/72716 approved by Anomie, Chris know about it, yes
[15:59:30] <qgil>	 either more time to get 10 people, or less people, or a more flexible definition of "involved" seems to be what we are saying
[15:59:33] <sumanah>	 these will help us guide volunteer test-writers' contribution
[15:59:43] <sumanah>	 qgil: ok. What definition of "involved" would you perhaps like?
[16:00:10] <sumanah>	 if we run a weekly test-writing sprint online, and ~10 people participate in the one on Sept 30, that might satisfy me
[16:00:15] <zeljkof>	 I think "involved" would be somebody that contributes regularly for a long period of time
[16:00:16] <qgil>	 I'm for the real definition: someone contributing test cases to the code repository at least once a month
[16:00:27] <qgil>	 or I'd say more frequent than that
[16:01:14] <zeljkof>	 qgil: yes, several times a month, but once a month is fine with me, if it is for several months, plus being active on the mailing list and/or contributing to the documentation
[16:01:16] <hoo>	 lazyktm: Could reproduce your problem
[16:01:16] <qgil>	 the problem with synchronous activities is that it's hard for people to make it regularly, different timezones etc
[16:01:30] <liangent>	 hi MatmaRex
[16:01:39] <qgil>	 what about how many people do we have pairing on a regular basis, saying once a week whenever suits them
[16:01:46] <qgil>	 in an organized, documented way
[16:02:02] <MatmaRex>	 hi liangent
[16:02:24] <zeljkof>	 qgil, sumanah: how many volunteers are contributing to core?
[16:02:24] <qgil>	 and then our task is to help building those pairs
[16:02:52] <chrismcmahon>	 honestly, I think quality is more important than quantity
[16:03:02] <sumanah>	 chrismcmahon: Quantity has a quality all its own.
[16:03:15] <sumanah>	 :)
[16:03:16] <qgil>	 chrismcmahon, ok, your turn to define a measurable outcome
[16:03:49] <qgil>	 zeljkof, same for you: define your measurable goal
[16:03:51] <sumanah>	 more seriously, chrismcmahon: For bus factor reasons, it does not make sense to nurture just 1 or 2 high-quality contributors to the exclusion of building a numerically robust community. I'm not asking for dozens
[16:03:53] <chrismcmahon>	 hrm
[16:05:27] <chrismcmahon>	 what about measuring contributions rather than contributors?  e.g. zeljkof did a good job identifying some onboarding tasks and we had a user TP make several valuable contributions because of that.  rachel99 is about to make another set of valuable contributions
[16:05:48] <sumanah>	 I think contributions AS WELL AS contributors -- both are important measures
[16:06:18] <qgil>	 I'll say one: if we have 3 pairs (not counting us) meeting regularly, around in the QA list / mediawiki.org and with some code committed by the end of September, I would be happy
[16:06:18] <zeljkof>	 I think we realistically can have in the next 2-3 months 2-3 active contributors, contributing code, documentation and/or to mailing list several times each month,
[16:06:42] <qgil>	 2-3 pairs, and deal?
[16:07:07] <zeljkof>	 qgil: what do you mean by 2-3 pairs?
[16:07:14] <qgil>	 4-6 people
[16:07:16] <qgil>	 pairing
[16:07:23] <gerrit-wm>	 New patchset: Hoo man; "Link correct Page in AbuseLog for users who can't see details" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72740
[16:07:32] <hoo>	 lazyktm: ^
[16:07:44] <qgil>	 (somehow I feel not knowing enough English subtelties to type "2-3 couples pairing")  :)
[16:07:46] <zeljkof>	 qgil: that is possible, but 2-3 people is more possible than 4-6 :)
[16:07:59] <qgil>	 zeljkof, sure, but I
[16:08:09] <qgil>	 d prefer a bit more of ambition
[16:08:20] <zeljkof>	 qgil: we can aim for 10+, there is no harm in being optimistic
[16:08:33] <qgil>	 ambition, not na�vity
[16:08:43] <zeljkof>	 I like to think of myself as realist, but my wife would say I am a pessimist :)
[16:08:45] <sumanah>	 well, I'd like for us to actually work through the theory of change, and figure out what we would have to do in order to get to 6, or 10
[16:09:38] <qgil>	 Promote those pairing on Fridays that chrismcmahon and zeljkof started themselves. Add more mass to that gravity.
[16:09:48] <sumanah>	 so, in order to have (let's say) 3 pairs of people, 6 volunteers, pairing regularly by September 10th and commiting tests, what specific recruiting and mentoring steps would we take?
[16:10:35] <qgil>	 Continue pulling from the QA list. Some specific individuals have shown interest beyond 2 emails.
[16:10:36] <qgil>	 then
[16:10:51] <qgil>	 From the SF atttendees we could perhaps pull another 1-2
[16:11:08] <qgil>	 and then we can organize another workshop in SF again with Chris etc by the end of August
[16:11:26] <sumanah>	 Are the "Weekend Testers" interested in writing automated tests?
[16:11:48] <qgil>	 the pairing thing is good, because once you get two people you have someone else than ourselves pulling hands
[16:11:51] <sumanah>	 yes
[16:11:59] <zeljkof>	 sumanah: chrismcmahon will know more, but I think some of weekend testers are interested in automation
[16:12:15] <sumanah>	 we could use http://wiki.growstuff.org/index.php/Pear or pairwithme to recruit more people interested in pairing & learning in general
[16:12:42] <qgil>	 if those sites do work then definitely, very good idea
[16:12:48] <zeljkof>	 but for pairing to be useful, we have to have at least one volunteer that is skilled in writing tests
[16:12:58] <qgil>	 we have the "Fix Wikipedia!" flag, which is powerful
[16:13:20] <zeljkof>	 and we do not have one at the moment, at least not active in our community
[16:13:31] <chrismcmahon>	 Weekend Testers as such are not interested in automation
[16:13:45] <sumanah>	 zeljkof: not yet. rachel99 will be skilled enough within probably a month, right? to help people get started?
[16:14:02] <sumanah>	 and judytuna could probably pick things up reasonably fast
[16:14:06] <zeljkof>	 sumanah: that is the plan
[16:14:06] <qgil>	 zeljkof, well, we can be flexible her. Chris and you can start pairing with new comers and nurturing them
[16:14:24] <qgil>	 in the SF meetup there was a guy that also was insider, new to Wikipedia.
[16:14:43] <zeljkof>	 sumanah: several people with high skills said they are interested, but nobody really contributed so far
[16:15:05] <qgil>	 zeljkof, we (I) need to followup
[16:15:17] <zeljkof>	 maybe we just have to ping them more fequently
[16:15:18] <sumanah>	 qgil: this also seems like an opportunity to make friends with Railsbridge/Hackbright Academy, the Ruby-specific learning communities in SF
[16:15:23] <gerrit-wm>	 New patchset: Mwalker; "Adding Silverpop Email Export Script" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72741
[16:15:25] <zeljkof>	 skilled people tend to be busy
[16:15:39] <qgil>	 yes and yes
[16:16:06] <qgil>	 Judy is a very good local contact, she knows the Ruby community and she knows us
[16:16:06] <gerrit-wm>	 Change merged: Mwalker; [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72741
[16:17:03] <qgil>	 Then Carol is a good example of the learner, like many other (women!) that came to the SF workshop. They are working in QA, more or less bored with the current specialty and willing to learn to change
[16:17:38] <sumanah>	 !log
[16:17:38] <wm-bot>	 There is no such key, you probably want to try: !anonnotice, !api, !chansearch, !cms, !debug, !errors, !gitaccount, !logo, !logs, !MediaWiki:action-suppressionlog, !MediaWiki:addwatch, !MediaWiki:all-logs-page, !MediaWiki:alllogstext, !MediaWiki:anononlyblock, !MediaWiki:api-error-mustbeloggedin, !MediaWiki:articlepage, !MediaWiki:blocklogentry, !MediaWiki:block-log-flags-angry-autoblock, !MediaWiki:block-log-flags-anononly, !MediaWiki:block-log-flags-hiddenname, !MediaWiki:block-log-flags-noautoblock, !MediaWiki:block-log-flags-nocreate, !MediaWiki:block-log-flags-noemail, !MediaWiki:block-log-flags-nousertalk, !MediaWiki:blocklogpage, !MediaWiki:blocklogtext, !MediaWiki:confirmemail_loggedin, !MediaWiki:confirmemail_needlogin, !MediaWiki:createaccountblock, !MediaWiki:create-this-page, !MediaWiki:delete_and_move_reason, !MediaWiki:deletethispage, !MediaWiki:deletionlog, !MediaWiki:dellogpage, !MediaWiki:dellogpagetext, !MediaWiki:double-redirect-fixed-maintenance, !MediaWiki:double-redirect-fixed-move, !MediaWiki:editthispage, !MediaWiki:emailblock, !MediaWiki:exception-nologin, !MediaWiki:exception-nologin-text, !MediaWiki:feedback-bugornote, !MediaWiki:gotaccountlink, !MediaWiki:img-auth-nologinnWL, !MediaWiki:imported-log-entries, !MediaWiki:import-logentry-interwiki, !MediaWiki:import-logentry-interwiki-detail, !MediaWiki:import-logentry-upload, !MediaWiki:import-logentry-upload-detail, !MediaWiki:importlogpage, !MediaWiki:importlogpagetext, !MediaWiki:lastmodifiedat, !MediaWiki:log, !MediaWiki:logdelete-failure, !MediaWiki:logdelete-selected, !MediaWiki:logdelete-success, !MediaWiki:logentry-rights-autopromote, !MediaWiki:logentry-rights-rights, !MediaWiki:logentry-rights-rights-legacy, !MediaWiki:log-fulllog, !MediaWiki:login, !MediaWiki:login-abort-generic, !MediaWiki:loginerror, !MediaWiki:loginlanguagelabel, !MediaWiki:loginprompt, !MediaWiki:loginreqlink, !MediaWiki:loginreqpagetext, !MediaWiki:loginreqtitle, !MediaWiki:loginsuccess, !MediaWiki:loginsuccesstitle, !MediaWiki:login-throttled, !MediaWiki:login-userblocked, !MediaWiki:logout, !MediaWiki:logouttext, !MediaWiki:log-show-hide-patrol, !MediaWiki:log-title-wildcard, !MediaWiki:mailnologin, !MediaWiki:mailnologintext, !MediaWiki:mergelog, !MediaWiki:mergelogpagetext, !MediaWiki:movedarticleprotection, !MediaWiki:movelogpage, !MediaWiki:movelogpagetext, !MediaWiki:movenologintext, !MediaWiki:nav-login-createaccount, !MediaWiki:newuserlog-byemail, !MediaWiki:newuserlogpage, !MediaWiki:newuserlogpagetext, !MediaWiki:noautoblockblock, !MediaWiki:nocookieslogin, !MediaWiki:nocreate-loggedin, !MediaWiki:noemail, !MediaWiki:nologin, !MediaWiki:nologinlink, !MediaWiki:nosuchuser, !MediaWiki:nosuchusershort, !MediaWiki:notloggedin, !MediaWiki:overwroteimage, !MediaWiki:pagemerge-logentry, !MediaWiki:password-login-forbidden, !MediaWiki:passwordreset-pretext, !MediaWiki:patrol-log-header, !MediaWiki:patrol-log-page, !MediaWiki:prefsnologintext, !MediaWiki:protectlogpage, !MediaWiki:protectlogtext, !MediaWiki:protect-summary-cascade, !MediaWiki:protectthispage, !MediaWiki:qbfind, !MediaWiki:qbmyoptions, !MediaWiki:qbsettings, !MediaWiki:reblock-logentry, !MediaWiki:resetpass-submit-loggedin, !MediaWiki:resetpass-temp-password, !MediaWiki:rev-deleted-comment, !MediaWiki:right-deletelogentry, !MediaWiki:rightslog, !MediaWiki:rightslogtext, !MediaWiki:right-suppressionlog, !MediaWiki:securelogin-stick-https, !MediaWiki:showhideselectedlogentries, !MediaWiki:sp-contributions-blocklog, !MediaWiki:sp-contributions-logs, !MediaWiki:speciallogtitlelabel, !MediaWiki:specialloguserlabel, !MediaWiki:specialpages-group-login, !MediaWiki:suppressionlog, !MediaWiki:suppressionlogtext, !MediaWiki:suspicious-userlogout, !MediaWiki:talkpage, !MediaWiki:tooltip-p-logo, !MediaWiki:tooltip-pt-anonlogin, !MediaWiki:tooltip-pt-login, !MediaWiki:tooltip-pt-logout, !MediaWiki:unblocklogentry, !MediaWiki:undeletebtn, !MediaWiki:unprotectedarticle, !MediaWiki:unprotectthispage, !MediaWiki:uploadedimage, !MediaWiki:uploadlogpage, !MediaWiki:uploadlogpagetext, !MediaWiki:uploadnologin, !MediaWiki:uploadnologintext, !MediaWiki:userlogin, !MediaWiki:Userlogin, !MediaWiki:userloginnocreate, !MediaWiki:userlogin-resetlink, !MediaWiki:userrights-nologin, !MediaWiki:userrights-reason, !MediaWiki:viewpagelogs, !MediaWiki:watchlistanontext, !MediaWiki:watchlistedit-normal-legend, !MediaWiki:watchlistedit-raw-legend, !revdelete, !sal, !sharedlogins, !sqllog, !sul, !tautology, 
[16:17:41] <sumanah>	 !logs
[16:17:41] <wm-bot>	 channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://bots.wmflabs.org/~wm-bot/html/index.php?action=search&channel=%23mediawiki
[16:18:37] <zeljkof>	 sumanah, chrismcmahon, qgil: I have to do now
[16:18:41] <marktraceur>	 YuviPanda: So if I have array( array( 'blah' => 'blah' ) ), or some other combination of nesting normal arrays and associative ones, this seems like it won't work
[16:18:41] <zeljkof>	 I have to go now
[16:19:16] <sumanah>	 sorry zeljkof
[16:19:18] <sumanah>	 thanks for the chat
[16:19:19] <zeljkof>	 is there anything that is left for me to answer?
[16:19:20] <marktraceur>	 I feel like you'd need to run through nested arrays and merge the internal ones first
[16:19:49] <sumanah>	 zeljkof: would you feel comfortable with a goal of 6 people who pair regularly & commit tests ~ every 2 weeks/ for sept 30?
[16:20:10] <zeljkof>	 sumanah: no :)
[16:20:20] <sumanah>	 OK, what goal would you feel comfortable committing to?
[16:20:23] <zeljkof>	 I think 2-3 is realistic, but we might get lucky :)
[16:20:52] <sumanah>	 I think if only 2-3 is realistic given our current speed/activities then we need to increase our speed and get more effective with our activities
[16:21:21] <zeljkof>	 we might have 6-10 people contributing a few times a year
[16:21:40] <qgil>	 sumanah, ok, at the end this is an ECT goal.
[16:21:45] <sumanah>	 qgil: what's your perspective?
[16:21:51] <zeljkof>	 but 2-3 is realistic (as far as I can see) that commit a few times a month
[16:21:59] <zeljkof>	 chrismcmahon, qgil: what do you think?
[16:22:06] <sumanah>	 ok zeljkof you should go ahead and head off, qgil and chrismcmahon and I will continue chatting
[16:22:16] <zeljkof>	 sumanah: thanks
[16:22:26] <zeljkof>	 feel free to ping me on qa mailing list
[16:22:27] <sumanah>	 thanks for the perspective.  important to be realistic but also to figure out how to achieve this level of change, eventually
[16:22:29] <sumanah>	 sure!
[16:22:30] <zeljkof>	 or privately
[16:22:52] <gerrit-wm>	 New patchset: Mollywhite; "Whitespace cleanup, changing lists to use ordered list." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742
[16:23:05] <qgil>	 I'll aim for 4-6 real independent new comers. Plus Rachel, zeljkof chrismcmahon , plus WMF employees that seem to have an interest on this. About 10 productive people that we can get whenever there is an activity
[16:23:23] <qgil>	 from those, about 4 also contribute individually, pairing regularly
[16:23:26] <sumanah>	 qgil: yeah, it's an ECT goal for sure, but I want to check in with zeljkof & chrismcmahon partly because I know we'll be needing their time ....
[16:23:30] <hoo>	 greg-g: So, can we have a Window? (shall we rather talk in -operations... it's less noisy there)
[16:23:58] <greg-g>	 hoo: sure, let's go to -ops
[16:24:02] <qgil>	 what I mean is that I understand they don't want to risk, but I think we ECT need a bit more ambition considering the resources/focus we are putting to it
[16:24:18] <greg-g>	 hoo: -operations, of course, I just shorthand it when typing ;)
[16:24:23] <qgil>	 I'd rather fail than not aim
[16:24:24] <hoo>	 Sure :D
[16:25:01] <sumanah>	 qgil: ok.
[16:25:40] <chrismcmahon>	 qgil: as long as it's clearly an aim and not a mandate
[16:25:48] <sumanah>	 chrismcmahon: what should the mandate be then?
[16:26:32] <qgil>	 these are goals. Goals are goals.
[16:26:59] <sumanah>	 qgil: May I ask you (sometime tomorrow probably) to write that up and send it to the QA list & put it someplace onwiki as a record of ECT's more specific July-September goal?
[16:27:20] <chrismcmahon>	 like the difference between an estimate and a deadline :-)
[16:27:29] <sumanah>	 ok. Deadlines are better.
[16:27:30] <qgil>	 ok sumanah , tomorrow after the ECT meeting just in case there are more comments about this
[16:27:36] <sumanah>	 Ok qgil
[16:28:06] <sumanah>	 qgil: in the meantime, the anecdata about GSoC demographics will be helpful as I edit agenda/notes for today's ECT review will be helpful sooner :)
[16:28:07] <qgil>	 something I agree with chris / zeljkof is tht this takes time, and perhaps end of Sep is too tight
[16:28:19] <qgil>	 considering that we have holidays and wikimania in between
[16:28:34] <qgil>	 so if not September then december, or somewhere in between
[16:28:43] <qgil>	 ok gsoc
[16:29:04] <sumanah>	 qgil: That's something to take into consideration, yes
[16:29:16] <qgil>	 it's more of a diesel than a turbo task
[16:30:04] <qgil>	 and July-September is not like January-March in therms of people's productivity (volunteers included, not just us)
[16:30:09] <qgil>	 terms
[16:30:48] <qgil>	 but imho these are details, and the goal remains
[16:30:51] <sumanah>	 chrismcmahon: qgil - are you running a "how to write an acceptance test" sprint or training or something at Wikimania?
[16:30:56] <sumanah>	 qgil: nod
[16:31:10] <qgil>	 not me
[16:31:14] <chrismcmahon>	 I'm not going to Wikimania
[16:31:39] <qgil>	 I'm not a person to run such session alone
[16:31:52] <gerrit-wm>	 New review: Anomie; "Really, just fix it in your configuration: Specify 'apibase' as either http://commons.wikimedia.org/..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61390
[16:32:02] <sumanah>	 well, not yet, but probably qgil you could run one if we did some info transfer between now and Aug 8
[16:33:09] <qgil>	 mmmaybe the plain English descriptions part, which is anyway the only one that would initially interest the Wikimania audience
[16:34:32] <qgil>	 sumanah, is the Wikimania hackathon shcedule done in situ?
[16:34:38] <gerrit-wm>	 New review: Anomie; "Looks like something that was just forgotten in whatever patch added the global filter support." [mediawiki/extensions/AbuseFilter] (master) C: 2;  - https://gerrit.wikimedia.org/r/72740
[16:34:42] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72740
[16:36:12] <sumanah>	 qgil: it's editable
[16:36:19] <qgil>	 sumanah, anyway, let's talk about this another day. You should focus on the ECT review.  :)
[16:36:24] <sumanah>	 qgil: yeah I was thinkgin plain Eng descriptions
[16:36:25] <qgil>	 I'm open to the idea
[16:36:26] <sumanah>	 ok, yeah!
[16:36:43] <qgil>	 chrismcmahon, let me think about this and get back to you ok?
[16:37:16] <chrismcmahon>	 qgil: OK.  your call.
[16:37:39] <qgil>	 chrismcmahon, looking at timezones zeljko / you could be online unless you have holidays
[16:37:45] <qgil>	 anyway, to be discussed
[16:40:55] <marktraceur>	 multichill: Hey, you might have some opinion on this - we're merging a change to UploadWizard soon that would migrate Campaigns to be stored in JSON files in the Campaign namespace. Patch in gerrit, number 70446. Let me know if you have thoughts.
[16:41:31] <marktraceur>	 !g 70446 | multichill
[16:41:31] <wm-bot>	 multichill: https://gerrit.wikimedia.org/r/#q,70446,n,z
[16:43:08] <gerrit-wm>	 New patchset: Brian Wolff; "Fix undefined std_class::fa_deleted_timestamp warning during undelete." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72743
[16:44:34] <bawolff>	 Hmm, I'm not sure why that didn't cause problems, but it didn't seem to...
[16:45:39] <gerrit-wm>	 New patchset: Hoo man; "Update AbuseFilter to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72744
[16:47:22] <gerrit-wm>	 Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72744
[16:49:03] <gerrit-wm>	 New review: MarkTraceur; "I second brion's call for a good GUI, but for now I think Yuvi's gone through enough hoops. This loo..." [mediawiki/extensions/UploadWizard] (master) C: 2;  - https://gerrit.wikimedia.org/r/70446
[16:50:29] <brion>	 \o/
[16:50:35] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[16:50:53] <marktraceur>	 YuviPanda: ^
[16:50:57] <marktraceur>	 Like an effing boss.
[16:50:59] <Reedy>	 REVERT
[16:50:59] <Reedy>	 REVERT
[16:51:00] <Reedy>	 REVERT
[16:51:01] <liangent>	 how can I dump a full lua table to check its content?
[16:51:03] <liangent>	 and recursively
[16:51:36] <gerrit-wm>	 New patchset: Mollywhite; "Use __DIR__ directly, instead of storing it in a variable." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72745
[16:51:48] <parent5446>	 Wow 50 patch sets. I don't think I've seen that before.
[16:51:51] <marktraceur>	 chrismcmahon: We'd like to get latest UploadWizard on beta labs so we can point some Campaign admins at it and they can break it, but we'll need to run a maintenance script after updating
[16:51:53] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72743
[16:51:55] <multichill>	 marktraceur: That's one big commit
[16:52:00] <marktraceur>	 Yes, yes it is
[16:52:19] <marktraceur>	 multichill: It's less imposing in the GitHub form, I think
[16:53:06] <marktraceur>	 multichill: We'll get it on beta labs for you, you can test it out and tell YuviPanda how badly he broke it
[16:53:11] <chrismcmahon>	 marktraceur: awesome, can you let hashar know about UW and the maintenance script?
[16:53:17] <marktraceur>	 *nod* sure
[16:53:23] * marktraceur  emails

[16:53:36] <marktraceur>	 chrismcmahon: Wait, for beta labs or for jenkins?
[16:53:46] <chrismcmahon>	 marktraceur: Antoine is our beta sysadmin pretty much
[16:53:50] <marktraceur>	 Ah, cool.
[16:53:51] <chrismcmahon>	 beta labs
[16:53:58] <multichill>	 If it doesn't crash the site and adds history, it's fine with me
[16:54:10] <marktraceur>	 multichill: Well, it does that
[16:54:21] <marktraceur>	 You'll need to edit JSON, but I think we figured you all were clever enough for that
[16:54:33] <marktraceur>	 Also I think this means theoretically infinite ID fields.
[16:54:39] <marktraceur>	 But Yuvi can confirm.
[16:55:12] <gerrit-wm>	 New review: Anomie; "If you really want to fix it in the code, add an option to ApiQueryImageInfo to request protocol-rel..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61390
[16:58:15] <marktraceur>	 Email sent, so...yeah
[16:58:19] <marktraceur>	 That happened.
[17:00:41] <YuviPanda>	 marktraceur: re: nested arrays of that sort, it's intentional. array_replace_recursive does the thing you want, which was causing issues for us earlier
[17:00:54] <marktraceur>	 *nod*
[17:01:32] <YuviPanda>	 multichill: yes, infinite number of fields. and history, and a talk page.
[17:01:44] <YuviPanda>	 and you can wathlist them, etc too
[17:01:47] <YuviPanda>	 marktraceur: <3 \o/
[17:02:01] <YuviPanda>	 parent5446: look at the github link posted there, it is about 60 or so commits
[17:02:13] <YuviPanda>	 parent5446: merged together at marktraceur's insistence :)
[17:03:32] <parent5446>	 Oh wow. Lol. Were the commits squashed? If so that was a terrible idea.
[17:03:54] <marktraceur>	 YuviPanda: We're not out of the woods just yet - still need to deploy it after testing on beta
[17:04:21] <YuviPanda>	 parent5446: this is the GitHub <-> Gerrit bot, but yeah - ideally I'd have merged this as ~10 pull requests (equating to 10 gerrit patches)
[17:04:29] <YuviPanda>	 marktraceur: of course. I'd want a week or more of testing, at the least...
[17:04:36] <parent5446>	 Mhm
[17:04:48] <YuviPanda>	 marktraceur: am I cc'd in the email about maintenance script?
[17:04:55] <marktraceur>	 Uhhh no
[17:04:57] <YuviPanda>	 marktraceur: oh, also - no config changes needed in mediawiki-config.
[17:05:05] <YuviPanda>	 it doesn't override anything we changed
[17:05:24] <marktraceur>	 YuviPanda: EventLogging is already on Commons, yeah?
[17:05:28] <YuviPanda>	 yeah
[17:07:10] <YuviPanda>	 marktraceur: can you add me on the maintenance script thread?
[17:07:23] <marktraceur>	 Sure
[17:07:28] <YuviPanda>	 marktraceur: also I'm unsure if betalabs has the campaigns already. if not they'll need importing
[17:07:32] <YuviPanda>	 chrismcmahon: ^
[17:08:05] <marktraceur>	 That's what I emailed hashar about
[17:08:57] <YuviPanda>	 ah, okay. I've a copy of the sql if needed.
[17:09:17] <marktraceur>	 It, ah
[17:09:27] <marktraceur>	 My email client appears to have lost the sent message.
[17:09:45] <YuviPanda>	 mutt?
[17:10:02] <marktraceur>	 Yup
[17:10:05] <YuviPanda>	 ah
[17:11:30] <marktraceur>	 YuviPanda: I'll loop you in when hashar replies
[17:11:31] <gerrit-wm>	 New review: Anomie; "If you want to make the change yourself, please do. Otherwise I'll revise it so we can get it in tim..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[17:11:41] <gerrit-wm>	 New patchset: Cmcmahon; "update test for new behavior re Bug 50992" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72746
[17:11:53] <YuviPanda>	 marktraceur: ty
[17:12:14] <marktraceur>	 *nod*
[17:12:48] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72746
[17:15:40] <gerrit-wm>	 New patchset: Mollywhite; "Whitespace cleanup, changing lists to use ordered list." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72742
[17:16:15] <YuviPanda>	 Nischayn22: that huge patch got merged :)
[17:18:13] <hoo>	 https everywhere still is broken on voy :(
[17:18:41] <Reedy>	 Because the ruleset hasn't been backported
[17:18:57] <hoo>	 Reedy: It's on master but they don't distribute that?
[17:20:36] <Reedy>	 I was told I could backport it if I was "careful"
[17:20:42] <Reedy>	 I'm not quite sure how/where releases are done from
[17:21:21] <hoo>	 ...
[17:21:52] <hoo>	 We probably have global renaming before that happens
[17:21:54] * hoo  hides

[17:24:41] <YuviPanda>	 chrismcmahon: so we wait until hashar is back to run the maintenance scripts?
[17:25:45] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72495
[17:25:52] <chrismcmahon>	 YuviPanda: umm, good question.  As far as I'm concerned, go for it.  I don't think we've ever done what you're doing on beta.
[17:26:02] <Reedy>	  28 files changed, 1191 insertions(+), 1822 deletions(-)
[17:26:11] <YuviPanda>	 chrismcmahon: hmm, so someone needs to add me to the project on labs?
[17:29:55] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72745
[17:30:01] <Reedy>	 hoo: 3.2.3 was apparently branched 11 days ago
[17:30:19] <hoo>	 I'm on 3.2.3
[17:30:27] <Reedy>	 lol
[17:30:46] <hoo>	 It shows that Wikivoyage is in the Wikimedia group... but it doesn't redirect ...
[17:31:16] <Reedy>	 Yeah, due to the requests to other WMF resources
[17:33:58] <hoo>	 Reedy: mh? It does all inline requests via https (like upload and bits), just the request itself is plain http
[17:33:58] <YuviPanda>	 chrismcmahon: it is deployment prep?
[17:34:07] <YuviPanda>	 (project name)
[17:34:33] <hoo>	 and of course that one hold the cookies (luckily I'm not logged in on http)
[17:34:38] <hoo>	 * holds
[17:35:01] <chrismcmahon>	 YuviPanda: yes, should be deployment-prep
[17:35:08] <YuviPanda>	 chrismcmahon: can you add me to it?
[17:35:18] <YuviPanda>	 with... enough permissions to run these things? :)
[17:36:53] <YuviPanda>	 marktraceur: apparently that patch was so large that gerrit couldn't email me the entire thing :)
[17:37:23] <chrismcmahon>	 YuviPanda: I don't think I can add you actually.
[17:37:34] <YuviPanda>	 hmm, let me see if I can find someone who does
[17:37:44] <gerrit-wm>	 New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72749
[17:38:58] <YuviPanda>	 chrismcmahon: hmm, can you tell me who are all admin on deployment-prep?
[17:39:29] <chrismcmahon>	 YuviPanda: just guessing but petan maybe Krinkle maybe
[17:39:36] <marktraceur>	 Hah.
[17:41:06] <gerrit-wm>	 New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72750
[17:45:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72749
[17:46:35] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/72218
[17:47:16] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72750
[17:47:18] <marktraceur>	 Krinkle: Is it more kosher for me to add something to mw.api from a module in an extension or to add it in core, even though it's pretty specific to this extension?
[17:47:47] <Krinkle>	 marktraceur: Can you be more specific about this something?
[17:48:45] <marktraceur>	 Krinkle: I want to use the API to get all pages in a category, figured I'd just write a convenience function as mw.api.getPagesInCategory or oso
[17:48:48] <marktraceur>	 so*
[17:49:12] <marktraceur>	 With continue arguments and all.
[17:49:55] <Krinkle>	 If it's not too large, you could add it to core in mediawiki.api.category, don't add it to mediawiki.api itself though
[17:50:19] <Krinkle>	 However considering the data probably doesn't need post-processing, I'd recommend not doing it like this
[17:50:25] <marktraceur>	 Ah, K
[17:50:27] <Krinkle>	 it's just a general query with continuation
[17:50:49] <Krinkle>	 I'd love to have a mw.api.query (like mw.api.edit and mw.api.category) that helps with this in general
[17:51:00] <Krinkle>	 then for categorymembers you'd just pass the relevant parameters
[17:51:18] <marktraceur>	 Krinkle: Recommend just writing it into the extension code, then, or write a more general module that can do this?
[17:52:03] <Krinkle>	 I'd recommend adding mw.Api#query and have it do the convenience stuff you're after (resolve continuation etc.), but without being specific to 'categorymembers'
[17:52:06] <Krinkle>	 in core
[17:52:25] <marktraceur>	 Hm.p
[17:52:28] <marktraceur>	 Hm.*
[17:52:42] <marktraceur>	 K, I'll do what I can.
[17:52:59] <Krinkle>	 then in your extension you'd call something like mw.Api#query({ foo: 'categorymembers', bar: 'Living people' })
[17:54:50] <marktraceur>	 Krinkle: I guess you mean mw.api#ajax or mw.api#get?
[17:55:35] <Krinkle>	 No
[17:56:28] <Krinkle>	 Like mediawiki.api.login.js and mediawiki.api.parse.js, there'd be a mediawiki.api.query.js
[17:56:30] <Krinkle>	 action=query
[17:57:02] <Krinkle>	 which does mw.Api#get with action:'query' and abstracts query contiuation
[17:57:08] <marktraceur>	 Oh, huh
[17:57:59] <Krinkle>	 the nice thing is that (at least last I checked) our query continuation logic in the API is agnostic to the type of query
[17:58:13] <marktraceur>	 Seems like it, yeah
[17:58:44] <Krinkle>	 so you'd merge the results of each query (probably just array concat and/or extend object)
[17:59:26] <Krinkle>	 the method will take an object as first parameter with key/value pairs for the api url query, this parameter is required/non-optional as you need to tell it what query to run :)
[17:59:42] <Krinkle>	 I'll let you to it :)
[18:01:36] <gerrit-wm>	 New patchset: Mwalker; "Updates to the export script" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72752
[18:04:22] <marktraceur>	 Krinkle: I figured I'd just call it and have the API remember the continue key so I don't have to
[18:04:33] <marktraceur>	 I don't need all the members at once, that would be crazy :)
[18:06:08] <MatmaRex>	 marktraceur: i wrote a generic wrapped for continued queries once, but in Ruby
[18:06:11] <MatmaRex>	 wrapper*
[18:06:31] <Krinkle>	 marktraceur: What do you mean by having the "API" remember the continue key?
[18:06:35] <MatmaRex>	 and yeah, it seems to work like Krinkle said, just merge all results together to get one bigger one
[18:06:59] <MatmaRex>	 marktraceur: https://github.com/MatmaRex/Sunflower/blob/master/lib/sunflower/core.rb#L233-L272
[18:07:15] <gerrit-wm>	 New patchset: PleaseStand; "Unbreak cascading protection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[18:07:36] <MatmaRex>	 marktraceur: and a bunch of callers at https://github.com/MatmaRex/Sunflower/blob/master/lib/sunflower/list.rb#L98 and below
[18:07:40] <gerrit-wm>	 New patchset: PleaseStand; "Unbreak cascading protection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[18:08:18] <marktraceur>	 Ugh, brain, sorr
[18:08:19] <marktraceur>	 y
[18:08:21] <gerrit-wm>	 New patchset: Mwalker; "Updates to the export script" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72752
[18:08:31] <marktraceur>	 MatmaRex: I mean having the JavaScript mw.api interface remember it
[18:09:07] <MatmaRex>	 marktraceur: doing something like the code i linked, but in JS, should be rather simple
[18:09:23] <MatmaRex>	 marktraceur: you might want to make it a little smarter than i did and somehow guess those two keys
[18:09:52] <marktraceur>	 MatmaRex: I was thinking it would be possible to list all the continue keys in core...or at least the ones I need
[18:10:18] <MatmaRex>	 haha, yeah, that would work too
[18:10:25] <MatmaRex>	 i was just too lazy to do it in my implementation
[18:11:07] <gerrit-wm>	 New review: PleaseStand; "Hopefully, this is what you wanted. If not, just go ahead and revise it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[18:11:14] <marktraceur>	 *nod*
[18:11:28] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #173: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/173/
[18:11:36] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #154: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/154/
[18:11:55] <Krinkle>	 marktraceur: Right, you'll need to have it return an object from a closure I suppose to keep it in memory privately. You don't want to store it statically for the query in general (different code paths can form different queries with different conditions as to what to include in the response etc.)
[18:12:06] <Krinkle>	 Why would you not make it include all at once?
[18:12:28] <Krinkle>	 You want to allow walking through step by step and able to stop when not needing more?
[18:12:40] <Krinkle>	 Perhaps some kind of promise-based iteration object
[18:12:59] <marktraceur>	 Yeah, that's possible
[18:13:05] * marktraceur  thinks

[18:13:10] <Krinkle>	 Good luck :)
[18:13:19] <MatmaRex>	 hey, Krinkle. you busy? :)
[18:13:23] <Krinkle>	 yes
[18:13:36] <Krinkle>	 but talk ahead, I'll answer when I can
[18:13:40] <MatmaRex>	 boo. well, good luck with the work, then :P
[18:13:51] <MatmaRex>	 i just wanted to mention that https://gerrit.wikimedia.org/r/#/c/72738/ really wants to get merged ;)
[18:13:52] <gerrit-wm>	 New patchset: Krinkle; "Unbreak cascading protection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[18:17:58] <aharoni>	 Hallo. Is there any way to see more languages in http://reportcard.wmflabs.org/graphs/articles_per_day ?
[18:19:27] <Krinkle>	 MatmaRex: checked it code wise, may test/verify later today
[18:19:28] <YuviPanda>	 aharoni: better off asking in #wikimedia-analytics
[18:21:59] <MatmaRex>	 Krinkle: i'm mostly concerned about the delegate trigger for all <a>s inside the surface now, you guys have gotten me scared that it might break stuff, and it seemed pretty straightforward to me
[18:22:10] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #100: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/100/
[18:22:14] <MatmaRex>	 ( https://gerrit.wikimedia.org/r/#/c/71249/ )
[18:26:19] <gerrit-wm>	 New patchset: Cscott; "Sync up with Parsoid tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72759
[18:27:36] <RoanKattouw>	 MatmaRex: I don't think it will break stuff, necessarily, because we don't have UI elements directly in the ce.DocumentNode. But the delegation seems a bit scary to me performance-wise and just today we discovered issues in Chrome with refocusing the document node (it scrolls)
[18:27:44] <RoanKattouw>	 So we feel like we should be careful
[18:27:51] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Run tests for WikibaseQuery" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72760
[18:28:44] <gerrit-wm>	 New patchset: PleaseStand; "Unbreak cascading protection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[18:28:44] <MatmaRex>	 RoanKattouw: yeah, but just how often are 'focus' events triggered?
[18:28:50] <MatmaRex>	 i'd say not particularly often in thiscontext
[18:29:27] <MatmaRex>	 if this was a delegated, i dunno, click, then it might not be the greatest idea ever
[18:29:53] <RoanKattouw>	 Right now, a lot unfortunately
[18:29:55] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added Serialization component" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72761
[18:30:10] <RoanKattouw>	 because we refocus the document when we come back from the format dropdown, and in some other cases
[18:30:23] <RoanKattouw>	 Rob is working on reducing this, because refocusing the document node scrolls it in Chrome
[18:31:15] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added Serialization component" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72762
[18:31:15] <MatmaRex>	 RoanKattouw: but those are fired directly on the .ve-ce-Document node?
[18:31:26] <MatmaRex>	 RoanKattouw: so theyshouldn't even go through the delegation handler?
[18:31:31] <MatmaRex>	 unless jQuery actually does that
[18:31:39] <MatmaRex>	 (also, i have no idea what i'm talking about :) )
[18:32:57] <RoanKattouw>	 Hmm you're right they are directly on the document node
[18:33:07] <RoanKattouw>	 I'm not sure that we transfer focus within it all that often in non-Opera
[18:33:41] <RoanKattouw>	 Again, this might be perfectly reasonable, it just triggers my spider senses regarding potential unintended consequences, so I want to test to make sure
[18:34:38] <gerrit-wm>	 New review: Hashar; "> I'm not sure about this -- I want the test warn but not prevent merges at the moment, and don't kn..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72221
[18:35:21] <MatmaRex>	 RoanKattouw: yeah, understood
[18:39:05] <marktraceur>	 Salut, hashar!
[18:39:21] <chrismcmahon>	 hi rachel99 go ahead and check in your next steps for the Scenario if you have them
[18:39:43] <rachel99>	 good timing..was just about to do it
[18:40:28] <hashar>	 marktraceur: Hallå Marcus
[18:40:31] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72759
[18:40:40] <marktraceur>	 I'll holla
[18:40:58] <hashar>	 though it is unlikely you speak Swedish anymore :-]
[18:41:24] <marktraceur>	 *nod* we evolved, now we speak Farsi.
[18:41:28] <gerrit-wm>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[18:41:55] <marktraceur>	 hashar: Pinged you 'cause I emailed you about a superfun UW change that got merged and should be deployed on betalabs soonish
[18:42:40] <hashar>	 marktraceur: will have to look at it later on. Daughter woke up I need to argue with her for the next hour or so about "it is night sleep, even if it is bright outside"
[18:42:41] <hashar>	  :-D
[18:42:46] <hashar>	 be back in a few
[18:43:04] <marktraceur>	 hasharAFK: Bright kid you got there.
[18:43:24] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #149: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/149/
[18:43:27] <hasharAFK>	 I need to underclock her :-D
[18:43:30] <hasharAFK>	 *wave*
[18:49:54] <hashar>	 so I am out for 2 hours and a half and I get 7 mails from engineering folks
[18:50:01] <hashar>	 marktraceur: there
[18:50:25] <marktraceur>	 Is that all? :P
[18:50:36] <hashar>	 she is smart
[18:50:46] <hashar>	 she WILL wake up again
[18:50:46] <hashar>	 and ask for a cookie
[18:50:50] <hashar>	 or whatever pass her mind :-)
[18:51:12] <hashar>	 last night she woke up just a bit before 10pm to ask to go to the park
[18:51:43] <hashar>	 Campaigns are now stored as JSON in pages in the Campaign: ns
[18:51:52] <hashar>	 robla & ori json schema are taking over the world
[18:52:26] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[19:02:20] <hashar>	 marktraceur: replied and added Yuvi in CC
[19:02:26] <marktraceur>	 Grazie
[19:02:35] <spagewmf>	 does anyone know how I can install two versions of the same PEAR package?  `pear install --installroot /tmp/newphpcs PHP_CodeSniffer-1.5.0RC2` puts the new version  in /tmp/newphpcs, but when I run /tmp/newphpcs/usr/bin/phpcs it loads all  PHP files from /usr/share/php/CodeSniffer :(
[19:03:08] <gerrit-wm>	 New review: Daniel Friesen; "There's a difference between using inheritance in your app. And inheriting from a native class which..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72453
[19:05:16] <gerrit-wm>	 New patchset: Ori.livneh; "Perform strict and verbose validation of optional 'Roles.yaml' file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[19:06:41] <gerrit-wm>	 New review: Parent5446; "There's nothing about the PHP DateTime class that makes it "not supposed to be inherited"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72453
[19:10:20] <YuviPanda>	 hashar: there?
[19:10:40] <hashar>	 spagewmf: my 2 cents : (1) do not use pear but composer   (2) pear sucks  :/
[19:11:03] <YuviPanda>	 hashar: I just managed to do everything you mentioned in the email by digging around and feeling around (with help from -labs) when I received the email :)
[19:11:25] <YuviPanda>	 hashar: so far so good. Can you tell me where the mysql server is? I need to import some data...
[19:11:33] <hashar>	 spagewmf: you might need to adjust your include path as well to make sure   /tmp/ is at the beginning of your path maybe
[19:11:35] <YuviPanda>	 (campaigns data, from commons)
[19:11:56] <hashar>	 pff
[19:12:09] <hashar>	 I am tired of contracting for Wikimedia. Too many smart people that process my emails too fast
[19:12:26] <hashar>	 YuviPanda: so hmm we don't have good sql wrapper  yet :(
[19:12:30] <YuviPanda>	 did I just get accidentally included with 'smart people'?
[19:12:31] <YuviPanda>	 :)
[19:12:50] <hashar>	 yeah :-]
[19:12:56] <hashar>	 I knew it when I install the Signpost android app
[19:13:15] <YuviPanda>	 hashar: hehe :D That thing needs updates though.
[19:13:24] <YuviPanda>	 hashar: also, can I just use mysql directly into the databases?
[19:13:28] <YuviPanda>	 hashar: where are they? -sql seems dead
[19:13:30] <hashar>	 beta has two databases, deployment-sql and deployment-sql02
[19:13:41] <hashar>	 I connect to them using:
[19:13:59] <hashar>	  USER=`php -r 'include("/home/wikipedia/common/wmf-config/PrivateSettings.php"); print $wgDBuser;'`
[19:14:00] <hashar>	  PASS=`php -r 'include("/home/wikipedia/common/wmf-config/PrivateSettings.php"); print $wgDBpassword;'`
[19:14:00] <hashar>	  mysql -u $USER -p$PASS -h deployment-sql
[19:14:15] <hashar>	 the other one is deployment-sql02
[19:14:25] <gerrit-wm>	 New review: Nikerabbit; "I can't imagine a case where this information would be useful." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/71355
[19:14:25] <YuviPanda>	 which i think is dead?
[19:14:33] <hashar>	 ah yeah  /home is dead there
[19:14:39] <hashar>	 I need to fill a bug about it :-]
[19:14:43] <Nikerabbit>	 hi YuviPanda
[19:14:47] <hashar>	 but you can connect on deployment-bastion which has the mysql client
[19:14:50] <YuviPanda>	 ohai Nikerabbit
[19:14:55] <YuviPanda>	 hashar: ah, ty :)
[19:15:06] <YuviPanda>	 hashar: also I made myself 'crat on commons betalabs, will I be stoned to death?
[19:15:29] <hashar>	 YuviPanda: also maybe you can do something nasty like:    cat import.sql | mwscript sql.php --wiki=enwiki
[19:15:44] <YuviPanda>	 hashar: also everything is on the same server?
[19:15:45] <gerrit-wm>	 New patchset: Ori.livneh; "Perform strict and verbose validation of optional 'Roles.yaml' file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[19:15:47] <spagewmf>	 hashar FYI you have to modify the main program, add set_include_path( '/tmp/newphpcs/usr/share/php' . PATH_SEPARATOR . get_include_path() );
[19:15:54] <hashar>	 YuviPanda: yeah you will be made steward eventually :-D
[19:16:07] <YuviPanda>	 hashar: that sounds like undue punishment!
[19:16:27] <hashar>	 YuviPanda: na there are two dbs. in ops/mw-config there is  wmf-config/db-labs.php
[19:16:41] <hashar>	 YuviPanda: sql02 has the wikivoyage and wikidatawiki
[19:16:46] <YuviPanda>	 ah
[19:16:47] <hashar>	 YuviPanda: everything else is on sql
[19:16:48] <YuviPanda>	 right
[19:16:53] <YuviPanda>	 so commonswiki is on this
[19:16:54] <YuviPanda>	 wonderful
[19:17:03] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355
[19:17:12] <hashar>	 spagewmf: yeah that would do it.   Or php -d include_path="/foobar" maybe
[19:17:48] <spagewmf>	 hashar no argument on (2), why bother providing an   --installroot option when you have to hand-edit the files to make it work?  ;)
[19:18:21] <hashar>	 the top #1 irritating thing about pear:    pear --help  => Command '--help' is not valid, try 'pear help'
[19:20:30] <spagewmf>	 the good news is the new CodeSniffer doesn't print 74 warnings about "Duplicate class name" when a file has multiple <?php tags.
[19:23:15] <gerrit-wm>	 New review: Cmcmahon; "after exploring the Link UI, I think you are missing a step between entering a URL in the Content bo..." [qa/browsertests] (master) C: -1;  - https://gerrit.wikimedia.org/r/71724
[19:23:54] <gerrit-wm>	 New review: Daniel Friesen; "I'm not talking about supposed. I'm talking about intended. They never wrote it intending for it to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72453
[19:27:51] <yuri_k>	 anomie, have a sec?
[19:28:00] <hashar>	 spagewmf: ah that one was really cumbersome :-D
[19:28:02] <anomie>	 yuri_k: Not right now
[19:30:47] <yuri_k>	 anomie, that's ok, no rush, when would be a good time?
[19:31:17] <YuviPanda>	 marktraceur: http://commons.wikimedia.beta.wmflabs.org/wiki/File:Screen_Shot_2012-09-01_at_3.19.40_AM.png (import finished successfully, things are being tested by odder now)
[19:31:27] <marktraceur>	 Smexy
[19:32:11] <marktraceur>	 YuviPanda: Looks like the license is wrong
[19:32:22] <YuviPanda>	 marktraceur: ? -nl to me
[19:32:26] <YuviPanda>	 marktraceur: the te
[19:32:31] <YuviPanda>	 templates haven't been imported
[19:32:34] <marktraceur>	 Ah, right.
[19:32:35] <marktraceur>	 Fine then.
[19:32:49] <YuviPanda>	 i've been looking only at wikitext to verify
[19:33:00] <YuviPanda>	 marktraceur: i gave odder sysop on betalabs, so should be sorting thes out soonish
[19:34:35] <marktraceur>	 Coolio.
[19:40:36] <gerrit-wm>	 New review: Cmcmahon; "Bug 51065" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[19:46:09] <gerrit-wm>	 New review: Ori.livneh; "No reply, so abandoning. Un-abandon if you'd like to make a case for this. Thanks for the push to im..." [mediawiki/vagrant] (master) C: -2;  - https://gerrit.wikimedia.org/r/64609
[19:48:55] <gerrit-wm>	 New patchset: Anomie; "Don't skip UserGetRights hook in addGroup/removeGroup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72765
[19:55:05] <gerrit-wm>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72766
[19:59:35] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72766
[19:59:48] <YuviPanda>	 bawolff: the huge patch got merged :)
[20:00:01] <bawolff>	 YuviPanda: Congrats. I think that's some sort of record
[20:00:09] <YuviPanda>	 bawolff: patch size?
[20:00:13] <YuviPanda>	 or patchset count?
[20:00:26] <bawolff>	 Probably the latter
[20:00:29] <YuviPanda>	 :D
[20:00:32] <MatmaRex>	 hmm
[20:00:35] <bawolff>	 Was wikidata merged as one patch
[20:00:41] <MatmaRex>	 do we have any docs about github repo replication?
[20:00:51] <YuviPanda>	 well, it's the github -> gerrit process. Seeing the github link gives a very good overview of each patchset
[20:00:54] <MatmaRex>	 or any place i could putinfo related to it?
[20:00:58] <YuviPanda>	 slash / commit
[20:01:30] <MatmaRex>	 because i've finally learned how to make Wikimedia commits show up on your github profile, and i want to share the knowledge :D
[20:01:47] <YuviPanda>	 MatmaRex: that knowledge has caused a netsplit :)
[20:01:54] <YuviPanda>	 MatmaRex: also it has *always* appeared for me...
[20:02:17] <MatmaRex>	 YuviPanda: it never did for me,because i haven't *starred the repository*.
[20:02:39] <YuviPanda>	 .....
[20:02:40] <YuviPanda>	 wut
[20:02:45] <MatmaRex>	 apparently github doesn't see the association between me and those commits if i haven't "acted on" the repository somehow
[20:02:53] <MatmaRex>	 being added as an admin, forking, or, iguess, starring it
[20:03:04] <MatmaRex>	 that's the official solution from github support, btw. :P
[20:03:11] <YuviPanda>	 ah
[20:03:16] <YuviPanda>	 so that explains it for me, since I'm admin
[20:03:29] <YuviPanda>	 MatmaRex: this has bit a fair number of people :D not sure where to put it
[20:03:32] <YuviPanda>	 email wikitech-l too :)
[20:04:52] <MatmaRex>	 hm, good idea
[20:07:39] <MatmaRex>	 YuviPanda: doned
[20:07:47] <YuviPanda>	 \o/
[20:07:53] <YuviPanda>	 lego was looking for that a while ago
[20:08:42] <MatmaRex>	 yeah, i complained about this once somewhere and i remember people complained with me. :P
[20:08:50] <YuviPanda>	 :D
[20:09:06] <YuviPanda>	 MatmaRex: now I need to complain about how my 60+ commits to UploadWizard don't count because they were merged as 1
[20:09:20] <gerrit-wm>	 New patchset: Brian Wolff; "Don't purge thumbs for old versions of an image during ?action=purge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[20:09:24] * Reedy  passes YuviPanda an e-penis pump

[20:09:40] * YuviPanda  uses it to fix Gerrit

[20:10:33] <MatmaRex>	 YuviPanda: i… have trouble imagining how would that work.
[20:10:37] <MatmaRex>	 but please don't explain.
[20:10:37] <MatmaRex>	 :D
[20:10:39] <YuviPanda>	 :)
[20:11:13] <YuviPanda>	 hmm, how do I parse some wikitext from PHP?
[20:11:28] <bawolff>	 $wgParser->parse ?
[20:11:32] <marktraceur>	 YuviPanda: Whine whine whine, it's not like you get a prize
[20:11:51] <YuviPanda>	 whine is its own reward
[20:12:01] <bawolff>	 or OutputPage -> addWikiText
[20:12:19] <YuviPanda>	 hmm, this will show up from js so I need to parse and then send it back as js config variables
[20:13:19] <bawolff>	 If you're not doing from somewhere that is in a parsing context, $wgParser->parse is probably your best bet
[20:14:08] <YuviPanda>	 bawolff: but can I safely send it downwards, without having to wrory about XSS? the parser does stripping, etc, right?
[20:14:24] <bawolff>	 Yes, the output of the parser is safe
[20:14:43] <gerrit-wm>	 New patchset: Physikerwelt; "Styling and struggling with HTTP:post" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72770
[20:15:00] <YuviPanda>	 bawolff: ah, sweet
[20:15:18] <bawolff>	 Note if you're in a hook extension, doing something like $parser->recursiveTagParse doesn't give you final html, so don't stick that into js
[20:15:39] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #141: FAILURE in 6 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/141/
[20:16:13] <YuviPanda>	 bawolff: so i'm going to take wikitext from JSON from the Content objects ad parse them out into html to send back js
[20:16:21] <YuviPanda>	 with $wgParser->parse
[20:16:34] <gerrit-wm>	 Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72770
[20:17:01] <bawolff>	 Assuming you're not already parsing something I think that should work
[20:21:14] <gerrit-wm>	 New review: Mattflaschen; "My previous comments still apply to the rebased version." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/66193
[20:22:53] <gerrit-wm>	 New review: Anomie; "Looks great! My reasoning (which I should have included earlier, sorry) is that we should be checkin..." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72211
[20:25:48] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72211
[20:26:04] <gerrit-wm>	 New review: Swalling; "Same goes for me. "Enter email address" is not clear and friendly, and ideally we'd split the messag..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/66193
[20:29:52] <gerrit-wm>	 New patchset: PleaseStand; "Update 'right-protect', 'right-autoconfirmed' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72224
[20:30:54] <gerrit-wm>	 New patchset: PleaseStand; "Update 'right-protect', 'right-autoconfirmed' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72224
[20:31:19] <MaxSem>	 mwalker, <Krinkle> MaxSem: btw, I noticed that on https://test.wikipedia.org/wiki/Main_Page?useformat=mobile there is a rather concerning request that I urge you to look into
[20:31:19] <MaxSem>	 <Krinkle> https://geoiplookup.wikimedia.org/?_=1373400794154
[20:31:19] <MaxSem>	 <Krinkle> https://bits.wikimedia.org/geoiplookup
[20:31:28] <MaxSem>	 appears only on mobile
[20:31:39] <Krinkle>	  1) There is 2 of them (why?), 2) It has cache busting parameters (why?)
[20:32:17] <mwalker>	 1) there are two of them because bits.wm.o is IPv6 capable but GeoIP is not
[20:32:29] <mwalker>	 (so we fallback to geoiplookup.wm.o which is IPv4 only)
[20:32:51] <mwalker>	 the cache busting is a mistake; but it doesn't particularly matter because the request is non cachable
[20:33:07] <gerrit-wm>	 New patchset: Mollywhite; "Bug 50988: Add i18n for the JSON error messages" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72774
[20:34:33] <GorillaWarfare>	 ori-l: You around?
[20:35:09] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72774
[20:36:38] <Krinkle>	 			// If the user has no counry assigned, we try a new lookup via
[20:36:39] <Krinkle>	 			// geoiplookup.wikimedia.org. This hostname has no IPv6 address,
[20:36:39] <Krinkle>	 			// so will force dual-stack users to fall back to IPv4.
[20:36:40] <Krinkle>	 			if ( mw.centralNotice.data.country === 'XX' ) {
[20:36:42] <Krinkle>	 				$( 'body' ).append( '<script src="//geoiplookup.wikimedia.org/"></script>' );
[20:36:44] <Krinkle>	 Aha, interesting
[20:37:18] <Krinkle>	 mwalker: So, this is somewhat odd. HTML parsing and dom manipulation to request a script. $.getScript would probably be easier. The reason it is being cache-busted is because this script tag is not being executed.
[20:37:27] <Krinkle>	 browsers don't execute or interpret script tags that are added as html strings
[20:37:51] <gerrit-wm>	 New review: Cscott; "Why did/does this patch remove newlines in parsoid-only tests?  This causes regressions for us." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[20:38:06] <Krinkle>	 but because jQuery is so tolerant it actually regexes these out for you and does a $.getScript request. and since $.ajax defaults to options.cache=false for "script", it gets the cache busting
[20:38:14] <mwalker>	 ah
[20:38:16] <mwalker>	 good to know
[20:38:21] <Krinkle>	 So this is quite fragile code, it works by accident.
[20:38:32] <mwalker>	 :) like the rest of everything
[20:38:37] <mwalker>	 give me 5 and I'll get a patch for it
[20:38:38] <gerrit-wm>	 New review: Reedy; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/59522
[20:38:57] <Krinkle>	 mwalker: I'd recommend changing to use straight up $.ajax() with type "script" and cache:true
[20:39:15] * Jasper_Deng  pokes hoo

[20:39:31] <gerrit-wm>	 New patchset: Hoo man; "Make the links in Special:AbuseLog plainlinks" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72813
[20:39:41] <hoo>	 hey Jasper_Deng :)
[20:40:01] * Jasper_Deng  wonders if hoo can investigate bugs 51007 and 51008

[20:40:08] <Krinkle>	 ajax option dataType (not type)
[20:40:18] <Jasper_Deng>	 mwalker: I did make suggestions about IPv6 support for that
[20:40:26] <Jasper_Deng>	 not a trivial thing to do, it turned out.
[20:40:46] <mwalker>	 no; we do in fact take the country if the IPv6 lookup returns something useful
[20:40:53] <mwalker>	 but... more often than not it doesn't
[20:41:02] <gerrit-wm>	 New review: Matmarex; "Whoops. Probably a rebase artifact. Do you want me to fix it?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[20:41:14] <mwalker>	 what were you suggesting?
[20:41:17] <MatmaRex>	 who is cscott on irc?
[20:41:19] <gerrit-wm>	 New review: Reedy; "Code otherwise looks fine." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59522
[20:41:22] <Jasper_Deng>	 giving it an IPv6 address
[20:41:25] <hoo>	 Jasper_Deng: One has already been fixed (and we even made an extra deployment for it)
[20:41:33] <hoo>	 The other one will need some investiagtion
[20:41:47] <hoo>	 just CC on such bugs in the future :)
[20:41:49] <YuviPanda>	 MatmaRex: cscott? :D
[20:41:50] <mwalker>	 ooh; you want geoiplookup to have a AAAA?
[20:41:58] <YuviPanda>	 MatmaRex: he's on #mediawiki-parsoid
[20:42:01] <mwalker>	 (bits already does)
[20:42:03] <MatmaRex>	 YuviPanda: well, he's not here
[20:42:04] <MatmaRex>	 ah.
[20:42:18] <YuviPanda>	 MatmaRex: too many channels, etc, etc
[20:42:22] <Jasper_Deng>	 mwalker: yes
[20:42:32] <gerrit-wm>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72830
[20:42:34] <Jasper_Deng>	 but I was told the software has no support at all
[20:42:46] <Jasper_Deng>	 even if IPv6 geolocation databases exist
[20:43:03] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72830
[20:44:16] <gerrit-wm>	 New patchset: Cscott; "Replace newlines in parsoid-only parserTests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72831
[20:45:54] <gerrit-wm>	 New review: Matmarex; "Sorry about that, rebase artifact, and I didn't check `git diff` enough times apparnetly :/" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72831
[20:49:50] <Jasper_Deng>	 hoo: are you sure it was deployed?
[20:49:59] <Jasper_Deng>	 b/c I still see filter 0 entries in mw.org's abuse log
[20:50:16] <chrismcmahlunch>	 YuviPanda: have you gone all the way through the steps at http://commons.wikipedia.beta.wmflabs.org/wiki/Special:UploadWizard ?  I'm hanging on the Upload step
[20:50:30] <gerrit-wm>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[20:50:33] <YuviPanda>	 chrismcmahon: I did, uploaded a few. brion did too, works for him...
[20:50:49] <chrismcmahon>	 YuviPanda: ok
[20:50:56] <YuviPanda>	 chrismcmahon: but that was right before hashar did some restarting and other things on the labs filesystems, so might be that?
[20:51:11] <gerrit-wm>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72832
[20:51:25] <gerrit-wm>	 New patchset: Hashar; "mw ext typo: StragegyWiki -> StrategyWiki" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72833
[20:52:10] <gerrit-wm>	 New review: Hashar; "There was a typo in the Jenkins job name. Fixed by https://gerrit.wikimedia.org/r/#/c/72833/" [mediawiki/extensions/StrategyWiki] (master) - https://gerrit.wikimedia.org/r/72816
[20:52:26] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/72467
[20:55:05] <gerrit-wm>	 New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72833
[20:59:00] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72832
[20:59:47] <gerrit-wm>	 New review: Matmarex; "I77c92896086f0fefbdbafe3a17385517ba2c4c38" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[20:59:56] <hashar>	 I am off  *waves*
[21:01:46] <spagewmf>	 YuviPanda: "so i'm going to take wikitext from JSON from the Content objects ad parse them out into html to send back js"  ?  Could you send the JSON to the client and use mw.message() and mw.api.parse() on it as needed?
[21:02:07] <YuviPanda>	 spagewmf: wouldn't that require an extra network request?
[21:02:10] <DanielK_WMDE>	 is it just me, or is gerrit unusably slow?
[21:02:17] <DanielK_WMDE>	 i mean, worse than the usual slow.
[21:02:19] <YuviPanda>	 spagewmf: and I know for a fact that it *will* be used
[21:02:25] <DanielK_WMDE>	 when using git review, not the web interface
[21:02:50] <gerrit-wm>	 New patchset: Mwalker; "Use a jQuery call instead of HTML parsing" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/72834
[21:03:32] <MatmaRex>	 DanielK_WMDE: the web interface seems rather down right now too
[21:03:56] <DanielK_WMDE>	 :/
[21:06:35] <gerrit-wm>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72836
[21:07:39] <marktraceur>	 YuviPanda: FWIW I think I may have seen the bug chrismcmahon was seeing, I just worked around it 'cause I had other stuff to get done
[21:07:56] <chrismcmahon>	 marktraceur: how did you work around it?
[21:08:01] <YuviPanda>	 marktraceur: hmm, okay. let me try, but me/odder/brion were all able to upload stuff
[21:08:14] <marktraceur>	 chrismcmahon: By checking out the commit before YuviPanda's :)
[21:08:22] <YuviPanda>	 marktraceur: did that work?
[21:08:22] <YuviPanda>	 !
[21:08:22] <wm-bot>	 ok, you just typed an exclamation mark with no meaning in the channel, good job. If you want to see a list of all keys, check !botbrain
[21:08:27] <marktraceur>	 Though I also ran update.php
[21:08:32] <chrismcmahon>	 tsk tsk marktraceur
[21:08:41] <YuviPanda>	 marktraceur: was update.php required?
[21:09:31] <marktraceur>	 YuviPanda: Naw, I just hadn't run it in a minute
[21:09:33] <gerrit-wm>	 New review: Krinkle; "Please improve commit message (perhaps mention SpecialPageFactory::getAliasList)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/59522
[21:09:43] <marktraceur>	 Er, a while.
[21:09:53] <spagewmf>	 YuviPanda: true, api.parse()  makes a request.  mediawiki.jqueryMsg does some client-side parsing including simple wiki links.
[21:10:01] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72836
[21:10:10] <YuviPanda>	 spagewmf: true, but this will probably be used for template expansion and such
[21:11:33] <gerrit-wm>	 New review: Cscott; "Poking jenkins..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72831
[21:12:44] <spagewmf>	 YuviPanda: 'dependencies' => 'parsoid' 8-)  I kid, templates have to be done server-side.
[21:13:02] <YuviPanda>	 spagewmf: :D yeah, brion mentioned the other day about how we should ship a parsoid instance inside the mobile app... :D
[21:13:16] <brion>	 haha
[21:15:38] <spagewmf>	 YuviPanda: I wonder if it would be useful to enhance RL to support parsed wiki text elements so it can cache them.
[21:16:01] <YuviPanda>	 spagewmf: might be, depending on how many people use them, I suppose.
[21:16:12] <YuviPanda>	 spagewmf: personally I'd just be happy with having a 'blessed' js templating library
[21:16:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72831
[21:16:26] <gerrit-wm>	 New patchset: Mwalker; "Use a jQuery call instead of HTML parsing" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/72834
[21:19:11] <gerrit-wm>	 New patchset: Mwalker; "Updates to the export script" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72752
[21:19:19] <gerrit-wm>	 New patchset: Cscott; "Update parsoid package.json, update domino to 1.0.12." [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/72838
[21:19:57] <gerrit-wm>	 New review: Mwalker; "We ran it; and it works! whoo" [wikimedia/fundraising/tools] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72752
[21:19:57] <gerrit-wm>	 Change merged: Mwalker; [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/72752
[21:23:22] <mwalker>	 GorillaWarfare: how goes book management?
[21:25:02] <GorillaWarfare>	 mwalker: It goes well
[21:25:11] <GorillaWarfare>	 I've started committing directly to Gerrit, so I have a lot more code up
[21:25:19] <GorillaWarfare>	 working on the JSON validation still
[21:25:47] <mwalker>	 I noticed :) do you want me to go through it; or is it still mostly rough and tumble?
[21:27:01] <spagewmf>	 GorillaWarfare: I saw https://meta.wikimedia.org/wiki/Schema:BookManagerv2 .  I think this is the first schema not used for validating events but rather validating some other data structure?
[21:27:20] <GorillaWarfare>	 spagewmf: I suppose it might be
[21:27:33] <GorillaWarfare>	 mwalker: It's pretty rough and tumble :P A lot of it is straight from EventLogging
[21:28:45] <mwalker>	 actually; spage brings up an interesting point; are you not storing your schema locally in your code?
[21:29:03] <gerrit-wm>	 New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[21:29:08] <spagewmf>	 https://meta.wikimedia.org/wiki/Schema_talk:BookManagerv2 , we need to generalize the {{SchemaDoc}} template to not assume it's always for EventLogging.  As hashar said "robla & ori json schema are taking over the world"
[21:29:08] <gerrit-wm>	 New patchset: Matmarex; "jquery.client: Detect Opera 15" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72467
[21:29:15] <mwalker>	 oh right; we talked about that... it needs to be user modifiable...
[21:29:31] <GorillaWarfare>	 mwalker: Right now, I'm storing it locally
[21:29:47] <robla>	 my understanding is that YuviPanda is working on an RFC for moving JsonSchema.php into core
[21:29:51] <GorillaWarfare>	 But yeah, I'm thinking eventually it will pull from Schema:BookManagerv2
[21:29:59] <GorillaWarfare>	 robla: Yeah, he mentioned something along those lines
[21:29:59] <ori-l>	 haha, i didn't hear hashar say that
[21:30:01] <YuviPanda>	 s/is working on/will be working on/
[21:30:12] <robla>	 hee
[21:30:40] <YuviPanda>	 spagewmf: I can't put the UploadWizard schema there since 1. It doesn't need to be user modifiable and 2. it has dynamic components.
[21:30:44] <mwalker>	 GorillaWarfare: doesn't that mean you now have a dependency on eventlogging?
[21:30:55] <mwalker>	 actually, ori-l: who installs the schema namespace/contenthandlers?
[21:31:05] <mwalker>	 is that EventLogging?
[21:31:20] <YuviPanda>	 ori-l, the contenhandler santa
[21:31:30] <YuviPanda>	 you get a namespace, but only if you are nice...
[21:32:14] <ori-l>	 mwalker: yeah, though the setup code is reproduced in zero & uw I think
[21:32:20] <spagewmf>	 GorillaWarfare: efSchemaValidate() in PHP, mw.eventLog.isValid() or assertValid() in JS?
[21:32:47] <GorillaWarfare>	 mwalker: No, "reusing" in the sense that the BookManager files are using a lot of the same code
[21:32:52] <GorillaWarfare>	 spagewmf: What?
[21:33:34] <spagewmf>	 I'm responding to (02:25:19 PM) GorillaWarfare: working on the JSON validation still.  hope that helps
[21:34:11] <ori-l>	 GorillaWarfare: feel free to ping if you have any questions about the code
[21:34:16] <GorillaWarfare>	 ori-l: Ooh, if you have a sec, mind looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=51062#c1?
[21:34:31] <GorillaWarfare>	 spagewmf: I'm not sure what you're asking, I guess..
[21:35:21] <ori-l>	 GorillaWarfare: oh, interesting. I haven't run into that. It may simply be a bug. I'll add myself as a CC to remind myself to look at the validation code later today, K?
[21:35:45] <GorillaWarfare>	 ori-l: Okay, sure
[21:35:52] <YuviPanda>	 ori-l: you mentioned that was intentional departure from the spec? ignoring extra fields?
[21:35:52] <GorillaWarfare>	 ori-l: Could also be I borked something
[21:35:56] <YuviPanda>	 or... am I remembering it wrong?
[21:36:11] <GorillaWarfare>	 YuviPanda: Oh, no, it's not validating properties that are in the schema
[21:36:18] <gerrit-wm>	 New review: Anomie; "Thanks for cleaning this up!" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72224
[21:36:19] <GorillaWarfare>	 Or wait
[21:36:32] <GorillaWarfare>	 I wonder...
[21:38:15] <GorillaWarfare>	 No, that's not it
[21:38:56] <GorillaWarfare>	 So anyway, I have "additionalProperties": false in the schema, and it indeed prevents additional properties from being included in the root
[21:39:14] <GorillaWarfare>	 But inside another object, it's allowing them
[21:39:26] <gerrit-wm>	 Change merged: Subramanya Sastry; [mediawiki/extensions/Parsoid/js/contrib] (master) - https://gerrit.wikimedia.org/r/72838
[21:39:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72224
[21:41:10] <YuviPanda>	 GorillaWarfare: ah, okay. same behavior for me too, so we're seeing the same thing.
[21:41:10] <GorillaWarfare>	 ori-l: Also, to clarify, https://bugzilla.wikimedia.org/show_bug.cgi?id=51063 is reasonable, right?
[21:41:27] <gerrit-wm>	 New review: Hazard-SJ; "As for splitting the messages, couldn't that be done in another commit?" [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/66193
[21:41:36] <YuviPanda>	 i meant extra fields everywhere, recursively. assumed that's what ori-l meant by 'departure' from spec
[21:42:17] <ori-l>	 GorillaWarfare: yes, totally
[21:42:33] <gerrit-wm>	 New review: Aaron Schulz; "This needs an inline comment so people won't repeat the mistake IMO." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72765
[21:42:33] <GorillaWarfare>	 Alright, cool :)
[21:42:36] <ori-l>	 YuviPanda: right, but it should be everywhere or nowhere; validation should not be magically relaxed as soon as you go one level deep
[21:42:45] <YuviPanda>	 yeah, sounds like a bug
[21:42:49] <YuviPanda>	 I thought itw asn't
[21:43:01] <ori-l>	 yeah, I'll have to sit with the spec and the implementations and figure things out
[21:43:19] <gerrit-wm>	 New review: Krinkle; "Html format seems fine, not yet sure about the resulting UI though. It doesn't seem obvious that the..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/72317
[21:43:22] <gerrit-wm>	 New patchset: Brion VIBBER; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[21:43:58] <GorillaWarfare>	 ori-l: So for an array that allows its contents to either be integers or arrays of integers, would this be the way to represent it in the schema? (https://meta.wikimedia.org/wiki/Schema:BookManagerv2 -- it's down at the bottom under sections->pages)
[21:44:18] <GorillaWarfare>	 Or would it be better to do like... "type": "integer|array"?
[21:44:21] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[21:44:27] <James_F>	 brion: Ooh, is that ready to merge now?
[21:44:34] <James_F>	 brion: Would be nice. :-)
[21:44:38] <gerrit-wm>	 New patchset: Spage; "Form improvements when creating another's account" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72841
[21:44:43] <lazyktm>	 MatmaRex: ill try that, thanks :D
[21:44:50] <brion>	 James_F: nope
[21:44:54] <MatmaRex>	 James_F: actually biron added fialing tests
[21:44:56] <MatmaRex>	 damn you, brion!
[21:44:57] <MatmaRex>	 :D
[21:44:59] <brion>	 it fails on the UA strings i actually have in my copy of 8.1
[21:45:13] <gerrit-wm>	 New patchset: Krinkle; "jquery.client: Detect Internet Explorer 11" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72469
[21:45:16] <brion>	 this is why you gotta test the 64-bit version too ;)
[21:45:29] <James_F>	 Ha.
[21:45:33] <MatmaRex>	 i don't have either, sorry :P
[21:45:40] <lazyktm>	 >  Pushed 1 commit to wikimedia/mediawiki-extensions-GlobalBlocking Jul 05
[21:45:44] * lazyktm  huggles MatmaRex 

[21:45:54] <MatmaRex>	 lazyktm: :D
[21:45:54] <James_F>	 brion: TBF on MatmaRex he was going on what MS told me to check for. :-)
[21:46:05] * Jasper_Deng  wonders what lazyktm's commit was for

[21:46:05] <MatmaRex>	 brion: hm, these use "rv:11" instead if "rv 11"
[21:46:16] <brion>	 heh
[21:46:20] <MatmaRex>	 brion: so that's a one-character fix in the regex
[21:46:35] <MatmaRex>	 but the article i copied that from claimed there's a space there, not a colon
[21:46:38] <brion>	 MatmaRex: James_F: well I'd consider any IE11 user-agent strings to be provisional for now, they might change
[21:46:38] <MatmaRex>	 why didn't they just use a slash? silly microsoft
[21:46:39] <gerrit-wm>	 New review: Spage; "I00e0d21d63bf32ad691ea3a27523298478e2d45c changes this message along with several others when you're..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66193
[21:46:44] <lazyktm>	 Jasper_Deng: https://github.com/wikimedia/mediawiki-extensions-GlobalBlocking/commit/091ad84d673fcd63bb5259f73ca13e7532bb05a4
[21:46:46] <ori-l>	 GorillaWarfare: I thought it was type: ["integer", "array"], but would have to look at the spec, which I'd only be able to do a little bit later
[21:46:54] <brion>	 usually they do a blog post about the new user-agent strings before each major IE release
[21:47:01] <James_F>	 brion: Indeed.
[21:47:10] <MatmaRex>	 brion: well, i'd just add the colon in therefor now and we'll recheck that later
[21:47:19] <MatmaRex>	 and by we, i mean James. :P
[21:47:21] <brion>	 yeah
[21:47:22] <brion>	 heh
[21:47:23] <Jasper_Deng>	 oh I have a huge laundry list of faulty interface messages that really should get fixed
[21:47:29] <GorillaWarfare>	 ori-l: And how do you validate that the nested array only has integers?
[21:47:42] <gerrit-wm>	 New review: Catrope; "Looks good to me and works well, should be good to merge except for the issues Krinkle pointed out." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72317
[21:48:08] <brion>	 MatmaRex: http://blogs.msdn.com/b/ie/archive/2012/07/12/ie10-user-agent-string-update.aspx <- here's their post on the ie10 string format, which looks similar
[21:48:12] <brion>	 to the 11 ones so far
[21:48:23] <spagewmf>	 FYI there's http://jsonschemalint.com/ which claims to validate against the Draft 03 specification
[21:48:34] <ori-l>	 GorillaWarfare: I'm half on IRC, half filling out expense reports, and am botching both due to inattention :) I have to finish the paperwork stuff but can look at the bug report later this evening.
[21:48:49] <GorillaWarfare>	 ori-l: Sure, no problem
[21:48:53] <brion>	 except for switching out the MSIE and the revision :P
[21:49:29] <Krinkle>	 brion: also in their library http://msdn.microsoft.com/en-us/library/ie/hh920767(v=vs.85).aspx
[21:49:35] <brion>	 oh yay
[21:49:42] <brion>	 permanent doc locations are good
[21:49:48] <brion>	 even if they are fucking msdn urls with random numbers ;)
[21:49:53] <brion>	 it's like wikidata urls…. haha
[21:49:54] <Krinkle>	 and for 11 http://msdn.microsoft.com/en-us/library/ie/bg182625(v=vs.85).aspx
[21:50:07] <brion>	 \o/
[21:50:14] <brion>	 i'd been looking for that
[21:50:18] <brion>	 maybe i should have used bing instead of google
[21:50:25] <Krinkle>	 yeah, those pages are virtually unreachable. Google gave it to my by luck
[21:50:39] <Krinkle>	 https://www.google.com/search?q=msdn+ie11+user+agent
[21:50:53] <gerrit-wm>	 New patchset: MarkTraceur; "Add mediawiki.api.query and getAndContinue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844
[21:50:55] <marktraceur>	 Krinkle: ^^
[21:51:03] <brion>	 I will say it tickles me pink that IE reports itself as "like gecko" :D
[21:51:56] <brion>	 "The navigator.appName property now returns "Netscape" to reflect the HTML5 standard and to match behavior of other browsers." lol
[21:52:05] <RoanKattouw>	 Ahm, wat
[21:52:14] <MatmaRex>	 it's in the html5 spec.
[21:52:17] <RoanKattouw>	 returning Netscape "reflects the HTML5 standard"?
[21:52:20] <MatmaRex>	 and something being "Gecko" too
[21:52:20] <RoanKattouw>	 Really?
[21:52:21] <MatmaRex>	 yep
[21:52:26] <MatmaRex>	 100% serious
[21:52:28] <MatmaRex>	 :D
[21:52:36] <YuviPanda>	 the 90s called...
[21:52:49] <brion>	 html5… it's not the standard we wanted, but it's the standard we deserved
[21:53:16] <marktraceur>	 brion: I'd watch that move
[21:53:18] <marktraceur>	 movie*
[21:53:45] <brion>	 maybe an audiobook? "The HTML5 spec, as read by Bane"
[21:54:14] <marktraceur>	 brion: Some people just want to watch Netflix implemented in pure HTML5
[21:54:20] <brion>	 haha
[21:54:47] <Krinkle>	 RoanKattouw: Yeah, it is basically the standard since early 90s browser sniffing used that to see whether things like iframes were supported
[21:55:02] <Krinkle>	 which is why navigator.appName has become useless
[21:55:20] <marktraceur>	 Actually making a short commercial for this as the story of the 'net trying to take down DRM in HTML5 might be pretty cool.
[21:55:36] <YuviPanda>	 man, this is going to eventually become 'because the bible said...'
[21:55:36] <ebernhardson>	 how to construct a browser user agent string:  top browser of 1995 + top browser of 2001 + top browser of 2008 + your browser :)
[21:55:36] <Krinkle>	 it is basically non-standard values before and then at some point Netscape came along and did something that got standardized and they got their way to get it in the standard
[21:56:08] <MatmaRex>	 ebernhardson: have you seen Opera 15's user-agent?
[21:56:13] <Krinkle>	 http://webaim.org/blog/user-agent-string-history/
[21:56:23] <MatmaRex>	 Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.52 Safari/537.36 OPR/15.0.1147.130
[21:56:25] <Krinkle>	 Yeah, Opera tops Chrome
[21:56:27] <MatmaRex>	 there's five browsers in here
[21:56:30] <MatmaRex>	 opera is not one of them. :P
[21:56:31] <RoanKattouw>	 OPR?
[21:56:37] <MatmaRex>	 OPR.
[21:56:39] <lazyktm>	 MatmaRex: my feed on github is just a bunch of wikimedians starring a bunch of wikimedia/* repos :P
[21:56:43] <ebernhardson>	 MatmaRex: cant say i have,  although i guess i have now :)
[21:56:48] <MatmaRex>	 lazyktm: :D
[21:56:54] <brion>	 jeebus Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.52 Safari/537.36 OPR/15.0.1147.132
[21:57:11] <YuviPanda>	 marktraceur: chrismcmahon i can reproduce it. it errors out if you try to upload without a campaign
[21:57:34] <Krinkle>	 Opera switched away from "Opera/x" for the same reason Microsoft turned away from "MSIE x". People were doing unversioned checking
[21:57:36] <Krinkle>	 actually, this is the second time Opera has did it
[21:57:44] <brion>	 blackberry 10 dropped 'blackberry' from the UA for the same reason
[21:58:00] <MatmaRex>	 the first time they did it in a saner way, though
[21:58:02] <brion>	 anybody doing compatibility checking for old blackberries was gonna send you to some shit old page ;)
[21:58:06] <Krinkle>	 They did it with 10 as well (they still have "Opera/9.80" in Opera 11 and 12 with another "Version/12.0" that is the real version
[21:58:09] <YuviPanda>	 marktraceur: chrismcmahon err, did someone just remove UploadWizard from betalabs?
[21:58:19] <YuviPanda>	 http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard&debug=True is 404
[21:58:30] <brion>	 YuviPanda: you want a ? in there
[21:58:32] <brion>	 not &
[21:58:32] <marktraceur>	 Wasn't me
[21:58:41] <marktraceur>	 Ah,
[21:58:44] <YuviPanda>	 I...
[21:59:01] <YuviPanda>	 sorry
[21:59:30] <Krinkle>	 lazyktm: What's your github name?
[22:00:09] <marktraceur>	 Krinkle: Is $.each for an array a no-no? I've had vague nasty feelings about that for a while, it's an UploadWizardism...
[22:00:11] <spagewmf>	 GorillaWarfare: "pages" : { "type" : [ "integer", "array" ] }  meets the spec, but it allows "pages": [ 5, [3, "bad", 7] ].  I think to validate deeper you'd need to reference another schema.
[22:00:59] <YuviPanda>	 marktraceur: confirmed, I broke uploadwizard without a campaign in it. fix on the way
[22:01:07] <Krinkle>	 marktraceur: See [[mw:CC/JS]]. It comes down to at least making it clear what you're iterating over (e.g. name/value vs. i/value). and for arrays I'd prefer for(i=0, i<len)
[22:01:31] <marktraceur>	 I like that way better too.
[22:01:32] <gerrit-wm>	 New patchset: Mwalker; "Updating DonationInterface to current master" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/72845
[22:02:42] <marktraceur>	 YuviPanda: Great jearb
[22:02:54] * marktraceur  takes appropriate amount of blame for this

[22:02:54] <GorillaWarfare>	 spagewmf: Yeah, that was my concern
[22:03:03] <MatmaRex>	 marktraceur: just don't mix and match
[22:03:05] <MatmaRex>	 tablesorter does that, and it's awful
[22:03:39] <marktraceur>	 MatmaRex: I'm using normal-for for arrays and $.each for objects, seems sane to me
[22:05:04] <gerrit-wm>	 New patchset: MarkTraceur; "Add mediawiki.api.query and getAndContinue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844
[22:05:05] <MatmaRex>	 hm. fair enough
[22:05:09] <gerrit-wm>	 New patchset: Mwalker; "Update for Luhn Check" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/72846
[22:05:23] <MatmaRex>	 marktraceur: although for(i in o) would work as well, no? (with o.hasOwnProperty(i) if you feel like some extra safety is needed)
[22:05:30] <spagewmf>	 GorillaWarfare: well, sometimes you have to express intent the best you can in code and let documentation handle the rest :)
[22:05:47] <marktraceur>	 MatmaRex: Ugh.
[22:05:51] <marktraceur>	 That is all.
[22:06:18] <MatmaRex>	 haha
[22:06:31] <MatmaRex>	 use coffeescript :P
[22:06:38] <MatmaRex>	 (just kidding, it's annoying to use, please don't)
[22:06:54] <MatmaRex>	 they made *commas* optional. commas.
[22:06:57] <MatmaRex>	 that's just too much for me.
[22:07:10] <gerrit-wm>	 New patchset: Mwalker; "Update for Luhn Check" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/72846
[22:07:50] <lazyktm>	 Krinkle: "legoktm"
[22:08:08] <Krinkle>	 MatmaRex: for-in on arrays, note that you'll have string values as your key in that case, it may contain gaps, and the iteration order will not be consistently from low to high, and (though this next one is a bad reason) if you array has non-numerical keys (since Array is just a subclass of Object) a for-in on an array would include those props too
[22:08:44] <MatmaRex>	 Krinkle: yeah, i meant for..in on objects
[22:08:54] <Krinkle>	 Right, yeah, that's fine.
[22:08:59] <MatmaRex>	 brb
[22:11:31] <spagewmf>	 MatmaRex:  Coco, for when CoffeeScript isn't radical enough.  https://github.com/satyr/coco/wiki/side-by-side-comparison :)
[22:12:37] <gerrit-wm>	 New patchset: Krinkle; "mw.Map: Fix typos in documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72848
[22:13:25] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/72846
[22:13:38] <gerrit-wm>	 New patchset: Krinkle; "mw.Map: Fix typos in documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72848
[22:15:01] <gerrit-wm>	 New review: MarkTraceur; "Trivial" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72848
[22:15:39] <marktraceur>	 Aye sah.
[22:16:54] <YuviPanda>	 spagewmf: is... someone writing something in coco again?
[22:20:08] <marktraceur>	 Sigh, don't make functions within a loop.
[22:20:15] <marktraceur>	 Krinkle: ^^ that's a stupid rule
[22:20:53] <marktraceur>	 I mean, the "obj is not defined" one is more important.
[22:21:36] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[22:22:03] <gerrit-wm>	 New patchset: MarkTraceur; "Add mediawiki.api.query and getAndContinue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72844
[22:22:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72848
[22:24:36] <MatmaRex>	 spagewmf: heh. did the [^a-z] range physically hurt those guys? ;)
[22:25:10] <MatmaRex>	 actually, hm, there's a lot of sigilfurther down.
[22:25:45] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[22:25:54] <MatmaRex>	 lol, the dicts
[22:25:59] <MatmaRex>	 really
[22:26:11] <MatmaRex>	 wow
[22:26:18] <MatmaRex>	 i don't even want to see the parser for this thing
[22:26:31] <YuviPanda>	 MatmaRex: are you talking about Coco? :)
[22:26:35] <MatmaRex>	 !=x
[22:26:35] <wm-bot>	 There is no such key, you probably want to try: !MediaWiki:nosuchactiontext, 
[22:26:36] <MatmaRex>	 whaaaa
[22:26:41] <MatmaRex>	 YuviPanda: yes
[22:26:48] <MatmaRex>	 "#str" * num - /\D+/g
[22:26:49] <MatmaRex>	 gods
[22:26:51] <YuviPanda>	 MatmaRex: yeah, I... am not a fan.
[22:27:03] <YuviPanda>	 MatmaRex: Limn is written in it, which is frustrating.
[22:27:10] <YuviPanda>	 (github.com/wikimedia/limn)
[22:27:15] <gerrit-wm>	 New patchset: SuchABot; "Fix JS error when using uploadwizard without campaigns" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72850
[22:27:23] <MatmaRex>	 biggest = a >? b
[22:27:25] <marktraceur>	 Oh my gods.
[22:27:31] <MatmaRex>	 what's wrong with a max() function?
[22:27:38] * marktraceur  mumbles something about using Gerrit like everyone else

[22:27:39] <YuviPanda>	 marktraceur: http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard&debug=True
[22:27:45] <YuviPanda>	 err
[22:27:46] <YuviPanda>	 wrong url
[22:27:52] <YuviPanda>	 marktraceur: https://gerrit.wikimedia.org/r/#/c/72850/
[22:27:54] <marktraceur>	 I can see it
[22:27:59] <YuviPanda>	 indeed :)
[22:28:18] <MatmaRex>	 seriously
[22:28:26] <MatmaRex>	 there is a point where syntax evolutionneeds to stop
[22:28:30] <YuviPanda>	 marktraceur: *you* are using gerrit like everyone else, *I* am using GitHub... :)
[22:28:31] <MatmaRex>	 these guys have passed it
[22:28:49] <YuviPanda>	 MatmaRex: well, evolution needn't stop. These are probably a dead end. 3 commits to their master in the last 2 months.
[22:28:50] <MatmaRex>	 "Coco is a CoffeeScript dialect that aims to be more radical and practical."
[22:28:50] <marktraceur>	 YuviPanda: Dunno why you wouldn't just use the same thing as everyone
[22:28:52] <MatmaRex>	 you don't say.
[22:29:05] <YuviPanda>	 marktraceur: dogfooding, remember?
[22:29:17] <MatmaRex>	 Principles
[22:29:18] <MatmaRex>	 Die for DRY.
[22:29:20] * marktraceur  forgets what it means but faintly recalls

[22:29:20] <MatmaRex>	 Perl over Ruby.
[22:29:27] <MatmaRex>	 well, they sure got that part right at least
[22:29:39] <marktraceur>	 Ah. Yes.
[22:29:48] <MatmaRex>	 :)
[22:30:10] * marktraceur  uploads 50 images

[22:30:37] <gerrit-wm>	 New review: Cmcmahon; "this seems to cause some flaky behavior" [mediawiki/extensions/UploadWizard] (master) C: 1;  - https://gerrit.wikimedia.org/r/72850
[22:31:20] <gerrit-wm>	 New review: Cmcmahon; "better said:  this change seems to fix some flaky behavior, sorry" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72850
[22:31:53] <YuviPanda>	 chrismcmahon: hehe, at cause vs fix :)
[22:32:00] <YuviPanda>	 chrismcmahon: do the tests pass with this enabled?
[22:32:17] <gerrit-wm>	 New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[22:33:02] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72763
[22:33:22] <gerrit-wm>	 New patchset: Shirayuki; "Grammar correction" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72851
[22:34:02] <gerrit-wm>	 New review: Aaron Schulz; "Can the "Try purging" bit be moved to a gerrit comment?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[22:36:03] <chrismcmahon>	 YuviPanda: is that change up to beta now?  I'm thinking not...
[22:36:12] <YuviPanda>	 chrismcmahon: marktraceur hasn't merged it yet
[22:38:56] * marktraceur  merges

[22:39:04] <YuviPanda>	 marktraceur: <3
[22:39:21] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72850
[22:39:42] <marktraceur>	 YuviPanda: I was going to ask you to fix two hundred other things
[22:39:48] <marktraceur>	 But then I figured, nawww
[22:39:57] <YuviPanda>	 marktraceur: two hundred other things I broke? :)
[22:40:28] <marktraceur>	 I think you're only up to 153.
[22:40:33] <gerrit-wm>	 New patchset: Bsitu; "Fix the alias case for SpecialListGroupRights" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72853
[22:43:04] <gerrit-wm>	 New review: Krinkle; "Untested, code looks good." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/72614
[22:43:33] <YuviPanda>	 marktraceur: ah :)
[22:43:46] <YuviPanda>	 marktraceur: well, would've been interesting if that patch never got merged until *everything* was fixd
[22:44:21] <marktraceur>	 *nod*
[22:44:34] <gerrit-wm>	 New patchset: Cscott; "Sync up with Parsoid tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72854
[22:45:08] <marktraceur>	 New patchset: YuviPanda; "Fix UploadWizard" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/100000
[22:45:23] <YuviPanda>	 haha :D
[22:47:28] <gerrit-wm>	 New patchset: Mwalker; "Allowing display of stats for 2013 General Fundraiser 1" [mediawiki/extensions/ContributionReporting] (master) - https://gerrit.wikimedia.org/r/72855
[22:48:08] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[22:51:11] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72854
[22:51:56] <gerrit-wm>	 New patchset: Hoo man; "Make global AbuseFilters searchable on Special:AbuseLog" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72856
[22:55:50] <gerrit-wm>	 New patchset: Brian Wolff; "Don't purge thumbs for old versions of an image during ?action=purge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[22:56:08] <robla>	 csteipp: are all of the patches deployed for the SUL stuff?
[22:56:22] * robla  still sees at least one bug

[22:56:29] <csteipp>	 robla: not yet. Still working on them
[22:56:39] <gerrit-wm>	 New review: Brian Wolff; "[[commons:File:Bearbeitungsstand_Denkmale_?sterreichs_nach_Gemeinden_Bilder.svg]] is an example file..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[22:56:41] <robla>	 k...thx
[22:58:52] <bawolff>	 Krinkle: I'm confused what you mean by your comment at https://gerrit.wikimedia.org/r/#/c/72769/1//COMMIT_MSG
[22:58:56] <gerrit-wm>	 New review: Katie Horn; "woo!" [mediawiki/extensions/ContributionReporting] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72855
[22:58:57] <gerrit-wm>	 Change merged: Katie Horn; [mediawiki/extensions/ContributionReporting] (master) - https://gerrit.wikimedia.org/r/72855
[22:59:18] <Krinkle>	 bawolff: https://gerrit.wikimedia.org/r/#/c/72769/1/includes/revisiondelete/RevisionDelete.php
[23:00:22] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/72853
[23:00:30] <bawolff>	 Krinkle: Previously $file->purgeCache() line did what I added to RevisionDelete.php
[23:01:02] <superm401>	 Anyone know what the media query max-width corresponds to?
[23:01:03] * marktraceur  points bawolff at https://gitorious.org/categoryslideshow/categoryslideshow

[23:01:10] <marktraceur>	 Hacky, ugly
[23:01:14] <superm401>	 In other words, if I want to see what the media query would consider the current width.
[23:01:22] <superm401>	 $(window).width() doesn't seem to be it, in Firefox.
[23:01:27] <mwalker>	 greg-g: can I sneak in on today's LD?
[23:01:29] <marktraceur>	 But functional
[23:01:41] <RoanKattouw>	 superm401: Have you tried to play with .outerWidth() ?
[23:02:06] <bawolff>	 Krinkle: So its related to bug 30192 in so much as if I didn't add it back after removing it from the other method, there would be a regression of that bug
[23:02:38] <superm401>	 RoanKattouw, same as width in Firefox, apparently.
[23:03:04] <Krinkle>	 bawolff: right, but the commit message suggested that most places already have this call and that the one you're removing is redundant, I guess this is an exception?
[23:03:14] <YuviPanda>	 anyone who's done anything with the parser before? :D
[23:03:22] <YuviPanda>	 does it always wrap things into <p>s?
[23:03:27] <MatmaRex>	 superm401: window.innerWidth?
[23:03:38] <bawolff>	 Yes. When the commit for bug 30192 went through none of the places had the redundant call. Now all of them except revdel do
[23:04:03] <wmf-selenium-bot>	 Yippie, build fixed!
[23:04:04] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #155: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/155/
[23:04:18] <bawolff>	 marktraceur: woo!
[23:04:44] <marktraceur>	 bawolff: If I can get Ryan_Lane to make us a labs project I'll even put it on a wiki soon.
[23:04:48] * marktraceur  looks at Ryan_Lane

[23:04:52] <Ryan_Lane>	 heh
[23:05:01] <greg-g>	 mwalker: yes!
[23:05:09] <Ryan_Lane>	 this was for multimedia?
[23:05:09] <MatmaRex>	 superm401: there's a lengthy acticle about that at http://www.quirksmode.org/mobile/viewports.html ;)
[23:05:12] <Ryan_Lane>	 one sec
[23:05:13] <marktraceur>	 'twas
[23:05:15] <marktraceur>	 Grazie
[23:05:21] <bawolff>	 :D
[23:05:28] <marktraceur>	 bawolff: See, once you're actually waiting on him he's quick. :P
[23:05:29] <mwalker>	 greg-g: awesome -- adding my patch to wikitech now; anyone currently in the window?
[23:05:43] <greg-g>	 mwalker: nope!
[23:06:13] <bawolff>	 marktraceur: I love the syntax highlighting of the license comment block at https://gitorious.org/categoryslideshow/categoryslideshow/blobs/master/CategorySlideShow.php
[23:06:31] <marktraceur>	 Hee
[23:06:56] <Ryan_Lane>	 marktraceur: done
[23:07:03] <YuviPanda>	 chrismcmahon: did that commit fix the browser tests?
[23:07:05] <marktraceur>	 Thanks!
[23:07:09] <Ryan_Lane>	 yw
[23:07:30] <gerrit-wm>	 New review: Cscott; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72854
[23:07:34] <chrismcmahon>	 YuviPanda: those builds are almost finished, will report shortly
[23:07:41] <wmf-selenium-bot>	 Yippie, build fixed!
[23:07:41] <YuviPanda>	 ty
[23:07:42] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #57: FIXED in 3 min 37 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/57/
[23:08:00] <marktraceur>	 Now hopefully I have appropriate SSH keys on this machine.
[23:08:07] <bawolff>	 Krinkle: So to clarify, should I change the commit message to say something like "however since then most of the places it was needed added other calls to do the purge except for revision deletion."?
[23:08:27] <superm401>	 MatmaRex, somehow jQuery treats a whole bunch as the same.
[23:08:38] <superm401>	 Apparently it only wants you to use width() on window.
[23:09:49] <gerrit-wm>	 New patchset: Mwalker; "Updating ContributionReporting to master for 2013 fundraiser" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72857
[23:09:53] <Krinkle>	 bawolff: that sentence is getting rather long and hard to interpret, I lost context after "it was needed added other calls"
[23:10:35] <Krinkle>	 bawolff: but yeah, something like that "[..] to do purge explicitly. Except for RevisionDelete which still relied on it being done automatically"
[23:10:56] <Krinkle>	 or whatever terminology makes sense
[23:11:39] <MatmaRex>	 superm401: yeah, jquery is a mess.
[23:12:22] <chrismcmahon>	 YuviPanda: Firefox build is back to green, Chrome build still had a single UW failure but I'm thinking it's probably just a flaky run, double-checking now
[23:12:30] <YuviPanda>	 chrismcmahon: ok
[23:12:40] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72857
[23:13:08] <gerrit-wm>	 New patchset: Brian Wolff; "Don't purge thumbs for old versions of an image during ?action=purge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72769
[23:13:29] <bawolff>	 Krinkle: updated message
[23:13:46] <chrismcmahon>	 YuviPanda:  I noticed a little while ago that UW now has a prompt if Category is not filled in, that's now in the test, so nice to see the build green for that too.
[23:14:03] <YuviPanda>	 chrismcmahon: \o/
[23:14:19] <YuviPanda>	 I think that was something Nischayn22 added.
[23:16:41] * AaronSchulz  notes that gwicke seems quite today

[23:16:51] <gerrit-wm>	 New review: EBernhardson; "needs rebase" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621
[23:16:59] <YuviPanda>	 anyone who knows anything about the parser around?
[23:17:10] <YuviPanda>	 does it always surround things with a <p>?
[23:17:10] <mwalker>	 greg-g: all done
[23:17:21] <RoanKattouw>	 YuviPanda: Yes
[23:17:21] <YuviPanda>	 (using OutputPage->parse( ) '
[23:17:22] <YuviPanda>	 )
[23:17:22] <bawolff>	 YuviPanda: There's an option you can pass it
[23:17:29] <bawolff>	 to mark it not first line
[23:17:30] <RoanKattouw>	 bawolff: No, that's just in Message.php
[23:17:31] <bawolff>	 I think
[23:17:49] <RoanKattouw>	 Read the wfMessage( ... )->parse() (as opposed to parseAsBlock) implementation and weep
[23:17:51] <YuviPanda>	 RoanKattouw: so I can sortof assume that and strip that out later on?
[23:18:13] <RoanKattouw>	 This has already been done before. I refer to my "... and weep" comment
[23:18:21] <bawolff>	 I thought the fourth argument to Parser::parse controlled that...
[23:18:21] <YuviPanda>	 ... okay
[23:18:47] <gerrit-wm>	 New patchset: Parent5446; "Added fallback information to LocalisationCache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72866
[23:19:05] <gerrit-wm>	 New patchset: Parent5446; "Complete usage of message fallback chain" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72867
[23:19:21] <RoanKattouw>	 bawolff: May be, but Message.php doesn't use it AFAICT
[23:19:28] <YuviPanda>	 bawolff: testing that hypotheses
[23:19:48] <YuviPanda>	 bawolff: nope
[23:19:48] <YuviPanda>	 still gettin ps
[23:19:54] <bawolff>	 hmm, guess it must do something else
[23:20:58] <bawolff>	 yeah, if there was an easy way, I guess the ugliness in Message.php wouldn't happen
[23:22:13] <YuviPanda>	 bawolff: true. I'm just stripping the <p>s there
[23:22:18] <YuviPanda>	 and saving myself some weeping
[23:24:45] <gerrit-wm>	 New patchset: Mattflaschen; "Improve wording of toolbar." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/72868
[23:25:02] <gerrit-wm>	 New review: Mattflaschen; "Pending discussion." [mediawiki/extensions/GettingStarted] (master) C: -2;  - https://gerrit.wikimedia.org/r/72868
[23:25:03] <greg-g>	 mwalker: awesomesauce
[23:27:56] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72854
[23:29:00] <chrismcmahon>	 YuviPanda: UW feels a bit slow in Chrome, but seems to dtrt
[23:29:30] <YuviPanda>	 chrismcmahon: hmm, not just betalabs being slower?
[23:29:53] <chrismcmahon>	 YuviPanda: hard to say, FF was zippy, but might have just been timing
[23:29:54] <YuviPanda>	 marktraceur: btw, re: UploadWizard release, I believe that we should do a 'release' only after your JS refactor stuff lands
[23:30:00] <YuviPanda>	 chrismcmahon: yeah, probably.
[23:30:29] <YuviPanda>	 marktraceur: any objections? we might even bump the number up a fair bit if that happens
[23:32:16] <gerrit-wm>	 New review: Tim Starling; "It's a really clear case, not because of PHP or MW quirks, but because of the change of interface be..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72453
[23:35:42] <AaronSchulz>	 TimStarling: inheritance hater! ;)
[23:35:52] <gerrit-wm>	 New patchset: SuchABot; "Enable use of wikitext in field labels" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/72869
[23:37:09] <gerrit-wm>	 New review: Ryan Lane; "Inline JS should be avoided. Comments inline." [mediawiki/extensions/UserMerge] (master) C: -1;  - https://gerrit.wikimedia.org/r/70671
[23:39:07] <TimStarling>	 AaronSchulz: did you see what he was doing? inheriting from DateTime then overriding most of its methods with completely different semantics
[23:39:25] <TimStarling>	 so there was no way for an external caller to access the original DateTime methods if that was actually what you wanted
[23:40:41] <TimStarling>	 speaking of hating inheritance, I was wondering if you really want to insist on the use of closures for https://gerrit.wikimedia.org/r/#/c/72067/
[23:41:05] <TimStarling>	 you know I give you a lot of leeway w.r.t. style when I review your patches
[23:41:44] <AaronSchulz>	 TimStarling: I was joking about the inheritance bit
[23:42:08] <AaronSchulz>	 TimStarling: so you saw my other patch?
[23:42:33] <TimStarling>	 what other patch?
[23:42:53] <gerrit-wm>	 New review: Kaldari; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: -1;  - https://gerrit.wikimedia.org/r/72357
[23:42:54] <AaronSchulz>	 I was faffing around with https://gerrit.wikimedia.org/r/#/c/72671/
[23:43:15] <AaronSchulz>	 though it manually did the filter stuff, that would be OK too
[23:43:19] <TimStarling>	 I see
[23:43:20] <AaronSchulz>	 *if it manually
[23:43:22] <yuri_k>	 TimStarling, do you know if there has been a discussion about pubsubhubbub for MW?
[23:43:40] <TimStarling>	 yuri_k: seems unlikely
[23:44:06] <YuviPanda>	 yuri_k: me and Dantman were lazily talking about it the other day, nothing serious.
[23:44:22] <yuri_k>	 seems unlikely that it should/will happen, or that anyone has discussed it?
[23:44:44] <yuri_k>	 YuviPanda, yeah, wikia had been asking for that, as well as google and others
[23:44:55] <YuviPanda>	 yuri_k: oh, I wasn't aware of that
[23:45:20] <gerrit-wm>	 New review: Ryan Lane; "(1 comment)" [mediawiki/extensions/UserMerge] (master) C: 2;  - https://gerrit.wikimedia.org/r/70671
[23:45:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/70671
[23:45:33] <YuviPanda>	 yuri_k: start a discussion? :D
[23:46:20] <yuri_k>	 nah, implement first, asq questions later
[23:46:44] * yuri_k  changes his life's motto

[23:49:19] <YuviPanda>	 are our jQuery versions old enough that we can't do $.parseHTML?!
[23:49:19] <marktraceur>	 YuviPanda: Sounds good to me
[23:49:21] * YuviPanda  checks

[23:49:43] <gerrit-wm>	 New review: Yuvipanda; "brb, making this backwards compatibile." [mediawiki/extensions/UploadWizard] (master) C: -1;  - https://gerrit.wikimedia.org/r/72869
[23:50:08] <marktraceur>	 Hah, brb.
[23:50:21] <marktraceur>	 Wait, which patch is that?
[23:50:44] <YuviPanda>	 marktraceur: for two other 'nice to have' bugs that odder poked me about, and I agree with him on that
[23:50:46] <YuviPanda>	 marktraceur: rather small
[23:51:23] <marktraceur>	 Ah K.
[23:52:24] <TimStarling>	 AaronSchulz: maybe if reround was replaced by an actual word, I could approve that ;)
[23:53:02] <AaronSchulz>	 TimStarling: I saw that on a dictionary site when I googled that yesterday
[23:53:17] <TimStarling>	 ok, you win
[23:53:41] <gerrit-wm>	 New review: Adamw; "Obstinate responses inlined." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72669
[23:54:08] <TimStarling>	 ah, but it is not in wiktionary or dict.org
[23:54:19] <AaronSchulz>	 gah, typo, I see
[23:54:27] <TimStarling>	 so maybe you don't win
[23:54:32] <gerrit-wm>	 New patchset: Kaldari; "Fix confirmThanks() for Diff view" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/72357
[23:54:42] <AaronSchulz>	 TimStarling: I actually had "reround", not "rewound"?
[23:54:43] * AaronSchulz  looks

[23:54:48] <TimStarling>	 yes, twice
[23:55:01] <TimStarling>	 three times, even
[23:55:20] <TimStarling>	 like you made a typo in your brain and then correctly transferred it to the code
[23:55:28] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/72357
[23:55:29] <AaronSchulz>	 well I use an IDE and tested it in eval.php, so if it has a typo it will be everywhere
[23:55:33] <AaronSchulz>	 otherwise it would just give warnings
[23:55:40] <AaronSchulz>	 I don't know why this always surprises you
[23:56:16] <YuviPanda>	 marktraceur: hmm, thoughts on making a breaking change that can not be automatically migrated, but needs human work?
[23:56:25] <YuviPanda>	 not much, mind you - and it does provide a rather very desirable feature
[23:56:42] <YuviPanda>	 it's also easyish to provide backwards compat, at the cost of muddling the code some more.
[23:56:53] <YuviPanda>	 I personally want to break backwards compat.
[23:56:57] <TimStarling>	 in my day, IDEs didn't have this new-fangled autocomplete
[23:57:26] * Dantman  feels a disturbance in the force.

[23:57:40] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: avoid exceptions due to races in redis job listing functions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72671
[23:57:45] <YuviPanda>	 marktraceur: will you be ok merging such a change?
[23:57:52] <marktraceur>	 YuviPanda: You should be more descriptive
[23:58:03] <YuviPanda>	 marktraceur: okay, right. whytf am I talking in general terms?!
[23:58:10] <Dantman>	 Agh...  and the public logs are messed up.
[23:58:25] <YuviPanda>	 marktraceur: so, labelPage is currently a 'page name', which is retreived and then used as label
[23:58:38] <YuviPanda>	 marktraceur: unparsed. This means that a lot of things that teh WLM folks want to do can't be done (links, etc)
[23:59:00] <TimStarling>	 I think I tried a PHP IDE or two, but I always found some excuse to go back to gvim
[23:59:01] <YuviPanda>	 marktraceur: there already exists 'label', which is just a plain text string and pretty much useless (i18n, etc)
[23:59:11] <gerrit-wm>	 New patchset: Parent5446; "Added fallback information to LocalisationCache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72866
[23:59:23] <YuviPanda>	 marktraceur: so I jsut made label accept wikitext, parse and display it. Now labelPage is redundant, and should be killed
[23:59:37] <YuviPanda>	 marktraceur: except that wikis currently use labelPage, since that is the only way to do i18n.
[23:59:47] <YuviPanda>	 marktraceur: that'll have to be replaced by {{int:}}, which can't be done automatically
[23:59:51] <marktraceur>	 Aha.
[23:59:53] <YuviPanda>	 marktraceur: so, it'll have to be a manual job.