[00:03:54] <gerrit-wm>	 New review: Tim Starling; "It's OK with me to do these two queries on each diff page view." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72317
[00:09:27] <MatmaRex>	 yay tim. thanks.
[00:18:22] <gerrit-wm>	 New patchset: Hoo man; "Make use of the APIEditBeforeSave hook for nicer errors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[00:19:46] <gerrit-wm>	 New review: Hoo man; "Addressed Anomie's comments (forward compatibility and output properties)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[00:35:32] <gerrit-wm>	 New patchset: Hoo man; "Make use of the APIEditBeforeSave hook for nicer errors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[00:36:56] <gerrit-wm>	 New review: Hoo man; "Fixed code to get the summary (EditPage doesn't have an accessor for this), also made the code to av..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[00:48:29] <gerrit-wm>	 New review: Yuvipanda; "Meh, didn't get time to test the GitHub bot." [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72323
[00:48:30] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/72323
[00:56:43] <gerrit-wm>	 New patchset: Yuvipanda; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[00:57:35] <gerrit-wm>	 New patchset: Yuvipanda; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[01:23:39] <gerrit-wm>	 New patchset: Mwjames; "\SMW\Collector improve exception tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72472
[01:24:11] <gerrit-wm>	 New patchset: Mwjames; "\SMW\Collector improve exception tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72472
[01:31:47] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72472
[01:39:07] <gerrit-wm>	 New review: Tim Starling; "I think you should use composition rather than inheritance here. Provide access to the DateTime obje..." [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/72453
[01:40:06] <bawolff>	 Do AssembleChunkedUpload jobs get run for testwiki ?
[01:40:26] <TimStarling>	 I would assume so
[01:41:01] <bawolff>	 I was testing chunked upload there, and things seem to hang at that stage
[01:41:29] <bawolff>	 but no error, so seems like perhaps that job isn't set up to run there
[01:45:04] <TimStarling>	 $ mwscript showJobs.php --wiki=testwiki --group
[01:45:04] <TimStarling>	 webVideoTranscode: 6 queued; 0 claimed (0 active, 0 abandoned)
[01:45:17] <TimStarling>	 no AssembleChunkedUpload jobs queued
[01:45:32] <TimStarling>	 so that would imply that they were run
[01:46:07] <bawolff>	 Hmm, interesting. the api is still giving me {"upload":{"result":"Poll","stage":"queued"}}
[01:46:28] <TimStarling>	 when did the upload start?
[01:47:27] <bawolff>	 first chunk at Mon, 08 Jul 2013 01:22:57 GMT
[01:47:47] <TimStarling>	 2013-07-08 01:32:23 mw1007 testwiki: AssembleUploadChunks File:11k5hupd3sh0.zc2d5p.3724.ogx filename=Test-chunked-upload.ogv filekey=11k5hupd3sh0.zc2d5p.3724.ogx session=array(4) t=49900 good
[01:48:37] <bawolff>	 Hmm, so I guess its just not recording the result back to my session
[01:48:58] <TimStarling>	 not surprising, if the session is really array(4)
[01:49:38] <bawolff>	 that's not actually the real session
[01:49:55] <bawolff>	 that's an array with your session id, so it can access it via the job queue
[01:50:20] <bawolff>	 I personally think its a bit odd to use the session the way chunked uploading does...
[01:51:12] <TimStarling>	 can it use a flat string instead?
[01:51:46] <TimStarling>	 I think it would make more sense to use strings for parameters than to change Job::toString()
[01:52:19] <TimStarling>	 anyway, it is probably a testwiki-specific issue
[01:52:23] <TimStarling>	 use test2 instead
[01:52:55] <bawolff>	 ok, I'll use that for my next test
[01:53:20] <bawolff>	 It also stores a list of headers in that array (although it doesn't seem to need them at first glance)
[01:54:58] <gerrit-wm>	 New patchset: Brian Wolff; "Have Chunked upload jobs bail if cannot associate with session." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72473
[02:06:46] <gerrit-wm>	 New review: Tim Starling; "WebRequest::getPathInfo() etc. is not supported by all servers. If a compatible interface was provid..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/71858
[02:15:25] <gerrit-wm>	 New review: Yurik; "Tim, the goal is to make "action" part of the URL's path, not query, as query will not be visible to..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71858
[02:15:51] <yurik>	 TimStarling, answered, let me know if i can clarify anything re path_info
[02:19:23] <gerrit-wm>	 New review: Tim Starling; "We could distinguish between parameters from $_GET and parameters from $_POST, and deny requests wit..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71858
[02:20:43] <yurik>	 TimStarling, but wouldn't this be a very backwards workaround just to allow rare mediawiki servers to feel "like everybody else"?
[02:21:16] <yurik>	 handling PATH_INFO could be the best approach for most, and for those who don't support it - use a separate entry point like api1.php
[02:21:32] <TimStarling>	 there's no api1.php in your patch
[02:21:46] <yurik>	 that's because i didn't think it was needed
[02:21:54] <TimStarling>	 I can only review based on what I see there
[02:21:55] <yurik>	 what servers don't support path_info?
[02:22:29] <TimStarling>	 HipHop
[02:24:21] <TimStarling>	 also it is easy to lose the PATH_INFO environment variable accidentally when you use CGI via a chroot wrapper, I think this is the origin of some shared hosting issues
[02:25:40] <yurik>	 tim, ok, if this is still a problem, i could add another entry point for those servers, but disable it in default
[02:26:01] <TimStarling>	 in HipHop you can configure a rewrite from the path to the query string
[02:26:14] <TimStarling>	 but then the web app obviously has to be able to understand the query string
[02:26:47] <TimStarling>	 you know we are talking about moving WMF to HipHop this year
[02:27:36] <yurik>	 the default (enabled in WMF) will be using path_info and api.php. In non default, api1.php will be enabled, and will allow action to be passed as a parameter. For hiphop we can latter start using rewrite for api requests, thus doing a clean migration?
[02:28:24] <yurik>	 i mean - my end goal is to have "api.php/action" - regardless if it is done by rewrite rule or by path_info (which is better because smaller servers will mostly support this out of the box)
[02:29:00] <yurik>	 it seems there have been some requests for hiphop to support path_info, so maybe htis will happen at some point as well
[02:30:53] <gerrit-wm>	 New patchset: Brian Wolff; "Have Chunked upload jobs bail if cannot associate with session." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72473
[02:31:11] <gerrit-wm>	 New review: Brian Wolff; "PS2: spelling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72473
[02:35:44] <TimStarling>	 the doc comment on $wgUsePathInfo has some information on when PATH_INFO is unavailable
[02:36:08] <TimStarling>	 it says that it is broken on lighttpd
[02:36:59] <TimStarling>	 also DefaultSettings.php disables it by default on IIS, which is consistent with http://www.mediawiki.org/wiki/Manual:Short_URL/IIS6
[02:38:03] <yurik>	 TimStarling, so how do you think it should be done to achieve maximum usage while still have a workaround?
[02:40:02] <TimStarling>	 I don't know, if you have to set up rewrite rules in the server's configuration then 90% of installations are not going to do that, unless the wiki refuses to work without it
[02:43:02] <TimStarling>	 you could basically have a curl check in the installer which makes sure the API is accessible with the action in the path
[02:43:18] <TimStarling>	 and then refuse to install if it's not working
[02:43:53] <TimStarling>	 but I'm not sure if it is worth causing the user that much inconvenience, considering there is another option available
[02:44:49] <TimStarling>	 which is to distinguish between $_GET and $_POST and continue to use $_GET for action
[02:46:31] <TimStarling>	 basically I am saying there are two options:
[02:47:18] <TimStarling>	 1) introduce an actionpath= parameter in $_GET, and the web server would be expected to rewrite the path info to ?actionpath=...
[02:48:05] <TimStarling>	 2) introduce an optional version parameter to $_GET, and require that the action parameter be in $_GET not $_POST when the version is >=1
[02:51:14] <gerrit-wm>	 New patchset: Mwjames; "\SMW\HashIdGenerator (separate responsibility)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72474
[03:08:16] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72474
[03:32:59] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #135: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/135/
[04:13:52] <gerrit-wm>	 New patchset: Tim Starling; "date_default_timezone_set unneeded in Parser" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971
[04:14:14] <gerrit-wm>	 New patchset: Tim Starling; "Avoid date()/gmdate() for date formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71121
[04:18:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971
[04:21:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71121
[04:24:38] <gerrit-wm>	 New patchset: Mwjames; "\SMW\Settings extends ArrayAccessor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72475
[04:29:00] <gerrit-wm>	 New review: Ori.livneh; "Tested on OS X & Windows" [mediawiki/vagrant] (master) C: 2;  - https://gerrit.wikimedia.org/r/72343
[04:29:03] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72343
[04:29:08] <gerrit-wm>	 New patchset: Ori.livneh; "Disable Puppet-lint's 'class_parameter_defaults' warning" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72355
[04:29:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72355
[04:29:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72475
[04:30:44] <gerrit-wm>	 New review: Ori.livneh; "Merging. If anyone feels like reviewing the repo's .gitignore, please do." [mediawiki/vagrant] (master) C: 2;  - https://gerrit.wikimedia.org/r/72470
[04:30:47] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72470
[04:48:11] <gerrit-wm>	 New patchset: Rjain; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361
[04:50:31] <gerrit-wm>	 New patchset: Brian Wolff; "[Goes with I33462a8] Support for new gallery." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69455
[04:50:43] <gerrit-wm>	 New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885
[04:53:09] <gerrit-wm>	 New review: Brian Wolff; "PS14: Fix an issue I found with tmh integration." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885
[04:54:56] <gerrit-wm>	 New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885
[04:59:48] <gerrit-wm>	 New patchset: Ori.livneh; "Improve documentation and formatting of debug settings file" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72477
[05:00:10] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72477
[05:05:24] <gerrit-wm>	 New patchset: Tim Starling; "Don't queue refreshLinks jobs on null edit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72064
[05:11:09] <gerrit-wm>	 New review: Tim Starling; "Help message fixed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72064
[05:20:52] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #126: FAILURE in 8 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/126/
[05:38:13] <gerrit-wm>	 New review: Ori.livneh; "I think the combination of I7f6e96cb1 ("Load custom user manifests from puppet/manifests/manifests.d..." [mediawiki/vagrant] (master) C: -1;  - https://gerrit.wikimedia.org/r/64609
[05:38:51] <wmf-selenium-bot>	 Yippie, build fixed!
[05:38:52] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-linux-firefox build #398: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/398/
[06:50:56] <gerrit-wm>	 New patchset: Siebrand; "Remove default web font for Persian language" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69878
[06:54:36] <gerrit-wm>	 Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69878
[06:55:28] <gerrit-wm>	 New patchset: Santhosh; "jquery.i18n message store for ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71990
[06:57:17] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72065
[07:05:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71990
[07:05:11] <gerrit-wm>	 New patchset: Amire80; "Documentation for mw.uls.init" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72359
[07:11:18] <gerrit-wm>	 New patchset: Santhosh; "Documentation for mw.uls.init" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72359
[07:12:42] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72359
[07:21:22] <gerrit-wm>	 New review: Santhosh; "as per demo by Niklas" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2;  - https://gerrit.wikimedia.org/r/71008
[07:21:35] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71008
[07:24:03] <gerrit-wm>	 New review: Nikerabbit; "File https://bugzilla.wikimedia.org/50921 for the todos." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71784
[07:24:28] <gerrit-wm>	 New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72484
[07:25:39] <gerrit-wm>	 New patchset: Siebrand; "Blacklist plural checks for 'cdo'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72485
[07:30:55] <gerrit-wm>	 New patchset: Nikerabbit; "Accessibility attributes for ULS trigger" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71784
[07:36:17] <gerrit-wm>	 New patchset: Santhosh; "Make anything with class 'uls-settings-trigger' work like ULS trigger" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72077
[07:38:39] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72077
[07:42:04] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71784
[07:42:51] <gerrit-wm>	 New patchset: Nikerabbit; "Apply webfonts to the IME selector too" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72087
[07:43:14] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72087
[08:06:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72485
[08:06:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72484
[08:14:52] <gerrit-wm>	 New review: Daniel Friesen; "I'd ultimately like to eliminate the two methods responsible for this and do things in a proper way ..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72473
[08:30:19] <hashar>	 MaxSem: good morning :-]
[08:30:33] <hashar>	 MaxSem: if you are around, do you know whether testwiki still point to tin /a/common ?
[08:30:37] <hashar>	 I lost track
[08:30:49] <Nikerabbit>	 nope
[08:30:54] <hashar>	 :-]
[08:31:12] <Nikerabbit>	 hashar: https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Trying_tin.27s_code_on_testwiki
[08:31:13] <hashar>	 so we have no way to test out our local checkout on tin  right ?
[08:31:24] <hashar>	 ahhh
[08:31:38] <hashar>	 clever
[08:46:52] <apergos>	 that's bad about the i18n messages
[08:56:33] <ori-l>	 Nikerabbit: do you have a minute to help me debug the opera bug by live-hacking code on dev.translatewiki.net?
[09:05:47] <MaxSem>	 hashar, run sync-common on srv193
[09:05:59] <hashar>	 MaxSem: thank you!  just did it :-]
[09:06:31] <hashar>	 MaxSem: beta has bits assets pointing to bits.beta.wmflabs.org now (instead of the text cache  en.wikipedia.beta.wmflabs.org/w/load.php  \O/ ) .  Should fix a bunch of javascript issues
[09:06:41] <hashar>	 MaxSem: also the mobile caches are not purged right now :(
[09:10:47] <Nikerabbit>	 ori-l: yes
[09:15:54] <se4598>	 good morning mlitn
[09:16:19] <mlitn>	 hi se4598
[09:17:58] <ori-l>	 Nikerabbit: i was going to ask two things. one is disable that popup gadget. no real reason to suspect it other than the fact that it reliably loads early. (did you notice the opera bug goes away w/debug=true, btw?)
[09:18:36] <ori-l>	 Nikerabbit: the other thing is a small modification to EL, i guess i'll just submit that as a patch and let you cherry-pick it locally if you don't mind
[09:19:17] <Nikerabbit>	 ori-l: which popup gadget?
[09:20:01] <ori-l>	 ext.gadget.HoverPopTools
[09:20:48] <Nikerabbit>	 ori-l: oh it is enabled by default?
[09:20:50] <Nikerabbit>	 le tme see
[09:21:09] <ori-l>	 it's a bit of a shot in the dark
[09:21:40] <Nikerabbit>	 starting cbt first..
[09:21:58] <gerrit-wm>	 New patchset: Ori.livneh; "Shot in the dark #2" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/72488
[09:22:05] <ori-l>	 ^ Nikerabbit
[09:22:30] <Nikerabbit>	 ori-l: debug=true works
[09:22:58] <ori-l>	 yeah, which basically tells you it's a race condition due to scripts loading asyncronously
[09:23:25] <ori-l>	 but resourceloader is supposed to carefully take care of the load order for you
[09:24:18] <Nikerabbit>	 disabling hoverpop didn't help
[09:25:20] <ori-l>	 thanks for checking
[09:26:01] <Nikerabbit>	 trying https://gerrit.wikimedia.org/r/72488
[09:26:19] <Nikerabbit>	 still no luck
[09:27:17] <ori-l>	 hrmmm
[09:29:56] <gerrit-wm>	 New patchset: Njw; "Reduce bottom padding of message area" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/72490
[09:30:38] <ori-l>	 MatmaRex, got any ideas? (re: https://bugzilla.wikimedia.org/show_bug.cgi?id=50746)
[09:31:12] <MatmaRex>	 ori-l: oh, huh. i'll look
[09:31:27] <MatmaRex>	 are you doing anything mad like calling document.write()?
[09:31:32] <Nikerabbit>	 haa
[09:31:39] <ori-l>	 nope
[09:31:40] <Nikerabbit>	 Uncaught reference error: mw not defined
[09:32:31] <MatmaRex>	 hm
[09:32:34] <MatmaRex>	 when i load that page
[09:32:39] <MatmaRex>	 the HTMLcontains only <script src="/w/load.php?debug=false&lang=pl&modules=ext.eventLogging%7Cschema.UniversalLanguageSelector&skin=vector&version=20130708T074611Z&*"/>
[09:32:59] <MatmaRex>	 so id'say that something *is*calling document.write
[09:33:05] <MatmaRex>	 and writing out that thing ^
[09:34:42] <thedj[work]>	 sounds like a document.write
[09:37:21] <Nikerabbit>	 but what is?
[09:37:39] <Nikerabbit>	 and why only in opera?
[09:37:57] <MatmaRex>	 because RL has some nasty hacks, probably
[09:38:04] <MatmaRex>	 and they probably just stopped working
[09:38:31] <ori-l>	 i'm currently fumbling with dragonfly and exhibiting some of the least sophisticated computer usage of my adult life
[09:38:33] <MatmaRex>	 mediawiki\core\resources\mediawiki\mediawiki.js:928
[09:38:35] <MatmaRex>	 on master
[09:38:49] <MatmaRex>	 there's a document.write there
[09:41:50] <MatmaRex>	 ori-l: enable "break on first statement of a new script"
[09:42:07] <MatmaRex>	 ori-l: search for "document.write" using the right-side subwindow
[09:42:23] <MatmaRex>	 ori-l: and keep going through the scripts until you find the one from mediawiki.js
[09:42:30] <MatmaRex>	 ori-l: and put a breakpoint there
[09:42:40] <MatmaRex>	 it's called after the entire page is loaded, for some reason
[09:42:59] <thedj[work]>	 i remember Roan saying that that ready conditional there wasn't too reliable
[09:43:00] <MatmaRex>	 i'll investigate in a while. brb
[09:43:01] <ori-l>	 					if ( window.opera ) {
[09:43:01] <ori-l>	 						// Appending to the <head> blocks rendering completely in Opera,
[09:43:01] <ori-l>	 						// so append to the <body> after document ready. This means the
[09:43:03] <ori-l>	 						// scripts only start loading after the document has been rendered,
[09:43:05] <ori-l>	 						// but so be it. Opera users don't deserve faster web pages if their
[09:43:07] <ori-l>	 						// browser makes it impossible.
[09:43:13] <MatmaRex>	 ori-l: that path isn't called there
[09:43:34] <ori-l>	 ok, i'll do what you said and stop trying to be smart :P
[09:43:56] <MatmaRex>	 anyway, /w/load.php?debug=false&lang=pl&modules=ext.eventLogging%7Cschema.UniversalLanguageSelector&skin=vector&version=20130708T074611Z&* is document.written after the page is loaded
[09:44:00] <MatmaRex>	 which ois obviously bad
[09:44:06] <MatmaRex>	 but figuring out whywill be a pain
[09:44:16] <MatmaRex>	 the RL call stack is truly bizantine
[09:44:22] <thedj[work]>	 I think Roan wanted to remove that else {} with the document.write completely
[09:44:26] <MatmaRex>	 bleh
[09:44:28] <MatmaRex>	 brb.
[09:45:04] <Nikerabbit>	 hmm curious
[09:45:36] <ori-l>	 maybe adding it to wgResourceModules in the extension function is too late?
[09:46:20] <Nikerabbit>	 I was suspecting it has to do loading it JS side
[09:47:05] <ori-l>	 the mw.loader.using() you mean?
[09:47:09] <Nikerabbit>	 yeah
[09:55:33] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72492
[09:55:45] <gerrit-wm>	 New patchset: Aude; "Add ChangesList function deprecation to release notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72493
[09:59:00] <MatmaRex>	 back
[10:00:48] <MatmaRex>	 where does "mw.loader.using('schema.UniversalLanguageSelector', function() " come from?
[10:01:12] <MatmaRex>	 it seem to execute after the document is basically loaded, but before jQueyr.ready() is called at the end of the page HTML
[10:01:33] <MatmaRex>	 and mw.loader.loads before $.ready() are done using document.write.
[10:02:04] <MatmaRex>	 hm, it's from ext.uls.init
[10:02:25] <Nikerabbit>	 MatmaRex: yep
[10:02:28] <Nikerabbit>	 conditional loading
[10:03:22] <ori-l>	 so it has to go in $() ready
[10:03:29] <MatmaRex>	 is it still being loaded from the top queue?
[10:03:53] <Nikerabbit>	 pretty much all of ULS seems to be in the top queue
[10:03:58] <MatmaRex>	 yeah
[10:04:09] <MatmaRex>	 i'm pretty sure this would magically fix itself if it was loaded from bottom
[10:04:15] <MatmaRex>	 as it's after $.ready
[10:04:22] <MatmaRex>	 but this all stillshould work
[10:06:20] <MatmaRex>	 but really, the else clause incore with `document.write( mw.html.element( 'script', { 'src': src }, '' ) );` should be killed
[10:06:55] <MatmaRex>	 i'm pretty sure it doesn't make things any faster on recent browsers
[10:07:03] <MatmaRex>	 whichsupport <script async>
[10:07:27] <MatmaRex>	 and actually i think scripts appended after page starts loading are asynchronous anyway
[10:08:47] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72082
[10:09:12] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72494
[10:09:27] <Nikerabbit>	 are you able to do that, or able to formulate the issue clearly in the bug report?
[10:10:45] <MatmaRex>	 formulate, yes. code loads after page content is loaded, but before $.ready() is called; thiscauses RL to erroneously usedocument.write for loading it and the page to go blank.
[10:10:51] <MatmaRex>	 (sorry, i need to fix myspacebar.)
[10:11:11] <MatmaRex>	 this could also be fixed by adding that module to "server-side" dependencies
[10:11:24] <MatmaRex>	 so it would be already loaded by then, and thus RL wouldn't have todo the heavy lifting
[10:11:56] <MatmaRex>	 or by moving everything to bottom queue, which executes after $.ready()
[10:12:09] <MatmaRex>	 or by killing that code path in core
[10:12:24] <MatmaRex>	 i'm really not sure which would be best to do in the long term, and which would be best to just get it working now
[10:15:00] <gerrit-wm>	 New patchset: Njw; "Improve padding of message area" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/72490
[10:19:26] <ori-l>	 MatmaRex: huh. that makes a lot of sense
[10:19:49] <liangent>	 MatmaRex: see that bug
[10:19:56] <liangent>	 I cc'd you
[10:21:40] <MatmaRex>	 liangent: what bug?
[10:22:06] <liangent>	 MatmaRex: 50924
[10:22:37] <MatmaRex>	 liangent: ah, i replied
[10:22:42] <MatmaRex>	 i have no idea if that's fixed
[10:22:49] <MatmaRex>	 or if it just worked by chance
[10:22:55] <MatmaRex>	 it sometimes worked by chance before :)
[10:23:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72492
[10:43:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72493
[10:46:40] <gerrit-wm>	 New patchset: Matthias Mullie; "Make the opt-in/-out feature optional per wiki" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72495
[10:47:15] <YuviPanda>	 !logs
[10:47:15] <wm-bot>	 channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://bots.wmflabs.org/~wm-bot/html/index.php?action=search&channel=%23mediawiki
[10:53:38] <YuviPanda>	 ori-l: MatmaRex Elsie last night(?)'s discussion about catching and mentioning all the channels also missed -mobile, -fundraising, -analytics and -labs. :P
[10:54:05] <YuviPanda>	 at least among the ones I am on
[10:58:08] <MatmaRex>	 YuviPanda: someone mentioned #-mobile, i tihnk
[10:58:39] <MatmaRex>	 there's so many channels we can't even keep track of which ones we're discussing about. :P
[10:58:39] <YuviPanda>	 MatmaRex: not from the logs, no
[10:58:42] <YuviPanda>	 I mentioned it in passing
[10:58:54] <YuviPanda>	 but that was well before
[10:59:16] <YuviPanda>	 -fundraising got a little popular  around april because Randall was hanging around there :D
[11:00:10] <YuviPanda>	 MatmaRex: also I think we should also agree that some bot messages should be filtereed out. jenkins-bots merges after someone else +2's them, 'gerritadmin' bugzilla ones
[11:00:19] <YuviPanda>	 MatmaRex: also comments saying (1 comment) are incredibly useless
[11:00:30] <MatmaRex>	 YuviPanda: there's a bug for that
[11:00:36] <YuviPanda>	 which?
[11:00:47] <MatmaRex>	 no idea, but i'm pretty sure it's reported
[11:00:51] <gerrit-wm>	 New patchset: Micha? ?azowik; "(bug 29444) Replaced (latest|earliest) with (newest|oldest) on history" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[11:00:51] <MatmaRex>	 the(1 comment) thing
[11:00:53] <YuviPanda>	 ah
[11:00:54] <YuviPanda>	 yeah
[11:01:24] <YuviPanda>	 gerrit streamevents does the (1 comment) thing and that's also pissing me off (while doing the github bot)
[11:01:32] <YuviPanda>	 #gerrit doesn't seem to be interested in fixing that either
[11:01:52] <MatmaRex>	 last time i tried to foxsomething like this, the bot justdidn't have access to inline comments info
[11:02:02] <YuviPanda>	 MatmaRex: yeah, that's what I meant.
[11:02:05] <MatmaRex>	 previously it didn't comment at all if there were only inline comments, but no cover message
[11:02:15] <YuviPanda>	 MatmaRex: so you need to use the HTTP REST API to get the inline comments
[11:02:16] <MatmaRex>	 now it only fails to comment when there are neither
[11:02:27] <MatmaRex>	 so you can +2 things covertly
[11:02:57] <YuviPanda>	 I've the infrastructure in place to make this work 'right', on toollabs. Perhaps I should just write a bot that's smarter than gerrit-wm
[11:03:03] <YuviPanda>	 who maintains gerrit-wm?
[11:03:15] <MatmaRex>	 no one, duh
[11:03:20] <YuviPanda>	 hehe :P
[11:03:24] <MatmaRex>	 ^demon or qchris, maybe :P
[11:03:46] <YuviPanda>	 qchris: do you know how gerrit-wm works and where it is run?
[11:04:04] * qchris  reads the discussion

[11:04:12] <YuviPanda>	 qchris: also I'm not the only one who thinks stream events' '(1 comment)' behavior is inconsistent and baaaad
[11:04:22] <qchris>	 YuviPanda: About gerrit-wm bot ... no. I do not know.
[11:04:33] <YuviPanda>	 is that an 'inbuilt' feature of Gerrit or something?
[11:05:24] <YuviPanda>	 (IRC reporting)
[11:05:31] <MatmaRex>	 YuviPanda: from thetechnical side it's a bunch of python scripts insome obscure repo
[11:05:37] <qchris>	 YuviPanda: The "(1 comment)" is pretty much built in.
[11:05:44] <YuviPanda>	 qchris: no, asking about IRC reporting
[11:05:50] <YuviPanda>	 i am painfully aware of (1 comment) :P
[11:06:01] <YuviPanda>	 (I still haven't written the python api wrapper, grr)
[11:06:48] <qchris>	 Sorry ... What was the question then?
[11:06:55] <YuviPanda>	 qchris: gerrit-wm
[11:07:25] <YuviPanda>	 qchris: is 'report activity to IRC' a plugin or something we run?
[11:07:45] <qchris>	 YuviPanda: I guess it's a hook (but I do not know) let me check ...
[11:08:50] <qchris>	 YuviPanda: ./files/gerrit/hooks in the puppet repo look like they could power gerrit-wm
[11:09:35] <qchris>	 YuviPanda: But I am not sure and do not have access to the real config
[11:10:53] <YuviPanda>	 ah, okay
[11:11:34] <qchris>	 And manifests/gerrit.pp comes with a ircecho configuration
[11:13:55] <YuviPanda>	 hmm, so that's probably it
[11:14:09] <YuviPanda>	 we could modify that to be smarter, at some point, I guess
[11:14:12] * YuviPanda  puts that on his backlog

[11:19:55] <Elsie>	 YuviPanda: Are we competing for channels? :-)
[11:20:10] <YuviPanda>	 Elsie: oh no sir! not with you! :P
[11:20:14] <Elsie>	 I also have -wikidata, -northeast, -us, -toolserver, -stewards...
[11:20:15] <Elsie>	 :-)
[11:20:16] <YuviPanda>	 just that everyone misses out some
[11:21:18] <gerrit-wm>	 New patchset: Matthias Mullie; "Make the opt-in/-out feature optional per wiki" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72495
[11:37:27] <gerrit-wm>	 New patchset: Hydriz; "Adding .gitreview." [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72500
[11:38:09] <gerrit-wm>	 Change merged: Hydriz; [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72500
[11:50:25] <gerrit-wm>	 New patchset: Hydriz; "Renaming files to standardise files that are part of special pages." [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72501
[11:51:13] <gerrit-wm>	 Change merged: Hydriz; [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72501
[11:53:00] <gerrit-wm>	 New review: Nemo bis; "Makes sense. No grammatical objections raised on the bug so far by native speakers." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72498
[12:05:18] <gerrit-wm>	 New patchset: Hydriz; "Updating function calls for using messages." [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72502
[12:06:06] <gerrit-wm>	 Change merged: Hydriz; [mediawiki/extensions/CloseWikis] (master) - https://gerrit.wikimedia.org/r/72502
[12:29:21] <gerrit-wm>	 New patchset: Siebrand; "Simplify if-statement" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72503
[12:30:59] <gerrit-wm>	 New review: KartikMistry; "LGTM!" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/72503
[12:31:54] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72503
[12:33:01] <gerrit-wm>	 New patchset: Siebrand; "Pass integer instead of string" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72505
[12:34:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72494
[12:38:58] <gerrit-wm>	 New patchset: Siebrand; "Remove redundant value assignment" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72506
[12:40:24] <gerrit-wm>	 New patchset: MaxSem; "Add debug logging" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/72218
[12:41:03] <gerrit-wm>	 New review: MaxSem; "(1 comment)" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/72218
[12:41:52] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72505
[13:15:48] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72506
[13:20:39] <gerrit-wm>	 New review: Matmarex; "Let's do this. I'm the sixth person on this patch who thinks it's a good idea, and Siebrand is the o..." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/52749
[13:23:38] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52749
[13:26:53] <gerrit-wm>	 New patchset: Physikerwelt; "Restructuring of the files" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72508
[13:28:43] <gerrit-wm>	 New patchset: Matmarex; "$wgContLang->getSpecialPageAliases(); can return null causing functions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59522
[13:41:04] <MatmaRex>	 i need steven.
[13:41:08] <MatmaRex>	 @notify StevenW
[13:41:08] <wm-bot>	 I'll let you know when I see StevenW around here
[13:41:15] <MatmaRex>	 @seen StevenW
[13:41:15] <wm-bot>	 MatmaRex: Last time I saw StevenW they were quitting the network with reason: Remote host closed the connection N/A at 7/6/2013 6:02:16 AM (2.07:38:59.5619220 ago)
[13:45:44] <gerrit-wm>	 New patchset: Physikerwelt; "Restructuring of the files" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72508
[13:46:12] <gerrit-wm>	 Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/72508
[14:17:31] <gerrit-wm>	 New patchset: Acrida; "extensions fails, correcting error" [mediawiki/extensions/BiblioPlus] (master) - https://gerrit.wikimedia.org/r/72517
[14:46:34] <hashar>	 jenkins giving me headaches, I am out again.   Will be back later tonight for the monday conf calls  :D
[14:46:36] <hashar>	 *wave*
[14:53:00] <gerrit-wm>	 New review: Brian Wolff; "The bug probably wasn't a large sample size of english grammarians." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[14:53:49] <MatmaRex>	 bawolff: can't tell if intended. :P ^
[14:54:58] <bawolff>	 I'm going to go with no (I'm assuming I made a grammar error, but I don't see it ;)
[15:00:00] <gerrit-wm>	 New review: Micha? ?azowik; "Well, this is how it's been done locally on enwiki for half a year:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[15:08:36] <gerrit-wm>	 New review: Brian Wolff; "Sounds reasonable if enwiki does it." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/72498
[15:09:33] <gerrit-wm>	 New patchset: Umherirrender; "Include original exception when throw TimestampException" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72527
[15:16:07] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72064
[15:19:26] <gerrit-wm>	 New patchset: Micha? ?azowik; "Replaced (latest|earliest) with (newest|oldest) on history" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[15:19:48] <gerrit-wm>	 New patchset: Micha? ?azowik; "Replaced (latest|earliest) with (newest|oldest) on history page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[15:19:50] <gerrit-wm>	 New review: MaxSem; "This change has a problem with continue: Imagine we have  titles with limit=2:" [mediawiki/extensions/PageImages] (master) C: -1;  - https://gerrit.wikimedia.org/r/72373
[15:26:28] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[15:28:03] <Nemo_bis>	 Nikerabbit: do you see characters correctly in the two 72498 lines above?
[15:33:38] <Nikerabbit>	 Nemo_bis: no
[15:43:34] <gerrit-wm>	 New patchset: Cmcmahon; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[15:48:04] <gerrit-wm>	 New patchset: Cmcmahon; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[16:01:09] <gerrit-wm>	 New patchset: Aude; "whitelist Addshore" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/72531
[16:09:26] <gerrit-wm>	 New review: Tpt; "(1 comment)" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[16:11:50] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/72095
[16:22:08] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71800
[16:22:42] <chrismcmahon>	 rachel99: I'm in the hangout
[16:23:46] <gerrit-wm>	 New patchset: Matthias Mullie; "Abort page restriction if no null revision can be created" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69861
[16:33:09] <gerrit-wm>	 New patchset: CSteipp; "Add getPersonalToolsList to SkinTemplate" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72537
[16:34:40] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add WikibaseQuery" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72538
[16:41:23] <aude>	 greg-g_: Reedy i'm back in hour or so for deploying code to wikidata
[16:41:37] <aude>	 really nothing we need to do except be available if there is a problem
[16:41:43] <aude>	 (unlikely)
[16:47:58] <greg-g_>	 aude: :) awesome, thanks
[16:53:48] <bawolff>	 Reedy: Could https://gerrit.wikimedia.org/r/#/c/71821/ (TimedMediaHandler) get deployed earlier than normal?
[16:54:12] <Reedy>	 Just update to master/
[16:54:14] <Reedy>	 *?
[16:54:38] <marktraceur>	 YuviPanda: OK, so, I think I will be able to think clearly enough tonight that I can work on your patch's review some more. -.-
[16:54:47] <marktraceur>	 Maybe merge. Probably merge.
[16:58:59] <YuviPanda>	 marktraceur: :D
[16:59:08] <YuviPanda>	 marktraceur: I thinkb brion will also be able to look at it today
[16:59:15] <gerrit-wm>	 New patchset: Reedy; "Update TimedMediaHandler to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72540
[16:59:24] <marktraceur>	 Coolio, maybe we can conspire to merge it later
[16:59:32] <YuviPanda>	 indeed.
[17:00:05] <gerrit-wm>	 New review: CSteipp; "Minor issue that the function isn't static:" [mediawiki/extensions/AbuseFilter] (master) C: -1;  - https://gerrit.wikimedia.org/r/71945
[17:00:10] <bawolff>	 Reedy: yeah. There was a bug that prevented embedding videos from working that is kind of serious
[17:00:24] <Reedy>	 broken in wmf8 or just wmf9?
[17:00:52] <bawolff>	 I think in wmf8 too
[17:01:43] <bawolff>	 yes, its broken in wmf8
[17:02:36] <gerrit-wm>	 New patchset: Reedy; "Update TimedMediaHandler to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72542
[17:03:41] <csteipp>	 Hey greg-g_, I don't think SUL got onto the deployment calendar... is ULS scheduled right now?
[17:04:09] <greg-g_>	 hah!
[17:04:15] <greg-g_>	 I think I may have messed that up
[17:04:23] <greg-g_>	 csteipp: I think I typed it wrong... lemme check the page log
[17:05:49] <greg-g_>	 csteipp: yes, that's you, my bad monday morning post-vacation mind messed up the TLA
[17:05:52] <greg-g_>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=47534
[17:05:57] <greg-g_>	 erm, wrong paste
[17:06:00] <greg-g_>	 https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=prev&oldid=76346
[17:07:15] <csteipp>	 greg-g_: So the ULS Bugfix on the google calendar is incorrect?
[17:07:20] <greg-g_>	 right
[17:07:35] <greg-g_>	 my bad
[17:07:55] <greg-g_>	 https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=76633&oldid=76615  commit message: "SUL is SUL is Chris not ULS not Niklas but SUL and Chris"
[17:09:51] <gerrit-wm>	 New review: Anomie; "Backport" [mediawiki/core] (wmf/1.22wmf9) C: 2;  - https://gerrit.wikimedia.org/r/72537
[17:09:54] <gerrit-wm>	 Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72537
[17:10:44] <gerrit-wm>	 New patchset: Hoo man; "Make use of the APIEditBeforeSave hook for nicer errors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[17:11:34] <gerrit-wm>	 New review: Hoo man; "Made AbuseFilterHooks::onAPIEditBeforeSave static (thanks for pointing that out)." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[17:17:58] <csteipp>	 greg-g: Done. Thanks!
[17:18:35] <greg-g>	 csteipp: sweet, thanks, sorry about that confusion
[17:19:25] <gerrit-wm>	 New review: CSteipp; "Thanks!" [mediawiki/extensions/AbuseFilter] (master) C: 2;  - https://gerrit.wikimedia.org/r/71945
[17:19:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[17:19:45] <hoo|away>	 :)
[17:19:48] <csteipp>	 James_F: ^
[17:19:55] <James_F>	 csteipp: Yay. :-)
[17:20:00] <James_F>	 hoo|away: Thank you too. :-)
[17:20:24] <James_F>	 csteipp: You OK for us just to LD that today?
[17:21:10] <csteipp>	 James_F: yep
[17:22:24] <gerrit-wm>	 New review: Krinkle; "Using a static (basically, global) property to keep track of whether the filter has already run does..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[17:22:39] <James_F>	 csteipp: Kk; adding.
[17:23:50] <gerrit-wm>	 New patchset: Hoo man; "Allow running the AbuseFilter parser tests via phpunit" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[17:24:07] <gerrit-wm>	 New review: Hoo man; "Rebased" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[17:35:29] <gerrit-wm>	 New review: Kaldari; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72455
[17:36:36] <gerrit-wm>	 New patchset: Kaldari; "Improving comments in File class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72455
[17:42:00] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72455
[17:43:29] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[17:43:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72527
[17:43:35] <gerrit-wm>	 New patchset: Mati; "add and use updateExternalDBGroups function, fixes #49641" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70040
[17:46:49] <gerrit-wm>	 New patchset: Mati; "add and use updateExternalDBGroups function, fixes #49641" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70040
[17:48:43] <gerrit-wm>	 New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316
[17:50:35] <gerrit-wm>	 New patchset: Adamw; "Refine the "force" hack to ensure that the search criteria are really empty.  We were breaking results paging." [wikimedia/fundraising/crm/civicrm] (master) - https://gerrit.wikimedia.org/r/72552
[17:53:17] <gerrit-wm>	 New patchset: Mwalker; "(FR #981) Timestamp becomes Datestamp in TY Emails" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72554
[17:57:02] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[17:59:17] <gerrit-wm>	 Change merged: Mwalker; [wikimedia/fundraising/crm/civicrm] (master) - https://gerrit.wikimedia.org/r/72552
[18:01:38] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364
[18:07:05] <gerrit-wm>	 New patchset: Mollywhite; "Bug 50674: Adding an example JSON book structure." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72559
[18:11:28] <gerrit-wm>	 New patchset: Rjain; "Begining of making read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360
[18:12:57] <gerrit-wm>	 New review: Adamw; "(1 comment)" [wikimedia/fundraising/crm] (master) C: -1;  - https://gerrit.wikimedia.org/r/72554
[18:14:03] <gerrit-wm>	 New review: Mollywhite; "Adding to repository" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72559
[18:14:06] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72559
[18:18:17] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[18:18:56] * aude  waves to greg-g and reedy

[18:19:41] <gerrit-wm>	 New patchset: Mwalker; "(FR #981) Timestamp becomes Datestamp in TY Emails" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72554
[18:20:27] <marktraceur>	 YuviPanda: What's that change?
[18:20:42] <YuviPanda>	 marktraceur: bugs brion found in the maintenance script
[18:20:44] <gerrit-wm>	 New review: Hoo man; "Going to upload a follow up in a minute..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945
[18:20:48] <marktraceur>	 Coolio.
[18:21:02] <greg-g>	 aude: hi there
[18:21:48] <aude>	 nothing special to do for wikidata though we might do one small setting change (unrelated to deployment)
[18:22:10] <greg-g>	 aude: /me nods
[18:22:17] <greg-g>	 aude: Reedy appears busy in -operations :)
[18:22:30] <hoo>	 aude: The one I mentioned? If not, we want two :P
[18:22:39] <aude>	 hoo: yes that one
[18:22:44] <hoo>	 \o/
[18:22:58] <brion>	 YuviPanda: the migration still seems to come up 'disabled'
[18:23:19] <brion>	 i also notice you're not checking the status return value from doEditContent
[18:23:24] <YuviPanda>	 brion: yeah, just saw that again. I seem to have 'undid' my change before commiting, and it was 0 : 1 instead of other way around
[18:23:26] <brion>	 they all pass for me though
[18:23:28] <brion>	 hah
[18:23:38] <brion>	 YuviPanda: why 0/1? isn't it a boolean field?
[18:24:02] <YuviPanda>	 brion: so if doContentEdit fails the script aborts
[18:24:35] <YuviPanda>	 brion: by... itself. magically. I just assumed that's a feature of the maintenance script. try messing up the mappings' types and that'll go
[18:24:50] <greg-g>	 aude: what is the setting change, btw?
[18:24:51] <brion>	 hrm that's worrying
[18:25:01] <YuviPanda>	 brion: what is?
[18:25:02] <brion>	 is something throwing an exception instead of returning data in the status object?
[18:25:17] <brion>	 to my mind, returning a status object is a declaration that you won't throw an exception
[18:25:35] <YuviPanda>	 it does terminate with a proper message
[18:25:41] <aude>	 greg-g: it's for normalizing page titles when doing lookups
[18:25:53] <greg-g>	 interesting, cool
[18:25:53] <YuviPanda>	 brion: also it's a TINYINT  not 'boolean', so has to manually be 0 or 1
[18:26:00] <aude>	 e.g. allow to find barack obama whereas now you can only find Barack Obama
[18:26:02] <brion>	 YuviPanda: yeah but we're mapping it to a boolean
[18:26:06] <aude>	 if you look up an item by title
[18:26:12] <brion>	 (in the json) does something else do that conversion?
[18:26:22] <aude>	 kind of like that
[18:26:25] <YuviPanda>	 brion: while reading or writing?
[18:26:33] <brion>	 creating the initial json page
[18:26:40] <gerrit-wm>	 New patchset: Reedy; "Update TimedMediaHandler to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72540
[18:26:56] <aude>	 http://www.wikidata.org/wiki/Special:ItemByTitle/enwiki/Barack_obama
[18:27:04] <YuviPanda>	 			'enabled' => $campaign->campaign_enabled === 1,
[18:27:28] <YuviPanda>	 brion: either way, gimme a bit. investigating this so I can fix it properly
[18:27:38] <brion>	 ok
[18:29:09] * apergos  looks for AzaToth

[18:29:20] <apergos>	 it's that time again... time for another patchset with twice as many errors
[18:29:43] <brion>	 \o/
[18:29:54] <gerrit-wm>	 New patchset: Hoo man; "Avoid wgUser in AbuseFilterHooks edit handlers" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72563
[18:30:46] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[18:31:12] <YuviPanda>	 brion: ^
[18:31:15] <YuviPanda>	 should be better.
[18:31:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72540
[18:31:22] <YuviPanda>	 1 is 0, 0 is 1
[18:31:27] <wmf-selenium-bot>	 Yippie, build fixed!
[18:31:27] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #136: FIXED in 9 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/136/
[18:31:59] <brion>	 YuviPanda: \o/ they say enabled now yay
[18:32:10] <YuviPanda>	 brion: :) I'm testing wlm-nl now.
[18:32:20] <YuviPanda>	 brion: it was 1 == '1' but 1 !== '1'
[18:32:26] <brion>	 heh
[18:32:27] <hoo>	 csteipp: Do you plan to deploy AbuseFilter master today?
[18:32:43] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72542
[18:36:32] <hoo>	 Ok, doesn't matter
[18:37:33] <YuviPanda>	 brion: wlm-nl wfm
[18:37:37] <brion>	 hmmmm
[18:37:42] <brion>	 lemme test in different browsers
[18:37:59] <AzaToth>	 apergos: yes?
[18:38:02] <gerrit-wm>	 New patchset: Rjain; "Begining of making read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360
[18:38:53] <apergos>	 feel like some -1 comments? :-D  (whenever you have time)
[18:38:55] <brion>	 YuviPanda: same behavior in Firefox and Chrome for me
[18:39:04] <brion>	 'next' button on 'release rights' does nothing
[18:39:18] <brion>	 if i go through 'use a different license' it'll work, but the default… no go
[18:40:02] <gerrit-wm>	 Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72554
[18:40:27] <YuviPanda>	 brion: are you using a recent version of master?
[18:40:31] <YuviPanda>	 brion: caching issues perhaps?
[18:40:38] <apergos>	 I won't look at it again til tomorrow (that is, if you do review it today)
[18:40:39] <csteipp>	 hoo: VisualEditor guys are planning to deploy it
[18:40:39] <brion>	 updated it this morning
[18:40:47] <brion>	 two different browsers says not a caching issue
[18:40:50] <brion>	 one of which never ran the old version
[18:40:51] <YuviPanda>	 true
[18:40:54] <hoo>	 csteipp: ok, see PM, doesn't matter anyway, as I just saw :P
[18:40:54] <apergos>	 cause it's already my evening late-ish and in a meeting
[18:40:57] <YuviPanda>	 pastebin the json?
[18:41:43] <YuviPanda>	 yeah, just worked again
[18:41:46] <brion>	 YuviPanda: https://gist.github.com/brion/5951350
[18:42:57] <gerrit-wm>	 New review: Rtdwivedi; "Oh! I did not intend to remove this method. I must have committed this mistake while testing some ot..." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[18:43:14] <gerrit-wm>	 New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[18:44:08] <James_F>	 hoo: Anything we need to know before deployment?
[18:45:07] <gerrit-wm>	 New review: Tpt; "(1 comment)" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1;  - https://gerrit.wikimedia.org/r/72253
[18:45:41] <hoo>	 James_F: No ;) You just need to rebuild the message cache when going from wmf8 to master, but I guess that's clear
[18:46:16] <gerrit-wm>	 New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[18:46:23] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365
[18:46:54] <James_F>	 hoo: Oh, yes, indeed.
[18:47:09] <hoo>	 :)
[18:47:14] <James_F>	 hoo: Quite normal for VE deployments, which this will be too.
[18:47:31] <gerrit-wm>	 New review: Tpt; "(1 comment)" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1;  - https://gerrit.wikimedia.org/r/72253
[18:47:41] <YuviPanda>	 brion: still can't reproduce. Updated mw to today's master too....
[18:47:52] <gerrit-wm>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[18:47:53] <brion>	 hrmmmm
[18:48:00] <brion>	 well let's hope it's just MYSTERIOUS
[18:48:04] <YuviPanda>	 brion: tell me if something other than wlm-nl also causes similar behavior?
[18:48:12] <brion>	 yeah i'll try a few
[18:48:23] <brion>	 this would be easier if we still had Special:UploadCampaigns though ;)
[18:48:32] <brion>	  a list with nice one-click open
[18:49:22] <brion>	 or a link from the campaign: pages maybe
[18:49:26] <YuviPanda>	 brion: http://127.0.0.1:8080/w/index.php?title=Special%3APrefixIndex&prefix=&namespace=460
[18:49:29] <gerrit-wm>	 New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[18:49:34] <brion>	 yeah i can get a list
[18:49:37] <brion>	 then i have to copy-paste shit
[18:49:42] <YuviPanda>	 true
[18:49:50] <YuviPanda>	 brion: that should be next step, I think - 'phase4'
[18:49:59] <brion>	 LandtagsprojektAT same bug
[18:50:01] <YuviPanda>	 but not right now
[18:50:10] <brion>	 well you could have just left the old code instead of deleting it
[18:50:14] <brion>	 and it would have worked fine
[18:50:23] <brion>	 just change the edit links :)
[18:51:04] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253
[18:51:16] <YuviPanda>	 brion: Landtagsprojgasg also works for me
[18:51:39] <brion>	 YuviPanda: are you manually selecting a license?
[18:51:45] <brion>	 or leaving it at default?
[18:51:51] <YuviPanda>	 leaving it at default
[18:51:55] <YuviPanda>	 let me try manually selecting one?
[18:51:57] <brion>	 well, it doesn't work here….
[18:52:02] <brion>	 manually selecting one works around the bug for me
[18:52:04] <AaronSchulz>	 brion: https://gerrit.wikimedia.org/r/#/c/72245/
[18:52:17] <YuviPanda>	 brion: hmmm, i've a thought. go to your preferences and pick a default license?
[18:52:19] <YuviPanda>	 perhaps that is it
[18:52:42] <brion>	 it's set to "use whatever the default is"
[18:52:53] <brion>	 lemme pick CC-BY-SA 3
[18:52:55] <YuviPanda>	 brion: try changing it? That might be the bug
[18:53:28] <brion>	 YuviPanda: no difference
[18:53:51] <gerrit-wm>	 New review: Matmarex; "Someone please explain to me why we have to fix this thrice in three different files. :/" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/72454
[18:54:41] <YuviPanda>	 brion: that's... weird. check network tab, see if thing got uploaded actually?
[18:55:43] <brion>	 YuviPanda: upload is fine
[18:55:58] <brion>	 it's the release rights page that's broken
[18:56:04] <brion>	 that's after successful upload has been verified
[18:56:15] <YuviPanda>	 hmm, okay. let me destroy and recreate my setup
[18:56:23] <YuviPanda>	 thanks to vagrant that should be simpleish
[18:56:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72454
[18:56:40] <gerrit-wm>	 New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[18:57:19] <YuviPanda>	 brion: it's pulling things in now. moment.
[18:58:27] <gerrit-wm>	 New review: Kaldari; "continue is broken" [mediawiki/extensions/PageImages] (master) C: -1;  - https://gerrit.wikimedia.org/r/72373
[19:02:36] <brion>	 i can't find the fucking event handler for the next button
[19:02:42] <brion>	 i hate UploadWizard code
[19:02:52] <marktraceur>	 brion: ++
[19:03:02] <marktraceur>	 brion: showNext, should be a function in mw.UW.js
[19:03:02] * YuviPanda  waits for his vagrant to boot

[19:03:04] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365
[19:03:12] <marktraceur>	 ...I think
[19:04:17] <brion>	 there it is
[19:04:23] <brion>	 mw.UploadWizard.js
[19:04:27] <brion>	 		$j( '#mwe-upwiz-stepdiv-deeds .mwe-upwiz-button-next')
[19:04:27] <brion>	 			.click( function() {
[19:04:42] <marktraceur>	 Ah, of course.
[19:04:46] <brion>	 checks if the deedChooser is valid, and …… does nothing if it's not
[19:04:49] <gerrit-wm>	 New review: Kaldari; "@MaxSem: Hmm, I'm not sure how to fix continue without hurting the performance of the API. It looks ..." [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373
[19:05:00] <RoanKattouw>	 Ugh, $j
[19:05:09] <marktraceur>	 brion: The valid call has side effects up the wazoo
[19:05:13] <YuviPanda>	 UW's code is all ugh.
[19:05:21] <brion>	 i saw the comment. i assume it's a lie in this particular case :)
[19:05:39] <marktraceur>	 brion: Search for recoverFrom in the code - those are the side effects, IIRC
[19:05:42] <brion>	 ok confirmed! it's vcalling deedChooser.valid() and getting false
[19:05:44] <brion>	 and there's no notifications
[19:05:46] <marktraceur>	 Well, maybe not in the deeds step
[19:05:53] <marktraceur>	 Oh, huh.
[19:06:05] * marktraceur  rewrote bits of this in a patchset on top of Nischayn22's work

[19:06:25] * YuviPanda  waits for his dev vagrant to come back up some more

[19:07:25] <brion>	 ok…. !_this.showCustomDiv is false
[19:07:30] <brion>	 !_this.licenseInput.valid() is true
[19:07:30] <wm-bot>	 You are not authorized to perform this, sorry
[19:07:38] <brion>	 the result of &&ing these is false
[19:07:43] <brion>	 so what the fuck is showCustomDiv for
[19:08:12] <gerrit-wm>	 New review: CSteipp; "Iirc, Andrew did it the original way so that the filter could be checked for another user. I though ..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/72563
[19:08:17] <AaronSchulz>	 brion: :)
[19:08:18] <brion>	 _this.showCustomDiv = ownWork.licenses.length > 1 || licenseIsNotDefault;
[19:09:12] <YuviPanda>	 hmmm
[19:09:46] <YuviPanda>	 In retrospect, the vagrant destroy was a stupid idea
[19:10:30] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365
[19:11:33] <gerrit-wm>	 New patchset: Adamw; "* Do some required field enforcement. * thankyou_date column header has changed to "Thank You Letter Date".  Be sure to correct in incoming documents. * Include a recent db schema migration in the fresh install script." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72611
[19:16:34] <brion>	 YuviPanda: ok i get different values for config.licensesOwnWork.licenses
[19:16:44] <brion>	 in the old code i get just ["cc-by-sa-3.0-nl"]
[19:16:59] <gerrit-wm>	 New review: Cmcmahon; "Amir, I don't understand what's supposed to happen upon sending CTRL-M.  As far as I can see on test..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365
[19:17:06] <brion>	 on the new code i get ["cc-by-sa-3.0-nl","cc-by-3.0","cc-zero"]
[19:17:54] <YuviPanda>	 hmm, so that's array replacing code working not how it should be
[19:18:11] <YuviPanda>	 I also have no idea why it worked for me :|
[19:18:43] <YuviPanda>	 brion: i'm looking now - at least once I get my vagrant back up
[19:20:10] <brion>	 i'm suspicious of all those changes from array_merge to array_replace_recursive
[19:20:14] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365
[19:21:15] <YuviPanda>	 brion: yeah, this one is definitely a result of that.
[19:21:19] <YuviPanda>	 let me look through them a bit closer
[19:21:24] <brion>	 ok
[19:21:30] <YuviPanda>	 the older code had special cased licenses, I'm hoping I won't have to
[19:22:52] <gerrit-wm>	 New review: Brion VIBBER; "There's a problem with the configuration merging which, for instance, can cause additional licenses ..." [mediawiki/extensions/UploadWizard] (master) C: -1;  - https://gerrit.wikimedia.org/r/70446
[19:22:59] <brion>	 just added a note on the gerrit
[19:23:03] <brion>	 so we don't lose it :D
[19:23:46] <YuviPanda>	 brion: :) I'm still confused about why it worked for me
[19:24:01] <brion>	 yeah no idea
[19:24:21] <brion>	 no customizations on my UW config i can see
[19:24:59] <YuviPanda>	 brion: you picked CC BY SA, which isn't on the list, while I had CC Zero, which was
[19:25:02] <YuviPanda>	 that's probably it
[19:25:12] <YuviPanda>	 pick cc zero as your default license and then try?
[19:25:40] <brion>	 ooooh funky
[19:26:19] <brion>	 MYSTERY SOLLVED
[19:26:20] <brion>	 yay :D
[19:26:37] <brion>	 now i just have to figure out why UW only lets me add descriptions in slovenian
[19:26:45] <brion>	 but that's already broken in master for me so we can ignore it ;)
[19:27:23] <gerrit-wm>	 New patchset: Ori.livneh; "Use 'mw.hook' to queue events until EL has loaded" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[19:27:44] <brion>	 brb
[19:27:49] <YuviPanda>	 brion: heh
[19:29:13] <aude>	 Reedy: https://gerrit.wikimedia.org/r/#/c/72615/ minorish config change for wikidata
[19:31:52] <gerrit-wm>	 New patchset: Adamw; "fail entire check import if required columns are missing" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72616
[19:35:42] <gerrit-wm>	 New patchset: Cmcmahon; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[19:36:30] <gerrit-wm>	 New review: Cmcmahon; "Rachel: make the test click the Links icon; then I added the beginning of a Scenario that follows th..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[19:42:31] <gerrit-wm>	 New patchset: Foxtrott; "added support for synonyms in Semantic Glossary, added .idea to gitignore" [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969
[19:42:51] <gerrit-wm>	 Change merged: Foxtrott; [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969
[19:43:58] <gerrit-wm>	 New patchset: Ori.livneh; "Before touching 'locale-check.skip', ensure parent exists" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72617
[19:44:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72617
[19:58:14] <brion>	 YuviPanda: is suchabot still not closing pull requests? https://github.com/wikimedia/apps-android-commons/pull/22 is open but it's merged on gerrit's side
[19:58:32] <YuviPanda>	 brion: no it isn't. I've not found time to look at it on the weekends. been... distracted.
[19:58:40] <brion>	 no worries
[19:58:44] <brion>	 i'll close em out manually for now
[19:59:02] <YuviPanda>	 brion: yeah
[20:16:16] <GorillaWarfare>	 YuviPanda: Got a free second?
[20:16:21] <YuviPanda>	 sure
[20:16:48] <GorillaWarfare>	 I'm working on a JSON schema for a book
[20:17:12] <GorillaWarfare>	 And the validation of JSON blocks against  it is almost identical to EventLogger
[20:17:16] <GorillaWarfare>	 https://meta.wikimedia.org/wiki/Schema:BookManagerv2
[20:17:17] <YuviPanda>	 :D
[20:17:53] <GorillaWarfare>	 In the "sections" property, I want "pages" to be an array that contains either integers, an array of integers, or both
[20:18:11] <YuviPanda>	 ah, the 'or both' isn't currently supported in JsonSchema
[20:18:24] <GorillaWarfare>	 I suppose that would explain my problem :P
[20:18:47] <YuviPanda>	 GorillaWarfare: items is an array, but it can have only one element (Right now)
[20:18:56] <YuviPanda>	 that does need to be fixed
[20:19:04] <GorillaWarfare>	 Ahhh, okay
[20:19:14] <GorillaWarfare>	 Suddenly everything makes so much more sense :P
[20:19:17] <YuviPanda>	 GorillaWarfare: :)
[20:19:27] <YuviPanda>	 I'm also unclear what the spec actually says
[20:19:56] <GorillaWarfare>	 The JSON spec?
[20:21:54] <YuviPanda>	 GorillaWarfare: yeah, JSON Schema spec
[20:22:02] * GorillaWarfare  looks

[20:22:18] <YuviPanda>	 GorillaWarfare: JSON Schema is in the process of becoming an IETF standard. Our code uses draft-03, rather than -04
[20:22:30] <GorillaWarfare>	 Good to know
[20:22:47] <YuviPanda>	 GorillaWarfare: :)
[20:24:04] <GorillaWarfare>	 YuviPanda: Looks like it's okay by the spec
[20:24:28] <GorillaWarfare>	 It allows for "union types" like {"type":["string","number"]}
[20:25:35] <YuviPanda>	 GorillaWarfare: yeah, but IIRC it isn't supported by our code
[20:25:38] <wmf-selenium-bot>	 Yippie, build fixed!
[20:25:38] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #127: FIXED in 7 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/127/
[20:25:39] <YuviPanda>	 let me double check
[20:28:40] <gerrit-wm>	 New patchset: MaxSem; "Make PageImages return files themselves in NS_FILE" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72625
[20:29:02] <gerrit-wm>	 New review: MaxSem; "Just a sketch, doesn't actually work." [mediawiki/extensions/PageImages] (master) C: -1;  - https://gerrit.wikimedia.org/r/72625
[20:30:21] <gerrit-wm>	 New patchset: Nilesh; "Made corrections to wikiparser scripts and added reducer" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72626
[20:30:22] <gerrit-wm>	 New patchset: Nilesh; "Fixed errors in parser scripts" [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72627
[20:33:17] <YuviPanda>	 GorillaWarfare: also are you using Schema: on meta for this? I thought that was just for EL schemas...
[20:35:59] <gerrit-wm>	 New review: Krinkle; "Why was the casing changed? Latest -> newest. I don't disagree, but that change seems unexplained at..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[20:38:55] <gerrit-wm>	 New review: Micha? ?azowik; "That's just how it is now en enwiki. plwiki also has lowercase. Sorry for not mentioning that." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72498
[20:39:01] <gerrit-wm>	 New review: Krinkle; "Thanks. Release notes?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72064
[20:40:16] <gerrit-wm>	 Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72616
[20:40:16] <gerrit-wm>	 Change merged: Adamw; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72611
[20:40:43] <gerrit-wm>	 New patchset: Mollywhite; "Adding JSON schema patch." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72628
[20:41:10] <gerrit-wm>	 New review: Mollywhite; "Adding in JSON validation code" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72628
[20:41:11] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72628
[20:43:58] <gerrit-wm>	 Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/62531
[20:47:16] <gerrit-wm>	 New review: Mwalker; "+2 -- it was a mistake that this got self merged; but I've reviewed it and it looks fine." [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/72616
[21:15:26] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/71820
[21:21:22] <gerrit-wm>	 New patchset: Cmcmahon; "Only run uls ime tests on test2wiki" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72633
[21:21:52] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72633
[21:29:31] <gerrit-wm>	 New patchset: Mwalker; "Updating Brazil Form Layout" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72635
[21:52:15] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #62: FAILURE in 3 min 9 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/62/
[21:55:00] <gerrit-wm>	 New patchset: Mollywhite; "Use wgDBname for the BookManagerv2DBname" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72638
[21:55:12] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #52: FAILURE in 2 min 57 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/52/
[21:57:10] <gerrit-wm>	 New patchset: Ryan Lane; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557
[21:59:10] <gerrit-wm>	 New review: Krinkle; "Should probably keep the $.noop if wgULSEventLogging is disabled, saves a few instantiations and fun..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[22:02:44] * YuviPanda  re-implements array_merge sanely

[22:09:47] <gerrit-wm>	 New review: Krinkle; "mw.hook can be fired multiple times. Though this code doesn't do that, if that were to happen these ..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1;  - https://gerrit.wikimedia.org/r/72614
[22:12:13] <gerrit-wm>	 New patchset: Ryan Lane; "Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126
[22:25:24] <gerrit-wm>	 New patchset: Spage; "improve explanations of email confirmations" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72647
[22:28:40] <wmf-selenium-bot>	 Yippie, build fixed!
[22:28:40] <wmf-selenium-bot>	 Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #63: FIXED in 3 min 48 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/63/
[22:29:52] <mwalker>	 Krinkle: you there?
[22:30:30] <gerrit-wm>	 New patchset: Mollywhite; "Use the wiki DB for the BookManagerv2DBname." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72638
[22:31:14] <mwalker>	 actually RoanKattouw -- how do you, in VE, document 'dynamic' contents of JS arrays -- e.g. I have a couple of promise objects in an array and I'd like to document them -- but of course they aren't in existence at the start of the script I create them dynamically -- what is the best way of telling JSDuck about them?
[22:31:25] <mwalker>	 is it actually to just create an accessor function and document that?
[22:32:17] <RoanKattouw>	 Ahm, wait
[22:32:24] <RoanKattouw>	 Are the members of the array semantically distinct?
[22:32:33] <RoanKattouw>	 With arrays I usually just do {jQuery.Promise[]}
[22:32:53] <RoanKattouw>	 If there is something special about e.g. arr[1] then maybe you should make it an object with named keys
[22:32:53] <mwalker>	 they do different things yes
[22:33:43] <mwalker>	 hurm -- I'll poke at the object thing
[22:33:48] <RoanKattouw>	 If they're in an array then at least at that level of abstraction there shouldn't be anything special about the individual promises
[22:33:59] <RoanKattouw>	 Even if they're different, it could just be an array of "stuff to X before Y"
[22:34:05] <RoanKattouw>	 which is fine
[22:34:36] <RoanKattouw>	 Putting them in an array makes sense as long as there's some layer that goes "promises, shmomises, these things are all the same to me"
[22:34:36] <mwalker>	 so... backing up a step; I'm exposing a series of CentralNotice events to the outside world that things, like banners, can subscribe to
[22:34:43] <RoanKattouw>	 OK
[22:35:11] <mwalker>	 what is the best way to expose those events?
[22:35:56] <RoanKattouw>	 So, two questions
[22:36:23] <RoanKattouw>	 1) what are these events? how do the individual events differ? 2) where does the array of promises come in?
[22:36:54] <gerrit-wm>	 New review: Mollywhite; "Passed it by Raylton." [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72638
[22:36:54] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72638
[22:37:09] <mwalker>	 1) I have two currently -- bannerLoaded and bannerRendered
[22:37:27] <mwalker>	 2) the array came in because I store those two objects in mw.centralnotice.events
[22:37:35] <mwalker>	 which is an array
[22:37:38] <RoanKattouw>	 I guess these are events that only happen once and so you want a promise?
[22:37:44] <mwalker>	 yep
[22:37:46] <RoanKattouw>	 Right
[22:38:17] <RoanKattouw>	 An events is a straight up array of promises, and the caller has to know that mw.centralnotice.events[0] means loaded and events[1] means rendered?
[22:38:20] <RoanKattouw>	 *And events
[22:38:54] <mwalker>	 sorta -- they can address it by name too
[22:39:07] <mwalker>	 (so it's actually a dictionary)
[22:39:08] <RoanKattouw>	 How?
[22:39:18] <RoanKattouw>	 mw.centralnotice.events.foo ?
[22:39:21] <mwalker>	 yep
[22:39:23] <RoanKattouw>	 OK
[22:39:40] <RoanKattouw>	 So then it is exactly what I said :) I was trying to tell you to use a dictionary, I just used different jargon
[22:40:34] <RoanKattouw>	 However, in JS there's generally no reason why you'd have something that's both an array and a dictionary (a frankendictionarray?), a dictionary usually suffices
[22:40:46] <mwalker>	 yep; I was just using bad terminology
[22:41:04] <mwalker>	 so, create all the entries in the dictionary before hand and just assign null's to them until I init?
[22:41:15] <RoanKattouw>	 That's not even needed
[22:41:19] <RoanKattouw>	 Well
[22:41:28] <RoanKattouw>	 OK, so
[22:41:45] <RoanKattouw>	 You can document things regarding of their existence if you just document them as {jQuery.Promise|undefined}, although that's kind of eww
[22:41:58] <RoanKattouw>	 But even better, you can just init them with a promise, then resolve that promise later
[22:42:40] <RoanKattouw>	 var fooDeferred = $.Deferred(); events.foo = fooDeferred.promise(); ...... when foo is done, fooDeferred.resolve();
[22:42:53] <RoanKattouw>	 If your promise comes from somewhere else, you'd have to chain the promises, which I'm sure is possible, hang on
[22:43:35] <Krinkle>	 RoanKattouw: $.when
[22:43:42] <Krinkle>	 (I think(
[22:43:57] <RoanKattouw>	 Right
[22:44:20] <Krinkle>	 you can use .apply if you have an array instead of literal arguments
[22:44:29] <RoanKattouw>	 Krinkle: No my (hypothetical) problem is the promise I'm chaining won't exist until later
[22:44:42] <Krinkle>	 Aha
[22:44:46] <RoanKattouw>	 I mean this
[22:44:54] <RoanKattouw>	 Suppose I have some API that will give me a promise
[22:45:12] <Krinkle>	 Then you'll want to have a placeholder deferred that is then piped/forwarded from the other one once it exists
[22:45:12] <RoanKattouw>	 But I have a member I need to init as a promise and that I can't reassign later because things will bind to it
[22:45:17] <RoanKattouw>	 Yes, exactly
[22:45:42] <RoanKattouw>	 But is there a clean way to do that without stuff like .done( otherPromise.resolve.apply( ... ) ).fail( otherPromise.reject.apply(...) ) ?
[22:46:14] <Krinkle>	 e.g. mine = $.Deferred; /* time passes */ yours.done(mine.resolve).fail(mine.reject); You might be able to use .pipe/.then instead
[22:46:26] <RoanKattouw>	 mwalker: I hope we're not confusing you too much :) could you clarify whether you're creating the promise yourself or getting it from something else?
[22:46:33] <Krinkle>	 no need for .apply there
[22:46:36] <RoanKattouw>	 Krinkle: Oh, right, they're bound, I forgot
[22:46:44] <Krinkle>	 indeed :)
[22:50:46] <mwalker>	 I'm generating it myself in CentralNotice
[22:52:40] <mwalker>	 but what I'm hearing from you is that I write the dict as foo.bar = { baz: $.Deferred() };
[22:53:30] <mwalker>	 and then in init take foo.bar.bazDeferred = foo.bar.baz; foo.bar.baz = foo.bar.baz.promise() ?
[22:57:19] <gerrit-wm>	 New review: Matmarex; "This looks like a really overengineered workaround to me." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72614
[22:58:11] <gerrit-wm>	 New patchset: Spage; "(bug 47792) Fixed message for creations by email" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66193
[22:58:23] <mwalker>	 RoanKattouw: actually -- I guess I can just use mw.hook to accomplish this
[22:58:36] <mwalker>	 the documentation is not so great -- but it removes the responsibility from CentralNotice
[22:58:54] <RoanKattouw>	 Oh OK
[23:00:14] <mwalker>	 unless that's not the preferred method for doing this? and I really should be using promises/deferreds in my own extension
[23:00:50] <RoanKattouw>	 I don't really know
[23:00:53] <RoanKattouw>	 I don't know anything about mw.hook
[23:02:49] <mwalker>	 https://git.wikimedia.org/blob/mediawiki%2Fcore/HEAD/resources%2Fmediawiki%2Fmediawiki.js#L1809
[23:03:05] <mwalker>	 well; actually; this won't help me
[23:03:25] <RoanKattouw>	 How so?
[23:03:35] <mwalker>	 because I want the functionality of a promise -- e.g. will fire immediately if it's already been triggered
[23:04:36] <RoanKattouw>	 Yes, and mw.Hook does that too
[23:04:38] <RoanKattouw>	 per its docs
[23:05:19] <mwalker>	 oh, duh
[23:05:34] * mwalker  goes back to school for reading comprehension 

[23:20:22] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72651
[23:20:26] <bawolff>	 Is it a known issue that ?action=purge performance goes down significantly on image pages with large number of previous versions?
[23:21:10] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72651
[23:21:17] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72652
[23:21:24] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72652
[23:28:02] <marktraceur>	 ori-l: Hey, I'm trying to get oracle-java8 installed on a vagrant machine, and I want to set an environment variable for a run of package { } so it doesn't pull up an interactive interface for the licenses...is this possible? Easy? Already done and I don't need to complicate things?
[23:29:19] <gerrit-wm>	 New patchset: Catrope; "Update AbuseFilter to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72654
[23:29:32] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/72654
[23:30:10] <ori-l>	 marktraceur: google 'puppet preseed debian' w/o the quotes
[23:30:35] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[23:30:40] <gerrit-wm>	 New patchset: Catrope; "Update AbuseFilter to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72655
[23:31:15] <gerrit-wm>	 New patchset: Catrope; "Update AbuseFilter to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72655
[23:31:26] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/72655
[23:31:46] <marktraceur>	 Thankee ori-l
[23:31:58] <marktraceur>	 ori-l: Is this already in the puppet files somewhere or should I put it in?
[23:32:15] <gerrit-wm>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[23:32:30] <gerrit-wm>	 New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/72657
[23:35:15] <marktraceur>	 Answer: Putting it in.
[23:42:23] <gerrit-wm>	 New patchset: Mollywhite; "Disallow properties that aren't in the JSON schema." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72658
[23:42:30] <gerrit-wm>	 New review: Brion VIBBER; "This bad boy seems to work as expected for me, using an import of the Commons campaigns." [mediawiki/extensions/UploadWizard] (master) C: 1;  - https://gerrit.wikimedia.org/r/70446
[23:44:45] <gerrit-wm>	 New review: Mollywhite; "Self-merge" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72658
[23:44:45] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72658
[23:50:39] <gerrit-wm>	 New patchset: Mollywhite; "Bug 50987: Use a directory variable instead of calling repeatedly." [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[23:54:36] <gerrit-wm>	 New review: Mollywhite; "Minor change to code style" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/72660
[23:54:38] <gerrit-wm>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/72660
[23:55:51] <gerrit-wm>	 New patchset: Mwalker; "(FR #987) Fix Luhn Check for Odd Numbered Cards" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/72661
[23:57:18] <gerrit-wm>	 New patchset: Ori.livneh; "Nudge user to 'git pull' if lagging behind remote" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72662