[00:05:13] karima To clarify, you want to take a commit that is merged in master, and merge it also in REL1_21 ? [00:05:49] yes [00:06:15] for the download in mediawiki [00:07:24] bawolff:may be there is also a process for that [00:07:40] This is in your own extension I assume [00:07:50] ofcourse [00:08:03] If its your own extension and the extension is not being used by wmf, you're allowed to back port whatever you want [00:08:27] On gerrit, do you see the "cherry-pick to" button? [00:08:37] yes [00:08:37] for the commit you want to backport [00:08:49] you can use that to tell it to move the commit to a different branch [00:09:10] hmm ok... [00:13:23] New patchset: Karima Rafes; "Update for MediaWiki 1.21 and add basic test" [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72328 [00:14:43] Change merged: Karima Rafes; [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72328 [00:15:40] New patchset: Karima Rafes; "Patch 3" [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72329 [00:16:15] Change merged: Karima Rafes; [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72329 [00:16:31] New patchset: Karima Rafes; "fix several problem" [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72330 [00:16:54] Change merged: Karima Rafes; [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72330 [00:17:27] New patchset: Karima Rafes; "Fix the tests" [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72331 [00:17:50] Change merged: Karima Rafes; [mediawiki/extensions/LinkedWiki] (REL1_21) - https://gerrit.wikimedia.org/r/72331 [00:19:14] bawolff: it's normal ? REL_21 is not in https://git.wikimedia.org/log/mediawiki%2Fextensions%2FLinkedWiki [00:21:10] I guess its because gerrit changed the commit message, so its not the exact same commit. But its in there - https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FLinkedWiki/45966140f31517b466f31582ea3bfdd983001acc [00:21:22] See also https://git.wikimedia.org/log/mediawiki%2Fextensions%2FLinkedWiki/REL1_21 [00:21:49] New patchset: Shirayuki; "Replace "your are" by "you are"" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/72332 [00:24:03] bawolff: thanks ! My first commit ! And last question : there is doc on jenkins and where I can push my script of test ? [00:24:41] Umm, I don't know actually. Best bet is to try and track down hashar and ask him [00:24:48] bawolff, karima_, karima: http://stackoverflow.com/questions/12840279/how-to-merge-the-gerrit-branch-to-another-gerrit-branch [00:25:28] karima_: If its php unit tests, I think you can register them in mediawiki (that doesn't make jenkins run them, but is step 1) [00:25:40] AzaToth: thanks for the next time [00:25:49] karima: for jenkins, it's in the integration/jenkins-job-builder-config repo [00:26:46] bawolff: I would assume there is a jenkins job to run all phpunit tests right? [00:27:21] AzaToth: I have phpunit and cucumber... [00:28:59] phpunit is not commit for the moment [00:29:25] karima: are you karima_ ? [00:29:44] yes [00:29:53] wait [00:29:55] karima_: anyway, integration seems to do phpunit for extension [00:30:02] but not cucumber [00:30:10] test [00:30:12] ok [00:31:11] browser_qa has a bot jenkins in gerrit [00:32:08] I try to do the same thing... it's cool [00:32:15] LinkedWiki isn't listed though [00:32:28] it's a static list, so I assume new extensions haven't been added [00:32:46] chrismcmahonafk would be the one to ask for getting automatic cucumber tests running I believe [00:33:03] it's a very old... I work on it only the summer [00:34:42] I need to install in Jenkins and after I work on the server of test in the lab... [00:35:43] after anyone will can work on it [00:36:12] it's my plan for this summer [00:36:36] ok [00:38:00] New patchset: AzaToth; "add LinkedWiki extension to mwext-check-jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/72333 [00:38:06] karima: ↑ [00:38:21] now someone has to OK it [00:38:29] still lacks cucumber checks [00:38:50] dunno if make a specific check for that or make it generic [00:40:42] AzaToth: ok I wait ? or I add a script in my project ? [00:42:53] karima: only the folks in #wikimedia-operations has the power to add new jobs to jenkins [00:43:07] hashar in particular I would say [00:43:36] but you can add all tests you want [00:43:58] wont probably be added to jenkins during the weekend [00:44:08] they still have some kind of work week ツ [00:44:26] no problem... I have one month [00:45:01] Good... Thanks for your helps ;) [00:45:16] np [00:46:15] bawolff: also thanks for gerrit !!! Bye Bye [00:46:25] bye [01:17:36] New patchset: Brian Wolff; "[Goes with I33462a8] Support for new gallery." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69455 [01:17:42] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [01:18:41] New patchset: Brian Wolff; "[Goes with I33462a8] Support for new gallery." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69455 [01:37:23] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [01:44:09] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [01:45:12] ugh, should have looked at jenkins output before hitting git review... [01:55:15] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [01:56:04] I think I'm starting to remember why I started doing php stuff instead of js stuff [01:56:18] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:01:01] New patchset: Shirayuki; "Fix the capitalization" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72088 [02:01:01] New patchset: Shirayuki; "Replace "revison" by "revision"" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/72334 [02:08:17] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [02:09:36] New review: Parent5446; "Looks good, although hopefully this function can just be deprecated when the Uri class makes it to c..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/72312 [02:29:49] New patchset: Shirayuki; "Fix spelling (cannot)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72336 [02:41:18] New review: Brian Wolff; "This is now ready to the stage where it could use code review." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [02:51:32] New patchset: Shirayuki; "Fix spellings (its)" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/72337 [02:58:07] New patchset: Shirayuki; "Fix capitalization (MoodBar)" [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/72338 [03:03:22] New patchset: CSteipp; "Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/71741 [03:03:47] New patchset: Shirayuki; "Capitalize "PDF"" [mediawiki/extensions/Mpdf] (master) - https://gerrit.wikimedia.org/r/72339 [03:11:33] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #168: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/168/ [03:14:56] New patchset: Shirayuki; "Capitalize "PDF"" [mediawiki/extensions/Mpdf] (master) - https://gerrit.wikimedia.org/r/72339 [03:21:06] New patchset: Shirayuki; "Fix spelling (one-time)" [mediawiki/extensions/OATHAuth] (master) - https://gerrit.wikimedia.org/r/72340 [03:26:51] New patchset: Brian Wolff; "[Goes with I33462a8] Support for new gallery." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69455 [03:27:53] New patchset: Brian Wolff; "New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [03:39:04] New patchset: Shirayuki; "Replace "reprecusions" by "repercussions"" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/72341 [03:55:43] New review: Parent5446; "Not familiar with SUL, so not sure if/why it works, but the code looks good to me." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/71741 [04:08:36] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [04:09:28] New review: Brian Wolff; "PS7: it should work on all dbs now (only tested on mysql and sqlite though)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [04:11:23] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [04:24:51] New patchset: Shirayuki; "Replace "linkd" by "linked"" [mediawiki/extensions/Push] (master) - https://gerrit.wikimedia.org/r/72342 [04:27:01] New review: Daniel Friesen; "This is going to pretty much mess up the positioning every skin uses. Trying to change this to fixed..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72322 [04:27:09] New patchset: Ori.livneh; "Load optional roles from ./Roles.yaml, if present" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72343 [04:27:27] ^ marktraceur, you might be interested in that [04:27:36] Ooooh [04:28:27] it's kind of a hack [04:28:34] but it seems to work well enough [04:30:06] another way to do that apparently is to use hiera, but hiera isn't included w/puppet 2.7 by default, and that's the version that ships w/the image from canonical [04:30:42] some people have resorted to using a shell provisioner that runs before puppet and whose job it is to upgrade puppet, but that seemed gross and fragile. [04:31:31] D'you want to add me as a reviewer? I might get a chance to come back to it...ugh, sometime. [04:31:53] i just did a moment ago :) [04:32:13] Yaay [04:49:00] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [05:17:46] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #124: FAILURE in 7 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/124/ [05:41:45] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [05:41:45] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [05:43:17] New patchset: Shirayuki; "Fix spelling (permissions)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/72344 [05:47:48] New patchset: Shirayuki; "Fix spelling (exceeds)" [mediawiki/extensions/SemanticPageSeries] (master) - https://gerrit.wikimedia.org/r/72345 [05:50:38] New patchset: Shirayuki; "Fix spelling (collapsible)" [mediawiki/extensions/SideBarMenu] (master) - https://gerrit.wikimedia.org/r/72346 [05:57:08] New patchset: Shirayuki; "Fix spelling (minimum)" [mediawiki/extensions/Survey] (master) - https://gerrit.wikimedia.org/r/72347 [06:37:46] New patchset: Ori.livneh; "Use php::ini resource type" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72349 [06:38:02] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72349 [06:43:49] New patchset: Ori.livneh; "Expand tabs." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72350 [06:56:06] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [07:17:59] New patchset: Santhosh; "Load messages from a fallback chain" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72065 [07:53:21] New review: Ori.livneh; "Tested by re-provisioning from scratch." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/72350 [07:53:23] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72350 [08:04:24] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72065 [08:14:31] Change merged: jenkins-bot; [mediawiki/extensions/Survey] (master) - https://gerrit.wikimedia.org/r/72347 [08:20:43] New patchset: Ori.livneh; "Load optional roles from ./Roles.yaml, if present" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72343 [08:20:43] New patchset: Ori.livneh; "Disable Puppet-lint's 'class_parameter_defaults' warning" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72355 [08:47:18] New review: Wikinaut; "Jpond wrote" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71961 [08:53:52] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/72336 [09:36:25] New patchset: Hashar; "option to strip requested prefix index in the list" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71911 [10:04:00] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72065 [10:38:52] dutch wiki: [10:38:53] PHP fatal error in /usr/local/apache/common-local/php-1.22wmf8/includes/parser/Preprocessor_DOM.php line 955: [10:38:56] Argument 1 passed to DOMXPath::__construct() must be an instance of DOMDocument, null given, called in /usr/local/apache/common-local/php-1.22wmf8/extensions/Scribunto/engines/LuaCommon/LuaCommon.php on line 500 and defined [11:34:28] New patchset: Ori.livneh; "Load optional roles from ./Roles.yaml, if present" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/72343 [11:38:51] New patchset: Shirayuki; "Fix confirmThanks() for Diff view" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/72357 [11:43:12] New patchset: Shirayuki; "Fix confirmThanks() for Diff view" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/72357 [11:43:48] New patchset: Anomie; "Fix fatal in frame:callParserFunction" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/72358 [11:57:02] New patchset: Santhosh; "Documentation for mw.uls.init" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72359 [12:26:28] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [12:26:28] New patchset: Rjain; "Begining of making read class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72360 [12:26:29] New patchset: Rjain; "Added the search class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/72361 [12:26:43] New patchset: Amire80; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72093 [12:26:54] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [12:30:47] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [12:35:58] New patchset: Amire80; "Load messages from a fallback chain" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72065 [12:40:14] New patchset: Se4598; "Add triggered filter id as parameter to messages" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291 [12:46:47] New patchset: Physikerwelt; "Check if media wiki core is capable of xml type checking" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/72362 [13:04:30] New review: Tpt; "Some remaining points." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/71172 [13:09:43] whats the best way to add a banner to every page on the top of the body? [13:09:59] would I use a plugin or just manually edit the template? [13:10:27] Its the same banner on everypage and its static, may change but once a year [13:12:10] New review: Santhosh; "It is better to have a default font for fa gloablly to make sure content in fa is readable everywhere. " [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69878 [13:18:47] New review: Physikerwelt; "how to go on with this issue." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [13:22:12] whitebook: you can use the sitenotice [13:22:14] !sitenotice [13:22:14] Sitenotice is a wiki-wide message that appears at the top of the page for all users. It is editable by users in the sysop usergroup at [[MediaWiki:Sitenotice]]. See also: !anonnotice [13:25:55] Thx will check [13:32:44] anyone know why it's called the "universal" language selector anyways? [13:32:50] (asking for the sake of translation) [13:33:07] using it does set your pref on all wikis or something, does it? [13:33:13] no [13:33:27] probably because it has glued together from two other extensions and some other random components [13:33:32] which really don't belkong together [13:33:33] hahaha [13:33:37] so it's now universal [13:33:49] so it replaces all ther est of the crapola you mean [13:33:50] ok [13:33:51] hmmm [13:34:20] but i'm an outsider, the ULS team would know better ;) [13:34:22] too bad it's not just called "language selector" [13:34:26] it would be so much more helpful [13:34:30] right [13:34:54] ok, I'll ask Nikerabbit next time I see him around [13:34:56] thanks! [13:35:29] apergos: initial reasons I've heard from a long long time ago (when ULS was first being talked about) was for it to be used 'everywhere', aka not just on WMF sites and not just on desktop [13:35:39] that was also part of the reasoning towards having it hosted on GitHub [13:35:48] and also why we have GSoC students creating Firefox and Chrome extensions [13:35:56] but I might of course be very wrong :) [13:36:16] :-D [13:36:50] it was also in the process of being used as language selector on other places, IIRC [13:36:56] Red Hat / Mozilla, etc [13:37:21] ok well I have to think about it some, we have "unified" and "global" (which tuens out to have the same translation as "universal" in som e of the account stuff [13:37:22] New review: Ebrahim; "No, please. I said https://bugzilla.wikimedia.org/show_bug.cgi?id=49957#c24 here why. As an example,..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69878 [13:37:30] so that complicates matters [13:37:42] that would be nice if we had [13:37:53] one language selector to rule them all [13:38:36] hah [13:38:43] i think ULS is supposed to be that [13:40:19] in the land of unicode where the shadows lie [13:40:25] unicode is kinda like mordor in my mind [13:41:33] unicode is cool [13:41:53] there are plenty of people who say mordor was cool too [13:42:11] the seat of technological progress in a middle earth too infatuated with its 'glorious past'... [13:42:34] hmm, eerily similar to Unicode, except we don't have people pining for good ol' days of ASCII [13:42:41] I've been in unicode hell way too many times to say it's cool [13:42:43] (at least nobody to raise armies) [13:42:57] apergos: the name comes from an idea by guillom, iirc [13:43:08] * apergos is all ears [13:43:11] apergos: worses than code pages? [13:43:13] say more, say more [13:43:14] What did I do again? [13:43:30] ug [13:43:31] http://www.gpaumier.org/blog/628_universal-language-picker/ [13:43:44] I'm innocent! I have nothing to do with that! :P [13:44:02] ooo I remember this :) [13:44:07] the tower of babl, looks remarkably like orthanc before it went completely bad [13:44:31] Ah, memories. [13:45:10] so maybe you can tell me guillom [13:45:12] apergos: at some point it will take care of interlanguage links too, and hopefolly help fix the half dozen language selection tools on Commons [13:45:16] why it's "universal" [13:45:54] apergos: It was 3 years ago; I forgot :P I'd say, ask the people who chose that name :) [13:45:54] besides, it's a jquery plugin so any website could use it [13:46:11] who chose it, do you remember? [13:46:14] perhaps it was a bit inspired by the Universal Edit Button? [13:46:25] Ah, that's possible [13:46:33] uhh.. [13:46:40] what's the universal edit button? [13:47:14] the button that should show up in your browser when visiting any website you can edit [13:47:30] no wonder I don't know what it is [13:47:37] another big tease :-( [13:48:05] no need to think of other websites though, we have so many places where a language selection of sort happens.. [13:48:48] Nikerabbit: [13:48:56] since you ug'ed I guess that means you are here [13:49:06] sort of :P [13:49:28] any chance you remember why the name 'universal' in 'uls' means? [13:49:31] *what [13:49:39] I'm only sort of here too, don't worry [13:50:03] like ringwraiths waiting for mortals to pass into their sphere [13:51:50] * YuviPanda notes too many LotR references in a short time [13:53:14] apergos: why not? [13:53:18] apergos: as it's for translation, I think "unified" would be ok [13:54:12] Nikerabbit: why not what? [13:54:28] why not = what's wrong with "universal" [13:54:31] so if you do remember what was meant by ?universal" (why that was chosen), could you say a couple words about it? [13:54:46] no I don't remember how the name was chosen [13:54:50] ah rats [13:54:56] it is easier to google than just language selector though [13:55:29] ok well we'll come up with something or other I guess... [13:55:36] thanks, sorry for the waste of bandwidth [13:57:40] oh those poor electrons [13:59:19] nah, t's more about those poor eyeballs [14:37:58] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [14:54:05] at last! [14:54:16] GNU gettext 0.18.3 released [14:54:24] The 0.18.3 release has support for 4 new programming languages: Glade 3, [14:54:24] JavaScript, Lua, and Vala, support for Python 3 format strings, support [14:54:24] for newer Automake, portability fixes, and normal bug fixes. [14:54:59] took many years for us to get js support in gettext :( [14:58:04] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [15:02:36] AzaToth: too late, I suppose? [15:02:44] since most things that do js and have i18n have their own formats now [15:12:44] New patchset: Amire80; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72093 [15:17:07] YuviPanda: things can be fixed [15:17:35] I think it's Starling's law which says 'Things that are meant to be temperoary tend to become permanent' [15:18:22] YuviPanda: Depends on which Starling you're talking about [15:18:40] there are multiple starlings? [15:18:50] I don't know who coined it as a 'law' tho [15:19:03] This predates Tim's birth [15:22:55] YuviPanda: life it meant to be temporary [15:23:02] deep [15:23:09] ツ [15:23:24] multichill: there should be another law about how all such laws have already been formed but people just keep making up different names for it [15:32:30] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72093 [15:42:49] YuviPanda: Sorry, I worked on my own project more than I should have, I'll try to make it up to you today [15:43:00] d'aww [15:43:21] marktraceur: I might not have expressed how grateful I am that you're even helping with this, considering you don't *have* to [15:43:28] * YuviPanda expresses that now [15:43:28] Not right now, as I have a flight in 3.75 hours, but around 14:30 I'll be home [15:43:30] Thanks :) [15:43:40] *nod* 's understood, man, that's what we do 'round here :) [15:43:46] :) [15:44:24] enjoy your flight, marktraceur! [15:44:31] * YuviPanda goes to try becoming unsick [15:50:45] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/72093 [15:54:43] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [16:38:24] New review: Tpt; "Two little cosmetics points." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [16:56:10] New patchset: Amire80; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [16:59:29] New patchset: Amire80; "WIP: Trying to write a test for bug 50790" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/72365 [17:06:41] New review: Matmarex; "> Yes, parameters could be handled by BadTitleError class. And yes, in that case $this->mBadtitleErr..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166 [17:14:41] New patchset: Jeroen De Dauw; "Explicit refs to globals" [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72366 [17:14:42] New patchset: Jeroen De Dauw; "use wfMessage" [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72367 [17:14:42] New patchset: Jeroen De Dauw; "Rem dead links" [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72368 [17:14:42] New patchset: Jeroen De Dauw; "Adding a preload parameter" [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72369 [17:15:23] New patchset: Jeroen De Dauw; "Adding a preload parameter" [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72369 [17:15:39] Change merged: Jeroen De Dauw; [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72366 [17:15:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72367 [17:15:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72368 [17:16:06] Change merged: Jeroen De Dauw; [mediawiki/extensions/CreatePage] (master) - https://gerrit.wikimedia.org/r/72369 [17:24:07] thedj: you alive? [17:24:38] thedj: do you think $.makeCollapsible should add tabindex=0 role=button to all custom togglers? https://bugzilla.wikimedia.org/show_bug.cgi?id=17616#c13 [17:25:13] or rather, is there a reason why it shouldn't? [17:52:15] MatmaRex: perhaps to all custom toggles [17:52:38] MatmaRex: adding it to a might be a bit over the top. Though really it wouldn't hurt either. [18:11:29] Yippie, build fixed! [18:11:30] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #169: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/169/ [18:19:49] New patchset: Jeroen De Dauw; "Make tests less bound to MW" [mediawiki/extensions/SubPageList] (1.0.x) - https://gerrit.wikimedia.org/r/72370 [18:20:21] Change merged: Jeroen De Dauw; [mediawiki/extensions/SubPageList] (1.0.x) - https://gerrit.wikimedia.org/r/72370 [18:27:15] New patchset: Matmarex; "jquery.makeCollapsible: Togglers accessibility" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72371 [18:27:24] thedj: ^ when you feel like looking [18:40:35] New patchset: Matmarex; "Correctly use $wgFeedLimit in page history feed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72372 [18:40:38] New review: Parent5446; "Some comments. Also, this patch seems to accidentally change the permissions on a bunch of files." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/71364 [18:42:07] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/72361 [18:51:21] New review: Matmarex; "Argh, I forgot that position:fixed is always relative to the entire document, not to any positioned ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72322 [18:55:04] hey matanya [18:59:21] New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373 [18:59:34] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [19:00:01] New review: Kaldari; "Not finished" [mediawiki/extensions/PageImages] (master) C: -1; - https://gerrit.wikimedia.org/r/72373 [19:00:36] New review: Tpt; "All looks good now :-)" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: 2; - https://gerrit.wikimedia.org/r/71172 [19:13:00] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [19:22:24] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [19:39:11] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71121 [19:53:03] New review: Parent5446; "Nevermind, I'll just handle it in the next commit." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/71121 [19:53:55] New review: Yury Katkov; "looks good for me" [mediawiki/extensions/SemanticGlossary] (master) C: 1; - https://gerrit.wikimedia.org/r/71969 [20:07:50] New patchset: Parent5446; "Changed MWTimestamp to extend DateTime for ease of use" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72453 [20:15:03] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [20:20:20] Yippie, build fixed! [20:20:21] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #125: FIXED in 7 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/125/ [20:29:01] New patchset: Rtdwivedi; "Separation of rendering part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/72253 [20:43:49] Project browsertests-test2.wikipedia.org-linux-firefox build #397: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/397/ [20:45:10] New patchset: TheDJ; "Thumbnails: Set margin on magnify icon" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72454 [20:55:24] New patchset: Kaldari; "Improving comments in File class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72455 [21:05:00] hi mooeypoo [21:08:15] heyhey [21:08:33] figured I'd say hello :) I see you in the VE feedback page a lot! [21:11:52] dammit thedj, remind me why do we have so many duplicated CSS files [21:12:08] also, oldshared.css is now apparently only used by cologneblue [21:12:19] i wonder if moving it would break backcompat badly [21:14:53] mooeypoo: thanks :) had some extensive testing days some time ago [21:16:03] BTW mooeypoo if you need any help, i'd be glad to help out [21:23:39] matanya: I'll keep it in mind, thanks a lot :) I'm trying to sort out the bugs we should deal with, the feedback has abunch that I think were corrected in the massive code-changes in the past 2 weeks [21:24:03] yeah, i can't repro most of them [21:24:08] but it's odd when I can't replicate a bug and people don't come back to answer :P but overall I think the reactions are pretty good [21:24:30] I may wait a couple of days and then just set those non-reproduceable bugs as assumed 'resolved' [21:24:42] i trust the users will complain again if there's still a problem... [21:24:51] would you like me to try repro some of those you aren't ablw to repro? [21:25:00] *able [21:25:09] if you can, that'll be great. Some of them I have a strong feeling were already fixed. The older ones probably. [21:25:31] can you like to BZ ? [21:25:40] #1, for example... pretty sure it's not relevant anymore. [21:25:42] BZ ? [21:26:01] bugzilla [21:26:20] or you prefer working on the VE page in he.wiki? [21:26:40] well, I try to only submit bugs I can replicate and make sure are not user errors in bugzilla [21:27:11] ok, look at he.wiki [21:27:17] so i am going through the feedback page to see which need to be bugzilla'ed and which might be stuff like suggestions (which I pass to the crew) or user error ... or translation, in which case I fix them [21:27:19] New patchset: Nilesh; "Fixed errors in wikiparser scripts and tested on Hadoop." [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/72457 [21:27:43] which one are you refering to as #1? [21:28:25] I'm going by the content box, so that would be "1 תמונות בצד ההפוך" [21:28:56] same with #3, though, Amir couldn't replicate (neither could I) [21:29:30] do you have a windows machine in hand? [21:29:33] I do [21:29:47] bad for you :) [21:30:00] haha [21:30:08] the only windows here is win7 and it is off now [21:30:16] gets worse, I work on a Windows8 machine :p [21:30:43] i have some co-workers who have that, poor them [21:30:50] I do have arch on this machine [21:30:51] anywyas, when I edit those pages I see the pictures well [21:31:03] so i can try it here [21:31:07] there ARE problems with the way the box is viewed, but that's more or less expected [21:31:07] let me see [21:31:10] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72455 [21:31:34] the text "רחוב ירושלים" dropped below its box. The picture is visible, though, for me. [21:32:00] yes, it dropped. [21:32:02] but .. ah! I did find a bug. Not related... the "Transclusion" popup icon appears in the opposite side of the page. I thnk i can fix it, I'll submit a but about it. [21:34:14] mooeypoo: just found a new bug, special for you [21:35:32] ooo [21:35:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=50905 <-- this one too [21:36:32] New review: PleaseStand; "I haven't looked at the code in detail, although I question whether this is really a good idea." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72453 [21:36:45] mooeypoo: https://he.wikipedia.org/wiki/%D7%A1%D7%9C%D7%A1%D7%94_%28%D7%A8%D7%99%D7%A7%D7%95%D7%93%29 [21:37:18] edit the קישורים חיצוניים with VE and go to the end of the link there and press tab [21:37:22] what happens? [21:37:37] hang on [21:37:54] hmmm [21:37:55] interesting [21:38:09] actually I think this is a general problem, not just RTL [21:38:19] do you get many dots? [21:38:28] New patchset: Jeroen De Dauw; "Update composer file" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72458 [21:38:28] New patchset: Jeroen De Dauw; "Update gitignore" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72459 [21:38:29] New patchset: Jeroen De Dauw; "Add PSR-0 based class loading" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72460 [21:38:29] I get 2 dots [21:38:29] New patchset: Jeroen De Dauw; "Added phpunit config file and bootstrap" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72461 [21:38:29] New patchset: Jeroen De Dauw; "Add todos" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72462 [21:38:29] New patchset: Jeroen De Dauw; "Automatically registers tetss with MW test hook" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72463 [21:38:35] it's indenting wrong [21:38:40] give another tab [21:38:40] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72458 [21:38:46] New review: Ori.livneh; "(1 comment)" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [21:38:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72459 [21:38:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72460 [21:38:54] yeah each tab = "pseudo" indent [21:39:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72461 [21:39:06] i think it's a general indentation problem, let me test this on the english wiki [21:39:09] we should find a cannel without gerrit [21:39:10] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72462 [21:39:16] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72463 [21:39:53] matanya: #mediawiki-visualeditor [21:47:22] * YuviPanda grumbles about bots driving people like mooeypoo and matanya away from general channels into more specific, lower traffic ones [21:47:36] New patchset: Kaldari; "PageImages on File namespace should be the file itself" [mediawiki/extensions/PageImages] (master) - https://gerrit.wikimedia.org/r/72373 [21:48:07] New review: Kaldari; "Not complete" [mediawiki/extensions/PageImages] (master) C: -1; - https://gerrit.wikimedia.org/r/72373 [21:49:18] New patchset: Jeroen De Dauw; "Added TravisCI config" [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72464 [21:49:24] YuviPanda: that's why all bots should go in onechannel [21:49:27] Change merged: Jeroen De Dauw; [mediawiki/extensions/ParserHooks] (master) - https://gerrit.wikimedia.org/r/72464 [21:49:35] YuviPanda: there are two spambots here and one in #mediawiki [21:49:37]