[00:19:34] New patchset: AzaToth; "Add debian-glue macros" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71245 [00:26:23] New patchset: Hoo man; "Make use of the APIEditBeforeSave hook for nicer errors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71945 [00:32:08] New patchset: Aaron Schulz; "[WIP] Added consumer request and approval pages" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/71156 [00:36:44] New patchset: Aaron Schulz; "[WIP] Added consumer request and approval pages" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/71156 [00:47:43] New patchset: Catrope; "Update VE to master again to pick up 10fd1a3, 1875851" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71946 [00:47:54] New patchset: Catrope; "Update VE to master again to pick up 10fd1a3, 1875851" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71947 [00:48:02] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71947 [00:48:10] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71946 [00:57:59] New patchset: Catrope; "Fix occasional collapsibleTabs JS error" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71948 [01:00:25] New patchset: Catrope; "Fix occasional collapsibleTabs JS error" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71950 [01:00:33] New patchset: Catrope; "Fix occasional collapsibleTabs JS error" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71951 [01:02:46] New patchset: Jpond; "(Bug 50710)Compatibility File::thumbName & File::publish" [mediawiki/extensions/NSFileRepo] (master) - https://gerrit.wikimedia.org/r/71952 [01:09:37] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71948 [01:09:59] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71951 [01:10:19] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71950 [01:43:58] New patchset: Catrope; "Update VE to pick up 092fa74" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71956 [01:44:20] New patchset: Catrope; "Update VE to pick up 092fa74" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71957 [01:44:35] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71957 [01:44:43] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71956 [02:06:52] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70215 [02:07:48] New patchset: Jpond; "Special:OpenIDDashboard still using wgOpenIDClientAndProviderMode Bug: 50712" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71961 [02:17:33] New patchset: Krinkle; "Enable @example for jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70787 [02:17:40] New patchset: Krinkle; "Enable @example for jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70787 [02:17:58] New patchset: Krinkle; "mediawiki-core-jsduck-publish: Copy resources directory" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71247 [02:21:22] New review: Anomie; "This isn't any better on the versioning. Which in general still seems to me like it's going to cause..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71759 [02:29:47] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [02:33:04] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [03:03:58] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71247 [03:21:35] lol, I guess Gerrit's diffing is drunk? [03:21:36] http://cl.ly/image/2l2Y0V3o1K1I [03:22:23] New review: MarkTraceur; "I like it! Seems to work locally too." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/70787 [03:23:23] * marktraceur merges core patch, disappears for two hours [03:23:27] Muahaha. [03:24:54] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70787 [03:27:32] New review: Krinkle; "Though it needs a rebase, looks good to me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/67264 [03:28:29] New review: Krinkle; "I'd recommend pulling this out of the stack or at least lower in the stack to separate enhancements ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [03:30:53] New patchset: Krinkle; "CSSJanus: Fix handling of CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [03:31:03] New review: Krinkle; "Resolved merge conflicts." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67263 [03:31:33] marktraceur: Thx for merging the @example [03:31:35] https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.html [03:31:36] It's workign [03:31:40] it's working [03:32:27] e.g. remove "new Html.Raw" (leaving the "(") to see what happens if it gets interpreted as text instead of raw html [03:32:34] (switching back and forth with live preview) [03:33:10] New patchset: Krinkle; "doc: Improve documentation for mw.Map and mw#config" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70596 [03:33:32] marktraceur: Can you merge https://gerrit.wikimedia.org/r/#/c/70596/ per Ori's +2 ? [03:33:38] It had a dependency, rebased it now. [03:33:59] Jun 28 [03:34:54] Ah, you already played with it. nice [03:35:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [04:00:04] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63631 [04:09:23] New patchset: Aaron Schulz; "Compatibility of File::thumbName & File::publish" [mediawiki/extensions/NSFileRepo] (master) - https://gerrit.wikimedia.org/r/71952 [04:10:27] Change merged: Aaron Schulz; [mediawiki/extensions/NSFileRepo] (master) - https://gerrit.wikimedia.org/r/71952 [04:25:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [04:32:10] TimStarling: can you tell why the Oracle DB class overrides reportQueryError()? [04:34:29] oh, nvm [04:34:39] I see the base is doing the same thing [04:36:48] * Aaron|home dislikes ignoreErrors() [04:56:36] New patchset: Wikinaut; "Special:OpenIDDashboard still using wgOpenIDClientAndProviderMode Bug: 50712" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71961 [04:57:44] New review: Wikinaut; "well spotted! Thanks" [mediawiki/extensions/OpenID] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/71961 [04:57:44] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71961 [05:00:40] New review: Tim Starling; "> It's rather easy, actually: we merge this, we merge I756927b3 in Vector, and as far as I know the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [05:01:24] New review: Yurik; "Anomie, I don't think this is a good forum for discussing versioning approach. I thought we agreed o..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71759 [05:02:25] New patchset: Yurik; "API versioning in module~2 format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71759 [05:06:34] New review: Wikinaut; "jpond:" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71961 [05:16:45] New patchset: Yurik; "PATH_INFO-based API actions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71858 [05:17:18] New review: Yurik; "PS3 is a rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71858 [05:18:50] New patchset: Tim Starling; "Add wgIsProbablyEditable for editability based on quickUserCan." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [05:21:05] New patchset: Tim Starling; "updateCollation.php: sanity check the collation before proceeding" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64503 [05:23:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [05:23:48] Yippie, build fixed! [05:23:49] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #28: FIXED in 5 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/28/ [05:25:51] New patchset: KartikMistry; "Possible license issue with Utkal font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71803 [05:25:52] New patchset: KartikMistry; " Iranian Sans is missing source in font.ini" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71962 [05:26:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64503 [05:29:12] Yippie, build fixed! [05:29:12] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #126: FIXED in 5 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/126/ [05:37:16] Yippie, build fixed! [05:37:16] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #118: FIXED in 8 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/118/ [05:39:07] New patchset: Tim Starling; "Fix protection rights usage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536 [05:39:32] New review: Tim Starling; "PS3: rebase" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/71536 [05:43:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536 [05:44:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70596 [05:50:57] New patchset: Tim Starling; "In $wgConf, allow wgCanonicalServer to be false or absent" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64226 [05:55:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64226 [05:55:43] New patchset: Tim Starling; "Use a UNIX timestamp in the LoggedOut cookie" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65593 [05:56:24] New review: Tim Starling; "PS2: rebase" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65593 [05:56:47] New patchset: Tim Starling; "Use a UNIX timestamp in the LoggedOut cookie" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65596 [05:58:00] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65596 [06:00:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65593 [06:00:23] New review: Ori.livneh; "Nice change; thanks!" [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/71850 [06:00:47] New patchset: Tim Starling; "Add IPv6 range support, for Opera Turbo" [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/66182 [06:01:45] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71850 [06:02:05] New review: Tim Starling; "PS2: added note to trusted-hosts.txt as requested." [mediawiki/extensions/TrustedXFF] (master) C: 2; - https://gerrit.wikimedia.org/r/66182 [06:02:15] Change merged: jenkins-bot; [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/66182 [07:01:47] New patchset: Rtdwivedi; "Separated the rendering and parsing part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71965 [07:14:17] New review: Swalling; "Spage et al: Any reason not to review and merge, now that the old forms are gone?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60952 [07:17:11] New review: FastLizard4; "I'm going to trust you on this one RAN1 :P" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/70452 [07:17:11] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/70452 [07:26:25] New patchset: Aaron Schulz; "jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71966 [08:46:02] New review: Tpt; "The forgotten comments" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/71172 [08:54:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=49935#c14 wtf. [09:29:41] MatmaRex: how much does that issue affect? [09:29:43] I mean https://bugzilla.wikimedia.org/show_bug.cgi?id=49935#c14 [09:30:10] does it cover https://bugzilla.wikimedia.org/show_bug.cgi?id=50245 [09:30:29] ie only when input boxes are clicked? [09:31:17] liangent: it's on page load [09:31:46] liangent: but ULS is full of that kind of crappy code [09:38:35] New patchset: Euvl; "added support for synonyms in Semantic Glossary, added .idea to gitignore" [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969 [09:42:07] New review: Nikerabbit; "Did anyone check if there are and purge unused i18n messages?" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71750 [09:43:07] New patchset: Euvl; "added support for synonyms in Semantic Glossary; added .idea to .gitignore" [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969 [09:46:12] New review: Nikerabbit; "I only see deletions. Commit message says something was moved." [mediawiki/extensions/WikidataEntitySuggester] (master) - https://gerrit.wikimedia.org/r/71772 [09:47:56] New patchset: Njw; "Improve comments throughout" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71970 [09:49:00] addshore: afaik, 100000 years < 293 billion years [09:54:17] only if both sides are about the same planet and similar speed [09:54:36] New review: Njw; "Nothing to see here, no code changes." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/71970 [09:54:38] Change merged: jenkins-bot; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71970 [10:06:15] New review: Nikerabbit; "Which versions of IE?" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/71795 [10:10:07] New review: Nemo bis; "Needs rebase..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41386 [10:13:47] New patchset: Nemo bis; "Use {{int:}} syntax to ensure consistent translations" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/50362 [10:15:32] New review: Nemo bis; "This is a JS popover or popwhatever that appears when editing entities e.g. adding a sitelink. Accor..." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/50362 [10:17:13] New review: Matmarex; "It was reported for IE9 and IE10 (see the bug), I was only able to reproduce on IE9." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/71795 [10:21:54] New patchset: Nemo bis; "Ignore now empty message for translation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [10:26:39] AzaToth: exactly :P [10:26:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [10:54:28] New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71973 [10:58:09] New review: Nemo bis; "Needs rebase. Probably better to ignore release notes for now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42279 [11:04:24] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71973 [11:22:36] New patchset: Amire80; "Adjust the position of the menu near the cog by a few pixels" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585 [11:30:54] New patchset: Amire80; "Calculate the position of the menu near the cog properly" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585 [11:55:31] New review: Foxtrott; "Looks good. I think there is a problem left with caching. Please see inline comments." [mediawiki/extensions/SemanticGlossary] (master) C: -1; - https://gerrit.wikimedia.org/r/71969 [12:07:16] New patchset: Njw; "Simplify CSS a tiny bit" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71975 [12:12:47] Change merged: jenkins-bot; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71975 [12:24:06] New patchset: Euvl; "added support for synonyms in Semantic Glossary, added .idea to gitignore" [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969 [12:26:43] New review: Euvl; "Improved caching. Please read my answer in inline comment. Thanks" [mediawiki/extensions/SemanticGlossary] (master) - https://gerrit.wikimedia.org/r/71969 [12:36:53] New patchset: Nikerabbit; "Calculate the position of the menu near the cog properly" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585 [12:37:19] New patchset: Hashar; "some more extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/71976 [12:38:28] New review: Nikerabbit; "Tested on mix of Chrome, IE (8, 9), Firefox and Opera on Windows, Linux and Mac." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/71585 [12:38:49] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585 [12:40:43] New patchset: Hashar; "some more extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/71976 [12:41:05] Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/71976 [12:43:39] hashar: if you plan to do this regularly, adding Raymond as reviewer may be a nice way to notify him of new repos to add to translatewiki.net [12:43:49] I can't find a file-specific feed on gitblit [12:43:57] do what ? [12:44:44] ah adding extensions [12:45:07] Nemo_bis: I am pretty sure raymond has a script already to detect extensions. Most probably out of https://gerrit.wikimedia.org/mediawiki-extensions.txt [12:46:12] ah, it's possible [12:55:53] New patchset: Nikerabbit; "Allow loading redirects in Common languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [13:00:53] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [13:01:46] New patchset: Amire80; "Remove redundant caret elements" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71978 [13:27:48] New review: Nikerabbit; "I tested this in Chrome, IE, Opera and Firefox." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/71784 [13:39:05] ori-l: have you encountered any issues with eventlogging and opera? [13:39:07] New patchset: Amire80; "Allow disabling of IME by a jQuery selector" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [13:43:15] New patchset: Amire80; "Allow disabling of IME by a jQuery selector" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [14:13:16] New patchset: Njw; "Several CSS improvements" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71984 [14:14:19] Change merged: jenkins-bot; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71984 [14:30:42] New patchset: Njw; "Release v1.1" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71987 [14:31:04] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71987 [14:48:10] New patchset: Santhosh; "Use single entry point mw.uls.init for all ULS ui initialization" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71989 [14:48:10] New patchset: Santhosh; "jquery.i18n messagestore for ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71990 [14:52:35] New patchset: Santhosh; "Use single entry point mw.uls.init for all ULS ui initialization" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71989 [15:00:20] New patchset: Tpt; "Add support for x3d files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71991 [15:07:39] New patchset: Tpt; "Adds support for x3d files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71991 [15:08:24] why doesn't Special:Nearby work on the desktop site? [15:08:56] New review: Brian Wolff; "I'm not sure this is safe. I assume the html tags on the list are blacklisted for a reason." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71991 [15:13:04] Nikerabbit: boring to get location? [15:20:20] New review: Demon; "Looks good, but do we have a test for this?" [mediawiki/extensions/Scribunto] (master) C: 1; - https://gerrit.wikimedia.org/r/71820 [15:22:44] New review: Tpt; "If I've well understood the comment before the filtering based on tags code, this filtering is only ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71991 [15:25:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67033 [15:33:35] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/62193 [15:33:51] New patchset: Alex Monk; "Fire Echo event when revision is rejected" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/62193 [15:36:38] New review: Foxtrott; "I think this should work now. I will try it later today." [mediawiki/extensions/SemanticGlossary] (master) C: 1; - https://gerrit.wikimedia.org/r/71969 [15:36:45] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [15:51:00] Hello! Anyone can help me with Apache and URL Rewriting for media wiki? [15:51:27] !shortURL [15:51:36] ... [15:51:38] * Reedy kicks wm-bot [15:51:39] THought today would be a good day to update my wiki. I have successfully upgraded the database. [15:51:49] !shorturl [15:51:49] To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at or try the new beta tool at . There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [15:51:54] !shorturls [15:51:55] Stupid thing [15:51:55] To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at or try the new beta tool at . There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [15:52:13] Thx. [15:53:12] In the logs i see it says applying pattern '^/wiki/(.*)$' to uri 'wiki.phtml/Main_Page' [15:53:28] not sure where its getting wiki.phtml from [15:53:45] see wiki.phtml is just includes index.php [15:54:09] wiki.phtml is there for back wards compatibility... it shouldn't be used [15:55:35] lol, very backwards [15:56:42] so what could be calling it? [15:57:03] very old rewrite rules? [15:57:32] A version of php from when I was in elementary school? [15:57:40] Value true was stored into infobot-help to config [15:57:50] !shorturl [15:57:50] To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at or try the new beta tool at . There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [15:57:58] !shortURL [15:57:58] There is no such key, you probably want to try: !shorturls, !rewriteproblems, [15:58:02] here we go :P [16:05:39] not sure why I am getting a 404 [16:05:52] I followed the guide. [16:05:58] I enabled the rewrite logging [16:06:08] I see it going to wiki.phtml [16:06:14] in my .htaccess I have [16:06:34] RewriteEngine on [16:06:35] RewriteRule ^/?wiki(/.*)?$ %{DOCUMENT_ROOT}/index.php [L] [16:07:14] where is wiki.phtml coming from? [16:07:24] this mediawiki 1.2 [16:07:38] whitebook: MediaWiki 1.2 and not 1.20? [16:07:52] sorry 1.21 [16:07:57] ok :) [16:08:32] I installed it into /var/www [16:08:39] Check your httpd.conf / other apache config files to see if they have some old rewrite rules in them [16:09:02] ok let me see where they might have hidden them. [16:10:19] what about on the wiki side, anything there I should check. [16:10:43] Server version: Apache/2.2.22 (Debian) [16:10:44] $wgArticlePath in your LocalSettings.php [16:10:44] Server built: Mar 4 2013 22:05:16 [16:10:56] I set that to wiki/$1 [16:11:07] no wiki.phtml [16:11:13] I searched there too [16:14:39] seems if I change the article path when I access the wiki it forwards it to /wiki/ [16:14:48] but I get a 404 [16:15:26] and my rewrite rule is off the wiki shorturl site. [16:16:35] If your logs are mentioning index.phtml - it really sounds like you have extra old rewrite rules [16:16:55] EFFIN B! I moved wiki.phtml to w.phtml and it worked [16:17:06] whatever thats about [16:17:25] * bawolff has no idea :) [16:19:21] super strange. But works now. Thanks for your help [16:24:37] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [16:26:24] New review: Reedy; "I guess this replaces the Extension too?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [16:28:52] bawolff: the next thing you need to do is to add support for [[Special:MovePage|moving]] categories ;-) [16:29:25] ashley: Actually, I parent4545 did a commit related to that. I haven't looked at it yet though [16:29:53] ashley: The downside, is my approach for special:randomincategory is rather shitty [16:30:03] but people want it to be efficient without a schema change [16:30:14] seriously? yaaaaaaaaaay :D been long enough (NicDumZ tried to implement it as a GSoC project back in 2008 or so; no clue why it was abandoned) [16:30:26] bawolff: tell 'em that they can't have cake and eat it, too ;) [16:30:27] choices, choices... [16:30:56] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [16:30:56] New patchset: Rjain; "Added the create class The annotations are now stored into the db but need to find out how to get user id and revision id in the API Module." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [16:32:28] Reedy: Didn't even know there was an extension [16:32:46] Reedy: But probably the extension gives better results at the expense of a more expensive query [16:34:03] ashley: I remember there was one attempt I looked at done in the svn days which got reverted because it didn't quite take into account that moving a category meant existing links had to be changed too [16:35:05] I never even noticed that you couldn't move categories. [16:35:11] mmm...how complicated would it be to take that into account? [16:36:23] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [16:36:38] you'd have to come up with a reliable way to edit all pages to use the new category name wouldn't you? [16:36:48] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [16:36:57] not so easy with wikitext I'd imagine [16:40:37] New review: Brian Wolff; "Re Reedy: I didn't actually know about the extensions existence when I wrote this, but not quite. Th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [16:41:50] Krenair: I think the idea is to have a schema change so that you would store both cl_to and cl_actual_to, and resolve redirects before plucking in db [16:42:08] oh right, of course [16:44:27] * bawolff goes off in search of food [16:44:49] talking about category redirects? [16:50:19] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [16:58:03] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [17:05:11] New patchset: Amire80; "Use single entry point mw.uls.init for all ULS ui initialization" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71989 [17:26:20] New review: MZMcBride; "(1 comment)" [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/66182 [17:37:13] New review: Anomie; "Since this has been merged now (in time for 1.22wmf10), we should also make sure that Iac866bc1 gets..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536 [17:37:16] New review: Anomie; "Now that I6bf650a3 has been merged in time for 1.22wmf10, we should probably get this merged as well..." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/71537 [17:53:09] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71989 [17:59:05] New patchset: Amire80; "jquery.i18n messagestore for ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71990 [18:00:02] New patchset: Alex Monk; "Fix case of first letter of group-centralnoticeadmin-member message" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/72000 [18:00:24] ^ easy one-character case consistency fix there [18:09:42] New patchset: Amire80; "jquery.i18n messagestore for ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71990 [18:10:41] New review: Hoo man; "Needs release notes and at least a wikitech-l post!!! Just kidding :)" [mediawiki/extensions/WikimediaMessages] (master) C: 2; - https://gerrit.wikimedia.org/r/72000 [18:10:48] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/72000 [18:23:46] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [18:23:46] New patchset: Rtdwivedi; "Separated the rendering and parsing part from ProofreadPage.body.php." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71965 [18:24:24] New patchset: Aaron Schulz; "jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71966 [18:29:17] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:32:12] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:36:24] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:38:32] New review: Brian Wolff; "Re parent" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:39:41] New patchset: Rjain; "Added the create class" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [18:40:36] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:44:31] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:44:50] New review: Brian Wolff; "PS3: Address some of Parent's comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [18:53:41] New review: Matmarex; "Retested, works as advertised." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/68859 [18:55:21] New review: Ladsgroup; "Hello, about other things, I'll do it. It's not a big deal but my big problem is showing this font i..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71658 [18:56:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [19:16:48] New patchset: Liangent; "Disable language conversion for echoed sortkeys in defaultsort errors." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72003 [19:19:14] liangent: i'll leave it for alex to recheck and merge this one :) [19:19:53] MatmaRex: ok [19:20:32] Krenair: ^^ [19:20:40] MatmaRex: interested in checking this? [19:20:41] https://gerrit.wikimedia.org/r/#/c/71996/3/client/includes/parserhooks/PropertyParserFunction.php [19:20:52] it's more mediawiki than wikibase [19:23:00] liangent: aw, i really have no idea how these things work [19:27:42] New patchset: Brian Wolff; "(bug 42246) allow hiding patrol entries from main Special:log" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42279 [19:30:20] New review: Brian Wolff; "PS3: rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/42279 [19:32:19] hey hoo, you promised me something yesterday. <3 [19:34:30] Looking at liangent's change above :P [19:34:56] hoo: which? [19:40:52] hoo: "You probably shouldn't access Parser::$ot directly, rather use the accessor Parser::OutputType" I didn't really find it [19:41:09] why isn't it named getOutputType which looks more normal [19:41:24] liangent: It's a mixed getter and setter... [19:41:50] hoo: there's another setter setOutputType which should be really used [19:41:59] setOutputType set those "aliases" too [19:42:03] ->ot[*] [19:42:15] liangent: Yes, but there's no other getter ... that sucks [19:47:41] MatmaRex: Did you test all these extension changes? [19:54:45] New review: Tpt; "Some points" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/71172 [19:59:51] New review: Alex Monk; "Removing myself from the reviewer list - I hardly know anything about the language converter, certai..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72003 [20:18:05] New review: Parent5446; "One more thing I noticed. Sorry I missed it earlier." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71997 [20:21:26] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72003 [20:25:23] New patchset: Liangent; "Disable language conversion for echoed sortkeys in defaultsort errors." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72003 [20:27:02] hoo|away: no, of course not :P [20:27:15] hoo|away: i'm pretty sure they won't even run on master MW [20:27:29] hoo|away: i updated one against core changes from like 2007 [20:27:54] hoo|away: so as long as thecode parses my changes are probably improvements, really. :P [20:29:47] * mooeypoo yawns and waves [20:29:51] happy fourth of july, everyone [20:30:03] Yippie, build fixed! [20:30:04] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #131: FIXED in 6 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/131/ [21:05:00] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [21:10:38] hey Krenair, you there? [21:10:43] hi [21:10:48] I am for now [21:10:48] re https://gerrit.wikimedia.org/r/72003 - is there anyone who does? :) [21:11:16] will be going on holiday for a week to NYC tomorrow. I won't be on IRC then [21:11:21] I have no idea [21:11:41] because i'm pretty sure nobody does [21:11:58] and thus we should just test it and merge if it works? [21:16:22] Is there anyone who does what? [21:16:36] oh language converter [21:16:38] what, test before merging? :P [21:16:59] ah, i read 'what' as 'that', disregard me [21:17:05] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [21:17:15] Language converter is annoying and everyone pretends it doesn't exist :P [21:17:37] but its fairly easy to test [21:17:47] (serbian is a good testing language) [21:18:27] yeah, i know [21:18:33] i filed a bug to make a pig latin variant for english [21:18:43] but it looks like i'll have to implement that myself [21:19:06] lol [21:19:17] That's a wonderful feature idea [21:19:36] (disabled by default, of course :P) [21:19:50] https://bugzilla.wikimedia.org/show_bug.cgi?id=43547 [21:19:55] I wonder if lang converter architecture would be compatible with gnu talk filters [21:22:59] New patchset: Brian Wolff; "Add Special:RandomInCategory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [21:24:34] New review: Brian Wolff; "PS4: per Parent." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71997 [21:26:31] bawolff: what? [21:26:43] New patchset: Parent5446; "Changed temporary password system to use tokens." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27472 [21:26:46] > [21:26:49] ? [21:26:59] liangent: what in regards to which comment? [21:27:15] bawolff: "gnu talk filters" [21:27:36] http://linux.die.net/man/1/talkfilters [21:28:59] bawolff: you want to create a variant with these filters? [21:29:21] is there a php version of them? [21:29:26] I think it would be mildly cool [21:29:54] I have no idea. Probably not. They probably are not complex though [21:30:15] * bawolff hasn't seriously looked into the idea, just thinks it would be funny [21:30:40] * bawolff wonders if enwikipedia would go for it on international talk like a pirate day... [21:31:16] bawolff: what's the package name of http://linux.die.net/man/1/talkfilters ? [21:31:23] .deb name [21:31:30] bah [21:31:34] pig latinis the best, guys [21:32:38] MatmaRex: well you can just go to create a normal english -> pig latin text filter [21:32:52] I don't think it'll be difficult to adapt it to mediawiki then [21:33:14] What is Pig Latin? [21:33:16] nvm found the wikipedia page [21:34:14] I'm not sure. I think filters. google is being uncooperative [21:34:28] liangent: i was hoping someone would do the dirty work for me [21:34:34] also, i'm testing that langconv commit now [21:34:39] let me just make my testwiki serbian [21:34:48] bah, i need to ssh. [21:36:21] MatmaRex: hmm btw you need to get a iso 639 for pig latin first [21:36:40] at least let mediawiki support pig latin [21:36:50] liangent: can't we use xx-en-piglatin or something like that? [21:36:57] iirc it's assumed in various places that variants are acceptable languages [21:36:58] * MatmaRex is not well-versed in the art if ISO codes [21:37:03] of* [21:37:10] private use subtag! [21:37:17] en-x-piglatin [21:37:24] is a valid code [21:37:38] yay [21:38:22] and we may need another language code for "normal" language [21:38:24] * bawolff also strongly thinks we should change simple wikis to use en-x-simple instead of 'simple' as the lang code [21:38:40] it's always done in existing languages with variants [21:38:50] I'm not sure whether it's forced to have [21:41:41] okay, the langconv thing works, let's get it merged [21:42:55] but i have no freaking idea why the message is still shown in polish when the wiki language is serbina and the UI language is english [21:42:59] really mediawiki, what. [21:43:08] ( http://users.v-lo.krakow.pl/~matmarex/testwiki/index.php?title=Duplicate-defaultsort-escape&variant=sr-el ) [21:44:31] New review: Matmarex; "Works as advertised." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/72003 [21:46:19] New patchset: Himeshi; "Added implementation of {{{section}}} tag to the form definition syntax." [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/72051 [21:47:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72003 [21:49:42] New review: Brian Wolff; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [21:50:54] MatmaRex: parser cache? Was your content lang originally set to polish? [21:51:04] although touching LocalSettings.php should kill parser cache [21:52:23] bawolff: i even edited the page [21:52:24] l10n cache, probably [21:52:30] or one of the other dozen of caches [21:53:21] I think it'd be odd for l10n cache. I thought that stored things based on language code, not a "this is content language" [21:54:14] MatmaRex: The content language on the wiki you linked to is set to pl [21:54:17] well, it's not a use-case, really [21:54:20] bawolff: yes, it is now [21:54:23] i switched it back [21:54:30] real wikis don't change languages anyway [21:54:35] :) [21:55:16] also, https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner is even awesomer now [21:55:29] and i have the second higest number of patchsets pending in core. [21:55:35] you guys should do something about that. [21:56:12] subtle hint :P [21:56:29] That report would be better if it discounted changesets with -1's [21:58:34] bawolff: https://github.com/mzmcbride/gerrit-reports/issues/ [21:58:59] New patchset: Liangent; "(bug 43547) New language variant en-x-piglatin DO NOT MERGE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72053 [21:59:07] MatmaRex: ^ [21:59:10] i think Elsie's database generator doesn't include this sort of info right now [21:59:15] no real filter done [21:59:39] I just wrote return '!PigLatin^' . strtoupper( $text ) . '^PigLatin!'; [21:59:51] bawolff: or maybe it does, hm. https://github.com/mzmcbride/gerrit-reports/blob/master/database/update-database.py#L70 [21:59:59] it would be rather easy to code up in thiscase [22:00:08] bawolff: see, an opportunity to get a github account for you! [22:00:13] liangent: yay [22:01:35] Something's not up with that page [22:01:46] E.g. my row [22:02:17] oh, right, nevermind. I understand it now. Core is included in mediawiki/* of course [22:02:30] I don't think -1 and +1 are stored for Gerrit reports. [22:02:41] rreports [22:02:53] Hi Ori. [22:03:00] New review: Hoo man; "(1 comment)" [mediawiki/extensions/CodeEditor] (master) C: 2; - https://gerrit.wikimedia.org/r/64371 [22:03:00] MatmaRex: note that patch will break enwiki if -{ }- syntax is used somewhere accidentially [22:03:07] I'll be parsed [22:03:08] Change merged: jenkins-bot; [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64371 [22:03:45] liangent: ugh. couldn't languageconverter use some saner escaping? [22:04:02] also, is this documented anywhere? [22:04:10] (the escaping syntax, that is) [22:04:18] what's saner escaping? [22:04:29] Elsie: I think you'd have to look at individual comments probably [22:04:30] Hi Elsie [22:04:31] New review: Hoo man; "Shouldn't harm :)" [mediawiki/extensions/DiscussionThreading] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64369 [22:04:31] Change merged: Hoo man; [mediawiki/extensions/DiscussionThreading] (master) - https://gerrit.wikimedia.org/r/64369 [22:04:45] bawolff: Probably. [22:04:50] I'm not sure they're exposed in the API. [22:04:56] And it'd probably be painful in any case. [22:04:58] liangent: something more akin to ? like ? [22:05:09] There's a magic word of some kind. [22:05:16] __NOTITLECONVERT__ or something. [22:05:55] MatmaRex: -{ }- is not only for noconvert, and it may be used more often than nowiki :p [22:06:50] i have never heard about it existing before looking at your other patch earlier today [22:07:31] brb [22:10:02] MatmaRex: Reviewed all the patches you added me to ... :) [22:12:05] * bawolff should perhaps start adding hoo as a reviewer to his patch [22:12:07] s [22:12:16] :P [22:12:41] Doing Wikibase CR almost all day know... in fact I almost only did CR today :P [22:14:18] Any interest in reviewing my evil huge patch making Special:Listfiles show old versions of files [22:15:20] actually the one I'd really like to see reviewed is adding filemetadata parser function - https://gerrit.wikimedia.org/r/#/c/67047/ [22:16:24] bawolff: You can add me to it... I can't promise anything but maybe I get around to have a look some time [22:16:54] added [22:17:42] * bawolff looks sadly at his patches that have been there since April :s [22:18:07] New patchset: Liangent; "(bug 43547) New language variant en-x-piglatin DO NOT MERGE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72053 [22:19:47] bawolff: well I have patches since 2012 [22:19:47] bawolff: why not add that to scribunto instead? [22:19:56] ori-l: I did [22:20:01] In a dependent patch set [22:20:08] I thought it would be useful to have both [22:20:23] good answer [22:20:44] My (somewhat imaginary) usecase is someone could put on an image description page {{#filemetadata:ImageDescription}} in the description page instead of typing it out [22:21:13] The only main difference is the parser function can also do some funky formatting quirks, where the lua version just returns the data [22:21:13] bawolff: I think the syntax is a bit awkward. [22:21:21] And I'm worried about the parser function being expensive. [22:21:25] bawolff: nice, I see it: https://gerrit.wikimedia.org/r/#/c/67588/ [22:21:26] But I haven't a change to look closely at the code. [22:21:34] Elsie: we can run the fundraiser a few extra days [22:21:36] I'm also vaguely worried about escaping of property names. [22:21:44] ori-l: ;-) [22:21:50] Elsie: Any suggestions for better syntax? [22:21:50] There's code to limit expensive parser functions. [22:22:11] {{#foo:bar}} is usually in a form where "bar" is the page title. [22:22:24] defaultsort:, pagename:, fileinfo:, I think? [22:22:43] hoo: yay, thanks [22:22:52] Being expensive is not something we can really get around. But it counts only as one expensive parser func per each image you query [22:22:56] And I think |R is last. [22:23:03] bawolff: Right, but does it mark itself as expensive? [22:23:08] bawolff: I'll review. I don't know parser functions well enough to +2, probably, but maybe I'll catch some bug. [22:23:10] Elsie: it does [22:23:11] bawolff: yeah, that's on my todo as well [22:23:14] Okay, cool. [22:23:23] bawolff: where 'todo' is 'those 40 e-mails marked as unread' [22:23:38] MatmaRex: yeah, I have a bunch of those too [22:23:40] I wish I had only 40 unread e-mails. :-( [22:24:05] Elsie: The reason I went with that syntax, is so it could default to the current page name without being awkward [22:24:42] Being a Python person, I prefer the explicit to the implicit. ;-) [22:25:07] The thing with that patch that I think is most likely to be touchy, is that in formatted mode it formats the exif values according to user language instead of content language [22:26:02] Shhhhhhh. [22:26:06] Let people find those bugs on their own. [22:26:08] ok :) [22:26:09] New patchset: Liangent; "(bug 43547) New language variant en-x-piglatin DO NOT MERGE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72053 [22:26:10] No spoilers. [22:26:22] I wrote a justification of why I did it that way on the bug [22:29:58] New patchset: Matmarex; "Adjust doEditLink() after changes in core" [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [22:30:17] New review: Matmarex; "Whoops. Too much copy&paste, thanks for spotting." [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [22:30:22] hoo: ^ [22:30:46] * hoo looks [22:31:22] New review: Hoo man; "Looks good now :)" [mediawiki/extensions/Wikilog] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64368 [22:31:22] Change merged: Hoo man; [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [22:32:58] New patchset: Liangent; "(bug 43547) New language variant en-x-piglatin DO NOT MERGE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/72053 [22:35:53] MatmaRex: I stole a 3rd party, very badly written pig latin function [22:35:57] and there's now http://imagebin.org/263441 [22:37:01] liangent: uhhhhh wow, that's nasty [22:37:11] doesn't php have a unicode-aware uppercase function? [22:37:19] doesn't mediawiki, actually? [22:37:56] yes [22:38:01] $wgLang->uc [22:38:34] bawolff: I don't want to clutter your change-set with inane comments; can I ask some questions here? [22:38:48] Sure [22:39:35] MatmaRex: and parser functions start to fail https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-parser/9135/console [22:39:47] didn't check their reasons [22:39:56] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [22:40:12] * YuviPanda wishes more people would use SuchABot [22:40:41] Well, the first isn't a question so much as a comment: 'getIndependentMetaArray' is really confusing. What about one of: getCommonMetaArray? I thought of 'getHandlerIndependentMetaArray', too, but what is confusing about that is that it does depend on the handler implementing support [22:40:58] err, s/one of//. [22:41:15] Honestly, I had a lot of trouble coming up with a good name for that [22:41:33] I originally had getStandardMetaArray [22:41:42] New review: Yuvipanda; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [22:41:50] getCommonMetaArray sounds fine to me [22:42:08] liangent: oh man, why is our test suite so awful [22:43:27] New review: Yuvipanda; "@bawollf: Now this registers namespaces by default. Not i18n'd, though. Will look at that later. And..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [22:43:45] marktraceur: warning about changed namespace ids in the gerrit comment for the patch. [22:43:53] (also you can use gerrit for commenting now, no ened to use github) [23:07:53] New review: Matmarex; "Probably needs adding 'en' to LanguageConverter::$languagesWithVariants." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/72053 [23:34:42] New patchset: MF-Warburg; "Fix so that, when searching, the message telling users to set a test wiki preferences so a creation suggestion can be made is actually shown, instead of a "None/Pagename" suggestion" [mediawiki/extensions/WikimediaIncubator] (master) - https://gerrit.wikimedia.org/r/71304 [23:48:50] New review: Brian Wolff; "Sorry I took so long to look at this. And thank you for taking the initiative to try and fix such a ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65176 [23:49:46] New patchset: MF-Warburg; "Fix so that, when searching, the message telling users to set a test wiki preferences so a creation suggestion can be made is actually shown, instead of a "None/Pagename" suggestion" [mediawiki/extensions/WikimediaIncubator] (master) - https://gerrit.wikimedia.org/r/71304 [23:51:54] New review: Matmarex; "> *Special:MovePage creates redirects that look like #REDIRECT[[Category:Foo]]. It really should be ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65176 [23:53:13] New review: Matmarex; "For the record, the test thing is now filed as bug 50611." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [23:54:44] New patchset: MF-Warburg; "Fix so that, when searching, the message telling users to set a test wiki preferences so a creation suggestion can be made is actually shown, instead of a "None/Pagename" suggestion" [mediawiki/extensions/WikimediaIncubator] (master) - https://gerrit.wikimedia.org/r/71304 [23:57:38] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaIncubator] (master) - https://gerrit.wikimedia.org/r/71304