[00:00:25] The RefreshLinks job does Linksupdate which does all the link tables and page properties. it is the same class and function that the refreshLinks.php maintenance script calls. Apparrently one does something the other doesn't and I dont' see it. [00:00:44] I know why but I don't see how. [00:01:38] Krinkle, someone has asked me to add a new parameter to jsMessage so VisualEditor's post edit notice can be hidden by ID/class... I told them it's deprecated and mw.notify should be used instead. [00:01:38] Could the VE team change VE to use mw.notify with a tag option so that it has a class? [00:02:06] Krenair: We've already written that code; it's waiting on a core change for us to merge. [00:02:31] Krenair: ... which I would link to if gerrit wasn't down. :-( [00:02:41] Yeah I was about to ask :) [00:02:47] James_F: It's up again [00:02:53] and even seems to work in Firefox \o/ [00:03:15] Seems to be hanging for me [00:03:30] <^d> Caches are cold, give it a minute. [00:03:32] maybe it's overloaded after the reboot [00:03:34] yeah [00:03:36] good night [00:03:42] works now :) [00:04:28] Krenair: https://gerrit.wikimedia.org/r/69856 but again gerrit seems down. [00:04:52] <^d> Should be back now? [00:06:07] ^d: Yeah; thanks. :-) [00:06:37] ok, thanks James_F [00:09:50] James_F: Krenair: One instance of jsMessage has already been updated to mw.notify (as can be seen on https://gerrit.wikimedia.org/r/#/c/69856/1/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js ) the other can be updated as well without the postedit change having to go first. [00:10:15] also, that change nor the one in core gives it a dedicated tag, which is needed for it to have a togglable class [00:12:52] It will have .postedit though, which seems to fit what the user wants (already has .postedit { display: none; }, wants VE postedit notifications to go away as well) [00:16:00] k [00:16:12] New patchset: Ryan Lane; "Add api action for getting console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [00:16:50] \o/ [00:17:00] I think I'm actually getting the hang of promise/deferred [00:17:16] and I found a reasonable doc on it :) [00:20:24] Yeah promise/deferred is nice :) [00:21:23] Ryan_Lane: I also did an attempt to explain it during the FrontendMasterClass this january at wmf office. [00:21:43] I'll need to make sure to attend JS classes in the future [00:21:54] We recorded this one [00:21:55] at the time I didn't think I'd be using JS [00:21:57] * Krinkle finds link [00:21:57] ah [00:21:58] cool [00:22:16] http://www.youtube.com/watch?v=2K5PtLTkwhs#t=51m36s [00:22:22] bleh. looks like I rebased this changeset again [00:22:53] New review: EBernhardson; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71740 [00:23:08] in case anyone wants to code review this (https://gerrit.wikimedia.org/r/#/c/60783/20) needs to be checked [00:23:47] and it's a fairly minor change, just following up on a few comments [00:33:11] New patchset: Bsitu; "Mime emails should be sent with UTF-8 charset" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71747 [00:34:17] New patchset: Cmcmahon; "WIP add ve_refs check" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [00:48:08] New review: Krinkle; "It looks like it is currently doing this:" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/69298 [01:12:05] New patchset: Katie Horn; "Starting the Great Form Purge of O-13 Phase 1: Basic cruft removal" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71750 [01:14:18] New patchset: Hiong3-eng5; "moved most SpecialPage from app to setup" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71576 [01:18:45] it sounds more like you want to isolate some particular bug, rather than that you want to know how LinksUpdate works [01:19:40] maintenance/refreshLinks.php is never run on WMF, and we have working categories [01:20:03] so obviously it's not quite as you describe [01:20:40] What did I miss? [01:22:26] New patchset: Mwalker; "Always Display Emergency Priority Banners" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/71751 [01:22:42] the behaviour you describe in comment 16 sounds completely normal [01:24:10] 10 minutes is not a long enough wait to ensure that everything in the job queue was executed, and you didn't confirm that the job in question was in fact executed [01:26:43] New review: Mwalker; "yay! I'm a bit worried that there might be a hidden CSS dependency -- but this will root it out if t..." [mediawiki/extensions/DonationInterface] (master) C: 2; - https://gerrit.wikimedia.org/r/71750 [01:28:21] 2013-07-02 05:57:55 mw1015 enwiki: refreshLinks Template:Redirect masterPos=db1056-bin.000205/872529929 rootJobSignature=5910fa49190166d8f186f2301298b82e6c001fd8 rootJobTimestamp=20130620135710 t=3800 good [01:29:00] the edit was at 00:33, so it took 5.5 hours [01:29:21] Thanks [01:30:16] as for action=purge doing links updates [01:30:22] there are two ways to purge the page [01:30:26] TimStarling: Can you confirm it wasn't a job caused by a (null) edit to the page directly? [01:30:36] they only differ in whether or not they do links updates [01:30:42] Sure, I understnad. [01:30:46] action=purge doesn't, null edit does [01:30:51] If it just takes a few hours then we don't have a problem. [01:31:05] other than our job queue being a bit slow, but that's not my problem directly. [01:31:23] if the page was null edited, the update would have been done immediately, rather than queued [01:33:14] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/71740 [01:35:12] I think the rootJobTimestamp indicates that the job was in response to an edit on June 20 [01:48:37] New review: Mattflaschen; "Not tested, but I understand the issue from using the old version. It will be nice to easily distin..." [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/71659 [01:51:30] TimStarling: an edit to a template then, yes [01:52:32] TimStarling: So you're saying the page properties that templatedata adds when is used on a page will end up on Template:Foo when added to Template:Foo/doc, it just didnt' happen yet? [01:52:48] New review: Mattflaschen; "There are definitely parts of the MathJax that are confusing, indirect, and don't meet MW standards...." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [01:52:59] yes [01:53:36] have we got a job queue length graph somewhere? [01:54:08] I guess the "jobs" property siteinfo gives in the API is not accurate then :P [01:54:28] http://ganglia.wikimedia.org/latest/?c=Miscellaneous%20pmtpa&h=hume.wikimedia.org&m=cpu_report&r=hour&s=descending&hc=4&mc=2#metric_Global_JobQueue_length [01:54:48] Krinkle: that doesn't check redis [01:55:03] self::$jobs = $dbr->estimateRowCount( 'job' ); [01:55:11] ha [01:55:15] I noticed that weeks ago [01:55:27] it relies on the implemention being sql backed [01:55:33] that explains [01:55:55] I wanted to make some performance tweaks for batch queue size detection first...too many things on the TODO list [01:56:09] * Aaron|home has been doing nothing but oauth the last few days [01:56:11] TimStarling: Could you reply on https://bugzilla.wikimedia.org/show_bug.cgi?id=50372 with what you told me? (That it should be working as far as you know, the job queue just took a few hours). [01:56:50] well, a couple of weeks actually [01:59:26] Krinkle: 20 June -> 2 July != "a few hours". [02:00:09] I was citing TimStarling from "5.5 hours". [02:00:43] Aha. [02:00:44] yeah, it happened to execute 5.5 hours after your edit, but it was responding to an edit made 2 weeks previously, not to your edit [02:00:46] Do we have a confirmed sighting that took even longer? Which one was edited on june 20 and only visible until today? [02:00:52] Aha [02:01:06] Which is not good. [02:01:25] : I think the rootJobTimestamp indicates that the job was in response to an edit on June 20 [02:01:27] Missed that one [02:03:16] Do we have statistics on what kind of jobs the job are in the queue (e.g. which type has the most ones) and/or which are taking the most processing time? [02:03:52] refreshLinks takes the most time [02:03:54] It taking several weeks sounds pretty bad. Any possible solutions ops is looking at? [02:04:00] or do you mean what sort of refreshLinks? [02:04:15] I'm not sure, I just looked into that logic for the first time today :) [02:04:48] (I know how it worked roughly, but not how it was called from the ParserOutput) [02:06:38] Krinkle: So apparently for Parsoid Aaron built them their own queue. [02:06:58] $wgJobTypesExcludedFromDefaultQueue[] = 'ParsoidCacheUpdateJob'; [02:07:05] yeah, I spotted that earlier. Fancy :) [02:12:53] queue lengths: http://paste.tstarling.com/p/AMtkHB.html [02:16:00] New review: Ori.livneh; "This works, with the caveat that the PHP call to add the schema module to the page output precedes t..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/68862 [02:16:51] better method, same results: http://paste.tstarling.com/p/idhZKj.html [12:48:13] <^demon|away> Opera has never worked well with Gerrit. [12:48:17] yeah, but it worked better than right now. [12:48:37] <^demon|away> qchris: We should update repo-discuss with what we know too, I fear we need someone who Knows More Than Us to really solve it...I'm fearing some GWT bug. [12:49:11] ^demon|away: Yes, I fully agree. [12:49:21] ^demon|away: However, let us try the new build first. Maybe there are some users who still experience the problem nonetheless :-/ [12:49:32] <^demon|away> Yes, new build is the right first step. [12:49:46] <^demon|away> And if it fixes it for people, it's an acceptable workaround for now pending upstream actually caring. [12:57:46] yurik: you there? [12:58:17] yurik: am i understanding https://gerrit.wikimedia.org/r/#/c/71759/ right? you want people to use URLs like api.php/action=query&prop=whatever? with a slash? [12:58:28] isn't that a really bad idea? [13:18:16] Change merged: jenkins-bot; [mediawiki/extensions/DumpHTML] (master) - https://gerrit.wikimedia.org/r/60194 [13:23:46] New patchset: Hashar; "pupptest-test-runner a wrapper to run puppet tests" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71789 [13:24:37] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71789 [13:33:16] New patchset: Hashar; "puppet-test-runner was missing an exit call" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71791 [13:33:44] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71791 [13:34:21] New patchset: Hashar; "operations-puppet-test" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71792 [13:34:50] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71792 [13:41:11] New patchset: Matmarex; "Use background-image: none instead of background: none" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/71795 [13:47:43] New patchset: Aude; "Update Wikibase with code for propagateChangesToRepo setting" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71797 [13:48:42] New patchset: Hashar; "tweaks for puppet-test-runner" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71798 [13:49:02] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71798 [13:56:51] New review: Anomie; "You've got two separate changes munged together here: the change to specify the action via pathinfo,..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71759 [14:00:39] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71797 [14:02:04] New patchset: Hashar; "puppet-test-runner report success" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71799 [14:02:28] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/71799 [14:02:43] New patchset: Anomie; "Add getPersonalToolsList to SkinTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71800 [14:03:11] New patchset: Anomie; "Add getPersonalToolsList to SkinTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71800 [14:28:22] New patchset: KartikMistry; "Possible license issue with Utkal font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71803 [14:32:06] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [14:32:41] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [14:35:06] New patchset: Hashar; "set ansicolor colormap to vga" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71805 [14:35:24] New review: Hashar; "pending upstream change" [integration/jenkins-job-builder-config] (master) C: -2; - https://gerrit.wikimedia.org/r/71805 [14:48:50] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [15:00:01] New review: Anomie; "Code looks fine, and the tests seem to run correctly through PHPUnit locally. Did make a few style o..." [mediawiki/extensions/AbuseFilter] (master) C: 1; - https://gerrit.wikimedia.org/r/71571 [15:08:09] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [15:20:39] New review: Alex Monk; "needs rebase" [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/65269 [15:29:29] New patchset: J; "Optional SVG mode with PNG fallback" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [15:33:13] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71705 [15:33:53] hoo: you alive? [15:34:16] MatmaRex: Sure :D [15:35:43] hoo: i added you to three changes fixing obscure extensions aften the change you merged yesterday :P [15:35:47] after* [15:36:11] ok, I guess I can have a look later today [15:36:22] going to unbreak wikibase firsth, though :P [15:36:54] heh [15:37:00] good luck [15:42:23] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [15:43:20] New patchset: Cmcmahon; "WIP add ve_refs check" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [15:49:18] MatmaRex, pong [15:49:39] i want people to use api.php/query?prop=whatever [15:49:48] without the "action" [15:51:20] hm. [15:51:29] that's still going to be annoying to use [15:51:40] MatmaRex, why so? [15:51:55] New patchset: Anomie; "Fix mw.ustring edge cases" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/71816 [15:52:07] because i can't use standard URL libraries to construct the entire request URL from a dictionary/hash/object/associative-array [15:52:16] i'd have to handle theaction myself [15:52:18] there is a very good reason for this -- it forces action to always be part of the URL, not POST request, and allows varnish to direct traffic based on action to different clusters [15:52:55] hmmmm, well that's at least be a justification [15:53:20] it'd still be annoying, of course, but that makes sense :) [15:53:29] MatmaRex, the fact that you would have to write one line to extract "action" from the param array and append it to the URL is not that influential :) [15:54:01] parsoid ppl have asked for this [15:54:14] yurik: hey, this is a rather critical detail you didn't mention anywhere :) [15:54:32] sure i did - it has been discussed for a while, including the RFC [15:54:43] s/anywhere/in the commit message/ [15:54:58] i will probably make it a separate commit [15:55:18] anomie is not happy that it is bunched together with the module versioning [15:55:39] so i will make one patch with versioning, and onether that uses that versioning when it sees /action [15:56:14] anomie is hard to please, but he usually makes sense :-P [15:57:54] ;) [15:59:46] * brion starts spouting crazy api ideas just to confuse yurik … :D [16:00:04] allow client to POST multiple JSON objects with request parameters to bundle multiple requests together! [16:00:06] * brion hides [16:00:29] nope, ain't happening :) lots of discussion on that one, there is really no need [16:01:33] its already batched up together as much as we can, and if the multiple requests need to do stuff in sequence, there has to be handling of "step #4 failed, stopping", whereas if its not sequential, do them in parrallel, more efficient [16:01:33] hehehe [16:01:44] http pipelining oughta work anyway [16:01:52] mooeypoo: hi there [16:02:01] plus we won't be able to send stuff to different subclusters based on action [16:02:18] well [16:02:31] we could fan the requests out to multiple backend servers [16:02:36] but let's not get ahead of ourselves :D [16:03:11] New patchset: Anomie; "Make lang:parseFormatterNumber more like tonumber" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/71820 [16:04:03] man i've got a lot of old email to clear out [16:04:08] * brion wanders off to gmail and hits 'archive' a lot [16:05:10] brion, use "e" to archive - by far the most useful button in gmail :) [16:05:23] yurik: yes, keyboard is lovely :D [16:05:30] though i've gotten used to swiping in the android app [16:05:35] * brion misses touchscreen on his laptop [16:06:03] guys, get a real mail client. :P [16:06:30] pine is the one true email client [16:06:32] New patchset: Anomie; "Make lang:parseFormattedNumber more like tonumber" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/71820 [16:06:48] New patchset: J; "(bug 50617) fix iframe output" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/71821 [16:07:00] sumanah: heyhey [16:07:22] sorry, was busy trying to translate stuff [16:07:34] mooeypoo: no prob! just wanted to wave and ask how your GSoC summer is going. [16:07:59] oh hey, Alpine got a new release this year. https://groups.google.com/forum/#!msg/comp.mail.pine/4w_f1ro6GRA/faiu1Egw_ywJ [16:09:33] great so far! :) very hectic, VE is going through metamorophosis we have to keep up with, but it's awesome seeing things come together [16:10:34] mooeypoo: you're working on the RTL support? [16:11:02] sumanah: the weird thing now is that I realize how much I don't know my technical *hebrew*.. ain't that an irony [16:11:07] brion: aye aye [16:11:11] awesome [16:11:13] or rather, eya eya [16:11:17] mooeypoo: hahaha [16:11:28] ahahah [16:11:41] Dan Kaminsky says "I love being wrong - it means the world is more interesting than I thought it was" [16:11:42] the word "feature" got me completely stumped yesterday on how to say it in Hebrew [16:11:57] I love the many things you are learning :D [16:12:11] New review: CSteipp; "It looks like the logic was correctly duplicated, and the new function looks sane. Working on my tes..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/71800 [16:12:12] True, I just wish I was wrong *less* in this case, it's still my main language [16:12:20] with luck, VE will be a friendlier environment than markup for bidi text. i've tried, and though it doesn't help not speaking the language, ….. that markup gets scary with mixed latin and hebrew :D [16:12:23] I'm like in language limbo! :D [16:13:02] brion: as a noobie, I have to say, I have NO IDEA how people managed to do mixed hebrew with wiki markup (or even html markup) up until now [16:13:26] I'm translating, and that uses markup -- and that's soooo confusing when it comes to using even things like {{ }} or [] inside hebrew text. [16:13:31] "with great difficulty" [16:14:52] hehe yeah [16:17:00] and I never really noticed how convenient it is that English doesn't have gender in its verbs, by the way. [16:17:09] That's another interesting conclusion from translating. [16:17:32] hmmm [16:17:40] does gerrit allow wildcard searches? [16:17:45] like "status:open project:mediawiki/extensions/*" [16:17:49] (this doesn't work) [16:18:10] "You can click the button to do whatever" is good in English. But in hebrew, you'd have to either use the male-voice (offending women) or the women-voice (alienating men) or rewrite that as a formal "This action can be done by clicking.." [16:18:48] mooeypoo: Wow, I never knew that.. [16:18:58] GorillaWarfare: me neither, and I *speak* the language. [16:19:03] Well, I knew it, I just never really noticed. [16:20:59] mooeypoo: that's why our translation system supports gender… it's complicated :) [16:23:33] brion: true, but then it's exhausting [16:24:05] I'm already getting vertigo from shifting ltr/rtl, if I have to think in two genders, I may well go crazy. [16:24:21] hehe [16:24:28] it's enough to make one give up text and go to all icons [16:24:33] then *nobody* understands what the software does [16:24:38] also, in hebrew I think it makes a bit more sense to go the "formal" tone in user guides, etc. [16:24:43] brion: IKEA. [16:24:47] lol [16:24:49] \o/ [16:25:19] localisation - it is hard [16:25:21] brion, mooeypoo: I think we should just use illustrations, like in airplane emergency exit guides [16:26:10] GorillaWarfare: I fly far too much and am getting to be a connoisseur of those guides [16:26:26] like, there are ones that do not make it super clear whether the overwing exits also provide rafts in the case of a water landing. Bad! [16:27:03] Qantas's was great - it explained *why they want you to do certain things* [16:27:06] with DATA [16:27:28] * sumanah is turning into Roan [16:28:14] MatmaRex: did you already look at the search docs? [16:28:14] GorillaWarfare: "Put your head between your legs / open door and jump onto the big floating yellow boat" works better in icons than "When you click the "References" button, you have the option of adding either a linked reference or a paragraph you can also format to your liking". [16:28:23] MatmaRex: https://gerrit.wikimedia.org/r/Documentation/user-search.html [16:28:26] ... but we *MIGHT* be able to do that with comic strips [16:28:32] ... now that's an idea right there [16:28:51] MatmaRex: I've been able to do, for instance, https://gerrit.wikimedia.org/r/#q,status:open+project:%255Emediawiki.*,n,z "status:open project:^mediawiki.*" [16:29:17] Hey we have a precedent with the upload licensing tutorial [16:29:35] there's an upload licensing tutorial? [16:29:46] mooeypoo: UploadWizard - the cartoon [16:29:56] There's a cartoon!? yay! where? [16:30:11] augh and I thought I was all revolutionary. [16:30:11] https://commons.wikimedia.org/wiki/File:Licensing_tutorial_en.svg [16:30:15] sumanah: yeah,ive found it in the meantime [16:30:19] thanks [16:30:40] mooeypoo: Honestly, I think an illustration of "put your head between your legs" might be helpful for most of our instructional pages [16:30:46] ah! I think I saw that before. [16:30:48] mooeypoo: if you can't be revolutionary, then comfort yourself with the phrase " best practice " [16:30:52] haha GorillaWarfare ++ [16:31:20] דוצשמשי: עםםג שגהןבק [16:31:23] err [16:31:26] sumanah: good advice [16:31:45] GorillaWarfare: mooeypoo - https://meta.wikimedia.org/wiki/Participation:Ocaasi,_Valeriej,_The_wub/Open_Help_Conference/Report a few Wikimedians went to a conference recently to learn about how to do help pages/instructions better in MediaWiki & Wikipedia [16:32:23] interesting [16:32:23] Oh yeah, I remember the wub was working on help pages [16:32:25] * GorillaWarfare looks [16:33:29] Ooh, I'm going to link [16:33:35] Oops [16:33:36] Was the answer - take everything we're currently doing, and do the opposite :P [16:33:44] *Ooh, I'm going to link https://en.wikipedia.org/wiki/Wikipedia:Help_Project/guidelines to some of the helpers in the IRC chan [16:34:17] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [16:34:42] the key thing with help pages is not to let wikipedians keep making them longer and longer [16:34:53] it's a huge temptation to just add one more admonition [16:34:57] it is [16:35:05] constraints are good [16:35:08] bawolff: well, I take everything you guys are LTR'ing and I'm RTL'ing it. So I guess that's pretty much exactly what I'm doing. [16:35:15] hahaha [16:35:32] mooeypoo: you're from the mirror universe! do you have a goatee like Mirror Spock? [16:35:43] :) [16:35:55] rofl [16:36:40] New patchset: Aude; "Update Wikibase, removing propagate moves patch in this branch" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71827 [16:37:19] Shh... you weren't supposed to tell [16:37:54] New review: Yaron Koren; "Looks good! All the code is well-formatted. I don't know if "cache seconds" is an ideal name for tha..." [mediawiki/extensions/ExternalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/71722 [16:37:54] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71722 [16:37:57] ^d: Reedy around? [16:38:04] https://commons.wikimedia.org/wiki/File:Identification_Department,_Calgary_-_Criminal_Identification_Book_-_2_%28HS85-10-38280-2%29.jpg confirms what firefly has taught us. All the bad guys wear hats [16:38:09] * aude needs https://gerrit.wikimedia.org/r/#/c/71827/ deployed (sorry to bother) [16:38:54] Yeah [16:39:41] should be all we need until monday [16:39:43] aude: http://www.openitp.org/openitp/circumvention-tech-summit.html it's in Berlin - think you would like to go? [16:39:56] sumanah: i think so :) [16:40:14] it's on a weekend, so would work [16:40:27] you should totally go [16:40:33] and you should encourage other Berlin folks [16:40:43] sure :) [16:41:20] New patchset: Kipcool; "Specialdatasearch" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71829 [16:42:33] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71829 [16:45:22] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71827 [16:51:12] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71659 [16:56:25] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [17:00:38] New patchset: AzaToth; "Add debian-glue macros" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71245 [17:01:58] New patchset: Eranroz; "Support ApiPageSet in ApiWatch" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53964 [17:01:59] * marktraceur loves getting pinged by all these people saying UploadWizard. [17:12:49] New review: Rjain; "I think we can merge this if its OK since there are other commits depending on this and are facing m..." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [17:13:26] New patchset: Yurik; "Update zero ext" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71831 [17:14:06] New patchset: Yurik; "Update zero ext" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71832 [17:16:45] New patchset: MarkTraceur; "Make DI tests nonvoting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71833 [17:17:12] Change merged: MarkTraceur; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71833 [17:18:38] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71831 [17:18:40] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71832 [17:21:32] New patchset: Mwalker; "Starting the Great Form Purge of O-13 Phase 1: Basic cruft removal!" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71750 [17:24:23] Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71750 [17:32:51] Special:RecordImpression ? what's that ? [17:33:39] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [17:33:48] New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724 [17:35:06] New patchset: Matmarex; "Fixed $wgCookieExpiration functionality when set to 0." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61593 [17:36:17] New review: Matmarex; "Simple enough. I'm fixing the docs at https://www.mediawiki.org/wiki/Manual:$wgCookieExpiration too." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61593 [17:36:41] * SickPanda looks for a marktraceur [17:37:17] * marktraceur hides [17:37:32] wow, we have a LOT of JS requests on an average page... [17:37:34] SickPanda: hey -- re that giant UW ContentHandler patch -- i skimmed through it last night and it LGTM'd to me. are you depending on me for thorough review, or are you covered? [17:37:50] ori-l: i'm looking at marktraceur for review, since it is UW. [17:37:52] SickPanda: I'm working on a patch for mwalker first, then reviewing Rasel160's latest, then you'll get my attention [17:37:57] thedj: don't you say. [17:37:58] marktraceur: yessir [17:38:10] SickPanda: cool, thanks [17:38:14] thedj: WMF should seriously consider removing some extensions, really, eh. [17:38:28] ori-l: I'll poke you when I start moving JsonContent and friends into core. [17:38:43] ori-l: and when I start writing the JSON schema for this one. [17:38:52] ori-l: want to get this merged first, since it is already huge. [17:39:02] hi rachel99 [17:39:04] SickPanda: Just for the record, there's a maintenance script in your patch that will convert things. Right? [17:39:09] SickPanda: yep, i saw your comment, makes sense to em [17:39:10] me [17:39:24] marktraceur: not yet. will be. Don't want to make this patch even bigger. [17:39:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61593 [17:39:42] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [17:39:50] marktraceur: it's trivially convertible, and I'll add it if you want me to. This patch is already well over 2000LOC changes tho, so... [17:40:11] MatmaRex: well a lot would be solved with actually profiling stuff once in a while. [17:40:12] ^D: hello [17:40:18] instead we only seem to add. [17:40:21] ^d: http://pastebin.com/z9MJLRz6 gerrit [17:40:27] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [17:40:36] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [17:40:36] ^d Hello [17:40:36] I'm getting that when it hangs with "working...", not sure if they are related [17:40:44] * thedj wonders if ReferenceTooltips is resourceloader compatible [17:40:48] New patchset: Kipcool; "SpecialDatasearch" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71838 [17:40:57] ^d : getting an error logging into Gerrit [17:41:07] marktraceur: I've marked TODOs in the comments. Essentially, Maintainance scripts, i18n fixing, and schema verification. will add after i get this merged [17:41:18] thedj: it is, or it almost is [17:41:19] ^d : cannot assign user name [17:41:28] thedj: the version we use at pl.wp is loaded via RL [17:41:34] SickPanda: In that case, the old system is still in place and will work for the time being? [17:42:03] ^d : Can you help with me out? [17:42:09] Like, after I merge this patch, I will still have campaigns in the DB and UW will use the DB to access them, not get them from Campaign:Whatever? [17:42:37] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71838 [17:42:50] MatmaRex: i'll switch the en.wp version to that as well then, if i can't find a previous revert [17:43:53] thedj: ours might be a modified, though [17:44:08] because when it comes to MW gadgets, nobody ever looks upstream [17:44:52] bawolff, I'm late to the party, but I think the "height constrained no overlay" version of your new gallery is excellent. [17:45:18] ragesoss: thanks [17:45:27] New review: Matmarex; "Wouldn't it be simpler to include the version information in the cache key?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54207 [17:45:45] hey, it's a bawolff [17:45:50] MatmaRex: hmm, i can't even get the thing to work on test.wp [17:46:05] bawolff: wanna look at ^^? it'd be good if someone who actually knows what they're doing reviewed it :) [17:46:05] MatmaRex: I've been here for several hours :P [17:46:23] That's never a good way to introduce please review my patch [17:46:29] Now I think its going to be scary ;) [17:46:36] the patch isn't even mine :D [17:46:40] and it's +5, -1 [17:47:09] thedj: let's do it live! [17:47:17] ragesoss: So far I've gotten that hover is controversial, and one of the two non-hover modes would be best [17:48:03] yeah, I think many times the captions are an essential part of galleries. [17:48:17] users need to be able to see all that info at once, in some cases. [17:48:39] I think it depends on context. In some places it probably doesn't super matter (galleries on category pages where the caption says the file size) [17:48:40] and I much prefer the one that doesn't cover up images with caption. [17:49:08] yes, in some cases, the focus really is on just being a gallery of pretty images related to the page. [17:49:31] Personally I find the current gallery doesn't really show off the beauty of the images [17:49:39] New review: Anomie; "PS11: Remove 'viewprivateinfo' requirement for seeing real name, remove permission requirement for v..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [17:49:45] particularly on things like galleries of featured pictures [17:49:45] no, the current gallery is awful. [17:50:09] the backgrounds, and the wasted space both within and outside of the backgrounds... really, just terrible. [17:50:18] And commons has some very beautiful pictures [17:50:57] yeah. the hover-captions version would actually make plenty of sense on Commons. [17:51:53] biggest issue with hover captions is that doesn't work well with touch screens [17:52:14] I have it falling back to being always on in that case, but still weird to have two different behaviours [17:55:18] New patchset: Yurik; "Update zero ext" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71841 [17:55:42] New review: Alex Monk; "needs rebase" [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/65557 [17:55:58] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71841 [17:56:40] MatmaRex: i see no changes between the .pl and the .en version, so if you never heard a complaint on pl, i'm just gonna switch it to RL [17:56:41] New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724 [17:56:43] bawolff: re: touch screens. Isn't most of these stuff not loaded when viewed with MobileFrontend anyway? [17:57:06] That assumes people look at it with mobile frontend [17:57:12] And good question, I don't even know [17:57:17] * bawolff checks [17:57:23] where did my phone go [17:57:45] bawolff: IIRC it is, unless you specifically target mobile with RL [17:58:01] bawolff: also, commons by default doesn't redirect to mobilefrontend, so it does get the desktop site, warts'n'all [17:58:03] Well its largely css [17:58:13] thedj: yeah, it's always worked, and the only change seems to be translation and making it run in all namespaces [17:58:33] wait, yeah guess I can't test my testwiki as it doesn't have mobile frontend installed [17:58:42] New patchset: Yurik; "Update zero ext" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71842 [18:00:14] Interesting. On current code, on mobile galleries have rounded corners [18:00:44] bawolff: all RL modules are not loaded on MF unless they are specifically targetted to mobile, though. [18:00:52] also, use vagrant! :D [18:03:32] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71842 [18:06:02] New review: Yuvipanda; "Create a page in the Campaign: namespace with the following content(https://dpaste.de/BwMkK/) to tes..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [18:07:16] marktraceur: i'm going to try and sleep this sickness off. see you tomorrow! :) [18:07:18]