[00:02:19] <RoanKattouw>	 superm401: Are you done lightning-deploying?
[00:02:24] <RoanKattouw>	 greg-g: Is there anyone else in line?
[00:02:34] <gerrit-wm_>	 New review: Hoo man; "While I agree that this should be deprecated it's still used in SiteSQLStore::siteFromRow and mentio..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/65691
[00:03:35] <superm401>	 RoanKattouw, yes.
[00:03:52] <RoanKattouw>	 OK, going
[00:04:59] <superm401>	 MatmaRex, we didn't use the preference for two reasons:
[00:05:19] <MatmaRex>	 superm401: i've read the announcement at VPT  already :)
[00:05:20] <superm401>	 1. It's public, so if you don't feel comfortable with other users seeing it, you won't fill it out.
[00:05:30] <superm401>	 MatmaRex, okay, make sense?
[00:05:39] <MatmaRex>	 superm401: yup
[00:05:41] <MatmaRex>	 thanks :)
[00:10:43] <gerrit-wm_>	 New review: Hoo man; "Looks good on first sight... added someone to do i18n review." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291
[00:13:29] <hoo>	 MatmaRex: Could you have a look at https://gerrit.wikimedia.org/r/70583 please? Chris and I both lay hands on it, so neither of us can merge
[00:14:34] <gerrit-wm_>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71564
[00:14:52] <MatmaRex>	 hoo: uh, i have no idea how abusefilter actually works, you know. :)
[00:14:54] <gerrit-wm_>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71565
[00:15:05] <MatmaRex>	 hoo: add me as a reviewer?
[00:15:05] <gerrit-wm_>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71565
[00:15:17] <gerrit-wm_>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71564
[00:22:28] <hoo>	 MatmaRex: Already done
[00:22:42] <hoo>	 it's more about that one jQuery question raised inline :P
[00:23:12] <hoo>	 I tested the code and I'm pretty sure Chris did as well
[00:27:09] <MatmaRex>	 hoo: #mw-abusefilter-warn-message-existing is a <select>?
[00:28:43] <MatmaRex>	 hoo: myself i'd use its selectedIndex property, then, but .prop() there should be okay
[00:29:48] <hoo>	 MatmaRex: it's a select, yes
[00:30:15] <hoo>	 Can you take that opinion into gerrit somehow
[00:30:17] <hoo>	 ?
[00:30:23] <MatmaRex>	 can do
[00:31:05] <gerrit-wm_>	 New review: Matmarex; "Super-quick note." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583
[00:31:06] <gerrit-wm_>	 New review: Katie Horn; "(1 comment)" [wikimedia/fundraising/crm] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/71557
[00:31:06] <gerrit-wm_>	 Change merged: Katie Horn; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71557
[00:31:12] <MatmaRex>	 hoo: ^^^
[00:32:26] <hoo>	 MatmaRex: Thanks :) I really want to get this merged before Thursday so that we can start testing global AbuseFilters in production soon
[00:34:28] <MatmaRex>	 hoo: i can look and merge tomorrow if you don't find anyone better for this ;)
[00:35:10] <hoo>	 That would be great, let's see :)
[00:36:24] <MatmaRex>	 hoo: but i'm not merging stuff at 3 am. :P
[00:36:27] <gerrit-wm_>	 New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536
[00:36:44] <hoo>	 :D
[00:37:05] * Reedy  thinks MatmaRex can't tell the time

[00:38:06] <MatmaRex>	 well, half past two.
[00:38:21] <MatmaRex>	 it'd be three before i checked it out locally with my connection
[00:38:38] <Reedy>	 heh
[00:49:19] <marktraceur>	 qgil: FYI I've booked a conference room up here if you want to hole up with me, but I suspect it's not necessary
[00:49:42] <qgil>	 marktraceur, I'm in Mountain View today, but thank you
[00:49:46] <marktraceur>	 Ah sure
[00:49:53] <marktraceur>	 BART strike? Or just more convenient?
[00:55:32] <robla>	 "I'm flying to Fiji because [<clears throat>] BART strike"
[00:56:19] <qgil>	 marktraceur, today I had a bunch of GSoC since 7am so I decided to book only one meeting (at home)  :)
[00:56:25] <qgil>	 gsoc meetings
[00:56:51] <qgil>	 marktraceur, are you creating the meeting? My first BigBlueButton...
[00:57:48] <gerrit-wm_>	 New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[00:57:50] <qgil>	 marktraceur, well, it seems simple. I'll create one.
[00:59:18] <marktraceur>	 I was creating it
[00:59:22] <marktraceur>	 qgil: Did you start one already?
[00:59:31] <qgil>	 http://videoconf.wikimedia.ch/bigbluebutton/create.jsp?action=invite&meetingID=GSoC+team+meeting
[01:03:57] <gerrit-wm_>	 New patchset: Kaldari; "More concise i18n message" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/71567
[01:04:54] <gerrit-wm_>	 New review: Kaldari; "trivial change" [mediawiki/extensions/Disambiguator] (master) C: 2;  - https://gerrit.wikimedia.org/r/71567
[01:45:34] <gerrit-wm_>	 New patchset: Hoo man; "Allow running the AbuseFilter parser tests via phpunit" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[01:54:48] <gerrit-wm_>	 New review: Tim Starling; "Real name is not private info. It is available for anonymous users to view by using action=credits o..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/67876
[01:58:59] <gerrit-wm_>	 New patchset: Hoo man; "Make AbuseFilter work without AntiSpoof" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[02:01:36] <gerrit-wm_>	 New patchset: Aaron Schulz; "[WIP] Added consumer request controllers" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/71156
[02:07:42] <gerrit-wm_>	 New patchset: Hoo man; "Allow running the AbuseFilter parser tests via phpunit" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[02:07:53] <gerrit-wm_>	 New review: Parent5446; "Those were my exact concerns, especially considering extensions use many of these accessor functions..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/67876
[02:08:30] <gerrit-wm_>	 New review: Hoo man; "Allow running the tests without the AntiSpoof extension" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71571
[02:18:25] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71520
[02:38:18] <gerrit-wm_>	 New review: Mattflaschen; "Tested successfully on both paths (start/continue-editing).  Will merge when -2 is removed." [mediawiki/extensions/GettingStarted] (master) C: 2;  - https://gerrit.wikimedia.org/r/70766
[02:45:16] <gerrit-wm_>	 New patchset: Mattflaschen; "Adding support for primary link in notification" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766
[02:46:01] <gerrit-wm_>	 New review: Mattflaschen; "You can +2 if it looks good." [mediawiki/extensions/GettingStarted] (master) C: 1;  - https://gerrit.wikimedia.org/r/70766
[03:41:35] <ori-l>	 paging Elsie
[03:43:13] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69979
[03:48:53] <Elsie>	 ori-l: What'd Elsie do?
[03:49:08] <ori-l>	 didn't do
[03:49:13] <Elsie>	 Damn her.
[03:49:17] <ori-l>	 I have a project.
[03:49:53] <ori-l>	 go to https://github.com/wikimedia/mediawiki-core and have a look at the rendered README below the file listing
[03:49:55] <Elsie>	 I know a guy who's pretty good with Python... goes by the name Livneh.
[03:50:50] <ori-l>	 "MediaWiki: Only a little worse than you thought"
[03:50:56] <Elsie>	 http://osrc.dfm.io/atdt
[03:51:00] <Elsie>	 What am I looking at?
[03:51:21] <Elsie>	 Oh.
[03:51:33] <ori-l>	 heh "Ori's most active time is around 1am"
[03:51:33] <Elsie>	 I wonder who wrote that.
[03:51:55] <ori-l>	 The caption at the top used to say something like "You're at the wrong place, go to Gerrit"
[03:52:04] <ori-l>	 but yuvipanda and matt and i changed it without asking
[03:52:20] <Elsie>	 Because there's GitHub <--> Gerrit integration now?
[03:52:21] <gerrit-wm_>	 New review: Rjain; "@Tilgovi, then how do we identify the position of where the annotation was made in a wiki page if we..." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794
[03:52:45] <ori-l>	 no, the default github repo description has always been that way
[03:53:05] <ori-l>	 previous it was:
[03:53:13] <ori-l>	 Github mirror of MediaWiki extension SemanticMediaWiki - our actual code is hosted with Gerrit (please see https://www.mediawiki.org/wiki/Developer_access for contributing)
[03:53:13] <ori-l>	 https://gerrit.wikimedia.org
[03:53:13] <ori-l>	  — Edit
[03:53:27] <Elsie>	 Right.
[03:53:31] <ori-l>	 so you know you're looking at non-actual code
[03:53:54] <Elsie>	 Now it says...
[03:54:05] <Elsie>	 > MediaWiki is the collaborative editing software that runs Wikipedia. It powers some of the most highly-trafficked sites on the web, serving content in over a hundred languages to more than half a billion people each month.
[03:54:09] <Elsie>	 https://www.mediawiki.org/wiki/MediaWiki
[03:54:23] <Elsie>	 https://github.com/wikimedia
[03:54:26] <gerrit-wm_>	 New patchset: Mwjames; "SMWQueryPage::getSearchForm() add search form" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71573
[03:54:27] <Elsie>	 Interesting.
[03:54:31] <Elsie>	 It's GitHub, by the way.
[03:54:36] <Elsie>	 GitHub, Bitbucket.
[03:54:53] <Elsie>	 MediaWiki.
[03:55:05] <Elsie>	 Wikimedia.
[03:55:11] <Elsie>	 I should write a poem.
[03:55:24] <ori-l>	 so, the README:
[03:55:34] <ori-l>	 - stale metric (Jan 2012), check
[03:55:52] <Elsie>	 Yeah.
[03:55:56] <ori-l>	 etc.
[03:55:56] <Elsie>	 I think I asked above who wrote it.
[03:56:09] <ori-l>	 git blame
[03:56:15] <Elsie>	 git-review is your friend.
[03:56:36] <ori-l>	 https://github.com/wikimedia/mediawiki-core/blame/master/README
[03:56:42] <Elsie>	 I just got there.
[03:56:44] <Elsie>	 Thank you.
[03:56:52] <ori-l>	 blame/master
[03:57:15] <Elsie>	 I thought this file was more recent for some reason.
[03:57:37] <Elsie>	 This isn't a good job for me.
[03:57:42] <Elsie>	 I think you want guillom.
[03:58:27] <ori-l>	 Well, OK
[03:58:44] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71573
[03:58:53] <ori-l>	 this is pretty hilarious: https://github.com/wikimedia/mediawiki-core/commit/bad64100e0d7821374709ed4c571a1745a1676d5
[03:59:05] <Elsie>	 It might a good way to test GitHub <--> Gerrit integration, though.
[03:59:10] <Elsie>	 You can edit that file on GitHub, presumably.
[03:59:12] <Elsie>	 Like a wiki!
[04:00:13] <Elsie>	 The README seems to have a very unclear scope.
[04:00:25] <Elsie>	 Why is it acting as a CREDITS listing?
[04:00:56] <Elsie>	 There's a CREDITS and LICENSE file, but the README includes its own copies of both.
[04:00:59] <ori-l>	 That's the kind of first-rate investigative journalism I expected
[04:01:30] <Elsie>	 Rewriting it is tedious, but probably not particularly controversial.
[04:01:33] <Elsie>	 The French have a way with words.
[04:01:40] <ori-l>	 It reads a bit like those forum threads where you're supposed to just paste whatever is in your clipboard without stopping to censor
[04:01:42] <Elsie>	 Lure guillom with the promise of... I dunno.
[04:01:49] <Elsie>	 Heh.
[04:02:00] <Elsie>	 It mirrors a wiki page being developed in many ways.
[04:02:10] <Elsie>	 Except there were no non-coders to come in and do housekeeping.
[04:03:35] <Elsie>	 I wonder if removing the list of authors from the README and just retaining the CREDITS file would be controversial.
[04:05:04] <ori-l>	 You could convert the list to a long copyright attribution, like Special:Version
[04:05:50] <Elsie>	 Maybe: we should have a three-month RFC. Have the original text on one side and proposed text on another side. On a wiki page on mediawiki.org. Then sync it at the end of three months. Wikis are nice for collaboration and discussion. Or at least we're fairly good at using them for that.
[04:06:08] * Elsie  shrugs.

[04:06:26] <Elsie>	 It seems like it needs some work, but I'm not sure how protective people are of the content.
[04:06:36] <Elsie>	 And it's a pretty old file.
[04:08:13] <gerrit-wm_>	 New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836
[04:09:20] <Elsie>	 https://github.com/wikimedia/mediawiki-core/blob/d82c14fb4fbac288b42ca5918b0a72f33ecb1e69/README is funny ten years later.
[04:09:24] <Elsie>	 ori-l: ^
[04:10:22] <ori-l>	 I'm filing a bug
[04:10:36] <Elsie>	 A blocker of bug 1!
[04:12:17] <gerrit-wm_>	 New review: Tim Starling; "So the protection levels are now named after rights instead of groups, specifically editprotected an..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/71536
[04:16:22] <Elsie>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=27152#c0
[04:16:29] <Elsie>	 That's a lovely username.
[04:27:07] <TimStarling>	 why is gerrit so broken atm?
[04:28:06] <gerrit-wm_>	 New patchset: Mwjames; "\SMW\Store\Collector add test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71574
[04:28:48] <Elsie>	 Are you using Firefox?
[04:28:59] <Elsie>	 I heard it was super-slow for Firefox users since the recent upgrade.
[04:32:29] <gerrit-wm_>	 New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836
[04:32:30] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71574
[04:41:56] <gerrit-wm_>	 New patchset: Spage; "postEdit module needs to run before openTask" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/71575
[04:43:24] <gerrit-wm_>	 New review: Nischayn22; "The bug report covers the description, anyways next time it will be better ;)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71277
[04:46:08] <gerrit-wm_>	 New review: Tim Starling; "Has any benchmarking of this been done? I see that this will cause an extra in_array() in openElemen..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70036
[04:47:40] <gerrit-wm_>	 New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836
[04:49:03] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836
[04:52:18] <gerrit-wm_>	 New review: Mattflaschen; "Should be ext.gettingstarted.logging, since that's where wgPostEdit is actually used." [mediawiki/extensions/GettingStarted] (master) C: -1;  - https://gerrit.wikimedia.org/r/71575
[04:59:11] <gerrit-wm_>	 New patchset: Spage; "postEdit needs to run before GS logging" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/71575
[05:00:06] <gerrit-wm_>	 New patchset: Hiong3-eng5; "moved most SpecialPage from app to setup" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71576
[05:01:25] <gerrit-wm_>	 New review: Ori.livneh; "The only thing that's worse than a bug that may or may not be a bug is a fix that may or may not be ..." [mediawiki/extensions/GettingStarted] (master) C: -1;  - https://gerrit.wikimedia.org/r/71575
[05:03:07] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766
[05:03:21] <gerrit-wm_>	 New patchset: Mwjames; "SMW\SQLStore\PropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/70041
[05:04:40] <gerrit-wm_>	 New patchset: Santhosh; "Remove Arial fontfamily style for buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71577
[05:09:17] <gerrit-wm_>	 New review: Hiong3-eng5; "Kindly check for corrections. If none, kindly merge. thanks." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71576
[05:14:09] <gerrit-wm_>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[05:28:41] <wmf-selenium-bot>	 Yippie, build fixed!
[05:28:41] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #24: FIXED in 4 min 52 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/24/
[05:34:05] <wmf-selenium-bot>	 Yippie, build fixed!
[05:34:05] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #122: FIXED in 5 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/122/
[05:47:50] <gerrit-wm_>	 New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172
[05:51:47] <gerrit-wm_>	 New review: Rtdwivedi; "I was planning to add the tests for ProofreadPageContent in another commit but it fits well in this ..." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172
[05:57:20] <gerrit-wm_>	 New review: KartikMistry; "LGTM." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/71577
[05:57:48] <gerrit-wm_>	 New patchset: Santhosh; "After rendering input and display settings, refresh webfonts" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71580
[06:16:20] <gerrit-wm_>	 New review: Aaron Schulz; ""the longer a file has gone unchanged"...arg, lots of typo fail" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67880
[06:23:22] <gerrit-wm_>	 New patchset: Kaldari; "Changing 'cb' to 'callback'." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71581
[06:24:06] <gerrit-wm_>	 New patchset: Kaldari; "Changing 'cb' to 'callback'." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71581
[06:33:44] <gerrit-wm_>	 New review: Mattflaschen; "Why are you minus-1'ing S's fix because I didn't test it (he did, if you look at the bug)?" [mediawiki/extensions/GettingStarted] (master) C: 1;  - https://gerrit.wikimedia.org/r/71575
[06:53:42] <gerrit-wm_>	 New review: Ori.livneh; "Sorry -- I missed the follow-up on Bugzilla, which is indeed clearer." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/71575
[07:04:04] <gerrit-wm_>	 New patchset: Aaron Schulz; "Changed some md5 calls to use sha1 instead." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/66145
[07:04:20] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71577
[07:04:51] <gerrit-wm_>	 New patchset: Tim Starling; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802
[07:04:52] <gerrit-wm_>	 New patchset: Tim Starling; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089
[07:05:58] <gerrit-wm_>	 New review: Tim Starling; "PS34: rebase" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/54089
[07:07:25] <gerrit-wm_>	 New review: Ori.livneh; "Well, mw.hooks() would only solve half the problem; you'd reliably log page-save-success, though you..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/71575
[07:08:42] <gerrit-wm_>	 New review: Tim Starling; "PS15: rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802
[07:23:03] <gerrit-wm_>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71584
[07:31:36] <gerrit-wm_>	 New patchset: Amire80; "Adjust the position of the menu near the cog by a few pixels" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585
[07:35:43] <gerrit-wm_>	 New review: Kipcool; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/71576
[07:37:43] <gerrit-wm_>	 New patchset: Amire80; "Adjust the position of the menu near the cog by a few pixels" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71585
[08:00:38] <gerrit-wm_>	 New patchset: Pastakhov; "Allow objects in foxway as function	(version 0.5.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/71587
[08:02:27] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/71587
[08:03:07] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71584
[08:23:48] <gerrit-wm_>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364
[08:25:37] <gerrit-wm_>	 New patchset: Nikerabbit; "ULS to master on 1.22wmf8" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71589
[08:29:59] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71589
[08:54:55] <hashar>	 I am going to upgrade Jenkins, would take roughly half an hour to complete.
[09:31:33] <gerrit-wm_>	 New patchset: Aude; "deprecate ChangesList::usePatrol" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[09:34:01] <gerrit-wm_>	 New review: Aude; "I am tempted to simply remove this entirely, although perhaps we can wait a little while." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[09:47:21] <gerrit-wm_>	 New review: Matmarex; ">  It is difficult for us to simultaneously switch one feature off and the other on during deployment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089
[10:05:50] <gerrit-wm_>	 New patchset: Wikinaut; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258
[10:06:29] <gerrit-wm_>	 New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287
[10:21:41] <gerrit-wm_>	 New review: Nikerabbit; "I would add wfDeprecated, add release notes entry and remove it in next release." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[10:23:43] <Nikerabbit>	 hashar: your updates don't affect gerrit at all, right?
[10:24:54] <hashar>	 Nikerabbit: should not :)  what is wrong?
[10:25:02] <Nikerabbit>	 hashar: I'm getting signed out
[10:25:33] <hashar>	 might be an issue with the labs LDAP
[10:25:39] <hashar>	 or some random function
[10:25:44] <Nikerabbit>	 hashar: is there bug for that or should I file one?
[10:25:57] <hashar>	 fill one :-)
[10:26:08] <hashar>	 I don't think I have the issue
[10:26:16] <hashar>	 although yesterday i got disconnected a couple times
[10:26:51] <Nemo_bis>	 hashar: Ori said that was because of the two updates
[10:27:08] <hashar>	 yeah I guess the session table in Gerrit is cleared on upgrade
[10:27:10] <Nemo_bis>	 more than 2 disconnections would be a(nother) bug I suppose
[10:28:26] <Nikerabbit>	 I doubt there was an upgrade in last 30 minutes or so
[10:48:06] <gerrit-wm_>	 New patchset: Wikinaut; "fixed null array error for fullname/email in AX array" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258
[10:52:25] <gerrit-wm_>	 New review: Nikerabbit; "So many magic numbers - don't you think some comments would be helpful? Can you explain the calculat..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1;  - https://gerrit.wikimedia.org/r/71585
[10:52:25] <gerrit-wm_>	 New review: Wikinaut; "Parent5446 and jpond:" [mediawiki/extensions/OpenID] (master) C: 1;  - https://gerrit.wikimedia.org/r/71258
[10:53:21] <gerrit-wm_>	 New patchset: Nikerabbit; "After rendering input and display settings, refresh webfonts" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71580
[10:56:45] <gerrit-wm_>	 New patchset: Hashar; "HTCPPurge() early exit on socket error" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71596
[10:56:45] <gerrit-wm_>	 New patchset: Hashar; "$wgHTCPMulticastRouting now support multiple hosts" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[10:59:59] <gerrit-wm_>	 New review: Hashar; "Roan, I have added you as a reviewer of this change since you wrote the original $wgHTCPMulticastRou..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[11:02:59] <gerrit-wm_>	 New review: Wikinaut; "Dear Parent5446: " [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258
[11:18:17] <gerrit-wm_>	 New patchset: Zfilipin; "Upgrade Ruby to the latest released version" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[11:19:00] <gerrit-wm_>	 New patchset: Zfilipin; "WIP Upgrade Ruby to the latest released version" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[11:19:20] <gerrit-wm_>	 New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/63378
[11:20:39] <gerrit-wm_>	 New patchset: Zfilipin; "WIP Upgrade Ruby to the latest released version" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[11:22:28] <gerrit-wm_>	 New patchset: Zfilipin; "Upgrade Ruby to the latest released version" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[11:38:24] <gerrit-wm_>	 New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364
[11:46:14] <gerrit-wm_>	 New patchset: Santhosh; "[WIP] Content editable support" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71602
[11:46:34] <gerrit-wm_>	 New patchset: Santhosh; "[WIP] Content editable support" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71602
[11:46:51] <gerrit-wm_>	 New review: Santhosh; "WIP" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2;  - https://gerrit.wikimedia.org/r/71602
[11:47:46] <gerrit-wm_>	 New patchset: Siebrand; "Namespace translations for Dutch" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/71603
[11:49:41] <gerrit-wm_>	 New patchset: Siebrand; "Update formatting" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/71604
[11:49:46] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/71603
[11:51:48] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/71604
[11:52:37] <gerrit-wm_>	 New review: Matmarex; "See inline." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/43166
[12:07:44] <gerrit-wm_>	 New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71606
[12:10:12] <gerrit-wm_>	 New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089
[12:25:23] <gerrit-wm_>	 New patchset: Matmarex; "mediawiki.page.startup: Code cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71608
[12:26:30] <zeljkof>	 how do I run a command for every file in a folder (in bash), recursively?
[12:26:33] <zeljkof>	 for example
[12:26:56] <zeljkof>	 ruby -cw features/step_definitions/aftv5_steps.rb
[12:27:35] <zeljkof>	 but instead of pointing to a file, doing it for all files in a folder (recursively)?
[12:28:06] <zeljkof>	 "ruby -cw *" is not doing what I want :)
[12:28:26] * zeljkof  is doing some googleing

[12:28:44] <MatmaRex>	 zeljkof: **/* may or may not work
[12:28:52] <MatmaRex>	 depending on your configuration
[12:29:17] <MatmaRex>	 zeljkof: `find . | xargs ruby -cw` will work for sure, though.
[12:29:23] <MatmaRex>	 (assuming unix-line environment)
[12:29:38] <zeljkof>	 MatmaRex: yes, I am on a mac, xargs is what I was looking for
[12:29:41] <zeljkof>	 will try now
[12:30:06] <zeljkof>	 hm
[12:30:14] <zeljkof>	 $ find . | xargs ruby -cw
[12:30:15] <zeljkof>	 ruby: Is a directory -- . (LoadError)
[12:30:20] <zeljkof>	 am I doing something wrong?
[12:30:29] <Nikerabbit>	 hmm
[12:30:50] <zeljkof>	 I guess I should run it just for .rb files
[12:30:58] <Nikerabbit>	 try find -d
[12:31:01] <Nikerabbit>	 erm
[12:31:30] <Nikerabbit>	 find -type f
[12:31:40] <Nikerabbit>	 or find -name "*.rb"
[12:31:55] <Nikerabbit>	 and perhaps xargs -n1 unless the script can handle multiple files at once
[12:35:33] <gerrit-wm_>	 New review: Hoo man; "While I agree that we should have those two additional rights I have to be evil and demand one that ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536
[12:36:03] <gerrit-wm_>	 New review: Zfilipin; "Looks like there are no problems, the same tests fail as with the previous Ruby version: https://wmf..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[12:36:50] <zeljkof>	 Nikerabbit, MatmaRex: thanks, trying your suggestions
[12:38:45] <zeljkof>	 Nikerabbit, MatmaRex: I guess I am doing something wrong
[12:39:33] <gerrit-wm_>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[12:40:41] <zeljkof>	 http://etherpad.wmflabs.org/pad/p/wikimedia-dev
[12:41:38] <zeljkof>	 I am not sure how to get all ruby files (.rb)
[12:42:42] <Nikerabbit>	 find . -name "*.rb"
[12:43:27] <Nikerabbit>	 dot (where to look) is important
[12:43:54] <zeljkof>	 Nikerabbit: I see, thanks
[12:44:18] <zeljkof>	 Nikerabbit: now it works!
[12:44:31] <MatmaRex>	 hm, `find -name "*.js"` works as well for me. :)
[12:45:02] <MatmaRex>	 (my find --version is find (GNU findutils) 4.4.2)
[12:46:07] <zeljkof>	 Nikerabbit, MatmaRex: this worked
[12:46:08] <zeljkof>	 find . -name "*.rb" | xargs -n1 ruby -cw
[12:46:15] <zeljkof>	 http://etherpad.wmflabs.org/pad/p/wikimedia-dev
[12:47:13] <gerrit-wm_>	 New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/54089
[12:47:48] <gerrit-wm_>	 New patchset: Nikerabbit; "Prepare ULS for EventLogging" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862
[12:47:50] <Nikerabbit>	 zeljkof: applause
[12:47:53] <MatmaRex>	 :)
[12:49:29] <Nikerabbit>	 ori-l: is that how you visioned it? Perhaps I was going overboard trying to ensure we would know if it is called too early
[12:51:51] <gerrit-wm_>	 New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089
[12:53:26] <MatmaRex>	 Nikerabbit: thanks for spotting ^
[12:53:31] <jarry1250>	 Is $40k a reasonable average salary for a dev? I find it hard thinking in $ terms
[12:53:35] <jarry1250>	 (WMF dev)
[12:53:51] <jarry1250>	 Sorry, badly phrased
[12:54:01] <Nemo_bis>	 to think?
[12:54:16] * Nemo_bis  has problems with to vs ing

[12:54:19] <jarry1250>	 * Is $40k a reasonable guess at the average salary of a WMF dev?
[12:55:37] <Nemo_bis>	 I think Erik gave some numbers in some recent thread
[13:03:44] <Nemo_bis>	 I suppose (11922-2487-1889)/139 = 54k is not particularly useful a lower bound for an average
[13:03:48] <YuviPanda>	 jarry1250: see also GlassDoor's WMF numbers.
[13:04:02] <Nemo_bis>	 based on https://upload.wikimedia.org/wikipedia/commons/4/48/WMF-AR_2011%E2%80%9312_EN_SHIP2_17dec12_300dpi_hi-res.pdf https://wikimediafoundation.org/w/index.php?title=Template:STAFF-COUNT&oldid=82625
[13:04:04] <YuviPanda>	 but place appropriate levels of trust/distrust on that
[13:04:25] <gerrit-wm_>	 New review: Zfilipin; "Related bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=49867" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70045
[13:05:27] <jarry1250>	 YuviPanda: GlassDoor want me to login :/
[13:05:47] <YuviPanda>	 try incognito?
[13:05:50] <YuviPanda>	 or a different browser?
[13:05:50] <Nemo_bis>	 even less useful: 7468*2/145 = 103 https://upload.wikimedia.org/wikipedia/foundation/6/68/Jul-Dec%2712_Mid-year_financials2.pdf
[13:06:13] <YuviPanda>	 there was also the wikimedia-l thread a while back about this?
[13:06:32] <jarry1250>	 YuviPanda: I think it's because I'm not in the US?
[13:06:35] <YuviPanda>	 it did devolve into funny photos with Champagne though
[13:06:43] <YuviPanda>	 jarry1250: well, I'm not either :P
[13:06:53] <jarry1250>	 It should be www.glassdoor.co.uk/Salary/Wikimedia-Foundation-US-Salaries-EI_IE38331.0,20_IL.21,23_IN1.htm
[13:08:34] <Nemo_bis>	 btw this was rather mysterious :) http://markmail.org/message/mcus3prbf3srcd2b
[13:08:54] <Elsie>	 jarry1250: I have page 1.
[13:09:42] <Elsie>	 jarry1250: http://pruebita.com/glassdoor-wikimedia-foundation-page-1.png
[13:10:32] <jarry1250>	 Elsie: Thanks :)
[13:11:19] <Elsie>	 Salaries should be higher in SF.
[13:11:30] <Elsie>	 Because there's more competition and a much higher cost of living.
[13:12:14] <Nemo_bis>	 this sort of happened: "we're actively looking into an additional engineering presence in a lower-salary region as part of the 11-12 budgeting process that's currently underway"
[13:14:36] <YuviPanda>	 jarry1250: in unrelated news, I should transfer the Signpost backend (Feed, Push for App) to toollabs. Should make it easier to have other maintainers.
[13:18:10] <Nemo_bis>	 hmm (11922-2487-1889)/(139-60) = 95 k
[13:18:32] <Nemo_bis>	 still https://upload.wikimedia.org/wikipedia/commons/4/48/WMF-AR_2011%E2%80%9312_EN_SHIP2_17dec12_300dpi_hi-res.pdf but less non-eng https://wikimediafoundation.org/w/index.php?title=Template:Staff_and_contractors&oldid=82626
[13:18:41] <Nemo_bis>	 too much guesswork :)
[13:19:18] <Nemo_bis>	 jarry1250: I'd say at least 55k
[13:22:48] <Nemo_bis>	 but really, such numbers mean little
[13:28:45] <gerrit-wm_>	 New review: Jeroen De Dauw; "Woha, that tablePrefix is some bad code. Even though it already provides the same thing as the funct..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52177
[13:30:43] <gerrit-wm_>	 New review: Jeroen De Dauw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785
[13:32:33] <gerrit-wm_>	 New patchset: Jeroen De Dauw; "Allow registration of Actions using a callback that returns an Action instance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785
[13:33:23] <gerrit-wm_>	 New review: Jeroen De Dauw; "Hope this won't sit here for another half year so I can rebase again since we bumped to 1.23" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785
[13:37:23] <gerrit-wm_>	 New review: Demon; "The docs clearly state what it does. I see no need to duplicate functionality here." [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/52177
[13:38:38] <Nikerabbit>	 that would be sad
[13:42:39] <^demon>	 ori-l: "For now the purpose is merely to convince the reader that installing MediaWiki is simple and straightforward." -- emphasis on "convince." I need some convincing myself ;-)
[13:48:03] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71580
[14:02:04] <gerrit-wm_>	 New patchset: Jeroen De Dauw; "Move inclusion of composer autoloader to after inclusion of DefaultSettings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71616
[14:05:33] <gerrit-wm_>	 New patchset: Jeroen De Dauw; "Move inclusion of composer autoloader to after inclusion of DefaultSettings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71616
[14:06:26] <gerrit-wm_>	 New patchset: VitaliyFilippov; "Replace step-by-step publishing with publish-staying-in-editmode" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/71617
[14:07:48] <gerrit-wm_>	 New patchset: Yaron Koren; "Version 1.3, + formatting and typo fixes" [mediawiki/extensions/LiveTranslate] (master) - https://gerrit.wikimedia.org/r/71618
[14:14:13] <gerrit-wm_>	 New review: Jpond; "Wikinaut - tested it with $ax this am.  All looks good" [mediawiki/extensions/OpenID] (master) C: 1;  - https://gerrit.wikimedia.org/r/71258
[14:15:00] <gerrit-wm_>	 Change merged: Yaron Koren; [mediawiki/extensions/LiveTranslate] (master) - https://gerrit.wikimedia.org/r/71618
[14:34:47] <gerrit-wm_>	 New patchset: VitaliyFilippov; "Add russian messages for bad title errors." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/44397
[14:34:47] <gerrit-wm_>	 New patchset: VitaliyFilippov; "Show detailed errors for bad titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166
[14:43:29] <gerrit-wm_>	 New review: VitaliyFilippov; "Okay, I've made fixes for most of your remarks, except:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166
[14:44:54] <gerrit-wm_>	 New review: MZMcBride; "This seems like an area where unit tests might be helpful/useful." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[14:45:22] <gerrit-wm_>	 New review: Cmcmahon; "I think we should find out why this is not on beta before we delete the test for it." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71347
[14:53:12] <gerrit-wm_>	 New review: Daniel Kinzler; "I have no particular issue with this change, but I don't think I fully understand it and its implica..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378
[14:54:11] <se4598>	 hi, I need someone to merge and deploy a mw-config change after community decision (AFTv5 for dewiki), https://gerrit.wikimedia.org/r/71546
[14:54:56] <gerrit-wm_>	 New review: Daniel Kinzler; "As per Nikerabbit: if it's unused, either just remove it or add wfDeprecated. " [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/71591
[15:03:44] <gerrit-wm_>	 New patchset: Matmarex; "Provide month names via mediawiki.language.months RL module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36391
[15:03:47] <gerrit-wm_>	 New patchset: Matmarex; "jquery.tablesorter: support genitive month names" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496
[15:05:43] <gerrit-wm_>	 New review: Matmarex; "I rewrote the patch from scratch. Let's make it happen at last." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36391
[15:06:05] <gerrit-wm_>	 New review: Matmarex; "I rewrote the dependency from scratch and adjusted this accordingly. Let's make it happen at last." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496
[15:09:13] <gerrit-wm_>	 New patchset: Matmarex; "Provide month names via mediawiki.language.months RL module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/36391
[15:09:22] <se4598>	 Reedy, you there and wanna deploy a mw-config change?
[15:09:33] <Reedy>	 I'm here
[15:09:37] <Reedy>	 And I'm not sure, what is it? :P
[15:09:56] <se4598>	 https://gerrit.wikimedia.org/r/71546
[15:10:39] <se4598>	 Reedy: mlitn is on vacation this week, so he can't do it in the best way
[15:13:57] <Nemo_bis>	 se4598: why didn't they vote for the full disable?
[15:15:14] <gerrit-wm_>	 New patchset: Matmarex; "jquery.tablesorter: support genitive month names" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496
[15:15:44] <gerrit-wm_>	 New patchset: Aude; "deprecate ChangesList::usePatrol" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[15:16:09] <gerrit-wm_>	 New review: Daniel Kinzler; "Should be fine, but I'm uneasy about the arcane way the code determines whether we need a leading ':..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[15:16:10] <se4598>	 Nemo_bis: It was a test phase so we have to vote for permanent activation, and that poll was negativ so we going to have the status quo ante (but with aft enable to see atleast the existing feedbacks for an amount of time)
[15:17:39] <gerrit-wm_>	 New review: Matmarex; "(That knowledge shouldn't really be necessary, the parser should handle redirects like this without ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[15:17:48] <Nemo_bis>	 se4598: yes, I know, I was just wondering why full disable wasn't put up for vote even though it seems to be among the options discussed at the top
[15:19:06] * gwicke  was just hit by the Gerrit vs. Firefox bug again

[15:19:18] <gerrit-wm_>	 New review: Aude; "added wfDeprecated." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[15:19:19] <se4598>	 Nemo_bis: it is the consequence of the two question: full or opt-in. so we don't list it as a separate point
[15:19:22] <YuviPanda>	 firefox usually wins that one :)
[15:20:05] <gwicke>	 those Googlers are probably only testing on Chrome these days
[15:20:28] <Nemo_bis>	 se4598: ah, you mean that full disable is also approved by that poll, but you leave it to a future config change?
[15:20:41] <Nemo_bis>	 (this discussion should be on #wikimedia-tech)
[15:24:25] <gerrit-wm_>	 New review: Daniel Kinzler; "@LivingShadow: welcome to the crazy world of MediaWiki development with gerrit!" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/71074
[15:29:08] <gerrit-wm_>	 New review: Hashar; "Shouldn't it be done between DefaultSettings and LocalSettings.php ?  If it is done late, how one co..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71616
[15:31:23] <gerrit-wm_>	 New patchset: Njw; "Disable justification at very narrow widths" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71619
[15:31:35] <gerrit-wm_>	 New patchset: Hoo man; "Make AbuseFilter work without AntiSpoof" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[15:32:36] <gerrit-wm_>	 New review: Hoo man; "Addressed Anomie's comments" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[15:32:45] <gerrit-wm_>	 New patchset: Njw; "Remove unneeded header comment on erudite.css, and update copyright to GPLv2 or later (after email confirmation with Matt Weibe that he was happy with that)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71620
[15:36:38] <gerrit-wm_>	 New patchset: Hashar; "$wgHTCPMulticastRouting now support multiple hosts" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[15:36:54] <gerrit-wm_>	 New review: Hashar; "Mark wrote:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[15:43:19] <gerrit-wm_>	 New patchset: Njw; "Disable justification at very narrow widths" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71619
[15:44:35] <gerrit-wm_>	 Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71619
[15:44:56] <gerrit-wm_>	 New review: Jeroen De Dauw; "You are right, it needs to be before LocalSettings to avoid that problem. I'm concerned putting it b..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/71616
[15:45:38] <gerrit-wm_>	 Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/71620
[15:48:26] <gerrit-wm_>	 New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536
[15:48:59] <gerrit-wm_>	 New patchset: Anomie; "Fix protection rights usage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536
[15:51:25] <aude>	 qgil: back in 30 min or so
[15:51:38] * aude  try not to be late but need to go home

[15:53:02] <gerrit-wm_>	 New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2;  - https://gerrit.wikimedia.org/r/70982
[15:53:03] <gerrit-wm_>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70982
[15:54:51] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[15:54:55] <gerrit-wm_>	 New patchset: Hashar; "$wgHTCPMulticastRouting rename + multi hosts support" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[15:55:06] <gerrit-wm_>	 New review: Matmarex; "Hm, let's try some tests then. I wonder if they'll pass, I have no idea what I'm doing." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[15:55:26] <gerrit-wm_>	 New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2;  - https://gerrit.wikimedia.org/r/71600
[15:55:27] <gerrit-wm_>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71600
[15:55:51] <gerrit-wm_>	 New review: Hashar; "* Renamed $wgHTCPMulticastRouting to $wgHTCPRouting with back compatibility " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71597
[15:56:11] <gerrit-wm_>	 New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2;  - https://gerrit.wikimedia.org/r/71606
[15:56:11] <gerrit-wm_>	 New review: Anomie; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[15:56:11] <gerrit-wm_>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71606
[15:58:34] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[15:58:49] <gerrit-wm_>	 New review: Hashar; "I thought about LocalSettings.php, I guess that is the best place to fit it in.  After all, that is ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71616
[15:58:53] <gerrit-wm_>	 New patchset: Anomie; "Improve UI for page protection with $wgNamespaceProtection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71539
[15:59:21] <gerrit-wm_>	 New patchset: Anomie; "Improve UI for page protection with $wgNamespaceProtection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71539
[15:59:37] <gerrit-wm_>	 New review: Anomie; "PS3: Address issues" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71539
[16:00:49] <gerrit-wm_>	 New review: Anomie; "PS2: Remove hack in ProtectionForm, have Title::isSemiProtected recognize both BC protection level a..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71536
[16:01:27] <gerrit-wm_>	 New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[16:02:37] <MatmaRex>	 where is hashar when i need him
[16:03:08] <MatmaRex>	 in a PHP unit test, i need a user with privileges to edit MediaWiki: pages. how do i get one? :(
[16:04:10] <Nikerabbit>	 that's not a unit test ;)
[16:04:30] <gerrit-wm_>	 New patchset: Hoo man; "Make AbuseFilter work without AntiSpoof" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[16:12:01] <gerrit-wm_>	 New patchset: Zfilipin; "UploadWizard now throws a warning if 'category' is not filled in" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71387
[16:12:08] <gerrit-wm_>	 Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71387
[16:12:29] <gerrit-wm_>	 New patchset: Jeroen De Dauw; "Move inclusion of composer autoloader to LocalSettings." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71616
[16:12:31] <gerrit-wm_>	 Change merged: MaxSem; [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/71567
[16:13:26] <MatmaRex>	 Nikerabbit: well, i'm testing EditPage
[16:13:36] <MatmaRex>	 Nikerabbit: so that's probably the best i can get
[16:13:43] <MatmaRex>	 https://gerrit.wikimedia.org/r/#/c/71332/
[16:14:35] <gerrit-wm_>	 New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/71539
[16:18:10] <gerrit-wm_>	 New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49785
[16:18:46] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:19:01] <MatmaRex>	 Nikerabbit: i wonder if that'll work. ^
[16:20:08] <gerrit-wm_>	 New review: Parent5446; "@Wikinaut - There's no functional reason. It just tends to look cleaner that way. Consider" [mediawiki/extensions/OpenID] (master) C: 1;  - https://gerrit.wikimedia.org/r/71258
[16:22:01] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:22:06] <Nikerabbit>	 MatmaRex: the correct thing to do here would be to rewrite half of mediawiki from scratch, but meh
[16:22:20] <MatmaRex>	 Nikerabbit: precisely my point
[16:22:32] <MatmaRex>	 i just want to see if two lines of code work
[16:22:41] <MatmaRex>	 but i have to test the entire article editing process
[16:22:42] <MatmaRex>	 oh well
[16:23:10] <Nikerabbit>	 MatmaRex: I have that feeling way too often
[16:23:16] <MatmaRex>	 argh god dammit
[16:23:20] <MatmaRex>	 fscking semicolons
[16:23:22] <Nikerabbit>	 MatmaRex: only thing which might b0rk that I can figure out is that the user is not added to the database
[16:23:54] <MatmaRex>	 how did that one even get there
[16:24:04] <gerrit-wm_>	 New review: Liangent; "Well there need to be a function $title->getTextUsedToLinkToThisTitleOnGivenTitle( $anotherTitle ) =..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[16:24:07] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:24:07] <nileshc>	 I just pulled from my newly set up extension repository on gerrit. It seems that I don't have push rights. So, the workflow is like this I guess: git review -R ---> code review ---> merge. I just need to know if I'm getting this right, if there are any more gotchas I should look out for...TODOs etc. Links are welcome. :)
[16:24:09] <MatmaRex>	 Nikerabbit: docs for User::createNew claim it gets added
[16:24:22] <MatmaRex>	 not that i'd believe our docs for something critical
[16:24:24] <Nikerabbit>	 but I think there isn't much better thing to do here  but just tweak until the tests pass and have someone else to fix it later if stuff is finally refactored
[16:24:41] <MatmaRex>	 yeah, and our resident hashar is not here
[16:24:44] <Nikerabbit>	 you can be correct, that was just my guess
[16:28:14] <MatmaRex>	 well, poop, the tests still fail
[16:28:24] <MatmaRex>	 but apparently i found a bug in my owncode at least
[16:28:31] <MatmaRex>	 or maybe unexpected behavior, rather
[16:28:35] <gerrit-wm_>	 New review: Daniel Kinzler; "@liangent: when is $anotherTitle relevant to this decision?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[16:28:49] <aude>	 nileshc: i think that is the default permissions
[16:29:15] <aude>	 you might ask DanielK_WMDE_ how it should be setup for this
[16:31:23] <aude>	 qgil: i don't have permission to join the hangout
[16:31:27] <DanielK_WMDE_>	 nileshc: as long as you are working on this by yourself, you'll probably want to push directly. you can request that right from... err... well, i'd just ask ^demon, i guess
[16:31:37] <DanielK_WMDE_>	 gah
[16:31:43] <aude>	 he's gone
[16:31:45] <DanielK_WMDE_>	 now he's gone
[16:31:48] <DanielK_WMDE_>	 :/
[16:31:49] <DanielK_WMDE_>	 hmpf
[16:32:01] <DanielK_WMDE_>	 anyway, direct push makes sense as long as he's working on this alone
[16:32:19] <DanielK_WMDE_>	 as soon as we get anywhere near production, that right should go and be replaced by a 4-eyes review process
[16:32:32] <aude>	 agree
[16:32:36] <gerrit-wm_>	 New review: Liangent; "langlinks ([[en:Something]]) works on subject pages AND special pages (ouch, IIRC) but NOT talk page..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[16:32:48] <qgil>	 aude, @wikimedia.de? sent invitation there
[16:33:06] <aude>	 yes, i tried
[16:33:14] <aude>	 always works for other hangouts
[16:33:28] <qgil>	 aude, I just sent an invitation now
[16:33:37] <qgil>	 yay!
[16:33:38] <aude>	 ok, now it works
[16:33:43] <parent5446>	 Matmarex: There's an existing user UTSysop setup by the unit tests as a bureaucrat.
[16:34:51] <gerrit-wm_>	 New review: Liangent; "@Matmarex: That sounds good but I just discovered that this side effect is somehow used by core, for..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[16:36:13] <gerrit-wm_>	 New patchset: Zfilipin; "Use page text for check, @browser.text makes test flaky" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70744
[16:37:01] <gerrit-wm_>	 Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70744
[16:37:51] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:38:06] <MatmaRex>	 parent5446: oh. hm
[16:38:13] <MatmaRex>	 parent5446: i think i just figured that out myself ^
[16:38:25] <gerrit-wm_>	 New review: Matmarex; "Got rid of the ternary inside if." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:38:29] <MatmaRex>	 parent5446: also ^
[16:38:49] <MatmaRex>	 and also, you should use irc more. ;)
[16:38:55] <gerrit-wm_>	 New patchset: Zfilipin; "WIP add ve_refs check" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128
[16:40:20] <gerrit-wm_>	 New review: Zfilipin; "Please make the commit message more descriptive." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128
[16:40:23] <gerrit-wm_>	 New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:40:52] <parent5446>	 :) Yeah, I keep forgetting to go on
[16:41:38] <MatmaRex>	 parent5446: used that user ^
[16:41:55] <parent5446>	 Mhm, crossed fingers for passing tests.
[16:42:14] <apergos>	 irc, it's where all the cool kids are
[16:42:49] <gerrit-wm_>	 New patchset: Zfilipin; "WIP add ve_refs check" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128
[16:43:20] <gerrit-wm_>	 New review: Zfilipin; "Resolved conflict when merging with master." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128
[16:44:05] <gerrit-wm_>	 New review: Zfilipin; "Removing -1 review since the commit is marked WIP." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468
[16:44:11] <gerrit-wm_>	 New review: Cmcmahon; "Instead of deleting this test, run it in the test2wiki environment where uls-trigger exists instead. " [qa/browsertests] (master) C: -1;  - https://gerrit.wikimedia.org/r/71347
[16:44:27] <gerrit-wm_>	 New patchset: Zfilipin; "The text of link is only Create" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[16:46:59] <YuviPanda>	 Nikerabbit: meeting in 10, I think
[16:48:22] <gerrit-wm_>	 New review: Matmarex; "Aww yeah, tests." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[16:48:28] <orsa>	 YuviPanda: done :)
[16:52:56] <Nikerabbit>	 YuviPanda: meeting in 8!
[16:53:26] <YuviPanda>	 indeed
[16:56:49] <MatmaRex>	 hey brion, wanna review something for me?
[16:56:51] <MatmaRex>	 brion: https://gerrit.wikimedia.org/r/#/c/71332/
[16:56:55] <brion>	 i can try
[16:57:02] <MatmaRex>	 brion: it has ten times as much test code lines as real code lines
[16:57:15] <brion>	 hmmmmm seems legit
[16:57:39] <Nikerabbit>	 YuviPanda: meeting in 3
[16:57:58] <YuviPanda>	 Nikerabbit: yes, doing the 'incognito 2factor auth' dance
[16:58:06] <^d>	 brion: That's always been your version of +2 :)
[16:58:16] <^d>	 Brion says it looks legit, must be ok ;-)
[16:58:24] <Nikerabbit>	 YuviPanda: hmm I always have to do ?authuser=1 but that's even worse
[16:58:39] <brion>	 hehe
[16:58:40] <MatmaRex>	 ^d: i have something for you as well!
[16:58:40] <YuviPanda>	 hmm, let me try that
[16:58:43] <MatmaRex>	 ^d: https://gerrit.wikimedia.org/r/64364
[16:58:47] <MatmaRex>	 this one has no text
[16:58:50] <MatmaRex>	 and no lines of code added
[16:58:57] <^d>	 Dangit, should've kept my mouth shut.
[16:58:58] <MatmaRex>	 tests*
[16:59:03] <MatmaRex>	 just removing some
[16:59:03] <YuviPanda>	 brion: https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/3 is the large commit, btw :)
[16:59:16] <^d>	 Ooooh, deleting things :D
[16:59:20] <^d>	 My favorite kind of patch
[17:00:22] <MatmaRex>	 ^d: i saved it for you. :P
[17:00:41] <gerrit-wm_>	 Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419
[17:00:50] <brion>	 c'mon gerrit, log me back in
[17:01:22] <^d>	 MatmaRex: +2'd. https://gerrit.wikimedia.org/r/#/c/64365/ is gonna need a rebase, fwiw.
[17:01:37] <gerrit-wm_>	 New review: Brion VIBBER; "Looks legit. Changes 'blank page check' to instead check against default message value for MediaWiki..." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/71332
[17:01:41] <gerrit-wm_>	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332
[17:02:17] <YuviPanda>	 ^d: yeah, -~1600 deletion
[17:02:18] <MatmaRex>	 ^d: hm. on it
[17:02:54] <^d>	 YuviPanda: If you're not deleting over 1000 loc, you're doing it wrong :)
[17:03:01] <YuviPanda>	 indeed :D
[17:03:07] <YuviPanda>	 now to get that merged
[17:04:48] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64364
[17:05:22] <^d>	 Omg, seriously?
[17:05:33] <^d>	 https://gerrit.wikimedia.org/r/#/c/70596/ - why is diffy now shown for gerrit's comments?
[17:05:36] <^d>	 Dear lord...
[17:05:45] <^d>	 s/diffy/Diffy/
[17:06:31] <MatmaRex>	 ^d: hm... then you don't want to look at https://gerrit.wikimedia.org/r/#/c/55496/
[17:06:33] <marktraceur>	 Hah, ^d, it's a feature not a bug
[17:06:35] <gerrit-wm_>	 New review: Cmcmahon; "This test runs for beta labs and potentially for test2wiki.  Any environment that has VisualEditor e..." [qa/browsertests] (master) C: -2;  - https://gerrit.wikimedia.org/r/70044
[17:06:51] <^d>	 marktraceur: Stupid feature.
[17:07:40] <marktraceur>	 Wait, can we has avatars too?
[17:07:48] <marktraceur>	 Gerritbook!
[17:07:51] <^d>	 We can write our own plugin
[17:08:01] <^d>	 There's an avatar plugin point now
[17:08:21] <^d>	 There's already a gravatar plugin, but I don't like gravatar.
[17:08:37] <^d>	 Could come up with something that fetches images from commons :)
[17:09:40] <brion>	 we need native avatars in mediawiki dude
[17:09:54] <gerrit-wm_>	 New review: Brian Wolff; "They were notified at https://commons.wikimedia.org/wiki/Commons:VP#Adding_.wav_support_to_Commons ...." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401
[17:09:55] <brion>	 also, support for 3d printing
[17:09:59] <brion>	 3d-printed avatars!
[17:10:11] <gerrit-wm_>	 New review: Zfilipin; "The test works just fine with code from master, but fails with your change." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[17:11:49] <gerrit-wm_>	 New review: Aaron Schulz; "I'd like to just kill toUnsigned() and redo toHex() for the v4 case...sometime" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/70451
[17:13:02] <YuviPanda>	 qgil: your connection dropped
[17:14:22] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70451
[17:14:31] <^d>	 brion: I'd have to re-learn PHP :)
[17:14:36] <^d>	 Too much Java in my head
[17:14:44] <brion>	 hehe
[17:15:01] * brion  wonders if avatar linkages belong in WikiData

[17:15:12] <gerrit-wm_>	 New patchset: Matmarex; "Make brackets in section edit links accessible to CSS." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[17:15:19] <MatmaRex>	 ^d: ^ could you?
[17:15:28] <MatmaRex>	 (assuming tests still pass)
[17:16:24] <^d>	 +101, -127 - your added-to-removed ratio is too high.
[17:16:36] <^d>	 ;-)
[17:17:44] <gerrit-wm_>	 New patchset: Zfilipin; "Fixed confusion in element names" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[17:18:49] <gerrit-wm_>	 New review: Zfilipin; "I have pushed code that I think does the same thing, fixes the confusion that developed when "create..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[17:19:21] <MatmaRex>	 ^d: ;)
[17:22:14] <gerrit-wm_>	 New patchset: Zfilipin; "Deleted test for a feature that is not enabled at beta" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71347
[17:23:02] <gerrit-wm_>	 New patchset: Matmarex; "Make brackets in section edit links accessible to CSS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[17:25:04] <thedj>	 RoanKattouw: is there an event that i can hook into when VE is done with the toolbar ?
[17:25:38] <RoanKattouw>	 There currently isn't
[17:25:46] <thedj>	 hmm.
[17:25:52] <RoanKattouw>	 I agree that there should probably be one
[17:26:04] <RoanKattouw>	 We're about to split our repository and have a related discussion on plugin architecture
[17:26:18] <thedj>	 i was looking for w way to autohide the redlink editnotice for sysops
[17:26:38] <RoanKattouw>	 Oh, that
[17:26:50] <RoanKattouw>	 We've been discussing that over in #mediawiki-visualeditor as well
[17:27:30] <James_F>	 thedj: That's much more do-able than you needing to have a hook.
[17:27:32] <thedj>	 i was thinking 'if editnotices == 1 and .editnotice-redlink == 1, then hide after 2 seconds
[17:28:04] <James_F>	 thedj: Sure, or alternatively we can just put yet another hack in ViewPageTarget.js which is already a mess so no-one would notice.
[17:29:30] <MatmaRex>	 ^d: https://gerrit.wikimedia.org/r/#/c/64365/ can you +2 again?
[17:29:32] <gerrit-wm_>	 New review: Cmcmahon; "Make choice of "Create source" over "Create" explicit now that VE is live" [qa/browsertests] (master) C: 2;  - https://gerrit.wikimedia.org/r/70044
[17:29:58] <^d>	 I didn't +2 it :p
[17:30:12] <thedj>	 James_F: sure, your code, but I figured it was more en.wp responsibility
[17:30:19] <MatmaRex>	 but Krinkl.e is recovering from jet lag, i think :P
[17:30:33] <James_F>	 thedj: I think we owe it to enwiki to fix it for now, though. :-0
[17:30:35] <MatmaRex>	 James_F: or maybe you should do that
[17:30:42] <MatmaRex>	 James_F: it's a workaround fix for VE
[17:32:21] <James_F>	 MatmaRex: It's been in gerrit since May; a few more hours for Krinkle to come back online won't hurt.
[17:33:32] <gerrit-wm_>	 New review: Demon; "I can't figure out how to merge this. I granted myself +2 on the All-Projects acl but I'm only seein..." [All-Projects] (refs/meta/config) - https://gerrit.wikimedia.org/r/71173
[17:34:35] <qgil>	 superm401, hi, are we having the gsoc meeting now?
[17:34:56] <superm401>	 qgil, yep, are you okay with using Skype instead?
[17:35:06] <qgil>	 superm401, sure
[17:35:16] <qgil>	 quimgil there, give 1 sec to connect
[17:35:40] <superm401>	 Me too
[17:35:55] <qgil>	 superm401, connected
[17:36:23] <qgil>	 superm401, rahul and mdale are also aware?
[17:36:40] <gerrit-wm_>	 New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112
[17:38:23] <qgil>	 superm401, er... should I wait to be invited? Rahul has contacted me there.
[17:38:38] <gerrit-wm_>	 New patchset: Bsitu; "Fix two typos + one js integer casting" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71643
[17:39:21] <superm401>	 qgil, you can dial, or I can, up to you.
[17:39:27] <superm401>	 I haven't heard from mdale about the meeting.
[17:39:36] <superm401>	 I'm assuming he's not going to make it.
[17:39:57] <qgil>	 superm401, what is your handler?
[17:40:14] <superm401>	 qgil, handler?
[17:40:18] <qgil>	 skype
[17:40:28] <superm401>	 matthewflaschen
[17:40:58] <gerrit-wm_>	 New patchset: Wikinaut; "code cosmetics: changing from Xml to Html class in most cases" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/70671
[17:43:09] <gerrit-wm_>	 New patchset: Bsitu; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[17:43:11] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71643
[17:49:38] <gerrit-wm_>	 New patchset: Bsitu; "Adding support for primary links in notification" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/69964
[17:53:32] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/69964
[17:55:20] <gerrit-wm_>	 New patchset: Zfilipin; "Run "Open Language selector" scenario at test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71646
[17:55:33] <gerrit-wm_>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[17:56:07] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[17:56:36] <gerrit-wm_>	 New patchset: Zfilipin; "Run "Open Language selector" scenario at test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71646
[17:56:55] <gerrit-wm_>	 New patchset: Zfilipin; "Run "Open Language selector" scenario at test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71646
[18:00:12] <gerrit-wm_>	 New patchset: Mwalker; "Apparently Civi only likes names 64 Chars or Less" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71650
[18:02:33] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71396
[18:02:33] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71165
[18:04:22] <gerrit-wm_>	 New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172
[18:05:10] <gerrit-wm_>	 New review: Karima Rafes; "So I have to install by default visual editor in Vagrant. No ?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[18:07:30] <gerrit-wm_>	 New patchset: Zfilipin; "Use Tempfile to manage temporary test images" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71516
[18:08:26] <gerrit-wm_>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71646
[18:08:59] <gerrit-wm_>	 New review: CSteipp; "Agree with Tim. I still still think there's plenty of controller logic in the User class, but making..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876
[18:14:46] <gerrit-wm_>	 New patchset: Bsitu; "Update Echo, GettingStarted, PageTriage and Thanks to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71653
[18:14:53] <MatmaRex>	 what the hellis taking gerrit s omuch time when it's loading a diff
[18:15:15] <MatmaRex>	 and what the hellis it doing client-side to consume s omuch processor power
[18:17:33] <gerrit-wm_>	 New patchset: MarkTraceur; "Add .gitreview" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71654
[18:17:38] <marktraceur>	 GorillaWarfare: ^^
[18:17:40] <marktraceur>	 WFM
[18:18:05] <marktraceur>	 GorillaWarfare: What version of git-review are you running?
[18:18:20] <marktraceur>	 e.g. I have 1.22
[18:18:25] <marktraceur>	 See git-review --version
[18:18:45] <GorillaWarfare>	 Oh, sorry, was focusing on my other screen :P
[18:18:46] <GorillaWarfare>	 Sec
[18:19:09] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71653
[18:19:20] <GorillaWarfare>	 marktraceur: 1.22
[18:19:25] <gerrit-wm_>	 New review: Matmarex; "Eh, please don't rebase while making other changes, it makes it a lot harder to compare subsequent p..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166
[18:19:58] <marktraceur>	 ...sigmh
[18:20:01] <marktraceur>	 sigh
[18:20:21] <MatmaRex>	 Nikerabbit: you there?
[18:20:36] <gerrit-wm_>	 New patchset: Kaldari; "Bug 49269: Echo markup adjustments" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[18:20:43] <MatmaRex>	 Nikerabbit: is it even possible to directly edit MessagesXx.php files in core, or would such changes get silently overwritten on l10n update?
[18:21:01] <MatmaRex>	 Nikerabbit: i'm wondering whether to +2 or -2 https://gerrit.wikimedia.org/r/#/c/44397/ ;)
[18:21:10] <marktraceur>	 GorillaWarfare: Well what the eff. Is it on GNU/Linux?
[18:21:21] <GorillaWarfare>	 Mhm, Debian
[18:21:33] <marktraceur>	 Sigh.
[18:24:17] <Nikerabbit>	 MatmaRex: there is a change that they would get overriden
[18:24:50] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71522
[18:25:21] <MatmaRex>	 Nikerabbit: chance* ?
[18:25:33] <MatmaRex>	 how can there be a chance and not certainty either way? :P
[18:26:19] <Nikerabbit>	 MatmaRex: chance
[18:26:39] <Nikerabbit>	 MatmaRex: it depends whether Raymond imports those or not and what happens in the wiki
[18:26:53] <MatmaRex>	 Nikerabbit: ah, hm.
[18:27:15] <MatmaRex>	 Nikerabbit: is it easier for raymond to import them than for someone to manually copy them over? :)
[18:28:13] <Nikerabbit>	 MatmaRex: it would be nice for Raymond to copy these over
[18:29:31] <gerrit-wm_>	 New review: Zfilipin; "I do not think so, this commit should make the test work for both cases, when visual editor is the d..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044
[18:29:51] <Raymond_>	 MatmaRex, Nikerabbit now that I know this patch set it's ok to merge it :)
[18:30:03] <Raymond_>	 I will handle it as import
[18:30:06] <MatmaRex>	 Raymond_: it's dependent on unmerged one right now
[18:31:23] <MatmaRex>	 Raymond_: can you somehow mark it so you'll get notified when it merged? i can;t guess your gerrit username, apparently
[18:31:33] <MatmaRex>	 or i'd add you as a reviwer
[18:31:42] <gerrit-wm_>	 New review: Raimond Spekking; "♦" [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/44397
[18:31:57] <Raymond_>	 MatmaRex: done... wtf. ♦????
[18:32:06] <Raymond_>	 ignore it
[18:32:15] <^d>	 I figured you did that on purpose :p
[18:32:29] <Raymond_>	 no :P
[18:32:41] <Nemo_bis>	 MatmaRex: you have to use the i, not the y
[18:33:11] <Nemo_bis>	 (name and not nickname)
[18:33:29] <MatmaRex>	 ah, alright, thanks Nemo_bis
[18:33:37] <MatmaRex>	 and thanks Raymond_
[18:33:51] <Raymond_>	 MatmaRex: you are welcome
[18:36:41] <gerrit-wm_>	 New patchset: Kaldari; "Bug 49269: Echo markup adjustments" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[18:37:22] <gerrit-wm_>	 New review: Hashar; "You want to ping Asher "binasher" or Peter "notpeter" since its db related :-)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468
[18:38:05] <YuviPanda>	 Nikerabbit: ULS to enwiki today?
[18:38:19] <Nemo_bis>	 YuviPanda: already done
[18:38:23] <YuviPanda>	 oh
[18:38:35] <Nemo_bis>	 check your gears
[18:38:37] <MatmaRex>	 and it already has a VPT thread ~
[18:38:38] <YuviPanda>	 i'm not getting it yet
[18:39:02] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[18:40:31] <gerrit-wm_>	 New review: CSteipp; "Should it add a warning (wfDebugLog) when ccnorm is used but Antispoof isn't available? Since it use..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[18:42:57] <gerrit-wm_>	 New patchset: Matmarex; "Show detailed errors for bad titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166
[18:44:08] <gerrit-wm_>	 New patchset: Zfilipin; "Use temp folder to manage temporary test images" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71516
[18:44:19] <gerrit-wm_>	 New patchset: Zfilipin; "Use temp folder to manage temporary test images" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71516
[18:44:27] <gerrit-wm_>	 New patchset: Mollywhite; "Initializing repository with BookManagerv2 files. Files taken from https://github.com/mollywhite/BookTest" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71655
[18:45:17] <GorillaWarfare>	 ^ marktraceur :D
[18:45:30] <marktraceur>	 Yaaay!
[18:46:40] <Nikerabbit>	 MatmaRex: yeah that's what I needed to finish my day
[18:47:26] <Nemo_bis>	 those threads always come up after workday ends :)
[18:47:34] <YuviPanda>	 marktraceur: i'm going to head to sleep early today (now). Do leave comments, though :)
[18:47:50] <marktraceur>	 YuviPanda: I know I know
[18:49:12] <ori-l>	 Nikerabbit: there's a bug in your latest EL for ULS patch; I haven't had the chance yet to write it up in a review comment. Would you like me to update the patch w/a fix or just note it in a comment?
[18:50:05] <gerrit-wm_>	 New review: Mollywhite; "Initializing repo with code from https://github.com/mollywhite/BookTest" [mediawiki/extensions/BookManagerv2] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/71655
[18:50:06] <gerrit-wm_>	 Change merged: Mollywhite; [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71655
[18:53:53] <gerrit-wm_>	 New review: Mollywhite; "Superseded by patchset <Ic166be026df5d9e97a8b8e5ab8304727aa7b4c57>" [mediawiki/extensions/BookManagerv2] (master) - https://gerrit.wikimedia.org/r/71654
[18:56:50] <gerrit-wm_>	 New review: Nischayn22; "May be fix this at other places in the same commit?" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71581
[18:57:08] <gerrit-wm_>	 New review: Tpt; "Some details." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1;  - https://gerrit.wikimedia.org/r/71172
[18:59:21] <gerrit-wm_>	 New review: QChris; "Do you still have +2 granted?" [All-Projects] (refs/meta/config) - https://gerrit.wikimedia.org/r/71173
[19:00:19] <gerrit-wm_>	 New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[19:03:43] <gerrit-wm_>	 New patchset: Yuvipanda; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446
[19:03:57] <gerrit-wm_>	 New patchset: Ladsgroup; "Some settings and an imporved font for Persian, removing Amiri font for Persian and adding "system" option per bug 49957" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71658
[19:05:43] <gerrit-wm_>	 New review: Bsitu; "Why do we merge this during the deployment window?  We are done testing Echo on testwiki, now I see ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[19:06:56] <gerrit-wm_>	 New patchset: Ori.livneh; "Manage configuration fragments in rc.d-like dir" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71659
[19:08:00] <legoktm>	 hoo:  Catchable fatal error: Argument 1 passed to AbuseFilter::getEmergencyValue() must be of the type array, double given, called in /var/www/mediawiki/extensions/AbuseFilter/AbuseFilter.class.php on line 1521 and defined in /var/www/mediawiki/extensions/AbuseFilter/AbuseFilter.class.php on line 1562
[19:08:23] * hoo  takes a look

[19:08:31] <legoktm>	 haven't had time to debug, but that just randomly started showing up on a 3rd-party wiki i help run
[19:08:47] <legoktm>	 which is on 1.21
[19:09:37] <legoktm>	 that shows up for any abusefilter hit
[19:09:47] <gerrit-wm_>	 New review: Rtdwivedi; "I would prefer $header, $body, $footer as it fits with the structure of a page. @Tpt: What do you th..." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172
[19:10:06] <gerrit-wm_>	 New review: LivingShadow; "I'm sure that many people would benefit from it! :D" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/71074
[19:11:23] <gerrit-wm_>	 New patchset: Bsitu; "Update Echo, GettingStarted, PageTriage and Thanks to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71663
[19:12:02] <hoo>	 legoktm: Probably the configuration of that wiki is flawed
[19:12:16] <hoo>	 or outdated
[19:12:31] <legoktm>	 erp. lemme pm you what i have set up for AF configuration
[19:13:41] <hoo>	 k
[19:15:04] <gerrit-wm_>	 New review: Matmarex; "A few more brief comments, I'm not done yet. I've got a feeling you didn't actually run thecode. :/" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/43166
[19:15:35] <gerrit-wm_>	 Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71663
[19:17:03] <gerrit-wm_>	 New review: Katie Horn; "(1 comment)" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71650
[19:20:26] <gerrit-wm_>	 New patchset: Mwalker; "Apparently Civi only likes names 64 Chars or Less" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71650
[19:22:38] <epoc>	 hi
[19:22:56] <epoc>	 Hello browser testers
[19:23:22] <gerrit-wm_>	 Change merged: Katie Horn; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71650
[19:25:15] <gerrit-wm_>	 New patchset: Matmarex; "ChangesList mode information as CSS class on Special:Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71705
[19:26:04] <gerrit-wm_>	 New review: Matmarex; "Superseded by https://gerrit.wikimedia.org/r/71705" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70540
[19:27:23] <liangent>	 MatmaRex: I have an unclear memory that you commented some line of my code about a failed unit test?
[19:28:28] <gerrit-wm_>	 New review: Parent5446; "Looks like a good idea." [mediawiki/vagrant] (master) C: 1;  - https://gerrit.wikimedia.org/r/71659
[19:29:28] <MatmaRex>	 liangent: i commented on the redirect contenthandler stuff, yeah, not about tests in particular, though
[19:29:47] <chrismcmahon>	 epoc browser testers?
[19:43:47] <gerrit-wm_>	 New review: Tpt; "@Aarti It's fine for me." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172
[19:50:43] <gerrit-wm_>	 New patchset: Hoo man; "Make AbuseFilter work without AntiSpoof" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[19:52:06] <gerrit-wm_>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71708
[19:52:17] <gerrit-wm_>	 New review: Hoo man; "Use wfDebugLog in case ccnorm is used but AntiSpoof isn't installed. (I'm not sure anyone is really ..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[19:54:25] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71572
[19:58:19] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:02:05] <gerrit-wm_>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71708
[20:10:52] <MatmaRex>	 hoo|away: hmmm
[20:11:04] <MatmaRex>	 hoo|away: are you sure thecondition in https://gerrit.wikimedia.org/r/#/c/70583/8/Views/AbuseFilterViewEdit.php does the trick?
[20:11:37] <MatmaRex>	 hoo|away: once could create any message like mediawiki:abusefilter-warning-whatever and choose that in the selector, and it'd work
[20:11:50] <MatmaRex>	 hoo|away: and i'm not sure what is the intended behavior in this case
[20:12:02] <MatmaRex>	 csteipp: or maybe you can answer this? ^
[20:16:44] <csteipp>	 MatmaRex: Yeah, that probably is the case
[20:17:16] <MatmaRex>	 csteipp: so you want to allow custom messages, but not custom arbitrary messages?
[20:17:58] <csteipp>	 MatmaRex: We only want to allow messages that are actual Messages, with translations
[20:18:24] <csteipp>	 I think I was going to also limit the selection process and left that part out
[20:18:38] <MatmaRex>	 csteipp: i can create [[mediawiki:abusefilter-warning-whatever]] and have it show up in that selector and be selectable
[20:18:55] <MatmaRex>	 the only actual Message is 'abusefilter-warning' itself afaik
[20:19:00] <csteipp>	 Yep. I forgot to limit that part
[20:19:34] <MatmaRex>	 csteipp: so imo it should be`!= 'abusefilter-warning'`
[20:20:02] <MatmaRex>	 unless you plan to add more of these messages, or maybe create them via WikimediaMessages and somehow hook it in there :)
[20:20:26] <csteipp>	 MatmaRex: We are planning to add more messages, but to start with that would wor
[20:20:27] <csteipp>	 work
[20:20:46] <ori-l>	 chrismcmahon: željko's link to the tmpdir test (<https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/182/>) 404s for me -- do you know where it should be pointing?
[20:21:59] <gerrit-wm_>	 New review: CSteipp; "MatmaRex pointed out I forgot to limit the messages. It's possible to add MediaWiki:abusefilter-warn..." [mediawiki/extensions/AbuseFilter] (master) C: -1;  - https://gerrit.wikimedia.org/r/70583
[20:22:51] <chrismcmahon>	 ori-l: yeah, it's backed up in Jenkins right now https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/
[20:23:02] <gerrit-wm_>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71715
[20:23:39] <chrismcmahon>	 ori-l: sorry, we have a ton of red builds right now and merged a ton of changes today too
[20:23:42] <gerrit-wm_>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71715
[20:23:50] <ori-l>	 chrismcmahon: no worries at all
[20:24:09] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:25:31] <gerrit-wm_>	 New review: Matmarex; "Yeah, apart from that and the quick note on JS it looks good." [mediawiki/extensions/AbuseFilter] (master) C: -1;  - https://gerrit.wikimedia.org/r/70583
[20:31:48] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:33:10] <gerrit-wm_>	 New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71717
[20:33:34] <gerrit-wm_>	 Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71717
[20:37:26] <MatmaRex>	 ori-l: did you mean to add me as a reviwer on https://gerrit.wikimedia.org/r/#/c/71659/ , or did you want someone else? i really have no idea how that stuff works
[20:37:41] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:39:06] <ori-l>	 MatmaRex: Yeah, I'm interested in feedback about how comfortable a setup it is (globbing LocalSettings fragments from an rc.d-style directory); I added a bunch of people for that reason. You can remove yourself if you don't have an opinion either way.
[20:40:19] <MatmaRex>	 ori-l: i don't even know what rc.d is :)
[20:40:40] <gerrit-wm_>	 New patchset: Hashar; "test word boundaries in devanagari words" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71718
[20:41:00] <MatmaRex>	 ori-l: but you're missing a comma after glob( __DIR__ . '/settings.d/*.php' )
[20:41:48] * ori-l  quickly removes MatmaRex as reviewer

[20:41:58] <ori-l>	 j/k, thanks for spotting that :)
[20:41:58] <MatmaRex>	 :D
[20:43:28] <MatmaRex>	 ori-l: i really have no idea what to think about that change apart from that
[20:44:09] <MatmaRex>	 thanks for asking, but i'm rather useless here :)
[20:44:15] <ori-l>	 no worries
[20:49:43] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:54:42] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[20:58:29] <gerrit-wm_>	 New patchset: Ori.livneh; "Manage configuration fragments in rc.d-like dir" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/71659
[21:05:23] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #25: FAILURE in 6 min 52 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/25/
[21:06:17] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[21:06:47] <gerrit-wm_>	 New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[21:11:21] <gerrit-wm_>	 New review: Liangent; "A note about that test issue:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272
[21:11:31] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #123: FAILURE in 6 min 8 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/123/
[21:14:45] <MatmaRex>	 hey hashar
[21:14:54] <hashar>	 bed time sorry
[21:15:03] <MatmaRex>	 hashar: but the tests are all messed up!
[21:15:04] <hashar>	 just reading some news and forgot to shutdown irc! hehe
[21:15:10] <hashar>	 which ?
[21:15:13] <marktraceur>	 MatmaRex: Classic mistake, pinging hashar is a sure way to get him to leave
[21:15:16] <MatmaRex>	 (overexaggerating, sorry :P)
[21:15:22] <MatmaRex>	 hashar: see last comment on https://gerrit.wikimedia.org/r/#/c/71272/
[21:15:45] <MatmaRex>	 marktraceur: haha
[21:15:59] <hashar>	 feel free to fill a bug about it against wikimedia > continuous integration
[21:15:59] <hashar>	 :)
[21:16:31] <marktraceur>	 Bug 50124, hashar needs to work 16 hours a day
[21:16:31] <gerrit-wm_>	 New patchset: Jqnatividad; "Added "cache seconds" parameter to #get_web_data to add per query cache settings. Some APIs are fairly static (e.g. Wikipedia places) and some are very dynamic (e.g. Craiglists listings) and having one global cache expire time was insufficient." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71722
[21:16:42] <hashar>	 MatmaRex: seems like a race condition between some tests
[21:16:50] <hashar>	 marktraceur: yeah I need to work less :)
[21:17:23] <hashar>	 I am off now.  Have fun everyone :-]
[21:18:03] <MatmaRex>	 we clearly have too few bugs, don't we
[21:18:20] <MatmaRex>	 liangent: feel like filing another? because i should go to sleep as well
[21:18:56] <liangent>	 MatmaRex: another for what?
[21:19:13] <MatmaRex>	 liangent: your test issues. see hashar's comments above :)
[21:20:24] <gerrit-wm_>	 New patchset: Hoo man; "Prevent custom warning messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583
[21:20:27] <gerrit-wm_>	 New patchset: Bsitu; "Title diff links should not include any fragment" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71723
[21:20:40] <gerrit-wm_>	 New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583
[21:22:03] <gerrit-wm_>	 New review: Hoo man; "Fixed a JS style flaw and fixed the condition in AbuseFilterViewEdit. Thanks for the code review Chr..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583
[21:23:24] <wmf-selenium-bot>	 Yippie, build fixed!
[21:23:24] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #115: FIXED in 7 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/115/
[21:24:46] <gerrit-wm_>	 New patchset: Rachel99; "WIP VE links" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71724
[21:27:24] <epoc>	 Hi I am a noob. I seen on http://www.mediawiki.org/wiki/QA/Browser_testing/Search_features that I would be able to give a hand on browser testing mediawiki. Is this possible?
[21:27:54] <marktraceur>	 epoc: Hey, don't worry about being new, we're all new at one point :)
[21:28:15] <epoc>	 oh cool thanks. How can I help out here?
[21:28:15] <marktraceur>	 And it's totally possibly to help the QA team with that. chrismcmahon, any specific input or direction for epoc?
[21:28:36] <chrismcmahon>	 hi epoc
[21:28:42] <epoc>	 Hi
[21:30:48] <chrismcmahon>	 epoc: do you have any particular interests?  you might want to join the QA mail list and introduce yourself there https://lists.wikimedia.org/mailman/listinfo/qa
[21:36:16] <epoc>	 Ok I have subscribed to that mailing list. I have an interest in general QA/testing or development. Any way I can help out
[21:41:32] <gerrit-wm_>	 New review: Matmarex; "Well, let's do this then." [mediawiki/extensions/AbuseFilter] (master) C: 2;  - https://gerrit.wikimedia.org/r/70583
[21:41:36] <MatmaRex>	 hoo: ^
[21:41:38] <MatmaRex>	 csteipp: ^
[21:41:53] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583
[21:43:15] <csteipp>	 MatmaRex: Thanks!
[21:45:58] <chrismcmahon>	 epoc:  send a message to the mail list introducing yourself and mention your interests
[21:57:27] <gerrit-wm_>	 New review: Bsitu; "This change needs to reverted or updated" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[22:01:26] <gerrit-wm_>	 New patchset: MarkTraceur; "Add an additional DonationInterface job" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71726
[22:04:53] <gerrit-wm_>	 New patchset: MarkTraceur; "Adding DonationInterface test runner" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71727
[22:05:20] <gerrit-wm_>	 New review: Bsitu; "I will revert this for now since this will create display issue to some browser" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71523
[22:05:25] <gerrit-wm_>	 New patchset: Katie Horn; "Removing half a file of css redefinitions for the adyen form" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71728
[22:07:19] <gerrit-wm_>	 New patchset: Bsitu; "Revert "Bug 49269: Echo markup adjustments"" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71729
[22:08:03] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71728
[22:08:06] <gerrit-wm_>	 New patchset: Bsitu; "Revert "Render dates as headings"" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71730
[22:09:24] <gerrit-wm_>	 New review: MarkTraceur; "Jenkins, you be trippin'." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71726
[22:09:24] <gerrit-wm_>	 Change merged: MarkTraceur; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71726
[22:11:45] <gerrit-wm_>	 Change merged: Bsitu; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71729
[22:13:28] <gerrit-wm_>	 New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71723
[22:14:45] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71730
[22:18:38] <marktraceur>	 Note, I reloaded zuul to deploy a config change, let me know if there's nastiness going on
[22:19:01] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/71723
[22:19:08] <gerrit-wm_>	 New patchset: MarkTraceur; "Adding DonationInterface test runner" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71727
[22:20:02] <gerrit-wm_>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71732
[22:21:50] <gerrit-wm_>	 New review: MarkTraceur; "You're wrong on this one, Jenkins, but it's only because you didn't try hard enough." [mediawiki/extensions/DonationInterface] (master) C: 2;  - https://gerrit.wikimedia.org/r/71732
[22:24:47] <hoo>	 MatmaRex: Thanks :)
[22:24:58] <hoo>	 And yes, we tested that (at least I did)
[22:30:01] <gerrit-wm_>	 New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71733
[22:30:39] <gerrit-wm_>	 Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71733
[22:34:52] <MatmaRex>	 hoo: :)
[22:40:18] <gerrit-wm_>	 New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71734
[22:41:06] <gerrit-wm_>	 Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71734
[22:43:24] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71591
[22:45:35] <gerrit-wm_>	 New review: Hoo man; "(1 comment)" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/64365
[22:46:00] <hoo>	 MatmaRex: ^ There's your reward :D
[22:48:11] <MatmaRex>	 hoo: haha, thanks
[22:48:23] <gerrit-wm_>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365
[22:52:09] <wmf-selenium-bot>	 Project _debug-browsertests-template build #182: FAILURE in 1.1 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/182/
[22:59:48] <gerrit-wm_>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[23:00:31] <gerrit-wm_>	 New review: MarkTraceur; "If this passes, not only will I eat my hat^W^Wdinner later, I'll also revert it right quick." [mediawiki/extensions/DonationInterface] (master) C: 2;  - https://gerrit.wikimedia.org/r/71737
[23:01:07] <GorillaWarfare>	 Lol
[23:02:20] <marktraceur>	 GorillaWarfare: Hey, it *did* fail
[23:05:05] <gerrit-wm_>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[23:06:04] <kflorence>	 this looks kinda bad: https://www.dropbox.com/s/kcfshm9msn2bsyl/Screenshot%20from%202013-07-02%2015%3A59%3A46.png
[23:07:03] <MatmaRex>	 heh
[23:07:16] <MatmaRex>	 donation guys are the worst
[23:07:33] <MatmaRex>	 but their messups are the funniest
[23:19:45] <gerrit-wm_>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[23:27:02] <Ryan_Lane>	 Krinkle, RoanKattouw, James_F: looks like you guys hit slashdot: http://news.slashdot.org/story/13/07/02/2135223/wikimedia-rolls-out-its-wysiwyg-visual-editor-for-logged-in-wikipedia-users
[23:27:20] <RoanKattouw>	 Nice :)
[23:28:11] <James_F>	 Ryan_Lane: All three users of it. :-)
[23:28:18] <Ryan_Lane>	 :)
[23:28:43] <MatmaRex>	 "Lowering the barrier for contributing............. will ensure more user edits will never see the light of day! More contributions and a lower percentage of them getting through the winding colon of wikipolitics. It sounds like everyone wins!"
[23:28:44] <MatmaRex>	 what.
[23:29:12] <MatmaRex>	 it seems like these guys have enough imaginary issues to discuss not to notice real ones!
[23:29:14] * MatmaRex  rejoices

[23:33:41] <TimStarling>	 why does gerrit keep freezing?
[23:34:25] <TimStarling>	 https://gerrit.wikimedia.org/r/#/c/69971/ is completely reproducible
[23:34:37] <TimStarling>	 I go there, it freezes with a "working..." message
[23:34:45] <TimStarling>	 I enable firebug, reload, it works
[23:34:54] <TimStarling>	 disable firebug, reload, doesn't work
[23:34:57] <hoo>	 TimStarling: It's broken in Firefox for days now
[23:35:02] <TimStarling>	 enable firebug, works again
[23:35:19] <hoo>	 wow, it really works with firebug :P
[23:35:25] <TimStarling>	 some pages do
[23:35:36] <TimStarling>	 other pages freeze with firebug and work with it off
[23:35:55] <p858snake|l>	 TimStarling: its a "random" issue w/ firefox users that ^d is having trouble tracking down afaik
[23:36:12] <TimStarling>	 like I say, it doesn't seem very random at the moment
[23:36:32] <^d>	 TimStarling: Logging out/in helps for some people, adding dbg=1 to the URL is a crappy workaround.
[23:36:43] <^d>	 Christian and I are really trying to find the cause, we know it's annoying.
[23:36:50] <TimStarling>	 you mean dbg=1 also fixes it?
[23:36:54] <TimStarling>	 in addition to enabling firebug?
[23:37:07] <TimStarling>	 are there any other debugging tools that also fix it? ;)
[23:37:31] <^d>	 No clue, but dbg=1 is gerrit's "use the expanded JS rather than the minified obfuscated gwt crap"
[23:37:37] <hoo>	 the firefox web console debug thingy doesn't fix it :P
[23:39:03] <TimStarling>	 yes, dbg=1 does indeed fix it
[23:39:33] <TimStarling>	 so the challenge then is to debug the problem in minified mode with no firebug
[23:40:13] <hoo>	 TimStarling: Easy one
[23:40:32] <hoo>	 but I don't really know what the errors want to tell me :P
[23:40:46] <^d>	 Yes, indeed. I tried doing a thread dump to see if the JVM was hanging on something, but nothing was interesting.
[23:40:56] <hoo>	 http://p.defau.lt/?faVzE84oUfpi2pV2BkBGdQ
[23:41:11] <TimStarling>	 yeah, I was about to paste the same thing
[23:41:20] <Krinkle>	 TimStarling: sent you and Aaron an e-mail about LinksUpdate, could you check it out soon? It is currently causing lots of issues with TemplateData which is getting rather prime time appearance now that VE is enabled. This is blocking further deployment of VE.
[23:41:28] <Krinkle>	 Thanks :)
[23:41:38] <gerrit-wm_>	 New patchset: EBernhardson; "Make wfForeignMemcKey consistent with wfMemcKey" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71740
[23:41:45] <^d>	 hoo: Yeah, that's the obfuscated gwt mess...which is impossible to debug from.
[23:42:10] <TimStarling>	 not impossible, just difficult
[23:42:31] <gerrit-wm_>	 New patchset: CSteipp; "(WIP) Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/71741
[23:42:38] <gerrit-wm_>	 New patchset: MarkTraceur; "Dummy commit for Jenkins to trip on" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/71737
[23:42:39] <TimStarling>	 it should be easier than debugging machine code
[23:43:11] <gerrit-wm_>	 New patchset: CSteipp; "(WIP) Redirect to correct protocol in SUL2" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/71741
[23:43:17] <^d>	 Possibly, but I'm kind of out of ideas so far.
[23:43:54] <ori-l>	 I poked at it the other day. The null object is supposed to be something representing the changeset. The expression that is triggering the error is a.changeId() or something like that.
[23:44:06] <ori-l>	 Didn't get farther than that.
[23:45:05] <hoo>	 ori-l: Usual step than is to add some debug mess code in a local test instance
[23:45:13] <hoo>	 I don't have one, so I can't do anything :P
[23:45:21] <TimStarling>	 Krinkle: I've never heard of TemplateData
[23:45:25] <Elsie>	 Vagrant!
[23:45:51] <Elsie>	 TimStarling: https://www.mediawiki.org/wiki/Extension:TemplateData
[23:46:03] <Krinkle>	 TimStarling: it's a small extension that grew out of VisualEditor, done separately to keep it generic and re-usable
[23:46:45] <Krinkle>	 TimStarling: Basically what it does is take a JSON blob given to it from <templatedata> in wikitext and (after validation)  sticks it into page properties for retrieval from the API and usage in VisualEditor.
[23:46:56] <^d>	 ori-l: Any stacktrace that got you that far? changeId is a difficult place to start grepping.
[23:47:53] <Krinkle>	 TimStarling: Since people tend to like putting things on /doc instead of the main template for various reasons (performance of purges for doc of high-visible template, different protection levels etc.), we're hitting a bug where the page properties aren't being updated.
[23:48:04] <Elsie>	 Does #dbq=mode or whatever disable the obfuscation?
[23:48:10] <Krinkle>	 looks like LinksUpdate is either broken or apparently has a performance feature we need to disable.
[23:48:29] <Krinkle>	 See mail and referred 2 bugs for more details.
[23:48:34] <^d>	 Elsie: Yes, but it also causes the bug to no longer happen.
[23:49:02] <Elsie>	 :-(
[23:49:16] <TimStarling>	 the templatedata is on the /doc page?
[23:49:52] <Krinkle>	 TimStarling: Yes, it can be (doesn't have to be, but on en.wiki they do so our wmf-operations' advice from 2007/2008 afaik)
[23:50:06] <Krinkle>	 on*
[23:50:07] <^d>	 Elsie: I'm still pretty convinced something's being cached somewhere that shouldn't be, considering it's not reproducable on all changes (or for all people) and sometimes resolves after doing things like logging out or closing your browser.
[23:50:19] <^d>	 I was pretty sure flushing all of gerrit's on-disk caches would've cleared it, but not so.
[23:50:32] <Elsie>	 Lame.
[23:50:42] <Krinkle>	 e.g. avoid edits to the template page that result in purging millions of page.
[23:51:00] <TimStarling>	 page_props won't be updated until the refreshLinks job runs
[23:51:01] <Krinkle>	 so instead they put it on /doc and transclude it in <noinclude> on the template page so we only have to purge 1 page.
[23:51:24] <Krinkle>	 TimStarling: Where does that logic of not updating page_props and links tables reside/
[23:52:02] <TimStarling>	 it is implicit in the design
[23:52:15] <Krinkle>	 These are SecondaryDataUpdates updates, right?
[23:52:37] <Elsie>	 ^d: I continually wonder if Gerrit is more benefit than cost.
[23:52:39] <Krinkle>	 I've followed the code, but I can't find where it makes the decision not to run those for transcluding pages.
[23:53:35] <Krinkle>	 TimStarling: I see it runs them for the edited page, and then schedules a RefreshLinks2 job that does it recursively for pages transcluding the edited one.
[23:53:38] <Elsie>	 ^d: Though it seems better lately. I like the auto-expand comments.
[23:53:41] <TimStarling>	 SecondaryDataUpdates is to update the links of the page that is being edited
[23:53:44] <^d>	 Elsie: It's incrementally less bad than before :)
[23:53:47] <Elsie>	 Right.
[23:54:05] <TimStarling>	 i.e. the /doc subpage
[23:54:09] <Krinkle>	 Yes
[23:54:53] <Krinkle>	 https://github.com/wikimedia/mediawiki-core/blob/master/includes/WikiPage.php#L2072-L2076
[23:55:04] <Krinkle>	 and it passes 'true' which makes it schedule the jobs to do it recursively.
[23:55:13] <Krinkle>	 RefreshLinks2
[23:55:23] <TimStarling>	 so what is your problem?
[23:55:32] <Krinkle>	 This is e.g. what balloons our job queue when people edit Infobox.
[23:55:44] <TimStarling>	 btw I have a meeting in 5 minutes
[23:56:01] <Krinkle>	 TimStarling: My problem is, what makes that job not update page_props but do something else only, and what is that something else that it does do?
[23:56:48] <TimStarling>	 so your problem is with the job queue, not SecondaryDataUpdates?
[23:56:54] <TimStarling>	 and not LinksUpdate?
[23:57:28] <Krinkle>	 Well, no, not really. The job to refresh links recursively calls LinksUpdate and getSecondaryDataUpdates(recursive=false)
[23:57:38] <Krinkle>	 but sure, the job queue
[23:57:59] <TimStarling>	 and you are sure that the relevant job has been executed?
[23:58:21] <Krinkle>	 are you sure the job queue will balloon if a highly visible template is edited?
[23:58:36] <Krinkle>	 I haven't checked it personnally no, I assume this logic is not disabled since last year.
[23:58:37] <Krinkle>	 Has it?
[23:58:39] <^d>	 Rebooting manganese: gerrit's gonna be unavailable for a few.
[23:58:45] <TimStarling>	 yes, of course it does
[23:58:49] <Krinkle>	 OK
[23:59:06] <Krinkle>	 We blow it full of refreshLinks jobs, right? What does that jobs do?
[23:59:14] <TimStarling>	 we have techniques in place to make sure the actual job queue size is limited, but it still does the same amount of work as it always has
[23:59:44] <Krinkle>	 TimStarling: yeah, though the limit can't be the cause in this case since /doc is never transcluded more than 1 or 2 times.
[23:59:45] <TimStarling>	 you should talk to Aaron|home about this, he doesn't have a meeting starting right now
[23:59:51] <Krinkle>	 k