[00:06:34] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/71276 [00:06:39] Change merged: Siebrand; [mediawiki/extensions/Comments] (master) - https://gerrit.wikimedia.org/r/67255 [00:07:38] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Premoderation] (master) C: -1; - https://gerrit.wikimedia.org/r/70598 [00:08:03] New review: Siebrand; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) C: -1; - https://gerrit.wikimedia.org/r/70594 [00:12:43] New review: Yuvipanda; "Looks good to me. Tested to work (adding categories=blah|blaaah to the URL pre-fills them)." [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/71277 [00:13:07] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71277 [00:13:38] New review: Yuvipanda; "In hindsight, this could've used a better commit message :)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71277 [00:16:56] New patchset: Shirayuki; "Remove succes(s)fully" [mediawiki/extensions/Premoderation] (master) - https://gerrit.wikimedia.org/r/70598 [00:26:00] New patchset: Shirayuki; "Modify the message "ajaxpoll-vote-revoked"" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/70594 [00:56:32] New patchset: Rachel99; "WIP add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [01:00:42] New patchset: Jpond; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71310 [01:34:21] New patchset: Aaron Schulz; "[WIP] Added consumer request controllers." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/71156 [01:39:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71308 [01:42:25] New patchset: Alex Monk; "Set taborder for Special:ListFiles" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49595 [01:48:36] New patchset: Alex Monk; "Parse duplicate-defaultsort error message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [01:52:44] New patchset: Jpond; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258 [03:02:11] Project _debug-browsertests-template build #177: FAILURE in 1 min 18 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/177/ [03:23:21] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #172: FAILURE in 8 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/172/ [03:49:27] ori-l: So am I the only one who says an awful white background on the logo at https://wikitech.wikimedia.org/ ? [03:49:43] no, it's been driving me nuts [03:50:05] Hmmmm. [03:50:08] https://wikitech.wikimedia.org/wiki/File:Wikimedia_labs_logo.svg [03:50:08] the SVG logo has 'Wikimedia Labs' in it, so presumably ryan stop using it for that reason [03:50:16] It's using that logo. [03:50:21] But it doesn't seem like the file has changed. [03:50:33] > Used as $wgLogo on this wiki. Embedding here since this wiki has no thumb-404 handler: [03:54:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=49373 [04:19:26] Project browsertests-en.wikipedia.org-linux-firefox build #146: FAILURE in 3 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/146/ [04:41:17] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #112: FAILURE in 6 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/112/ [05:18:23] New review: Springle; "+1 on Parent5446's suggestion of a surrogate primary key. It may also simplify joins if you discover..." [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/70794 [06:07:16] New patchset: Tim Starling; "Add a script for fast integration testing during scap" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/71318 [06:50:44] New review: Daniel Kinzler; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [07:16:51] New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [07:30:04] Ryan_Lane: I can't ssh to instance-proxy.pmtpa.wmflabs again. could you have a look [07:30:22] liangent: I can't right now [07:30:33] * hashar sends Ryan_Lane to bed :D [07:30:35] maybe in a little bit [07:30:46] liangent: btw, you had installed dnsmasq on that instance [07:30:58] Ryan_Lane: yeah [07:31:09] and it was being used for attacks. it's really important not to run unconfigured dns [07:31:34] how for attacks? [07:31:52] and what does 'unconfigured' mean [07:32:17] it had no configuration [07:32:24] it was just running as installed [07:32:44] it has a configuration to forward dns requests and override for some specific one [07:33:14] yeah. and it allowed anything on the internet to do so [07:33:19] and I didn't see any config for it at all [07:33:55] then what config is needed? [07:34:02] as a dns forwarder? [07:34:14] beside forwarding destination [07:34:20] hold on [07:38:06] liangent: so, yeah. it was used for an amplification attack [07:38:22] liangent: what's the need for forwarding dns requests? [07:38:29] the proxy works fine without it [07:39:25] that's not for proxy. it's something else [07:39:59] then it probably shouldn't be in that project ;) [07:40:03] what's it for? [07:40:04] some user reported that the default wikipedia ip has been blocked for ssl :/ [07:40:35] labs is in our ip ranges [07:40:40] Ryan_Lane: https://zh.greatfire.org/blog/2013/jun/wikimedia-foundation-says-it-doesnt-hold-chinese-readers-any-less-regard-we-disagree [07:40:43] and I'd really prefer that it not be used in tis way [07:41:21] DNS won't help with this [07:41:36] Ryan_Lane: it helps :p [07:41:41] how? [07:41:41] they don't block all ips [07:41:45] it doesn't change the IP [07:41:53] and resolving wikipedia.org to another ip works [07:42:14] to another IP being which IP? [07:42:28] you know all wikibooks/wikisource/wikixxx servers are able to serve wikipedia contents too [07:42:39] as long as it has a correct http Host header [07:42:47] ah. right. we serve a unified cert right now [07:42:55] you realize that's going to be changing right? [07:43:27] what's going to be changing [07:43:45] we're going to serve smaller certs and deliver them with SNI, and we'll have a fallback unified cert [07:44:13] we may not have those other IPs serving SSL, which means this doesn't help [07:44:13] I know nothing about it [07:44:40] well the blocking rule keeps changing too [07:44:44] also, why should we tell people to point at another DNS server, when they can just add entried to their hosts riles? [07:45:00] a game of cat and mouse isn't the right solution [07:45:08] Ryan_Lane: because wikipedia.org has hundreds of subdomains [07:45:16] Ryan_Lane: right [07:45:24] you should be telling people to use tor, to use open proxies, to use VPNs, etc [07:45:27] that's only for short term [07:45:47] I implemented because some other user ask me to do / talked with me about this [07:46:08] this is definitely the kind of thing you should ask about [07:47:02] it's definitely a little iffy from the terms of use point of view, since: 1. it's doing something for a production service, and 2. it's proxying something between networks [07:47:59] also, it's dangerous if done incorrecty (as we've encountered) [07:48:02] *incorrectly [07:48:45] well I didn't advertise it [07:49:00] btw open proxies are often blocked [07:49:17] they don't for reading [07:49:22] neither does tor [07:49:52] editors need it too [07:49:55] editors generally only edit a few wikis. they can modify their hosts [07:50:24] but really, they should get a VPN [07:50:38] Ryan_Lane: so they have to swap between http and https again and again [07:50:49] proxied and unproxied [07:51:32] the situation sucks, but there really isn't much we can do for them [07:53:18] Ryan_Lane: I know so I didn't really ask you (server admins) to do something [07:53:22] I've only tried what I can [07:53:29] the only reliable solution for editors is a VPN [07:53:34] * Ryan_Lane nods [07:53:46] make sure to ask before doing stuff like that, though [07:53:58] projects are created in labs with intended purposes [07:56:31] I could request another project for deal with government blocking issues, but it would waste another public ip [07:56:47] especially there aren't much services to host now [07:57:02] also, it would go against the ToU for probably anything you'd do [07:57:26] which ToU? [07:57:51] http://www.mediawiki.org/wiki/Wikimedia_Labs/Terms_of_use [07:57:57] ok [07:58:10] "Using Labs as a proxy between networks is not allowed." [07:58:31] page also says "This page is currently a draft." ;P [07:59:02] that one is somewhat up to interpretation, of course, because there's some legitimate stuff that's done that may fall within that definition [07:59:28] Nemo_bis: it hasn't been modified since 2 Nov 2012 [07:59:52] it's waiting on legal to clarify for the most part [08:00:10] the spirit of the ToU are very, very unlikely to change [08:01:06] forwarding DNS and modifying entries definitely falls under proxying between networks ;) [08:01:07] yes, I just asked which ToU because the general WMF ToU is board-approved and basically set in stone (for a few years), while this isn't and won't [08:01:57] I wouldn't be opposed to this also being board approved [08:02:18] or being included as a section of our general ToU, but that's up to legal [08:02:19] not me [08:06:54] tool lab replica db down now? [08:16:08] New review: Liangent; "What should I do if a test works on my box but fails on server?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [08:16:38] New patchset: Tpt; "Remove the node from the table of contents" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71321 [08:33:15] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [08:35:05] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [08:37:17] zeljkof: hey there :-] [08:37:30] zeljkof: just for your information, I have migrated beta text cache from squid to varnish [08:38:14] hashar: thanks for letting me know, but I have no idea what that means :) [08:38:21] ooops [08:38:34] so the cache keeps a copy of the text, to prevent all user requests to be send to the apaches [08:38:42] we used squid and are now using varnish [08:38:50] so there might be some configuration mistakes here and there [08:39:00] if the jenkins test fails, that might be related to it [08:39:05] ok, will open my eyes :) [08:40:53] New patchset: Tpt; "Remove the

node from the table of contents" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71321 [08:41:54] zeljkof: there will also be some slowness [08:41:57] due to the cache being cold [08:42:07] but luckily our spammers are going to help filling up the cache heh [08:42:14] New patchset: MathiasLidal; "Remove newline before final bracket" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/71323 [08:44:12] No submodule mapping found in .gitmodules for path 'extensions/Campaigns' [08:44:17] wtf? [08:45:55] Nikerabbit: I think that extension had an issue last week [08:45:58] we had a bug opened [08:47:13] Nikerabbit: https://bugzilla.wikimedia.org/show_bug.cgi?id=50261 [08:47:19] extension Campaigns (and some others?) not current on beta [08:49:11] Nikerabbit: I wrote a check-sync.sh script at the root of mediawiki/extensions.git , that pull and update all submodules then for each submodule check whether HEAD points to origin/master [08:49:14] Nikerabbit: running it rightnow [08:49:30] ERROR! Bootstrap is lagging behind. [08:49:31] ERROR! EImage is lagging behind. [08:49:33] ERROR! Less is lagging behind. [08:49:34] ERROR! PerPageLicense is lagging behind. [08:49:35] ERROR! VisualEditor is lagging behind. [08:49:36] :( [08:49:40] hashar: I can't update wmf8 branch locally :/ [08:58:16] New patchset: MathiasLidal; "Set correct default-value for offset" [mediawiki/extensions/SemanticMaps] (master) - https://gerrit.wikimedia.org/r/71324 [09:06:17] Nikerabbit: the wmf branch of mediawiki/core ? [09:09:56] hashar: yes [09:15:21] No submodule mapping found in .gitmodules for path 'extensions/Campaigns' [09:15:22] ah [09:18:07] New review: Matmarex; "It's not that simple, I have a more advanced patch to do it already waiting to be merged: https://ge..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71321 [09:22:18] Nikerabbit: git rm --cached extensions/Campaigns [09:22:21] Nikerabbit: that should fix it [09:32:27] Nikerabbit: I can add it; could you wait a moment? [09:37:56] New patchset: Hashar; "mwext-MobileFrontend-qunit" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71325 [09:39:44] New patchset: Hashar; "Add qunit to MobileFrontend" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71153 [09:40:38] New review: Hashar; "rebased and fixed conflict" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/71153 [09:40:39] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71153 [09:41:01] ori-l, hashar: sure [09:41:04] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/71325 [09:49:44] New review: Hashar; "And the build is passing:" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/71153 [09:51:53] Nikerabbit: https://gerrit.wikimedia.org/r/#/c/70987/1/.gitmodules [09:52:05] it was in core, removed by mistake [09:52:46] okay [09:53:00] i'm fixing it, sorry for the delay [09:54:15] New review: Ori.livneh; "I assume the removal of extensions/Campaigns from .gitmodules was not intentional; adding it back now." [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70987 [09:56:05] hashar: *poke* [09:56:11] pong [09:56:13] MatmaRex: [09:56:13] hashar: why is https://gerrit.wikimedia.org/r/#/c/71272/3 failing its tests on jenkins? [09:56:54] have you looked at the build console log ? [09:59:17] New patchset: Ori.livneh; "Restore extensions/Campaigns submodule" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71327 [09:59:18] yep [09:59:31] it claims that "expected" is not the same "expected" as in code [09:59:53] aka the test is failing :-] [09:59:57] New review: Matmarex; "Find hashar and have him fix it. :P" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [10:00:20] no [10:00:24] "actual" is correct [10:00:27] it's "expected" that's wrong [10:00:30] which is bizarre [10:00:44] 07:17:56 [exec] --- Expected [10:00:44] 07:17:56 [exec] +++ Actual [10:00:44] 07:17:56 [exec] @@ @@ [10:00:44] 07:17:56 [exec] -'#REDIRECT [[::Foo]]' [10:00:44] 07:17:56 [exec] +'#REDIRECT [[:Category:Foo]]' [10:01:15] New review: Ori.livneh; "Reverted the removal of extension/Campaigns in change I58a424c70." [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70987 [10:02:49] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71327 [10:05:35] $this->assertEquals( $content->serialize(), $serialized ); [10:05:46] MatmaRex: looks like the parameters are in wrong order [10:06:25] would be clearer if $serialized were called $expected [10:07:01] MatmaRex: so looking at the patch [10:07:08] MatmaRex: https://gerrit.wikimedia.org/r/#/c/71272/3/includes/content/WikitextContentHandler.php,unified that looks like a hack [10:07:37] MatmaRex: don't we have a a method in Title that takes care of crafting an article name for #REDIRECT ? [10:07:47] do we? [10:07:54] Nikerabbit: fixed; thanks for being patient. [10:07:55] also, redirects shouldn't add stuff to categories anyway, regardless of the format [10:08:06] but i was unable to find where the hell they are parsed [10:08:37] I have no idea [10:08:49] hashar: we don't or i don't see it [10:10:21] hashar: also, comment on the patch please? [10:10:33] i hardly know anything about phpunit, really [10:10:42] the fact that it seems quite braindead to me doesn't help [10:11:14] well the issue is in the code or the test [10:11:18] not in jenkins/phpunit :-) [10:11:50] hashar: cool, got it, please point it out? [10:11:57] ah, wrong parameter order, like Nikerabbit said? [10:12:08] maybe [10:12:11] hashar: also, it apparently passes for liangen.t locally [10:12:12] let me add some comments [10:13:17] New review: Matmarex; "Works as advertised." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/49595 [10:15:49] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49595 [10:18:57] New patchset: Rjain; "Added the db schema" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [10:21:41] New review: Hashar; "Seems to me the issue is related to the actual code or test, not an issue in PHPUnit or jenkins itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [10:21:55] MatmaRex: commented :) ^^^^ [10:22:26] thanks [10:30:20] New review: Matmarex; "I'm now pretty sure this is not needed; applying this patch results in error messages such as 'passw..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/47821 [10:35:38] in a SQL query, how can I ask for log_timestamp or other MW timestamp less than a timestamp I have? it seems to give random results to me :S [10:36:31] Nemo_bis: are you using the full timestamp? including the time part? [10:36:46] yes [10:36:59] (what else is available?) [10:37:20] then I'm out of ideas, sorry [10:38:53] New review: Matmarex; "Behavior looks correct to me now." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/68859 [10:39:29] Nemo_bis: goesn't simple < work correctly? [10:40:03] Nemo_bis: WHERE log_timestamp< "20130701123900" [10:40:11] (if i've gotten the format right) [10:44:17] New patchset: Santhosh; "Remove namespace parameter from ApiULSLocalization" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71328 [10:47:04] MatmaRex: why the " ? I tried ' but it didn't work [10:48:03] Nemo_bis: hm, why not? [10:48:10] that's what I'm asking [10:48:25] did this way work? [10:48:34] double-quoted strings seem natural to me :P [10:49:02] dunno, trying [10:49:12] nope [10:50:13] New review: Matmarex; "Yeah, I know, that's why I avoided implementing that. The current Vector extension version disregard..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:51:33] New review: Liangent; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [10:52:01] Nemo_bis: that's how it's done in core as far as i can see [10:52:23] RecentChange::purgeExpiredChanges: [10:52:24] array( 'rc_timestamp < ' . $dbw->addQuotes( $cutoff ) ), [10:52:27] New patchset: MathiasLidal; "Fix prefix in search boxes" [mediawiki/extensions/InputBox] (master) - https://gerrit.wikimedia.org/r/71330 [10:52:41] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=50488 interested in this too? [10:54:03] New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [10:54:13] liangent: whaaa. where do you pull that stuff from [10:55:50] MatmaRex: I made it up myself, when testing that makeRedirectContent patch [10:55:58] the best I managed to do so far is, with something like "AND log.log_timestamp > '( NOW() - INTERVAL 3 MONTH )'", it returns everything before the timestamp, both with < and > [10:56:15] since direct links (no colon) to NS_FILE and NS_CATEGORY are two special cases [10:56:25] New review: Pastakhov; "Add break/continue statements" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [10:56:37] there's some problem for category. there might be another problem for files too [10:57:47] New patchset: MathiasLidal; "Fix prefix in search boxes, and add support for multiple search boxes" [mediawiki/extensions/InputBox] (master) - https://gerrit.wikimedia.org/r/71331 [10:59:02] liangent: my opinion is that redirect pages simply shouldn;t be parsed [10:59:11] liangent: this would solve all of the issues you mentioned [10:59:15] (categories, files, interwikis) [10:59:31] but i have no idea where should it be iffed-out :P [11:03:30] MatmaRex: see https://en.wikipedia.org/wiki/Category:Redirects_from_alternative_languages [11:03:39] New review: Tpt; "Some details." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/71172 [11:04:43] sometimes they put redirects into categories delibrately [11:05:19] liangent: yes, sure, but [11:05:36] liangent: the categories should only come from the text after #redirect[[...]] [11:05:50] the redirect syntax itself should be killed before further parsing [11:05:58] MatmaRex: right [11:06:19] MatmaRex: however https://bugzilla.wikimedia.org/show_bug.cgi?id=50488 is another thing [11:11:44] liangent: hm? [11:11:51] liangent: (sorry for being unresponsive :) ) [11:12:41] MatmaRex: [[File:Filename.jpg]] is after [[A]] [11:14:07] liangent: yeah, i think the regexes used for redirect detection are wonderfully vague [11:14:22] liangent: so you could have "#redirect my ass [[page" and it'd work [11:14:24] or something like that [11:15:46] MatmaRex: so can't we just strip the regex-matched text from the beginning of page content [11:17:18] liangent: yeah, i have no idea why this isn't done [11:17:23] (since it apparently isn't) [11:17:44] i dare you to try to dig that out. Paser.php is only 8000+ lines. :P [11:34:13] Was there any recent update to test.wikipedia.org which could make it impossible to login? [11:34:25] I'm always getting "Login error [11:34:25] Wikipedia uses cookies to log in users. You have cookies disabled. Please enable them and try again." [11:37:29] New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332 [12:20:55] New patchset: Matmarex; "Allow creation of empty MediaWiki: pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71332 [12:24:44] hashar: beta labs is now donw? [12:24:58] Nikerabbit: NFS broken, Ariel was working on it [12:24:59] Nikerabbit labs is down [12:26:17] oh [12:33:02] Yippie, build fixed! [12:33:03] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #46: FIXED in 1 min 1 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/46/ [12:35:20] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71328 [12:52:05] New patchset: Zfilipin; "WIP test steps written at WMF with volunteers!!" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70979 [12:53:43] New review: Zfilipin; "Added WIP (work in progress) at the front of the commit message." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70979 [12:58:00] New review: Parent5446; "Haven't tested yet. Not sure how I feel about a ternary statement inside an if statement." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/71332 [13:15:43] New review: Yaron Koren; "Hi - can you briefly explain what dot notation is, and what a call to #get_db_data that used it woul..." [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71255 [13:18:29] New patchset: Hashar; "SquidUpdate debug message are now in 'squid' group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71342 [13:25:29] andre__: hiya! [13:26:19] morning sumanah! [13:32:34] New patchset: Parent5446; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [13:37:11] New patchset: TheDJ; "jquery.tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [13:38:40] New patchset: TheDJ; "jquery.tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [13:41:28] New review: Hashar; "It seems Mark was not aware of this Mediawiki feature. I am enabling it on the beta cluster https..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4486 [13:49:08] New patchset: Zfilipin; "Deleted test for a feature that is not enabled at beta" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/71347 [13:53:17] guillom: http://adainitiative.org/2013/07/new-accessible-dropdown-menus-plugin-for-wordpress-now-available/ I don't believe we have any dropdown menus on the publicly accessible side of our WordPress install -- do we? [13:54:22] Not in the current theme, but in the upcoming one, I don't know [13:54:47] okay [13:55:17] liangent, please accept my skype invitation [13:55:35] aude, Denny_WMDE are you ready for the GSoC call now? I need your Skype handlers [13:55:58] hi sumanah guillom :) [13:56:01] qgil: sure or would it be easier to do via irc? [13:56:04] * aude does not care [13:56:04] hello [13:56:11] qgil: we are currently working with the student :) is that skype call really needed? would prefer it over irc a lot [13:56:14] * aude thinks liangent is doing well [13:56:16] aude, then skype as said in the invitation :) [13:56:27] mmmmmm [13:56:56] aude, Denny_WMDE liangent this is the one and perhaps only call in the whole GSoC, it's social and hearing voices (and perhaps seeing faces) is good [13:56:59] In general, we've found that having some face-to-face contact (even over pixels) boosts relationship-building and morale and helps keep the project on schedule [13:57:18] New review: Jqnatividad; "Hi Yaron," [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71255 [13:57:26] in a few minutes then [13:57:29] and in any case you had many days to comment on this meeting :) (liangent did, Skype was fine for her) [13:57:32] we're in the middle of discussing with her [13:57:42] ok [13:57:44] ok, if skype is fine then fine with us [14:04:04] qgil: i am vrandezo [14:04:17] * aude can sit with denny [14:07:55] andre__: http://www.neverworkintheory.org/?p=547 [14:09:08] sumanah, uh yay, a new paper! Thanks! [14:09:16] :) [14:09:35] Heh, I spent the weekend with papers on automatic classification of reports [14:15:47] andre__: https://twitter.com/neverworktheory is pretty great [14:17:17] I'll bookmark the website. I'm still not really a Twitter user. [14:17:27] guess I should check if they have some nuggets about bug management and quality [14:19:56] "Gerrit Code Review" has an avatar now ^demon? [14:20:16] <^demon> No, we've not put in a plugin for it. [14:20:29] <^demon> The default implementation is lame though, it makes the requests even if you don't have an avatar plugin. [14:20:39] <^demon> Feel free to ignore those. [14:24:33] <^demon> Krenair: Filed https://code.google.com/p/gerrit/issues/detail?id=1987 to shut those up. [14:26:40] do we get avatars now on gerrit? sweet [14:27:16] <^demon> There's a plugin point for it, but I've not installed any plugins. [14:27:35] aww [14:27:43] New patchset: TheDJ; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [14:27:51] <^demon> brion: We could come up with something that would fetch your chosen image from commons :) [14:28:03] <^demon> Special:Random/file ;-) [14:28:13] andre__: I bet they have an RSS feed if you're into that [14:28:50] could use page images on the user page... [14:31:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [14:40:03] Yippie, build fixed! [14:40:04] Project _debug-browsertests-template build #181: FIXED in 2 min 19 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/181/ [14:46:09] New review: TheDJ; "Should we send another email to the list of tools and bot operators ?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70036 [14:50:21] brion ^demon could just use gravtar for the avatars... [14:50:29] much simpler solution [14:50:39] New review: Hashar; "I am not sure whether it is a good idea to replace wfDebug() with wfDebugLogGroup(), the overhead s..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71342 [14:50:39] <^demon> I considered using the gravatar plugin, but it kinda gives me the willies. [14:50:45] <^demon> Exposes your e-mail address to a 3rd party [14:50:59] I am off, will be back later tonight for some conf calls [14:51:13] doesn't github already use it for these [14:51:16] *theres [14:51:23] and almost every where else in the web [14:51:37] <^demon> Yeah, doesn't mean I have to like it :) [14:52:58] New patchset: Alex Monk; "Set taborder on Special:ActiveUsers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71354 [14:56:27] gerrit down? getting 503s... [14:56:37] I agree with ^demon. It suffices for me if "Code Review Tool" shows Diffy as avatar :-) [14:56:52] Krenair: same here [14:57:06] I think ^demon is restarting it [14:57:09] <^demon> Krenair: Had to restart, trying to flush some caches to help with the firefox problem. [14:57:11] to nuke on-disk caches [14:57:28] Gerrit is back up for me. [14:57:29] New patchset: Jeroen De Dauw; "Remove list of functions added in wgExtensionFunctions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355 [14:57:46] New patchset: Jeroen De Dauw; "Remove list of functions added in wgExtensionFunctions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71355 [14:57:52] New patchset: Alex Monk; "Parse duplicate-defaultsort error message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [14:58:18] <^demon> qchris: [2013-07-01 14:56:58,311] INFO com.google.gerrit.pgm.Daemon : Gerrit Code Review 2.7-rc2-505-g7502a46 ready [15:04:40] What is the mediawiki parser dev channel? I had a few questions for those guys. [15:07:17] New review: TheDJ; "Got an TypeError: 'undefined' is not an object (evaluating 'upload.details.submit'). This is because..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/68835 [15:07:24] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/25262 [15:08:30] rplummer left before I could answer him :( [15:12:11] New patchset: Rjain; "changed the remote ext path to Annotator instead of prototyping inline comments" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [15:21:53] is it just me, or does https://gerrit.wikimedia.org/r/#/c/60871/11/resources/jquery/jquery.tablesorter.js not load? [15:22:20] MatmaRex: this link works for me [15:22:23] ah, nevermind, just me. [15:22:41] gerrit nagically reenabled "Syntax Coloring" by itself, which makes it not load on Opera. [15:23:18] oh, good to know :-) [15:24:04] hm, actually, it logged me out. [15:24:07] big update? [15:25:46] I was logged out a few minutes ago too [15:26:28] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:32:06] <^demon> MatmaRex: When we flushed those caches, it logged everyone out. [15:32:12] <^demon> Log back in, life goes on [15:35:10] ^demon: sure [15:36:35] New review: Matmarex; "Meh, just noticed the indentation in jquery.tablesorter.test.js is all messed up. I'll fix it myself..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:39:00] New patchset: Matmarex; "jquery.tablesorter: Support sortable column headers with rowspans" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:41:02] [15:43:27] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60871 [15:43:55] New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [16:10:59] MatmaRex: I was just using an old format for log_params... *hides* https://pt.wikipedia.org/w/index.php?title=Usu%C3%A1rio%28a%29%3ANemo_bis%2Fpatrulhadores&diff=36270815&oldid=36269803 [16:25:13] New patchset: Rjain; "Added the create class Just tried out adding the create class but there are some errors passing the Json data of annotations." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [16:28:44] qgil: Boy that's a late meeting :) [16:31:38] New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [16:36:04] New patchset: Matmarex; "Change "permissions errors" message to "permission error"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59060 [16:36:28] marktraceur, tell me, I had the first one today scheduled at 7am... [16:36:54] New review: Matmarex; "Let's do this. Even if there are, in fact, multiple reasons why the action could not be performed, t..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59060 [16:37:08] qgil: Confirm that I'm going to be in the office tonight at 19:00 PST [16:37:09] marktraceur, I don't understand people having jobs like micru ;) [16:37:55] ^demon: around? [16:38:12] ^demon: where does git review take my username / email from? [16:38:15] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [16:38:19] it keeps picking up suchabot's one and refuses to push [16:38:28] user.email is set appropriately... [16:38:43] <^demon> YuviPanda: git-review? Nfc. [16:38:45] marktraceur, looking at how the other meetings are going, by 6:30pm we could be done [16:39:00] hmm [16:39:00] <^demon> I don't touch that flaming pile of horse manure. [16:39:24] :) [16:39:48] ^demon: well, it's not a git review issues. gerrit responds with that when I push [16:39:51] but I think I've found the issue [16:40:24] Change merged: MaxSem; [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25628 [16:40:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59060 [16:40:41] .ssh/config had wrong username / key set [16:42:49] New patchset: Yuvipanda; "Revert "Use non-beta icons, add icon assets under scratch"" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/71368 [16:42:49] New patchset: Yuvipanda; "Updated CHANGELOG and bumped version number" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/71369 [16:43:16] though I doubt that's a problem many users will face [16:43:22] most don't have two user accounts [16:43:36] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/71368 [16:44:09] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/71369 [16:44:31] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [16:50:51] New patchset: CSteipp; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71372 [16:52:48] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71255 [16:55:52] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71372 [17:06:26] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [17:07:24] Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [17:15:25] New review: Rjain; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71364 [17:19:29]

" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [23:09:12] New patchset: Mattflaschen; "Update VisualEditor for gender survey." [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71552 [23:09:48] gender survey? [23:10:04] superm401: what is that? there is already a preference for user gender [23:10:20] and what does htis have to do with VE? [23:10:23] MatmaRex, I'll explain after the deploy. [23:11:01] New review: Spage; "yup, latest" [mediawiki/core] (wmf/1.22wmf8) C: 2; - https://gerrit.wikimedia.org/r/71552 [23:11:29] New patchset: Mattflaschen; "Update VisualEditor for gender survey." [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71553 [23:12:20] New review: Spage; "yup, d86c425 is latest" [mediawiki/core] (wmf/1.22wmf9) C: 2; - https://gerrit.wikimedia.org/r/71553 [23:15:18] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [23:16:07] New review: CSteipp; "Should be fine" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/68859 [23:16:47] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71552 [23:19:56] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71553 [23:20:31] New review: Matmarex; "Wow, I wasn't even waiting for this to get merged anymore. Thanks!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [23:33:26] greg-g: Is it OK if we take a late LD slot for a couple of extra patches for VisualEditor? Most notably, blacklisting Firefox 10 and under, which we were told was working but apparently the community member lied and now we've got lots of users trying to load VE and failing... [23:34:29] as long as superm401 is done [23:35:03] New patchset: Matmarex; "SpecialUserlogin: fix typo in comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71303 [23:35:13] James_F, in the middle of a scap. [23:35:18] Will let you know when done. [23:35:27] superm401: Yeah, was going to wait for you guys. :-) [23:35:35] superm401: Need anything from us? [23:35:49] hm. [23:35:51] oh, there you are (I forgot which channel I was in) [23:35:55] Nope, Krinkle +1'ed, then ori-l merged. [23:35:58] gerrit lets me cherry-pick changes from a branch to itself. [23:37:52] superm401: Are you deploying https://gerrit.wikimedia.org/r/#/c/71540/ too? [23:38:34] New review: Bsitu; "(1 comment)" [mediawiki/extensions/PageTriage] (master) C: -1; - https://gerrit.wikimedia.org/r/69964 [23:38:37] New review: CSteipp; "Haven't tested, but in concept this looks fine" [mediawiki/extensions/CheckUser] (master) C: 1; - https://gerrit.wikimedia.org/r/52237 [23:38:59] New review: Parent5446; "This patch is still necessary, I just implemented it incorrectly." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/47821 [23:39:39] James_F, no, since it's not merged yet. [23:40:15] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/69596 [23:40:23] New review: Matmarex; "(On a side note, I didn't expect gerrit to allow me to cherry-pick changes from a branch to itself, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71303 [23:41:13] superm401: Now +2ed. [23:46:11] James_F, scap is done. [23:46:18] superm401: Yay. [23:47:09] New review: Krinkle; "I didn't check when it was added as I couldn't imagine that obscure patterns like "static create: ne..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67023 [23:48:02] New review: Krinkle; "The pattern "static create: new self" is not used in MediaWiki and has been rolled back out in Ib080..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [23:48:54] New patchset: Rachel99; "WIP add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [23:49:09] New patchset: Mwalker; "Making Check Imports More Agnostic" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71557 [23:52:45] James_F, TrevorParscal: probably Tongbo won't be able to make it to the Hangout (I should have thought about the Chinese wall before). Let's cancel and fine a new time. Unless you have got in touch in the last hours? [23:53:33] qgil: Sure. [23:53:38] ok [23:53:41] qgil: Yeah, no, not spoken to him about this. [23:53:57] thanks James_F [23:55:26] New patchset: Mwalker; "Making Check Imports More Agnostic" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71557 [23:59:20] New patchset: Mwalker; "Making Check Imports More Agnostic" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/71557