[00:02:09] New review: Hoo man; "Let's finally get this merged :)" [mediawiki/extensions/MoodBar] (master) C: 2; - https://gerrit.wikimedia.org/r/52452 [00:02:15] Change merged: jenkins-bot; [mediawiki/extensions/MoodBar] (master) - https://gerrit.wikimedia.org/r/52452 [00:05:20] New review: Hoo man; "Merging as stewards would probably kill for this (per Chris and previous test). Thanks :)" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/60282 [00:05:35] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/60282 [00:14:13] We should write a rebase bot [00:15:45] rebase all the revisions! [00:15:46] etc [00:16:53] That's so *not* going to break gerrit :P [00:18:43] Stress testing [00:36:02] it was all hoo's idea! [00:40:04] Yup, he anticipated no problems in doing this [00:41:31] se4598: correct, I failed to realise that [00:41:58] Go for it... if gerrit breaks, we can still upload a change to gerrit to fix it ;) [00:42:03] se4598: I thought 3c4aac9 of core submoduled VE on that id [00:46:07] AzaToth: never know, talked to James_F hours before that the beta hadn't master. Special:Version also showed old version after update, but right now it shows the correct one [00:46:23] maybe you retest it right know to be really sure [00:46:40] I tested if after Reedy promised it has been updated [00:47:05] and I trust Reedy, he/she/it never lies [00:48:47] AzaToth: too; I saw that VE was looking different after that [00:50:05] but Special:Version was lying to me, so I don't understand who shows when the correct info, and where to look it up [00:53:07] I'll test again, could be some cache issue [00:54:27] ok, it's fine now [00:54:36] was probably some cache issue [01:00:07] se4598_2: though now it's strang when I edit the template after save with other params [01:01:15] maybe caused by the fix [01:01:23] http://en.wikipedia.beta.wmflabs.org/wiki/User:AzaToth [01:01:36] first I notice it doesn't check for extra spaces [01:01:51] and now no templatedata is shown for parameters [01:03:12] and now when I try to edit, I always end up at "old version" [01:03:18] three bugs in one minute! [01:04:38] and VE should be go more live tomorrow? [01:04:55] James_F: any ideas? [01:04:59] pretty much [01:11:30] AzaToth: at your page, if I move your mouse cursor over one to the other template and back and forth, I can't click on the template to select it, have to leave the template-area first; can you confirm this? [01:14:09] se4598_2: haven't tested that yet [01:14:18] filing bugs like a mad man [01:14:55] can confirm [01:15:06] you want to file that one? [01:15:13] I have another bug to file ツ [01:17:25] se4598_2: ? [01:17:30] argh, first have to restart firefox, Already taking 3 GB ram out of 4 GB real RAM that my laptop has, doesn't respond on program right. slow hdd swap :/// [01:17:32] have filed my fourth now [01:17:39] me too [01:17:47] seems to be some memory leak [01:18:14] actually only taking 4.7% mem [01:18:19] (out of 16G) [01:18:38] 200 tabs on 4 windows open or so, FF already running 27 days already missing updates [01:18:41] where you going to file it? [01:18:59] or should I? [01:19:25] James_F: 5 new fresh bug reports for VisualEditor [01:19:33] if you could i would appricate it, I want to go to bed [01:19:35] ok [01:21:18] ff is so slow at shutting down, it already warns that a internal JS script hangs :D [01:21:56] heh [01:22:38] done [01:23:02] https://bugzilla.wikimedia.org/50439 https://bugzilla.wikimedia.org/50440 https://bugzilla.wikimedia.org/50441 https://bugzilla.wikimedia.org/50442 and https://bugzilla.wikimedia.org/50443 [01:23:11] Krinkle|detached: ↑ [01:27:08] thanks AzaToth [01:28:15] np [01:29:25] * se4598_2 goes sleeping; already 3:30AM here [01:30:36] New patchset: Jqnatividad; "Added dot notation support for retrieving values from compound MongoDB result documents; added MongoDB aggregate mode" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/71255 [01:46:32] New patchset: Jpond; "(bug 50430) Generates null array errors in strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71256 [02:05:27] New patchset: Mattflaschen; "runOnloadHook is now only called from here. Remove old comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71257 [02:26:49] Change merged: Yaron Koren; [mediawiki/extensions/SemanticInternalObjects] (master) - https://gerrit.wikimedia.org/r/71251 [02:27:42] Change merged: Yaron Koren; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71250 [02:38:16] New review: Krinkle; ""from here", from where? Please improve commit message." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71257 [02:42:17] New patchset: Mattflaschen; "runOnloadHook is now only called from wikibits. Remove old comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71257 [02:45:50] New patchset: Jpond; "(bug 50430) Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258 [02:55:55] New patchset: Mwjames; "SMW\Store\Collector eliminate duplicate code and split responsibility" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71260 [03:07:16] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/71260 [03:33:15] New patchset: Rfaulk; "add. dummy methods for release and finish functions." [sartoris] (master) - https://gerrit.wikimedia.org/r/71262 [03:33:35] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/71262 [05:16:24] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #103: FAILURE in 39 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/103/ [05:18:24] legoktm: v [05:18:34] Hi Elsie. [05:19:55] Hello. [05:20:32] Any thoughts on the new patchset? [05:21:02] Dunno. [05:21:11] It's unclear whether you're targeting this for Wikimedia wikis or MediaWiki wikis. [05:21:16] I think it's fine for MediaWiki wikis. [05:21:34] For Wikimedia wikis, I think we need to figure out what's reasonable to log forever. [05:22:06] It still feels like it should be wrapped in AbuseFilter or something. [05:22:09] I dunno. [05:22:23] Why wouldn't it be reasonable to log forever? [05:22:54] Is there any value in logging it forever? [05:23:15] Why do we store edits forever? [05:23:35] Attribution is important. [05:23:45] Not for random vandalism. [05:23:55] Well, right. [05:24:05] Whether we should keep vandalistic edits forever is a good question to ask. [05:24:32] I wonder if logging to recentchanges would make more sense. [05:24:53] Is there any reason to keep this data around past 30 days? [05:25:10] For analysis of which sites to remove from the blacklist [05:25:49] I guess the issue you'd of course hit is that someone would just set up their own database of this, then... [05:26:09] Why is the log restricted to admins? [05:27:30] I don't think the log should be public (kinda defeats the point of blocking the links), so sysops is the normal choice to limit to. [05:29:20] New patchset: Parent5446; "Generates null array errors in strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71256 [05:34:22] New patchset: Parent5446; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71258 [06:01:03] legoktm: The data seems to be sitting somewhere between public and private. [06:01:24] I mean, if it's not public data, do we really want it around forever? [06:01:25] I dunno. [06:02:21] At the same time its not really private data, its just that I don't think its a good idea to have a page that lists every single spam link that people have tried adding publicly available. [06:02:59] That sounds like the spam blacklist itself. ;-) [06:03:25] New patchset: Ori.livneh; "Adopt a cleaner, simpler naming scheme for scripts" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/71268 [06:04:24] what's the question? [06:05:02] ori-l: we're discussing https://gerrit.wikimedia.org/r/69303 and the related bug [06:05:11] Elsie: The spam blacklist only has abstract regexes. [06:07:26] If you say so. [06:08:00] what are abstract regexes? [06:09:08] The title of a de Kooning exhibit at the MoMA. [06:09:10] [[MediaWiki:Spam-blacklist]] has regexes on it, but the're abstract in the sense that the regex doesn't give you a valid url to use [06:09:38] The point was more about whether you consider this private data or not. [06:09:48] If it's private data, I think it should auto-expire. [06:10:11] I don't consider it to be private data, its just data that shouldn't be publicly accessible to all. [06:10:26] So private I guess >.> [06:10:44] I think you see what I mean. [06:10:59] it's * [06:11:03] Of some relevance is the adaptation of Phalanx for Wikimedia sights [06:11:12] sites [06:11:14] done by ashley and a few others some months ago [06:11:19] Is Phalanx being adopted? [06:11:23] Or adaptation. [06:11:27] adaptation [06:11:29] Oh * [06:11:29] Elsie: On the other hand, not all private data expires. Like deleted/suppressed pages. [06:11:32] b/c idk of deployment [06:12:03] legoktm: Sure. [06:12:58] what's the use-case? [06:13:12] Heh. [06:13:15] I was about to say something similar. [06:13:19] I was just re-reading the bug. [06:13:22] Again. [06:13:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=1542 [06:13:39] I think aggregate stats may be a better approach. [06:14:25] No, probably not [06:14:39] It'd be a more invasive change and require much more code [06:14:57] You can identify spambot accounts that never break through the spam blacklist. You get CU data for these accounts and can give out IP blocks. You can tell when certain blacklisted sites are no longer being abused [06:15:18] You can look at this change and feel pretty confident that it'd work, because it uses infrastructure that is central to core and hence well-maintained and performant [06:15:40] What's the use-case? [06:15:54] lego: I did observe that letting an abuse filter on Wikidata block the spam URLs rather than the blacklist itself generated lots of IPs for us to block. [06:16:00] being able to remove entries from the blacklist without feeling like you're endangering the wiki in the process [06:16:11] Elsie: See what I said above :) [06:16:54] I wonder what the rate of hits is... [06:17:13] It could be overwhelming. [06:17:19] Elsie: it was today, for that abuse filter [06:17:24] 500 hits in <4 hours [06:17:31] from over a hundred IPs [06:17:32] Logging things indefinitely is expensive. [06:17:34] Elsie: Me too. But I don't know if anyone has ever looked at it [06:17:35] Jasper_Deng: "that abuse filter"? [06:17:39] I mean for logging spam blacklist hits. [06:17:48] I don't know what AbuseFilter filer you're talking about. [06:17:56] ori-l: https://www.wikidata.org/w/index.php?title=Special:AbuseLog&wpSearchFilter=5 [06:18:08] we used abuse filter b/c it was functional before spam blacklist was [06:18:25] What? [06:19:14] Elsie: The SpamBlacklist isn't usable on Wikidata because the content isn't rendered as links. So we have to use the abusefilter, which provides logging, giving us a picture of how many hits the spam blacklist theoretically would get. [06:19:39] isn't spamblacklist hostname-based only? [06:19:53] It's regex based [06:20:10] So if the url is "http://domain/path/blah" and the regex is .*path.* it would match [06:20:11] but the regex is executed against the editor's hostname and no other field, correct? [06:20:14] spam blacklist can also blacklist parts of subdirectories ^ [06:20:23] It's against the entire url. [06:20:31] the URL of what? [06:20:49] I'll just RTFM, hang on. [06:20:56] RTFS * [06:20:59] :) [06:21:17] I thought it was prefix-based. [06:21:36] Nope [06:21:55] I didn't really think that. [06:22:06] oh, it's applied to external links, not editor hostname [06:22:15] Right. [06:22:25] The addition of external links. [06:23:09] mhm [06:23:49] it's already logged using wfDebugLog [06:24:12] but it's not currently configured to actually write a log file, so the log data that is generated is thrown on the floor [06:24:23] and even if a file were generated, it wouldn't be very accessible [06:24:51] but if you're debating the value of logging, you could simply capture the debug log data for a week and have a look [06:25:12] I think legoktm's change is fine, though [06:25:25] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [06:26:40] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/70118 [06:27:04] thanks :) [06:29:21] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/SpamBlacklist] (master) C: -1; - https://gerrit.wikimedia.org/r/69303 [06:29:54] New review: Physikerwelt; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [06:30:17] "is fine" … "C: -1" [06:30:59] why is Gerrit taking so long to load? [06:31:12] It's fine for me. [06:31:17] Are you logged in? [06:31:29] yes [06:31:37] ori-l: will do in a bit, thanks for the review [06:33:59] Elsie: seems to be a browser issue [06:34:02] worked on Chrome [06:36:24] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/71268 [06:39:03] legoktm: ask Elsie to review the commit message and README changes [06:39:30] ok [06:49:04] Elsie: Firefox is broken in Firefox, but only when viewing certain commits and only when logged in [06:50:02] RoanKattouw: exactly what I was experiencing [06:53:08] Gabriel has reported the same [06:53:23] This started happening with the Gerrit upgrade that happened a couple of days ago [06:53:24] RoanKattouw: got an example handy? [06:53:42] that change by lego is an example here [07:01:06] GWT-generated JS is unreadable, sadly [07:04:55] https://gerrit.wikimedia.org/r/#/c/70851/ [07:05:03] is an example of a page that won't load for me in Firefox [07:07:51] same w/ me [07:09:44] WFM, but lego's change produces https://dpaste.de/IWr6b/ [07:09:50] 70851 WFM, I mean [07:11:08] the GWT compilation & minification makes it too difficult to debug [07:36:54] [07:47:16] * apergos raises an eyebrow at Amgine_ [08:04:24] New patchset: MaxSem; "Update GeoData to master tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71271 [08:04:48] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/71271 [08:18:56] New patchset: Liangent; "Create redirects to sections correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [08:23:16] New patchset: Liangent; "Create redirects to titles correctly in WikitextContentHandler" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71272 [08:34:30] New patchset: MaxSem; "Update GeoData to master tip" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71274 [08:35:18] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/71274 [10:15:56] New patchset: Shirayuki; "Replace single quotes by double quotes" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/71276 [10:18:35] New patchset: Nischayn22; "Fix regression for categories more require-looking" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/71277 [10:34:44] New patchset: Rjain; "Added the api endpoint and called the store plugin." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [11:38:36] New review: Matmarex; "See my comment on the bug." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/71176 [12:27:32] New review: Matmarex; "Yup, and it's this way since 2010! (r72349, ResourceLoader branch merge). Instead jQuery.ready() is ..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/71257 [12:28:01] Krinkle|detached: now when I return to my page, it seems something if fucked up [12:28:04] see http://en.wikipedia.beta.wmflabs.org/wiki/User:AzaToth [12:28:12] it's the wrong™ version [12:30:24] Krinkle|detached: http://i.imgur.com/uqS7225.png http://i.imgur.com/v7SgcF7.png http://i.imgur.com/quhDrQt.png [12:30:25] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71257 [12:30:42] seems VE has done something nasty here, or something hasn't actually been saved [12:30:56] James_F|Away: do you see the same? [12:31:09] James_F|Away: related to https://bugzilla.wikimedia.org/show_bug.cgi?id=50440 [12:31:37] Reedy: could you help me identify the problem? [12:33:44] MatmaRex: loha [12:34:42] Not really [12:35:04] Reedy: competentally or lack of time? [12:35:11] Both somewhat [12:35:22] There's enough VE developers to begin with! ;) [12:35:23] I see [12:35:35] Reedy: I thought there was only Krinkle ツ [12:35:44] hi AzaToth [12:35:58] 'author' => array( [12:35:58] 'Trevor Parscal', [12:35:58] 'Inez Korczyński', [12:35:58] 'Roan Kattouw', [12:35:58] 'Neil Kandalgaonkar', [12:35:59] 'Gabriel Wicke', [12:36:01] 'Brion Vibber', [12:36:03] AzaToth: they're all in #mediawiki-visualeditor [12:36:04] 'Christian Williams', [12:36:06] 'Rob Moen', [12:36:08] 'Subramanya Sastry', [12:36:10] AzaToth: and they're all away [12:36:10] 'Timo Tijhof', [12:36:12] 'Ed Sanders', [12:36:15] ), [12:36:16] Reedy: stop D: [12:36:21] Too late [12:36:23] Too early for anyone in SF [12:36:27] hehe [12:36:30] Which is ost of them [12:36:34] also, weekend. [12:36:38] I see [12:36:40] Weekend? [12:36:41] Wassat?# [12:37:06] wmf should start paying me, i sit here all day, every day :P [12:37:12] MatmaRex: I would assume they have no weekend atm as they must have if finished and bug free tomorrow [12:37:18] it* [12:37:43] lolololol [12:37:51] AzaToth: i would say you assume wrong :P although yeah, they seemed partially active yesterday [12:37:56] still less active than usually [12:37:57] brb [12:38:29] well, VE is going fully live tomorrow afaik [12:41:23] MatmaRex: well, to be fair Krinkle|detached is not "away", only "detatched" ツ [12:47:34] New patchset: Santhosh; "ULS i18n performance fixes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71283 [12:56:29] * MatmaRex is back [12:56:48] AzaToth: i think he's "detached" in the sense that `screen` sessions are detached [12:57:10] just logging the output. :P [12:59:44] MatmaRex: I know, I was just being funny [12:59:50] (trying) [13:03:51] ;) [13:07:33] MatmaRex for Community Liaison. [13:07:35] *runs* [13:07:59] dealing with the Community? [13:08:00] * MatmaRex hides [13:08:01] :P [13:47:20] New patchset: Matmarex; "Re-grouping and ordering the editing preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65478 [13:48:27] New review: Matmarex; "I fixed it myself." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65478 [13:52:11] New review: Matmarex; "Actually, the 'prefs-beta' message is in core, so this is good to merge once I429c8125b8db789d2756d6..." [mediawiki/extensions/WikiEditor] (master) C: 1; - https://gerrit.wikimedia.org/r/65468 [13:53:40] New review: Amire80; "Looks good and makes more sense than the previous version, though I'm not sure whether it fixes the ..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/71283 [13:56:49] could somebody merge https://gerrit.wikimedia.org/r/65478 for me, by chance? [14:16:00] was teasing, apergos [14:18:39] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/71283 [16:21:16] New review: Rjain; "Can we merge this if its OK?" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [16:30:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70028 [16:34:16] New patchset: Rtdwivedi; "Added unit tests for Page pages." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [16:39:13] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/68859 [16:54:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64521 [16:56:23] New patchset: Matmarex; "Set initial focus on Special:ExpandTemplates" [mediawiki/extensions/ExpandTemplates] (master) - https://gerrit.wikimedia.org/r/49493 [16:56:42] New review: Matmarex; "Adjusted mention of the bug per conventions." [mediawiki/extensions/ExpandTemplates] (master) C: 2; - https://gerrit.wikimedia.org/r/49493 [16:56:47] Change merged: jenkins-bot; [mediawiki/extensions/ExpandTemplates] (master) - https://gerrit.wikimedia.org/r/49493 [17:03:07] New patchset: Matmarex; "Set initial focus on some special pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49494 [17:03:39] New review: Matmarex; "Linked the bugs in the new way. LGTM." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/49494 [17:07:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49494 [17:11:46] New review: Matmarex; "Man, you have a lot of patches pending." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62844 [17:14:17] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62844 [17:17:57] is it just me, or is gerrit incredibly sluggish? :/ [17:18:06] not just you :) [17:18:12] graaaah. [17:18:20] i just want to merge some changes! :( [17:18:24] I'm told it might be faster in Chromium. There's a bug logged, IIRC [17:18:36] and should be taken care of sooooon [17:19:28] i'm not using firefox [17:19:32] ah, opera [17:19:40] that's just general sluggishness, I guess [17:19:47] from the new gerrit uprade [17:19:53] it also broke my github -> gerrit bot [17:19:56] Krenair: do you maybe work on https://bugzilla.wikimedia.org/show_bug.cgi?id=50464 ? (just saw your cc-ing yourself) [17:19:59] one side of it at leeast [17:25:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64461 [17:27:33] New patchset: Matmarex; "Harmonize revert messages when username is hidden" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71290 [17:28:21] New patchset: Matmarex; "Harmonize revert messages when username is hidden" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71290 [17:30:51] New patchset: Liangent; "Fix language code output for firstHeading" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55455 [17:32:38] New review: Matmarex; "Partial dupe of I0ff707d5f04218bef5721e6fc162c6359bb7538a?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55455 [17:34:36] New patchset: Liangent; "Fix various language tags used in Html attribs to use wfBCP47()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55456 [17:37:25] New patchset: Liangent; "Fix various language tags used in Html attribs to use wfBCP47()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55456 [17:41:32] New review: Liangent; "You're right." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55455 [17:44:20] New review: Matmarex; "This could probably be merged anyway, but it'd be nice to give that patch some love, it seems to do ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55455 [17:45:52] New patchset: Se4598; "Add triggered filter id as parameter to messages" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291 [17:49:25] New review: Matmarex; "Sounds very sane. Amir, is this okay to merge?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/54484 [17:49:53] New review: Se4598; "inline questions" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/71291 [17:58:19] thanks MatmaRex for the focuses :) [17:59:23] New review: Rtdwivedi; "Everything works properly now( local test )." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/71172 [18:00:20] Nemo_bis: yeah, i went on a merging spree ;) [18:00:27] https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [18:01:01] MatmaRex: there's also https://gerrit.wikimedia.org/r/#/c/49595/ [18:08:48] New review: Krinkle; "Does it even need to get the username from the user table? I thought we introduced user_text in many..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/71184 [18:12:30] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57018 [18:12:38] * YuviPanda waves at marktraceur [18:12:53] Oh my goodness a YuviPanda [18:12:58] indeed :D [18:13:07] good day so far? [18:13:13] Meh [18:13:21] YuviPanda: Woke up a bit earlier than I wanted to [18:13:24] ah [18:13:47] :) [18:16:14] marktraceur: too early to bug you about CR? :D [18:17:31] New patchset: Parent5446; "changed the remote ext path to Annotator instead of prototyping inline comments" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [18:17:59] New review: Parent5446; "Only issue is that this commit is depending on the DB schema commit, so we can't submit it until the..." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [18:18:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65478 [18:20:26] YuviPanda: Way too [18:20:31] :D [18:20:36] * YuviPanda gives marktraceur ice cream instead [18:21:37] I doubt that will help wake me up, but maybe coffee will [18:21:41] * marktraceur goes to find that [18:28:42] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/71278 [18:30:14] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) C: -1; - https://gerrit.wikimedia.org/r/70794 [18:33:37] Nemo_bis: reviewed that one too [18:37:25] New review: Matmarex; "Let's do this." [mediawiki/extensions/WikiEditor] (master) C: 2; - https://gerrit.wikimedia.org/r/65468 [18:37:34] Change merged: jenkins-bot; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/65468 [18:40:18] New patchset: Jpond; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71292 [18:40:59] New patchset: Liangent; "bug 44798: Don't abuse comma-separator message" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/52237 [18:49:26] @notify odder [18:49:26] This user is now online in #wikimedia-tech. I'll let you know when they show some activity (talk, etc.) [18:51:37] Yay, fun bug - compare upload time with page creation time of https://commons.wikimedia.org/wiki/File:VisualEditor_-_Icon_-_Secure-link.svg :-( [18:52:44] liangent: you there? [18:52:52] MatmaRex: here [18:53:18] liangent: so i was looking at https://gerrit.wikimedia.org/r/#/c/55456/, and thus as wfBCP47() [18:53:24] liangent: and it says: [18:53:29] foreach ( $codeSegment as $segNo => $seg ) { [18:53:30] if ( count( $codeSegment ) > 0 ) { [18:53:38] that kinda doesn't make sense [18:53:57] if the foreach bodyis executing, then obviously there's at least one segment [18:54:01] MatmaRex: I didn't even look at it [18:54:13] New patchset: Reedy; "Update VE to master again again" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/71294 [18:54:25] liangent: then look :P as i assume you know what this function should be doing [18:54:26] MatmaRex: where is it? [18:54:31] liangent: GlobalFunctions [18:54:32] .php [18:54:44] New patchset: Jpond; "Generates null array errors strict php mode for fullname and email" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71295 [18:54:44] New patchset: Jpond; "mend" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/71296 [18:55:56] Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/71294 [19:00:44] MatmaRex: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/53722 add it with a comment "fix E_NOTICE on r53720 and r53721." [19:00:53] not sure what that notice is [19:01:27] yeah, i got there as well, but it didn't help me understand the motive here at all :P [19:02:58] I'm trying to install the LAMP stack on my labs instance [19:03:29] to check if apache has been installed, the instructions tell me to visit http:// [19:03:36] I did that but nothing seemed to happen [19:04:22] New review: Matmarex; "Trivial. Why did it wait since March? :/" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/55456 [19:04:45] Yippie, build fixed! [19:04:46] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #171: FIXED in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/171/ [19:06:05] pragunbhutani: did you get a public ip assigned for you? [19:06:44] or, what is [19:07:02] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55456 [19:09:33] Raymond_: fyi, this requires action on TWN https://gerrit.wikimedia.org/r/70553 ;) [19:11:00] hoo|away: I have seen but will handle it tomorrow. Currently I have a bit unstable connection on a motorhome site :) [19:11:49] liangent: I didn't get a public ID assigned [19:11:55] maybe that's the problem then? [19:11:56] :) That's fine, I guess [19:12:17] MatmaRex: how would you understand the comment line "// Keep casing for single segment" [19:12:46] I guess it's intended to say count( $codeSegment ) > 1 ? [19:13:16] but why would it trigger a notice "for single segment"? [19:13:39] liangent: i don't understand it at all [19:13:46] liangent: this seems to already be handled in // Use lowercase for other cases [19:14:21] liangent: hm, this seems to have some commented-out tests [19:14:28] maybe it should be just > 1 [19:14:34] liangent: /tests/phpunit/includes/GlobalFunctions/wfBCP47Test.php [19:14:45]