[00:08:25] Krinkle: as you looked at https://gerrit.wikimedia.org/r/70763 : do you also mean that it is safe and I should remove the dateFormat 'pretty'? [00:09:20] se4598: No, I'm saying if this is the patch you want to make (I don't know whether this is right or not) then it doesn't make sense to have if (foo) X elseif (bar) X repeat the same thing twice [00:09:40] it should be if (foo || bar) X in that case, know what I mean? [00:09:41] New patchset: Aaron Schulz; "Made runJobs.php respect time limits better and try to bail before OOMs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70781 [00:10:34] Krinkle: yeah, thought about that simplifcation [00:10:53] New patchset: Aaron Schulz; "Made runJobs.php respect time limits better and try to bail before OOMs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70781 [00:11:17] Krinkle: But me reason to not do that (for the first PS) was: "I left the elseif without merging it into the above one as maybe someone could remove the year for timestamps that are in the same year." [00:11:47] New review: Aaron Schulz; "Ideally this would re-build the hash ring without the bad servers to respect weights...though that's..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66227 [00:16:15] New patchset: Krinkle; "docs: Fix member index for mw.html" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70782 [00:17:54] New patchset: Krinkle; "docs: Fix member index for mw.html" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70783 [00:19:34] Change abandoned: Krinkle; "Aight, that's for GitX. Empty commit. See I22580a625 instead." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70782 [00:26:40] Krinkle: regexp fail on https://wikitech.wikimedia.org/wiki/Server_Admin_Log, i shall eat my hat in shame [00:27:12] 'gerrit change 2013' is especially unfortunate [00:27:28] anno gerriti [00:34:25] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70596 [00:35:25] New review: Cmcmahon; "login on test2wiki I mean" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70764 [00:44:06] New patchset: Katie Horn; "Limiting the GC orphan rectifier such that it will only mess with GC messages in the cc-limbo queue." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/70777 [00:48:23] Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/70777 [01:11:10] New patchset: Krinkle; "docs: Fix member index for mw.html" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70783 [01:11:10] New patchset: Krinkle; "doc: Improve documentation for mw.Map and mw#config" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70596 [01:11:10] New patchset: Krinkle; "Enable @example for jsduck index" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70787 [01:35:42] Krinkle: no worries. I'll handle it. doing it myself helps me learn what's actually going on [01:52:13] New review: Mattflaschen; "Psuedo-code:" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/69298 [02:02:46] New review: Swalling; "We should add the section edit step, ala what's in GettingStarted now, before we merge and test this." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [02:11:09] New patchset: Mattflaschen; "Enable VisualEditor in NS_MAIN in addition to VE namespace." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70791 [02:14:00] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70791 [02:39:10] New patchset: Mattflaschen; "Add 'mediawiki.ui' CSS module to all pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [03:01:56] Project _debug-browsertests-template build #171: FAILURE in 51 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/171/ [03:16:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #75: FAILURE in 7 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/75/ [03:24:06] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #75: FAILURE in 7 min 13 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/75/ [03:26:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #113: FAILURE in 8 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/113/ [03:34:04] New review: Krinkle; "I'm not against this in general, but I'm not sure whether the reasons make sense at this time. Loadi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [03:41:47] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #128: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/128/ [03:54:24] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #17: FAILURE in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/17/ [04:14:29] New review: Nischayn22; "We tried to answer that in the other commit as "Precedence can be influenced (other then by changing..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70589 [04:14:44] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [04:18:44] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/68199 [04:24:00] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #97: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/97/ [04:50:29] New patchset: Santhosh; "Special page TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69285 [04:52:52] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [05:02:05] that was quick! [05:06:37] New patchset: Rjain; "Added the db schema" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [05:43:29] New patchset: Spage; "Remove position from CSS-only resources" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70796 [06:05:01] New review: Rjain; "I am in a doubt that should the revision id be the unique id in the table? Does all annotations on a..." [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [06:15:23] New review: Tpt; "Looks globally pretty good. You have just forgotten to rename ProofreadPageValue in ProofreadPageCon..." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/70610 [06:33:53] New review: Rtdwivedi; "I also wanted to have the default values of header and footer to be '' instead of null but wasn't to..." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/70610 [06:34:39] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [06:40:09] New patchset: Mattflaschen; "Add missing qqq messages" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70798 [06:50:07] New patchset: Ori.livneh; "Get rid of NS_VISUALEDITOR & make VE user-toggleable" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70799 [06:50:29] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70799 [06:51:31] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70798 [06:57:34] New patchset: Mattflaschen; "Fix incorrect qqq descriptions, improve a couple others" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70800 [06:58:14] New review: Tpt; "Some more details" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/70610 [07:01:51] New review: J; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [07:02:38] New patchset: Mattflaschen; "Add missing qqq messages" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70798 [07:08:14] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [07:17:36] New patchset: Spage; "Add vform format to HTMLForm, use in PasswordReset" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [07:19:26] New patchset: Rjain; "changed the remote ext path to Annotator instead of prototyping inline comments" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [07:32:38] New patchset: Euvl; "Support for multiple definitions per term" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70802 [07:34:13] New review: Krinkle; "Revisited, let's do this :)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64365 [07:34:13] New review: Krinkle; "(pending merge of dependency)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365 [07:52:07] New patchset: Raimond Spekking; "Ignore now empty message for translation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [08:05:07] New review: Nikerabbit; "Just curious, what is the benefit of adding these methods to WebRequest class over fetching the data..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70747 [08:07:22] lo [08:07:53] yo [08:14:22] apergos: been some crazy weeks recently [08:14:31] sorry I did not follow up that much on beta and thumbnails rendering :( [08:16:17] I don't think there was anything that needed followup [08:16:19] it's all good [08:17:30] we had an issue that started last friday where some Javascript where still cached [08:17:41] some load.php URLs were not properly purged [08:18:00] I suspect it is a bug somewhere in the resource loader, haven't tracked it down though [08:18:03] morning [08:18:07] so I had to clear the text squid cache [08:18:15] huh [08:18:36] how did it handle that? [08:18:40] also the load.php are cached on the text squid because $wgLoadScript is a relative URL. So you get js/css served at something like en.wikipedia.beta.wmflabs.org/w/load.php.... [08:19:02] will have it migrated to bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php with https://gerrit.wikimedia.org/r/#/c/70322/ [08:19:07] more like in production [08:19:19] Nikerabbit: hello :) [08:19:42] it's cached? ewww [08:19:52] I am not entirely sure how it works [08:19:58] I guess the cache query the backend for load.php [08:20:08] and mediawiki returns something like "yeah it is ok, your version is up to date" [08:20:11] when it is not actually up to date [08:20:15] great [08:20:31] due to some dependencies changes in the javascript modules, seems the resource loader does not invalidate them properly [08:20:42] in production the ResourceLoader caches are purged on deployment [08:21:17] ah but deployment there isn't automagic from git [08:21:20] right [08:21:33] we must be missing some step which is done manually possibl [08:21:33] y [08:21:40] not that much of an issue though [08:22:33] I guess I will have to understand that process better one of these days [08:22:43] are you on the ops mailing list? I forget [08:24:09] I am :-) [08:24:14] I do rant there from time to time [08:24:26] the resource loader, I barely know about it though :( [08:24:33] and I barely do any deployment [08:25:00] oh this was going to be about another topic, I wonder if you have been following the roles-modules discussion for puppet [08:25:01] RL is more or less still maintained by its original authors (Timo + Trevor, maybe Roan) but they are working on the visual editor nowadays [08:25:12] ah sorry [08:25:19] so the roles / modules no I haven't followed it up [08:25:20] New patchset: Foxtrott; "fix bug (method name mis-spelled)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64964 [08:25:25] yeah I think we never discuss rl on the ops list :-D [08:25:25] I guess there are enough people involved as is [08:25:37] Change merged: Foxtrott; [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64964 [08:25:53] it just might determine our entire puppet layout is all :-D [08:26:05] to my understanding, seems everyone agree we should move our manifests to modules to take advantage of autoloader and possibly later let us write unit/integration tests [08:26:32] and people seems to slightly disagree about the purpose of modules (should they be third party usable, where to put WMF specific bits, how to handle configuration) [08:26:35] or what to do with roles [08:26:43] roles are a big one [08:26:43] New patchset: Foxtrott; "bugfixes: Ajax error handler, use correct data from web request, setup parser" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70745 [08:26:54] yeah that is not really easy to determine [08:27:04] but also there's "in theory I agree with the move" and "in practice this code isn't good enough so I don't want it to move, maybe someday" [08:27:13] which can turn into "it never moves" [08:27:15] if I cast my voice, I would bitch to get the configuration out of puppet manifests and in to a central store (such as puppet Hiera) [08:27:29] so which bits would the configuration be? [08:27:45] ah yeah the migration. We had that discussion with Faidon a while back, I agreed to refactor my manifests while migrating them to modules. [08:28:07] cause since one is working on the manifests, he can as well refactor them a bit and make them nicer. [08:28:28] yes, I think that's a fine approach, as long as it doesn't turn into a blockin approach [08:28:30] *blocking [08:28:44] with hiera, if you want to retrieve the ntp server, you would do something like hiera( $ntp_server ), no need for $::site / $::realm [08:29:10] hmm [08:29:13] New patchset: Foxtrott; "fix bug (autoedit does never finish on error)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289 [08:29:14] and in hiera you have a hash map that says something like: dc==pmtpa && realm==prod => ntp_server = 'some ip in pmtpa' [08:29:28] (I didn't pay much attention to that part of the resources/profiles/roles slides) [08:29:32] but then hiera means adding yet another layer to our already very complicated installation [08:29:33] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289 [08:29:44] there's going to be a layer one way or another [08:30:00] either it's a spaghetti layer that's not easily distinguished form the rest of what we have [08:30:06] or it's in hiera or somewhere else [08:30:29] we just need to decide what that layer looks like and how it's implemented instead of [08:30:42] doing what we do now which is to close our eyes to the problem [08:31:34] more or less :-) [08:31:55] a possibility would be to get a puppet consultant for a couple weeks to help drive the movement [08:32:00] sometimes more explicit layers makes things simpler [08:32:11] mm [08:32:18] New review: Foxtrott; "JS fix is duplicate of Ib433027469fbe8143ac4eb27f38eca0dabbeb4df" [mediawiki/extensions/SemanticForms] (master) C: -2; - https://gerrit.wikimedia.org/r/70745 [08:32:21] but then you still needs the team to agree on where it wants to go [08:32:39] exactly, the problem is more about us all buying into a single plan [08:33:31] Change abandoned: Foxtrott; "Don't need it anymore. Don't have the time to do this properly." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/50943 [08:34:54] apergos: agreeing on a goal and building the roadmap of steps to reach that is definitely the hard part [08:35:06] sure is [08:35:18] hopefully the ops team likes to reach consensus [08:35:35] so it might take some time, but I am confident it will be done. Might take a few weeks though [08:35:35] mm [08:36:00] I'm not sure true concensus on some tings is ever reached [08:36:05] *things [09:06:58] New review: Krinkle; "I know this has been dumped and pasted for years, but doctor please, no more of these, eh.... Let's ..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/69298 [09:08:18] New review: Krinkle; "This is seriously freaking me out... http://cmi.memecdn.com/805/95805.jpg" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [09:11:38] New patchset: Hashar; "Revert "Register resources with absolute path"" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70805 [09:12:04] New patchset: Hashar; "Revert "Register resources with absolute path"" [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/70806 [09:12:09] New review: Foxtrott; "See inline comments." [mediawiki/extensions/Lingo] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/70742 [09:12:20] Change merged: jenkins-bot; [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/70806 [09:12:37] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70805 [09:41:58] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [09:42:30] New patchset: Euvl; "improvements for 8e9bd87ede91cc5e07bcf79480bb31b34522ff67 commit" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807 [09:44:59] New patchset: Matmarex; "Further improve load order of RC and watchlist styling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [09:46:13] New review: Matmarex; "Linked bug 49610 (created in the meantime) in the commit message." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/68601 [09:47:00] New review: Tpt; "Two minor detail and it should be good." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/70610 [09:49:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [09:53:14] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [09:55:13] Change abandoned: Euvl; "failed with gerrit" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807 [09:56:08] Change restored: Euvl; "Or not" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807 [09:56:36] New review: Foxtrott; "Please do not implement fixes on patches as new patches. Instead fix the original patch. See http://..." [mediawiki/extensions/Lingo] (master) C: -2; - https://gerrit.wikimedia.org/r/70807 [09:58:09] New review: Euvl; "Thanks, yeah I understood that I failed with it already but didn't find a way to change the situation" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807 [09:58:33] New review: Tpt; "Yes! Let's go for unit tests!" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: 2; - https://gerrit.wikimedia.org/r/70610 [09:58:41] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [10:06:37] New review: Physikerwelt; "@Krinkle" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/69298 [10:13:45] New review: Raimond Spekking; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [10:28:07] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [10:33:36] New review: Matmarex; "Will this magically clear existing translations? (I tried to find someone from TWN on IRC yesterday ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [10:41:23] New review: Raimond Spekking; "Translations will be removed from the MessageXx.php file with the next export from translatewiki.net..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [10:43:38] New review: Matmarex; "Awesome, thanks :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70803 [10:44:40] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [10:44:56] New review: Matmarex; "I think 'position' => 'top' would still be useful if these modules were loaded with addModules or as..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70796 [10:45:35] New review: Hashar; "rebased to grand parent commit to get rid of a dependency that got merged meanwhile. Now I need to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [11:02:07] New patchset: Amire80; "Allow loading redirects in Common languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [12:07:48] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [12:08:10] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [12:09:01] New review: Hashar; "rebased. I have included all changes made between the original version and the tip of master:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [12:18:00] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [12:18:18] New patchset: Hashar; "test: skip math parser tests when missing $wgTexvc" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [12:34:31] New patchset: VitaliyFilippov; "Allow to create new SVG files using SVGEdit" [mediawiki/extensions/SVGEdit] (master) - https://gerrit.wikimedia.org/r/70814 [12:40:57] New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [12:42:52] New patchset: VitaliyFilippov; "Show SVGEdit WikiEditor "SVG drawing" button on preview, not only on the initial edit." [mediawiki/extensions/SVGEdit] (master) - https://gerrit.wikimedia.org/r/70815 [12:46:44] New patchset: Euvl; "Ability to turn off the recognition of glossary terms in certain places." [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70742 [12:48:01] Change abandoned: Euvl; "(no reason)" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807 [12:51:19] New patchset: VitaliyFilippov; "Query user for the filename of SVGs inserted via WikiEditor button." [mediawiki/extensions/SVGEdit] (master) - https://gerrit.wikimedia.org/r/70817 [12:53:31] New review: Matmarex; "Code style." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60871 [12:57:34] New review: VitaliyFilippov; "Can someone merge these changes to this extension?" [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65977 [13:05:33] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [13:09:32] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [13:47:31] is there a bot in this channel that will ping me when somebody appears? [13:50:08] I think !notify will do that zeljkof [13:50:22] @notify [13:50:24] MartijnH: thanks! [13:50:36] or what hashar said ;) [13:50:39] yeah petan wrote a bot for it [13:50:45] might want to do that in #wikimedia-labs [13:50:48] hi [13:50:51] hashar: thanks to you too :) [13:51:06] hashar, MartijnH: is there any documentation about that? [13:51:08] it doesn't matter where you do it :P [13:51:11] yes [13:51:13] This bot is running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.10.8.15 source code licensed under GPL and located at https://github.com/benapetr/wikimedia-bot [13:52:29] petan: thanks! :) [13:52:41] @notify rachel99 [13:52:42] I'll let you know when I see rachel99 around here [13:52:56] thanks wm-bot, you are such a nice bot :) [13:52:57] Hey zeljkof, you are welcome! [13:53:39] look at that, wm-bot is even a polite one! :) [13:54:08] wm-bot: <3 :) [13:54:08] Hi petan, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [13:54:15] meh [13:54:29] petan: :) [13:55:30] I wanted to make a small workshop related to wm-bot and improvements on irc on hackaton but I completely forgot that :D [13:56:45] petan: that would be fun [14:01:03] New patchset: Anomie; "Rework CentralAuth login flow" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [14:03:16] Yippie, build fixed! [14:03:17] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #162: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/162/ [14:03:28] New review: Foxtrott; "I like it." [mediawiki/extensions/Lingo] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/70742 [14:06:19] New patchset: Euvl; "Support for multiple definitions per term" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70802 [14:27:23] New patchset: Euvl; "Support for multiple definitions per term. Used Coding conventions" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70802 [14:33:23] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/SVGEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/70817 [14:48:52] New patchset: Rjain; "Added the db schema" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [14:54:13] New patchset: Rjain; "Added the db schema" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70794 [15:03:41] New patchset: Zfilipin; "Fix logging in for upload wizard tests" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70824 [15:04:59] New review: Zfilipin; "For this to work, see comment 8 of bug 50130" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70824 [15:15:15] New patchset: VitaliyFilippov; "Query user for the filename of SVGs inserted via WikiEditor button." [mediawiki/extensions/SVGEdit] (master) - https://gerrit.wikimedia.org/r/70817 [15:15:46] New review: VitaliyFilippov; "Oops, sorry, that whitespace actually isn't needed at all." [mediawiki/extensions/SVGEdit] (master) - https://gerrit.wikimedia.org/r/70817 [15:25:07] 'git' 'push' 'origin' 'wmf/1.22wmf8' [15:25:07] To ssh://gerrit.wikimedia.org:29418/mediawiki/core.git [15:25:07] ! [rejected] wmf/1.22wmf8 -> wmf/1.22wmf8 (non-fast-forward) [15:25:07] error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/mediawiki/core.git' [15:25:07] To prevent you from losing history, non-fast-forward updates were rejected [15:25:08] Merge the remote changes (e.g. 'git pull') before pushing again. See the [15:25:10] 'Note about fast-forwards' section of 'git push --help' for details. [15:25:13] git exit with status 1 [15:25:27] Ugh. Never mind [15:25:31] I cannot apparently count today [15:27:12] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [15:45:33] New patchset: Aude; "Update branch for Wikidata" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/70828 [16:03:58] that site should be phased out to somewhere else I guess [16:04:07] maybe we can migrate the /conf/ to doc.wikimedia.org [16:04:30] which is on CI server [16:05:26] New patchset: Aude; "Update Wikidata extensions" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70833 [16:05:32] reedy@fenari:/home/wikipedia/common-before-tin$ git pull [16:05:32] Updating dc3cec9..06c499c [16:05:32] fatal: Not a git repository: /home/wikipedia/common/.git/modules/docroot/bits/WikipediaMobileFirefoxOS [16:05:32] arfhgha [16:05:50] New review: Aude; "requires installing the WikibaseDataModel extension." [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70833 [16:05:57] https://gerrit.wikimedia.org/r/#/c/70833/ but make sure the dependency is there first [16:06:17] at least before deploying [16:06:40] Want me to add the new submodule? [16:06:45] yes [16:06:46] still deploying the first round of code from tin [16:06:46] * Reedy waits [16:06:57] I'll do it from somewhere else [16:06:59] New patchset: Demon; "Fix misconfiguring of a bunch of extensions." [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/70834 [16:07:01] ok [16:07:04] Change merged: Demon; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/70834 [16:08:07] ^demon: seems there are more and more extensions that are not up to date :( [16:08:21] <^demon> VisualEditor broke itself again, which is confusing. [16:08:28] I wrote a lame shell script to monitor it [16:08:30] <^demon> The rest of them were added in batch by someone who didn't know what they were doing. [16:08:36] <^demon> And did it wrong. [16:08:38] ah might be me :-) [16:08:43] <^demon> No, it wasn't. [16:08:55] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70833 [16:08:57] I pasted a lame shell oneliner on https://bugzilla.wikimedia.org/show_bug.cgi?id=49906#c3 [16:09:05] git submodule foreach 'test "$(git rev-list HEAD..origin/master --count)" = "0" && echo "Up to date." || echo "ERROR!"' [16:09:16] yes, it seemed like not very many submodule updates [16:09:18] when i ran that [16:10:52] New patchset: Matmarex; "Remove the EditSectionLink hook" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64364 [16:11:41] New patchset: Reedy; "Add WikibaseDataModel" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70835 [16:15:26] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [16:16:47] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [16:17:05] <^demon> hashar: If you pull from master, you'll see all those have been fixed I think. [16:17:40] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70835 [16:18:09] ^demon: some are still around [16:18:28] <^demon> Oh, well they're fixed in the config. [16:18:37] <^demon> Next time something merges on one of them, they'll update. [16:22:12] New patchset: Hashar; "script to verify Gerrit synchronization" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/70836 [16:22:36] ^demon: ^^^ : [16:22:56] checkout them all to master, pull and commit the change ;) [16:22:57] New patchset: Anomie; "Separate RevDel logic from UI" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70748 [16:22:57] Change merged: Demon; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/70836 [16:23:26] the poor bugzilla plugin did not update my bug :( [16:23:34] the commit you merged was referencing https://bugzilla.wikimedia.org/show_bug.cgi?id=49906 [16:26:05] <^demon> Dangit, it was working this AM when we updated. [16:26:09] <^demon> Will have a look at the plugin later. [16:30:25] New patchset: CryoKey; "Fixed link URL in README" [mediawiki/extensions/CryoKey] (master) - https://gerrit.wikimedia.org/r/70837 [16:31:11] Change merged: CryoKey; [mediawiki/extensions/CryoKey] (master) - https://gerrit.wikimedia.org/r/70837 [16:37:24] New patchset: Anomie; "Add API action=revisiondelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [16:37:26] Platonides, I'm trying to schedule the GSoC meeting. Is tomorrow at 6pm good for you? [16:37:38] New patchset: Anomie; "Add API action=revisiondelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [16:37:47] Platonides, check the emails from csteipp and anubhav if you haven't yet, please. [16:38:22] Platonides, 6pm your time [16:42:42] Platonides, I updated the schedule. Please confirm the invitation or complain. Thank you. [16:48:14] New review: Brian Wolff; "looks fine to me" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/69826 [16:50:31] New patchset: Aaron Schulz; "Made runJobs.php respect time limits better and try to bail before OOMs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70781 [16:50:51] New patchset: Hashar; "triggers for pywikibot-*" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70844 [16:51:17] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [16:51:55] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70844 [16:56:29] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [16:58:51] ^demon, the latest dashboard includes a 'status' column but it's blank for everything except Recently Closed entries [16:59:34] <^demon> That's just because it's shown as its own search result column now. [17:00:03] <^demon> It'll show draft, or submitted too [17:01:43] New patchset: Hashar; "pywikibot/* : fix gerrit names" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70847 [17:02:16] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70847 [17:02:46] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [17:02:55] ^demon, something else I noticed after I enabled "Display Person Name In Review Category" - I thought that the bold entries on 'Incoming Reviews' meant that you hadn't reviewed the change, but actually I have some bold '-1 Alex Monk' [17:03:07] What does bold text actually mean there? [17:03:18] <^demon> Bold means you haven't personally reviewed it [17:03:23] umm [17:03:32] <^demon> Supposed to, at least [17:04:52] it's doing the same thing on your dashboard as well... https://gerrit.wikimedia.org/r/68485 is bold but is marked Code-Review-2 Demon [17:05:02] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).. Change-Id: I71e3f559ad18a05909fcf4d93ebaccd7dd1c8037" [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [17:06:39] hashar: Jenkins appears to have broken on https://gerrit.wikimedia.org/r/#/c/70767/ [17:07:00] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)...." [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [17:07:28] It did "Starting gate-and-submit jobs" but nothing after that and there's nothing on the status page to show that it's running any jobs for AF [17:08:29] Krenair: looking [17:08:43] yeah I got a stack trace [17:08:49] it could not merge it [17:08:52] fatal: "--force-message" is not a valid option [17:08:59] ^demon: --force-message has been removed from Gerrit :-( [17:09:37] <^demon> --force-message? [17:09:37] <^demon> Remind me [17:09:46] it is being used when submitting a patch to make sure the report is send even if the change has been closed [17:09:59] that happens when someone force merge without waiting for gate-and-sbumit to complete [17:10:07] so the gerrit review --force-message is always used [17:10:10] and that is no more support [17:10:12] ed [17:10:57] filling a bug [17:12:36] ^demon: https://bugzilla.wikimedia.org/show_bug.cgi?id=50300 :) [17:13:03] <^demon> hashar: Not a bug, we just want to use --message. [17:13:13] <^demon> commit c2713185777832936fc2242780a9bf09594f3874 [17:13:13] <^demon> Author: David Pursehouse [17:13:13] <^demon> Date: Wed May 1 11:05:51 2013 +0900 [17:13:14] <^demon> Remove `--force-message` option from the `review` command [17:13:16] <^demon> [17:13:18] <^demon> Since 8c850ec the review message is always added even if labels [17:13:20] <^demon> could not be applied, making the `--force-message` option redundant. [17:13:22] <^demon> [17:13:23] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)....." [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [17:13:24] <^demon> Remove the option from the command and the documentation. [17:13:26] <^demon> [17:13:28] <^demon> Change-Id: Id10f8f4dc77988670584dea622e6708942320780 [17:16:18] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [17:17:08] ahh [17:18:31] New patchset: Hashar; "remove force-message got removed from Gerrit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70849 [17:19:20] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70849 [17:20:23] reloading zuul [17:21:10] New review: Hashar; "Zuul / Gerrit had a bug ( bug 50300 ) retriggering merge." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/70767 [17:21:18] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [17:21:56] ^demon: fixed! thanks for the hint :-] [17:22:00] i am off now [17:23:18] off heading back to home [17:28:34] New review: Krinkle; "I agree. Also, it isn't unlikely for addModulesStyle to perhaps become position aware when we refact..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70796 [17:32:12] New patchset: Reedy; "Update Wikibase to head of mw1.22-wmf6" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70852 [17:33:19] New patchset: Reedy; "Update Wikibase to head of mw1.22-wmf6" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70853 [17:33:25] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [17:34:55] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70852 [17:34:56] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70853 [17:39:41] New patchset: MaxSem; "Allow to adjust commit mode" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/70638 [17:43:39] New review: Krinkle; "Don't add the Enabler as a global variable. Make it a local variable or add it to the mw.libs host o..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [17:44:49] qgil: when is the test today? [17:46:56] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70748 [17:51:37] New review: Yurik; "Why not make this a part of "action=delete"??? It seems like that would be a perfect location for th..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70749 [17:53:15] New review: Bsitu; "I will merge this for now since the diff link in email is strongly desired." [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/64876 [17:53:27] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [18:03:53] hi matanya sorry I was in a meeting. Mmm what test? [18:04:19] hi, sorry i bothered. isn't there something with cucumber? [18:04:38] browser testing or something? [18:04:57] matanya, ah yes, 7pm: http://www.meetup.com/wikimedia-tech/events/124334432/ [18:05:20] matanya, more details at https://www.mediawiki.org/wiki/Meetings/2013-06-27 [18:05:38] oh, a real meeting. i'm way too far [18:05:39] matanya, will you join? [18:05:56] matanya, where are you? [18:06:01] i'm 10 hours behind your time zone [18:06:12] matanya right... [18:06:46] but if i can help in IRC, that is cool too :) [18:06:46] matanya, you can still join our tech talk in a bit more than 1h... https://www.mediawiki.org/wiki/Meetings/2013-06-27-midday [18:07:23] matanya, if you are awake, we are having hangout & IRC on since there are others interested [18:08:02] good, if i only would use google products [18:08:24] * matanya is PRISMed [18:08:50] qgil: doesn't the wmf have some foss meeting tool? [18:08:56] matanya, I'm very happy to investigate free alternatives. In any case for you it's just a YouTube video stream [18:09:06] agreed [18:09:13] New review: CSteipp; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [18:09:25] though I would love a free alternative [18:09:42] matanya, marktraceur just told me yesterday about http://videoconf.wikimedia.ch/ [18:09:56] took my words out of my keyboard [18:10:09] matanya, but I don't know how it is in terms of max capacity and streaming [18:10:10] and there is freepbx as well that gives this [18:10:40] We use this at my work place [18:11:00] you can have online meetings that are limited only by your hardware [18:11:02] matanya, I'm convinced about defaulting to free options. The rest is just my ignorance about current options (after years of trying and spending more time than desired) [18:11:34] it is out of scope i guess, better focus on mediawiki [18:12:10] matanya, well, I don't mind trying something different e.g. in a next meeting or tech talk, and if it doesn't hold then fallback to hangout [18:12:26] matanya, actually I'm interested, just ignorant [18:13:38] i'll remind my self to build a POC for this [18:14:11] New patchset: Anomie; "Add mw.logObject" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/70857 [18:16:52] New review: Brian Wolff; "nitpicks on the messages." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [18:20:37] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64251 [18:21:05] Yippie, build fixed! [18:21:06] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #76: FIXED in 8 min 39 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/76/ [18:21:26] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68817 [18:24:49] New review: Matmarex; "Let's do this." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64251 [18:25:43] LEEEEEEEEEEEEEEEEEERRRRRRRRRRRRRRRRRRRRRRRRRRROOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY [18:26:13] New review: Anomie; "@Yurik: Because page deletion and RevDel are two very different things, despite the similarity of th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [18:27:26] heh Reedy [18:27:56] HUDSON [18:28:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64251 [18:29:49] Yippie, build fixed! [18:29:49] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #76: FIXED in 8 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/76/ [18:30:02] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [18:30:50] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70748 [18:32:07] Yippie, build fixed! [18:32:08] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #114: FIXED in 8 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/114/ [18:34:07] New patchset: Reedy; "Add Echo" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/70860 [18:37:05] New review: Manybubbles; "(1 comment)" [mediawiki/extensions/GeoData] (master) C: 1; - https://gerrit.wikimedia.org/r/70638 [18:37:39] New patchset: Matmarex; "Allow uca-sv@collation=standard to be a collation name." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55498 [18:39:33] New review: Se4598; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [18:39:55] New review: Matmarex; "Rebased." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/55498 [18:42:44] New patchset: Matmarex; "updateCollation.php: sanity check the collation before proceeding" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64503 [18:43:13] qgil: and also https://openmeetings.apache.org/ but i'm sure you checked that one already [18:43:15] New review: Matmarex; "I fixed it and now it should actually work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64503 [18:43:48] New review: MarkTraceur; "I'd +2, but if you think this is hacky then maybe we should wait for a better solution?" [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/70027 [18:45:49] New review: Matmarex; "Let's do this too." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/55498 [18:46:19] New patchset: Kaldari; "Remove the feedback link from the flyout - no longer needed" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69961 [18:48:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55498 [18:54:12] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [18:55:56] New patchset: Matmarex; "Improve language handling of page titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [18:56:59] matanya, no, I didn't. I tell you I'm an ignorant in videoconference setups, and I mean it. :) [18:57:18] New patchset: Hashar; "fix pywikibot prefix" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70863 [18:57:52] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70863 [18:58:57] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #163: FAILURE in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/163/ [18:59:10] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)....." [pywikibot/core] (master) - https://gerrit.wikimedia.org/r/70845 [18:59:41] New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596 [19:06:25] New patchset: Se4598; "getHumanTimestamp() now also returns time for timestamps in same year" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [19:19:26] New review: MarkTraceur; "Getting there! A few nitpicks about function definitions, and I'll merge it." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50760 [19:19:41] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70752 [19:20:50] New review: Yurik; "@anomie, I am assuming that action=delete removes a page by its pageid or title, and deleterevision ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [19:21:28] New patchset: Reedy; "Add archive, externallinks PK" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51675 [19:21:36] Woah, that rebased [19:22:46] New review: Anomie; "Instead of assuming, you should actually go look it up if you don't know." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [19:28:08] New review: Mattflaschen; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69826 [19:29:49] New patchset: Foxtrott; "bugfix (timeline loaded partially)" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/70867 [19:30:32] New patchset: Brian Wolff; "Preserve returnto when upload requires logging in" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69826 [19:31:23] qgil: Tech talk? [19:33:31] New review: Brian Wolff; "re-submit" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/69826 [19:33:32] Change merged: Brian Wolff; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69826 [19:34:27] 1min anomie [19:36:18] http://etherpad.wikimedia.org/currentmeeting [19:36:27] http://youtu.be/z9gEH-EqNFo [19:36:45] http://www.mediawiki.org/wiki/Meetings/2013-06-27-midday [19:38:37] can you see the stream? [19:39:00] New patchset: Spage; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70869 [19:41:13] does http://youtu.be/z9gEH-EqNFo work for you? [19:42:02] qgil: Yes, works fine here [19:42:43] anomie, good, because apparently it doesn't for for some of us here... weird [19:42:47] * bawolff can see it [19:44:16] lol, much more than 1 or 2 bad guys on wikipedia for some definition of bad :P [19:45:19] So, hang the browser for 5-10 seconds per request? [19:46:14] anomie: yeah, didn't like that part [19:46:30] anomie et al, when it's a question for the speaker please quote me so I can distinguish from just comments, thanks! [19:47:08] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [19:47:30] I guess people who want to do complex things either are inherently evil or need a special pass [19:48:00] greg-g: I've never trusted those editors with over a million edits [19:48:07] totally [19:49:19] but, seriously, let's just start using this, have our browser test be bitcoin mining [19:49:34] Only if it gets sent to my wallet :) [19:50:50] how big a deal is DOS attacks for us anyways. I feel like its not that big an issue in general [19:51:06] OMG Jidini can pass his system.. [19:52:19] New review: Yuvipanda; "Consider abandoning, since almost all of the current Campaign code will disappear when https://githu..." [mediawiki/extensions/UploadWizard] (master) C: -2; - https://gerrit.wikimedia.org/r/70027 [19:52:31] qgil: Re obfuscated javascript requires the botnet to emulate a browser: Just use nodejs. [19:53:09] Nischayn22: you should checkout https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/3 :) [19:53:22] Nischayn22: as well as mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace proposal [19:53:30] which is what is being implemented [19:53:36] heya, those on the video, are the camera views changing around? [19:54:25] I only see his document on the youtube stream [19:54:42] bawolff: that's probably fine, it isn't changing around like when MaxSem talks? [19:55:04] nope. Just showing some document with the title "Beer garden" [19:55:11] cool [19:55:23] The problem that's typically experienced with computation captchas is how do you compensate for varying devices -- everything from the mobile user to those with power desktop processors -- how do you load down the desktop users without killing the mobile user? [19:55:42] but the right hand side is changing as he, the presenter, is clicking on things. Like right now the Experiments page? [19:55:48] "sophisticated attack" as in overloading with ab instead of browser? [19:55:52] qgil: ^ mwalker's comment [19:56:06] greg-g: yeah, its on Experiments page now [19:56:11] cool [19:56:16] * bawolff wonders what the mediawiki diff attack is [19:56:30] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [19:56:31] Loads of people asking for expensive diffs? [19:56:34] ok, 1 min anomie mwalker [19:57:14] I wonder which one of those attacks is "action=purge on Barack Obama, pre-Scribunto" [19:57:23] hah [19:57:26] hey everybody watching the stream of the tech talk, it's Chip. [19:57:43] anomie: lol [19:57:43] Just wanted to let you know that Google+ is acting up at the moment, and I can't tell if video views are changing [19:57:54] so I'm going to keep it on the screenshare, no camera - sorry :-/ [19:57:59] anomie, even post-Scribunto, it's quite nice;) [19:58:05] they're seeing his docuemnt fine, cndiv_ [19:58:18] ok good to know greg-g [19:59:11] anomie: but on a serious note, I can think of other rather expensive things - Special:contribs of top only in ascending order of user:Cluebot_II [20:00:05] we don't use FastCGI, lol [20:01:18] I imagine that running 100 fastcgi threads would play some serious problems with APC performance [20:01:24] https://xkcd.com/669/ [20:01:30] Krinkle: Is there some magic I need to perform to get @source and @example to work with jsduck/ [20:01:34] ? [20:02:00] anomie, lololololol [20:02:05] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [20:02:38] OK, @example works if I do it properly. [20:03:24] I imagine this would really screw over people using user scripts to do mass editing [20:04:14] yep [20:05:01] The typical wmf emergency server settings: "We are supported by donations" [20:05:27] bawolff: and then a link to a server that's on the same overloaded cluster :p [20:07:03] Shame PHP never caught up with other languages on the ability to do async request handling [20:07:16] New patchset: Spage; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70910 [20:07:18] any questions? [20:07:34] <^demon> greg-g: How many roads must a man walk down? [20:07:57] Or at least sync without redoing worker setup each time [20:08:00] ^demon: shh you [20:10:21] New review: Nischayn22; "In that case its more reasonable to get in?" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [20:10:43] Can you hear Adam? [20:10:45] can anyone hear adam?? [20:10:52] yes [20:11:03] thanks! [20:11:03] slightly quiet, but still definitely audiable [20:11:09] working on that... [20:12:07] how's the audio now? [20:12:15] dude, adam's slide template is awesome [20:12:24] awjr: agreed [20:12:28] It might be still a tad quiet, but pretty much good enough [20:12:40] that's better [20:12:49] the mic right now is dangerously hot, we've asked him to speak up a little... [20:13:07] I just don't want to feedback and rip everyone's eardrums :-) [20:13:11] thanks [20:13:17] rofl: "tubz" [20:13:20] New review: Yuvipanda; "Special:UploadWizardCampaign(s) is going away, will be rm'd soon." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [20:13:40] Krinkle: NVM, just removing [20:13:44] New patchset: Spage; "Update Campaigns to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70911 [20:14:12] marktraceur: Don't use @example, it is a special annotation in jsduck to do example iframe code editing [20:14:30] marktraceur: To show code, just use "Example: " and indent code with 4 spaces (5 in total from the * symbol) [20:14:52] 1 empty line before and after [20:14:55] Ah K [20:15:04] Krinkle: And now I see the source tag in your ruby file [20:16:22] * marktraceur considers copying that over [20:16:25] Probably not worth it [20:17:59] questions for Adam so far? [20:18:37] We supposedly put X-Frame-options: deny for anything vulnrable [20:18:54] qgil: What was the page that his tool was reporting should have the x-frame-options [20:19:03] and should it actually have it [20:19:41] bawolff: I think it was ResourceLoader's load.php? [20:19:53] bawolff, ok, 1 min [20:20:12] load.php shows plain text, there should be little value to it showing in a frame. [20:20:16] We set it on output page [20:20:24] by default [20:20:41] certain pages disable it when they need/want to allow embedding [20:20:45] this is to prevent click jacking [20:20:46] I don't think you can do click jacking on a js page [20:21:14] Krinkle: you sure, i think we do that the other way, put the option only on pages you can click jack for [20:21:32] + all special pages get x-frame-options off by default [20:22:40] s/off/on [20:22:49] but normal pages (that don't have a patrol link on it) shouldn't have x-frame-options set [20:24:09] bawolff: Article.php, line 559 and line 1128 [20:24:37] bawolff, sorry, do I still need to ask the question or is what anomie replied? [20:24:41] New review: Spage; "cd5a77e is latest" [mediawiki/core] (wmf/1.22wmf8) C: 2; - https://gerrit.wikimedia.org/r/70910 [20:24:51] qgil: not really, he kind of moved on in his presentation [20:25:11] anomie: yes. Those lines tell mediawiki to not set x-frame-options [20:25:11] sorry, didn' want to interrupt his demo [20:27:15] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf9) - https://gerrit.wikimedia.org/r/70869 [20:27:27] New patchset: MarkTraceur; "Add jsduck docs for ConfirmCloseWindow" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70912 [20:27:41] * marktraceur causes trouble in the UW repo [20:27:53] bawolff: define "a js page" ? I don't have the context of this conversation [20:28:23] click jacking is the process of iframing a page, making it visible, showing a button in a certain place in a parent (evil) frame, and when the user clicks it, they end up clicking on something inside Wikipedia [20:28:30] Krinkle: I mean if it was load.php the scanner tool was complaining about, you can't clickjack something that is simply a text/javascript file [20:28:40] (e.g. delete article, patrol something, unblock user etc.) [20:28:55] what scanner tool [20:28:57] so in that case, it would be a false positive [20:29:02] The one in the presentation [20:29:09] what presentation (sorry) [20:29:21] Krinkle: https://www.youtube.com/watch?v=z9gEH-EqNFo&feature=youtu.be [20:29:39] New review: Spage; "0311e41 is latest (already in 1.22wmf9 branch)." [mediawiki/core] (wmf/1.22wmf8) C: 2; - https://gerrit.wikimedia.org/r/70911 [20:29:43] New patchset: MarkTraceur; "Add jsduck docs for ConfirmCloseWindow" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70912 [20:29:53] bawolff: Estimation where in the stream roughly? [20:29:54] Krinkle: sorry, without that context, my previous comment made probably no sense [20:29:56] any questions [20:30:08] Like about 15 minutes ago [20:30:16] sorry [20:30:22] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70910 [20:30:40] wait is that qgil talking right now? [20:30:40] YuviPanda: yes [20:30:48] heh, first time I'm seeing him f2f :) [20:30:51] bawolff: peer garden? [20:31:03] Krinkle: that was the first one, then OWASP ZAP [20:31:24] OK, I"m not looking it up [20:31:31] what it is the problem [20:31:39] that's ok [20:31:45] is something failing due to load.php denying iframe? [20:32:20] Krinkle: in the presentation he had a vulnrability scanner that was complaining the x-frame-options: deny header was not being set [20:32:53] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70911 [20:32:57] It was kind of unclear which page, but possibly complaining about load.php (which wouldn't make much sense) [20:38:46] New review: Mattflaschen; "Krinkle is right that MathJaxEnabler should not be global. However, per https://www.mediawiki.org/w..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/69298 [20:39:51] bawolff: Ah, about it *not* being set. [20:39:52] Interesting [20:41:03] That's a false positive I think. Though I don't have the context, at first glance I'd say using x-frame-options for cross-domain *script* security is imho not very good move. It is good in general, but if you need it to secure scripts, you're in trouble because there's a dozen other ways that can still get at it. [20:42:05] We protect it via and session, tokens and cross-origin instead. The token is the biggest wall, from there even with the token both ajax and iframe disallow reading of the iframe contents if from another origin. [20:42:53] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68817 [20:44:37] hmm, is there no hook for 'this page just got deleted'? [20:44:45] that gives me the Content rather than just the WikiPage? [20:51:35] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [20:57:32] New patchset: Hashar; "migrate mediawiki-core-phpunit-* to slaves" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70917 [20:57:55] New patchset: Hashar; "migrate mediawiki-core-phpunit-* to slaves" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70917 [20:59:42] New review: Hashar; "deployed and verified :-)" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/70917 [20:59:42] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70917 [21:02:15] New review: Kaldari; "I think there may still be legitimate uses for the pretty format. Regardless, pretty should not be r..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70763 [21:03:29] greg-g 58 minutes of deploy window for sale cheap! [21:08:43] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [21:08:44] New patchset: MarkTraceur; "Clean up the jsduck docs after first two patches" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70919 [21:13:03] New patchset: Ori.livneh; "Standardize executable names; bump version to 0.6" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/70920 [21:13:50] spagewmf: this offer won't last long, folks! [21:16:14] New patchset: Ori.livneh; "Standardize executable names; bump version to 0.6" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/70920 [21:18:35] New patchset: MarkTraceur; "Clean up the jsduck docs after first two patches" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70919 [21:18:39] New review: Foxtrott; "LingoElement already supports multiple definitions per term. Just change addDefinition() so it accep..." [mediawiki/extensions/Lingo] (master) C: -2; - https://gerrit.wikimedia.org/r/70802 [21:18:40] btw Krinkle / bawolff, I'm just reading the scrollback of your conversation. The only issue is if load.php ever showed and edit token, then someone could do a redressing attack to steal the token-- e.g., iframe the token in a window, and tell the user on another site it's a "captcha", etc. [21:20:39] New patchset: Mattflaschen; "changed the remote ext path to Annotator instead of prototyping inline comments" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/70801 [21:21:07] New patchset: Se4598; "getHumanTimestamp() now also returns time for timestamps in same year" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [21:24:28] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/70920 [21:25:37] New review: Se4598; "going with Kaldari as theres no reason for me to remove it although it was introduced with the same ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [21:28:11] New patchset: Foxtrott; "bugfixes: use correct data from web request, setup parser" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70745 [21:30:11] Change merged: jenkins-bot; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70745 [21:32:17] New review: Yury Katkov; "I agree with Stephan. the changes are not needed" [mediawiki/extensions/Lingo] (master) C: -1; - https://gerrit.wikimedia.org/r/70802 [21:43:30] csteipp: Indeed, though there are more straight forward attacks possible if load.php would show tokens [21:43:50] csteipp: Such as overloading the JSON parser and/or array prototype and just make the ajax request [21:44:08] the browser will parse it as javascript instead of json, and you can get it that way. [21:44:40] That was the reason we re-enforced proper content-type and no more tokens under any conditions [21:45:18] e.g. in older firefox json served through ajax but with text/javascript insteads of aplication/json as content-type would trigger js parser instead of json parser, which means user land Array/Object prototypes are "used". [21:46:48] Krinkle: that is what I thought I remembered, but good to know for sure. Thanks! [21:47:06] New patchset: GWicke; "Sync up with Parsoid tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70922 [21:48:43] New review: Platonides; "?The idea behind the format was that since the date occurs more than 5 days ago that the time does n..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [21:51:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70922 [21:53:26] New patchset: Aaron Schulz; "profiler: log slow methods that worsen DB locks in transactions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70923 [21:53:55] New patchset: Aaron Schulz; "profiler: log slow methods that worsen DB locks in transactions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70923 [21:54:19] New review: Aaron Schulz; "Can be triggered in eval.php like:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70923 [21:55:04] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [21:59:51] New patchset: MarkTraceur; "Add UWUI to the jsduck docs" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70925 [22:05:42] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70925 [22:08:15] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70925 [22:08:59] Krenair: In short, this is a doc patch, I'm not changing the code as much as possible [22:09:53] New patchset: MarkTraceur; "Add UWUI to the jsduck docs" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70925 [22:23:26] marktraceur, yeah, so no -1 [22:23:37] Grazie :) [22:23:52] I mean, a +1 would be nice, +2 even better... [22:24:21] I'd have to do the "Massive refactor" patch first though wouldn't I? [22:30:16] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [22:31:58] marktraceur: ? [22:32:41] Ah, yeah. Sorry :) [22:32:50] Krenair: I mean, you could totally review that too [22:36:58] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [22:41:08] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [22:50:16] New review: Cmcmahon; "This change still does not get us to a working test. With MEDIAWIKI_URL set correctly, after logging..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/70824 [22:52:28] New patchset: MarkTraceur; "(bug 37128) Add a remove icon to categories, plus style changes" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9141 [22:53:36] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [22:54:41] New patchset: MarkTraceur; "(bug 37128) Add a remove icon to categories, plus style changes" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9141 [22:55:14] New review: MarkTraceur; "thedj, your issue with the first category is a non-issue, the "delete" on the first category field i..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9141 [22:59:07] New patchset: MarkTraceur; "Add UWUI to the jsduck docs" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70925 [23:07:44] New patchset: MarkTraceur; "Add a remove icon to categories, plus style changes" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9141 [23:08:04] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [23:08:13] New patchset: MarkTraceur; "Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [23:09:27] New patchset: MarkTraceur; "Allow "next" without completing all uploads" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/11004 [23:10:52] Yippie, build fixed! [23:10:52] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #164: FIXED in 39 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/164/ [23:12:50] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:14:28] Yippie, build fixed! [23:14:28] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #131: FIXED in 42 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/131/ [23:15:42] New review: Parent5446; "Just for the record, I was not the one who came up with the pretty format. My patch was ported from ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [23:19:32] New patchset: Spage; "Improve out-of-date campaigns-desc" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70938 [23:22:50] New review: Cmcmahon; "Sorry, did not read this carefully, use https instead of http on test2wiki. " [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/70824 [23:22:53] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70824 [23:25:20] Change merged: jenkins-bot; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70938 [23:33:26] hello, I am having trouble performing rollbacks using the MediaWiki API. I'm doing a POST with jQuery, I have the rollback token, but my user is not authenticated, I feel like that must be required, e.g. must have rollback rights. [http://www.mediawiki.org/wiki/API:Rollback] does not cover this