[00:03:10] TimStarling: the patch permitting null return vals from hook functions was merged, and I'd like to send a quick note to wikitech-l about it. What do you think we should recommend for new code? Should we make explicit 'return true' a code convention, since it buys you backwards-compatibility and costs nothing? Or should we assume that without "enforcement" (i.e., hard crashes) the convention is bound to erode anyway? [00:04:38] brb [00:07:14] I would not have merged that [00:09:23] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70046 [00:11:50] AaronSchulz: It's never too late for a "revert wall of shame" in Gerrit. Since fixme is revert + comment nowadays [00:18:54] Change abandoned: Krinkle; "(no reason)" [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/15781 [00:19:55] TimStarling: you +1'd it [00:20:48] that doesn't mean I would have merged it [00:21:16] if I would have merged it, I'd have given it +2 [00:21:19] New review: Matmarex; "Your change actually broke a script on pl.wikisource that depended on wgCanonicalNamespace being loc..." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/66106 [00:22:01] TimStarling: I assumed that in the absence of any negative comments your +1 was meant to give more people a chance to weigh in [00:22:10] brion, specifically [00:22:18] and he did? [00:22:21] yeah [00:22:45] ok, that may possibly be acceptable [00:23:01] don't be all hyperbolic now [00:25:07] so what, if anything, is substantively wrong with the change or how i went about getting it merged? [00:25:53] New review: Wikinaut; "The following queries were generated when merging user 35 with user 1 (looks good to me, but I notic..." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [00:26:07] greg-g: you happen to be there? [00:27:24] New review: Parent5446; "Few minor things. Almost good to go." [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/69017 [00:27:52] is this some kind of meta zen koan about the absence of a veto being tantamount (or not) to tacit approval [00:31:13] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [00:38:23] New patchset: Matmarex; "Fix history and add section tabs being collapsed on RTL wikis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70569 [00:38:55] New patchset: Matmarex; "Fix history and add section tabs being collapsed on RTL wikis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70569 [00:39:07] New review: Matmarex; "Meh, jshint." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70569 [00:40:42] New patchset: Wikinaut; "Combine text and ID update fields" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [00:43:09] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [00:43:43] New review: Parent5446; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [00:48:19] New patchset: Wikinaut; "Combine text and ID update fields" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [00:49:26] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [00:52:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69583 [00:52:25] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [00:55:29] New review: Parent5446; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [01:02:32] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [01:02:54] New patchset: Matmarex; "Further improve load order of RC and watchlist styling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [01:03:36] New patchset: Wikinaut; "Combine text and ID update fields" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [01:03:59] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [01:07:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70569 [01:08:10] New review: Matmarex; "Caused bug 50196." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [01:19:09] New patchset: Catrope; "Fix history and add section tabs being collapsed on RTL wikis" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70576 [01:24:49] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70576 [01:52:40] New patchset: Mattflaschen; "Refresh Apache on php5-redis install." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70577 [02:09:01] New review: Wikinaut; "When will this become available ? At least some extensions need such code." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [02:25:49] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [03:25:13] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [03:34:17] New patchset: Ori.livneh; "In .gitreview: defaultrebase=0" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70584 [03:34:28] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70584 [03:36:19] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #73: FAILURE in 8 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/73/ [03:36:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #111: FAILURE in 8 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/111/ [03:45:09] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70585 [03:55:36] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70585 [03:56:06] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70586 [03:56:17] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70586 [04:20:59] New review: Ori.livneh; "(1 comment)" [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/70577 [04:22:04] New review: Ori.livneh; "You should also 'include apache' if you're going to notify the Apache service" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70577 [04:27:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64182 [04:33:02] New patchset: Hiong3-eng5; "SpecialPage:OWDownloads" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [04:38:55] New review: Hiong3-eng5; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:01:48] New patchset: Ori.livneh; "Refresh Apache service on php5-redis install" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70577 [05:02:01] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70577 [05:10:54] New patchset: Hiong3-eng5; "SpecialPage:OWDownloads" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:18:17] New review: Hiong3-eng5; "my changes are up to here unless there is any need for corrections." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:27:46] New review: Tim Starling; "I've been thinking about our use of the local timezone since I flamed the PHP Internals list on this..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971 [05:35:26] New patchset: MZMcBride; "date_default_timezone_set unneeded in Parser" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971 [05:46:27] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [05:47:49] New patchset: Nischayn22; "Show a disabled form for users without permissions." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [05:51:19] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [05:55:58] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [05:56:48] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70588 [06:01:00] New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [06:01:15] New patchset: Nischayn22; "Add a redlink to dead duplicate file links" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [06:02:17] New review: Nischayn22; "@TheDJ that helped, I will submit a change for jquery.ui.theme.css as well." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [06:06:04] New review: Tpt; "Some details" [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/69973 [06:09:02] New patchset: Nischayn22; "Added CSS to properly color links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70589 [06:12:22] New patchset: Nischayn22; "Added CSS to properly color links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70589 [06:14:14] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [06:19:30] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [06:20:04] New patchset: Nischayn22; "Add HTML5 drag and drop support" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [06:20:25] New review: Nischayn22; "Rebased" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [06:23:36] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [06:30:26] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [06:31:21] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [06:33:57] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [06:45:34] New patchset: Nischayn22; "Add HTML5 drag and drop support" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/3808 [06:46:40] New review: Nischayn22; "Still fails on Chrome, unable to detect Webkit version correctly" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/3808 [06:47:25] New review: Nikerabbit; "Can you provide steps to reproduce the issue?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66325 [06:56:31] New patchset: Nischayn22; "Add flickr templates to uploads from flickr." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [06:57:06] New review: Nischayn22; "I don't have the templates to test this. Help appreciated!" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [07:00:36] is git review broken for other people too? [07:00:43] AttributeError: StrictVersion instance has no attribute 'version' [07:02:00] blah [07:02:03] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70588 [07:02:07] vim `which git-review` [07:02:12] Nikerabbit: Depends on the version I guess [07:02:16] put 'return False' on line 166 [07:02:23] after def latest_is_newer(): [07:02:30] to short-circuit that [07:02:45] i haven't seen that before [07:04:03] ori-l: well, apparently it went away now that I ran git review --update (no idea what it is supposed to do) [07:04:43] there's a lot of wtf in git-review, plenty for everyone [07:05:36] you can also edit /etc/git-review/git-review.conf [07:05:38] and add: [07:05:40] [updates] [07:05:42] check=false [07:12:47] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [07:21:46] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70588 [07:23:16] Nikerabbit: https://bugs.launchpad.net/git-review/+bug/1098873 [07:23:29] did you ctrl-c while git-review appeared to be hung? [07:26:17] ori-l: I typed wrong command so I did ctrl+c [07:26:57] i'm fixing it [07:31:03] heh [07:31:17] http://stackoverflow.com/questions/14293727/how-do-i-fix-strictversion-instance-has-no-attribute-version-in-git-review [07:31:20] superm401: ^ [07:36:05] New patchset: Nikerabbit; "Update some docs in Translate.php" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/70592 [07:42:10] New patchset: Shirayuki; "Spelling: Successfully" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/70594 [07:42:36] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70417 [07:42:59] New patchset: Amire80; "Update IME from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70595 [07:43:56] New review: Foxtrott; "(1 comment)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70544 [07:45:22] New patchset: Krinkle; "doc: Improve documentation for mw.Map and mw#config" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70596 [07:55:55] New patchset: Shirayuki; "Spelling: successfully" [mediawiki/extensions/Premoderation] (master) - https://gerrit.wikimedia.org/r/70598 [07:58:44] New patchset: Tpt; "(bug 50215) {{{pagenum}}} is not fill at the loading of a new Page: page" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70599 [08:11:06] I am going to restart Jenkins to apply some plugins updates. Expecting 15 - 20 minutes downtime. [08:20:36] New review: Tpt; "Reviewed" [mediawiki/extensions/ProofreadPage] (master) C: 2; - https://gerrit.wikimedia.org/r/70393 [08:35:42] New review: Matmarex; "Redlinks' colors differ per skin." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70589 [08:36:09] New review: Matmarex; "Ah, this is just for Vector, so I guess it's okay." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70589 [08:37:42] New review: Matmarex; "Visit any page with more than one line of langlinks. For example https://pl.wikipedia.org/wiki/Lech_..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66325 [08:41:12] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70596 [08:52:41] New patchset: Nikerabbit; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70595 [08:53:39] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70595 [08:54:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66325 [08:58:42] New review: Tpt; "Jenkins fails" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70393 [08:58:58] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70393 [09:02:06] New patchset: Santhosh; "Sort the language modules based on id" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70601 [09:13:48] New patchset: Santhosh; "Sort the language modules based on id" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70601 [09:18:24] New patchset: Siebrand; "Basic support for Apache Cocoon i18n format" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/70602 [09:21:53] New patchset: Siebrand; "Basic support for Apache Cocoon i18n format" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/70602 [09:22:54] New patchset: Tpt; "(bug 47011) Wikilinks of Index: pages are mishandled if they contain a ":"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [09:24:37] New patchset: Siebrand; "Basic support for Apache Cocoon i18n format" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/70602 [09:31:57] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [09:33:58] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [09:47:25] New review: Tpt; "Looks like you haven't removed onEditFormPreloadText and onArticleSaveComplete from ProofreadPage.bo..." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [09:48:44] New review: Tpt; "(1 comment)" [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/69973 [09:51:42] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [09:57:02] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:04:56] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:08:50] New review: MaxSem; "Meh." [mediawiki/extensions/GeoData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64202 [10:09:00] Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/64202 [10:13:17] New patchset: Tpt; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:13:54] New review: Tpt; "Fix a type error" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:15:33] New review: Tpt; "Is fine now." [mediawiki/extensions/ProofreadPage] (master) C: 2; - https://gerrit.wikimedia.org/r/69973 [10:15:40] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:16:28] New review: Tpt; "Reviewed by Aarti" [mediawiki/extensions/ProofreadPage] (master) C: 2; - https://gerrit.wikimedia.org/r/70404 [10:16:38] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [10:22:47] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/70605 [10:25:46] New patchset: Nikerabbit; "Sort the language modules by id" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70601 [10:26:32] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/70605 [10:27:45] New review: Tpt; "Reviewed by Aarti" [mediawiki/extensions/ProofreadPage] (master) C: 2; - https://gerrit.wikimedia.org/r/70599 [10:27:55] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70599 [10:33:01] New patchset: Hashar; "use tmpfs in jenkins user homedir" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70607 [10:33:01] New patchset: Hashar; "mwext testextensions job now on slaves" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70608 [10:35:28] Change abandoned: Daniel Kinzler; "LoadBalancer needs to be changed to handle exceptions appropriately first." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70197 [10:36:44] Change abandoned: Daniel Kinzler; "The Database interface needs a isReadOnly() function first." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70196 [10:38:25] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70607 [10:38:37] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [10:38:38] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70608 [10:43:59] New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [10:44:43] Change abandoned: Santhosh; "I1bc5a4ac2788d20d2bdba6454bd278a3b4681168" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70588 [10:47:30] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [11:00:02] New patchset: Hashar; "test: coverage recording now needs to be explicit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125 [11:08:34] New patchset: Amire80; "Allow loading redirects in Common languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [11:11:08] New patchset: Rtdwivedi; "Beginning of Page pages refactoring." [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) - https://gerrit.wikimedia.org/r/70610 [11:28:23] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70601 [11:33:53] New patchset: Siebrand; "Reduce usage of globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [11:34:06] Change abandoned: Siebrand; "Oops, meant to abandon." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [11:34:35] New review: Siebrand; "Is this still needed or should I abandon this?" [mediawiki/core] (chinese-collation) - https://gerrit.wikimedia.org/r/48798 [11:55:59] New patchset: Hashar; "benchmarks: README file having run recommendations" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66066 [11:56:56] New review: Hashar; "Lets apply this change without waiting for jenkins to be fixed." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66125 [11:58:06] Reedy: if you are still around, I could use a review / merge of https://gerrit.wikimedia.org/r/#/c/66140/2/maintenance/mwdocgen.php,unified [11:58:15] that tweaks mwdocgen.php to support multiples parameters to --file [12:00:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125 [12:00:26] comma separation sounds icky [12:00:52] want carrot or sharp separation ? :D [12:00:59] --file=foo,bar,again [12:01:31] someone suggested to add that support directly in the Maintenance class [12:15:19] New patchset: Hashar; "mark parsertests with option 'texvc'" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [12:15:51] New review: Hashar; "The option is now named 'texvc'. Will update the mediawiki/core change https://gerrit.wikimedia.org/..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [12:19:32] New patchset: Hashar; "test: skip math parser tests when missing $wgTexvc" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [12:20:03] New review: Hashar; "Now recognize 'texvc' option in parser tests files, keeping 'math' around for back compatibility." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [12:27:34] New patchset: Hashar; "GuidedTour PHPUnit and Qunit tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70617 [12:40:10] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [12:40:37] New review: Phe; "+1 ok" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [12:42:08] New review: Tpt; "Some points" [mediawiki/extensions/ProofreadPage] (pagePagesRefactoring) C: -1; - https://gerrit.wikimedia.org/r/70610 [12:50:11] New patchset: Amire80; "Allow loading redirects in Common languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [12:52:34] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [13:00:16] New patchset: Reedy; "mwdocgen: support multiple --file values" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140 [13:07:30] New patchset: Hashar; "zuul layout validation needs a public conf file" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70625 [13:08:28] New review: J; "looks like something did not work out during rebase." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [13:12:15] New review: Hashar; "This change needs to be manually rebased on top of master." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [13:19:27] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70114 [13:31:01] New patchset: Hashar; "GuidedTour PHPUnit and Qunit tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70617 [13:32:17] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70617 [13:33:57] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70625 [13:35:02] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70629 [13:37:33] New patchset: Hashar; "GuidedTour : check-only -> check" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70630 [13:37:56] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70630 [13:38:59] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70629 [13:39:16] Change merged: jenkins-bot; [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/70391 [13:40:49] Change abandoned: Hashar; "https://bugzilla.wikimedia.org/show_bug.cgi?id=49032 is now fixed :)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70629 [13:51:15] qchris: ^demon: hi :) [13:51:26] Hi hashar :-) [13:51:27] seems Buck is being packaged so we will be able to install it on the CI server [13:51:31] and migrate your jobs to use it [13:51:38] That'll be great. [13:51:52] I checeked before and the change was +2 but not yet merged. [13:52:06] Reedy: Ping? [13:52:08] <^demon> Yeah, I wondered that too. [13:53:01] Ohai [13:53:20] qchris: we can ping ops to get the package build and uploaded to apt.wm.o [13:53:29] qchris: or maybe whoever voted +2 is waiting for a second review [13:53:37] James_F: Wasssssssup? [13:53:46] Ok, I'll do that. [13:53:56] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=50226 seems to be a RL caching bug. [13:54:44] Reedy: Any chance of a touch/purge? :-) [13:55:17] Touching/purging anything in particular? :p [13:57:55] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/70583 [13:58:12] New review: Alex Monk; "oops... trying again" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [14:02:59] Reedy: Sorry, touching VisualEditor code in deployment. [14:03:10] Reedy: wmf7 and …8 [14:03:14] What files? [14:03:32] seeing as you have loooooads [14:11:41] New review: Anomie; "Why is the theme overriding the link colors at all, if we care about redlinks and such?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70589 [14:12:44] New review: Wikinaut; "Tyler:" [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/69017 [14:16:23] ^demon: I am manually triggering builds for various java projects to make sure they execute on the 'gallium' Jenkins slave [14:16:59] <^demon> So is gallium the slave now? [14:17:29] yeah I have setup a slave on gallium [14:17:40] will do the announce on some of the list whenever I am done [14:17:59] unless you have hardcoded paths to /var/lib/jenkins , you should be fine :) [14:19:56] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:20:43] <^demon> hashar: So what's the master now? [14:20:51] still gallium [14:21:01] New patchset: MaxSem; "Allow to adjust commit mode" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/70638 [14:21:01] so gallium server has both a Jenkins master and a Jenkins slave [14:21:12] the master is known has "master", the slave has "gallium" [14:21:14] <^demon> Gotcha [14:21:22] Reedy: Any JS file will do (RL will see the module's changed), apparently. [14:21:24] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:21:26] then whenever we have the second server, it will be slave as well [14:21:35] and jobs can freely roam between gallium and the new server :-] [14:23:25] New review: Anomie; "PS10: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:32:38] Yippie, build fixed! [14:32:39] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #158: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/158/ [14:33:10] Yippie, build fixed! [14:33:10] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #125: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/125/ [14:41:19] New patchset: Zfilipin; "Fixed failing login test" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70639 [14:44:53] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70639 [14:44:53] New review: Manybubbles; "Looks good to me. I left some comments but they aren't required." [mediawiki/extensions/GeoData] (master) C: 1; - https://gerrit.wikimedia.org/r/70638 [14:53:53] Nikerabbit: uga? [14:56:07] $foo = getenv( 'BAAAA' ) || 'foo'; [14:56:11] that doesnotwork sniff :( [14:58:41] New patchset: MaxSem; "Allow to adjust commit mode" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/70638 [15:01:34] Nikerabbit: ping? [15:02:31] hashar, thanks for following up on the GuidedTour tests [15:04:10] superm401: and the best is that the tests are passing :-] [15:04:20] :) [15:06:10] New review: Manybubbles; "(1 comment)" [mediawiki/extensions/GeoData] (master) C: 1; - https://gerrit.wikimedia.org/r/70638 [15:06:20] New patchset: Hashar; "ExtraSettings.php sets tmpfs to Jenkins user homedir" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/70642 [15:07:41] YuviPanda: ugaga sorry [15:23:35] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70442 [15:24:34] New review: Demon; "(1 comment)" [mediawiki/extensions/CirrusSearch] (master) C: -1; - https://gerrit.wikimedia.org/r/70535 [15:30:39] New patchset: Hashar; "ant: points sqlite.dir.tempfs to $HOME/tmpfs" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/70645 [15:31:23] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/70642 [15:31:23] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69944 [15:31:34] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/70645 [15:33:40] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70646 [15:41:01] New patchset: Manybubbles; "Add more profiling hooks." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70535 [15:41:43] New patchset: Manybubbles; "Allow users to fuzzy match." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [15:42:48] New patchset: Manybubbles; "TODO updates" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70537 [15:42:55] New patchset: Manybubbles; "Enable prefix search hook with full text flag." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70538 [15:47:24] James_F: there? :D [15:47:30] hoo: Yes! [15:47:34] hoo: Can I help? [15:48:09] I got a question (more out of interest): Would it be possible to create local accounts for all global accounts on Wikidata.org? [15:48:34] hoo: You mean, artificially create them? [15:48:46] Out of curiosity, why would you want that? [15:48:50] hoo: Is this for a cross-wiki gadget? [15:49:17] James_F: Not a gadget... a gadget would probably trigger the auto creation... [15:49:35] We plan to do server side cross wiki stuff and that only works if the account's are there yet [15:49:52] hoo: How urgent is this plan? [15:50:12] hoo: 'Cos we could just do the shortcut of renumbering all users to use the global IDs and get rid of the local user concept entirely. [15:50:13] ;-) [15:51:10] Not at all, everything will work without it... but as long as those local users aren't there some page moves on Wikipedia's wont be (automatically) propagated to WD.org [15:55:12] New patchset: Hashar; "mediawiki-core-install-sqlite is now on slaves" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70647 [15:55:43] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70647 [16:01:40] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/68126 [16:06:26] New patchset: MaxSem; "Allow to adjust commit mode" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/70638 [16:06:58] what can I do for that core dependency? https://gerrit.wikimedia.org/r/#/c/67399/ [16:07:04] aude: ^ [16:19:57] Change abandoned: Hashar; "cant remember what it was for." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65457 [16:20:22] New patchset: Reedy; "Don't upload if output looks erroneous" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/70648 [16:24:44] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70646 [16:32:46] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70649 [16:33:21] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70650 [16:34:24] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70650 [16:34:33] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70649 [16:37:42] New review: Liangent; "Just leave it here, or is it possible to transfer the ownership to me if you think it's cluttering y..." [mediawiki/core] (chinese-collation) - https://gerrit.wikimedia.org/r/48798 [16:39:05] New patchset: Zfilipin; "Fix failing login test" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70651 [16:42:37] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70651 [16:49:48] New patchset: Rachel99; "WIP add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [16:58:10] New review: Mdale; "Looks good, tested and working." [mediawiki/extensions/TimedMediaHandler] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70406 [16:58:10] Change merged: Mdale; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70406 [17:03:16] New review: Krinkle; "Don't use Verified (just Code-Review) on repos where jenkins-bot is in good condition. Unless there ..." [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/64202 [17:06:19] ori-l: Have a chance to look at my butchering of the vagrant repo? [17:14:38] New review: Siebrand; "No problem, I'll leave it here. I was just unsure if it was still needed." [mediawiki/core] (chinese-collation) - https://gerrit.wikimedia.org/r/48798 [17:19:31] marktraceur: i started last night but wasn't sure what was working and what wasn't [17:20:08] ori-l: Going to e.g. localhost:8080/drupal won't give you a drupal instance, despite my attempts to force it [17:20:08] Yippie, build fixed! [17:20:08] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #14: FIXED in 31 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/14/ [17:20:22] I suspect I'm thinking about it wrong [17:21:32] ok, i'll look today [17:25:07] Yay [17:25:19] ori-l: It's sort of necessary for testing that I did the civi stuff properly [17:25:45] * ori-l reviews [17:29:21] * marktraceur moves on to activemq which should be fusn [17:29:23] fun even [17:36:35] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70535 [17:45:50] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [17:48:42] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [17:49:15] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [17:55:34] Zaran, I'm trying to find your name / email address (sorry, too many GSoC people) :P [17:57:37] Zaran, ah, Thibaut. ok :) [17:58:42] New patchset: Yurik; "Updated Zero extension" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70661 [18:01:04] New patchset: Yurik; "Updated Zero extension" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70662 [18:02:09] Change abandoned: Yurik; "(no reason)" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70661 [18:02:19] Yippie, build fixed! [18:02:20] Project _debug-browsertests-template build #170: FIXED in 46 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/170/ [18:03:12] New patchset: Yurik; "Updated Zero extension" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70663 [18:03:39] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70662 [18:03:52] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70663 [18:08:31] New review: Demon; "If nobody uses it then how about we just axe it? We can make conscious design decisions to leave out..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [18:11:09] New review: Demon; "That being said, I'd love to see some actual numbers on how many people do use this. The people resp..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [18:12:32] New review: Manybubbles; "If it had been difficult to implement I'd have left it in the shouldn't do list but it was simple. ..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [18:15:39] New review: Hoo man; "A lot of nit picking... looks good despite... let's get global filters for production fast :)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/70583 [18:15:48] New review: Manybubbles; "For numbers - I grep-ed through a day's worth of search logs and almost all of queries that included..." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [18:18:49] New review: Demon; "Fair enough. If it becomes a problem, it's just as easy to discuss then and remove." [mediawiki/extensions/CirrusSearch] (master) C: 2; - https://gerrit.wikimedia.org/r/70536 [18:18:58] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [18:19:41] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70537 [18:21:05] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70538 [18:22:12] New review: MarkTraceur; "See inline" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [18:23:05] thanks ^demon - from here on out I swear I'll use branches for everything so merging isn't such a mess [18:24:17] New patchset: Foxtrott; "Escape tooltip only once" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70665 [18:28:26] Yippie, build fixed! [18:28:27] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #74: FIXED in 8 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/74/ [18:28:38] New review: Physikerwelt; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69872 [18:31:10] New patchset: MarkTraceur; "mv donationinterface.php DonationInterface.php" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/70666 [18:32:10] Yippie, build fixed! [18:32:10] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #112: FIXED in 9 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/112/ [18:34:24] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [18:36:34] New patchset: Foxtrott; "Escape tooltip only once" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70665 [18:36:40] New patchset: CSteipp; "Prevent custom messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [18:36:55] Change merged: jenkins-bot; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70665 [18:37:29] qgil: Rasel160, Micru, and I have successfully used BigBlueButton to do video conferencing before, I suggest we plan to use that instead. [18:37:59] I would encourage you to consider it for other meetings, but I suspect I'll be the only one who's enough of a stick in the mud to make noise about it. :P [18:38:11] qgil: In particular http://videoconf.wikimedia.ch/ is very helpful. [18:38:32] marktraceur, happy to use BigBlueButton for the first time [18:39:02] and happy to try alternatives, but not this time with 20 meetings. Will do from now on. I'm not in love at all with Google hangouts [18:39:07] New patchset: Cmcmahon; "WIP add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [18:40:40] New review: Cmcmahon; "VE references now happens inside an iframe that has no id" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [18:41:43] New review: CSteipp; "I'm leaning towards just forking it. It's not under active development, and I fixed a bug in it in t..." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70315 [18:43:51] New review: Mdale; "Looks good, tested with 69480" [mediawiki/extensions/MwEmbedSupport] (master) C: 1; - https://gerrit.wikimedia.org/r/69479 [18:44:15] New review: Mdale; "Looks good, but must be merged at the same time as 69479 and I don't have +2 on MwEmbedSupport" [mediawiki/extensions/TimedMediaHandler] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/69480 [18:55:35] New patchset: Mwalker; "Merge branch 'master' into wmf_deploy" [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/70668 [18:56:02] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/70668 [18:57:40] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #159: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/159/ [19:06:59] New patchset: Ori.livneh; "Make extension entrypoint match repository name" [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/70670 [19:08:04] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #126: FAILURE in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/126/ [19:09:02] New review: Ori.livneh; "(See )" [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/70670 [19:10:58] Published patchset: Wikinaut; "code cosmetics: changing from Xml to Html class in most cases" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/70671 [19:11:53] New review: Wikinaut; "Remark related to my previous comment:" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [19:12:22] New patchset: Wikinaut; "code cosmetics: changing from Xml to Html class in most cases" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/70671 [19:19:20] Krinkle: I think I've covered all of your concerns re: https://gerrit.wikimedia.org/r/#/c/60783/ [19:23:10] New patchset: Ori.livneh; "Add 'fundraising' role" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [19:28:28] New patchset: Ori.livneh; "Add 'fundraising' role" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [19:31:05] New review: Ori.livneh; "Katie / Mwalker: could you look at templates/fr-config.php.erb and give it a quick sanity check? If ..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [19:31:27] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #15: FAILURE in 33 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/15/ [19:38:19] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [19:44:40] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [19:49:09] New patchset: Ori.livneh; "Add 'mediawiki.ui' CSS module to all pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [19:54:49] ori-l: Sorry, we went to lunch [19:55:01] New review: Mattflaschen; "I gave Rahul a hand with the rebasing. It looks like we missed a couple minor things, and there's a..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [19:55:35] marktraceur: if the PHP settings get a nod from an additional FR eng, I'm cool with merging it [19:55:48] Coolio [19:55:56] Wait...the vagrant patch? [19:56:03] yeah, i updated it [19:56:14] Oh! [19:56:16] I removed drush / drupal with the suggestion that we make that a separate patch [19:56:21] Ahhhh. [19:56:43] and i reworked the mediawiki stuff somewhat [19:58:12] OK [19:58:26] ori-l: Do you have some concept of what I did wrong with the drupal setup? [19:59:21] Also K4-713 / mwalker ^^ [19:59:26] no, i haven't looked at it yet. my suggestion to defer it to another patch was based on the fact that the mediawiki FR setup was already sufficiently involved and more or less discrete [19:59:36] Heh. Yeah. [19:59:59] New review: Daniel Friesen; "Can you explain why Echo loading this on every logged page means that this has to be loaded for ever..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70740 [20:00:32] Change merged: Mwalker; [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/70670 [20:00:45] ori-l: "More or less" since most of the moving parts will actually require integration with drupal and civi [20:00:53] And...activemq [20:01:03] (I think that's all the parts) [20:01:06] * K4-713 looks at backscroll, nods as helpfully as possible [20:02:25] marktraceur: right; the fact that role is not enabled by default makes it OK (in my opinion) to merge it even though it's not complete [20:02:37] Sure sure [20:02:54] New patchset: Euvl; "Ability to turn off the recognition of glossary terms in certain places." [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70742 [20:04:05] New review: Matmarex; "Per Daniel, as far as I know that module is only needed in the places where it's actually used." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70740 [20:05:24] marktraceur: Have you considered keeping them sort of modular on purpose? Like, if somebody had a reason to run the pipeline out of three distinct VMs or something? [20:05:28] Instead of just the one. [20:05:42] New patchset: IAlex; "(bug 49840) Moving a page with subpages may lead in the page being moved twice" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70743 [20:05:46] Hrm [20:06:39] K4-713: I can't see that taking a lot of extra work, but for vagrant I'm not sure it's necessary - I'm mostly targeting someone who just needs _an_ environment, not necessarily a specific kind (like with separate VMs) [20:06:55] Unless there's some reason to consider that a core use case, [20:07:02] s/,$// [20:07:40] I guess... [20:07:56] marktraceur: I don't think it would take a lot of extra work [20:08:07] ...how much of a PITA would it be, to just have the one instance and test something like... upgrading the activeMQ environment? [20:08:10] you could still have a single role that includes all modules [20:08:15] Because we need to do that sometimes. [20:08:20] And it's usually horrifying. [20:09:18] New patchset: Swalling; "Add 'mediawiki.ui' CSS module to all pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [20:09:27] K4-713: I doubt it would be hard to test such a thing - you'd just use the version we'll enable (that part of the puppet files isn't written yet), run a few laps through the pipeline, then upgrade. [20:09:45] Then at least you can know what you'll likely have to watch for [20:09:53] Being able to do it in parallel would be cute, though. [20:10:15] so what are the three distinct machine roles? [20:10:17] Yeah, now that I think about it ori-l is right, it's possible [20:10:22] * ori-l isn't familiar with the setup at all [20:10:24] ori-l: mediawiki, drupal+civi, activemq [20:10:25] Yippie, build fixed! [20:10:25] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #96: FIXED in 31 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/96/ [20:10:55] So the frmediawiki role should work for the 0th one [20:10:59] yeah, that seems eminently doable [20:11:05] Coolio [20:11:45] kickin'. This will save me some brain cells, for sure. :) [20:12:36] New patchset: Cmcmahon; "Use page text for check, @browser.text makes test flaky" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70744 [20:12:51] is there anything that is currently included in https://gerrit.wikimedia.org/r/#/c/69618/ that more properly belongs in the activemq or drupal/civi roles? (I'm thinking of rsyslog specifically) [20:13:09] ori-l: rsyslog is for the payment processing bits of DonInt, so no [20:13:43] cooool. /me merges. [20:13:54] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [20:13:58] New patchset: Mattflaschen; "Add 'mediawiki.ui' CSS module to all pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [20:14:36] ori-l: OK so hopefully I can rebase on top of that and submit the new patch for drupal? [20:15:13] it'll probably take some deft git footwork, but yes [20:15:19] * marktraceur has faith [20:15:40] can anyone fix #wikimedia-operations ? [20:18:56] New review: Mattflaschen; "From talking to Ori, I think the main purpose of the commit is to make the CSS classes available to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [20:20:51] ori-l: Wait, you're using proper extension calls to set up the extensions? I'm not sure if that's necessarily kosher with our actual setup... [20:21:27] New patchset: Foxtrott; "bugfixes: Ajax error handler, use correct data from web request, setup parser" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70745 [20:22:06] New review: Swalling; "I tried to update the commit message so it sounds less like Echo loading the module is the reason we..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70740 [20:23:08] marktraceur: proper extension calls? [20:23:29] ori-l: I mean, you're cloning from master of the extensions [20:24:39] Err. [20:24:43] * marktraceur re-reads manifest [20:25:14] well, what is the actual development process? this is a dev instance, not prod, so running everything off of master can make sense [20:25:23] I guess so [20:25:26] OK, fine [20:25:26] but if you'd rather mirror production as closely as possible, we can change that to use the submodule ref [20:25:44] ori-l: Did you miss the FRLocalSettings.php file in your commit? [20:26:21] no, i ported it to a puppet template [20:26:24] Ah. [20:26:25] read the commit :P [20:27:17] *nod* yes yes [20:37:40] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [20:38:34] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [20:48:06] New review: Brian Wolff; "Looks good." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/70227 [20:48:40] New patchset: Matmarex; "CologneBlue: Use search input and button generators from SkinTemplate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60212 [20:51:37] New review: Matmarex; "woot" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/60212 [20:51:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70227 [20:54:11] Exciting times we live in! [20:55:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68838 [20:57:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60212 [20:57:41] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/69978 [21:00:57] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [21:01:25] New review: Matmarex; "Makes sense, thanks for the explanation. But please fixup the commit message :)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70740 [21:02:10] Yippie, build fixed! [21:02:11] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #16: FIXED in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/16/ [21:06:44] New review: Rasel160; "MarkTraceur, Nischayn22, please let me know if you would like any other changes for this patch so i..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [21:08:36] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [21:12:52] New patchset: Ori.livneh; "Add 'mediawiki.ui' CSS module to all pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [21:14:29] New patchset: CSteipp; "Add methods to get raw request in WebRequest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70747 [21:14:43] New patchset: Anomie; "Separate RevDel logic from UI" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70748 [21:14:45] New patchset: Anomie; "Add API action=revisiondelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70749 [21:17:49] marktraceur: Re discussion over dinner earlier: https://github.com/trevorparscal/oojs/blob/master/src/EventEmitter.js [21:18:30] New patchset: Bsitu; "Remove unused i18n messages" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/70750 [21:18:52] Ta [21:19:55] I just realized it's lacking a feature [21:20:46] You can do emitter.disconnect( targetObj, { 'event': ['methods'] } ); , and even emitter.disconnect( targetObj ); to disconnect all bindings to an object, but you can't do emitter.disconnect(); to disconnect everything (yet) [21:21:00] Trevor was trying to use that in the commit I just reviewed and I pointed out that that feature doesn't actually work :) [21:21:01] New patchset: Mattflaschen; "Auto-scroll to guider." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70752 [21:21:22] New patchset: Mattflaschen; "Auto-scroll to guider by default." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70752 [21:24:40] marktraceur, this BigBlueButton... do you use Ubuntu? [21:24:55] qgil: I do [21:25:23] marktraceur, what did you use to install it? [21:25:31] qgil: To install...what? [21:25:50] qgil: BBB is running at http://videoconf.wikimedia.ch/ [21:25:51] marktraceur, ok... is it web based? [21:26:00] Ag, good [21:26:43] marktraceur, thanks, nevermind. :) [21:26:47] Change abandoned: Aaron Schulz; "Looks like we won't need this approach due to the redis queue in use now. The DB indexes would have ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52601 [21:30:15] New review: Swalling; "Seems like a sane default. I've tested the scrolling behavior in prod several times, and so far it i..." [mediawiki/extensions/GuidedTour] (master) C: 1; - https://gerrit.wikimedia.org/r/70752 [21:31:34] Yippie, build fixed! [21:31:35] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #127: FIXED in 29 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/127/ [21:31:43] RoanKattouw: is there no way to do signatures in VE? [21:31:53] Nope [21:31:57] Not meant for talk pages [21:32:03] -_- [21:32:18] https://www.mediawiki.org/wiki/Release_Management_RFP/NicheWork_and_Hallo_Welt <— not a talk page [21:32:28] signatures are useful for things other than talk [21:32:36] :( [21:32:39] does parsoid even support pre-save transforms? [21:32:43] * MatmaRex hopes it doesn't [21:32:49] I meant "discussion pages" as opposed to "talk namespace" [21:32:52] No, it doesn't [21:33:36] are we going to have a flow module for use cases like this? [21:33:51] That's the plan [21:33:52] how are we going to handle things like RFCs in the glorious VE future? [21:33:54] ah [21:33:55] ok [21:34:09] Flow, of course, would use mini-VEs for the comments [21:34:14] right [21:34:16] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70743 [21:34:19] (VE is embeddable, we already have inception in VE) [21:34:21] that sounds sane to me [21:34:29] RoanKattouw: is it called inception? :) [21:34:35] Not in the code [21:34:36] Yet [21:34:38] awwww [21:34:39] hahaha [21:34:48] Basically you can edit the caption of an image, and it'll pop open a (mostly) full editor [21:34:56] That caption can contain a reference --> another editor [21:34:57] I think that calls for a refactor [21:35:01] just to rename [21:35:14] which can contain a template --> dialog with setting thingies, and possibly future mini-editors [21:35:45] cool [21:36:09] also, I could use a final review for something https://gerrit.wikimedia.org/r/#/c/60783 [21:36:18] Krinkle did the last one [21:38:12] Ryan_Lane: rrrr, rebase and changes in the same commit ;-) [21:38:21] sorry :( [21:38:33] I should change the .gitreview in that extension [21:39:05] Ryan_Lane: Are you not in the office? Or hiding down behind your pair of monitors :P [21:41:37] New review: Matmarex; "No longer merges. I think the userlogin templates were replaced with Agora versions?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64517 [21:42:40] Ryan_Lane: Did something change in Gerrit? [21:42:46] I'm unable to git review -d anything [21:43:13] really? [21:43:16] nothing should have changed [21:43:25] I never use git-review -d [21:43:27] https://gist.github.com/Krinkle/5872006 [21:45:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70556 [21:45:46] New patchset: J; "ID3Handler::getID3 should be protected" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70757 [21:47:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69889 [21:48:05] New review: Mattflaschen; "Echo is logged in only. GuidedTour is available to anyone (however, other extensions may choose to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70740 [21:48:37] Ryan_Lane: https://gist.github.com/Krinkle/5872006 [21:49:04] New patchset: Matmarex; "Remove unnecessary clears" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [21:50:02] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140 [21:53:49] Ryan_Lane: Works :) https://gist.github.com/Krinkle/5872006/revisions [21:54:34] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [21:54:36] New patchset: Matmarex; "Remove unnecessary clears" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [21:56:11] New review: Matmarex; "Just a rebase sans the conflicting files (those changes are irrelevant anyway)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [21:56:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54584 [21:58:05] New patchset: Hoo man; "Prevent custom warning messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [21:58:25] bawolff_away: robla just lost his computer [21:58:29] FYI [21:58:42] ok. I thought it suddenly went quiet [21:58:48] New review: Hoo man; "Chris: I hope you don't mind, but while testing I came up with a nicer solution." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [22:01:08] marktraceur: he can't find it? [22:01:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [22:03:06] New review: Matmarex; "Some wording changes, hope you don't mind." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [22:03:09] New patchset: Matmarex; "Fix getPageDimensions failure handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [22:03:35] New review: Hoo man; "Shouldn't cause any trouble" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67848 [22:04:48] New patchset: Hoo man; "Prevent custom warning messages for global rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [22:04:49] New patchset: Bsitu; "Update email copy and remove unused messages" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/70761 [22:04:49] Reedy: Something like that [22:05:08] New review: Hoo man; "We no longer need this message" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [22:06:12] New review: CSteipp; "Not at all. That looks good to me." [mediawiki/extensions/AbuseFilter] (master) C: 1; - https://gerrit.wikimedia.org/r/70583 [22:08:25] New patchset: Se4598; "getHumanTimestamp() now also returns time for timestamps in same year" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [22:13:07] New review: Se4598; "This function was introduced with https://gerrit.wikimedia.org/r/45651" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [22:13:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67848 [22:14:36] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70747 [22:23:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [22:26:16] New patchset: Cmcmahon; "WIP, do not merge, demo for Zeljko" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70764 [22:27:35] New review: Cmcmahon; "this shows the issue with login, please see http://www.mediawiki.org/wiki/Auth_systems/SUL2#Redirect..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70764 [22:28:11] New patchset: J; "handle case where getStreamTypes returns no types" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70765 [22:28:46] New patchset: J; "handle case where getStreamTypes returns no types" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70765 [22:30:36] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70757 [22:33:47] Change merged: J; [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/69479 [22:34:01] Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69480 [22:37:29] New patchset: Bsitu; "Adding support for primary link in notification" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [22:44:11] New review: Parent5446; "Minor docs issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70748 [22:45:29] New patchset: Hoo man; "Fix global abuse log username" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [22:46:12] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70583 [22:46:33] New patchset: CSteipp; "Basic MediaWiki integration, library cleanup" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [22:48:17] New patchset: Hoo man; "Fix global abuse log username" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [22:48:19] New review: CSteipp; "Close enough for now. Thanks!" [mediawiki/extensions/OAuth] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69958 [22:48:20] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/69958 [22:48:48] New review: Parent5446; "Is there a compelling reason for this change? The idea behind the format was that since the date occ..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/70763 [22:50:17] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -1; - https://gerrit.wikimedia.org/r/70767 [22:51:00] Change merged: jenkins-bot; [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [22:51:21] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/70766 [22:52:20] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70747 [22:55:24] New review: Hoo man; "(1 comment)" [mediawiki/extensions/AbuseFilter] (master) C: -2; - https://gerrit.wikimedia.org/r/70767 [22:55:51] Change merged: Parent5446; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66066 [22:57:50] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [22:59:21] New patchset: Hoo man; "Revert "Change AbuseFilter to use UserCache instead of user_text fields"" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [23:00:17] New review: Hoo man; "Entirely remove the UserCache usage. It's just not yet ready for cross wiki usage. On top of that it..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [23:01:43] New patchset: Hoo man; "Revert "Change AbuseFilter to use UserCache instead of user_text fields"" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [23:01:56] New review: Hoo man; "Linked bug in commit message" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/70767 [23:05:25] New review: Se4598; "the reason is stated in the commit-msg." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [23:06:32] ori-l: Do you think it makes sense to have the git::submodule call? [23:06:40] Or should I just call exec every time? [23:11:41] Hrm. [23:13:36] New review: Bsitu; "how about notification-gettingstarted-link-text-get-started? This indicates that the link text is '..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [23:15:43] New review: Mattflaschen; "Ideally, the message key should tell you how the message is used/its significance, not the text (sin..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [23:17:10] New review: Mattflaschen; "notification-gettingstarted-link-text-get-started is probably alright, though, if we can't think of ..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [23:18:25] New patchset: Wikinaut; "code cosmetics: changing from Xml to Html class in most cases" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/70671 [23:19:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [23:19:59] Krenair: so, for https://gerrit.wikimedia.org/r/#/c/70767/4, which pages had bad user names? [23:20:30] If I recall they were local ID + name and not "0 ID + name" [23:27:49] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:32:06] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/GeoData] (refs/meta/config) - https://gerrit.wikimedia.org/r/70772 [23:32:34] New review: Krinkle; "Can be done from GUI, but doing via git for better logs." [mediawiki/extensions/GeoData] (refs/meta/config); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70772 [23:32:34] Change merged: Krinkle; [mediawiki/extensions/GeoData] (refs/meta/config) - https://gerrit.wikimedia.org/r/70772 [23:33:08] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [23:33:27] New review: Parent5446; "Hmm I see your point." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [23:34:19] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70555 [23:37:15] New review: Brian Wolff; "Not sure if it's really an issue for this commit. But shouldn't getStreamType have a stub implementa..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70765 [23:38:44] New patchset: Yurik; "Update Zero extension" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70775 [23:38:58] New review: Bsitu; "All right, I will update it to notification-gettingstarted-link-text-get-started for now, we can cha..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [23:39:31] New patchset: Yurik; "Update Zero extension" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70776 [23:39:40] New patchset: Bsitu; "Adding support for primary link in notification" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70766 [23:39:44] New patchset: Tim Starling; "database: Improve DatabaseMysql::masterPosWait() performance by caching the position" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [23:40:22] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70775 [23:40:22] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70776 [23:43:05] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70763 [23:43:23] New patchset: Katie Horn; "Limiting the GC orphan rectifier such that it will only mess with GC messages in the cc-limbo queue." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/70777 [23:43:38] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70778 [23:44:09] New patchset: Krinkle; "Add api action for getting console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [23:44:13] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70779 [23:44:29] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70778 [23:44:36] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70779 [23:45:38] New review: Wikinaut; "tested, ok." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/70671 [23:46:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [23:46:36] ori-l: git-review is your friend. [23:47:04] sometimes, but not consistently [23:47:08] Is it really appropriate that mobile web upload i18n-izes the upload summary when uploading to commons? [23:47:09] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70763 [23:47:39] bawolff: i18n-izes? [23:47:59] Elsie: translates the edit summary used for uploading the file on to commons [23:48:10] New review: Mdale; "tested looks good." [mediawiki/extensions/TimedMediaHandler] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70765 [23:48:11] Change merged: Mdale; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70765 [23:48:15] bawolff: Sounds like a feature. [23:48:22] Unless it's using the wrong language. [23:48:35] Well who's language [23:48:43] The uploader's? [23:48:47] whose [23:48:55] rand() language [23:48:58] commons is multilingual, but you can only have one language in the upload summary [23:49:17] and the uploader probably isn't the one who is going to be looking at the upload summary [23:49:41] but you're right, english isn't exactly the best choice either [23:49:42] Isn't the upload summary uneditable? [23:49:49] It is [23:49:53] Presumably if there were user control, it'd be in the user's language. [23:50:27] I mean, I can't imagine the Germans or the French using English in an upload summary, if they could. [23:51:48] That's a good point [23:52:16] aber englisch ist so geil [23:52:58] Then again, the user probably wouldn't say "Contributed image from Special:Uploads" or "Imagen donada desde el móvil" [23:53:27] I guess realistically, this was more a use case that tags were invented for instead of upload summary [23:53:42] New review: Krinkle; "Noticed a few minor issues I didn't catch until now that the code is in much better state." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/60783 [23:54:33] Ryan_Lane: Sorry for pushing it back this long, you can clean that up later if you want to push this sooner. Just making sure it gets done :) I can do the fix up too if you like. [23:56:44] bawolff: I don't see why tags are needed for mobile edits/uploads. [23:57:14] Personally I'd like to see everything have tags [23:57:30] that way you could search through logs/rc however you liked