[00:01:59] New patchset: Andrew Bogott; "Added a few log lines for failed account creation." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70351 [00:02:42] Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70351 [00:06:44] New review: Bsitu; "plus some js style issues outlined in patch set #9" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68817 [00:11:12] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [00:11:15] New patchset: Andrew Bogott; "Make explicit mention that shell name must be lowercase." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70353 [00:11:55] New patchset: Andrew Bogott; "Make explicit mention that shell name must be lowercase." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70353 [00:12:23] Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70353 [00:13:47] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70348 [00:15:32] New patchset: Ori.livneh; "Check for multiple arguments, tweak error message, add test." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154 [00:15:35] New patchset: Aaron Schulz; "Proposed SQL schema for OAuth tables" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/69958 [00:17:34] New review: Ori.livneh; "looks good + has tests + tests pass = +2" [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/65154 [00:17:57] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154 [00:20:15] New patchset: Mattflaschen; "Make buttonSpecs and allowAutomaticOkay both non-optional" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70356 [00:22:10] MatmaRex: BTW, I've done batch null-editing. [00:22:22] MatmaRex: It really depends if you're doing templates and/or only redirects. [00:22:47] Obviously long articles will take longer to save and require more processing overall than a redirect. [00:26:06] Elsie: hm, no, no templates there [00:26:14] actually, there might be some, when i think about it [00:26:17] so let's just skip them [00:26:52] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [00:27:09] i'm mostly wondering if i'd need some wait time between subsequent null saves, or if i could just go all out with this [00:27:13] csteipp: is that fine now? [00:27:35] since afaik normal save or a normal article doesn't trigger any jobs [00:28:00] apart from, say, mails to editors who have it on watchlist, but this being a null edit this is not an issue, too [00:30:19] ori-l there's still a weird eventlogging problem for mobilefrontend on betalabs - i commented on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=49723 [00:31:47] Go all out. [00:31:52] I did like twenty parallel processes. [00:32:09] I did over a million edits in a day, as I recall. [00:32:20] You're only doing 100K? [00:32:47] MatmaRex: ^ [00:33:57] New review: Aaron Schulz; "Any use of $wgRequest that can not be dependency injected should at least use RequestContext::newMai..." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70316 [00:35:55] Elsie: approximately, i guess [00:36:08] Elsie: https://pl.wikipedia.org/wiki/Specjalna:UnconnectedPages?iwdata=only [00:36:10] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [00:36:24] MatmaRex: Should only take a few hours. [00:36:36] Elsie: the 10.000th item starts with an 'E', so by extrapolating i calculated the wrok case to be about 100k :P [00:37:15] it looks like i'll have to screen-scrape that stuff, though [00:38:02] which is uncool [00:41:14] MatmaRex: Some null edits add a revision to the DB. [00:42:39] Elsie: in reasonable cases, or something like if the previous edit was from 2001 and is missing the trailing newline? [00:43:01] The latter. [00:43:06] Though not just 2001. [00:43:11] Lots of bugs over the years. ;-) [00:43:28] i think pl.wp didn't quite exist back theb [00:43:30] :P [00:43:34] then* [01:04:17] New patchset: Inez; "Adjust tests for gerrit 69509" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70365 [01:33:51] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [01:40:15] New patchset: Krinkle; "Update VisualEditor submodule to latest master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70367 [01:42:22] New patchset: Krinkle; "Update VisualEditor submodule to latest master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70368 [01:46:45] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70367 [01:48:10] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70368 [01:49:47] Reedy: marktraceur: Looks like UploadWizard in wmf7 still has undeloyed/unupdated changes pending on tin.eqiad.wmnet. submodule has been updated in git, but not yet applied/deployed. [01:53:31] Sigh. [01:53:43] I can just deploy it tomorrow. [02:02:38] New review: Krinkle; "I'd recommend documenting for clarity that not returning a value (or explicit null) will have the sa..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [02:15:21] New review: MZMcBride; "What's needed to get this merged/deployed?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [02:35:39] New review: Krinkle; "This change is good to go from a intend point of view. Some minor issues with the code." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/39792 [02:39:17] New review: Krinkle; "In its current state of intend (adding an alias) this is not going to be approved unless there is pr..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/62614 [03:25:57] Change abandoned: Ganeshaditya1; "Dont have the time right now to modify the patch" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62614 [03:33:31] Yippie, build fixed! [03:33:31] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #71: FIXED in 8 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/71/ [03:54:21] New review: Ori.livneh; "Krinkle, that's a good idea. I'll wait a bit for this to pick up some more reviews first, though, to..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [04:24:21] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/70356 [04:24:34] New patchset: Ori.livneh; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [04:28:24] Krinkle|detached: Thanks for reviewing https://gerrit.wikimedia.org/r/#/c/39792/17 :-) [05:02:53] Yippie, build fixed! [05:02:53] Project browsertests-en.wikipedia.org-linux-chrome build #145: FIXED in 3 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/145/ [05:15:38] ori-l: So to serve browsers SVGs, would it be simple enough to count the elements in an SVG and establish cut-offs for what's considered overly complex to render? [05:16:09] I wonder if it would make sense to store that... [05:16:13] New patchset: Hiong3-eng5; "SpecialPage:OWDownloads" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:16:54] Elsie: what's 'overly-complex'? [05:17:41] that is, what makes you worry about rendering performance? [05:17:57] I think the concern is that an SVG of a very complex map would be slow in a lot of browsers. [05:18:19] Let's find a silly example on Commons... [05:20:19] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #100: FAILURE in 4 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/100/ [05:22:27] https://upload.wikimedia.org/wikipedia/commons/f/fc/CIA_WorldFactBook_Time_Zones.svg [05:22:47] ori-l: I think some browsers wouldn't like to scale down an image like that. ^ [05:24:10] https://upload.wikimedia.org/wikipedia/commons/4/47/France_-_OSM_Mapnik.svg is the biggest by byte size, I think. [05:24:19] Trippy to watch it load in Chrome. [05:25:19] Plus a full SVG loading can be larger than a rasterized PNG, I guess. [05:25:44] That one is 83.44 MB. If the PNG worked, it'd surely be smaller. [05:26:37] Change abandoned: Hiong3-eng5; "Patch 3 did not go as I expected, I do not know how much damage it will cause the script." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:30:02] New review: Hiong3-eng5; "I did not know that if I abandoned change for patch 3, it means I abandon all." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [05:36:47] Elsie: well, that's an interesting case [05:37:43] :-) [05:37:45] * Elsie sleeps. [05:38:21] I was thinking of cases where the SVG and the PNG are meant to be rendered at roughly the same resolution [05:39:19] in those cases, it's true that the SVG can be computationally more expensive to render, but that's changing as more and more devices add hardware support for vector web graphics [05:40:01] plus it's usually *less* data across the wire, and that counts too, especially on mobile devices [05:40:57] a PNG that had the same level of detail as that SVG would not be smaller, I don't think [05:41:48] a 300px PNG would be, sure, but that's because it's essentially obliterating vast amounts of detail that the SVG simply doesn't show at that resolution [05:59:48] Change restored: Hiong3-eng5; "will try to correct this" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [06:00:29] New patchset: Spage; "Add campaign to login form's signup link." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [06:09:20] nayone here happen to know, if I just edit Local.php on virt0 is this sufficient to modify wiktech settings? I hunted aorund for something in puppet or any other git repo but cam eup empty [06:09:36] about to add a namespace so we can move all the outdated docs into it... [06:09:42] New review: Spage; "PS3 uses the shorthand for a $(document).ready() handler per Krinkle's suggestion. As it's the only..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [06:10:53] apergos: yes, that should be sufficient [06:11:26] ok, I guess that the rackspace instance or whatever it is just gets an rsync once in awhile? [06:11:54] AFAIK Ryan updates it manually [06:12:00] oh :-D [06:12:11] I guess that's "rsync" :) [06:12:12] guess I'll go look at that right after [06:12:37] well api picked em up so that's good [06:14:55] ok edited manually on rackspace too. thanks for the info [06:17:48] np! [06:19:35] New patchset: IAlex; "(bug 50025) rebuildall.php script needs database admin rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70371 [06:36:13] New review: Spage; "Without this, bad login after sufficient attempts uses the "To help protect against automated edit s..." [mediawiki/extensions/ConfirmEdit] (master) C: 2; - https://gerrit.wikimedia.org/r/68138 [06:36:19] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/68138 [06:52:20] New patchset: Tpt; "(bug 50154) The parameter of the header template should be in lower case" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70372 [06:54:06] Reedy: Hi! there is an other bug introduced by 1.22wmf8 related to ProofreadPage https://bugzilla.wikimedia.org/show_bug.cgi?id=50154 I have made a change, can you review it, please? https://gerrit.wikimedia.org/r/#/c/70372/ Sorry :-( [07:07:02] New patchset: Spage; "Add campaign to login form's signup link." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [07:14:44] New patchset: Pastakhov; "Add while loops (version 0.5.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [07:21:08] New patchset: Ori.livneh; "Add .jshintrc" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70373 [07:24:15] New patchset: Krinkle; "(bug 50025) rebuildall.php script needs database admin rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70371 [07:25:16] hashar: You're awake already? Ah, it's morning already there. [07:25:20] I'm still working :) [07:25:28] well, online at least. [07:25:41] yeah I am awake everyday at 7am thanks to my living alarm clock :) [07:25:55] New patchset: Ori.livneh; "triggers for mw/ext/Campaigns" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70375 [07:26:06] indeed, indeed. very impressive :) [07:26:39] New patchset: Ori.livneh; "jobs for mw/ext/Campaigns" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70376 [07:26:58] child :) [07:29:08] New review: Ori.livneh; "Self-merging since I worry that this file may need to be in place for the extension-checks Jenkins j..." [mediawiki/extensions/Campaigns] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70373 [07:29:08] Change merged: Ori.livneh; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70373 [07:34:25] New review: Nikerabbit; "I have a slight preference for the current behavior because of its explicitness, but this issue isn'..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [07:35:52] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70327 [07:38:25] ori-l: I have noticed your addition of Zuul triggers for the Campaigns extension [07:38:35] that needs jobs as well :-] [07:39:10] nm [07:39:11] !g 70376 [07:39:12] https://gerrit.wikimedia.org/r/#q,70376,n,z [07:39:25] New review: Nemo bis; "Fatal error: Call to a member function getLabel() on a non-object in /www/dev.translatewiki.net/w/ex..." [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/70332 [07:39:39] New review: Tim Starling; "I recommended this in 2007 when the exception was introduced, but Brion vetoed it." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70328 [07:39:57] New patchset: Ori.livneh; "Fix missing whitespace" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70378 [07:40:12] New patchset: Hashar; "jobs for mw/ext/Campaigns" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70376 [07:40:20] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70376 [07:40:30] New review: Hashar; "ori-l > well done!" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70376 [07:40:30] * Krinkle was just busy creating those ;-) [07:40:40] oh sorry, will let you proceed [07:40:44] no, go ahead [07:40:57] :) [07:41:00] hashar: Stop using mw/ext/.. there is no such thing [07:41:34] thanks for the jenkins/zuul setup; it's very useful. [07:42:04] Krinkle: that is shorter :-] [07:42:08] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/70378 [07:42:27] hashar: mwext- or mediawiki/extensions/, there is no such thing as mw/ext [07:42:38] ah I could go with mwext [07:42:53] New patchset: Krinkle; "mwext: Sort ext-name list alphabetically (case-insensitive)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70379 [07:43:04] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70379 [07:43:17] Sublime has a nice shortcut for sorting [07:43:40] oh [07:43:54] and timo I have a bug in JJB, it does not recognize the jobs when I pass them as arguments [07:43:55] hashar: I assume you're pushing to jenkins now the jobs created by the mwext-check-jobs boilerplate ? [07:44:03] aka : jenkins-jobs --conf jenkins_jobs.ini update config/ mwext-Campaigns-jslint [07:44:07] it just does not filter it [07:44:12] let me try [07:44:16] New review: Nikerabbit; "May I suggest that we either keep this as a upstream library as-is (so that we can pull in updates e..." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70315 [07:44:31] so I was wondering how you were updating a single job or a small subset of them [07:44:47] hashar: You do run the test first? that creates the job file [07:44:48] s [07:44:52] New review: Hashar; "jobs deployed in production" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70376 [07:45:02] https://www.mediawiki.org/wiki/CI/JJB#Deploy_changes [07:45:03] that works for me [07:45:08] ah I should read that maybe [07:45:09] I do it almost every day [07:45:27] anyway the patch upstream is https://review.openstack.org/#/c/34197/ [07:45:27] don't forget the pull and sudo python setup.py develop [07:45:35] (and pull from the right remote if you have both) [07:45:41] ah right that as well [07:47:13] also I am going to train manybubbles (nik) and AaronSchulz [07:47:20] they expressed interest regarding jenkins / zuul [07:47:55] Clean up: -qunit is voting by default [07:47:55] hashar: hmm weird [07:47:56] \O/ [07:48:03] It's been that way always [07:48:23] that is a good thing [07:48:36] I deployed my first qunit job yesterday for EventLogging [07:48:38] worked like a charm [07:49:01] https://gist.github.com/Krinkle/5856722 [07:49:04] something is wrong [07:49:12] it isn't doing the push for the Campaigns ones [07:49:19] I think I will write a quick script to detects extensions having unit tests / qunit tests and build a report that mentions to us which jobs are missing in zuul/jjb [07:49:34] ah yeah [07:49:39] that is the bug I was talking about [07:49:40] it does exist in the output/ directory, I verified [07:49:43] the filtering does not work sometime [07:50:13] how come it does work other times? [07:50:18] your upstream patch suggests it never works [07:50:22] that is a good question [07:50:27] this is the first time ever for me that it hasn't worked [07:50:41] you can look at the code around https://review.openstack.org/#/c/34197/1/jenkins_jobs/builder.py,unified [07:50:56] if jobs_filter and job not in jobs_filter: [07:50:56] yeah, Im there [07:51:09] jobs_filter is a list of the arguments passed on the command line [07:51:19] job was a dict for me [07:51:26] so the dict can't be found in the list of job name [07:51:32] and I had to use the job['name'] [07:51:36] but maybe sometime job is actually the name [07:51:39] maybe it isn't always a dict? or maybe some of them have a toString? [07:51:44] not sure how else it could work [07:51:45] yeah possibly [07:51:54] WAT [07:51:57] :( [07:52:13] Anyway, this is the pleasure of working shifts :P [07:52:27] Now it is your problem to solve. [07:52:34] indeed :-] [07:52:36] head to bed! [07:52:50] will deploy the triggers for mw-ext-campaigns [07:52:56] Indeed, I should've been in bed already. thx for the chat, we'll sync up to tomorrow. I can help debugging tomorrow if you need me. [07:53:28] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70375 [07:53:45] ori-l: that was fast [07:54:23] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70381 [07:54:27] Krinkle|detached: sleep well : [07:54:28] ) [07:54:40] Nikerabbit: it wasn't a complicated change :) [07:54:54] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/70381 [07:55:22] ori-l: Campaigns has basic linting checks now. Thank you for the paper work! [07:55:40] hashar: at a glance, it looks like it might be better to use 'self.getJob()' rather than "job['name']" [07:56:29] ori-l: usually people are either away (sleeping) or don't care so it was nice surprise [07:56:40] i say this for two reasons: one, self.getJob() uses dict.get, which suggests there are cases in which the 'name' key is unset (and therefore "job['name']" would throw a keyerror) [07:57:12] two: it's a compelling theory for what the person writing it had in mind [07:58:43] Nikerabbit: nah, I appreciate drive-by reviews; you often pick out good stuff. The isset -> !empty voodoo in CoreEvents was a good example. [07:59:18] ori-l: same here [08:02:03] New review: Ori.livneh; "recheck" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [08:03:23] Change merged: jenkins-bot; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [08:05:12] hashar: Hi! Is it possible to setup jenkins to execute Proofread Page PHPUnit tests as part of the gate-and-submit jobs? [08:08:23] Tpt_: yes [08:08:24] :-) [08:08:58] hashar: Tahnks :-). So, can you do it? [08:09:39] ProofreadPage yeah i can [08:09:41] let me do that right [08:09:43] now [08:10:07] Thanks a lot :-) [08:13:07] New patchset: Hashar; "triggers for mwext-ProofreadPage" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70383 [08:13:13] here it is [08:13:48] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/70383 [08:14:35] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70384 [08:14:52] Tpt_: mwext-ProofreadPage-testextensions-master: SUCCESS [08:15:09] hashar: Thanks a lot! :-) [08:15:14] Tpt_: https://integration.wikimedia.org/ci/job/mwext-ProofreadPage-testextensions-master/1/testReport/(root)/ProofreadIndexPageTest/ [08:15:18] that is the test report [08:15:24] congratulations! [08:15:31] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70384 [08:18:31] hashar: Thanks :-) [08:23:35] New patchset: Raimond Spekking; "Register i18n file, fix typo in message key" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70385 [08:39:52] hey all, anyone know how to get confirmed for the wikitech-l … have tried a few times to sing-up but have never gotten a confirm email or any list emails ... [08:40:15] you shouldn't have to get confirmed [08:40:18] it ought to jus tsubscribe you [08:41:10] apergos: thanks … hopefully it will work this tim then ... [08:41:15] https://lists.wikimedia.org/mailman/listinfo/wikitech-l [08:41:20] I assume you went via the form [08:41:44] if ou don't see mail in a few minutes pm me with the email addr you used and I'll see if I can find out what's up [08:41:49] *if you [08:43:12] apergos: thanks, found the request confirmation email in the spam box this time and was able to confirm [08:43:26] excellent! [08:54:27] New patchset: Daniel Kinzler; "Assert write perms when opening a sqlite file." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70196 [08:55:35] New review: Daniel Kinzler; "Rebased to kick jenkins into action." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70196 [09:23:20] New review: Tpt; "Minor change reviewed." [mediawiki/extensions/ProofreadPage] (master) C: 2; - https://gerrit.wikimedia.org/r/70372 [09:23:30] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70372 [09:26:09] New patchset: Tpt; "(bug 50154) The parameter of the header template should be in lower case" [mediawiki/extensions/ProofreadPage] (1.22wmf8) - https://gerrit.wikimedia.org/r/70389 [09:26:50] New review: Tpt; "backport" [mediawiki/extensions/ProofreadPage] (1.22wmf8); V: 2 - https://gerrit.wikimedia.org/r/70389 [09:27:32] Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (1.22wmf8) - https://gerrit.wikimedia.org/r/70389 [09:30:12] New patchset: Tpt; "Update ProofreadPage to track 1.22wmf8 branch" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70390 [09:31:15] Change abandoned: Tpt; "Not needed" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70245 [09:38:47] New patchset: Nikerabbit; "Remove RTL-specific CSS rules" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/61051 [09:41:11] New patchset: Hiong3-eng5; "SpecialPage:OWDownloads" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [09:42:07] Change merged: jenkins-bot; [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/61051 [09:43:29] New review: Tpt; "See https://bugzilla.wikimedia.org/show_bug.cgi?id=50154" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70390 [09:44:37] New patchset: Nikerabbit; "Css cleanup" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/70391 [09:48:47] New review: Hiong3-eng5; "Kindly check for corrections else merge. thanks." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [09:50:22] New patchset: Nikerabbit; "Move Search page from redirects to pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [09:50:28] New patchset: Nikerabbit; "Move Search page from redirects to pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [09:52:09] New review: Nikerabbit; "Who can I bribe to get this reviewed and merged?" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [09:55:11] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [09:55:12] New patchset: Nemo bis; "Cope with missing hover-in event in stats tables row highlighting" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [10:01:44] New patchset: Nikerabbit; "Remove Special:QueryCreator" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69073 [10:03:16] New review: Nikerabbit; "Are there so many valid uses of RequestContext::main that we really need a wrapper to to make it eas..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [10:06:02] New patchset: Foxtrott; "Remove non-existing class from autoloader" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/69013 [10:07:18] New patchset: Tpt; "Improve code quality of DbConnectors" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70393 [10:08:44] Change merged: jenkins-bot; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/69013 [10:39:16] hey hashar [10:40:17] hashar, any idea why one test fails in jenkins but passes on every other environment I've seen, including labs? [10:40:42] MaxSem: change ? [10:40:44] https://gerrit.wikimedia.org/r/#/c/69585/ [10:41:23] werd [10:41:25] weird [10:41:40] wondering what "About this sound" is :D [10:42:12] link to description page [10:43:16] no idea honestly [10:43:16] New patchset: Hashar; "bind some integration jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70397 [10:43:17] New patchset: Hashar; "test-mediawiki-docgen on master (for now)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70398 [10:43:17] New patchset: Hashar; "bind parsoid jobs on 'master'" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70399 [10:43:17] New patchset: Hashar; "bind some operations jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70400 [10:43:17] New patchset: Hashar; "bind qunit tests to master" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70401 [10:43:18] New patchset: Hashar; "bind more jobs to 'master'" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70402 [10:43:18] New patchset: Hashar; "mark more jobs has requiring slave scripts" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70403 [10:43:25] MaxSem: out for lunch will be back soon [10:45:11] New patchset: Tpt; "(bug 47011) Wiki link of Index: pages are mishandled if they contain a ":"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [10:52:19] New patchset: Tpt; "(bug 47011) Wiki link of Index: pages are mishandled if they contain a ":"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [10:54:42] New patchset: Tpt; "(bug 47011) Wiki link of Index: pages are mishandled if they contain a ":"" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/70404 [10:59:41] New patchset: J; "Updated the id3 files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69952 [11:01:39] Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69952 [11:07:58] New patchset: J; "Refactor MediaHandlers" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70406 [11:08:40] re [11:22:51] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [11:29:35] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [11:31:26] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [11:45:18] !r 90266 [11:45:18] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90266 [11:48:27] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70197 [11:51:23] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70408 [11:52:12] New patchset: Hashar; "bind some integration jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70397 [11:52:37] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70397 [11:53:31] New patchset: Hashar; "bind more jobs to 'master'" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70402 [11:53:31] New patchset: Hashar; "test-mediawiki-docgen on master (for now)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70398 [11:53:31] New patchset: Hashar; "mark more jobs has requiring slave scripts" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70403 [11:53:31] New patchset: Hashar; "bind parsoid jobs on 'master'" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70399 [11:53:31] New patchset: Hashar; "bind some operations jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70400 [11:53:32] New patchset: Hashar; "bind qunit tests to master" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70401 [11:53:52] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70398 [11:54:04] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70399 [11:54:12] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70400 [11:54:20] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70401 [11:54:31] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70402 [11:54:44] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/70403 [12:06:01] New review: Kipcool; "I found a few comments to make :)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [12:12:28] New patchset: Tpt; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [12:17:16] New patchset: Matmarex; "skin: Convert table of contents from to
" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:17:43] New review: Matmarex; "Krinkle, fixed and replied." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:18:46] MatmaRex: and I was going to complain about THAT bug [12:18:59] MatmaRex: aka HTML stalled in caches for 30 days which cause css issues [12:19:15] but you updated oldshared.css :-]  [12:19:15] \O/ [12:20:30] hm? how is oldshared relevant? :P [12:20:42] but yeah, caching html is not nice [12:20:49] caching it twice is even less nice [12:20:53] (parser cache and squids) [12:21:17] but i guess it's necessary, eh [12:21:24] (or maybe shall i say, i hope it is.) [12:21:37] hashar: oh, also! [12:21:54] hashar: you might like https://bugzilla.wikimedia.org/show_bug.cgi?id=46956 [12:22:38] yup [12:22:41] that is a regular issue [12:29:19] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [12:40:41] RD: still not here? [12:56:48] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70408 [13:31:09] New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/70417 [13:48:14] New review: Daniel Kinzler; "All the failover stuff should really be changed to use exceptions, not magic return values and objec..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70197 [13:48:40] New patchset: J; "Always use capitalized DBKey for $file" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [14:07:39] New patchset: Anomie; "Fix LuaSandbox mw.ustring.byteoffset with negative 'i'" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/70421 [14:19:03] New patchset: IAlex; "(bug 50078) Allow a string other than '*' as condition for DatabaseBase::delete()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70423 [14:22:09] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70390 [14:23:48] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [14:25:05] * Reedy wonders if iAlex has been away on holiday or something [14:27:08] bug 111. nice. [14:27:25] i think my best was bug 358 [14:28:34] uuh lovely one [14:35:01] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=50163#c2 [14:35:11] hooray database corruption! [14:35:17] (or idiotic caching) [14:35:59] We like caching idiots [14:36:07] Makes them easier to share [14:37:45] MatmaRex, I think I fixed it [14:38:55] Krenair: fixed which part? [14:39:06] permalink to current version is still pointing to an old version. [14:39:15] which is funny in a perverse way [14:39:31] hm. try ctrl+R? [14:41:50] Krenair: doesn't help [14:41:59] Krenair: what is "Permanent link" at http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Common.js linking to for you? [14:42:18] it's linking to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.js&oldid=55058 for me [14:42:27] which is obviously not the latest revision [14:42:39] ah, whatevs [14:43:10] it's http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Common.js&oldid=57656 for me [14:43:22] i'm no longer even fazed by database mess, really [14:43:32] Krenair: logged in or out? (logged out for me) [14:44:15] i remember once dealing with `false`being returned as revision text by the API for some pages [14:44:20] logged in [14:44:28] and freaking out [14:44:30] AzaToth: Sorry, here now [14:44:32] but i don't care anymore [14:44:55] well, then it's cached for anons [14:45:00] lovely [14:45:00] welcome... to database consistency apathy [15:21:38] New review: Rtdwivedi; "Works fine for me." [mediawiki/extensions/ProofreadPage] (master) C: 1; - https://gerrit.wikimedia.org/r/70404 [15:43:22] New patchset: Anomie; "API: Add prop=sha1 to list=recentchanges" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70435 [15:45:18] New patchset: Demon; "Index fully parsed pages" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70432 [15:45:18] New review: Demon; "PS2 only runs the silly updateText() method if we're not handling the content explicitly." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70432 [15:48:49] New review: Manybubbles; "Looks good to me." [mediawiki/extensions/CirrusSearch] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70432 [15:48:54] Change merged: jenkins-bot; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70432 [15:50:00] New patchset: J; "Always use capitalized DBkey for $file" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [15:55:54] New patchset: Manybubbles; "TODO updates." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70437 [15:55:54] New patchset: Manybubbles; "Readme style fix." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70438 [15:58:04] so git review tells me I've got a bunch of outstanding commits to submit but they are mostly translatewiki commits I didn't make. Is there a way to shut it up? [15:58:39] manybubbles: git fetch gerrit [15:58:56] someone else can explain it in more detail, I think [15:59:23] cool - I've been doing `git pull` but I'll try that [15:59:33] <^demon> git fetch --all [15:59:38] <^demon> Or git pull --rebase [15:59:56] <^demon> I'm a big fan of the latter when I've got changes I haven't committed. [16:00:08] cool. I'll do that [16:00:16] <^demon> s/committed/pushed/ [16:00:29] it's nice except if you haven't committed yet [16:01:02] <^demon> Well if you haven't committed there's git stash :) [16:02:30] ^demon: yeaah well I haven't learned it [16:02:49] is it any easier than just doint git commit -av "uga buga" [16:03:00] <^demon> Haha, that works too [16:03:53] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70371 [16:04:36] manybubbles: you might also want to kill your "origin" remote and make "gerrit" the default [16:04:51] or alternatively, configure git-review to use "origin" instead of "gerrit" [16:05:10] so this doesn't happen again [16:06:16] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/70421 [16:08:37] MatmaRex_: ah! this is starting to come together for me. I come from hg and a very different work flow. [16:09:00] New review: Aaron Schulz; "The message file is already registered in defineSourcePaths" [mediawiki/extensions/OAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/70385 [16:09:22] manybubbles: :) [16:09:23] (brb) [16:10:02] MatmaRex_: killing the origin worked perfectly. thanks. [16:18:22] New patchset: Raimond Spekking; "Fix typo in message key" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70385 [16:22:56] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [16:28:58] New review: J; "reading the source of FileRepo::getNameFromTitle not sure if this works for http://mg.wiktionary.org..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [16:40:30] Change merged: Demon; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70437 [16:40:50] Change merged: Demon; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70438 [16:44:40] New review: J; "ah ok found it in wmf-config/filebackend.php, will push new version" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [16:46:37] New patchset: J; "use $file->getName() instead of $title->getDBkey()" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70419 [16:53:33] New patchset: J; "Increase transcode timeout for 720p uploads > 1h" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70441 [16:57:59] New review: Alex Monk; "Assuming we have no hooks returning 0 to mean false (we shouldn't...), this should be okay. +1 for t..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70328 [17:06:20] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [17:12:33] New patchset: Aaron Schulz; "database: Improve DatabaseMysql::masterPosWait() performance by caching the position" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [17:17:43] New patchset: Manybubbles; "Sanitize html into search and in results." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70442 [17:18:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70423 [17:19:40] New patchset: J; "Increase transcode timeout and size for 720p uploads > 1h" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70441 [17:25:15] New patchset: Hoo man; "SpecialAbuseLog: use DifferenceEngine::addHeader to render diffs" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67846 [17:32:00] New review: Hoo man; "Thanks for the patch :)" [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/67846 [17:32:04] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67846 [17:32:34] oh hi rachel99, nice to see you on IRC [17:33:33] New patchset: Ryan Lane; "Fix undefined offset error for AD group searches" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/70445 [17:34:13] chrismcmahon: Hi Chris! [17:35:28] New patchset: Matmarex; "AbuseFilterViewDiff: Make diffs use standard styling (and more)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67868 [17:36:36] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/70445 [17:42:18] rachel99: did you see about the big meeting tomorrow for OPW/GSOC people? [17:45:16] chrismcmahon: yes, I am signed up for that [17:46:23] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [17:50:54] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [17:53:27] New review: Yuvipanda; "WIP. Also keep comments on GitHub, since Gerrit doesn't do 'multiple separate commits' review well." [mediawiki/extensions/UploadWizard] (master) C: -2; - https://gerrit.wikimedia.org/r/70446 [17:53:51] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/69983 [17:55:06] New review: Dzahn; "deployed" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/69983 [17:58:14] New patchset: Reedy; "Update UploadWizard to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70449 [18:06:25] evening [18:09:03] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70449 [18:09:19] +654c3e12724380a6abc2198198380df931e1404e extensions/UploadWizard (mw1.20-322-g654c3e1) [18:09:30] hashar: ^ any idea where that weird version has come from in the () ? [18:09:55] 322 would be a jenkins build number ? [18:09:58] Reedy: is that on beta? [18:10:07] Nope, production [18:10:16] maybe it is a tag [18:10:33] The mw1.20 is, but it's acient [18:10:36] *ancient [18:10:43] oh we are on 1.22 now [18:10:49] Even after just updating it to master the output is still weird [18:10:50] reedy@tin:/a/common/php-1.22wmf8$ git submodule status extensions/UploadWizard [18:10:50] 654c3e12724380a6abc2198198380df931e1404e extensions/UploadWizard (mw1.20-322-g654c3e1) [18:11:08] git deploy? [18:11:23] .. [18:11:25] and the g is weird [18:11:27] that is not a sha1 [18:11:42] Chad does prefix short sha1 with a g for gerrit [18:11:43] mw1.20 hasn't been touched since 2012-11-28 [18:12:04] marktraceur pointed out that UW hadn't been updated in 1.22wmf7 or 8 for some reason [18:12:53] $ git tag -l [18:12:53] list [18:12:54] mw1.20 [18:12:55] $ [18:13:32] the tag points to Date: Wed Nov 28 12:56:57 2012 -0800 [18:14:03] reedy@tin:/a/common/php-1.22wmf8$ git submodule status extensions/UploadWizard [18:14:03] 654c3e12724380a6abc2198198380df931e1404e extensions/UploadWizard (list) [18:14:16] $ git submodule extensions/UploadWizard/ [18:14:17] 654c3e12724380a6abc2198198380df931e1404e extensions/UploadWizard (list) [18:14:18] yeah [18:14:20] New patchset: Mormegil; "Improve behavior of IP::toUnsigned on Windows" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70451 [18:14:39] There's a couple of other extensions showing weird output [18:14:55] ah 'list' is a tag I created sorry [18:15:37] maybe git find the latest tag [18:15:41] ab21d08f4541673bdf166b912993e97e69a11e3d extensions/LandingCheck (heads/master) [18:15:41] da36d2ca81c6515378f88f639be993a38406df57 extensions/LdapAuthentication (2.0c-22-gda36d2c) [18:15:41] c1de07238619b15f7857325f6d6fbc34c5dc6a95 extensions/LiquidThreads (heads/master) [18:15:48] append the number of commits to reach current head [18:15:54] thus forging a nice version number [18:16:03] It does seem to be doing something like that [18:16:20] But when in most cases it's a revision from master... why would it do something weird with the tag? [18:16:47] It's also amusing we have remotes/origin/HEAD and heads/master and such [18:18:01] New patchset: RAN1; "Remove globals from special page execution" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/70452 [18:18:42] Reedy: sorry that is beyond my knowledge :( [18:19:06] Don't worry! [18:19:11] 792556ecb6218e7260f67e30640f90d99b8759f9 extensions/EducationProgram (0.2-343-g792556e) [18:19:17] df0ac41c537007e95bc90a3a5cf7289df4c3db97 extensions/SemanticForms (2.5.1-217-gdf0ac41) [18:19:18] 6ed064d81bfa14e2532666902dd6c0b941fc207b extensions/SemanticMediaWiki (1.8.0.3-4-g6ed064d) [18:19:18] a94a3b4f04e8f2f76ff87a2bf6cb68c7eb3d92d6 extensions/SemanticResultFormats (1.7.1-427-ga94a3b4) [18:19:23] It just seemed like the strangeness you'd see on labs or something [18:19:33] For the Semantic* extensions, we are using specific tags [18:19:46] New review: Krinkle; "For the record, note that the "qunit" job isn't just about the javascript tests. It also acts as our..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70196 [18:19:56] EducationProgram$ git log --oneline 0.2..792556e|wc -l [18:19:57] 343 [18:20:04] and it shows (0.2-343-g792556e) [18:20:21] so I guess it is git submodule forging a version number for you [18:20:32] let you know that the submodule is ahead of 0.2 by 343 commits and points to 792556e [18:20:41] lol [18:20:49] which is .. nice [18:20:51] awesomely useless data [18:21:09] New review: RAN1; "Tests of the extension look good, no major change to extension functionality so I'm approving it for..." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70452 [18:21:13] na I have seen that schema used already [18:21:36] I am wondering whether it shows up in Special:Version :) [18:22:01] Reedy: git submodule calls git-describe - Show the most recent tag that is reachable from a commit [18:23:48] hashar@tin:/a/common/php-1.22wmf8/extensions/EducationProgram$ git describe --debug --tags [18:23:49] searching to describe HEAD [18:23:51] lightweight 343 0.2 [18:23:52] lightweight 497 0.1 [18:23:53] traversed 1195 commits [18:23:54] 0.2-343-g792556e [18:23:58] Reedy: today I learned yet another command hehe [18:35:28] Change merged: Aaron Schulz; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/70385 [18:52:30] New patchset: Aaron Schulz; "Stop spamming exception log with random upload stash failures" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69583 [18:59:32] New review: Brion VIBBER; "Probably for the best." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70328 [19:10:41] New patchset: Ori.livneh; "Allow explicit & implicit null returns from hook handlers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [19:12:10] New review: Ori.livneh; "PS2 amends the documentation changes to incorporate Krinkle's suggestion. I think it's OK to merge now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [19:19:56] ^demon, did you see https://gerrit.wikimedia.org/r/#/c/70370/ ? It WFM locally, redirecting gerrit gitweb project URLs and project+file URLs. [19:21:36] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69583 [19:22:09] <^demon> spagewmf: lgtm, but someone from ops has to merge :) [19:22:38] is there a gerrit labs machine? [19:24:07] there's a gerrit project: https://wikitech.wikimedia.org/wiki/Nova_Resource:Gerrit [19:24:28] <^demon> spagewmf: Ah, we can do that. [19:24:34] <^demon> Lemme cherry pick that into labs [19:26:02] New patchset: Foxtrott; "fix bug: popup form" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70465 [19:27:53] New review: Spage; "recheck" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [19:28:13] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70465 [19:33:10] New patchset: Demon; "Respect namespaces when searching" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69944 [19:38:00] <^demon> spagewmf: :) https://gerrit-dev.wmflabs.org/r/gitweb?p=mediawiki/core.git [19:51:39] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70470 [19:51:39] New patchset: MaxSem; "Update ZeroRatedMobileAccess to master tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70471 [19:55:00] RoanKattouw: http://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor \O/ [19:55:37] Yay [19:55:49] hasharCall: I think there was some sort of issue with VE not updating on beta that I'm supposed to look into [19:56:00] RoanKattouw: VE works well on beta :-] [19:56:13] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70470 [19:56:17] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70471 [19:57:20] RoanKattouw: that was Gerrit being improperly configured for mediawiki/extensions.git [19:57:27] the VisualEditor was not updating there indeed [19:57:33] but it got fixed by Chad a few days ago :-) [19:57:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70328 [19:57:55] Oh, hah [19:57:56] ah found a bug :-] [19:58:02] I had not suspected it would be that [19:58:21] logged on http://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor when clicking Edit I am being shown another article content eheh [19:58:37] ha [19:58:42] Oh, of coures [19:58:49] This is because of the ... dammit [19:58:54] My fault [19:58:55] post lunch :-] [20:00:37] anyway, kudos on setting it up there [20:01:27] New patchset: Hiong3-eng5; "SpecialPage:OWDownloads" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [20:03:12] New review: Hiong3-eng5; "See my comments. Kindly recheck and merge if no corrections are needed. Thanks." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [20:04:32] New review: Hiong3-eng5; "here's my comment on patch 4..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [20:07:02] New review: Hiong3-eng5; "take 3, I hope this is my comments on patch 3" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [20:07:32] New review: Hiong3-eng5; "I mean patch 4. I really need to sleep now ;)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/70325 [20:09:36] New patchset: TheDJ; "Further improve load order of RC and watchlist styling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [20:13:37] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [20:14:36] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70532 [20:14:55] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70532 [20:21:54] New review: Manybubbles; "Makes sense to me. The namespace todo for the title shouldn't be too bad." [mediawiki/extensions/CirrusSearch] (master); V: 2 - https://gerrit.wikimedia.org/r/69944 [20:26:12] who want to merge this https://gerrit.wikimedia.org/r/#/c/66325/ [20:27:22] Yippie, build fixed! [20:27:22] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #101: FIXED in 4 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/101/ [20:27:53] New review: TheDJ; "if math == texvc installed, then shouldn't it perhaps be called texvc ?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [20:31:25] New review: TheDJ; "well i guess what you could do is make the enabler for latexml, depend on the enabler for mathjax." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [20:31:35] thedj: can you explain what this "green bullet in watchlist is"? [20:32:03] can't find a way to enable it [20:32:10] AzaToth: it's bold in watchlist for ppl who are anal about their text changing shape [20:32:45] AzaToth: only works if you aren't in Enhanced Recent Changes mode. [20:33:28] which can be enabled where? [20:33:43] preferences -> recent changes tab [20:34:04] uh [20:34:05] the green bullets are on for all registered users by default if I remember [20:34:28] thedj: I must be blind [20:34:30] http://i.imgur.com/Taaml0c.png [20:35:01] unless you: enabled "enhanced recent changes", disabled them in gadgets, or have the gadget to restore the "bold" functionality. [20:35:24] "group changes" that's enhanced recent changes [20:35:38] http://i.imgur.com/yy2w3pF.png [20:35:51] I guess we 'dummyfied' the description of it at some point :D [20:36:03] http://i.imgur.com/jpKfvmC.png [20:36:09] I don't see any "green bullets" [20:36:47] because you have the "group changes by page in recent changes and watchlist" option enabled [20:36:59] ah, "aren't" [20:37:33] why would anyone NOT have that enabled? [20:37:45] * thedj doesn't [20:38:32] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [20:39:32] thedj: heh [20:40:02] New patchset: Manybubbles; "Sanitize html into search and in results." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70442 [20:40:02] New patchset: Manybubbles; "Add more profiling hooks." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70535 [20:40:02] New patchset: Manybubbles; "Allow users to fuzzy match." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70536 [20:40:02] New patchset: Manybubbles; "TODO updates" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70537 [20:40:02] New patchset: Manybubbles; "Enable prefix search hook with full text flag." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/70538 [20:40:11] sorry for all the noise [20:40:38] manybubbles: We love noise! [20:40:38] Change abandoned: Inez; "Handle as a part of 69509 itself - https://gerrit.wikimedia.org/r/#/c/69509/6/js/tests/parserTests.txt" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70365 [20:40:47] Especially when it's patchnoise [20:40:51] noise is good, noise means activity [20:41:06] * marktraceur spots thedj [20:41:10] marktraceur: btw. did you ping me ? [20:41:16] thedj: I tried to ping you a few times about a patch [20:41:26] yeah, i was busy the last two weeks [20:41:39] thedj: I got tired of talking about the nasty array stuff in UW, so I refactored, like, all the things [20:41:43] and with that, I'm going to go run an errand. [20:42:12] thedj: https://gerrit.wikimedia.org/r/68835 [20:42:12] marktraceur: 'all' ? [20:42:16] that sounds ambitious [20:42:17] Many of the things [20:42:18] :D [20:42:25] thedj: where is that text defined? [20:43:07] AzaToth: more specific please, which text ? [20:43:24] "Pages that have been changed since you last visited them are shown with a green bullet." [20:43:44] &uselang=qqx [20:43:56] and it will probalby show you which Mediawiki message is responsible [20:44:01] ah [20:44:13] marktraceur: wow, that's a big patch [20:44:21] Yeeeeah [20:44:37] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [20:44:39] thedj: Honestly the best review I could have would be common workflow testing [20:44:53] thedj: Especially error handling which I haven't really tested [20:45:47] marktraceur: i should have some time again tomorrow evening and the day after. will make this my primary focus area. [20:45:53] K! Thanks :) [20:46:21] thedj: Hopefully this plus a few other things I have in the pipeline will make it slightly less physically painful to contribute to the project. [20:46:42] thedj: See e.g. https://bugzilla.wikimedia.org/show_bug.cgi?id=49987 [20:47:17] haha: "will probalby never be closed" [20:48:07] Yeahhh [20:49:31] marktraceur: Could probably extend that bug to mediawiki too :P [20:50:04] bawolff: Almost certainly! But that's not really my purview [20:50:42] If you want to make a huge overarching "code cleanup" tracking bug I'd add this as a blocker :0 [20:50:45] :)* [20:51:59] There's probably already one [20:52:27] Nice even number: 700 [20:53:11] ugh, didn't mean to remove the other blocking bug [20:56:28] New review: TheDJ; "@Nischayn22" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [20:57:17] New patchset: AzaToth; "only show wlheader-showupdated if we are using the old watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70540 [20:57:27] thedj: there :-P [20:58:39] AzaToth: uh, no [20:58:47] AzaToth: the enhanced watchlist has bolding as well [20:58:50] MatmaRex_: no [20:59:01] yes, i'm using it [20:59:15] New review: Matmarex; "The enhanced watchlist has the bolding as well." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70540 [20:59:47] MatmaRex_: I've never seen any boldish on my watchlist [20:59:48] although maybe it only applies if you've also enabled the second thing [20:59:56] the one where you see all edits, not just the latest one [21:00:27] MatmaRex_: http://i.imgur.com/Taaml0c.png http://i.imgur.com/yy2w3pF.png http://i.imgur.com/jpKfvmC.png [21:00:31] (which is confusingly in "Recent changes" section of preferences) [21:00:56] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70441 [21:01:26] AzaToth: ugh, that's not the "enhanced" watchlist. [21:01:34] MatmaRex_: either I've clicked the wrong™ checkbox at the wrong™ time [21:01:35] AzaToth: bolding was disabled for en.wp when it got enabled wikimedia wide. [21:01:50] you are looking for a different flag [21:01:53] AzaToth: yeah, en.wp has some shitty-ass hacks there [21:01:55] MatmaRex_: so whatthefuck is "enhanced" watchlist [21:01:59] AzaToth: one sec [21:02:44] AzaToth: http://i.imgur.com/I6N1aZi.png , sans the yellow crap (my own hack, disregard it) [21:02:46] AzaToth: enhanced watchlist is a table style formatting of your recent changes and watchlist pages, that comes with collapsed sections using javascript [21:03:15] AzaToth: http://i.imgur.com/InYI91t.png [21:03:47] $wgShowUpdatedMarker is the bolding (by default) of pages that have been updated since the last time you visited them. [21:03:55] AzaToth: and also http://i.imgur.com/tQWf4WD.png (more prefs) [21:04:04] MatmaRex_: http://imgur.com/J4fvbZU [21:04:09] further down [21:04:09] the options for this are all over the prefs [21:04:24] AzaToth: ah, well [21:04:25] on en.wp this bolding is disabled. a green bullet is used instead if you don't have Enhanced RC enabled. [21:04:32] AzaToth: so yeah, probably what thedj days [21:04:34] says* [21:04:37] en.wp being dumb [21:04:42] blame edokter [21:04:53] hehe [21:04:57] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70541 [21:04:57] New patchset: MaxSem; "Update ZeroRatedMobileAccess to master tip" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70542 [21:05:00] i have nfi why they're suppressing this [21:05:28] no, this whole thing is actually extremely sensitive if you start messing with it, because there are 6 options or something so n^6 variations [21:05:42] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70541 [21:05:42] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70542 [21:05:44] 6^6^6 [21:05:51] AzaToth: what do you want to fix [21:06:01] * MatmaRex_ is in the mood for some grade school humour [21:06:05] MatmaRex_: I know it was disabled before due to it was too expensive server side [21:06:37] AzaToth: that must have been 2006 or so, it's been enabled for quite some time now [21:06:38] AzaToth: you want to hide the message in enhanced view, because it's not applicable to Enhanced RC users riright ? [21:06:42] New patchset: J; "Refactor MediaHandlers" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/70406 [21:06:44] thedj: should be a way to differentiate messages depending on preference [21:07:07] * bawolff doesn't like enhanced rc [21:07:16] thedj: practically in my case yes, but the general case would have to have either different messages or a way in the message to differentiate [21:07:41] bawolff: I use it becuase it's more tabular than the normal [21:07:51] you are not suppose to make it differentiate, that's just en.wp being anal [21:08:04] thedj: so sue them! :-P [21:08:18] so let's just find a css rule to hide it on en.wp or do it with JS [21:08:31] * MatmaRex_ doesn't like bawolff [21:08:35] enhanced rc is cool [21:08:51] boo :P [21:09:01] i've been using it since ever [21:09:08] Its ugly [21:09:13] it's the old one that should be killed [21:09:15] duh [21:09:18] the old one is as well [21:09:25] true [21:09:28] Kill all the RC [21:09:31] +1 [21:09:35] thedj: if you are actually using the enhanced one, you don't need any header messages :-P [21:09:53] AzaToth: bawolff: there's a bug to make it default [21:09:57] !bug enhanced default [21:09:57] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=enhanced+default [21:10:03] MatmaRex_: enhanced RC bundles all the log entries together, which I find annoying [21:10:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=35785 [21:10:32] bawolff: yeah, it's a little weird. file a bug? :P [21:10:41] bawolff: instead of having them scrambled inbetween YOLOFAGLOL? [21:11:00] AzaToth: ok, the problem here is that there is no parent element to that message that indicates that the page is in enhanced-rc mode, so we need JS to tackle this. [21:11:17] or add a parent elem ツ [21:11:33] thedj: adding a class to Special:Watchlist seems kosher to me [21:11:35] MatmaRex_: But filing a bug is step 1 towards someone guilting me into fixing it :P [21:11:42] * bawolff goes files the bug [21:11:54] i wonder if i would be lynched if i actually changed that [21:12:08] https://bugzilla.wikimedia.org/show_bug.cgi?id=35785 [21:12:22] sorry [21:12:27] wrong clickzors [21:12:48] addshore: no haddaway todai? [21:12:59] :> [21:13:08] * addshore decided to try something different [21:16:33] AzaToth: did T13 poke you earlier? :) [21:16:57] addshore: http://paste.debian.net/12689/ [21:16:58] yes [21:17:37] mehe :) [21:22:58] AzaToth: better now ? [21:23:16] you still have the button, that doesn't actually do anything... [21:24:08] but if i hide that, it breaks for people who have 'bolding' enabled in their gadgets. [21:24:43] k [21:25:14] thedj: really, the formatting has to be changed in core not be be a bolding [21:25:22] (because that's like really dumb, honestly) [21:25:24] New patchset: Foxtrott; "fix bug: Added wikitext in the system message Mediawiki:Minoredit is not parsed when using "edit with form"" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70544 [21:25:29] then the enwiki junk's gotta go [21:26:38] New patchset: Foxtrott; "fix bug: Added wikitext in the system message Mediawiki:Minoredit is not parsed when using "edit with form"" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70544 [21:27:29] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/70544 [21:35:26] andre__: are you the one to talk to about adding new bugzilla components? [21:35:45] andre__: it would be good if there were a MW extensions component for http://www.mediawiki.org/wiki/Extension:PageImages [21:37:09] awjr: He is the person, but if he's not around, typically filing a bug works pretty well too [21:37:21] whoa [21:37:22] meta [21:37:37] what do i file a bug under for adding a new component? [21:37:48] AzaToth: https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=561580341&oldid=558646641 [21:37:58] bawolff: Wikimedia/bugzilla ? [21:38:08] yeah [21:38:16] cool thanks bawolff :) [21:38:17] AzaToth: now if you enable the 'bold' gadget, it should show you the old text. [21:38:29] english only, but who cares. [21:39:06] awjr, https://bugzilla.wikimedia.org/show_bug.cgi?id=50139 ? [21:39:17] I might do that tomorrow [21:40:21] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [21:41:23] thedj: nice [21:41:31] thought I wonder if I want boldish [21:41:40] prolly notish [21:41:56] i just hate those loose ends [21:41:59] having 8000 thingis on wathclist [21:42:03] hehe [21:42:09] heh yeah that's the one andre__, didn't realize there was already a bug open [21:45:37] New review: TheDJ; "This is an en.wp only problem. Solved here: https://en.wikipedia.org/w/index.php?title=MediaWiki:Com..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/70540 [22:06:06] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [22:12:33] New patchset: Catrope; "The customization page is WikiLove.js, not Wikilove.js" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/70553 [22:23:46] New patchset: Plavi; "Sorted page elements alphabetically" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70555 [22:24:06] New patchset: Aaron Schulz; "Avoid the "key conflict attempting to insert a user row" exception in some cases" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587 [22:24:30] TimStarling: is https://gerrit.wikimedia.org/r/#/c/69587/ ok'ish? [22:25:09] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [22:25:38] interesting [22:26:02] lol, "The sandy-haired Aussie has carved out a successful niche in the art world thanks to the versatility of his genitalia, which he uses to paint vivid portraits of celebrities, or anyone with the inclination and $200 Australian." [22:26:10] may as well try it [22:26:20] oops, wrong room [22:26:33] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587 [22:27:08] ebernhardson: Also makes for fun deletion discussions [22:31:30] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [22:31:37] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [22:33:09] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [22:34:09] New patchset: Aaron Schulz; "Include the backtrace in the log for job exceptions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70556 [22:35:50] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [22:39:50] New review: AzaToth; "Generally the draft option in gerrit can be used for changesets not ready for merge" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [22:58:06] New review: Tim Starling; "I think Status::newFatalPermissionDenied() should be in the User class, not the Status class. I thin..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67875 [23:01:05] TimStarling: I feel like Status should be more of a simple value-object thing (granted we've already got $wgLang, parsing dependent functions, ect) [23:02:00] Daniel would no doubt propose a StatusFormatter class [23:02:33] maybe it would hold a MessageCache reference [23:03:07] heh, actually a status and a status formatter is not that crazy [23:03:28] beyond that would probably be a little excessive [23:03:30] there is already a split between formatting and generation [23:04:15] the factory stores message keys, then the caller of the function that returned the error is responsible for interpreting them [23:04:32] that allows the caller to use whatever language it wants, or whatever API format [23:05:15] true, it lets the caller decide, though the issue would be whether to have stuff like getHTML()/Message stuff in there or in a formatter [23:05:21] ideally that commaList() call would have been in the formatting functions [23:05:37] and the stored message parameter would be an array of some kind [23:05:39] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/68601 [23:05:47] but it's probably too late for that [23:06:13] Krinkle: why didn't you {{fixit}}? :) [23:06:29] New patchset: SuchABot; "Redo campaigns backend to use ContentHandler" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70446 [23:08:04] New patchset: Wikinaut; "Combine text and ID update fields" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [23:10:47] New patchset: Aaron Schulz; "Stop spamming exception log with random upload stash failures" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69583 [23:12:21] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70561 [23:13:02] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70562 [23:13:55] New review: Wikinaut; "Tyler, after the bug 50078 (reported by me) has been fixed and merged, I updated the UserMerge code ..." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/69017 [23:16:02] anyone know what labs instance Nik/manybubbles has been using? [23:16:05] New patchset: Aaron Schulz; "Include the backtrace in the log for job exceptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70556 [23:18:25] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70562 [23:19:51] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70561 [23:21:03] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [23:22:26] New review: EBernhardson; "Looks good to me, quick test looks to work as planned. Also i've never seen stream_resolve_include_..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70114 [23:22:50] New patchset: Matmarex; "Refactor watchlist token handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [23:24:16] Krinkle: I miss the "wall of shame" in CodeReview [23:24:58] New patchset: Alex Monk; "Warn if you try to link to a disambiguation page" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [23:25:26] AaronSchulz: Doesn't a wall of shame require broken code to actually be merged into master? [23:26:18] DanielFriesen: you could still count -1/-2 votes for patches...though the shame factor is a lot lower [23:26:49] New patchset: Bsitu; "Add HTML email support to Echo notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/70112 [23:26:49] New patchset: Alex Monk; "Warn if you try to link to a disambiguation page" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/70564 [23:28:29] " Raymond_: why the hell you use $wgUser->getSkin() while being in a Skin object? " [23:28:33] heh, nice BZ quip [23:37:55] New review: Bsitu; "Thanks for the cleanup!" [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/69314 [23:38:03] New patchset: MarkTraceur; "WIP Add a role for testing fundraising stuff" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [23:38:06] ori-l: So I tried adding a drupal site to a vagrant instance, and it seems like I cannot reach it...see patch ^ in particular puppet/modules/drupal [23:38:06] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69314 [23:39:31] AaronSchulz: https://toolserver.org/~bawolff/gerrit-stats.htm , although I feel my wall of shame query is a bit broken as I would expect more results [23:39:42] marktraceur: i'll check it out [23:39:47] Ta [23:44:21] New patchset: Wikinaut; "Combine text and ID update fields" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [23:45:53] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [23:46:14] New patchset: Alex Monk; "Fix history and add section tabs being collapsed on RTL wikis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70569 [23:46:57] New review: Bsitu; "-2ed not because this patch needs improvement. This will be implemented in a different way in html ..." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/64876 [23:47:53] New review: Wikinaut; "changed the deduplication-the-watchlist code to use $join_conds. Code tested (ok), but please check ..." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/69017 [23:49:58] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401