[00:21:43] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/69314 [00:25:51] New patchset: Alex Monk; "Cleanup JS" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69314 [00:29:48] New patchset: Krinkle; "Minor clean up" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [00:30:54] New review: Krinkle; "Resolved merge conflict." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [00:32:00] New patchset: Krinkle; "Minor clean up" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [00:32:08] New review: Krinkle; "Rebased." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [01:04:29] New patchset: AzaToth; "copy paste comment should probably have end instead of start" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70030 [03:30:15] New review: Parent5446; "Haven't tested" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64450 [03:32:32] Yippie, build fixed! [03:32:32] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #67: FIXED in 8 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/67/ [03:33:20] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/70028 [03:33:45] Krinkle|detached: Special:MergeAccount ;) [04:06:51] New patchset: RAN1; "Update twitteroauth for API v1.1, minor fixes" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/70029 [05:05:48] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #5: FAILURE in 4 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/5/ [05:44:58] Hazard-SJ: What about Special:MergeAccount? [05:46:05] Krinkle: You were detached :P [05:46:30] Right.. That happens automatically, I'm never around to see that, naturally. [05:47:25] Krinkle|detached is roughly the same as Krinkle|away [05:47:26] :P [06:03:41] New patchset: Krinkle; "Update VisualEditor submodule to latest master for A/B test" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70034 [06:04:46] New patchset: Krinkle; "Update VisualEditor submodule to latest master for A/B test" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70035 [06:05:09] Except that "away" is when my laptop is still connected to the irc proxy, and detached when I'm not. [06:07:07] Krinkle: don't merge that yet, please [06:07:19] Merge what [06:07:26] I already CR+2'ed it [06:07:42] ori-l: What [06:07:44] 's wrong? [06:08:18] OK, no big deal. I wanted to go over the eventlogging logs to make sure the test data checks out; sometimes that uncovers small bugs. But I don't know of anything wrong so no need to pull the emergency halt lever or anything. [06:08:51] ori-l: We're not starting the A/B test yet [06:09:01] We're fixing code so it's not horrendously broken on the eve of the A/B test [06:09:13] "The A/B test is scheduled for Monday and can be enabled [06:09:13] through mw config." [06:09:16] aha, ok :) [06:09:39] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/70035 [06:11:02] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/70034 [06:15:47] New review: Krinkle; "FIXME: This was not deployed (the meta was pulled to production, but you either didn't deploy it or ..." [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68809 [06:15:54] marktraceur: ^ [06:18:53] Krinkle: Agghhhhh I thought I did that correctly [06:19:07] I'm not deploying so don't do it now in case you were [06:19:10] .. about to [06:19:13] now* [06:19:16] I am now deploying code [06:19:24] Krinkle: Should I deploy it properly on Monday? I think greg-g and James_F said that wmf7 would get deployed automatically next Monday [06:19:29] Er, last Monday [06:20:25] marktraceur: Yes please do [06:20:44] Depends on whether the people that will do the autodeploy on Monday will be slackers and ignore the fact that there is an undeployed change for unknown reasons followed by their decision of deploying it anyway or ignoring it. [06:20:46] :P [06:20:53] I'd recommend you do it before they get to it [06:35:34] Krinkle: I'll keep that in mind. Would it be acceptable for me to tell them not to be lazy? [06:37:06] It would, if you're not afraid of a combined deployment [06:46:28] RoanKattouw: I don't think it would be a problem - what are the potential side effects? [06:48:44] If your UW change breaks things, blame might be placed on the larger update [06:50:26] RoanKattouw: Considering the change was deployed already in wmf6, I'm not so worried [06:50:33] OK that's fine then [06:50:45] So then instruct Sam accordingly and it'll all be fine [06:52:08] Righto [06:52:27] * marktraceur tells Reedy to update UploadWizard on the next deployment [07:05:17] New patchset: Nischayn22; "Use statistics from the stats table not Count(*) " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [07:23:23] New patchset: Nischayn22; "Show a disabled form for users without permissions." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [07:25:40] New patchset: Nischayn22; "Show a disabled form for users without permissions." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [08:08:42] New review: Mwjames; "Tests are still failing." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [08:09:32] New patchset: Mwjames; "Use statistics from the stats table not Count(*)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [08:14:18] hello. For E:UserMerge I need a clever database query for multi-row deletion from table watchlist to remove duplicates wl_user, wl_namespace, wl_title ... Is someone listening here who can help me ? [08:17:53] Wikinaut: and you are asking in here compared to #mediawiki, why? [08:21:07] p858snake: why not here, the channel header on #wikimedia.dev says "MediaWiki and Wikimedia software development" (I wanted to cross-post it in #mediawiki when I don't get an answer here.) [08:21:27] I am not sure, for what exactly the -dev channel is. [08:21:41] for instances etc ? [08:46:25] New patchset: Krinkle; "Always quote attribute values ending in a backslash." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67603 [08:48:38] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67603 [08:55:46] New patchset: Alex Monk; "Add ID to action=info table rows" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70028 [09:05:39] New patchset: Krinkle; "Set $wgWellFormedXml to false by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70036 [09:06:59] New review: Nischayn22; "The problem I am facing is that these tests are running fine locally" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [09:07:30] New patchset: Krinkle; "Set $wgWellFormedXml to false by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70036 [09:08:48] New patchset: Krinkle; "Set $wgWellFormedXml to false by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70036 [09:32:03] New patchset: Krinkle; "Fix typo "relavent" in release notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70037 [09:36:00] New review: Mwjames; "Doing a get_class is not a fine design approach, what if you mock the store with an implied assumpti..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [09:58:11] New patchset: Mati; "add and use updateExternalDBGroups function, fixes #49641" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70040 [11:07:25] New review: Wikinaut; "Tyler, just to avoid double-work: I am working on that now (deduplication of common watchlist entrie..." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/69017 [12:01:24] New patchset: Mwjames; "SMW\SQLStore\PropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/70041 [12:05:11] New review: Mwjames; "Karsten, as always would you mind having a look at the message part." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/70041 [12:23:21] New review: Mwjames; "It took me considerable time to design tests (especially the mocks) that would cover every possible ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/70041 [14:16:59] New review: Nischayn22; "Damn my core was behind master." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:24:56] New review: Nischayn22; "But apparently that's not the matter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:25:04] New patchset: Nischayn22; "Use statistics from the stats table not Count(*)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:41:09] New review: Mwjames; "You are changing from DB select to selectRow but the DB Mock don't know anything about selectRow." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:43:43] New patchset: Karima Rafes; "The text of link is only Create" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70044 [14:53:59] New patchset: Plavi; "Ruby warnings cleanup in cucumber step files" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/70045 [15:01:35] New patchset: Mwjames; "Use statistics from the stats table not Count(*) " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [15:24:23] New review: Alex Monk; "I wonder what other cases it breaks in." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [15:45:29] New patchset: Alex Monk; "Fix some Echo-related messages" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/70046 [15:51:13] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/58096 [15:52:37] New review: Alex Monk; "per previous comment" [mediawiki/extensions/PopupPages] (master) C: -1; - https://gerrit.wikimedia.org/r/51843 [15:58:00] New review: Mwjames; "## Tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [16:00:53] New review: Se4598; "after looking at http://de.wikipedia.beta.wmflabs.org/w/index.php?oldid=2802" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [16:02:36] New review: Alex Monk; "Needs rebase as well" [mediawiki/extensions/GeoCrumbs] (master) C: -1; - https://gerrit.wikimedia.org/r/39728 [16:04:20] New review: Alex Monk; "Needs rebase, and please take into account Jeroen's comments" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/43803 [16:05:29] New review: Alex Monk; "Also needs rebase" [mediawiki/extensions/LiquidThreads] (master) C: -1; - https://gerrit.wikimedia.org/r/58096 [16:11:58] New review: Alex Monk; "Requires Ia3daaeba and needs rebase." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/65109 [16:14:46] New review: Alex Monk; "Needs rebase." [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/61568 [16:19:37] New review: Alex Monk; "Needs rebase, code style comments inline." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/35626 [16:20:59] New review: Kghbln; "Nice changes! I18n looks good to me. :)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1; - https://gerrit.wikimedia.org/r/70041 [16:24:58] New review: Nischayn22; "There could be a small difference depending on a wiki. I think the difference arises from duplicate ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [16:26:29] New review: RAN1; "Seems to work now in terms of creating, deleting, and reading tweets. This should be about ready to ..." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/70029 [16:28:32] New patchset: QChris; "Always set change status for ChangeAttributes" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/69429 [16:28:32] Change merged: QChris; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/69429 [16:31:03] New review: QChris; "On updating the wmf branch, gerrit auto-merged this change, as it has been accepted upstream." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/69429 [16:31:18] New patchset: Dbeeson; "Fixes RDF export of subobjects" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/70047 [16:33:38] New patchset: QChris; "Harmonize color of first data row for tables" [gerrit] (master) - https://gerrit.wikimedia.org/r/70048 [16:33:39] New patchset: QChris; "Pretend to color change table rows by data row index" [gerrit] (master) - https://gerrit.wikimedia.org/r/70049 [16:34:49] Change abandoned: QChris; "Wrong branch" [gerrit] (master) - https://gerrit.wikimedia.org/r/70048 [16:34:56] Change abandoned: QChris; "Wrong branch" [gerrit] (master) - https://gerrit.wikimedia.org/r/70049 [16:36:17] New review: Alex Monk; "Needs another rebase." [mediawiki/extensions/CheckUser] (master) C: -1; - https://gerrit.wikimedia.org/r/11562 [16:36:22] New patchset: QChris; "Pretend to color change table rows by data row index" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64306 [16:36:23] New patchset: QChris; "Harmonize color of first data row for tables" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64305 [16:37:50] New review: Alex Monk; "Nischay's issue is valid, and needs rebase." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/47212 [16:38:19] New patchset: QChris; "Add REST endpoint to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64299 [16:38:20] New patchset: QChris; "Add SSH command to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64298 [16:38:20] New patchset: QChris; "Add infrastructure for renaming of projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [16:38:21] New patchset: QChris; "Add separate capability to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64301 [16:38:21] New patchset: QChris; "Add UI to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64300 [16:38:21] New patchset: QChris; "Add test infrastructure for tests that use logging and mocking" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70050 [16:38:22] New patchset: QChris; "Add project renaming task to reparent all child projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70051 [16:38:22] New patchset: QChris; "Add project renaming task to update the changes table" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70052 [16:38:22] New patchset: QChris; "Add project renaming task to update project watches" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70053 [16:38:23] New patchset: QChris; "Add project renaming task to move the git repository itself" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70054 [16:38:23] New patchset: QChris; "Add project renaming task to temporarily block access to target" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70055 [16:38:23] New patchset: QChris; "Add project renaming task to update subscriptions' super projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/70056 [16:41:59] New patchset: QChris; "Bring draft status to PatchSetAttribute" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/69428 [16:54:41] New review: Alex Monk; "Needs rebase" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/59387 [17:01:02] New review: QChris; "This series of rebased changes builds again against latest wmf." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [17:21:14] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/70027 [17:49:39] New review: Alex Monk; "Needs rebase." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/3808 [17:50:24] New review: Mwjames; "Hmm ... I checked my dev wiki and [[Special:Statistics]] shows:" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [18:13:43] New patchset: Ori.livneh; "Validate adherence to 'enum' constraint in server-side logging" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/70062 [18:41:52] New patchset: Matthias Mullie; "(bug 44827) Show amount of remaining characters for moderation-note" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59387 [19:54:35] New patchset: Mwjames; "Use statistics from the stats table not Count(*)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [20:00:32] New review: Mwjames; "I extended the tests (code coverage is again 100%) but the discrepancy mentioned earlier needs some ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [20:00:52] New patchset: Cmcmahon; "WIP use this code as a start for the training exercise June 27 before merging" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283 [20:05:04] New review: Matmarex; "Tyler, replied." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64565 [20:07:40] New review: Parent5446; "Haven't tested." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/70028 [20:08:33] Yippie, build fixed! [20:08:34] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #6: FIXED in 4 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/6/ [20:08:53] New patchset: Matmarex; "Refactor watchlist token handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [20:11:59] New patchset: Matmarex; "Refactor watchlist token handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [20:19:36] New patchset: Parent5446; "Add and use updateExternalDBGroups function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70040 [20:29:19] New review: Helder.wiki; "(1 comment)" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [20:42:28] New patchset: Rfaulk; "mod. have check_lock return false on 'ls' fail." [sartoris] (master) - https://gerrit.wikimedia.org/r/70101 [20:43:24] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/70101 [20:54:12] New patchset: Rfaulk; "mod. logging for lock removal on remote." [sartoris] (master) - https://gerrit.wikimedia.org/r/70102 [20:54:30] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/70102 [21:02:09] I'm trying to build a parser extension, I've confirmed that me setup function gets called and I run $parser->setFunctionHook( 'eveShips', 'EveShipRenderParserFunction' ); but when I put {{#eveShips}} in a wiki page my function never gets called [21:02:15] what did I do wrong? [21:02:30] function header [21:02:31] function EveShipRenderParserFunction( $parser ) { [21:03:18] waterfoul__: shouldn't that be … setFunctionHook( '#eveShips' … ? [21:03:39] * MatmaRex doesn't know what he's talking about [21:04:54] causes [464c4711] 2013-06-23 21:04:43: Fatal exception of type MWException [21:05:47] hm. all i can recommend is to look at how other extensions do this, sorry :( [21:06:21] my code is based off the example on the wiki... [22:05:36] New patchset: Ori.livneh; "Fix redis module" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/70105 [22:06:29] waterfoul__: parser functions are deprecated in favor of scribunto / lua [22:06:52] can you look up the exception in the error log? i presume this is on wikia, right? [22:45:55] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [22:51:11] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [22:53:15] New review: Alex Monk; "Seems that the link breaks if ANY character, not just the one immediately after the ']]', is upper-c..." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [23:57:38] seems nbrad has problem with echo: http://en.wikipedia.org/wiki/User_talk:Newyorkbrad#Question_for_TPWs [23:58:38] I commented.