[00:14:51] New review: CSteipp; "(1 comment)" [mediawiki/extensions/OAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/69958 [00:19:35] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69855 [00:24:37] New patchset: Kaldari; "Adding support for primary links in notification" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/69964 [00:46:25] New patchset: Ori.livneh; "Don't log null UASs" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/69966 [01:06:11] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [03:27:49] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #65: FAILURE in 7 min 59 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/65/ [03:33:07] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #65: FAILURE in 8 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/65/ [03:35:47] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #103: FAILURE in 7 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/103/ [03:46:16] New review: Dan-nl; "brian," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67229 [05:55:55] New review: FastLizard4; "Code review looks good, now testing" [mediawiki/extensions/CommunityTwitter] (master) C: 2; - https://gerrit.wikimedia.org/r/69275 [05:58:39] New review: FastLizard4; "Tests OK, go for merge!" [mediawiki/extensions/CommunityTwitter] (master); V: 2 - https://gerrit.wikimedia.org/r/69275 [05:58:39] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [06:26:04] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62005 [07:53:24] New review: Nikerabbit; "I don't understand. isset returns false for null." [mediawiki/extensions/CoreEvents] (master) C: -1; - https://gerrit.wikimedia.org/r/69966 [08:32:13] New patchset: Umherirrender; "date_default_timezone_set unnneeded in Parser::getVariableValue" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971 [08:56:01] New patchset: Nikerabbit; "Allow text selection in page mode" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69972 [09:34:28] New patchset: Umherirrender; "date_default_timezone_set unnneeded in Parser" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69971 [09:55:30] New patchset: Rtdwivedi; "Separated data fetching from manipulation for page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [10:17:56] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [10:20:25] New patchset: Esanders; "Allow postEdit confirmation to be triggered asynchronously" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [10:23:21] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [11:30:33] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [11:35:49] New patchset: Nikerabbit; "Make the proofread tooltip get stuck less in wrong places" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69974 [11:36:48] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [11:44:58] New patchset: Nikerabbit; "Check that response.error exists before using it" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69975 [11:50:12] New review: Daniel Kinzler; "@Krinkle: I'm not sure I really follow your logic. When would the error ocurr? Not in the constructo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [12:14:39] New review: Mwjames; "For all apparent changes, tests are accompanied. Feel free to revert but since my time is precious I..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/69859 [12:15:58] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [13:14:51] New patchset: Matmarex; "Make image pagination not require a page load." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [13:15:14] New patchset: Kipcool; "css z-index" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69976 [13:15:30] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69976 [13:16:04] New review: Matmarex; "I went ahead and fixed issues raised on the previous patchset myself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [13:20:05] New patchset: Matmarex; "Make image pagination not require a page load." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [13:21:44] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69886 [13:24:25] New patchset: Matmarex; "Don't use a for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [14:03:24] New patchset: Nikerabbit; "Make the proofread tooltip get stuck less in wrong places" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69974 [14:07:48] New patchset: Nikerabbit; "Check that response.error exists before using it" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69975 [14:18:56] New patchset: Jeroen De Dauw; "Deprecate assertException in MediaWikiTestCase as it adds no value" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64499 [14:18:57] New patchset: Jeroen De Dauw; "Deprecate Site::newForType since it is so bad" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65691 [14:27:00] New patchset: Jeroen De Dauw; "Remove Settings::newFromGlobals" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/69977 [14:40:33] New patchset: Jeroen De Dauw; "Fix unserialization of revision data" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/69978 [14:50:41] New patchset: Jeroen De Dauw; "Use markdown in readme file and link to TravisCI and Jenkins build status" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69979 [14:56:24] New patchset: Jeroen De Dauw; "Use markdown in readme file and link to TravisCI and Jenkins build status" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69979 [14:56:44] New patchset: Jeroen De Dauw; "Improvements to enrollment code [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63914 [15:09:52] New patchset: Jeroen De Dauw; "Register unit tests automatically with MW" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/69980 [15:10:05] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/69980 [15:37:52] New patchset: Jeroen De Dauw; "Improvements to enrollment code" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63914 [15:42:40] New review: Tpt; "Some remaining errors." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [15:46:52] New review: Tpt; "Some basic things." [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/69973 [15:53:43] New patchset: Alex Monk; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [16:01:08] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [16:09:20] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [16:10:54] Change merged: jenkins-bot; [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/69779 [16:14:40] New review: Alex Monk; "just js style issues" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [16:18:59] New patchset: Alex Monk; "Cleanup JS" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69314 [16:27:22] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:50:01] New patchset: Alex Monk; "Tweak account creation interface messages for logged in users" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39862 [16:56:29] New patchset: Jeroen De Dauw; "Improvements to enrollment code" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63914 [17:13:29] New patchset: Alex Monk; "Set taborder for Special:ListFiles" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/49595 [17:21:20] New patchset: Alex Monk; "(bug 44900) Allow wildcard searching in wiki IDs for interwiki user rights logs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48661 [19:07:58] New patchset: Mollywhite; "(bug 42731) Fix bullet point overlap in "See also" section. Remove a bullet point image that's added by vector.css Bug: 42731" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/69983 [19:09:11] New patchset: Alex Monk; "(bug 42731) Fix bullet point overlap in "See also" section." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/69983 [19:17:44] New patchset: Rtdwivedi; "Editing system for pages separated." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69973 [19:22:48] ...hmm I randomly had an idea how to deal with the issue of extensions that need common JS libraries that we don't package in core and some other extension may need too. [19:27:02] package them in core. ✓ problem solved! [19:27:10] :P [19:42:53] MatmaRex: I'm thinking of how to handle the intermediate issue. The fact that the extension is going to be released but stable doesn't have the library. [19:44:54] I can come up with a half dozen useful libraries we have no use for... and we could pack those into core. [19:45:45] ...then I could hand over microjs.com's list of JS libraries and tell you that we still don't have every JS library that an extension may want to use. [19:46:27] Then we could go against all sanity and package every single js library we know of including all the stuff on that list into core. [19:46:55] ;) And then an extension could come along and tell us that a number of extensions could really use a jquery plugin we don't have. [19:53:57] New review: Mattflaschen; "Per Nikerabbit. If an array has a value of null at a particular index, it is *not* considered set t..." [mediawiki/extensions/CoreEvents] (master) C: -1; - https://gerrit.wikimedia.org/r/69966 [20:11:21] New patchset: Rudolf.grossmann; "Change-Id: I1cfa6262a2f2ab0429a56ca34ff374f31de21f72" [mediawiki/extensions/FormelApplet] (master) - https://gerrit.wikimedia.org/r/69985 [20:21:32] i just wrote some CSS liberally using CSS3 selectors. it felt good. [20:28:44] New patchset: Rtdwivedi; "Separated data fetching from manipulation for page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [20:52:56] New patchset: Rachel99; "WIP add ve_refs check - not finished. just checking that my changed email address works in Gerrit" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [20:55:36] New review: Rachel99; "Code didn't change. I'm just checking that my changed email address in Gerrit is working properly." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [20:55:57] Nischayn22: I've decided to take on the task of making your patches with async: false work a little better [20:56:28] New patchset: MarkTraceur; "licenseInput: Handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [21:00:19] Nischayn22: Can you remind me why https://gerrit.wikimedia.org/r/#/c/50755/9/resources/mw.UploadWizardLicenseInput.js can't be async? [21:09:04] Nischayn22: Never mind, I get it now [21:55:59] New patchset: Nischayn22; "Show a disabled form for users without permissions." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [21:56:31] Nischayn22: Reping, I'm still working on gerrit 50755, so don't try to mess with it or we might conflict [21:57:26] Nischayn22: Also is 70027 a bug fix or a feature addition? [21:57:53] Also, cool that we got past 50k bugs and 70k patches in the same night [22:39:57] New review: Alex Monk; "See bug for example code to use to display 'can read but not modify' text" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/70027 [23:07:16] New patchset: Alex Monk; "Add ID to action=info table rows" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/70028 [23:39:39] New review: Krinkle; "Where would $registry come from in your example? In unit tests you can instantiate the class with wh..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [23:47:05] New patchset: RAN1; "Update twitteroauth files to fix for Twitter API v1.1" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/70029