[00:00:57] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [00:03:38] Change merged: jenkins-bot; [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/69818 [00:04:58] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [00:05:11] <^demon> Aaron|home: Ok, redid all of that. [00:05:51] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [00:06:58] New review: MarkTraceur; "Just a rebase. The thing actually runs now, though, so we're moving forward." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [00:07:18] Nikerabbit: fair amount of MessageGroupStats::forItemInternal deadlocks in dberrors.log [00:07:44] New review: MarkTraceur; "PS2 was the push we needed to get this running again. Uploads now work." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [00:08:11] New patchset: MaxSem; "Remove unused RL config var" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69820 [00:19:50] New patchset: RAN1; "Divide communitytwitter-access-error into sub-messages" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [00:26:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648 [00:54:23] New patchset: Mattflaschen; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [01:02:00] New review: Krinkle; "So inside the closure you'd do something like this?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [01:02:49] New review: Krinkle; "Though it would still rely on some global state." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [01:33:02] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [01:34:14] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [01:35:47] New review: Physikerwelt; "@TheDJ: Ok. That's a pitty. I really don't like to copy code. However, that works reliable as tested..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [01:38:32] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [01:39:08] New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596 [01:45:16] New review: Mattflaschen; "I think a subclassing solution (rather than forking the enabler) should work fine. As long as you o..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [02:17:01] New patchset: Mattflaschen; "Preserve returnto when upload requires logging in" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69826 [03:00:44] New patchset: Mattflaschen; "Make it show email as required if you choose to email a random password." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60952 [03:35:49] New patchset: Rfaulk; "mod. refactor _check_lock." [sartoris] (master) - https://gerrit.wikimedia.org/r/69833 [03:36:06] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69833 [03:50:34] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [03:51:53] New review: Mattflaschen; "Sorry, Gerrit mangled the verifyUpload link. It's http://goo.gl/jPYrb" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [03:59:41] New patchset: Mwalker; "Redoing Logging to Make it Less Stupid" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [04:36:14] New review: Mattflaschen; "This looks good." [mediawiki/extensions/Annotator] (master) C: 2; - https://gerrit.wikimedia.org/r/68857 [04:40:02] New patchset: Mattflaschen; "Add non-voting lint checks for Annotator." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69835 [04:41:23] Change merged: Mattflaschen; [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/68857 [04:42:58] New review: Mattflaschen; "Physikerwelt, if we merge this, are there any down-sides for typical users (non-power users)?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64527 [04:45:02] New patchset: Pastakhov; "Add while loops (version 0.4.5)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [04:55:24] New review: Physikerwelt; "To be honest I don't understand what you mean by subclassing solution. Can you sketch it?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [05:31:30] New patchset: Krinkle; "database: Improve DatabaseMysql::masterPosWait() performance by caching the position" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [05:31:51] New patchset: Krinkle; "database: Simplify selectSQLText() and fix USE INDEX bug" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64182 [05:33:24] New patchset: Krinkle; "Change @since and @deprecated notes to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64549 [05:38:46] New review: Krinkle; "Confirmed that the added lines in the release notes are also no longer in the release notes file in ..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64549 [05:41:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64549 [05:42:29] New patchset: Physikerwelt; "Fix: Missing equation ids" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69838 [05:44:50] New review: Physikerwelt; "No. Not from a technical perspective. However it splits the user-base further. Those, who have the f..." [mediawiki/extensions/Math] (master) C: 1; - https://gerrit.wikimedia.org/r/64527 [05:45:07] New patchset: Physikerwelt; "Fix: Missing equation ids" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69838 [05:45:40] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69838 [06:08:24] New patchset: Krinkle; "mediawiki.api.parse: Specify wikitext as the content model" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69472 [06:12:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69472 [06:39:11] New patchset: Rtdwivedi; "Separated data fetching from manipulation for page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [06:46:25] New patchset: Mwalker; "SmashPig now Uses Composer! (And Symfony/HttpFramework)" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69839 [06:53:15] Aaron|home: is there a bug for that? [06:53:52] * Aaron|home has no idea what "that" is [06:56:29] New patchset: RAN1; "Divide access-error into sub-messages, add block check" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [07:16:18] New patchset: RAN1; "Divide access-error into sub-messages, add block check" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [07:21:28] New review: RAN1; "Error checking and messages seem to work in tests of all new cases. Messages are as complete and con..." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/69275 [07:25:12] New review: Raimond Spekking; "+1 from i18n side. Thanks for your improvements." [mediawiki/extensions/CommunityTwitter] (master) C: 1; - https://gerrit.wikimedia.org/r/69275 [08:17:29] New patchset: SuchABot; "Explicitly specify which class comes from which File" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [08:22:38] hello [08:25:39] New patchset: Spage; "Add campaign to login form's signup link." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/69841 [08:26:55] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69654 [08:27:01] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [08:27:03] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/69664 [08:27:07] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Transliterator] (master) - https://gerrit.wikimedia.org/r/69666 [08:28:27] New review: Nischayn22; "Can't even recall what I did here :p" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/54702 [08:36:03] New review: Nischayn22; "Improperly rebased" [mediawiki/extensions/UploadWizard] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/54127 [08:40:10] Change abandoned: Spage; "Reedy beat me to it by 4 minutes with change https://gerrit.wikimedia.org/r/#/c/69693/" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69694 [08:41:28] New review: Ori.livneh; "What about allowing the callback to cancel module instantiation by returning null?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [08:42:00] New patchset: Darkdadaah; "New tool to analyze Wiktionary interwiki links in dumps" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/69842 [08:42:14] New patchset: Nischayn22; "Link to custom copyright tags were wrong." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53041 [08:43:09] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/69842 [08:47:13] New review: Nischayn22; "Why have multiple classes in one file?" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [08:51:36] New review: Yuvipanda; "I'm working on https://www.mediawiki.org/wiki/User:Yuvipanda/Campaigns_namespace_proposal, and that ..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [09:01:17] New patchset: Yuvipanda; "Explicitly specify which class comes from which File" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [09:03:04] New review: Yuvipanda; "Commit message amended to postpone bikeshed" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [09:04:38] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69840 [09:35:35] New patchset: Pastakhov; "Add while loops (version 0.4.5)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69836 [10:14:47] New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [10:15:34] New review: Nischayn22; "Strange, I see no reason for that bug. Working fine for me." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [10:28:55] New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [10:29:46] New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [10:33:17] New review: Hashar; "Generates an apk under https://integration.wikimedia.org/nightly/mobile/android-commons/" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/68566 [10:33:20] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [10:50:04] New patchset: Hashar; "postmerge now reports back to Gerrit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69851 [10:50:40] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69851 [11:04:12] New patchset: Zfilipin; "WIP test aiming to play Commons Media of the Day" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [11:04:35] New review: Zfilipin; "Changed commit message to start with WIP (work in progress)." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [11:05:48] New patchset: Zfilipin; "WIP test aiming to play Commons Media of the Day" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [11:06:12] New review: Zfilipin; "Added bug numer to the commit message." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [11:07:19] New patchset: Zfilipin; "WIP use this code as a start for the training exercise June 27 before merging" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283 [11:08:39] New review: Zfilipin; "Changed commit message to start with WIP (work in progress)." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283 [11:24:24] New patchset: Zfilipin; "WIP test aiming to play Commons Media of the Day" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [11:29:29] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [11:41:07] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) C: -1; - https://gerrit.wikimedia.org/r/68952 [12:34:46] New patchset: Esanders; "Allow postEdit confirmation to be triggered asynchronously" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [12:36:23] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952 [12:38:51] Anyone got a clue why Gerrit complains about "fatal: Needed a single revision, invalid upstream 2d97168fcaed6964b1e6d79ddbda6a9e31f2125a" when doing "git rebase 2d97168fcaed6964b1e6d79ddbda6a9e31f2125a" on 69827? There should be nothing wrong with that since that Change-ID I want to rebase to is the last patch-set of the original change-set 69827 is based on. [12:40:45] New patchset: Esanders; "Allow postEdit confirmation to be triggered asynchronously" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [12:41:24] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69820 [12:45:57] argh, just changed the commit message of 2d97168fcaed6964b1e6d79ddbda6a9e31f2125a's change set twice, now rebaseing to the new ID, works like a charm... Gerrit's so strange [13:05:12] I recal there was a page with SQL queries being used on the DB - anyone remeber where it is ? [13:22:29] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [13:23:14] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [13:28:43] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [13:42:02] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [13:47:34] New patchset: Zfilipin; "WIP test aiming to play Commons Media of the Day" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [13:48:44] New patchset: Zfilipin; "WIP test aiming to play Commons Media of the Day" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/50468 [13:50:44] New review: Mwjames; "Not unexpected because of @group Database ... " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [13:54:56] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952 [13:57:51] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:00:44] New review: Mwjames; "Expect failures because of the setup/teardown of unitest tables but I don't want to make SpecialTest..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:06:32] New patchset: Matthias Mullie; "Abort page restriction if no null revision can be created" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69861 [14:10:21] New review: Zfilipin; "I have made a few minor updates, but it is not finished yet, do not merge." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/50468 [14:11:38] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:14:46] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:15:24] New review: Zfilipin; "Let's agree on convention when pushing commits to Gerrit that are not finished. Chris said a day or ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [14:17:06] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [14:23:01] New review: Mwjames; "Still failing on Error: 1 no such table: unittest_unittest_smw_object_ids" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:24:09] New patchset: Hashar; "jenkins validation ignore me" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69862 [14:25:49] New review: Matthias Mullie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [14:30:05] New patchset: Hashar; "jenkins validation ignore me" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69862 [14:32:46] New review: Jforrester; "I'm not entirely convinced that this should take over-ride messages, so much as have different condi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [14:32:57] New patchset: Hashar; "phpcs-HEAD building macro now use git-changed-in-head" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69863 [14:33:14] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69862 [14:33:22] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69863 [14:52:22] New review: Mwjames; "I don't what is going or why the unittest table doesn't exists. Doing a var_dump now since locally I..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:52:50] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:53:01] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [14:56:11] New review: Mwjames; "Doing var_dump( $storeIdTableName, $this->dbConnection->tableExists( $storeIdTableName ) );" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [14:56:52] New patchset: Zfilipin; "WIP $session_id variable requires that @browser variable is initialized" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69690 [14:58:39] New patchset: Zfilipin; "WIP $session_id requires that @browser is initialized" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69690 [15:02:42] Change abandoned: Zfilipin; "No reply in two weeks, abandoning the commit. Indrani, we can restore the commit if you plan to cont..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62968 [15:03:42] chrismcmahon: are we pairing now? [15:07:33] New patchset: Mwjames; "SMW\UnusedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69859 [15:18:26] New patchset: Zfilipin; "Change the time when Jenkins jobs run" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69865 [15:20:46] New patchset: Zfilipin; "Change the time when Jenkins jobs run" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69865 [15:21:10] New review: Zfilipin; "Added bug number to commit message." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69865 [15:39:07] New patchset: Anomie; "Clean up transform dimension height handling" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69869 [15:40:38] New patchset: Cmcmahon; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69635 [15:40:56] New review: Cmcmahon; "maintenance" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/69635 [15:40:57] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69635 [15:48:15] New patchset: Hashar; "test: skip math parser tests when missing $wgTexvc" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [15:50:11] New patchset: Hashar; "mark parsertests with option 'math'" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [15:50:51] New patchset: Hashar; "mark parsertests with option 'math'" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69873 [15:50:56] New patchset: Hashar; "test: skip math parser tests when missing $wgTexvc" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69872 [15:54:53] ^demon: Hi! [15:54:55] ^demon: *big-nice-friendly-smile* Any chance I can talk you into updating gerrit? [15:55:44] * Platonides wonders who is this chris. We have too much of them :P [15:55:52] :-) [15:56:20] que, chris? :D [15:57:38] Oh... freenode killed the trailing chris ... [15:58:06] <^demon> I upgraded the labs install to the 2.7 branch [15:58:20] <^demon> With a dump of data from prod [15:59:00] Sounds great! [15:59:24] Any chance we can bring that live? [16:00:07] week-end time, see you on monday [16:01:33] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [16:09:40] New patchset: Zfilipin; "Run the tests in Internet Explorer 10" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69875 [16:10:05] New patchset: Zfilipin; "Run the tests in Internet Explorer 10" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69875 [16:15:05] New review: Tpt; "Some comments." [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/69802 [16:16:40] New review: Cmcmahon; "add IE10 builds" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/69875 [16:16:41] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69875 [16:17:06] Project browsertests-test2.wikipedia.org-windows-internet_explorer_10 build #1: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_10/1/ [16:17:48] New review: Physikerwelt; "Looks good. However I suggest to merge this after Jenkins confirms it." [mediawiki/extensions/Math] (master) C: 1; - https://gerrit.wikimedia.org/r/69873 [16:17:49] New patchset: Anomie; "API: Fix imageinfo iiurlheight on audio files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69876 [16:21:37] New review: Anomie; "I found this while investigating bug 49921, a query like https://en.wikipedia.org/w/api.php?action=q..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69876 [16:21:48] Project browsertests-en.wikipedia.org-windows-internet_explorer_10 build #1: SUCCESS in 4 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_10/1/ [16:33:02] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10 build #1: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_10/1/ [16:33:42] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10 build #1: FAILURE in 30 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/1/ [16:37:03] New patchset: Ebrahim; "Fixing Bug 49957 * Disabling Iranian Sans for Persian Wikis as a default font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69878 [16:42:30] New review: Manybubbles; "They syntax highlighter highlights $this->namespace funny that isn't a big deal to me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/69809 [16:51:54] New review: Manybubbles; "This makes sense to me. We'll probably want to be able to configure CirrusSearch to return true dur..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/69515 [17:08:10] New patchset: Anomie; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [17:08:30] New review: Anomie; "Rebased and added RELEASE-NOTES entry." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66038 [17:12:16] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/69876 [17:12:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [17:14:42] New review: Demon; "If you see the latest master in CirrusSearch, you'll see I'm returning false. That way I can handle ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [17:17:13] New review: MarkTraceur; "Didn't test this iteration but it's getting better! :)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [17:19:06] New patchset: Physikerwelt; "Fix: Queries are not escaped properly." [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69882 [17:20:15] New patchset: Physikerwelt; "Fix: Queries are not escaped properly." [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69882 [17:20:35] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/69882 [17:20:36] New review: Parent5446; "Qqq needs to be updated with parameter." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69826 [17:22:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69809 [17:24:55] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [17:35:38] New patchset: Rtdwivedi; "Separated data fetching from manipulation for page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [17:44:21] grr fatal: reference is not a tree: 1d4f93ee40cfef18b31d7ec85f7113fc6dc87914 [17:46:56] brion: http://nataliedee.com/i-am-a-tree.jpg [17:47:28] :) [17:54:26] brion: Apparently the repos for DataTypes, ValueFormatters, ValueParsers, ValueValidators, and ValueView are broken somehow, they have no branches or revisions. And WikibaseDatabase and WikibaseQuery are pointing at nonexistent revisions, but they at least have a 'master' branch. ^demon or Reedy, can this be easily fixed or should we just remove those first five from the mediawiki/extensions project until someone does whatever work is needed? [17:54:42] ugh [17:55:08] <^demon> Bug JeroenDeDauw. [17:55:17] <^demon> He's supposedly committing code to them, so I made them empty on purpose. [17:55:23] <^demon> They're not *broken*, just lack a master. [17:55:48] well, 'git submodule update' stops and i'm not convinced it's updating everything [17:55:51] so .... not good. [17:56:27] ^demon: They've been like that for some time now. How much longer do we have to wait? [17:57:02] <^demon> Again, but JeroenDeDauw, or delete them from mediawiki/extensions. [17:57:08] <^demon> I dunno where his code is or what he's doing with it. [17:57:39] why don't i push a .gitreview to the repos that don't have a master branch [17:57:45] that should fix it, no? [17:57:57] * ori-l tries [17:58:48] ori-l: If it doesn't work, I'm readying a changeset to delete them for now. [17:59:01] <^demon> If you push a .gitreview to it, I'll get an angry e-mail from someone saying to leave the repos empty [17:59:05] <^demon> Just remove them from the meta repo. [18:00:05] do you think deleting them is less likely to make someone angry? (not snarking, asking seriously) [18:00:53] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [18:00:56] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [18:00:59] <^demon> ori-l: Probably, yes [18:01:09] New patchset: Anomie; "Remove empty submodules, fix others" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/69885 [18:01:12] anomie: in that case, go ahead [18:01:42] <^demon> I hate maintaining that stupid meta-repo. [18:01:48] <^demon> It's such a pain in the ass. [18:01:55] New patchset: Anomie; "Remove empty submodules, fix others" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/69885 [18:02:03] why isn't that automated [18:02:13] ^demon, ori-l: https://gerrit.wikimedia.org/r/69885 [18:02:24] <^demon> Nikerabbit: New repos have to be added, but they're supposed to update automatically. [18:02:29] Change merged: Ori.livneh; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/69885 [18:05:02] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [18:09:20] New patchset: Physikerwelt; "Refactor configuratable allowed root elements" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69886 [18:11:46] New patchset: Ori.livneh; "Make 'trackActionURL' pass-thru" [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/69887 [18:12:01] ugh the broken submodules keep getting recreated [18:12:13] i'll just update from master in each repo instead of git submodule update :P [18:12:54] brion: If you do a pull on mediawiki/extensions, they should be gone now. [18:13:02] oh yay [18:13:28] * brion does the happy dance [18:13:48] <^demon> I've got a weird parser question. [18:13:55] ^demon: Speaking of "supposed to update automatically", do we know anything more about bug 48893? [18:14:05] ^demon, luck for you we've got a weird parser. [18:14:27] <^demon> anomie: I fixed VisualEditor. [18:14:52] Ooh, what was wrong with it? Want a list of other modules that seem broken? [18:15:08] <^demon> Misconfigured at some point, and feature wasn't robust enough to pick up when it was fixed. [18:15:12] <^demon> Had to fix manually in the DB [18:15:24] <^demon> brion: If I've got some $text, and I want both the preprocessed text and final ParserOutput, can I do that without parsing twice? [18:15:40] <^demon> I'd really really like to avoid having to call preprocess() && parse() [18:16:45] <^demon> Crickets. [18:16:57] ^demon, hmm [18:17:04] ^demon, preprocessor is MUCH faster than the full parser [18:17:09] so worst case, it's not the end of the world [18:17:17] ^demon, check what api query revisions does [18:17:35] it's got an option to retrieve preproc xml, and also to retrieve html output [18:17:39] and can return them both together [18:18:06] i wish preprocessor included [[links]] [18:18:30] ApiQueryRevisions calls preprocess() and parse(). Well, actually preprocess() and $content->getParserOutput(). [18:18:40] hmm [18:19:17] <^demon> Which ends up calling parse() [18:19:17] <^demon> That's what I'm doing now [18:19:30] Looking at the code, it doesn't look like there's a straightforward way to get preprocessed and parsed, since Parser::preprocess isn't strictly "parse() but stop after step X" [18:20:08] <^demon> Granted, if you're calling parse() then hopefully you're hitting the parser cache. [18:20:08] It's more like "parse() but skip steps X to Y, but still do step Z at the end" [18:20:48] <^demon> Hmm. Well does anything in http://p.defau.lt/?kj9Y4S1oaJx3Yb4WqrQJww stand out as low-hanging fruit for optimization? [18:20:50] New patchset: Aaron Schulz; "Removed some inappropriate global state from FSFile." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69889 [18:21:11] <^demon> I'm trying to improve this script: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCirrusSearch.git/HEAD/forceSolrIndex.php [18:21:19] ^demon: you could also use Parsoid output [18:21:44] <^demon> I'd rather not make this depend on parsoid. [18:21:53] heh, someone using --profiler [18:22:13] <^demon> This script is helllllaaaa slow right now [18:22:16] <^demon> And I need to make it not. [18:22:20] ^demon: we'll soon have a generic 'give me HTML+RDFa' API [18:22:35] that will abstract if that HTML comes from the DB or Parsoid [18:22:53] I'd at least keep it in mind for the longer term [18:23:06] <^demon> Yes [18:23:07] Google will also use that output to index Wikipedia [18:23:21] <^demon> And I'm using Content stuff, so if that supports it then my code will too. [18:23:50] ETA for the API is sometime in July [18:24:31] <^demon> Hmm, I might get by without needing preprocessed text. [18:24:51] <^demon> manybubbles: So, I've been playing with the text we index and I think we need to decide what we're going to index. [18:25:05] ^demon: Are you hitting the parser cache in there? [18:25:11] <^demon> Prolly not. [18:25:25] <^demon> Obviously we want templates expanded, I'm not 100% on what exactly we want in Solr. [18:25:38] New patchset: Aaron Schulz; "Removed some inappropriate global state from FSFile." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69889 [18:25:58] <^demon> I'm open to input from anyone on this who has a good idea :) [18:26:40] I was thinking we'd want to index pretty much a plain text copy of the article. [18:27:06] <^demon> So would the best thing be to just take the final parsed version and strip html? [18:27:07] we can add a filter to turn html into that plain text if we have html and need it. I'm sure the filter is super quick. [18:27:23] I _think_ we can have solr strip the html for us [18:27:33] <^demon> That would make life even easier. [18:27:39] I'm only mentioning the final parsed html because it might be something simpler to make than plain text [18:28:03] <^demon> However, we're already hitting the problem that Mobile has. If we expand templates, that means we're also expanding stuff like maintenance templates. [18:28:20] <^demon> So if you search for something that matches a template, you get some overzealous results. [18:28:30] I'm not really sure what that is so give me bit to look it up. [18:28:51] <^demon> eg: https://en.wikipedia.org/wiki/Andr%C3%A9_Pierre_Charles [18:28:57] <^demon> Template at top of page gets included [18:29:10] * anomie searches for "citation needed" [18:29:23] <^demon> So if you search for something like "Verification," you end up with a ton of bogus results not actually about verifying anything :) [18:29:27] I honestly not convinced that is a bad thing. [18:29:53] Yippie, build fixed! [18:29:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #64: FIXED in 8 min 8 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/64/ [18:30:01] <^demon> anomie: Also that, yes. [18:30:16] <^demon> So, I'm starting to see why lsearchd didn't expand these. [18:30:41] <^demon> Parsing is a damn rabbit hole :) [18:30:45] but not expanding them in general gives a much less rich index. [18:30:46] yeah. [18:31:09] we could build something to carefully select which templates to expand. the problem with that is that we're already too slow [18:32:04] <^demon> I believe mobile does it with a list of templates to exclude. [18:32:07] <^demon> But yes, we're already slow [18:32:44] looks like it is one extra line of config to strip html characters from the content in solr. [18:33:20] Code-wise, selectively expanding templates wouldn't actually be too horrible to do. But it would mean you couldn't use the parser cache to speed things up. Maybe just ignore anything inside an element with class="nosearch", and then let the community update all their maintenance templates? [18:33:21] oh, and it un-escapes stuff like A in the index. [18:33:24] <^demon> But I'm kinda in favor of doing the preprocess() model, and then stripping stuff like [18:33:59] ^demon, manybubbles: the Parsoid output marks which part of the page is generated by which template, so you can pick & choose which templates to include in your indexing that way [18:35:03] http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec [18:35:30] gwicke: how commonly is parsoid deployed outside of wmf? [18:35:46] manybubbles: about as common as the VE [18:36:12] so pretty rare then? I've never edited a mediawiki with VE other than ours. [18:36:24] and for the longer term we are working on making the Parsoid HTML format the storage format for MediaWiki [18:36:26] manybubbles: 'none' probably, except experimentally [18:36:38] though we can expect that to change fairly rapidly [18:36:45] (that's my hunch, at least) [18:36:46] so at that point you'll get that HTML without Parsoid being involved [18:37:11] yes, once VE is the default on WP people will want to have it on their own wikis too [18:37:49] we now have the infrastructure that makes retrieving the current HTML a static page request, so very fast & cheap [18:38:37] <^demon> As long as the functionality is in core. I'm really trying to make sure this search is useful to everyone outside WMF too :) [18:39:24] Yippie, build fixed! [18:39:25] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #102: FIXED in 9 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/102/ [18:39:29] ^demon: our goal for next fiscal is to have HTML storage in core [18:39:43] <^demon> That's a little far off for this timeline :( [18:39:56] yeah - we're looking at something in a few weeks [18:40:16] it is usable now, but the backend will change from a custom Parsoid setup to use core natively [18:41:16] so there is some api in core we can call that for now uses parsoid but in future won't? [18:41:25] where future is 12ish months? [18:42:02] manybubbles: that API is currently private to VE, but will have a public outing after the release [18:42:11] the Google folks are waiting for it too [18:42:23] Change abandoned: Mwalker; "No longer relevant" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69324 [18:42:32] it is trivial to write, we just did not have the time to do so yet [18:42:39] mid-July is my guess [18:43:49] manybubbles: internally you can directly request those pages from our cache service too [18:43:50] you are talking about an API in the external sense. How about in the internal sense - like something a plugin can use. [18:44:05] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/69887 [18:44:23] I wouldn't want to rely on cache servers unless the api builds the page on miss. [18:44:36] manybubbles: it builds pages on edit [18:44:49] so the cache should always be close to full [18:44:59] and we would actually like somebody to spider it to fill it further ;) [18:45:07] New patchset: Mwalker; "Redoing Logging to Make it Less Stupid" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69834 [18:45:32] well we'll need to crawl all the articles before we turn on searching for the whole world. [18:45:36] manybubbles: internally you can do HTTP requests like http:///enwiki/title?oldid=1234 [18:46:06] and that builds that page on cache miss? [18:46:14] normally it will return the cached page [18:46:22] but on miss, it will build it on the fly [18:46:41] <^demon> anomie: I'm definitely not using the parser cache here. [18:47:31] New review: Ori.livneh; "..Also note that this makes articleFeedback.fn.trackActionURL behave as an existing comment says it ..." [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/69887 [18:48:35] manybubbles: you can also check out our output at http://parsoid.wmflabs.org/ [18:48:40] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/ArticleFeedback] (master) C: -1; - https://gerrit.wikimedia.org/r/69887 [18:48:48] that is not cached at all though, and on a slow labs VM [18:49:09] the production cache is http://10.2.2.29/ [18:52:07] New patchset: Manybubbles; "Fix name on forceSolrIndex maintenance script." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69892 [18:57:52] New patchset: Ori.livneh; "Make 'trackActionURL' pass-thru" [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/69887 [19:02:54] Change merged: Demon; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69892 [19:09:23] New review: Ori.livneh; "I think it's fine to make the action generic. Making something private / protected because "you shou..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69855 [19:12:15] New review: MarkTraceur; "Good good good! :)" [mediawiki/extensions/UploadWizard] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/53041 [19:12:16] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53041 [19:12:58] <^demon> manybubbles: A-ha! Using parser cache makes it way faster when you hit a non-stale cache. [19:13:21] <^demon> Got it from 1m15s on a stale cache to 19s on a full cache hit. [19:14:45] New patchset: Demon; "Use parser cache" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69895 [19:15:33] New review: Ori.livneh; "No Jenkins, Mattflaschen +2'd." [mediawiki/extensions/ArticleFeedback] (master); V: 2 - https://gerrit.wikimedia.org/r/69887 [19:15:33] Change merged: Ori.livneh; [mediawiki/extensions/ArticleFeedback] (master) - https://gerrit.wikimedia.org/r/69887 [19:15:45] ^ greg-g [19:15:52] * ori-l deploys [19:15:53] New patchset: Alex Monk; "Insert link dialog: Insert simplest form of wikilinks possible" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [19:16:09] New review: Demon; "Current output when you get 100% cache hit: http://p.defau.lt/?SBDgLeEaVIUrd7Ww6fgLfg" [mediawiki/extensions/CirrusSearch] (master) C: 1; - https://gerrit.wikimedia.org/r/69895 [19:18:16] New patchset: Ori.livneh; "Update ArticleFeedback to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69897 [19:18:23] New patchset: Ori.livneh; "Update ArticleFeedback to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69898 [19:22:05] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot" [mediawiki/extensions/UploadWizard] (refs/meta/config) - https://gerrit.wikimedia.org/r/69900 [19:22:27] Change merged: Krinkle; [mediawiki/extensions/UploadWizard] (refs/meta/config) - https://gerrit.wikimedia.org/r/69900 [19:22:44] Krinkle: I'm not sure I want Jenkins to merge UW code [19:22:47] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69897 [19:22:57] Given the tests are, like, useless [19:23:17] marktraceur: The repo already has a gate-and-submit pipeline, I didn't create that [19:23:25] you whenever someone CR+2'ed it would run tests and merge. [19:23:34] Right [19:23:39] it doesn't change anything, just makes it not possible to merge without the tests passing. [19:23:52] I waited for the moment that the tests are passing (whatever tests there area) [19:23:54] are* [19:23:58] Krinkle: Which is absolutely silly because I could CR+2, not having verified things, and it would merge [19:24:08] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69898 [19:24:19] You do know how our workflow or CR+2 works, right? This isn't new. [19:24:25] Don't CR+2 if it isn't ready to merge. [19:24:36] * marktraceur thinks that's not the meaning of CR and V [19:24:45] CR means the code looks good, V means it works properly [19:24:57] Anyway, like I said, I didn't change the jenkins behaviour. It already merged it for you. [19:24:58] https://gerrit.wikimedia.org/r/#/c/53041/ [19:25:05] "Starting gate-and-submit … [19:25:13] I know [19:25:17] "Build succeeded." got rejected because it was already merged. [19:25:44] * marktraceur is annoyed that he has to wait for a service that knows nothing about the extension [19:26:05] teach it something about the extension, then :P [19:26:26] New patchset: Cmcmahon; "add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [19:26:41] {{sofixit}} [19:27:09] V means it passes the automated tests. It does not mean it has been verified by something or someone. Same for other repos, if you manually verify something you can state that in a comment. V+2 must only be set if it (also) passes all automated tests (the version and configuration of jshint, phplint, and qunit/phantomjs etc.) otherwise the next commit would be rejected if it doesn't pass. Which the nex [19:27:09] t user will be annoyed by. [19:27:40] Krinkle: Is it even possible to do testing on browser JavaScript in Jenkins? [19:27:44] * marktraceur doesn't know [19:27:53] If you want to verify things manually before letting it be merged, then go ahead. It won't stop you. (you can do your own verifications first, then code-review and then jenkins does its verifycations and merges) [19:28:00] marktraceur: Yes, has been for almost half a year now. [19:28:04] Hrm [19:28:13] * marktraceur should get 'round to that soon then [19:28:47] All I'm making sure is that you can't merge if it fails jenkins. Whether you decide to merge based on jenkins or jenkins + your own tests (until there are tests that you yourself find reliable) is totally fine and understandable. [19:29:49] marktraceur: I'd recommend starting by adding a .jshintrc file (see [[mw:CC/JS]] for template) and making that pass. [19:32:41] Good plan. [19:33:09] Though it would take...some work, I think [19:33:13] I guess that's mostly OK [19:33:25] But first I guess I should help you jsduckify mw-core :) [19:33:33] Errr, "first" [19:36:44] marktraceur: btw, the current errors for jshint on UploadWizard are moslty false positives due to the absence of a jshintrc file (e.g. whitespace constraints) [19:37:09] Ah, K. [19:37:42] My zeroth task is to finish my immense refactor of a lot of the higher-level "handle a list of things" code in UW [19:41:50] New patchset: Mattflaschen; "Preserve returnto when upload requires logging in" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69826 [19:47:57] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [19:58:36] New review: Se4598; "That approach is simple, but may doesn't work as expected on special cases where the wikilink is not..." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/69896 [20:01:15] New patchset: Kipcool; "Using automatic css ellipsis instead of fixed truncation for definitions in header. Also reduced a bit the text sizes." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69903 [20:01:50] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #68: STILL FAILING in 28 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/68/ [20:02:42] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69903 [20:09:11] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952 [20:11:04] New review: Manybubbles; "Makes sense to me." [mediawiki/extensions/CirrusSearch] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69895 [20:11:40] New patchset: Kipcool; "fixed truncation" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69906 [20:11:58] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69906 [20:14:17] ^demon: brion: anomie: what's going on? [20:14:50] Stuff pointing to non-existing revs is probably caused by Reedy making some commits there and the repos then getting deleted and re-created since they needed to be empty [20:15:01] JeroenDeDauw: brion: Apparently the repos for DataTypes, ValueFormatters, ValueParsers, ValueValidators, and ValueView are broken somehow, they have no branches or revisions. And WikibaseDatabase and WikibaseQuery are pointing at nonexistent revisions, but they at least have a 'master' branch. ^demon or Reedy, can this be easily fixed or should we just remove those first five from the mediawiki/extensions project until someo [20:15:01] ne does whatever work is needed? [20:15:09] <^demon> JeroenDeDauw: No, it was because the repos were added without actually having HEAD. [20:15:20] So what is broken? [20:15:21] <^demon> Well, maybe the ones with bogus sha1s. [20:15:23] <^demon> Nothing now. [20:15:33] ^demon: they did not get deleted I hope? [20:15:34] <^demon> The repos were removed from the meta repo until the new repos have code. [20:15:51] The meta repo? [20:16:19] mediawiki/extensions [20:16:45] https://git.wikimedia.org/summary/mediawiki%2Fextensions.git [20:22:25] oh, I have only 5 outdated extensions it seems, if Brad's script worked for me [20:22:55] Change merged: Aaron Schulz; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/69800 [20:33:59] New patchset: Demon; "Fix prefix searching to respect namespaces, plus proper output" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69944 [20:34:08] New review: Demon; "This is untested." [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69944 [20:34:44] Change merged: Demon; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/69895 [20:35:22] New review: Spage; "Like Ori I'd expect to be able to return null if the conclusion of information injection is "don't b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [20:57:00] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #315: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/315/ [21:01:20] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #319: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/319/ [21:08:58] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #339: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/339/ [21:09:53] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #25: FAILURE in 54 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/25/ [21:18:05] New patchset: Umherirrender; "Improve help text for list=alllinks and alltransclusions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69950 [21:22:43] New review: Umherirrender; "This change set has cherry picked parts from I2ad0579e. Thanks to Anomie, which makes the changes th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69950 [21:25:27] New patchset: Aaron Schulz; "Removed some inappropriate global state from FSFile" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69889 [21:26:43] New patchset: Rachel99; "add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [21:29:53] binasher: https://gerrit.wikimedia.org/r/#/c/69587/ [21:30:52] hmm [21:31:07] i'll need to read function writesOrCallbacksPending() [21:32:45] New patchset: Rahul21; "Updated the id3 files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69952 [21:34:36] New patchset: Umherirrender; "Capitalize URL in api help" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69953 [21:35:14] New review: Rahul21; "Tested and works perfectly for webm, ogg, ogv and oga." [mediawiki/extensions/TimedMediaHandler] (master) C: 1; - https://gerrit.wikimedia.org/r/69952 [21:38:55] New review: Aaron Schulz; "Per Timo" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65009 [21:43:13] New review: Mattflaschen; "When Rahul was working on the WAV patch we found that the latest getID3 WAV code depends on newer ve..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69952 [21:55:46] New review: Mattflaschen; "Retested successfully." [mediawiki/extensions/TimedMediaHandler] (master) C: 2; - https://gerrit.wikimedia.org/r/68642 [21:55:54] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [22:10:50] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [22:16:02] New review: Platonides; "This looks ugly." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [22:27:29] New patchset: Aaron Schulz; "Proposed SQL schema." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/69958 [22:29:01] Lol... there go Opera bugs. [22:29:43] Thanks to Opera adopting WebKit a number of Opera bugs don't show up in Opera anymore. Like Gerrit diffs, those work if you open them up in Opera Next. [22:33:05] New patchset: Ryan Lane; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [22:41:51] New patchset: Ryan Lane; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [22:44:06] New review: Aaron Schulz; "After rebasing, maybe the code could avoid having the global have a default of "default", which seem..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67229 [22:47:03] New review: Aaron Schulz; "If this is changed then so should img_auth.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69025 [22:48:48] New review: Aaron Schulz; "Specifically, why with regards to why there is logic to restore the old global here but not there." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69025 [22:51:55] New patchset: Ryan Lane; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557 [22:53:05] New review: Daniel Kinzler; "@Krinkle: yes, that's exactly the idea. It's very hard to eliminate global scope completely, but it'..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [22:58:18] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:00:22] New review: Mattflaschen; "Aaron, not sure which of Timo's comments you're referring to. Please see Tim's reply re a "bullet-p..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [23:03:01] New patchset: Kaldari; "Remove the feedback link from the flyout - no longer needed" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69961 [23:04:24] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:04:48] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [23:05:32] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:06:22] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:06:46] thedj: ^^ FYI this patch is nearing completion [23:07:22] It's sort of huge because once I broke the array magic we were doing, I was forced to do some stuff with async that I couldn't bring myself to do without Promise/Deferred [23:09:27] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:09:33] oops [23:09:46] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:10:52] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:11:05] New review: MarkTraceur; "Please review! :)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:19:45] "Logical shard determined via consistent hashing: crc32(json_encode(array( 'wiki'=>$wiki, 'nstext' => $nstext, 'text' => $titleText ) ) ) % 864" [23:19:49] Aaron|laptop: ^^ [23:28:17] New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:35:40] Aaron|laptop: http://bugs.mysql.com/bug.php?id=67718 [23:40:21] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:42:36] Blech, that looks like an unstable way to do the hash for sharding. [23:44:52] New review: Esanders; "I agree the message should be fully customisable, different plugins may want to use the system in sl..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69855 [23:47:19] New patchset: MarkTraceur; "Massive refactor" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [23:52:09] New review: Krinkle; "Actually, I think it would hurt. The module interface should give you all the tools you need to comm..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471