[00:01:27] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69401 [00:11:10] New review: Spage; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [00:15:30] New patchset: Amire80; "Allow loading redirects in Common languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69613 [00:30:07] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [00:35:21] New review: Mwjames; "Feel free to revert but I need to moved forward here ..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/66052 [00:36:46] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [00:38:53] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [00:43:48] Change abandoned: Mwjames; "It was pushed using [1]" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66056 [00:44:46] New patchset: PleaseStand; "Change @since and @deprecated notes to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64549 [00:45:33] anomie: https://gerrit.wikimedia.org/r/#/c/60783/12/modules/ext.openstack.Instance.js,unified <— "Is it safe to assume .parent() is the dialog "wrapper" element? Or should .dialog( 'widget' ) be used instead?" [00:45:47] by that do you mean, should I use .parent().dialog( 'widget' ).css( 'position', 'fixed' )… ? [00:46:15] New patchset: PleaseStand; "Change @since and @deprecated notes to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64549 [00:52:35] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [00:55:01] Ryan_Lane: $consoleoutput.dialog( 'widget' ).css( ... ); $consoleoutput.dialog( 'open' ); [00:56:27] * Ryan_Lane tries [00:56:36] that doesn't work :) [00:57:34] I take that back [00:57:37] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [00:57:41] I was chaining poorly [00:58:36] It seems that using .parent() is depending on internal implementation details of jquery.ui.dialog, while .dialog( 'widget' ) seems to be the public interface to it. [00:58:54] ah. cool. yeah, widget seems safer, then [00:59:51] while making some of the changes recommended, I ended up redesigning the whole thing to work more like the address js, which was structured better [01:00:09] so, yeah, going to make the review a little more of a pain in the ass probably [01:03:10] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:14:09] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [01:17:40] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:20:29] New review: MarkTraceur; "Should we not also make the link red-coloured?" [mediawiki/extensions/UploadWizard] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/50760 [01:25:04] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:26:29] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:26:30] * Ryan_Lane grumbles [01:28:15] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/69284 [01:28:29] Ryan_Lane: Tough work? [01:29:00] of: window <— that global was not working with jshint and it was annoying me :) [01:29:08] Ugh. [01:29:20] There should be an option to assume a window option [01:29:26] there is [01:29:33] /*jslint browser: true*/ [01:29:35] Right [01:29:39] in the file [01:29:50] Oh, it ignored the option? [01:29:59] Or it's there *now*? [01:30:03] it's there now [01:30:05] Ah k. [01:30:06] so it's passing [01:30:13] We should have a .jshintrc or something, too [01:30:16] we do [01:30:25] Not workin', eh? [01:30:30] is that something I should just set globally? [01:30:35] Yeahhh [01:30:37] ah [01:30:44] I mean, it's only ever going to be running in the browser [01:30:49] true [01:32:34] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [01:32:58] there we go [01:37:03] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [01:40:30] New review: MarkTraceur; "Does what it says, just a few code style thingies." [mediawiki/extensions/UploadWizard] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/48357 [03:10:45] New patchset: Mwjames; "(Bug 49852) sortKey.toLowerCase()" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/69617 [03:10:46] I profess roughly zero proficiency. [03:11:38] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/69617 [03:16:54] New patchset: MarkTraceur; "Move site.pp to e default, ignore site.pp" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/64609 [03:16:55] New patchset: MarkTraceur; "WIP Add a role for testing fundraising stuff" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69618 [03:17:01] ori-l: ^^ [03:17:10] I thought we'd merged that site.pp patch though [03:48:34] marktraceur: no, i haven't yet. i looked at it again today. [03:48:39] i'll review it, sorry for the delay. [03:49:01] 's no problem :) [04:23:59] New review: MarkTraceur; "Few minor issues. Didn't test." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/65474 [04:46:29] New patchset: Hiong3-eng5; "Added a few words for translation" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69619 [05:04:14] New patchset: Mattflaschen; "Improve appearence of task toolbar on low width screens and print." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [05:07:45] New patchset: Santhosh; "Update Lohit fonts from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69620 [05:36:31] New review: KartikMistry; "LGTM!" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/69620 [05:45:17] New patchset: Spage; "Restore messages of old login and signup forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69621 [05:51:27] New review: Raimond Spekking; "Thanks for fast re-adding messages :-)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/69621 [05:54:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69621 [06:03:32] New patchset: Santhosh; "Update LinuxLiberine fonts" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69622 [06:17:20] New review: Swalling; "Tested and working on piramido." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/69282 [06:17:32] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69504 [06:20:35] New patchset: Ori.livneh; "Log whether edit was made via API and/or mobile site" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/69623 [06:59:29] New patchset: Pastakhov; "Add Mathematical Functions (version 0.4.4)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69627 [07:02:13] New patchset: Santhosh; "Map Charis SIL font to nan(Min-nan)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69628 [07:07:54] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/69627 [07:52:50] New patchset: Ori.livneh; "Support inter-page JSON references" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68941 [08:03:29] New review: Nischayn22; "Caused by jquery.ui.theme" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [08:36:57] New review: Kipcool; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69619 [08:37:36] New patchset: Nischayn22; "Add a way to make categories more require-looking" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69284 [08:49:32] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587 [08:51:51] New review: J; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/69595 [08:59:54] New patchset: Santhosh; "Fonts for nan(Min-nan) - Charis SIL and Doulos SIL" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69628 [09:01:42] New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [09:07:08] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/48357 [09:07:58] New patchset: Nischayn22; "shouldn't copy prefilled values by default." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/48357 [09:12:31] New patchset: Nischayn22; "Stop uploading if maxLimit reached" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65474 [09:16:50] New review: PleaseStand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67422 [09:26:14] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/69613 [09:43:27] New patchset: Nikerabbit; "Stricter parsing for external links in JavaScript" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69634 [09:55:28] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69635 [09:57:56] New patchset: Mattflaschen; "Fix E_STRICT issue (only variables should be passed by ref)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69595 [09:58:28] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69595 [09:59:58] New patchset: Zfilipin; "run Math test on beta and test2, not enwiki" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69599 [10:00:33] New review: Zfilipin; "Improved commit message." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69599 [10:04:47] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69620 [10:09:25] New patchset: Hashar; "move html code to their own files" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68185 [10:09:50] New review: Hashar; "renamed 'mainpage.html' to 'default.html'." [integration/docroot] (master) C: 2; - https://gerrit.wikimedia.org/r/68185 [10:10:13] Change merged: Hashar; [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68185 [10:10:57] New patchset: Mattflaschen; "Fix E_STRICT issue (only variables should be passed by ref)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69595 [10:13:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69622 [10:18:24] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [10:21:00] New patchset: Santhosh; "Fonts for nan(Min-nan) - Charis SIL and Doulos SIL" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69628 [10:21:04] New patchset: Zfilipin; "Refactoring: class UserPage renamed to VisualEditorPage" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67865 [10:23:02] New patchset: Zfilipin; "Refactoring: class UserPage renamed to VisualEditorPage" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67865 [10:23:35] New review: Zfilipin; "Added link to message that suggested this should be done." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67865 [10:23:50] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67865 [10:24:59] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [10:26:25] New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401 [10:50:02] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69628 [10:50:56] New review: QChris; "This change has meanwhile been accepted upstream:" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/69429 [10:56:55] New patchset: Mattflaschen; "Improve appearence of task toolbar on low width screens and print." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [10:59:05] New review: Mattflaschen; "Updated on piramido, adding logging." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [10:59:41] New patchset: Mattflaschen; "Improve appearence of task toolbar on low width screens and print." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [11:23:08] New patchset: Nikerabbit; "Introducing TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66540 [11:23:41] New patchset: Hiong3-eng5; "Added a few words for translation P2: corrected seach to search. Change-Id: Ie96ea91c60a377afa489272245fec792b5771e9e" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69619 [11:23:58] New patchset: Santhosh; "Show stats for groups in aggregate group if there are translations" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69639 [11:26:38] New patchset: Nikerabbit; "Introducing TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66540 [11:40:47] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/69639 [11:40:59] New patchset: VitaliyFilippov; "Show gallery and thumbnail captions in lightboxes" [mediawiki/extensions/SlimboxThumbs] (master) - https://gerrit.wikimedia.org/r/69642 [11:41:27] Change merged: VitaliyFilippov; [mediawiki/extensions/SlimboxThumbs] (master) - https://gerrit.wikimedia.org/r/69642 [11:47:13] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/69619 [11:54:33] why is qa-browsertest in github instead of wmf git [11:55:36] New patchset: Daniel Kinzler; "(bug 49264) Handle corrupt data values gracefully." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952 [11:55:44] oh it is [12:03:47] New patchset: Santhosh; "Special page TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69285 [12:40:17] New review: Hashar; "Lets land this in core and start running the parser tests. \O/" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63164 [12:43:03] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [12:49:57] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/LabeledSectionTransclusion] (master) - https://gerrit.wikimedia.org/r/63134 [13:08:21] New patchset: Andrew Bogott; "Add a couple of features:" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69646 [13:12:49] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69646 [13:25:43] hi I want help for updating pdf export [13:26:22] fonts [13:33:07] Published patchset: Daniel Kinzler; "Make SnakFactory not load Property content." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68962 [13:35:12] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69467 [13:35:40] reza: pdf or fonts [13:36:00] please see [13:36:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=32317 [13:38:41] New patchset: Hashar; "PHPUnit for extensions now uses --testsuite" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [13:43:33] nemo_bis [13:43:48] I want to update mediawiki feefonts [13:44:13] especially monospace [13:51:09] reza: you must report it to https://savannah.gnu.org/projects/freefont/ [13:51:43] they updated I want to use it in pdf export [13:51:55] in wikipedia [13:53:03] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69595 [13:53:08] please read the last comment in https://bugzilla.wikimedia.org/show_bug.cgi?id=32317 [13:53:48] now their last update supports arabic [13:56:45] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/69650 [14:00:37] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Arrays] (master) - https://gerrit.wikimedia.org/r/69651 [14:06:49] New patchset: Andrew Bogott; "Added a (super dangerous!) mode to act on every instance." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69652 [14:07:06] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/LabeledSectionTransclusion] (master) - https://gerrit.wikimedia.org/r/63134 [14:07:57] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/69653 [14:08:09] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69652 [14:08:44] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69654 [14:09:24] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [14:11:30] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Poem] (master) - https://gerrit.wikimedia.org/r/69656 [14:14:15] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/69657 [14:23:41] New review: Hashar; "Required by Jenkins job builder https://gerrit.wikimedia.org/r/#/c/62622/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [14:24:00] New review: Hashar; "Made possible with mediawiki core change https://gerrit.wikimedia.org/r/#/c/63164/" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/62622 [14:24:02] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/62622 [14:30:29] New patchset: Hashar; "MediaWiki extensions having parser tests" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69660 [14:30:42] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69660 [14:33:03] New patchset: Mboisson; "Modified getSourceLanguage() so that it returns the language code returned by getTitle()->getPageLanguage()->getCode(). This allows to properly support pages that have a source language that is different from the main wiki language." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69661 [14:36:03] New patchset: Hashar; "MediaWiki extensions having parser tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69662 [14:37:59] New review: Hashar; "JJB https://gerrit.wikimedia.org/r/#/c/69660/" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/69662 [14:37:59] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69662 [14:38:10] New review: Hashar; "Zuul https://gerrit.wikimedia.org/r/#/c/69662/" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69660 [14:39:18] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/Arrays] (master) - https://gerrit.wikimedia.org/r/69651 [14:41:33] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/69664 [14:42:32] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/ReplaceSet] (master) - https://gerrit.wikimedia.org/r/69665 [14:42:46] * MatmaRex slaps gerrit-wm around a bit with a large trout [14:43:47] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Transliterator] (master) - https://gerrit.wikimedia.org/r/69666 [14:44:43] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/ReplaceSet] (master) - https://gerrit.wikimedia.org/r/69665 [14:44:50] * Nemo_bis points MatmaRex to the always-guilty wm-bot  [14:45:30] nah, wm-bot's my pal [14:47:22] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/Transliterator] (master) - https://gerrit.wikimedia.org/r/69666 [14:48:13] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/Variables] (master) - https://gerrit.wikimedia.org/r/69667 [14:49:29] New patchset: Nischayn22; "Use statistics from the stats table not Count()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:52:28] New patchset: Nischayn22; "Use statistics from the stats table not Count()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [14:54:08] New patchset: Hashar; "triggers for mw/ext/NaturalLanguageList" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69669 [14:54:08] New patchset: Hashar; "unit tests for three extensions" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69670 [14:55:03] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69669 [14:56:27] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69670 [14:57:37] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [14:58:28] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/69653 [14:58:33] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/Poem] (master) - https://gerrit.wikimedia.org/r/69656 [14:58:38] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/69657 [14:58:43] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [15:02:14] New review: Daniel Kinzler; "@Krinkle: if your ResourceModule has to know about some other object, for, say, getting a list of th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471 [15:06:45] New patchset: Hashar; "jobs for mw/ext/NaturalLanguageList" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69671 [15:07:02] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [15:07:22] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69671 [15:07:43] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Variables] (master) - https://gerrit.wikimedia.org/r/69667 [15:07:59] New patchset: Zfilipin; "run Math test on beta and test2, not enwiki" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69599 [15:08:19] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/ReplaceSet] (master) - https://gerrit.wikimedia.org/r/69665 [15:08:45] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/69657 [15:08:51] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Poem] (master) - https://gerrit.wikimedia.org/r/69656 [15:08:56] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/69653 [15:09:02] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Arrays] (master) - https://gerrit.wikimedia.org/r/69651 [15:09:06] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/69650 [15:09:52] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69599 [15:11:14] New review: CSteipp; "After talking with the UX people yesterday, we decided to skip the login success page entirely from ..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [15:11:28] New patchset: Jeroen De Dauw; "Improvements to TravisCI build config" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69672 [15:11:47] New patchset: Nischayn22; "Use statistics from the stats table not Count()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [15:12:15] New patchset: Jeroen De Dauw; "Fix irc channel used by TravisCI" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69673 [15:16:06] New review: Mwjames; "In this case add a public method to the store in order to be able to derive the information from $th..." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/69668 [15:23:05] New patchset: CSteipp; "Revert Id47efec74e2d625bf0d3761ed53e3b6ab6f74c2c" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69674 [15:24:06] New patchset: Hashar; "stop voting when parser tests do not pass" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69675 [15:24:45] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69675 [15:25:21] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/Transliterator] (master) - https://gerrit.wikimedia.org/r/69666 [15:25:29] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69654 [15:25:34] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)..." [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [15:25:39] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/69664 [15:26:02] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)..." [mediawiki/extensions/Transliterator] (master) - https://gerrit.wikimedia.org/r/69666 [15:26:09] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69654 [15:26:28] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)...." [mediawiki/extensions/NaturalLanguageList] (master) - https://gerrit.wikimedia.org/r/69655 [15:26:41] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/69664 [15:27:58] enough spam for today, I am off now :-] [15:27:59] see you later tonight (maybe) [15:30:01] g'night :) [15:31:00] Change merged: jenkins-bot; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69672 [15:32:06] New patchset: Jeroen De Dauw; "Remove mail notifications for TravisCI" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69677 [15:32:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69677 [15:32:32] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68599 [15:33:21] New patchset: Reedy; "Narayam and WebFonts were replaced with ULS" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68647 [15:33:22] New patchset: CSteipp; "Revert "Replace image-based AutoLogin with iframes"" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69678 [15:34:02] New patchset: RAN1; "Divide communitytwitter-access-error into sub-messages" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [15:34:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69673 [15:36:42] Change abandoned: CSteipp; "missed the i18n changes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69674 [15:39:03] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68647 [15:43:04] New patchset: Jeroen De Dauw; "Fix directory creation in travis build config" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69679 [15:45:32] New patchset: CSteipp; "Revert "Replace image-based AutoLogin with iframes"" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69678 [15:45:42] Change merged: Tobias Gritschacher; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69679 [15:46:23] New review: CSteipp; "PS2 was a manual rebase to fix merge conflicts." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69678 [15:50:21] New patchset: Jeroen De Dauw; "typo fix in travisci build config" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69681 [15:51:12] Change merged: Tobias Gritschacher; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69681 [15:53:32] New patchset: Jeroen De Dauw; "Make SnakFactory not load Property content." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68962 [15:53:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68962 [15:56:10] New patchset: Jeroen De Dauw; "Update PHPUnit bootstrap after testsuite names got changed" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69683 [15:57:42] New patchset: CSteipp; "Revert "Replace image-based AutoLogin with iframes"" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69678 [16:07:47] New patchset: Darkdadaah; "New tool to analyze Wiktionary interwiki links in dumps" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/69684 [16:08:54] Yippie, build fixed! [16:08:54] Project browsertests-en.wikipedia.org-linux-chrome build #137: FIXED in 3 min 42 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/137/ [16:12:39] Yippie, build fixed! [16:12:39] Project browsertests-en.wikipedia.org-linux-firefox build #126: FIXED in 3 min 44 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/126/ [16:19:13] Yippie, build fixed! [16:19:14] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #92: FIXED in 5 min 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/92/ [16:20:08] New patchset: Aaron Schulz; "Fixed doc typo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69685 [16:22:44] New review: Nischayn22; "That's too much work, let me find a workaround" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [16:23:09] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69635 [16:23:29] New review: Cmcmahon; "merging" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69449 [16:23:30] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69449 [16:24:09] Yippie, build fixed! [16:24:10] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #104: FIXED in 4 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/104/ [16:25:22] Yippie, build fixed! [16:25:22] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #100: FIXED in 4 min 12 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/100/ [16:27:48] Yippie, build fixed! [16:27:48] Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #24: FIXED in 1 min 2 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/24/ [16:28:34] Yippie, build fixed! [16:28:35] Project MobileFrontend-en.m.wikipedia.org-linux-firefox build #16: FIXED in 46 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/16/ [16:28:37] Yippie, build fixed! [16:28:37] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #100: FIXED in 4 min 27 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/100/ [16:28:56] Nischayn22|Away: Agh, I made progress last night, and now I'm back to where I started [16:29:38] Nischayn22|Away: In any case, the next two days for me will consist of "Make the things in https://gerrit.wikimedia.org/r/#/q/owner:Nischayn22+status:open+project:mediawiki/extensions/UploadWizard,n,z have full CR columns" [16:30:04] If you have any additional directions for me to take, I'm listening [16:30:07] New patchset: Nischayn22; "Use statistics from the stats table not Count()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [16:30:13] Oh, huh, he's here [16:36:00] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69678 [16:37:05] marktraceur: Hi :) [16:38:05] Halloooo [16:40:06] Okay, that sounded Indian [16:41:12] marktraceur: I think you are doing fine in progress, unless you want to also review Moodbar and PageTriage [16:43:15] hah [16:43:36] Nischayn22: Are they JS changes? I might do, if I run out of UW review to do (unlikely) [16:44:07] marktraceur: Some of them are JS changes [16:44:49] Add me? [16:45:03] okay [16:46:07] marktraceur: Apparently there's only one JS+CSS [16:46:50] Then add me there :) [16:47:11] done [16:54:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69685 [16:59:28] New patchset: Jeroen De Dauw; "Hack around my ignorance of bash" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69688 [16:59:46] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69683 [17:02:58] RFP meeting in #wikimedia-office now [17:03:09] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69688 [17:10:19] New patchset: Zfilipin; "WIP $session_id has to be initialized when @browser points to a browser" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69690 [17:12:13] New review: EBernhardson; "Couple suggestions to reduce code complexity" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68817 [17:19:01] New patchset: Spage; "New Campaigns extension" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/69691 [17:29:27] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/69691 [17:30:01] New patchset: Reedy; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69692 [17:30:06] csteipp_afk: ^ [17:30:42] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69692 [17:31:56] New patchset: Reedy; "Add missing Campaigns extension" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69693 [17:32:13] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69693 [17:35:39] New patchset: Spage; "Add Campaigns extension" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69694 [17:36:05] spagewmf: I beat you to it ;) [17:36:30] foiled again! [17:39:41] anomie: what was the use for $wgCentralAuthSilentLogin beyond feature flagging on $wgCentralAuthLoginWiki ? [17:41:22] Aaron|home: Keeping the "login success" screen with the images on it, because they want to roll that out more slowly. [17:42:11] http://test.wikipedia.org/wiki/Special:UserLogin/signup?campaign=ReedyLove working, thanks! [17:43:50] spagewmf: I was hoping for a picture of Reedy on that link :s [17:51:12] Reedy: Thanks! [17:53:07] bawoff, FYI the old CustomUserSignup extension let people do crazy signup customization, e.g. https://en.wikipedia.org/wiki/MediaWiki:Customusertemplate-ACP2-Welcomecreation [17:53:48] New patchset: Ori.livneh; "Click anywhere outside code samples to close code samples" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69700 [17:53:49] You could simulate it with (untested) in your custom.js add a check if ( $.cookie( wgCookiePrefix + '-campaign' === 'ReedyLove' ) ) { mw.notify( 'Reedy thanks you for joining' ); } [17:57:05] spagewmf: All I really want is an image of Reedy surounded by a giant red heart. I feel the url promised me this [17:57:16] patches welcome :) [17:57:43] New review: TheDJ; "you have a problem of multiple dependencies in multiple resourceloaders here. I doubt you can ever m..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [17:57:45] lol [18:04:30] Jun 20 18:04:15 10.64.16.171 apache2[8884]: PHP Fatal error: Call to a member function getCode() on a non-object in /usr/local/apache/common-local/php-1.22wmf8/includes/GlobalFunctions.php on line 1288 [18:05:47] ProofreadPage seems to be broken on job runners [18:06:40] New review: Hashar; "Patch has been merged upstream. Still have to tweak the destination path." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [18:07:04] Reedy: That particular line is $wgLang->getCode() .... seems like a core bug there [18:07:18] Yeah, only proofreadpage causing it though [18:08:23] New patchset: Mwjames; "Use statistics from the stats table not Count() " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [18:08:36] Moved to core l10n [18:11:00] New review: Mwjames; "This is why we are writing tests." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69668 [18:18:33] Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [18:22:55] mmm bad Reedy but thanks for the review anyway [18:23:21] New review: MarkTraceur; "All right, let's merge this puppy." [mediawiki/extensions/UploadWizard] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65474 [18:23:22] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65474 [18:23:56] New review: Krinkle; "Indeed. Strange." [qa/browsertests] (refs/meta/config) - https://gerrit.wikimedia.org/r/69323 [18:24:09] ^demon: Any ideas why https://gerrit.wikimedia.org/r/#/c/69323/ might not be working ? [18:26:40] Nikerabbit: https://bugzilla.wikimedia.org/show_bug.cgi?id=49897 [18:26:46] https://test2.wikipedia.org/ [18:27:01] Means $wgLang is null [18:27:24] <^demon> Krinkle: Project Owners always have full review. This is set at All-Projects level. [18:27:49] <^demon> If you don't want them to have it either, you'd have to set it explicitly for Project Owners on that repo (or parent) with DENY [18:31:10] k, no problem for now. [18:32:21] I don't want to go out of my wait to enforce it. We should be able to expect proper behaviour from a product owner, especially one in QA. I'll just tell them directly. The button being there may be confusing (and is, because I know they know they shouldn't use it unless needed) but oh well.... [18:33:34] chrismcmahon: zeljkof: So yeah, I can't disable the buttons for you two because you both own the repo so you see the buttons still (e.g. I no longer see them now). But try to remember not to use them unless you explicitly intend to discard, ignore and override the jenkins-bot. [18:33:59] Krinkle: OK [18:34:19] Krinkle: ok [18:34:59] several other repo's also have them disabled now. eventually it'll probably happen globally, but beginning at smaller repos for now. [18:37:40] Reedy: left a comment [18:38:11] Reedy: perhaps a workaround would be to use $wgLanguageCode instead, or setup wgContLang earlier, but I'd like code not to call wfMessage that early [18:39:29] New review: MarkTraceur; "LGTM, let's see if Jenkins will merge." [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/48357 [18:39:33] I guess that means it is a Proofread bug.. [18:39:37] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/48357 [18:42:44] New patchset: Hashar; "doc: sync with doxygen 1.7.6.1" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69708 [18:42:44] New patchset: Hashar; "doc: raise doxygen lookup cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69709 [18:42:44] New patchset: Hashar; "doc: speed up dot generation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69710 [18:44:00] Reedy: Doxygen tweaks for you to look at :) ^^^ [18:44:06] ohnoes! [18:44:24] they are trivial ones :-] [18:44:34] the commit message should be enough hopefully [18:44:40] there is no hurry :] [18:44:58] New review: Spage; "WFM on local wiki with regular edits and with forcing mobile mode+beta+experimental to make an edit...." [mediawiki/extensions/CoreEvents] (master) C: 2; - https://gerrit.wikimedia.org/r/69623 [18:45:12] New review: MarkTraceur; "Sure sure." [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/69284 [18:45:20] New review: Ori.livneh; "No Jenkins on this repo yet, so manually verifying" [mediawiki/extensions/CoreEvents] (master); V: 2 - https://gerrit.wikimedia.org/r/69623 [18:45:20] Change merged: Ori.livneh; [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/69623 [18:46:47] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69284 [18:46:48] New review: EBernhardson; "As you mentioned we can adjust the apache config file for devwiki, we can also create a file in /etc..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [18:49:23] New review: Reedy; "This would seem to have possibly caused bug 49897" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/37648 [18:49:50] Change merged: Reedy; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69708 [18:50:52] ori-l: If CoreEvents is going to be deployed, please get tests on it very soon :) [18:51:08] (aside from unit tests, php linting would be a start) [18:51:16] I can do it now if you like [18:51:48] Krinkle: that would be awesome [18:52:06] I'm just about to step out but will be back online in a bit. [18:52:13] k [18:55:56] New patchset: Krinkle; "Add CoreEvents to mwext list" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69711 [18:57:37] :-) [18:59:18] New patchset: EBernhardson; "Sample debugging configuration for MediaWiki" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [19:02:08] Change restored: Hashar; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [19:02:12] New patchset: Hashar; "validate jenkins job" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [19:05:34] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69753 [19:05:48] Change merged: Raimond Spekking; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69753 [19:06:29] New review: Swalling; "Re-tested on piramido. Logging appears to be broken due a previous change, and the UI modifications ..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [19:14:05] New patchset: Reedy; "doc: raise doxygen lookup cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69709 [19:15:08] New patchset: Tpt; "(bug 49897) Fix a failure in Wiki with message caching" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69754 [19:20:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69709 [19:23:48] New patchset: Reedy; "doc: speed up dot generation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69710 [19:25:28] New patchset: Anomie; "Rework CentralAuth login flow" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [19:25:45] New patchset: Anomie; "Remove Special:AutoLogin" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64253 [19:27:22] New patchset: Andrew Bogott; "Don't delete class at index [false] if we don't find a matching class." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69758 [19:27:44] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69758 [19:28:04] New patchset: Anomie; "Rework CentralAuth login flow" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [19:28:21] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69710 [19:28:22] New patchset: Anomie; "Remove Special:AutoLogin" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64253 [19:32:39] New patchset: Rachel99; "add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128 [19:35:21] New patchset: Umherirrender; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [19:42:00] New patchset: Parent5446; "Changed FOR UPDATE handling in Postgresql" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69767 [19:42:46] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69768 [19:43:40] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69769 [19:44:05] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69768 [19:44:17] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69769 [19:48:26] New review: Anomie; "Comments:" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [19:49:03] New patchset: SuchABot; "Do not dismiss progress dialog when user taps outside in LoginActivity" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69770 [19:51:05] New review: Brion VIBBER; "hehehe" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69770 [19:51:05] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69770 [19:51:32] New patchset: Anomie; "Return errors from WatchAction" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [19:58:07] New patchset: Ori.livneh; "Update CoreEvents to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69772 [20:00:36] New patchset: Ori.livneh; "Update CoreEvents to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69773 [20:02:00] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69711 [20:05:10] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69772 [20:06:34] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69773 [20:09:05] ^demon: Reedy: any idea how mediawiki/extensions.git get updated ? VisualEditor extension last update is from May 28th :( [20:09:16] <^demon> It's supposed to be automatic. [20:09:18] It should be done automatically... [20:09:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=49846 [20:09:37] git rev-parse HEAD origin/master [20:09:38] 5add8cc4c0ea5b305525c30d8af5261406e5d355 [20:09:39] ed1c06ee6b36851ba1f6e3a68d0584da4c20be46 [20:09:43] i.e. it does not :( [20:09:48] hang on [20:10:00] if we could write some doc somewhere that would be nice :)) [20:11:14] <^demon> http://p.defau.lt/?HQvcivAQTlx6_asxWB9jMg [20:11:29] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [20:11:30] New patchset: Reedy; "Update VE to master" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/69775 [20:11:51] help it along its way [20:11:57] <^demon> Bah, it's misconfigured. [20:12:02] Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/69775 [20:12:09] New review: Spage; "Fixes the problem." [mediawiki/extensions/EventLogging] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/69700 [20:12:26] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69700 [20:12:40] New patchset: Mattflaschen; "Fix openTask cookie removal by using same options." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69776 [20:12:55] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [20:13:55] ^demon: no idea what is wrong but I trust you :-) [20:14:06] <^demon> Fixed. [20:14:20] would it make sense to run a daily query that would report any mis configuration ? [20:14:20] New patchset: Ori.livneh; "Update EventLogging to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69777 [20:14:39] beta rely on mediawiki/extensions.git to deploy master branches [20:15:01] <^demon> I just checked, there's none else broken like that. [20:15:10] <^demon> Can't for the life of me figure out why, but there you go. [20:15:19] New patchset: Ori.livneh; "Update EventLogging to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69778 [20:15:48] ^demon: great. Assigned you https://bugzilla.wikimedia.org/show_bug.cgi?id=49846 go ahead and mark it resolved :) [20:16:03] i will fill a low priority bug to have that monitored [20:17:36] New patchset: Reedy; "Add core/core.zip to .gitignore" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/69779 [20:17:59] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69777 [20:18:13] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/EventLogging] (refs/meta/config) - https://gerrit.wikimedia.org/r/69780 [20:18:14] New patchset: Cmcmahon; "update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499 [20:18:24] Change merged: Krinkle; [mediawiki/extensions/EventLogging] (refs/meta/config) - https://gerrit.wikimedia.org/r/69780 [20:18:46] New review: Krinkle; "Don't use Verified." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69700 [20:18:49] Wikibase, Parsoid and GuidedTour are all dirty due to their own submodules and stuff [20:19:05] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [20:19:37] New patchset: Mattflaschen; "Fix EventLogging (variable was read before initialization)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:20:51] New patchset: Cmcmahon; "update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499 [20:21:08] Change merged: Reedy; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69754 [20:21:46] New review: Cmcmahon; "will need this for tomorrow" [qa/browsertests] (master) C: 2; - https://gerrit.wikimedia.org/r/69499 [20:21:57] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69778 [20:22:16] New patchset: Reedy; "Update ProofreadPage to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69782 [20:22:32] New review: Mattflaschen; "The GuidedTour logging is fixed by https://gerrit.wikimedia.org/r/#/c/69781/ . However, the logging..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [20:22:37] New review: Cmcmahon; "will need this for tomorrow" [qa/browsertests] (master); V: 2 - https://gerrit.wikimedia.org/r/69499 [20:22:38] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499 [20:22:47] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69782 [20:23:48] New patchset: Krinkle; "Enable mwext-CoreEvents jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69783 [20:24:43] New review: Ori.livneh; "Thanks very much for this!" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69783 [20:25:42] New review: Ori.livneh; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:26:02] New review: Krinkle; "(cancelling jenkins for this change since there is a big queue and you already bypassed it)" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69782 [20:26:50] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69783 [20:26:58] New review: Ori.livneh; "Yep." [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/69776 [20:28:33] New patchset: Ori.livneh; "Improve appearence of task toolbar on low width screens and print." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [20:29:12] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69776 [20:29:34] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [20:29:46] New patchset: Krinkle; "Fix EventLogging variable read before initialization" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:30:14] New review: Ori.livneh; "FOUND" [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/69781 [20:31:16] New review: Krinkle; "one more time" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:31:27] New patchset: Krinkle; "Fix EventLogging (variable was read before initialization)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:32:32] New patchset: Ori.livneh; "Update GettingStarted & GuidedTour to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69784 [20:33:13] Krinkle: should I override or wait? [20:33:30] ori-l: Can you wait 3 more minutes? I made a type and need to re-apply [20:33:32] typo* [20:33:38] sure, no problem. [20:34:02] New patchset: Krinkle; "Create mwext-GuidedTour-qunit job" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69785 [20:34:31] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69785 [20:35:33] ok so hmm [20:35:35] I hate our code [20:35:39] (sometime) [20:36:12] New patchset: Krinkle; "Create mwext-GuidedTour-qunit job" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69786 [20:36:29] Yeah, I have to push to test. We need a test for jjb and everything [20:36:48] hashar: I pushed a zuul change referring to a job that didn't exist yet, I have to manually push it from my laptop to production [20:36:53] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69786 [20:37:53] New review: Krinkle; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:37:54] Krinkle: a zuul config change or zuul itself ? [20:37:59] zuul config [20:38:04] I listed GuidedTours-qunit [20:38:06] and that job existed [20:38:11] but it wasn't pushed to jenkins api yet [20:38:16] our Zuul installation is a fork in the wmf repository [20:38:20] it existed in jjb but not in jenkins [20:38:33] I know that [20:38:36] it has a nasty hack to avoid spamming Gerrit. Need to get upstreamed :) [20:38:37] ok [20:38:43] zuul config [20:39:02] ori-l: Okay, override for now. [20:39:12] I really need to have JJB configuration to be pushed automatically [20:39:13] ori-l: Looks like either you have a failing qunit test or the thign is broken [20:39:19] but that needs a debian package as a requisite [20:39:27] ^ superm401 [20:39:33] could it be a qunit failure? [20:40:06] see https://integration.wikimedia.org/ci/job/mwext-GuidedTour-qunit/1/console [20:40:26] if it is, it's not related to this change, so I'm overriding anyway. [20:40:27] Looking [20:40:37] ori-l: override for now [20:40:37] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69781 [20:41:33] ori-l: Can you verify running Special:JavaScriptTest/qunit on your localhost with latest master of core and GuidedTours does not result in a qunit or js error? [20:41:43] looks like it is failing very early on, qunit doesn't get a chance to finish [20:42:10] New review: MarkTraceur; "Synchronous HTTP requests are eeeeevil." [mediawiki/extensions/UploadWizard] (master) C: -2; - https://gerrit.wikimedia.org/r/50755 [20:42:46] New patchset: Ori.livneh; "Update GettingStarted & GuidedTour to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69784 [20:42:49] Krinkle, so you made the QUnit voting? [20:43:11] I know I requested it [20:43:33] superm401: qunit has always been voting, it has no non-voting mode. If your tests are failing that's quite bad :-) [20:43:39] but this seems like an infrastructure issue [20:43:52] New patchset: Ori.livneh; "Update GettingStarted & GuidedTour to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69787 [20:43:56] Krinkle, you're right, I meant adding it to Jenkins. [20:44:22] yes, I added the qunit build step macro to the GuidedTour job a few minutes ago [20:44:58] New patchset: MarkTraceur; "Make Special:UploadCampaigns visible to everyone" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/54702 [20:45:03] https://gerrit.wikimedia.org/r/#/c/68567/6/layout.yaml [20:45:24] (the default is merge+lint) [20:45:37] There are a couple failing tests, which I'll fix after the deploy. [20:45:48] Obviously, that shouldn't result in LOST, though. [20:45:58] superm401: It doesn't say LOST anymore [20:46:14] it said lost because of a race condition. I enabled it in the flow before I defined it. that's fixed now [20:46:18] It now just "fails" [20:46:37] i'm all out of love -- i'm so lost without you [20:46:38] but it doesn't fail in qunit assertion, it fails in javascript early on. probably a fatal uncaught js exception [20:46:42] i know you were right, believing for so longggggg [20:47:01] https://integration.wikimedia.org/ci/job/mwext-GuidedTour-qunit/2/console [20:47:05] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69784 [20:49:37] Krinkle, it's a regular test failure locally [20:50:06] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69787 [21:02:19] superm401: Found it [21:02:22] superm401: ori-l: [21:02:23] Fatal error: Class 'ResourceLoaderSchemaModule' not found in /srv/ssd/jenkins/workspace/mwext-GuidedTour-qunit/includes/resourceloader/ResourceLoader.php on line 401 C [21:02:29] startup module is giving HTTP 500 [21:02:34] https://doc.wikimedia.org/krinkle-mwext-GuidedTour-qunit/load.php?debug=true&modules=startup&only=scripts [21:05:20] Krinkle: huh. how do you declare another extension as a requirement for testing? [21:05:38] in zuul-config dependencies: - ... [21:05:48] or in jenkins-job-builder-config [21:05:52] the latter [21:06:21] I'll submit a patch. [21:07:18] there should be a few examples [21:07:24] Thanks [21:12:54] New review: MarkTraceur; "Good stuff, thanks Nischay!" [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/54702 [21:13:02] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/54702 [21:13:49] Krinkle: should I declare the dependency on the '{name}-{ext-name}-testextensions-{mwbranch}' job, the '{name}-{ext-name}-qunit' job, or both? [21:14:26] Both [21:14:43] Though the former is unused afaik [21:14:48] at least not yet for GuidedTour [21:15:21] New patchset: Ori.livneh; "Declare GuidedTour's dependency on EventLogging" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69792 [21:16:09] New review: Cmcmahon; "This seems to be causing a performance problem in beta labs where the collapsible tabs take signific..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:22:59] New review: Krinkle; "@Chris: If I read that link correctly, it is trying to locate the "Print/export" link which is unaff..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:25:02] New review: Hoo man; "I'm getting "Exception thrown by skins.vector.js: $(...).bind(...).bind(...).collapsibleTabs is not ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:27:32] New patchset: Krinkle; "qunit: Enable PHP debug, fix default config, dump load.php" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69794 [21:27:52] New review: Krinkle; "Syncing live code back to Gerrit." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/69794 [21:27:52] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69794 [21:28:26] New review: Krinkle; "Make sure you have the lastest version of the Vector extension installed. master + master." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:29:12] New review: Hoo man; "I *don't* have the Vector extension installed at all!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524 [21:29:18] New patchset: Krinkle; "Declare GuidedTour's dependency on EventLogging" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69792 [21:31:02] ori-l: Here we go: https://integration.wikimedia.org/ci/job/mwext-GuidedTour-qunit/4/console [21:31:26] no fatals, just 3 regular qunit failures. According to superm401 that's expected for now. [21:31:39] New review: Krinkle; "Confirmed to work: https://integration.wikimedia.org/ci/job/mwext-GuidedTour-qunit/4/console" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/69792 [21:31:40] Change merged: Krinkle; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69792 [21:32:36] Krinkle: that's excellent; thanks again for looking into that. [21:36:38] New review: Darkdadaah; "Basic lib needed for dumps management." [wiktionary/anagrimes] (master); V: -1 - https://gerrit.wikimedia.org/r/69684 [21:37:21] Change abandoned: Darkdadaah; "Script needs the basic.pm lib." [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/69684 [21:40:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [21:45:10] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [21:48:10] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [21:51:34] New patchset: Mattflaschen; "Fix type of 'step' for logging." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69797 [21:54:24] New review: Ori.livneh; "By-passing Jenkins for hotfix." [mediawiki/extensions/GuidedTour] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69797 [21:54:33] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69797 [21:56:21] New patchset: Ori.livneh; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69798 [21:57:37] New patchset: Ori.livneh; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69799 [21:58:12] New patchset: Hoo man; "Make FRInclusionCache::getRevIncludes more robust" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/69800 [21:59:52] Change merged: Ori.livneh; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69798 [22:03:59] New patchset: Rtdwivedi; "Separated data fetching from manipulation for page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/69802 [22:04:10] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf8) - https://gerrit.wikimedia.org/r/69799 [22:05:50] E3 deployment ran 5 minutes over but is done now. [22:19:27] New patchset: Matmarex; "displaytitle: Pass-by-reference fix for PHP 5.4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69807 [22:19:47] New review: Matmarex; "Submitted a followup per Mormegil: https://gerrit.wikimedia.org/r/69807" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [22:28:35] Change merged: Parent5446; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69807 [22:29:32] New review: MarkTraceur; "I'm going to hold off on merging this until at least tomorrow...this solution seems really inelegant..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/54127 [22:29:33] Krinkle, anyone: seems 1.22wmf7 introduced some module inflation. Browsing enwiki anonymously there are 550 known RL modules, 101 in a 'ready' state. [22:30:11] IIRC RL modules was around 150 before. [22:30:30] spagewmf: Check mw.loader.getModuleNames() [22:31:20] spagewmf: I see almost a 100 from wikibase alone [22:31:31] Krinkle I am. jquery.valueview.*, wikibase.*, and a few mobile.device.* are new to me. yup [22:31:32] For some reason it is registering all modules for wikidata-wiki [22:33:33] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [22:33:45] New patchset: Aaron Schulz; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [22:33:55] and all the mobile styles, plus 'ep'. Plus echo schemas (do anonymous users get Echo)? [22:34:34] spagewmf: Well, the startup registry is and should be agnostic to that [22:34:42] this isn't loading, just the registry [22:36:01] Nischayn22|Away: Two of your patches are blocked because you didn't use async-y code, would you like some help with that tomorrow? [22:36:22] spagewmf: tolowercase /wikibase|datavalues/ matches 53 modules [22:36:32] >> mw.loader.getModuleNames().filter(function (a) { return a.toLowerCase().indexOf('wikibase') !== -1 || a.toLowerCase().indexOf('datavalue') !== -1 }).length [22:36:32] Krinkle: ReferenceError: mw is not defined [22:36:40] YuviPanda: 'settings' takes either a hash, an array, or a string literal. hash won't work here because you need to extend an array. but you can do settings => [ '$wgFoo = arbitrary_php_code( 'bar' )' ] [22:36:42] Yes ecmabot-wm, thank you [22:37:00] YuviPanda: minus the lack of escaping the single quotes [22:37:19] YuviPanda: or you could do settings => template("my_php_template_with_requisite_configs.php") [22:37:29] ori-l: yeah, but that looks yuckish. Could be easier to make settings be able to hash of hashes, and then expand them ou [22:37:30] t [22:37:31] since puppet's template() is just a function that takes a string [22:37:47] the current extension generator template can be modified [22:37:48] er, returns [22:37:49] to support that [22:37:51] > mw.loader.getModuleNames().filter(function (a) { return !!a.toLowerCase().match(/(wikibase|datavalue|valueview)/); }).length [22:37:52] 72 [22:38:13] so settings can also set assocarrays / arrays than just variables [22:38:22] I suppose that should have been the scope of that bug [22:38:32] YuviPanda: you think so? I had my doubts about allowing hashes at all. it's syntactic sugar that looks really nifty in simple cases but it doesn't work for more complicated ones [22:38:51] how's your ruby? [22:39:02] mw.loader.getModuleNames().filter(function (a) { return !!a.toLowerCase().match(/(wikibase|datavalue|datatype|valueparser|valueview)/); }).length [22:39:04] > 80 [22:39:15] ori-l: currently non-existent, but that shouldn't be that much of a problem :) [22:39:27] ori-l: if you want to, do assign it to me, and I"ll try to fix that over the weekend [22:39:49] YuviPanda: the code is here: https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/mediawiki/templates/extension-loader.php.erb [22:39:56] ori-l: yeah, I already looked a it [22:39:57] *at it [22:40:26] in the template, because if you're going to do ridiculous over-involved magic you might as do it in a template so that it's not just complicated, it's complicated and *hidden* [22:40:28] Krinkle yes. But among 'ready' (actually loaded) it's not so bad. Maybe some could be smarter. [22:40:28] :P [22:40:43] ori-l: if we support hashes inside hashes, then it can essentially recurse down to any level of hashes / arrays [22:40:53] YuviPanda: i was tempted to add '# sorry, i couldn't help it' [22:40:59] spagewmf: well, 80 modules is pretty crazy imho. Separating classes into files is fine, but loading each in a separate module is nonsense. [22:41:12] VisualEditor has 100s of classes but only like 5-10 modules at most [22:41:13] YuviPanda: yeah, if you come up with a good implementation i'd be for it. [22:41:53] ori-l: hmm, okay. I'm talking all this assuming that the implementation is possible in a sane way, because I am still a super-puppet-noob. [22:41:58] and I suppose a lot of the mobile modules shouldn't register on target=desktop ? [22:42:04] ori-l: i'll look at it once I'm a bit farther along :) [22:42:42] maybe erb is shittier than I think. who knows :) [22:43:07] YuviPanda: it's just ruby [22:43:17] yeah, that doesn't sound that bad [22:43:22] Krinkle only mobile.desktop is in state 'ready' on desktop, and I don't see any of the wikibase/values stuff in 'ready' [22:43:39] except wikibase.client.init [22:44:04] spagewmf: Indeed. The non-client modules should not be registered on client wikis [22:44:20] and visa versa the module to edit data on wikidata.org should be for the wikidata wiki only. [22:44:25] It's weird that those are all loaded. [22:44:29] ori-l: hmm, can I create files inside settings/* myself? [22:44:34] ori-l: for loading code in development? [22:44:35] I thoguht those woudl be in wikidata repo, not in wikidata client or wikibase [22:44:44] YuviPanda: yeah, see the README [22:44:51] hmmm, readme didn't say too much [22:45:01] oh, README of settings/ [22:45:08] yeah [22:45:46] it's the rc.d approach [22:45:46] ori-l: yeah, makes sense. The question was wether I should use puppet for stuff that I'm developing right now (UploadWizard in this case), so I guess not [22:45:51] hehe [22:45:52] it's up to you [22:46:17] i do it even for simple stuff since i find it easier to just add @mediawiki::extension { 'myext': } then to do a git clone and create the setup file by hand [22:46:32] hmm, ok [22:46:59] but there's some ugliness there that needs to be sorted out. my biggest issue is that 'vagrant destroy' doesn't remove old setting files from settings/* and so mediawiki [22:47:21] ..can fail to load if you destroy the machine and recreate it , but forget to clean up settings/ [22:48:03] ah, hmm. but that should be easy enough to catch [22:48:58] hmm, for some reason I just typed brion provision >_< [22:49:03] instead of vagrant provision [22:49:37] puppet seems slo tho [22:51:16] Change restored: Demon; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [22:51:24] New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515 [22:51:25] New patchset: Demon; "Docs and drop silly m prefix from private variables" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69809 [22:54:09] ori-l: virtualbox's shared stuff can't reach across softlinks? [22:54:26] New patchset: Demon; "Docs and drop silly m prefix from private variables" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69809 [22:54:36] symlinking into vagrant/mediawiki/extensions/UploadWizard from my local works fine on the host [22:54:39] YuviPanda: I don't think so, no [22:54:52] hmm, sigh. [22:55:02] i'll need to move it and reverse symlink, I guess [22:55:14] possibly. I'm too exhausted at the moment to investigate, sorry :/ [22:56:37] ori-l: you have been around way too much these days [22:56:43] * YuviPanda suggests some decompression time [22:57:23] * YuviPanda heads to sleep [22:58:48] YuviPanda: yes, not a bad idea. have a good night [23:06:58] If I wanted to log an error that we'd notice and take action to stop, what should I do? It isn't fatal but it is pretty bad. [23:07:26] In this case it is a user trying to perform a search but the search system being down or otherwise choking. [23:10:21] manybubbles: i'm pretty new here, but i would probably check with -ops regarding that. Most likely you would log in a particular way and their system would pick it up and repeat the error to irc or something else people regularly watch [23:12:37] <^demon> manybubbles: Would wfDebugLog() not suffice? [23:16:51] manybubbles: if it's not private for some reason, Bugzilla should do for that sort of thing [23:17:37] manybubbles: Product: Wikimedia, Component: lucene-search-2 maybe? [23:19:51] chrismcmahon: file a bug in bugzilla from production when the live code fails to connect to SolrCloud? :-) [23:20:19] <^demon> No, that's not what we'd want to do. [23:20:21] ebernhardson: we use Bugzilla for EVERYTHING :) [23:20:23] <^demon> Nor is it lsearchd :) [23:20:24] Yippie, build fixed! [23:20:25] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #63: FIXED in 8 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/63/ [23:21:09] * chrismcmahon lacks context I think [23:21:24] chrismcmahon: no worries, it was brand new announced to one of the lists in the last week [23:21:32] ^demon: This kind of falls on monitoring too.... if we get more than X of these (or more than X% or something) this should page people [23:22:01] <^demon> Well having some sort of icinga alerts monitoring the logs could work. [23:22:19] chrismcmahon: http://www.mediawiki.org/wiki/Requests_for_comment/CirrusSearch is the project [23:23:09] ebernhardson: oic. I did read that, did not realize manybubbles comment was in re, thanks [23:24:21] sorry for the confusion. [23:25:14] chrismcmahon, I think he means automatically, i.e. this is a symptom of, e.g. possible downtime. [23:25:15] ^demon: I see wfLogWarning which perports to log warnings *in production* as compared to *wfWarn* which logs warnings in development. I'm kind of confused. [23:26:13] <^demon> That should end up somewhere...can't remember which log though. [23:26:19] <^demon> fatal.log maybe? [23:33:38] circus search? sounds promising, I'm entertained already :) [23:38:27] New review: Alex Monk; "Caused bug 49918" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/34032 [23:46:44] ^demon: are you planning on throwing away the results of self::updateText( $this->text ) ? [23:47:07] New patchset: Krinkle; "mediawiki.js: Clean up and improve documentation coverage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648 [23:47:23] <^demon> Aaron|home: I screwed up on the second patch. I'm reworking it now. [23:53:49] New patchset: Mattflaschen; "Fix cookie tests:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69817 [23:54:08] New patchset: Ori.livneh; "Add a coroutine-driven demuxer" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/69818 [23:57:49] New patchset: Ori.livneh; "Add a coroutine-driven demuxer" [mediawiki/tools/fluoride] (master) - https://gerrit.wikimedia.org/r/69818 [23:59:32] New patchset: Mattflaschen; "Fix cookie tests" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/69817