[00:00:04] <gerrit-wm>	 New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/WikibaseDataModel] (master) C: -1;  - https://gerrit.wikimedia.org/r/68952
[00:03:33] <AzaToth>	 James_F: true
[00:26:20] <Aaron|home>	 binasher: you can look at https://gerrit.wikimedia.org/r/#/c/66227/2 then :)
[00:37:05] <gerrit-wm>	 New patchset: Aaron Schulz; "Made ProfileSection support chaining for nested profiling." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745
[00:40:54] <gerrit-wm>	 Change abandoned: Aaron Schulz; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745
[00:42:31] <gerrit-wm>	 New patchset: Aaron Schulz; "Switched FileBackendStore to use ProfileSection when possible." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69441
[00:43:55] <gerrit-wm>	 New patchset: Aaron Schulz; "Switched FileBackendStore to use ProfileSection when possible." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69441
[00:47:09] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-chrome build #133: FAILURE in 3 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/133/
[01:09:45] <gerrit-wm>	 New patchset: RAN1; "Divide communitytwitter-access-error into sub-messages" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275
[01:29:17] <Krenair>	 RobH or notpeter: Hi, are either of you two around?
[01:38:31] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69446
[01:39:04] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69447
[01:39:18] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69446
[01:39:28] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69447
[01:51:17] <gerrit-wm>	 New patchset: Krinkle; "Copied collapsibleTabs module from Vector ext. to Vector skin" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524
[02:00:47] <gerrit-wm>	 New patchset: Krinkle; "Delete collapsibleTabs module (moved to core)" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/56711
[02:01:25] <gerrit-wm>	 New review: Krinkle; "Here we go!" [mediawiki/extensions/Vector] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/56711
[02:01:30] <gerrit-wm>	 Change merged: Krinkle; [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/56711
[02:03:53] <Krinkle>	 !b 46513
[02:03:53] <wm-bot>	 https://bugzilla.wikimedia.org/46513
[02:09:10] <gerrit-wm>	 New patchset: Krinkle; "Add collapsibleTabs module from Vector extension" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524
[02:09:37] <gerrit-wm>	 New patchset: Krinkle; "Vector: Add the collapsibleTabs script from the Vector extension" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524
[02:13:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55524
[02:16:22] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: various cleanups to JobQueueFederated." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69448
[02:17:13] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617
[02:20:46] <gerrit-wm>	 Change abandoned: Aaron Schulz; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60455
[02:24:48] <gerrit-wm>	 New patchset: Amire80; "Test that language names appear in the dropdown" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69449
[02:36:44] <gerrit-wm>	 New review: Krinkle; "Embedding the PNG and the SVG is suboptimal but done in other places. Embedding the same SVG data tw..." [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/65400
[02:50:36] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1;  - https://gerrit.wikimedia.org/r/64102
[03:04:09] <gerrit-wm>	 New review: Physikerwelt; "This method does not work due to caching issues. i.e. for non logged in users the code is not even b..." [mediawiki/extensions/Math] (master) C: -1;  - https://gerrit.wikimedia.org/r/69298
[03:07:33] <gerrit-wm>	 New review: Brian Wolff; "Typically such browser specific blacklisting of js is done on the javascript side." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[03:09:28] <gerrit-wm>	 New review: Mattflaschen; "I'm going to do a separate patch for jsonfm.  But I'm not a fan of the way IndexUri disappears and A..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617
[03:09:41] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: cleaned up JobQueue exception handling." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69451
[03:09:57] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: cleaned up JobQueue exception handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69451
[03:21:24] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[03:26:11] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[03:27:08] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[03:28:29] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[03:39:40] <gerrit-wm>	 New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/EventLogging] (master) C: -1;  - https://gerrit.wikimedia.org/r/69452
[03:42:01] <gerrit-wm>	 New patchset: Physikerwelt; "Fix: Browser dependent rendering decission" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69453
[03:43:27] <gerrit-wm>	 Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69453
[03:48:59] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[04:19:52] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[04:20:28] <gerrit-wm>	 New patchset: Mattflaschen; "Support jsonfm (pretty JSON formatted with HTML)." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[04:35:16] <gerrit-wm>	 New patchset: Yurik; "PHPDoc cleanup of includes/ dir" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69454
[04:40:57] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69452
[04:49:47] <gerrit-wm>	 New review: Mattflaschen; "See also last patch set." [mediawiki/extensions/Math] (master) C: -1;  - https://gerrit.wikimedia.org/r/69298
[04:58:48] <gerrit-wm>	 New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885
[05:08:30] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282
[05:12:03] <gerrit-wm>	 New patchset: Santhosh; "Fix Cog hover behavior for Opera" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69456
[06:41:43] <gerrit-wm>	 New review: Physikerwelt; "yes... however I have no Idea about javascript in mw" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[06:44:46] <gerrit-wm>	 New patchset: Siebrand; "Fix cog hover behavior for Opera" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69456
[06:58:14] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[07:59:34] <gerrit-wm>	 New review: Mattflaschen; "First, it's !== -1" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[08:05:14] <gerrit-wm>	 New review: Mattflaschen; "Looks good for the most part.  I have some minor issues and suggestions." [mediawiki/extensions/OpenStackManager] (master) C: -1;  - https://gerrit.wikimedia.org/r/65557
[08:05:41] <gerrit-wm>	 New review: Mattflaschen; "Sorry, link broke.  It's just .jshintrc from the core root." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557
[08:18:15] <gerrit-wm>	 New patchset: Spage; "Update to reflect mediawiki.ui in core." [mediawiki/extensions/Agora] (master) - https://gerrit.wikimedia.org/r/69458
[08:20:34] <gerrit-wm>	 New patchset: Rfaulk; "mod. _create_lock creates the lock on deploy target." [sartoris] (master) - https://gerrit.wikimedia.org/r/69459
[08:21:14] <gerrit-wm>	 Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69459
[08:22:11] <gerrit-wm>	 New review: Spage; "Matt discovered that the Echo extension loads 'mediawiki.ui' on every page load, so it's effectively..." [mediawiki/extensions/Agora] (master) - https://gerrit.wikimedia.org/r/69458
[08:24:31] <gerrit-wm>	 New review: Kghbln; "Well of course patchwork messages should be avoided if possible and useful. I guess it depends on th..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 1;  - https://gerrit.wikimedia.org/r/69330
[08:29:47] <gerrit-wm>	 New patchset: Rfaulk; "mod. add method _remove_lock." [sartoris] (master) - https://gerrit.wikimedia.org/r/69460
[08:30:18] <gerrit-wm>	 Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69460
[08:39:42] <gerrit-wm>	 New review: Mattflaschen; "Well, the only sites Echo is on (not counting testing) are MW.org and English Wikipedia.  But I expe..." [mediawiki/extensions/Agora] (master) - https://gerrit.wikimedia.org/r/69458
[08:43:50] <gerrit-wm>	 New review: Physikerwelt; "mh...are you sure?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[08:48:44] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617
[09:04:52] <gerrit-wm>	 New patchset: Rfaulk; "mod. handling lock file removal and checking." [sartoris] (master) - https://gerrit.wikimedia.org/r/69462
[09:05:09] <gerrit-wm>	 Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69462
[09:08:16] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69463
[09:08:16] <gerrit-wm>	 New patchset: Santhosh; "Use content language as default language for ime selector" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69464
[09:08:39] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1;  - https://gerrit.wikimedia.org/r/69298
[09:10:56] <gerrit-wm>	 New review: Mattflaschen; "Thanks for removing the unneeded top and explaining the other one.  That was my last concern, and th..." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/67233
[09:13:33] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233
[09:16:07] <gerrit-wm>	 New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69464
[09:16:19] <gerrit-wm>	 New review: Nikerabbit; "Test scenario:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400
[09:20:13] <Nikerabbit>	 hmm
[09:34:27] <gerrit-wm>	 New review: Physikerwelt; "Hi," [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[09:47:08] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[09:50:23] <gerrit-wm>	 New review: Physikerwelt; "This patch set does for me what it should do." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[09:53:34] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[09:54:54] <hashar>	 Reedy: are you around by any chance ? :)
[09:55:03] <Reedy>	 I am
[09:55:17] <hashar>	 I got a mediawiki config change for you to review :  https://gerrit.wikimedia.org/r/69466
[09:55:27] <hashar>	 that is to change the abusefilter central DB on beta :-)
[09:55:43] <hashar>	 'metawiki' was hardcoded in CommonSettings.php
[09:55:59] <gerrit-wm>	 New patchset: Nikerabbit; "Remove border-radius from ULS cog" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69467
[09:56:04] <Reedy>	 Looks fine
[09:56:27] <gerrit-wm>	 New review: Nikerabbit; "This is alternative fix to gerrit 69456" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69467
[09:56:39] <hashar>	 Reedy: the next step is : how do I sync it on production ? : -)
[09:56:48] <hashar>	 I guess tin then the usual sync-file  right?
[09:59:14] <gerrit-wm>	 New patchset: Nikerabbit; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69463
[09:59:20] <Reedy>	 Yeah, just use /a/common on tin
[09:59:24] <Reedy>	 sync-dir wmf-config
[09:59:45] <hashar>	 I keep forgetting about sync-dir
[10:00:26] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69463
[10:02:09] <Nikerabbit>	 Reedy: perhaps you could also review my patches ;)
[10:04:03] <gerrit-wm>	 New review: Nikerabbit; "https://gerrit.wikimedia.org/r/69467 seems to be simpler solution for this. I still had problems wit..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69456
[10:04:44] <gerrit-wm>	 New patchset: Nikerabbit; "Use content language as default language for ime selector" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69464
[10:06:06] <jarry1250>	 James_F et al.: Still on for early July VE rollout?
[10:07:46] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69464
[10:23:02] <gerrit-wm>	 New patchset: Nikerabbit; "Restore API action=parse&text=foo functionality on wikidata.org" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[10:25:02] <gerrit-wm>	 New patchset: Daniel Kinzler; "Register ResourceLoaderModule via callback." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69471
[10:26:25] <Nikerabbit>	 DanielK_WMDE: could you (poke someone to) review https://gerrit.wikimedia.org/r/69470 ?
[10:29:46] <Nemo_bis>	 Nikerabbit: there's a handy wikidata group
[10:29:56] * Nemo_bis  doesn't fear spam

[10:34:09] <Nikerabbit>	 Nemo_bis: that feels excessive
[10:34:57] <Nikerabbit>	 Nemo_bis: besides, only DanielK_WMDE has +2 rights of them all
[10:35:19] <DanielK_WMDE>	 Nikerabbit: i'm not sure this is a good idea at all.
[10:35:38] <DanielK_WMDE>	 Nikerabbit: the title is passed into the parser, which may make assumptions about what it can do with the page
[10:36:00] <Nemo_bis>	 Nikerabbit: you didn't speak of +2
[10:36:02] <Nikerabbit>	 breaking action=parse and not fixing it is not a good idea at all, but I'm open for other suggestions or someone else fixing it
[10:37:04] <DanielK_WMDE>	 Nikerabbit: if you want to parse wikitext, use a wikitext page as context?
[10:37:22] <Nikerabbit>	 and how do I get a wikitext page?
[10:38:11] <Nikerabbit>	 this is essentially the fix suggested in the bug report &contentmodel=wikitext but implemented on server side to not break all clients
[10:38:23] <DanielK_WMDE>	 Nikerabbit: you mean out of the blue? you don't actually have any context for the text you parse, but want to supply a dummy?
[10:38:34] <DanielK_WMDE>	 in that case, why require a title at all in the API?
[10:39:10] <DanielK_WMDE>	 If you really need a dummy: pages in the MediaWiki namespace should be safe, at least as long as they don't end in .js or .css
[10:39:24] <DanielK_WMDE>	 talk pages and user pages are also very unlikely to be anything else but wikitext
[10:39:49] <DanielK_WMDE>	 the same goes for the Project and Help namespaces
[10:40:00] <Nikerabbit>	 DanielK_WMDE: api has used [[API]] as the dummy title who knows for how long, I'm not sure if it is okay to change it
[10:41:32] <DanielK_WMDE>	 Nikerabbit: we can no longer be sure of that page's content model, so that assumption has to go
[10:43:03] <Nikerabbit>	 well, I can come up with similar issues in all your suggestions as well
[10:44:55] <Nikerabbit>	 having to rely on any title doesn't sound a good idea, hence I'm overriding it but I have no idea if it works (according to Aude it works)
[10:44:55] <DanielK_WMDE>	 Nikerabbit: sure. I think the concept of a default title is fundamentally flawed.
[10:45:12] <DanielK_WMDE>	 an API call would either define a title, or there is no title.
[10:45:19] <DanielK_WMDE>	 (yes that wpo
[10:45:21] <DanielK_WMDE>	 err
[10:45:28] <Nikerabbit>	 Parser doesn't work without title as far as I know
[10:45:35] <DanielK_WMDE>	 yes, that would break some existing code. but it would be the right approach
[10:45:54] <DanielK_WMDE>	 Parser doesn't have to - it always works on a wikitext page
[10:46:03] <DanielK_WMDE>	 if you want to parse wikitext, you have to kjnow for which poage
[10:46:07] <DanielK_WMDE>	 the parser requires this
[10:46:20] <DanielK_WMDE>	 if you want to supply a dummy, it'S up to you to find a good dummy.
[10:46:41] <DanielK_WMDE>	 but let me look at the parse module again
[10:48:34] <DanielK_WMDE>	 Nikerabbit: ApiParse doesn't use wgTitle, so it doesn't care about [[API]]
[10:48:42] <DanielK_WMDE>	 what matters is what you supply in the title param
[10:49:21] <DanielK_WMDE>	 ah, damn, i'm wrong
[10:49:32] <DanielK_WMDE>	 "API" is the default value for the title param
[10:49:35] <DanielK_WMDE>	 that sucks
[10:50:14] <DanielK_WMDE>	 Nikerabbit: the cleanest solution would be to just always specify model=wikitext
[10:50:49] <DanielK_WMDE>	 you are trying to parse wikitext, and ignore the title's "own" model - so say so.
[10:51:43] <Nikerabbit>	 DanielK_WMDE: yes, that's what I am doing, but in a way that we don't break all existing clients relying on the current behaviour
[10:54:05] <DanielK_WMDE>	 Nikerabbit: but they already are broken. they are assuming all pages contain wikitext. this is no longer true.
[10:54:30] <DanielK_WMDE>	 there is no way we can make clients work with non-wikitext pages without becoming aware of this fact.
[10:54:35] <gerrit-wm>	 New patchset: Nikerabbit; "api.parse: default to wikitext model" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69472
[10:54:53] <Nikerabbit>	 DanielK_WMDE: most clients just want to parse snippet of wikitext, they don't care about the rest
[10:55:05] <Nikerabbit>	 DanielK_WMDE: ^^ that is another thing I can do, but it doesn't fix everything
[10:55:23] <DanielK_WMDE>	 Nikerabbit: actually, if no model *AND* no title is provided explicitly, then defaulting to wikitext is sensible.
[10:56:50] <DanielK_WMDE>	 but the code you provide will always default to wikitext, even if a title pointing explicitly to a non-wikitext page is provided.
[10:58:03] <AzaToth>	 if anyone using dolphin browser on their android phone could confirm my issue at https://bugzilla.wikimedia.org/49804, that would be great!
[10:58:22] <gerrit-wm>	 New patchset: Nikerabbit; "Restore API action=parse&text=foo functionality on wikidata.org" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[10:58:28] <Nikerabbit>	 DanielK_WMDE: ^^
[10:58:36] <gerrit-wm>	 New review: ArielGlenn; "Verified that with a standard apache setup, with the default upload path and dir, having $wgGenerate..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69025
[10:59:34] <gerrit-wm>	 New review: Daniel Kinzler; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/69470
[11:00:12] <DanielK_WMDE>	 Nikerabbit: that'S close, except for the case that there really is a page called "API" and it'S not wikitext :)
[11:00:34] <DanielK_WMDE>	 i'd prefer to set title to = '' per default so the code can know whether the title was given explicitly or not
[11:00:38] <DanielK_WMDE>	 see me comment on the bug
[11:00:41] <DanielK_WMDE>	 err, on the change
[11:02:51] <gerrit-wm>	 New patchset: Santhosh; "jquery.ime updates - keyboard mapping fixes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69473
[11:08:10] <gerrit-wm>	 New patchset: Nikerabbit; "Restore API action=parse&text=foo functionality on wikidata.org" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[11:09:51] <gerrit-wm>	 New review: KartikMistry; "LGTM!" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/69473
[11:24:12] <gerrit-wm>	 New review: Nikerabbit; "In general I'm against this kind of changes unless they bring some benefit. Just adding @param $foo ..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/69454
[11:53:15] <gerrit-wm>	 New patchset: J; "Register resouces with absolute path" [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/69479
[11:53:26] <gerrit-wm>	 New patchset: J; "Register resources with absolute path" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69480
[12:05:49] <Nikerabbit>	 DanielK_WMDE: is the new patch(es) okay
[12:17:41] <gerrit-wm>	 New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/69479
[12:19:51] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69291
[12:22:21] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Revert "Improve TravisCI build script"" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69484
[12:22:47] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69484
[12:28:28] <gerrit-wm>	 New patchset: Hashar; "Revert "jshint/jsduck: Include config files in file match filter"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69485
[12:28:30] <gerrit-wm>	 New patchset: Hashar; "Revert "jshint/jsduck: Include config files in file match filter"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69485
[12:29:09] <gerrit-wm>	 New patchset: Hashar; "Revert "jshint/jsduck: Include config files in file match filter"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69485
[12:29:35] <gerrit-wm>	 New review: Hashar; "regression" [integration/zuul-config] (master) C: 2;  - https://gerrit.wikimedia.org/r/69485
[12:29:35] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69485
[12:34:36] <gerrit-wm>	 New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582
[12:35:43] <gerrit-wm>	 New patchset: Nemo bis; "Register resources with absolute path" [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/69479
[12:39:51] <gerrit-wm>	 New patchset: Hashar; "soften the file restriction for javascript jobs" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69486
[12:40:15] <gerrit-wm>	 New review: Hashar; "Reinstated with  https://gerrit.wikimedia.org/r/69486" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69260
[12:40:52] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69486
[12:43:55] <gerrit-wm>	 New patchset: Hashar; "jenkins validate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69487
[12:45:41] <gerrit-wm>	 New patchset: Hashar; "jenkins validate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69487
[12:47:19] <gerrit-wm>	 Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69487
[13:07:41] <gerrit-wm>	 New review: J; "was not sure __DIR__ is available in the version of php required for mediawiki, but since it was add..." [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/69479
[13:20:29] <gerrit-wm>	 New patchset: Nikerabbit; "Allow non-translators to sign up" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/64591
[13:24:08] <gerrit-wm>	 New review: Nikerabbit; "(1 comment)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69486
[13:28:36] <gerrit-wm>	 New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102
[13:29:21] <gerrit-wm>	 New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102
[13:46:18] <gerrit-wm>	 New review: Daniel Kinzler; "a test case would be nice, ApiParseTest exists but is very limited" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[13:52:47] <gerrit-wm>	 New review: Daniel Kinzler; "Whzn using action=parse without a title, it's sensible to always specify the contentmodel parameter." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/69472
[13:53:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[14:02:19] <gerrit-wm>	 New review: Nischayn22; "Okay. This already needs some more work, specifically in the UI part." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306
[14:16:58] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Allow fail on php 5.5. build" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69489
[14:17:15] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Allow fail on php 5.5 build" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69490
[14:17:24] <gerrit-wm>	 New patchset: Jeroen De Dauw; "allow fail on php 5.5 build" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69491
[14:24:46] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69489
[14:24:50] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69490
[14:24:55] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69491
[14:26:08] <gerrit-wm>	 New review: Anomie; "Oh, damn. Someone went and merged this while I was reviewing it, despite all the problems in it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69470
[14:26:27] <anomie>	 DanielK_WMDE: Grr.
[14:31:01] <Nikerabbit>	 anomie: can you make a followup?
[14:31:13] <anomie>	 Nikerabbit: Yeah, I will in a few minutes
[14:31:44] <anomie>	 Sucks that we can't fix the poor commit summary on the merged one though.
[14:39:42] <DanielK_WMDE>	 anomie: sorry about that. i guess the documentation issues can be addressed in a follow-up.
[14:39:50] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/69403
[14:40:14] <DanielK_WMDE>	 anomie, Nikerabbit: actually, there is a pretty big issue here, but i didn't want to blockj on it since i'm not sure about the current best practice in core:
[14:40:19] <DanielK_WMDE>	 there's no regression test
[14:40:32] <DanielK_WMDE>	 ApiParserTest needs love urgently
[14:40:44] <DanielK_WMDE>	 i wouldn't have merged something like this without tests into wikibase
[14:41:42] <gerrit-wm>	 New review: Zfilipin; "What does this commit do? As far as I understood the commit message, it should disable "Verified" ra..." [qa/browsertests] (refs/meta/config) - https://gerrit.wikimedia.org/r/69323
[14:42:16] <gerrit-wm>	 New review: Lbenedix; "." [mediawiki/extensions/UIFeedback] (master) - https://gerrit.wikimedia.org/r/50004
[14:47:57] <gerrit-wm>	 New review: Raimond Spekking; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233
[14:50:59] <gerrit-wm>	 New review: J; "Firefox 3.5 crashes here on start, do you get any js error in the console?" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64932
[14:57:23] <gerrit-wm>	 New patchset: Anomie; "Improve documentation of action=parse (followup Ie4f7324c)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69494
[14:58:27] <anomie>	 DanielK_WMDE: The API in general needs more tests, really.
[14:58:53] <DanielK_WMDE>	 yes. and when changing behavior, it's a good time to write some
[15:10:46] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69494
[15:22:26] <gerrit-wm>	 New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038
[16:10:41] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Work on unserialization [DO NOT MERGE]" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/54024
[16:16:09] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Work on unserialization [DO NOT MERGE]" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/54024
[16:21:28] <gerrit-wm>	 New patchset: Yaron Koren; "Added fix for non-UTF-8 encodings in web data" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/69498
[16:23:28] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/69498
[16:28:36] <gerrit-wm>	 New patchset: Cmcmahon; "update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[16:30:49] <gerrit-wm>	 New review: Physikerwelt; "Still problems with the configuration... there is a special guide on the configuration" [mediawiki/extensions/Math] (master); V: -1 C: -1;  - https://gerrit.wikimedia.org/r/69298
[16:36:46] <Nikerabbit>	 DanielK_WMDE: well, as we know api modules are not easily testable... making it so would be big refactoring
[16:42:30] <gerrit-wm>	 New review: Physikerwelt; "I can not reproduce the error... maybe it was a problem with my browser cache. However it would be g..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[16:42:37] <gerrit-wm>	 New review: Brian Wolff; "No js errors, but in debug mode I get:" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64932
[16:44:32] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Work on unserialization [DO NOT MERGE]" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/54024
[17:02:29] <DanielK_WMDE>	 Nikerabbit: that's not entirely true. it's near impossible to unit test them, but integration tests have been working for a year now. They may need global fixtures (such as users or pages in the database), but that's the only big annoyance.
[17:02:51] <DanielK_WMDE>	 Writing tests for ApiParse should be a matter of half an hour. maybe two hours if you do it for the first time
[17:03:41] <DanielK_WMDE>	 ApiParse doesn't need tokens or permissions; you'd need to create a page in the database to test with title and page, but that's about it
[17:07:28] <gerrit-wm>	 New patchset: Ori.livneh; "Exec 'git clone' as 'vagrant' user" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69502
[17:11:42] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67043
[17:14:07] <^demon>	 DanielK_WMDE: So, I was poking getTextForSearchIndex(). For wikitext content models, I'm wondering if returning wikitext is the best option.
[17:15:02] <^demon>	 In the new search, I'd rather index the preprocessed text and I'm wondering if that's also the best idea for core.
[17:15:09] <DanielK_WMDE>	 ^demon: well, it's what was happening before, so i kept it that way.
[17:15:21] <^demon>	 The old behavior is kinda bleh ;-)
[17:15:28] <DanielK_WMDE>	 hehe :)
[17:15:47] <gerrit-wm>	 New patchset: Brian Wolff; "disablecontrols should only be set once not per source" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64932
[17:15:48] <DanielK_WMDE>	 if you think transforming the text first ios a good idea, go right ahead :)
[17:16:02] <Nikerabbit>	 DanielK_WMDE: hmm you mean selenium tests?
[17:16:11] <^demon>	 I think I'm gonna try it and see what happens.
[17:16:15] <^demon>	 Will test against my solr setup plus out-of-the-box mysql.
[17:16:24] <DanielK_WMDE>	 ^demon: the thing is: the search engine should really get the COntent object, and for any content models it knows could implement special behavior. For unknown content, it would use getTextForSearchIndex.
[17:16:46] <^demon>	 Hmm, that would be nice.
[17:16:56] <DanielK_WMDE>	 which in turn would be implemented in a smalles-common-demominator way
[17:17:49] <DanielK_WMDE>	 Nikerabbit: no i mean phpunit test. just phpunit tests that don't test the api module class isulated from everythign else, but tests its operation on top of the full stack down to the database
[17:17:54] <DanielK_WMDE>	 that's an integration test
[17:17:59] <DanielK_WMDE>	 selenium would be an interaction test
[17:18:25] * DanielK_WMDE  can't type for his life today

[17:18:29] <^demon>	 We'd need some kind of support within SearchResult (and children) for that as well.
[17:18:34] <DanielK_WMDE>	 it'S too damn hot here!
[17:18:36] <Nikerabbit>	 mmm I'm not sure I've used to that kind of terminology
[17:19:07] <DanielK_WMDE>	 ^demon: yes, please! it's quite possible i lefet some //todos about that in the code
[17:19:34] <DanielK_WMDE>	 Nikerabbit: people just call them unit tests even though they arn't. *shrug*
[17:19:39] <DanielK_WMDE>	 i find the distinction useful
[17:20:36] <Nikerabbit>	 well, they are using phpunit so it's easy to call them unit tests
[17:21:05] <DanielK_WMDE>	 Nikerabbit: https://en.wikipedia.org/wiki/Software_testing#Testing_levels
[17:25:04] <DanielFriesen>	 Anyone want to have a random meta-discussion on old semantic mistakes made during the standardization of HTML?
[17:25:31] <DanielFriesen>	 ^_^ Like how <dt> and <dd> should have had a container for each definition.
[17:25:46] <DanielFriesen>	 And <button> should have NEVER had it's default type set to submit.
[17:28:18] <AaronSchulz>	 anomie: I still have one comment on https://gerrit.wikimedia.org/r/#/c/68462/2/docs/hooks.txt
[17:28:37] * AaronSchulz  would like to get this merged soon though

[17:29:10] <DanielFriesen>	 ...I keep forgetting to mention something about that...
[17:29:35] <anomie>	 AaronSchulz: It seems to me that blowing away the current status state would be valid there, especially since $status is ignored unless the hook returns false.
[17:29:37] <DanielFriesen>	 Why does it have to be horrible old hooks.txt format vs. ugly Doxygen format.
[17:30:03] <DanielFriesen>	 Oh... n/m ignore me. Wrong commit.
[17:30:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68004
[17:30:21] <^demon>	 DanielK_WMDE: Stupid question. In WikitextContent, how do I find out the title I'm currently on?
[17:31:17] <^demon>	 This is what I'm trying to do, but I may be totally wrong: http://p.defau.lt/?ObPHDa_YFatxhCaGYwzn4g
[17:31:26] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[17:31:42] <gerrit-wm>	 New review: Brian Wolff; "Ok. Looks like the issue I was having was fixed in master, but not in the revision this commit was b..." [mediawiki/extensions/TimedMediaHandler] (master) C: 2;  - https://gerrit.wikimedia.org/r/64932
[17:32:02] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64932
[17:32:47] <DanielK_WMDE>	 ^demon: you can't. The Content object is oblivious to "where" it is. it just represents the content as such.
[17:33:03] <DanielK_WMDE>	 ^demon: actually, i now feel that is has far too much functionality that should really be in ContentHandler
[17:34:42] <DanielK_WMDE>	 the fact that Parser needs a Title object seems horribly broken to me :)
[17:35:54] <gwicke>	 DanielK_WMDE: some preprocessor and parser behavior changes depending on the page you are on
[17:36:01] <RoanKattouw>	 {{PAGENAME}} etc.
[17:36:06] <DanielK_WMDE>	 but, uh... getTextForSearchIndex really shouldn't return HTML. It's (ab)used in several places for a "plan text" view of the content - in AbouseFilter, for instance
[17:36:14] <gwicke>	 even something as simple as wiki links
[17:36:16] <^demon>	 Ew.
[17:36:23] <^demon>	 This is going to suck.
[17:36:42] <DanielK_WMDE>	 if you want to index based on HTML, the indexer should really process COntent objects, and call getParserOutput to get the HTML.
[17:36:52] <DanielK_WMDE>	 RoanKattouw: sure, but it could be optional.
[17:37:00] <DanielK_WMDE>	 RoanKattouw: {{PAGENAME}} would just be empty
[17:37:04] <^demon>	 I'm trying to do it in a way that core can mimic as well.
[17:37:05] <gerrit-wm>	 New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[17:37:13] <^demon>	 I'm trying to use the SearchUpdate infrastructure.
[17:37:42] <DanielK_WMDE>	 ^demon: but if you make getTextForSearchIndex return HTML, the standard mysql search will also be indexing HTML, with horrible results
[17:37:57] <DanielK_WMDE>	 you could add getHTMLForSearchIndex... but ugh.
[17:37:59] <^demon>	 The SearchUpdate strips most of that.
[17:38:40] <DanielK_WMDE>	 I don't this going that way is a good idea.
[17:38:48] <DanielK_WMDE>	 an indexer that wants HTML should go and fetch HTML
[17:39:02] <DanielK_WMDE>	 and indexer that has knowledge about a specific data model should use that knowledge con the COntent object
[17:39:33] <^demon>	 Well then core is just as broken as the extension.
[17:41:21] <^demon>	 Wait, I was doing this wrong anyway...
[17:41:29] <^demon>	 I want preprocessed wikitext, not final html.
[17:41:41] <^demon>	 Which *does* make sense for mysql as well as others.
[17:41:44] <gerrit-wm>	 New patchset: Amire80; "Update localization from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69504
[17:42:35] <gerrit-wm>	 New review: Physikerwelt; "Ok. This is the best I can do at the moment after reading through mathjax and mediawikis resource lo..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298
[17:44:03] <DanielFriesen>	 ...$wgVectorUseIconWatch = true; oh, right. I made that change.
[17:46:31] <DanielK_WMDE>	 ^demon: i don't think Content has an interface for that at present
[17:46:40] <^demon>	 No, it doesn't.
[17:46:53] <DanielK_WMDE>	 it's also not really defined for anything but wikitext
[17:47:06] <gerrit-wm>	 New patchset: Amire80; "Remove trailing comma" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69505
[17:47:11] <DanielK_WMDE>	 though there could be a general notion of "expanding" content.
[17:47:53] <^demon>	 A-ha, I got lucky.
[17:47:57] <DanielK_WMDE>	 expand() should probably return a new COntent object that contains the expanded version
[17:48:04] <^demon>	 Nobody calls SearchUpdate outside of core. Can handle it all in one place.
[17:49:09] <gerrit-wm>	 New patchset: Nikerabbit; "jquery.ime updates - keyboard mapping fixes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69473
[17:50:12] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[17:54:52] <gerrit-wm>	 New patchset: Cmcmahon; "WIP: update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[17:56:35] <gerrit-wm>	 New patchset: Demon; "Pass content to SearchUpdate rather than raw text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[17:56:53] <^demon>	 DanielK_WMDE: Step 1 ^
[17:59:44] <gerrit-wm>	 New patchset: Demon; "Pass content to SearchUpdate rather than raw text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[18:00:36] <gerrit-wm>	 New patchset: Demon; "Pass content to SearchUpdate rather than raw text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[18:02:28] <bawolff>	 lol ori-l "Furthermore, PHP_SAPI rhymes with "happy", whereas "php_sapi_name" rhymes with "lame". QED, etc."
[18:03:00] <marktraceur>	 Aw, that's great.
[18:03:43] <^demon>	 lol.
[18:08:08] <gerrit-wm>	 New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858
[18:08:16] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69507
[18:08:56] <gerrit-wm>	 New review: Manybubbles; "This should still be compatible with MWSearch because MWSearch conveniently uses hooks instead of th..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/69506
[18:12:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69507
[18:16:09] <Nikerabbit>	 gerrit is giving lots of timeouts currently
[18:16:16] <Nikerabbit>	 when trying to update repos
[18:17:00] <^demon>	 Has been working fine for me all day.
[18:17:45] <gerrit-wm>	 New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858
[18:18:07] <Nikerabbit>	 twn:/resources/nike/wmf (wmf/1.22wmf7)$ git submodule update --init
[18:18:07] <Nikerabbit>	 ssh: connect to host gerrit.wikimedia.org port 29418: Connection timed out
[18:18:10] <Nikerabbit>	 fatal: The remote end hung up unexpectedly
[18:18:13] <Nikerabbit>	 Unable to fetch in submodule path 'extensions/LiquidThreads'
[18:18:55] <Nikerabbit>	 aww crap
[18:20:24] <gerrit-wm>	 New patchset: Nikerabbit; "Remove comma that shouldn't have been introduced" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69508
[18:20:57] <Nikerabbit>	 can someone review this oneliner for me: https://gerrit.wikimedia.org/r/#/c/69508/ ?
[18:23:03] <Nikerabbit>	 ^demon, marktraceur?
[18:23:32] <^demon>	 lgtm.
[18:23:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69508
[18:23:47] <marktraceur>	 Seconded
[18:23:52] <marktraceur>	 Aw, fastest +2 in the east.
[18:24:01] <Nikerabbit>	 thanks
[18:25:06] <gerrit-wm>	 New patchset: Nikerabbit; "jquery.ime updates - keyboard mapping fixes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69473
[18:26:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69473
[18:26:59] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69441
[18:27:40] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69510
[18:32:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69510
[18:33:20] <gerrit-wm>	 New patchset: MarkTraceur; "Fix bug if Adyen is disabled" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69513
[18:33:24] <marktraceur>	 mwalker: ^^
[18:35:16] <gerrit-wm>	 New review: Mwalker; "I'll go for it; but fix the syntax error :p" [mediawiki/core] (fundraising/1.22) C: -1;  - https://gerrit.wikimedia.org/r/69513
[18:35:20] <gerrit-wm>	 New patchset: Nikerabbit; "ULS to master without extra commas and more layout fixes" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69514
[18:36:07] <mwalker>	 marktraceur: ^
[18:36:22] <Nikerabbit>	 aww ;)
[18:36:43] <gerrit-wm>	 New patchset: MarkTraceur; "Fix bug if Adyen is disabled" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69513
[18:36:50] * marktraceur  goes to commit seppuku

[18:37:13] <marktraceur>	 's what I get for moving code and not thinking
[18:37:32] <gerrit-wm>	 New patchset: Aaron Schulz; "jobqueue: cleaned up JobQueue exception handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69451
[18:38:40] <gerrit-wm>	 New patchset: Demon; "Allow SearchUpdate hook to abort core update call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515
[18:38:40] <gerrit-wm>	 New patchset: Demon; "Remove unused class, SearchUpdate is backend-agnostic" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69516
[18:39:10] <DanielFriesen>	 T_T I can't find the old discussions on a spinner design.
[18:40:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69514
[18:41:18] <DanielFriesen>	 And it was an interesting one.
[18:42:41] <anomie>	 Is anyone else getting errors trying to git submodule update --init --recursive on a checkout of mediawiki/extensions? It seems that submodules got added that aren't actually available: DataTypes ValueFormatters ValueParsers ValueValidators ValueView WikibaseDatabase WikibaseQuery
[18:42:47] <anomie>	 Reedy, ^demon: ^
[18:44:00] * bawolff  wonders if it is just for me that switching between files in diff view in gerrit is slow...

[18:44:00] <^demon>	 They all wfm...
[18:44:14] <gerrit-wm>	 New review: Mwalker; "(1 comment)" [mediawiki/extensions/DonationInterface] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66886
[18:44:14] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/66886
[18:44:26] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69513
[18:44:54] <Nikerabbit>	 bawolff: try go up every once in a while, it tends to get exponentially slower
[18:45:04] <Nikerabbit>	 though this seems to be busy time for gerrit so it's generally slower
[18:45:05] <^demon>	 anomie: Ah, DataTypes seems to be referring to a sha1 that doesn't exist.
[18:45:16] <anomie>	 ^demon: I also see e.g. https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FDataTypes.git looks empty
[18:45:17] <^demon>	 Possibly due to us deleting & recreating the repo.
[18:45:56] <^demon>	 Well, I just made the repo. Up to someone to push their code :)
[18:45:57] <gerrit-wm>	 Change abandoned: Nikerabbit; "Sorry, I didn't notice that this patch already exists. Another patch was merged." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69505
[18:46:37] <gerrit-wm>	 New review: Krinkle; "Re-done with I6b1120c1b8c382ba4d64." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69485
[18:46:43] <gerrit-wm>	 New review: Krinkle; "Re-done with I6b1120c1b8c382ba4d64." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69260
[18:48:05] <gerrit-wm>	 New patchset: Demon; "Pass content to SearchUpdate rather than raw text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[18:49:05] <gerrit-wm>	 New review: Krinkle; "How is this better than registering it from a hook (e.g. onSetup / extension functions). What "just ..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/69471
[18:49:28] <DanielFriesen>	 Aaagh... I went through a few search pages and now GitHub is giving me a rate limit page.
[18:55:21] <gerrit-wm>	 New review: Aaron Schulz; "Meh, not going to bikeshed :)" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/68462
[18:55:35] <gerrit-wm>	 New review: Krinkle; "This is due to gzip merging the two in 1 dictionary item. Nice." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400
[18:56:42] <gerrit-wm>	 New patchset: Cmcmahon; "make page.feature pass in envs where VE is enabled" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69519
[18:56:52] <gerrit-wm>	 New review: Brian Wolff; "Ok, I got my software issues sorted out, and tested this. It all works and looks good, except for on..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/68642
[19:09:53] <gerrit-wm>	 New patchset: Krinkle; "vector: Add SVG versions of collapsible menu icons" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400
[19:13:43] <gerrit-wm>	 New review: Krinkle; "Looks good to me, but not approving since I don't manage Echo." [mediawiki/extensions/Echo] (master) C: 1;  - https://gerrit.wikimedia.org/r/64102
[19:14:06] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400
[19:16:41] <gerrit-wm>	 New review: Mattflaschen; "Commuting consensus is not required to merge this.  This does not actually enable FLAC uploads on Co..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:16:56] <gerrit-wm>	 New review: Cmcmahon; "thanks for the CR Rachel!" [qa/browsertests] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69519
[19:16:56] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69519
[19:18:08] <gerrit-wm>	 New patchset: Brian Wolff; "UserCache::getUserName: Docs said @since 1.21, but not in REL1_21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69524
[19:20:13] <gerrit-wm>	 New review: Alex Monk; "When that commit was created it was fine, but it got merged two days after the REL1_21 branch." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/69524
[19:22:43] <bawolff>	 Krenair: I figured it was probably something like that
[19:22:45] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69524
[19:22:51] <bawolff>	 Thanks for merging :)
[19:22:52] <gerrit-wm>	 New review: Mattflaschen; "Sorry for the typo.  I meant "Community consensus", obviously." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:23:24] <gerrit-wm>	 New patchset: Ori.livneh; "Exec 'git clone' as 'vagrant' user" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69502
[19:23:29] <Krenair>	 bawolff, I'm just wondering how the hell you managed to notice that :)
[19:23:45] <bawolff>	 User in #mediawiki complained
[19:23:53] <bawolff>	 alas I'm not actually that nitpicky
[19:24:11] <bawolff>	 that I check each @since tag as I see it
[19:24:25] <Krenair>	 :)
[19:24:36] <gerrit-wm>	 New patchset: Ori.livneh; "Exec 'git clone' as 'vagrant' user" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69502
[19:25:57] <gerrit-wm>	 New review: Brian Wolff; "TMH modifies the variable, which happens after execution of InitialiseSettings.php Thus merging this..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:28:17] <bawolff>	 Maybe I should just start a thread on Commons:VP about flac.
[19:29:29] <gerrit-wm>	 New patchset: Mwjames; "Travis + sqlite + PHP 5.4" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69525
[19:30:04] <gerrit-wm>	 Change merged: Mwjames; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69525
[19:41:17] <gerrit-wm>	 New review: Brian Wolff; "I started a thread at COM:VP - https://commons.wikimedia.org/wiki/Commons:Village_pump#Adding_.flac_..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:41:52] <gerrit-wm>	 New review: Mattflaschen; "Thanks, Brian.  My mistake (about $wgFileExtensions)." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:47:53] <AaronSchulz>	 ^demon: want to look at https://gerrit.wikimedia.org/r/#/c/68940/ ?
[19:52:33] <^demon>	 AaronSchulz: If you look at a few of mine :) https://gerrit.wikimedia.org/r/#/q/status:open+owner:Demon,n,z
[19:52:52] <gerrit-wm>	 New patchset: Mwjames; "i18n and patchwork messages !!!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69330
[19:53:47] <gerrit-wm>	 New review: Mwjames; "Thanks Karsten for the swift and responsive review." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69330
[19:56:49] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69330
[19:57:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68940
[19:57:49] <gerrit-wm>	 New patchset: Mwjames; "Replace is_array/is_string with a more performant approach" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68944
[19:58:26] <gerrit-wm>	 New patchset: Krinkle; "mediawiki.js: Clean up and improve documentation coverage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648
[19:58:27] <gerrit-wm>	 New patchset: Mwalker; "Removal of Non Required File" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69527
[19:59:10] <AaronSchulz>	 ^demon: what uses the SearchUpdate hook?
[19:59:31] <AaronSchulz>	 so it would now fire for deletes and title only updates, hmm
[20:01:23] <^demon>	 AaronSchulz: Nothing does.
[20:01:31] <AaronSchulz>	 yeah, grep shows nothing
[20:01:34] <^demon>	 I might possibly use it in CirrusSearch, haven't decided yet.
[20:01:48] <AaronSchulz>	 so your comment was right :)
[20:02:20] <gerrit-wm>	 New review: Alex Monk; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557
[20:02:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68944
[20:02:51] <AaronSchulz>	 ^demon: what would cause the abort? some check of the title content model type or something?
[20:03:50] <^demon>	 Possibly. I thought about possibly having Cirrus collect those search updates and do them in batch, rather than making individual requests.
[20:04:26] <^demon>	 But there's no real point, since the usual case (all cases?) is that there's only one search update.
[20:04:34] <^demon>	 reindexer is out of band.
[20:05:36] <AaronSchulz>	 one update per what?
[20:05:47] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 49264) Handle corrupt data values gracefully." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952
[20:05:47] <^demon>	 Per edit/delete/move
[20:06:53] <AaronSchulz>	 well move probably does two
[20:07:08] <AaronSchulz>	 but otherwise yes
[20:07:10] <^demon>	 Yeah, move is two edits.
[20:07:16] <^demon>	 Or an edit and a delete.
[20:08:19] <AaronSchulz>	 ^demon: hmm, so is that change needed then?
[20:08:31] <^demon>	 Not really, no :p
[20:08:40] <^demon>	 I'll rebase the child on master and abandon.
[20:08:59] <gerrit-wm>	 Change abandoned: Demon; "Not actually needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69515
[20:09:11] <^demon>	 Hmm, where's my rebase button....
[20:09:28] <AaronSchulz>	 lol, https://gerrit.wikimedia.org/r/#/c/66665/ is still pending
[20:09:52] <^demon>	 ya
[20:10:16] <gerrit-wm>	 New patchset: Demon; "Remove unused class, SearchUpdate is backend-agnostic" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69516
[20:13:34] <gerrit-wm>	 New review: Aaron Schulz; "Either change release notes or alter SearchEngine create to rewrite this value to the normal class n..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/69516
[20:14:43] <AaronSchulz>	 ^demon: what is the default maxLineLength ?
[20:14:51] <^demon>	 Like 60?
[20:15:26] <AaronSchulz>	 so it be changed to 100 then :)
[20:15:39] <AaronSchulz>	 *could be
[20:16:30] <wmf-selenium-bot>	 Yippie, build fixed!
[20:16:30] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #113: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/113/
[20:18:44] <gerrit-wm>	 New patchset: Mwjames; "(Bug 33181) Special:Concepts to list available concepts" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396
[20:20:38] <gerrit-wm>	 New review: Demon; "If someone had $wgSearchType set to "MyISAM", this hasn't worked in a super long time anyway... Sear..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69516
[20:20:46] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #60: FAILURE in 9 min 1 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/60/
[20:21:05] <gerrit-wm>	 New review: Mwjames; "Karsten, doing {{PLURAL:$1|concept|$1 concepts}} now as proposed." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396
[20:22:31] <gerrit-wm>	 New patchset: Andrew Bogott; "Add puppetValues.php tool" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69528
[20:22:51] <gerrit-wm>	 New review: Aaron Schulz; "Your right, that's already broken and can't exist to call the myisam update class." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/69516
[20:23:34] <gerrit-wm>	 Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69528
[20:24:28] <gerrit-wm>	 New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1;  - https://gerrit.wikimedia.org/r/64102
[20:24:40] <gerrit-wm>	 New review: Mwjames; "Going to merge this now (rebase drives me nuts) and surely the mediawiki "God" will crucify me for t..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2;  - https://gerrit.wikimedia.org/r/67396
[20:25:08] <AaronSchulz>	 ^demon: that's one down
[20:25:21] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69516
[20:25:44] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #60: FAILURE in 9 min 14 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/60/
[20:26:08] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396
[20:28:04] <AaronSchulz>	 ^demon: https://gerrit.wikimedia.org/r/#/c/67236/ easy one
[20:28:17] <gerrit-wm>	 New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102
[20:30:04] <^demon>	 AaronSchulz: Totally missed ApprovedRevs when grepping.
[20:30:26] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #99: FAILURE in 9 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/99/
[20:30:34] <AaronSchulz>	 that's little extension that's totally not FlaggedRevs
[20:30:42] <AaronSchulz>	 *that
[20:31:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67236
[20:31:45] <gerrit-wm>	 New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102
[20:33:28] <gerrit-wm>	 New patchset: Amire80; "Update localization from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69504
[20:34:00] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102
[20:37:25] <gerrit-wm>	 New review: Alex Monk; "Needs rebase." [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1;  - https://gerrit.wikimedia.org/r/63665
[20:38:44] <gerrit-wm>	 New patchset: Jqnatividad; "Added dot notation support for retrieving values from compound MongoDB result documents" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/69557
[20:39:08] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #110: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/110/
[20:41:04] <gerrit-wm>	 New patchset: Demon; "Pass content to SearchUpdate rather than raw text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[20:42:08] <gerrit-wm>	 New patchset: Cmcmahon; "update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[20:42:23] <gerrit-wm>	 New patchset: Kipcool; "SQLite Compatibility" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[20:43:11] <gerrit-wm>	 New patchset: Cmcmahon; "update test for new work flow" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[20:43:49] <gerrit-wm>	 New review: Cmcmahon; "This is quite a bit more clever than it used to be, it should pass consistently on test2wiki." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69499
[20:44:27] <gerrit-wm>	 Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[20:48:03] <gerrit-wm>	 New patchset: Mwjames; "Travis WikiPage::doEditContent" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69582
[20:50:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/69502
[20:53:20] <gerrit-wm>	 New patchset: Aaron Schulz; "Stop spamming exception log with random upload stash failures" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69583
[20:54:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69582
[20:57:36] <gerrit-wm>	 New patchset: Aaron Schulz; "Stop spamming exception log with random upload stash failures" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69583
[20:58:53] <gerrit-wm>	 New patchset: Mwjames; "SMW\Profiler encapsulates MediaWiki's (wfProfileIn/wfProfileOut)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69292
[20:59:36] <AaronSchulz>	 ^demon: would wfDeprecated() be useful?
[20:59:50] <^demon>	 For one extension?
[21:00:28] <AaronSchulz>	 well there should be someway to track things that a deprecated...that or an annotated comment
[21:00:36] <AaronSchulz>	 otherwise people will forget
[21:03:26] <ori-l>	 greg-g: could i sync an extension (eventlogging)? doesn't look like anyone is deploying atm, and i won't be around during LD.
[21:13:19] <gerrit-wm>	 New patchset: Aaron Schulz; "Avoid the "key conflict attempting to insert a user row" exception in some cases." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587
[21:15:08] <gerrit-wm>	 New patchset: MarkTraceur; "Actually make DI and CT work" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69588
[21:15:20] <gerrit-wm>	 New patchset: Aaron Schulz; "Avoid the "key conflict attempting to insert a user row" exception in some cases" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587
[21:15:21] <marktraceur>	 mwalker: Two sort of unrelated changes, but one of them is pointed at your head ^^
[21:16:05] <gerrit-wm>	 New review: Aaron Schulz; "Could use deprecation notice/comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[21:16:55] <AzaToth>	 Ryan_Lane: loh
[21:17:35] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69588
[21:18:04] <gerrit-wm>	 New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[21:19:44] <ebernhardson>	 lol, new favorite quote "I'm not sure I agree with this premise of we shouldn't provide better functionality just because it would make al the other poorly written functions look bad."
[21:19:48] <ebernhardson>	 doh wrong channel :P
[21:21:40] <gerrit-wm>	 Change abandoned: Mwjames; "(no reason)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65006
[21:23:01] <greg-g>	 ori-l: sorry for delay. Yes.
[21:26:01] <gerrit-wm>	 New patchset: Mwjames; "SMW\Profiler encapsulates MediaWiki's (wfProfileIn/wfProfileOut)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69292
[21:28:20] <gerrit-wm>	 New patchset: Kaldari; "New primary and secondary links" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817
[21:29:23] <gerrit-wm>	 New patchset: MarkTraceur; "Adding orphaned file from previous patch" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69589
[21:30:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69292
[21:35:06] <gerrit-wm>	 New review: Bsitu; "This will be handled differently in the html email patch, which adds the diff link to both text and ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876
[21:36:00] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.org-linux-firefox build #124: FAILURE in 4 min 12 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/124/
[21:39:47] <marktraceur>	 mwalker: I'm just adding a file I failed to add (I bloody hate git), it's a one-line SQL patch, shall I selfreview or...?
[21:40:18] <AzaToth>	 marktraceur: you want to use svn instead?
[21:40:47] <marktraceur>	 AzaToth: Have we totally ruled out the possibility of using Visual SourceSafe?
[21:40:48] <bawolff>	 svn: we miss you :P
[21:40:54] <ebernhardson>	 noone misses svn :P
[21:40:55] <mwalker>	 marktraceur: if it's to the deploy branch and already reviewed just push it
[21:40:57] <AzaToth>	 marktraceur: hehe
[21:41:01] <mwalker>	 marktraceur: otherwise I'll look
[21:41:09] <mwalker>	 also; VSS can rot in hell and die
[21:41:20] <bawolff>	 ebernhardson: We miss not having to convince others that our code is sane :P
[21:41:24] <mwalker>	 along with Rational ClearCase
[21:41:38] <AzaToth>	 imo for git, people really need to learn how to use reflog
[21:41:52] <AzaToth>	 the magical anti-fuckup command
[21:42:10] <marktraceur>	 Oh, yeah, not reviewed yet mwalker
[21:42:19] <marktraceur>	 Noted
[21:42:45] <marktraceur>	 mwalker: I'm sure as hell not disagreeing with you on VSS, had to use it for a month and I nearly hanged myself
[21:42:56] * bawolff  is reading man git-reflog right now

[21:43:43] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69589
[21:44:06] <AzaToth>	 bawolff: generally if you've made a bad commit, reflog is sufficient, and you dont' need to dig into git fsck
[21:44:44] <bawolff>	 If I make a bad commit, usually i just sit down and cry
[21:44:51] <AzaToth>	 hehe
[21:44:52] <bawolff>	 Or do git reset --hard HEAD
[21:45:13] <AzaToth>	 if you made a bad commit, then git reset --hard HEAD will not do anything
[21:45:29] <^demon>	 reset --hard origin/master :p
[21:45:33] <AzaToth>	 if you made a bad commit, then git reset --hard HEAD@{1} might work
[21:46:02] <bawolff>	 lol, good point AzaToth
[21:46:45] <AzaToth>	 but what I meant is that when you've made something bad, like git reset --hard $(random commit), then reflog can save you
[21:47:17] <AzaToth>	 as you can see wtf you've done
[21:48:48] <AzaToth>	 bawolff: if you need to do "git fsck --lost-found" then you are pretty fucked up ツ
[21:48:54] <gerrit-wm>	 New patchset: MarkTraceur; "Update ContributionTracking to master" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69590
[21:49:13] <gerrit-wm>	 Change merged: MarkTraceur; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69590
[21:50:13] <AzaToth>	 bawolff: master@{one.week.ago} means "where master used to point to one week ago"
[21:50:36] <AzaToth>	 that's if you have no clue what you've done last week
[21:50:43] <bawolff>	 That seems like a bad idea in all circumstances...
[21:51:05] <bawolff>	 Its broken now. Maybe it was less broken sometime last week...
[21:51:14] <AzaToth>	 depends on what you plan to do  with it
[21:52:20] <AzaToth>	 bawolff: perhaps you went on vacation, and someone using your account fucks it all up ツ
[21:52:34] <bawolff>	 lol
[21:52:36] <gerrit-wm>	 New review: Aaron Schulz; "Meh, there is a @todo near by enough :)" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/69506
[21:52:42] <bawolff>	 They better not be
[21:53:56] <qgil>	 marktraceur, thank you for reminding that the Oakland Wiknic is no SUNDAY
[21:54:15] <marktraceur>	 My pleasure
[21:54:20] <qgil>	 marktraceur, Oakland is nice, but visiting twice in a weekend from South Bay...
[21:54:22] <marktraceur>	 I think I'll drag sucheta to it as well :)
[21:54:39] <qgil>	 great!
[21:54:44] <gerrit-wm>	 New review: Mdale; "I tested this locally it all worked well. Going to just +1 to give some more people a chance to test..." [mediawiki/extensions/TimedMediaHandler] (master); V: 2 C: 1;  - https://gerrit.wikimedia.org/r/68642
[21:57:45] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69506
[21:59:24] <gerrit-wm>	 New patchset: Aaron Schulz; "Avoid the "key conflict attempting to insert a user row" exception in some cases" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69587
[22:02:36] <gerrit-wm>	 New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401
[22:13:29] <Hazard-SJ>	 Krinkle: Ping
[22:13:37] <Krinkle>	 Pong.
[22:14:33] <Hazard-SJ>	 Krinkle: Did you recieve any errors when you tried to restart CommonsDelinker?
[22:14:48] <Krinkle>	 Yes, account password is unknown or wrong.
[22:14:55] <Krinkle>	 presumably for awb
[22:14:58] <Krinkle>	 err. pywiki
[22:15:18] <Krinkle>	 I don't have that password. I operate the ts account, not the wiki bot account.
[22:15:41] <Krinkle>	 There should be a chmod 600 .pwd file in the pywiki directory so that we dont have to realy on pywiki keeping cookies
[22:15:51] <Krinkle>	 rely*
[22:17:54] <Hazard-SJ>	 Krinkle: Do you know if the commands CommonsDelinkerHelper were stored anywhere, or if they'll have to be recovered from the page's history?
[22:18:16] <Krinkle>	 Why would they no longer be on the wiki page? Did someone clear the page?
[22:19:11] <Hazard-SJ>	 Krinkle: The helper bot kept removing commands.
[22:19:26] <Hazard-SJ>	 Krinkle: https://commons.wikimedia.org/w/index.php?title=User:CommonsDelinker/commands&action=history
[22:20:07] <Hazard-SJ>	 Or better yet, https://commons.wikimedia.org/wiki/Special:Contributions/CommonsDelinkerHelper
[22:20:32] <gerrit-wm>	 New patchset: Ryan Lane; "Require tokens for post actions" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69593
[22:22:06] <gerrit-wm>	 New patchset: Ryan Lane; "Require tokens for post actions" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69593
[22:22:56] <AzaToth>	 Ryan_Lane: I assume you said there was 996 more packages to be fixed right?
[22:23:09] <Ryan_Lane>	 eh? for what?
[22:23:10] <Ryan_Lane>	 oh
[22:23:11] <Ryan_Lane>	 heh
[22:23:19] <Ryan_Lane>	 confused for a sec
[22:23:22] <AzaToth>	 ツ
[22:23:24] <Ryan_Lane>	 yeah, I'm sure there's more
[22:23:36] <AzaToth>	 anyone that is prio?
[22:23:39] <Ryan_Lane>	 hm
[22:23:52] <gerrit-wm>	 New patchset: Mattflaschen; "Fix E_STRICT issue (only variables should be passed by ref)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69595
[22:24:00] <Ryan_Lane>	 let me try to find some in a bit
[22:24:05] <AzaToth>	 I've noticed you've created some empty repos for debs
[22:24:24] <Ryan_Lane>	 oh. I know for sure one that some folks would love you for
[22:24:28] <Ryan_Lane>	 ircd-ratbox
[22:24:37] <Ryan_Lane>	 RobH: ^^
[22:25:02] <Ryan_Lane>	 hm. what happened to that change
[22:25:02] <AzaToth>	 hmm
[22:25:05] <Ryan_Lane>	 I wonder if someone closed it
[22:25:08] <Ryan_Lane>	 or abandoned it
[22:25:15] <Ryan_Lane>	 we have a patched version of ircd-ratbox
[22:25:22] <AzaToth>	 where?
[22:25:26] <Krinkle>	 Hazard-SJ: That's odd. If it can't process them, it shouldn't remove them from the page.
[22:25:27] <Ryan_Lane>	 it's unpackaged :D
[22:25:31] <AzaToth>	 oh
[22:25:43] <Ryan_Lane>	 so, I merged the patches with the ubuntu version of the pacckage
[22:25:47] <Krinkle>	 I don't know the software, but I wouldn't be surprised if it doesn't handle this properly it certainly doesn't preserve them either.
[22:25:50] <Ryan_Lane>	 but it wasn't in a format that mark wanted
[22:25:57] <AzaToth>	 format?
[22:26:36] <Ryan_Lane>	 https://gerrit.wikimedia.org/r/#/admin/projects/operations/debs/ircd-ratbox
[22:26:40] * Ryan_Lane  sighs

[22:26:47] <Ryan_Lane>	 the damn change is just gone
[22:27:00] <Ryan_Lane>	 that's totally lame
[22:27:19] <Ryan_Lane>	 https://gerrit.wikimedia.org/r/#/c/12425/
[22:27:27] <Ryan_Lane>	 there we go
[22:27:38] <Ryan_Lane>	 "You should use a git-buildpackage repo layout"
[22:27:46] <Ryan_Lane>	 which ubuntu doesn't use
[22:28:17] <Ryan_Lane>	 and the version that ubuntu is using isn't in debian
[22:28:32] <Ryan_Lane>	 it's the debian version with ubuntu changes (thanks ubuntu!)
[22:29:32] <AzaToth>	 actually it looks like ubuntu hasn't modded it at all
[22:29:35] <AzaToth>	 http://packages.ubuntu.com/raring/ircd-ratbox
[22:29:51] <Ryan_Lane>	 oh?
[22:30:39] <Ryan_Lane>	 I think this is our patches: https://gerrit.wikimedia.org/r/#/c/12425/1/debian/patches/novoice_nonops
[22:30:54] <Ryan_Lane>	 *our only
[22:31:37] <gerrit-wm>	 New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[22:31:45] <Ryan_Lane>	 it's annoying to have an unpatched, unpuppetized service still around, though :)
[22:33:30] <gerrit-wm>	 New patchset: Ryan Lane; "Require tokens for post actions" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69593
[22:34:01] <AzaToth>	 Ryan_Lane: can you replace current one directly with git://git.debian.org/collab-maint/ircd-ratbox.git
[22:34:21] <Ryan_Lane>	 we need the patches applied
[22:34:34] <AzaToth>	 ÿou really do not want me to make 100+ patchsets
[22:34:38] <Ryan_Lane>	 we run a modified version with wmf specific changes
[22:34:54] <Ryan_Lane>	 but yeah, we can run a newer version
[22:35:06] <AzaToth>	 yea, but I really do not want to use a different repo than the original
[22:35:11] <Ryan_Lane>	 that's fine
[22:35:19] <Ryan_Lane>	 we're not using a packaged version at all right now
[22:35:23] <AzaToth>	 heh
[22:35:27] <Ryan_Lane>	 anything + our C changes is fine
[22:38:02] <gerrit-wm>	 New review: Ryan Lane; "Already deployed" [mediawiki/extensions/OpenStackManager] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69593
[22:38:02] <gerrit-wm>	 Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69593
[22:39:03] <gerrit-wm>	 New patchset: Mwjames; "SMWDIProperty class alias" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69598
[22:42:36] <Hazard-SJ>	 Krinkle: What server does CommonsDelinker's database use?
[22:42:47] <Krinkle>	 I don't know
[22:42:52] <Krinkle>	 siebrand: ^
[22:43:10] <Krinkle>	 I only execute "restart" a few times a year when it goes down
[22:43:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69598
[22:43:21] <Krinkle>	 and shut it down when it is going crazy to start it again later
[22:43:38] <Hazard-SJ>	 OK, thanks
[22:45:46] <gerrit-wm>	 New patchset: Cmcmahon; "run Math test on beta and test2 not enwiki. Math test fails on enwiki because of VE preferences" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69599
[22:46:41] <gerrit-wm>	 New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[22:49:53] <AzaToth>	 Ryan_Lane: correct me if I'm wrong, but can't that patch be made using configurations instead?
[22:50:11] * Hazard-SJ  couldn't find it :(

[22:50:12] <AzaToth>	 seems disable channel creation would be pretty normal config
[22:50:18] <Ryan_Lane>	 not as far as I know
[22:50:27] <Ryan_Lane>	 pretty sure it isn't
[22:50:44] <gerrit-wm>	 New patchset: MarkTraceur; "Set fullpath=true in the CT make-null patch" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69600
[22:50:46] <marktraceur>	 mwalker: I am hopeful that this will be the last patch.
[22:50:51] <Ryan_Lane>	 the normal way for handling this is to run a service like chanserv
[22:51:54] <marktraceur>	 mwalker: https://doc.wikimedia.org/mediawiki-core/master/php/html/classDatabaseUpdater.html#a47ddbdea76be952d12d93ab752f952ed
[22:52:02] <Ryan_Lane>	 of course, I think even chanserv wouldn't fully work. because people could still create channels
[22:52:08] <Ryan_Lane>	 they just wouldn't be able to talk in them
[22:53:01] <gerrit-wm>	 Change merged: Mwalker; [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69600
[22:55:20] <gerrit-wm>	 New patchset: MarkTraceur; "Update ContributionTracking to master" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69601
[22:59:17] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/68642
[22:59:51] <gerrit-wm>	 Change merged: MarkTraceur; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/69601
[23:05:14] <gerrit-wm>	 New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[23:06:52] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[23:07:52] <gerrit-wm>	 New patchset: Kaldari; "New primary and secondary links" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817
[23:08:46] <Ryan_Lane>	 Krenair: re: https://gerrit.wikimedia.org/r/#/c/60783/11..12/modules/ext.openstack.Instance.js,unified I can increase it, but doubling it makes it giant
[23:08:59] <Ryan_Lane>	 how about 600px width?
[23:12:36] <AzaToth>	 Ryan_Lane: done?
[23:12:54] <Ryan_Lane>	 done with?
[23:13:23] <AzaToth>	 ratbox init
[23:13:53] <Ryan_Lane>	 I'm confused. context? :)
[23:14:16] <AzaToth>	 <AzaToth> Ryan_Lane: can you replace current one directly with git://git.debian.org/collab-maint/ircd-ratbox.git
[23:14:20] <Ryan_Lane>	 ah
[23:14:35] <Ryan_Lane>	 one sec
[23:16:32] <Ryan_Lane>	 AzaToth: done
[23:16:58] <Ryan_Lane>	 sorry, keep getting distracted with random things :)
[23:18:27] <AzaToth>	 hehe
[23:20:27] <gerrit-wm>	 New patchset: Kaldari; "Adding support for primary and secondary links" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/69596
[23:21:40] <gerrit-wm>	 New review: Kaldari; "Depends on Echo change I94aed697" [mediawiki/extensions/Thanks] (master) C: -1;  - https://gerrit.wikimedia.org/r/69596
[23:21:41] <gerrit-wm>	 New patchset: SuchABot; "Bug 48995: Add acceptable use 'tutorial' to app" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69606
[23:21:57] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #114: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/114/
[23:25:18] <gerrit-wm>	 New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052
[23:26:04] <AzaToth>	 Ryan_Lane: please if you can create a branch wmf on master
[23:26:37] <Ryan_Lane>	 yep
[23:27:04] <gerrit-wm>	 New patchset: Kaldari; "New primary and secondary link behavior for Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817
[23:27:10] <Ryan_Lane>	 AzaToth: done
[23:29:48] <gerrit-wm>	 New review: Mattflaschen; "It works, but I think you need a getMetadata function, which hopefully will also resolve the warning..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/69401
[23:35:21] <Aaron|laptop>	 rfarrand: did you see enwiki's featured article Monday (http://en.wikipedia.org/wiki/Lynn_Hill)? Interesting read.
[23:35:38] <rfarrand>	 Yes!! I did
[23:36:21] <rfarrand>	 I saw her at a slide show once
[23:36:28] <rfarrand>	 bad ass climber
[23:36:58] * Aaron|laptop  was trying not to spend to much time reading that during work

[23:37:22] <Elsie>	 too
[23:38:40] <rfarrand>	 aaron|laptop: There is a slideshow in Emeryville by http://en.wikipedia.org/wiki/Steph_Davis tomorrow night!
[23:41:44] <Aaron|laptop>	 'Eventually, she made Moab her home by "acquiring a storage unit and a library card."' heh
[23:49:37] <gerrit-wm>	 New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401
[23:51:11] <gerrit-wm>	 New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401
[23:53:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66383
[23:53:43] <gerrit-wm>	 New patchset: Rahul21; "Add support for WAV audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69401