[00:00:28] ori-l: ... I'm... I'm using Windows 8 [00:00:32] * mooeypoo sniffles [00:00:53] but it's okay, windows 8.1 comes out soon, and that's pretty much a reversion bck to windows 7 [00:01:10] Is it bad? I haven't used it. I thought Windows 7 was pretty solid.. [00:01:17] New patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [00:06:05] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67557 [00:12:48] New patchset: Brian Wolff; "Make rc_cur_id have proper value for upload log entries." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69269 [00:21:30] Ryan_Lane: Whenever you have a minute: https://gerrit.wikimedia.org/r/#/c/69255/ [00:22:00] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69269 [00:22:13] * AaronSchulz likes Win7 [00:22:27] except the task bar icons mixing running and pin programs [00:22:30] ok. trying to tackle one last issue in a patchset, then I'll get to that [00:23:12] after years I still miss the highlighting and click what I think are icons for running apps thinking "what what am I doing with IE open?" only to realize it was not open and is now being opened [00:23:23] * AaronSchulz could unpin it, but also uses those icons sometimes [00:23:37] maybe it's just me...I had the same problem with OS X [00:31:20] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67564 [00:33:22] New patchset: Brian Wolff; "Make rc_cur_id have proper value for upload log entries." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69269 [00:33:47] New review: Brian Wolff; "PS 2: d'oh" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69269 [00:33:59] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67566 [00:34:34] New patchset: Mwalker; "Enable CentralNotice on Stable Mobile Site" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/69271 [00:37:58] Project browsertests-en.wikipedia.org-linux-chrome build #130: FAILURE in 3 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/130/ [00:44:55] New patchset: Ori.livneh; "Add API module for retrieving JSON Schema" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [00:45:49] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #95: FAILURE in 5 min 1 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/95/ [00:47:03] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #95: FAILURE in 4 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/95/ [00:47:46] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/69271 [00:51:16] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #99: FAILURE in 5 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/99/ [00:52:23] Krinkle, RoanKattouw_away, turns out the Firebug issue (media queries don't show in CSS tab) is fixed in 1.12, just not yet in my version. :) [00:52:47] 1.12 of what? [00:52:50] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #87: FAILURE in 5 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/87/ [00:52:58] 1.12 of Firebug. [00:53:04] oh, interesting [00:53:20] https://code.google.com/p/fbug/issues/detail?id=1717 [00:53:23] That's the last thing I expected. [00:54:29] Krinkle, there is a bug in RL too, but it's small (just for explicit printable requests). [00:54:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=49722 [00:55:58] New patchset: Ryan Lane; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [00:58:35] New patchset: Ryan Lane; "Add .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255 [00:59:28] well, that's a helpful error message [00:59:32] ah [00:59:46] New patchset: Ryan Lane; "Add .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255 [01:00:11] Krinkle: ^^ [01:02:20] New patchset: Krinkle; "Make mwext-OpenStackManager-jslint voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69273 [01:02:56] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69273 [01:04:07] New review: Ryan Lane; "Fixed all but one issues mentioned in comments." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [01:04:13] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255 [01:04:32] Ryan_Lane: OK. Merged and made jslint voting. [01:04:43] New review: Ryan Lane; "Adding "done" messages." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [01:04:43] https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-jslint/435/console : SUCCESS in 1s (non-voting) [01:04:44] https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-jslint/436/console : SUCCESS in 0s [01:04:57] cool, thanks! [01:06:05] Ryan_Lane: next time those change are rebased they should pass/fail jenkins accordingly [01:06:38] New patchset: Ryan Lane; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [01:06:45] well, we'll see :) [01:07:07] didn't on that patchset... [01:07:46] hm. I rebased that. wtf [01:08:25] ah, yeah. indeed. it's rebased and has the .jshintrc [01:09:36] Krinkle: does the actual patchset need to touch js or the jshintrc? [01:09:46] or just the change as a whole? [01:12:27] Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69189 [01:14:24] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #314: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/314/ [01:17:30] New review: Krinkle; "Per Tim, the stylesheet needs to be sanitized. Also, it might be wise to load it from the MediaWiki ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123 [01:31:45] New patchset: SuchABot; "Allow users to select preferred license for their contributions" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69274 [01:34:21] New patchset: RAN1; "Divide communitytwitter-access-error into sub-messages" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [01:40:22] New review: Spage; "Compared with index.php?action=raw, the API call adds a title key to the JSON (without "Schema:" na..." [mediawiki/extensions/EventLogging] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/68617 [01:42:59] New patchset: Mattflaschen; "ResourceLoader Pass printable parameter to load.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69276 [01:43:39] New patchset: Mattflaschen; "ResourceLoader Pass printable parameter to load.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69276 [01:44:28] New patchset: Mattflaschen; "ResourceLoader: Pass printable parameter to load.php." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69276 [01:45:13] New review: Mattflaschen; "The main reason I went with a wg variable is that getParamValue isn't available in mediawiki.js" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69276 [02:16:42] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [02:19:37] New review: Krinkle; "Placeholder -1 per conceptual problems pointed out on the bug." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/69276 [02:38:32] New review: Krinkle; "This configuration is currently entirely unused and not deployed. wikibugs is only in #mediawiki. Th..." [wikimedia/bugzilla/wikibugs] (master) - https://gerrit.wikimedia.org/r/54984 [02:51:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [03:04:33] Got a VE problem on enwiki fatal exceptions in due to "Hook VisualEditorHooks::onAddNewAccount failed to return a value", anyone around? [03:05:05] spagewmf: Someone is! [03:05:16] I don't know if that's helpful, but I could halp debug [03:05:44] Well, it's pretty self-explanatory, but I'm not sure what to revert [03:06:01] Oh, it's probably part of their A/B test, it'd be a shame to revert it [03:07:16] Hrm [03:10:09] I dunno what to revert, though, so not super helpful anyway [03:10:11] (sorry) [03:11:21] Looks like returning true would do it [03:15:05] spagewmf: I've submitted a two-line fix [03:15:12] spagewmf: https://gerrit.wikimedia.org/r/69277 [03:15:35] marktraceur, thanks, sorry superm401 and I are in #wikimedia-operations fixing away [03:23:34] New review: Ori.livneh; "> the API call adds a title key to the JSON (without "Schema:" namespace prefix) and gets rid of all..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [03:31:02] Hey there dan-nl! [03:31:54] dan-nl: Thanks for the extra coverage on Rasel160's patch, much appreciated :) [03:32:27] marktraceur: ah, np, it's not much, but every now and then i'm able to get a quick look at it [03:32:36] Indeed [03:33:48] marktraceur: are the two of you happy with the progress so far? [03:34:40] Pretty happy [03:34:46] You mean Rasel or Micru? :) [03:35:16] marktraceur: well, all of you :) [03:36:51] marktraceur: do you happen to know of any pages using the TemplateData extension on commons? [03:42:00] dan-nl: I put a draft of Information up [03:42:02] One sec [03:42:21] dan-nl: https://commons.wikimedia.org/wiki/Template:Information/sandbox/TemplateData [03:42:44] marktraceur: thanks! [03:42:47] Yup [03:54:00] dan-nl: Ta! [03:54:21] * marktraceur responds publicly because he likes public channels where possible [03:54:35] Change merged: jenkins-bot; [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [04:16:46] New patchset: Rfaulk; "fix. formatting." [sartoris] (master) - https://gerrit.wikimedia.org/r/69278 [04:17:07] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69278 [04:24:23] New review: Hiong3-eng5; "Since these new problems probably are Mediawiki related. Can you merge this if there are no more cor..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946 [05:33:33] Change merged: Mwalker; [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69154 [05:57:36] New review: Mwalker; "your on-wiki message actually had the info I was looking for -- I missed the ->convert() line. I'll ..." [mediawiki/extensions/CentralNotice] (master) C: 2; - https://gerrit.wikimedia.org/r/67629 [05:57:40] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/67629 [06:08:26] New patchset: RAN1; "Divide communitytwitter-access-error into sub-messages" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [06:18:41] New patchset: Wikinaut; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [06:21:53] New patchset: Mattflaschen; "Improve appearence of task toolbar on low width screens." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [06:31:36] New patchset: Spage; "Only new vertical format login and signup forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [06:32:07] New review: Spage; "I need position => top for the JS, but not for the CSS." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [06:52:18] New patchset: Nischayn22; "Add a way to make categories more require-looking" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/69284 [07:13:28] New patchset: Santhosh; "[WIP]Special page TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69285 [07:14:39] New patchset: Santhosh; "[WIP]Special page TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69285 [07:25:01] New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69286 [07:32:09] New patchset: Nikerabbit; "ULS to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69287 [07:33:45] New review: Mwjames; "Karsten could you review this change in order to merge this as soon as possible. Thanks" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [08:06:41] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69287 [08:08:04] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69286 [08:15:34] New review: Matmarex; "I haven't tested, though." [mediawiki/extensions/OpenStackManager] (master) C: 1; - https://gerrit.wikimedia.org/r/65421 [08:16:27] New patchset: Rfaulk; "add. config vars for path, user, and target." [sartoris] (master) - https://gerrit.wikimedia.org/r/69290 [08:16:43] New review: Matmarex; "(My comments on PS9 still stand.)" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [08:17:10] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/69290 [08:35:02] New patchset: Physikerwelt; "Replace SimpleXml by Mediawiki library" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [08:50:02] New review: Krinkle; "Principly against sniffing of this kind. This is going to be inconsistent and incomplete. We have de..." [mediawiki/tools/codesniffer] (master) C: -2; - https://gerrit.wikimedia.org/r/69090 [08:50:26] New patchset: Krinkle; "Implement DeprecatedGlobalSniff for $wgUser" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/69090 [08:55:08] New review: Kghbln; "Sorry it took me so long. Was not in during the last bunch of days." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/67609 [09:12:59] hi [09:14:12] ug [09:14:13] yo [09:16:11] New patchset: Pastakhov; "Add PCRE Functions (version 0.4.3)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67965 [09:17:58] New patchset: Jeroen De Dauw; "Improve TravisCI build script" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69291 [09:19:26] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67965 [09:20:57] New patchset: Mwjames; "SMW\Profiler encapsulates MediaWiki's (wfProfileIn/wfProfileOut)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69292 [09:23:27] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode exept for Firefox" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69293 [09:24:25] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67607 [09:26:44] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode exept for Firefox" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69293 [09:28:18] zeljkof: hey :-] [09:28:24] zeljkof: we got Math support on beta now! ( https://bugzilla.wikimedia.org/show_bug.cgi?id=47203 ) [09:28:33] hashar: great news! :) [09:29:09] not sure which tests can be written but at least the feature is around [09:29:23] we already have one test for it [09:29:26] just checking if it works at all [09:29:42] https://github.com/wikimedia/qa-browsertests/blob/master/features/math_readonly.feature [09:30:07] New review: J; "i was reading "-1 for Brian Wolf's inline comment on the i18n file" not as -1 for patch 2 but -1 fo..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [09:30:16] I will run the test on beta and if it works will enable it in the code [09:30:23] zeljkof: the source is going to be different though [09:30:27] And src for that img should come from //upload.wikimedia.org/math/ [09:30:29] that is for production [09:30:37] I will figure it out [09:30:57] we should probably change that url anyway [09:31:02] //upload.beta.wmflabs.org/math/0/4/9/049dc5a60b2b3315b2504c319f6fb8e1.png [09:31:10] http://en.wikipedia.beta.wmflabs.org/wiki/Math [09:31:11] a regexp will probably be a good solution [09:31:17] probably [09:31:31] something like /upload.*math/ :) [09:31:48] I will test the regexps and make one that makes sense [09:32:19] the only thing important is that there is an image and that we are pretty sure it is a valid image, not an error page [09:34:07] New patchset: Nikerabbit; "Turn edit tab to translate tab on translation pages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69162 [09:40:08] New review: Matmarex; "This is measuring bytes, not characters, and "a character is one byte" is only true for the 128 ASCI..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65139 [09:42:41] New review: Hashar; "Looking at the error log does not catch all occurrences, and I have yet to see how we can throw a de..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/69090 [09:42:47] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode exept for Firefox" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69293 [09:47:13] New patchset: Mwjames; "Display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [10:01:59] New patchset: Physikerwelt; "Enabling MathJaX in LaTeXML rendering mode except for Firefox" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/69298 [10:03:55] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [10:04:00] New review: Matthias Mullie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [10:05:44] New review: Physikerwelt; "This works fine... I think it can be also applied on the main branch." [mediawiki/extensions/Math] (LaTeXML); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69293 [10:05:45] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69293 [10:12:30] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69023 [10:17:31] New review: Physikerwelt; "I'm not sure if we really want this." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64527 [10:19:28] New review: J; "testing this with:" [mediawiki/extensions/TimedMediaHandler] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/68953 [10:35:45] New patchset: Physikerwelt; "(bug 43571) Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [10:37:59] New review: Physikerwelt; "This did not work..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65301 [10:38:32] New patchset: Santhosh; "Special page TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69285 [10:39:09] New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [10:45:31] New patchset: Physikerwelt; "(bug 43571) Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [10:48:42] New review: Physikerwelt; "@AlephNull" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [10:52:27] Change abandoned: Matmarex; "Whatever." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59604 [10:52:51] New patchset: J; "Tune Special:TimedMediaHandler" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [10:53:14] New review: J; "also caching getTranscodes query for 60 seconds now." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [11:11:22] New patchset: Physikerwelt; "(Bug 45194) Fix: Remove Bugfix that is now unnecessary" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69302 [11:12:18] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/69302 [11:21:19] what does LD window mean? [11:21:22] mwalker|away: ^ [11:22:52] lightning deploy [11:24:02] New patchset: Legoktm; "Log blacklist hits to Special:Log" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/69303 [11:26:42] New patchset: Legoktm; "Log blacklist hits to Special:Log" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/69303 [11:27:56] hoo: thanks [11:38:37] New patchset: Legoktm; "Log blacklist hits to Special:Log" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/69303 [11:41:19] New patchset: Legoktm; "Log blacklist hits to Special:Log" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/69303 [12:02:46] Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69117 [12:15:31] New review: Liangent; "For deployment ... Remember there's a core dependency." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/67629 [13:04:43] New patchset: Nischayn22; "Adds support for sorting Special:Properties by usage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306 [13:06:29] hey hashar [13:07:34] hashar, what do you think about https://gerrit.wikimedia.org/r/#/c/68309/ ? [13:07:52] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306 [13:08:27] MaxSem: it is in my review queue :) [13:09:06] curl | mwscript edit.php [13:09:07] hehe [13:09:14] sometime I feel like I am a mediawiki noob [13:09:29] MaxSem: maybe it can be made in Jenkins [13:09:51] and we can add it to https://integration.wikimedia.org/ci/view/Beta/ :-D [13:09:56] will think about it and let you know [13:11:23] New review: Nischayn22; "To manually test this append ?sort_by=usage_count DESC" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306 [13:16:54] New review: Mwjames; "TESTS?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69306 [13:18:13] New patchset: Rtdwivedi; "1. Separated index functions from pages. 2. Separated setting up editing system from the main class ProofreadPage. Change-Id: I0b841a32f2ea00b742d8e06e71984bc0d6edce42" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68861 [13:29:34] New review: Mwjames; "Let's wait with this change until I clean-up the SMW_SQLStore3_SpecialPageHandlers.php (which should..." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/69306 [13:31:48] New review: Mwjames; "In order to finish the work on the Collectors for unused/properties I'm going to merge this within t..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [13:55:55] New review: Matmarex; "Eh?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [14:16:05] New patchset: SuchABot; "Allow users to select preferred license for their contributions" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69274 [14:33:02] New patchset: SuchABot; "Better rounding for width, avoids pixelation in large displays" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69309 [14:34:44] New patchset: Alex Monk; "Pass along tagFilter to ContribsPager, it already expects it" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69153 [14:36:02] New review: Alex Monk; "Used by I6f4309bc" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/69153 [14:36:25] New patchset: Alex Monk; "Don't find AFT results if tagfilter set" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69152 [14:37:02] New review: Alex Monk; "Trying again... this time mentioning the bug" [mediawiki/extensions/ArticleFeedbackv5] (master) C: 2; - https://gerrit.wikimedia.org/r/69152 [14:38:48] New patchset: SuchABot; "Fix crash on Android 2.3 caused by missing method" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69310 [14:39:00] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69152 [14:39:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69153 [14:46:44] New patchset: SuchABot; "Remove Machine specific IML files" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69311 [14:51:27] New patchset: Anomie; "Make CentralAuth login more silent" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [14:56:34] New review: Brion VIBBER; "Pretty sure this is right thing to do. Cross them fingers!" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69311 [14:56:34] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69311 [14:57:55] New patchset: Anomie; "Make CentralAuth login more silent" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [14:57:56] New patchset: Anomie; "Remove $wgCentralAuthSilentLogin, defaulted to true" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/69312 [15:00:35] New review: Brion VIBBER; "In theory getByteCount() is a convenience method that gives the same result as the other calculation..." [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69310 [15:00:35] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69310 [15:04:26] New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102 [15:06:49] New patchset: Brion VIBBER; "Better rounding for width, avoids pixelation in large displays" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69309 [15:11:23] New review: Brion VIBBER; "Hm, it doesn't seem to work. I added a log line to check what I'm getting:" [apps/android/commons] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/69309 [15:12:25] New patchset: Brian Wolff; "Fix handling of height parameter in TMH." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68953 [15:12:54] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [15:14:58] New review: Brian Wolff; "Sorry, looks like I didn't test this one sufficiently (Or at all apparently. Although at the time I'..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68953 [15:16:46] New patchset: Brion VIBBER; "Better rounding for width, avoids pixelation in large displays" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69309 [15:18:47] New review: Brion VIBBER; "Confirmed working on my Kindle Fire 1st-gen" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69309 [15:18:47] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69309 [15:28:29] New patchset: Alex Monk; "Cleanup JS" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69314 [15:29:03] Nikerabbit: uga? [15:29:13] okay, nevermind [15:29:21] brion: yeah, i am pretty sure that the XML will inteprept it [15:29:22] fast [15:30:01] Nemo_bis: or slow [15:30:10] YuviPanda: ploppa [15:30:22] Nikerabbit: hmm, any idea how we can handle nonbreakingspace in twn? [15:30:37] I've used the unicode character in xml, also mentioned it in qq [15:30:41] (not merged yet) [15:31:04] trying to ruin my day?!? [15:31:12] New patchset: Brion VIBBER; "Allow users to select preferred license for their contributions" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69274 [15:31:21] actually it is merged [15:31:23] Nikerabbit: https://gerrit.wikimedia.org/r/#/c/69309/ [15:31:25] Nikerabbit: :( [15:31:31] anyway, I do not think there is anything better than usimg some kind of symbol for it [15:31:57] wrong patch? [15:32:31] sigh [15:32:43] okoh [15:32:43] yes [15:32:43] https://gerrit.wikimedia.org/r/#/c/69274/3/commons/res/values/strings.xml [15:32:43] wrong patch [15:32:50] yes that is the one [15:32:56] yeah [15:32:58] fugly [15:33:05] so that unicode literal is bad for twn [15:33:07] and we should use another char [15:33:11] and do a .replace in code? [15:33:14] I'm concerned a translator will mistake where the escape ends and the text starts [15:33:28] but not sure if it is worth any special handling [15:33:41] Nikerabbit: right. [15:33:45] so I'll just... leave it as is? [15:34:16] New patchset: Daniel Kinzler; "(bug 49264) Handle corrupt data values gracefully." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68952 [15:34:33] YuviPanda: the path of least resistance [15:34:41] okay [15:34:44] * YuviPanda leaves it as is [15:34:53] are CC license names usually translated? [15:35:01] perhaps do a check at some point to see how many translators have messed it up [15:35:13] YuviPanda: they usually have localised names [15:35:15] New review: AlephNull; "I'm pretty sure it was rebased correctly. When I checkout the patch everything works (i.e. the bug d..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [15:35:38] Nikerabbit: alright. sounds good. [15:35:39] ty [15:35:44] CC-Nimeä-Ei muutoksia-Epäkaupallinen (CC BY-NC-ND) [15:38:21] New patchset: Anomie; "Improve ./configure search for lua" [mediawiki/php/luasandbox] (master) - https://gerrit.wikimedia.org/r/69315 [15:43:45] New patchset: Brion VIBBER; "Allow users to select preferred license for their contributions" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69274 [15:44:06] New review: Brion VIBBER; "Patchset 4 fixes strings.xml issues" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69274 [15:44:07] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69274 [15:44:15] New review: Brian Wolff; "No one has complained... +2" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62337 [15:47:34] New patchset: Mwjames; "Display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [15:48:54] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [15:53:10] New review: Anomie; "api/ApiNovaInstance.php looks good to me. Haven't reviewed the rest yet." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [15:54:08] yay thanks bawolff [15:54:38] I had just resisted pinging you because it wasn't a week yet :) [15:54:38] :) [15:54:56] * bawolff paitently awaits assination by some obscure wiki who doesn't like our docs :P [15:57:55] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53968 [15:57:56] they still can customise the link ^^ [16:00:35] New patchset: Mwjames; "Display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [16:04:56] Is there any way to see which wikis have a specific page title... [16:08:26] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [16:09:35] bawolff: On WMF? [16:09:42] yes [16:09:59] With database access (like on TS or tool labs) or via API? [16:10:24] Preferably something where I don't have to write my own script to check 758 different sites [16:10:35] but api or db is fine [16:18:19] bawolff: In bash: https://toolserver.org/~hoo/stuff/doesExist.sh [16:18:34] that *should* work [16:18:35] thanks :) [16:19:46] Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68953 [16:20:03] Hmm, I'm looking at a MW namespace page that has a default, so it would give a 200 [16:20:52] bawolff: I ran into a similar problem. Try action=raw, it returns 404 if the message has not been overridden [16:21:02] cool [16:21:06] I consider that a bug (action=view returning things differently from raw) but people disagree [16:23:43] action=raw is obsolete, use the api :) [16:26:29] New patchset: Njw; "Use default mediawiki list formatting, and correct padding of top menu items" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69319 [16:35:29] New review: Mwjames; "Karsten could you verify this change before I'll do a rebase to merge this change?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [16:35:43] Yippie, build fixed! [16:35:43] Project browsertests-en.wikipedia.org-linux-chrome build #131: FIXED in 4 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/131/ [16:36:55] New review: Kghbln; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/67396 [16:36:59] Nemo_bis: I sent an email to wikitech-ambassadors mentioning the change [16:38:03] New patchset: Njw; "Use default mediawiki list formatting, and correct padding of top menu items" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69319 [16:39:42] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [16:42:37] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [16:44:47] New review: Kghbln; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [16:48:38] bawolff: ohnoes now wikimania2005.wikimedia.org community will complain and kill us [16:49:44] :P [16:51:07] Not to mention nostalgia.wikipedia.org - We don't want to mess with those old timers hanging out at the locked wiki [16:53:55] bawolff: especially as they must be as strong as Ents [16:54:13] * Nemo_bis repairs in the cellar [16:58:48] New patchset: Mwjames; "SMW\Profiler encapsulates MediaWiki's (wfProfileIn/wfProfileOut)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69292 [16:59:08] New patchset: Mwjames; "SMW\JsonParameterFormatter to be used in #set and #subobject" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68950 [17:02:03] New patchset: Rtdwivedi; "1. Separated index functions from pages. 2. Separated setting up editing system from the main class ProofreadPage. Change-Id: I0b841a32f2ea00b742d8e06e71984bc0d6edce42" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68861 [17:02:03] New patchset: Rtdwivedi; "Separated data fetching from presentation and data manipulation from the page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68204 [17:07:58] New patchset: Njw; "Several small style tweaks" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69319 [17:09:24] New review: Rtdwivedi; "I just found out that I have been testing with the wrong copy of the extension. There are mistakes." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68861 [17:14:34] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [17:18:01] <^demon> qchris: "Why account_group_names and account_group_id table?" makes me laugh. [17:18:13] New review: Raimond Spekking; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:18:19] :-)) [17:19:30] ^demon: Better not tell anyone what we are running on... [17:20:26] <^demon> qchris: The misinformation about MyISAM/InnoDB on the issue tracker annoys me. [17:20:45] <^demon> Basically every MySQL bug has someone chiming in saying "Use MyISAM instead" [17:21:08] New patchset: Alex Monk; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [17:21:26] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:21:35] Gerrit people just do not like MySQL. [17:21:52] If anyone had doubts before, Shawn made it clear. [17:21:57] New patchset: Nemo bis; "Correct translators list on CREDITS file" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [17:22:07] <^demon> qchris: Maybe we should use a real database like H2 ;-) [17:22:15] We can also find this in code in many places. (Not phrased so clearly though) [17:22:59] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:23:04] ^demon: Yes, we totally should. We threw away maven, will throw away gwt, lets throw away MySQL as well. And let's also not use browsers. There is wget, isn't it :-)) [17:23:39] <^demon> To be fair, Shawn is raising a valid point. Making an application totally database agnostic is very hard, so you have to cut corners somewhere. [17:23:43] <^demon> MW is certainly guilty of this. [17:23:49] But more seriously, gerrit is moving away from the db. More and more stuff is coming into the repos themselves. so maybe we do not need any db at all sooner or later. [17:24:39] New review: Raimond Spekking; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:24:56] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [qa/browsertests] (refs/meta/config) - https://gerrit.wikimedia.org/r/69323 [17:25:02] Yes, database abstraction is hard. And I agree with him that's it's a pain to support more than one database. [17:25:22] But lately his comments getting less and less helpfull :-/ [17:25:51] Change merged: Krinkle; [qa/browsertests] (refs/meta/config) - https://gerrit.wikimedia.org/r/69323 [17:26:03] <^demon> Indeed. [17:29:55] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:38:53] New patchset: Mwalker; "Add Tabs to Console Log Output" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69324 [17:41:34] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [17:42:26] Change merged: jenkins-bot; [mediawiki/php/luasandbox] (master) - https://gerrit.wikimedia.org/r/69315 [17:43:56] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63572 [17:57:40] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67841 [17:58:29] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [18:00:26] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62808 [18:00:59] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [18:02:46] New patchset: Mattflaschen; "Improve appearence of task toolbar on low width screens." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [18:03:28] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [18:05:01] New patchset: SuchABot; "Add icons to menu items (Gingerbread support)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69327 [18:06:28] New review: Mattflaschen; "This is on piramido for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/69282 [18:07:23] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [18:07:30] marktraceur: ^^ huzzah! [18:07:52] Woo [18:08:20] Ryan_Lane: Is that all, or just one? [18:08:30] just one [18:08:33] 4 left to go [18:09:02] Heh [18:10:06] I'm working on 60783 next :) [18:11:44] New review: Brion VIBBER; "Screenshot of new icon-laden menu :D" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69327 [18:11:44] Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69327 [18:12:08] New patchset: Mwalker; "Multiply Capture Amount by 100!" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69328 [18:12:45] New patchset: Kaldari; "Update PageTriage, Echo, and ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69329 [18:13:03] New patchset: Mwjames; "i18n and patchwork messages !!!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69330 [18:14:21] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/69328 [18:15:36] New patchset: Bsitu; "Update Echo, ArticleFeedbackv5, PageTriage to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69331 [18:18:46] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [18:18:46] New review: Spage; "I'm fine with the whitespace reduction and adding title, I was just noting the changes. I'll try to ..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [18:19:11] New review: RAN1; "Here's my question, is it possible from a TranslateWiki standpoint to simply rearrange the translati..." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/69275 [18:20:30] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69331 [18:21:15] New patchset: Ryan Lane; "Show more informative instance status" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65269 [18:25:53] New review: Swalling; "Works well down to about 850px of width." [mediawiki/extensions/GettingStarted] (master) C: 1; - https://gerrit.wikimedia.org/r/69282 [18:27:29] New review: Mwjames; "ああ～超イライラしてる。俺にはこのことも超苦手だ。" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69330 [18:30:43] ori-l: so, in a comment you mentioned we should be using a JS MVC [18:30:51] ori-l: is MW core using one? any other extensions? [18:31:17] I'm not in disagreement, but I'd prefer not to be the guinea pig, especially since my JS skills aren't the strongest [18:31:23] Ryan_Lane: the pattern or some library implementation? [18:31:35] either [18:31:56] the pattern, yeah, to varying degrees. But I see where you're coming from. ah. IIRC I did not attach a negative score to my review for that reason. [18:32:01] preferably a library, because not invented here syndrome sucks [18:32:05] yeah :) [18:32:28] I'm fine for refactoring our JS at some point [18:32:37] And I did not +2 because there were a couple of concrete unaddressed items from previous reviewers [18:32:48] I definitely wanted to get these changes in. it's a tangled web of changes now [18:33:19] OK, I'll have a look again later today [18:33:23] I think most of the changes are ready for review [18:33:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69269 [18:33:31] and I merged the 1st today [18:33:37] I was up until 5 dealing with the account snafu so I'm still a bit out of it [18:33:43] ewwww [18:33:48] sorry to hear that [18:33:58] if matmarex comes on today, I can get him to review [18:34:01] since he'd be following up [18:34:13] I tested that Special:NovaAddress ajax-y interface commit earlier, but IIRC all it did was make the deassociate link ajax-y [18:34:30] Krenair: that's all its supposed to do :) [18:34:43]