[00:22:28] <gerrit-wm>	 New patchset: Brian Wolff; "Add audio transcodes to Special:TimedMediaHandler." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69023
[00:26:35] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #61: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/61/
[00:59:27] <bawolff>	 Anyone know if thumb_handler.php is generally broken, or is it just my local set up...
[01:01:30] <James_F>	 bawolff: It's in core, so it being broken is highly likely. :-)
[01:01:59] <bawolff>	 Damn core, we should just get rid of it
[01:02:08] <bawolff>	 You know how many bugs have been reported against core?
[01:02:19] <bawolff>	 thousands
[01:02:42] <James_F>	 Exactly.
[01:02:49] <James_F>	 Like that feedback bug. :-)
[01:04:27] <bawolff>	 Also, Jidinni said something about it not working well with lynx...
[01:14:56] <Reedy>	 bawolff: thumb.php was working locally when I tried it no so long ago with Jarrys svg localisation stuff
[01:15:38] <bawolff>	 Were you following the instructions for setting it up as a 404 handler at Manual:Thumb.php ?
[01:15:55] <Reedy>	 I can't remember. I set it up for proofreadpage
[01:16:09] <Reedy>	 http://p.defau.lt/?TrGBP9ebqLakcjf_nVtmwQ
[01:16:14] <bawolff>	 Seems like the sticking point currently in my setup is that it fails to extract path_info properly
[01:16:58] <bawolff>	 ok, that's what's listed as the "old" way in the docs
[01:17:07] <bawolff>	 which avoids the path_info issue
[01:33:03] <Reedy>	 I can try it later and see if I have any luck
[01:36:08] <wmf-selenium-bot>	 Yippie, build fixed!
[01:36:08] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #312: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/312/
[01:42:32] <gerrit-wm>	 New patchset: Brian Wolff; "thumb_handler.php doesn't seem to extract path_info correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69025
[01:42:38] <bawolff>	 Reedy: --^ Is my fix for the issue
[01:48:17] <gerrit-wm>	 New review: Brian Wolff; "I can confirm that I tested this, and it does indeed work (after hacking thumb.php to accept PATH_IN..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/69019
[02:08:10] <gerrit-wm>	 New review: MarkTraceur; "A few comments." [mediawiki/extensions/UploadWizard] (master) C: -1;  - https://gerrit.wikimedia.org/r/66561
[03:02:39] <gerrit-wm>	 New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211
[03:05:08] <gerrit-wm>	 Published patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211
[03:07:19] <gerrit-wm>	 New patchset: Brian Wolff; "Make thumb_handler.php use MediaHandler::parseParamString" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69027
[03:08:43] <gerrit-wm>	 New review: Brian Wolff; "Note, I've also submitted https://gerrit.wikimedia.org/r/#/c/69027/ , which if accepted would make t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69019
[03:21:50] <gerrit-wm>	 New patchset: Brian Wolff; "Make thumb_handler.php use MediaHandler::parseParamString" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69027
[03:22:32] <gerrit-wm>	 New review: Brian Wolff; "PS2: Call hook first. TMH has a broken parseParamString implementation, version 1 of this patch brok..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69027
[03:25:44] <gerrit-wm>	 New review: Brian Wolff; "When doing a purge of a test FLAC file I got the following warnings (May or may not be this commit, ..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[04:39:17] <gerrit-wm>	 New patchset: Santhosh; "Validate imeId before rendering" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69028
[04:47:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69011
[04:50:05] <gerrit-wm>	 New patchset: Ori.livneh; "Default output URI should be 'stdout://'" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69029
[04:50:05] <gerrit-wm>	 New patchset: Ori.livneh; "Pretty-print when stdout is a tty; drop 'util'" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69030
[04:58:29] <gerrit-wm>	 New review: Nischayn22; "(1 comment)" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/68942
[05:01:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68839
[05:04:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69029
[05:04:57] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/69030
[05:17:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68326
[07:28:10] <gerrit-wm>	 New review: Nikerabbit; "Seems to work, but not on preview" [mediawiki/extensions/PageLanguage] (master) C: -1;  - https://gerrit.wikimedia.org/r/68852
[07:59:55] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69031
[08:18:22] <gerrit-wm>	 New review: Santhosh; "Agreed that the order of tabs in language settings were random  depending on which module get regist..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2;  - https://gerrit.wikimedia.org/r/68816
[08:18:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816
[08:21:36] <gerrit-wm>	 New patchset: Liangent; "Initial version of the extension" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[08:46:55] <gerrit-wm>	 Change abandoned: Nischayn22; "Meh" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/67090
[08:52:58] <gerrit-wm>	 New patchset: Santhosh; "Disable IME also in blacklisted browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69032
[09:01:29] <gerrit-wm>	 New patchset: Nischayn22; "use mw.Api() instead of ajax" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61351
[09:02:46] <gerrit-wm>	 New review: Kipcool; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[09:09:23] <gerrit-wm>	 New patchset: Santhosh; "Disable IME also in blacklisted browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69032
[09:10:08] <gerrit-wm>	 New review: Santhosh; "ok, so will address these comments in upstream." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1;  - https://gerrit.wikimedia.org/r/69031
[09:18:03] <gerrit-wm>	 New patchset: Nischayn22; "Use edit summaries when posting to user talk pages." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/69033
[09:19:34] <gerrit-wm>	 New patchset: Santhosh; "Disable Webfonts too for blacklisted browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69034
[09:20:46] <gerrit-wm>	 Change abandoned: Nischayn22; "(no reason)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/62480
[09:26:34] <gerrit-wm>	 New review: Nischayn22; "Tested manually, works as desired." [mediawiki/extensions/SemanticMediaWiki] (master); V: 2 - https://gerrit.wikimedia.org/r/65681
[09:29:03] <gerrit-wm>	 Change merged: Nischayn22; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681
[09:30:54] <gerrit-wm>	 Change abandoned: Hashar; "(no reason)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68564
[09:31:01] <gerrit-wm>	 Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68697
[09:31:08] <gerrit-wm>	 Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698
[09:31:13] <gerrit-wm>	 Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68699
[09:31:57] <gerrit-wm>	 New patchset: Nikerabbit; "Disable IME too in blacklisted browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69032
[09:32:53] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69032
[09:33:04] <gerrit-wm>	 New patchset: Nikerabbit; "Disable Webfonts too for blacklisted browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69034
[09:33:45] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69034
[09:43:22] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69028
[09:43:33] <gerrit-wm>	 New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566
[09:45:01] <gerrit-wm>	 New review: Hashar; "Sync with upstream patch at https://review.openstack.org/#/c/32965/ I have updated the option name: ..." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566
[10:42:04] <gerrit-wm>	 New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/66140
[10:44:33] <gerrit-wm>	 New patchset: SuchABot; "Add .gitreview" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69050
[10:45:59] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69050
[10:53:28] <hashar>	 YuviPanda: hey :)
[10:53:34] <YuviPanda>	  ohai hashar
[10:53:43] <hashar>	 YuviPanda: the jenkins job for testing out apps/android/common is deployed :-)
[10:53:51] <YuviPanda>	 weee
[10:53:55] <YuviPanda>	 i think i saw the bug report
[10:53:56] <YuviPanda>	 update
[10:54:01] <hashar>	 YuviPanda: I need a change in upstream Jenkins Job Builder though, so my conf change is not merged in yet
[10:54:07] <YuviPanda>	 oh
[10:54:09] <hashar>	 YuviPanda: but it is definitely under my radar
[10:54:21] <YuviPanda>	 alright!
[10:54:22] <hashar>	 and the job has been deployed anyway :)
[10:54:26] <YuviPanda>	 but it does build from gerrit now
[10:54:27] <YuviPanda>	 yeah :)
[10:54:27] <YuviPanda>	 so
[10:54:33] <YuviPanda>	 hashar: thanks hashar :)
[10:55:01] <hashar>	 YuviPanda: any person whitelisted will have the build to run for them
[10:55:10] <hashar>	 YuviPanda: and you can get the changes merged by Jenkins using CR+2
[10:55:13] <YuviPanda>	 just the standard whitelist, right?
[10:55:17] <hashar>	 yeah
[10:55:27] <hashar>	 will close the bug whenever upstream has merged my change
[10:55:31] <YuviPanda>	 wonderful
[11:11:05] <gerrit-wm>	 New review: Siebrand; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649
[11:23:23] <gerrit-wm>	 New review: VitaliyFilippov; "Someone... please merge this patch...." [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/25628
[11:27:19] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69031
[11:28:19] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add phpunit config file, test bootstrap and TravisCI config" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69057
[11:28:30] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69057
[11:31:05] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Doc tweak" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69060
[11:31:12] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69060
[11:33:16] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Path fix in Travis config" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69062
[11:33:28] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69062
[11:36:06] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fix path in Travis config" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69063
[11:36:27] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69063
[11:40:53] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/66902
[11:44:21] <gerrit-wm>	 New patchset: Nikerabbit; "Added a message for sandboxed users" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/69064
[11:45:04] <gerrit-wm>	 New patchset: Nikerabbit; "Added a message for sandboxed users" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/69064
[11:46:05] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Update TravisCI build config to fully use composer" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69065
[11:46:14] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69065
[11:49:51] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove TravisCI email notifications" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69066
[11:50:11] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69066
[11:51:18] <gerrit-wm>	 New patchset: Nikerabbit; "Update formatting" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649
[11:51:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649
[12:00:30] <gerrit-wm>	 New patchset: Hashar; "beta: job to recompile texvc (Math)" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69068
[12:04:11] <gerrit-wm>	 New patchset: Hashar; "Math merges updates texvc on beta" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69069
[12:04:12] <gerrit-wm>	 New patchset: Hiong3-eng5; "SQLite Compatibility" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[12:04:36] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69069
[12:06:10] <gerrit-wm>	 New review: Hashar; "tested out on https://integration.wikimedia.org/ci/job/beta-recompile-math-texvc/ seems to work fine." [integration/jenkins-job-builder-config] (master) C: 2;  - https://gerrit.wikimedia.org/r/69068
[12:06:11] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69068
[12:09:11] <gerrit-wm>	 New patchset: Nikerabbit; "Added a message for sandboxed users" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/69064
[12:12:53] <gerrit-wm>	 New review: Hiong3-eng5; "can you check this. Is it just configuration problem?" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[12:19:04] <gerrit-wm>	 New patchset: Mwjames; "Travis + @test Settings::newFromGlobals" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69071
[12:22:09] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69071
[12:25:21] <gerrit-wm>	 New review: Siebrand; "i18n/L10n review done." [mediawiki/extensions/TwnMainPage] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/69064
[12:26:27] <gerrit-wm>	 New review: Siebrand; "i18n/L10n reviewed." [mediawiki/extensions/PageTriage] (master) C: 1;  - https://gerrit.wikimedia.org/r/69033
[12:30:38] <gerrit-wm>	 New review: Siebrand; "i18n/L10n review done. Also a few other comments left inline." [mediawiki/extensions/PageLanguage] (master) C: -1;  - https://gerrit.wikimedia.org/r/68852
[12:32:23] <gerrit-wm>	 New review: Siebrand; "i18n/L10n is similar to what's already being used, so no comments. -1 for Brian Wolf's inline commen..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/68642
[12:34:56] <gerrit-wm>	 Change abandoned: Yuvipanda; "Testing, again." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598
[12:35:19] <gerrit-wm>	 New review: Siebrand; "Per earlier +1." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/63274
[12:35:43] <gerrit-wm>	 New review: Siebrand; "i18n/L10n changes are trivial." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/64565
[12:37:17] <gerrit-wm>	 New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/65478
[12:37:31] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add composer file" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69072
[12:37:41] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69072
[12:38:16] <gerrit-wm>	 New patchset: Nikerabbit; "Remove Special:QueryCreator" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69073
[12:41:15] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69074
[12:42:31] <gerrit-wm>	 New patchset: Mwjames; "Travis + @test CacheHandler::newFromId" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69075
[12:45:34] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69075
[12:51:28] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add Wikibase as dependency in composer file" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69076
[12:51:53] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69076
[12:53:44] <gerrit-wm>	 New review: Zfilipin; "I am not a PHP developer and I do not know if anybody uses this code, but if it is not used I vote f..." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/68729
[13:00:23] <gerrit-wm>	 New patchset: Liangent; "Initial version of the extension" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[13:02:00] <gerrit-wm>	 New patchset: Mwjames; "Travis + @test Settings::newFromGlobals Part II" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69078
[13:02:09] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69031
[13:02:31] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69074
[13:02:48] <gerrit-wm>	 New review: Liangent; "(1 comment)" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[13:02:53] <gerrit-wm>	 New review: Liangent; "(1 comment)" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[13:04:32] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add gitignore file" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69079
[13:04:33] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added PHPUnit config file and improved bootstrapping code" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69080
[13:04:33] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add TravisCI config" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69081
[13:05:03] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add strict settings to TravisCI config" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69082
[13:05:12] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69079
[13:05:19] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69080
[13:05:24] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69078
[13:05:30] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/69081
[13:05:41] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69082
[13:07:56] <gerrit-wm>	 New patchset: Liangent; "Initial version of the extension" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[13:08:25] <gerrit-wm>	 New review: Liangent; "PS4 contains an attempt to resolve preview issue." [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852
[13:12:26] <gerrit-wm>	 New review: MZMcBride; "As I said on bug 49631, PageTriage is adding a new section to a talk page. It should be using sectio..." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/69033
[13:13:12] <gerrit-wm>	 New review: Siebrand; "i18n/L10n: Trivial changes." [mediawiki/extensions/SemanticMediaWiki] (master) C: 1;  - https://gerrit.wikimedia.org/r/69073
[13:15:18] <gerrit-wm>	 New patchset: Mwjames; "Travis + @test Settings::newFromGlobals Part III" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69085
[13:15:28] <gerrit-wm>	 New patchset: Luis Felipe Schenone; "Uploading the basic extension files" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[13:16:18] <gerrit-wm>	 New review: Siebrand; "Scenario in uls_ime_steps.rb looks good to me." [qa/browsertests] (master) C: 1;  - https://gerrit.wikimedia.org/r/68934
[13:18:25] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69085
[13:21:26] <gerrit-wm>	 New patchset: Luis Felipe Schenone; "Uploading the basic extension files" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[13:21:36] <gerrit-wm>	 New review: Siebrand; "Quick L10n scan. Left a few comments. Incomplete i18n/L10n review." [mediawiki/extensions/UIFeedback] (master) C: -1;  - https://gerrit.wikimedia.org/r/50004
[13:23:38] <gerrit-wm>	 New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Hovergallery] (master) C: -1;  - https://gerrit.wikimedia.org/r/69086
[13:29:47] <gerrit-wm>	 New review: Siebrand; "i18n/L10n review and some other inline comments." [mediawiki/extensions/Hovergallery] (master) C: -1;  - https://gerrit.wikimedia.org/r/69086
[13:32:53] <Nikerabbit>	 hashar: is your bbq perhaps in the wrong calendar?
[13:33:48] <hashar>	 Nikerabbit: should be in my wikimedia provided calendar
[13:34:29] <gerrit-wm>	 New patchset: Mwjames; "Travis + @test Settings::newFromGlobals Part IV" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69088
[13:36:08] <gerrit-wm>	 New patchset: Hashar; "$wgUser is deprecated, warn about it" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/69090
[13:37:28] <Nikerabbit>	 hashar: I see it in engineering
[13:37:41] <gerrit-wm>	 New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968
[13:38:24] <hashar>	 Nikerabbit: I don't have it there sorry
[13:38:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69088
[13:40:04] <gerrit-wm>	 New review: Siebrand; "L10n review. Left inline comments. Why does this file start with a lower case letter? Our convention..." [mediawiki/extensions/Ads] (master) C: -1;  - https://gerrit.wikimedia.org/r/68855
[13:40:26] <Nikerabbit>	 hashar: unless it has something to do with mails broken, I don't understand why we would see different things
[13:40:45] <hashar>	 Nikerabbit: what is the even title ?
[13:42:59] <gerrit-wm>	 New patchset: Siebrand; "Add gender-neutral pronouns and correct grammar" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/68661
[13:46:00] <Nikerabbit>	 small bunny eats a carrot
[13:46:26] <gerrit-wm>	 New patchset: Mwjames; "Replace is_array/is_string with a more performant approach" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68944
[13:46:29] * Nemo_bis  run out of them

[13:50:17] <gerrit-wm>	 New review: Njw; "Great, I'm happy with this now, merging." [mediawiki/skins/erudite] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68212
[13:50:18] <gerrit-wm>	 Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212
[13:51:47] <gerrit-wm>	 New review: Nikerabbit; "Just noting that this is not always possible and can introduce unexpected bugs, see" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/69090
[13:55:00] <gerrit-wm>	 New patchset: Nemo bis; "$wgUser is deprecated, warn about it" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/69090
[13:55:37] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added COPYING README and INSTALL" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69093
[13:56:13] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69093
[13:57:34] <gerrit-wm>	 New patchset: Mwjames; "Display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609
[13:58:00] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fix markup in README" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69094
[13:59:11] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Improve markup in README file" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69095
[13:59:18] <gerrit-wm>	 New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609
[13:59:30] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69094
[13:59:35] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69095
[14:00:33] <YuviPanda>	 ^demon: the GitHub<->Gerrit bot now replicates comments / abandons / merges/ reopens back to GitHub from Gerrit :)
[14:00:52] <YuviPanda>	 need to do inline comments, and then the other way around soon though
[14:01:29] <^demon>	 I saw :)
[14:01:32] <YuviPanda>	 ^demon: there's also a redis based reliable-delivery queue on tools-labs for other people who want to write code
[14:01:37] <YuviPanda>	 based on gerrit stream-events
[14:02:05] <^demon>	 Oh that's sweet
[14:02:45] <YuviPanda>	 ^demon: need to document it, but the bootstrapping code is like 10 lines of python. Similar sized in all languages
[14:02:55] <YuviPanda>	 let me know if you have any ideas on how it can be put to use :)
[14:03:20] <YuviPanda>	 I'd be happy to write more tools :)
[14:08:07] <Nikerabbit>	 YuviPanda: you there in about 1h20mins?
[14:08:16] <YuviPanda>	 Nikerabbit: yes
[14:08:29] <YuviPanda>	 Nikerabbit: I thought i had setup invites, apparently forgotten it :(
[14:08:30] <YuviPanda>	 can you?
[14:09:20] <gerrit-wm>	 New review: Mwjames; "I haven't looked at it in detail but guessing from (Special:QueryCreator) which is implemented as [1..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/69073
[14:10:23] <Nikerabbit>	 YuviPanda: please review
[14:11:05] <YuviPanda>	 Nikerabbit: also invite aharoni
[14:11:16] <YuviPanda>	 okay
[14:11:18] <YuviPanda>	 i can add apparently
[14:11:19] <YuviPanda>	 i added
[14:18:07] <gerrit-wm>	 New patchset: Luis Felipe Schenone; "Uploading the basic extension files" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[14:18:20] <YuviPanda>	 ori-l: can you take a look at the redis stuff on https://github.com/yuvipanda/SuchABot/blob/master/suchabot/github-sync.py when you can? Just a cursory review, perhaps
[14:18:28] <YuviPanda>	 ori-l: specifically I'm wondering if I'm using brpop correctly
[14:18:40] <YuviPanda>	 or if I should be using timeouts
[14:21:01] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added INSTALL, README and COPYING" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69096
[14:21:19] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69096
[14:24:17] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Improve doc layout" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69097
[14:24:32] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69097
[14:25:31] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Improve doc layout" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69098
[14:25:37] <gerrit-wm>	 New patchset: Luis Felipe Schenone; "Uploading the basic extension files" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[14:25:50] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/69098
[14:34:23] <gerrit-wm>	 New patchset: Siebrand; "Remove unused variable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69100
[14:34:23] <gerrit-wm>	 New patchset: Siebrand; "Initialise possibly undefined variables" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69101
[14:34:24] <gerrit-wm>	 New patchset: Siebrand; "Update docs and type hints" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69102
[14:36:48] <gerrit-wm>	 New patchset: Siebrand; "Update indentation and newlines" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69103
[14:39:28] <gerrit-wm>	 New patchset: Siebrand; "Simplify return statement" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69104
[14:40:54] <gerrit-wm>	 New review: MarkTraceur; "Some notes for dan-nl" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561
[14:45:04] <gerrit-wm>	 New patchset: Siebrand; "Remove last bits of MediaWiki 1.19 compatibility" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69105
[14:45:12] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Improve README file" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69106
[14:45:26] <gerrit-wm>	 New patchset: Siebrand; "Update version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69107
[14:45:48] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove obsolete dependencies.txt file" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69108
[14:45:57] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69106
[14:46:03] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69108
[14:47:53] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove dead global" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69109
[14:48:28] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69109
[14:49:08] <gerrit-wm>	 New patchset: Siebrand; "Coding style updates" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69110
[14:51:24] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Add release notes and bump version to 0.4" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69111
[14:51:46] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69111
[14:55:10] <gerrit-wm>	 New review: Siebrand; "This is slightly inconsistent with other areas of our code where we use "themselves" which is synony..." [mediawiki/extensions/EducationProgram] (master) C: 2;  - https://gerrit.wikimedia.org/r/68661
[14:55:27] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/68661
[14:55:57] <gerrit-wm>	 New patchset: Nemo bis; "Reduce usage of globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330
[14:56:40] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Increment version to 0.5 alpha" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69113
[14:57:12] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69113
[14:59:20] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Put correct file extension for RELEASE NOTES" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69114
[14:59:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69114
[15:00:21] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Update release notes" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69115
[15:00:42] <gerrit-wm>	 New review: Siebrand; "(1 comment)" [mediawiki/extensions/Hovergallery] (master) C: -1;  - https://gerrit.wikimedia.org/r/69086
[15:00:43] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69115
[15:03:06] <gerrit-wm>	 New review: Siebrand; "+1 per earlier review." [mediawiki/extensions/Echo] (master) C: 1;  - https://gerrit.wikimedia.org/r/63572
[15:05:26] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Update DataModel min version" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69116
[15:05:34] <gerrit-wm>	 New patchset: Luis Felipe Schenone; "Uploading the basic extension files" [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[15:06:05] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/69116
[15:07:44] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69100
[15:09:48] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Make EntityId->getPrefix private" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/69117
[15:11:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69104
[15:11:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69103
[15:11:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69102
[15:11:20] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69101
[15:14:00] <gerrit-wm>	 New patchset: SuchABot; "Add a progress bar to display upload progress, instead of just text" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69118
[15:14:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69107
[15:14:32] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69110
[15:14:33] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/69105
[15:20:18] <gerrit-wm>	 New review: Luis Felipe Schenone; "No Siebrand, thanks to you all for reviewing my code!" [mediawiki/extensions/Hovergallery] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69086
[15:20:18] <gerrit-wm>	 Change merged: Luis Felipe Schenone; [mediawiki/extensions/Hovergallery] (master) - https://gerrit.wikimedia.org/r/69086
[15:21:24] <gerrit-wm>	 New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164
[15:21:33] <gerrit-wm>	 New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164
[15:24:06] <YuviPanda>	 Nikerabbit: see you in 10 mins.
[15:41:10] <gerrit-wm>	 New review: Jarry1250; "Seems functional, though I guess there may be some performance questions (not sure)." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/69027
[16:16:41] <gerrit-wm>	 New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[16:17:09] <gerrit-wm>	 New review: J; "Brian, your undefined warning should be gone now." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[16:21:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68814
[16:31:55] <gerrit-wm>	 New review: Brian Wolff; "Still getting:" [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/68642
[16:32:24] <gerrit-wm>	 Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998
[16:38:07] <gerrit-wm>	 New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[16:46:05] <gerrit-wm>	 New review: Brian Wolff; "Confirmed no more warnings." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[16:52:03] <gerrit-wm>	 New review: J; "see Siebrand's comment about the qqq messages, this message is in line with the other messages." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[16:55:49] <AaronSchulz>	 ^demon: https://gerrit.wikimedia.org/r/#/c/69022/
[16:56:32] <gerrit-wm>	 New patchset: Yaron Koren; "Fix for '_str' property type going away in SMW 1.9" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/69123
[16:56:54] <bawolff>	 siebrand: Just to clarify, on change 68642 - were you agreeing with my comment or disagreeing with it?
[16:57:12] <siebrand>	 bawolff: agreeing, so J misunderstood.
[16:58:06] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/69123
[16:58:07] <bawolff>	 ok, do you mind leaving a comment saying so?
[16:59:39] <gerrit-wm>	 New patchset: SuchABot; "Maintain max width / height info to speed up image downloading" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68662
[17:00:03] <gerrit-wm>	 New review: Brion VIBBER; "(1 comment)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68662
[17:00:22] <brion>	 YuviPanda: one tiny comment there :)
[17:00:53] <YuviPanda>	 brion: note that your comments were sync'd to github :) (https://github.com/wikimedia/apps-android-commons/pull/8)
[17:01:00] <YuviPanda>	 but need to make them actually inline tho
[17:01:15] <brion>	 yeah not so good for the inline comment ;)
[17:01:51] <YuviPanda>	 brion: yeah, gerrit-stream doesn't give me that
[17:01:56] <YuviPanda>	 need to hook up the API
[17:02:00] <gerrit-wm>	 New review: Yuvipanda; "(1 comment)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68662
[17:02:04] <YuviPanda>	 brion: responded
[17:02:56] <brion>	 haha "because lazy"
[17:02:58] <brion>	 acceptable
[17:03:02] <brion>	 lemme test
[17:03:12] <gerrit-wm>	 New patchset: Rahul21; "Add audio transcodes to Special:TimedMediaHandler." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69023
[17:05:04] <YuviPanda>	 brion: :)
[17:14:37] <brion>	 ok it's about standup time
[17:18:10] <gerrit-wm>	 New patchset: Krinkle; "mediawiki.js: Clean up and improve documentation coverage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648
[17:19:30] * AaronSchulz  hands brion https://gerrit.wikimedia.org/r/#/c/69022/

[17:21:09] <gerrit-wm>	 New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601
[17:26:09] <gerrit-wm>	 New patchset: Andrew Bogott; "Cache the list of project members." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69126
[17:27:02] <YuviPanda>	 marktraceur: ping?
[17:27:35] <YuviPanda>	 are UW's license options set by Commons admins or in code?
[17:32:14] <gerrit-wm>	 Change abandoned: Njw; "I'll submit a new change based on the current tree." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68364
[17:34:46] <ebernhardson>	 hmm, somehow i lost my invite to wikimedia-staff (yes, logged in via SASL and confirmed via NickServ)
[17:35:17] <marktraceur>	 YuviPanda: It's in LocalSettings
[17:35:33] <YuviPanda>	 marktraceur: ah, okay. I'll look
[17:35:38] <YuviPanda>	 at our current config
[17:35:46] <marktraceur>	 Sure sure
[17:36:15] <YuviPanda>	 marktraceur: adding license selection to the app, so will mooch off what's there in UW
[17:36:18] <YuviPanda>	 (or maybe cut some out)
[17:36:20] <YuviPanda>	 ty
[17:37:21] <marktraceur>	 *nod* you're welcome
[17:38:38] <gerrit-wm>	 New patchset: Rahul21; "Add audio transcodes to Special:TimedMediaHandler and added a condition to check for audio transcodes in TimedMediaHandler.hooks.php ." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/69023
[17:40:28] <bawolff>	 marktraceur: btw, did you see the feedback for UW at https://commons.wikimedia.org/wiki/Commons:VP#About_the_Upload_Wizard (Just mentioning it since I imagine that its not doing a lot of use on the VP)
[17:41:31] <marktraceur>	 Hm, maybe not
[17:41:49] <gerrit-wm>	 New review: Brion VIBBER; "Seems to work, doesn't explode obviously." [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68662
[17:41:50] <gerrit-wm>	 Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68662
[17:42:07] <marktraceur>	 bawolff: Thanks, I'll file related bugs
[17:43:16] <bawolff>	 The conversation below is also kind of amusing
[17:45:12] <YuviPanda>	 bawolff: most conversations over $sizeThreshold on any VP are usually amusing, I think? :)
[17:45:55] <bawolff>	 Usually there's a size threshold where they turn from amusing to annoying, but yes generally
[17:48:51] <gerrit-wm>	 New patchset: Brion VIBBER; "Add a progress bar to display upload progress, instead of just text" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69118
[17:49:14] <marktraceur>	 "
[17:49:14] <marktraceur>	 A third problem is that at least one third of the copyvios is uploaded by Spanish-speaking users. Is there anything we could do about it?
[17:49:17] <marktraceur>	 "
[17:49:41] <marktraceur>	 Maybe our Spanish translations are wrong?
[17:50:15] <Reedy>	 Or Spanish people don't view copyright highly :D
[17:50:44] <marktraceur>	 Maybe
[17:50:59] <marktraceur>	 Are there any Spanish speakers in the house? Want to review http://commons.wikimedia.org/wiki/File:Licensing_tutorial_es.svg to make sure it's sane-ish?
[17:51:26] <Reedy>	 I would've poked Platonides.. But he's not about
[17:51:29] <marktraceur>	 You could also run through the licensing options on UploadWizard if you'd like
[17:53:15] <gerrit-wm>	 New review: Brion VIBBER; "Looks good!" [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69118
[17:53:15] <gerrit-wm>	 Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69118
[17:57:31] <gerrit-wm>	 New patchset: Nemo bis; "(bug 46534) Rename uz File namespace to Fayl" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58687
[17:59:47] <Nemo_bis>	 marktraceur: what's the context? UploadWizard in general?
[18:00:01] <marktraceur>	 Seems like
[18:03:31] <gerrit-wm>	 New patchset: Rachel99; "add ve_refs check - not finished." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/69128
[18:05:13] <gerrit-wm>	 Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69126
[18:06:45] <gerrit-wm>	 New review: Cmcmahon; "Rachel and I are still working on this" [qa/browsertests] (master) C: -1;  - https://gerrit.wikimedia.org/r/69128
[18:07:29] <Nemo_bis>	 marktraceur: the translation looks sane
[18:07:35] <marktraceur>	 Nemo_bis: Thankee
[18:07:59] <Nemo_bis>	 of course I'm es-0 but I don't think there can be anything so wrong in there
[18:09:18] <gerrit-wm>	 New patchset: Aaron Schulz; "Fixed mysql warning about expecting a resource." [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69129
[18:09:27] <Nemo_bis>	 maybe it's the UW translation itself, you can send people to https://translatewiki.net/w/i.php?title=Special:Translate&language=es&group=ext-uploadwizard&filter=translated|!reviewer%3A1136|!last-translator%3A1136&action=proofread for review
[18:11:12] <gerrit-wm>	 New review: CSteipp; "That looks like better behavior. Thanks." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/69022
[18:12:49] <gerrit-wm>	 New patchset: Krinkle; "mediawiki.js: Clean up and improve documentation coverage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648
[18:13:58] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69129
[18:16:00] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69022
[18:16:31] <gerrit-wm>	 New patchset: Njw; "Remove unnecessary custom line-heights to simplify the code" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69134
[18:17:26] <awjr>	 ori-l: on betalabs, something appears to be trying to load some dependent JS from eventlogging (i think navigation timing?), resulting in JS errors (at least on the mobile site). from what i understand, eventlogging and friends are not fully configured on betalabs, so i figured just explicitly disabling eventlogging and navigationtiming on betalabs for the time being should fix the problem, unless you have a better idea? https://gerrit.wikimedia.org
[18:17:43] <gerrit-wm>	 New review: Njw; "Uncontroversial and good." [mediawiki/skins/erudite] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69134
[18:17:46] <gerrit-wm>	 Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69134
[18:19:02] <awjr>	 ori-l: example of the js error on betalabs: http://en.m.wikipedia.beta.wmflabs.org/wiki/0.4171307280313894_Moved?debug=true
[18:24:30] <AaronSchulz>	 Reedy: what is this vote script cron on hume?
[18:25:21] <Reedy>	 No idea
[18:25:24] <Reedy>	 I didn't set it up
[18:25:53] <AaronSchulz>	 who did?
[18:26:07] <Reedy>	 Still no idea
[18:26:59] <AaronSchulz>	 and it's almost like there are new DBs missing in tampa
[18:27:24] <robla>	 possibly either Tim or Werdna ... is that something old that was set up?
[18:27:44] <Reedy>	 If it's newer, Tim or Jamesofur|away might know
[18:28:01] <robla>	 Tim's out this week  :-/
[18:28:03] <Reedy>	 Tim isn't around though, ofc
[18:29:35] <AaronSchulz>	 hmm sql.php works fine with slaves though
[18:29:44] <Reedy>	 i've not looked at the code, but some sort of intermediate tallying script?
[18:30:16] <Reedy>	 If it's something like that, chances are higher that Jamesofur|away would be the owner
[18:30:41] <gerrit-wm>	 New patchset: Anomie; "Return errors from WatchAction" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462
[18:32:22] <gerrit-wm>	 New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462
[18:38:43] <gerrit-wm>	 New patchset: Njw; "Simplify CSS, and reduce header space slightly if not much space" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69137
[18:39:47] <gerrit-wm>	 Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/69137
[18:44:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466
[18:46:06] <gerrit-wm>	 New patchset: Subramanya Sastry; "Once more: turn off parsoid-parsertests job in gate+submit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69139
[18:47:25] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69139
[18:53:03] <gerrit-wm>	 New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/66038
[19:03:10] <hashar>	 Krinkle: I am abandoning the integration/docroot evil __desctruct() :-)
[19:03:18] <gerrit-wm>	 New review: Anomie; "Issues noted on PS8 still need to be addresses." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/53964
[19:03:29] <gerrit-wm>	 Change abandoned: Hashar; "Per timo, lets not make stuff unobvious" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68186
[19:04:07] <Krinkle>	 hashar: Thanks
[19:04:18] <hashar>	 Krinkle: my rational was to avoid the ->flush() call :-)
[19:04:41] <hashar>	 Krinkle: if you have anytime this week, you can get a look at https://gerrit.wikimedia.org/r/#/c/68185/ which puts the HTML in a different file
[19:05:42] <Krinkle>	 I'll review it sometime this week, but not today or tomorrow. Got some VE priorities first.
[19:05:51] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68729
[19:08:15] <gerrit-wm>	 New patchset: Hashar; "experimental breadcrumb display" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343
[19:08:26] <gerrit-wm>	 New review: Hashar; "rebased" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343
[19:09:55] <gerrit-wm>	 New patchset: Umherirrender; "Do not output numberofviews, if $wgDisableCounters = true" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69143
[19:12:52] <gerrit-wm>	 New patchset: Hashar; "phplint for integration/docroot" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69144
[19:13:10] <gerrit-wm>	 New patchset: Hashar; "trigger phplint for integration/docroot" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69145
[19:13:34] <gerrit-wm>	 New patchset: Hashar; "trigger phplint for integration/docroot" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69145
[19:13:55] <gerrit-wm>	 New patchset: Tpt; "Move a part of the index pages related code to ProofreadIndexPage" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/37648
[19:14:15] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69145
[19:15:12] <gerrit-wm>	 New patchset: Hashar; "experimental breadcrumb display" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343
[19:16:16] <gerrit-wm>	 New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) C: 2;  - https://gerrit.wikimedia.org/r/69144
[19:16:16] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69144
[19:17:20] <gerrit-wm>	 New review: Tpt; "Patch set 9: rebase + bug fixed." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/37648
[19:18:18] <gerrit-wm>	 New review: Tpt; "The change doesn't break anything now and have been reviewed by Zaran." [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/37648
[19:18:18] <gerrit-wm>	 Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/37648
[19:18:54] <gerrit-wm>	 New review: Tpt; "Minor change: no need for deep reviewing." [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/66106
[19:18:55] <gerrit-wm>	 Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/66106
[19:19:48] <gerrit-wm>	 New review: Bsitu; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620
[19:22:27] <gerrit-wm>	 Change merged: Parent5446; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69143
[19:22:54] <gerrit-wm>	 New patchset: Hashar; "trigger jshint for integration/docroot" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69147
[19:24:53] <gerrit-wm>	 Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69147
[19:25:57] <gerrit-wm>	 New patchset: Hashar; "jslint for integration/docroot" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69148
[19:27:26] <gerrit-wm>	 Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/69148
[19:31:42] <gerrit-wm>	 New patchset: Hashar; "experimental breadcrumb display" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343
[19:32:36] <gerrit-wm>	 New review: Hashar; "removed the sidebar listing some dots. Was intended to represent the directories but it is a bit cum..." [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343
[19:38:12] <gerrit-wm>	 New review: Mattflaschen; "J, Siebrand -1'ed patch set 2, citing "Brian Wolf's inline comment on the i18n file"" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642
[19:42:23] <ori-l>	 awjr: I saw that you pinged me but I lost context. What's up?
[19:43:11] <awjr>	 ori-l: nothing major, just issues with eventlogging/navigationtiming on betalabs; i wound up explicitly disabling both on betalabs
[19:43:29] <ori-l>	 awjr: what was the issue?
[19:45:10] <awjr>	 ori-l: looked like navigationtiming was trying to load a JS resource provided by eventlogging that wasn't loading, causing JS errors
[19:45:38] <ori-l>	 awjr: did you happen to capture the console output by any chance?
[19:46:02] <awjr>	 yeahi put it in a gist - lemme see if i can dig it up
[19:46:17] <awjr>	 ori-l: https://gist.github.com/awjrichards/6761b6b4bde243b750bf
[19:46:50] <ori-l>	 awjr: awesome, thanks for capturing that and sorry about it.
[19:47:29] <awjr>	 no problem ori-l; it would be cool if we could get eventlogging totally working on betalabs - how difficult do you think that would be?
[19:48:19] <ori-l>	 awjr: not very. MaxSem did much of the work already. I can do the rest.
[19:48:36] <gerrit-wm>	 New patchset: Kipcool; "SQLite Compatibility" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[19:48:39] <ori-l>	 awjr: I'll file a bug so we can track it.
[19:49:07] <awjr>	 ori-l: awesome, thanks :) we were going to schedule it for our next iteration, but if it's not a big deal for you that would be rad
[19:54:32] <gerrit-wm>	 New patchset: Kipcool; "SQLite Compatibility" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68946
[19:57:33] <gerrit-wm>	 New patchset: Cmcmahon; "Add a test to check the appearance of the IME menu" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68934
[19:59:08] <gerrit-wm>	 New review: Cmcmahon; "I think this is nice, but I'd like Zfilipin to review also before merge." [qa/browsertests] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/68934
[19:59:46] <AzaToth>	 MatmaRex: chris or chrismcmahon ?
[20:00:00] <gerrit-wm>	 New review: Krinkle; "(random sudle reminder: Don't set Verified under any circumstances unless Jenkins is broken and you ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68934
[20:00:01] <chrismcmahon>	 hi AzaToth
[20:00:27] <AzaToth>	 chrismcmahon: are you the one in charge of wmf-selenium-bot ?
[20:00:45] <MatmaRex>	 AzaToth: yes, him, i think
[20:00:55] <chrismcmahon>	 AzaToth: yes, me and zeljkof who is not here at the moment
[20:00:57] <MatmaRex>	 AzaToth: there's also qchris, who's a gerrit guy
[20:01:02] <AzaToth>	 hehe
[20:01:04] <MatmaRex>	 do we know more chrises? :P
[20:02:02] <chrismcmahon>	 AzaToth: wmf-selenium-bot reports when a browser test build goes from failing to passing, or from passing to failing.
[20:02:08] <AzaToth>	 chrismcmahon: would it be possible to get rid of the "Yippie, build fixed!" line, and also change "FAILURE in 12 min" to "FAILURE after 12 min"?
[20:02:38] <chrismcmahon>	 AzaToth: sure.  we just left the defaults in place.  I'll see about changing that.
[20:03:03] <AzaToth>	 also I wonder where the bot is running, cant find anything defined on gerrit/puppet/etc...
[20:03:46] <chrismcmahon>	 AzaToth: it's running from a hosted service
[20:03:55] <AzaToth>	 the "FAILURE in" part does really itch me ツ
[20:04:07] <AzaToth>	 so it's not a wmf bot?
[20:05:11] <chrismcmahon>	 AzaToth: it is in a manner of speaking.  It is part of the Jenkins instance that we run from https://wmf.ci.cloudbees.com
[20:05:24] <AzaToth>	 just wondering, difficult to know whom "owns" what
[20:06:16] <ebernhardson>	 can anyone shoot me an invite to wikimedia-staff?  it was working for ~ a month, and now i'm "not invited"
[20:08:26] <RoanKattouw>	 ebernhardson: Ping James_F about it after he's done with this meeting
[20:08:33] <gerrit-wm>	 New patchset: Umherirrender; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038
[20:08:51] <AzaToth>	 chrismcmahon: any reason for using third party for that?
[20:09:29] <chrismcmahon>	 AzaToth: yes.  to oversimplify,  we can run code on that host that we can't support on WMF hosts.
[20:09:41] <AzaToth>	 ok
[20:10:38] <AzaToth>	 is it a free or paid one?
[20:10:43] <chrismcmahon>	 AzaToth: we also have access to Windows VMS, reporting infrastructure, etc. etc. that would be far more expensive to put in place ourselves.
[20:10:54] <gerrit-wm>	 New review: Umherirrender; "Change of the CSS class was not intended, but the class ChangeList self is using 'minor' instead of ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038
[20:11:08] <AzaToth>	 ok
[20:11:34] <chrismcmahon>	 AzaToth: it is ridiculously inexpensive
[20:11:47] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #126: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/126/
[20:14:36] <AzaToth>	 chrismcmahon: does the bot actually scrape the web page of jenkins?
[20:14:41] <chrismcmahon>	 AzaToth: https://bugzilla.wikimedia.org/show_bug.cgi?id=49713
[20:15:05] <chrismcmahon>	 AzaToth: no, the bot is a supported plugin for Jenkins
[20:15:34] <AzaToth>	 oh, ok, the "selenium" part made me imply it was scraping
[20:16:18] <chrismcmahon>	 AzaToth: no, it is reporting on builds that are running Selenium tests
[20:16:26] <AzaToth>	 i see
[20:20:21] <chrismcmahon>	 AzaToth: our Se tests turn up problems fairly often https://bugzilla.wikimedia.org/show_bug.cgi?id=49713 https://bugzilla.wikimedia.org/show_bug.cgi?id=49445
[20:20:43] <AzaToth>	 chrismcmahon: unless you already using it, I can recommend using https://wiki.jenkins-ci.org/display/JENKINS/SCM+Sync+configuration+plugin
[20:21:54] <chrismcmahon>	 AzaToth: thanks! looking
[20:21:55] <AzaToth>	 and for good meassure, throw in https://wiki.jenkins-ci.org/display/JENKINS/Bugzilla+Plugin to spam the bugzilla of failed tests ツ
[20:22:36] <AzaToth>	 yea, the SCM sync config plugin was really important to keep track of configuration changes made in jenkins
[20:23:09] <AzaToth>	 was one bug in it when I used it though, dunno if they fixed it now (was a couple of months ago I used it)
[20:25:16] <AzaToth>	 https://issues.jenkins-ci.org/browse/JENKINS-15128 - not fixed  yet ヾ
[20:25:25] <AzaToth>	 i.e. do not rename jobs
[20:28:42] <gerrit-wm>	 New patchset: Matthias Mullie; "Don't find AFT results if tagfilter set" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69152
[20:28:46] <chrismcmahon>	 AzaToth: on a related subject, our build schedule has outgrown its usefulness, zeljkof and I will be rearranging which builds run when in the next few days.
[20:29:05] <gerrit-wm>	 New patchset: Matthias Mullie; "Pass along tagFilter to ContribsPager, it already expects it" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69153
[20:29:06] <gerrit-wm>	 New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140
[20:29:18] <gerrit-wm>	 New patchset: Hashar; "mwdocgen: support multiple --file values" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140
[20:29:29] <AzaToth>	 okai
[20:30:04] <AzaToth>	 chrismcmahon: you might want to throw in a android and an ios vm for good meassure
[20:33:16] <James_F>	 ebernhardson: Fixed.
[20:34:50] <gerrit-wm>	 New patchset: MarkTraceur; "Add fix for longstanding bug in contribution_tracking DB" [mediawiki/extensions/ContributionTracking] (master) - https://gerrit.wikimedia.org/r/69154
[20:37:30] <gerrit-wm>	 New patchset: Matthias Mullie; "Don't find AFT results if tagfilter set" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/69152
[20:46:19] <gerrit-wm>	 New patchset: Cmcmahon; "Add a test to check the appearance of the IME menu" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68934
[20:55:48] <gerrit-wm>	 New review: Cmcmahon; "Paired with Amir, made this test use 'should be_visible' and merged" [qa/browsertests] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68934
[20:55:52] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68934
[20:56:43] <hashar>	 is that only me or gerrit is a bit slow tonight ?( ^demon )
[20:56:51] <^demon>	 Yeah, it is.
[20:57:05] <AzaToth>	 hashar: somewhat slower than normal
[20:57:08] <gerrit-wm>	 New patchset: Hashar; "test: coverage recording now needs to be explicit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125
[20:57:17] <gerrit-wm>	 New patchset: Hashar; "test: coverage recording now needs to be explicit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125
[20:57:44] <gerrit-wm>	 New review: Hashar; "Blocking this change, it depends on https://bugzilla.wikimedia.org/show_bug.cgi?id=43972" [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/66125
[20:57:51] <AzaToth>	 ^demon: there are many gits that seems to be either obsolete, unused, or failures
[20:58:04] <AzaToth>	 any idea to clean it out?
[20:58:08] <hashar>	 ^demon: could it be some LDAP slowness ?
[20:58:12] <^demon>	 Hadn't planned on it.
[20:58:14] <^demon>	 hashar: No.
[20:58:18] <AzaToth>	 or is gerrit still unable to understand that a repo can be removed?
[20:58:56] <gerrit-wm>	 New patchset: Hashar; "test: rework interwiki lookup in parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64574
[20:59:13] <AzaToth>	 ^demon: for example USERINFO, analytics/global-dev/reportcard, etc..
[20:59:24] <hashar>	 USERINFO is kept for historical purposes :)
[20:59:34] <^demon>	 AzaToth: I can delete repos. I just had no plans to.
[20:59:41] <hashar>	 it also has a few easter eggs we want to keep for whenever we are all deads
[20:59:48] <AzaToth>	 hashar: I would assume as the svn will be available for eternity, no need to keep it in git
[21:00:18] <AzaToth>	 ^demon: difficult sometimes to know which repo is the "right" one
[21:00:27] <hashar>	 AzaToth: da4b3c7 (of USERINFO.git )
[21:00:31] <AzaToth>	 ^demon: for example operations/debs/wikibugs vs wikimedia/bugzilla/wikibugs
[21:00:52] <^demon>	 AzaToth: Make a list of ones to delete, ask people to weigh in.
[21:00:57] <^demon>	 Then we can do some cleanup.
[21:01:11] <gerrit-wm>	 New patchset: Ryan Lane; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421
[21:01:45] <AzaToth>	 Reedy: you might be able to answer that
[21:01:55] <gerrit-wm>	 New review: Daniel Friesen; "Some day we need to update the maintenance class so it can accept multiples of the same arg." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140
[21:01:59] * hashar  sends Reedy and ^demon to conf call :-D

[21:02:08] <AzaToth>	 hehe
[21:06:46] <gerrit-wm>	 New review: Hashar; "Indeed :)  We could look at something similar to http://docs.python.org/dev/library/argparse.html  ...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140
[21:06:53] <gerrit-wm>	 New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783
[21:07:55] <gerrit-wm>	 New review: Hashar; "Yeah yeah optimizing. Self merge reason: that is not going to kill the site and tests are passing :-D" [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/64574
[21:10:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64574
[21:15:31] <gerrit-wm>	 New patchset: Nikerabbit; "WIP: Turn edit tab to translate tab on translation pages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/69162
[21:18:18] <gerrit-wm>	 New patchset: Ryan Lane; "AJAXify delete instance action" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65557
[21:19:50] <gerrit-wm>	 New patchset: SuchABot; "Persist width & height to Parcelables" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69189
[21:19:53] <spagewmf>	 ^demon, in gerrit Differences > Preferences there's a Tab width: field (yay!), but changing it has no effect in Chromium or Firefox.
[21:20:17] <^demon>	 Known bug, I believe.
[21:20:54] <^demon>	 The whole diff ui is being redone anyway, so I don't see upstream fixing it unless it's a problem with the new UI :)
[21:21:14] <spagewmf>	 OK. Google "gerrit tab width preference" only coughed up the wikitech debate about tabs in August 2012 (good times :) )
[21:27:35] <gerrit-wm>	 New patchset: Andrew Bogott; "Cache a dict of member ids and names rather than just names." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69155
[21:28:46] <gerrit-wm>	 New review: Yuvipanda; "Small bug fix" [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69189
[21:40:50] <AzaToth>	 git diff -w is something that I always miss in web based diffs ^demon
[21:40:59] <^demon>	 :)
[21:42:40] <AzaToth>	 ^demon: did gerrit et al build and run properly?
[21:43:01] <^demon>	 I don't remember where I left off friday.
[21:43:12] <^demon>	 Buck was definitely ok.
[21:43:39] <AzaToth>	 even though it has bundled jars installed?
[21:44:28] <AzaToth>	 I couldn't use system jython, so I had to bundle it's jython-standalone ヾ
[21:44:46] <AzaToth>	 system available guava was too old
[21:44:54] <AzaToth>	 the rest hadn't any debian packages available
[21:45:54] <gerrit-wm>	 New patchset: Bsitu; "Remove unused global variable and documentation fix" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69249
[21:46:26] <AzaToth>	 bsitu: are you removing unused documentation fixes?
[21:46:37] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/69192
[21:46:55] <bsitu>	 AzaToth: :), sorry, it's not clear, I will change the message
[21:47:01] <AzaToth>	 hehe ツ
[21:47:17] <AzaToth>	 sorry, I couldn't resist
[21:47:18] <bsitu>	 thanks for catching this
[21:47:22] <bsitu>	 no problem
[21:47:48] <AzaToth>	 ^demon: jackson-core was also too old on system
[21:48:59] <AzaToth>	 bsitu: natural language are generally too ambigious
[21:50:12] <Krinkle>	 Ryan_Lane: Could you add a .jshintrc file (see [[mw:CC/JS]] for a boilerplate) to the OSM mw-ext repo and rebase your 3 ajax-related changes onto it? It will make it easier to review knowing it passes lint checks. Right now it is failing because it doesn't have any ruleset and is basically emitting random errors based on configs of other projects.
[21:50:45] <Krinkle>	 Right now I'm on VE priorities, I'll get to your OSM patches (which I hear you're blocked on, did as much as you can with it still pending in gerrit) within a few days
[21:50:51] <Krinkle>	 I'm in the office now btw.
[21:50:57] <Ryan_Lane>	 Krinkle: all of them are reviewed right now
[21:51:02] <Krinkle>	 OK
[21:51:17] <Ryan_Lane>	 after adding every JS person it happened pretty quick :)
[21:51:18] <Krinkle>	 By whom
[21:51:28] <Ryan_Lane>	 matmarex and ori
[21:51:30] <gerrit-wm>	 New patchset: SuchABot; "bug 47671 -- don't show crashy photo button if no camera present" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69253
[21:51:32] <Ryan_Lane>	 and anomie
[21:51:49] <Ryan_Lane>	 I've pushed in new changesets for all of them since then, but not for the JS
[21:51:50] <gerrit-wm>	 New patchset: Bsitu; "Remove unused global variable and update function return type" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69249
[21:51:52] <Ryan_Lane>	 for the php
[21:54:25] <AzaToth>	 bsitu: no documentation fix any more? ツ
[21:54:29] * AzaToth  hides

[21:55:19] <gerrit-wm>	 New review: Daniel Friesen; "As usual the Symfony component doesn't look much better than what we already have. It doesn't seem t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140
[21:56:02] <AzaToth>	 ^demon: gerrit is really sluggish now, any probs on srv?
[21:56:19] <^demon>	 Kinda.
[21:57:24] <bsitu>	 AzaToth: It's too long to fit the 64 chars constraint, just make it simple, :)
[21:58:15] <AzaToth>	 heh
[21:59:12] <hashar>	 manybubbles: AaronSchulz: about CI training, I will follow up probably tomorrow and we can find a time to do some hangout
[22:06:29] <gerrit-wm>	 New patchset: Brian Wolff; "Make score work with multi-page files" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63266
[22:08:09] <gerrit-wm>	 New review: Brian Wolff; "PS3: Minor issue with variable name in regards to width/height code" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63266
[22:08:40] <gerrit-wm>	 New review: Brian Wolff; "For reference, here is some example data to test with:" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63266
[22:12:08] <gerrit-wm>	 New review: Yuvipanda; "(1 comment)" [apps/android/commons] (master) C: -1;  - https://gerrit.wikimedia.org/r/69253
[22:13:41] <gerrit-wm>	 New review: Yuvipanda; "(1 comment)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69253
[22:14:33] <gerrit-wm>	 Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69155
[22:15:40] <superm401>	 Krinle, RoanKattouw, or anyone that knows:
[22:15:55] <superm401>	 It seems ResourceLoader does not support media queries (you have to put them in the CSS directly)
[22:15:59] <superm401>	 Is that correct?
[22:18:56] <RoanKattouw>	 No
[22:19:03] <RoanKattouw>	 It does support them
[22:19:06] <RoanKattouw>	 Let me grab you an example
[22:19:57] <RoanKattouw>	 superm401: See the module definition of skins.vector in https://git.wikimedia.org/blob/mediawiki%2Fcore.git/4953ac4f6c92d1d044f548a5fc832d9d337c89db/resources%2FResources.php#L89
[22:20:13] <RoanKattouw>	 Specifically 'vector/screen-hd.css' => array( 'media' => 'screen and (min-width: 982px)' ),
[22:21:01] <superm401>	 RoanKattouw, but that's using addModuleStyles, which doesn't go through ResourceLoader.
[22:21:13] <superm401>	 I assumed it would work with RL, but doesn't seem like it.
[22:21:40] <Krinkle>	 superm401: the 'media
[22:21:46] <gerrit-wm>	 New patchset: SuchABot; "bug 47671 -- don't show crashy photo button if no camera present" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69253
[22:21:50] <superm401>	 Well, it's technically a module, but it's not processed for prod mode with ModuleStyles.
[22:21:54] <Krinkle>	 superm401: the 'media' you set in the module definition is used to wrap the module contents in css (wraps it in a @media)
[22:22:03] <Krinkle>	 so if you use it in the css file itself as well, it is broken because you can't nest them.
[22:22:09] <superm401>	 I didn't use it in both.
[22:22:14] <Krinkle>	 So either set it on the module or set it not on the module and one in the file.
[22:22:21] <RoanKattouw>	 superm401: Are you saying you used this feature and the CSS wasn't wrapped in a @media by RL?
[22:22:24] <Krinkle>	 Then it shoudl work, regardless of addModuleStyles or addModules
[22:22:36] <superm401>	 RoanKattouw, correct, with addModules.
[22:22:50] * Krinkle  yields to Roan

[22:23:13] <RoanKattouw>	 Odd. That's supposed to work
[22:23:39] <superm401>	 http://pastebin.com/s54ysirw
[22:23:49] <superm401>	 Alright, I'll play around with it a little more.
[22:23:58] <RoanKattouw>	 I don't have time to investigate right now (or even today) but this sounds like we might have broken it with the changes in how CSS is handled
[22:24:08] <gerrit-wm>	 New review: Yuvipanda; "(1 comment)" [apps/android/commons] (master) C: -1;  - https://gerrit.wikimedia.org/r/69253
[22:24:19] <RoanKattouw>	 There was some back and forth on how we work around IE's inability to deal with >32 <style> tags
[22:24:55] <RoanKattouw>	 superm401: That should work via addModules(), but that code path isn't used in core so I wouldn't be entirely surprised if we broke it and never noticed
[22:25:00] <RoanKattouw>	 superm401: Could you file a bug please?
[22:25:10] <gerrit-wm>	 Change merged: Aaron Schulz; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63266
[22:25:12] <superm401>	 RoanKattouw, will do
[22:27:53] <gerrit-wm>	 New patchset: Ryan Lane; "Adding a .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255
[22:28:25] <Ryan_Lane>	 Krinkle: this is what you wanted, right? ^^
[22:28:36] <Ryan_Lane>	 I'm going to have to rebase all the changes, but I needed to do that anyway
[22:28:54] <Krinkle>	 Ryan_Lane: Be sure to use tabs and no trailing space on the empty line
[22:29:20] <Krinkle>	 Ryan_Lane: Hm.. strange, the jenkins-bot didn't run jshint on that patch set
[22:29:22] <gerrit-wm>	 New review: Yuvipanda; "Because moving the app one level up in this case doesn't really give us anything. Should move the ne..." [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/69253
[22:29:35] <Krinkle>	 Be sure it passes before you merge/rebase on that change
[22:29:43] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/69253
[22:30:06] <Ryan_Lane>	 bleh. tabs? heh
[22:30:18] <gerrit-wm>	 New patchset: Ryan Lane; "Adding a .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255
[22:31:06] <Ryan_Lane>	 it doesn't look like it's working to me...
[22:31:28] <Ryan_Lane>	 I don't get it. jshint was running on OSM changes at some point in the past
[22:32:12] <Krinkle>	 Ryan_Lane: indeed
[22:35:01] <Krinkle>	 Reloading zuul and re-triggering patch set
[22:35:09] <gerrit-wm>	 New patchset: Krinkle; "Add .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255
[22:36:54] <superm401>	 Krinkle, RoanKattouw, RL mostly seems to work correctly.
[22:37:06] <superm401>	 The problem was that Firebug does not show the media queries in the CSS tab.
[22:37:10] <Krinkle>	 https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-merge/525/ this one had no jslint child
[22:37:12] <RoanKattouw>	 Ha!
[22:37:25] <Krinkle>	 https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-merge/519/ this one did
[22:37:32] <RoanKattouw>	 You may have to inspect the generated <style> element to see what is actually there
[22:37:40] <superm401>	 RoanKattouw, yeah I did.
[22:37:41] <Krinkle>	 https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-merge/527/ this one also does
[22:37:44] <superm401>	 However, there is one RL issue, that it does not convert the queries in printable mode the way transformCssMedia does.
[22:37:59] <superm401>	 So all the static CSS shows in print mode when you have printable=yes, but not the RL stuff.
[22:38:01] <superm401>	 Will file.
[22:38:01] <Ryan_Lane>	 Krinkle: does it only trigger on changes that have js in them?
[22:38:05] <RoanKattouw>	 It used to at some point
[22:38:18] <RoanKattouw>	 And it might actually still do it correctly in the addModuleStyles code path
[22:38:28] <RoanKattouw>	 Thanks superm401
[22:38:32] <Krinkle>	 Ryan_Lane: Ha, that could be it. hashar probably optimised it without me knowing, and didn't include .jshintrc/.jshintignore in that detection
[22:38:39] <superm401>	 RoanKattouw, yeah, I think it does for addModuleStyles
[22:38:54] <hashar>	 OOPS
[22:39:04] <hashar>	 Krinkle: yup the jslint jobs are only triggered on files matching *.js
[22:39:18] <Krinkle>	 https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml#L246-L250
[22:39:23] <Ryan_Lane>	 Krinkle: indeed: https://gerrit.wikimedia.org/r/#/c/68126/
[22:39:28] <Ryan_Lane>	 that change has no jshint check
[22:39:43] <Ryan_Lane>	 :D
[22:39:45] <Krinkle>	 hashar: The one for jsduck is also wrong, because there is jsduck.json  and jsduck.categories.json
[22:40:25] <Krinkle>	 actually, the jsduck files (unlike jshint) can have any name. So that one can't be optimised for now (though it could be *.json as an improvement)
[22:40:43] <hashar>	 go ahead and tweak the regex :)
[22:40:57] <Krinkle>	 hashar: Can you fix -jslint to trigger on .jshint* (*rc and *ignore) and jsduck on *.json ?
[22:40:57] * Krinkle  does

[22:41:04] <hashar>	 too late for me sorry
[22:41:09] <hashar>	 i would make a mistake :-]
[22:41:19] <hashar>	 I +2 your regex skills
[22:42:13] <Krinkle>	 >> /^(.*\.js|.*\.json|.jshint*)$/.match( '.jshintrc' )
[22:42:13] <ecmabot-wm>	 Krinkle: TypeError: Object /^(.*\.js|.*\.json|.jshint*)$/ has no method 'match'
[22:42:18] <Krinkle>	 >> /^(.*\.js|.*\.json|.jshint*)$/.exec( '.jshintrc' )
[22:42:18] <ecmabot-wm>	 Krinkle: (object) null
[22:42:24] <Krinkle>	 >> /^(.*\.js|.*\.json|\.jshint*)$/.exec( '.jshintrc' )
[22:42:25] <ecmabot-wm>	 Krinkle: (object) null
[22:42:28] * Krinkle  does in PM

[22:43:52] <gerrit-wm>	 Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68412
[22:44:59] <RoanKattouw>	 Krinkle: jshint.* not jshint*
[22:45:06] <Krinkle>	 Yeah, figured it already
[22:45:10] <Krinkle>	      - '^(.*\.(js|json)|\.jshint.*)$'
[22:45:14] <hashar>	 Krinkle: http://regexpal.com/ :D
[22:45:14] <Krinkle>	      - '^.*\.(js|json)$'
[22:45:33] <marktraceur>	 jshintttttt
[22:45:34] <Krinkle>	 node-repl or browser console are much faster for me
[22:45:36] <RoanKattouw>	 Krinkle: Also, ^.* is redundant
[22:45:39] <marktraceur>	 Wait
[22:45:49] <RoanKattouw>	 Just don't anchor the regex in that case, and use \.(js
[22:45:51] <RoanKattouw>	 Ahm
[22:45:58] <RoanKattouw>	 \.(js|json)$
[22:46:06] <Krinkle>	 Right
[22:46:14] <Krinkle>	 That was already there though
[22:46:16] <marktraceur>	 Krinkle: Why wouldn't \.jshint* have picked up '.jshintrc'?
[22:46:17] <Krinkle>	 but I'll take it
[22:46:33] <marktraceur>	 Oh, no, got it
[22:46:34] <RoanKattouw>	 marktraceur: No, it picks up .jshin or .jshint or .jshintt or .jshinttt or ....
[22:46:35] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/69249
[22:46:39] * marktraceur  doesn't pay attention

[22:46:40] <Krinkle>	 marktraceur: you said so yourself, t* is t-tttttt not t*anything*
[22:46:44] <marktraceur>	 Right
[22:47:00] <marktraceur>	 I forgot about the end-anchor, which is also superfluous
[22:47:09] <marktraceur>	 Oh, in that case.
[22:47:09] <hashar>	 :-]
[22:47:35] <marktraceur>	 \.(js$|json$|jshint)
[22:47:49] <gerrit-wm>	 New patchset: Brian Wolff; "Follow-up 42333412 - Fix behaviour $wgVerifyMimeType = false;" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/69257
[22:48:25] <Krinkle>	 marktraceur: readability vs. less characters
[22:48:28] <Krinkle>	 I'm going to use (\.(js|json)|\.jshint.*)$
[22:48:34] <marktraceur>	 Fewer
[22:48:38] <Krinkle>	 I'll put the \. outside
[22:49:02] <marktraceur>	 I don't know that .*$ is more readable, but OK
[22:49:25] <RoanKattouw>	 I would recommend \.jshint[^.]* instead
[22:49:33] <RoanKattouw>	 You presumably don't want to match foo.jshint.bar
[22:49:36] <RoanKattouw>	 Or maybe you do?
[22:49:54] <Krinkle>	 (.js, .json or .jshint* )$, as opposed to .js$, .json$ or .jshint
[22:49:56] <Krinkle>	 indeed
[22:49:59] <Krinkle>	 do not want to match
[22:50:32] * marktraceur  clearly doesn't understand what problem Krinkle is trying to solve :)

[22:51:53] <Krinkle>	 marktraceur: https://github.com/wikimedia/integration-zuul-config/blob/master/layout.yaml#L246-L258
[22:51:53] <marktraceur>	 Hey ori-l, I'm trying to build in some extra non-mediawiki stuff for Vagrant. But I want to use SQL. Would it make sense to "refactor" the SQL config out of the role::mediawiki class and into a more general class that can be inherited?
[22:52:06] <hashar>	 Krinkle: (^.jshint.*|\.js|\.json)$
[22:52:09] <Krinkle>	 marktraceur: jshint and jsduck don't run when editing .jshintrc, .jshintrc or jsduck.something.json
[22:52:10] <marktraceur>	 Aha.
[22:52:15] <gerrit-wm>	 Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67554
[22:52:17] <Krinkle>	 hashar: I already have it
[22:52:21] <Krinkle>	      - '\.(js|json|jshint.*)$'
[22:52:37] <marktraceur>	 Also I guess RoanKattouw should yell at hashar about the ^.* stuff
[22:52:52] <Krinkle>	 Theoratically you might want to exclude something.jshintrc
[22:53:01] <Krinkle>	 but I'd say if that exists, it is more likely to be related then to be unrelated
[22:54:30] <gerrit-wm>	 New patchset: Brian Wolff; "Use canonical url instead of protocol relative for sitemap feed." [mediawiki/extensions/GoogleNewsSitemap] (master) - https://gerrit.wikimedia.org/r/69259
[22:55:41] <ori-l>	 marktraceur: sure. there's a separate mysql module already -- what aspects of the mysql setup were tightly coupled to mediawiki?
[22:55:52] <marktraceur>	 AFAICT the username and password
[22:56:04] <marktraceur>	 They're hardcoded in
[22:56:31] <hashar>	 beddd tme
[22:58:18] <gerrit-wm>	 New patchset: Krinkle; "jshint/jsduck: Include config files in file match filter" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69260
[23:03:27] <gerrit-wm>	 Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/69260
[23:05:32] <gerrit-wm>	 New patchset: Krinkle; "Add .jshintrc file" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/69255
[23:11:00] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69261
[23:11:06] <wmf-selenium-bot>	 Yippie, build fixed!
[23:11:07] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #127: FIXED in 9 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/127/
[23:11:45] <gerrit-wm>	 New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69262
[23:13:21] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/69261
[23:16:45] <gerrit-wm>	 New review: Krinkle; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) C: -1;  - https://gerrit.wikimedia.org/r/69255
[23:17:01] <gerrit-wm>	 Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/69262
[23:20:38] <marktraceur>	 Oh, huh, ori-l never mind, it's configurable, just the mediawiki class doesn't use the variables
[23:27:31] <ori-l>	 marktraceur: there's a standing request to switch from mysql to mariadb, btw, if you're refactoring that stuff
[23:27:40] <marktraceur>	 Noooo
[23:27:47] <marktraceur>	 ori-l: It's too much for one changeset, I think
[23:27:58] <marktraceur>	 I'm trying to build a vagrant instance for the fundraising setup
[23:28:01] <ori-l>	 k :)
[23:28:11] <marktraceur>	 You can imagine how hairy that is
[23:28:57] <ori-l>	 let me know if you get stuck
[23:30:02] <marktraceur>	 *nod* I think it would be more likely to be caused by the fundraising side than the vagrant side :)
[23:31:07] <Krinkle>	 ^demon: Can you look at Gerrit? It's been slow for the last few hours. Merging to a wmf-branch in core took 3 minutes (not Jenkins/Zuul including). And opening a html page for a change set took like half a minute to load.
[23:33:05] <gerrit-wm>	 New review: Spage; "One bug(?) with title key, otherwise the API works; mostly some comments and questions about the way..." [mediawiki/extensions/EventLogging] (master) C: -1;  - https://gerrit.wikimedia.org/r/68617
[23:33:18] <mooeypoo>	 hey ori-l, we were gossipping shamelessly about you today.
[23:33:51] <ori-l>	 you were?
[23:33:53] <mooeypoo>	 okay, I'm exaggerating. We just talked about vagrant and how to install it, and then we mentioned you.
[23:34:19] <marktraceur>	 mooeypoo: "We"?
[23:35:13] <mooeypoo>	 yurik explained the installation process, and I am trying to replicate it now. I'm running into git problems though, even before vagrant. SSH keys aren't working, even though I posted them ingerrit and in wikitech.
[23:35:54] <ori-l>	 mooeypoo: are you running into problems git-cloning the vagrant repository, or with vagrant git-cloning mediawiki-core?
[23:36:14] <mooeypoo>	 both, I ended up using the https:// version to clone instead of the ssh://
[23:36:16] <mooeypoo>	 is that horrible?
[23:36:28] <RoanKattouw>	 mooeypoo: SSH keys won't work that way
[23:36:34] <mooeypoo>	 I know
[23:36:37] <RoanKattouw>	 Oh right
[23:36:42] <mooeypoo>	 https didn't require keys, that's why I ended up using it
[23:36:43] <RoanKattouw>	 https:// clones are read-only
[23:36:48] <RoanKattouw>	 So you won't be able to submit any code
[23:36:51] <mooeypoo>	 hm
[23:36:52] <marktraceur>	 RoanKattouw: Not true
[23:36:58] <RoanKattouw>	 ?
[23:37:03] <marktraceur>	 RoanKattouw: git-review will auto-create the gerrit remote
[23:37:04] <ori-l>	 marktraceur: read only for git-review, which is effectively the same
[23:37:05] <mooeypoo>	 should I redo?
[23:37:11] <RoanKattouw>	 marktraceur: ...which will be an ssh:// remote
[23:37:13] <mooeypoo>	 deleting the folders and re-cloning will work?
[23:37:15] <marktraceur>	 I did this today with ContributionTracking
[23:37:24] <marktraceur>	 Yeah, I'm just saying, cloning via HTTPS isn't a problem
[23:37:30] <RoanKattouw>	 Right, OK
[23:37:45] <ori-l>	 roan didn't say anything about cloning
[23:37:51] <mooeypoo>	 ok, that's the other thing, I'm going to check vagrant's working, but I need to install git-review on windows too, and I understand that required python
[23:37:54] <mooeypoo>	 which I installed
[23:38:21] <mooeypoo>	 it finally finished cloning wiki core
[23:38:30] <mooeypoo>	 now i can do the vagrant up command and cross my fingers
[23:38:33] <ori-l>	 I thought you were referring to the fact that gerrit will allow you to git push gerrit HEAD:refs/for/master via HTTPS, but git-review doesn't support it. There's an open bug.
[23:39:02] <mooeypoo>	 I should do the 'vagrant up' through inside the mediawiki folder, right?
[23:39:28] <ori-l>	 mooeypoo: the folder that contains 'Vagrantfile' or any of its subfolders (which includes the mediawiki folder)
[23:39:35] <mooeypoo>	 ok
[23:39:38] <mooeypoo>	 crossing my fingers.
[23:39:50] <ori-l>	 makes it hard to type :P
[23:39:59] <mooeypoo>	 but not impossible
[23:42:13] <mooeypoo>	 okay, it stopped.
[23:42:16] * mooeypoo  tests

[23:44:03] <mooeypoo>	 It seemed to have installed stuff, but then it finished with a lot of errors.
[23:44:58] <ori-l>	 mooeypoo: can you copy/paste the buffer into a pastebin, like https://dpaste.de/ ?
[23:45:12] <mooeypoo>	 yup doing that now
[23:45:22] <mooeypoo>	 http://pastebin.com/jXzWdxvS
[23:46:00] <mooeypoo>	 and the vm box vanished
[23:46:10] <mooeypoo>	 no more vagrant VM in virtualbox
[23:46:14] <mooeypoo>	 should I redo vagrant up ?
[23:46:38] <ori-l>	 this looks like an upstream vagrant bug
[23:46:42] <ori-l>	 sure, try it. i'll research meanwhile.
[23:47:44] <ori-l>	 mooeypoo: https://github.com/mitchellh/vagrant/issues/1828
[23:48:26] <ori-l>	 mooeypoo: are you also using gitbash on windows?
[23:49:24] <mooeypoo>	 msysgit
[23:49:34] <mooeypoo>	 but yurik did it today and it worked great
[23:50:02] <AaronSchulz>	 manybubbles: http://blog.endpoint.com/2011/09/postgresql-allows-for-different.html
[23:50:07] <AaronSchulz>	 nice table
[23:50:37] <ori-l>	 mooeypoo: well, it may be that this and the problem you had git-cloning over ssh are both the result of a malformed key
[23:51:10] <mooeypoo>	 hm, GitHub for Windows uses a key in the .ssh folder and seems to work ok
[23:51:14] <mooeypoo>	 but I can redo the key
[23:52:17] <gerrit-wm>	 New review: Parent5446; "Will test tonight, and if good will merge." [mediawiki/extensions/UserMerge] (master) C: 1;  - https://gerrit.wikimedia.org/r/68211
[23:52:35] <manybubbles>	  AaronSchulz:  well there you go.  and I've always just run it in READ COMMITTED....  I suppose I should pay more attention to these things.
[23:53:10] <mooeypoo>	 I think for the moment I'll return to working in the VM though. I've wasted some time on this, and I have code to write :\
[23:54:19] <ori-l>	 sure.
[23:55:14] <mooeypoo>	 git for windows is frustrating
[23:55:24] <mooeypoo>	 it's not even vagrant, git is acting up
[23:57:14] <ori-l>	 try cygwin, perhaps?
[23:57:55] <ori-l>	 does windows 7 has some kind of remote tech support screen-sharing?
[23:58:22] <gerrit-wm>	 Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67555