[00:10:28] Reedy: wikidata folks have done a bit of reorganization in Wikibase extension. Seems some models have been moved to new extensions. That is breaking the beta cluster right now [00:10:38] Yeah, I'm pretty confused [00:10:38] Reedy: something to look at for the next wmf cut [00:10:45] I don't know why they need 10 extensions [00:10:58] ooover engineering :-] [00:11:00] They had like 3 originally, and combined all the "wikibase" stuff into one early in the git process [00:11:17] New patchset: Brian Wolff; "getPageDimensions failure handling incorrect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [00:11:22] I think one of the idea is to have independent components that others could use [00:11:30] https://gerrit.wikimedia.org/r/#/c/68630/ Remove DataModel component as it now resides in the WikibaseDataModel git repo [00:11:43] so it seems everything is under WikibaseDataModel ext now [00:13:53] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #81: FAILURE in 5 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/81/ [00:14:23] bah [00:14:31] WikibaseDataModel is empty on beta :( [00:15:41] I can't get it to update :-( [00:15:58] ah rm [00:16:17] yeah, some are fscked [00:16:47] http://en.wikipedia.beta.wmflabs.org/ we have nice fatal errors now [00:17:23] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [00:18:04] New patchset: Brian Wolff; "getPageDimensions failure handling incorrect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [00:18:34] Reedy: does the main doSpam now have the deduping function or do we have to still run the perl script Tim gave a couple nights ago on it? [00:18:41] Err [00:18:52] I thought anomie|away had added some and tim had CR'd it [00:19:22] Added the following cleanups: [00:19:22] * Run block/bot checks on all wikis, not just those with over 100 eligible voters [00:19:22] * Eliminate name entirely if bot/blocked on any wiki. [00:19:22] * Add check for already-voted users [00:19:22] * Add check for multiple usernames with the same email address [00:19:58] require_once( "$IP/extensions/WikibaseDataModel/WikibaseDataModel.php" ); [00:19:59] \O/ [00:20:52] Jamesofur: Oh.. Looks like the get-voter-list.sh is the old version of doSpam [00:21:07] oh well :D [00:21:14] LOL [00:21:28] it looks like doSpam does indeed do the deDup [00:21:39] going through it now, and tries to pick the right language too [00:22:32] New patchset: Reedy; "Remove get-voter-list.sh, it's deprecated to doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68832 [00:22:45] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68832 [00:23:54] Jamesofur: I'll just run doSpam and grab the output [00:23:56] easiest thing to do [00:23:58] * Jamesofur nods [00:24:34] Reedy: Philippe would like us to spam him as well [00:24:41] lol [00:24:43] A full set? [00:24:58] yes :) well, at least I'm not clarifying [00:26:09] Reedy: beta should be fixed with https://gerrit.wikimedia.org/r/68833 , that insert an include to the new WikibaseDataModel extension [00:28:38] Jamesofur: Sent [00:28:48] thanks :D [00:30:11] I ammm done [00:30:13] 2am already [00:31:35] bah it is no more issuing fatals [00:31:37] Jamesofur: doSpam done [00:31:47] reedy@tin:/a/common/elections-2013-spam$ wc -l users-by-wiki [00:31:47] 39340 users-by-wiki [00:32:07] Spammmmmmmm. [00:32:28] nearly 40k emails to be sent [00:32:32] Jamesofur: Want a copy of the list somewhere? [00:32:49] hashar: I had a 4.30 am sometime last week.. [00:33:39] <^demon|away> Heh, running rebuildall.php with hhvm. This is way faster :) [00:34:04] waking up in 5 hours, time to sleep :-) [00:34:04] Reedy: yes, dump it in tmp again, just want to look at it briefly won't take long [00:34:17] *wave* [00:34:28] Done [00:36:58] Reedy: I may have to get you to re run translations, sorry, getting some complaints ;) will let you know in a sec [00:37:12] heh, we know that works now ;) [00:40:00] Reedy: in sendmail.php change 'Wikimedia Board Elections Committee' to "Wikimedia Foundation Election Committee" (can keep same email address) [00:41:49] New patchset: Reedy; "Update name email comes from" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68834 [00:43:30] Yippie, build fixed! [00:43:31] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #328: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/328/ [00:45:22] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68834 [00:46:02] New patchset: MarkTraceur; "Add UploadWizardUploadList class, use deferreds" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68835 [00:46:12] * marktraceur vomits a rewrite all over your Gerrit instance [00:46:43] New review: MarkTraceur; "WIP patch, not ready for merge. You can look at the code if you enjoy pain, though." [mediawiki/extensions/UploadWizard] (master) C: -2; - https://gerrit.wikimedia.org/r/68835 [00:48:25] New review: MarkTraceur; "Haha, jenkins-bot, you have no idea what you're saying." [mediawiki/extensions/UploadWizard] (master); V: -1 - https://gerrit.wikimedia.org/r/68835 [00:49:46] New patchset: Reedy; "Update langlist to how things are for this year" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68836 [00:50:18] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68836 [00:51:18] Jamesofur: Sooooooooooooooooooooooooooooooooooooooooooo [00:52:19] sorry, trying to fix translations [00:52:39] that's alright [00:53:22] Reedy: Not enough 'o's in "so" [00:54:13] Jamesofur: [00:54:13] Sooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:13] oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:13] oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:13] oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:15] oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:18] oooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:20] ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo [00:54:27] !pastebin [00:54:28] Please do not paste more than 2-3 lines of text into the channel as it disrupts the flow of conversation. When sharing multiple lines of code, please use a pastebin such as or and post a link to your paste in the channel. [00:54:31] :P [00:54:52] bawolff: It's only one line in my irc client [00:54:53] :D [00:55:14] I love fridays. [00:55:17] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68837 [00:55:36] * Jamesofur eyes the hammer on his desk [00:55:51] Nischayn22: Hey, you might be intrigued by the UW patch I just pushed, lemme add you as a reviewer [00:55:56] where's James_F when you need him? ;) [00:56:02] Whut? [00:56:12] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68837 [00:56:16] marktraceur: because you gotta get down? [00:56:29] * ^demon|away whacks p858snake|l [00:56:30] <^demon|away> No. [00:56:31] Reedy: I don't have magic +b privs in this channel. :-) [00:56:55] p858snake|l: No, I gotta get up-a, a-get on up, get on the scene-a, a-like a patch machine [00:58:58] <^demon|away> James_F: Oh btw, I hit a VE bug today. It might be totally obvious and known, but anyway. I had to fix: https://www.mediawiki.org/w/index.php?title=Requests_for_comment/CirrusSearch&diff=prev&oldid=711384 [00:59:20] ^demon|away: Hmm. Did it look OK in the viewer? [00:59:23] <^demon|away> When I made the previous edit with VE, everything *looked* ok. I pressed enter and tab to indent one. [00:59:24] <^demon|away> Yep [01:00:36] New patchset: Brian Wolff; "Doc fixes for MediaHandler. No behaviour changes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68838 [01:00:56] * Reedy waits for the tests to fail [01:01:13] ^demon|away: You went with CirrusSearch! Ah that's awesome. [01:01:34] Searching clouds? [01:01:36] Is it webscale? [01:01:50] <^demon|away> Yes, webscale is one of the design requirements. [01:02:27] <^demon|away> marktraceur: Yeah, we liked that one. Doesn't seem to be used by anyone, still remotely enough related to the original name to identify it. [01:02:42] * marktraceur points at https://www.mediawiki.org/wiki/Extension:SunnySearch [01:07:09] I hate localization [01:09:25] <^demon|away> Silly bugs are silly: https://github.com/facebook/hiphop-php/issues/812 [01:10:46] ^demon|away: silly bugs? (link to jidannis bug submissions here) >.> [01:11:10] <^demon|away> I figured that went without saying [01:24:21] New review: Brian Wolff; "I feel like this should be done automatically by a script or the credits file will become outdated. ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [01:28:08] New review: Brian Wolff; "The bug got wontfixed. If you want this in core, convince the people who wontfixed the bug that it r..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/59373 [01:28:51] New patchset: Amire80; "Cleanup ext.uls.languagesettings.js" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68839 [01:34:59] Reedy: still awake? :) [01:39:05] Yup [01:40:05] yay [01:40:15] can you rerun the translation dump [01:40:18] I should be set there [01:40:22] and then we're almost ready [01:40:24] finally [01:40:27] * Jamesofur kicks things [01:42:21] Jamesofur: Do you want them copying to terbium again? [01:42:35] You didn't remove the category! :p [01:42:40] Reedy: yeah, but I won't need more then 3 minutes on them [01:42:56] because they're still wiki pages and someone would bitch at me more then they already would given the short cuts I was taking ;) [01:43:02] I'll fix that when I review them [01:43:04] easy enough [01:43:23] Pushed [01:43:55] Reedy: group writable please :) [01:44:09] done [01:44:29] they start as apache:apache on tin [01:44:38] and only apache can write [01:50:50] ok translations set [01:51:05] New review: Parent5446; "Is there any plan to move the tests that are in qa/browsertests here?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68729 [01:52:04] Reedy: both translations and the list look ok [01:52:36] I think we may finally be ready [01:53:03] Reedy: did you sync the change for the email name? (I assume so) [01:53:11] given how long I made you wait for the translations [01:53:17] haha [01:53:18] I think I did [01:53:57] reedy@tin:/a/common$ grep -i Wikimedia php-1.22wmf6/extensions/SecurePoll/cli/wm-scripts/bv2013/sendMails.php [01:53:57] $sender = new MailAddress( 'board-elections@lists.wikimedia.org', 'Wikimedia Foundation Election Committee' ); [01:53:57] $subject = 'Wikimedia Foundation Elections 2013'; [01:54:04] yup [01:54:05] cool [01:54:20] all right, time to dive off the depend :) [01:54:24] deep too [02:01:23] Jamesofur: Oh FFS [02:01:33] Remind me to beat werdna the next time I see him [02:01:34] what happened? [02:01:45] deal [02:01:47] what he do? [02:01:51] list( $site, $name, $address, $lang ) = explode( "\t", trim( $line ) ); [02:01:55] Oh, Reedy, I almost forgot, beat werdna next time you see him [02:02:00] ^ one format using one script [02:02:03] another format using another script [02:02:10] so what was in the file was right to work with doSpam [02:02:14] but not to work with the bash script [02:02:18] RAAAAAARRRGGHH [02:02:23] * Jamesofur sighs [02:03:00] * Jamesofur pets Reedy [02:03:04] New patchset: Reedy; "Revert "Fix parameter list order when splitting a string"" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68842 [02:03:15] New patchset: Reedy; "Revert "Fix parameter list order when splitting a string"" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68842 [02:03:23] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68842 [02:03:48] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68843 [02:04:20] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68843 [02:05:12] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68844 [02:06:44] heh, addshore should have an email ;) [02:07:02] Reedy: they all going through? [02:07:05] *going out [02:36:26] New patchset: Reedy; "Fix parameter order to match actual in sendMail.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68847 [02:37:41] GOD [02:37:43] DAMN [02:37:43] IT [02:37:47] The birds are already singing [02:37:54] and I haven't gone to bed yet [03:22:10] Reedy: wanna merge https://gerrit.wikimedia.org/r/#/c/68558/ for me? its just backporting a patch from master to REL1_21 [03:26:08] Poor Reedy. [03:26:42] Change merged: Reedy; [mediawiki/extensions/DynamicPageList] (REL1_21) - https://gerrit.wikimedia.org/r/68558 [03:42:46] Reedy: ty :) [04:29:00] New patchset: Skizzerz; "fix bug" [mediawiki/extensions/RegexFunctions] (master) - https://gerrit.wikimedia.org/r/68628 [04:29:57] Change merged: Skizzerz; [mediawiki/extensions/RegexFunctions] (master) - https://gerrit.wikimedia.org/r/68628 [05:19:42] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [05:25:51] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [05:57:00] New review: Nemo bis; "Bawolff, yes, but the whole CREDITS file is updated manually and irregularly." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [06:12:06] Poor Reedy indeed. I'm curious to see how my notification will look like. Oh wait, I have voted already, silly me. [06:14:11] Luckily Jamesofur|away removed wikitext from the email. :D https://meta.wikimedia.org/w/index.php?title=Wikimedia_Foundation_elections_2013/Voter_e-mail/it&diff=5571207&oldid=5564962 [07:33:22] New patchset: Liangent; "Initial version of the extension" [mediawiki/extensions/PageLanguage] (master) - https://gerrit.wikimedia.org/r/68852 [08:20:27] New review: Mattflaschen; "This is a really cool idea." [mediawiki/extensions/UIFeedback] (master) C: -1; - https://gerrit.wikimedia.org/r/50004 [08:44:34] New patchset: Ori.livneh; "Add API module for retrieving JSON Schema" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [09:46:03] New patchset: Raimond Spekking; "Fix typo in extension description message key" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68853 [09:46:38] Change merged: Raimond Spekking; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68853 [10:11:47] New patchset: Raimond Spekking; "Some consistency tweaks in preparation for adding extension to translatewiki.net" [mediawiki/extensions/Ads] (master) - https://gerrit.wikimedia.org/r/68855 [10:16:19] New review: FastLizard4; "Code review looks good, tests out okay. Approved and merged." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68613 [10:16:19] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/68613 [10:40:21] New patchset: Kipcool; "* replaced deprecated ow_DefinedMeaningAttributes by ow_Relations * changed a few while by foreach" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68856 [10:42:12] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68856 [11:10:55] New patchset: Rjain; "changed the way namespaces are checked" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/68857 [12:34:30] Pft, JSDuck doesn't impress me much at all. [12:35:14] The authors hardcoded a pile of Ext stuff into it. [12:36:16] And instead of properly writing a system for documenting JavaScript libraries. [12:36:52] They write something so rigidly focused on classic classes that they'd have been better off writing a non-JS documentation tool. [12:38:06] You can't link to global functions. You can't document namespaced functions. When you try to namespace a function by making it a method on a faux class you can't link to it. [12:38:47] You can't document objects that aren't classes without pretending they are classes. [12:39:17] And naturally you can't simply document objects nested in objects. [12:59:49] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [14:13:23] ori-l: hmm eventlogging server doesn't work in 10.04 [14:16:01] New patchset: Alex Monk; "Parse duplicate-defaultsort error message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [14:23:00] ori-l: hmm python-jsonschema is not listed as required package? [14:32:13] New review: Liangent; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [14:35:36] New patchset: Alex Monk; "Show an edit link for discussion page headers even if the user can't edit it" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/68860 [14:45:05] New patchset: Alex Monk; "Parse duplicate-defaultsort error message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [14:58:05] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [14:59:42] New patchset: Rtdwivedi; "1. Separated index functions from pages. 2. Separated setting up editing system from the main class ProofreadPage. Change-Id: I0b841a32f2ea00b742d8e06e71984bc0d6edce42" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68861 [15:04:35] New patchset: Nikerabbit; "Prepare ULS for EventLogging" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862 [15:08:05] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [15:22:31] New patchset: Amire80; "Make Display settings the default view for the cog Language settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [15:22:35] New patchset: Umherirrender; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [15:22:58] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [15:28:41] New review: Liangent; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68859 [15:35:33] Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68663 [15:36:59] New patchset: Reedy; "Remove contrib directory and add gitignore to ignore it" [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/68863 [15:38:23] New review: Yuvipanda; "Merging crash fix." [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68663 [15:44:17] Change merged: jenkins-bot; [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/68863 [15:52:02] New patchset: Eranroz; "Add pagination support to watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [15:55:29] New patchset: Eranroz; "Add pagination support to watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [16:06:53] New patchset: Rtdwivedi; "1. Separated index functions from pages. 2. Separated setting up editing system from the main class ProofreadPage. Change-Id: I0b841a32f2ea00b742d8e06e71984bc0d6edce42" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68861 [16:06:54] New patchset: Rtdwivedi; "Separated data fetching from presentation and data manipulation from the page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68204 [16:08:48] New patchset: Eranroz; "Add pagination support to watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [16:08:49] New patchset: Eranroz; "Support ApiPageSet in ApiWatch" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53964 [16:21:42] New review: Yuvipanda; "Just another comment (Testing more SuchABot stuff)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68663 [16:22:50] New review: Yuvipanda; "Another comment" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68663 [16:24:31] New review: Yuvipanda; "Testing patch" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:24:53] New review: Yuvipanda; "Anpther" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:25:10] New review: Yuvipanda; "Another" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:28:01] New review: Yuvipanda; "One more" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:28:23] New review: Yuvipanda; "tetete" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:54:17] New review: Yuvipanda; "Gerrit today is so inactive I need to put in fake comments to have it send me events :(" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:55:27] New review: Yuvipanda; "Another one." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [16:59:57] YuviPanda: it's saturday, what did you expect? :P [17:00:04] MatmaRex: exactly that :) [17:00:20] MatmaRex: but writing that out is better than just writing crap spam comments, don't you think so? [17:00:37] haha [17:00:42] * YuviPanda is building a pseudo-reliable 0mq+redis based pubsub server for our Gerrit Events [17:00:52] hmm, I think the buzzword quotient on that was high enough :P [17:01:07] MatmaRex: didn't we have someone's bot that automatically added people as reviewers based on some preconditions? [17:02:23] YuviPanda: yeah, it's somewhere on mw.org [17:02:32] * MatmaRex is looking for it [17:04:42] YuviPanda: https://www.mediawiki.org/wiki/Git/Reviewers [17:04:51] I think there is one on my servers too [17:04:53] hi MatmaRex [17:05:17] ah, thanks MatmaRex [17:05:23] hi YuviPanda [17:05:27] ohai Nikerabbit [17:05:48] hm, [[mw:Git]] is a redirect to [[mw:Gerrit]] [17:05:58] and it has like 30 subpages… https://www.mediawiki.org/w/index.php?title=Special%3APrefixIndex&prefix=Git%2F&namespace=0&hideredirects=1 [17:06:57] hmm, if I want a 'cryptographically secure set of random numbers' [17:07:02] I should just cat /dev/random [17:07:04] I guess [17:07:18] okay that was a stupid idea [17:07:37] I read "cryptographically secure set of random users" [17:07:43] heh [17:07:48] this just a secret key [17:12:26] New review: Yuvipanda; "Not particularly creative at writing these" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [17:12:33] You don't particularly need /dev/random over /dev/urandom [17:12:44] YuviPanda: MWCryptRand [17:13:08] DanielFriesen: no, this was a one time thing. I just generated it using one of those django generators [17:13:12] hey, DanielFriesen, speaking of MWCryptRand [17:13:22] (just replacing default secret key for some redis stuff) [17:13:26] wanna review https://gerrit.wikimedia.org/r/#/c/64565/ ? ("Refactor watchlist token handling") [17:23:14] Nikerabbit: still there? i just fixed https://github.com/wikimedia/jquery.uls/pull/97 to really actually work for realsies [17:34:05] ugga [17:54:28] New review: Daniel Friesen; "I'll need to find some time to actually checkout the code and test it before I can give a +1." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [17:59:28] DanielFriesen: you can see this live on http://users.v-lo.krakow.pl/~matmarex/testwiki/?uselang=en , if you want :) [18:07:34] MatmaRex: btw I'm (ab)using that token for something else [18:08:11] liangent: well that's not nice of you to do. but if this gets merged, you could easily add a new one [18:08:27] liangent: (and all existing use-cases should keep working like they did anyway) [18:08:50] liangent: (it's still readable and modifiable via the options API, for example) [18:09:14] MatmaRex: https://zh.wikipedia.org/wiki/User:Liangent/Scripts/AutoTrigger.js the script [18:10:21] liangent: ah, i was thinking in an extension. well, you can't add new ones then, but what you're doing there should keep working just like it did before [18:12:45] MatmaRex: ok [18:15:12] MatmaRex: would you use another approach if you designed that script? [18:16:28] liangent: that token is basically used for CSRF protection, right? [18:16:51] liangent: you could use mw.user.sessionId() for this, i think [18:19:34] MatmaRex: yes [18:19:42] is that sessionId used somewhere else? [18:22:34] liangent: not in core. i think eventlogging or something uses this [18:22:51] or maybe not, it doesn't grep [18:24:33] MatmaRex: it'll be saved in browser history in my use case. it doesn't look nice if this sessionId is used somewhere else critical [18:26:05] i'm pretty sure it's not intended for anything even remotely close to 'critical' :) [18:26:29] liangent: it's even a sessioncookie [18:26:35] (disappears when you close your browser) [18:27:17] liangent: you could also generate a random token yourself and store it in cookies or localStorage [18:27:37] sessionStorage* [18:27:47] (or just pass the information this way instead of via URL parameters, i've got a script that does that) [18:29:21] I'm changing it to use mw.user.sessionId() now [18:29:33] but what does "pass the information this way" mean? [18:30:45] liangent: hm, okay, maybe it doesn't make much sense when you have the information already in the href [18:31:30] liangent: i meant something like i'm doing in https://pl.wikipedia.org/wiki/MediaWiki:Gadget-disFixer.js - grep for calls for createCookie and readCookie [18:32:45] (and please don't judge me, that code is old :P) [18:37:21] MatmaRex: That's not bad at all. You should see my old js code [18:38:31] bawolff: well, it was spiffed up just a tiny bit, in a true wiki fashion [18:39:03] bawolff: the 2009 versions are slightly more horrific :P [18:39:23] nobody spiffs up my wikinews user js :( [18:39:44] bawolff: implicit globals galore [18:42:30] do you have a habit of writing comments in your mother tongue instead of english? [18:42:31] btw, thanks for reviewing my commit, I eagerly look forward to the day when you can +2 stuff :) [18:43:32] MatmaRex: ^ and I guess this solution may fail in concurrent actions [18:43:48] ie some user is using this tool in two tabs of the same browser [18:45:54] liangent: no, but i used to ;) see - old code [18:46:27] hm, yeah, possible - i think i include wgPageName in the key to prevent that [18:46:42] yeah, that's what i do [18:46:50] bawolff: heh, thanks [18:47:32] That's from an entirely selfish perspective of I want my code merged ;) [19:15:17] New review: Parent5446; "(1 comment)" [mediawiki/extensions/Annotator] (master) C: 1; - https://gerrit.wikimedia.org/r/68857 [19:40:06] New patchset: Eranroz; "Add pagination support to watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [20:11:22] Yippie, build fixed! [20:11:23] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #105: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/105/ [20:11:58] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [20:12:21] New review: Parent5446; "OK, so I only have a few more comments. Sorry for being so picky. After this I think I'll be OK with..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53968 [20:12:25] Yippie, build fixed! [20:12:25] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #122: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/122/ [20:20:51] Yippie, build fixed! [20:20:52] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #52: FIXED in 9 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/52/ [20:29:54] Yippie, build fixed! [20:29:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #91: FIXED in 9 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/91/ [20:35:29] Yippie, build fixed! [20:35:29] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #102: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/102/ [20:43:11] New patchset: Eranroz; "Add pagination support to watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [20:53:18] Yippie, build fixed! [20:53:19] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #130: FIXED in 23 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/130/ [20:56:27] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53964 [20:58:28] Yippie, build fixed! [20:58:29] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #98: FIXED in 22 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/98/ [21:06:44] Yippie, build fixed! [21:06:44] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #59: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/59/ [21:08:17] New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [21:11:26] New review: J; "like the idea of making the full error message a link, that way the table looks better too." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68814 [21:11:53] New review: Yuvipanda; "There is a cat in my lap" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:12:13] New review: Brian Wolff; "Ok. marking -1 to remind myself to redo this patch" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/68814 [21:14:55] New review: Parent5446; "(1 comment)" [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/68211 [21:16:45] New patchset: Darkdadaah; "New SQL file to import with LOCAL INFILE" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68931 [21:16:45] New patchset: Darkdadaah; "Reduce the counter as there are searches that have only a few items to find" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68932 [21:16:45] New patchset: Darkdadaah; "Improve pronunciation detection on the form line + pron section" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68933 [21:17:46] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68931 [21:17:58] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68932 [21:18:08] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68933 [21:23:01] New patchset: J; "Tune Special:TimedMediaHandler" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [21:23:41] New review: Yuvipanda; "Test" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:23:59] New review: Yuvipanda; "Another test?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:27:51] New review: Yuvipanda; "fdsfd" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:28:47] New review: Yuvipanda; "meh?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:29:26] New review: Yuvipanda; "Uhm, wut mate?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65598 [21:39:49] New review: Ori.livneh; "Hey Niklas, I'm going to update the patch to reflect some accumulated experience w/managing a soft d..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862 [21:46:41] New patchset: Ori.livneh; "Prepare ULS for EventLogging" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862 [21:57:07] Yippie, build fixed! [21:57:07] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #82: FIXED in 5 min 12 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/82/ [22:27:43] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #329: FAILURE in 9 min 55 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/329/ [22:31:11] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862 [22:31:58] ori-l: working on weekend? [22:32:27] Nikerabbit: gerrit is outside space-time [22:33:47] ori-l: I can believe [22:34:40] you mentioned something about access to stat1 [22:35:08] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68862 [22:35:17] and I don't know if you already had a look on the schema... it needs more tweaking still [22:35:18] Nikerabbit: just about to e-mail you the details, actually :) [22:37:02] I had some issues running the server on ubuntu 10.04 lts (might be that I didn't follow the instructions correctly) but it worked fine on my fedora localhost [22:43:50] Nikerabbit: what was the error on ubuntu? [22:49:32] New patchset: Amire80; "Add a test to check the appearance of the IME menu" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68934 [22:50:07] ori-l: one missing python package I think [22:50:59] hmm are there docs on how the redis stuff on mw's job queue is done? [22:53:05] PandaWithACat: I don't think there's a whole lot yet. The source code is in includes/job/JobQueueRedis.php. There's some documentation in includes/job/README. Your best bet is probably to read through the source and maybe use 'git log includes/job/JobQueueRedis.php' to read the commit messages. [22:53:18] hmm, alright [22:53:30] PandaWithACat: I haven't looked around though, so check mw.org anyway. [22:53:43] yeah, I checked - there's a paragraph on [[Redis]] [22:53:45] but... that's it [22:53:51] so I'll probably need to look at code [22:54:16] PandaWithACat: the people involved with writing / managing it are pretty active on wikitech-l, too, so if you have some specific questions you could ask there. [22:54:17] I'm building a gerrit-stream pseudo-reliable thing of sorts, and am trying to figure out how mw did the queueing [22:54:22] sweet [22:54:31] PandaWithACat: oh, queueing on redis is easy [22:54:47] ori-l: so I don't want to just push + pop. there are a few other issues. [22:55:02] ori-l: multiple clients who all want the same stream [22:55:10] and need buffered, reliable feeds [22:55:27] ori-l: plus this is on tools-labs with a shared redis server, so I'm unsure if we can actually share keys [22:55:55] ori-l: so every key from every app needs to be prefixed with a secret key, for security purposes [22:56:06] zeromq is available in the apt repos and it's what i've recently used to have buffered reliable feeds [22:56:09] (we also killed all (hopefully?) of the commands of redis that make it possible to list keys, etc [22:56:33] yeah, i've been reading up on 0mq, and though their pubsub thing is probably not going to suit me I think the regular req/recieve is good enough [22:57:09] ori-l: where did you use it, btw? [22:57:24] with redis you can maintain a list of app keys, and have a lua script stuff incoming events into each app's queue [22:57:53] hmm, a shared secret / API Key sortof thing? [22:58:12] ori-l: oh, separate queue for each app? [22:58:25] it's a lot of data duplication... [22:58:26] just have your publish call be an EVAL to a lua script that does: for (each key in app_keys) { put msg in queue }. it'll be very fast, since it's all executed on the server [22:58:30] but it *will* make stuff a lot simpler [22:58:43] network programming = lots of data copying [22:58:58] it's ok, if you're dealing with gerrit data the amount of data is quite miniscule [22:59:03] I was thinking of the in memory stuff, but I guess that isn't something I should be wrorying about [22:59:12] indeed [22:59:22] caught with a case of premature optimization there, I think :) [22:59:36] hmm, so shared secret keys + 1 queue per app should work :) [22:59:39] you can call LTRIM or whatever on each app's queue [22:59:42] in the lua script [22:59:44] yeah [22:59:46] to limit the buffer [22:59:56] hmm, yeah - and it'll also be a per-app buffer [22:59:56] nice [23:00:21] sortedset with timestamp as score works well too for this sort of thing [23:01:27]