[00:01:29] also I'd like to know why it's necessary to reduce the average expiry time so severely, is the cache really full of file objects? [00:01:54] New patchset: Arrbee; "Adding ULS test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [00:02:00] is there a reason to think that a file, when uploaded, will probably not be accessed again? [00:03:22] maybe for some data sets, that is the case, but surely every file on commons is accessed a few times for review [00:03:42] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #126: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/126/ [00:03:50] New patchset: Ryan Lane; "Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126 [00:05:35] Change abandoned: Ori.livneh; "(no reason)" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68593 [00:10:24] New patchset: Ryan Lane; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [00:10:25] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [00:11:53] New patchset: Anomie; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [00:12:10] New review: Anomie; "PS14: Add comment." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [00:12:41] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/67872 [00:19:50] New review: Cmcmahon; "Some issues:" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [00:24:26] New patchset: Ryan Lane; "Show more informative instance status" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65269 [00:25:17] New patchset: Ryan Lane; "Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126 [00:33:10] New patchset: Ryan Lane; "Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126 [00:33:19] New review: Tim Starling; "The implication seems to be that the probability of access per unit time, and thus the value of a ca..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/67880 [00:36:35] New patchset: Mattflaschen; "Fix bugs, refactor and cleanup user state/cookie code:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68326 [00:38:12] New review: Mattflaschen; "Okay, I think this is ready for review. I fixed a few bugs. I have some ideas for refactoring appr..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68326 [00:44:25] New patchset: Mattflaschen; "Check for multiple arguments, tweak error message, add test." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154 [00:50:54] New patchset: Tim Starling; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [00:51:28] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [00:56:09] New review: Anomie; "I like TheDJ's take on this in changeset 68601 better." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [00:57:22] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [00:57:50] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [00:58:12] RoanKattouw: If you're around and alive, I had a more interesting VE bug for you. [00:58:16] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=49411 [00:58:21] Though that may also be Parsoid. [00:59:02] New patchset: Anomie; "API: Fix action=parse without any page or title or text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63138 [01:00:09] Elsie: First one is a known Parsoid issue with it occasionally pulling stuff from other wikis. Though this is the first time I've seen it with French content, usually it's German (and we know of one case where it picked Russian) [01:00:23] Second one, ditto [01:00:34] Hrmph. [01:00:44] gwicke: Do you guys have an open Bugzilla ticket about the Parsoid-randomly-decides-German-dominates-the-world bug somewhere? [01:00:57] 49411 should be duped to that if it exists [01:01:08] It seems all I find is Parsoid bugs. [01:01:36] , , weird normalization of attributes/template parameters, unexpanded templates in the wrong language. [01:02:24] Yeah well, all serialization bugs are either in ve.dm (VE data model), or in Parsoid [01:02:24] New review: Anomie; "Trivial rebase in RELEASE-NOTES-1.22, no code change, Tim already +2ed the previous version." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63138 [01:02:50] Most VE bugs that we know of right now are in different components of VE and don't directly affect wikitext sanity [01:03:12] Although they may affect your ability to get to the wikitext diff by overlaying something on top of the save button ;) [01:03:23] Heh. [01:03:30] Yeah, I did catch some of those bugs. [01:03:36] Z-index weirdness. [01:04:02] Yeah [01:04:11] We have interesting UI bugs [01:04:21] I had another weird one involving transparency, but I haven't filed it yet. [01:04:24] One of the ones I worked on recently turned out to be a rendering bug in Webkit [01:04:26] It's sitting on my desktop on another computer. [01:04:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63138 [01:13:48] New review: Mattflaschen; "Anomie, not sure what you mean. That's for a different issue, but are you saying I should split it ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [01:16:01] New review: Anomie; "Oh, you're right. I was just confused." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [01:18:57] TimStarling: the assumption is more so that files that haven't change in a long time are less likely to change [01:19:16] thus you don't have to worry about key re-mapping on server failure so much [01:20:51] New review: Tim Starling; "In answer to the question in your comment: yes, the voter list can be extracted directly from the da..." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [01:22:16] in any case it's all a tricky problem, and very annoying when files show up missing that were just uploaded (like during the eqiad switchover) [01:22:38] maybe just the negative caching ttl can be tweaked [01:22:41] New patchset: Anomie; "Add missing break in switch" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68608 [01:23:48] if negative entries had a timestamp stored, they could do application-level invalidation that can lengthen the next cache time based on the previous negative cache time [01:23:52] New patchset: Anomie; "Make CentralAuth login more silent" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [01:24:03] though all that would start over on cache server restart or something [01:24:16] New review: Anomie; "Rebase" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [01:24:59] or disable remapping on cache set for this particular cache [01:25:01] New patchset: Anomie; "Make CentralAuth login more silent" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199 [01:26:35] TimStarling: then you might really get some master queries [01:26:49] I remember asher I talking about halving two pools (one that remaps and one that doesn't) [01:27:10] that could work if we used slaves in that case [01:27:38] if we knew that get() failed due to server issues, one could fetch from a slave and not recache [01:27:47] then having a non re-mapping pool could work better [01:28:23] New patchset: Mattflaschen; "Add overlay hook for user scripts." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [01:28:24] though...somethings might use wfFindFile() et al as reads to determine a write [01:28:31] I'm not sure if there's any option for it in Memcached::setOption(), but it would be possible to use setByKey() [01:28:34] though realistically there should have been a parameter for that [01:29:44] Change merged: Aaron Schulz; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68608 [01:46:34] TimStarling: anyway, let me know if you have any specific alternative ideas on this [01:51:43] AaronSchulz: so the problem is that a negative cache entry is created in the canonical server, then purged in the remapped server, then fetched again from the canonical server? [01:52:10] right, same problem with updated versions (though not as severe in effect AFAIK) [01:52:34] * AaronSchulz might be the last person in the office [01:52:44] ...nope [01:53:04] ok, heading home for now [01:53:06] do you have to turn off the lights and set the alarm if you're the last one out? [01:53:24] TimStarling: yes, that's why I'm leaving before I stuck doing that [01:53:27] * ASchulz|away is gone [01:53:33] hehe, it's a race [02:35:43] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [02:51:30] New review: Mattflaschen; "Looks good, except allowAutomaticOkay is not really optional (it's explicitly defaulted to true in a..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [03:12:05] New review: Mattflaschen; "I confirmed it locally. I must messed something up when testing earlier." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66394 [03:14:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [03:18:41] New patchset: RAN1; "Remove unnecessary closure from JS module" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/68613 [03:30:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [03:33:59] New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [03:53:52] where is teh T13|ClassSOC102 ? [03:54:03] * jeremyb runs away [04:33:46] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [04:39:07] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [04:44:23] New patchset: Mwjames; "Don't run the ParserTextProcessor on SpecialPages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68008 [04:50:13] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68008 [05:05:13] New patchset: Pastakhov; "Add PCRE Functions (version 0.4.3)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67965 [05:06:10] New review: Pastakhov; "fix and optimize function process_slashes()" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67965 [05:25:07] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [05:49:20] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [06:20:11] New patchset: Mwjames; "(Bug 33181) Special:Concepts to list available concepts" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [06:21:45] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [06:25:03] New patchset: Santhosh; "Make the link to undo language change usable" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68616 [06:28:38] New review: Tim Starling; "Fine in concept, but I haven't completely reviewed the diff." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/68199 [06:33:10] New patchset: Tim Starling; "(bug 47449) {{#special:}} should always return a usable title" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60105 [06:34:00] Change abandoned: Santhosh; "patch submitted to upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68408 [06:36:34] New review: Tim Starling; "Needs change to DatabaseBase::factory(), per my comment on I7334c487" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62173 [06:36:51] New patchset: Ori.livneh; "Add API module for retrieving JSON Schema" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [06:37:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60105 [06:38:06] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [06:38:42] New review: Nikerabbit; "This change is useless unless you make it https://www.mediawiki.org. The current one just redirects ..." [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68549 [06:41:16] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [07:52:17] New review: Nikerabbit; "Better but it looks like the hide timers are not cleared correctly:" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/68616 [08:12:53] New review: Santhosh; "that must be another bug and fix. I did not touch any code related to timers in this patch." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68616 [08:50:47] New patchset: Ori.livneh; "Add API module for retrieving JSON Schema" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68617 [10:17:04] New patchset: Jeroen De Dauw; "Update name of dataValues repo as it got changed" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68624 [10:35:51] New patchset: Jeroen De Dauw; "Fix Wikibase dependencies and add WikibaseDataModel, WikibaseDatabase and WikibaseQueryEngine" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68626 [10:44:46] New patchset: Pastakhov; "fix bug" [mediawiki/extensions/RegexFun] (master) - https://gerrit.wikimedia.org/r/68627 [10:45:01] New review: Daniel Kinzler; "It would be very nice if we could maintain this file ourselves." [integration/jenkins-job-builder-config] (master) C: 1; - https://gerrit.wikimedia.org/r/68626 [10:50:31] New patchset: Pastakhov; "fix bug" [mediawiki/extensions/RegexFunctions] (master) - https://gerrit.wikimedia.org/r/68628 [11:15:20] New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [11:16:36] New review: Matmarex; "JavaScript looks good, apart from what seems like a bug in Address#notifyError. I left some other mi..." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/65421 [11:17:30] New review: Matmarex; "(Also, I didn't test nor run the code, I assume you did. :) )" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [11:17:51] New review: Njw; "(1 comment)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [11:20:16] New review: Njw; "Many thanks for the review Jon, most helpful - I didn't realise the viewport tag was required for mo..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [11:24:01] Change merged: Demon; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68626 [11:33:40] New review: Matmarex; "Minor comments on the JS, looks nice." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/60783 [11:39:10] New review: Matmarex; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) C: 1; - https://gerrit.wikimedia.org/r/65557 [11:40:52] @notify Ryan_Lane [11:40:52] I'll let you know when I see Ryan_Lane around here [11:47:03] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64251 [11:52:57] New review: Nikerabbit; "I will approve this and file a new bug then." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/68616 [11:53:13] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68616 [11:57:57] New review: Nikerabbit; "https://bugzilla.wikimedia.org/show_bug.cgi?id=49574" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68616 [12:04:38] New patchset: J; "only fail jobs that have actually started" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68636 [12:36:40] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [12:42:24] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [12:43:40] New patchset: J; "Add support for FLAC audio files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [12:54:48] New patchset: J; "Update transcode table with more errors if job fails" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68645 [12:59:04] New review: Nikerabbit; "Didn't test." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/68211 [13:00:01] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [13:11:37] New patchset: J; "Update transcode table with more errors if job fails" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68645 [13:13:29] New patchset: Nikerabbit; "Narayam and WebFonts were replaced with ULS" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68647 [13:18:47] New patchset: J; "More accurate timming for captions, progress event fixes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998 [13:21:48] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68160 [13:21:48] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68154 [13:23:09] New patchset: Matmarex; "Set preference 'watchlisttoken' to type=api" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [13:23:11] New review: Matmarex; "> Just a thought, we could consider moving it wholly to a separate Special page?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64565 [13:23:44] MatmaRex: ugh new special pages? [13:26:04] hi manybubbles [13:26:08] hi! [13:28:46] Nikerabbit: just a little one. subpage of preferences, really. [13:28:48] brb [13:30:33] (back) [13:30:57] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649 [13:32:09] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649 [13:32:28] New patchset: Nikerabbit; "Consistent style for generated CSS" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68651 [13:33:10] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68651 [13:33:56] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68649 [13:40:14] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [13:48:30] New review: Matthias Mullie; "Code looks good; not sure if it should already be merged given your valid remark regarding usability" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/64858 [13:49:24] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65415 [13:56:31] New patchset: Anomie; "Cleanup bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [13:56:31] New patchset: Anomie; "More coding style fixes to elections-2011-spam imports" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68654 [13:57:01] New review: Anomie; "PS3: Rebase" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [14:26:04] New patchset: Jeroen De Dauw; "Added gireview file" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68658 [14:26:26] New patchset: Jeroen De Dauw; "Rename files to WikibaseDatamodel" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68659 [14:26:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68658 [14:27:03] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68659 [14:31:26] New patchset: Anomie; "Cleanup bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [14:33:15] New review: Anomie; "PS4: Implement changes suggested by Nemo and Tim" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [14:34:26] New patchset: Ragesoss; "Add gender-neutral pronouns and correct grammar" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/68661 [14:34:49] New patchset: SuchABot; "Maintain max width / height info to speed up image downloading" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68662 [14:35:00] New patchset: SuchABot; "Do not crash in details view if we try to view local image" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68663 [14:38:09] New patchset: Jeroen De Dauw; "Update file name in composer.json" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68664 [14:38:46] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68664 [14:40:21] New patchset: Jeroen De Dauw; "Add TravisCI config" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68665 [14:40:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68665 [14:41:55] I filed https://bugzilla.wikimedia.org/49580 didn't see any older bugs related [14:42:25] New patchset: Jeroen De Dauw; "Update package dependency on Wikibase Database" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68666 [14:42:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68666 [14:56:37] New patchset: Darkdadaah; "More SQL queries to move the new tables without dropping the old ones, and allow to move the old ones in case the new tables fail." [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68671 [14:58:06] New patchset: Jeroen De Dauw; "No longer allow standalone mysql and sqlite falures and this should now work" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68672 [14:58:15] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68671 [15:04:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68624 [15:06:31] New patchset: Jeroen De Dauw; "Update irc channel in composer.json" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68673 [15:07:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68673 [15:09:12] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68672 [15:09:30] Yippie, build fixed! [15:09:30] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #102: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/102/ [15:18:00] New patchset: Jeroen De Dauw; "Tweak gitignore file" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68675 [15:18:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68675 [15:18:59] New review: Jeroen De Dauw; "Leaving +2 to the i18n people" [mediawiki/extensions/EducationProgram] (master) C: 1; - https://gerrit.wikimedia.org/r/68661 [15:23:22] New patchset: Jeroen De Dauw; "Update composer.lock file" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68676 [15:23:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68676 [15:25:25] manybubbles: I love your phrasing of "we don't want to barf at our users, just into our logs" [15:46:11] New patchset: Jeroen De Dauw; "Guard against multiple loading" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68678 [15:46:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68678 [15:48:46] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68654 [15:55:01] New patchset: Jeroen De Dauw; "Make standalone builds non optional on travis ci" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68680 [15:55:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68680 [16:03:53] Yippie, build fixed! [16:03:54] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #127: FIXED in 24 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/127/ [16:08:19] New patchset: Jeroen De Dauw; "Update data values package name in composer.json" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/68682 [16:09:25] New patchset: Jeroen De Dauw; "Update gitignore file" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68683 [16:09:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/68682 [16:12:15] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68683 [16:25:06] New review: Anomie; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [16:38:12] New review: Parent5446; "@CSteipp - Honestly, it'd be preferable if the User class just wasn't handling this stuff. The User ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [16:52:52] New patchset: Lewis Cawte; "Change HTTPS links to www per Nikerabbit's comment on I203f553f0cac1d0b18d9d46980816038caa00b16." [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68688 [16:54:13] New review: Lewis Cawte; "Oh, forgot about that!" [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68549 [16:55:18] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [16:56:11] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [16:57:17] New patchset: Lewis Cawte; "Change URL to https://www.mediawiki.org as https://mediawiki.org redirects to HTTP." [mediawiki/extensions/FeaturedFeeds] (master) - https://gerrit.wikimedia.org/r/68689 [17:00:47] hi Ryan_Lane [17:00:55] howdy [17:00:57] i commented on the JS stuff [17:01:03] thanks for the reviews :) [17:01:14] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [17:11:44] New patchset: Lewis Cawte; "HTTPS MediaWiki.org redirects to HTTP, so changing to WWW." [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/68692 [17:19:23] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [17:20:53] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68636 [17:21:13] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [17:21:50] Change merged: jenkins-bot; [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/68692 [17:23:37] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68645 [17:23:54] New patchset: Lewis Cawte; "HTTPS MediaWiki.org redirects to HTTP, so changing to WWW." [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/68693 [17:25:08] j^: gah, I noticed something after merging [17:25:10] $this->setTranscodeError( $transcodeKey, $result ); [17:25:17] $result is a Status not a string [17:26:14] I guess it can call getWikiText() [17:27:10] AaronSchulz: will have a look [17:30:12] New patchset: Lewis Cawte; "HTTPS MediaWiki.org redirects to HTTP, so changing to WWW." [mediawiki/extensions/Solarium] (master) - https://gerrit.wikimedia.org/r/68695 [17:36:23] Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/68693 [17:36:39] Change merged: jenkins-bot; [mediawiki/extensions/Solarium] (master) - https://gerrit.wikimedia.org/r/68695 [17:37:01] Attention, smart JavaScript people: I want to make a class into an event emitter, but it's not really a DOM element...how should I do this? In Node I'd use EventEmitter, but that doesn't seem to be available in the same form, and events seem focused on the DOM. [17:37:15] Basically I want a class that I can extend, but that may or may not be the best solution [17:37:27] Change merged: jenkins-bot; [mediawiki/extensions/FeaturedFeeds] (master) - https://gerrit.wikimedia.org/r/68689 [17:39:25] I guess I could just use jQuery event handling [17:39:39] Or the fancy new Promise stuff [17:40:28] Yeah, Deferreds and Promises are good enough for this. [17:42:20] New patchset: Hashar; "triggers for three wikibase extensions" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68696 [17:43:49] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68697 [17:44:36] hey hashar [17:45:11] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [17:45:28] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68696 [17:46:19] New review: Hashar; "Zuul config https://gerrit.wikimedia.org/r/68696" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68626 [17:47:42] New review: Tychay; "Also a small grammatical error fix. :-)" [mediawiki/extensions/EducationProgram] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/68661 [17:48:28] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68699 [17:48:40] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68697 [17:48:47] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [17:48:53] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68699 [17:50:51] New patchset: J; "pass text not status object to setTranscodeError" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68700 [17:51:21] New patchset: Hashar; "new wikibase extensions have tests" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68701 [17:51:44] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68701 [17:51:50] AaronSchulz: https://gerrit.wikimedia.org/r/#/c/68700 [17:52:05] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68697 [17:52:21] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [17:52:25] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68699 [17:52:44] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68700 [17:54:27] New patchset: Aaron Schulz; "Made purgeDeletedFiles.php delete files still in the public zone." [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68702 [17:55:30] New patchset: AzaToth; "Copying and modifying operations/debs/gerrit into gerrit" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [17:55:38] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [17:56:14] New patchset: Jeroen De Dauw; "Ignore composer.lock" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68704 [17:56:27] JeroenDeDauw: the WikibaseQueryEngine extensions should have an entry point file named WikibaseQueryEngine.php (it is currently QueryEngine.php ) [17:56:38] wrong chan [17:57:30] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [17:57:38] New patchset: Jeroen De Dauw; "Add Wikibase prefix to files" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68705 [17:57:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68705 [17:57:55] New patchset: Jeroen De Dauw; "Ignore composer.lock" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68704 [17:59:13] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68702 [17:59:44] New patchset: Jeroen De Dauw; "Added WikibaseDatabase as missing dependency to WikibaseQueryEngine" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68706 [18:01:48] New review: Aaron Schulz; "No the assumption is that the long a file a gone unchanged, the less likely it is to change and ther..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67880 [18:02:07] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [18:04:23] New review: Hashar; "deployed" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/68706 [18:04:23] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68706 [18:04:48] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [18:06:23] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [18:09:31] New patchset: Jeroen De Dauw; "Added Diff as missing dependency to WikibaseQueryEngine" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68708 [18:10:33] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68708 [18:10:58] New patchset: Jeroen De Dauw; "Ignore composer.lock." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68704 [18:11:29] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [18:12:26] New patchset: AzaToth; "Copying and modifying operations/debs/gerrit into gerrit" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [18:13:58] New patchset: Jeroen De Dauw; "Fix file name in composer.json" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68709 [18:14:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68709 [18:15:45] New patchset: Jeroen De Dauw; "Fix 1i8n file name" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68710 [18:16:11] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68710 [18:16:38] New patchset: Jeroen De Dauw; "Ignore composer.lock." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68704 [18:17:14] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68704 [18:22:09] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [18:24:53] New patchset: Lewis Cawte; "HTTPS MediaWiki.org redirects to HTTP, so changing to WWW." [mediawiki/extensions/ApiSandbox] (master) - https://gerrit.wikimedia.org/r/68713 [18:25:41] New patchset: Subramanya Sastry; "Turned off parsoid-parsertests job since it is redundant now" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68714 [18:27:43] New patchset: Jeroen De Dauw; "Exclude two not really needed jobs for Travis" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68715 [18:27:52] marktraceur: Is your UploadWizard fix going out today or Monday? It's in the LD calendar for Monday... [18:27:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68715 [18:28:15] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT).." [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68698 [18:29:19] James_F: It's not clear - it would depend on it getting merged today [18:29:47] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68714 [18:30:03] marktraceur: https://gerrit.wikimedia.org/r/#/c/68574/ ? [18:31:23] That's the one, ori-l [18:31:33] Would deploy later today if it's merged [18:31:39] Because apparently, we're that crazy [18:32:09] I am off again [18:32:48] bye hashar [18:34:16] marktraceur: do you ever call UploadWizardUploadInterface? [18:34:30] oh, yes, never mind. [18:35:36] marktraceur: I can review it more thoroughly in a bit, but in the meantime I'm leaving a quick review suggesting another way to tackle this. [18:35:55] New patchset: Aklapper; "Copy unchanged files from default to custom as preparation for custom changes" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/68717 [18:35:58] New patchset: Aklapper; "Change generic "login" string to "email address"" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/68718 [18:36:21] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68574 [18:36:49] Change abandoned: Aklapper; "Superseded by https://gerrit.wikimedia.org/r/#/c/68717/ and https://gerrit.wikimedia.org/r/#/c/68718/" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42105 [18:37:16] ori-l: Or, you know, someone could merge it [18:37:31] Thanks Krenair [18:37:54] Looks like there'll be some deploying in my future [18:38:15] yw marktraceur [18:38:43] my exams finished today so I have time for stuff like this now [18:39:10] Huzzah [18:39:47] Krenair: I may take advantage of that soon, I'm in the middle of rewriting...a lot of UploadWizard. Notably: No more reservedIndex, use Promises and Deferreds for the transports [18:39:57] Probably more as I keep going [18:41:43] New review: Ori.livneh; "there's only ever one mw.UploadWizardUploadInterface instance, right? If so, instead of using a cons..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68574 [18:42:19] ori-l: Oh, no, there are Interface instances for each Upload [18:43:19] Sorry about the confusion [18:43:35] marktraceur: well, just means you need to refactor a bit more thoroughly. this '_this' everywhere business is messy. [18:43:47] Hah. [18:44:02] ori-l: Believe me, I know. I'm working through some portion of that right now. [18:44:15] The alternative is to bind() a lot, maybe [18:44:26] Or use self instead of _this, or something [18:45:43] I can take a look later today probably [18:45:50] gotta run for now. [18:46:23] *nod* [18:53:50] New patchset: Matmarex; "Refactor watchlist token handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [18:55:26] New review: Matmarex; "PS5 is a completely new and IMO much better approach than what we currently have. Man, user interfac..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [18:56:41] New review: Matmarex; "For anybody wishing to test this, it's currently live on my test wiki: http://users.v-lo.krakow.pl/~..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [19:02:17] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [19:02:29] New patchset: Anomie; "Return errors from WatchAction" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [19:09:48] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [19:14:31] New patchset: Matmarex; "Refactor watchlist token handling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [19:16:48] Change merged: MaxSem; [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68688 [19:17:16] Change merged: jenkins-bot; [mediawiki/extensions/ApiSandbox] (master) - https://gerrit.wikimedia.org/r/68713 [19:18:56] New review: Dzahn; "yes, confirmed these are the existing files from ./template/en/default/account/auth/ as on kaulen. c..." [wikimedia/bugzilla/modifications] (master) C: 2; - https://gerrit.wikimedia.org/r/68717 [19:19:15] New review: Dzahn; "yes, confirmed these are the existing files from ./template/en/default/account/auth/ as on kaulen. c..." [wikimedia/bugzilla/modifications] (master); V: 2 - https://gerrit.wikimedia.org/r/68717 [19:19:16] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/68717 [19:20:01] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [19:22:57] New patchset: Arrbee; "Adding more test scenarios for ULS user settings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [19:23:11] New review: Matmarex; "@Isarra:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [19:24:43] New review: Dzahn; "http://en.wiktionary.org/wiki/email_address" [wikimedia/bugzilla/modifications] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68718 [19:24:46] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/68718 [19:31:23] are there any multi-get (multiple keys in one round trip) options for memcached in mediawiki? i looked through MemcachedBagOStuff and related, but doesnt look like it. wanted to make sure before i make the multiple round trips [19:32:37] * ebernhardson is blind ... somehow missed getMulti in the client specific implementations just not in the base implementation [19:34:03] New review: Amire80; "* About starting from English: The tests should specify particular languages, rather than saying "cl..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [19:40:52] New review: Dzahn; "looks good but i don't know how/if this is actually deployed" [wikimedia/bugzilla/wikibugs] (master) C: 1; - https://gerrit.wikimedia.org/r/54984 [19:41:49] * Isarra hugs MatmaRex. [19:41:58] * Isarra wraps marktraceur in kelp. [19:42:03] * Isarra jumps out the window. [19:43:32] hi Isarra. [19:44:18] New review: Anomie; "I agree, messing around with the animation is too much messing around in things that shouldn't be me..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [19:47:30] New review: Aaron Schulz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [19:47:54] Isarra: You be trippin' [19:47:58] And hi [19:53:17] Tripping on my own feet. [19:53:19] Hello. [19:53:28] Isarra: How goes't? [19:53:48] Ghaaaaack. [19:54:21] That well, eh? [19:55:06] Heh. >.< [20:06:22] New review: AlephNull; "May I request the reviews re-review this patch? " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [20:11:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #103: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/103/ [20:12:10] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #120: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/120/ [20:17:10] New review: Brian Wolff; "I found some minor formatting issues (Note I didn't really do a review of the functionality, just lo..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65301 [20:17:13] New patchset: EBernhardson; "Rename index for sqlite support" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68728 [20:21:05] New patchset: Demon; "Remove Selenium tests from core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68729 [20:21:06] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #50: FAILURE in 9 min 22 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/50/ [20:21:43] <^demon> Heh...+0, -8143 [20:21:54] New review: EBernhardson; "Per guidelines, a bug has been filed as 49593 to have the indexes (possibly) renamed in production." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68728 [20:21:55] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #50: FAILURE in 9 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/50/ [20:22:09] New review: EBernhardson; "production database update bug : https://bugzilla.wikimedia.org/show_bug.cgi?id=49593" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68728 [20:22:38] ^demon: <3 [20:22:51] these are annoying me every single time i grep for something [20:22:58] New review: Mattflaschen; "Good to see someone's looking at it. I saw a minor issue in the i18n, and I'm wondering if the ID3 ..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/68642 [20:23:32] csteipp, I've CC'd you to https://bugzilla.wikimedia.org/show_bug.cgi?id=49592 ... given that this is a security feature i'm guessing the request to remove it is a wontfix [20:27:12] New review: Cmcmahon; "between the design problems here and the age of these tests, I don't see any value in keeping these" [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/68729 [20:35:38] New patchset: AzaToth; "Copying and modifying operations/debs/gerrit into gerrit" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [20:38:26] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #128: FAILURE in 8 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/128/ [20:38:56] New patchset: AzaToth; "Copying and modifying operations/debs/gerrit into gerrit" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [20:42:37] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #57: FAILURE in 4 min 10 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/57/ [20:43:11] Hi. Is it a bad practice to have the data fetching functions to be public in a class? [20:44:19] heavily depends on circumstances [20:46:15] I have a class that fetches data from the DB. Its functions are public because they need to be called in other classes. Is it safe in this case? Or should I elaborate more? [20:49:45] * MaxSem sees no problem [20:51:11] Ok. Thank you! :-) [20:52:11] Krinkle: You're currently my favorite person [20:52:29] I'm flattered, thanks mark [20:52:31] I'm rewriting huge bits of UploadWizard to use Deferreds and Promises [20:52:37] So, what is it you need this time :P [20:52:38] And all the API methods already use them [20:52:47] No no, I needed something you already did [20:52:51] So you're my favorite [20:53:03] Are you sure you don't need anything? [20:53:14] Pretty sure [20:53:17] * marktraceur thinks [20:53:18] k :) [20:53:40] Krinkle: Yeah, unless you want to help this insane rewrite that I'm doing, don't need anything currently [20:54:10] Krinkle: If you have time to help marktraceur, you have time to work on VE things. :-) [20:54:26] * marktraceur throws a kitten at James_F [20:54:31] :-) [20:54:32] Krinkle: Quick, while he's distracted! [21:05:04] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68728 [21:05:19] New review: Worden.lee; "Thanks! Am doing some more work on it, so will wait to resubmit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67173 [21:05:24] Krinkle: Do you have a moment? [21:08:54] New review: Bsitu; "Good to know there is already an existing way to handle this, guess I need to find out the person wh..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297 [21:11:44] New patchset: MarkTraceur; "Update UploadWizard to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68731 [21:14:56] New patchset: Aaron Schulz; "Fixed doc typo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68732 [21:15:51] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68731 [21:16:56] New review: AlephNull; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [21:18:06] New patchset: AlephNull; "(bug 43571) Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [21:19:39] New review: Brian Wolff; "If you set color.diff to auto using git config, git diff/git show will highlight whitespace issues f..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [21:20:53] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68732 [21:20:57] New patchset: Reedy; "Update inclusion of commandLine.inc" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68734 [21:30:34] New review: EBernhardson; "I've been thinking about the user experience, as I see it there are two options, perhaps kaldari co..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [21:31:02] Damn it [21:31:03] one short [21:31:21] ^demon, why does gerrit output gitblit links for changes in the labs/private repository? [21:31:24] they don't work... [21:32:52] <^demon> Because gerrit doesn't know better. [21:33:16] New patchset: Reedy; "Update inclusion of commandLine.inc" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68734 [21:33:47] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68734 [21:34:16] New review: EBernhardson; "I've been thinking about the user experience, as I see it there are two options, perhaps kaldari cou..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [21:34:23] New review: Reedy; "(1 comment)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [21:37:37] New patchset: Reedy; "Add updated scripts for bv2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68738 [21:39:40] New patchset: Reedy; "Cleanup bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [21:41:01] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [21:43:12] James_F: anomie|away I think we should be good to go with the email scripts.. [21:43:47] well, need to update SP code on the cluster, but that's more incidental [21:43:52] * Jamesofur nods [21:43:57] Reedy: I think you want Jamesofur. :-) [21:44:01] ;oinf [21:44:03] csteipp: is there any reason not to close https://bugzilla.wikimedia.org/show_bug.cgi?id=46903 ? [21:44:12] I have a feeling the translation pages on meta may give us some annoyance [21:44:13] James_F: Considering I had just PM'd him [21:44:16] faail [21:44:36] Reedy: Though I too have a major e-mail push coming, it's not this one. :-) [21:44:37] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #327: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/327/ [21:44:42] but if so I can fix that by just quickly making plain text versions of those pages [21:45:16] Are they inventing stuff again? [21:45:38] all of the translation mark up crap [21:45:56] that's a yes then [21:45:56] that was not there for the previous iterations [21:45:57] :D [21:45:59] ;) [21:47:04] I know anomie|away is off for 5-6 hours but if we can at least try to test the scripts out it would be great. [21:47:21] AaronSchulz: Let's call it dead after the UX signoff next wed [21:47:31] Can't realy see why we can't run them if things are ready.. [21:47:52] I think Tim just suggested for helping update the scripts [21:48:35] https://wikitech.wikimedia.org/wiki/SecurePoll#Email_spam [21:48:41] doSpam should be ready, you can use /home/jamesofur/noemail-boardelections for the noEmail list [21:48:53] (just updated) [21:48:57] let me update the code on the cluster for starters [21:49:00] * Jamesofur nods [21:49:02] should only take a couple of mins [21:49:46] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68760 [21:50:12] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68764 [21:50:25] * Jamesofur goes ahead and creates non translate markuped translations [21:51:34] Hmm, Special:TimedMediaHandler seems to do a full table scan of transcode table. That seems like it would be expensive [21:51:48] Maybe that should go onto a TODO list for the localisation team for next year [21:52:03] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68764 [21:52:19] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68760 [21:53:29] bawolff: "only" 81953 rows on commonswiki [21:54:58] Guess it can't be too bad, after all hasn't caused any performance alarm bells to ring [21:55:19] But I imagine we should have an index on the relavent field [21:56:37] can't harm things [21:56:44] Jamesofur: sooooooo [21:57:34] Reedy: want to just run the list creator and see how it goes? ;) I'm still creating the stripped translations though you could try running that and seeing how badly it breaks [21:58:15] the only thing you should have to edit on the doSpam is board-vote-2011 --> 2013 and switch the no email list to mine [21:58:37] Oh fail [21:59:01] I did that in my amendment to brads commit [21:59:06] New patchset: Reedy; "Add updated scripts for bv2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68738 [21:59:14] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68738 [21:59:19] * Reedy grumbles [21:59:56] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68801 [22:00:33] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68802 [22:00:50] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68801 [22:01:00] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68802 [22:01:24] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68642 [22:01:31] Reedy: that's pointing to the wrong place for emails too ;) [22:01:37] New patchset: Darkdadaah; "New small tool: simple pairwise list comparison" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68803 [22:01:37] New patchset: Darkdadaah; "Small bugs" [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68804 [22:02:53] New patchset: Reedy; "2011 -> 2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68805 [22:03:16] New patchset: Brian Wolff; "Fix warnings on Special:TimedMediaHandler (undefined variable line 164)" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68806 [22:03:24] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68805 [22:03:56] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68807 [22:04:13] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68808 [22:04:27] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68807 [22:04:36] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68808 [22:04:40] New patchset: MarkTraceur; "Update UploadWizard to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68809 [22:05:51] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68803 [22:05:57] $specialWikis = array_map( 'trim', file( '/home/wikipedia/common/special.dblist' ) ); [22:05:59] Damn it [22:06:01] There's always one [22:06:08] $prefix = "Board_elections/2013/Email/"; $textPrefix = '
'; $textSuffix = "
\n[[Category:Board elections 2013]]"; [22:06:09] should probably be $prefix = "Wikimedia_Foundation_elections_2013/Voter_e-mail/"; $textPrefix = ''; $textSuffix = "\n[[Category:Board elections 2013]]"; [22:06:19] because we could never structure things the same way two years in a row [22:06:24] Change merged: Darkdadaah; [wiktionary/anagrimes] (master) - https://gerrit.wikimedia.org/r/68804 [22:06:59] New patchset: Reedy; "/home/wikipedia -> /a/common" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68810 [22:07:10] lmfao [22:07:26] Let's fix that next then [22:07:31] It's a good job there's a lot of numbers [22:08:13] lol [22:08:21] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68810 [22:11:41] New patchset: Reedy; "More minor year specific updates" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68811 [22:11:55] Jamesofur: ^ [22:12:29] yup, that should do it [22:12:47] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68811 [22:20:19] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68812 [22:20:34] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68813 [22:22:09] New patchset: Brian Wolff; "Missing whitespace between previous message and show error link." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68814 [22:22:18] i'm glad I wrote a script to do that ;) [22:22:23] lol [22:22:49] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68813 [22:23:01] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68812 [22:24:03] lol Reedy [22:25:14] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68806 [22:27:01] New patchset: Ori.livneh; "Fix typo ('associed' => 'associated')." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68815 [22:27:04] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68809 [22:28:34] huh [22:28:48] too fast for me [22:29:55] Jamesofur: You don't have access to tin, do you? [22:30:13] negative [22:30:58] I guess get-voter-list will probably take 10-15 minutes at the most [22:31:22] yeah, if that, we don't have nearly as many voters as I'd like [22:31:57] echo "SELECT '$wiki', user_name,user_email,up_value FROM securepoll_lists JOIN user ON li_member=user_id JOIN user_properties ON up_property='language' AND up_user=user_id WHERE li_name='board-vote-2013' AND user_email_authenticated IS NOT NULL;" [22:32:16] It's a very cheap query based on an already minified list.. sorta hope it'd be quick ;) [22:32:33] heheh [22:32:35] yeahhh [22:32:51] been shocked before but it shouldn't be ;) [22:33:54] well, it's already past enwiki [22:34:07] reedy@tin:/a/common$ wc -l elections-2013-spam/users-by-wiki [22:34:07] 12711 elections-2013-spam/users-by-wiki [22:35:20] 15278 [22:36:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68815 [22:37:35] 20k [22:38:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68467 [22:41:36] 30k! [22:41:52] Jamesofur: 31112 done [22:41:57] yay! [22:42:18] do you want to try and run the build translations script? [22:43:00] dump! [22:43:03] not build ;) [22:43:14] Oh, no [22:43:16] ignore that [22:43:20] :p [22:43:22] buildSpamTranslations.php [22:46:02] eugh, didn't notice where it writes it to [22:46:05] live hacks [22:46:28] lol, does it still write to andrew's folder? [22:46:44] nope, in the folder where the script is [22:46:45] $file = dirname( __FILE__ ) . "/email-translations/" . $lang; [22:46:53] ahhhhh [22:49:12] hacked for now [22:49:30] hmm, nothing on first run.. [22:49:58] hmm [22:49:59] https://meta.wikimedia.org/wiki/Special:PrefixIndex/Wikimedia_Foundation_elections_2013/Voter_e-mail/ [22:50:40] right… it should get all of those ... [22:50:41] Oh, looks like it's using old code [22:50:41] fail [22:51:00] lol [22:51:39] New patchset: Amire80; "Make Display settings the default view for the cog Language settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68816 [22:52:08] better [22:52:12] complaining about file permissions [22:52:40] that's a step [22:52:58] it's used to running in home directory lol [22:53:13] Done [22:53:31] 16 lines each [22:54:29] Do you want them putting somewhere for you to check? [22:54:43] that would be good, I have a feeling I'm going to have to make a couple small tweaks [22:54:51] a couple of them are assuming access to {{GENDER}} [22:54:54] which they don't have [22:55:19] Yup [22:55:32] ast, ca, es, fr, gl, ms, yi [22:56:57] Jamesofur: /tmp/translations on terbium [22:57:03] thanks lookin [22:59:25] Reedy: can you do me a favor and make them group writable? [23:00:17] or I can give you the small changes for those ones :) [23:00:17] done [23:00:20] thanks [23:00:25] helps if type the right commands [23:02:07] New review: Cmcmahon; "Besides making browser tests pass consistently, I think it is good to present a consistent user expe..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/68816 [23:02:18] New patchset: Kaldari; "New primary and secondary links" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68817 [23:02:33] New review: Kaldari; "Not ready yet" [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/68817 [23:03:35] New review: Kaldari; "Sorry, I was confused." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/67589 [23:04:14] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67589 [23:06:37] Reedy: should be set [23:06:56] test email time, if we can send a test email for all of the languages it would be best [23:06:59] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59530 [23:07:10] unless there are a couple more maint scripts that still need to run not he list [23:07:48] We need to dump the noemail list to a file? [23:07:57] straight from a page on meta? [23:08:41] you should be able to copy mine, I have it at /home/jamesofur/noemail-boardelections on terbium [23:08:51] grabbed it from the wiki page an hour ago [23:09:23] great [23:10:09] Moved to nomail-list-stripped [23:10:52] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [23:11:42] doSpam.php followed by sendEmails [23:11:50] though we can test them first [23:11:53] yeah [23:11:57] let's do some test emails first [23:12:03] so that we see how they come out [23:12:11] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59530 [23:12:16] $transTemplates[$lang] = file_get_contents( 'email-translations/' . $lang ); [23:12:17] especially with the username replacement [23:13:22] $langs = explode( ' ', 'bar be-tarask bg bn bs ca cy da de diq el en eo es fa fi fr gl he hi hy id ' . [23:13:22] 'is it ja lb mr ms nb nl pl pt ro ru si sk sq sv tr uk vi yi yue zh-hans zh-hant' [23:13:22] ); [23:13:37] I think we might need to update that, or at least, wrap the loop that uses them in a file_exists [23:13:39] yeah, we probably need to update that [23:13:41] yeah [23:14:36] New patchset: Reedy; "Update path" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68820 [23:15:04] $content = $transTemplates[$lang]; [23:15:44] * Reedy checks [23:18:09] New patchset: Reedy; "Update path" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68820 [23:18:25] Reedy: hey. do you have any idea how we log PHP fatal errors in production ? [23:18:43] Uhh [23:19:02] the ones in beta are only sent over syslog [23:19:10] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68820 [23:20:00] hashar: role::logging::mediawiki [23:20:12] That's in site.pp for fluorine, probably a good place to start [23:20:18] thanks : [23:20:19] ) [23:20:51] oh udp2log [23:21:26] New patchset: Matmarex; "AJAXify watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63274 [23:21:42] New review: Matmarex; "Addressed comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63274 [23:22:01] New patchset: Reedy; "Fixup output path of buildSpamTranslations" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68822 [23:22:38] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68822 [23:23:13] * marktraceur swears loudly at the still not-functional UploadWizard refactor [23:23:32] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68823 [23:23:51] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68823 [23:24:02] Reedy: so there is a wmerrors extension that send an udp packet to some production server. I guess that is my problem. Thx for the hint [23:24:47] That sounds about right [23:24:59] yeah I got them by using tcpdump [23:25:06] need to write yet another puppet change grmblbl [23:26:51] Jamesofur: do you want 35 emails then? [23:27:33] Reedy: works for me :) [23:27:47] let's create a spamlist of all you [23:28:08] ahhharh [23:28:18] heh, I feel like there are a couple companies that already have one built for us [23:28:19] yet another bug, php-fatal-error.html from mediawiki-config.git is not in git :-D [23:34:01] Reedy: I have added php-fatal-error.html to git https://gerrit.wikimedia.org/r/68825 :D [23:34:10] last modified by Roan in 2011 [23:34:11] Jamesofur: I think that language list in sendMails list isn't sufficient [23:34:38] we must have a way to get all languages from MW [23:34:40] hmm, interesting, what's it doing? [23:47:26] New patchset: Reedy; "Fix parameter list order when splitting a string" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68826 [23:47:51] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68826 [23:56:33] New patchset: Reedy; "Uppercase replacement parameters" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68828 [23:56:49] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68828