[00:05:32] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68303 [00:10:55] New patchset: Parent5446; "Fixed bug in Special:Sessions with variable name" [mediawiki/extensions/SecureSessions] (master) - https://gerrit.wikimedia.org/r/68320 [00:11:51] hi rachel99 [00:12:44] New patchset: Parent5446; "Fixed incorrect variable name in SpecialSessions" [mediawiki/extensions/SecureSessions] (master) - https://gerrit.wikimedia.org/r/68321 [00:13:05] Change merged: Parent5446; [mediawiki/extensions/SecureSessions] (master) - https://gerrit.wikimedia.org/r/68321 [00:13:48] New review: Parent5446; "Minor style issues, but everything seems to work." [mediawiki/core] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/62173 [00:26:45] New patchset: Kaldari; "Switching to short date headers based on user prefs (sort of)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68323 [00:29:28] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [00:35:43] New review: Aaron Schulz; "Is easier for debugging in test setups (like looking at the objectcache table) and when looking at e..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [00:37:41] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [00:38:25] New patchset: Mattflaschen; "Fix bugs, refactor and cleanup user state/cookie code:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68326 [00:42:31] New patchset: Kaldari; "Switching to short date headers based on user prefs (and timezone)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68323 [00:45:52] New patchset: Kaldari; "Switching to short date headers based on user prefs (and timezone)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68323 [00:49:49] New patchset: Mattflaschen; "Check for multiple arguments, tweak error message, add test." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154 [00:58:59] New patchset: Hiong3-eng5; "Transaction.php script cleaning" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68328 [01:02:44] New review: Raylton P. Sousa; "Thank you :)" [mediawiki/extensions/BookManager] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66194 [01:02:52] Change merged: Raylton P. Sousa; [mediawiki/extensions/BookManager] (master) - https://gerrit.wikimedia.org/r/66194 [01:13:04] Project browsertests-test2.wikipedia.org-linux-chrome build #381: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/381/ [01:13:39] New patchset: Mattflaschen; "Remove gt.initGuider, allow one guider per tour at a time:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171 [01:14:42] Yippie, build fixed! [01:14:42] Project browsertests-test2.wikipedia.org-linux-firefox build #341: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/341/ [01:18:47] New review: Mattflaschen; "Alright, this is my last ping to Siebrand about this. If you feel strongly this shouldn't be merged..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52749 [01:21:11] New review: Mattflaschen; "mw.hook is merged, so this is ready for review." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [02:07:30] New review: Jamie Thingelstad; "THANK YOU! Applied diff and can confirm fixes issue!" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68287 [02:25:13] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [02:26:26] New patchset: Parent5446; "Added throttling framework." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34677 [02:27:50] New patchset: Bsitu; "(bug 47666) All system messages should have sender = -1" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68329 [02:27:55] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [02:31:59] Elsie: your blacklist is barely half the size of fenari's. Very disappointing. [02:33:36] New review: Ori.livneh; "Your blacklist is contains barely half as many entries as the one on fenari. Very disappointing. We ..." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [02:42:58] https://wikimediafoundation.org/wiki/Bugzilla_administrator_rights_policy [02:43:01] ori-l: ^ [02:43:50] I wish I'd gotten a screenshot of the new Bugzilla homepage with old CSS. [02:43:56] It was neat. [02:44:01] Bizarre, but neat. [02:52:57] Change abandoned: Karim.rayani; "abodoning, the feature was not required." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62223 [02:53:53] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [02:54:45] Change abandoned: Karim.rayani; "This commit fails due to dependency on the kind of data displayed which is not consistent, abandonin..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62231 [03:05:48] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [03:07:26] New patchset: Parent5446; "Changed temporary password system to use tokens." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27472 [03:32:33] New review: Emufarmers; "I figured obscenity generation would be a good candidate for crowdsourcing, anyway. :)" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [03:39:03] New patchset: Ori.livneh; "Add a default blacklist for FancyCaptcha." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [03:40:23] New review: Ori.livneh; "PS4 adds entries from prod which were not present in earlier patchsets." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [03:57:10] New patchset: Ori.livneh; "Add a default blacklist for FancyCaptcha." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [03:57:52] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/53124 [04:10:42] New patchset: Santhosh; "Add UnifrakturMaguntia font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68333 [04:14:14] Elsie: http://tools.wikimedia.pl/~odder/screenshots/Bugzilla-MainPage.png [04:14:42] Yeah, I had some version of that! [04:14:44] alternate title: "Zarro's last stand" [04:14:55] I actually saw the text, but with the color underneath. [04:15:03] And I was like "uhh, I guess that's a way to style the links." [04:15:15] Oh, the text is there, just shifted. [04:15:22] On mine, it aligned properly. [04:15:30] Silly, silly. [04:15:55] http://i.imgur.com/xOg1ESY.png [04:16:03] ! [04:16:03] ok, you just typed an exclamation mark with no meaning in the channel, good job. If you want to see a list of all keys, check !botbrain [04:16:20] * Elsie growls. [04:16:25] What caused the colors? [04:16:51] And what makes the sad search icon sad? [04:20:12] zarro's demise, obviously [04:20:44] I wish I'd gotten a screenshot of the new Bugzilla homepage with old CSS. [04:21:05] what you're seeing is actually the new CSS applied against the old HTML [04:21:32] wait, no. that can't be right. [04:21:53] new html, old css. [04:31:52] ori-l: I tried to replicate with new HTML and old CSS. [04:31:59] And I still don't get where the colors are coming from. [04:38:20] New patchset: Santhosh; "Add Linux Libertine font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68334 [04:40:45] New review: MZMcBride; "Brad: I copied you on this change. Would it be possible to add this changeset to the agenda of the n..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [04:41:45] New review: Mattflaschen; "Prop is undeclared." [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/68140 [04:47:39] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67483 [04:50:03] New patchset: Jeroen De Dauw; "Fix breakage due to changes in base class in core" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66025 [04:50:07] New patchset: Jeroen De Dauw; "Fixed phantom log entries for "course updates" that havent happened" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66032 [04:50:39] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66025 [04:50:48] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66032 [05:02:43] New patchset: Hiong3-eng5; "API:SynonymsTranslation - corrections etal" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68336 [05:07:35] New review: Hiong3-eng5; "syntrans[] did not work as thought. I was able to check it just now on the Windows. I am trying to u..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68336 [05:10:31] New review: Hiong3-eng5; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68336 [05:26:21] New patchset: Amire80; "Allow disabling of IME by class or id" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [05:26:26] New patchset: Physikerwelt; "(Bug 48952) Show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [05:27:43] New patchset: Physikerwelt; "Replace SimpleXml by Mediawiki library" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [05:29:00] New review: KartikMistry; "LGTM." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/68333 [05:38:50] New review: KartikMistry; "Can we use latest version? Or have to use this only? See: http://sourceforge.net/projects/linuxliber..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68334 [05:52:51] New patchset: Santhosh; "Set the language for the settings panel for correct webfonts" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67825 [06:09:14] New patchset: Mattflaschen; "Add preference change logging; modified version of Echo code." [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [06:11:13] New review: Kaldari; "This was already done in some other revision a week or two ago." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/67589 [06:11:43] New review: Santhosh; "Does not fix the bug. Where are we defining the ids or class for captcha fields in this patch?" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/68339 [06:16:11] New review: Amire80; "This allows adding the problematic id or the class manually in LocalSettings. For example, for the a..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [06:20:08] New review: Krinkle; "What's wrong with an explicit flush?" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68186 [06:20:33] New review: Kaldari; "I guess this is fine if we merge change I7896abbc as well. Not my area of expertise, so I'll give it..." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/65316 [06:22:26] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [06:24:24] New patchset: Mattflaschen; "Add preference change logging; modified version of Echo code." [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [06:25:37] New review: Santhosh; "wpCaptchaWord is in core right? Why can't be that a default value for noImeIds?" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [06:32:57] New patchset: Kaldari; "Adding diff link to talk page notifications for email" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [06:36:18] New patchset: Kaldari; "Adding diff link to talk page notifications for email" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [06:40:37] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67401 [06:42:10] New review: Kipcool; "Strange that sytrans [] does not work. But fine :-)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68336 [06:42:30] New review: Kipcool; "Strange that sytrans [] does not work. But fine :-)" [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68336 [06:42:31] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68336 [06:43:32] New review: Kipcool; "Thanks for doing that :-)" [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68328 [06:43:33] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68328 [06:48:56] New review: Siebrand; "I think we should include the latest version of the font. This one appears to be of February 2012, a..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/68333 [06:50:14] New patchset: Amire80; "Allow disabling of IME by class or id" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68339 [06:52:41] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67875 [06:58:14] New patchset: Nischayn22; "Correct email validation" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68342 [06:58:28] New review: Siebrand; "I created bug 49510 for the version update." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/68333 [06:58:44] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68333 [06:58:57] New review: Siebrand; "I created bug 49511 and bug 49512 for version update and adding small capital variant." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 2 - https://gerrit.wikimedia.org/r/68334 [07:21:58] New patchset: Mormegil; "(bug 47449) {{#special:}} should always return a usable title" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60105 [07:24:45] New patchset: Santhosh; "Add Linux Libertine font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68334 [07:27:19] New review: Mormegil; "Not sure why it works for everyone including Jenkins and not for me, but the parser test fails for m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [07:28:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68334 [07:40:25] Published patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [07:42:28] New review: Wikinaut; "This PS7 uses Html::rawElement in the cases where the content component already is message class->es..." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/68211 [07:51:56] New patchset: Ori.livneh; "'encapsulate' => 'prepare'; computed properties" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140 [08:04:18] New review: Parent5446; "Haven't tested yet." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/68211 [08:09:22] * YuviPanda pounces on hashar with https://bugzilla.wikimedia.org/show_bug.cgi?id=49500 [08:11:08] New review: Matthias Mullie; "Chrome & Safari (probably all webkits) show the top left number (the total amount of posts, on feedb..." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67970 [08:11:50] New patchset: Hashar; "experimental breadcrumb display" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343 [08:12:53] hashar: would switching be hard? [08:13:22] New review: Hashar; "Hello Timo, that is a very rough work in progress. You can try it out by setting up pathinfo and th..." [integration/docroot] (master) C: -1; - https://gerrit.wikimedia.org/r/68343 [08:13:36] YuviPanda: hello [08:13:47] heya! [08:14:30] YuviPanda: are you dropping Github entirely ? :D [08:15:02] hashar: well, primary reason is a little selfish - we'll still use GitHub pull requests for CR, but use my GitHub to Gerrit Bot (SuchABot) for code merging / syncing :P [08:15:08] so... [08:15:36] so you probably want the app to be build whenever a patchset is submitted [08:16:12] that is not necessarily hard but need a bit of engineering to clean up the old mess and make it more robust [08:16:27] hashar: hmm, whenever it is merged, I think? [08:16:30] ah [08:16:35] submitted, Gerrit terminology, merged, okay [08:16:56] apps ... [08:17:08] that is an awful generic name for gerrit projects hehe [08:18:17] hashar: 'submitting'? [08:18:32] sorry [08:18:39] so people will send pull requests to github [08:18:47] then a bot upload a patchset in gerrit [08:19:13] yeah [08:19:16] we can't really trigger tests / build on such patchsets that would mean anyone can run anything in jenkins [08:19:30] (i.e. that is untrusted code) [08:19:36] hashar: no, I want them to run *after* they are merged [08:19:41] ahh [08:19:43] post commit ok [08:19:49] don't we have a job for that app already ? [08:20:08] hashar: yes, but it is pulling from GitHub [08:20:18] and when I looked at the job config it looked rather GitHub specific [08:20:34] indeed [08:21:26] hashar: so didn't want to touch that ;) [08:21:52] cp commons/target/commons-1.0-SNAPSHOT.apk /srv/org/mediawiki/integration/nightly/mobile/android-commons/android-commons_${BUILD_ID}.apk [08:21:53] cp commons/target/commons-1.0-SNAPSHOT.apk /srv/org/mediawiki/integration/nightly/mobile/android-commons/android-commons_${GIT_COMMIT%??????????????????????????????}.apk [08:21:53] ln -f -s /srv/org/mediawiki/integration/nightly/mobile/android-commons/android-commons_${GIT_COMMIT%??????????????????????????????}.apk /srv/org/mediawiki/integration/nightly/mobile/android-commons/android-commons_latest.apk [08:22:02] that is the part I need to make more robust [08:23:02] hmm, the move apk to public part [08:23:22] apps/android/commons I would have loved for us to have a better path such as mobile/commons/android , but I am nitpicking [08:23:37] so yeah the move apk to public part need to be made a shell script [08:24:05] that will take as parameter the generated .apk and the git commit sha1 then do the copy / link [08:24:17] right [08:24:24] can it also pot a comment on the patchset? [08:24:24] also need to figure out how to create a maven job using Jenkins Job Builder [08:24:42] New review: Nikerabbit; "So instead of sprinkling those in the subclasses, it is better to sprinkle these all around core and..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [08:25:40] hashar: oh, that isn't how it is running right now? [08:25:56] na the job has been created manually [08:26:06] I had that in mind for quite a long time now [08:27:32] hashar: ah [08:27:44] hashar: don't we have anything else building things with maven? [08:32:51] YuviPanda: no idea :-) [08:33:08] hmm, okay :) [08:33:08] let me fix my vim install and I will look at creating the Jenkins Job template to do that [08:33:15] wonderful, hashar :) [08:34:25] for some reason my vim config does not properly auto indent in vim files :( [08:37:12] vimception? [08:38:06] what do you mean ? [08:39:14] vim not being vim enough while editing vim config files... [08:39:16] nevermind :P [08:40:26] New review: Nikerabbit; "I'm cautious about adding new features mid-deployment." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/68339 [08:43:38] hashar: The gerrit jobs (including plugins) we have are using maven to build [08:44:06] indeed :-) [08:44:17] I was looking at how to generate the job iusing Jenkins Job Builder [08:44:32] ok. [08:44:35] hashar: also, is there a gerrit / zuul instance on labs to play with? [08:44:51] qchris: ^ [08:45:15] YuviPanda: gerrit: Yes, there is gerrit-dev.wmflabs.org [08:45:24] But it's not constantly running [08:45:48] hmm, so I need to test out some zuul stuff (for GitHub integration) [08:45:53] would that be a viable place to test those on? [08:46:13] There is no zuul for gerrit-dev.wmflabs.org [08:46:47] oh :( [08:47:04] ^demon once said that hashar might have an instance for zuul to toy with. [08:47:10] ^ hashar? [08:48:28] * hashar gives up with vim [08:48:42] so yeah I have an instance in labs that has zuul + jenkins [08:48:46] but I have not upgraded it [08:48:53] * qchris lures hashar to the dark side: Use emacs. [08:48:54] yet another thing I need to maintain [08:49:39] YuviPanda. I have a local zuul running just to test gerrit connectivity. Would that be of any help? (I guess not) [08:49:51] how hard is it to setup Gerrit / zuul locally? [08:50:05] Not too hard. [08:50:11] Grab a gerrit.war file. [08:50:13] though I think that would be of little help, since I sortof want to use zuul to do some sort of 'webhooks' [08:50:34] you could point a zuul instance at the production gerrit site [08:51:00] hmm? would that actually trigger? Isn't that supposed to require a stream of some sort from Gerrit? [08:51:04] all it does is ssh to gerrit and issues the 'gerrit stream events' command, which should be accessible to you [08:51:10] ... oh? [08:51:14] Run gerrit installer (can use h2 database, so you do not need to setup any database by yourself. and you can use BECOME_ANY_ACCOUNT authentiacator) [08:51:14] that's sweet [08:51:25] hmm, wait, if that is the case can't I just use gerrit stream events directly? [08:51:30] from my tool, rather than require zuul? [08:51:56] hmm, would be more complicated though [08:51:58] YuviPanda: Yes, you can. [08:52:23] hmm, let me dig up docs [08:52:31] YuviPanda: But with the next upgrade, stream-events requires special permissions. [08:52:48] well, that's something that I can hopefully get? [08:52:51] (the tool runs on tools-labs) [08:52:56] 'ssh gerrit.wikimedia.org -p29418 gerrit stream-events' [08:53:24] your console may appear to hang, but that's because there isn't much happening at the moment. [08:53:31] YuviPanda: I hope so to. Was just meant as hint for later :-) [08:54:04] ori-l: heh, the tyranny of timezones [08:54:32] New review: Yuvipanda; "Merging minor code myself." [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68315 [08:54:39] well, that works [08:54:45] this is pretty sweet [08:54:57] and like sane people they picked JSON instead of rolling their own [08:54:59] how wonderful [08:55:48] qchris: does streams 'catch up' if something crashes? [08:56:08] What is "something"? [08:56:14] If gerrit crashes: No. [08:56:15] the listener? [08:56:35] the network dies? [08:56:37] something like that? [08:56:39] If the connection between you and gerrit goes down and you reconnect, you likely lost some messages [08:56:39] no, it doesn't buffer for disconnected subscribers [08:57:00] hmm [08:57:17] fortunately, gerrit never goes down [08:57:29] There is (was?) some signal that messages have been dropped (e.g.: gerrit queue overload). [08:57:44] So you could at least detect that. [08:57:46] hmm, I suppose it'll be easier / more reliable to just integrate with current zuul, have it do 'web hooks' [08:58:41] that way, I'll also have to make sure my code is idempotent, which is a plus when dealing with situations like this [08:58:51] New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [08:59:52] New patchset: Jeroen De Dauw; "Fix link" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68344 [09:00:24] New patchset: Jeroen De Dauw; "Added readme file" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68346 [09:00:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/68344 [09:00:42] plus the stream seems noisyish too, and there will be plenty of them I won't be interested in... [09:00:53] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68346 [09:04:09] qchris: can you grant me access to gerrit-dev so I can play with / setup zuul there? [09:04:16] (better than doing on my local, I suppose) [09:04:37] I am just a normal user on our gerrits. [09:04:43] But let me try nonetheless [09:05:48] YuviPanda: Nope. I do not have admin priviledges there. [09:05:58] qchris: hmm, no admin powers o labs? [09:06:02] * YuviPanda checks who does [09:06:29] you should be able to log in with your labs account [09:06:51] New review: Nikerabbit; "Ping? This is a dependency for a task I have in this Language Engineering team sprint." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [09:07:08] Oh you meant just to log in to the machine? [09:07:13] yes yes :) [09:07:26] adding me to the project on labs would be enough I think [09:07:39] I am not a heavy user of labs. How do I do that? [09:08:06] 'manage projects' in the left sidebar [09:08:10] qchris: on https://wikitech.wikimedia.org/wiki/Special:NovaProject [09:08:12] on https://wikitech.wikimedia.org/ [09:08:51] select the appropriate project, and you should get a table with 'actions' in the far right column, including 'add member' [09:08:59] * qchris takes a look [09:10:06] YuviPanda: why do you need to SSH in? [09:10:12] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [09:10:29] ori-l: setup zuul there? [09:10:39] always better to have it where other people can see, I think? [09:10:40] you can set it up anywhere [09:10:51] see point 2. [09:11:08] I can't do long running process on tools-labs properly yet (I think?) [09:11:16] plus gerrit-dev seemed like a good instance to do it in [09:11:24] are you no a member of other projects? [09:11:29] yeah, gerrit-dev seems appropriate [09:11:36] i'm not an admin on that, sadly [09:11:39] I am, but again, appropriateness. [09:11:46] qchris should be, I think? [09:11:54] YuviPanda: But IIRC it has not everything has been puppetized there. So I am not convinced that installing software there is a good thing. [09:11:54] etherpad / bots / mobile hardly seem like a good place for zuul [09:12:20] you mean everything has been puppetized? [09:12:22] or not been? [09:12:44] YuviPanda: Not everything has been puppetized. [09:14:25] YuviPanda: I don't think gerrit-dev has a zuul install [09:14:34] yeah, it doesn't [09:14:42] i was planning on setting it up there, but going to hold off for now [09:14:46] but I can add you to the integration project in labs [09:14:51] that has an instance with Jenkins + Zuul [09:14:55] though I will have to update them [09:14:56] ah [09:15:01] (and it has Gerrit too) [09:15:01] that'll be nice, I think? [09:15:20] New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [09:15:23] hashar: do add :) [09:15:34] New patchset: Jeroen De Dauw; "Add TravisCI config file and fix paths in PHPUnit bootstrap file" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68347 [09:15:36] hashar: does that zuul pull from our production gerrit or its local gerrit? [09:15:41] locally [09:16:27] New patchset: Nikerabbit; "Accepting and rejecting users by age" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65099 [09:16:53] Change merged: jenkins-bot; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68019 [09:16:53] YuviPanda : I have added you to the project with sudo. The instance is integration-jenkins2.pmtpa.wmflabs [09:17:07] thanks hashar! [09:17:17] * YuviPanda logs in [09:17:18] YuviPanda: we have an apache proxy which let you access that Jenkins installation via http://integration.wmflabs.org/ci/ [09:17:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68347 [09:17:59] New review: Nikerabbit; "Santhosh: is this enough to convince you to lift -1?" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [09:18:02] YuviPanda: can't remember how to log in though [09:18:29] New patchset: Nikerabbit; "Introducing TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66540 [09:18:47] * YuviPanda looks for the zuul config there [09:18:59] upgrading the instance right now [09:20:40] YuviPanda: and the Gerrit is supposed to be at http://integration.wmflabs.org/gerrit/ but it is dead :/ [09:21:17] gerrit-dev.wmflabs.org is running, tho [09:21:46] different project, but [09:22:37] SSLCertificateFile: file '/etc/ssl/certs/star.mediawiki.org.pem' does not exist or is empty [09:22:39] yeahhhh [09:25:38] there's a puppet class for that iirc [09:25:52] puppet role, even, exposed via the openstack interface on-wiki [09:27:27] hmm, I think I'll just setup zuul locally for now [09:27:30] * YuviPanda reads docs [09:33:17] grmblblb [09:35:51] New patchset: Nikerabbit; "Avoid exceptions by first checking language code validity" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68004 [09:36:02] YuviPanda: http://integration.wmflabs.org/gerrit/ :) [09:36:17] PINK! [09:37:07] LDAP integration is pretty neat [09:37:17] it is not over https though :( [09:37:24] so that expose your labs credentials [09:38:25] New review: Ori.livneh; "Code looks good. Haven't tested yet." [mediawiki/extensions/GuidedTour] (master) C: 1; - https://gerrit.wikimedia.org/r/65171 [09:42:04] New patchset: Santhosh; "Use system as default font for Tamil" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68350 [09:44:38] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68139 [09:45:29] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67346 [09:46:45] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68350 [09:49:06] New patchset: Jeroen De Dauw; "Added INSTALL.md file" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68351 [09:49:09] hashar: ow, too late [09:49:16] YuviPanda: what ? [09:49:18] well, I should change them anyway [09:49:20] * YuviPanda changes [09:49:24] didn't notice the lack of https [09:49:55] qchris: seems apt.wikimedia.org does not have the latest Gerrit version. My labs instance received 2.6-rc0-144-gb1dadd2 when production has 2.6-rc0-154-gfcdb34b ( 144 vs 154 ) [09:50:06] qchris: I guess I should ping Chad about it shouldn't i ? [09:50:20] He plans to upgrade soonish [09:50:37] oook :-) [09:50:38] * YuviPanda also enabled two factor auth [09:50:44] So I am not sure if it's worth it to get the rolled back version back it. [09:50:55] New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [09:50:57] probably not [09:51:09] Ok. [09:51:17] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67825 [09:55:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68351 [09:59:09] New review: Mattflaschen; "There's some user state stuff I want to get in here." [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/68326 [10:04:23] New patchset: Mattflaschen; "Remove gt.initGuider, allow one guider per tour at a time:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171 [10:09:32] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68159 [10:17:50] New review: Matmarex; "Just a note, posisbly not the best idea here: you could split these into separate files and have Res..." [mediawiki/skins/erudite] (master) C: 1; - https://gerrit.wikimedia.org/r/68212 [10:21:14] New review: Matmarex; "It should work, as the callback is called with a reference (`call_user_func_array( $processCallback,..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:24:20] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [10:24:49] New review: Nikerabbit; "Curiously enough I see +2 in comments but nothing in the reviewer list." [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [10:29:07] New patchset: Santhosh; "Update Lohit Tamil fonts to 2.5.3 version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68353 [10:29:31] Nikerabbit: doesn't that usually happen when one reviews an old patch? [10:29:54] as in, a new patch is uploaded during review and gerrit is confused [10:32:34] New review: KartikMistry; "LGTM." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/68353 [10:32:35] New review: Nikerabbit; "Is this the same COG as in ULS or different one? The png can be optimized further for size." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67970 [10:34:29] New review: Mattflaschen; "Ah, I missed that before. Call-time pass by reference is deprecated (see http://php.net/manual/en/l..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:35:15] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68353 [10:38:58] New review: Mattflaschen; "Actually, if I'm reading http://php.net/manual/en/function.call-user-func-array.php#refsect1-functio..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:40:22] New review: Mattflaschen; "Sorry for the confusion. I removed it to make sure Benny had a chance to review. But I don't think..." [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [10:41:56] New review: Nikerabbit; "I don't see it done in HEAD: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEcho/aa5771bceb..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67589 [10:51:38] New patchset: Jeroen De Dauw; "List stuff in directory on Travis" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68355 [10:51:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68355 [10:56:27] New review: Nikerabbit; "changepassword-text should be added to ignored messages in messageTypes.inc" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/27472 [10:57:20] New review: Njw; "Oh, I had forgotten that ResourceLoader takes media declarations. I don't think it makes sense to sp..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [10:57:51] New patchset: Jeroen De Dauw; "Have Travis do a MW install and get the dependencies" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68356 [10:58:24] New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [11:00:09] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68356 [11:00:12] New patchset: Jeroen De Dauw; "Do not spam IRC untill build is fixed" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68357 [11:00:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68357 [11:12:39] New patchset: Jeroen De Dauw; "Travis build fixed, so reenable showing all falures on IRC" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68358 [11:12:40] New patchset: Jeroen De Dauw; "Have Travis run the integration tests as well" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68359 [11:12:53] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68358 [11:12:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68359 [11:16:52] New review: Nikerabbit; "Many of the "License" links generated do not actually show anything for me." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [11:19:29] hashar: any luck on the android stuff? [11:19:34] would also be nice if you cc'd yourself on https://bugzilla.wikimedia.org/show_bug.cgi?id=49500 :) [11:19:38] idk your bugmail [11:22:45] YuviPanda: doesn't look too bad [11:22:50] :D [11:27:28] Nikerabbit: mergeable? [11:28:06] New patchset: Siebrand; "Restore erroneously removed messages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/68360 [11:28:21] Nikerabbit: dammit, I thought I got all the tabs [11:29:05] New patchset: Jeroen De Dauw; "Fix path in test bootstrap" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68361 [11:29:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68361 [11:30:43] Nikerabbit: fixed both comments [11:35:45] rotfl, I LOVE es5-sham.js's hack for emulating Object.create(null) where __proto__ can't be used. [11:36:05] New review: Nikerabbit; "I would likely have renamed/moved the messages to make clear they are used in Special:ImportTranslat..." [mediawiki/extensions/Translate] (master) C: 2; - https://gerrit.wikimedia.org/r/68360 [11:36:23] New patchset: Santhosh; "Add language selector for signup form" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/66902 [11:36:31] YuviPanda: nice [11:38:32] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/68360 [11:51:03] off for the rest of the day [11:51:07] *wave* [11:51:54] thanks hashar :) [11:51:58] Nikerabbit: mergeable? [11:56:09] New patchset: Jeroen De Dauw; "Fixed a couple of bad dependencies" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68362 [11:56:09] New patchset: Jeroen De Dauw; "Switch to using MySQL" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68363 [11:56:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68362 [11:56:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68363 [11:56:45] New patchset: Njw; "Remove custom line-height declarations for headings." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68364 [11:57:23] Change abandoned: Matthias Mullie; "(no reason)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64063 [12:00:01] YuviPanda: need to test it first [12:00:05] New patchset: Jeroen De Dauw; "Fix broken dependency" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68365 [12:00:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68365 [12:04:37] New patchset: Jeroen De Dauw; "Claims need to have their GUID set" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68366 [12:04:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68366 [12:05:16] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [12:11:05] New review: Matmarex; "I don't know; maybe something like "screen, handheld" would be more appropriate? I guess including t..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [12:12:45] New patchset: Jeroen De Dauw; "Attempt to have Travis run with both sqlite and mysql" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68370 [12:12:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68370 [12:14:52] New patchset: Jeroen De Dauw; "Try to allow sqlite falures" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68371 [12:15:17] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68371 [12:29:26] New patchset: Jeroen De Dauw; "Attempt to fix dbpath argument" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68372 [12:29:34] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68372 [12:29:36] New review: Nemo bis; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [12:34:10] New patchset: Jeroen De Dauw; "Move travis setup to dedicated sh file and make sqlite non-optional" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68376 [12:34:16] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68376 [12:36:43] Published patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [12:37:36] New patchset: Jeroen De Dauw; "Have Travis end up in the correct directory" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68377 [12:37:39] New review: Wikinaut; "code tested (the basic UserMerge functions)" [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/68211 [12:37:46] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68377 [12:46:41] New patchset: Jeroen De Dauw; "Show bash commands in output for Travis" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68380 [12:46:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68380 [12:54:11] New patchset: Nemo bis; "Correct translators list on CREDITS file" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68381 [13:14:36] New review: Njw; "Actually reading more it looks like all modern phones etc that people actually use to browse the web..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [13:21:38] Change abandoned: Nemo bis; "(no reason)" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/62611 [13:26:16] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [13:29:07] New review: Nemo bis; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [13:33:08] New review: Wikinaut; "pls. can someone of you finally code review it? You said, I should not +2ing ..." [mediawiki/extensions/AJAXPoll] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67002 [13:33:45] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68342 [13:35:03] Change abandoned: Nischayn22; "Abandoning the change as its a problem in Safari itself. Could not come with a appropriate workaround" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64851 [13:47:57] New review: Anomie; "It does work for user input previews with &preview=1§ion=0 or &preview=1§ion=new, as long as..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/68302 [13:50:39] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68302 [13:57:08] New review: Aklapper; "I tested this on boogs.wmflabs.org (whouhou!) and it works as expected - it's a simple two-liner cha..." [wikimedia/bugzilla/modifications] (master) C: 1; - https://gerrit.wikimedia.org/r/42105 [13:57:20] New patchset: Aklapper; "(bug 24992) Show "email" instead of "login" as field label in Bugzilla" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42105 [14:04:11] Nikerabbit: you there? remember when i said i'm going to do something about the ULS language list loading taking incredibly long? [14:04:19] Nikerabbit: i'm trying to do something right now [14:06:28] MatmaRex: cool [14:07:39] if it is very complex change we might want to be careful before merging due to deployments [14:08:07] right now i'm still trying to figure out what takes so long [14:08:35] i killed some $("...:last") calls which seemed like obvious offenders, but that didn't do much [14:08:57] Opera's profiling tells me it's just reflowing stuff again and again [14:09:56] and "style recalculation" [14:10:02] and doing "style recalculation" [14:12:34] i think it's disliking all of the overly unspecific ".grid ..." selectors… [14:13:19] still, running the JS itself after clicking the personal menu link takes over a second [14:13:23] too much jquery, i guess [14:20:31] New patchset: Andrew Bogott; "When deleting an instance, clear the page." [openstack-wikistatus] (master) - https://gerrit.wikimedia.org/r/68394 [14:27:00] New patchset: Hashar; "experimental breadcrumb display" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68343 [14:27:46] MatmaRex: is it possible to use .append() with many lements? [14:29:07] Nikerabbit: which append() [14:29:08] ? [14:29:16] the jQuery one or the silly ULS ones? [14:29:38] one of the silly ULS ones*, as apparently there are many [14:29:44] MatmaRex: jQuery [14:29:59] if that is what is causing the reflows [14:30:04] sure it is, although it will just call appendChild() repeatedly internally [14:30:09] honesly i don't know what's causing them [14:30:16] the parent element ishidden while all this is happening [14:30:27] so there should be only one reflow at the very end [14:33:28] New patchset: Reedy; "Update wikidata extensions to 1.22wmf6 for wmf7 deploy" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68398 [14:34:28] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68398 [14:36:56] Anyone know what extension provides prop=extracts? [14:38:04] Looks like MobileFrontend... [14:38:55] New review: Anomie; "Structurally, this seems a mess. You're leaving all the code for the old login form in place to bitr..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/27022 [14:38:57] New review: Matthias Mullie; "Code looks fine to me" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [14:39:01] yep [14:43:18] New patchset: Anomie; "API: Fix IPv6 handling in list=blocks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62445 [14:45:11] DanielK_WMDE, around? [14:47:43] New review: Anomie; "Trivial rebase in RELEASE-NOTES-1.22, no code change, Tim already +2ed the previous patchset." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62445 [14:50:11] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62445 [14:51:22] New review: Anomie; "Code looks fine, it makes sense to skip more expensive checks for codes that can never be known." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/68004 [14:52:30] Change restored: Reedy; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [14:53:51] MaxSem: hey [14:55:00] DanielK_WMDE, I understand that you just started working on coordinate data type, however when we can/should start discusing a GeoData integration? [14:55:54] New patchset: Reedy; "Commit of various wmf-branch live hacks" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [14:56:13] Change abandoned: Reedy; "Updated and abandoned" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22466 [14:56:18] MaxSem: good question. we have support for geo-coordinates rolled out, but no special handing for it in the database, and no dedicated API for it either [14:57:03] and I see it still needs work [14:57:16] indeed [14:57:23] MaxSem: i could imagine two things: 1) GeoData used on wikipedia could take coordinates from wikidata instead of templates/parser functions [14:57:42] New patchset: Reedy; "Update patch after rebase against master" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68403 [14:57:46] and 2) on Wikidata itself, it could provide a dedicated interface for retrieving geodata [14:58:05] also, we'll need a specialized index in the database at some point [14:58:21] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68403 [14:58:21] it would be interesting to see whetehr we can use GeoData code for that [14:58:22] a spatial index? [14:58:32] JeroenDeDauw: thoughts on that? [14:58:44] MaxSem: yes. well, that would be nice, anyway. [14:58:50] bah, reading [14:58:51] there are no concrete plans, yet. [14:58:58] zzzz [14:59:05] ask me tomorrow [14:59:11] heh [14:59:44] mysql spatial indexes suck [15:00:07] yea, i wouldn't suggest to use that [15:00:33] so ol' good Solr is the remaining option (stabstabstab) [15:00:34] MaxSem: what does GeoData currently use? [15:00:39] just plain ranges in mysql? [15:00:43] a parser function [15:00:50] @notify kaldari [15:00:50] MaxSem: for storing, i mean [15:00:50] I'll let you know when I see kaldari around here [15:00:52] grrr, misunderstood [15:01:15] for storing, MySQL. for searches, Solr [15:01:23] hmhm [15:01:25] New patchset: Yaron Koren; "New version: 0.4.1" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/68405 [15:01:42] MaxSem: i suppose we could benefir from your experience with that, perhaps even re-use code [15:02:00] i'm trying to think how GeoData could get coordinates from wikidata directly, without using the parser function [15:02:20] you could just look into the current item, and use any geo-coordinates you find [15:02:29] it may be tricky to figure out which of them is the "primary" one, though [15:02:37] funny thing is that parser function will likely still be needed - for secondary coordinates [15:02:38] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/68405 [15:03:12] MaxSem: actually, i think it will mostly be needed to identify the primarty coordinate - wikidata can handle any number of coordinates even for a single property [15:03:23] but it has no way to designate one of them as "primary". [15:03:56] yeah, but secondary coordinates are very text-specific, so I see no reliable use-case for sharing them between wikis [15:04:32] if they correspond to some property defined on wikidata... [15:04:34] how about creating a "primary coordinate" property type? [15:04:39] but yea, the prser function will still be needed [15:04:48] New review: Matthias Mullie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [15:04:57] it would just be annoying if every coordinate would have to be passed from wikidata to geodata via the parser function [15:05:01] that seems silly [15:06:29] Change merged: Andrew Bogott; [openstack-wikistatus] (master) - https://gerrit.wikimedia.org/r/68394 [15:08:09] yep [15:08:45] I was thinking that GD could fetch the primary from WD and let users use the PF for the secondary coordinates [15:10:05] MaxSem: how would it find out which coordinate on WD is primary? [15:10:22] there can be any number of coordinate properties, and each of them can have any number of values. [15:10:29] it has to be marked:) [15:10:37] ...as such [15:10:54] i can't see how that would fit with the data model [15:11:19] actually, it would contradict one of the most important premises: we don't collect facts, only 3rd party statements. [15:11:40] VagueData [15:11:53] :) [15:11:55] indeed [15:15:06] MaxSem: ther ecould be a list of preferred properties, and once you have found one of them, you can pick one of the "preferred" values. [15:15:11] this will *usually [15:15:18] ....*usually* only be one. [15:15:39] you could also take them all, average them, and adjust the precision accordingly :P [15:15:58] that would be fair towards the contradicting sources [15:17:25] New patchset: Alex Monk; "Fix 'Back to project list' link if returnto isn't given" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68407 [15:18:03] averaging will not work if one of sources provides a completely different point [15:18:33] in that case, just skip it [15:18:49] i can't imagine a case where that would be legit [15:18:52] dunno, sounds sloppy [15:18:55] must be a mistake or vandalism [15:19:11] MaxSem: well, it's for a search index, not for a reasoning engine. [15:19:21] for a search index, sloppy is ok, 99% is good enough [15:23:14] New review: Nischayn22; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [15:35:36] Nikerabbit: patches coming! [15:35:39] New patchset: Matmarex; "RegionSelector: Avoid reflows when generating the list" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68408 [15:35:39] New patchset: Matmarex; "LanguageCategoryDisplay: Minor improvements and code cleanup" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68409 [15:35:46] New patchset: Matmarex; "Disable lazyload for language list" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68410 [15:36:40] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [15:37:10] New review: Matmarex; "This still works with lazyload enabled, but makes the list flicker on region change - not much of an..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68408 [15:37:58] Nikerabbit: can you look at these three patches, or get someone to? :) [15:39:10] New patchset: Anomie; "Import scripts from hume ~andrew/election-2011-spam" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68411 [15:39:40] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [15:41:51] New patchset: Anomie; "Import scripts from hume ~andrew/election-2011-spam" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68411 [15:42:00] New patchset: Andrew Bogott; "Don't delete instance pages from OpenStackManager." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68412 [15:44:40] New review: Andrew Bogott; "There was a race between this code and openstack-wikistatus." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68412 [15:52:03] MatmaRex: of course [15:53:00] ^demon: You able to fix the Jenkins problem we're having? It's the usual "PhantomJS timed out" thing - can't remember how to fix it, and hashar and Krinkle are offline. [15:53:26] on a side note, i justdiscovered that Opera Software has reimplemented CSSJanus in JS: https://github.com/operasoftware/flipcss [15:53:30] <^demon> James_F: I don't know anything about PhantomJS...I can look, but I dunno how much help I'll be. [15:53:51] ^demon: It's either the APC thing or the other one that we get a few times a week. [15:53:54] they've got some fun stuff on their github [15:53:56] * James_F can't remember whim. [15:54:00] s/whim/which/ [15:54:10] ^demon: Let me just shout at Timo instead, don't worry. [15:54:19] <^demon> Ok. Well I'm around if you do want a hand. [16:07:58] petan: Are you available? I'm getting a response from wm-bot that "@add #example" is an unknown command. [16:08:09] when trying to add it to #T13 [16:08:41] Like http://meta.wikimedia.org/wiki/WM-Bot#.40add says can be done. [16:11:25] New patchset: Matmarex; "Quote 'class' in JS object literals" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68418 [16:14:43] @seen kaldari [16:14:43] MatmaRex: Last time I saw kaldari they were quitting the network with reason: Client Quit N/A at 6/13/2013 1:44:21 AM (14:30:22.4523440 ago) [16:14:47] @notify kaldari [16:14:47] I'll let you know when I see kaldari around here [16:15:00] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68323 [16:15:05] the https://gerrit.wikimedia.org/r/68418 above is rather important, is there anybody other than kaldari working on Thanks? [16:15:29] MatmaRex: I can also yell at him when he gets in if you'd like - if it's a JS change I could probably look at it too [16:15:45] Hah, trivial change. [16:15:51] MatmaRex: I love it when you make things easy for me [16:16:14] MatmaRex: Are there places where .class is used erroneously? [16:17:02] marktraceur: nah, only this grepped [16:17:17] marktraceur: this came up at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Popups_not_working_in_page_histories [16:17:26] Mmmkay. [16:18:01] New review: MarkTraceur; "Shame on whoever isn't using an editor with proper syntax highlighting." [mediawiki/extensions/Thanks] (master) C: 2; - https://gerrit.wikimedia.org/r/68418 [16:18:02] New review: Matmarex; "This would be rather nice to get deployed quickly." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68418 [16:18:07] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68418 [16:18:12] New patchset: Kaldari; "'class' is a reserved word for Explorer, enclosing in quotes" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68419 [16:18:13] Wow, fast Jenkins. [16:18:18] Hah [16:18:26] Where the hell is he? Home? Geez. [16:18:33] heh, what is kaldari doin' [16:18:47] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68419 [16:18:52] New review: MarkTraceur; "Submitted patch for this already, 68418." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68419 [16:19:05] Damn it [16:19:12] wait, that merged? [16:19:20] New patchset: Mwjames; "SMW\Subobject add DataValue mock test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68420 [16:19:21] It shouldn't have [16:19:23] both of those merged? [16:19:24] wat [16:19:33] * marktraceur has stern words with kaldari about making changes without being on IRC [16:20:04] *and* self-reviewing with such speed [16:20:51] New review: Siebrand; "Thanks!" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2; - https://gerrit.wikimedia.org/r/68408 [16:21:30] New review: MarkTraceur; "Wasn't fast enough with my -2." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68419 [16:21:59] New review: Siebrand; "Please submit jQuery.uls patches upstream." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2; - https://gerrit.wikimedia.org/r/68409 [16:23:06] New review: Siebrand; "Please submit upstream." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2; - https://gerrit.wikimedia.org/r/68410 [16:23:56] New review: MarkTraceur; "And besides, the commit message is wrong - class is reserved in ECMAScript, see https://developer.mo..." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68419 [16:26:46] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68420 [16:31:57] James_F: ^demon: Looking into it now [16:32:06] Krinkle: Thanks. [16:32:32] Wifi is pretty good at oscon oregon convention center. Listening to anual keynote now [16:32:56] Krinkle: Enjoying the conference so far? [16:33:16] Yep [16:33:40] So far jQuery has been saying every event (I've attended them all since the first one, this is #2) that it is the biggest jQuery event yet. [16:33:53] :-) [16:34:10] New review: Daniel Kinzler; "@GWicke: The Content object will always generate a complete ParserOutput, and not modify it. fillPar..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983 [16:35:41] New patchset: Jeroen De Dauw; "Fix path in test bootstrap" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68422 [16:35:41] New patchset: Jeroen De Dauw; "Rename files to WikibaseDataModel" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68423 [16:35:41] New patchset: Jeroen De Dauw; "Add i18n file" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68424 [16:35:42] New patchset: Jeroen De Dauw; "Add Travis CI config" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68425 [16:35:42] New patchset: Jeroen De Dauw; "Add gitreview file" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68426 [16:38:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68422 [16:38:51] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68423 [16:38:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68424 [16:39:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68425 [16:39:20] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68426 [16:39:27] New review: Umherirrender; "Making that expensive will break the edit tab on protected pages, because that also used quickUserCa..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66191 [16:45:54] Change abandoned: Jforrester; "(no reason)" [mediawiki/extensions/PageCredits] (master) - https://gerrit.wikimedia.org/r/24442 [16:47:09] New patchset: Jeroen De Dauw; "Update bootstrapping code so it works with composer" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68431 [16:47:17] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68431 [16:49:11] New patchset: Jeroen De Dauw; "Fix file name in composer.json" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68432 [16:49:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68432 [16:52:54] ori-l: I'm amending the change now [16:56:48] New patchset: Wikinaut; "Bug 45857 - wgRSSUrlWhitelist protocol relativity and partial matching" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/52644 [17:00:21] New patchset: Jeroen De Dauw; "Fix package name in composer.json" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68435 [17:00:44] New patchset: Daniel Kinzler; "Fix fatally broken EntityId::newFromArray" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68436 [17:00:47] New review: Wikinaut; "not ready for merging, untested, Jenkins failed. " [mediawiki/extensions/RSS] (master) C: -1; - https://gerrit.wikimedia.org/r/52644 [17:00:55] New patchset: Jeroen De Dauw; "Update package name in composer.json" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68437 [17:01:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68435 [17:03:33] New review: Matmarex; "Meh, that's real damn intuitive. Why aren't you using git submodules?" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68408 [17:07:57] New patchset: Jeroen De Dauw; "Update travis test run code" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68438 [17:08:25] New patchset: Jeroen De Dauw; "Have the tests run both as stanalone and with MediaWiki loaded on TravisCI" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68438 [17:08:29] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68438 [17:09:18] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68437 [17:11:17] New patchset: Jeroen De Dauw; "Update TravisCI build matrix" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68439 [17:11:24] New patchset: Jeroen De Dauw; "Update TravisCI build matrix" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68439 [17:11:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68439 [17:12:21] New review: Matmarex; "You have a new pull request: https://github.com/wikimedia/jquery.uls/pull/97" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68408 [17:12:45] siebrand: ^ [17:13:58] New patchset: Jeroen De Dauw; "Update TravisCI build matrix" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68440 [17:14:06] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68440 [17:17:46] New patchset: Jeroen De Dauw; "Update TravisCI build matrix" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68441 [17:17:48] ori-l: Can you look over https://gerrit.wikimedia.org/r/#/c/68117/ ? It works now, but if there's a more common pattern to do this that has the same effect, let me know. [17:17:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68441 [17:18:28] Yippie, build fixed! [17:18:28] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #97: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/97/ [17:19:27] New patchset: Jeroen De Dauw; "Update TravisCI build matrix" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68442 [17:19:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68442 [17:24:21] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65316 [17:26:24] New patchset: Jeroen De Dauw; "Remove standalone postgres build" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68444 [17:26:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68444 [17:28:10] New patchset: Jeroen De Dauw; "Revert "Remove standalone postgres build"" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68445 [17:28:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68445 [17:29:23] Yippie, build fixed! [17:29:24] Project browsertests-test2.wikipedia.org-linux-chrome build #382: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/382/ [17:32:39] Yippie, build fixed! [17:32:39] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #124: FIXED in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/124/ [17:34:09] New patchset: Jeroen De Dauw; "Reduce postgres builds" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68448 [17:34:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68448 [17:35:35] New patchset: Raimond Spekking; "Add newline at end of file" [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68449 [17:35:58] Change merged: Raimond Spekking; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68449 [17:43:15] New patchset: Jeroen De Dauw; "Update min stability in composer.json" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68451 [17:43:16] Summer of Code: 102 A.D. [17:43:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68451 [17:43:48] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDataModel] (master) - https://gerrit.wikimedia.org/r/68436 [17:43:50] Er, Svmmer of Code. [17:44:44] New patchset: Jeroen De Dauw; "Fix exclude config for travis build" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68452 [17:44:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68452 [17:50:44] New patchset: Jeroen De Dauw; "Drop PHP 5.4 builds to reduce build time" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68453 [17:50:53] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68453 [17:52:26] New patchset: Kipcool; "Special:Datasearch showing next/previous buttons only when not all results are displayed in one page." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68454 [17:52:54] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68454 [17:53:29] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:55:13] To whomever is doing the new account stuff: Having ****** as a prefil text/placeholder on the password box is really confusing since it looks like my web browser had already auto-filled my password [17:56:03] New review: Reedy; "This looks fine to submit, as it's just an import of the current scripts not in any version control." [mediawiki/extensions/SecurePoll] (master) C: 1; - https://gerrit.wikimedia.org/r/68411 [17:56:07] qgil: so why cant you use {{#invoke:Sandbox/QuimGil/Flagicon | flag |{{{1}}}|{{{variant|}}}|{{{size|}}}}} ? [17:56:48] like brad said, you can detect emptiness in lua [17:57:11] compatibility only arguments only needs to be handled at the template wrapper, not the module itself [17:57:29] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68407 [17:57:46] AaronSchulz, I'll try now. I'm just learning about how the templates themselves work. Thank you! [17:58:31] *compatibility of arguments [18:01:07] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171 [18:01:12] New patchset: Ori.livneh; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [18:02:34] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [18:02:59] New patchset: Ori.livneh; "Cleanup jsduck documentation and commenting:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68137 [18:04:41] New review: Ori.livneh; "Very nice!" [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/68137 [18:04:49] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68137 [18:05:07] New patchset: Ori.livneh; "Fix bugs, refactor and cleanup user state/cookie code:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68326 [18:05:21] New patchset: Jeroen De Dauw; "Attempt to fix error in build script" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68457 [18:06:05] New patchset: Jdlrobson; "Bug 49440: Load hidpi plugin at top of page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [18:06:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68457 [18:08:08] New patchset: Jeroen De Dauw; "put in true as script command so it does not default to phpunit" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68461 [18:08:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68461 [18:09:09] New patchset: Anomie; "Return errors from WatchAction" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [18:09:43] New review: Anomie; "As requested on Ie33446a2" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68462 [18:10:59] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/Campaigns] (master) C: 2; - https://gerrit.wikimedia.org/r/67587 [18:11:34] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [18:11:56] New patchset: Bsitu; "Some more adjustment to timestamp in user timezone" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68464 [18:12:23] New review: Anomie; "PS6: Address comments, partially by rebasing on top of a patch that adds Status to WatchAction." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [18:12:41] New patchset: Jeroen De Dauw; "Attempt to fix passing of variable to build script" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68465 [18:12:53] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68465 [18:13:12] Change merged: Ori.livneh; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [18:14:28] New review: Anomie; "> Is get-voter-list.php empty at the source?" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68411 [18:14:49] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68411 [18:15:51] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [18:17:58] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [18:18:47] New patchset: Aaron Schulz; "Cleaned up variable/type order in docs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68467 [18:21:06] New patchset: Jeroen De Dauw; "Pass evn variable as argument to work around my shell script ignorance" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68468 [18:21:14] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68468 [18:23:48] New patchset: Reedy; "Minimal updating of scripts" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68469 [18:25:13] New review: Aaron Schulz; "Well that wouldn't deal with the first things I said. Most extensions don't have issues (only occasi..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [18:26:03] RoanKattouw_away or Krinkle or someone: It looks like OutputPage::addScript puts scripts after all the modules in a page...is there a way to reverse that manually, or am I thinking about it wrong? Specifically this is adding a "makeVariablesScript" return value, by the way. [18:26:04] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68464 [18:26:25] Oh, hm, probably I need to use addJsVars. [18:26:30] marktraceur: legacy scripts load after rl scripts [18:26:31] er, ConfigVars. [18:26:34] that's by design [18:27:15] yeah, addJsVars for page-related vairables [18:27:43] New patchset: Reedy; "Minimal updating of scripts" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68469 [18:28:02] New patchset: Kaldari; "Update Thanks to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68471 [18:29:23] Done and done. [18:29:27] New patchset: Jeroen De Dauw; "Update loading code to work with composer" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68472 [18:29:27] New patchset: Jeroen De Dauw; "Do not require standalone builds for now, as they are broken and cannot be fixed yet" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68473 [18:29:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68472 [18:29:42] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68473 [18:31:08] New patchset: Kaldari; "Update Thanks to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68474 [18:31:24] New patchset: MarkTraceur; "Fix UploadWizard's config variables" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68475 [18:31:51] @notify kaldari [18:31:51] This user is now online in #wikimedia-tech. I'll let you know when they show some activity (talk, etc.) [18:32:19] @notify jeremyb [18:32:19] I doubt that anyone could have such a nick ' jeremyb' [18:32:21] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [18:32:32] New patchset: Bsitu; "Some more adjustment to timestamp in user timezone" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68464 [18:32:39] lol [18:32:41] T13|ClassSOC102: hm, the bot is apparently whitespace-sensitive [18:32:47] Yep [18:32:48] petan: ^ [18:33:02] New patchset: Anomie; "Copy doSpam.php from elections-2011-spam to bv2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68476 [18:33:03] New patchset: Anomie; "Code style fixes in cli/wm-scripts/bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68477 [18:33:03] New patchset: Anomie; "Cleanup bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [18:33:23] TRIM ALL THE THINGS [18:33:46] I'm on my droid. was there a double space before or a space after? [18:33:49] New review: Anomie; "Needs updating of the variables near the top of the script. What should those be?" [mediawiki/extensions/SecurePoll] (master) C: -1; - https://gerrit.wikimedia.org/r/68478 [18:34:22] New patchset: Jeroen De Dauw; "Add WikibaseDataModel to clone list in travis config" [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68479 [18:34:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseQueryEngine] (master) - https://gerrit.wikimedia.org/r/68479 [18:34:41] T13|ClassSOC102: double before [18:35:15] @notify jeremyb [18:35:15] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [18:35:25] thanks [18:36:02] New review: Brian Wolff; "PS8: Add tests. Change method name to getIndependentMetaArray per suggestion. Whitespace fix." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [18:36:35] New review: Kaldari; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/68475 [18:38:02] New patchset: MarkTraceur; "Fix UploadWizard's config variables" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68475 [18:38:27] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68475 [18:38:28] New review: Reedy; "I'd probably be inclined to create a folder in /a/common and use that. Though, terbium would not use..." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [18:39:39] documented.. [18:40:41] New review: Ori.livneh; "(I'll re-review this.)" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/64609 [18:42:27] New review: Anomie; "I flagged a few more places where spaces should be inserted" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68469 [18:44:02] New patchset: Brian Wolff; "(DO NOT MERGE; needs I49b7d8a05) Add a lua interface for getting file metadata" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [18:44:04] New review: Anomie; "Merge with https://gerrit.wikimedia.org/r/#/c/68469/, then abandon this." [mediawiki/extensions/SecurePoll] (master) C: -2; - https://gerrit.wikimedia.org/r/68477 [18:44:33] New review: Brian Wolff; "PS4: adjust method name per feedback on I49b7d8a05" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [18:44:38] New review: Anomie; "Rebase on https://gerrit.wikimedia.org/r/#/c/68469/ once that is merged." [mediawiki/extensions/SecurePoll] (master) C: -1; - https://gerrit.wikimedia.org/r/68476 [18:45:07] New review: Bsitu; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [18:45:52] New review: Anomie; "Pick whichever paths you like, I have no opinion. And feel free to just amend them into this change ..." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [18:48:19] Reedy: there might be something in wmf7 that breaks JS things for IE8, still investigating [18:48:55] Nikerabbit: the Thanks extension? [18:49:05] Could not set propery of href. Invalid property value. [18:49:05] Nikerabbit: it's fixed on master already [18:49:11] kaldari said he'll deploy it [18:49:13] ah, that's not it. [18:49:38] MatmaRex: http://media.crossbrowsertesting.com/users/47023/snapshots/z8086d031a77e2bff711.png [18:50:45] >> 'foo' + 5 - 2 + 'bar' [18:50:45] Krinkle: (string) 'NaNbar' [18:52:12] Nikerabbit: i'll be happy to look at those, but i'm not going to retype the URLs. :P [18:53:49] >> 'interesting, what this do?' [18:53:49] bawolff: (string) 'interesting, what this do?' [18:54:08] Or more to the point what's the use case (other then being kind of cool) [18:54:10] ? [18:54:18] Nikerabbit: about the github changes - [18:54:28] bawolff: Mostly for Watman purposes. [18:54:31] Nikerabbit: should i just submit more commits, or are you using some more complicated process there? [18:54:36] (like amending and friends) [18:55:06] * bawolff is not sure what a Watman is? [18:55:30] meh that error seems to be something local to telugu wikipedia [18:55:44] MatmaRex: just more commits to the same request, can you do that? [18:55:52] >> Array(16).join('wat' - 1) + " Batman !" [18:55:53] marktraceur: (string) 'NaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaN Batman !' [18:56:07] ... [18:56:19] wikimedians have just TOO much fun with bots [18:56:22] New patchset: Reedy; "Minimal updating of scripts" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68469 [18:56:29] Nikerabbit: surely [18:56:31] http://blog.mkasprzyk.net/wp-content/uploads/2012/09/watman.jpg [18:56:44] uh that leaves me clueless [18:56:45] >> alert('XSS') [18:56:45] MatmaRex: undefined; Console: 'XSS' [18:56:48] ~ [18:57:11] Nikerabbit: also, http://api.jquery.com/last-of-type-selector/ [18:57:17] Nikerabbit: it has a polyfill, but only in 1.9 [18:57:18] why doesn't ULS work in IE8 on XP in Wikipedias anymore (it does work on translatewiki.net)? [18:57:26] and MW is still on 1.8 [18:57:38] Nemo_bis: We're working on a bot that will automatically run all the standard "Hm, an ECMAScript emulator, I wonder if I can break it" messages for new people to the channel [18:57:38] it has a last-child, though - http://api.jquery.com/last-child-selector/ [18:57:44] and this should do as well [18:57:57] And then a bot that will call that one upon detecting new-person-like messages [18:58:08] MatmaRex: what was the thanks issue, could it cause this? [18:58:23] Nikerabbit: probably not - a 'class' not quoted in an object literal [18:58:28] marktraceur: I hope it relays results via icinga-wm on -operations and !log s results via logmsgbot to morebots [18:58:29] Nikerabbit: it would be a syntax error on IE8 [18:58:42] Nikerabbit: as in, {stuff: 42, class: 'whatevs'} [18:58:56] oh [18:59:00] I don't see any JS errors [18:59:16] Nemo_bis: No, results are dumped in JSON format on Jimmy's talk page, logging happens on randomly-named pages on metawiki [18:59:46] and it has nothing to do with wmf7 either [18:59:48] RidiculousBot. [19:01:35] Nikerabbit: pushed [19:01:47] i hope i didn't introduce any syntax errors ~ [19:02:17] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68471 [19:07:18] New review: Matmarex; "If you load it on top, the tags will not yet be visible when it runs, and thus will not be hid..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/68458 [19:07:36] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68474 [19:07:50] New review: Matmarex; "s/be visible/exist/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:11:27] New review: Jdlrobson; "Although loaded at the top the code only runs on DOMContentLoaded due to use of jQuery ready jQuery(..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:12:22] New patchset: Jdlrobson; "Bug 49440: Load hidpi plugin at top of page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:12:42] New patchset: Jdlrobson; "Bug 49440: Load hidpi plugin at top of page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:13:01] Reedy: Possible to do a messages cache update? New VE messages not showing up on MW.org. [19:13:02] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [19:14:08] New review: Matmarex; "Ah, I missed the jQuery(), it should probably use jQuery(document).ready() per the code conventions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:14:18] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [19:14:31] New review: Anomie; "Looks good. Commit summary needs fixing to remove the p.s. (and the "do not merge" note when it's re..." [mediawiki/extensions/Scribunto] (master) C: 1; - https://gerrit.wikimedia.org/r/67588 [19:15:11] New review: Mattflaschen; "Tested successfully. It seems like this would be most useful for defaults, but it could help with l..." [mediawiki/extensions/EventLogging] (master) C: 2; - https://gerrit.wikimedia.org/r/68140 [19:15:34] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140 [19:16:04] New patchset: AzaToth; "adding gitreview file" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68484 [19:16:05] New patchset: AzaToth; "Copying and modifying operations/debs/gerrit into gerrit" [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68485 [19:17:43] New review: Brion VIBBER; "Hmm... Won't the code just run on document-ready regardless of whether it's loaded at top or bottom?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [19:19:06] Change merged: Demon; [gerrit] (wmf-debian) - https://gerrit.wikimedia.org/r/68484 [19:19:13] New patchset: Ori.livneh; "Log preference changes" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [19:19:13] New patchset: Ori.livneh; "Add .gitreview" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68486 [19:20:36] !e CoreEvents [19:20:36] https://www.mediawiki.org/wiki/Extension:CoreEvents [19:21:20] New review: Spage; "Comment comments." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140 [19:22:13] Change merged: Ori.livneh; [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68486 [19:22:23] James_F: Probably something I should add to my deployment list [19:22:25] MatmaRex: hmph [19:22:36] Nikerabbit: mhmph? still broken? [19:22:44] Reedy: Yeah. Or the small script you were writing to replace you. ;-) [19:23:04] just some rambling: I actually liked the gerrit patches since they were easy to test... have to do some hackery to test the patches in github [19:23:37] you guys really should be using submodules there. [19:23:52] especially since it's all "in-house" code [19:24:18] i had to manually copy files and recreate the commits to submit them to github, too [19:24:23] like a goddamn neanderthal [19:24:27] D: [19:25:59] New patchset: Ori.livneh; "Tweaks to comment-block suggested by S" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68488 [19:26:53] MatmaRex: hmm that could be possible, would you like to file an enhancement request? [19:27:52] Nikerabbit: i haven't really used submodules myself (apart from submitting a commit to update an extension to master on one of the wmf branches), so i'd rather not pretend i know anything about them [19:28:25] i don't really understand why did you split the JS part out of the extension, but oh well [19:28:35] New review: Mattflaschen; "I haven't been able to get this to work yet, though it may be my settings. I see the toolbar and me..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [19:31:14] New review: Spage; "(blushes)" [mediawiki/extensions/EventLogging] (master) C: 2; - https://gerrit.wikimedia.org/r/68488 [19:31:15] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68475 [19:31:18] MatmaRex: we have two standalone components jquery.uls and jquery.ime and the extensions just wraps over them [19:31:36] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68488 [19:31:48] Krinkle|detached or ^demon, is Jenkins running the same PHP version as production (5.3.10-1ubuntu3.6+wmf1)? [19:31:58] New review: Ori.livneh; "S's suggestions implemented in Ibc147a700" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140 [19:32:09] <^demon> MaxSem: I believe so, lemme check [19:32:11] Nikerabbit: wouldn't it make more sense for two extensions to exist separately? [19:32:57] <^demon> MaxSem: Yes [19:33:01] New patchset: Mattflaschen; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [19:33:48] hmm. thanks ^demon - investigating yet another unexplainable Jenkins failure:( [19:34:19] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [19:43:34] MatmaRex: no [19:43:47] MatmaRex: ULS has it all in one integrated UI [19:46:07] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/68533 [19:46:13] integrated UI? it's just some options dialogs that are integrated [19:46:18] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/BlockAndNuke] (master) - https://gerrit.wikimedia.org/r/68534 [19:46:29] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/68535 [19:46:33] (and which IMO really should use standard preferences - the anon issuescertainly could be solved somehow) [19:46:39] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68536 [19:46:39] Nikerabbit: ^ ^^ [19:46:49] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/DataTypes] (master) - https://gerrit.wikimedia.org/r/68537 [19:47:00] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/SOLRSearch] (master) - https://gerrit.wikimedia.org/r/68538 [19:47:10] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ValueFormatters] (master) - https://gerrit.wikimedia.org/r/68539 [19:47:21] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ValueParsers] (master) - https://gerrit.wikimedia.org/r/68540 [19:47:31] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ValueValidators] (master) - https://gerrit.wikimedia.org/r/68541 [19:47:35] dammit Reedy [19:47:42] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ValueView] (master) - https://gerrit.wikimedia.org/r/68542 [19:47:42] why don't people create those when adding new extensions [19:48:03] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68543 [19:48:13] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/68544 [19:48:30] MatmaRex: they are using preferences for logged in users [19:49:00] spaaaaaam [19:49:07] Reedy: :( [19:49:08] you guys are dicks [19:49:10] chill out [19:49:12] Nikerabbit, ^demon: Re bug 49521, !g 67531 did break the wmf l10nupdate script. I'm thinking of making a simple fix: change $1 and $2 in the gitblit urls to $3 and $4, and change the code so $1 and $2 are non-urlencoded and $3 and $4 are the new urlencoded versions. Sound sane? [19:49:17] Nikerabbit: yeah, but not the UI [19:49:30] Nikerabbit: and last time i checked it just saved a JSON blob, right? [19:49:36] yup [19:49:53] 'cause our preferences system is quite inflexible [19:49:54] <^demon> anomie: Sounds reasonable. Lemme know when it's up and I'll review. [19:49:55] which is not very nice thing todo IMO [19:50:02] inflexible? :o [19:50:10] but really that's besides the point [19:50:16] yeah, true [19:50:34] the point is that the core functionality is standalone to easy third party reuse [19:53:59] New review: Nemo bis; "Thanks for this! Two questions on the logic. Just ignore me if it's rubbish, I know I don't know PHP..." [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [19:58:31] New patchset: SuchABot; "Fix download title to make more sense" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68545 [20:04:08] New review: GWicke; "I was referring to the hook case where default processing (with fillParserOutput) still runs. " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983 [20:05:46] New patchset: Anomie; "Fix update for non-default URLs" [mediawiki/extensions/LocalisationUpdate] (master) - https://gerrit.wikimedia.org/r/68546 [20:06:51] Change abandoned: Jdlrobson; "Seems I got confused. I thought modules loaded at the bottom were loaded slightly differently from t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [20:06:58] !g 68546 | ^demon Nikerabbit [20:06:58] ^demon Nikerabbit: https://gerrit.wikimedia.org/r/#q,68546,n,z [20:07:55] MatmaRex: hmm do you have any idea what are the remaining causes of slowness in the rendering... it has noticeable delay on my computer so it can only be worse on low end machines [20:08:42] New patchset: MarkTraceur; "Update UploadWizard to f0fb66c643014621a4abbde8fd63a4cea30f719c" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68548 [20:09:19] Sigh. [20:09:33] ^demon: I'm still not in the production group on Gerrit, halp please [20:09:44] <^demon> production group? [20:09:45] Er, deployment, or whatever the hell it is. [20:10:11] <^demon> https://gerrit.wikimedia.org/r/#/admin/groups/21,members - just added you. [20:10:18] <^demon> I don't remember anyone telling me to do so before. [20:10:25] Thanks [20:10:25] anomie: lgtm but I have no easy way to verify [20:10:35] I thought I asked last time I did a deploy, but maybe not [20:11:06] Change merged: MarkTraceur; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68548 [20:11:49] hey marktraceur, i'm just curious, what linux distribution are you using? [20:11:55] hi by the way :P [20:12:19] <^demon> Nikerabbit: Testing default setup is pretty easy. Just include, rely on default config, run maintenance script it has. [20:12:25] <^demon> But yeah, testing wmf setup is harder. [20:14:06] New review: Nemo bis; "(1 comment)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [20:14:09] mooeypoo: Hi there! I'm using Ubuntu 12.04 on my laptop at work and Trisquel GNU/Linux 5.5 on my server at home (which is where I'm running irssi) [20:14:56] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #118: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/118/ [20:14:56] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #100: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/100/ [20:16:42] New patchset: Lewis Cawte; "Change MediaWiki.org links from HTTP to HTTPS." [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68549 [20:16:54] New patchset: Spage; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68550 [20:19:10] Change merged: Reedy; [mediawiki/extensions/ValueValidators] (master) - https://gerrit.wikimedia.org/r/68541 [20:19:33] Change merged: Reedy; [mediawiki/extensions/WikibaseQuery] (master) - https://gerrit.wikimedia.org/r/68544 [20:19:47] Change merged: Reedy; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/68543 [20:19:56] New patchset: Spage; "Update EventLogging to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68552 [20:19:59] Change merged: Reedy; [mediawiki/extensions/ValueView] (master) - https://gerrit.wikimedia.org/r/68542 [20:20:27] Change merged: Reedy; [mediawiki/extensions/ValueParsers] (master) - https://gerrit.wikimedia.org/r/68540 [20:20:34] Change merged: Reedy; [mediawiki/extensions/ValueFormatters] (master) - https://gerrit.wikimedia.org/r/68539 [20:20:40] Change merged: Reedy; [mediawiki/extensions/SOLRSearch] (master) - https://gerrit.wikimedia.org/r/68538 [20:20:50] Change merged: Reedy; [mediawiki/extensions/DataTypes] (master) - https://gerrit.wikimedia.org/r/68537 [20:20:54] Change merged: Reedy; [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68536 [20:20:58] Change merged: Reedy; [mediawiki/extensions/CirrusSearch] (master) - https://gerrit.wikimedia.org/r/68535 [20:21:01] Change merged: Reedy; [mediawiki/extensions/BlockAndNuke] (master) - https://gerrit.wikimedia.org/r/68534 [20:21:11] Change merged: Reedy; [mediawiki/extensions/Annotator] (master) - https://gerrit.wikimedia.org/r/68533 [20:24:21] New review: Spage; "right commit" [mediawiki/core] (wmf/1.22wmf7) C: 2; - https://gerrit.wikimedia.org/r/68552 [20:25:38] Nikerabbit: i think at this point it's simply running too much code [20:25:55] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68552 [20:25:55] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68550 [20:25:59] Nikerabbit: all of the values it .find()-s could probably be cached in instance variables [20:26:04] New patchset: Spage; "Update GuidedTour to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68554 [20:26:07] or object fields, or however are those called in JS [20:26:21] We have too many extensions [20:26:22] TOO MANY [20:26:45] Reedy: help me in my quest to eradicate Vector, maybe? [20:26:54] patches are pending [20:27:01] 1 out of 561? [20:27:10] at least 561 [20:27:12] New review: Spage; "fc1fb8c is latest" [mediawiki/core] (wmf/1.22wmf6) C: 2; - https://gerrit.wikimedia.org/r/68554 [20:27:25] Reedy: small steps, eh [20:27:29] (brb) [20:28:31] New review: Bsitu; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [20:30:23] New patchset: Spage; "Update EventLogging to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68555 [20:31:04] New review: Spage; "ba1ee98 is latest" [mediawiki/core] (wmf/1.22wmf6) C: 2; - https://gerrit.wikimedia.org/r/68555 [20:31:05] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68554 [20:33:02] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [20:33:28] MatmaRex: properties [20:33:30] :) [20:33:52] New patchset: SuchABot; "Disallow newlines in multiple upload edit title window" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68557 [20:34:38] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68555 [20:36:06] New review: Yuvipanda; "Small change, self merging" [apps/android/commons] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68557 [20:36:07] Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68557 [20:36:17] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68464 [20:36:56] New patchset: Legoktm; "Remove deprecated call to wfLoadExtensionMessages." [mediawiki/extensions/DynamicPageList] (REL1_21) - https://gerrit.wikimedia.org/r/68558 [20:37:26] marktraceur: reason I ask is that an online friend of mine just claimed no one's a true Linux user unless they use Gentoo. [20:37:40] ... I was.. curious what you're using :P [20:38:09] New review: Legoktm; "Backport to the 1.21 branch, which needs this." [mediawiki/extensions/DynamicPageList] (REL1_21) - https://gerrit.wikimedia.org/r/68558 [20:38:19] mooeypoo: I can show them the output of uname -a if they're curious, I assure you I'm using Linux [20:38:48] Change merged: jenkins-bot; [mediawiki/extensions/LocalisationUpdate] (master) - https://gerrit.wikimedia.org/r/68546 [20:39:08] <^demon> anomie: https://gerrit.wikimedia.org/r/#/c/68546/ looks good enough to me. Go ahead and feel free to try it out. Said you wanted to do it today. [20:40:18] New patchset: Mattflaschen; "Log preference changes" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [20:40:23] ^demon: +2 so I can backport and test for the lightning deploy in a few hours? [20:41:30] <^demon> I just +2'd. [20:42:14] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [20:43:55] marktraceur: oh, I had no doubt you are. Though I do believe someone once told me Ubuntu is not Linux, it's "GNU/Linux". [20:44:04] * mooeypoo is a good student [20:44:23] I was just amused by the other guy's statement, I wanted to see what you had to say about it hehe [20:45:02] mooeypoo: Yes, but your friend claimed that Gentoo was the only way to use Linux. Linux is distributed across many GNU/Linux distros, so it makes very little sense to claim that. [20:45:21] mooeypoo: Ubuntu, for example, distributes a copy of Linux to me that I'm running right now [20:45:25] holy gentoo [20:45:33] Trisquel distributes linux-libre, which is a form of Linux. [20:46:20] * mooeypoo is now confused again [20:46:49] oh, he didn't say it was the only way, he said it was the only *right* way [20:47:02] it was a statement of elitism, not descrimination [20:47:17] ^demon: thanks! [20:49:05] Considering that "Linux" is a kernel used by every single Linux distro and more, and the "GNU/Linux" concept is Linux + a bunch of software included in every linux distro... there is absolutely no validity to the Gentoo elitism. [20:49:57] New patchset: MarkTraceur; "Updating UploadWizard to f0fb66c643014621a4abbde8fd63a4cea30f719c" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68559 [20:50:11] New review: Eranroz; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [20:52:56] <^demon> marktraceur: Of course the answer is that we should all use slackware. [20:53:01] New review: MarkTraceur; "I'll be merging this right before deployment, just getting everything set up so I can be fast." [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68559 [20:53:39] ^demon: The real pros will install slackware on a laptop while slacklining [20:53:44] http://www.linuxfromscratch.org/ [20:53:47] Slackwarelining. [20:53:59] Krinkle: yeah, i always forget the proper nomenclature :) [20:54:36] <^demon> AzaToth: Also, I wonder if buck upstream would take some of the debian/* stuff in their repo. Would make things easier to maintain :) [20:55:31] mooeypoo: At some level gentoo appeals to me, on other levels I don't want to spend my weekends maintaining my desktop's capacity to be connected to the network [20:55:43] Maybe my new computer can use Parabola. [20:55:48] <^demon> Whoops, wrong channel. [20:56:25] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [20:58:05] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #88: FAILURE in 21 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/88/ [20:58:42] New review: Hashar; "I like convention and shorter code. My rational is to get rid of the flush() call hence the implici..." [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68186 [21:00:41] New review: Hashar; "mostly a proof of concept." [integration/docroot] (master) C: -1; - https://gerrit.wikimedia.org/r/68343 [21:01:50] Parabola ? [21:02:26] mooeypoo: A linux-libre port of Arch Linux with all free software in its repos [21:03:26] Ah. I think I may stick to Ubuntu [21:03:45] mooeypoo: That's probably fine-ish for now [21:03:49] I assume you replaced its "Unity" desktop with something else btw? [21:03:59] .. fine-ish? Hey, I was a Windows user. That's progress. [21:04:24] mooeypoo: Actually no, I've been lazy about customizing this laptop because I intend to make it Trisquelly in the near future [21:04:37] * MatmaRex doesn't mind Windows at all [21:04:39] Though I'm also considering real-life projects of greater importance that may put that on hold [21:06:06] Yeah real life interfers with proper Linuxing for years, I hear. [21:06:09] MatmaRex: Looks deeply inside yourself. I'm sure there is a free-software nut burred deep inside [21:07:28] * DanielFriesen shuns MatmaRex [21:07:31] bawolff: pretty much everything but Windows itself here is free [21:07:43] and i have the entire linuxey environment set up [21:07:46] (mingw) [21:07:51] i even got ssh-agent to work. [21:07:51] I suppose I can't be that high and mighty. I'm using unfree firmware [21:08:17] * bawolff uses linux because it Just Works(tm) [21:08:28] Some of the time [21:08:32] lol [21:08:39] bawolff: yeah well, about that… :P [21:08:39] maybe about 4 out of 5 boots it does [21:09:09] ^_^ Well if I had the money I'm quite confident returning to a new Ubuntu laptop would work much better than this MacBook Air I'm stuck with. [21:09:16] but seriously, in terms of apache, php, ssh, and git. It does have a serious just works advantage [21:09:19] MatmaRex: mingw is GNUy, not Linuxy [21:09:33] and a command line that doesn't suck [21:09:34] It's not minlw [21:09:43] marktraceur: heh [21:09:45] That wouldn't make any sense [21:09:51] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68329 [21:09:57] alright, will remember :P [21:10:06] bawolff: ssh works for me, so does git [21:10:22] And strictly speaking anything linux'y that doesn't use the linux kernel is really unix'y rather than linux'y. [21:10:27] bawolff: never tried installing apache and php, since i have bad feelings about that :P [21:10:37] Like the stuff using BSD kernels and whatnot. [21:10:48] bawolff: me too; every time I try Windows I get lost even with the simplest things [21:10:58] * MatmaRex has always been sad Plan 9 didn't gain more popularity [21:11:00] OSX uses a unix-like base too. [21:11:10] Nemo_bis: get mingw or cygwin, you'll feel right at home [21:11:22] tried that [21:11:27] DanielFriesen: Everytime i use OS X i'm totally screwed until I manage to figure out how to get to a console [21:11:31] then everything is ok again [21:11:34] Nemo_bis: it feels good typing 'rm' instead of 'del' and 'ls' instead of 'dir' [21:12:07] MatmaRex: That's 2 keystrokes you can never get back [21:12:10] bawolff: Command + Space; Start typing term till you can hit enter to open up the Terminal program. [21:12:22] * bawolff will have to remember that [21:12:44] bawolff: also, linux doesn't have autohotkey [21:12:50] which is seriously the best software ever [21:12:54] You could also use the search icon in the upper right rather than the Command + Space shortcut. [21:13:09] The only thing I miss about windows is window key+R gives me a run box, and I'm not sure what the equivalent key combo (or if there is one) for gnome [21:13:16] * bawolff doesn't know what autohotkey is [21:13:28] New patchset: Hashar; "move html code to their own files" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68185 [21:14:02] * DanielFriesen has an interesting program on OSX called DTerm... but practically never uses it to the point he can't even remember the hotkey. [21:14:02] the uber hotkey (re)mapping and gui automation tool [21:14:04] Yay! Finally someone who gets lost in Windows! [21:14:04] just googled it. Does sound cool [21:14:15] * bawolff returns high five [21:14:20] New review: Hashar; "addresses all issues from PS1." [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68185 [21:14:29] with three lines i have the controls for my music player in my mouse. [21:14:32] Especially now that they changed the start menu [21:14:35] fourth mouse button + scroll = alt+tab [21:14:40] fifth mouse button + scroll = ctrl+tab [21:14:40] * bawolff can use Windows 95 like a pro [21:14:56] these are the most useful shortcuts ever [21:15:06] Hm, DTerm reminds me of Guake [21:15:13] Which is...amusing in so many ways [21:15:18] Why don't I use Guake anymore? [21:15:19] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #54: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/54/ [21:15:20] * marktraceur installs it [21:15:21] alt + . = …; alt + - = – [21:15:25] good for typography [21:15:27] :D [21:15:28] Change merged: Daniel Friesen; [mediawiki/extensions/SidebarDonateBox] (master) - https://gerrit.wikimedia.org/r/68549 [21:15:42] The ctrl+u+code point thing is nice on linux [21:16:37] New review: Demon; "This still needs ini4j, plus buck built with the other patchset. Don't think this one is quite there..." [gerrit] (wmf-debian) C: -2; - https://gerrit.wikimedia.org/r/68485 [21:17:21] Oh man, irssi in guake is my new favorite thing [21:17:28] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68012 [21:19:27] bawolff: me too! windows 98 I skipped, and ME disliked when it tried to change the bar to something XP-y I think [21:19:50] Windows 95 was the first computer I had back when I was about 8 [21:19:55] New patchset: Reedy; "Add lots of new extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/68562 [21:20:08] The next one after that was XP I think [21:20:11] Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/68562 [21:20:47] New review: Hashar; "Thank you andrewbogott !" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68012 [21:21:20] New patchset: Hashar; "triggers for apps/android/commons (non voting)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68563 [21:21:27] New review: Matmarex; "> Hmm... Won't the code just run on document-ready regardless of whether it's loaded at top or bottom?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68458 [21:22:08] jdlrobson: ^ [21:22:43] New patchset: Hashar; "triggers for apps/android/commons (non voting)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68563 [21:22:44] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:23:29] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68563 [21:24:00] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53968 [21:24:26] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68564 [21:25:10] hashar, how do I request my new extension have PHP and JS CI tests run? [21:27:52] spagewmf: I was trying to craft a Yoda still answer [21:27:56] but gave up [21:28:35] submit a change you must [21:29:04] spagewmf: Timo is in SF this week I think, so you might poke him if he has sometime [21:29:21] spagewmf: he could introduce you to the arcane of the jenkins job builder and Zuul trigger configuration [21:29:39] the qunit tests, I have no idea though [21:29:52] need to have a look at them. I know Timo has them running for VisualEditor extension [21:30:05] New review: Brian Wolff; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) C: -1; - https://gerrit.wikimedia.org/r/67002 [21:30:12] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:31:03] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:31:16] hashar Thanks. what repo has the Jenkins/Zuul config? I can pattern match how the VE extension is configured. [21:31:45] integration/jenkins-job-builder-config hold the yaml files that defines our jobs [21:32:02] the doc for jenkins job builder is at https://www.mediawiki.org/wiki/CI/JJB [21:32:10] that is basically a python script that create jobs for us [21:33:03] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:34:09] spagewmf: the Zuul workflow is under integration/zuul.git [21:34:11] err [21:34:16] integration/zuul-config.git [21:34:41] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:37:17] New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [21:41:18] hashar, spagewmf: Timo will be in SF starting next week [21:41:35] RoanKattouw I hope your exams are going well [21:41:51] I had the last one yesterday, they went well [21:42:01] Now anxiously waiting for grades to be published [21:42:11] RoanKattouw: thanks :) [21:42:24] Dipl.Sci Eng. PhD MSc ?! [21:43:53] MSCS [21:44:05] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68469 [21:44:07] Won't be done till March/April 2014 though [21:44:23] Change abandoned: Reedy; "(no reason)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68477 [21:44:40] New patchset: Reedy; "Copy doSpam.php from elections-2011-spam to bv2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68476 [21:45:33] Project browsertests-en.wikipedia.org-linux-chrome build #121: FAILURE in 4 min 17 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/121/ [21:47:11] New patchset: Reedy; "Copy doSpam.php from elections-2011-spam to bv2013" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68476 [21:47:40] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68476 [21:47:53] New review: Krinkle; "Spam spam spam spam... Lovely spam! Wonderful spam!" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68476 [21:49:17] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [21:49:36] New patchset: Krinkle; "Enable mwwext-GuidedTour-qunit" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68567 [21:49:42] Project browsertests-en.wikipedia.org-linux-firefox build #112: FAILURE in 4 min 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/112/ [21:51:04] New review: Hashar; "Requires JJB upstream change https://review.openstack.org/#/c/32965/" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [21:52:09] Reedy: Don't see a message cache rebuild in the SAL - did you get a chance to do that? [21:54:17] Change merged: Ori.livneh; [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68340 [22:00:34] fatal: reference is not a tree: 967ec6fa35df1d42d6dbd45208a8792565d87074 [22:00:34] Unable to checkout '4d25bdd4e152fce719b46e702578e70d85119071' in submodule path 'WikibaseDataModel' [22:00:35] Unable to checkout '967ec6fa35df1d42d6dbd45208a8792565d87074' in submodule path 'WikibaseQueryEngine' [22:00:35] Updating extensions FAILED. [22:00:36] Awesome [22:03:01] New patchset: Spage; "Add Campaigns extension to 1.22wmf7" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68568 [22:05:13] New patchset: Reedy; "Cleanup bv2013/doSpam.php" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/68478 [22:06:32] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [22:07:09] New patchset: Hashar; "apps-android-commons-build" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/68566 [22:07:15] Published patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [22:07:42] Project browsertests-test2.wikipedia.org-linux-chrome build #383: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/383/ [22:07:43] New review: Wikinaut; "simply using " [mediawiki/extensions/AJAXPoll] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67002 [22:08:00] New review: Bsitu; "One problem with this approach is that if a user hits reset, these two options would not default bac..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297 [22:08:37] andd i am sleeping [22:10:53] Submodule 'bootstrap' (https://github.com/twitter/bootstrap.git) registered for path 'bootstrap' [22:10:53] Cloning into 'bootstrap'... [22:11:09] well, that's never going to finish [22:11:56] Project browsertests-test2.wikipedia.org-linux-firefox build #342: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/342/ [22:12:20] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68568 [22:12:33] Reedy: give it a chance [22:12:40] ori-l: No, it'll never finish [22:12:47] it can't access github [22:12:52] no matter how hard it tries [22:12:53] or doesn't [22:12:57] sorry, i was joking [22:13:04] I wasn't sure... ;) [22:13:45] New review: Parent5446; "That's a good point. In that case I guess this change is OK." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297 [22:14:11] Hmm, doesn't actually fail though [22:14:12] https://github.com/leafo/lessphp.git [22:14:46] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68572 [22:14:54] At least it'll carry on without dying completely.. [22:15:11] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68573 [22:15:30] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68572 [22:15:36] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68573 [22:17:11] New review: Brian Wolff; "Jenkins doesn't seem to check this extension(?)" [mediawiki/extensions/AJAXPoll] (master); V: 2 - https://gerrit.wikimedia.org/r/67002 [22:17:11] Change merged: Brian Wolff; [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [22:17:57] spagewmf: [22:18:09] spagewmf: Please refrain from merging things into wmf7 during other people's deployment windows [22:18:41] RoanKattouw: sorry, I'm at fault [22:18:46] didn't notice the time [22:18:58] Would you like me to push that out with my change (I'm scapping anyway)? [22:19:08] RoanKattouw: sure, thanks, and apologies again. [22:19:25] Just Campaigns in wmf7 ,right? [22:19:32] Ahm wait [22:19:39] That's an addition, not an update [22:19:41] OK [22:20:03] yes; nothing's using it yet. (no config change) [22:20:04] ori-l: I'm adding it but it's not in extension-list so it won't be enabled [22:20:12] that's fine, yeah. thanks. [22:20:13] New patchset: MarkTraceur; "Deal with failure to understand "this" in UWI" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/68574 [22:20:14] You also cannot put it in extension-list without also putting it in wmf6, FYI [22:20:50] Yep. [22:25:56] New patchset: Reedy; "Fix wikibase refs" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/68576 [22:26:03] RoanKattouw: is there an event that is published when the VE editer ui is setup, and/or when the content wysiwyg is finished rendering ? [22:26:09] Change merged: Reedy; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/68576 [22:26:17] thedj: You mean an EventLogging event? [22:26:27] i mean a jquery hook [22:26:29] Oh [22:26:41] Not currently [22:26:43] But that sounds useful [22:27:23] I hate to say it but patches are welcome. I have too many other things to work on right now [22:27:26] New patchset: Ori.livneh; "(Bug 38894) Abort{New,Auto}Account: error may be Message or HTML." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64645 [22:27:40] RoanKattouw: i'll make a ticket and if i have the time submit a patch [22:27:59] OK cool [22:28:03] The bug report will help at least [22:28:09] That'll bring it to James's attention [22:33:52] Published patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [22:33:53] Warning: file_get_contents(/var/lib/l10nupdate/mediawiki/extensions/StrategyWiki/ActiveStrategy%2FActiveStrategy.i18n.php): failed to open stream: No such file or directory in /a/common/php-1.22wmf7/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 255 [22:33:53] Cannot get the contents of /var/lib/l10nupdate/mediawiki/extensions/StrategyWiki/ActiveStrategy%2FActiveStrategy.i18n.php [22:33:53] Failed to read /var/lib/l10nupdate/mediawiki/extensions/StrategyWiki/ActiveStrategy%2FActiveStrategy.i18n.php [22:34:03] Why is part of it encoded? [22:34:18] anomie: ^ [22:34:27] New review: Wikinaut; "remark: the new database code with makeList not tested yet." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211 [22:35:29] New review: Anomie; "This is definitely not the right way to do this." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/68297 [22:36:53] Reedy: Fix is already merged, and will be backported during the lightning deploy slot in about 25 minutes. [22:37:55] anomie: FYI I still have a scap running [22:38:04] I'll let you know when it finishes [22:38:08] Reedy: !g 67531 is what broke it, and !g 68546 is the fix, BTW. [22:38:10] RoanKattouw: Ok [22:38:12] Should be on time for your window but you never know [22:40:04] New patchset: Ori.livneh; "Add 'Campaigns' extension" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68582 [22:44:15] are there any helper functions in mw javascript to take a url and add a parameter to the query string? Couldn't certainly do raw string manipulation but seemed like something there might alreay be an abstraction for [22:48:09] Theres a Url/Uri module. [22:50:10] New review: Amire80; "I don't see a fix for it anywhere either, unless I'm missing something." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67589 [22:52:32] DanielFriesen: hmm, any better pointers where that would be? my grep-fu is weak today [22:53:45] https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#mediawiki.Uri [22:53:46] New review: TheDJ; "Hmm, now the mediawiki.special.changeslist css is loaded trough Javascript, causing a FOUC..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [22:54:03] DanielFriesen: awsome, thanks! [22:58:44] RoanKattouw: So the two issues I've been seeing in VE edits are: spurious tags; and occasionally awkward template parameter (or HTML attribute) normalization. [22:58:55] The latter resulting in dirty diffs. [22:59:27] Elsie: Those sound like Parsoid issues [22:59:34] * RoanKattouw directs Elsie to #mediawiki-parsoid ;) [23:00:33] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/68462 [23:00:36] Well... perhaps. [23:00:57] New patchset: Catrope; "Update VisualEditor for i18n change" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68585 [23:01:06] New patchset: Catrope; "Update VisualEditor for i18n change" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68586 [23:01:15] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68586 [23:01:26] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68585 [23:01:45] New patchset: Anomie; "Update LocalisationUpdate to master" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68587 [23:01:47] New review: Jdlrobson; "(1 comment)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212 [23:01:54] New review: Bsitu; "I talked with Kaldari about this patch earlier and I believe he was thinking about something else." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/67589 [23:02:00] New review: Anomie; "Backport" [mediawiki/core] (wmf/1.22wmf7); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68587 [23:02:01] Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68587 [23:04:30] ^demon: what is mwimport? [23:05:00] some sort of importDump.php wrapper? does it pass --no-updates ? [23:05:08] <^demon> I have no clue. [23:05:18] <^demon> I was going to use importDump with --no-updates. [23:06:24] <^demon> AaronSchulz: https://meta.wikimedia.org/wiki/Data_dumps/mwimport [23:06:51] New patchset: Hoo man; "Fix patrolling where NP patrol isn't explicitly enabled" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68588 [23:07:13] "It can only output SQL statements according to MediaWiki schema version 1.5." [23:07:16] ...right [23:08:22] Yippie, build fixed! [23:08:22] Project browsertests-en.wikipedia.org-linux-firefox build #113: FIXED in 4 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/113/ [23:08:27] Change merged: MarkTraceur; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68559 [23:08:41] New patchset: Brian Wolff; "Fix patrolling where NP patrol isn't explicitly enabled" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68588 [23:09:25] New review: Aaron Schulz; "Did the /lib stuff come from somewhere? Needs docs/headers and such." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/68001 [23:12:25] Yippie, build fixed! [23:12:25] Project browsertests-en.wikipedia.org-linux-chrome build #122: FIXED in 4 min 2 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/122/ [23:12:38] New review: Aaron Schulz; "Layout seems mostly fine." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/68001 [23:13:51] New review: Patrick87; "This patch should be modified since it breaks watch list styling (notably the bolding of updated pag..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [23:14:31] New review: TheDJ; "Or rather, .mw-changeslist-line-watched .mw-title, is part of this CSS, and it's not related to enha..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [23:14:45] New patchset: Hoo man; "Fix patrolling where NP patrol isn't explicitly enabled" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68589 [23:15:36] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68582 [23:16:23] New patchset: Ori.livneh; "Add 'CoreEvents' extension" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68591 [23:17:57] New patchset: Ori.livneh; "Add 'CoreEvents' extension" [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68592 [23:18:25] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68588 [23:19:13] <^demon> AaronSchulz: mwdumper seems to be way faster :p [23:19:54] Change abandoned: Hoo man; "Probably PageTriage is broken, this fix doesn't apply to WMF configuration." [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68589 [23:21:43] New patchset: EBernhardson; "Talk page links in notifications should not follow redirects" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [23:22:02] Yippie, build fixed! [23:22:03] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #119: FIXED in 9 min 37 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/119/ [23:24:58] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68591 [23:25:22] New review: Parent5446; "Looks good at first glance. Will test later, and also let Nikerabbit take a look." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/68211 [23:26:13] Nikerabbit: i think i halved the ULS window loading time. (again.) [23:26:31] praise me. [23:26:31] Nikerabbit: i'll get you the patch shortly [23:27:18] New patchset: Spage; "Revert removal of server-side log events" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68593 [23:27:20] MatmaRex: santhosh may be a better bet for an EET-night praise [23:28:04] New review: Brian Wolff; "Note, on test2 it seems that PageTriage currently universially hides new page patrol link regardless..." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/67872 [23:28:44] Nikerabbit: javascript execution down from 880ms to 450 ms ~ [23:29:18] and it took, uh [23:29:22] 1 files changed, 13 insertions(+), 5 deletions(-) [23:33:04] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf7) - https://gerrit.wikimedia.org/r/68592 [23:33:50] * AaronSchulz hands https://gerrit.wikimedia.org/r/#/c/68203/ to TimStarling [23:33:57] New review: Tim Starling; ""limitreport-expenseivefunctioncount" is spelt wrong everywhere. Otherwise, looks good, can be merge..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53802 [23:35:34] New patchset: Ryan Lane; "WORK IN PROGRESS: Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126 [23:37:01] New patchset: Tim Starling; "Made purgeDeletedFiles.php delete files still in the public zone." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68203 [23:38:12] New review: Hoo man; "I can't test this right now as I don't have the extension installed." [mediawiki/extensions/PageTriage] (master) C: 1; - https://gerrit.wikimedia.org/r/67872 [23:39:10] New patchset: Ryan Lane; "WORK IN PROGRESS: Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126 [23:39:23] New patchset: Subramanya Sastry; "Added parsoid-only tests for parsoid's native cite implementation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68596 [23:39:36] TimStarling: oh, and https://gerrit.wikimedia.org/r/#/c/67880/2 is fairly small [23:39:42] * AaronSchulz squeezes the lemon [23:39:51] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [23:41:14] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68203 [23:41:35] interesting concept [23:41:50] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #88: FAILURE in 9 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/88/ [23:42:58] do you know if it has been studied? [23:42:59] TimStarling: by the way, we have auto-ejection on with TwemProxy [23:43:56] well, there are certainly a few papers about tracking and purging vs adaptive TTLs [23:44:13] so I guess somebody studied that ;) [23:45:19] how did you choose the tunables? [23:45:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68596 [23:46:32] New review: Anomie; "At least it was consistent!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [23:46:51] I just used the same ones FileBackend uses...I vaguely recall looking at some tables and examples for that [23:47:00] New patchset: Anomie; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [23:47:54] New patchset: Mattflaschen; "Add CoreEvents extension." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/68599 [23:48:17] New patchset: Anomie; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [23:48:18] I think I also mixing that up with some reading on exponential average factor tables I was doing for some other thing I stopped working on [23:49:07] the physicist in me is saying that a formula like that needs an exponential somewhere ;) [23:49:21] TimStarling: I suppose I can do a random (by SHA1) sample of highly used files and get a histogram [23:49:46] though most high use items to be well established and not new (though they'd count as new if recently moved) [23:49:51] but the software engineer is wondering how many times it will be recached, assuming it starts with minTTL and is requested regularly forever [23:50:49] I think the main case to think about would be re-uploading over a heavily used file [23:51:27] Nikerabbit: more commits on https://github.com/wikimedia/jquery.uls/pull/97 [23:51:45] Nikerabbit: and on https://github.com/wikimedia/jquery.uls/pull/98 , too [23:52:30] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #99: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/99/ [23:53:54] * TimStarling plugs the numbers into a spreadsheet [23:54:25] @notify santhosh [23:54:25] I'll let you know when I see santhosh around here [23:54:36] I can always trust Aaron to come with the most interesting "small" changes [23:57:18] so the answer is that if missingTTL were unspecified, the file would be recached 46 times in the first day [23:57:47] New patchset: TheDJ; "Further improve load order of RC and watchlist styling" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68601 [23:57:58] but since missingTTL is 1 day, we can skip to the second day, when it will be recached 7 times [23:58:05] New review: TheDJ; "https://gerrit.wikimedia.org/r/#/c/68601/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [23:59:54] basically I'm wondering why $factor should be low