[00:19:26] <gerrit-wm>	 New review: Aaron Schulz; "I don't agree that the risk of someone thinking it is somehow elitist is worth the small loss of cla..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/68121
[00:28:02] <gerrit-wm>	 New review: Parent5446; "OK then I'll provide a specific example. Right now Extension:SSLClientAuthentication uses $user->get..." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/67876
[00:32:07] <gerrit-wm>	 New patchset: Mattflaschen; "Default schema location to Meta, matching revids in extensions." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68122
[00:32:27] <gerrit-wm>	 New review: Mattflaschen; "See IRC" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68122
[00:38:21] <gerrit-wm>	 New patchset: Jdlrobson; "Proof of concept: Allow templates to have css associated with them" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123
[00:38:40] <gerrit-wm>	 New review: Jdlrobson; "Posting for discussion not necessarily merging :)" [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/68123
[00:41:04] <gerrit-wm>	 New patchset: Jdlrobson; "Proof of concept: Allow templates to have css associated with them" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123
[00:42:44] <gerrit-wm>	 New patchset: Jdlrobson; "Proof of concept: Allow templates to have css associated with them" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123
[00:50:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68122
[00:56:17] <gerrit-wm>	 New review: Parent5446; "Two code issues." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/68123
[00:58:02] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #297: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/297/
[00:58:09] <gerrit-wm>	 New review: Tim Starling; "The performance is still as bad as ever. When I tested this, I got two additional queries per RC row..." [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/66191
[01:00:27] <gerrit-wm>	 New review: Spage; "The check works but is it necessary? I may have discovered a flaw in your tests." [mediawiki/extensions/GuidedTour] (master); V: 1 C: -1;  - https://gerrit.wikimedia.org/r/65154
[01:01:15] <gerrit-wm>	 New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572
[01:03:58] <gerrit-wm>	 New review: Tim Starling; "No, "if and only if" is not elitist, you can write that if you want. I didn't just replace "iff" wit..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68121
[01:04:36] <gerrit-wm>	 New patchset: Kaldari; "Calling functions explicitly due to context" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68125
[01:07:54] <gerrit-wm>	 New patchset: Ryan Lane; "WORK IN PROGRESS: Add resize support" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/68126
[01:10:02] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68125
[01:14:52] <gerrit-wm>	 New review: Mattflaschen; "See inline." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154
[01:40:13] <gerrit-wm>	 New review: Tim Starling; "I think you'd be better off just adding a <style> tag and deduplicating the styles thus generated. T..." [mediawiki/core] (master) C: -2;  - https://gerrit.wikimedia.org/r/68123
[02:08:18] <gerrit-wm>	 New patchset: Mattflaschen; "Move PageContentSaveComplete from EventLogging." [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68131
[03:21:46] <gerrit-wm>	 Change merged: Ori.livneh; [mediawiki/extensions/CoreEvents] (master) - https://gerrit.wikimedia.org/r/68131
[03:32:32] <gerrit-wm>	 New review: MZMcBride; "I feel like "iff" works better on-wiki where it can be linked. The wikis also are more education-foc..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68121
[03:42:06] <gerrit-wm>	 New review: Spage; "(1 comment)" [mediawiki/core] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/52749
[03:45:29] <gerrit-wm>	 New review: Brian Wolff; "Re: SPage - you can have parameters survive the redirect, it just needs to be a redirect special pag..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52749
[03:50:50] <gerrit-wm>	 New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561
[03:54:37] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68132
[04:17:36] <gerrit-wm>	 New patchset: Santhosh; "Scroll to viewport after input methods list is rendered" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68134
[04:19:58] <gerrit-wm>	 New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885
[04:24:10] <gerrit-wm>	 New patchset: Mattflaschen; "Remove gt.initGuider, allow one guider per tour at a time:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171
[05:36:06] <gerrit-wm>	 New patchset: Aaron Schulz; "Removed redundant documentation for some methods." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68136
[05:38:07] <gerrit-wm>	 New review: KartikMistry; "Looks good to me. Thanks for quick fix." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/68134
[05:39:52] <gerrit-wm>	 New patchset: Spage; "Add campaign support" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587
[05:42:04] <gerrit-wm>	 Change abandoned: Spage; "Since the code removing ServerSideAccountCreation from EventLogging is already committed to master, ..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944
[05:42:05] <gerrit-wm>	 New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675
[05:46:00] <gerrit-wm>	 Published patchset: Wikinaut; "added newline character after the delete message." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675
[05:57:01] <gerrit-wm>	 New patchset: Mattflaschen; "Cleanup jsduck documentation and commenting:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/68137
[06:10:59] <gerrit-wm>	 New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68132
[06:14:59] <gerrit-wm>	 New review: Mattflaschen; "Asirra is fully fixed.  ReCAPTCHA will be in a separate change." [mediawiki/extensions/ConfirmEdit] (master) C: 2;  - https://gerrit.wikimedia.org/r/60366
[06:15:15] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60366
[06:26:11] <gerrit-wm>	 New patchset: Mattflaschen; "Fix reCAPTCHA password message." [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/68138
[06:34:22] <gerrit-wm>	 New patchset: Mattflaschen; "Fixup mixed leading whitespace" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67451
[06:49:18] <gerrit-wm>	 New patchset: Siebrand; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68132
[06:50:01] <gerrit-wm>	 New patchset: Santhosh; "Use Tipsy on "Language settings" tooltip" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68139
[06:53:28] <gerrit-wm>	 New patchset: Santhosh; "Scroll to viewport after input methods list is rendered" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68134
[07:04:01] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171
[07:06:19] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67451
[07:13:31] <gerrit-wm>	 New review: KartikMistry; "LGTM." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1;  - https://gerrit.wikimedia.org/r/68139
[07:24:31] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68132
[07:25:13] <gerrit-wm>	 New review: Daniel Friesen; ""there may be new security issues in the validation of entire stylesheets."" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123
[07:30:36] <gerrit-wm>	 New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233
[07:41:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68134
[07:52:44] <gerrit-wm>	 New review: Nikerabbit; "When changing language, I now see "Language settings" instead of "Language changed from X"" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1;  - https://gerrit.wikimedia.org/r/68139
[07:55:51] <gerrit-wm>	 New review: Nikerabbit; "I was unable to see font change in the following scenario:" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1;  - https://gerrit.wikimedia.org/r/67825
[07:57:26] <gerrit-wm>	 Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68025
[08:18:49] <gerrit-wm>	 New patchset: Ori.livneh; "'encapsulate' => 'prepare'; computed properties" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140
[08:33:21] <gerrit-wm>	 New review: Yuvipanda; "For a moment I thought this was going to be generally available on the Server Side to any client..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68140
[08:36:13] <gerrit-wm>	 New patchset: J; "More accurate timming for captions, progress event fixes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998
[08:37:20] <gerrit-wm>	 New patchset: SuchABot; "Adding roles for the ProofreadPage and WikiEditor extension" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/68141
[08:38:29] <gerrit-wm>	 New patchset: Nemo bis; "Remove unused searchhelp-url and searchmenu-help" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68142
[08:42:10] <gerrit-wm>	 New review: Nemo bis; "@Bawolff, ok, I'll do that in a separate commit, we just have to link the PD help docs index. Should..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337
[08:42:52] <gerrit-wm>	 New patchset: MrFredH; "Bugfix 47055: Modified Revision::fetchFromConds to fix a postgres related constraint, relating to select queries with FOR UPDATE clause, which Postgres objects to when the query contains a join. This is as described in https://bugzilla.wikimedia.org/show_" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68143
[08:44:17] <gerrit-wm>	 New review: J; "progress is download progress, this is not fired once the video is downloaded, for timed text you wa..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/67998
[09:02:36] <gerrit-wm>	 New patchset: Santhosh; "Use Tipsy on "Language settings" tooltip" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68139
[09:03:19] <gerrit-wm>	 New review: MrFredH; "I had to make this change to my 1.21.1 install to get extension Nuke to work." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/68143
[09:11:23] <gerrit-wm>	 New review: J; "also TextSource.match2caption formats milliseconds as second before passing it as milliseconds again..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998
[09:15:31] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68120
[09:16:40] <gerrit-wm>	 New review: Daniel Kinzler; "@Spage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[09:19:19] <gerrit-wm>	 New review: Ori.livneh; "Daniel, do you know which other extensions rely on this interface? I don't mind making the requisite..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[09:20:00] <gerrit-wm>	 New patchset: Ori.livneh; "Adding roles for the ProofreadPage and WikiEditor extension" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/68141
[09:20:33] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/68141
[09:24:32] <gerrit-wm>	 New patchset: Santhosh; "Allow non-translators to sign up" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/64591
[09:26:37] <gerrit-wm>	 New review: Daniel Kinzler; "@Spage: thanks for your comments, I'll amend, fixing the documentation." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/67983
[09:27:20] <gerrit-wm>	 New review: Daniel Kinzler; "@Ori: I only know of the EventLogger thing and the Zero thing, but there may be more, I don't know." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[09:31:04] <gerrit-wm>	 New patchset: Nikerabbit; "Add composer.json" [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/68145
[09:50:22] <ori-l>	 YuviPanda: http://googlewebmastercentral.blogspot.com.br/2013/06/changes-in-rankings-of-smartphone_11.html
[09:51:42] <YuviPanda>	 ori-l: other than 'unplayable videos' I think we are all good :)
[09:51:52] <YuviPanda>	 ori-l: besides, Wikipedia is reasonably specialcased inside Google, IIRC
[09:52:03] <ori-l>	 yeah, i thought so
[09:52:10] <YuviPanda>	 (they even had a project going on where they were serving wiki content from their servers (cached) for a while)
[09:52:22] <YuviPanda>	 IIRC that was killed
[09:52:32] <YuviPanda>	 but yeah, even without that we're good
[10:27:39] <DanielFriesen>	 Hmmm http://googlewebmastercentral.blogspot.ca/2013/04/x-default-hreflang-for-international-pages.html interesting thought for our variants
[10:27:54] <DanielFriesen>	 ie: /wiki/ is x-default
[10:43:53] <Nemo_bis>	 uh https://productforums.google.com/forum/#!categories/webmasters/internationalization
[10:46:00] <Nemo_bis>	 DanielFriesen: I still didn't get your "ie: /wiki/ is x-default"
[10:47:20] <DanielFriesen>	 We already use rel=alternate hreflang for variants.
[10:47:49] <DanielFriesen>	 <link rel="alternate" hreflang="zh" href="/zh/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:47:52] <DanielFriesen>	 <link rel="alternate" hreflang="zh-hans" href="/zh-hans/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:47:55] <DanielFriesen>	 <link rel="alternate" hreflang="zh-hant" href="/zh-hant/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:47:59] <DanielFriesen>	 <link rel="alternate" hreflang="zh-cn" href="/zh-cn/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:01] <DanielFriesen>	 <link rel="alternate" hreflang="zh-hk" href="/zh-hk/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:04] <DanielFriesen>	 <link rel="alternate" hreflang="zh-mo" href="/zh-mo/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:07] <DanielFriesen>	 <link rel="alternate" hreflang="zh-sg" href="/zh-sg/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:11] <DanielFriesen>	 <link rel="alternate" hreflang="zh-tw" href="/zh-tw/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:14] <DanielFriesen>	 Going by that new post we could also now add:
[10:48:27] <DanielFriesen>	 <link rel="alternate" hreflang="x-default" href="/wiki/Wikipedia:%E9%A6%96%E9%A1%B5" />
[10:48:32] <Nemo_bis>	 ah, you meant language converter
[10:48:53] <Nemo_bis>	 it could also be used for /wiki/Special:MyLanguage/*
[10:49:06] <DanielFriesen>	 Haven't looked at that before
[10:50:13] <DanielFriesen>	 Though if you're suggesting that redirects, etc... where we insert some variant = blah that we can use an x-default to point those redirects to the plain /wiki/ instead, sure.
[10:50:58] <DanielFriesen>	 Heck we could probably add &uselang=x-default as a way for a logged in user to bypass their own personal lang preferences and view the wiki's UI in the content lang.
[10:51:44] <DanielFriesen>	 Nemo_bis: Want to make the tweaks or want me to put them in my black hole?
[10:55:05] <Nemo_bis>	 DanielFriesen: if you think x-default should be used for it, file a bug against Translate and you'll get opinions
[10:55:25] <Nemo_bis>	 you can always assign it to yourself at some point :)
[10:58:24] <liangent>	 for my comments on   https://gerrit.wikimedia.org/r/68146    I guess one more language selector on zhwiki confuses some people more
[10:59:12] <liangent>	 currently there're already two on Preferences: one for uselang and another for variant, which are already confusing for some users
[10:59:21] <liangent>	 now the same happens on every page
[10:59:44] <liangent>	 also, Narayam isn't really useful on zhwiki
[10:59:46] <liangent>	 Nemo_bis: ^
[11:00:24] <Nemo_bis>	 liangent: maybe you could ask this on the ULS talk and/or join the IRC office hours today 1700-1800 UTC if it's not too late?
[11:01:27] <Nemo_bis>	 liangent: https://www.mediawiki.org/wiki/Talk:Universal_Language_Selector + email pginer@
[11:05:01] <liangent>	 Nemo_bis: so any potential solution?
[11:05:29] <liangent>	 maybe we can merge the variant selector into uls during uls startup?
[11:06:07] <Nemo_bis>	 liangent: sorry, I have no idea, that's why I suggest to ask Pau who's the designer :)
[11:13:57] <gerrit-wm>	 New review: Liangent; "One more alternative solution: One pref entry per language-with-variants ie variant-zh, variant-sr, ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10243
[11:25:15] <gerrit-wm>	 New patchset: Nikerabbit; "Use resource loader module for project icons" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68154
[11:27:17] <gerrit-wm>	 New patchset: Nikerabbit; "Use resource loader module for project icons" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68154
[11:33:20] <gerrit-wm>	 New patchset: Matthias Mullie; "(bug 49445) IE9: intermittent: AFTv5 not appearing in beta labs" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/68157
[11:36:07] <gerrit-wm>	 New patchset: Santhosh; "Input settings - language selection cleanup" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68159
[11:38:04] <gerrit-wm>	 New patchset: Nikerabbit; "Remove custom border from input elements" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/68160
[11:41:57] <gerrit-wm>	 New patchset: Santhosh; "Input settings - language selection cleanup" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/68159
[12:13:39] <gerrit-wm>	 New patchset: Liangent; "Allow more than one variant set in user preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10243
[12:25:26] <gerrit-wm>	 New patchset: Matthias Mullie; "Make lottery-based default permission level check safer" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/68165
[12:33:25] <gerrit-wm>	 New patchset: Liangent; "Allow more than one variant set in user preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10243
[12:40:03] <liangent>	 Nemo_bis: http://imagebin.org/261112 a horrible set of dropdowns for languages...
[12:43:30] <gerrit-wm>	 New review: Nischayn22; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: 1;  - https://gerrit.wikimedia.org/r/65681
[12:58:28] <Nemo_bis>	 eek
[13:42:44] <gerrit-wm>	 New patchset: Liangent; "Allow more than one variant set in user preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10243
[13:46:44] <gerrit-wm>	 New patchset: Liangent; "Allow more than one variant set in user preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/10243
[13:46:56] <gerrit-wm>	 New patchset: Nischayn22; "Correct tabIndexes" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176
[13:49:17] <gerrit-wm>	 New patchset: Mdale; "More accurate timming for captions, progress event fixes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998
[13:55:00] <gerrit-wm>	 New patchset: Nischayn22; "Correct tabIndexes" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176
[13:55:51] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68176
[13:58:17] <gerrit-wm>	 New patchset: Mdale; "mw.measurements2seconds now returns float seconds not int" [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/68178
[14:00:35] <gerrit-wm>	 New review: Mdale; "Thanks J, yes of course "timeupdate" :) " [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998
[14:15:45] <gerrit-wm>	 New review: Brion VIBBER; "If we wanted to go to a lot of effort we could probably enforce prefixing of ids and classes in the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68123
[14:20:36] <DanielFriesen>	 hmmm
[14:21:48] <DanielFriesen>	 Looks like our exports may be outdated with the addition of ContentHandler.
[14:34:01] <gerrit-wm>	 New review: Cmcmahon; "Seems like it would be harmless in any case, and if it makes IE9 do the right thing, that would be h..." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1;  - https://gerrit.wikimedia.org/r/68157
[14:37:04] <gerrit-wm>	 New patchset: Nischayn22; "Login user after Signup" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68179
[14:39:12] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/68179
[14:44:52] <gerrit-wm>	 New review: MZMcBride; "If you're fixing a rare race condition in a specific browser, an associated inline comment in the co..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040
[14:52:05] <gerrit-wm>	 New review: Siebrand; "Looks good to me from a functional perspective. I am not able to answer your questions on optimising..." [qa/browsertests] (master) C: 1;  - https://gerrit.wikimedia.org/r/67873
[14:57:46] <gerrit-wm>	 New review: J; "looks ok but the issue in 67998 is that milliseconds is passed as seconds, but we need to pass milli..." [mediawiki/extensions/MwEmbedSupport] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68178
[14:57:54] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/MwEmbedSupport] (master) - https://gerrit.wikimedia.org/r/68178
[15:00:47] <gerrit-wm>	 New review: J; "you still have to pass milliseconds not second sfloat in  match2caption" [mediawiki/extensions/TimedMediaHandler] (master) C: -1;  - https://gerrit.wikimedia.org/r/67998
[15:01:03] <gerrit-wm>	 New patchset: Hashar; "html in their own files" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68185
[15:01:03] <gerrit-wm>	 New patchset: Hashar; "automatically flush the content via a __destruct() call" [integration/docroot] (master) - https://gerrit.wikimedia.org/r/68186
[15:09:43] <ebernhar1son>	 say you are developing an extension that will need the concept of revisioned text, but its not a literal wiki pages text(no page_id, etc.) ... does it seem reasonable to (within the extension) make an 'AbstractRevision' class which is basically the standard Revision class but with all title/page related functionality pushed into abstract methods?  The extension itself will be using the extension db, not the primary one(so no overlap in
[15:09:49] <ebernhar1son>	 bah that ended up way too long ...
[15:11:08] <MatmaRex>	 ebernhar1son: your message was cut off at "(so no overlap in"
[15:11:31] <MatmaRex>	 also, to me it seems like the extension should just use wiki pages…
[15:11:49] <ebernhar1son>	 MatmaRex: well, the thing is the extension is on a seperate db cluster
[15:11:57] <ebernhar1son>	 MatmaRex: and the content is not related to anything with a page_id
[15:12:15] <ebernhar1son>	 which makes it, difficult, to use proper wiki pages
[15:13:39] <ebernhar1son>	 MatmaRex: anything is possible, what would be your suggestion there, insert a bunch of fake pages with 'unlikely' titles?
[15:13:54] <ebernhar1son>	 MatmaRex: or how would you use the revisions table without a Title or wiki page to associate with?
[15:14:49] * MatmaRex  has no idea

[15:14:55] <MatmaRex>	 probably insert pages in a new namespace?
[15:14:59] <ebernhar1son>	 neither do I, which is why i'm asking here :)
[15:15:17] <ebernhar1son>	 hmm, a custom namespace has potential
[15:17:05] <ebernhardson>	 although, i wonder if that also defeats some of the purpose of having an independant db cluster to run Flow on,  since it would push alot of the heavy lifting back onto the already heavily loaded primary db cluster
[15:17:28] <MatmaRex>	 you're talking about Flow? :o
[15:17:33] <ebernhardson>	 yes, the whole time :P
[15:17:49] <ebernhardson>	 thats what needs revisions (flow summarys, posts by users, votes, etc)
[15:17:55] <MatmaRex>	 why wouldn't that information be stored on the wiki the users are editing from?
[15:18:04] <ebernhardson>	 flow is multi-wiki
[15:18:09] <ebernhardson>	 one flow, all wiki's
[15:18:09] <MatmaRex>	 i was thinking, dunno, something silly like AFT
[15:18:28] <MatmaRex>	 that doesn't sound like a good idea to me
[15:19:08] <MatmaRex>	 with ContentHandler i don't see what could be the trouble with storing discussions as wiki pages
[15:19:39] <ebernhardson>	 well, i think the concern there(from other that used LQT) is that loading a few hundred wiki pages (each post is its own revisioned page) was "very slow"
[15:19:54] <MatmaRex>	 then use only one wiki page for the entire discussion?
[15:19:55] <ebernhardson>	 but i dont know enough about it, still learning and figuring out
[15:20:02] <MatmaRex>	 you can prevent users from editing the data blob directly
[15:20:04] <MatmaRex>	 (Wikidata does it)
[15:20:21] <MatmaRex>	 and honestly the Flow guys is the first time I hear about LqT being slow
[15:20:36] <MatmaRex>	 (but i admin, i don't have much experience with it)
[15:20:38] <MatmaRex>	 admit*
[15:20:46] <ebernhardson>	 i have no experience with it, so i have to believe what people tell me :S
[15:21:24] <MatmaRex>	 LqT has its own share of problems, there's no need to invent new ones
[15:21:42] <ebernhardson>	 what are they?  its good to know what the previous attempt failed at
[15:22:02] <MatmaRex>	 the UI, mostly
[15:22:24] <MatmaRex>	 (you could certainly count a couple dozen separate problems there :P)
[15:22:46] <MatmaRex>	 !bug :liquidthreads
[15:22:46] <wm-bot>	 https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=%3aliquidthreads
[15:23:22] <ebernhardson>	 i'll have to think about the "1 large blob" idea,  currently all the post data is transfered from the wiki to the UI as structured json about each post, will have to think about how to go from wiki page -> structured json (since wiki pages are as unstructured as they come )
[15:24:00] <MatmaRex>	 you can store the JSON blobs as wiki pages with ContentHandler?
[15:24:06] <MatmaRex>	 (again, that's what Wikidata does)
[15:24:27] <ebernhardson>	 hmm, interesting.
[15:24:47] <ebernhardson>	 i suppose i need to learn more about ContentHandler as well, i've seen it but no clue what it really does
[15:24:53] <MatmaRex>	 and you can have structured diffs between them, too
[15:25:36] <ebernhardson>	 some good ideas, i appreciate it!
[15:38:21] <gerrit-wm>	 New patchset: Daniel Kinzler; "Introducing ContentGetParserOutput hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[15:38:51] <chrismcmahon>	 hi judytuna
[15:41:19] <gerrit-wm>	 New review: Daniel Kinzler; "gah! how did the orig files get into the commit!" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/67983
[15:42:11] <gerrit-wm>	 New patchset: Yaron Koren; "Added needed "static" declaration" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/68191
[15:42:20] <gerrit-wm>	 New patchset: Daniel Kinzler; "Introducing ContentGetParserOutput hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[15:43:13] <gerrit-wm>	 Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/68191
[15:45:04] <gerrit-wm>	 New review: Matthias Mullie; "Anyone comfortable reviewing this change?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620
[16:02:52] <gerrit-wm>	 New patchset: Brian Wolff; "Remove unused searchhelp-url and searchmenu-help" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68142
[16:04:52] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675
[16:05:35] <gerrit-wm>	 New patchset: Parent5446; "Modified Revision::fetchFromConds to fix a postgres related constraint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68143
[16:12:11] <gerrit-wm>	 New review: Brian Wolff; "Yeah, looks long gone." [mediawiki/core] (master) C: 2;  - https://gerrit.wikimedia.org/r/68142
[16:12:32] <gerrit-wm>	 New patchset: Raimond Spekking; "Fix message key rights -> right" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/68193
[16:14:40] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68142
[16:14:55] <gerrit-wm>	 New review: Brian Wolff; "Re Nemo: Yeah probably, or a mailing list post, just to make sure no one object to changing the defa..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337
[16:16:26] <gerrit-wm>	 New review: Raimond Spekking; "trivial self merge" [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68193
[16:16:26] <gerrit-wm>	 Change merged: Raimond Spekking; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/68193
[16:24:14] <gerrit-wm>	 New patchset: Cmcmahon; "prevent flaky test, check for element saying "Redirect page" not entire page text." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68194
[16:25:04] <gerrit-wm>	 New review: Cmcmahon; "refactor to prevent flaky test" [qa/browsertests] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68194
[16:25:04] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68194
[16:26:13] <gerrit-wm>	 New review: Parent5446; "Commented on bug." [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/68143
[16:44:37] <gerrit-wm>	 New review: CSteipp; "Tyler, it seems like that would only be a problem if you're having an OAuth client authenticate with..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876
[16:47:15] <wmf-selenium-bot>	 Yippie, build fixed!
[16:47:15] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #85: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/85/
[16:58:28] <Nemo_bis>	 Wikimedia Language Engineering team office hours in #wikimedia-office in 2 min, with the Universal Language Selector and more
[17:03:47] <qgil>	 robla, http://blog.bitergia.com/category/metrics-grimoire-2/
[17:06:50] <gerrit-wm>	 New patchset: Yurik; "Updated Zero extension to latest" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68196
[17:07:30] <gerrit-wm>	 New patchset: Yurik; "Updated Zero extension to latest" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68197
[17:08:03] <gerrit-wm>	 Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68197
[17:08:23] <gerrit-wm>	 Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68196
[17:10:31] <Nemo_bis>	 qgil: oh, I had just looked for something in their website
[17:20:41] <gerrit-wm>	 New patchset: Cmcmahon; "do not run PDF tests for IE7/IE6 Bug 49485" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68198
[17:21:14] <gerrit-wm>	 New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68198
[17:21:17] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68198
[17:22:32] <qgil>	 Nemo_bis, I'm glad your interest in metrics is alive  :)
[17:23:18] <Nemo_bis>	 qgil: /me, spying Wikimedia metrics since 2006 :P
[17:23:22] <gerrit-wm>	 New patchset: Anomie; "Make CentralAuth login more silent" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/68199
[17:23:34] <qgil>	 Nemo_bis, :D
[17:25:16] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67873
[17:35:40] <gerrit-wm>	 New patchset: Miguel2706; "Git-initial" [mediawiki/extensions/Ads] (master) - https://gerrit.wikimedia.org/r/68201
[17:42:05] <gerrit-wm>	 New review: MarkTraceur; "Shorter review :)" [mediawiki/extensions/UploadWizard] (master) C: -1;  - https://gerrit.wikimedia.org/r/66561
[17:42:12] <wmf-selenium-bot>	 Yippie, build fixed!
[17:42:12] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7 build #51: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_7/51/
[17:44:31] <gerrit-wm>	 New review: Miguel2706; "Great!" [mediawiki/extensions/Ads] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68201
[17:44:32] <gerrit-wm>	 Change merged: Miguel2706; [mediawiki/extensions/Ads] (master) - https://gerrit.wikimedia.org/r/68201
[17:48:29] <gerrit-wm>	 New patchset: Aaron Schulz; "Made purgeDeletedFiles.php delete files still in the public zone." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68203
[17:49:39] <YuviPanda>	 ohai ^demon. may I ask for a gerrit repository, with history import?
[17:49:45] <YuviPanda>	 (moving Android app to Gerrit)
[17:50:51] <^demon>	 YuviPanda: Put it on-wiki, I'll get it in a bit.
[17:51:02] <YuviPanda>	 ^demon: alright, ty.
[17:53:09] <gerrit-wm>	 New patchset: Rtdwivedi; "Separated data fetching from presentation and data manipulation from the page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68204
[17:54:09] <gerrit-wm>	 New patchset: Bsitu; "Remove quote around javascript object property name" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68205
[17:54:55] <gerrit-wm>	 New patchset: Rtdwivedi; "Separated data fetching from presentation and data manipulation from the page." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68204
[18:03:48] <gerrit-wm>	 New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876
[18:09:11] <gerrit-wm>	 New patchset: Cmcmahon; "do not run ULS tests for IE6/IE7" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68206
[18:09:46] <gerrit-wm>	 New review: Cmcmahon; "left out not to run this test on IE6/IE7" [qa/browsertests] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68206
[18:09:46] <gerrit-wm>	 Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68206
[18:10:43] <gerrit-wm>	 New review: Rasel160; "configuration for the selector is there, will add the configuration to load the template messages by..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561
[18:21:33] <gerrit-wm>	 New patchset: Greg Grossmeier; "Link to the correct Extension: page." [mediawiki/extensions/Calendar] (master) - https://gerrit.wikimedia.org/r/68209
[18:24:52] <gerrit-wm>	 New review: Lewis Cawte; "Looks good to me!" [mediawiki/extensions/Calendar] (master) C: 1;  - https://gerrit.wikimedia.org/r/68209
[18:25:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Calendar] (master) - https://gerrit.wikimedia.org/r/68209
[18:25:38] <gerrit-wm>	 New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875
[18:25:38] <gerrit-wm>	 New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876
[18:25:56] <gerrit-wm>	 New review: Anomie; "PS6: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876
[18:26:07] <gerrit-wm>	 New review: Anomie; "PS5: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875
[18:26:12] <wmf-selenium-bot>	 Yippie, build fixed!
[18:26:13] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6 build #52: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_6/52/
[18:31:26] <gerrit-wm>	 New review: MarkTraceur; "The configuration variable should be required to _turn on_ this feature. In its absence, the interfa..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561
[18:38:04] <aude>	 greg-g: Reedy poke
[18:38:15] <greg-g>	 hi there
[18:38:19] <aude>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=48506
[18:38:35] <aude>	 we have the maintenance script ready to fix that bug
[18:38:43] <aude>	 when would be a good time to run it?
[18:39:23] <aude>	 should be fairly quicky since it does not have to run through the entire page table.... just the missing ones
[18:39:43] <greg-g>	 cool, yeah, today is pretty open
[18:39:50] <aude>	 ok
[18:40:09] <aude>	 not urgent yet good to do asap since it's ready
[18:40:11] <greg-g>	 Reedy: around and able to run that script? Whenever you can really, it's an open day.
[18:40:12] <gerrit-wm>	 New patchset: Njw; "Add @media rules for small screens" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212
[18:40:32] <aude>	 it is rebuildEntityPerPage.php --only-missing
[18:40:40] <aude>	 in wikibase repo
[18:40:55] <aude>	 you can add --verbose to see progress
[18:57:10] <gerrit-wm>	 New review: Njw; "Note that you can see this deployed on a more or less fresh mediawiki install at the demo site: http..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68212
[18:57:25] <gerrit-wm>	 New review: Njw; "Note that you can see this deployed on a more or less fresh mediawiki install at the demo site: http..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68019
[19:06:03] <gerrit-wm>	 New review: Alex Monk; "Which is now at https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Archive_1#Notice_for_reverts" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61722
[19:12:56] <gerrit-wm>	 New review: MaxSem; "If this change has problems, I blame everyone who had a chance to review it but didn't:P" [mediawiki/extensions/Disambiguator] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/67367
[19:14:26] <MaxSem>	 let me guess: jenkins is dead again?
[19:14:52] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/67367
[19:21:25] <Krenair>	 Krinkle, ^demon: ^
[19:21:48] <^demon>	 Huh?
[19:21:56] <^demon>	 It's been fine since monday.
[19:23:50] <MatmaRex>	 on monday*
[19:23:51] <MatmaRex>	 :P
[19:24:20] <gerrit-wm>	 New review: Umherirrender; "Sounds like the 'checkPageRestrictions' should be marked as expensive, because it results in databas..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66191
[19:27:02] <gerrit-wm>	 New patchset: Foxtrott; "Popup forms: Save Page button does not work anymore" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68218
[19:27:18] <Krinkle>	 Krenair: what are you referring to?
[19:27:34] <Krenair>	 MaxSem thought Jenkins was not working
[19:27:38] <Krinkle>	 MaxSem: Jenkins has not been dead for months. The problem is in Gerrit
[19:27:51] <Krinkle>	 Gerrit is not sending Zuul events, thus Zuul doesn't spawn Jenkins jobs
[19:28:02] <Krinkle>	 However it is working fine
[19:28:04] <Krinkle>	 https://integration.wikimedia.org/zuul/
[19:28:14] <Krinkle>	 Maybe the queue is busy
[19:28:17] <Krinkle>	 0 pending
[19:28:56] <gerrit-wm>	 Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68218
[19:31:27] <MaxSem>	 it didn't start a gate'n'submit for that change, thus it passes my definition of dead:P
[19:31:28] <gerrit-wm>	 New patchset: Aaron Schulz; "filebackend: try to combine SH and EX lock acquisition" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68220
[19:34:45] <Krinkle>	 MaxSem: It might be because your action didn't match what it is looking for
[19:34:56] <Krinkle>	 You overwrote the verified field
[19:34:58] <Krinkle>	 don't do that
[19:35:28] <MaxSem>	 old good habit, however I've not seen it reacitng this way before
[19:35:44] <Krinkle>	 Maybe, just maybe, one can do that for deployment-sensitive changes when jenkins-bot is unavailable. But don't do it by default.
[19:36:15] <Krinkle>	 In preparing for revoking "Verified" from human accounts, I'm keeping statistics on how much it is used to ensure we don't break any use cases.
[19:36:37] <Krinkle>	 But for that it would help to not have as much uses of it that are unintentional. Anyway, no worries, but try to avoid from now on.
[19:39:39] <thedj>	 Krinkle: question, when it comes to top loaded RL modules vs bottom modules, do we have a 'rule of thumb'-list or something ?
[19:40:42] <gerrit-wm>	 New patchset: Asher; "support setting Memcached::OPT_SERVER_FAILURE_LIMIT, Memcached::OPT_RETRY_TIMEOUT" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68222
[19:42:24] <MatmaRex>	 thedj: i think it's styles on top if you need it to avoid FOUC, critical scripts which for some reason require it on top, the rest by default at bottom
[19:44:34] <thedj>	 MatmaRex: we should write something about this on the RL description page. it says something about styles, but the whole JS part is pretty much 'undescribed' when it comes to top vs bottom.
[19:44:44] <Krinkle>	 thedj: You mean when to use top and when to use bottom/
[19:44:56] <thedj>	 yes
[19:45:01] <thedj>	 specifically for scripts.
[19:46:05] <Krinkle>	 thedj: top should be used if something ( needs to execute before the dom is ready ) or if ( it needs to execute at document ready and affects the visual page above the fold )
[19:46:32] <Krinkle>	 and both cases you should try and keep the module as small as possible
[19:47:25] <Krinkle>	 which generally means it is like ext.foo.bar where .bar does not depend on ext.foo.core
[19:47:46] <gerrit-wm>	 New patchset: Asher; "support setting Memcached::OPT_SERVER_FAILURE_LIMIT, Memcached::OPT_RETRY_TIMEOUT" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68222
[19:47:57] <YuviPanda>	 ^demon: will you be able to create the repo today or is it going to be a bit more?
[19:48:14] <^demon>	 I will get to it today.
[19:48:49] <thedj>	 Krinkle: so if i want to add something to <head> i probably shouldn't use top  right ?
[19:49:45] <gerrit-wm>	 New patchset: Asher; "support setting Memcached::OPT_SERVER_FAILURE_LIMIT, Memcached::OPT_RETRY_TIMEOUT" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68222
[19:52:01] <Krinkle>	 thedj: Depends what it is
[19:55:06] <gerrit-wm>	 Published patchset: Wikinaut; "improvement of result page: adding missing <br> after edit count results" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68224
[19:55:27] <gerrit-wm>	 New review: Wikinaut; "small layout improvement of result page: adding missing <br> after edit count results" [mediawiki/extensions/UserMerge] (master) C: 1;  - https://gerrit.wikimedia.org/r/68224
[19:56:23] <gerrit-wm>	 New review: Wikinaut; "Tyler, I had to add a further >br>. See screenshots, links on the commit." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68224
[19:56:27] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68222
[19:56:58] <aude>	 greg-g: alright, i am off for the night
[19:57:43] <aude>	 script doesn't have to run today if not good for reedy etc. but just don't want to forget about it
[19:58:03] <aude>	 although it could be run with out my being around also
[19:58:16] <gerrit-wm>	 New patchset: IAlex; "Removed redundant documentation for some methods." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68113
[19:58:27] <gerrit-wm>	 New review: Wikinaut; "uh, wrong dependencies. One moment, please." [mediawiki/extensions/UserMerge] (master) C: -1;  - https://gerrit.wikimedia.org/r/68224
[19:59:42] <thedj>	 Krinkle: the config of MathJax, needs to be inserted as a <script> into head, and there is another script that actually does that. I'm wondering if I can move that thing into top.
[20:00:56] <Krinkle>	 thedj: Wait, you have a script that inserts a <script> tag? Why not execute it from the first script? Unlike css, javascript doesn't have to be in the dom in order to be available in the execution context
[20:01:01] <Krinkle>	 thedj: Which code reads the config?
[20:01:45] <greg-g>	 aude: noted. thanks, g'night!
[20:01:46] <Krinkle>	 Assuming it is read from a global variable (or a property on a variable) it just needs to be loaded in time for/before MathJax itself
[20:01:58] <aude>	 ok
[20:02:01] <Krinkle>	 thedj: As such I don't think it helps if you load it from the top, and if it does, then it is a no brainer.
[20:02:11] <Krinkle>	 thedj: the object being there doesn't do anything, right?
[20:02:29] <gerrit-wm>	 New patchset: Aaron Schulz; "support setting Memcached::OPT_SERVER_FAILURE_LIMIT, Memcached::OPT_RETRY_TIMEOUT" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68279
[20:02:32] <thedj>	 Well currently it's also loading the MathJax loader script.
[20:03:05] <thedj>	 I'm toying a bit with it, it's not really the most effecient right now I presume.
[20:03:43] <thedj>	 https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMath.git/a6c23c67c39106d517a71de5ff79b16c8174bfd7/Math.php
[20:03:53] <thedj>	 https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMath.git/a6c23c67c39106d517a71de5ff79b16c8174bfd7/modules%2Fext.math.mathjax.enabler.js
[20:04:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68113
[20:06:40] <thedj>	 both the RL enabler around mathjax (which add config and loads mathjax loader)  as well as the mathjax loader itself are now bottom modules.
[20:07:40] <gerrit-wm>	 New patchset: IAlex; "Removed redundant documentation for some methods." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68136
[20:08:53] <gerrit-wm>	 Change abandoned: Wikinaut; "this patch is not needed, I made a mistake locally." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68224
[20:18:27] <gerrit-wm>	 New patchset: Wikinaut; "code cosmetics: changing to Html class" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211
[20:20:36] <gerrit-wm>	 New review: Wikinaut; "Tyler, I upgraded the code to use Html class except a small part which still uses Xml. This will be ..." [mediawiki/extensions/UserMerge] (master) C: 1;  - https://gerrit.wikimedia.org/r/68211
[20:29:59] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68136
[20:31:32] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #85: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/85/
[20:38:12] <gerrit-wm>	 Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67445
[20:41:54] <gerrit-wm>	 New patchset: Andrew Bogott; "Make pep8 tests voting in operations/software" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68012
[20:43:41] <gerrit-wm>	 New patchset: SuchABot; "Volley images" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68282
[20:45:02] <gerrit-wm>	 New patchset: SuchABot; "Volley images" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68282
[20:52:33] <gerrit-wm>	 New review: Brion VIBBER; "With fix for <320 confirmed this works in LDPI emulator. Yay!" [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68282
[20:52:33] <gerrit-wm>	 Change merged: Brion VIBBER; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68282
[20:53:35] <YuviPanda>	 ^ woohoo \o/
[20:53:47] <brion>	 oh gerrit you wacky thing
[20:53:53] <brion>	 now you've been githubbinated
[20:54:07] <YuviPanda>	 brion: :D
[20:54:13] <YuviPanda>	 brion: we should do core patches this way :P
[20:54:53] <gerrit-wm>	 New patchset: Cmcmahon; "INCOMPLETE: use this code as a start for the training exercise June 27 before merging" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283
[20:56:34] <wmf-selenium-bot>	 Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #122: FAILURE in 25 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/122/
[20:57:22] <gerrit-wm>	 New review: Cmcmahon; "I'd like to use the code for the training session June 27. " [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283
[20:59:35] <gerrit-wm>	 New patchset: Bsitu; "Update mention notification threshold from 300 to 100" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68284
[21:00:22] <ebernhardson>	 are commit messages supposed to be manually wrapped at 80 chars? (mildly annoyed at a particular commit with a ~220 char line that has to be horizontally scrolled to read in gerrit0
[21:01:06] <thedj>	 ebernhardson: our setup guide for committers advises settings to do this
[21:01:46] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393
[21:01:56] <YuviPanda>	 ebernhardson: sorry, that was mine.
[21:02:18] <ebernhardson>	 YuviPanda: actually the one i'm looking at is another persons :)
[21:02:22] <YuviPanda>	 we were bringing that in from GitHub, sortof automatically happened. Won't happen again.
[21:02:24] <YuviPanda>	 oh? :D
[21:02:31] <ebernhardson>	 https://gerrit.wikimedia.org/r/#/c/68165/
[21:02:44] <YuviPanda>	 ah :D
[21:03:02] <YuviPanda>	 I'm going to add a pre-proecessing step to the GitHub -> Gerrit bot to have it wrap lines
[21:03:05] <ebernhardson>	 i'm reviewing it for other reasons, but was just double checking its legitimate to complain about the length of lines in commit messages before i actually complain :)
[21:03:19] <brion>	 our teletypes can't handle these long lines
[21:03:31] <ebernhardson>	 i hate horizontal scroll :P
[21:03:42] <YuviPanda>	 brion: apparently this is in the standard library http://docs.python.org/2/library/textwrap.html :0
[21:03:56] <YuviPanda>	 ebernhardson: ideally, the solution would live in Gerrit not pretending to be stuck in a teletype
[21:04:00] <brion>	 PHP's got that too! http://php.net/manual/en/function.wordwrap.php
[21:06:12] <MatmaRex>	 sublime has a lovely plugin that will do it right
[21:06:23] <MatmaRex>	 (e.g. handling bulleted lists, indented code snippets, etc)
[21:06:26] <ebernhardson>	 vim has done it right for 20 years :P
[21:06:35] <MatmaRex>	 yeah, and vim too
[21:06:48] <MatmaRex>	 but i haven't found the way t oget it to wrap pre-written text
[21:06:53] <MatmaRex>	 it only wraps it as you write
[21:07:18] <MatmaRex>	 (oh, and the plugin's in python, you could probably integrate it into whatever)
[21:07:21] <ebernhardson>	 select a block of text with visual select, and then 'gq'
[21:07:49] <ebernhardson>	 or if you just want the current paragraph, gq}
[21:07:49] <ebernhardson>	 :)
[21:08:29] <ebernhardson>	 (but yea, everything in vim is basically undiscoverable and the language to write these things in as, at best a horrible mess compared to something like python)
[21:08:31] <gerrit-wm>	 New review: TheDJ; "code style" [mediawiki/core] (master) C: -1;  - https://gerrit.wikimedia.org/r/63274
[21:09:03] <MatmaRex>	 also /* * * */ doc comments.
[21:09:38] <MatmaRex>	 https://github.com/ehuss/Sublime-Wrap-Plus
[21:09:56] <YuviPanda>	 ah, Jinja2 has a filter for wordwrap too
[21:09:59] <YuviPanda>	 should do for this
[21:10:09] <MatmaRex>	 see https://github.com/ehuss/Sublime-Wrap-Plus#lists and below
[21:10:12] <YuviPanda>	 hmm, no it'll clobber things
[21:10:37] <MatmaRex>	 it's just awesome when things are done so right you don't even notice them.
[21:11:00] <YuviPanda>	 https://github.com/ehuss/Sublime-Wrap-Plus/blob/master/wrap_plus.py nice
[21:11:05] <YuviPanda>	 tied up a bit into sublime specific things though
[21:11:11] <YuviPanda>	 not much but
[21:11:56] <MatmaRex>	 probably just things like figuring out the paragraph your cursor is in etc
[21:12:04] <MatmaRex>	 (but i've never read thecode)
[21:12:09] <gerrit-wm>	 New patchset: Foxtrott; "fix bug 48838 (Semantic Forms sfautoedit (and #autoedit) broken in 1.21)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68287
[21:12:15] <YuviPanda>	 MatmaRex: yeah, mostly
[21:12:20] <YuviPanda>	 should be simple-ish to pull out
[21:12:27] <gerrit-wm>	 New patchset: Kaldari; "Preventing FOUC on Special:Notifications page" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68288
[21:12:43] <YuviPanda>	 MatmaRex: there... is no License in the code though :(
[21:12:59] * YuviPanda  files issue

[21:13:25] <YuviPanda>	 https://github.com/ehuss/Sublime-Wrap-Plus/issues/21 done
[21:13:39] <MatmaRex>	 oh, that's uncool.
[21:14:14] <gerrit-wm>	 Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68287
[21:15:19] <gerrit-wm>	 New patchset: Foxtrott; "fix bug (autoedit does never finish on error)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289
[21:16:36] <gerrit-wm>	 New patchset: Foxtrott; "fix bug (autoedit does never finish on error)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/68289
[21:18:49] <gerrit-wm>	 New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572
[21:19:30] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68284
[21:20:23] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68288
[21:21:20] <YuviPanda>	 ^demon: ping? Does l10n bot have +2 on the new apps/android/commons repository?
[21:21:35] <^demon>	 Probably not.
[21:21:46] <YuviPanda>	 can you give it?
[21:22:01] <gerrit-wm>	 New patchset: SuchABot; "Upgrade Maven Android plugin to 3.6.0" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68290
[21:22:48] <^demon>	 YuviPanda: Doned.
[21:22:55] <YuviPanda>	 thanks
[21:24:13] <Nemo_bis>	 thanks
[21:28:22] <gerrit-wm>	 New review: GWicke; "In this version it seems to be possible to return a modified ParserOutput object that is then furthe..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983
[21:31:48] <gerrit-wm>	 New review: Yuvipanda; "Brion is eating a Burrito" [apps/android/commons] (master); V: 2 C: 2;  - https://gerrit.wikimedia.org/r/68290
[21:31:49] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68290
[21:38:14] <gerrit-wm>	 New patchset: Aaron Schulz; "support setting Memcached::OPT_SERVER_FAILURE_LIMIT, Memcached::OPT_RETRY_TIMEOUT" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68293
[21:40:29] <gerrit-wm>	 New patchset: SuchABot; "Clean out some excess logging" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68294
[21:41:28] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68294
[21:56:55] <gerrit-wm>	 New review: EBernhardson; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: 2;  - https://gerrit.wikimedia.org/r/68165
[21:57:16] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/68165
[21:58:15] <YuviPanda>	 qgil: just to note, we moved the Android app from GitHub to Gerrit, and are exclusively using the GitHub2Gerrit bot (SuchABot) to do Code Reviews / Merging. Should help stabilize the code + more bugfixes :)
[21:58:37] <qgil>	 this is great YuviPanda
[21:58:50] <qgil>	 Are you still busy with exams? How it went?
[21:58:57] <YuviPanda>	 qgil: they finished on Saturday :)
[21:59:11] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68205
[21:59:17] <YuviPanda>	 qgil: other than one case of $healthIssue, it went 'okay'
[21:59:25] <YuviPanda>	 qgil: i'm back developing now :)
[21:59:41] <qgil>	 YuviPanda, I can see that you are now taking at rest, working at somethingCrazy pm
[21:59:44] <YuviPanda>	 qgil: so it's primarily me and brion on this. We merged a couple of patches today with the workflow.
[21:59:48] <qgil>	 am
[21:59:56] <YuviPanda>	 qgil: indeed, 3:30 AM :)
[22:00:05] <YuviPanda>	 qgil: I've essentially given up trying to be productive before 10:00 PM :)
[22:00:50] <YuviPanda>	 next step - integrate with zuul :)
[22:01:01] <qgil>	 YuviPanda, I'm glad to see you nailed down the very complex GitHub / Gerrit problem
[22:01:26] <YuviPanda>	 qgil: :)
[22:01:39] <YuviPanda>	 qgil: switching to it exclusively for 'work' will help a lot, methinks
[22:01:49] <qgil>	 +1
[22:02:15] <YuviPanda>	 qgil: it also has proper logging, etc, and legoktm also contributed patches to it :)
[22:02:21] <legoktm>	 :)
[22:03:25] <YuviPanda>	 legoktm: we need to flask-ify the receiver.py thing
[22:04:00] <legoktm>	 mehhhhhhh
[22:04:02] <YuviPanda>	 legoktm: Y U NO LIKE FLASK
[22:04:28] <legoktm>	 Y U NO LIKE CGI
[22:04:39] * marktraceur  +qs the both of you

[22:04:48] <marktraceur>	 No framework wars
[22:05:00] <legoktm>	 I don't use a framework!
[22:05:01] <gerrit-wm>	 New patchset: Bsitu; "(bug 45020) Update watchlist preference for new users" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297
[22:05:54] <YuviPanda>	 marktraceur: CGI is not a framework!
[22:06:35] <marktraceur>	 No framework/lack thereof wars
[22:07:02] <YuviPanda>	 marktraceur: it isn't actually a war if we're talking about one particular tool both of us contribute to, is it?
[22:07:50] <qgil>	 that is a civil war
[22:09:41] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67833
[22:10:27] <gerrit-wm>	 New patchset: Parent5446; "Update watchlist preference for new users" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297
[22:19:42] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-linux-firefox build #340: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/340/
[22:20:17] <gerrit-wm>	 New review: Kaldari; "Seems reasonable to me in the absence of a better way to set defaults based on registration date." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/68297
[22:20:30] <gerrit-wm>	 New review: Parent5446; "So about the implementation of this. I think it'd be preferable to have this changed in DefaultSetti..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297
[22:21:12] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68293
[22:22:10] <gerrit-wm>	 New review: Parent5446; "Actually, considering the size of Wikipedia, what I mentioned might not be an option. Then again, co..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68297
[22:22:36] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68279
[22:28:13] <wmf-selenium-bot>	 Yippie, build fixed!
[22:28:13] <wmf-selenium-bot>	 Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #299: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/299/
[22:46:21] <gerrit-wm>	 New patchset: MaxSem; "Add section preview mode to API action=parse" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68302
[22:46:41] <superm401>	 Krinkle, can you look at GuidedTour QUnit again when you have a chance? https://bugzilla.wikimedia.org/show_bug.cgi?id=49032
[22:47:29] <gerrit-wm>	 New review: EBernhardson; "Some concerns regarding code duplication, but that already existed the patch itself looks good to me." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1;  - https://gerrit.wikimedia.org/r/67841
[22:48:59] <gerrit-wm>	 New patchset: Kaldari; "Everyone hates Christmas so we're getting rid of it in Thanks" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68303
[22:49:59] <gerrit-wm>	 New patchset: Kaldari; "Everyone hates Christmas so we're getting rid of it!" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/68303
[22:50:41] <gerrit-wm>	 New review: Swalling; "I hate Christmas." [mediawiki/extensions/Thanks] (master) C: 1;  - https://gerrit.wikimedia.org/r/68303
[22:55:27] <gerrit-wm>	 New review: EBernhardson; "Looks good to me, but i cant get any of my browsers to render it fuzzy in master so not sure how to ..." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1;  - https://gerrit.wikimedia.org/r/67970
[22:58:28] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/68157
[23:00:00] <gerrit-wm>	 New patchset: SuchABot; "Do not batch responses from image loader threads" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68305
[23:03:00] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68305
[23:16:32] <Ryan_Lane>	 Krinkle: you had pinged me the other day about the https stuff and my comments on MITMs
[23:17:12] <Ryan_Lane>	 Krinkle: there's been a number of past incidents, not necessarily with china, about intermediary CAs being given to organizations
[23:17:43] <Ryan_Lane>	 for instance: http://lwn.net/Articles/480279/
[23:19:08] <Ryan_Lane>	 Krinkle: most browsers trust CNNIC as a root level CA now. CNNIC is a branch of the government and is well known for doing non-https MITM attacks
[23:19:09] <Ryan_Lane>	 see: https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.security.policy/F7471-CzPow%5B1-25-false%5D
[23:20:16] <YuviPanda>	 Ryan_Lane: Has there been any talk of us doing Certificate Pinning?
[23:20:24] <YuviPanda>	 I'm guessing Chrome / FF will be happy to oblige
[23:20:24] <gerrit-wm>	 New patchset: Cmcmahon; "INCOMPLETE: use this code as a start for the training exercise June 27 before merging" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68283
[23:20:25] <Ryan_Lane>	 no, but we probably should
[23:20:37] <YuviPanda>	 we want to do that for the mobile apps too
[23:20:50] <Ryan_Lane>	 not all clients properly support it :(
[23:21:02] <Ryan_Lane>	 but having some support is better than none
[23:21:03] <YuviPanda>	 Ryan_Lane: would the CA cert be considered 'stable enough' to pin? From what I understand (From minimal cursory reading), that is what is needed
[23:21:42] <Ryan_Lane>	 well. maybe.
[23:21:56] <Ryan_Lane>	 it should
[23:22:12] <Ryan_Lane>	 it means we'll need to put some extra effort in whenever we want to change vendors
[23:22:13] <YuviPanda>	 so that is the thing I was worried about - if we pin it, and other people use those fingerprints, and then we have to change...
[23:22:18] <gerrit-wm>	 New patchset: Tim Starling; "Fixme comment for bug 49504" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68310
[23:22:19] <YuviPanda>	 ah
[23:23:13] <YuviPanda>	 Ryan_Lane: shall I start a wikitech-l thread later?
[23:23:15] <YuviPanda>	 (when I wake up)
[23:23:34] <Ryan_Lane>	 I definitely think we need to do the pinning at the CA and not the certificate lebel
[23:23:37] <Ryan_Lane>	 *level
[23:23:47] <Ryan_Lane>	 we have plans on serving different certs based on browser support
[23:24:07] <YuviPanda>	 right.
[23:24:08] <Ryan_Lane>	 (small certs for browsers that support SNI and the unified cert for browsers that do not)
[23:24:24] <Ryan_Lane>	 we may also want to consider changing vendors before we do this, too
[23:24:42] <Ryan_Lane>	 we'd like to reduce the number of certs in the chain if possible
[23:25:24] <YuviPanda>	 hmm, indeed.
[23:25:37] <YuviPanda>	 suppose it'll be a good thing to go through changes before we start telling people to pin it
[23:26:24] <Krinkle>	 Ryan_Lane: Thanks, digesting the info now
[23:26:31] <Ryan_Lane>	 yw
[23:26:38] <Ryan_Lane>	 YuviPanda: yep
[23:27:01] <Ryan_Lane>	 Krinkle: I'm not trying to pick on china specifically
[23:27:36] <Ryan_Lane>	 I believe Iran has already been seen doing this
[23:28:32] <Ryan_Lane>	 I wouldn't be surprised if many governments did this on a targeted scale
[23:31:33] <wmf-selenium-bot>	 Yippie, build fixed!
[23:31:33] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #86: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/86/
[23:32:12] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68310
[23:34:15] <gerrit-wm>	 New patchset: SuchABot; "Add subtle way to show people where uploads are going to" [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68315
[23:35:12] <wmf-selenium-bot>	 Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #96: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/96/
[23:35:38] <gerrit-wm>	 Change merged: Yuvipanda; [apps/android/commons] (master) - https://gerrit.wikimedia.org/r/68315
[23:38:27] <YuviPanda>	 nite everying. Ryan_Lane I'll put out a wikitech-l thread after waking up if necessary :)
[23:38:43] <Ryan_Lane>	 YuviPanda: cool :)
[23:41:49] <gerrit-wm>	 New review: Spage; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) C: 1;  - https://gerrit.wikimedia.org/r/65154
[23:44:17] <gerrit-wm>	 New patchset: Parent5446; "Prepare DatabaseMysql for mysqli" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130
[23:44:39] <gerrit-wm>	 New review: Parent5446; "Rebased to include the upsert() and getSoftwareLink() changes made in other patches." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130
[23:48:58] <gerrit-wm>	 New patchset: Parent5446; "Add support for mysqli extension" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62173
[23:49:04] <gerrit-wm>	 New patchset: Parent5446; "Allow selection of MySQLi database type during installation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62174
[23:52:05] <gerrit-wm>	 Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130
[23:59:01] <gerrit-wm>	 New review: Parent5446; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/68211