[00:00:02] hoo: https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuation [00:01:03] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [00:01:54] thanks, Hazard-SJ... I only looked into the PHP conventions :P [00:02:34] New patchset: Hoo man; "Only show notoken as possible API error once" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [00:03:09] New review: Hoo man; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [00:03:27] New review: Hoo man; "Wrapped long line (per Aude)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [00:03:47] New patchset: Hoo man; "Only show notoken as possible API error once" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [00:04:04] I shouldn't use gerrit to edit commit summaries [00:12:17] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [00:12:41] Change abandoned: Mattflaschen; "This was actually used for an urgent hotfix, but without actually merging to the branch." [mediawiki/extensions/GuidedTour] (forcontentHotfix) - https://gerrit.wikimedia.org/r/67231 [00:13:15] New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [00:16:00] Change merged: jenkins-bot; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/67599 [00:19:34] ori-l, oh, sorry, i have them hidden :) And yes, I saw that in the email [00:19:41] has it been +2ed? [00:20:04] btw, what was the command to run on vagrant after updating puppets? [00:21:44] New patchset: Tim Starling; "Drop __autoload." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66389 [00:22:28] New review: Kaldari; "(1 comment)" [mediawiki/extensions/FlaggedRevs] (master) C: 1; - https://gerrit.wikimedia.org/r/62193 [00:22:33] New review: CSteipp; "I'm mostly concerned about someone mistakenly using this to try and escape an attribute or value. Po..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67605 [00:22:38] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [00:24:26] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67570 [00:24:43] New review: Tim Starling; "Needs rationale, see https://bugzilla.wikimedia.org/show_bug.cgi?id=47529#c7" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60440 [00:25:29] I'm trying to update https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FAnnotator.git to include the latest changes from https://github.com/richajain/Prototyping-inline-comments/commits/master [00:25:38] This won't be an ongoing thing, since we're moving to Gerrit. [00:25:43] I just need to do one last resync. [00:25:53] I tried to give myself the Gerrit permissions to push into that repo, but it didn't work. [00:26:02] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66389 [00:27:09] New patchset: Aude; "Update Wikibase with fix for lua/geo data type" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67937 [00:32:08] * aude needs help with deploying https://gerrit.wikimedia.org/r/#/c/67937/ [00:32:14] greg-g: ^ [00:32:23] one last thing.... [00:33:25] aude: I see no change there :/ [00:33:40] Hazard-SJ: It's just a submodule update [00:33:49] what hoos ays [00:33:51] hoo says [00:34:22] * facepalm * [00:35:37] TimStarling: might you get the chance to peek at https://gerrit.wikimedia.org/r/#/c/64992/2 ? [00:38:11] Change abandoned: Demon; "Doing this in I9274fd89." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62339 [00:39:52] looks fine [00:40:00] New patchset: Tim Starling; "[Database] Tweaked LoadMonitor::getLagTimes() to further reduce stampedes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64992 [00:40:03] ok, who to poke? https://gerrit.wikimedia.org/r/#/c/67937/ [00:43:42] Yippie, build fixed! [00:43:42] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #73: FIXED in 5 min 59 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/73/ [00:44:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64992 [00:50:21] New patchset: Catrope; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67940 [00:51:33] New patchset: Catrope; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67941 [00:51:44] New review: Ori.livneh; "Code looks good; haven't tested." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/67147 [00:52:03] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/67937/ could you take care of that for us? [00:52:09] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67941 [00:52:14] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67940 [00:52:27] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67937 [00:52:30] aude: Sure [00:52:38] awesome! :) [00:52:40] \o/ [00:52:48] * aude owes you beer [00:52:50] aude: Do you have a wmf6 equivalent of that too? [00:53:02] it's only in the client extension [00:53:16] That doesn't answer my question [00:53:26] no, not yet [00:53:30] Is there a second commit that does the same update in wmf6? I just merged two commits, for instance [00:53:37] no [00:53:39] wikipedias aren't till thursday [00:53:41] OK [00:55:28] New patchset: Anomie; "Allow patrolling pages by revision id" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [00:55:46] New review: Anomie; "Hope you don't mind, I added a RELEASE-NOTES entry for you." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [00:57:13] thanks RoanKattouw [00:57:41] that fixed the issue [00:59:02] New review: Hoo man; "Of course I don't, thanks for that." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [00:59:11] New patchset: Aaron Schulz; "[Database] Tweaked LoadMonitor::getLagTimes() to further reduce stampedes" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67942 [01:01:00] New patchset: Krinkle; "Change how Vector's tabs behave on small resolutions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [01:01:28] New patchset: Krinkle; "CSSJanus: Fix handling of CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [01:02:14] New patchset: Krinkle; "mediawiki.api: Implement login method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [01:04:31] * AaronSchulz waits for jenkins to submit [01:04:57] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67942 [01:08:11] New patchset: Yaron Koren; "More fixes related to type (_str and Date)" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/67943 [01:09:55] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [01:10:30] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #299: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/299/ [01:10:47] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/67943 [01:13:08] New patchset: Spage; "Migrate ServerSideEventLogging from EventLogging" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944 [01:14:57] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Campaigns] (master) C: -1; - https://gerrit.wikimedia.org/r/67944 [01:20:06] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #319: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/319/ [01:22:07] New patchset: Hiong3-eng5; "API: modified SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [01:25:28] New review: Parent5446; "Quick questions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [01:29:12] Yippie, build fixed! [01:29:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #112: FIXED in 9 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/112/ [01:29:51] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67876 [02:04:04] New patchset: Parent5446; "Add special page for listing throttle overrides" [mediawiki/extensions/ThrottleOverride] (master) - https://gerrit.wikimedia.org/r/67627 [02:40:04] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [02:40:40] New review: Parent5446; "OK, looked at PS5. All is good." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65868 [03:01:53] New review: Mattflaschen; "Okay, I'm fine with setting them to none." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [03:17:08] New patchset: Parent5446; "Add referer and origin check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [03:19:08] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/37606 [03:29:42] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [03:31:24] New review: Mattflaschen; "I understand why you're using the referrer, but you should expect that it will be stripped or forged..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [03:34:35] New review: MZMcBride; "Bug 12945?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [03:46:42] New review: Mattflaschen; "The overlay talk page links look and work correctly, and the code is fine." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64823 [03:47:29] New review: Mattflaschen; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [03:49:37] New review: Mattflaschen; "Trying to make Jenkins do its job" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61075 [03:50:22] New patchset: Parent5446; "Add referer and origin check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [03:53:10] New review: Mattflaschen; "Looks good, and edit links work locally." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61072 [03:55:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [03:55:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61072 [04:17:37] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [04:25:11] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [04:26:45] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [04:42:53] New review: Santhosh; "IIRC, the full screen mode is supposed to come just after the message filters starts floating on the..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [04:55:01] New patchset: Santhosh; "Cleanup" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67949 [04:59:51] New review: Mattflaschen; "Looks very good overall. I cross-checked the message changes, and it looks right." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67233 [05:01:50] New patchset: Santhosh; "Update version" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67950 [05:49:27] New patchset: Eloquence; "Add link to MariaDB to MySQL's software link." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [05:52:25] New patchset: Eloquence; "Add link to MariaDB to MySQL's software link." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [05:53:47] New patchset: Eloquence; "Add link to MariaDB to MySQL's software link." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:07:08] New patchset: Spage; "(bug 42253) link user in accountcreatedtext msg" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37606 [06:08:32] New review: Spage; "Rebased and MessagesQqq messages adjusted." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37606 [06:12:29] New patchset: Mattflaschen; "(bug 42253) link user in accountcreatedtext msg" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37606 [06:13:19] New patchset: Spage; "Migrate ServerSideAccountCreation from EventLogging" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944 [06:18:23] New review: MZMcBride; "Mentioning patch set-specific changes in commit messages maximally angers the Krinkle deities. ;-)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:19:44] New patchset: Eloquence; "Add link to MariaDB to MySQL's software link." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:20:05] New review: Eloquence; "I'll take your word for it - removed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:23:35] New review: MZMcBride; "Overall, this solution (using "MariaDB / MySQL") feels kind of clunky to me. If MariaDB is a drop-in..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:24:18] New review: Spage; "Good points. Merging mediawiki.special.userLogin.signup.js into ...createAccount.js is a bit of work." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [06:42:02] New patchset: Nischayn22; "Added support for Captcha" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/66382 [06:45:08] New review: Eloquence; "Yeah, I agree it's a bit clunky. I didn't want to outright replace it since MySQL still has a fair b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:48:52] New review: Parent5446; "Unfortunately, the only way I see this working without being clunky is to actually make a new MariaD..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:49:10] New review: Siebrand; "I guess we should just go ahead with this. Needs manual rebase." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/35871 [06:50:43] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/53491 [06:52:38] Reedy: why did you change wikidatawiki just to wikidata? [06:54:04] Nikerabbit: seems to be to apply to testwikidatawiki [06:54:20] New review: Asher; "You could always parse the output of select version();" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67951 [06:58:48] New patchset: Siebrand; "Remove unnecessary exception from Title::getLatestRevID()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67235 [06:59:08] New review: Siebrand; "Comment by Wizardist addressed in PS2." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67235 [07:00:33] New patchset: Siebrand; "Mouseover explanations for interlanguage links in native language" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/35871 [07:01:57] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [07:02:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67235 [07:03:40] New patchset: Spage; "Only new vertical format login and signup forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [07:03:58] New review: Mattflaschen; "This is related to bug 40040. I think it's a step forward, but there's still room for improvement (..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [07:06:50] siebrand: if you have some time, could you review the comments at https://gerrit.wikimedia.org/r/#/c/66372/ ? [07:07:44] legoktm: I'd like to see input from another core +2 developer there. [07:08:05] ok about what specifically? [07:08:22] legoktm: about your and max's assesment. [07:09:43] siebrand: https://en.wikipedia.org/wiki/Special:ListGroupRights and https://www.mediawiki.org/wiki/Manual:User_rights, ctrl+f for "nominornewtalk" [07:10:34] siebrand: that's not documented anywhere [07:11:05] unless Echo broke it, it's tested and proven to be liked that [07:11:18] Nemo_bis: Echo did break it, so they fixed echo ;) [07:11:32] legoktm: irrecoverably broke it, then [07:11:44] huh? [07:11:56] it still works fine with echo [07:12:03] maybe i just phrased my comment wrong [07:12:48] New review: Tpt; "Some minor details." [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/67632 [07:14:43] New review: Nikerabbit; "I copied the logic from the prototype: http://pauginer.github.io/prototype-translate/pencil/compact-..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [07:15:10] legoktm: what was the echo bug number? [07:15:49] umm, let me search [07:16:35] Nemo_bis: https://bugzilla.wikimedia.org/show_bug.cgi?id=47910 [07:16:56] New patchset: Spage; "Only new vertical format login and signup forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [07:17:25] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [07:17:28] New review: Spage; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [07:17:39] New review: Kipcool; "A few comments on a few details ;)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [07:20:47] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [07:22:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/37606 [07:26:24] HAH! Google is taking interesting participation into the whole update gig. [07:48:17] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67949 [07:48:36] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67950 [07:59:34] Change merged: jenkins-bot; [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [08:14:00] ohai hashar [08:14:02] YuviPanda: :) [08:14:10] what bug did you want to report? [08:14:12] YuviPanda: so on my Android, I got the commons android application [08:14:25] I took a nice pictures of some bees and wanted to upload it [08:14:38] the upload eventually got aborted due to lack of internet connectivity [08:14:55] it is now showing as 'Queued' [08:15:13] New review: Tpt; "(1 comment)" [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/67632 [08:15:30] hashar: there's a bug for it already, let me look [08:15:57] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=46606 [08:15:58] I am not sure which version of commons I have. It seems to be 1.0 [08:16:02] let me add it to this week's iteration [08:16:56] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [08:17:02] apparently I got v1.0 from f-droid [08:17:14] and f-droid propose me to update to 1.0beta8 [08:17:50] hashar: that... is weird [08:18:04] hashar: I *think* 1.0beta8 is probably more 'recent' [08:18:06] but maybe I have another version hehe [08:18:14] yeah let me lookup the sha1 [08:18:14] hashar: might just have been a snafu on fdroid's part? [08:18:18] in the initial thing? [08:18:19] idk [08:18:31] not sure if a sha1 would help, since fdroid builds it themselves... [08:18:44] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [08:18:52] they have a metadata file listing the upstream sha1 / tag [08:19:26] ah [08:19:28] ok [08:19:40] also the macbook air is woefully underpowered to do much java work :( [08:19:46] ahhh [08:19:54] or maybe I have downloaded another random issue [08:19:58] another random version [08:20:00] let me update :D [08:20:02] hehe [08:20:03] ok [08:20:11] but I doubt that issue will go away (most probably) [08:20:31] yeah [08:20:37] so f-droid detects the upgraded [08:20:40] the upgrade [08:20:48] and warns me about the signing key being different [08:21:10] and says its is going to delete the application data :( [08:21:15] ow [08:21:32] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [08:21:35] hashar: so... you need a new release with the f-droid signing key? [08:22:46] hmm [08:22:54] and i have no idea where the files are being sent haha [08:23:36] hashar: okay, 1.0beta8 was the last 'released' version [08:24:56] installing it [08:25:02] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [08:29:11] YuviPanda: yup and it got a beta icon [08:29:25] YuviPanda: do you know which backend it is using? My production commons account does not work :( [08:29:45] hashar: it is meant to upload to commons... [08:30:03] hashar: at least that is what we tried to setup on the fdroid build process - I never actually verified they set it up correctly [08:30:09] hashar: if not to commons, it'll go to testwiki [08:31:03] yeah does not let me log in :-D [08:31:55] hashar: :( [08:32:03] hashar: do you have an account that exists on testwiki? [08:32:12] ahhh [08:32:12] https://test.wikipedia.org/wiki/Special:Contributions/Hashar [08:32:13] :-D [08:32:30] hashar: if it came from jenkins then it is *definitely* going to testwiki [08:32:32] not commons [08:32:43] yeah that confirms it [08:32:54] the new beta8 from f-droid, I have no idea where it tries to connect though [08:33:10] I'm going to guess that it is trying to connect to commons [08:33:15] provided they didn't mess it up [08:33:39] hashar: there is a signed beta8 apk at http://dumps.wikimedia.org/android/ [08:33:47] hashar: beta8 is also on the play store [08:34:19] I want to avoid the play store :-D [08:34:24] I will figure it out [08:34:32] probably will have to sniff the traffic [08:34:33] hashar: yeah, realized - that's why I gave you the link to our own signed apks :) [08:34:37] and tail the production logs [08:34:39] hashar: it's all https... [08:34:43] ahh [08:34:44] ah, production logs :) [08:34:52] but it is not checking the certificate isn't it ? [08:35:06] it should - if your cert is invalid it should error out [08:35:20] oh [08:35:33] by error out i mean 'throw up a huge dialog box telling you something is wrong and do you want to email the wmf about it?' [08:35:49] in the future we should actually implement certificate pinning [08:36:05] hashar: but production logs? sure! :) [08:36:21] hashar: in the mean time I'm implementing a feature that should tell you where you're uploading to in the about page [08:36:54] that could be shown on the login page as well [08:37:21] yeah, there too - agreed [08:37:53] https://trello.com/c/IlD8oY55 added to this week's iteration [08:40:38] nothing shown in the api.log :( [08:41:46] will investigate another day :D [08:45:58] New review: Wikinaut; "I suggest renaming from Html:escape to Html::escapeContent ." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [08:59:53] hashar: :) :( [10:05:31] New review: Daniel Friesen; "Htnl::escapeContent is starting to get pretty verbose. This is supposed to be a simple method for ne..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [10:06:56] New review: Parent5446; "Or we can just use htmlspecialchars() and avoid the extra function call and possible misuse." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [10:15:51] New review: Nikerabbit; "Do these need corresponding action- messages as well?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [10:17:44] New patchset: Nikerabbit; "Hide sidebar while using the translation tool" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [10:28:29] New patchset: Raimond Spekking; "Add i18n files" [mediawiki/extensions/Sarcasm] (master) - https://gerrit.wikimedia.org/r/67963 [10:28:39] New review: Daniel Friesen; "The exact function call's performance difference is negligible. And htmlspecialchars' defaults aren'..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [10:57:27] New patchset: Pastakhov; "Add PCRE Functions (version 0.4.3)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67965 [11:19:30] New review: Hiong3-eng5; "I will send a patch with some more bug fix that I found myself." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [12:14:13] New patchset: Matthias Mullie; "(bug 49285) ArticleFeedbackv5: Text is blurry due to use of CSS3 filter" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67970 [12:18:30] New patchset: Nikerabbit; "Hide sidebar while using the translation tool" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [12:23:59] New review: Brian Wolff; "What people should do and what people actually do are two very different things" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [12:54:03] New patchset: Matthias Mullie; "(bug 49285) ArticleFeedbackv5: Text is blurry due to use of CSS3 filter" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67970 [13:01:59] New review: Nischayn22; "This caused the following bug" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/51326 [13:06:08] gnah [13:24:09] New patchset: Hoo man; "Don't try to filter uploads with an invalid title" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67974 [13:36:06] New review: Anomie; "> Wrapped long line (per Aude)" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67625 [13:37:50] anomie: :D I guess I'm working to much with her and just read the leading "A"... [13:38:23] hoo: No problem. It was just the second time you did that so I though't I'd mention it ;) [13:38:34] or, really [13:38:41] * oh [13:38:50] heh [13:39:07] So it was you who reviewed my API patch? :P [13:39:50] * anomie reviews pretty much all the core API patches [13:40:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [13:41:00] This awkward... probably I've read through my emails and then saw some CR from aude so that I didn't really read the names on gerrit after :P [13:41:04] * This is [13:41:08] weir [13:41:15] d [13:48:27] Reedy: why did you change wikidatawiki just to wikidata? [13:48:35] So I didn't have to duplicate all the lines of config [13:48:52] It then applies to the wikidata group of wikis [13:48:54] a la https://noc.wikimedia.org/conf/highlight.php?file=wikidata.dblist [13:49:03] big happy wiki family :) [13:49:21] The config of testwikidatawiki and wikidatawiki shouldn't be too different [13:49:42] yep [13:50:45] Reedy: check [13:51:50] If you need to split them out for some cases, feel free [13:54:23] hashar: hey! I have two test cases that are not getting picked up by phpunit.php: [13:54:39] TextContentTest and JavaScriptContentTest. [13:54:56] The related CssContentTest and WikitextContentTest classes work fine. [13:54:59] any idea why that is? [13:55:16] if i run TextContentTest and JavaScriptContentTest by giving the file path, they run. [13:55:36] but they don't seem to be loaded as part of the ContentHandler group, nor when all tests should be run [13:56:08] (https://gerrit.wikimedia.org/r/#/c/28199/11 should never have been merged, it fails TextContentTest with a fatal error) [13:56:21] Reedy: or do you have an idea? [13:57:27] oh wow, i think i just found a massive bug. [13:57:37] ...in phpunit [14:02:43] DanielK_WMDE: similar issue we had before? [14:02:50] with the entity data stuff [14:04:33] aude: yes. i thought i found out why. but i can't reproduce with a simple test case. [14:04:49] aude: seems to be some odd interaction between inheritance and autoloading [14:04:50] strange [14:05:11] ugh [14:05:27] i don't think i actually figured out why [14:05:32] i just found way to make it work [14:06:07] hmhm. [14:06:13] i'll file a bug describing the issue [14:16:05] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [14:19:12] New patchset: Daniel Kinzler; "Introducing ContentGetParserOutput hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983 [14:19:48] New patchset: Daniel Kinzler; "Introducing ContentGetParserOutput hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67983 [14:21:18] New review: Daniel Kinzler; "You could have just renamed getHighlightHtml() to getHtml() in the extension, that would have fixed ..." [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67863 [14:21:40] New review: Daniel Kinzler; "Fixed version: I979e2438" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [14:26:35] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/67446 [14:33:19] New review: Anomie; "Hmm. Yes, it looks like action- messages might be appropriate here." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:35:09] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:36:45] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:36:45] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [14:37:08] New review: Anomie; "PS3: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [14:38:11] DanielK_WMDE: sorry was not paying attention [14:41:05] New patchset: Mwjames; "(Bug 48840) Create "smw-admin" rigth + "smwadministrator" group" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [14:41:26] New patchset: Mwjames; "(Bug 48840) Create "smw-admin" right + "smwadministrator" group" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [14:42:02] New patchset: Yaron Koren; "New version: 1.2.5" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/67989 [14:42:13] hashar: no rush, but look at the bug i filed. it's scary. [14:43:26] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [14:45:12] DanielK_WMDE: antoine.musso@laposte.fr that email bounce nowadays :-] [14:45:38] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [14:45:57] New review: Brian Wolff; "PS6: Whoops, not sure what I was doing, but I forgot to test my changes to the PNG handler." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [14:46:08] DanielK_WMDE: the bug is under my radar, will look it up this week hopefully. [14:50:16] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/67989 [14:51:58] New patchset: J; "Fix reset of timedout jobs" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67991 [14:52:32] New patchset: Aude; "Update DataValues and Wikibase with improvements to geo data type" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67992 [14:53:49] New patchset: Brian Wolff; "(DO NOT MERGE; needs I49b7d8a05) Add a lua interface for getting file metadata" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [14:54:23] New patchset: Aude; "Update Wikibase with patch for change notification jobs" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67993 [14:54:28] New patchset: Reedy; "Fixup mixed leading whitespace" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67451 [14:55:42] New patchset: Reedy; "Fixup mixed leading whitespace" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67451 [14:58:39] New review: Brian Wolff; "Thanks for the review." [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [14:58:50] New patchset: Njw; "Use em for all units except image specific, and a few style tweaks" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67994 [15:08:05] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67993 [15:08:17] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67992 [15:09:54] New patchset: Mwjames; "(Bug 48840) Create "smw-admin" right + "smwadministrator" group" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [15:15:07] New patchset: Njw; "Use em for all units except image specific, and a few style tweaks" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67994 [15:15:21] New patchset: Mdale; "More accurate timming for captions, progress event fixes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67998 [15:26:08] New review: Umherirrender; "I am prefer 'editusercss-own' or 'editownusercss', mediawiki has already a 'reupload-own' user right..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67874 [15:26:36] New patchset: Euvl; "added .idea to gitignore" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/68000 [15:30:12] New review: Yury Katkov; "accept. Many people use phpstorm" [mediawiki/extensions/Lingo] (master) C: 1; - https://gerrit.wikimedia.org/r/68000 [15:30:41] New review: Anomie; "Giving it to '*' allows checks for User::groupHasPermission( '*', $right ) to skip expensive checks ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67874 [15:42:42] New patchset: Njw; "Use em for all units except image specific, and a few style tweaks" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67994 [15:50:24] Change abandoned: Njw; "Actually I'm going to rework this before it sees review." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67994 [15:54:42] New patchset: Matthias Mullie; "Small cosmetic improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67833 [15:59:28] Change merged: CSteipp; [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/67286 [16:02:46] AaronSchulz: good morning! [16:03:02] it seems that the Parsoid jobs are not getting run yet [16:04:08] New patchset: CSteipp; "WIP commit of some basic classes for /initial call" [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/68001 [16:11:30] ^demon, thanks for importing Annotator. [16:11:41] <^demon> yw [16:11:45] Can you do one last import of the GitHub commits? [16:12:07] I've asked her not to stop committing to GitHub, but there's one last batch, and I don't seem to have permission to push it. [16:13:42] Yippie, build fixed! [16:13:43] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #77: FIXED in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/77/ [16:16:09] ^ ^demon. And also, I have a new extension repo request at https://www.mediawiki.org/wiki/Git/New_repositories/Requests, CoreEvents [16:17:37] New review: CSteipp; "Thanks!" [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/67974 [16:17:43] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67974 [16:21:41] New patchset: Brian Wolff; "(DO NOT MERGE; needs I49b7d8a05) Add a lua interface for getting file metadata" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [16:21:43] New patchset: Mwjames; "SMW\NamespaceExaminer class (deprecates smwfIsSemanticsProcessed())" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65008 [16:22:05] <^demon> superm401: Any other groups/people you want to own it, or just Matt? [16:22:51] ^demon, can you add Ori, S Page, and Benny Situ? [16:23:23] <^demon> Ok, you're all set. [16:25:09] ^demon, thanks. Did you see my comments above about syncing Annotator to Gerrit one last time? [16:28:32] Change merged: Foxtrott; [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/68000 [16:30:03] New review: Mwjames; "I already found a culprit where onInternalParseBeforeLinks calls ParserTextProcessor on Specialpages..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/65008 [16:31:25] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65008 [16:31:26] <^demon> superm401: Done. Had to tweak some acl's. [16:31:40] ^demon, thanks again. [16:31:45] <^demon> yw [16:37:17] Yippie, build fixed! [16:37:18] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #119: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/119/ [16:38:26] New patchset: Eranroz; "Hebrew translation for namespaces" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/68003 [16:42:58] New patchset: Nikerabbit; "Avoid exceptions by first checking language code validity" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68004 [16:43:28] New patchset: MarkTraceur; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [17:01:32] New review: CSteipp; "For security, please comment the escaping requirements of the new parameters in the javascript." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67173 [17:02:22] New patchset: Mwjames; "Don't run the ParserTextProcessor on SpecialPages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/68008 [17:06:48] New review: MarkTraceur; "Reviewing i18n bits" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [17:14:49] Yippie, build fixed! [17:14:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #320: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/320/ [17:25:59] * bawolff is wondering, if he x's the page curation toolbar, how do I un-x it? [17:28:53] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [17:32:14] * bawolff figured it out, its in the toolbox [17:33:13] New patchset: Andrew Bogott; "Make pep8 tests voting in operations/software" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/68012 [17:38:02] New review: Siebrand; "Need a test case, right?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68004 [17:38:13] Yippie, build fixed! [17:38:13] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #300: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/300/ [17:42:59] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/66382 [17:44:01] New review: Siebrand; "Thank you" [mediawiki/extensions/EducationProgram] (master) C: 2; - https://gerrit.wikimedia.org/r/68003 [17:44:15] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/68003 [17:45:10] New review: Kghbln; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [17:46:59] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [17:51:22] New review: Matthias Mullie; "I'd say $wgThanksConfirmationRequired = true; is quite a sane default!" [mediawiki/extensions/Thanks] (master) C: 2; - https://gerrit.wikimedia.org/r/67591 [17:51:31] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [17:53:01] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [17:53:51] New patchset: Kipcool; "Special Datasearch * added prev / next buttons * disable external id search for now * rewrote a few queries according to code conventions * simplified variable names" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68018 [17:54:14] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68018 [17:55:38] New patchset: Hiong3-eng5; "API: modified SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [18:05:23] New patchset: Hiong3-eng5; "API: modified SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [18:08:10] New patchset: Njw; "Use em for all text units, and a few style tweaks" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/68019 [18:10:23] New review: Hiong3-eng5; "(1 comment)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [18:15:47] New patchset: Aaron Schulz; "(bug 44978) loop over authors instead of setting same url" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66396 [18:16:10] New patchset: Bsitu; "Add new hook AbortTalkPageEmailNotification" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68020 [18:20:38] New patchset: Bsitu; "Update Echo, Thanks to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68021 [18:22:52] New patchset: Kaldari; "Add new hook AbortTalkPageEmailNotification" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68022 [18:23:37] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66396 [18:24:09] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68020 [18:24:27] Change merged: Bsitu; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68021 [18:25:41] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67946 [18:32:28] New patchset: Aaron Schulz; "Fix reset of timed out jobs" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67991 [18:33:05] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/67991 [18:44:16] New review: Aaron Schulz; "WIP" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/61745 [18:55:59] New patchset: Cmcmahon; "do not run ULS test on IE6/IE7" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68024 [18:56:06] New patchset: Hiong3-eng5; "API:Define add ability to include syntrans" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68025 [18:58:51] New review: Cmcmahon; "don't run ULS tests for IE6/IE7 per Nikerabbit" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/68024 [18:58:51] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/68024 [19:00:09] New review: Hiong3-eng5; "Kindly check for merging.Thanks" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/68025 [19:04:52] New patchset: Kaldari; "Setting tooltip gravity to 's' so that the tooltip shows above" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68027 [19:04:58] New patchset: Cmcmahon; "IN PROCESS: test for uls cog behavior for anonymous users, please review" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67873 [19:07:42] New patchset: Kaldari; "Setting tooltip gravity to 's' so that the tooltip shows above" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68027 [19:11:50] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68022 [19:17:02] New patchset: J; "Tune Special:TimedMediaHandler" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/68029 [19:24:22] New patchset: Nemo bis; "In 'uctop', replace 'top' with 'current' [revision]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [19:33:31] Nemo_bis: wow, that's been there since may [19:33:46] * Nemo_bis ndos [19:33:51] nods even [19:35:11] Well, lets do something about that [19:35:19] :) [19:35:21] New review: Brian Wolff; "Much more clear imo. I also strongly think we should make an effort to bring wikipedia tweaks to mes..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/58049 [19:36:02] bawolff: it was actually April btw [19:36:04] New review: Brian Wolff; "that got cut off. Was going to end with "they have had plenty of opportunity"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [19:37:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [19:38:52] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68036 [19:59:05] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68036 [19:59:39] New patchset: Spage; "Get Asirra captcha working on more forms" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60366 [20:03:51] New patchset: Kaldari; "Don't run mw.echo.special.initialize until DOM is ready" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [20:11:33] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #113: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/113/ [20:11:42] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #95: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/95/ [20:28:04] New patchset: Dzahn; "Bugzilla frontpage: make common tasks easier accessible" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [20:29:01] New review: CSteipp; "If what Roan says is true (and a little testing that I did looks like is the case), then it should b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [20:29:02] Change merged: Aklapper; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [20:32:22] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68047 [20:32:35] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68047 [20:33:36] Yippie, build fixed! [20:33:37] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #93: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/93/ [20:46:47] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [20:47:24] New patchset: Jeroen De Dauw; "(Bug 48840) Create "smw-admin" right + "smwadministrator" group" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [20:49:25] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68049 [20:49:45] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/68049 [20:50:15] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67988 [20:53:25] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #78: FAILURE in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/78/ [20:59:34] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68108 [20:59:52] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/68108 [21:08:52] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/68040 [21:18:50] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [21:20:31] New patchset: Kaldari; "Don't run mw.echo.special.initialize until DOM is ready" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [21:24:44] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/68040 [21:32:35] New review: Mattflaschen; "Looks good at Special:Preferences in the notifications section." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/68027 [21:34:56] New review: Bsitu; "Need to be rebased" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [21:35:08] New review: Wikinaut; "Parent, hi, I kindly ask you to code review this, too. It's fine and has been discussed with others...." [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [21:35:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68027 [21:35:58] New review: Ryan Lane; "(1 comment)" [mediawiki/extensions/LdapAuthentication] (master) C: -1; - https://gerrit.wikimedia.org/r/65865 [21:37:12] New patchset: Ryan Lane; "Prevent searching for AD groups for non AD LDAP" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/65865 [21:40:39] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/65865 [21:41:57] Published patchset: Wikinaut; "added newline character after the delete message." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [21:44:39] New patchset: Wikinaut; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [21:46:24] Change merged: Ryan Lane; [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/66195 [21:46:31] New review: Ryan Lane; "Thanks for the patch!" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/66195 [21:49:24] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [21:51:55] New review: Spage; "This worked for me locally with Schema: namespace and a sample CONTENT_MODEL_TEXT namespace. I didn'..." [mediawiki/core] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/67983 [22:00:36] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [22:07:04] csteipp: https://gerrit.wikimedia.org/r/67043 that should really be part of the next deployment cycle [22:07:06] Good night ;) [22:10:03] New patchset: Aaron Schulz; "Removed redundant documentation for some methods." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68113 [22:10:50] New review: CSteipp; "This fixes the issue, and hasn't caused any issues in limited testing. I'll merge tomorrow unless an..." [mediawiki/extensions/AbuseFilter] (master) C: 1; - https://gerrit.wikimedia.org/r/67043 [22:11:16] greg-g: isn't "that should really be part of the next deployment cycle [22:11:22] something for you usually [22:12:11] Nemo_bis: sure [22:13:19] but I'm not going to recommend a change with this in the commit message "(Only slightly tested)" to go out soon :) [22:13:38] Nemo_bis: I think hoo was just ping chris since chris reviewed it [22:14:55] ok :) [22:15:02] never judge the book from the cover [22:31:26] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [22:32:14] James_F: "NSA PRISM deepthroat VANISHES as pole-dance lover cries into keyboard" ... oh theregister.co.uk [22:32:39] Aaron|home: I try not to give them the oxygen of publicity. ;-) [22:33:43] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [22:35:03] New review: Spage; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/65171 [22:38:48] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [22:39:45] Yippie, build fixed! [22:39:45] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #114: FIXED in 9 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/114/ [22:43:06] New review: Ori.livneh; "Logging needs to happen in JS, per discussion." [mediawiki/extensions/Campaigns] (master) C: -1; - https://gerrit.wikimedia.org/r/67587 [22:48:41] New patchset: Tim Starling; "Fix return type of MessageCache::getMsgFromNamespace for existing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64277 [22:49:35] New review: Tim Starling; "PS3: rebase, and fix spelling error existant -> existent" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64277 [22:49:47] New review: MarkTraceur; "Don't let me discourage you, you're doing well, I just have a lot of opinions." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [22:50:12] Yippie, build fixed! [22:50:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #96: FIXED in 9 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/96/ [22:50:14] New patchset: Mattflaschen; "Move AddNewAccount out. It is intended for Extension:Campaigns." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68118 [22:51:55] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [22:52:35] New patchset: Mattflaschen; "Move PageContentSaveComplete out; intended to be in CoreEvents" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68119 [22:52:49] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64277 [22:53:53] New patchset: Zaran; "(bug 49453) Fix sql table creation failure" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/68120 [22:54:05] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68118 [22:56:44] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/68119 [22:57:08] New review: Mattflaschen; "Is there a reason you're not using a separate hooks file? I'm not really against this; it's just a ..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944 [23:02:39] New review: Parent5446; "Haven't tested, but code looks good to me." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [23:06:49] New review: Ori.livneh; "You based this patch on Ife949daf5, but we agreed there that the approach was faulty. Let's fix that..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944 [23:08:08] superm401: If you can't fit it all in one file then you're doing it wrong [23:09:42] Reedy, is that the Title.php philosophy? ;) [23:10:48] Long live WikiPage [23:11:11] New review: Ori.livneh; "> Is there a reason you're not using a separate hooks file? I'm not really against this; it's just a..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67944 [23:16:02] New patchset: Tim Starling; "Remove all instances of the word "iff"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/68121 [23:18:57] apparently it only dates back to 1955 [23:20:49] so if Newton was able to invent calculus without it, I figure it can't be very essential [23:21:19] New review: Parent5446; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [23:22:33] iff you say so [23:29:48] is it verbotten to append interface names with 'Interface' ? [23:30:14] one or two have used an "I" prefix [23:30:26] I just named mine like classes [23:32:23] hmm, but then i need better names :P best to stay consistent with what already exists though [23:35:15] New patchset: Tim Starling; "(bug 47449) {{#special:}} should always return a usable title" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60105 [23:35:54] Suprisingly, so does DataValues [23:46:22] New review: Brian Wolff; "I agree this makes sense. +1." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62337 [23:48:06] New review: Tim Starling; "Breaks parser tests." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60105