[00:01:02] Change merged: Hoo man; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67630 [00:10:02] hoo: Jenkins has not been down for months. [00:10:04] hoo: Zuul is also up. [00:10:06] hoo: Gerrit is closing the notifications socket to Zuul, so Zuul gets no notifications and thus it won't create jobs in Jenkins [00:10:24] :/ [00:10:39] Any ETA to when it will be fixed? [00:11:46] gerrit has been doing this for 7 days now. Every day it randomly quits the socket and won't reopen it [00:11:49] See the logs https://wikitech.wikimedia.org/wiki/Server_admin_log [00:12:27] !log Gerrit has once again closed the Zuul socket, ssh event stream down [00:12:57] ETA is "whenever someone in ops can restart Gerrit" [00:13:42] "Have you tried restarting?" [00:15:30] New review: Krinkle; "Fair warning: Don't override Verified, Don't manually merge – unless it is really friggin' import..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67630 [00:15:42] Gerrit is root-only, I can't restart it. [00:15:59] Restarting it will fix it, but it will only work for a few hours until Gerrit will close the door again on Zuul. [00:16:11] Something broke last week in gerrit and nobody knows what. [00:25:44] "Have you tried restarting?" is a meme. [00:31:00] Elsie: Hm.. maybe I know it under a different name? That phrase doesn't ring any bells [00:31:06] I know "on/off again" though – http://www.youtube.com/watch?v=p85xwZ_OLX0 :D [00:31:58] It's the same meme. [00:32:08] k :) [00:32:14] Ain't nobody got time for that :P [00:32:50] :P [00:34:18] hoo: I noticed that you always do "Verified+2 Code-Review+2" when approving changes. not just when jenkins-bot is unavailable but always. [00:34:22] Can you please not? [00:34:34] Only CR+2?! [00:35:03] I don't know where you got that from, but it is not what our workflow prescribes. We do CR+2, the bot gets notified and runs the tests, and then it merges. [00:35:33] If you manually set Verified+2, it will override the bot. Thus masking any errors jenkins reports. [00:36:01] The field isn't even supposed to be exposed to human accounts, on many repositories it has already been disabled for non-bot accounts. [00:36:13] We still have it on core for legacy reasons but please don't use it :) [00:39:28] Ok, good to know [02:16:04] New patchset: Parent5446; "Add special page for listing throttle overrides" [mediawiki/extensions/ThrottleOverride] (master) - https://gerrit.wikimedia.org/r/67627 [02:45:12] Change abandoned: Ori.livneh; "(no reason)" [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/66315 [02:59:34] New patchset: Krinkle; "mw.toolbar: Clean up code and jsduckify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [03:21:57] New review: Ori.livneh; "Looks good. A couple of really minor points about the comments inline." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67647 [03:26:46] New review: Ori.livneh; "Bypassing Jenkins, since it does not test or lint CSS, anyway." [mediawiki/core] (master); V: 2 - https://gerrit.wikimedia.org/r/67168 [03:26:48] Change merged: Ori.livneh; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67168 [03:47:06] New patchset: Krinkle; "mw.toolbar: Clean up code and jsduckify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [03:55:44] New patchset: Krinkle; "jquery.makeCollapsible: cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [03:56:06] New patchset: Krinkle; "Link to mediawiki.org page in 'edithelppage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [03:56:27] New patchset: Krinkle; "Properly center arrowheads text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64556 [04:04:51] New review: Ori.livneh; "Tested and verified. This is nice, straightforward change. I'm terribly sorry it took so long for it..." [mediawiki/extensions/PagedTiffHandler] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/37654 [04:04:52] Change merged: Ori.livneh; [mediawiki/extensions/PagedTiffHandler] (master) - https://gerrit.wikimedia.org/r/37654 [04:40:44] New patchset: Krinkle; "mediawiki.js: Clean up and improve documentation coverage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67648 [04:42:32] New patchset: Krinkle; "mw.toolbar: Clean up code and jsduckify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [05:04:02] New patchset: PleaseStand; "MysqlInstaller: use default character set of utf8" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67422 [05:15:50] I wonder if we should add a MEDIAWIKI_NOGLOBALS constant (false by default). [05:16:26] ie: So that when set to true wgRequest, wgTitle, wgUser, etc... disappear and compatibility for code without them can be tested. [05:58:43] DanielFriesen: they're declared in global scope. $wgRequest is $wgRequest everywhere. what sort of deep compatibility check do you envision that would surpass merely grepping for these names? [06:26:09] New patchset: Rfaulk; "fix/mod. formatting/config setting variable names." [sartoris] (master) - https://gerrit.wikimedia.org/r/67649 [06:26:39] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/67649 [06:33:31] ori-l: ;) testing to see if you get a fatal error or not in general use of MW when the globals suddenly disappear. [06:34:08] grepping is a bit of a false flag cause the variables are still referenced in various parts of code for compatibility. [06:34:24] New patchset: Santhosh; "Fix: new language is not added to button on the display panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67650 [06:34:47] yes, but it doesn't require that you reach every code path [06:37:42] It's essentially similar to $wgLegacyJavaScriptGlobals. [06:38:25] A flag that test wikis could be run with till the point we can sanely kill them completely. [06:46:06] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67650 [06:46:09] New review: Siebrand; "See http://www.mediawiki.org/wiki/I18n#Adding_new_messages on what to do when adding new messages." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67615 [06:48:18] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [06:51:47] New review: Peterbruin; "Looks ok to me, anybody interested?" [mediawiki/extensions/LdapAuthentication] (master) C: 1; - https://gerrit.wikimedia.org/r/66195 [06:52:57] New review: Peterbruin; "Without this my error logs get 8 entries for every log in. Seems like a straight forward fix." [mediawiki/extensions/LdapAuthentication] (master) C: 1; - https://gerrit.wikimedia.org/r/65865 [06:54:28] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67652 [07:14:54] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67652 [07:18:34] New review: Tpt; "Some generic comments:" [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/67632 [07:19:29] New review: Tpt; "And, sorry, I forgot: Thanks for the change :-)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [07:31:25] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67652 [08:04:48] New patchset: Nikerabbit; "[1.22wmf6] ULS to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67810 [08:06:08] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67810 [08:07:35] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php Will do the same for other functions also. Change-Id: I9e067185529af2d259cfbeb84c3c3db66d2ddd95" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [08:13:21] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [08:16:48] New patchset: Alvaro Lopez Tijeras; "Remove multiply operation from Linux." [sandbox] (master) - https://gerrit.wikimedia.org/r/67811 [08:17:20] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [08:19:04] New patchset: Nikerabbit; "[1.22wmf5] ULS to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67814 [08:19:33] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67814 [08:22:51] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67811 [08:22:59] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67811 [08:27:12] Garr... It looks like the author of ApiQueryRevisions::getRollbackToken could have easily made it non-static and not used wgUser. [08:27:42] DanielFriesen: there is no way to do that easily [08:27:51] at least not in extensions [08:28:04] That's part of core [08:28:16] dunno if it is any easier there [08:28:25] In this case it is. [08:30:31] The non-static ApiQueryRevisions::getTokenFunctions is it's primary user, it constructs a $this->tokenFunctions containing an array( 'ApiQueryRevisions', 'getRollbackToken' ) callable referring to the other function, lets a hook tweak it, then returns. [08:30:48] It could have trivially used $this instead of writing out the static class name. [08:30:51] hashar: is it only chad who can kick gerrit or are there other perople as well? [08:31:56] New patchset: Alvaro Lopez Tijeras; "Add multiply operation from Linux." [sandbox] (master) - https://gerrit.wikimedia.org/r/67815 [08:37:43] New review: Alvaro Lopez Tijeras; "(1 comment)" [sandbox] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/67815 [08:41:41] New review: Hashar; "PS2 is still using the incremented number which is not really nice and not useful. Note that your p..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [08:44:11] New review: Hashar; "Mailed Tim about this change." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66066 [08:44:20] Nikerabbit: hey :) [08:44:29] Nikerabbit: any ops can restart gerrit on manganese [08:45:41] hashar: I take you are not ops :/ [08:52:21] Nikerabbit: indeed I am not [08:52:35] Nikerabbit: I should probably get access on manganese to be able to restart Gerrit :-] [09:08:58] New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67818 [10:00:50] New review: Rtdwivedi; "@Tpt: Thanks. I am making the changes." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [10:37:58] New review: Netbrain; "Didn't even have it installed. i guess it's missing a DataValues "is installed and loaded" check?" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/66924 [10:38:06] Change abandoned: Netbrain; "(no reason)" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/66924 [10:41:47] New review: Nikerabbit; "Also fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=49381 (dupe?)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/67818 [10:53:28] New patchset: Pastakhov; "Add String Functions (version 0.4.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67651 [10:59:36] #join #gsoc [11:31:53] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65572 [11:31:57] New review: Siebrand; "Not sure how I ended up on this patch set. i18n/L10n review done and fine." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63274 [11:34:10] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65567 [11:36:28] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67247 [11:38:44] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67641 [11:40:15] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Campaigns] (master) C: -1; - https://gerrit.wikimedia.org/r/67587 [11:41:00] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67638 [11:43:17] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67637 [11:45:07] New review: Siebrand; "L10n review and glanced at other files. Comments inline." [mediawiki/extensions/ThrottleOverride] (master) C: -1; - https://gerrit.wikimedia.org/r/67627 [11:49:16] New review: Siebrand; "i18n/L10n okay." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/66139 [11:52:21] New review: Siebrand; "i18n/L10n changes are trivial." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64565 [11:59:00] New patchset: Shirayuki; "Fix "RAM" and "IPs"" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/67821 [11:59:35] New review: Siebrand; "Can this be put in an extension? This seems to possibly be over engineering the core product with i1..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [12:08:06] New review: Siebrand; "Follow-up for L10n in Change-Id: I9e61314f951c7638a4de44f61111146cd20b21e6." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/67525 [12:08:22] New patchset: Nikerabbit; "mediawiki.api: Implement login method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [12:09:01] New review: Siebrand; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [12:09:47] New patchset: Nikerabbit; "Remove
as its not supported by jQueryMsg" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64551 [12:16:41] did gerrit-jenkins just get stuck again? [12:17:03] New review: Raimond Spekking; "Accepting this patch with German translations for this time bebause it is not in translatewiki.net." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66884 [12:17:03] Change merged: Raimond Spekking; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/66884 [12:17:09] apergos only restarted it a hour or two ago... [12:19:23] <^demon> Nikerabbit: I think it's fine at the moment, maybe just a tad slow. #1 priority for me today is fixing this. [12:20:05] New review: KartikMistry; "Looks good to me. Thanks!" [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/67818 [12:20:13] ^demon: nothing in https://integration.wikimedia.org/zuul/ [12:21:30] <^demon> Bah, we lasted 2 hours? [12:22:02] <^demon> Curious, gonna try something different. [12:28:46] <^demon> hashar: So, rather than restarting gerrit, I wondered if clearing gerrit's queue and restarting zuul would suffice. Doesn't seem to. [12:29:07] New review: Siebrand; "Are we sure we're actually reporting character difference here, and not byte difference? I just did ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65139 [12:29:12] <^demon> I see no errors on gerrit's side, but zuul doesn't seem to reconnect to stream-events (even tho queue is empty) [12:29:25] hello [12:29:52] <^demon> Good morning :) [12:29:54] ^demon: the issue I had a few months ago was that reconnecting on stream-events was working but no events were being sent [12:30:05] not sure if the last days outage are related to that [12:30:50] Zuul also throw an exception whenever the output of stream-events is not valid json [12:31:39] <^demon> Yeah, I'm getting the same from stream-events. It's just annoying because I've been unable to replicate locally and nothing appears in the gerrit log. [12:35:41] ^demon: you were talking about some Gerrit queue being filled [12:36:01] I interpolate that Gerrit handles all events in a single queue which has a limited size [12:36:01] New review: Siebrand; "+2 now that Gerrit has been restarted." [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/64551 [12:36:08] New review: Siebrand; "+2 now that Gerrit has been restarted." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67525 [12:36:10] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64551 [12:36:20] New review: Siebrand; "+2 now that Gerrit has been restarted." [mediawiki/extensions/OpenStackManager] (master) C: 2; - https://gerrit.wikimedia.org/r/67821 [12:36:20] whenever some replicated slave start failing, all events are thus stuck in the queue [12:36:21] correct? [12:36:24] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67525 [12:36:29] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/67821 [12:36:32] <^demon> hashar: Single queue, but limited by number of threads. [12:37:41] <^demon> hashar: `ssh -p 29418 gerrit.wikimedia.org gerrit show-queue -w` is what I'm talking about [12:37:44] so does it ends up having all thread locked trying to replicate ? [12:38:00] handy command :D [12:38:30] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/67591 [12:38:33] <^demon> Well, it's not replication that's broken right now, I fixed that (the big number of replication jobs is because I just restarted, it replicates all on startup) [12:38:45] <^demon> It's stream-events jobs that get stuck waiting... and I don't know why [12:38:53] ah [12:39:20] <^demon> Only 3 things fail to replicate partially at the moment, they're known and don't repeat. [12:39:42] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/67647 [12:40:45] <^demon> $ ssh gerrit.wikimedia.org gerrit show-queue -w [12:40:45] <^demon> Task State Command [12:40:45] <^demon> ------------------------------------------------------------------------------ [12:40:47] <^demon> 30c124dc git-upload-pack p/mediawiki/core.git [12:40:49] <^demon> bc98850f 13:33:53.358 Log File Compressor [12:40:51] <^demon> ------------------------------------------------------------------------------ [12:40:53] <^demon> 2 tasks [12:41:04] <^demon> hashar: See, we're dandy now. Just give it a bit of time, and stream-events will start backing up (for reasons I do not know yet) [12:43:54] <^demon> I've often wondered if running gerrit in tomcat would be good. But it's not easy and I'm sure would create its own new set of problems. [12:45:49] New review: Siebrand; "i18n/L10n review. Added inline comments." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67047 [12:46:59] ^demon: so for the last outage (11:51am UTC), Zuul logged an exception about "No JSON object could be decoded" [12:47:20] <^demon> Yeah, I saw that last time. [12:47:21] which occurred roughly 6 minutes after the last event [12:47:42] the reason is that stream-events sends a non json message (which Zuul does not log unfortunately) [12:47:48] Change merged: Siebrand; [mediawiki/extensions/SubPageList] (master) - https://gerrit.wikimedia.org/r/67596 [12:47:49] could it be the ssh timeout message ? [12:47:56] New patchset: Raimond Spekking; "Some consistency tweaks in preparation for adding extension to translatewiki.net" [mediawiki/extensions/QuickResponse] (master) - https://gerrit.wikimedia.org/r/67824 [12:48:11] <^demon> *Could* be... [12:48:12] a while ago Chris had a script that would send an event every 4 minutes to workaround the timeout [12:48:32] <^demon> qchris_away is now known as qchris :) [12:48:36] anyway, Zuul did reconnect automatically [12:48:44] New patchset: Siebrand; "'articlefeedbackv5-disable-flyover-help-location' is poorly placed and not needed" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62808 [12:48:53] Hi ^demon, hashar [12:49:02] I am still reading the scrollback. [12:49:06] New patchset: Santhosh; "Set the language for the settings panel for correct webfonts" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67825 [12:49:54] the first exception was at 11:51:00, then zuul reconnected to ssh. Then I can see the same error at 12:01:05 , 12:11:10, 12:21:15 (aka 10 minutes and 5 seconds apart) [12:49:55] New review: Siebrand; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/62808 [12:50:12] so it seems it is hit by the evil ssh 10 minutes timeout [12:50:46] <^demon> I thought zuul raised that timeout. [12:52:22] well Zuul does not have any keep alive nor a timeout [12:52:27] ^demon: IIRC, we raised that timeout on the gerrit side sshd.idleTimeout [12:52:30] that is Gerrit ssh server that disconnects it :( [12:52:50] That timeout sneaked it at a mina sshd upgrade from upstream gerrit. [12:53:07] But aren't we back at the old gerrit that used to work several weeks? [12:53:18] <^demon> Yeah. [12:53:20] <^demon> idleTimeout = 864000 [12:53:39] <^demon> And yeah, we're back on 2.6-rc0-144-gb1dadd2, the stable build. [12:53:42] I tried locally: That timeout still works. [12:54:25] There is a related fix that I filed upstream (Mina ssh), but did not yet get included. Let me get that url ... [12:55:04] https://issues.apache.org/jira/browse/SSHD-226 [12:55:13] Change merged: Konarak; [mediawiki/extensions/QuickResponse] (master) - https://gerrit.wikimedia.org/r/67824 [12:55:44] It relates to our zuul<->gerrit use case, but we haven't been bitten by it before, so I am not sure if that problem/fix would be relevant for us. [12:57:38] New review: Siebrand; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [12:58:05] in this case the ssh timeout seems to be 10 minutes [12:58:41] that is not much of an issue since Zuul automatically reconnect (though it might lost some events meanwhile) [12:59:01] <^demon> It sounds like it's timing out but the stream-events job isn't being notified. [12:59:05] New review: Alvaro Lopez Tijeras; "Please, review the changes. It seems there is a missing semicolon." [sandbox] (master) - https://gerrit.wikimedia.org/r/67815 [12:59:09] <^demon> So we get stuck [12:59:55] history of disconnections in zuul http://paste.openstack.org/show/38309/ [13:00:05] started on June 6th [13:00:27] 2013-06-06 12:24:26 [13:00:30] that is the first occurence [13:00:46] I'll revive the gerrit-ping change [13:01:02] New review: Siebrand; "i18n/L10n review done. Left inline comments." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/66379 [13:01:14] ^demon: 12:26 ^demon: bringing gerrit down for a few minutes to pick up some changes [13:01:15] :D [13:01:29] oh you rollbacked [13:01:34] from 424 to 420 [13:01:37] then to 144 [13:01:42] <^demon> Yeah, we rolled back very shortly. [13:02:58] apparently something was not rollbacked or was a hack that got overridden :D [13:03:16] the error appeared during the few hours following the last rollback [13:03:28] <^demon> Indeed. [13:03:36] maybe the ssh timeout value [13:03:41] or a hack of mina sshd ? [13:03:43] <^demon> No, that's still what's in puppet. [13:03:49] <^demon> Didn't have any specific hacks in place. [13:04:06] <^demon> Nothing weird or creepy sitting in lib/ like when we had mysql problems. [13:06:50] qchris: ^demon how did the 10 min timeout got solved ? [13:06:57] i can't remember :D [13:07:12] On the gerrit side [13:07:18] I'll look it up again. [13:07:27] There were several ingredients. [13:07:42] https://gerrit.wikimedia.org/r/#/c/58060/ [13:07:58] :-) [13:08:02] ^ hashar: Do I need to do anything else to get that change to get through zuul? [13:08:18] I comment there now every 4 minutes. [13:08:40] yeah I got them [13:08:44] Ok. [13:08:52] if you are afraid about the amount of comment, you can remove / add a reviewer on the change [13:08:57] that generates an event over stream-events [13:09:02] but that is merely cosmetic hehe [13:09:13] 2013-06-10 13:07:08,577 DEBUG zuul.Scheduler: Adding trigger event: [13:09:14] \O/ [13:09:52] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65581 [13:11:43] I have marked the bug as a duplicate of the good old bug https://bugzilla.wikimedia.org/show_bug.cgi?id=46917 "Gerrit no more emit events when using `stream-events`" [13:12:14] Looked up the solution from back in April. Back then, gerrit had upgraded Mina Sshd, which added the idle timeout with a default of 10 minutes. We added a setting for that in gerrit and set it to a sufficiently high number. [13:12:43] There were some other ssh fixed (protocol getting out of sync and the like), but they were not that relevant for the timeout. [13:15:05] New review: Hashar; "(1 comment)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [13:15:13] New patchset: Matthias Mullie; "'articlefeedbackv5-disable-flyover-help-location' is poorly placed and not needed" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62808 [13:16:48] ^demon b1dadd2cc209482f60ca0e52c47e76bc51b87ed7 does not provide the idleTimeout setting. [13:16:57] git checkout b1dadd2cc209482f60ca0e52c47e76bc51b87ed7 [13:17:04] grep -Ri idletimeout */src [13:17:10] yields no result [13:17:22] New patchset: Matmarex; "jquery.makeCollapsible: cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [13:17:25] New review: Hashar; "Indeed patchset 2 is what we want https://gerrit.wikimedia.org/r/#/c/67462/2/layout.yaml,unified Th..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [13:17:39] New review: Siebrand; "i18n/L10n okay." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1; - https://gerrit.wikimedia.org/r/62808 [13:18:29] <^demon> qchris: We're not on b1dadd2, we're on fd55e91, which does have it. [13:18:56] It says: 2.6-rc0-144-gb1dadd2 for me on [13:19:01] https://gerrit.wikimedia.org/r/#/c/58060/ [13:19:11] oops [13:19:26] Is there a cache somewhere? [13:19:59] <^demon> Bah, you're right. [13:20:04] <^demon> Was looking at wrong gerrit. [13:20:50] one thing that would be nice would be to tag the deployments in our git repo. Something like wmfdeploy- [13:22:35] We had the "Golden Star" in Jenkins :-) [13:22:54] <^demon> "Promoted" build :) [13:24:31] ^demon How to proceed from here. Do you still have a war with the idleTimeout around? Or should I provide one? [13:24:34] s/provide/build/ [13:24:54] New review: Siebrand; "Trailing whitespace in release notes." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67233 [13:25:08] <^demon> I'm thinking. [13:25:27] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [13:25:43] * qchris hums Jeopardy jingle :-) [13:27:06] There goes ^demon :-) [13:27:50] <^demon> ...ok? [13:27:56] <^demon> Stupid freenode. [13:33:03] New review: Hashar; "https://gerrit.wikimedia.org/r/#/c/67830/ validated." [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/67462 [13:33:03] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [13:36:11] hi [13:36:20] ^demon: poke jenkins for me? https://gerrit.wikimedia.org/r/#/c/61075/ [13:37:30] <^demon> busy [13:40:55] New review: Hashar; "Sorry I am not really qualified to review a html / xml class change nor do I know anything about tha..." [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [13:41:18] New patchset: Alvaro Lopez Tijeras; "Add multiply operation from Linux. Fixed." [sandbox] (master) - https://gerrit.wikimedia.org/r/67815 [13:41:52] <^demon> qchris: Can you get that build together? I'm fighting buck and maven switchovers.... [13:42:18] <^demon> Checking out before and after the swapover has my build confused. [13:42:27] On Apr 8, you said you deployed 2.6-rc0-154-gfcdb34b (I do not have that ref) [13:42:46] I'll try to build the war. [13:42:56] <^demon> Ahh, I have 154 still. [13:43:02] <^demon> Lemme grab that on manganese. [13:43:13] Ok. [13:48:37] gerrit 2.6-rc0-154-gfcdb34b is back online :-) [13:48:42] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: 1; - https://gerrit.wikimedia.org/r/67591 [13:48:57] New review: Alvaro Lopez Tijeras; "It looks good." [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67815 [13:49:26] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67815 [13:51:18] New review: Siebrand; "Doesn't merge, needs manual rebase. We usually put the GENDER on the verb, but it doesn't really mat..." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/57314 [13:59:27] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67418 [14:00:22] hashar, ^demon: since we're on a known good gerrit again, I'll turn off automatic commenting on https://gerrit.wikimedia.org/r/#/c/58060/ again. Ping me, if we need it again. [14:01:18] qchris: awesome thanks! Can you just add a quick note on https://bugzilla.wikimedia.org/show_bug.cgi?id=46917 about what you did ? [14:01:34] that would keep everyone informed and might be useful later on [14:01:42] Yes, of course. [14:02:45] and I note that gfcdb34b is not show in the git repo :-D [14:03:13] gerrit emails broken? [14:03:46] Krenair: Like in "Krenair does no longer receives emails from gerrit"? Or another kind of problem? [14:03:50] <^demon> Krenair: No. [14:04:01] <^demon> hashar: Drop the g at the start. [14:04:06] <^demon> It's gcdb34b [14:04:10] I was expecting an email for New review: Siebrand; "Doesn't merge, needs manual rebase. We usually put the GENDER on the verb, but it doesn't really mat..." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/57314 [14:04:15] <^demon> Bah, fcbd34b [14:04:15] But did not get one [14:04:25] <^demon> Letters are hard. [14:04:49] Krenair: We just rolled back gerrit to an older version. The fix for the problem you described is newer. [14:04:59] ah. [14:05:11] :-( [14:05:24] Freenode really hates ^demon today... [14:05:26] ^demon: oops. But still fcdb34b is not found :D [14:06:13] hashar: I cannot find it either. I guess its 153 + the idleTimeout cherry-picked on top -- in ^demon's private repo [14:06:55] <^demon> It might've been. Lemme tag it and push to gerrit.wm.o/gerrit [14:08:38] New patchset: Alex Monk; "Show that the Echo notification messages support {{GENDER:$1}}" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/57314 [14:10:08] New patchset: Matthias Mullie; "Small cosmetic improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67833 [14:10:54] New review: Hashar; "I would keep it around since that might be useful from time to time." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64499 [14:10:56] <^demon> qchris, hashar: https://git.wikimedia.org/commit/gerrit.git/fcdb34b97f3d684515668710bd5f1e3c681d187f [14:11:01] \O/ [14:11:07] Thanks \o/ [14:12:24] last thing is a quick note on https://bugzilla.wikimedia.org/show_bug.cgi?id=46917 and we are fine :) [14:12:36] New review: Siebrand; "L10n/i18n reviewed." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1; - https://gerrit.wikimedia.org/r/67833 [14:14:20] New review: Jeroen De Dauw; "> Meaning to test multiple throws" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64499 [14:15:12] <^demon> hashar: Oh, and I don't have a re-attempt date yet, but if you're wanting to use it for any testing, I think we're looking at 2.7-rc1-424-gef469ac as the upgrade point (plus any other fixes we find we need before now & deploy) [14:15:29] <^demon> Can be gotten from https://integration.wikimedia.org/nightly/gerrit/wmf/gerrit-2.7-rc1-424-gef469ac.war [14:19:04] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/57314 [14:22:04] New patchset: Hashar; "points ops-puppet-pep8 failures to the report URL" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67836 [14:22:55] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67836 [14:24:46] ^demon: will have to repeat that tomorrow :-D [14:24:58] ^demon: ping me again about it and I will test it out [14:25:40] <^demon> k. [14:25:51] sent myself a mail reminder though [14:26:00] I am off for some shopping and other stuff [14:26:01] brb [14:26:12] well technically, I will be back later [14:27:27] Change merged: jenkins-bot; [mediawiki/extensions/LocalisationUpdate] (master) - https://gerrit.wikimedia.org/r/67531 [14:29:12] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [14:30:06] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67818 [14:37:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67631 [14:38:36] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [14:41:27] New review: Anomie; "Note $wgCodeEditorEnableCore is still false for production wikis, and that variable still gates the ..." [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64593 [14:50:48] New review: Clancer; "I dont know if 3 bytes is informative of adding a single chinese character anyway? the measurement i..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65139 [14:53:05] New patchset: Matthias Mullie; "(bug 49327) overlapping text after moderation on permalink-page of feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67838 [15:04:48] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [15:07:22] New review: Brian Wolff; "PS5: Per Siebrand. Also an issue with false being handled properly in the change to the file handler..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [15:09:52] New patchset: Bharaththiruveedula; "Added 'Developers' link to footer link" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [15:13:17] Change merged: Alex Monk; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67600 [15:16:32] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67615 [15:17:48] New patchset: Matthias Mullie; "(bug 49327) overlapping text after moderation on permalink-page of feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67838 [15:18:43] New patchset: Bharaththiruveedula; "Added 'Developers' link to footer link" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [15:19:38] New patchset: Matthias Mullie; "(bug 49327) overlapping text after moderation on permalink-page of feedback" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67838 [15:20:20] New review: Alex Monk; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67601 [15:20:44] ^ Does Jenkins not support that any more? :/ [15:21:32] oh there it is, just doesn't work as expected [15:26:38] New patchset: Matthias Mullie; "Small cosmetic improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67833 [15:30:26] New patchset: Brian Wolff; "Make generating Parser test class names more robust" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [15:33:49] New review: Brian Wolff; "Even though its useless, once we removed meta keywords tag support from core, people almost instantl..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67606 [15:41:33] New review: Daniel Friesen; "Heh, that one was originally written for 1.6.x. Updated for 1.18.x. And uses addMeta( 'keywords', ....." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67606 [15:42:59] New patchset: Raimond Spekking; "Fix typo in message key: faxway... -> foxway..." [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67840 [15:42:59] New patchset: Matthias Mullie; "(bug 49286) ArticleFeedbackv5: Consider showing "reader feedback" less or not on top of the page" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/67841 [15:43:52] New review: Brian Wolff; "Looks like I spoke too fast there :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67606 [15:44:08] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [15:47:18] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67840 [15:53:15] New review: Brion VIBBER; "CAUSE ITS LIFE TO END WITH AN OXYGEN REACTION PRODUCING LIGHT AND HEAT!" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67606 [15:53:16] Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67606 [16:11:19] New review: Alex Monk; "recheck" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [16:25:55] New review: Mwalker; "I'll +2 this -- but I had a question about where the conversion to the varient takes place if not he..." [mediawiki/extensions/CentralNotice] (master) C: 1; - https://gerrit.wikimedia.org/r/67629 [16:59:38] New patchset: Matmarex; "CSS: Minor code style fixes" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67845 [16:59:39] New patchset: Matmarex; "SpecialAbuseLog: use DifferenceEngine::addHeader to render diffs" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67846 [16:59:57] review, anyone? these are trivial ^ [17:00:10] (or at least the first one, i didn't test the second, though) [17:00:20] * YuviPanda looks [17:01:21] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67845 [17:01:58] YuviPanda: do you have AF installed locally somewhere, and could you test the secondchange, if so? [17:02:21] MatmaRex: I do have it installed locally, but haven't touched it in ages [17:02:53] MatmaRex: I'll take a look in an hour or so - have a bunch of meetings in about 10 mins [17:02:56] YuviPanda: go to [[Special:AbuseLog/whatever]], if it displays, then that should be fine to merge :P [17:02:58] ah, sure. [17:03:00] thanks :) [17:03:19] (by 'whatever', i mean a valid numeric id :P ) [17:03:19] added myself just as a reminder [17:07:22] New patchset: Cmcmahon; "disable UW tests for IE8 and below Bug 49393" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67847 [17:10:19] New patchset: Kaldari; "Adding optional confirmation process to Thanks workflow" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [17:10:33] New patchset: Aaron Schulz; "Use getFileContents() instead of incorrect file system call to fetch file contents." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67236 [17:14:41] New review: Matmarex; "Tested, works on master MediaWiki core. This shouldn't break back-compat, that function has been the..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67846 [17:15:30] New review: Alex Monk; "Needs to be re-approved or submitted" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67601 [17:17:22] New review: Cmcmahon; "disable UploadWizard test for IE8/7/6 pending fix for test tool" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67847 [17:17:25] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67847 [17:23:49] New patchset: Matmarex; "SpecialAbuseLog: use DifferenceEngine::addHeader to render diffs" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67846 [17:26:42] ori-l, there are tons of warnings when uploading file to a fresh vagrant install. Not sure if you know about it [17:28:58] yurik: i found out about it yesterday :) i'll submit a fix today [17:29:45] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/67591 [17:30:47] ori-l, cool, thx!!! [17:39:06] New patchset: Ori.livneh; "mw.toolbar: Clean up code and jsduckify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [17:40:11] New review: Ori.livneh; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [17:41:24] New review: Ori.livneh; "@Anomie: ah yes, I see that now." [mediawiki/extensions/CodeEditor] (master) C: 2; - https://gerrit.wikimedia.org/r/64593 [17:41:44] Change merged: jenkins-bot; [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64593 [17:43:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67647 [17:44:56] New patchset: Matmarex; "DifferenceEngine: Don't display empty header row" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67848 [17:45:44] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67066 [17:58:18] New review: Liangent; "core - languages/LanguageConverter.php" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/67629 [18:00:27] New review: Ori.livneh; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [18:09:13] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [18:16:25] New patchset: Matmarex; "DifferenceEngine: Remove broken comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67850 [18:17:36] New review: Matmarex; "Alex, if you still remember what you intended to write here ;), please say, so we can expand this in..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67850 [18:29:52] New review: Tychay; "The original code (at least in January) had it this way. TylerRomeo introduced this change with the ..." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66023 [18:29:53] Change merged: Tychay; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [18:37:57] Change merged: Parent5446; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67601 [18:42:06] is there a sane way to get DifferenceEngine to display *all* of the available context in its diff? [18:42:40] or Diff, or whatever else [18:42:48] New review: Parent5446; "@Tychay, I did not make this change. The change was made by Jeroen De Dauw in ece97c35." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [18:45:02] or maybe [18:45:12] is there a sane way to get it to display any context if the diff is empty? [18:45:50] New review: Tychay; "@TylerRomeo: Hah! My bad, I misread the directionality between ece97c358424015777db3881d87aa33966d63..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [18:57:56] New patchset: Spage; "Hack fix for bug 49398" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/67857 [18:58:32] New patchset: Raimond Spekking; "Add i18n file" [mediawiki/extensions/ExternalArticles] (master) - https://gerrit.wikimedia.org/r/67858 [18:59:08] New review: Ori.livneh; "I think we should just remove the calls to getHtml if the method no longer exists on TextContent" [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/67857 [19:00:16] New review: Ori.livneh; "This caused https://bugzilla.wikimedia.org/show_bug.cgi?id=49398." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [19:01:49] New review: Ori.livneh; "Or reintroduce it to core, since it's core that's calling it after all." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/67857 [19:04:51] kaldari: ping [19:05:17] New patchset: Kaldari; "Adding optional confirmation process to Thanks workflow" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [19:05:27] hoo: howdy [19:05:42] Is page triage removing patrollinks from page? [19:05:52] yes, it should be now [19:05:58] wow, wow [19:06:09] just for pages with PageTriage activated [19:06:18] Why? Shouldn't we just disable page patrolling then? [19:06:25] It makes some pages unpatrollable on en [19:06:30] ? [19:06:37] https://en.wikipedia.org/wiki/National_Highway_183_%28India%29 [19:06:52] the page patrol link is there and then it just vanishes [19:07:53] That's probably only if you've visited Special:NewPagesFeed recently [19:08:04] I've been there once [19:08:08] that hting is nasty [19:09:29] so any page is patrollable, it's just a question of whether you can use the link or the PageTriage interface [19:10:26] kaldari: huh? I see neither the link nor that page triage toolbar on that page, do you? [19:11:02] if you closed the pagetriage interface, it may just be a link in the toolbar now: "Curate this article" [19:11:17] under the Toolbox [19:11:53] ah yes [19:12:03] I don't remember how long the setting sticks for using PageTriage [19:12:15] lemme look [19:12:22] That thing is pretty confusing... is it using cookies? [19:12:58] no, it's using an API user option I believe [19:13:05] New patchset: Ori.livneh; "Revert "Introducing ContentGetParserOutput hook."" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67860 [19:13:35] although it may make sense to switch to a cookie, if you think people are going to want to turn it off explicitly [19:14:00] Well... but why is it hiding the link when I disable it? That's sounds broken to me [19:14:33] So you're saying that if you dismiss the PageTriage interface, it should reintroduce the patrol link? [19:14:43] that seems reasonable I suppose [19:14:49] Yes, so that you can use the native interface for patrolling [19:14:55] that's what I assumed it does [19:15:26] I think that's a good point that we hadn't thought about [19:15:35] can you file a bug for it? [19:15:49] That might go under today [19:15:59] Change abandoned: Anomie; "We decided to go in a different direction" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66286 [19:16:04] So many people shooting at me for patrol stuff [19:17:55] New patchset: Ori.livneh; "Revert "Introducing ContentGetParserOutput hook."" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67863 [19:17:55] that's basically why we created a totally new interface. After we consulted with patrollers about all the problems that they had, it made sense to just create a totally new system from scratch, but I take it some people still want to use the old interface since they are used to using Twinkle and such. [19:18:32] * ori-l shoots at hoo [19:18:51] kaldari: Especially since you're building up on it, you shouldn't IMO just hide it from the users in these cases [19:19:53] In the case where the PageTriage floating toolbar is hidden I agree, otherwise, it is confusing though. [19:19:54] ori-l: re the ContentGetParserOutput hook- is there any need for that to happen server-side? [19:20:17] something like syntax highlighting sounds like it could also be done on the client [19:20:27] gwicke: don't ask me; it's daniel's patch. My question was: was there a need for that to remove methods from the class that other methods were still calling? [19:20:33] hoo: running off to lunch [19:20:34] gwicke: and the answer to that is a comfortable "no" [19:20:42] kaldari: ok ;) [19:20:55] ori-l: k [19:21:19] it sounds like something that we can't really support sanely when switching to HTML-based storage [19:23:13] gwicke: sounds right; I'm in the midst of reverting it to fix a fatal in prod, so you'll get a second chance to raise your concerns when Daniel resubmits it. [19:23:40] k [19:24:23] hm... is krinkle around today? [19:25:05] New review: GWicke; "How will this work with HTML storage?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [19:27:21] Reedy, greg-g: I'd like to sync https://gerrit.wikimedia.org/r/#/c/67863/ ASAP; it fixes https://bugzilla.wikimedia.org/show_bug.cgi?id=49398 , which is currently causing fatals on Schema pages on Meta. When could I sync it? [19:28:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67860 [19:28:21] ori-l: Go for it. It's still the wmf6 deployment window [19:28:49] New patchset: Plavi; "Refactoring: class UserPage renamed to VisualEditorPage" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67865 [19:28:50] Reedy: OK, thank you. [19:28:52] New review: Nischayn22; "I am so thankful to MWJames for taking over this one, I wanted to get this fixed but didn't get the ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [19:29:36] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67863 [19:31:17] New review: Brian Wolff; "PS3: Doing as you suggested. Note, I still have the appending a number thing in case of a conflict. ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [19:35:46] Reedy, greg-g: done [19:35:58] thanks [19:37:42] Change abandoned: Ori.livneh; "Fixed by reverting Ibfb2cbefe instead." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/67857 [19:41:39] New patchset: Jeroen De Dauw; "Fix breakage due to changes in base class in core" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66025 [19:41:44] New patchset: Jeroen De Dauw; "Fixed phantom log entries for "course updates" that havent happened" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66032 [19:43:20] hoo: I looked at the stickiness and it's only supposed to be for 1 day. I think in our rush to fix the conflict before the branch was cut, we may have broken page patrolling :( [19:43:30] I'll see if I can get it all fixed today [19:44:22] kaldari: Ok... please also see all the patches I put you as reviewer in gerrit... I don't want the universe to collapse again ;) [19:44:40] good idea :) [19:50:37] The changes to ArticleViewFooter in I94e2d931, are a little odd in my mind. Why not just allow the hook to disable showing the patrol footer, instead of telling extensions what it did? [19:54:22] New patchset: Matmarex; "AbuseFilterViewDiff: Make diffs use standard styling (and more)" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67868 [19:54:22] New patchset: Matmarex; "Pass context when contructing DifferenceEngines" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67869 [19:55:15] New review: Matmarex; "For best results combine with I9e3e7422 in core, but it's not a dependency." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/67868 [19:58:24] New review: Wikinaut; "Because I currently do not qualify for becoming maintainer of this extension - this is what Marc, Kr..." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [19:59:04] New patchset: Yaron Koren; "Added 'noparse' and 'isHTML', apparently necessary for MW 1.21+" [mediawiki/extensions/Widgets] (master) - https://gerrit.wikimedia.org/r/67871 [19:59:51] New patchset: Kaldari; "Better solution to page curation / page patrolling conflict" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/67872 [20:00:03] New review: Ori.livneh; "Some comments in-line, but no dealbreakers. Haven't had the chance to verify it. Eric: the EventLogg..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [20:04:03] New patchset: Cmcmahon; "IN PROCESS: test for uls cog behavior for anonymous users, please review" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67873 [20:04:09] Change merged: Yaron Koren; [mediawiki/extensions/Widgets] (master) - https://gerrit.wikimedia.org/r/67871 [20:07:52] New review: Cmcmahon; "This should pass for everyone. Looking for opinions: should we make this test more efficient or have..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67873 [20:09:08] New patchset: Anomie; "Add user rights 'editmyuserjs' and 'editmyusercss'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67874 [20:09:08] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [20:09:09] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [20:11:51] hoo: actually it wasn't completely broken. If you go to National Highway 183 (India) _from_ Special:NewPages, it shows the patrol link, but otherwise it's hidden, which obviously isn't what you want to happen. [20:11:56] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #110: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/110/ [20:12:00] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #92: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/92/ [20:12:21] kaldari: Yes... but I originally came from newpages, but maybe I've reloaded after [20:12:45] hoo: must've been reloaded [20:12:53] anyway, I have a patch for the behavior you want [20:13:05] https://gerrit.wikimedia.org/r/#/c/67872/ [20:13:12] New review: Brian Wolff; "I know I'm a bit late here, but I find this hook change a bit odd. Wouldn't we want extensions using..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [20:13:57] New review: MZMcBride; "What began as a fairly lightweight and simple extension is quickly growing complex. Unless a configu..." [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [20:16:58] hoo: on https://gerrit.wikimedia.org/r/#/c/67040/ you remove the caching of the patrol link from the diff view without mentioning it in the commit message. What's the reasoning for doing that? [20:17:49] bawolff: It hasn't been there before and I doubt it's worth it as diffs aren't viewed this often [20:18:05] I only put it there to ahve it gain some performance from the Article class change [20:18:26] hoo: yeah, it doesn't seem quite as critical a path as the normal article view [20:18:55] Flooding mc doesn't seem worth it [20:19:04] poke Tim if you're unsure, but we had that for ages [20:19:20] hoo: no I agree with you that that sounds reasonable [20:19:52] :) [20:20:03] hoo: My only (very minor) concern with https://gerrit.wikimedia.org/r/#/c/67040/ at this point, is in the caching call, it caches a value of 1 for boolean true, instead of the value true, which seems kind of odd to me [20:20:57] New patchset: Ronengi; "Show a warning when deleting a page to which there are links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65581 [20:20:59] Yippie, build fixed! [20:21:00] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6 build #42: FIXED in 9 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_6/42/ [20:21:06] bawolff: Ask Tim for that, too. We decided together that this is better than trying to serialize true [20:21:23] New review: Kaldari; "Unfortunately, I think 'sane' is a subjective assessment :)" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [20:21:23] We just need to set it anyway, value doesn't matter [20:21:48] Don't we already have support for doing that? [20:21:49] Yippie, build fixed! [20:21:50] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7 build #42: FIXED in 9 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_7/42/ [20:22:05] bawolff: Doing what [20:22:06] ? [20:22:19] Giving true to the caching backend and things just working? [20:22:49] It works, but I think it stores much more data or so [20:22:58] Tim said this is more sane, and I agree with him [20:23:04] ok, that sounds fine then [20:24:05] New review: Brian Wolff; "This looks good to me." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67040 [20:26:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67040 [20:26:50] New patchset: Anomie; "Add user rights 'viewmywatchlist', 'editmywatchlist'" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67875 [20:26:51] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [20:29:53] Yippie, build fixed! [20:29:53] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8 build #81: FIXED in 8 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_8/81/ [20:31:58] New patchset: Aaron Schulz; "Use adaptive TTL in LocalFile to deal with memcached flapping better." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67880 [20:33:13] New patchset: Aaron Schulz; "Use adaptive TTL in LocalFile to deal with memcached flapping better." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67880 [20:33:30] New patchset: Anomie; "Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67876 [20:34:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #90: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/90/ [20:45:07] hashar: around? quick question? [20:46:45] busy conf call sorry YuviPanda [20:46:56] hashar: np, will ping later / tomorrow :) [20:49:25] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [20:55:11] Yippie, build fixed! [20:55:11] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #75: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/75/ [20:56:32] YuviPanda: yeah mail me please or fill an enhancement/bug request in Bugzilla making sure I am in cc :-D [20:56:43] mm, sure! :) [20:56:46] YuviPanda: connecting to next conf call right now then I will head to bed (it will be midnight) [20:56:58] this isn't exactly urgent, so it's fine :) [20:57:00] i'll put it on bz [20:57:09] enjoy your conference calls, hashar! :) [20:57:09] <3 [20:57:11] thanks yuvi ! [20:57:51] * hashar hasher's writes a note to remember himself about filling a bug for the android commons apps. [20:58:50] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67874 [21:19:15] New patchset: MaxSem; "Always output even default globe" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/67886 [21:19:24] legoktm, ^^^ [21:19:32] MaxSem: thanks :D [21:20:39] New review: Legoktm; "Thanks for this." [mediawiki/extensions/GeoData] (master) C: 1; - https://gerrit.wikimedia.org/r/67886 [21:24:45] New patchset: Aaron Schulz; "Don't show the "permissions error" page after a user self-removes rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66383 [21:32:16] New review: Tim Landscheidt; "I haven't tested it yet, but this doesn't look right. The link to the release notes about hstore do..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59046 [21:52:53] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [21:57:14] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62518 [21:57:30] New review: Parent5446; "Tested on local wiki. Edit count now updates." [mediawiki/extensions/UserMerge] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66139 [21:57:30] Change merged: Parent5446; [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [22:00:45] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #72: FAILURE in 6 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/72/ [22:01:46] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65581 [22:04:17] New patchset: Parent5446; "Added JobQueue that uses Amazon SQS." [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/51635 [22:04:43] Change merged: Parent5446; [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/51635 [22:07:23] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65581 [22:13:14] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65581 [22:18:34] New patchset: Bsitu; "Add new hook AbortTalkPageEmailNotification" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67901 [22:20:47] New patchset: Bsitu; "Add new hook AbortTalkPageEmailNotification" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67901 [22:22:52] New patchset: Bsitu; "(bug 49142) Notifications Productivity A/B Test" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67570 [22:24:45] New review: Bsitu; "This patch depends on https://gerrit.wikimedia.org/r/#/c/67901/" [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/67570 [22:27:23] hey kaldari - there's a gossip that you need stuff reviewed? [22:27:30] https://gerrit.wikimedia.org/r/#/c/67367/ [22:27:31] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67901 [22:27:35] New patchset: Hoo man; "Allow patrolling pages by revision id" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [22:28:24] MaxSem: we need to get it live this week for some outside developers to be able to use it [22:28:25] New review: Hoo man; "Addressed Aude's concerns." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [22:28:40] Yippie, build fixed! [22:28:41] Project browsertests-test2.wikipedia.org-windows-internet_explorer_6 build #294: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_6/294/ [22:28:49] MaxSem: But it doesn't belong to any dev team, so hard to find someone to review it [22:29:29] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67906 [22:31:43] Yippie, build fixed! [22:31:44] Project browsertests-test2.wikipedia.org-windows-internet_explorer_7 build #298: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_7/298/ [22:32:54] I have some dead-simple PHP that sets a session cookie in response to ?campaign=WikimaniaSignup in a URL. When MW sends its cached response, does it also send the Set-Cookie header ? [22:37:31] New patchset: Bsitu; "Add new hook AbortTalkPageEmailNotification" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67901 [22:37:38] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67906 [22:38:11] Reedy: fyi, we've introduced two new messages with that [22:38:23] wmf5? but not wmf6? [22:38:49] Reedy: yes [22:38:52] it's something else [22:39:06] more critical, but i can prepare the one for wmf6 in a minute [22:39:42] Sorry, I thought this was the repo fix [22:39:46] hoo: no [22:39:46] New review: Bsitu; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67901 [22:39:57] i can get to that now [22:40:21] ah, it's that parser thing [22:40:25] yes! [22:41:40] Yippie, build fixed! [22:41:40] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #318: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/318/ [22:42:49] New patchset: Spage; "Add campaign support" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [22:43:27] Does wmf6 need a scap too? [22:43:33] Id' rather not have to run it twice ;) [22:43:48] New review: Spage; "Thanks, review comments addressed." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [22:44:02] ok, one sec.... [22:45:02] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67918 [22:45:10] https://gerrit.wikimedia.org/r/#/c/67918/ [22:45:13] that one actually has message changes :P [22:45:15] that's it [22:45:23] :o [22:45:59] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67918 [22:48:34] much better :) [22:54:37] kaldari, is Disambiguator already live on enwiki? [22:55:15] Special:Version says no [22:55:45] no, but it's live on test and test2 [22:55:45] documenation for it is on MediaWiki.org [22:55:46] https://www.mediawiki.org/wiki/Extension:Disambiguator [22:56:22] meh, I hoped to see the queries on real data:P [22:56:38] MaxSem: You can see how it's broken here: https://test.wikipedia.org/wiki/Special:DisambiguationPageLinks [22:56:55] those arrows are supposed to point to another page title [22:57:14] but since testwiki is in MiserMode it can't pull the data [22:58:59] MaxSem: MiserMode is a bit mysterious, so let me know if I should explain it more in the commit summary [22:59:17] I know what it is:) [22:59:20] cool :) [23:01:00] I've tested locally with MiserMode on and it now works correctly (with the patch) [23:03:36] MaxSem: I basically just changed it from using the querycache table (the default) to using querycachetwo, which can support more complicated query results [23:03:46] Yippie, build fixed! [23:03:46] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #93: FIXED in 9 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/93/ [23:05:46] MaxSem: unfortunately the QueryPage class doesn't have any built-in support for using querycachetwo [23:06:08] but maybe someone will add that one day [23:11:08] New review: MZMcBride; "Siebrand: Brian W. made a similar point: a "developers" link on (for example) the jQuery wiki could ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [23:12:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67901 [23:13:31] New patchset: Ori.livneh; "Make file uploads work" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/67925 [23:14:56] ^ yurik [23:15:07] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/67925 [23:15:21] Krenair: What's up? [23:31:19] New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [23:31:25] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #117: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/117/ [23:31:51] Hello, are all Wikivoyage wikis recogni[sz]ed by wikivoyage in $wgConf? [23:32:07] yes [23:32:17] it's a group from the dblist [23:32:39] But httpseverywhere doesn't recognize them correctly :P [23:32:51] (It does recognize them as Wikimedia, but isn't redirecting) [23:32:56] [23:33:02] old rule set? [23:33:30] It was added ages ago [23:33:51] It should be current enough [23:33:57] I even git blamed it :P [23:34:03] Reedy: It's because I'm making some genfixes to InitialiseSettings and see both wikivoyage and the dbnames used, I'll fix that [23:34:17] Reedy: Does it work for you http://fr.wikivoyage.org/w/index.php?namespace=8&tagfilter=&title=Sp%C3%A9cial%3AModifications+r%C3%A9centes ? [23:34:39] It shows the site as "Wikimedia" but isn't doing the redirect and I've no idea why [23:34:43] hoo: does wikimedia include Meta? [23:35:11] Hazard-SJ: in httpseverywhere? Yes [23:35:46] hoo: In $wgConf [23:35:59] Oh, I'm not sure [23:35:59] https://github.com/reedy/https-everywhere/blame/master/src/chrome/content/rules/Wikimedia.xml [23:36:20] WikiVoyage attributed to me in November/December last year [23:36:20] Reedy: Is it working for you? :P [23:36:25] Nopd [23:36:34] I'm not sure that's a ruleset problem though [23:36:58] Hmm, it's completely broken [23:37:00] wtf [23:37:55] New patchset: Brian Wolff; "[WIP] New more slick gallery display" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67885 [23:38:37] Just mentioned it in their irc channe; [23:38:55] Reedy: Does wikimedia include metawiki in $wgConf? [23:39:20] Ni [23:39:21] *No [23:39:21] Wikimedia is just chapter wikis [23:39:25] https://noc.wikimedia.org/conf/highlight.php?file=wikimedia.dblist [23:39:44] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #76: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/76/ [23:41:13] OK, thanks [23:41:53] kaldari, looks good to me - but would like someone to veto it performance-wise [23:42:34] MaxSem: Any suggestions for other reviewers? [23:43:16] Tim/Aaron? [23:44:19] basically, the question is whether this filesort acceptable for a periodically run script. what's the total number of dabs on enwiki? [23:45:39] ori-l, i remember i was pushing for cache2, but never got around to using it. It was for various special pages that api simulated [23:46:07] yurik: hm? not sure what the context is [23:46:21] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/64532 [23:47:03] gwicke: going somewhere? :) [23:47:12] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65766 [23:47:26] kaldari, also - if you need it running this week you should know that it will take the job queue some time to populate the DB [23:49:05] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65765 [23:49:48] Change merged: Yaron Koren; [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65767 [23:50:41] ori-l, you pinged me above [23:50:57] yurik: what's 'cache2'? [23:51:39] ori-l, querycachetwo conv that you pinged me about? [23:52:30] New review: PleaseStand; "Needs rebase. RELEASE-NOTES-1.21 needs to be deleted for this to be merged." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64860 [23:53:01] yurik: no, I was flagging: 6:13 New patchset: Ori.livneh; "Make file uploads work" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/67925 [23:55:12] Do we have any style conventions on how to (properly) do multiline ifs? [23:56:46] hoo: With else? [23:57:12] Hazard-SJ: No, I mean multiline conditions [23:58:04] MaxSem: thanks I'll add TimStarling as a reviewer as well [23:58:53] Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/67886