[00:09:09] New patchset: Ori.livneh; "Move post-edit font-family rule to Vector-specific selector" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67168 [00:17:31] New review: Ori.livneh; "@MZMcBride: OK, fair. Your point about the two-steps-forward, one-step-back process is duly noted. B..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67168 [00:21:35] Anyone really familar with mysql performance want to look over https://gerrit.wikimedia.org/r/#/c/67468 and tell me if its acceptable, and if the 'USE INDEX' is appropriate? (/me wants a second opinion) [00:30:10] bawolff: Got an example query? (to run explain on, with and without the USE INDEX) [00:30:45] Give me a moment [00:30:59] yay for laziness [00:32:17] https://dpaste.de/sS7yX/ [00:32:31] Basically, usually the results of explain are the same [00:32:55] but one I did it for image/jpeg which represents about 50% of the images in my local db, it went to a table scan [00:33:23] and me and Tyler are arguing on the gerrit patchset about if that is a good thing or a bad thing [00:37:47] New review: Daniel Friesen; "@Parent5446, users should never use a Html for just escaping attributes. Html::expandAttributes alre..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [00:45:55] New patchset: Hoo man; "Allow patrolling pages by revision id" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [00:54:50] New patchset: Hoo man; "Allow patrolling pages by revision id" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [01:00:34] Yippie, build fixed! [01:00:35] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #81: FIXED in 5 min 27 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/81/ [01:07:11] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [01:07:39] New patchset: Hoo man; "Allow patrolling pages by revision id" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [01:08:23] New review: Hoo man; "Fixed error documentation, per Parent5446" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67624 [01:10:24] New review: Mwjames; "Do you still get the CacheHandlerTest::testNewFromId failure because I don't and since Jenkins CI di..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [01:16:04] New patchset: Hoo man; "Only show notoken as possible API error once" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [01:16:44] New patchset: Hoo man; "Only show notoken as possible API error once" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67625 [01:27:56] New review: Mwjames; "Well sorry for hijacking but I can't hear it any more not being able to write/have tests so in order..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [01:42:44] Change merged: Mwjames; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67620 [01:44:13] New patchset: Hoo man; "Remove revision patrol links from normal page views" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67040 [01:45:34] New patchset: Hoo man; "Remove revision patrol links from normal page views" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67040 [01:46:47] New review: Hoo man; "Totally changed the approach here: Removed the revision patrol link from non-diff page views entirel..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67040 [01:48:01] Change merged: Mwjames; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67621 [01:52:20] New review: Jeroen De Dauw; "Hey, I'm not complaining :)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [01:55:56] Krinkle: BTW, jenkins is dead again. [01:56:57] James_F: I don't see any errors in either Jenkins nor Zuul [01:57:10] Krinkle: I also don't see any activity. :-( [01:57:27] Gerrit's stream is broken again [01:57:58] Probably. [01:58:14] see -operations [03:53:35] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [04:00:00] New patchset: Parent5446; "Add special page for listing throttle overrides" [mediawiki/extensions/ThrottleOverride] (master) - https://gerrit.wikimedia.org/r/67627 [04:01:30] Okay, so, Reedy... what does "smart attire" mean, when part of a dinner invitation? [04:12:13] New review: Mattflaschen; "recheck" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67168 [04:17:13] Amgine_: generally something like nice jeans + long sleeve shirt [04:17:31] depends if they also mean smart smart, or smart casual [04:19:08] https://en.wikipedia.org/wiki/Smart_casual https://en.wikipedia.org/wiki/Informal_attire [04:20:08] superm401: https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=73373 [04:20:42] If you see someone in operations later today, tell them to restart Gerrit [04:20:48] I'm signing off for today [04:21:20] Thanks, Krinkle. I probably won't be following up either tonight, though. [04:26:38] Thanks p858snake|l. I'm just paranoid 'cuz it's St. Andrews in Scotland. [04:27:00] *way* out of my comfort zone. [04:34:42] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/67451 [04:35:53] Show of hands, outputting CURIES for RDFa using code (ie: adding OpenGraph, Schema.org, etc... stuff) [04:36:03] A) $og->curie( 'site_name' ); [04:36:08] B) $og['site_name'] [04:36:15] C) $og->site_name [04:37:05] New review: Krinkle; "If you want to play it that way, I'd find it unfortunate but I can't stop you." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54089 [04:37:56] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53802 [04:45:48] New review: Krinkle; "(1 comment)" [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/66139 [04:48:09] New review: Krinkle; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [04:49:17] New review: Krinkle; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [05:01:25] New review: Krinkle; "Needs release notes. Also I'd recommend rephrasing commit message to more clearly indicate this is f..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [05:03:27] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [05:03:32] New review: Wikinaut; "see inline comments" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [05:09:00] New review: Mwjames; "The only missing collectors are unused properties and properties which after that will allow to reti..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [05:12:49] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [05:14:08] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [05:19:52] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [05:21:09] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [05:21:34] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [05:23:00] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [05:38:29] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [05:41:58] New patchset: Mattflaschen; "Improve multiple tour support:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67066 [06:02:41] New patchset: Mattflaschen; "Improve multiple tour support:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67066 [06:19:05] New patchset: Daniel Friesen; "Major improvements to RDFa and tweaks to Microdata support." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67608 [06:23:22] New review: Daniel Friesen; "PS: Fix regression in itemprop." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67608 [07:15:26] Published patchset: Wikinaut; "trim white spaces around urls in feed item or tags" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/67628 [07:17:56] New patchset: Wikinaut; "trim white spaces around urls in feed item or tags" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/67628 [07:18:18] New patchset: Wikinaut; "trim white spaces around urls in feed item or tags" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/67628 [07:18:30] New patchset: Wikinaut; "trim white spaces around urls in feed item or tags" [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/67628 [07:27:37] *facepalm* [07:28:00] I messed up a little while working with Git in Gareth. [07:28:45] I just found a nice GitPython library that would vastly simplify my Gareth Git code. [07:29:11] ((I'll still need a number of the stuff I wrote but I just don't need most of the low level stuff.)) [07:29:25] This is probably PHP's fault ;) [07:29:58] I started in PHP, all the git libraries were crap for PHP, so I wrote a ProcGit to work with git commands directly. [07:30:17] Then when I switched to Python I sort of ported that. [07:35:28] New review: Krinkle; "Don't merge yet per bug 49228." [mediawiki/extensions/Vector] (REL1_21) C: -2; - https://gerrit.wikimedia.org/r/67254 [07:43:28] New review: Krinkle; "> Krinkle: How are users supposed to read the token to then copy/paste into a tool interface that us..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [07:50:47] New review: Krinkle; "As for when it populates, I have my centralauth account auto-created on almost all of the 900 wikis...." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [08:04:23] New review: Daniel Friesen; "First note. The watchlist token exists purely for the purpose of including it inside RSS/Atom feed u..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64565 [08:06:54] New patchset: Mwjames; "SMW\SQLStore\PropertyTableDefinitionBuilder (fixedProperties to Settings)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [08:42:01] New patchset: Liangent; "(bug 49354) New config variable: $wgNoticeUseLanguageConversion" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/67629 [08:49:49] New review: Liangent; "Change Ib2109176 for Language::getParentLanguage() is required when $wgNoticeUseLanguageConversion i..." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/67629 [09:22:28] New patchset: Krinkle; "mediawiki.user: Simplify implementation and jsduckify" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67630 [09:26:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67262 [09:31:23] New review: Krinkle; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [10:08:36] New review: Ori.livneh; "But no rush, y'know." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [10:08:42] New patchset: Umherirrender; "Remove unneeded parenthesis from warning text in prop=revisions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67631 [10:28:10] New review: Ori.livneh; "Code editor has crept its way into production use, despite not having undergone a formal and thoroug..." [mediawiki/extensions/CodeEditor] (master) C: 1; - https://gerrit.wikimedia.org/r/64593 [10:32:08] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [10:33:54] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [10:57:33] New patchset: Mwjames; "SMW\SQLStore\PropertyTableDefinitionBuilder (fixedProperties to Settings)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [12:05:44] New patchset: Matmarex; "CSSJanus: add support for CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [12:06:22] New review: Matmarex; "Done, hopefully, because I'm not sure what did you exactly want." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [12:12:00] New review: Matmarex; "Krinkle, had you even glanced at this change and the corresponding I756927b3 in Vector, you'd notice..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [12:35:42] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [12:36:25] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [12:39:29] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [13:29:30] New patchset: Wikinaut; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [14:29:39] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [15:25:32] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php Will do the same for other functions also. Change-Id: I9e067185529af2d259cfbeb84c3c3db66d2ddd95" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [15:33:23] New review: Reedy; "Why's the .htaccess been added in this commit?" [mediawiki/extensions/ProofreadPage] (master) C: -1; - https://gerrit.wikimedia.org/r/67632 [17:08:42] ping server admins: https://bugzilla.wikimedia.org/show_bug.cgi?id=49363 git.wikimedia.org gives Error 503 ? [17:16:16] * Jasper_Deng_away lets Azatoth know of his memos before going for breakfast [17:18:08] * AzaToth wonder what Jasper_Deng_away eats for breakfirst [17:21:32] Jasper_Deng_away: I see [17:22:32] Jasper_Deng: the relevant code is http://paste.debian.net/9375/ [17:22:50] I don't see any "errors" by the look of it [17:23:06] hhm [17:23:53] Azatoth: why not use the same regex as IP.php? [17:25:20] Jasper_Deng: it's javascript [17:25:30] I mean, the same regex should be valid [17:26:33] Jasper_Deng: https://github.com/azatoth/twinkle/blame/master/morebits.js#L51-L66 [17:26:49] oh [17:27:36] mysterious bug [17:28:01] Jasper_Deng: it was added before WP supported IPv6 [17:28:11] https://github.com/azatoth/twinkle/commit/48e5a783b5d31643544d20530ce964a23ccd20b3 [17:28:12] this is strange then [17:28:30] "This is copied from mediaWiki.util" [17:28:47] dunno if they changed the one in utils after that [17:29:03] it sounds like it might be some hard-coding elsewhere in TW [17:29:48] could change the function to do mw.util.isIPv4Address(addr) || mw.util.isIPv6Address(addr) [17:30:12] which would hopefully get around that regex being out of date [17:31:01] I saw that util has been changed [17:32:00] Jasper_Deng: why aint there a me.util.isIPAddress()? [17:32:04] mw* [17:32:10] idk [17:32:21] * Jasper_Deng doesn't know much about MW's JS [17:33:37] Jasper_Deng: fixed/synced/done [17:33:56] now we have to wait for an admin to block an IPv6 vandal and see what happens [17:33:56] https://github.com/azatoth/twinkle/commit/093389c32aa52e8671e2b6969e4a9edc6d1eeb27 [17:34:10] many IPv6 vandals? [17:34:34] not many, on average it seems to be one or two a day [17:34:44] (although French Wikipedia gets a handful a day in comparison) [17:40:07] ok, time for breakfast for real [17:59:31] New patchset: Nikerabbit; "Rewrite storage to get rid of multiple issues" [mediawiki/extensions/InviteSignup] (master) - https://gerrit.wikimedia.org/r/67636 [18:03:27] New patchset: Nikerabbit; "Avoid backwards ordering on first export of json files" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67637 [18:13:34] New patchset: Rtdwivedi; "Separated data fetching from presentation in function load_index in ProofreadPage.body.php Will do the same for other functions also. Change-Id: I9e067185529af2d259cfbeb84c3c3db66d2ddd95" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/67632 [18:16:19] New review: MZMcBride; "I think code review evaluations (+1, +2, etc.) would be more valuable to the person who has to event..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [18:23:45] New review: Amgine; "Nonsense. Snark is always welcome. (On another hand, when one doesn't feel qualified to review the c..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [19:00:43] New patchset: Nikerabbit; "Avoid exception in ApiHardMessages" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67638 [19:44:33] Change merged: Wikinaut; [mediawiki/extensions/RSS] (master) - https://gerrit.wikimedia.org/r/67628 [20:01:23] New review: Ori.livneh; "@MZMcBride: I +1'd the change on Feb. 3rd. Between the first and fourth patchsets, I re-worked the p..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [20:10:16] Yippie, build fixed! [20:10:16] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #108: FIXED in 9 min 4 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/108/ [20:10:40] Yippie, build fixed! [20:10:41] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #90: FIXED in 9 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/90/ [20:21:15] New patchset: Jeroen De Dauw; "Updated entry point to not run stuff twice when using Composer and composer.lock" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67639 [20:21:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67639 [20:40:04] New patchset: Physikerwelt; "(Bug 49169) Draft: Check all tex commands before passing them to renderer" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67607 [20:44:46] New patchset: Nikerabbit; "Hide sidebar while using the translation tool" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67640 [20:47:26] :O [21:07:06] New patchset: Nikerabbit; "Don't include suggestions in the source language for "in other languages" section" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67641 [21:07:07] hey ^demon [21:07:27] gitblit is giving 503s [21:07:54] yeah and tests are not running and new patches are not announced in bugzilla [21:07:58] Can't even login to the host it's on [21:08:48] appropriate response :p [21:16:57] New review: TheDJ; "Just a thought, we could consider moving it wholly to a separate Special page? I mean how many ppl a..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [21:35:09] New patchset: Krinkle; "CSSJanus: Fix handling of CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [21:37:49] New review: Matmarex; "It doesn't "break" on them now; it just doesn't do the transformations." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67263 [21:39:27] New patchset: Matmarex; "CSSJanus: Fix handling of CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [21:39:52] New review: Matmarex; "-1 per above. :/ (I currently can't submit a patchset.)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67263 [23:29:17] New review: Krinkle; "Which typo is that? I don't see it. And the text you changed in the commit message ("using them work..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [23:31:32] New review: Hoo man; "Going to merge this in a few days if no further concerns are raised." [mediawiki/core] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/60200 [23:32:15] New review: Krinkle; "As for no longer breaking, last I checked, CSSJanus did touch 5-part values, but did so incorrectly,..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [23:32:36] New review: Matmarex; "You added a comma, I can't tell if it was intentional." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [23:47:50] New review: Hoo man; "Looks good and works like a charm." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67630 [23:47:59] Is Jenkins up again? [23:51:29] New review: Krinkle; "I added the comma because the sentence seemed ambiguous without it. Fixing now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [23:55:43] New patchset: Krinkle; "CSSJanus: Fix handling of CSS3 color syntaxes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263