[00:02:23] New patchset: Mwalker; "Refund Actions!" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67566 [00:03:22] New review: Brian Wolff; "When you review a page, the ajax thingy pops up with a box saying "You have marked this change as pa..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67040 [00:11:52] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #111: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/111/ [00:23:05] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #68: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/68/ [00:25:35] New patchset: Spage; "More informative warning for invalid enum value" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/67567 [01:00:26] New patchset: Mwalker; "Fixing Messages so We Don't Blow Up" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67554 [01:00:41] New patchset: Mwalker; "Actions Should be Associated with their Messages" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67555 [01:01:46] New patchset: Mwalker; "Adding Capture Message" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67557 [01:02:08] New patchset: Mwalker; "Adyen Chargeback Handling" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67564 [01:04:32] New patchset: Mwalker; "Adyen Chargeback Handling" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67564 [01:04:57] New patchset: Mwalker; "Refund Actions!" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67566 [01:06:54] New patchset: Bsitu; "(bug 49141) Notifications Productivity A/B Test" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67570 [01:07:21] New patchset: Bsitu; "(bug 49142) Notifications Productivity A/B Test" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67570 [01:08:22] Yippie, build fixed! [01:08:22] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #79: FIXED in 5 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/79/ [01:26:24] New patchset: Reedy; "Make $wgServer available for use in remote-mw-script-path" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67575 [01:27:48] Change merged: jenkins-bot; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67575 [01:30:10] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67577 [01:31:04] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67578 [01:32:15] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67577 [01:32:22] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67578 [01:38:53] New patchset: GWicke; "Fix Thai link trail regexp" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67579 [01:42:59] New patchset: Reedy; "Remove all trailing whitespace" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67580 [01:45:38] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #313: STILL FAILING in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/313/ [01:47:32] New patchset: Amire80; "(bug 35288) the message articlefeedbackv5-disable-flyover-help-location is poorly placed and not needed anyway" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/62808 [01:48:42] New patchset: Rfaulk; "mod. update git config instructions." [sartoris] (master) - https://gerrit.wikimedia.org/r/67581 [01:49:07] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/67581 [01:53:02] New patchset: Hiong3-eng5; "API: Corrections on SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [01:58:27] New review: Ori.livneh; "Cool, thanks. I still yearn for JS sprintf-like function in core." [mediawiki/extensions/EventLogging] (master) C: 2; - https://gerrit.wikimedia.org/r/67567 [01:58:45] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/67567 [02:01:08] New review: Krinkle; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) C: -1; - https://gerrit.wikimedia.org/r/67002 [02:09:15] ^demon: Who do I talk to about Jenkins? [02:09:26] <^demon> Huh? [02:11:14] My RDFa changes are going to have a new dependency for the tests. [02:14:35] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:14:39] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [02:16:02] New review: Wikinaut; "let's go with this patch set, it works fine !" [mediawiki/extensions/AJAXPoll] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67002 [02:21:11] New patchset: Reedy; "Remember kids, 'wiki' and 'wikipedia' aren't the same thing!!" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67583 [02:21:23] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67583 [02:22:09] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67584 [02:22:56] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67585 [02:23:10] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67584 [02:23:17] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67585 [02:31:35] New review: Krinkle; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:32:06] New patchset: Reedy; "Generate "$wgServer" from SiteConfiguration using wikiid (dbname)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67586 [02:37:12] New patchset: Spage; "Add campaign support" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [02:38:22] New patchset: Brian Wolff; "(DO NOT MERGE; needs I49b7d8a05) Add an lua interface to getting file metadata" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67588 [02:38:54] New review: Brian Wolff; "See related lua commit at https://gerrit.wikimedia.org/r/67588" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [02:39:08] New review: Spage; "No, do it in PHP." [mediawiki/extensions/Campaigns] (master) C: -1; - https://gerrit.wikimedia.org/r/67587 [02:41:07] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:43:48] I'm in [02:43:50] New review: Krinkle; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:44:20] Wikinaut: Can you not vote on your own commits? Also V+1 doesn't make sense as there are no unit tests [02:44:34] I assume you review your own code before pushing to gerrit ;-) [02:44:38] I always do this, it is my extension [02:44:51] Krinkle: ^^ yes, I do [02:44:55] but my +1 means that: [02:44:57] Everyone does, if not, you shouldn't be pushing to gerrit. [02:45:01] I really have inspected the code [02:45:27] inspected means: looked up, how it looks in gerrit browser [02:45:30] Aha, the famous saveArticle -> doSaveArticle, ->reallyDoSaveArticle, and not to for get reallyDoSafeArticle_internal [02:45:37] forget* [02:45:39] New patchset: Amire80; "Never underline the badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67589 [02:47:28] Krinkle: anyway, the present patchset, in my view, is such an improvement (now using Html: class) that you can't really vote against it... [02:47:57] Well, it's your extension so I suppose I have no business reviewing it anyway. [02:48:41] but any comment is/was useful, thanks [02:51:33] Krinkle: Is saveArticle -> doSaveArticle, ->reallyDoSaveArticle, and not to forget reallyDoSafeArticle_internal - really a thing? [02:51:35] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:51:41] because that's disgusting ;) [02:52:38] bawolff: It is a thing in that some older MediaWiki code ended up looking like that after 10 years of hasty iteration [02:52:57] anti-pattern naturally [02:53:17] but there's no actual class with 4 layers of reallyActuallyISeriouslyMeanToDoX() [02:53:39] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/67468 [02:59:22] Krinkle: regarding Sanitizer::decodeCharReferences( $string ); -- is this really all I need ? I mean, is no further escaping or sanitizing necessary ? The output isthe content part of Htlm::rawElement . I just wanted to be sure. [02:59:40] Wikinaut: Nooo! Escape! [02:59:43] Wikinaut: Sanitizer::decodeCharReferences decodes, not encodes. It turns those &123; back into text. [02:59:56] Then pass to Html::element, not rawElement. that takes care of the rest [03:00:10] uh, yes, of course, let me try [03:00:13] immediately [03:00:17] ;-) [03:00:37] that was the most important thing to do [03:00:45] hopefully, it works now [03:01:17] uh, i have these nested Elements. [03:01:26] bawolff: https://github.com/wikimedia/mediawiki-core/blob/REL1_19/includes/QueryPage.php#L344 reallyDoQuery [03:02:09] Krinkle: Yeah I've seen that one. I was hoping for one with 4 layers ;) [03:02:41] https://github.com/wikimedia/mediawiki-core/blob/REL1_19/includes/api/ApiResult.php#L208 setIndexedTagName and setIndexedTagName_internal [03:03:54] acking for 'reallydo' -i -Q over core gives me only calls to (many subclasses of) Querypage [03:04:09] and the only _internal left is apiResult [03:04:18] So we've gotten rid of most of 'em [03:04:32] Krinkle: I think, one of the previous patchsets was correct, using my local escapeContent() with htmlspecialchars( .... double_encode=false) [03:04:50] because I cannot use Html::element [03:04:58] Wikinaut: You can and should use Html::element [03:05:00] becuase of nested
s [03:05:14] there are nested
's inside the input you receive from ? [03:05:20] you said no html was allowed? [03:05:32] no, when I construct the output [03:05:36] ! [03:05:36] ok, you just typed an exclamation mark with no meaning in the channel, good job. If you want to see a list of all keys, check !botbrain [03:05:36] * DanielFriesen thinks we need a Html::escape for that use case. [03:05:38] Then you're doing it wrong ;-) [03:05:44] DanielFriesen: +1 [03:05:50] Krinkle: no [03:07:01] Krinkle: two days ago I posted to the mailing list [03:08:02] Krinkle: http://lists.wikimedia.org/pipermail/wikitech-l/2013-June/069792.html [03:08:44] and I think like DanielFriesen, we should have an Html::escape method or so [03:08:56] I am logging out now, sorry. I have to. [03:09:01] I wanted to do that at the same time as replacing strtr [03:09:05] call htmlspecialchars on the inner text if you need to. that's pretty much the standard function we use whenever we don't want to wrap it in an element [03:09:08] perhaps you can find a solution. [03:09:19] Krinkle: this is WHAT I was doing [03:09:20] granted, it doesn't match the logic Html::element uses, but it is good enough (even more elaborate) [03:09:26] Wikinaut_: No, most certainly not. [03:09:38] you called it with quotes and doubles and what not [03:09:44] htmlspecialchars(...... double_encode=false) [03:09:47] and not calling it with text but hybrid html entity stuff [03:09:55] I mean plain htmlspecialchars() [03:10:01] that's what Html::escape would effectively do [03:10:17] Wikinaut_: No he's saying htmlspecialchars( Sanitizer::decodeCharReferences( ... ) ) [03:10:17] the double stuff is unrelated to Html::escape, it wouldn't solve that [03:10:20] Exactly [03:10:36] DanielFriesen: ok, was also in my mind [03:11:10] so back to my own escapeContent() function ! [03:11:24] htlm..(Sanit...) [03:11:26] I just want a real Html::escape because it's really ugly to have Html.php's nice html handling with it's own escaping of everything....... and then go and plop an ugly php native function that escapes text in a completely different way. [03:11:53] DanielFriesen: let me know, if this is available, pls [03:14:30] New patchset: Mwjames; "SMW\MessageFormatter class (deprecates smwfEncodeMessages())" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [03:14:45] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [03:17:54] New patchset: Mwjames; "SMW\MessageFormatter dependency injection" [mediawiki/extensions/SemanticInternalObjects] (master) - https://gerrit.wikimedia.org/r/67590 [03:19:27] New patchset: Mwjames; "SMW\MessageFormatter dependency injection" [mediawiki/extensions/SemanticInternalObjects] (master) - https://gerrit.wikimedia.org/r/67590 [03:19:33] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [03:25:11] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [03:25:59] New review: Brian Wolff; "PS3: Make it increment expensive count first time it accesses a file. Also fix minor issue with pars..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [03:26:03] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [03:26:26] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [03:30:42] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [03:32:15] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [03:35:58] New patchset: Mwjames; "SMW\SQLStore\StatisticsCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [03:36:29] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [03:44:09] New patchset: Brian Wolff; "Add {{#filemetadata:..}} to insert file metadata on to a wiki page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [03:44:41] New review: Brian Wolff; "PS4: rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67047 [04:15:27] New patchset: Spage; "Add campaign support" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [04:17:11] New review: Spage; "No, we decided to reduce scope." [mediawiki/extensions/Campaigns] (master) C: -1; - https://gerrit.wikimedia.org/r/67587 [05:13:41] New patchset: Kaldari; "Adding optional confirmation process to Thanks workflow" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [05:17:21] New patchset: Kaldari; "Adding optional confirmation process to Thanks workflow" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/67591 [05:27:10] New patchset: Spage; "Add campaign support" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [05:28:53] Change abandoned: Spage; "Doing it in a separate extension, see Ife949daf51210d68a3328fc7b4bfef581afe80cd" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [05:44:26] New patchset: Hiong3-eng5; "API: Corrections on SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [05:59:16] New patchset: Physikerwelt; "Fix XmlTypeCheck docs. Change-Id: Ia6a394a0dd4fc74c2c2435e48104df367a6b714a" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [06:00:26] New review: Physikerwelt; "sorry" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67552 [06:13:16] New patchset: Physikerwelt; "Fix XmlTypeCheck docs. Change-Id: Ia6a394a0dd4fc74c2c2435e48104df367a6b714a" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [06:21:51] New patchset: Physikerwelt; "Fix XmlTypeCheck docs. Change-Id: Ia6a394a0dd4fc74c2c2435e48104df367a6b714a" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [06:28:21] New patchset: Spage; "Fix comment for mw.user.sessionId()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67592 [06:31:42] New review: Physikerwelt; "I think it would be better if one could include the param description from the constructor, otherwis..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [06:38:41] New review: Hiong3-eng5; "Kindly check and merge if without corrections." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [06:39:19] New patchset: Physikerwelt; "Replace SimpleXml by Mediawiki library" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [06:43:00] New review: Physikerwelt; "How can I make the dependency to" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [06:43:29] New review: Hiong3-eng5; "oops, just found a bug when part_lang_id exist but does not have any synonym." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [06:45:22] New review: Wikinaut; "hello, some persons recently objected that I too often do +2ing for extensions I maintain (which as ..." [mediawiki/extensions/AJAXPoll] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67002 [06:55:28] New patchset: Hiong3-eng5; "API: Corrections on SynonymTranslation Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [07:42:38] New review: Hashar; "ping pong" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67418 [07:42:47] Change restored: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67418 [08:03:13] Change abandoned: Aaron Schulz; "Patch no longer maintained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30431 [08:06:35] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [08:26:34] Change merged: Nikerabbit; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67579 [08:29:24] New review: Ori.livneh; "Are you sure this view is not cached? If it is, then you'd have to do something else. Perhaps resurr..." [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67587 [08:32:02] New review: Spage; "I think it's worthwhile and the doxygen syntax changes aren't too bad." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/66128 [09:04:14] New patchset: Nemo bis; "Remove unused lqt_rc CSS classes" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/67595 [09:17:54] New patchset: Nemo bis; "Typo in spl-subpages-par-class" [mediawiki/extensions/SubPageList] (master) - https://gerrit.wikimedia.org/r/67596 [10:43:35] New patchset: J; "rebuid ogg if length was not extracted" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/67599 [10:44:43] New patchset: J; "rebuild ogg if length is missing" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/67599 [10:50:48] 720 open unreviewed commits in mediawiki/.* , 555 of which from outside WMF [10:53:12] New review: Hiong3-eng5; "Kindly check and merge if without corrections, Thanks!" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [10:53:46] New patchset: MaxSem; "Fix XmlTypeCheck docs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [10:54:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67592 [10:57:23] Nemo_bis: I counted 128 unreviewed commits in mediawiki/.* [10:57:29] what's your query? [10:57:39] mine is: is:open -is:reviewed project:"^mediawiki/.*" [10:58:15] I always use the one robla suggested a long time ago https://www.mediawiki.org/wiki/Gerrit/Navigation#Gerrit_queries [10:58:37] yes, "unreviewed" was an imprecise shortcut [10:58:54] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [10:59:24] that query looks wrong -- it ends with "AND NOT label:Code-Review<=-1'" [10:59:35] which seems to me like it would pull all commits that are open and did not get a -2 [10:59:38] or -1 [10:59:43] yep [10:59:44] but that excludes +1s [11:00:29] yes, it's all open commits, just filtering out those which may be rejected but not abandoned just because the owner forgot them [11:00:55] is:reviewed counts also jenkins approvals AFAICS, I doubt it's useful https://gerrit.wikimedia.org/r/Documentation/user-search.html#status [11:00:57] and I'm not even sure that search operator works, tbh -- i think it predates the 'is:reviewed' operator [11:01:11] which search operator? [11:01:34] 'label:Code-Review<=-1', but I rescind that, since the link you just referenced mentions it. [11:01:41] I just updated it https://www.mediawiki.org/w/index.php?title=Gerrit%2FNavigation&diff=696066&oldid=666775 [11:02:00] it's the =-1 and =-2 which were deprecated, apparently [11:03:06] New patchset: Daniel Friesen; "Followup mistake in I82711cee" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67600 [11:05:24] anyways, it's not a happy figure, i agree [11:06:30] if you exclude also +1 it's 627 [11:08:09] New patchset: Daniel Friesen; "Add vendor to mwdocgen's excludes list." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67601 [11:25:29] *snickers* [11:25:53] ^_^ I /love/ how I have to include 4 \'s to represent a single \ in a regexp, lol [11:36:41] New patchset: Mwjames; "Improve code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67602 [11:38:35] New patchset: Daniel Friesen; "(bug 49232) Always quote attribute values ending in a backslash." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67603 [11:39:37] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67602 [11:48:13] New patchset: Daniel Friesen; "Followup If21705c2, Shorten remaining urls to the whatwg HTML spec." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67604 [12:32:00] New review: MaxSem; "Since git blame will not work anymore after this, we'll just blame it all on Reedy!" [mediawiki/extensions/SecurePoll] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67580 [12:32:07] Change merged: jenkins-bot; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67580 [12:45:14] New patchset: Physikerwelt; "(Bug 48952) Show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [13:04:17] New review: Martineznovo; "Patch tested on local installation and it has been fixed" [mediawiki/extensions/LiquidThreads] (master) C: 1; - https://gerrit.wikimedia.org/r/67558 [13:14:39] New patchset: Daniel Friesen; "Add a Html::escape method." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [13:31:08] New patchset: Daniel Friesen; "Kill in a blazing fire." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67606 [13:44:02] New patchset: Physikerwelt; "(Bug 49169) Draft: Check all tex commands before passing them to renderer" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67607 [13:47:11] New patchset: Daniel Friesen; "Major improvements to RDFa and tweaks to Microdata support." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67608 [14:11:05] New patchset: Mwjames; "Be more helpful and display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [14:12:07] New patchset: Mwjames; "Be more helpful and display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [14:17:43] New patchset: Mwjames; "Be more helpful and display an introductory text for predefined properties" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [14:24:18] New review: Mwjames; "I'm throwing in the towel, it is the second time within one day that Jenkins doesn't execute unit te..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67609 [14:57:16] Nemo_bis: I think it's the best to kill the revision patrolling on the bottom of the page now... the resistance and the problems are just to big [14:58:40] hoo: yep, probably better [14:58:54] I don't think you cared about that? [14:59:13] nor that killing that feature would be too hard, I hope [15:00:19] Well, first I liked having that a little (although I can see the downsides... especially on Wikidata where you (almost never) see the full page content it's dangerous) [15:00:47] But I guess there will be none or very little crying when we kill it [15:15:06] New review: Brian Wolff; "In addition to the qqq messages, you also need to add any new messages to maintenance/language/messa..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65139 [15:25:31] New review: Brian Wolff; "Hmm, I'm not sure how I feel about this. I see nothing wrong with having the extra things escaped an..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [16:22:21] New patchset: Daniel Friesen; "Deprecate many of the static SpecialVersion methods in favour of methods with context." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55507 [16:22:21] New patchset: Daniel Friesen; "Update Special:Version to output hooks registered with the new style Hooks::register as well as $wgHooks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55509 [16:26:51] New review: Daniel Friesen; "PS: Rebased, and (sorry) fixed the getCopyrightAndAuthors method in the same commit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55507 [16:28:09] New review: Daniel Friesen; "PS: Rebased and spacing fixed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55509 [16:43:52] New patchset: Daniel Friesen; "Add support for skin classes that are not prefixed with 'Skin'." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56426 [16:44:08] New review: Daniel Friesen; "PS: Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56426 [16:46:02] hoo: if/when the revision patrolling in page view gets removed from the wikis, can you make sure to query the DB on all wikis using RCPatrol to see if the percentage of patrolled edits (over non-unpatrolled edits if possible) increased in the period? [16:46:45] ewk, mh [16:46:50] it would also be nice to compare those stats to the 2005 ones Tim made when introducing the feature (an interesting discussion on en.wiki) [16:46:59] ouh? [16:47:08] I mean, if you can't I need to find someone else :) [16:47:09] ock? [16:47:19] okfn? [16:47:24] the few days it was active now might not be enough for covering statistics [16:47:35] better than nothing.. [16:47:41] Probably [16:47:52] Don't you have a TS/ labs account? [16:48:58] yes but I have almost 0 mastering of SQL queries [16:50:08] You should... complicated (nested) SQL queries can be fun to write [16:50:25] New patchset: Daniel Friesen; "Drop support for old skins that don't use head element." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [16:50:41] New review: Daniel Friesen; "PS: Rebased before making changes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [16:51:31] DanielFriesen: Why do you rebase beforehand? IMO that's not much better than rebase + changes [16:51:59] (I can see that's nicer to handle, of course) [16:52:37] yes, there are many languages I should learn [16:53:16] Same here :D [16:54:40] New patchset: Daniel Friesen; "Drop support for old skins that don't use head element." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [18:09:42] New patchset: Daniel Friesen; "Improve language handling of page titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [18:10:09] New review: Daniel Friesen; "PS: Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [18:19:20] New patchset: Bharaththiruveedula; "Added 'Developers' link to footer link" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [18:20:04] New patchset: Daniel Friesen; "Improve language handling of page titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [18:21:04] New patchset: Brian Wolff; "Added 'Developers' link to footer link" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [18:24:00] New review: Nikerabbit; "Besides, all PHP developers are (I hope) familiar with htmlspecialchars, but not Html::escape." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [18:30:10] New review: Brian Wolff; "As I mentioned in irc, when you're adding messages you also have to add docs to languages/messages/m..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67615 [18:31:05] New review: Matmarex; "Slboat, this is now reported as bug 49228." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56881 [18:37:57] New review: MaxSem; "Hi and thank you for your contributions. In addition to Brian's remarks:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67615 [18:38:08] New patchset: MarkAHershberger; "Move extension generation so that diffs work better" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/56883 [18:39:50] New review: Brian Wolff; "I'm not sure about the 'non-configurable' on wiki part. For example, for example, on wikitech.wikime..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67615 [19:04:18] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67582 [19:08:36] New patchset: Jeroen De Dauw; "Add autoload section to composer.json" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67617 [19:09:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67617 [19:18:47] New patchset: Jeroen De Dauw; "Put version constant definition above composer autoload inclusion to avoid double loading" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67618 [19:19:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67618 [19:21:13] New patchset: Jeroen De Dauw; "Remove obsolete check" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67619 [19:21:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67619 [19:28:07] Change merged: Brian Wolff; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67604 [19:39:33] New patchset: Jeroen De Dauw; "Added composer.json" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67620 [19:43:41] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [19:48:59] New patchset: Jeroen De Dauw; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [19:50:07] New review: Jeroen De Dauw; "Resolved conflict" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [19:52:04] New review: Matmarex; "> Although there's no issues with the CSS here I'm not sure if it's an improvement - this makes the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [19:52:55] New review: Jeroen De Dauw; "1) SMW\Test\CacheHandlerTest::testNewFromId" [mediawiki/extensions/SemanticMediaWiki] (master); V: -1 - https://gerrit.wikimedia.org/r/61171 [19:53:21] New review: Parent5446; "Agreed with both Brian and Nikerabbit. htmlspecialchars() has the same performance as str_replace, a..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67605 [19:54:11] New patchset: Jeroen De Dauw; "Added composer.json" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67620 [19:56:27] New patchset: Parent5446; "Always quote attribute values ending in a backslash." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67603 [19:59:53] New review: Brian Wolff; "note, htmlspecialchars does not encode single quote by default (The source of many a security bug)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [20:00:12] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [20:00:45] New review: Parent5446; "Ah yes. Almost forgot (I was just reading straight off the PHP docs.)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67605 [20:02:17] New patchset: Matmarex; "Change how Vector's tabs behave on small resolutions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [20:04:23] New review: Matmarex; "What Tyler said." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67605 [20:24:43] New patchset: Jeroen De Dauw; "Update loading code to work with Composer" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67621 [20:30:54] New patchset: Jeroen De Dauw; "Do not fail when not loaded from global scope" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67622 [20:31:31] New review: Matmarex; "Here's an IE7 screenshot, courtesy of Browsershots: http://i.imgur.com/lb3I8I0.png . Looks good enough." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [20:40:19] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67622 [20:51:09] Yippie, build fixed! [20:51:10] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #112: FIXED in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/112/ [21:00:52] New review: Parent5446; "@Daniel - Yep on the whole API thing. I figured it should be in a separate patchset (and I don't hav..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [21:01:12] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [21:10:55] New review: Jeroen De Dauw; "Nischayn22: haha, MWJames so hijacked your commit here :) Better add tests immediately next time :)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [21:11:02] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [21:14:03] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [21:17:11] New patchset: Jeroen De Dauw; "Updated documentation files" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67623 [21:17:21] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67623 [21:30:53] New review: Hoo man; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67040 [21:54:09] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #80: FAILURE in 5 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/80/ [22:13:15] mwalker|away: fyi https://meta.wikimedia.org/w/index.php?diff=5551164&oldid=5546810 Please test banners before pushing them into production [22:14:34] hoo: You must be new around here? [22:14:49] Testing before production... yes, sorry [22:15:29] Testing in production of course is way better... the chance of catching all bugs is way higher AND you make users recognize your change [22:15:46] ;) [22:38:07] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [23:18:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #107: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/107/ [23:18:36] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #89: FAILURE in 17 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/89/ [23:22:30] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67468