[00:00:20] New patchset: Parent5446; "Add referer and origin check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [00:06:13] New review: Mwalker; "Did you load PS5? I did have everything in the first column in an earlier patchset; but now there is..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [00:09:58] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65418 [00:20:06] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67375 [00:26:45] New review: Brian Wolff; "Thanks for Looking it over. I've responded to your comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60858 [00:28:47] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67166 [00:37:02] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67166 [00:37:59] New review: Krinkle; "Needs a better commit summary as this commit is doing way more than implement a method "sprintfDate"..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67166 [00:38:46] New patchset: Tim Starling; "Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67387 [00:39:44] New review: Krinkle; "Also a bug report and/or elaboration in commit message as to why this is needed in mw.language would..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67166 [00:40:39] New patchset: Catrope; "Update VisualEditor to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67388 [00:43:23] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #76: FAILURE in 5 min 39 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/76/ [00:44:37] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67388 [00:45:45] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #63: FAILURE in 5 min 49 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/63/ [00:52:49] New patchset: Brian Wolff; "Make generating Parser test class names more robust" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [00:54:18] New review: Brian Wolff; "Hashar: Ok, sounds reasonable. I did a more "proper" job at fixing the issue in PS2" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [00:57:31] New review: Brian Wolff; "Perhaps. Is that an option? (Historically I've needed better justification then "a minor feature wil..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [01:01:12] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [01:05:09] TimStarling: I hope there isn't some pathological new page handling extension that breaks with https://gerrit.wikimedia.org/r/#/c/67387/1 [01:05:18] seems reasonable [01:05:31] core callers are fine [01:08:19] hmm, it should fall back if $id is passed in, shouldn't it? [01:09:52] not sure why page conditions would be required in that case [01:10:55] gah, right, it should if $id is passed [01:11:23] * Aaron|home was busy looking at extensions [01:11:37] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [01:12:28] the ones we use seem fine [01:17:01] New review: Brian Wolff; "PS11: Clarify the $descending thing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [01:29:42] New review: Brian Wolff; "responded inline." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [01:32:27] If I want to use/reuse code from a script that is currently designed to be standalone via a cli call, is there a way to use it in another script, but prevent the code it normally runs straight away as it's in global scope? [01:32:37] * Reedy re-reads that to check if it actually makes any sense [01:34:39] Using include the file will be executed.. [01:35:06] I should probably go to bed [01:39:14] Reedy: geodata does something ugly like that [01:39:17] lol [01:39:27] a job runs by using execute() of a maintenance script [01:39:35] Seemingly just easier to execute the file and trap the output... [01:39:54] wfWikiShellCmd() or whatever [01:40:22] One ways to to move the code not directly executed to another file. Makes the "standalone" script a bit more annoying as you've then got to move 2 files around [01:45:07] New review: Krinkle; "I assume you meant declaration not deceleration. MediaWiki is moving fast but it isn't slowing down ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67095 [01:48:27] * Aaron|home almost though no one would make a snarky comment there for a while [02:01:34] New review: Aaron Schulz; "Actually come to think of it, I can just kill the other profiling layer in filebackend anyway" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745 [02:19:29] New review: Michael Shavlovsky; "The job queue need to be synchronized. I am not sure how to fix current job queue, so I implemented ..." [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/25903 [02:23:04] lol [02:23:07] * bawolff hangs head [02:24:01] New patchset: Mwjames; "(Bug 33181) Special:Concepts to list available concepts" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [02:25:45] bawolff: I thought you might want to know that I highlighted Wikisource in my chat today in the all-hands meeting [02:26:32] https://meta.wikimedia.org/wiki/Metrics_and_activities_meetings/2013-06-06 http://youtu.be/UoCEj5AOrFA?t=51m41s [02:26:33] sumanah: Yay sister projects [02:27:22] * bawolff notes that he is a wikinews person though, and hasn't ever really touched wikisource [02:28:06] bawolff: people touch wikisource? *runs* [02:28:29] bawolff: argrghhhh I'm sorry for misremembering [02:33:53] New patchset: Mwjames; "(Bug 33181) Special:Concepts to list available concepts" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [02:40:25] http://cl.ly/image/423K2B1p1M2Q [02:40:59] New review: Aaron Schulz; "As Tim noted, this should happen only when $id is not set." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67387 [02:45:47] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:54:29] New review: Rasel160; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [03:22:45] New review: Pastakhov; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/34976 [03:52:26] New review: Tim Starling; "Another way to do it would be to chain the references:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745 [03:56:38] TimStarling: I was thinking about chaining, though not the way you had it (which I kind of like) [03:56:57] it would be an extra function call though [04:30:48] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [04:38:24] New patchset: Hiong3-eng5; "API: modified Express and Define Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [04:40:38] New review: Hiong3-eng5; "I hope this is it!" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [04:56:03] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [04:57:15] New review: Santhosh; "Niklas, that issue is addressed in Ibf076e6049e87e1398c87d2a264343f32eaddf28" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67053 [05:11:51] New patchset: Aaron Schulz; "Made ProfileSection support chaining for nested profiling." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61745 [05:12:59] TimStarling: hmm, seems kind of cute [05:13:21] * Aaron|home tested with trace profiler [05:17:07] yes, very cute [05:17:59] but not so cute as to trip my anti-cuteness detectors [05:19:00] that subprofile method was a nice attempt, but you didn't quite manage to make the calling code simpler, did you? [05:20:22] how about: [05:20:29] function subprofile( $name ) { [05:20:53] $prev = new ProfileSection( $this->name ); [05:21:16] $prev->prev = $this->prev; [05:21:23] $this->prev = $prev; [05:21:25] } [05:22:02] well it collapses the in/out calls into one, without much fear of mistakes, so it should be simpler [05:22:49] sanity check: are we having a discussion about how best to make some newbie PHP programmer's brain explode? [05:23:05] or is this all just fine? ;) [05:23:07] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [05:23:24] I mean if I want 1 parent and X nested calls, there will be like X+1 calls minimum (unless the first was collapsed, but that would look less simple) [05:23:59] subprofile() has those calls plus that $sectionL1 = null; assignment [05:24:16] that's the only extra thing [05:24:16] missed this line: [05:24:22] $this->name = $name; [05:24:50] basically I am trying to avoid swapping the object references by swapping every member variable instead [05:26:38] * Aaron|home isn't sure how that function would work [05:27:00] if it starts with a new ProfileSection, something will be mismatched [05:27:37] well, or double counted [05:28:13] hmm, you are right [05:28:26] [22:23] TimStarling or is this all just fine? [05:28:28] I guess not [05:30:17] well, the aim is to get $this->prev->name to hold the first name, and $this->name to hold the second, so that the profile sections will be closed in the right order [05:30:27] which I managed [05:32:38] how about this: http://paste.tstarling.com/p/KyxgZD.html [05:32:47] oh, sorry [05:33:13] this: http://paste.tstarling.com/p/hbXwUe.html [05:33:18] hmm, I think I see were you are going [05:33:19] there was a constructor patch also to avoid double-counting [05:35:53] $this->enabled = true; won't get set [05:36:17] oh, wait [05:36:22] it was already set [05:36:33] maybe I missed $this->prev->enabled [05:36:46] but you can set that to $this->enabled [05:37:00] it was missed :) [05:37:15] so there would be no profile out [05:43:02] New review: FastLizard4; "For now, I'm going to hold off on review/merge until I can find out where we are in terms of Transla..." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/66884 [05:46:01] TimStarling: so how does one close the previous subprofile? [05:47:20] you mean without letting the object go out of scope? [05:47:41] Profiling error: in(hello_profiling-section-b), out(hello_profiling-section-a)0.000210 -0.9 < hello_profiling-section-a [05:48:02] hrm [05:49:39] New patchset: Physikerwelt; "(Bug 48952) Show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [05:50:15] New review: Physikerwelt; "Thanks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [05:54:25] the case that I had subprofile() was when a function is split into N profiling regions, maybe I should have called that childprofile() [05:55:00] a lot MW code has gaps between the regions though... [06:04:47] gah, forgot that $name check [06:09:25] TimStarling: so you'd have unset() calls sprinked into callers then right? [06:19:29] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [06:22:42] Aaron|home: maybe [06:47:46] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [06:48:36] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [06:50:55] New patchset: Santhosh; "Avoid duplicate language buttons in input settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67244 [07:12:32] New review: Wikinaut; "I am using the following self-built method in one of my extensions:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [07:14:41] New review: Parent5446; "@Wikinaut - LoginForm::setLoginToken() stores the login token in $_SESSION. The idea here is to avoi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [07:17:03] New review: Kipcool; "This is it! Well done :)" [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67092 [07:17:03] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [07:24:03] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67398 [07:28:54] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67234 [07:30:38] New patchset: Nikerabbit; "Use smooth scrolling for the windows when not in viewport" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67058 [07:32:48] New patchset: Nikerabbit; "Update button css from Agora" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67248 [07:47:52] New review: Nikerabbit; "Meh, what's the reason we cannot do this on the BagOStuff level?" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [07:53:18] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67332 [07:54:56] New patchset: Nikerabbit; "Fix: ULS popup moves to sidebar if opened from ime menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67074 [07:58:08] New review: Nikerabbit; "Trying once more..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67049 [07:58:36] meh [07:58:54] CI not working for two days is horrible [07:59:52] change TZ for your counting and it's only 1 :p [08:01:33] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67049 [08:02:52] New review: Wikinaut; "@Parent" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [08:03:47] New review: Wikinaut; "correction:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [08:27:12] New patchset: J; "Optional SVG mode with PNG fallback" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [08:28:41] Change abandoned: J; "https://gerrit.wikimedia.org/r/#/c/62243/3 includes the changes from this patch" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63725 [08:32:14] anyone around to fix CI? [08:50:55] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [09:09:15] New patchset: Daniel Friesen; "Support installing PHPUnit using composer." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66395 [09:09:59] New review: Daniel Friesen; "PS: Rebased" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/66395 [09:27:59] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [09:38:14] New patchset: Mwjames; "Subobject clean-up work in constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [09:45:00] andre__: hashar is on vacation afaik [09:45:22] uh, true. I remember some email. [09:51:12] New patchset: Matmarex; "Remove Wikimedia-specific hack in ParserOutput" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61072 [09:51:38] New review: Matmarex; "This is safe to be merged now. Someone do it, pretty please?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61072 [09:51:47] New patchset: Matmarex; "Remove all uses of obsolete .editsection class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [09:51:54] New review: Matmarex; "This is safe to be merged now. Someone do it, pretty please?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61075 [09:54:50] MatmaRex: nothing is being merged at the moment [09:56:18] Nikerabbit: yay. i saw it in the scrollback [09:57:46] New patchset: Matmarex; "Ensure
and
have different computed font size" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67401 [10:06:02] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:09:19] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:10:13] New review: Matmarex; "Adjusted the commit message to make it clearer this is a complete rewrite. Next patchset will be a m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:13:38] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:20:55] New patchset: Matmarex; "AJAXify watchlist editor" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63274 [10:21:14] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63274 [10:22:07] dontcha love this when jenkins breaks just when you have lots of commits to submit. [10:32:41] MatmaRex: yep, especially weekend approaches soon and deployment is next monday [11:14:22] New review: Matmarex; "Yeah… turns out not only one element can have" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [11:14:51] New patchset: Matmarex; "jquery.makeCollapsible: cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [12:41:42] New patchset: Reedy; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67410 [12:42:31] New patchset: Reedy; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67411 [12:42:49] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67410 [12:42:51] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67411 [12:45:49] New review: Zfilipin; "This commit was not updated in a month. Indrani, do you plan to work on this?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62968 [12:46:26] New review: Zfilipin; "Karim, do you plan to continue working on this, or should this commit be abandoned?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62231 [12:54:56] New review: Zfilipin; "Karim, do you plan to work on this commit, or should it be abandoned?" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/62223 [12:55:54] New patchset: Zfilipin; "Scenario: The cog icon is visible in the sidebar on an article" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [13:03:59] New review: Zfilipin; "Great work on this commit! :) (Apologies for the late review.)" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63137 [13:03:59] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [13:04:43] Change abandoned: Alvaro Lopez Tijeras; "se abandona" [sandbox] (master) - https://gerrit.wikimedia.org/r/67260 [13:05:13] Change abandoned: Alvaro Lopez Tijeras; "Se abandona" [sandbox] (master) - https://gerrit.wikimedia.org/r/67238 [13:17:08] New patchset: Physikerwelt; "Demo: getSecure TeX see MathSearch" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67412 [13:18:23] New review: Hashar; "recheck" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [13:18:43] New patchset: Physikerwelt; "show secured tex in specialpage mathdebug" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/67414 [13:22:04] New patchset: Hashar; "benchmarks: README file having run recommendations" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66066 [13:22:45] Change restored: Alvaro Lopez Tijeras; "Se restaura" [sandbox] (master) - https://gerrit.wikimedia.org/r/67260 [13:24:41] Change restored: Alvaro Lopez Tijeras; "Se restaura" [sandbox] (master) - https://gerrit.wikimedia.org/r/67238 [13:41:29] New patchset: Reedy; "Initial version of script to automatically upload changelogs to mw.org" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67416 [13:42:53] New patchset: Reedy; "Initial version of script to automatically upload changelogs to mw.org" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67416 [13:43:35] greg-g: ^^ Present for you https://gerrit.wikimedia.org/r/#/c/67416 [13:44:55] hashar: sorry! [13:45:10] that's life [13:45:16] <^demon> hashar: I restarted zuul for you. [13:45:47] hashar: I was hoping there is a backup for you [13:47:25] nice [13:48:18] not sure whether it fixed it [13:48:45] <^demon> Not sure yet. [13:48:48] [21:06:41] Ryan_Lane: Do you know anything about Zuul? It's dead, all CI people are gone and following the instructions re restarting the service when these symptoms occur didn't help [13:48:55] from yesterday in -tech, time is bst [13:50:17] will connect in a few minutes. almost at home. [13:50:59] <^demon> ssh gerrit.wikimedia.org gerrit stream-events is showing me nothing :\ [13:51:27] jenkins is on holiday? [13:51:44] <^demon> I think gerrit is. [13:51:55] :( [13:52:37] <^demon> Gerrit queue is backed up. [13:53:08] <^demon> http://p.defau.lt/?F7iyytfj0uHx6WaYZvVvMg [13:54:03] that happened last week [13:54:04] same time [13:54:39] It's friday, friday... [13:55:15] <^demon> Gotta break down on friday. [13:55:43] gonna make everyone work on the weekend, baby [13:56:23] that meme isn't going to die easily, is it? [13:56:33] ug [13:57:44] <^demon> Ok, gerrit's up and queue's catching up. Pretty sure I know what happened. [13:58:14] <^demon> stream-events seems dandy [13:58:29] <^demon> Zuul log looks happy [13:59:10] \o/ [13:59:11] yeahhh laptop [13:59:15] ^demon: if Gerrit sends its events to zuul, then that is zuul not being able to talk with Jenkins [13:59:38] I will one day have to setup a serve monitoring for the whole setup [14:00:52] <^demon> hashar: Yes, let's do that together. [14:00:56] <^demon> It was gerrit's fault this time. [14:01:00] ahh [14:01:34] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67418 [14:02:07] ^demon: have yourestarted gerrit ? [14:02:11] <^demon> Yeah I did. [14:02:21] it happened last week I think [14:02:25] asher had to restart Gerrit [14:02:34] I think thestream-events was not more sending anything [14:02:40] <^demon> Queue was overloaded. [14:02:46] in Gerrit? [14:02:51] <^demon> Yeah. Replication was failing, so queue got borked. [14:02:55] ahhh [14:07:57] New patchset: Karun; "Bug 14931 - changed to use default character set of utf8" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67422 [14:09:52] Change abandoned: Hashar; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67418 [14:11:16] New patchset: Alvaro Lopez Tijeras; "Add multiply operation." [sandbox] (master) - https://gerrit.wikimedia.org/r/67238 [14:11:20] New patchset: Njw; "Release v1.0" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67423 [14:11:28] why do people send me emails in vacations :D [14:11:42] I got 136 new e-mail over the last 24 hours [14:13:11] ^demon: I have closed the bug :)D [14:14:05] New review: Alvaro Lopez Tijeras; "It looks good." [sandbox] (master) C: 2; - https://gerrit.wikimedia.org/r/67260 [14:14:13] ^demon: for monitoring, I was thinking about monitoring the full stack. Like having a script that send a change, which triggers a jenkins job that would abandon the change. Then the monitoring script would check whether there is such changes are still there after X minutes. [14:14:15] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67260 [14:14:27] if there is still one, something is broken, and thus we could alarm about it [14:14:40] New patchset: Zfilipin; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [14:14:42] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/67423 [14:15:43] !log Zuul was no more triggering Jenkins jobs {{bug|49294}} . Fixed by Chad who restarted Gerrit. [14:15:56] New review: Alvaro Lopez Tijeras; "Satisfied test." [sandbox] (master); V: 2 - https://gerrit.wikimedia.org/r/67413 [14:16:20] New review: Alvaro Lopez Tijeras; "The changes are good." [sandbox] (master) C: 2; - https://gerrit.wikimedia.org/r/67413 [14:16:27] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67413 [14:16:51] <^demon> hashar: That sounds reasonable. Wanna chat about it next week when you're back? [14:17:40] New review: Alvaro Lopez Tijeras; "Pass" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67238 [14:17:53] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67238 [14:18:09] ^demon: definitely [14:18:38] <^demon> Ok. Well go back to your vacation and have a good time :) Since we know this is acting finicky, I'll keep an eye on things closely over the weekend. [14:18:54] adding myself a calendar entry to ping you about it [14:19:25] hmm [14:19:34] we could even implement the whole monitoring workflow in nagios :D [14:20:46] is it okay to start giving +2 again? [14:21:20] <^demon> Nikerabbit: Everything should be humming along now. I'll be keeping a close eye just in case. [14:21:40] thanks chad :) [14:21:43] * DanielFriesen is close to finishing the RDFa 1.1 stuff [14:21:51] heading back to the sun *grin* [14:22:22] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [14:23:18] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67049 [14:25:40] New patchset: Nikerabbit; "On show of language settings, update the panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67053 [14:25:42] Added some restrictions/fixes for Microdata too. [14:26:12] New patchset: Nikerabbit; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67057 [14:26:22] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67053 [14:26:32] New patchset: Nikerabbit; "Use smooth scrolling for the windows when not in viewport" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67058 [14:26:48] New patchset: Nikerabbit; "Fix: ULS popup moves to sidebar if opened from ime menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67074 [14:26:48] integration.wikimedia.org is using an invalid certificate? [14:27:09] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67057 [14:27:36] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67058 [14:27:57] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67074 [14:27:58] New patchset: Anomie; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [14:28:18] New patchset: Nikerabbit; "Avoid duplicate language buttons in input settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67244 [14:28:56] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [14:29:15] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67244 [14:29:41] New review: Anomie; "PS10: Rebase" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [14:33:05] New patchset: Zfilipin; "don't run VE tests for IE6/7/8 per https://bugzilla.wikimedia.org/show_bug.cgi?id=49187" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67294 [14:33:11] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67294 [14:33:50] New patchset: Jeroen De Dauw; "Update autoload and keywords in composer.json" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67426 [14:34:33] New patchset: Zfilipin; "accommodate altered page create workflow on beta" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67365 [14:39:07] New patchset: Nikerabbit; "Update button css from Agora" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67248 [14:39:26] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67248 [14:42:09] New patchset: Anomie; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [14:42:33] New review: Anomie; "PS11: Adjust "@since", other doc comments" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [14:45:26] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67426 [14:49:00] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67398 [14:50:45] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [14:53:42] New review: Physikerwelt; "Jenkins test?" [mediawiki/extensions/Math] (LaTeXML) C: 2; - https://gerrit.wikimedia.org/r/67412 [14:55:16] New patchset: Liangent; "New function Language::getParentLanguage()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67399 [14:57:01] New review: Reedy; "recheck" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67412 [14:58:29] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67365 [15:14:44] New patchset: Physikerwelt; "Demo: getSecure TeX see MathSearch" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67412 [15:22:16] Reedy: interesting! is botclasses.php a known thing? [15:22:46] Sort of [15:22:48] We have https://www.mediawiki.org/wiki/API:Client_code [15:22:54] But that isn't actually part of that list [15:23:13] https://en.wikipedia.org/wiki/Wikipedia:Creating_a_bot#Programming_languages_and_libraries [15:23:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/62663 [15:24:11] Part of that is me being lazy. Wasn't difficult to automate either ;) [15:25:15] :) [15:25:31] * greg-g was voice chatting with quim & sumana [15:25:34] * greg-g now looks at those links [15:26:52] I am planning on trying to create a script to create the roadmap page and all of the individual deployment pages too [15:26:58] As most of that is boilerplate type code [15:28:14] weeee [15:29:43] New patchset: Zfilipin; "Move initializaton of $session_id from after to before block" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67443 [15:31:03] New patchset: Physikerwelt; "Demo: getSecure TeX see MathSearch" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67412 [15:32:57] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #104: ABORTED in 9 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/104/ [15:33:06] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #37: ABORTED in 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/37/ [15:33:08] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/67412 [15:35:19] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/67414 [15:37:20] oh zeljkof and chrismcmahon: so, I forgot to double check this: given the new cycle start day (Thursday) do we need to reschedule any of the automated tests? [15:37:41] like, banging away at stuff today to pile up bug reports would be good :) [15:37:59] greg-g: I think we are fine :) [15:38:02] tests run every day [15:38:14] ok, perfect :) [15:38:41] greg-g: actually, I do want to rearrange some run times, but we're doing some other maintenance first [15:41:10] chrismcmahon: :) cool. [15:41:25] time of day is the same (11am-1pm is the window), just the day changed [15:44:23] New review: Reedy; "(1 comment)" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67416 [15:47:31] New patchset: Zfilipin; "Increase the time we wait for the link to appear" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67444 [15:50:34] New review: Jeroen De Dauw; "Neat. Including the autoloader is needed to use composer properly for other packages as well anyway :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66395 [15:50:35] New patchset: Physikerwelt; "Fix: PHP Style corrections" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67445 [15:53:36] Project _debug-free-style build #115: STILL FAILING in 25 sec: https://wmf.ci.cloudbees.com/job/_debug-free-style/115/ [15:54:38] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [15:54:40] New review: Cmcmahon; "wait for PDF to finish" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67444 [15:54:40] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67444 [15:56:39] New review: Greg Grossmeier; "(1 comment)" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67416 [15:56:44] New review: Jeroen De Dauw; "Just had a quick glance - looks good" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [15:57:44] New patchset: Reedy; "Add missing break" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/67446 [16:01:54] New patchset: Jeroen De Dauw; "Register unit tests automatically" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67449 [16:02:19] New patchset: Jeroen De Dauw; "Register unit tests automatically" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67449 [16:03:19] New patchset: Zfilipin; "Move initializaton of $session_id from after to before block" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67443 [16:06:33] New patchset: Reedy; "Fixup mixed leading whitespace" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67451 [16:22:07] New patchset: Physikerwelt; "Added Support for Farsi Digits and Scripts in LaTeX Mathematical Formulae( bug 30463 )" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/58302 [16:26:23] Yippie, build fixed! [16:26:23] Project _debug-browsertests-template build #154: FIXED in 2 min 14 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/154/ [16:26:27] New review: Physikerwelt; "I fixed a syntactical bug. However I'm not sure if the change does what it should do. " [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/58302 [16:28:48] New review: Zfilipin; "I think this can be merged in: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/154/con..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67443 [16:29:18] New patchset: Physikerwelt; "Enhancement: Allow XmlTypeCheck for strings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [16:30:10] New review: Cmcmahon; "nice to have this fixed!" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67443 [16:30:10] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67443 [16:43:26] New patchset: Zfilipin; "Make sure the link is there before trying to click it" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67461 [16:43:27] Project _debug-browsertests-template build #155: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/155/ [16:45:20] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [16:47:37] New review: Zfilipin; "Looks like links are fixed now: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/155/te..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67443 [16:49:06] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [16:49:18] New review: Mwjames; "Thanks" [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/67449 [16:50:38] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67449 [16:50:51] New patchset: Mwjames; "Subobject clean-up work in constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [16:52:00] New patchset: Mwjames; "Code coverage fine tunning after forceCoversAnnotation="true"" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67463 [16:52:27] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [16:52:28] New patchset: Mwjames; "Subobject clean-up work in constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [16:56:24] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67463 [16:56:29] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [16:58:23] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [16:59:41] New patchset: Mwjames; "Subobject clean-up work in constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [17:03:03] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67400 [17:03:42] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [17:06:02] New review: Cmcmahon; "fix for occasionally flaky test" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67461 [17:06:02] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67461 [17:06:29] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [17:10:27] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [17:11:16] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [17:11:20] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67319 [17:11:34] Reedy: https://gerrit.wikimedia.org/r/#/c/67236/ [17:14:16] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [17:23:33] New patchset: Mwjames; "(Bug 33181) Special:Concepts to list available concepts" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [17:26:01] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67396 [17:36:27] New patchset: Brian Wolff; "Make Special:MIMESearch a non-expensive special page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [17:39:57] New patchset: Aaron Schulz; "Add a script to remove deleted files from storage" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67469 [17:41:42] New review: Hoo man; "Some minor styke things... logic looks good (untested)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66365 [17:43:00] New patchset: Aaron Schulz; "Use getPrefixedDBkey() for template profile call." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67470 [17:43:27] Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67469 [17:45:42] New review: Andrew Bogott; "I absolutely cannot make this work, but I would like to make pep8 mandatory in puppet. Can someone ..." [integration/zuul-config] (master); V: -1 - https://gerrit.wikimedia.org/r/67462 [17:46:45] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [17:47:24] New review: Mwjames; "Rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [18:02:40] Change merged: Aaron Schulz; [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/67165 [18:06:33] New patchset: Umherirrender; "Show rollback link on changes list only for RC_EDIT" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66064 [18:06:47] New patchset: Physikerwelt; "Enhancement: Allow XmlTypeCheck for strings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [18:07:48] Yippie, build fixed! [18:07:49] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #73: FIXED in 6 min 12 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/73/ [18:09:41] New review: Physikerwelt; "@Hoo man: Thank you very much for your comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [18:11:32] New patchset: Cmcmahon; "add when_visible because test is slow on Sauce" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67474 [18:11:51] New patchset: Physikerwelt; "Enhancement: Allow XmlTypeCheck for strings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [18:15:02] ^demon: https://gerrit.wikimedia.org/r/#/c/67470/ [18:15:11] Yippie, build fixed! [18:15:11] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #77: FIXED in 7 min 22 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/77/ [18:15:58] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #39: STILL FAILING in 27 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/39/ [18:17:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66064 [18:18:40] ^demon: https://gerrit.wikimedia.org/r/#/c/64844/ would be nice too :) [18:18:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67470 [18:27:10] New patchset: Kaldari; "Echo: Better support for non-default skins, as well as no Javascript" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66367 [18:27:28] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [18:27:47] New review: Siebrand; "Marking as DO NOT MERGE until support for MediaWiki 1.20 in ULS will be dropped." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -2; - https://gerrit.wikimedia.org/r/67265 [18:27:54] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67398 [18:28:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [18:32:09] New review: Bsitu; "Processed most of Spage's feedback, a few left for further discussion" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [18:36:31] New patchset: Kaldari; "Echo: Better support for non-default skins, as well as no Javascript" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66367 [18:37:28] New review: Kaldari; "Thanks Matthias, I've added all of your suggestions as well." [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/66367 [18:37:40] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66367 [18:38:04] New patchset: Umherirrender; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [18:38:09] New patchset: Cmcmahon; "add when_visible to reduce false failures" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67477 [18:42:40] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67474 [18:42:56] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67477 [18:46:06] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [18:47:09] ^demon: Thank you for your weird signature, it exposed a bug in VisualEditor :) [18:47:35] <^demon> Glad I could help :p [18:47:41] New patchset: Bsitu; "Add clickthrough eventlogging to Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67147 [18:58:34] New review: CSteipp; "Pleasestand: good catch on the RL issue, that would have caused problems. I'm separately trying to c..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21986 [19:08:50] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #107: STILL FAILING in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/107/ [19:09:28] New patchset: Jeroen De Dauw; "Tweak to travis.yml" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67483 [19:18:03] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [19:21:53] New patchset: Jeroen De Dauw; "Imrpovements to the test setup [DNM]" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67486 [19:22:03] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [19:26:03] New patchset: Andrew Bogott; "Require pep8 compliance for .py scripts in puppet repo." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [19:26:45] New review: Andrew Bogott; "ok... now I think that many of those patches were fine and I was just misunderstanding the test output." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67462 [19:27:26] New patchset: Jeroen De Dauw; "Imrpovements to the test setup" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67486 [19:33:15] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [19:38:49] New review: Nikerabbit; "This commit breaks RTL keyboard icon." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67398 [19:41:01] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [19:47:40] Yippie, build fixed! [19:47:40] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #108: FIXED in 19 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/108/ [19:55:29] New review: Brian Wolff; "replied inline" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [19:56:15] <^demon> spagewmf: So, I installed gitweb in labs so we have a place to still experiment with some of the URLs we want to rewrite. [19:56:31] <^demon> I figure we can't rewrite everything, but a lot of the stuff is probably doable. [19:56:33] <^demon> http://gitweb.instance-proxy.wmflabs.org/gitweb/ [19:56:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67486 [19:56:56] Personally, as long as the basic https://gerrit.wikimedia.org/r/gitweb?p=operations/mediawiki-config.git type redirect, I don't I'd care a great deal [19:57:08] ignore parameters and just redirect unconditionally ;) [19:58:27] <^demon> So just detect the p=? and toss the rest? [19:58:33] <^demon> Enough to get people to the right place I suppose. [20:00:46] ^demon OK, do I have rights to ssh to it and fiddle with its Apache config? Or I can work on rewrite rules for my local config [20:01:07] <^demon> Well, I think Reedy has a good point. [20:04:22] New review: CSteipp; "Looks fine, and working in test for me. Thanks!" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66365 [20:07:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [20:11:07] New patchset: Jeroen De Dauw; "Fix test registration when run with MW" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67491 [20:11:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67491 [20:17:48] ori-l, around? [20:18:32] New patchset: Jeroen De Dauw; "Update standalone test config" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67495 [20:18:32] New review: Wikinaut; "@Brian:" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [20:19:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67495 [20:20:53] New patchset: Jeroen De Dauw; "Fix package name in composer file" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67496 [20:21:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67496 [20:32:43] yurik: hey [20:33:17] New patchset: Jeroen De Dauw; "Remove autload section for now from composer file" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67498 [20:33:18] hey ori-l, so i asked you this earlier but not sure it sorted out - is it possible to have the mediawiki dir OUTSIDE of vagrant dir? [20:33:39] Change merged: jenkins-bot; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/67498 [20:34:19] yurik: it's not impossible, but not (yet) especially easy, either. Let me file a bug and I'll look into it this weekend. [20:36:25] yurik: the problem is that neither NFS nor VirtualBox Shared Folders like having a host folder mounted under two different mountpoints. So if the mediawiki folder is *outside* the vagrant folder, no problem: we'd just declare it as a separate shared folder in the Vagrantfile, and the specific path would be easy to override [20:36:37] <^demon> Reedy: Ewww, https://www.mediawiki.org/w/index.php?title=Special:LinkSearch&limit=500&offset=0&target=https%3A%2F%2Fgerrit.wikimedia.org%2Fr%2Fgitweb [20:36:58] ori-l, thanks! and other q -- i remember you did a few changes to allow for overrides in various places. Would it be possible to have ALL configuration overrides in the same file? [20:37:06] but if the mediawiki folder is a subfolder of the vagrant dir, then you can't mount both ./ and ./vagrant [20:37:35] so either: 1) vagrant doesn't manage the mediawiki checkout and just asks you to configure a path -- this would probably work best for advanced users [20:37:49] configure a path == specify the path to an existing clone, I mean [20:38:22] <^demon> 1259 links from mw.org to gitweb. Who wants to help? :) [20:38:24] 2) vagrant manages the mediawiki checkout, but we push the mountpoints one level up [20:38:34] ^demon: pywikipedia does [20:38:49] err, one level down [20:39:14] or 3) we preserve the current setup but make it easy to switch to something like #1 instead. i like this best. [20:40:58] <^demon> I wonder if there's any template wizard who could help with https://www.mediawiki.org/wiki/Template:Gerrit_file [20:41:32] yurik: as for centralizing overrides: yes, I think that'd be desirable, too. puppet is the appropriate place for centralizing management of the guest configuration, but puppet can't configure the host -- the Vagrantfile does that. but I think there should be a management interface, maybe web-based, that makes these configuration overrides easy to set. [20:43:10] I'm not expressing myself well, but what I mean is that you need to bootstrap Puppet somehow, so you can't simply fold the Vagrantfile stuff into Puppet, so you need at least two configuration schemes (Vagrantfile, Puppet). But there's no reason why they couldn't be managed using a common interface or tool. [20:44:00] hmm, ok, makes sense :) [20:44:13] and i don't think we should have an elaborate mgmt interface [20:44:20] that's an overkill for devs [20:45:23] ^demon: Is there a mass find an replace type exercise needed? [20:45:23] !log Restarting pybal on lvs3 for real this time [20:45:43] <^demon> Reedy: No, I'm doing stuff in Template: ns first. [20:45:52] yurik: how about a single JSON or CSV file (with columns "key" and "value) that both Puppet and Vagrantfile parse for the values relevant to them? (I am proposing CSV because Puppet has built-in support for reading / parsing it) [20:45:57] <^demon> {{Gerrit File}} needs a template wizard. [20:46:26] anomie maybe? [20:46:41] me maybe what? [20:46:58] Chad needs some template voodoo help [20:47:20] Convert it to lua! [20:48:14] ^demon: What do we need it to do? [20:48:36] ori-l, as long as it is tab or space separated, commas are evil :) [20:49:01] <^demon> anomie: Not use gitweb anymore, point to gitblit [20:49:53] yurik: ok, noted :) [20:51:11] ori-l, also, as for the cloning, i guess it could be an override like that too [20:51:39] it is needed, as i would want multiple machines - one for dev, one for testing [20:51:47] and it would be better to share common repo [20:51:52] * anomie will look at the template, later [20:52:10] yurik: yes, agreed -- this has been annoying me too [20:52:30] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #109: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/109/ [20:52:47] testing i will make a big machine, with its own UI & browser(s) [21:02:20] New review: Bsitu; "Looks good, some minor nitpicks" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63076 [21:02:53] New review: Brian Wolff; "Gerrit is a usability trainwreck..." [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [21:03:19] <^demon> Whee, down to 1091. [21:05:17] <^demon> Reedy: Actually, there might be some mass replacing needed. There's a ton of extension pages that link to READ [21:05:45] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [21:09:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66395 [21:20:58] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67468 [21:29:22] New patchset: Reedy; "Fix options" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67511 [21:30:03] New patchset: Jeroen De Dauw; "Fix breakage due to changes in base class in core" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66025 [21:30:16] New patchset: Jeroen De Dauw; "Fixed phantom log entries for "course updates" that havent happened" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66032 [21:30:20] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67511 [21:30:31] New patchset: Reedy; "Prevent warning when importing jump config (no questions)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67268 [21:31:26] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [21:33:08] New review: Parent5446; "@CSteipp - So the one thing I'm against is doing some sort of divided plan where some users are chec..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [21:33:35] New patchset: Reedy; "Prevent warning when importing jump config (no questions)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67268 [21:34:41] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67268 [21:38:16] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [21:39:43] New patchset: Ronengi; "Show a warning when deleting a page to which there are links" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65581 [21:42:34] New patchset: Mwalker; "Ack! Function Arguments in Wrong Order" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67518 [21:47:21] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67168 [21:51:07] New patchset: Reedy; "Update EducationProgram to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67521 [21:52:55] New patchset: Reedy; "Update EducationProgram to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67523 [21:54:40] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67521 [21:54:53] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67523 [21:58:44] New review: Katie Horn; "Urf." [wikimedia/fundraising/PaymentsListeners] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67518 [21:58:44] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67518 [21:59:14] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #78: FAILURE in 5 min 55 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/78/ [21:59:27] Yippie, build fixed! [21:59:27] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #66: FIXED in 5 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/66/ [22:00:39] New patchset: Mattflaschen; "Remove obsolete message include from GuidedTour.php." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67525 [22:01:34] Project browsertests-sandbox.translatewiki.net-linux-chrome build #86: FAILURE in 2 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/86/ [22:01:48] Project browsertests-sandbox.translatewiki.net-linux-firefox build #116: FAILURE in 2 min 21 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/116/ [22:04:00] New patchset: Alex Monk; "Gitweb -> Gitblit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67527 [22:04:13] New patchset: Lewis Cawte; "Update Extension Distributor messaging for 1.21 stable release." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67528 [22:05:20] New patchset: Alex Monk; "Gitweb -> Gitblit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67527 [22:05:22] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_8 build #60: FAILURE in 1 min 50 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_8/60/ [22:05:36] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_9 build #60: FAILURE in 2 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_9/60/ [22:08:30] New patchset: Demon; "Point to Gitblit since Gitweb is deprecated" [mediawiki/extensions/LocalisationUpdate] (master) - https://gerrit.wikimedia.org/r/67531 [22:12:07] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67527 [22:16:20] Project browsertests-test2.wikipedia.org-linux-chrome build #369: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/369/ [22:16:27] Project browsertests-test2.wikipedia.org-linux-firefox build #329: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/329/ [22:19:35] New patchset: Mattflaschen; "Only load tours if user JS is allowed on the page." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67535 [22:21:05] bah. typo. [22:23:22] New patchset: Anomie; "Handle bogus entries in MediaWiki:Scribunto-doc-page-name" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67538 [22:24:30] New review: Brian Wolff; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [22:27:32] New patchset: Lewis Cawte; "Update Extension Distributor messaging for 1.21 stable release." [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67528 [22:27:40] New patchset: Cmcmahon; "fix a typo" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67540 [22:27:58] New review: Cmcmahon; "fix a typo" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67540 [22:27:58] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67540 [22:28:25] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67528 [22:33:47] Project browsertests-test2.wikipedia.org-windows-internet_explorer_8 build #312: ABORTED in 2 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_8/312/ [22:33:49] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #341: ABORTED in 2 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/341/ [22:34:53] <^demon> Krenair: Ping [22:35:49] ^demon: Pong [22:35:56] <^demon> So, I pushed https://gerrit.wikimedia.org/r/#/c/67531/ to fix LocalisationUpdate to not use gitweb anymore. More urgently, that's the biggest thing still hitting it...could use a hand on a rewrite rule. [22:36:04] <^demon> I tried the following, but it didn't seem to work :\ [22:36:06] <^demon> RewriteRule ^/r/gitweb?p=mediawiki/core.git;a=blob_plain;f=languages/messages/([a-z]+).php;hb=HEAD https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fmessages%2F$1.php [R=302,NC] [22:36:37] <^demon> whoops, 301 [22:36:59] Is this rule live on a publicly accessible machine anywhere? [22:37:07] <^demon> I tried it on gerrit.wm.o :) [22:37:17] <^demon> http://p.defau.lt/?SW_8ZFaPgQGDKyKVAzdNVQ is the full rewrite block from the config [22:37:58] <^demon> eg: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob_plain;f=languages/messages/MessagesZea.php;hb=HEAD 404's [22:38:37] New review: CSteipp; "Already deployed. Thanks." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/67535 [22:38:37] Yeah I can't match that regex... [22:38:37] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67535 [22:39:19] <^demon> Blargh. Reedy? Need regex help :) [22:39:32] lols [22:39:46] <^demon> http://p.defau.lt/?SW_8ZFaPgQGDKyKVAzdNVQ is what I'm trying, but the gitweb regex ain't matching. [22:40:14] Well that ? needs to be escapes for starters [22:40:34] And some of the . [22:40:47] <^demon> The . will match . :) [22:40:50] <^demon> since it's just 1. [22:40:52] ^/r/gitweb\?p=mediawiki/core\.git;a=blob_plain;f=languages/messages/([a-z]+)\.php;hb=HEAD [22:41:18] Also a-z needs to be a-zA-Z [22:41:23] Then it seems to match for me [22:41:23] <^demon> That was the [NC] [22:41:34] <^demon> I thought [22:41:43] It gets as far as messages/ [22:41:53] New patchset: Brian Wolff; "Make Special:MIMESearch a non-expensive special page." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [22:41:55] <^demon> I can't help but thinking there's an easier way with RewriteCond that catches and blob_plain [22:42:07] <^demon> s/and// [22:42:11] Yeah that should be okay [22:42:20] I use http://gskinner.com/RegExr/ to test regexes [22:42:42] '^/r/gitweb\?p=mediawiki/core.git;a=blob_plain;f=languages/messages/([a-z]+).php;hb=HEAD' is matching '/r/gitweb?p=mediawiki/core.git;a=blob_plain;f=languages/messages/MessagesEn.php;hb=HEAD' if I turn on ignoreCase ([NC] in apache I think) [22:43:17] the . doesn't actually need to be escaped but it matches any character otherwise [22:44:06] ^/r/gitweb\?p=mediawiki/core\.git;a=blob_plain;f=languages\/messages\/([a-zA-Z]+)\.php;hb=HEAD [22:44:11] Matches /r/gitweb?p=mediawiki/core.git;a=blob_plain;f=languages/messages/MessagesZea.php;hb=HEAD [22:44:41] But not https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob_plain;f=languages/messages/MessagesZea.php;hb=HEAD as /r/ isn't the start of the string [22:45:09] I don't think https://gerrit.wikimedia.org is included in the check... [22:46:10] RewriteRule ^/r/gitweb\?p=mediawiki/core.git;a=blob_plain;f=languages\/messages\/([a-z]+)\.php;hb=HEAD$ https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fmessages%2F$1.php [R=301,NC] [22:46:43] Missing $ at the end of the regex [22:46:57] New review: Brian Wolff; "PS2: Per Parent." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67468 [22:50:20] <^demon> Still 404'ing. Considering this is LU, I wonder if we can do it with RewriteCond. [22:50:27] <^demon> /r/gitweb?p=mediawiki/extensions/LocalisationUpdate.git;a=blob_plain;f=LocalisationUpdate.i18n.php;hb=HEAD [22:50:31] <^demon> Is showing up now [22:53:33] New patchset: Jeroen De Dauw; "Fixed exception" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/66924 [22:53:51] New patchset: Jeroen De Dauw; "Added a new parameter to table format. tableheader={left/top} where top is default." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66379 [22:54:09] Yippie, build fixed! [22:54:09] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #110: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/110/ [22:54:25] Yippie, build fixed! [22:54:25] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #67: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/67/ [22:54:42] <^demon> Heh, wonder if it's just easier to do it as a php script that gets all $_GET and handles them :p [22:54:45] New review: Jeroen De Dauw; "I suspect you are running with an out of date DataValues" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/66924 [22:56:16] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67535 [22:56:25] New patchset: Jeroen De Dauw; "Autocenter on Polygons and other shapes." [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/36700 [22:56:48] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [23:00:01] Change merged: jenkins-bot; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/67538 [23:05:14] Yippie, build fixed! [23:05:14] Project browsertests-test2.wikipedia.org-linux-chrome build #370: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/370/ [23:05:15] Yippie, build fixed! [23:05:16] Project browsertests-test2.wikipedia.org-linux-firefox build #330: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/330/ [23:12:20] <^demon> Grrrrr [23:12:22] <^demon> RewriteRule ^/r/gitweb\?p=mediawiki/core.git;a=blob_plain;f=languages/messages/([a-z_]+)\.php;hb=HEAD$ https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fmessages%2F$1.php [R=301,NC] [23:12:22] <^demon> RewriteRule ^/r/gitweb\?p=mediawiki\/extensions\/([a-z]+)\.git;a=blob_plain;f=(.+)\; https://git.wikimedia.org/raw/mediawiki%2Fextensions%2F$1.git/HEAD/languages%2Fmessages%2F$1.php [R=301,NC] [23:13:01] <^demon> The first regex *should* work [23:13:58] http://p.defau.lt/?xcW3fbhopCt6TDeLME_Igw [23:14:35] RoanKattouw: what do those two wget of gitweb URLs do? need update? [23:14:53] <^demon> I put a change into the LocalisationUpdate, need Nikerabbit or siebrand to review :) [23:14:58] Nemo_bis: I have no idea, that's all gwicke [23:15:05] ^demon: yes I saw that one [23:15:12] RoanKattouw: ok thanks [23:15:29] <^demon> I hate mod_rewrite [23:16:02] <^demon> More precisely, I hate gitweb urls for being so ugly and hard to rewrite. [23:16:14] Nemo_bis: that is old / dead code, we can remove it I think [23:19:55] <^demon> ascaocacasoc8aua98 [23:20:16] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #342: STILL FAILING in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/342/ [23:22:21] ^demon: on the bright side, maybe it will be easier to update old SVN URLs on our wikis to point to gitblit? [23:22:22] gwicke: ok thanks [23:23:31] New patchset: Nemo bis; "Always try to patrol the page before the revision" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67040 [23:24:45] <^demon> Nemo_bis: I wasn't planning on updating svn urls...svn is going to continue to exist in read-only mode. [23:24:57] <^demon> Well, we can update ones worth updating. But no need to mass-rewrite them. [23:25:00] ^demon: sure, I didn't mean you, but bot owners or whatever [23:25:15] wikignomes and update-frenzies [23:25:45] <^demon> Grrrrr. [23:25:46] <^demon> RewriteRule ^/r/gitweb\?p=mediawiki/core\.git;a=blob_plain;f=languages/messages/([a-z_]+)\.php;hb=HEAD https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fmessages%2F$1.php [R=301,NC] [23:25:52] <^demon> Current attempt, not working. [23:27:36] <^demon> I need help :( [23:27:55] RoanKattouw: did you just say an infinite loop is a tiny issue? [23:28:05] Yup [23:28:07] * AaronSchulz always overhears random portions of things [23:28:07] :) [23:28:16] without any context [23:28:20] * ^demon jumps around in front of AaronSchulz and RoanKattouw [23:28:26] He did this.foo() intending to call the parent's implementation [23:28:31] But that's not how you do that in JS [23:28:39] So instead it's unconditional infinite recursion [23:28:41] ^demon: try again mentioning infinite loops [23:28:42] heh [23:29:33] New patchset: Mattflaschen; "Fix XmlTypeCheck docs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67552 [23:32:23] * ^demon pouts [23:34:25] sorry, I tried but I don't see anything wrong in there, my rewriting skills are surely worse than yours :[ [23:35:09] Change merged: Demon; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/67194 [23:37:19] New patchset: Mwalker; "Fixing Messages so We Don't Blow Up" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67554 [23:37:26] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63818 [23:38:07] New review: Demon; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67236 [23:38:47] New patchset: Mwalker; "Actions Should be Associated with their Messages" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67555 [23:39:58] New patchset: Mwalker; "Adding Capture Message" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67557 [23:40:30] New patchset: Alex Monk; "Don't record changes to subjects if there's no real change" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/67558 [23:40:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64534 [23:41:11] ^demon, where's gerrit notification bot? :/ [23:41:25] <^demon> irc notifs? [23:41:31] bz [23:41:37] <^demon> Oh, upstream :) [23:41:52] <^demon> Repo's called plugins/hooks-bugzilla [23:41:54] no [23:42:11] I uploaded https://gerrit.wikimedia.org/r/#/c/67558/ [23:42:16] But it didn't report this at https://gerrit.wikimedia.org/r/#/c/67558/ [23:42:20] I mean at https://bugzilla.wikimedia.org/show_bug.cgi?id=49311 [23:42:47] <^demon> It broke earlier today [23:46:12] New patchset: Ori.livneh; "Initial commit, adding .gitreview" [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67562 [23:46:31] New patchset: Physikerwelt; "Replace SimpleXml by Mediawiki library" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67563 [23:46:36] Change merged: Ori.livneh; [mediawiki/extensions/Campaigns] (master) - https://gerrit.wikimedia.org/r/67562 [23:53:19] <^demon> AaronSchulz: I reviewed some of your changes, help me with mod_rewrite :) [23:54:35] <^demon> Blah, I'm gonna get dinner...too hungry to figure this out [23:57:24] New patchset: Mwalker; "Adyen Chargeback Handling" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67564