[00:12:03] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67179 [00:14:58] New review: Spage; "Works, the unprefixed URL is sent to the client and Firefox loads the script. I didn't test it on an..." [mediawiki/extensions/ConfirmEdit] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/62186 [00:15:04] Change merged: jenkins-bot; [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/62186 [00:16:44] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67180 [00:19:48] New review: Katie Horn; "Yup: I officially authorize this. " [mediawiki/extensions/DonationInterface] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67181 [00:20:46] gwicke: that looks fine [00:21:02] New patchset: Spage; "Get Asirra captcha working on more forms" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/60366 [00:21:08] csteipp: great, thanks! [00:21:21] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/67045 [00:24:16] New review: Katie Horn; "(1 comment)" [mediawiki/extensions/DonationInterface] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67046 [00:24:17] Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/67181 [00:24:17] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/67046 [00:26:20] dr0ptp4kt: 1st Design talk at Wikipedia with IDEO & Catapult Design http://designatwikipedia.eventbrite.com/ [00:29:13] New patchset: Mwalker; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67204 [00:29:13] New patchset: Mwalker; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67205 [00:29:13] New patchset: Mwalker; "Fixing minor issues with testing code" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67206 [00:29:13] New patchset: Mwalker; "Changes for SmashPig/Adyen!" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67207 [00:29:13] New patchset: Mwalker; "Allowing the OrderID for Adyen to be Resurrected" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67208 [00:31:36] New patchset: Reedy; "Add Parsoid to the list of deployed extensions" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67142 [00:43:38] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67204 [00:43:41] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67142 [00:43:49] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67205 [00:44:13] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67206 [00:44:23] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67207 [00:44:37] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/67208 [00:50:43] Yippie, build fixed! [00:50:43] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #74: FIXED in 5 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/74/ [00:53:21] New patchset: Mwalker; "Updating DonationInterface for Adyen" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/67213 [00:53:50] Change merged: Mwalker; [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/67213 [00:58:14] Yippie, build fixed! [00:58:14] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_9 build #57: FIXED in 1 min 40 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_9/57/ [01:23:42] New review: Brian Wolff; "I'm supportive of merging this. People do manually type in special page names. This alias is no more..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/52749 [01:33:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67118 [01:41:20] TimStarling: does https://gerrit.wikimedia.org/r/#/c/66999/ look fine? [01:42:26] yes [01:42:50] I looked at this yesterday but got distracted by fantasies of what stick would be best to beat tyler over the head with and forgot to +2 it [01:44:43] New patchset: Tim Starling; "Refactored WikiPage::updateCategoryCounts() to use upsert()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66999 [01:49:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66999 [01:51:22] New patchset: Spage; ""Your domain" appearance fixes for new forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67220 [02:03:57] New patchset: Krinkle; "Re-enable mwext-Vector-jslint" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67224 [02:04:32] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/67224 [02:16:07] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/ConfirmEdit] (master) C: -1; - https://gerrit.wikimedia.org/r/60366 [02:16:21] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [02:18:34] New review: Brian Wolff; "To avoid rebasing this ten billion times, I'm just going to rebase it after the change it depends on..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [02:21:37] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [02:21:37] New patchset: Brian Wolff; "Do not allow sorting Special:Listfiles by img_name when filtering by username" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [02:24:00] New review: Brian Wolff; "PS9: Anomie's comments" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [02:26:38] How is it that https://gerrit.wikimedia.org/r/#/c/67002/ starts at patch set 4? [02:32:00] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [02:37:12] hi, what's the proper way to do a redirect from onBeforePageDisplay hook? [02:37:41] $out->redirect( $target, 'code' ), $out->output(), return false ? [02:46:15] New review: Brian Wolff; "I gave it a very quick look over (not a full review). The biggest issue is using $wgContLang->normal..." [mediawiki/extensions/AJAXPoll] (master) C: -1; - https://gerrit.wikimedia.org/r/67002 [02:49:20] New patchset: Mwjames; "Use @covers annotation to allow forceCoversAnnotation="true"" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67225 [02:50:01] New review: Brian Wolff; "In regards to your comment above with escaping $lines - That depends on what type of content it is. ..." [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [02:52:15] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/67225 [03:22:50] New review: PleaseStand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21986 [03:59:24] New patchset: Brian Wolff; "Have separate timeouts for upload by url ($wgCopyUpload[Async]Timeout)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67229 [03:59:43] New review: Daniel Friesen; "My position is still the same as it was on the bug. I don't like the cache-by-ip edit token. I'd sti..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21986 [04:17:12] New patchset: Tim Starling; "Remove template parse operation on every page view" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67230 [04:21:11] New review: Brian Wolff; "Perhaps, but is it really worth the extra effort? (especially when you take into account some extens..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [04:22:46] New review: Tim Starling; "I will merge this and deploy it very soon if there are no objections." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67230 [04:23:19] TimStarling: regarding ^ [04:23:44] If I read the code correctly, and that bit is for parsing wikitext and templates [04:24:05] yes [04:24:17] no tour currently running must have that functionality [04:24:30] so no problem to remove until we figure out a more performant way of addressing it [04:24:57] if there was another tour using it, that template would have been 45% instead of 90% of all fetches [04:25:10] well, 47.5 or whatever [04:25:24] so it's ok to merge right now? [04:25:27] I think so [04:25:34] superm401: ? [04:25:55] Yeah, I'll merge it. [04:25:59] you can do parses on demand, or cache them [04:25:59] Cool. [04:26:14] you just can't do them in a MakeGlobalVariablesScript hook [04:26:31] not unconditionally anyway [04:26:56] it would have been more efficient if you had used {{int:...}} instead of {{mediawiki:...}} [04:27:40] also it may have been possible to do something like this in the startup module, possibly with an additional cache [04:27:49] New review: Mattflaschen; "I didn't know the performance impact was anything near there." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/67230 [04:27:57] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67230 [04:27:57] MakeGlobalVariablesScript is just for variables which change from page to page, or from user to user [04:28:55] That message was parsed enough to account for 30% of query load? [04:29:06] TimStarling, it was intentionally using content, since it's supposed to use content language. [04:29:15] I didn't realize it would be totally uncached though. [04:29:29] so you didn't test it? [04:29:48] I didn't test the performance, no. [04:29:55] in your dev setup, you should have $wgDebugDumpSql = true [04:30:07] then check the query count of new features [04:30:24] if you're adding something to every page view, even one query is usually too many [04:30:57] https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-test-wikitext-description [04:31:06] it's not necessarily possible to detect this sort of thing by benchmarking pre-deployment [04:31:17] but query count is easy to measure [04:31:48] I understand. I will bear this in mind. [04:31:48] Was it just that message causing the issue? I don't see how enough people would be parsing it for it to matter. [04:32:18] Susan: in the past we have managed to avoid unstubbing the parser at all on parser cache hits [04:32:27] that saves about 15ms or so [04:32:42] probably that is not the case at the moment since parser cache hits are really slow, in historical terms [04:32:59] Right, but I'm saying that even if parsing that page were expensive (which it doesn't seem like it would be), were a lot of en.wiki users getting the tour? [04:33:01] but it would be nice to be able to reassert that policy at some point [04:33:25] it's a hook into OutputPage, it runs on every page view [04:33:37] it wasn't conditional on any user action [04:33:44] Ah. [04:34:14] it was a known hack, but I didn't know it had that high impact. [04:34:32] there's a core issue which is that templates cause master query load [04:34:52] but it helps not to multiply the template invocation rate by 10 [04:35:30] We should probably fix https://bugzilla.wikimedia.org/show_bug.cgi?id=25349, not since the test tour is really necessary, but since it's needed in other areas too. [04:35:32] Multiplication comes from {{MediaWiki:}} instead of {{int:}}? [04:35:36] And it will be cached properly. [04:36:07] New review: Hiong3-eng5; "I made the corrections. Please see if can be merged." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [04:37:23] Susan: yes, {{MediaWiki:}} is just a template invocation, {{int:}} goes via MessageCache which is heavily optimised [04:37:29] New patchset: Hiong3-eng5; "API: modified Express and Define Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [04:38:09] Interesting. [04:38:17] The only reason for the hack to begin with though was since int didn't serve the purpose. [04:38:24] I knew about parsing on page view. Domas used to complain about that. [04:38:24] But clearly this implementation did not cut it either. [04:38:41] Back when he cared about Wikimedia performance. :-) [04:40:23] TimStarling, FYI, there's another usage of the same hack in SpecialUserlogin.php, but there it's only on loads of the signup, so the impact should be smaller. [04:40:48] Search on 25349 [04:41:50] superm401: Helplogin-url? [04:43:39] I saw Helplogin-url in the tcpdump traces, it happens about 500 times less often than Guidedtour-help-url [04:45:25] Yes, that is on the login form too (though it doesn't use any JS var hack. [04:45:34] But I meant a different one, still page-specific but using the hack: [04:45:47] createacct-imgcaptcha-help [04:46:52] Which transcludes MediaWiki:createacct-captcha-help-url [04:47:26] do you have deployment branches in GuidedTour? [04:47:56] No, we deploy that one every week. [04:48:18] And we haven't needed them so far. [04:48:23] so how am I meant to deploy this bug fix? [04:49:00] I've already checked the diff, there's loads of stuff in it [04:49:08] Can you wait until our normal window tonight? [04:49:21] If not, I'll do a hotfix branch and we can cherry-pick. [04:51:52] I wonder what would happen if I cherry-picked it locally on tin [04:52:40] it's not really urgent in terms of performance, the site's still up apparently, it'd just be nice to be able to verify the fix, in terms of workflow [04:53:13] I'll try it locally. [04:54:23] obviously it's not your fault, nobody uses deployment branches [04:54:37] I'm musing about this because this is not the first time I've had this problem [04:54:44] and maybe next time, it'll be really urgent [04:55:47] New patchset: Mattflaschen; "Remove template parse operation on every page view" [mediawiki/extensions/GuidedTour] (forcontentHotfix) - https://gerrit.wikimedia.org/r/67231 [04:56:29] TimStarling, it's at https://gerrit.wikimedia.org/r/#/c/67231/ [04:56:52] You could ask csteipp his procedure. Of course, he has it tougher since he has to be sure it doesn't leak on Gerrit, etc. [04:59:08] btw, here is the breakdown of these master queries by title: http://paste.tstarling.com/p/odoJCJ.html [05:00:01] the 0.03% and 0.07% ones are probably not statistically significant [05:01:28] Thanks, do I have access to generate that list (or equivalent) on Ganglia or something? [05:02:11] no, I made it with tcpdump | perl -ne on the DB master server [05:03:04] I guess I could add a log [05:04:00] There's an unusually high amount of Mississippi. [05:04:21] yeah, it was probably just a single parse that happened while tcpdump was running [05:04:32] if I ran it again, it'd be some other article [05:07:58] superm401: so you want me to merge this, then switch the default branch in 1.22wmf5 to forcontentHotfix? [05:09:31] TimStarling, or, since it's a one-time thing, you could go into the GuidedTour directory on tin and run: [05:09:34] git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/GuidedTour refs/changes/31/67231/1 && git checkout FETCH_HEAD [05:09:44] That will just fetch the cherry-pick explicitly. [05:09:47] Up to you [05:09:58] ok [05:11:35] I'm doing what you said [05:41:00] New patchset: Mattflaschen; "Fix FUOC on preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [05:43:20] New patchset: Liangent; "Fix FOUC on preferences." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67232 [05:55:45] New patchset: Spage; "Only new vertical format login and signup forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67233 [06:18:59] New review: Wikinaut; "@Parent:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66228 [06:28:45] New patchset: Santhosh; "Correct the loop logic for language buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67234 [06:32:29] New review: Wikinaut; "@Daniel Friesen:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [06:36:36] New patchset: Santhosh; "Correct the loop logic for language buttons" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67234 [06:49:10] Oh fun I just realized a bug in our HTML5 code! [06:49:12] [06:49:26] Our edit tokens require quoting. [06:49:31] We need to fix Html.php [06:51:21] New review: Daniel Friesen; "@Wikinaught, it's an age old mistake. It has a purpose but it has nothing to do with the edit token." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [06:52:55] New patchset: Tim Starling; "Remove unnecessary exception from Title::getLatestRevID()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67235 [06:57:25] TimStarling: What fun I just realized we output when $wgWellFormedXml = false; [06:58:02] Nikerabbit: ;) maybe TWN should set $wgWellFormedXml = false; so that we actually have a running wiki ensuring it works. [07:02:06] New review: Wikinaut; "Brian Wolff wrote:" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:11:40] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:16:13] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:16:30] DanielFriesen: as far as i know we have been running with that setting for months if not years [07:17:04] Aww... you are. [07:17:22] Guess there's no way a bug like this would have been normally noticed. [07:17:41] sorry, which bug? [07:18:27] New patchset: Wikinaut; "code cosmetics: extension now uses Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:19:19] Nikerabbit: https://bugzilla.wikimedia.org/show_bug.cgi?id=49232 [07:20:00] hmm [07:20:20] we disabled editing without user account also long time ago [07:24:18] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:24:42] New review: PleaseStand; "@Wikinaut, @Daniel Friesen: EDIT_TOKEN_SUFFIX (introduced in r18112) is actually to detect edits fro..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [07:34:59] New patchset: Aaron Schulz; "Use getFileContents() instead of incorrect file system call to fetch file contents." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67236 [07:36:04] New patchset: Alvaro Lopez Tijeras; "Remove multiply operation." [sandbox] (master) - https://gerrit.wikimedia.org/r/67237 [07:39:48] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67237 [07:39:57] New review: Kipcool; "So, it won't let me merge... It says "Need Rebase or Has Dependency". This is because of the conflic..." [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67092 [07:45:41] New patchset: Alvaro Lopez Tijeras; "Add multiply operation." [sandbox] (master) - https://gerrit.wikimedia.org/r/67238 [07:48:05] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67238 [07:48:06] DanielFriesen: so you observed that bug on TWN? [07:48:15] Nemo_bis: No [07:48:15] or in other words, TWN is affected by it? [07:48:17] ok [07:48:25] But TWN would be affected by it. [07:48:58] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [07:49:13] Ok if you mean observed as in "you see that bug active on TWN" then yes. [07:49:51] New review: Hashar; "If it makes error message obvious, it is worth the effort. The --tap option passed to PHPUnit would..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67098 [07:50:32] I just meant no as in "I tested for the bug on a local install after having a hunch from Wikinaught's comment, I didn't look at TWN till Nikerabit mentioned it." [07:50:51] New patchset: Alvaro Lopez Tijeras; "Add divide operation." [sandbox] (master) - https://gerrit.wikimedia.org/r/67239 [07:51:48] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67239 [07:52:22] lol Wikinaught [07:52:26] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/67239 [07:52:34] poor T. [07:54:33] New review: Daniel Friesen; "Ah right, badly written proxies not badly written bots." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [07:54:41] New patchset: Nemo bis; "In 'uctop', replace 'top' with 'current' [revision]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [08:01:34] New review: Wikinaut; "Thanks for your comments (should perhaps be document on a related MediaWiki page)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [08:10:40] New review: Daniel Friesen; "-1 because:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66228 [08:26:19] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65816 [08:53:50] Change abandoned: Wikinaut; "see comments. This approach (working on new get/match CSRFToken methods) has currently no support." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66228 [10:05:31] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [10:24:28] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67166 [10:29:20] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [10:44:27] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [10:54:55] New patchset: Pastakhov; "Add Array Functions (version 0.4.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/67242 [11:33:41] New review: Wizardist; "Help me please to decide which way to announce the module:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67166 [11:35:27] New patchset: Santhosh; "Avoid duplicate language buttons in input settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67244 [11:55:54] New review: Alex Monk; "What was the pos-above class?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/67220 [12:06:43] New patchset: Nikerabbit; "Partial revert of If5755624 and a comment" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67247 [12:10:21] New review: J; "should be applied to all project that have TMH enabled, most videos are in commonswiki though, other..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57536 [12:15:35] New patchset: Santhosh; "Update button css from Agora" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67248 [12:22:12] New patchset: Santhosh; "Update button css from Agora" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67248 [12:34:52] New review: Aude; "test http://www.wikidata.org/wiki/Wikidata:Main_Page" [mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/67083 [12:39:06] New patchset: ArielGlenn; "XML text dumps: skip rev length check for weird content models" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [12:40:20] New patchset: ArielGlenn; "XML text dumps: skip rev length check for weird content models" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [12:42:31] New review: ArielGlenn; "Yes, the whole rev_len thing turns out to be less useful and more irritating than I could wish. It ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [12:44:51] manybubbles: Thanks for the very quick review :) I'm planning one more Solr related patch [12:45:21] manybubbles: I've also created a bug report requesting the Solr 3.6.0 package to be updated to 3.6.2. I'll add you on CC. [12:47:11] New patchset: Siebrand; "Do not commit upates to the index immediately" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [12:49:46] New patchset: Siebrand; "Do not commit upates to the index immediately" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [12:50:12] New review: Siebrand; "PS2 removes a second addCommit() that is not needed." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [12:55:41] andre__, can we have the GmailThreading bz extension? the 'new bug' emails being in different conversations to the comments is slightly annoying [12:56:08] Krenair, file an enhancement request [12:57:45] done [12:57:46] !b 49250 [12:57:46] https://bugzilla.wikimedia.org/49250 [12:58:39] thanks [13:12:48] New patchset: Nikerabbit; "Avoid duplicate language buttons in input settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67244 [13:16:37] New review: Nemo bis; "Note, there are some changes in the patch unrelated to the commit message, like addition of some ext..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/28956 [13:18:52] New review: Nemo bis; "https://gerrit.wikimedia.org/r/#/c/28956/ was not merged yet (needs rebase) and contains a bunch of ..." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65649 [13:22:38] New review: Jamie Thingelstad; "SMW + Lua makes me so excited! I can't wait to dive into some modules with this!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [13:23:26] New review: Wizardist; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67235 [13:23:28] New review: Nikerabbit; "Okay, I will merge this and check again, and I will report a bug with steps to reproduce." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/67049 [13:25:51] New patchset: Alex Monk; "Revert "Delete the editWarning feature"" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/67253 [13:26:37] ^demon: is jenkins/zuul stuck currently? [13:26:54] <^demon> Not a clue...it might've flipped out when we restarted gerrit. [13:26:57] <^demon> I'll check the log [13:27:15] no notification for abandons now? [13:28:14] <^demon> I didn't change the hooks. [13:28:40] Ugh what? I ran git revert on a branch tracking REL1_21 and then 'git review REL1_21', but it says no new changes? [13:28:53] caused by the one I accidentally sent to master maybe? I did abandon that though... [13:29:37] New patchset: Wizardist; "(Bug 48952) Show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [13:30:25] New patchset: Alex Monk; "Revert "Delete the editWarning feature"" [mediawiki/extensions/Vector] (REL1_21) - https://gerrit.wikimedia.org/r/67254 [13:30:42] nvm got it with the 'chery pick to' button. haven't noticed that before, is it new? [13:33:40] <^demon> Yep, new feature. [13:33:52] <^demon> Does what it says on the tin :) [13:35:07] Was that added when you restarted? [13:36:04] <^demon> Yep, we got a ton of new features & fixes. [13:36:23] hah, that was great timing for me [13:43:55] <^demon> Ok, rolled back to the pre-upgrade build. We broke zuul. [13:48:35] New patchset: Shirayuki; "Grammar correction" [mediawiki/extensions/Comments] (master) - https://gerrit.wikimedia.org/r/67255 [14:01:02] New patchset: Matmarex; "CSSJanus: support text-shadow and box-shadow flipping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52611 [14:04:28] New review: Matthias Mullie; "#mw-echo-overlay-pokey vertical position seems to be off by 1px on Safari, vs Firefox. Otherwise, it..." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/66367 [14:14:24] <^demon> Susan: I'm thinking "Freenode netsplit" should be added to your blamewheel :) [14:28:31] New review: Daniel Kinzler; "Seems good, but I havn't tested, and I suppose we don't have tests for this, so, no +2." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65236 [14:46:12] New review: MaxSem; "For the reference, the current situation is:" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [14:50:30] siebrand, why are you committing on behalf of manybubbles? :P [14:50:34] New patchset: Zfilipin; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [14:50:49] MaxSem: ehr...? [14:51:07] who of you is an ops?:) [14:51:14] MaxSem: huh? [14:51:25] MaxSem: well, I have some experience, and I wanted to get this working again. [14:51:52] MaxSem: afaik manybubbles was hired to upgrade the wiki search cluster, not these insignificant thingies. [14:52:39] technically for the big thing mostly but I'm really quite keen to do the reviews at least for everything else as well. [14:52:58] merge merge merge [14:53:30] I'll happilly do it but I've been directed to try to ignore it and work on the main wiki search. it feels funny, a bit, but it makes sense. [14:54:04] hmm, autoCommit and commitWithin at the same time... [14:55:16] MaxSem: If no commit is given, and we don't have auto commit, the updates will not get committed until a manual update is made. So even though commitWithin is preferred, it's a sane default. [14:55:57] +1'd the puppet changes, waiting for reply in ttm one [14:56:19] MaxSem: Nikerabbit has tested some on twn. [14:56:44] MaxSem: I've tested in very different situations, but basically the defaul 3.6 config sucks, and this all makes it much better. [14:56:59] riiight, we have twm [14:57:27] so: do you ever delete docs? [14:57:51] MaxSem: best ask Nikerabbit [14:58:03] MaxSem: I don't think so, we just replace them [14:58:17] only exception is the boostrap process which wipes everything for given wiki clean [14:58:20] what if a message got deleted? [14:58:35] nothing happens [14:59:35] o_0 [14:59:37] okay [15:00:06] It's like a search result that 404s until the index is rebuilt. [15:00:10] my concern was that delete oprations could have caused commits. however, when there are no deletes.... [15:04:00] New review: Manybubbles; "I'm not sure why need commitwithin if we've got autocommit. One or the other should be fine. Remov..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [15:06:30] +1 on the ^^^ [15:07:08] and if we want to commitWithin the time should be made a constant or a config variable [15:07:44] manybubbles, so you're working on upgrading our search to modern Lucene? [15:08:27] New review: Nikerabbit; "Didn't find any problems while testing this on dev.translatewiki.net." [mediawiki/extensions/Translate] (master) C: 1; - https://gerrit.wikimedia.org/r/67250 [15:08:55] New review: Siebrand; "We need commitWithin because we cannot be certain that all who use Translate with Solr will have aut..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [15:09:12] MaxSem: yeah - I'm going to see if I can get us off the hand rolled lucene thing and onto a new version of solr. [15:09:43] MaxSem: config variable seems quite excessive [15:10:00] yeah, that's why I said or const [15:15:33] New patchset: Nikerabbit; "Do not commit upates to the index immediately" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [15:15:42] MaxSem: ^^ does that address your concern? [15:18:40] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [15:18:44] d'oh [15:21:23] MaxSem: so about the solrconfig change you made to use more memory. Where can I find our how much memory the solr java process is allowed to consume total? As in, where is that configured? [15:21:43] not by me;) [15:22:13] it's defined by java start arguments [15:22:17] ok! Let me go through puppet some. Because if they are using the default heap size then that amount of memory seems like a bad idea [15:22:24] yeah, I just need to find them. [15:22:51] mmm, and we seem to use the default [15:23:09] it's in modules/solr/files/jetty [15:23:19] this: JAVA_OPTIONS="-XX:+UseConcMarkSweepGC" [15:23:24] <^demon> Default heap size is almost always wrong :) [15:23:31] almost! [15:23:42] we should crank that up with your change. [15:23:55] not mine!:) [15:23:56] I can leave a comment in garret if that is the right thing to do [15:24:11] wait, have I just got confused? [15:24:41] looks like I have. to garret! [15:24:44] do you have an evidence that the current 2G (?) is not enough for TTM and GeoData? [15:25:18] garret? gerrit? [15:25:45] I'm wondering if we should move ttm out of vanadium sooner or later [15:26:10] we should [15:26:26] well, *you* should [15:27:32] <^demon> Ideally we'd move both of you guys into the solr cloud with your own cores. [15:27:37] <^demon> When the time comes. [15:28:12] ^demon: how do we know when the time comes? [15:28:15] ^demon, are you still working on Search? [15:28:27] <^demon> I'm working with manybubbles on it, yeah [15:28:45] <^demon> Nikerabbit: Well, step 1 is actually having a production cloud :) [15:28:57] if it's with him ==> you're working on text search only, right?:P [15:29:35] <^demon> Well, I see lots of opportunities with Solr, so I want to have us setup in a way where lots of things can make use of it. [15:29:46] <^demon> But yeah, our initial focus is wikitext searching. [15:29:57] <^demon> I know wikidata wants to use it too. [15:31:57] New patchset: Zfilipin; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [15:32:07] <^demon> manybubbles: So, is there a compelling reason to run the zookeeper ensemble on its own hosts and not just run it on each of the solr instances? [15:32:31] ^demon: Kind of. [15:32:52] New review: Zfilipin; "Minor whitespace cleanup." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [15:33:05] ^demon: ZK might be used for stuff other than solr and then it wouldn't make sense to join them. [15:33:44] <^demon> Hmm. [15:34:06] ^demon: but more than that ZK is less tolerant to losing nodes than solr is so having it live on its own so we can restart it even more carefully might be better [15:34:28] what is the purpose of zoekeeper? [15:34:28] also, the more ZK nodes we have the slower it gets so we wouldn't want to run it on all the solr nodes. [15:34:50] <^demon> Nikerabbit: It manages configuration & cluster state between the solr nodes. [15:35:01] <^demon> Since with Solr 4, you don't run in a traditional master/slave setup anymore. [15:35:06] <^demon> It's a "cloud" :) [15:35:11] whiii [15:35:18] I'm running Solr 4 on translatewiki.net [15:35:26] it's huge cloud all on one server [15:35:38] beware humidity [15:35:47] Nikerabbit: you can still even do master/slave replication with solr 4 too [15:35:59] <^demon> Ah yes, sorry if I was unclear. [15:36:02] the "cloud" stuff is the ability to have new nodes join and just "do the right thing" [15:36:12] <^demon> Which makes scaling much easier :) [15:36:18] <^demon> And removes the master as a spof. [15:36:27] manybubbles: at twn I don't see need for more complexity right now [15:36:50] Nikerabbit: don't use it if you don't need it [15:37:37] zookeeper just makes sharing state easy and fault tolerant. [15:37:48] I don't dare to tell you how it is setup there currently, it's so hacky [15:38:13] ^demon: did you get my email this morning! I realized what I had forgotten yesterday. [15:38:26] <^demon> Yes, I did. I skimmed it because I was in the middle of breaking something :p [15:39:15] what a perfect excuse ;) [15:41:01] ^demon: I forgot to whinge @ you on Monday. None of the extensions I checked on Sunday were branched for 1.21, and someone said you were the appropriate target. [15:41:29] <^demon> Prod hexmode or Krinkle, they took my old script and did that. [15:41:38] kk, thanks. [15:42:04] Amgine: https://bugzilla.wikimedia.org/show_bug.cgi?id=48837 [15:42:24] Should be done, haven't configured ExtensionDistributor though, but the branches are available in git [15:43:03] ^demon: regardles of the right or wrongness of my email I'm going to keep going like we talked about. I get the sense that changing direction wouldn't be too hard any way. [15:43:27] <^demon> *nod* [15:43:36] New patchset: Physikerwelt; "Enhancement: Allow XmlTypeCheck for strings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [15:43:51] [15:46:25] New review: Physikerwelt; "Thanks for your comments. Hopefully I addressed them all." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66365 [15:49:40] New patchset: Physikerwelt; "Remove non UTF-8 chars from debug output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [15:50:07] New review: Manybubbles; "Due to the responses above I also endorse this change and consider my objections above dealt with." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67250 [15:51:25] New review: Zfilipin; "I think this commit needs a few more minor improvements." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/66307 [15:52:12] New patchset: Alvaro Lopez Tijeras; "Remove divide operation." [sandbox] (master) - https://gerrit.wikimedia.org/r/67260 [15:53:10] Whats the possible format for rvsvart and rvend timestamps for api call action=query&prop=revisions? [15:53:16] rvstart* [15:55:34] New patchset: Zfilipin; "Adding more test scenarios for ULS user settings" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63140 [15:55:56] New review: Physikerwelt; "Looks good, but I can not see how you addressed the caching aspect?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [15:56:24] New patchset: Physikerwelt; "(Bug 48952) Show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [15:57:55] New review: Physikerwelt; "Can someone tell me how I can get rid of the dependency?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [16:00:21] New review: Hoo man; "@Physikerwelt: https://www.mediawiki.org/wiki/Git/Workflow#Unlink_bogus_dependencies_.28rebase_chang..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [16:00:39] New review: Matmarex; "Cherry-pick this on master. You can do it using the "Download -> cherry-pick" git command you can co..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [16:03:51] New patchset: Matmarex; "CSSJanus: support text-shadow and box-shadow flipping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52611 [16:03:52] New patchset: Matmarex; "CSSJanus: don't mangle 5+ consecutive numeric values" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67262 [16:03:52] New patchset: Matmarex; "CSSJanus: improve color support" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67263 [16:03:52] New patchset: Matmarex; "CSSJanus: fix handling for border-radius" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [16:04:27] New review: AlephNull; "The protected property Database::views is inherited by DatabaseMysql. The DatabaseMysql::listViews m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [16:04:52] New patchset: Matmarex; "Revert "Workaround for border-radius due to bug 49074"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/67265 [16:04:58] New patchset: MaxSem; "action=parse now can parse in preview mode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67266 [16:07:43] New patchset: Hiong3-eng5; "API: modified Express and Define Class" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [16:08:01] hexmode: why do you have two e-mail in bugzilla, actually? [16:08:07] e-mails* [16:09:25] MatmaRex: I don't remember the exact reason. I think I used the gmail one for some bot work, but that is only a guess. [16:10:13] more likely, I started with the gmail one and wanted to focus on my personal one [16:11:04] New review: Hiong3-eng5; "I think this is wrong. I will try again." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [16:12:07] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [16:13:52] New review: EBernhardson; "I have on concern with this feature, not related to the mechanics but to the usability." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [16:16:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67266 [16:17:45] New patchset: Matmarex; "CSSJanus: fix handling for border-radius" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67264 [16:19:16] New review: Hiong3-eng5; "or is it? Kindly check. The link you sent me seems not to work or I misunderstood something from it." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [16:26:43] ^demon: this small wording change would use review too :p if you have a min https://gerrit.wikimedia.org/r/#/c/58049/ [16:30:04] is there an extension skeleton anywhere? [16:30:47] ebernhardson: https://git.wikimedia.org/log/mediawiki%2Fextensions%2Fexamples/HEAD maybe? [16:31:35] hoo: seems reasonable enough, thanks! [16:31:53] hoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=49259 :( [16:32:59] Do you think we should patch the API to accept revision ids instead of rc ids? [16:33:14] Or should we somehow include the rc id in the html (which is super bad) [16:33:25] or make an API to look up rc ids [16:33:41] the first solution seems the sanest to me [16:33:45] New patchset: Reedy; "Prevent warning when importing jump config (no questions)" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67268 [16:34:47] MatmaRex: Yeah :) [16:37:02] New review: Anomie; "You could make a patch to add an oi_timestamp index... ;)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/60088 [16:39:00] New patchset: Cmcmahon; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [16:40:36] New patchset: Cmcmahon; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [16:52:41] New review: Zfilipin; "A couple of tests are failing:" [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/66307 [16:54:40] New patchset: Jeroen De Dauw; "Update composer file so the latest version of DataValues is fetched rather then the latest tag" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67270 [16:58:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67270 [17:12:45] New review: Nikerabbit; "I think we should leave this in for a while, since we claim to support 1.20 still in MLEB." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/67265 [17:14:13] New review: Zfilipin; "Changes that I have suggested in patch set 2 should be made before this commit is merged into master." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/63140 [17:14:48] New patchset: Zfilipin; "Adding ULS test scenarios" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63135 [17:17:14] New review: Zfilipin; "Runa, could you please answer questions that I have asked in patch sets 2 and 3? I think this should..." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/63135 [17:21:13] New review: Kipcool; "No it is weird, there should not be so many files changing." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [17:25:44] New patchset: Jeroen De Dauw; "Update autoloader inclusion for composer installs" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67276 [17:26:05] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67276 [17:28:53] New patchset: Cmcmahon; "add tests for ULS Input and Fonts and More Languages" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [17:31:11] ^demon: Notice: Undefined variable: wgHTTPConnectTimeout in /var/www/daniel/wikidata/includes/HttpFunctions.php on line 242 [17:31:18] git blames you :) [17:31:23] <^demon> Fixed in master. [17:31:36] oh, time to pull again i guess [17:31:40] sorry for the noise, then [17:31:44] <^demon> np [17:38:22] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/34976 [17:44:56] New review: Kipcool; "The following seems to work for me:" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/67092 [17:45:18] greg-g: I guess https://bugzilla.wikimedia.org/show_bug.cgi?id=49259 can go in any post-mortem too [18:01:57] Yippie, build fixed! [18:01:58] Project browsertests-en.wikipedia.org-linux-firefox build #97: FIXED in 4 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/97/ [18:04:00] Yippie, build fixed! [18:04:01] Project browsertests-en.wikipedia.org-linux-chrome build #106: FIXED in 7 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/106/ [18:09:46] Yippie, build fixed! [18:09:47] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #61: FIXED in 6 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/61/ [18:13:31] Yippie, build fixed! [18:13:32] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #101: FIXED in 9 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/101/ [18:36:42] Yippie, build fixed! [18:36:42] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #83: FIXED in 9 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/83/ [18:43:12] New review: Cmcmahon; "I think the failures you saw have to do with ULS picking up your local settings. I've removed more ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [18:45:19] New review: Isarra; "But splitting it into two commits doesn't make sense when the first one wouldn't get merged at all n..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [18:47:43] New patchset: Parent5446; "Remove non UTF-8 chars from debug output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [18:59:33] when clicking on user.options on http://www.mediawiki.org/wiki/ResourceLoader/Default_modules imma getting 404 [18:59:39] anyone knows the right linky? [19:01:48] New patchset: Aaron Schulz; "Created skeleton code for the OAuth extension." [mediawiki/extensions/OAuth] (master) - https://gerrit.wikimedia.org/r/67286 [19:03:54] AzaToth, yeah gitweb has been replaced with gitblit. I'll try to find the right one.. [19:05:23] AzaToth, https://git.wikimedia.org/blob/mediawiki%2Fcore//includes%2Fresourceloader%2FResourceLoaderUserOptionsModule.php [19:07:29] why two slashes? [19:12:30] New patchset: Kaldari; "Specific font families should never be assigned outside of skin-specific CSS" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67168 [19:13:03] Nemo_bis, there was a commit hash between those slashes [19:14:00] Could've replaced it with HEAD [19:14:10] * AzaToth just found http://momentjs.com [19:14:44] threw it in as a gadget deps for me, but think it could be added to mw core libs [19:16:06] moment("2013-06-06T14:27:56Z").fromNow() →'5 hours ago' [19:16:06] moment("2013-06-06T14:27:56Z").calendar() →'Today at 4:27 PM' [19:16:08] ツ [19:16:58] AzaToth: how is the i18n support? [19:22:00] it says it's localized [19:22:57] http://momentjs.com/docs/#/i18n/ [19:24:26] https://github.com/timrwood/moment/tree/develop/lang [19:30:54] New patchset: Reedy; "/home/wikipedia to /a/common" [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/67292 [19:31:08] Change merged: Reedy; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/67292 [19:31:37] New patchset: Reedy; "Update WikimediaMaintenance to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67293 [19:32:18] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67293 [19:32:52] New patchset: Cmcmahon; "don't run VE tests for IE6/7/8 per https://bugzilla.wikimedia.org/show_bug.cgi?id=49187" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67294 [19:33:42] New patchset: Reedy; "Update WikimediaMaintenance to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67295 [19:37:19] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67295 [19:43:36] New review: Matmarex; "Yeah, the reason I rewrote that code is because it sucked. There's no point in merging the previous ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [19:55:45] New patchset: Reedy; "Cater for different license for testwikidatawiki too" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67301 [19:58:03] can someone remind me what the count graph in graphite means - if it's at 42, it's 42 occurences per what time interval? [20:00:50] MaxSem: context? [20:01:03] graphite.wikimedia.org [20:01:06] * Aaron|home wonders were the cache keys "commonswiki:pt-lock:File:U.S._Army_Sgt...." are used [20:01:18] New patchset: Reedy; "Cater for different license for testwikidatawiki too" [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/67301 [20:09:14] New patchset: Reedy; "Update WikiData related extensions for 1.22wmf6" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67305 [20:10:24] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #102: FAILURE in 9 min 38 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/102/ [20:18:25] New review: Matmarex; "Anyone? This is almost half a year old by now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [20:21:25] New review: Matmarex; "The use case is obviously non-skin CSS. (And if I could, I would kill the Skin method with fire.)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365 [20:22:19] New patchset: Alex Monk; "edit.php maintenance script not setting up context, just globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67309 [20:22:38] New review: CSteipp; "Seems to be doing the right thing, and working in test" [mediawiki/extensions/CheckUser] (master) C: 2; - https://gerrit.wikimedia.org/r/67165 [20:22:40] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67305 [20:24:09] ^demon|away: When you're back, can we just delete the REL1_19 etc. branches of VE in https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/VisualEditor,branches - it currently comes up on ExtensionDistributor but VE is still alpha and these don't make sense. [20:28:38] James_F, can't you do that? [20:28:55] Krenair: I /can/ do it; I'm asking ^demon|away's advice as to whether I /should/. :-) [20:29:01] ah, ok. [20:29:07] Or if doing so will break lots of things. [20:30:59] New patchset: Mattflaschen; "Bump GettingStarted for E3 deploy" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67313 [20:33:43] New patchset: Mwalker; "Stop PhpMailer Errors in Production" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67315 [20:33:56] does anyone know about $.tablesorter and its issues? seemsl ike its breaking when using it on multiple tables in the same page [20:35:06] New patchset: Aaron Schulz; "Fixed long memcached keys." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/67316 [20:37:08] New review: Spage; "4d9078c is latest" [mediawiki/core] (wmf/1.22wmf5) C: 2; - https://gerrit.wikimedia.org/r/67313 [20:37:15] csteipp: testwikidatawiki is now useable [20:37:34] Reedy: I just saw. Thank you! [20:41:23] New patchset: Aaron Schulz; "Fixed long memcached keys for infoaction." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67319 [20:41:46] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67315 [20:42:16] New patchset: Mattflaschen; "Remove PostEdit from make-branch." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67320 [20:42:38] Reedy: https://gerrit.wikimedia.org/r/#/c/67319/1 [20:46:04] Change merged: MaxSem; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67309 [20:46:12] New review: Jdlrobson; "Although there's no issues with the CSS here I'm not sure if it's an improvement - this makes the ri..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [20:47:47] New patchset: Matmarex; "Link to mediawiki.org page in 'edithelppage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [20:48:19] New patchset: Yurik; "updated to latest zero extension" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67323 [20:48:40] New patchset: Bsitu; "$wgOut->getContext()->getTitle() may return null" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67324 [20:48:57] New patchset: Yurik; "updated to latest zero extension" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67325 [20:50:19] * Reedy wonders how out of date Zero in wmf6 is [20:50:43] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67325 [20:50:48] New review: Alex Monk; "This shouldn't happen, the fact it was happening in bug 49271 has been fixed in core in Ie1b5f5bc" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/67324 [20:51:01] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67323 [20:55:07] New review: Bsitu; "Maybe keep this to be safe, I saw similar issue when running unit test against Echo, I am just afrai..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67324 [20:59:58] New patchset: Jeroen De Dauw; "Update entry point and gitignore to work with composer" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67329 [21:04:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67329 [21:06:08] New review: Spage; "forcing, Zuul is broken" [mediawiki/core] (wmf/1.22wmf5); V: 2 - https://gerrit.wikimedia.org/r/67313 [21:06:08] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67313 [21:06:49] New review: Spage; "I'm not familiar with the file but it lgtm. Zuul is down, so forcing a merge." [mediawiki/tools/release] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67320 [21:06:50] Change merged: Spage; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67320 [21:08:45] !log Running updateSpecialPages.php on testwiki to test new Disambigutor special pages [21:09:37] oops wrong chan [21:12:57] Job::insert() is @deprecated, whats the proper thing to do instead? The same thing that Job::insert does( JobQueueGroup::singleton90->push( $job ) ) ? [21:14:27] I love when something is marked deprecated whithout saying why and/or what alternatives exists [21:14:40] :) [21:15:40] ebernhardson: but offcourse, you should know that when something is marked deprecated is because the maintainer invented an abstract factory generator to solve the same thing [21:16:03] AzaToth: personally, i'm ok with abstract factory generators (as opposed to hard coded everything everywhere) [21:16:21] AzaToth: but i used to do java :P [21:16:24] hehe [21:17:42] abstractio ad absurdum [21:18:19] theres something incredibly satisfying about having reusable objects. I bet half of the code in mediawiki just duplicates what some other code in mediawiki does :P [21:18:31] ebernhardson: it's blody php [21:18:52] AzaToth: see: Zend2 and Symfony2. php doesn't have to suck [21:19:06] AzaToth: but if your codebase is 10 years old, it kinda does have to suck :P [21:19:15] as long there's nl2br(), it's sucky! [21:20:10] New review: Spage; "I'm not sure how to validate a cherrypick but comparing the changed files with master looks OK and i..." [mediawiki/core] (wmf/1.22wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/66316 [21:20:45] damn, mediawiki uses nl2b4 14 times [21:20:45] nl2br [21:21:00] New review: Spage; "forcing it since Zuul is down." [mediawiki/core] (wmf/1.22wmf5); V: 2 - https://gerrit.wikimedia.org/r/66316 [21:21:00] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66316 [21:24:02] New patchset: Jeroen De Dauw; "Update netry point file now the composer.json of DataValues has been updated" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67332 [21:24:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67332 [21:24:41] New patchset: Mattflaschen; "Bump GuidedTour for E3 deploy" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67333 [21:25:52] New review: Spage; ""4ab986c Remove template parse operation on every page view" is latest. Forcing since Zuul is down." [mediawiki/core] (wmf/1.22wmf5); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67333 [21:25:52] Change merged: Spage; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67333 [21:26:51] New patchset: Jeroen De Dauw; "Update composer.lock" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67334 [21:27:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67334 [21:28:06] New patchset: Jeroen De Dauw; "Remove dev dependency on phpunit from composer.json" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67335 [21:28:23] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67335 [21:34:05] New review: Matmarex; "> How are users supposed to read the token to then copy/paste into a tool interface that uses it? Re..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [21:35:19] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=49270 looks like another 1.21 release Vector-related bug :/ [21:35:55] that's what I was thinking [21:38:05] New patchset: Catrope; "Add Parsoid to wmf5 too" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67339 [21:38:16] Change merged: Catrope; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67339 [21:41:06] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #71: FAILURE in 5 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/71/ [21:45:00] New review: Helder.wiki; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59060 [21:45:26] New patchset: Jeroen De Dauw; "Add composer.phar to gitignore" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67342 [21:46:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67342 [21:49:11] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_6 build #58: FAILURE in 1 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_6/58/ [21:50:21] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_7 build #58: FAILURE in 1 min 30 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_7/58/ [21:51:53] New review: Alex Monk; "try to get zuul to submit this time" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/67220 [21:52:48] New patchset: Jeroen De Dauw; "Remove obsolete TODO and improve codeCoverageIgnore usage" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/67346 [21:54:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67220 [22:16:36] New review: Catrope; "I've poked Trevor about it, but since it's crunch time for VE it's unlikely he'll have a lot of time..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [22:28:01] New review: Reedy; "Is there really a need to re-implement your own version of a job queue? What's wrong with what's cur..." [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/25903 [22:34:35] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61745 [22:41:00] New review: Parent5446; "@PleaseStand" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [22:56:24] New patchset: Cmcmahon; "accommodate altered page create workflow on beta" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67365 [22:58:03] New review: Cmcmahon; "This should turn the Jenkins builds for beta labs green" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/67365 [23:03:14] New patchset: Kaldari; "Making Special:DisambiguationPageLinks work with $wgMiserMode" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/67367 [23:08:09] New patchset: Kaldari; "Making Special:DisambiguationPageLinks work with $wgMiserMode" [mediawiki/extensions/Disambiguator] (master) - https://gerrit.wikimedia.org/r/67367 [23:09:40] New patchset: Reedy; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67369 [23:10:31] New patchset: Reedy; "Update Parsoid to master" [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67370 [23:10:51] Yippie, build fixed! [23:10:51] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #103: FIXED in 9 min 37 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/103/ [23:11:57] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67369 [23:12:04] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf6) - https://gerrit.wikimedia.org/r/67370 [23:15:36] New review: Spage; "This fixes the rtl bug with Agora input focus ( Special:UserLogin&uselang=ar ), and the old CSSJanus..." [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/52611 [23:16:13] New patchset: Parent5446; "Add referer check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [23:17:14] New patchset: Parent5446; "Add referer and origin check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [23:18:05] New patchset: Parent5446; "Added Uri class and Uri Query classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167 [23:18:09] New patchset: Parent5446; "Add referer and origin check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [23:28:02] New review: Brian Wolff; "I do not think this is a good idea." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65418 [23:33:10] New review: Parent5446; "@Brian - I realize these issues. The only reason I made this patch is because of opposition in https..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [23:37:00] New patchset: Mwalker; "STOMP Selectors and Connection Sanity" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/67375 [23:38:09] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/67324 [23:52:05] New patchset: Parent5446; "Added Uri class and Uri Query classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167