[00:00:12] New review: Krinkle; "I'm not questioning whether this is the right way to address the use case. I'm questioning what the ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64365 [00:07:37] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [00:22:45] New review: Krinkle; "Avoid re-using the same ID for a different element. Either use a different ID, or (seems more approp..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64557 [00:23:45] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [00:25:09] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62337 [00:25:44] New review: Mwjames; "Added a $this->assertEmpty( $instance->getTable() )" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [00:47:15] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [00:49:24] New review: MZMcBride; "As far as I'm aware, Legoktm is correct: only edits marked as both bot _and_ minor will stifle the o..." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [00:51:34] New review: EBernhardson; "Updates made as requested, please re-review the updated parts." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [01:12:44] New patchset: Mwalker; "Fixing Two Bugs Preventing Deployment" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/66892 [01:20:52] Change merged: Katie Horn; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/66892 [01:57:34] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step from templates such as Template:Book,Template:Artwork etc." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:03:12] New review: Kaldari; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: 2; - https://gerrit.wikimedia.org/r/59156 [02:03:34] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [02:04:54] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step from templates such as Template:Book,Template:Artwork etc." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [02:10:20] New patchset: Cmcmahon; "add tests for ULS Input and Fonts" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [02:25:44] New review: Ori.livneh; "Oops. Thanks for that." [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/66870 [02:25:47] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/66870 [02:46:57] New review: Parent5446; "Also, on a side note, I made this hook specifically to help with OAuth integration FWIW: https://ger..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66286 [03:02:09] New review: Mattflaschen; "I like this idea. I'd like to know what browsers you tested in." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62207 [03:24:30] New patchset: Anomie; "Respect content model for viewing stable versions." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/66893 [03:24:33] New review: Anomie; "I really don't like this approach, special-casing wikitext. And I don't think that this approach wil..." [mediawiki/extensions/FlaggedRevs] (master) C: -1; - https://gerrit.wikimedia.org/r/65159 [03:27:54] New review: Mattflaschen; "See comment at bug 36755. There's an issue with old versions of IE, but only without JS." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62207 [03:58:50] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [04:42:17] New patchset: Mattflaschen; "Clarify setrawcookie comment." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/66894 [04:52:58] New review: Spage; "I appreciate it, further polish possible." [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/66894 [05:01:22] New patchset: Mattflaschen; "Clarify setrawcookie comment." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/66894 [05:03:29] New review: Mattflaschen; "Done" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/66894 [05:05:32] New patchset: Tim Starling; "Add a script to remove deleted files from storage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [05:09:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [05:22:28] New review: RAN1; "Hi, the translations look good (although my understanding of German isn't so much, so I'll go ahead ..." [mediawiki/extensions/CommunityTwitter] (master) C: 1; - https://gerrit.wikimedia.org/r/66884 [05:40:47] New review: Aaron Schulz; "This was a bit hacky since I wanted to get this out soonish, and the $wgFlaggedRevsHandleIncludes do..." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/65159 [05:44:10] New patchset: Santhosh; "Correct the id for related sites sidebar" [mediawiki/extensions/RelatedSites] (master) - https://gerrit.wikimedia.org/r/66895 [05:44:21] New review: Peachey88; "Has this extension been added to TranslateWiki yet since Raimond's patchset?" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/66884 [05:47:56] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [05:50:47] New review: Mwjames; "Don't be scared most LoC now comes from tests and the included TableFormatter [1] which should be me..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [06:11:05] New review: Netbrain; "I guess that splitting formatting and data is quite reasonable. So i guess this feature should be in..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66379 [06:12:46] New patchset: Tim Starling; "[Database] Added an upsert() function to perform/emulate ON DUPLICATE KEY UPDATE." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62106 [06:13:56] New patchset: Mwjames; "Refactor SMWFactbox, make it an instantiable class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [06:16:41] New patchset: Ori.livneh; "Add Vagrant's non-secure key pair in PuTTY PPK format" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/66896 [06:20:42] New patchset: Tim Starling; "[Database] Added an upsert() function to perform/emulate ON DUPLICATE KEY UPDATE." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62106 [06:22:00] New review: Tim Starling; "PS2: fix default $fname" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62106 [06:24:42] New review: Mattflaschen; "Looks good. What's the unconvincing reason, that it's a derived file?" [mediawiki/vagrant] (master) C: 2; - https://gerrit.wikimedia.org/r/66896 [06:24:44] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/66896 [06:24:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62106 [06:26:29] New review: Ori.livneh; "> Looks good. What's the unconvincing reason, that it's a derived file?" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/66896 [06:39:36] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/66894 [06:40:42] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66318 [06:48:44] New patchset: Physikerwelt; "Remove non UTF-8 chars from debug output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [06:51:19] New patchset: Santhosh; "Add language selector for signup form" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/66902 [06:57:54] New review: Tim Starling; "If I may comment on the whole topic branch:" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/62174 [07:02:33] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62173 [07:06:58] New patchset: Physikerwelt; "Remove non UTF-8 chars from debug output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [07:08:31] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [07:09:03] New review: Physikerwelt; "The function UtfNormal::cleanUp does everything what I needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [07:13:19] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [07:21:17] New review: Siebrand; "There is a plural missing in the message for the new key. Also suggesting a rewording of an exiting ..." [mediawiki/extensions/UserMerge] (master) C: -1; - https://gerrit.wikimedia.org/r/66139 [07:22:56] Change merged: jenkins-bot; [mediawiki/extensions/RelatedSites] (master) - https://gerrit.wikimedia.org/r/66895 [07:29:24] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66380 [07:30:01] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66879 [07:31:28] hello [07:38:53] New patchset: Hashar; "puppet jobs for ops/puppet/zookeeper" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66904 [07:39:02] New patchset: Amire80; "Make "Cancel" reset preferences and "Apply" save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [07:39:43] New patchset: Hashar; "triggers for ops/puppet/zookeeper" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66905 [07:40:00] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66904 [07:40:36] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66905 [07:42:39] New patchset: Amire80; "Make "Cancel" reset preferences and "Apply" save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [07:44:04] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:44:06] New patchset: Hashar; "fix up module name for ops/puppet/zookeeper" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66907 [07:44:34] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66907 [07:45:35] Published patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:46:35] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:47:07] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:48:46] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:49:13] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [07:51:52] New review: Wikinaut; "Siebrand, Iboyinc, Demon: the new version for you, with changes as requested by Siebrand (thanks jus..." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/66139 [07:58:04] New patchset: Mattflaschen; "Refactor and add support for multiple tours and sticky tours." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66373 [07:59:32] New review: Mattflaschen; "I've done almost all the items from the inline comments. Per discussion on IRC, I'm going to do som..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66373 [08:37:56] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [08:57:13] New patchset: Santhosh; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [08:58:42] New patchset: Santhosh; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [08:59:10] New patchset: Siebrand; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [09:02:15] New patchset: Santhosh; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [09:02:24] New patchset: Amire80; "Properly save back-up preferences for repeated canceling" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66910 [09:04:33] New patchset: Santhosh; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [09:08:32] New review: Hashar; "pulled on gallium" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [09:08:33] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (refs/meta/config); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66911 [09:09:36] New patchset: Hashar; "Switch to using a custom pep8 test for puppet files." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [09:20:25] New patchset: Nikerabbit; "Hide uls trigger from unspported browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [09:20:55] New patchset: Netbrain; "Fixed exception" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/66924 [09:22:27] New review: Netbrain; "Had to add this fix in order to get display_map to work." [mediawiki/extensions/Maps] (master) C: 1; - https://gerrit.wikimedia.org/r/66924 [09:22:59] New patchset: Siebrand; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [09:23:27] New patchset: Nemo bis; "Hide uls trigger from unsupported browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [09:24:41] New patchset: Siebrand; "Hide ULS trigger from unsupported browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [09:25:11] New review: Siebrand; "Same blacklists should be in place as for Narayam and WebFonts. This would for example enable ULS on..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66923 [09:25:30] New patchset: Hashar; "Switch to using a custom pep8 test for puppet files." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [09:26:17] New review: Hashar; "I have slightly adjusted the template to pipe the output to a pep8.txt file and have jenkins craft a..." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/66550 [09:26:18] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [09:31:52] New patchset: Amire80; "Workaround for border-radius due to bug 49074" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66381 [09:41:56] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66910 [09:41:58] New patchset: Nikerabbit; "Hide ULS trigger from unsupported browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [09:43:12] New patchset: Pginer; "(bug 49106) Keyboard icon misaligned in Firefox" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66951 [09:50:26] New review: Siebrand; "Tested in Firefox 21.0 and latest Chrome on OSX." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66951 [09:50:28] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66951 [10:04:01] New patchset: Santhosh; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [10:07:36] New patchset: Pginer; "(bug 49107) Huge icons in language settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66953 [10:09:19] New patchset: Siebrand; "Huge icons in language settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66953 [10:10:38] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66923 [10:11:41] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66953 [10:17:29] New patchset: Pastakhov; "Add Variable handling Functions (version 0.4.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [10:17:59] New patchset: Physikerwelt; "Adding LaTeXML branch to gerrit" [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/66954 [10:18:46] New patchset: J; "Mark active transcodes running for to long as failed" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66955 [10:19:18] New review: Pastakhov; "yet few tests for the function unset" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [10:21:44] New patchset: Nikerabbit; "Introduce Api for loading jquery.i18n json files" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [10:24:49] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [10:24:54] New review: Physikerwelt; "I think I should have pushed this change." [mediawiki/extensions/Math] (LaTeXML); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66954 [10:27:14] New patchset: Nikerabbit; "Hide ULS trigger from unsupported browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [10:28:51] New patchset: Demon; "Allow setting of connection timeouts for HTTP requests using cURL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58247 [10:29:19] New review: Demon; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58247 [10:31:52] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66909 [10:32:23] New patchset: J; "Mark active transcodes running for to long as failed" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66955 [10:34:16] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66923 [10:52:04] New patchset: Santhosh; "Json mimetype is application/json" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66956 [10:53:07] New patchset: Pastakhov; "Add Variable handling Functions (version 0.4.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [10:53:57] New review: Pastakhov; "ready for testing" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [11:01:09] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66956 [11:56:13] New patchset: Santhosh; "Fix: Uncaught TypeError: Cannot read property 'shown' of undefined" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66959 [12:25:21] New patchset: Hashar; "restore 'no space after cast' rule" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [12:27:25] Change merged: Physikerwelt; [mediawiki/extensions/Math] (LaTeXML) - https://gerrit.wikimedia.org/r/66954 [12:29:18] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66959 [12:36:22] New review: Siebrand; "Can "( int )$var" also be considered invalid, as it contains too much whitespace, or is that not pos..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [12:38:27] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66959 [12:45:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66959 [12:53:47] New review: Krinkle; "How are users supposed to read the token to then copy/paste into a tool interface that uses it? Requ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64565 [12:54:47] New review: Amire80; "I might be looking at the wrong thing, but I don't see any difference in display between master and ..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66381 [12:56:18] New review: Krinkle; "To make review easier I'd recommend splitting it up into a commit that changes it and a commit that ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/54089 [12:56:27] New review: Brian Wolff; "This behaviour is essentially the same as the old behaviour, and makes much more sense." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65958 [12:58:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65958 [13:07:26] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66041 [13:07:44] New review: Amire80; "My bad - it was about the border itself and I, as always, looked at the text." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/66381 [13:08:27] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66381 [13:10:13] New patchset: Hashar; "enable Squiz.WhiteSpace.CastSpacing" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66962 [13:10:28] New review: Hashar; "( int )$var" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:14:53] New review: Krinkle; "The spaces inside ( int ) I agree should be invalid. However the space after (int) is valid and in a..." [mediawiki/tools/codesniffer] (master) C: -1; - https://gerrit.wikimedia.org/r/66961 [13:15:26] New patchset: Krinkle; "Enable Generic.Formatting.NoSpaceAfterCast" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:16:54] New patchset: Krinkle; "Enable Generic.Formatting.NoSpaceAfterCast" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:23:50] New review: Hashar; "From a run there is like 60 errors so they are easy to fix :-}" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:28:31] New patchset: Krinkle; "Disable Generic.Formatting.SpaceAfterCast" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66964 [13:28:51] Change merged: Krinkle; [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66964 [13:31:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65295 [13:31:39] New patchset: Alvaro Lopez Tijeras; "Prueba a CodeReview en la rama master" [sandbox] (master) - https://gerrit.wikimedia.org/r/66965 [13:32:22] New patchset: Krinkle; "enable Squiz.WhiteSpace.CastSpacing" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66962 [13:32:45] New review: Krinkle; "It being easy to fix is irrelevant." [mediawiki/tools/codesniffer] (master) C: -1; - https://gerrit.wikimedia.org/r/66961 [13:32:48] New patchset: Hashar; "test: rework interwiki lookup in parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64574 [13:33:10] New review: Krinkle; "Both are easy to fix. It's a one-line find/replace regex. The number of matches does not matter." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:34:27] New review: Hashar; "Quoting you: "There are more useful rules we are currently violating that we should address first."" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:34:34] New patchset: Krinkle; "Enable Squiz.WhiteSpace.CastSpacing" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66962 [13:34:39] Change merged: Krinkle; [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66962 [13:35:26] New patchset: Krinkle; "Update tools/mwcodesniffer submodule" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66966 [13:38:04] New review: Alvaro Lopez Tijeras; "The change looks good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66965 [13:38:05] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/66965 [13:38:30] New review: Krinkle; "The fixability is irrelevant. The words you cite from me are about this rule not mattering for now. ..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [13:38:44] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66966 [13:42:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=49114#c5 [13:42:28] Ugh [13:44:18] nice :D [13:44:54] Reedy: I guess reopen and change summary to PHP5.5: no more provides json :D [13:44:58] New patchset: Alvaro Lopez Tijeras; "Se crea el fichero CodeReview2.txt para probar CodeReview en la rama master" [sandbox] (master) - https://gerrit.wikimedia.org/r/66967 [13:44:58] + a PHP 5.5 tracking bug [13:45:11] and we might want to add something in the installer / upgraded to check that json is available [13:45:39] New patchset: Krinkle; "User: Clean up coding style and documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66879 [13:46:05] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66967 [13:46:57] hashar: Yeah... I just logged a bug for that [13:47:47] Reedy: one day we have to start rewriting that lib under a free license [13:47:52] lol [13:48:20] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/66967 [13:48:27] Althought it's not a WMF blocker, we do need to deal with this somehow for when distros start allowing php 5.5 to anyone easily... [13:48:53] We're not even on PHP 5.4 yet, are we? [13:51:09] 5.3 still [13:51:16] and discussing about 5.4 [13:51:47] we were supposed to talk about it yesterday but the weekly meeting agenda was too dense [13:51:55] so we are going to talk about it next monday :) [13:51:58] New patchset: Zfilipin; "Looks like Bundler moved multi_json a few lines down" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66968 [13:52:20] did we ever mention "we support php version up to 5.x" [13:52:34] we always say "php 5.3+ please" iirc [13:52:41] New patchset: Krinkle; "User: Clean up coding style and documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66879 [14:10:53] New review: Hashar; "Timo, the convention has been introduced a few months ago after much bikeshed : https://www.mediawi..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [14:20:05] liangent: 5.4 is most probably fine :-] [14:20:16] 5.5 is still at RC status but should be mostly fine as well hehe [14:24:27] anyone willing to review a test related change ? https://gerrit.wikimedia.org/r/#/c/64574/2 ;D [14:24:42] that is to prevent the parser tests from looking up interwikis in the database [14:24:55] providing them via a hook instead :D [14:31:49] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [14:40:51] New patchset: Zfilipin; "Updated multi_json Ruby gem" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66973 [14:45:40] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66968 [14:46:10] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66973 [14:57:52] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63274 [15:05:12] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [15:07:17] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65414 [15:14:57] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65009 [15:16:44] New review: Krinkle; "* Put class in a separate file if we keep the class" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63395 [15:18:36] New review: Krinkle; "What much bikeshed and consensus? Are you referring to the irc conversation between Kaldari and your..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [15:23:42] New review: Krinkle; "jsduck index includes "mw.Api.* however it currently fails when I run it because it isn't being mixe..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63382 [15:27:11] New patchset: Alvaro Lopez Tijeras; "Se edita para subirlo como peticion de cambio" [sandbox] (master) - https://gerrit.wikimedia.org/r/66975 [15:35:23] Yippie, build fixed! [15:35:24] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #96: FIXED in 9 min 23 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/96/ [15:41:42] New review: Anomie; "Well, FlaggedRevs doesn't correctly support non-wikitext content types at all yet, does it? ;)" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/65159 [15:42:15] New patchset: Anomie; "mediawiki.icon: Move arrow icons to a separate module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [15:43:24] is rev_sha1 used? [15:43:56] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [15:44:29] Used? [15:45:02] New review: Hashar; "Yeah the one with Chad Niklas and a bunch of other people :-] We can bring that on wikitech-l and ..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [15:45:05] Reedy: I mean it is possible to have it added to api? [15:45:10] and is it functional [15:45:30] I'm not sure if it's been back populated it [15:45:36] But any revisions since then will have it [15:45:41] New review: Anomie; "@Krinkle:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [15:45:42] Can't see any reason it can't be exposed via the API [15:45:44] when is then? [15:45:51] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66975 [15:45:56] Somewhere since 1.19 [15:46:16] which where? [15:46:36] It was added in the 1.19 release cycle of MW [15:46:56] New review: Krinkle; "It's not double the work. You don't modify code while moving it between repositories. I don't think ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [15:47:14] when was 1.19 released? [15:47:54] AzaToth: https://www.mediawiki.org/wiki/Branch_points https://www.mediawiki.org/wiki/MediaWiki_1.19 [15:48:01] Final version released on 2012-05-02 [15:48:18] ok [15:49:38] filed https://bugzilla.wikimedia.org/show_bug.cgi?id=49136 [15:50:00] AzaToth: wait, it's not exposed? [15:50:11] Yippie, build fixed! [15:50:11] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #77: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/77/ [15:50:11] afaik no [15:50:17] Not via the API [15:50:17] i'm pretty sure it is [15:50:20] * MatmaRex checks [15:50:23] it's in xml dumps [15:50:38] it's available os rvprop [15:50:43] but not for query [15:50:49] as* [15:50:53] sure it is [15:50:54] https://pl.wikipedia.org/wiki/Specjalna:ApiSandbox#action=query&prop=revisions&format=json&rvprop=sha1&rvlimit=10&titles=API [15:50:58] ah [15:51:44] so you'd like to query on this. /me wonder if it has an index or whatever [15:51:50] wonders, even. [15:52:16] New review: Alvaro Lopez Tijeras; "No good" [sandbox] (master) C: -1; - https://gerrit.wikimedia.org/r/66975 [15:52:50] MatmaRex: I initially would assume such a field logically was indexed [15:53:59] Yippie, build fixed! [15:53:59] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #94: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/94/ [15:54:07] AzaToth: doesn't seem to be, looking at tables.sql [15:54:15] :( [15:54:21] img_sha1 is indexed [15:54:32] -- Used in API and duplicate search [15:54:32] CREATE INDEX /*i*/img_sha1 ON /*_*/image (img_sha1(10)); [15:56:15] MatmaRex: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=49138 for that [15:57:05] New patchset: Reedy; "Introducing ContentGetParserOutput hook." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [15:57:35] New review: Alvaro Lopez Tijeras; "Please, fix the file Calculator.java" [sandbox] (master) - https://gerrit.wikimedia.org/r/66975 [15:57:37] Because it's used to look for duplicate images [15:58:11] Reedy: well, I want to be able to lookup duplicate revisions [16:01:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [16:01:17] New review: Hashar; "I have posted on wikitech-l about this patch. http://lists.wikimedia.org/pipermail/wikitech-l/2013-J..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [16:02:18] Yippie, build fixed! [16:02:18] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #55: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/55/ [16:03:38] damn wmf-selenium-bot, stop [16:03:47] no need for two posts [16:04:26] * ^demon ignored that bot some time ago [16:04:43] heh [16:16:14] New patchset: Matthias Mullie; "Update unit tests to new aft_claimed_user db column" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66977 [16:21:12] New patchset: Matthias Mullie; "Ignore hooks in User for unittests (it breaks tests/phpunit/phpunit.php)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66978 [16:21:42] New patchset: Alvaro Lopez Tijeras; "Se edita para subirlo como peticion de cambio. Se ha corregido." [sandbox] (master) - https://gerrit.wikimedia.org/r/66975 [16:21:42] New patchset: Alvaro Lopez Tijeras; "Merge branch 'change/66975/1' into addDivideOperation" [sandbox] (master) - https://gerrit.wikimedia.org/r/66979 [16:23:36] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66975 [16:25:02] Change abandoned: Aaron Schulz; "(no reason)" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/65159 [16:25:15] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [16:26:23] Change merged: Alvaro Lopez Tijeras; [sandbox] (master) - https://gerrit.wikimedia.org/r/66975 [16:27:52] Change abandoned: Alvaro Lopez Tijeras; "No es necesario mergear" [sandbox] (master) - https://gerrit.wikimedia.org/r/66979 [16:28:22] New review: Alvaro Lopez Tijeras; "Good" [sandbox] (refs/meta/config) - https://gerrit.wikimedia.org/r/66911 [16:34:29] New patchset: Daniel Kinzler; "More profiling points for WikiPage::doEditContent." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/46945 [16:37:50] New patchset: Daniel Kinzler; "More profiling points for WikiPage::doEditContent." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/46945 [16:45:00] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [16:50:14] New review: Krinkle; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66318 [16:57:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66879 [17:23:55] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66977 [17:24:53] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [17:29:22] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66984 [17:31:26] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66985 [17:31:32] New review: EBernhardson; "WIP. Has a few more updates in the pipeline still." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64212 [17:35:01] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: 2; - https://gerrit.wikimedia.org/r/66955 [17:35:42] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66955 [17:36:28] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66984 [17:37:53] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66985 [17:40:26] ^demon: https://gerrit.wikimedia.org/r/#/c/63818/1 [17:40:47] New patchset: Aaron Schulz; "Simplified IPv6 regex per comment" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66304 [17:45:02] MatmaRex, you poked me about MF on Friday, but I was ill. do you still need help? [17:49:58] New patchset: Zfilipin; "don't run Math/Page tests on test2 without VE support; no AFT prefs on test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66368 [17:50:55] New patchset: Kaldari; "Add Disambiguator extension" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66988 [17:51:31] New review: Kaldari; "Not yet" [mediawiki/core] (wmf/1.22wmf5) C: -1; - https://gerrit.wikimedia.org/r/66988 [17:52:27] New patchset: Aaron Schulz; "Respect content model for viewing stable versions." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/66893 [17:52:51] New review: Aaron Schulz; "Fixed type fatal" [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/66893 [17:53:11] Change merged: Aaron Schulz; [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/66893 [17:53:36] MaxSem: i was figuring out what MF does to the main page [17:54:07] MaxSem: but i think i did figure it out. see the slick new main page at http://pl.m.wikipedia.org/wiki/Strona_główna ~ [17:54:52] is the production parser cache LRU, or is it permenant (i.e. just about guaranteed a wiki article will go through the parser once per revision and then its just stored as html) [17:55:06] MaxSem: a side-note, the mf-* selectors really should use classes, not IDs. i have already used ids on my main page and i do not wish to change them. [17:55:30] meh [17:55:40] where you were like 4 years ago?:P [17:55:50] New review: Zfilipin; "Please be more verbose in commit messages in the future. :)" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66368 [17:55:50] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66368 [17:56:09] ebernhardson: cached for 30 days, i think. [17:56:10] you can just wrap the needed content into extra divs with these ids [17:56:50] New patchset: Zfilipin; "add tests for ULS Input and Fonts" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [17:56:59] MatmaRex_: hmm, ok. That means bad things for me :P Basically thinking about ways to store discussions in Flow and it was mentioned that whatever Liquid Threads does is crazy slow so dont do that. Liquid Threads reads from the parser cache :( [17:58:07] MaxSem: yeah, i did that. but it's silly [17:58:20] ebernhardson: mentioned by whom? [17:58:27] MatmaRex_: jorm [17:58:28] New patchset: Kipcool; "getExpressionsRecordSet: $expression can be null..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66989 [17:58:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=30405 [17:58:43] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66989 [17:59:15] MatmaRex_: do you have other experiences with LT? i would love to hear about them to get a full picture before we start writing a prototype [17:59:25] MatmaRex_: (doesn't have to be now, but sometime) [18:01:38] ebernhardson: not really, but i never noticed this slowness you guys claim to exist, either [18:01:38] unless LqT is dumb enough to do a full reparse every time a thread is loaded [18:01:38] but that would be raving mad [18:01:38] so i hope it doesn't do that [18:01:44] the caches are fast enough for articles, i can't see how they wouldn't be for discussions (unless i'm missing something) [18:03:30] the parsing LQT does is crazy in itself (from a user perspective) [18:05:07] New patchset: J; "set last error if job fails" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66990 [18:06:58] Nemo_bis: how? (genuinely interested) [18:07:13] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66990 [18:07:41] MatmaRex: it's not consistent to start with, e.g. a link in summary is rendered in talk view but not thread view [18:08:17] some templates are expanded in recentchanges but don't work in simpler views [18:08:20] and so on [18:08:47] [weird mass quit] [18:08:51] New review: Zfilipin; "Whitespace problems (see inline comments). I will push whitespace fixes in a minute." [qa/browsertests] (master) C: -1; - https://gerrit.wikimedia.org/r/66307 [18:09:22] New patchset: Katie Horn; "Parsing and using currency-related data in cldr that we hadn't previously touched. Adds a CldrCurrencies class with static functions to access this data" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/65608 [18:10:14] New patchset: Zfilipin; "add tests for ULS Input and Fonts" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [18:14:23] the hell is up withfreenode today. [18:14:32] <^demon> Freenode sucks? [18:15:45] New review: TheDJ; "Ehm, wouldn't you just get it from the atom link on your watchlist ? That seems the most convenient ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [18:15:50] New review: Zfilipin; "I had a question that I would like answered before the code is merged into master." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66307 [18:18:54] New review: Brian Wolff; "I've made some comments at User:Bawolff/review/GWToolset (Since its a bit easier for big reviews the..." [mediawiki/extensions/GWToolset] (master) C: -1; - https://gerrit.wikimedia.org/r/59405 [18:19:09] New patchset: Kipcool; "corrected bug language suggest not working when using language filtering and user language not English." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66992 [18:19:26] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66992 [18:21:46] bawolff: Yay for the curl related comment. Noting also that apache on the cluster cannot make arbitary outbound requests too... [18:22:49] Reedy: I think I've come to the conclusion that I dislike code that doesn't follow MW conventions exactly (Even if its following more hip conventions like namespaces) [18:23:01] lol [18:23:19] I noticed there was a lot of wheel re-inventing going on throughout much of the extension [18:23:26] indeed [18:23:56] Oh, dan-nl's extension? [18:24:06] yeah [18:24:40] That's a shame [18:24:56] I can't remember if it also made it's own entry point somewhere [18:25:30] It adds an extra config file, for if people don't want to use LocalSettings.php(?) [18:25:54] i remember that and being lolno about it before [18:25:58] Hah. [18:26:07] And even more no if he wants it on WMF [18:26:19] I don't think that's the purpose of it [18:26:26] I'm kind of unclear on the workflow for this extension [18:26:57] You upload an xml file, which gives urls, which the extension then uploads to possibly a different wiki using the api [18:26:59] (I think) [18:27:13] Reedy: Ideally the UploadWizard project for GSoC will bring some of his ideas into an existing workflow, and sanify it [18:27:33] Push or pull? [18:27:34] But I get the impression people want this extension installed on commons [18:27:40] Indeed [18:27:52] That suggestion seems familiar [18:27:53] which makes me wonder why its indirectly uploading things over the web api [18:28:22] * bawolff still hasn't dug that far into the extension, could be getting the ideas behind it confused [18:28:40] i wonder if there's a blurb for it [18:28:54] This extension is designed to aid in A by doing B, C and D, helping people to do E... [18:29:22] gj Google [18:29:23] http://commons.wikimedia.org/wiki/Commons:GLAMToolset_project [18:29:24] There is quite a few, for details on this extension, see website X [18:29:34] "The goal of the project is to provide a set of tools to make batch uploads of GLAM content in Wikimedia Commons as easy as possible. The additional tools have to make sure that re-use can easily be tracked; and that Commons materials can easily be integrated back into the collection of the original GLAM or even other GLAMs." [18:30:37] Kind of seems like it would have been better if the extension got reviews well it was being developed, instead of after [18:31:30] Diederik did point this out to them numerous times - "get it in f***ing gerrit" [18:32:19] bawolff: I wondered why it wasn't an app like commonist [18:33:19] Aaron|home: yeah, that seems like it would make the most sense for their use case [18:35:29] New review: TheDJ; "Requires updating of the parser tests." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62207 [18:35:48] New patchset: Umherirrender; "Added tests for new DatabaseBase::upsert" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66994 [18:43:03] "Fetching origin" -> Hallowed are the Ori! [18:43:09] * Krinkle is re-watching some Stargate SG1 [18:43:26] aww [18:43:30] good stuff [18:43:34] oh, Fae too in another channel [18:43:35] :D [18:43:51] Just noticed my git remote is still origin instead of gerrit in some repositories. Looks weird even. [18:44:01] Oh hey, ori-l! Looks like you've got some religious followers [18:45:04] oh? is Susan dumping on my patches again? [18:48:46] New patchset: Matthias Mullie; "Only bind tipsy click events once, or tipsy toggles on and off immediately" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66996 [18:49:53] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66994 [18:51:06] New review: Umherirrender; "There is tableCleanup.inc which does also allow batched processing through a table, but without the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [18:55:08] New review: Umherirrender; "FYI: '-' or the empty string does not disable the message here, see bug 35151" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [18:56:49] New patchset: Esanders; "jQuery.client fixes and improvements." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66998 [18:57:47] New review: Umherirrender; "It is possible to resolve the dependency, remove it or wait/stop with the merge? It is confusing, wh..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496 [18:58:38] ^demon: will gitblit stick? If so,... 1. can I change the "Browse repository" link in the mediawiki.org left-hand nav? [18:59:12] <^demon> Yeah, it's not going away. [18:59:28] <^demon> I just need to clean up the config and puppetizing. [18:59:38] 2. Should the View code changes and Code Review links in the nav change? 3. OK I'll change the {{git file}} template. [18:59:55] congratulations. ooh, colors [19:00:03] New review: Matmarex; "This change depends on the other one, so no, unless we want to abandon them both." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496 [19:00:20] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62157 [19:00:47] <^demon> spagewmf: (2), I've got a change in gerrit to swap that. Am waiting on one thing but I'll take care of it when I'm ready. [19:01:04] <^demon> If this is something you're interested in, there's one thing you could do that would help me a lot... [19:01:25] New review: Krinkle; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66318 [19:02:38] ori-l: Not sure about Susan dumping, but I was referring to [[w:Ori (Stargate)]] in the context of git "fetching origin" and Stargate phrase "Hallowed are the Ori" (the creators of Origin) [19:02:48] New patchset: Matthias Mullie; "Only bind tipsy click events once, or tipsy toggles on and off immediately" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66996 [19:04:22] New patchset: Aaron Schulz; "Refactored WikiPage::updateCategoryCounts() to use upsert()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66999 [19:04:23] ^demon ... yes, what is the One Thing? I'm confused, these are just MediaWiki messages and templates on mediawiki.org that I'll fix. Are you going to make redirects or URL changes? [19:04:24] New patchset: IAlex; "More cleanup when removing accounts with removeUnusedAccounts.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67000 [19:05:01] <^demon> spagewmf: Redirects is what I'm wanting a hand on (haven't had the time). Coming up with some sane rewrite rules to redirect gitweb -> gitblit would help people. [19:05:13] <^demon> So old links and so forth won't go nowhere. [19:05:25] New review: Wizardist; "I'm preparing a patch that resolves the concerns raised by Krinkle (speaking simple words, a Languag..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496 [19:05:57] ^demon if it's Apache mod_rewrite rules I've been there [19:06:04] <^demon> Yep yep [19:06:16] New review: Krinkle; "@Wizardist Yes that is possible. If you need some git magic help, join #wikimedia-dev and ask around." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55496 [19:06:17] Krinkle: http://en.wikipedia.org/wiki/Ori_technology_in_Stargate#Ori_technology yesssss [19:06:55] New review: Aaron Schulz; "I feel like this would be better suited as a (Java?) desktop app like Commonist, unless there is som..." [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [19:06:56] I'm listing these as my tech achievements for the fiscal year [19:08:29] ori-l: haha, nice [19:09:00] Ori Livneh " Ascended being who serves as the main antagonist in gerrit patch set reviews" [19:09:36] binasher: the Parsoid Varnish service created by https://gerrit.wikimedia.org/r/#/c/63890 is completely private. All requests to it are made from our own PHP code. [19:10:13] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [19:12:43] gwicke: great! thanks for clarifying. the only issue i have then is the seeming duplication of purge logic. note that varnish functions (like vcl_recv) defined in .inc files are essentially appended to the end of those functions as defined in wikimedia.vcl. they don't replace or take precedence. [19:13:18] gwicke: why doesn't getParsoidURL() encode the url? [19:13:33] binasher: IIRC the default purge restricts access to localhost [19:13:34] well the title part [19:13:50] Aaron|home: I believe we should encode it, have it on my todo [19:14:18] that's why should have put as a TODO, but I mentioned the wrong function last time [19:14:25] ok [19:14:46] gwicke: wikimedia.vcl contains: if (!client.ip ~ purge) { [19:14:47] Aaron|home: should fix that today, and add logic to only perform some requests initially [19:14:55] so that we can slowly ramp up the load [19:15:03] binasher: https://gerrit.wikimedia.org/r/#/c/57536/4/WebVideoTranscode/WebVideoTranscode.php [19:15:04] gwicke: error 405 "Denied."; [19:15:07] that old code is so wtf [19:15:39] gwicke: note that the 200k limit is still in effect [19:15:39] binasher: exactly- we don't need that check [19:15:44] * Aaron|home never got around to staggering that [19:15:59] gwicke: you aren't replacing that check, you're adding code that would run after it.. and hence never run. [19:16:20] hmm, I thought the order was the other way around [19:16:34] but could well be wrong about that [19:16:37] gwicke: if (!client.ip ~ purge) -- purge == an acl. just define the purge acl to what you want, even 10./8 [19:17:29] New review: Bsitu; "I -2 this for now since this patch depends on 63076 to be deployed and maintenance script to update ..." [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/63572 [19:17:42] Aaron|home: was the 200k limit on refreshLinks or HTMLCacheUpdate? [19:17:52] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: 1; - https://gerrit.wikimedia.org/r/57536 [19:17:59] gwicke: the later [19:18:08] k [19:18:09] binasher: I think that commit is fine now [19:18:24] that is fine for us, template updates are not that critical [19:18:27] Jan wants to get that change done [19:18:38] gwicke: "If multiple subroutines with the the name of one of the builtin ones are defined, they are concatenated in the order in which they appear in the source." https://www.varnish-cache.org/docs/3.0/reference/vcl.html - under multiple subroutines [19:19:39] Aaron|home: will review it today [19:19:47] binasher: can we override the ACL later in the source? [19:19:49] gwicke: I thought the "'X-Parsoid: ' . json_encode( $parsoidInfo )" line was cute...I had to double check the escaping and HTTP spec for that [19:20:32] gwicke: yep. well, you can at least add to it i believe [19:20:56] Aaron|home: yeah, the main limitation is using a single line IIRC [19:21:54] i personally don't see why our varnish servers should accept purges from the entire app server range (10.64/16 in eqiad) even though that isn't how we currently send them purges [19:22:30] *shouldn't [19:23:04] yeah, that would simplify our life a bit [19:23:18] then we would not have to mess with purging at all [19:23:48] I did not find an explicit statement about redefining / extending ACLs in the VCL docs [19:27:20] binasher: The default vcl_recv does not do any purging itself and falls through to specialized versions. Instead other vcl_recv implementations call vcl_recv_purge. So it seems that our code as-is should work. Am I missing something there? [19:30:28] gwicke: you're right - what's in vcl_recv in parsoid-common.inc.vcl.erb is appropriate [19:30:52] gwicke: what's in vcl_miss and vcl_hit is duplicated still [19:30:52] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66999 [19:31:24] New patchset: Mattflaschen; "Fix QUnit issues, such as an incorrect use of OK." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66318 [19:31:28] New review: Krinkle; "I'd rather get other stuff in order first and abandon this for now in favour of the rule being disab..." [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66961 [19:32:30] binasher: definitely the purge logic. Will remove that. [19:32:43] ^demon OK "View code changes" and "Code review" point to git.wikimedia.org. I left "Code review" pointing to gerrit. Next I'll do Template:Git_file [19:33:03] New patchset: TheDJ; "MathJax: Support localizations of MathJax" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67001 [19:33:03] superm401: "OK" ? You mean ok (or assert.ok). Looks a bit odd in caps. [19:33:26] gwicke: cool, i'll merge the next patch set if you'd like [19:33:40] New patchset: Mattflaschen; "Fix QUnit issues, such as an incorrect use of assert.ok." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66318 [19:34:34] binasher: pushed a new version [19:34:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67000 [19:37:43] gwicke: can you rebase too? then i'll merge [19:38:25] binasher: the automatic rebase worked [19:38:46] oh good [19:39:12] binasher: thanks for reviewing! [19:40:27] gwicke: np, it's merged on sockpuppet now as well [19:40:47] awesome, thanks! [19:43:41] binasher: I'm gonna deploy this patchset in labs, then if it passes sanity checks there I'll run puppet on cerium and titanium. Sound good? [19:43:55] RoanKattouw: yup [19:54:11] New patchset: TheDJ; "Remove the $wgHandheldForIPhone config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63343 [19:54:19] 'Catrope deleted instance 'deployment-parsoidcache2' in project [[Nova Resource:Deployment-prep]]' [19:54:30] * Aaron|home shakes his fist at RoanKattouw [19:55:07] New patchset: Matmarex; "Remove unnecessary clears" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [19:55:23] * thedj starts a trout booth, to make some money of this [19:55:24] New review: Matmarex; "I messed with the message, hope you don't mind." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64517 [19:55:42] MatmaRex: mess away :D [19:55:47] :) [19:55:49] Aaron|home: I had to, puppet broke fatally [19:55:54] heh [19:55:56] I'm now building deployment-parsoidcache3 [19:56:01] the 'away' was not intended [19:56:12] (afk) [19:58:07] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63343 [20:08:33] hexmode: greg-g: Still getting complaints from people unable to upgrade to MediaWiki 1.21 (or attempting to do so but getting in a very akward position) due to extension branches still not existing [20:08:40] Who should I ping for this. [20:09:38] Krinkle: Sorry, we should have discussed more in AMS [20:09:41] Aaron|home: Didnt' you write a script to create extension branches retroactively? [20:09:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=48837 [20:10:08] if Aaron has something, I'd love it [20:10:22] I don't recall doing that [20:10:37] Aaron|home: Didn't you create them last time? [20:10:56] sure that wasn't Reedy? [20:10:58] You did them as tags first and then we decided to turn them into branches. I thought you did that. [20:11:08] Yippie, build fixed! [20:11:09] I'm sure it wasn't me [20:11:09] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #77: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/77/ [20:11:17] maybe Chad? [20:11:23] ^demon: maybe? [20:11:44] heh... looks like a job we need to assign to the tarball release manager [20:11:46] :P [20:12:06] <^demon> I had some script. [20:12:18] <^demon> But that was for retro-active. [20:12:29] <^demon> For doing it for current masters, can get by with a git submodule foreach. [20:12:59] ^demon: We need retro-active again for REL1_21 [20:13:18] we should've done that weeks ago when REl1_21 was originally branches from master in core, not when the release happens because then master has already diverged a lot [20:13:25] * apergos eyes ^demon [20:13:33] ^demon: ok, so we need to branch each submodule at the date we branched REL1_21 ... know a good oneliner for that? ;) [20:14:11] <^demon> There's no such thing. [20:14:12] <^demon> http://p.defau.lt/?1E5bloP3bBTbQFvIOWhKIQ [20:14:22] <^demon> That's what I used before, ymmv. [20:15:18] sooooo [20:15:34] I'm looking for someone who can tell me if this [20:15:35] https://gerrit.wikimedia.org/r/#/c/65236/ [20:15:35] that's kind of what I was thinking (the rev-list bit) [20:15:39] is a reasonable approach or what oughta be done differently.... [20:15:47] * apergos eyes ^demon again hopefully [20:15:51] Looks like git has a syntax like git show master@{"2013-03-20"} [20:16:00] it'll take the closest commit before or at that date [20:16:03] Published patchset: Wikinaut; "code cosmetics" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [20:16:16] <^demon> Krinkle: It does, but it only works but so well. [20:16:31] <^demon> If you're looking too far back in the index, it doesn't work. [20:16:37] gwicke: Cannot read file 'parsoid-common.inc.vcl.erb': No such file or directory [20:16:39] ^demon: rev-list seems safer indeed [20:16:40] VCL compliation failed [20:16:46] ^demon: fair enough :) [20:17:05] Should probably be parsoid-common.inc.vcl [20:17:14] ^demon: Can you amend that script to also account for not changing/overwriting existing branches? [20:17:32] ^demon: I'm about to add that script to version control (mediawiki/tools) [20:17:41] Or will you? [20:17:50] Actually that one isn't there either [20:17:50] (./release/make-extension-branches or something) [20:17:52] * RoanKattouw fixes [20:17:53] <^demon> That's just what I copy+pasted from on my disk. [20:18:01] k [20:18:36] I'd like to get this in order today because 1.21.x has been released and people are stuck in upgrade [20:18:45] lots of changes in 1.21 that are breaking [20:19:16] we should probably make it fetch the list from gerrit [20:19:18] Krinkle: where are you seeing all these reports? Not doubting you, just want to know where to look. [20:19:31] hexmode: bugzilla, irc, mw:Support_desk [20:19:38] especially the latter [20:19:58] k, I turned away for a bit from that [20:20:08] <^demon> apergos: I glanced at it, and it *looks* ok, but I haven't looked in-depth yet or tested. [20:20:16] yep [20:20:17] <^demon> And I'm only halfway through paperwork day :) [20:20:33] binasher: Could you merge https://gerrit.wikimedia.org/r/67003 ? Some trivial fixes for the Parsoid VCL stuff [20:20:39] well I am not sure whether that's the right approach for working around the issue too, I dunno about the content models and formats so much [20:20:56] also it's late in my day and revie day in your world so I don't expect instant fix [20:21:06] just to have it on your radar if you're a good person for it [20:21:37] <^demon> It's on my review list, I will take a look. [20:21:47] thanks! [20:21:52] RoanKattouw: merged [20:21:59] Thanks! [20:22:01] Krinkle: do you have time to branch the extensions? I'm up to my neck in work ATM. [20:22:19] New patchset: Physikerwelt; "show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [20:22:22] hexmode: Once there is a working script and if I have the appropiate permissions in Gerrit, yes. [20:22:32] :) [20:22:42] * hexmode PRAYS HARD for a working script [20:22:56] there, any moment now. [20:25:57] New patchset: Physikerwelt; "MathJax: Support localizations of MathJax" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67001 [20:28:32] <^demon> Krinkle, hexmode: Yeah, do what you want with that script. It was a one-off thing I wrote and have no further use for. You're lucky I don't delete stuff from this folder often :) [20:28:54] ^demon: OK. WTFPL ? [20:28:56] binasher: Thanks, it works in labs now, deploying to prod [20:29:16] <^demon> Krinkle: wfm. [20:29:34] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/67001 [20:29:34] Krinkle: I think I can get the script working if you give me a branch date [20:30:54] ^demon: is there a gerrit command to find a list of all extensions in the repo? [20:31:03] New patchset: Wikinaut; "code cosmetics" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [20:31:24] New review: Physikerwelt; "looks good" [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/67001 [20:31:37] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67001 [20:31:42] <^demon> hexmode: `ssh -p 29418 gerrit.wikimedia.org gerrit ls-projects -p mediawiki/extensions` [20:31:55] tyvm [20:33:58] hexmode: $wgExtDistListFile = 'https://gerrit.wikimedia.org/mediawiki-extensions.txt'; . [20:34:02] hexmode: fyi, I'm writing the script now [20:34:45] New patchset: Physikerwelt; "Oups... I did not see the comment mflaschen Revert "MathJax: Support localizations of MathJax"" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67007 [20:35:04] Krinkle: bless you! I just happened to be going crazy with this and two other things. But I did start! I'll let you finish. [20:35:17] binasher: Another trivial one, sorry :( https://gerrit.wikimedia.org/r/67006 [20:35:24] hexmode: Got anything I can use perhaps? [20:36:10] RoanKattouw: that's an important one :) [20:36:21] Krinkle: no, I was just going to use the list, iterate over it, clone each extension, find the rev.... [20:36:25] Yeah :) [20:37:33] hexmode: I'm going with cloning https://gerrit.wikimedia.org/r/p/mediawiki/extensions.git recursively :) [20:37:43] (I think, I'll have to try first) [20:37:58] :) [20:45:01] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #95: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/95/ [20:47:16] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #56: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/56/ [20:49:15] New patchset: TheDJ; "MathJax Localization: Remove language menu" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67009 [20:51:17] New review: TheDJ; "@Matt," [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67001 [21:01:00] New review: Mattflaschen; "Looks good. Let no one fault MathJax's configurability." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/67009 [21:01:16] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67009 [21:04:01] Nikerabbit, (https://bugzilla.wikimedia.org/show_bug.cgi?id=49110) I just successfully created an account on beta, what wiki were you having trouble with? [21:04:43] Krenair: en.wikipedia [21:04:43] (got a proper response page, not blank) [21:05:48] encountered by me and many other team members [21:06:14] strange... it works for me there as well [21:07:04] too tired to test again... is there no logs for beta to check for exceptions or errors [21:07:18] I just need someone to trigger it and I could look up the exception [21:07:31] well, it was triggered recently [21:07:46] less than two hours ago I think [21:08:11] /data/project/logs/exception.log, however it only seems to contain one entry [21:08:24] .... which is from 14:31:20. so your exception should be there... [21:09:15] perhaps it's php error then [21:09:23] since it was a white page [21:10:59] Krenair: just triggered it again [21:11:47] Doesn't appear to be anything in the log... [21:14:53] Krenair: this is not fair, you have to log out :) 21:05, 4 June 2013 User account Krenair (test bug 49110) (Talk | contribs) was created by Krenair (Talk | contribs) (Test bugzilla:49110) [21:15:04] you have to log out? [21:15:22] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Log/newusers shows it's what they did [21:16:06] oh, now I've got a server error in chrome [21:17:15] maybe hashar can tell me why this isn't showing up [21:18:20] bad Krenair not debugging properly and pinging people gratuitously :p [21:20:20] Krenair: not tonight sorry, busy handling some paper work :r( [21:20:28] What would you do instead, Nemo_bis? [21:20:30] ok [21:21:11] Hmmm [21:21:15] let me check out udp2log works properly [21:21:25] it is running on deployment-bastion [21:21:36] 24705 ? Ss 18:31 /usr/bin/udp2log --config-file=/etc/udp2log/mw --daemon --pid-file /var/run/udp2log-mw.pid -p 8420 --recv-queue=524288 [21:22:01] /data/project/logs has some fresh entries so it seems udp2log works [21:22:09] binasher, gwicke: The two Varnishes don't really seem to be sharing their backends correctly (they're supposed to do hash-based load balancing for the backend caches, right?). I tried hitting an uncached URL on cerium, then hitting the same URL on titanium, and titanium didn't have it in cache [21:22:14] from there one can get trace from the database.log / web.log / centralauth.log whatever [21:22:48] RoanKattouw: example request? [21:23:15] Oooooh never mind I'm a friggin' idiot [21:23:23] The X-Cache headers show that it's working [21:23:34] But http://titanium.wm.o/Foo and http://cerium.wm.o/Foo are different URLs [21:23:45] <^demon> Krinkle: Once you guys have those branches, it can be added to the Extension Distributor config too. [21:23:49] Krenair: I'd follow steps to reproduce more carefully ;) but I'm just kidding [21:24:40] RoanKattouw: you need to send the same host header I guess [21:24:43] Yeah [21:24:48] Will do that [21:25:06] I was expecting something to show in exception.log [21:26:29] gwicke: It works! Yay! [21:26:42] RoanKattouw: awesome! [21:27:03] I'll ready the PHP part then so that we can start stressing it [21:29:30] New patchset: Mattflaschen; "The locale must use menuSettings to work with hidden menu." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67014 [21:30:00] New patchset: Platonides; "Follow-up 05077dc3740" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67015 [21:32:37] New review: Mattflaschen; "I should have retested. It turns out menuSettings is the key one (it populates the other), even if ..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67009 [21:33:13] Yippie, build fixed! [21:33:13] New review: Platonides; "Hello Ruud. Please note that hashar example was actually wrong, in that he mistyped ___METHOD__ inst..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65295 [21:33:13] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #68: FIXED in 6 min 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/68/ [21:35:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67015 [21:36:28] Yippie, build fixed! [21:36:29] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #67: FIXED in 5 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/67/ [21:38:03] New patchset: Platonides; "Remove unused global" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67019 [21:39:00] Yippie, build fixed! [21:39:00] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #71: FIXED in 5 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/71/ [21:39:24] New review: TheDJ; "Hmm, perhaps we should simply set both. I see in the source code that it is also doing some font mag..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67014 [21:41:11] Yippie, build fixed! [21:41:12] Project browsertests-sandbox.translatewiki.net-linux-chrome build #80: FIXED in 2 min 11 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/80/ [21:41:18] New review: Platonides; "The revert was abandoned, the code was fixed instead in Ifd8d1d54d5252da958c30cdc0ffa1155ba4cf924" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [21:42:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67019 [21:42:37] New patchset: Mattflaschen; "Set menuSettings.locale" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67014 [21:43:09] Yippie, build fixed! [21:43:09] Project browsertests-sandbox.translatewiki.net-linux-firefox build #110: FIXED in 1 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/110/ [21:43:56] Yippie, build fixed! [21:43:57] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_6 build #54: FIXED in 1 min 36 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_6/54/ [21:44:42] Yippie, build fixed! [21:44:42] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_7 build #54: FIXED in 1 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_7/54/ [21:45:28] Yippie, build fixed! [21:45:29] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_8 build #54: FIXED in 1 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_8/54/ [21:46:27] Yippie, build fixed! [21:46:28] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_9 build #54: FIXED in 1 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_9/54/ [21:49:08] New review: Hashar; "That was a hard to catch typo :/ Well done Platonides!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65295 [21:50:25] New review: Mattflaschen; "You're right about the initial load. But I don't think that's actually necessary, due to https://gi..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67014 [21:51:33] Change merged: TheDJ; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67014 [21:55:40] New patchset: Platonides; "Create the exceptions to be thrown directly, not by using a function to create itself." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67023 [21:55:58] Yippie, build fixed! [21:55:59] Project browsertests-test2.wikipedia.org-linux-chrome build #363: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/363/ [21:57:10] Yippie, build fixed! [21:57:10] Project browsertests-test2.wikipedia.org-linux-firefox build #323: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/323/ [21:58:18] Hmm [21:58:39] Anyone want to help me fix SecurePoll after I seem to have broken part of it by RL-ing it [21:58:39] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SecurePoll.git;a=commitdiff;h=0f6c52f467e04aa1854be03e2e79582a9bc3b16e [21:59:00] Works fine with debug=true, but get Uncaught ReferenceError: securepoll_strike_popup is not defined without it [22:00:03] Krinkle: ^ [22:00:41] Reedy: Checkking [22:00:45] Reedy: Check the js file [22:01:27] https://github.com/wikimedia/mediawiki-extensions-SecurePoll/blob/master/resources/ext.securePoll.js [22:01:37] Reedy: the function is defined just fine [22:01:54] Reedy: The problem is that somewhere in the extension it is trying to access that function as a global function, which it isn't [22:02:19] ResourceLoader forces modules to be self-contained or extending jQuery/mediaWiki/window explicitly if neccecary [22:04:46] Change abandoned: TheDJ; "the revert is not needed anymore." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/67007 [22:08:11] New patchset: Tim Starling; "Allow setting of connection timeouts for HTTP requests using cURL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58247 [22:08:35] 'onclick' => "securepoll_strike_popup(event, $action, $voteId)" [22:08:59] Reedy: 282: $s .= ''; [22:09:07] Ballot.php [22:09:19] that's another one that is horrible [22:09:24] and will break [22:09:43] I might just revert what I did.. [22:09:53] 64: type="button" value="$msgStrike" onclick="securepoll_strike('strike');" /> [22:09:59] Might be easier/quicker than trying to fix everything up that sucks [22:10:21] Yeah, this extension's frontend looks ancient code. [22:10:30] New patchset: Reedy; "Revert "ResourceLoader-ify SecurePoll"" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67026 [22:10:35] New review: Platonides; "In case you wonder whether this was equivalent, it is verified by HtmlCheckMatrixTest::testPlainInst..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67023 [22:10:47] though onclick="" is worse than global functions. That was wrong even 10 years ago in the geocities age [22:10:52] New patchset: Platonides; "Add $wgJobQueueMigrationConfig to DefaultSettings.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67027 [22:10:59] essentially it is doing eval() [22:11:20] New patchset: Reedy; "Revert "ResourceLoader-ify SecurePoll"" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67026 [22:11:28] Change merged: Reedy; [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/67026 [22:12:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58247 [22:12:41] New patchset: Reedy; "Update SecurePoll to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67028 [22:13:04] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/67028 [22:27:48] New patchset: Parent5446; "Added SSL verification to PHPHttpRequest." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54584 [22:29:03] New patchset: Parent5446; "Add $wgJobQueueMigrationConfig to DefaultSettings.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67027 [22:30:06] New patchset: Parent5446; "Add $wgJobQueueMigrationConfig to DefaultSettings.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67027 [22:30:29] New review: Parent5446; "Preferably commit messages should just describe the changes being made, not the mistakes or warnings." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67027 [22:30:37] https://github.com/wikimedia-incubator [22:31:33] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/67027 [22:33:33] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67023 [22:39:04] New patchset: Krinkle; "Implement make-extension-branches" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [22:39:33] Reedy: Could you do a sanity check before I run it? ^ [22:39:52] I've ran it for AJAXPoll without dry-run and with dry-run for all. Seems to work fine. [22:40:19] (AJAXPoll is the first one, tested by adding 'break' at the end of the loop) [22:41:47] New patchset: Parent5446; "Added JobQueue that uses Amazon SQS." [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/51635 [22:41:49] New review: Aaron Schulz; "I didn't add it here as it is just an ad hoc method used to pass configuration information to a scri..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67027 [22:42:20] New patchset: Krinkle; "Implement make-extension-branches" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [22:42:33] New review: Krinkle; "Fixed some odd leading spaces." [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [23:02:30] New patchset: Krinkle; "Installer: Remove wgResourceLoaderMaxQueryLength in LocalSettings" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67033 [23:03:56] New review: Brian Wolff; "Well if the default is the empty string, bug 14176 does not apply" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [23:04:03] New patchset: Krinkle; "Minor clean up" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/67034 [23:11:20] New review: Platonides; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/67023 [23:16:36] New patchset: Krinkle; "Implement make-extension-branches" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [23:16:55] New review: Krinkle; "Added minor space and a documentation comment" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [23:20:49] New patchset: Krinkle; "Implement make-extension-branches" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [23:21:25] New review: Krinkle; "Fixed bug. And merging since this is the script that has been run. Further improvements shall go in ..." [mediawiki/tools/release] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/67031 [23:21:25] Change merged: Krinkle; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/67031 [23:33:58] New patchset: Krinkle; "Fix JSHint warnings:" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/67035 [23:37:42] Published patchset: Wikinaut; "code cosmetics: using our Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [23:39:16] New patchset: Wikinaut; "code cosmetics: using our Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [23:40:41] New review: Matmarex; "There's a patch to move collapsibleTabs to core, this would just cause edit conflicts for no benefit." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/67035 [23:41:09] New patchset: Wikinaut; "code cosmetics: using our Html class" [mediawiki/extensions/AJAXPoll] (master) - https://gerrit.wikimedia.org/r/67002 [23:41:34] New review: Matmarex; "There's also a patch to remove footerCleanup, and there should be one to remove sectionEditLinks as ..." [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/67035 [23:41:59] New review: Hoo man; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/67033 [23:42:47] New review: Wikinaut; "now using Html class" [mediawiki/extensions/AJAXPoll] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/67002 [23:47:04] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Vector] (master) C: -1; - https://gerrit.wikimedia.org/r/67035 [23:58:24] New patchset: Rasel160; "WIP, do not merge. Will allow dynamic form generation in the details step from templates such as Template:Book,Template:Artwork etc. Things left to do: - fixing remove button - fixing hint" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561