[00:00:38] * Jasper_Deng , on an unrelated note, wonders if AzaToth could answer a question about TW [00:01:36] heh [00:01:40] shout [00:22:57] azatoth: i am now. [01:55:46] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/51635 [02:21:10] New patchset: Legoktm; "If the user is in the bot group, mark the edits as bot" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [02:21:18] Susan: ^ [02:21:39] duh: Bless you, my child. [02:21:43] :> [02:22:56] New review: MZMcBride; "(1 comment)" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [02:23:48] sure [02:24:43] duh: Thank you for submitting that. [02:25:04] np. it's been bugging me for a while too. i'll add the comment in a sec [02:25:12] I'm generally annoyed that bug 33461 has been open for over a year. [02:25:27] The Language Engineering team deflected in a nasty way. [02:25:35] Anyway, blergh. [02:26:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=33461#c20 [02:27:19] Hm [02:27:32] I don't think that would work with stuff like Wikibase. [02:27:53] That? [02:28:19] "every extension or other piece of code should using the MediaWiki API to make edits" [02:28:29] Sounds like a bug in Wikibase, then. :-) [02:28:46] The MediaWiki API sanity checks for user permissions, blocks, bot flags, etc. [02:29:12] Which is why large extensions like VisualEditor have been using the MediaWiki API. [02:29:16] It's just saner. [02:29:22] The issue is that you can't edit with action=edit [02:29:29] Wikibase implements it's own editing API [02:29:42] its [02:30:08] Wikibase may be an exception. [02:30:54] I'm not sure how Wikibase works internally. [02:31:09] If it's using the revision/page tables, it should be using the standard interfaces. [02:31:15] If it's not, then it's less important. [02:31:35] That fight is for another day, though. [02:32:43] It uses revision/page, but the data is stored as serialized JSON or something. [02:33:49] Then it sounds like it's just doing a standard edit with non-standard page content. [02:34:05] If that's the case, it should using the MediaWiki API internally. [02:34:13] If it needs to extend the API for outside use, that's fine. [02:34:27] (Please file a bug if you think Wikibase is misbehaving.) [02:35:33] I don't [02:36:30] New patchset: Legoktm; "If the user is in the bot group, mark the edits as bot" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [02:36:37] added the comment [02:36:59] New review: Legoktm; "(1 comment)" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [02:37:00] Wonderful, thanks! [02:37:15] :D [02:40:03] New patchset: Mattflaschen; "Refactor and add support for multiple tours and sticky tours." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66373 [02:43:38] New review: Mattflaschen; "In addition to general feedback, I'm particularly looking for suggestions on the syntax for conditio..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66373 [02:44:33] New patchset: Jalexander; "Add bot flag to edit query" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66374 [02:45:28] Heh. [02:45:52] New review: MZMcBride; "This is a duplicate of Gerrit changeset 66372." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66374 [02:46:05] :/ [02:46:43] Change abandoned: Jalexander; "apparently someone beat me to it, abandoning in favor of earlier submitted patch." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66374 [04:35:05] New patchset: Liangent; "(bug 49072) Handle strings evaluating false correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66375 [04:43:46] New patchset: Liangent; "(bug 49072) Handle strings evaluating false correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66375 [04:46:50] New patchset: Liangent; "(bug 49072) Handle strings evaluating false correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66375 [04:57:55] New patchset: Liangent; "(bug 46634) Handle conversion rules of numeric-only string correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66376 [05:44:18] New patchset: Amire80; "Remove lot of scroll to view related code" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66233 [05:44:46] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66233 [05:44:57] New patchset: Amire80; "Position the language settings in RTL with interlanguage position" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66235 [05:47:44] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66235 [05:51:19] New patchset: Amire80; "Blacklist old browsers" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66330 [05:52:09] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66330 [05:53:57] New patchset: Amire80; "Filter group from Special:LanguageStats when group is not a priority language" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65092 [05:56:41] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65092 [06:28:38] New patchset: Rfaulk; "fix. formatting." [sartoris] (master) - https://gerrit.wikimedia.org/r/66377 [06:29:23] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/66377 [06:37:49] New review: Ori.livneh; "At 1,490 lines, it might be time to split up ext.guidedTour.lib.js into sub-modules." [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/66373 [06:54:36] New patchset: Rfaulk; "add. Test that sartoris correctly implements singleton." [sartoris] (master) - https://gerrit.wikimedia.org/r/66378 [06:55:04] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/66378 [06:55:33] superm401: I find you very frustrating sometimes. [06:56:02] I'm not stopping anyone from submitting the workaround to the Translate extension. [06:56:13] But I agree with Niklas a work around in every extension is not ideal. [06:56:44] Responding to a legitimate bug report with "well, this logic should be something else" rather than just fixing the issue is kind of insane and rude. [06:57:28] Yes, perhaps the logic should be optimized, but regardless, the extension is annoying users who are trying to get work done. [06:57:42] I have to agree with Susan on that part. [06:57:51] (w/o looking at the comments though) [06:57:56] Jasper_Deng, again, I'm not preventing anyone from submitting a change to Translate. [06:58:10] I'm not following that part [06:58:16] superm401: but, I hate the extension in general. [06:58:19] I don't think anyone suggesting you were preventing anything. [06:58:52] Jasper_Deng, there's a core issue where EditPage and the Edit API handle bot flags differently. [06:59:05] It can be worked around in extensions, or the behavior can be changed/fixed in core. [06:59:05] Right. [06:59:07] Or both [06:59:14] And presumably then the extension workarounds can be removed. [06:59:43] superm401: I think that bug's history pretty well demonstrates that by making the bug much larger in scope, it won't get resolved. [06:59:52] That bug is like 18 months old, isn't it? [07:00:04] For a change in the extension that would take maybe five minutes? [07:00:15] SOFIXIT [07:00:27] I filed a separate bug and marked it easy. [07:00:29] I'm not stopping either you or the translate team from submitting that fix. [07:00:39] Susan, it was originally a Translate bug, then it was refiled to core. [07:00:42] No, you're just making it more difficult. :-) [07:00:48] Right, it got hijacked. [07:01:00] The translate team said it should be fixed in core. [07:01:01] I was trying to unhijack it. [07:01:10] Yeah, well, they're wrong. ;-) [07:01:29] Or rather, "should" is a silly reason to defer action here. [07:01:45] There are surely pithy sayings about should that I could insert here. [07:03:22] Good night. If I have a chance, I'll try to do the core fix. [07:03:45] Good night. [07:36:12] New patchset: Pastakhov; "Add Variable handling Functions (version 0.4.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [07:38:09] New patchset: Netbrain; "Added a new parameter to table format. tableheader={left/top} where top is default." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66379 [07:41:32] New patchset: Amire80; "Make cancel reset preferences and apply save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [07:49:13] New patchset: Matmarex; "Cologne Blue: add missing 'undeletethispage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66041 [07:56:55] New patchset: Nikerabbit; "Workaround for border-radius due to bug 49074" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66381 [08:02:39] New patchset: Hashar; "(bug 43571) Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [08:02:56] New review: Hashar; "Rebased to trigger tests using the SQLite backend (which is used by Jenkins)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [08:03:58] New review: Hashar; "PS4 finished the conversion. Will probably work on reordering the list of hooks and polish up the pa..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [08:17:38] plop [08:21:09] New patchset: Amire80; "Make cancel reset preferences and apply save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [08:35:32] New patchset: Nischayn22; "Added support for Captcha" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/66382 [08:50:33] New patchset: IAlex; "Don't show the user a "permissions error" page after he just removed its own rights" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66383 [08:55:16] New patchset: IAlex; "Remove occurence of $wgOut in HTMLForm::displayForm()'s documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66384 [08:55:17] New patchset: QChris; "Set patchSet field for abandon and restore events" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66385 [08:56:25] New patchset: Amire80; "Make cancel reset preferences and apply save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [08:56:38] New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [08:57:42] New patchset: IAlex; "Fix fatal error when $wgValidateAllHtml is enabled and apache_request_headers() does not exists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [08:58:39] New review: QChris; "For abandon/restore messages, hooks-bugzilla currently" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66385 [09:00:13] New patchset: IAlex; "Correct section anchor for post-edit redirect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55508 [09:01:07] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66226 [09:01:08] New review: Santhosh; "I tried this:" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66380 [09:02:42] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66386 [09:03:21] New patchset: QChris; "Fix highlighting of matches in text of escaped html entities" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66387 [09:04:31] New review: QChris; "Merged upstream at" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66387 [09:08:05] New review: Siebrand; "This causes unexpected results for users. They indicate that they want a warning on a wiki, they get..." [mediawiki/extensions/TranslationNotifications] (master) C: -1; - https://gerrit.wikimedia.org/r/66372 [09:14:04] New patchset: Daniel Friesen; "Drop __autoload." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66389 [09:39:27] New patchset: Dan-nl; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [09:42:06] New patchset: Santhosh; "Clicking on the 'Apply Settings' does not close the ULS panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66391 [09:46:25] YuviPanda: uga! [09:46:31] buga? [09:46:32] :D [09:46:37] hello Nikerabbit [09:46:40] actually, I was looking for yurik [09:46:54] yes, happens all the time :P [09:52:19] no more jokes on shoe spouses though [10:01:40] New patchset: Physikerwelt; "Remove non UTF-8 chars from debug output" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66393 [10:03:26] YuviPanda: can you attend a meeting tonight? [10:03:39] how long and when tonight? [10:03:44] and most probably, yes. [10:04:01] let me check if it makes sense [10:09:33] New patchset: Physikerwelt; "show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [10:10:24] New patchset: Physikerwelt; "show debug output in toolbar" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [10:11:53] New review: Physikerwelt; "That change should not depend on anything else." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66394 [10:14:10] YuviPanda: you should have invite from runa [10:22:04] New patchset: Pastakhov; "Add Variable handling Functions (version 0.4.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/66224 [10:23:05] Change abandoned: J; "https://gerrit.wikimedia.org/r/#/c/64912/ was merged so this is no longer needed." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64625 [10:35:55] New patchset: Daniel Friesen; "Support installing PHPUnit using composer." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66395 [10:41:39] Nikerabbit: accepted [10:44:48] New patchset: J; "(bug 44978) loop over authors instead of setting same url" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66396 [10:50:42] Composer really doesn't solve much at all. [10:55:12] Libraries installed by composer are installed locally in a directory relative to what composer.json they were installed frim. [10:56:25] Not globally. And there's no way to synchronize with other composer.json files that aren't composer libraries. [10:57:11] And things are autoloaded so we can't really make MediaWiki Extensions proper composer libraries. [10:57:11] Nikerabbit: I"m off to study now. will come back up about 30 mins before meeting [10:58:05] So that means that any library installed by an extension will be installed inside that extension directory. [10:58:47] And if two extensions require the same library. Then that library will be installed twice and included twice in the autoloader. [11:00:30] Change merged: ArielGlenn; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64840 [11:00:50] DanielFriesen: is that bad? [11:01:09] what is the extensions demand different versions? in this case it's good [11:01:38] New review: Santhosh; "this fixes only one thing, Ensure window is closed when pressing apply button no matter something is..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66391 [11:02:56] MatmaRex: You do realize that two PHP classes of the same name can't exist. Right? There is no using two different versions, only one version is used. This is basically the same fault as if both extensions included the 3rd party code directly in their tarball. [11:03:59] And of course there's no negotiation of what one is actually loaded. [11:04:57] It would be fairly arbitrary based on some inclusion order that causes one autoload file to get priority over the other. [11:06:29] And say extension A requires >=1.1.3 of foo-lib and ends up with 1.1.4 installed. And extension B requires >=1.2.1 and ends up with 1.2.3 installed. [11:07:41] It's perfectly possible for extension A's autoloader to randomly get priority and end up including 1.1.4 despite the fact that it's incompatible with extension B. [11:07:57] DanielFriesen: i was missing the context, and it was unclear what 'library' is here [11:08:41] but okay, php sucks. [11:09:18] composer might be nice for including some libraries into core. [11:11:08] But it solves practically nothing in extensions that I can see. Despite the fact that I've seen people bring it up on the mailing list as if it's a magical fix for our extension troubles and we should make everything to do with extension installation depend on composer and we should use composer for installation instead of building our own proper extension distribution and installation system. [11:13:19] New review: Nikerabbit; "I extended the signup api for the comments, but we could also do it via action=options api directly ..." [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/64591 [11:44:14] New patchset: Amire80; "Make cancel reset preferences and apply save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [11:48:24] New review: ArielGlenn; "There's always "remove' :-P " [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62549 [12:06:45] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [12:10:37] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [12:11:35] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [12:23:37] New patchset: J; "Fix format detection for for video only files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66539 [12:23:44] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66538 [12:23:53] New review: Mwjames; "Please beware of [1], which separates formatting from data gathering, it introduces unit testing (li..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66379 [12:24:25] New patchset: J; "Fix format detection for for video only files" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66539 [12:27:14] New review: Matthias Mullie; "EBernhardson (WMF):" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66239 [12:27:32] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [12:29:01] New patchset: Amire80; "Make "Cancel" reset preferences and "Apply" save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [12:29:49] New review: Mwjames; "Just doing proper assertTag instead of a lazy assertContains" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [12:32:34] New review: VitaliyFilippov; "Hellloooooooooooo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166 [12:44:24] New patchset: Nikerabbit; "Introducing TranslationStash" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66540 [12:46:44] New review: Nikerabbit; "I changed my mind and want to use the options api instead." [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/64588 [13:25:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66364 [13:36:07] plop [13:38:33] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [13:42:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66331 [13:50:36] New patchset: Nikerabbit; "(Bug 46422) convertPlural makes using 0= and 1= rules impossible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62149 [13:51:14] New review: Nikerabbit; "The if ( !count( $forms ) checks should be moved after the explicit plurals in all files" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62149 [13:54:16] New review: Amire80; "A complete solution can be found at I9f5444ffd57ddf46d197ebdb23a18c0c4600b196 ." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66391 [13:54:51] New review: Amire80; "This doesn't seem to resolve the issue for me." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66381 [13:57:32] New review: Santhosh; "but that patch does not have this fix -second argument to callback function is must anyway. This pat..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66391 [13:59:16] New review: Amire80; "Right, I recalled that I noticed a problem with a missing param there." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/66391 [13:59:31] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66391 [14:03:29] New review: Brian Wolff; "I think the increased memory limit should be set as a wg global (e.g. $wgMaxTMHThumbMem or something..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/63418 [14:06:54] New review: Legoktm; "No, they would still get the "new messages" notification since the edit is not marked as minor." [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/66372 [14:23:20] New patchset: Daniel Kinzler; "Make headers in FauxRequest case insensitive" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66251 [14:24:39] Change merged: Reedy; [mediawiki/extensions/AddMetaAndTitle] (master) - https://gerrit.wikimedia.org/r/66349 [14:24:53] Change merged: Reedy; [mediawiki/extensions/AutoCreateCategoryPages] (master) - https://gerrit.wikimedia.org/r/66350 [14:25:08] Change merged: Reedy; [mediawiki/extensions/BlueSpiceExtensions] (master) - https://gerrit.wikimedia.org/r/66351 [14:25:12] Change merged: Reedy; [mediawiki/extensions/BlueSpiceFoundation] (master) - https://gerrit.wikimedia.org/r/66352 [14:25:16] Change merged: Reedy; [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/66353 [14:25:21] Change merged: Reedy; [mediawiki/extensions/MetaDescriptionTag] (master) - https://gerrit.wikimedia.org/r/66354 [14:25:26] Change merged: Reedy; [mediawiki/extensions/MultiAudioVideo] (master) - https://gerrit.wikimedia.org/r/66355 [14:25:34] Change merged: Reedy; [mediawiki/extensions/OracleTextSearch] (master) - https://gerrit.wikimedia.org/r/66356 [14:25:41] Change merged: Reedy; [mediawiki/extensions/RealNames] (master) - https://gerrit.wikimedia.org/r/66357 [14:25:46] Change merged: Reedy; [mediawiki/extensions/SearchRealnames] (master) - https://gerrit.wikimedia.org/r/66358 [14:28:43] New patchset: Hashar; "Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [14:29:08] New review: Hashar; "* cleaned trailing whitespaces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [14:45:18] New review: Hashar; "Thanks for the patch! There are a few minor things that needs to be addressed though :)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65301 [14:48:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66384 [15:04:03] New review: Hashar; "You are so fast. Works for me, thx." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66251 [15:06:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66251 [15:22:17] New patchset: Andrew Bogott; "Switch to using a custom pep8 test for puppet files." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [15:22:41] New patchset: Mdale; "Pop up videos set the autoplay attribute to true" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66551 [15:24:59] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [15:26:11] New review: Hashar; "some subsections had columns in their name which is invalid in doxygen, replaced them with underscore." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [15:33:06] New patchset: Andrew Bogott; "Add a custom job that runs pep8 on each .py file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [15:34:20] New review: Hashar; "Seems good. Note this depends on https://gerrit.wikimedia.org/r/#/c/66552/ so flagging -1 meanwhile." [integration/jenkins-job-builder-config] (master) C: -1; - https://gerrit.wikimedia.org/r/66550 [15:35:45] New review: Hashar; "Will get this a review. I think recent pep8 versions might handle that already but the one on galli..." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [15:36:53] New patchset: Andrew Bogott; "Switch to using a custom pep8 test for puppet files." [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [15:38:29] New review: Hashar; "(1 comment)" [integration/jenkins-job-builder-config] (master) C: -1; - https://gerrit.wikimedia.org/r/66550 [15:56:47] New review: J; "tested and looks ok except for the whitespace." [mediawiki/extensions/TimedMediaHandler] (master); V: 2 - https://gerrit.wikimedia.org/r/66551 [16:06:40] New patchset: J; "Pop up videos set the autoplay attribute to true" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66551 [16:07:14] Change merged: J; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66551 [16:12:57] New review: Parent5446; "To add on, as of PHP 5.3.0, it's impossible to even disable SPL." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/66389 [16:13:23] New patchset: Parent5446; "Handle strings evaluating false correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66375 [16:13:34] New patchset: Parent5446; "Handle conversion rules of numeric-only string correctly" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66376 [16:20:24] New review: Parent5446; "Thanks goodness. I've been hoping for better composer integration." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/66395 [16:38:34] New patchset: Nikerabbit; "Get rid of some ugly global context" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66558 [16:42:08] New patchset: Nikerabbit; "Get rid of some ugly globals" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66559 [16:42:36] New patchset: Nikerabbit; "Get rid of some ugly globals" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66558 [16:44:09] is there something up with jslint? https://integration.wikimedia.org/ci/job/mwext-OpenStackManager-jslint/419/console [16:45:39] New patchset: Nikerabbit; "Get rid of some ugly globals" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66560 [16:51:15] New patchset: Rasel160; "(bug47561) work in progress, do not merge" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/66561 [16:52:41] Nikerabbit: i'm already in the hangout, poke me when you guys are on :) [16:52:54] New review: Nikerabbit; "WFM - no idea why it doesn't work for you." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66381 [16:54:25] New patchset: Krinkle; "mediawiki.legacy.ajax: Wrap Sajax methods in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66265 [16:56:38] YuviPanda: trying to but gmail logs me out constantly [16:56:48] hmm, i used to have that issue [16:56:53] just started using incognito instead [16:56:55] also nobody else is there [16:56:57] is that expected? [16:57:36] it's very nice when it does that in middle of meeting and requires two factor auth to sign back in [16:58:01] hehe [16:58:14] yeah, it was a problem for me doubly since by the time i'm back the meeting is usually done [16:58:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66265 [16:59:53] people coming in [17:09:03] New review: Cmcmahon; "documentation" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65656 [17:09:04] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65656 [17:09:43] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66386 [17:09:43] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66386 [17:10:53] Nikerabbit: now i'm slightly scared [17:11:21] Nikerabbit: 'coz I haven't even read his proposal. [17:11:25] (should do once exams are done) [17:13:18] YuviPanda: don't be :) [17:13:44] Nikerabbit: we should explain to everyone that i'm just a 'technical backup mentor', to make the Panda less scared [17:14:59] I'll serve you a drink [17:18:37] Nikerabbit: can you send me a link to the proposal? [17:21:42] New review: Siebrand; "Can you please fix the code sniffer issues in a follow up?" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66559 [17:22:41] Change abandoned: Demon; "Not necessary since it went in upstream." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64485 [17:23:31] Change abandoned: Demon; "Not needed since upstream" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66387 [17:23:50] New patchset: Hashar; "trigger pep8/pyflakes on integration/jenkins" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66566 [17:24:10] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66566 [17:24:55] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [17:24:57] New review: Hashar; "recheck" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66550 [17:25:15] New review: Hashar; "recheck" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [17:26:59] Change abandoned: Demon; "Went in master upstream, not needed." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/66385 [17:27:17] New patchset: Hashar; "fix job names for integration/jenkins" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66567 [17:27:32] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66567 [17:27:35] New review: Nikerabbit; "You mean the one long line? It was not introduced here, but since you asked nicely I can fix it too." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66559 [17:28:14] New review: Hashar; "recheck" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [17:29:11] New patchset: Hashar; "python jobs for integration/jenkins" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66568 [17:29:32] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/66568 [17:29:53] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66539 [17:37:37] New patchset: Demon; "Sort labels alphabetically by name in the approval table" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64524 [17:37:37] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64524 [17:37:37] New patchset: Demon; "Fix PatchScript's mapping of lines below the last edit" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64444 [17:37:38] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64444 [17:41:36] csteipp: mind joining #wikimedia-labs? [17:42:04] New review: EBernhardson; "I don't know if this is related to the new changes, or just something wonky with the way apis are ha..." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [17:52:01] New review: Nischayn22; "Lots of style suggestions. Please check and correct wherever necessary." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [17:53:04] New patchset: Hashar; "pep8 configuration file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66569 [17:53:45] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66569 [17:54:00] New patchset: Hashar; "Add a custom job that runs pep8 on each .py file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [17:54:54] New review: Hashar; "I wanted to add a pep8 job for integration/jenkins but our pep8 version is way to old and does not s..." [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [18:06:57] New review: Siebrand; "*nod* Indeed the long line. I think it would be good if we slowly worked towards getting to no or a ..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66559 [18:08:06] New review: MarkTraceur; "Moar style suggestions and some thoughts about implementation. Haven't tested but I suspect there wi..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/66561 [18:12:42] New review: Siebrand; "Pointed out two i18n issues inline. There may be more, please check..." [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/59156 [18:18:00] New patchset: Nikerabbit; "Break long line" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66603 [18:25:55] New patchset: Matthias Mullie; "invalidparammix/missingparam get the module prefix twice" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66660 [18:26:48] New review: Matthias Mullie; "Mmh. It's unrelated to this change, but it indeed was incorrect." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [18:27:23] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66559 [18:29:50] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66603 [18:34:32] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66558 [18:36:51] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66560 [18:39:59] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [18:40:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66660 [18:42:38] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [18:47:42] Anyone around who cares about the patrolling system being broken? https://gerrit.wikimedia.org/r/66362 [18:50:04] Whoa, easy review. [18:50:42] marktraceur: But still nobody cares to +2 and deploy it... although people are yet complaining [18:51:13] Same with https://gerrit.wikimedia.org/r/65958 which just restores old behavior I had broken :P [18:52:41] New patchset: Aaron Schulz; "WebRequest::getIP() cleanups." [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66718 [18:53:05] New patchset: Aaron Schulz; "WebRequest::getIP() cleanups." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66722 [18:53:36] ^demon: as in a line that is 250 chars? [18:53:44] <^demon> Yeah. [18:53:48] seems crazy :) [18:53:53] <^demon> It happens :p [18:54:30] * aude writes commit summary in japanese :) then 250 is not so much [18:54:53] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66362 [18:55:26] aude: Don't worry, to compensate you get even less characters in japanese [18:55:38] yep [18:55:42] if its byte based [18:55:47] yep [18:56:38] aude: With the added bonus that we have no idea what you're saying! [18:56:40] New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [18:56:45] lol [18:56:51] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [18:58:35] <^demon> AaronSchulz: I'm more than happy to warn on shorter lengths, but I didn't want to hit valid use cases. [19:00:16] a commit summary entirely in non-ascii wouldn't be nice but could see a use case for including a word or two if it's language related [19:00:22] or whatnot [19:00:59] this could include one of those special german characters [19:01:16] <^demon> Yeah, which is why I figured the defaults of 65 & 70 were far too narrow. [19:01:21] agree [19:01:22] * hoo throws an ß to aude ;) [19:01:26] <^demon> Plus, yelling at someone for 71 chars was lame. [19:01:26] heh [19:01:28] <^demon> :) [19:07:18] New patchset: Kipcool; "Enabling sorting by part of speech (or any other annotation)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66822 [19:08:19] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66722 [19:09:52] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66718 [19:11:04] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/66239 [19:11:19] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66822 [19:11:47] AaronSchulz: Are you about to deploy the new core version? [19:12:11] We should probably backport https://gerrit.wikimedia.org/r/66362 [19:12:19] I was just going to do some backports [19:12:55] :) [19:13:04] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [19:14:27] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [19:16:12] New patchset: Aaron Schulz; "Fix edit patrolling in multi Diffs" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66867 [19:20:58] ^demon: https://gerrit.wikimedia.org/r/#/c/66174/ easy [19:23:41] Change merged: Demon; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/66344 [19:24:52] that needs deployment [19:25:38] i can do it, but you shouldn't expect it to be auto [19:28:22] New review: Dzahn; "deployed on kaulen. please don't expect it to auto-deploy though. this is delibarately not pulled by..." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/66344 [19:32:49] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [19:33:33] New review: Demon; "Yeah, I knew it wouldn't. Figured it'd be pushed out by someone :)" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/66344 [19:34:49] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66867 [19:35:10] Change merged: jenkins-bot; [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/66174 [19:41:43] anomie: care to have a look at https://gerrit.wikimedia.org/r/#/c/28199/ ? [19:41:57] hithas been sitting there for some time now, it's beginning to smell :P [19:45:42] Change abandoned: Krinkle; "Superseded by I1b963b6e1" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/63346 [19:54:59] Yaay, bawolff, gratz on the new gig :) [19:55:08] marktraceur: Thanks :) [20:02:41] https://bugzilla.wikimedia.org/describecomponents.cgi?product=Wikimedia [20:05:22] New patchset: Yurik; "Windows /dev/null is "NUL"" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/66870 [20:08:43] ori-l, i forgot, did you do anything to make it so that multiple vagrant instances can use a shared mediawiki dir? [20:11:01] So I got an email about OIT orientation, but nobody is in the google hangout... [20:11:22] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #73: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/73/ [20:11:27] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #93: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/93/ [20:11:28] I know UIT but not OIT [20:12:13] office IT i'm assuming [20:12:35] New patchset: Amire80; "Make "Cancel" reset preferences and "Apply" save and close" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66380 [20:14:20] yes, Office IT [20:27:15] Krinkle: favicon "proxy" redirect merged but won't work like that for $reason [20:27:30] still gives me 404 [20:29:22] mutante: I think it might be related to the leading slash [20:29:41] some apaches include it in what they match against path, some do not [20:29:46] I'm not sure why some do and some dont [20:30:05] hmm, actually tried that already.. looking more [20:30:14] oh [20:30:28] mutante: Is RewriteEngine On ? [20:31:47] heh, likely not.. but just tried that too [20:33:12] mutante: Anything in error logs? [20:33:53] Krinkle: got it, it was a combination of both those things, slash and engine not being on, fixing [20:34:06] Thx [20:34:18] https://doc.wikimedia.org/favicon.ico [20:37:00] RoanKattouw: I wish grep had a "don't follow symlinks options"...not seeing one in man [20:37:05] meh, I'll just exclude .git [20:37:16] AaronSchulz: Use ack-grep ;) [20:37:39] It auto-excludes .git and understands conventional extensions for things so it has flags like --php and --js [20:37:42] still too much noise [20:42:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #75: FAILURE in 18 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/75/ [20:45:24] AaronSchulz: http://savannah.gnu.org/patch/?4354 [20:48:55] \o/ [20:51:35] mutante: Is there a gerrit change I can look at? [20:51:51] Krinkle: in a minute [20:51:53] ok [20:51:59] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #53: FAILURE in 9 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/53/ [21:10:53] Change merged: jenkins-bot; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/64931 [21:10:58] New patchset: Cmcmahon; "Explicitly require json gem to avoid warning message on Linux and Windows" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66281 [21:11:44] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/66281 [21:11:44] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66281 [21:15:43] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #65: FAILURE in 6 min 10 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/65/ [21:21:31] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #69: FAILURE in 8 min 44 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/69/ [21:22:34] Change abandoned: Krinkle; "(no reason)" [mediawiki/extensions/Agora] (master) - https://gerrit.wikimedia.org/r/35804 [21:31:08] New patchset: Hashar; "Add a custom job that runs pep8 on each .py file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [21:32:03] jorm: wanted to have some communication regarding flow and twinkle of possible [21:32:11] if* [21:32:17] of course. [21:32:21] how so? [21:33:24] it's really difficult to get a picture how far flow will go, and how much of current procedure that will be obsolete or impossible [21:34:03] you said you will parse new section from bots/scripts right? [21:35:08] "How will Twinkle work? Simple: we grab the hook off "create section,"" [21:35:20] yes. [21:35:31] I wonder why you think that would work, as twinlke is not using create section [21:35:41] New review: Hashar; "This new patchset enhance the previous versions:" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [21:35:47] was too much hassly to try to make it work with section new [21:36:04] so it uses append directly with the section in wiki code [21:36:29] well, we're going to be building a full API about it. Ideally, tw can move to the API. I'm certain we'll be able to set aside development time to help the maintainers, or even do it ourselves. [21:36:58] ideally? [21:37:00] well, you have a rare opportunity with flow to go to a properly defined API to interact with instead of regexp and wikitext. I doubt anyone knows exactly wht it will look like yet but with your help and others to flesh out the requirements its a possibility [21:37:06] i wasn't aware that tw just used append; that's interesting. [21:37:08] I would assume using the api is the only way [21:37:33] hey, there's mer bernhardson right now. [21:37:39] it's basically due to it needs to use different levels of headings [21:37:43] jorm: just wondering – you keep mentioning "helping the maintainers" etc [21:37:44] azatoth, meet erik. erik, azatoth. [21:37:49] does that apply to all the hundreds of wikis? :/ [21:37:58] hi azatoth :) i'm helping spec out the backend for flow [21:38:05] ebernhardson: ah, I see [21:38:08] hopefully start on a prototype soonish [21:38:17] erik is *freshly* tasked with flow, and is a developer. [21:38:29] matmarex: i'm not sure i understand what you're asking? [21:38:31] New patchset: Ryan Lane; "Add Display Quotas action to Special:NovaProject" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [21:39:07] I think flow pages needs to be able to categorize, so different related discussions can be bound together under a heading [21:39:59] jorm: i'm duly noting that you're offloading work on users (but okay, this is understandable, new tools always have to be catered to) [21:40:06] but i also find your arguments about wikitext not being implementable hard to believe [21:40:19] and frankly inconsistent [21:41:09] AzaToth: there will be an "unstructured" area to handle that. in an ideal world, we wouldn't need it (maintenance templates would become tags, etc.) but we are where we are. [21:41:43] New patchset: Andrew Bogott; "Add a custom job that runs pep8 on each .py file" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [21:41:50] MatmaRex: You should talk with gabriel, then, about what the Parsoid can and cannot do with ease. [21:42:03] But either way, I think you can understand the need to *start* with the Visual Editor. [21:42:16] jorm: "unstructured area" sounds like a temporary hack [21:42:16] Change merged: Andrew Bogott; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66552 [21:42:29] Like how LQT has a "top section" [21:42:42] jorm: no, i don't. [21:42:43] haven't used lqt much [21:43:02] jorm: and i think the VE team has already mostly solved the issues with editing templates [21:43:08] or at least they're working on this extensively [21:43:11] AzaToth: It *should* be a temporary hack, but we know how long it will take to get to a point where we have structured metadata about articles/pages. So there's that. [21:43:16] and not just simple ones like the ones used on talk pages [21:43:23] which usually don't even take parameters or anything [21:43:35] AzaToth: when i hear unstructured area, basically what i'm hearing is 'a block of wiki text to be displayed before the discussion' So basically it covers all the use cases we couldn't cover in the first pass. I suppose by definition that is a hack, hopefully temporary :) [21:44:06] I know they're working on it extensively, but as I said, we cannot design based on "what ifs"; we have to assume that the tools available today are what we have. And if it comes down that, by the time Flow launches, the VE can handle tons of templates, well, there we go. [21:44:10] jorm: in short, if VE sucks so bad that it can't handle a {{done}} somewhere, it should just be scrapped already, and the resources allocated into something useful. [21:44:20] but as far as i can see this is not the case [21:44:24] but you seem to try to convince people to believe in that [21:44:37] jorm: heh, you're being inconsitent again [21:44:46] there is *no* working visual editor right now [21:44:52] and you've cheerfully assumed it [21:45:10] i don't think that's inconsistent at all. [21:45:11] right now you could implement plaintext or wikitext [21:45:49] and i think the current featureset supported by the VE is perfectly adequate for a discussion system. [21:45:51] ebernhardson: I would then assume that 99%+ of all "user talk/discussion" will end up in the unstructured area [21:46:02] jorm: it doesn't *work*. have you tried it? [21:46:03] it isn't for a *workflow* system, though, which is where our problems arise. [21:46:08] jorm: it's getting there, sure [21:46:14] just like the template support is getting there [21:46:16] Okay. Well, you'll have to take that up with the VE team. [21:46:43] AzaToth: that would be quite unfortunate, so whats the better option for supporting all the workflows we cant support in the first prototypes? [21:46:44] no, you're the one attempting to convince me VE can support discussion, but can't support templates, and this is false [21:46:48] :/ [21:47:57] ebernhardson: if warnings shall go to the notification system, then perhaps focus on getting that working before making flow live [21:48:19] warnings should be actual workflows. [21:48:24] users should have to acknowledge them. [21:48:28] i'm not even talking about warnings [21:48:39] i'm talking about templates like {{done}} or {{tl}} [21:48:42] i can see us enforcing stuff, too. you get a warning, and then until you've ack'd it, you can't save article stuff. [21:49:24] jorm: will those kind of rules be maintainable from the wiki pov, or is it something only devs can implement? [21:49:42] no, the point is that the local wikis get to decide those rules. [21:49:49] and design their workflows. [21:50:01] decide yes, but can they implement them by them self? [21:50:06] the canonical use case is block/unblock request. [21:50:07] yes, thats the goal [21:50:09] yes, that's the plan. [21:50:37] we're going to build a bunch of tools - say, give a big ass box of lego bricks - and the local wikis can then build workflows using those tools. [21:50:45] :> [21:50:54] * legoktm hugs jorm  [21:50:57] dont make it visual basic [21:51:08] *that* is what flow *actually* is (a workflow management system) - it's even where the name *comes from*. [21:51:08] we'll put the ++ in visual basic :P [21:51:12] * legoktm now scrolls up to see how legos got mentioned [21:51:33] but the easiest way to start understanding what Flow is about is with understanding a discussion system. [21:51:49] discussions are workflows, right? [21:51:55] New review: Tim Starling; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/58247 [21:52:15] * AzaToth needs to learn what "workflow" actually means forst [21:52:41] in many places, the workflow for a user-to-user discussion currently is: 1) user A leaves a message. 2) User B responds. 3) Eventually the discussion gets archived. [21:52:48] "A workflow consists of a sequence of connected steps. Emphasis is on the flow paradigm, where each step follows the precedent without delay or gap and ends just before the subsequent step may begin" [21:52:52] (very simplistic, but there's a set of steps) [21:53:07] no gaps? [21:53:10] right. you've installed software before? [21:53:20] afaik, discussions have many gaps and/or delays [21:53:28] jorm: please acknowledge :( [21:53:36] "gap" in that description means "there's no wait between the ability to move between states" [21:53:49] the system is "readY' [21:53:56] even if it is lying dormant. [21:54:00] jorm: I'm on linux, we don't "install" software :-P [21:54:03] true [21:54:07] sure you do. [21:54:41] New review: EBernhardson; "A couple tiny concerns, in general this looks to be good. I will only be able to +1 this after the ..." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [21:54:42] just had problem connecting discussions as workflows [21:55:02] here's the linux install workflow: 1) download tarball. 2) tar xcfvp - software.tar.gz. 3) cd software/ 4) ./configure 5) make 6) make install [21:55:22] I know, I was sarcastic [21:55:28] a discussion workflow is; 1) i talk. 2) you talk 3) i talk. 4) you talk. [21:55:50] MatmaRex: acknowledge what? [21:56:09] jorm: he wants to knos if {{done}} and {{tl}} will be possible in flow [21:56:12] [23:48] i'm not even talking about warnings i'm talking about templates like {{done}} or {{tl}} [21:56:50] Jorm: My install workflow is apt-get install foo; Warning, need to uninstall X11 due to dependency conflict; sit down and cry [21:56:58] i'm not able to answer with any certainty that won't have people saying that i'm being inconsistent. [21:57:12] ain't that always the truth, bawolff. [21:57:20] "No, please do not install this security hole on my server." [21:57:21] jorm: i was expecting more from you than such a non-answer, eh [21:57:33] i'm trying to answer you. [21:57:47] you're bringing up implementation details like these, expect questions about them :/ [21:58:00] the answer is "we're going to use the visual editor. if the visual editor can support things, great. if not, that's where we are." [21:58:31] personally, i think that requiring people to type {{done}} is just weird, and you should be able to insert something like that from a menu. but that's me. [21:58:36] MatmaRex: i may be naive, but i'm willing to trust in the visual editor team. Their page currently says " In Parsoid, we plan to support unexpanded template round-tripping at first (so the page will not be WYSIWYG wrt templates). Editing with expanded templates will then likely follow later." [21:59:00] jorm: thanks, that's more like the answer i was hoping for :) [21:59:10] Ah, Gabriel's away because he's still in Germany. [21:59:14] jorm: having all possible permutations of all possible ways to express yourself in a menu is a recipe for disaster [21:59:15] That explains a lot. [21:59:15] you seemed to be unequivocally discarding templates earlier [21:59:38] ebernhardson: i'm lurking in their irc channel, and the templates support is moving, as far as i can see [21:59:50] jorm: and personally I hate trying to find something in a menu when I know how to type it, but is prevented to do it [21:59:51] i have to design for the Worst Case, and that's the Worst Case, and it's better to take a hard line now and soften later. [21:59:59] ebernhardson: also, have you tied it sometime recently? [22:00:08] ideally you could probably enter a search-ahead template mode. [22:00:17] like how emacs works with functions. [22:00:25] * AzaToth uses vim [22:00:27] autocomplete, etc. [22:00:32] well, now we must fight. [22:00:45] * AzaToth rolls up his sleves [22:00:45] MatmaRex: yes, and its probably short of beta-quality as it curently stands, but the amount of work required to even get that far makes my head spin [22:01:03] ebernhardson: currently you can remove the templates, and i'm pretty sure you could insert them as well with some funcitons which are not yet exposed in the interface [22:01:14] MatmaRex: essentially, i'm glad that visual editor isn't my problem, because it sounds like a damn hard one :) [22:01:17] ebernhardson: it's really an UI matter right now, i think [22:01:36] ebernhardson: the visual editor is not the hard part, it's parsoid that is [22:01:51] AzaToth: well, yea i suppose i get the two confused. Its the round tripping that sounds incredibly hard [22:01:58] yea [22:02:13] parsoid is like making something possible which isn't [22:02:13] (sorry guys, be back in 15 minutes.) [22:03:47] okay. i REALLY need to knuckle down and work on the next iteration of the flow prototype [22:04:56] anyways, for the 1% of user discussions (those that are not warnings or automated notices) I don't think a strict threaded discussion model is optimal; Often you might need to have a scratchpad area for all participants to be able to edit in to evolve ideas and so [22:06:25] New patchset: Krinkle; "User: Clean up coding style and documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66879 [22:06:47] a mini-wiki-page might be possible [22:07:03] New review: Spage; "Not sure about automatically normalized arrays" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [22:07:37] AzaToth: sounds reasonable, I will add it to the list of things to think about (everything is mostly in the thinking stage still, no code written) [22:08:13] ebernhardson: afaik, you have that "prototype" [22:09:26] AzaToth: prototype hasn't been started yet :) so far just wiki pages discussing everything from concept/user research/etc. [22:09:33] and some UML floating around [22:09:39] hmm [22:10:08] so http://unicorn.wmflabs.org/flow/ doesn't exists? [22:10:11] at least, i was under the impression me and mlitn were supposed to be starting on the prototype soon, and that nothing is written yet [22:10:28] * AzaToth goes back to his time machine [22:10:32] we are still finishing up Echo stuff, and a few other things the team is on [22:11:46] seems to be jorm's prototype [22:12:31] oh, yea sorry i'm a backend guy so i consider a javascript prototype to be the irrelevant half :P [22:12:48] (Trying to be funnyish) [22:13:29] but basically jorm has the prototype for what the front end will looklike/how it might work, but there is nothing written in the backend for that to interact with. Thats what i'll be working on [22:15:11] New patchset: Ryan Lane; "Add Display Quotas action to Special:NovaProject" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [22:17:38] oh [22:17:40] I see [22:20:12] back. did i miss anything? [22:23:26] New review: EBernhardson; "This all looks good, i don't have +2 yet or i would." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64620 [22:26:56] New review: Mwalker; "This is no longer relevant -- covered in a different repo. Now; why can I not freaking abandon the c..." [wikimedia/fundraising/civicrm] (master) C: -2; - https://gerrit.wikimedia.org/r/53653 [22:27:41] mwalker: *I* can't abandon or rebase that change, and I'm a Gerrit admin. WTF. [22:27:48] And you own the change, too [22:27:53] I know! [22:28:07] it doesn't make sense [22:30:21] New patchset: Brian Wolff; "Change autocomment-prefix to be blank. Looks weird being '- '" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [22:31:22] New patchset: Wikinaut; "Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [22:32:06] New review: Wikinaut; "just rebased" [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/66139 [22:33:01] New review: Wikinaut; "Iboyinc: please can you check and give your +1 to the latest patch set, if you also think that this ..." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [22:52:58] New review: Andrew Bogott; "This will be useful! I few small questions in line. Are you planning to add a GUI for changing quo..." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [22:58:25] New patchset: Brian Wolff; "Change autocomment-prefix to be blank. Looks weird being '- '" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [22:59:18] New review: Brian Wolff; "PS2: fix parser test to account for this change" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66883 [23:02:35] New review: Ryan Lane; "I do plan on adding a GUI for modifying quotas. It's a little harder as it requires the use of nova'..." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [23:02:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #67: FAILURE in 5.2 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/67/ [23:03:14] Project browsertests-sandbox.translatewiki.net-linux-chrome build #79: FAILURE in 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/79/ [23:03:19] Project browsertests-sandbox.translatewiki.net-linux-firefox build #109: FAILURE in 5.1 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/109/ [23:03:24] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_6 build #53: FAILURE in 5.2 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_6/53/ [23:03:30] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_7 build #53: FAILURE in 5.3 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_7/53/ [23:03:35] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_8 build #53: FAILURE in 5.3 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_8/53/ [23:03:40] Project browsertests-sandbox.translatewiki.net-windows-internet_explorer_9 build #53: FAILURE in 5.2 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-windows-internet_explorer_9/53/ [23:05:43] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [23:11:44] New patchset: Ryan Lane; "Add Display Quotas action to Special:NovaProject" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [23:14:52] New review: Ryan Lane; "Fixed issues mentioned in the comments." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66303 [23:24:51] New patchset: Mwjames; "Use SMW\TableFormatter for the table query printer (SMWTableResultPrinter)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [23:26:10] New review: Spage; "I have a patch addressing some of Matt's comments. But obviously if server-side logging moves out of..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [23:34:36] New review: Mwjames; "Works for both a tables types now (standard and transpose), tests cover both tables types as well." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66537 [23:39:59] New patchset: Krinkle; "remove invalid comment from SkinVector::setupSkinUserCss" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59603 [23:44:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59603 [23:44:21] New patchset: Krinkle; "jquery.makeCollapsible: cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [23:46:23] New patchset: Krinkle; "Adjust efDoDiscussionLink() after changes in core" [mediawiki/extensions/DiscussionThreading] (master) - https://gerrit.wikimedia.org/r/64369 [23:47:06] New patchset: Basti2342; "German translation updated" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/66884 [23:53:29] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [23:53:38] New review: Krinkle; "It appears this change breaks one of the test cases on this page:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/55466 [23:56:19] New review: Krinkle; "Screenshots:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55466 [23:57:45] New patchset: MarkTraceur; "Add some tests to cover do_transaction" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/66886 [23:57:46] *sigh* that patch.