[00:04:55] New patchset: Mwalker; "Allow MW and extensions to declare included components" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66054 [00:08:55] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/57662 [00:12:44] New patchset: Mwalker; "Further Cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [00:12:52] New patchset: Mwalker; "Allow MW and extensions to declare included components" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66054 [00:20:59] New patchset: Bsitu; "(bug 47912) Visiting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [00:28:52] New patchset: Bsitu; "(bug 47912) Visiting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [00:34:42] Yippie, build fixed! [00:34:42] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #56: FIXED in 6 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/56/ [00:41:22] can gerrit show me the difference between patch sets? [00:43:13] so, instead of showing a diff from HEAD^ and the patch, can i see the difference between patch set 7 and patch set 8? [00:48:09] yes -- it's the "Old Version History" drop down on the patchset page [00:48:32] oh [00:48:36] I see what you're getting at [00:48:41] no -- not to the best of my knowledge [00:53:40] Reedy: Have you seen https://gerrit.wikimedia.org/r/65958 ? If you don't consider it important, ok... but I'm not especially looking forward to get blamed for that in broken English by $sisterProjectUsers [01:17:51] New patchset: Mwjames; "SMW\ParserParameterFormatter code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66058 [01:19:40] Published patchset: Parent5446; "Added file backend support for Amazon S3." [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/52089 [01:19:46] Change merged: Parent5446; [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/52089 [01:20:50] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66058 [01:25:02] New review: Kaldari; "It looks like this change adds the 'mark as patrolled' link to every new page regardless of whether ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [01:30:18] New patchset: Mwjames; "Remove smwfLoadExtensionMessages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66059 [01:34:13] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66059 [01:44:27] New review: Bsitu; "I agree with what kaldari said, [Mark this page as patrolled] link should be only shown if the page ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [01:45:08] New review: Mattflaschen; "Looks good. You could add a note to the commit message noting the message change, but you don't hav..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65867 [01:46:19] Yippie, build fixed! [01:46:19] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #44: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/44/ [02:25:52] does anyone have any advice on uploading wikipedia dump files to S3? [02:36:46] New patchset: Mwjames; "GlobalFunctions code coverage" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66060 [02:40:44] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66060 [02:41:32] New patchset: Mwjames; "SMW\Test\CacheHandler be explicit about test conditions" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66061 [02:44:38] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66061 [02:47:43] New patchset: Kaldari; "Add preliminary support for displaying images/videos in modal viewers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66062 [02:49:59] New patchset: Kaldari; "Respect new 'modal' file param if present." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66063 [02:50:31] New patchset: Kaldari; "Respect new 'modal' file param if present." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66063 [02:59:15] New patchset: Kaldari; "Add preliminary support for displaying images/videos in modal viewers" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66062 [03:16:39] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [03:44:27] New patchset: Bsitu; "(bug 47912) Visiting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [03:55:56] New review: Ori.livneh; "The problem that this change attempts to address is real, but I'm not convinced that this is the rig..." [mediawiki/vagrant] (master) C: -1; - https://gerrit.wikimedia.org/r/64609 [04:20:14] New review: PleaseStand; "The extension seems to work fine for me on PHP 5.4.6 as well, aside from a small problem with the Ma..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64840 [05:26:47] New patchset: Umherirrender; "Show rollback link on changes list only for RC_EDIT" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66064 [05:32:01] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65952 [05:41:17] New review: Mattflaschen; "I know (just from reading the READMEs the extension is to beat the performance of pure PHP), but I d..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64840 [06:02:58] New patchset: Santhosh; "Fix ULS positioning" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65967 [06:06:33] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65967 [06:08:40] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65966 [06:15:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65449 [06:46:06] New review: Mattflaschen; "I'll change removeCookie to take a guider." [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/65005 [06:52:57] New review: Ori.livneh; "Code looks good; verified on Toro." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/65005 [06:53:06] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [06:54:14] New review: Santhosh; "This functionality can be done without javascript" [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/65594 [06:58:19] New patchset: Physikerwelt; "Adjustments to the Math extension" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/66065 [06:58:21] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66014 [07:02:04] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/66065 [07:12:33] New review: Nikerabbit; "Santhosh: not really, since we want to make the highlighted row lighter without altering the current..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [07:28:49] hello [07:29:20] hi hashar [07:29:49] hashar: I kind of lost the discussion yesterday... would it be difficult to setup separate solr for labs? [07:40:59] New patchset: Hashar; "benchmarks: README file having run recommendations" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66066 [07:46:08] 09.29 < Nikerabbit> hi hashar [07:46:08] 09.29 < Nikerabbit> hashar: I kind of lost the discussion yesterday... would it be difficult to setup separate solr for labs? [07:46:29] Nemo_bis: thx :-D [07:46:55] Nikerabbit: we might have some people working on solr already. I am pretty sure Chad started working on that [07:46:59] but not in beta [07:47:10] that would require: 1) an instance (easy) 2) puppet manifests [07:47:15] definitely need to get ops involved [07:59:35] New patchset: Physikerwelt; "Calculate HTTP POST data in separate method for debugging" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/66067 [08:01:37] Change abandoned: Physikerwelt; "outdated" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65873 [08:03:52] New review: Hashar; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66062 [08:04:13] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/66067 [08:09:57] hashar: we have puppet manifests [08:12:23] Nikerabbit: a deployment-solr instance already exist https://wikitech.wikimedia.org/wiki/Nova_Resource:I-000006d7 :D [08:12:39] with a role::solr::geodata::labs class [08:16:19] hashar: hmm? [08:16:26] ahhh [08:16:28] :-D [08:16:28] hashar: but that is for geodata [08:16:35] tm needs separate instance [08:16:37] I have no clue [08:16:42] what do you want solr for ? [08:16:50] is that to replace lucene search ? [08:17:37] hashar: for translation memory & translation search [08:17:58] maybe create a deployment-solr-translate extension [08:18:03] apply the puppet manifest on it [08:18:12] then alter the mediawiki-config for labs to point to it [08:18:16] I will help :-] [08:19:33] hmm [08:25:26] it's been a while since I've been creating instances [08:26:23] Nikerabbit: seems I need to add you to the project :D [08:27:32] Nikerabbit: I have granted you access on deployment-prep + sudo right [08:44:11] New review: Hashar; "* mostly comment changes" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64563 [08:46:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64563 [08:47:40] I HATE PHP (again) [08:47:46] php > require( '/dev/null' ); [08:47:46] Warning: require(/dev/null): failed to open stream: Undefined error: 0 in php shell code on line 1 [08:47:48] I mean… wtf? [08:48:42] New review: Nikerabbit; "In RTL language, the arrows on edit page are on the wrong side and overlap the text." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/53802 [08:51:20] hashar: that should be require '/dev/null'; [08:53:49] bouncer service: Nikerabbit> hashar: that should be require '/dev/null'; [08:55:37] Nemo_bis: I did use a quoted string :-D [08:55:48] try it :-] [08:56:30] seems we can't open /dev/null [08:57:26] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [09:02:34] New patchset: Hashar; "mwdocgen.php going to require a LocalSettings.php" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66071 [09:03:10] New review: Hashar; "The wrapping script we use will create an empty LocalSettings.php file as of https://gerrit.wikimed..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64866 [09:05:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [09:17:38] New review: Nikerabbit; "Works perfectly in ltr and rtl." [mediawiki/extensions/Vector] (master) C: 2; - https://gerrit.wikimedia.org/r/65416 [09:17:55] Change merged: jenkins-bot; [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/65416 [09:18:36] Change merged: Hashar; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66071 [09:19:55] New review: Hashar; "deployed" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66071 [09:26:30] New review: Hashar; "Needed to make both Autoloader and Structure tests to always run." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64788 [09:28:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [09:34:51] Change abandoned: Hashar; "This need more work to happen in Jenkins before we can set the triggers. There is some work on prog..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/53535 [09:36:23] Change abandoned: Hashar; "This needed to be checked against doxygen 1.7.x which is on gallium. Feel free to reopen without th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57905 [09:39:27] New patchset: Aude; "Add setting wgLogAutopatrol to toggle logging of autopatrol actions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [09:42:24] New patchset: Hashar; "Typo fixes in RELEASE-NOTES-1.21" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65870 [09:49:51] New patchset: Santhosh; "If the ULS position is interlanguages, always add dummy language links" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66073 [10:07:36] New patchset: Kipcool; "changed arrows to characters supported by IE7" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66075 [10:07:36] New patchset: Kipcool; "Fixed IE problem not displaying images and also: - moved the resources directory to the extension root - moved the image resources into resources/images" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66076 [10:18:11] New review: Hashar; "I have logged an enhancement request for PHP CodeSniffer to make it whine on $wgUser https://bugzill..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [10:22:59] New patchset: Kipcool; "changed arrows to characters supported by IE7" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66075 [10:24:16] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66075 [10:27:11] New patchset: Kipcool; "Fixed IE problem not displaying images and also: - moved the resources directory to the extension root - moved the image resources into resources/images" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66076 [10:27:51] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66076 [10:54:54] New patchset: Freakolowsky; "Fixed EZConnect string regex in OracleInstaller class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65490 [10:59:46] freakolowsky: nice ;-) [11:01:21] freakolowsky: yeahhh more tests :-] [11:01:29] freakolowsky: I will rewrite it to use a dataProvider [11:01:36] aka you set a bunch of test cases in a huge array [11:01:50] and ask PHPUnit to apply a test method on each of the element of the array [11:02:23] freakolowsky: unless you are willing to adapt your patch to use a data provider :D [11:03:45] hmmm ... don't have time right now ... if you can spare some it'd be great so i can backport it to 21 asap [11:03:50] New review: Hashar; "Great! The tests should use a PHPUnit dataprovider though, aka an array of test cases that are pass..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65490 [11:04:01] freakolowsky: I will do the conversion to a dataprovider [11:04:53] ql ... one question tho ... if you change my commit how do i pull the changes back into my local branch [11:05:20] with git-review : git-review -d 65490 [11:05:24] that grabs the latest patchset [11:05:58] or in Gerrit GUI , look at the Download area which list a command to checkout the patch [11:06:03] does it put it into my existing branc or does it create a new one? [11:06:04] something like 65490 [11:06:14] something like: git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/90/65490/3 && git checkout FETCH_HEAD [11:06:42] git-review creates a branch name , either using a bug number or something like review/freakolowsky/66490 [11:06:53] if you want to be sure, use git fetch and git checkout -b somebranchname [11:06:55] New patchset: Thaiphan; "Fix incorrect variable name" [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/66083 [11:07:06] you can try git-review -d 65490 :D [11:07:28] okie ... 10x [11:07:42] freakolowsky: also you might want to configure your text editor to highlight trailing whitespaces :-] [11:07:48] I will fix them [11:09:09] New patchset: Santhosh; "Avoid setting inline style for the element when reset applied" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66084 [11:10:57] New patchset: Krinkle; "Disable Squiz.WhiteSpace.ObjectOperatorSpacing" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66085 [11:11:25] Change merged: Krinkle; [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/66085 [11:14:37] New patchset: Santhosh; "Update linktrails for Hindi and Odia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [11:15:54] New patchset: Krinkle; "Update tools/mwcodesniffer submodule" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66087 [11:16:18] TrevorP|Away: http://www.mediawiki.org/wiki/License_integration [11:28:16] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/66087 [11:30:01] New patchset: Hashar; "Fixed EZConnect string regex in OracleInstaller class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65490 [11:30:58] New review: Hashar; "PS4:" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65490 [11:31:00] freakolowsky: done :-] [11:31:11] whoop! [11:32:34] New patchset: Krinkle; "Enable voting for mwext-VisualEditor-phpcs-HEAD" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66088 [11:32:54] hashar: Gerrit already prefixes the comment with "Patch set #:" based on the patch set heading where you click "Review" [11:33:07] "Patch Set 4: Code-Review+1 PS4:" [11:33:09] Krinkle: yup [11:36:02] Krinkle: maybe we could have two phpcs run. One that will ignore warnings and be voting and another non voting one with warnigns [11:36:14] I should spend some time on that one day :-D [11:39:17] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)." [mediawiki/extensions/LabeledSectionTransclusion] (master) - https://gerrit.wikimedia.org/r/63134 [11:39:57] hashar: our code conventions state clearly 100 characters as the max. I made <100 warning and >100-120 error in attempt to reduce the noise on the short term, but since that has failed I might as well undo that [11:40:07] hashar: Having 2 runs doesn't make sense, we only have 1 set of code conventions. [11:40:21] A violation is a violation, we don't do soft play :P [11:40:25] but our code base violates too much of the style guide [11:40:34] so my idea was to have everything has warning for information [11:40:40] then slowly start making them blockers [11:41:03] We might as well not enforce it. I don't plan to manually look at the job for warnings. And we have enough jobs already. [11:41:18] If we plan to enforce it later we should do exactly that. [11:42:06] number of jobs is not an issue :D [11:42:24] It is and we all know it. [11:42:46] It shouldn't be and perhaps one day it wont be. [11:46:32] James_F: RoanKattouw: http://en.wikipedia.org/wiki/SpiderMonkey_(JavaScript_engine) [11:47:46] http://en.wikipedia.org/wiki/JavaScriptCore#JavaScriptCore [11:59:29] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/66088 [12:22:55] New patchset: VitaliyFilippov; "Allow relative inclusions in Main namespace." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66092 [12:36:55] New patchset: Kipcool; "coding conventions (sql queries)" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66093 [12:38:42] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66093 [12:48:58] New patchset: Yaron Koren; "New version: 1.6.1" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/66094 [12:51:41] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/66094 [12:55:16] New patchset: Kipcool; "sql queries reformatted" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66096 [12:55:48] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66096 [12:57:42] New patchset: Aude; "Add setting wgLogAutopatrol to toggle logging of autopatrol actions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:02:16] New review: Aude; "I have centralized this logic in the PatrolLog class, accounting for the $auto flag." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:09:36] New patchset: Kipcool; "Some i18n * Added 'Semantic annotations' and 'Lexical annotations' section titles to the i18n file * 'related to' now also translatable * Removed 2 unused messages." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66022 [13:16:05] New review: Hoo man; "Patch looks good and this seems like a valid thing to do... we just have to assure that all logging ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62785 [13:16:49] New patchset: Anomie; "(bug 46905) Add "centralauthtoken" to API" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [13:18:43] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [13:27:30] New review: Daniel Kinzler; "Looks good, but needs an entry in the release notes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:32:03] New patchset: Aude; "Add setting wgLogAutopatrol to toggle logging of autopatrol actions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:32:22] New review: Aude; "added this to the release notes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:37:09] New review: Daniel Kinzler; "Approving. Code looks fine and works. Default behavior doesn't change. Even though there are some re..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62785 [13:39:40] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [13:43:14] MatmaRex: ping, re !g 54089 [13:45:27] !g 54089 [13:45:27] https://gerrit.wikimedia.org/r/#q,54089,n,z [13:45:33] anomie: pong [13:46:09] MatmaRex: You saw DJ's comment? [13:46:43] yep [13:46:55] and i was wondering what to do about it [13:47:44] just wrap it in an like it was done before? [13:47:56] (as in, the entire thing, with the

inside etc) [13:48:06] (so not exactly like before) [13:48:09] I'd recommend just doing what the Vector extension does, output a new message wrapped in . [13:48:56] why would we need a new message for this? [13:49:23] and if we decide that we do, then there are multiple i18n issues this causes [13:50:10] so it'd be more like 10 new messages instead of 1, with the whole logic to choose and swap them as appropriate :/ [13:50:23] Because the existing messages may contain links, like enwiki's templatesused. What i18n issues, that aren't solved by mediawiki.jqueryMsg supporting {{plural:}}? [13:50:28] the way Vector did it was, i believe, a prototype [13:50:54] well, for starters, there are three different messages there [13:51:04] templatesused, templatesusedpreview, templatesusedsection [13:51:11] each of these needs PLURAL [13:51:21] and we should have variants with "Show..." and "Hide..." as well [13:51:29] so thats 3 times 2 times 2 [13:51:34] and this is just one of those collapsible lists. [13:52:03] 3 times 2, why the extra times 2? [13:52:04] it's not a technical issue, it can be done [13:52:23] ah, sorry. 3 times 2, then. [13:52:28] i'm still not coding that. [13:52:43] i tried when i wa making the patch [13:52:59] and abandoned the idea half an hour in, when i discovered what is it i'm getting into [13:53:18] (i think some of the early patchsets still have traces of it) [13:53:55] And hiddencategories doesn't currently have different versions for "this page" versus "this section" versus "this preview", BTW. [13:54:12] it probably should [13:54:32] (not "this section", of course, the other two) [13:55:09] i'm still not spending my free time coding that. feel free to. :) [13:55:13] And the existing Vector extension implementation doesn't bother with separate "this page" versus "this section" versus "this preview" versions for templatesused either. Although maybe it should, I don't know. [13:55:20] it certainly should [13:55:23] or core shouldn't [13:55:29] one way or the other [14:05:08] New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [14:10:18] New patchset: Tpt; "Set "Index" and "Page" as canonical names for Index and Page namespaces." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/66106 [14:29:33] -whois DanielFriesen [14:29:36] meh. [14:30:01] i hate it when my keyboard layout suddenly changes to spanish. [14:37:03] New review: Cmcmahon; "Without this or something like it, we can't write a reliable test on beta labs for ULS for anonymous..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/66073 [14:54:23] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60105 [14:54:59] Change abandoned: Sumanah; "Test. Thanks!" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65397 [14:55:14] Change abandoned: Sumanah; "Test. Thanks!" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65402 [14:55:16] New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [14:59:05] New patchset: Hashar; "PHPUnit now recognizes extension parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63164 [15:01:19] Is it possible to have linebreaks in MediaWiki:Gadget-definition? [15:01:28] http://test.wikipedia.org/wiki/MediaWiki:Gadgets-definition#experimental [15:01:40] my split results in a fucking long line... [15:02:19] AzaToth: Test it on a wiki where nobody care's I'd say [15:02:31] * hoo has no idea how the parsing in the extension happens [15:02:57] hoo: I'm testing on a wiki that nobody cares about :-P [15:03:10] just wondered if I could split the line [15:03:12] It's fine if it works then :P [15:05:55] New patchset: Hashar; "TEST are resources tests ran?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66117 [15:08:01] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65490 [15:08:27] New review: Hashar; "lets land it in core. Thanks!" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65434 [15:11:09] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65434 [15:11:59] New patchset: Hashar; "TEST are resources tests ran?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66117 [15:14:08] hoo: updated on enwiki now ツ [15:14:20] hoo: http://en.wikipedia.org/wiki/Special:Contributions/AzaToth [15:15:04] Wow :D [15:15:08] New patchset: Hashar; "tests: resources tests were not being run" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66117 [15:15:20] Have you thought about inclusions from other wikis? [15:15:26] no [15:15:48] I am pretty sure we could make MediaWiki:*.js to fetch the content from a git repository :-D [15:15:51] Are these going to break? :P [15:15:53] with some caching mechanism in front of ti [15:16:01] hashar: would love that ツ [15:16:10] Not in production please [15:16:12] bug request it ! [15:16:13] hoo: there's nothing changed in morebits.js [15:16:24] hashar: think I did that like 4-5 years ago [15:16:26] at least not with anything except our gerrit :P [15:17:44] hoo: this is what I use to sync: https://github.com/azatoth/twinkle/blob/master/sync.pl [15:17:57] hoo/hashar [15:18:01] New patchset: Hashar; "tests: resources tests were not being run" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66117 [15:18:06] but that could be build in :-] [15:18:27] {{sofixit}} ツ [15:18:29] hashar: And ahve the gadgets in gerrit? That would be good [15:18:39] but having them still on github... for heavens sake, no :P [15:19:37] New patchset: Reedy; "Type hints. Fixup missing return values" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/66120 [15:19:43] hoo: back in the days I placed in on github, yee here still used SVN [15:20:55] You could also do that with svn [15:21:08] :P [15:21:33] over my dead body [15:23:16] 1) Open a bug for that 2) Think of a software design 3) Find someone to implement it [15:23:23] 4) Get it deployed [15:23:30] 3 and 4 probably the hardest [15:23:41] 2 is dangerous [15:23:57] New review: Hashar; "simple file move that restore the resourcetests." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66117 [15:24:04] Yeah, just hack it... it's going to work :P [15:24:24] hoo: 2 is the hardest :D [15:24:39] New patchset: Reedy; "ResourceLoader-ify SecurePoll" [mediawiki/extensions/SecurePoll] (master) - https://gerrit.wikimedia.org/r/66121 [15:24:40] AzaToth: we have talked about such a git backend already [15:24:45] hoo: wonder if a bug should be against MediaWiki or Wikimedia [15:24:48] I mean among the Wikimedia MediaWiki core team [15:25:27] or to be more exact, something to be have gadgets and LUA modules in centralized repositories [15:25:43] ultimately hosted in git to let people interact with it with developers tools [15:26:04] You could probably even use MediaWiki as a git backend [15:26:20] :D [15:26:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66117 [15:26:35] hoo: forget using and it's suddenlt a signature committed [15:26:44] hoo: there is a perl script in git project that let you use mediawiki:// [15:27:46] hashar: Wow... that's probably very fast, is it :P [15:29:48] hoo: not really [15:30:27] hoo: if you want to try it: https://github.com/git/git.git then contrib/mw-to-git/ [15:30:46] hoo: their doc https://github.com/moy/Git-Mediawiki/wiki [15:31:29] wow :P [15:31:56] And I thought I was already crazy when prototyping with a vi like editor in MediaWiki [15:31:59] New review: Nikerabbit; "For double space, sorry." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64926 [15:32:23] wtf do we have soooo many spaces [15:34:12] New patchset: Hashar; "micro optimization when fetching a magic from cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [15:36:00] New review: Nikerabbit; "I see empty attribute

in the DOM, but I guess that is harmless." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/66084 [15:36:23] New review: Hashar; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65953 [15:37:14] New patchset: Hashar; "micro optimization when fetching a magic from cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [15:37:40] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [15:38:10] New review: No-L; "looks good to me :-)" [mediawiki/extensions/LdapAuthentication] (master) C: 1; - https://gerrit.wikimedia.org/r/65865 [15:38:22] Nikerabbit: I guess you can get my lame optimization patch merged in https://gerrit.wikimedia.org/r/#/c/65953 :D [15:41:47] hashar: but there is a double space in the commit message! (just kidding) [15:42:00] hashar: but you didn't fix the casing in the commit message [15:42:08] Nikerabbit: go ahead and fix it :D [15:42:22] oki [15:42:26] Nikerabbit: what do you think about using the subitem accessor instead of the item one ? [15:42:38] New patchset: Nikerabbit; "Micro optimization when fetching a magic from cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [15:42:39] the idea is to avoid copying the full array each time it is called [15:43:03] hashar: sound sane, is there something that makes you doubt? [15:45:56] Nikerabbit: na just wanted a double check :D [15:46:38] be brave and +2 ! [15:50:06] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [15:51:57] \O/ [15:51:59] Change merged: Aaron Schulz; [mediawiki/extensions/AWS] (master) - https://gerrit.wikimedia.org/r/66083 [15:54:48] who can i poke about MobileFrontend? [15:54:55] !e MobileFrontend [15:54:55] https://www.mediawiki.org/wiki/Extension:MobileFrontend [15:55:43] MaxSem: you. [15:56:00] * MaxSem runs away [15:56:02] MaxSem: tell me why does MobileFrontend use those ugly #mp-XXX ids on the main page, and which ones matter [15:56:07] and which ones i can throw away [15:56:16] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65870 [15:56:21] because i'm unbreaking a certain wikipedia main page right now [15:56:35] because ordinary main pages suck on mobile devices [15:56:50] fel free to throw away anything you don't need:) [15:56:51] and, actually, which ones are documented to exist, and which ones are inventions of whoever made the main page of pl.wp in like 2009 [15:57:03] since we have like ten of them [15:57:44] MaxSem: https://pl.wikipedia.org/wiki/Wikipedysta:Matma_Rex/SG like my HTML? i'm gonna put some more classes and ids on it and write the CSS to resemble current main page [15:57:56] mp-tfa, mp-itn, mf-\S+ [15:58:01] PHPUnit 3.8 is only supported on PHP 5.4.7 (or later). :( [15:58:49] MaxSem: so mp-dyk, mp-otd, mp-tfga, mp-other, mp-legal never existed? [15:59:18] I can't give comments about the times of the old Ruby gateway [15:59:30] okay, different question [15:59:37] can i rip them out, or do you guys want them? [15:59:52] hashar, we should switch to 5.4 to make all those crappy shared hosting users go away:] [15:59:53] New patchset: Matthias Mullie; "(bug 43167) list=articlefeedbackv5-view* accepts page titles as an option" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [16:00:14] MaxSem: yup that is more or less planned [16:00:20] MaxSem: I can't remember the exact details [16:00:29] MatmaRex, we don't need them and will not ad any more [16:00:35] also, if i've got you already. is there a way to feature the DYK section on the mobile main page? on pl.wp it's quite better than the news one. or should i just move the ID to it and screw good practices? :P [16:01:20] can't you read regexes? what mf-\S+ does?;) [16:02:29] it matches 'm', then 'f', then '-', then one or more of arbitrary non-whitespace characters. :P [16:02:38] yp [16:02:41] *yep [16:02:43] i guess those are kept on MF main page? [16:02:44] New review: Nikerabbit; "If $wgULSEnableAnon = false this causes empty 'in other languages' section. " [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/66073 [16:03:01] and you can use all such ids to publich divs on main page [16:03:13] okay, seems sane enough [16:03:14] thanks [16:03:15] :) [16:03:22] New review: Nikerabbit; "I would love to see parser tests for this." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66092 [16:07:44] New patchset: Hashar; "test: coverage recording now need to be explicit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125 [16:09:39] New review: Nemo bis; "Commit message doesn't clarify if the stated problem happens with or without subpages enabled for th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66092 [16:10:22] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=48981 [16:11:18] New patchset: Hashar; "test: coverage recording now need to be explicit" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66125 [16:11:54] AzaToth: thx [16:12:52] New review: MarkAHershberger; "You're right about the "an" but adding the comma is a bit more slippery." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65870 [16:13:13] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66001 [16:20:30] What the heck is MediaWiki trying to do... CREATE TEMPORARY TABLE `centralauth.objectcache` (LIKE `centralauth.objectcache`) [16:21:03] ugaga [16:38:58] New review: EBernhardson; "Needs qqq. Possibly tweak output for diffs with no total change in text size." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65139 [16:47:48] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63364 [16:52:17] New review: EBernhardson; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [16:52:26] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [16:58:31] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [16:59:11] Change abandoned: Kaldari; "Sounds like people may want this implemented as the default for video instead. Will regroup on image..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66062 [16:59:15] New review: Hashar; "Feel free to try it out using:" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/66128 [16:59:56] Change abandoned: Kaldari; "abandoned dependent change" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/66063 [17:19:23] hoo: ping [17:19:43] bsitu: Pong [17:21:38] hoo: Is it possible that you can fix the 'Mark this page as patrolled' link so it only show up if the page is coming from special:newPages [17:22:16] You could make a gadget for that [17:23:46] if ( !mw.util.getParamValue( 'patrolpage' ) ) $( '.patrollinks' ).remove(); [17:23:49] like hta [17:23:51] * that [17:24:23] bsitu: ^ [17:24:58] hoo: the toolbar won't load if the patrollink is present, this is detected from server side [17:25:22] toolbar? [17:25:43] it's the toolbar for pagetriage extension [17:26:09] Well, the extension's broken then [17:26:48] Use this https://gerrit.wikimedia.org/r/66035 [17:27:14] It worked in my brief tests [17:27:56] the toolbar should show up if it's coming from Special:NewPagesFeed, but now the 'Mark this page as patrollled' link is always visible in some cases, it breaks pagetriage [17:29:08] 'Mark this page as patrolled' should only be visible if the page is coming from Speicial:NewPages [17:29:11] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [17:29:12] are... are those these strange buttons on the right which magically are there sometimes? [17:29:21] bsitu: No, why should it [17:29:33] https://xkcd.com/1172/ [17:29:50] I have to go... cinema later... feel free to mail me or whatever [17:29:50] hoo: because competing interface elements that do the same thing are confusing [17:30:07] kaldari: Yep, that's why there shouldn't be an extension probably [17:30:26] or it shouldn't be there while the core's NP patrol still is enabled [17:30:43] hoo: that doesn't make any sense. All the work that was done for PageTraige was specifically to address all the bugs in page patrolling [17:31:01] kaldari: Well... that's a very weird way to go :P [17:31:07] why do you say that? [17:31:13] So, let's have two broken things instead of one [17:31:20] Rather fix it in core, or remove it from core [17:31:24] but not just amend to it [17:31:30] PageTraige isn't broken, well it wasn't until yesterday [17:31:56] but it was weird... I only now realized that was the thing with these weird toolbar on the right [17:32:10] Anyway, I really need to go [17:32:24] this needs to be reverted until the problems can be sorted out [17:32:30] hoo: we need to revert the patch [17:32:39] pagetriage should be reverted :/ [17:32:40] Or remove page triage for now [17:32:45] why? [17:32:58] because, no offense to you personally, in my opinion it sucks ~ [17:33:12] MatmaRex: The only reason we build PageTriage was because the en.wiki patrolling community asked us to [17:33:26] it's inconsistent with the interface, non-intuitive, enwiki-specific [17:33:30] every feature of it was built based on direct feedback from page patrollers [17:33:38] well, then it should probably be a gadget [17:33:47] what difference would that make? [17:33:53] but i have no interest in this, sorry, moving out of this discussion [17:34:47] MatmaRex: if there are things you don't like about it, why not file some bugs? [17:35:22] it would be better to improve it than kill it, IMO [17:38:00] kaldari: because i'm not editing enwiki enough to be constructive about this [17:38:13] kaldari: one bug that's probably alreayd filed is to make it less en.wp-specific [17:38:38] (this is one of the reasons it hsould be a gadget in its current form - unusable outside en.wp) [17:38:44] MatmaRex: all the en.wiki specific stuff is configurable on-wiki [17:39:56] kaldari: what is https://bugzilla.wikimedia.org/show_bug.cgi?id=48552 , then?> [17:39:58] New patchset: Aaron Schulz; "WebRequest::getIP() cleanups." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66130 [17:43:12] MatmaRex: I hadn't seen that. Guess we need to build a configuration guide :) [17:44:49] [20:31:48] -rakkaus:#mediawiki-i18n- [30-May-2013 17:32:06 UTC] PHP Warning: json_encode(): Invalid UTF-8 sequence in argument in /www/translatewiki.net/w/includes/json/FormatJson.php on line 151 [17:44:53] curious [18:02:04] Nikerabbit: anything that should be done about it? [18:02:18] Nemo_bis: it seems relatively new [18:05:55] New review: CSteipp; "PS6 seems to fix the autocreate issue (auto-creates from an api call with a token work now). The pat..." [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/57662 [18:06:11] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [18:10:02] New patchset: Bsitu; "Temporary fix to curation toolbar till things are sorted out" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66136 [18:10:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [18:12:55] New patchset: MarkTraceur; "Add tests for Gateway_Form" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64442 [18:17:17] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66136 [18:19:40] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [18:23:50] New patchset: Aaron Schulz; "WebRequest::getIP() cleanups." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66130 [18:24:43] New patchset: Aaron Schulz; "WebRequest::getIP() cleanups." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66130 [18:25:46] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [18:26:35] New review: Ori.livneh; "Matt: note that this removes the 'postEdit.afterRemoval' hook introduced in change I9d045019a. As I ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [18:28:06] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [18:30:15] New review: Eloquence; "If this breaks PageTriage it should be reverted for now until these issues can be resolved." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [18:30:53] New review: Matmarex; "Bsitu has already submitted PageTriage patch." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [18:35:40] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [18:38:04] AzaToth: (replying 3 hours late) Looking at the code, it looks like you can't have linebreaks in a gadget definition line. But you can put spaces around the "|" which will allow the browser to wrap the lines when it's displayed at https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition [18:39:17] New patchset: Aaron Schulz; "Normalized token TTLs and memcached calls." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/66138 [18:42:44] New patchset: Hashar; "mwdocgen: support multiple --file values" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66140 [18:43:48] New patchset: Bsitu; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66141 [18:46:44] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [18:48:29] anomie: ok [18:51:27] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [18:52:28] New patchset: Bsitu; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66142 [18:55:33] New patchset: Kaldari; "Adding link to user in flyout version" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/66144 [18:57:30] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/66144 [18:58:05] New review: CSteipp; "Trivial changes, all look good to me. Thanks!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/66138 [18:58:10] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/66138 [19:03:12] New review: Anomie; "Also, a bunch of other whitespace issues besides the one Parent5446 flagged." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66054 [19:04:45] New patchset: Aaron Schulz; "Changed some md5 calls to use sha1 instead." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/66145 [19:05:20] New patchset: Bsitu; "Update Echo, PageTriage and Thanks to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66146 [19:07:21] New review: Aaron Schulz; "This should be deployed at once (adding -2 for sanity)" [mediawiki/extensions/CentralAuth] (master) C: -2; - https://gerrit.wikimedia.org/r/66145 [19:07:41] New review: Aaron Schulz; "That is "all at once"" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/66145 [19:11:13] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66141 [19:12:32] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66142 [19:13:51] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66146 [19:14:26] Published patchset: Wikinaut; "(bug 44917) Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [19:15:11] New patchset: Kaldari; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66149 [19:15:26] Change abandoned: Ori.livneh; "If we're not sure we need it, let's abandon the patch. It'll be archived on Gerrit and we'll be able..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63263 [19:16:04] gerrit is especially painfully slow today [19:16:43] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66149 [19:19:11] New patchset: Kaldari; "Update Echo and Thanks to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66150 [19:20:54] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66150 [19:26:19] New review: Wikinaut; "Iboying: you proposed that patch, I modified the variable names and corrected the message, which now..." [mediawiki/extensions/UserMerge] (master) C: 1; - https://gerrit.wikimedia.org/r/66139 [19:28:56] Published patchset: Wikinaut; "(bug 44917) Merging users fails to merge edit counts" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/66139 [19:30:09] RoanKattouw_away: https://bugzilla.wikimedia.org/show_bug.cgi?id=48993 [19:31:13] brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=48901 [19:33:05] yurik: been like that for weeks now [19:33:34] yurik: it's java, what do you expect? [19:33:52] i wonder if we should run it under mono :) [19:34:55] * AzaToth wonders what the status is for this thing called VisualEditor [19:35:24] cancelled [19:35:24] we're switching to markdown [19:35:38] orly? [19:35:48] no, i'm trolling. there's an up-to-date status report on mw.org somewhere [19:36:13] it's coming along quite well. [19:36:23] * yurik always liked markup much better than WYSIWYG [19:36:27] brion: is https://gerrit.wikimedia.org/r/#/c/64844/3 ok ? [19:36:33] it's available as an optional feature on a number of wikimedia wikis, so you can try it out too. [19:36:42] especially {{{{{counting}}}{{stuff}}}}} [19:36:58] yurik: the markup was fine until someone (wistles innocently) found that you could play with templates [19:37:25] ori-l: yea, just posted a bug for it at https://bugzilla.wikimedia.org/show_bug.cgi?id=48993 [19:37:56] Aaron|home: looks plausible but i'm not certain :D [19:40:10] New patchset: Mattflaschen; "Bump Guiders for scroll animation." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66153 [19:40:57] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66153 [19:45:36] New patchset: Daniel Kinzler; "Adding ContentHandler example extension." [mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/66154 [19:48:12] New patchset: Mattflaschen; "Bump EventLogging for E3 deploy." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66155 [19:49:34] New patchset: Mattflaschen; "Bump EventLogging for E3 deploy" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66156 [19:51:04] New patchset: Mattflaschen; "Bump GuidedTour for E3 deploy" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66157 [19:51:51] New patchset: Mattflaschen; "Bump GuidedTour for E3 deploy" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66158 [19:53:25] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [19:59:47] New review: Swalling; "Verified on piramido.wmflabs.org." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65168 [19:59:47] Change merged: Swalling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65168 [20:01:53] New patchset: Mattflaschen; "Bump GettingStarted for E3 deploy" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66159 [20:07:21] New patchset: Mattflaschen; "Bump GettingStarted for E3 deploy" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66160 [20:07:25] New review: Spage; "b1ebe53 "Bump Guiders for scroll animation" is latest" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/66157 [20:10:26] New review: Spage; "b1ebe53 "Bump Guiders for scroll animation" is latest" [mediawiki/core] (wmf/1.22wmf5) C: 2; - https://gerrit.wikimedia.org/r/66158 [20:12:14] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66157 [20:13:35] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66158 [20:14:27] csteipp: https://gerrit.wikimedia.org/r/#/c/66045/ [20:16:19] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [20:17:58] New review: Spage; "174361e is latest" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/66159 [20:18:38] New review: Spage; "174361e is latest" [mediawiki/core] (wmf/1.22wmf5) C: 2; - https://gerrit.wikimedia.org/r/66160 [20:20:58] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/66045 [20:21:14] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66159 [20:22:39] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66160 [20:26:11] New review: Spage; "db9c0a3 is latest" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/66155 [20:27:58] New review: Spage; "db9c0a3 is latest" [mediawiki/core] (wmf/1.22wmf5) C: 2; - https://gerrit.wikimedia.org/r/66156 [20:29:03] New review: Mattflaschen; "Code looks fine, and works locally, though oddly the symptoms without the fix are somewhat different..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65859 [20:29:36] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66155 [20:29:46] New patchset: Hashar; "doc: converts hooks.txt to doxygen format" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66128 [20:31:28] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66156 [20:32:36] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65859 [20:36:36] New review: Mattflaschen; "Code looks fine." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/66047 [20:39:15] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66047 [20:41:17] New patchset: Aaron Schulz; "Respect $wgUsePrivateIPs for XFF headers." [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/66045 [20:45:43] New patchset: Spage; "benefits icon part of background, not float" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66163 [20:52:13] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [20:52:25] New patchset: Spage; "Darker labels in new login and create acct forms" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66164 [20:53:32] New patchset: Kaldari; "Adding tooltip for preference" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/66165 [20:53:44] ori-l: can you add that to the extensions to be integrated page? [20:54:18] greg-g: If no one else has requested it, I'd love to use the lighting deployment time today [20:54:26] Nemo_bis: sure, thanks for the reminder [20:54:42] thanks [20:54:55] kaldari: it's open, what's the change? [20:55:16] just adding a tooltip to the thanks preference [20:55:22] * greg-g nods [20:55:24] for extension:thanks [20:55:45] since it's going live in a little bit [20:55:51] * greg-g nods [20:56:01] New patchset: Reedy; "Delete RELEASE-NOTES-1.21" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66168 [21:00:50] New patchset: Spage; "Compress PNGs used in new forms" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66169 [21:01:38] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66163 [21:05:32] New patchset: Spage; "benefits icon part of background, not float" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66170 [21:08:34] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66169 [21:08:34] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66164 [21:09:46] New patchset: Kaldari; "Adding tooltip for preference" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66171 [21:11:39] New patchset: Spage; "Darker labels in new login and create acct forms" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66172 [21:11:39] New patchset: Spage; "Compress PNGs used in new forms" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66173 [21:11:48] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Thanks] (master) C: -1; - https://gerrit.wikimedia.org/r/66165 [21:20:44] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66170 [21:22:25] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66172 [21:23:50] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66173 [21:29:22] New review: Ori.livneh; "I've made minor points inline, but on the whole this is very nice -- well done." [mediawiki/extensions/examples] (master) C: -1; - https://gerrit.wikimedia.org/r/66154 [21:35:09] New review: Kaldari; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/48357 [21:36:32] New review: Bsitu; "(1 comment)" [mediawiki/extensions/PageTriage] (master) C: -1; - https://gerrit.wikimedia.org/r/66171 [21:37:37] Whoa, it's an rfarrand. [21:38:09] yay [21:38:58] :) [21:40:26] rfarrand: D'you need an invite to the staff channel? [21:41:50] New patchset: Kaldari; "Adding tooltip for preference" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66171 [21:42:38] yes, i emailed James about that just now [21:43:17] Oh, I think Leslie will be able to do it faster [21:44:39] New patchset: Kaldari; "Adding tooltip for preference" [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/66165 [21:45:15] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #61: FAILURE in 6 min 29 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/61/ [21:46:06] rfarrand: Leslie says to join #wikimedia-staff and see what happens [21:48:58] it says: "Error(473): #wikimedia-staff Cannot join channel (+i) - you must be invited" [21:49:12] New review: Kaldari; "She's not a developer, so I don't think she has a gerrit account." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [21:49:37] Hm [21:50:43] rfarrand: If you aren't registered it won't work [21:51:19] rfarrand: You'll want to private-message with NickServ about that, just /msg NickServ help and it'll pop up a private window with instructions [21:51:42] rfarrand: type /msg NickServ REGISTER somepassword rfarrand@wikimedia.org [21:51:54] but replace "somepassword" with a password of your choice [21:52:00] Man, ori-l is way more helpful than I am. :P [21:52:28] * marktraceur mumbles something about teaching people how to fish and wanders off into FR-tech QA Land [21:52:33] marktraceur: well, I would have linked http://freenode.net/using_the_network.shtml :D [21:53:21] Nemo_bis: Well that's arguably a pretty useful page [21:54:46] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66171 [21:57:55] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/66165 [22:07:21] New patchset: Aaron Schulz; "Removed excess mt_rand() calls, TempFSFile does this already." [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/66174 [22:39:27] New patchset: Kaldari; "Update PageTriage and Thanks to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66176 [22:46:04] New patchset: Kaldari; "Suppressing underline on hover for notification badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66177 [22:46:35] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/66177 [22:48:54] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66178 [22:50:02] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66176 [22:50:19] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66178 [22:57:02] New review: Aaron Schulz; "This still has large amounts of blank newlines everywhere" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [22:58:57] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [23:04:30] New patchset: Hazard-SJ; "Add bot to createAndPromote.php groups" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65872 [23:05:59] New patchset: Ori.livneh; "Migrate Extension:PostEdit interface to core" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66137 [23:06:51] New patchset: Kaldari; "Update Echo, PageTriage, and Thanks to master" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66179 [23:08:25] New review: Mattflaschen; "First, if you want to remove afterRemoval, you should provide a replacement first." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66137 [23:20:45] New patchset: Mwalker; "Fixing RTBT Methods that were two step" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/66180 [23:23:26] New patchset: Kaldari; "Temprorary PageTriage revert for wmf4 deployment" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66181 [23:23:50] Change merged: Kaldari; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66181 [23:25:16] New review: Mattflaschen; "See previous." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/66137 [23:28:31] New patchset: Tim Starling; "Add IPv6 range support, for Opera Turbo" [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/66182 [23:29:37] New patchset: Kaldari; "Update PageTriage to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66183 [23:29:58] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66183 [23:35:27] New patchset: Kaldari; "Temporary revert of PageTriage for wmf deployment" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66184 [23:36:00] Change merged: Kaldari; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66184 [23:37:55] New patchset: Kaldari; "Update PageTriage to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66185 [23:38:23] i know there are some concerns regarding changing internationalization messages that require renaming the message, are those listed anywhere? [23:38:23] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66185 [23:39:16] or if they are listed anywhere, is a change like switching from 1 to 0 parameters require a rename? [23:39:21] s/are/arnt/ [23:39:48] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/64523 [23:39:56] ebernhardson, I suspect your question is more likely to be seen by the right people in #mediawiki-i18n [23:41:09] Krenair: ok, htanks! [23:41:24] New review: MarkTraceur; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) C: 2; - https://gerrit.wikimedia.org/r/66180 [23:41:33] Change merged: jenkins-bot; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/66180 [23:42:28] Krinkle|detached: https://bugzilla.wikimedia.org/show_bug.cgi?id=424 [23:42:47] TimStarling: hacks :/ [23:43:10] ebernhardson: You've read [[mw:CC]]? [23:43:28] Aaron|home: you mean in TrustedXFF? [23:43:35] I feel like there's a related page about localization/internationalization specifically. [23:44:05] ebernhardson: https://www.mediawiki.org/wiki/Localisation#Changing_existing_messages [23:44:09] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66179 [23:45:14] Susan: aha, ok thanks. My first thought for CC was creative commons [23:45:35] New patchset: Mattflaschen; "Change removeGuider to take a guider as parameter." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66186 [23:46:14] New patchset: Mattflaschen; "Change removeGuider to take a guider as parameter." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/66186 [23:46:56] New review: Mattflaschen; "Followup to make it take a guider done in https://gerrit.wikimedia.org/r/#/c/66186/" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [23:47:44] New review: MZMcBride; "Please add a note to trusted-hosts.txt explaining that there's a separate list for IPv6 ranges (incl..." [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/66182 [23:53:40] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [23:54:11] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #46: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/46/ [23:54:36] New patchset: Krinkle; "(DRAFT) Experimental SQLite installer WIP" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65457 [23:58:25] New review: MarkTraceur; "Well hadurr." [mediawiki/extensions/CentralNotice] (wmf_deploy) C: 2; - https://gerrit.wikimedia.org/r/64332 [23:58:26] Change merged: MarkTraceur; [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/64332 [23:59:37] New patchset: Mattflaschen; "Add configuration variable for duration, and increase default." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/66188