[00:01:37] New review: Parent5446; "Needs rebase." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [00:05:05] New review: Parent5446; "I don't know anything about Oracle or about why the table names should be uppercase, but the code lo..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65630 [00:06:35] New review: Parent5446; "Same comments from PS1." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62549 [00:11:45] RoanKattouw: Can you CR2 these? https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:js-deprecations,n,z [00:16:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [00:18:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [00:19:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [00:21:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [00:31:54] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [00:33:20] New patchset: PleaseStand; "Check if API enabled before loading dependent JS modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [00:35:39] New review: PleaseStand; "Had to move OutputPage changes to Skin because of I89d529f0 ("Give skin more control of OutputPage m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [00:38:06] New patchset: Spage; "benefits icon part of background, not float" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65859 [00:39:16] New review: Swalling; "Design change verified. LGTM." [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/65859 [00:43:28] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [01:32:56] If I just checkout mediawiki/extensions, I just get the empty folders. Do I have to do something else to populate them or should I just checkout individually? [01:35:02] $ git submodule --init update [01:35:15] or maybe git submodule update --init [01:36:02] git submodule update --init --recursive [01:36:18] but this is if you do it from a mediawiki release branch [01:36:38] HSJ: What command did you run? [01:37:07] I think you just need a recursive flag, but if you paste the command, someone will say definitively. [01:37:39] Susan: I ran git clone ssh://hazard-sj@gerrit.wikimedia.org:29418/mediawiki/extensions [01:37:59] * HSJ looks up [01:38:01] HSJ: ori-l's command should work for you [01:38:58] * HSJ tries [01:44:56] Working slowly, but surely ... thanks :D [01:57:17] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [01:57:30] New patchset: Mattflaschen; "Move cookie-related functionalty from Guiders.js to GuidedTour." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [01:58:40] New patchset: Mattflaschen; "Move cookie-related functionalty from Guiders.js to GuidedTour." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [01:58:55] New patchset: Peterbruin; "Prevent searching for AD groups for no AD LDAP" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/65865 [02:22:37] New patchset: Parent5446; "Moved account creation throttle to ping limiter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65867 [02:52:49] New patchset: Mwalker; "Further Cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [02:54:12] New patchset: Mwalker; "Further Cleanup to Special:Version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65868 [03:02:14] New review: Spage; "It jumps down." [mediawiki/extensions/GettingStarted] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/65173 [03:02:23] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65173 [03:28:15] * HSJ would like some PHP help, please. [03:31:19] What's wrong with http://pastebin.com/PputE2Cc ? [03:33:27] New patchset: Liangent; "(bug 22808) Don't count "expensive" calls for cached titles" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/65828 [03:59:27] New patchset: Hazard-SJ; "Typo fixes:" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65870 [04:08:52] New patchset: Mattflaschen; "DRAFT - Add workaround to placeholder shim for password input boxes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65871 [04:10:04] Hi there, is this the right channel to ask about mediawiki extensions development? [04:16:48] proppy: I'd say so :) [04:17:31] Cool, I'm trying to override the Upload form POST url, is UploadForm:BeforeProcessing the best place to do that? [04:20:15] Shouldn't you be overriding the whole form/special page [04:20:17] oh actually UploadForm:initial looks like a better candidate [04:20:59] DanielFriesen: oh maybe, I'm new to SpecialUpload.php, so I'm still trying to figure out how to achieve this [04:29:42] New review: Spage; "(1 comment)" [mediawiki/extensions/GuidedTour/guiders] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/65174 [04:46:40] New patchset: Mattflaschen; "Animate scrolling to guider." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65174 [04:47:11] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65174 [04:48:38] New patchset: Hazard-SJ; "(bug 45160) Add bot to createAndPromote.php groups" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65872 [05:09:53] New review: Mattflaschen; "After talking on IRC, I completely grok it. There were some minor issues, including a file with onl..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65456 [05:39:07] New patchset: Physikerwelt; "Update to new Version of Math extension." [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65873 [06:00:16] New review: Peterbruin; "This is the message that would appear for every log in, 8 lines per login. Note that this was with t..." [mediawiki/extensions/LdapAuthentication] (master) C: 1; - https://gerrit.wikimedia.org/r/65865 [06:19:28] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65479 [06:21:53] New patchset: FastLizard4; "Fix whitespace error" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65874 [06:22:30] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65874 [06:26:34] New review: IAlex; "Also a note in DefaultSettings.php saying that $wgAccountCreationThrottle is deprecated would be nice." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65867 [06:28:47] New review: IAlex; "Sorry, you can forget the note about $wgAccountCreationThrottle just above, I don't know how I did m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65867 [06:30:34] New patchset: IAlex; "Fix the target URL of HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56610 [06:34:50] New patchset: IAlex; "Merge 'passwordreset-pretext' and 'passwordreset-text' messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59806 [06:35:53] New patchset: IAlex; "Add support for "tabindex" in HTMLFormField subclasses" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62014 [06:36:03] Published patchset: Wikinaut; "code cosmetics only" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/65875 [06:36:17] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/65875 [06:47:36] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [06:48:25] New review: Wikinaut; "work in progress; code still untested." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [06:49:37] diving in the upload code, does someone know off hand where the code persisting the file metadata in the db is located ? [06:50:05] so far I dived up to FileRepo::newFile [06:52:00] yay LocalFile::upload :) [06:53:59] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [06:58:14] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [07:00:30] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [07:06:09] New review: Mattflaschen; "Jenkins doesn't run on Guiders." [mediawiki/extensions/GuidedTour/guiders] (master); V: 2 - https://gerrit.wikimedia.org/r/65174 [07:06:17] Change merged: Mattflaschen; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65174 [07:15:10] New review: Liangent; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65872 [07:26:23] New review: Hashar; "Thank you for the patch! There is a minor issue though: when using a database which is not MySQL (e..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65301 [10:00:14] New patchset: Santhosh; "Update jquery.webfonts from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65948 [10:00:14] New patchset: Santhosh; "Exclude does not apply if the editfont preference is default" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65949 [10:09:19] New patchset: Nikerabbit; "Performance improvements" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65952 [10:11:21] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:11:21] New patchset: Matmarex; "ResourceLoader: Move arrow icons to a separate module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:14:08] New patchset: Nikerabbit; "Update linktrails for Hindi and Odia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [10:14:28] hello [10:14:33] is master broken? it seems to be. [10:14:40] see test failures on https://gerrit.wikimedia.org/r/#/c/65414/ [10:15:07] New review: Nikerabbit; "+1 to have time for feedback through bugzilla" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65653 [10:16:08] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65708 [10:16:23] New patchset: Santhosh; "Update linktrails for Hindi and Odia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [10:17:11] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65948 [10:17:23] New review: Santhosh; "Excluded danda characters in latest patchset" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [10:17:46] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65949 [10:21:41] Nikerabbit: *poke* [10:21:54] Nikerabbit: can you review wth is this guy going? https://translatewiki.net/wiki/Special:Contributions/Sapral_Mikail [10:22:20] Nikerabbit: changing widely used messages in russian [10:22:28] i noticed because one of his changes just broke our master. [10:23:06] the changes he's making don't even seem to be in russian [10:23:08] siebrand: ^ [10:24:20] Nemo_bis: can you handle? [10:24:32] looks like he is accidentally translating in /ru instead of /inh [10:25:24] New patchset: Hashar; "micro optimization when fetching a magic from cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [10:26:34] New review: Matmarex; "Welp, master is broken right now, but top people are working on a fix." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65414 [10:27:16] also, Nikerabbit, why are L10n-bot's commits merged without tests? :/ https://gerrit.wikimedia.org/r/#/c/65896/1 [10:31:58] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65579 [10:31:59] MatmaRex: because jenkins hasn't been reliable enough [10:32:16] well it'scertainly unreliable when you merge failing tests, isn't it. [10:32:36] can you revert that commit please? [10:32:49] because i find the CI useful and i'd like it to work again [10:32:59] New patchset: Hashar; "tests: update russian main page name" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65955 [10:33:05] and see [10:33:06] ^ [10:33:09] he's breaking it now [10:33:17] MatmaRex: who is breaking what? [10:33:24] right the main page thingie [10:33:30] New review: Matmarex; "No, the messages are wrong." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65955 [10:33:36] well, the test is broken anyway, it should not rely on the strings [10:33:41] Nikerabbit: hashar is breaking the tests to it the broken messages [10:33:44] https://gerrit.wikimedia.org/r/#/c/65955/ [10:33:55] ahh [10:34:02] talking about it in #mediawiki-i18n [10:34:03] :D [10:34:09] hashar: revert https://gerrit.wikimedia.org/r/#/c/65896/1 if you want to fix this [10:34:31] some guy on TWN got confused and overworte some russian messages [10:34:56] it's gonna be fun if this gets deployed on ru.wiki [10:34:56] also, i'm afk [10:35:10] good luck fixing it all [10:35:21] Nikerabbit: so apparently the russian messages introduced by https://gerrit.wikimedia.org/r/#/c/65715/ are wrong [10:35:30] related patch https://gerrit.wikimedia.org/r/#/c/65715/1/languages/messages/MessagesRu.php,unified [10:35:45] i can't read russian though [10:36:09] -'mainpage' => 'Заглавная страница', [10:36:09] +'mainpage' => 'Кертера оаг|ув', [10:37:07] Change abandoned: Hashar; "Per Matmarex" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65955 [10:37:40] well, the changes are certainly wrong, there is no doubt ot that [10:37:46] it's just matter of cleaning it up and notifying the user [10:38:14] would you revert the change made to languages/messages/MessagesRu.php ? [10:38:17] MatmaRex: have you written to the user? [10:41:03] reverter [10:41:06] New patchset: Hashar; "revert last 'ru' l10n update" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65956 [10:41:19] New review: Hashar; "Reverting russian part with https://gerrit.wikimedia.org/r/65956" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65715 [10:41:50] New review: Hashar; "Russian translation is reverted with https://gerrit.wikimedia.org/r/65956" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65955 [10:44:08] Nikerabbit: can you please approve the revert for the russian translation ? [10:44:13] Nikerabbit: that fix the tests : v [10:44:14] https://gerrit.wikimedia.org/r/#/c/65956/ [10:44:17] thx [10:45:26] done [10:47:09] Nikerabbit: I've notified the user but on-wiki rollback can wait a few hours [10:47:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65956 [10:47:50] He's a native Russian speaker (or claims so), so let's give him an opportunity to cleanup himself or confirm translations that happened to be ok [10:48:35] New patchset: Hashar; "micro optimization when fetching a magic from cache" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65953 [10:49:24] New patchset: Hashar; "ResourceLoader: Move arrow icons to a separate module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:49:27] Nemo_bis: on quick look I didn't see any worthy translations there [10:49:49] New patchset: Hashar; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [10:49:52] * MatmaRex is back [10:49:58] Nemo_bis: me neither [10:49:59] Nikerabbit: yes, I told him [10:50:07] Nemo_bis: as Nikerabbit said earlier, he probably just edited the wrong language [10:50:12] sure [10:50:26] hashar: so when will the test be fixed not to rely on false assumptions? [10:50:44] Nemo_bis: whenever someone look at them ? :D [10:51:01] hashar: do you mean that you're going to file a bug? ;) [10:51:02] New patchset: Hashar; "wfIniGetBool: reduce strtolower() calls" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65941 [10:51:14] Nemo_bis: I am not going to do anything sorry [10:52:04] New patchset: Hoo man; "Allow patrolling page creations from Special:RecentChanges" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65958 [10:52:08] looks like tests/phpunit/includes/MessageTest.php has the message content hardcoded [10:52:16] should probably fetch it directly from the PHP Language file [11:02:41] ohh a hashar [11:03:26] I sent you an email cause I thought you weren't going to be irc-reachable... [11:04:04] want to redo the media setup for beta to be more like prod and to fix some brokenness [11:04:52] this would involve setting up a separate upload.beta instance, and changing some configs too (handle n 404 and not on parse)... is this going to interfere with stuff you are doing? do you have specific plans for the setup? [11:05:28] if you are not really here feel free to ignore and I'll hear about it later [11:05:34] New patchset: VitaliyFilippov; "Add russian messages for bad title errors." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/44397 [11:05:35] New patchset: VitaliyFilippov; "Show detailed errors for bad titles." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166 [11:07:14] apergos: yeah hmm sorry :D [11:07:28] apergos: so I am back though under cover hehe [11:07:41] ok I will not let on to anyone [11:07:45] is this channel logged? :-D [11:08:03] hopefully not ! [11:08:27] * apergos avoids looking at the topic [11:08:42] so yeah upload is most probably broken [11:08:48] New review: VitaliyFilippov; "OK, I've changed it to a separate function, newFromTextThrow() that throws BadTitleError in case of ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/43166 [11:08:55] I have set up in a rush trying to have something more or less working [11:10:20] do you mind if I take it over? and also, likely I will break other parts of it for short periods, would I need to advtertise that somewhere to some people? [11:12:00] apergos: go ahead :-] [11:12:05] ok! [11:12:21] apergos: though the upload varnish cache is a bit messy [11:12:36] I got a few patches to adapt the puppet class in labs, that never got merged iirc [11:12:43] uh oh [11:13:23] I guess I should see what the upload caches do, I'm more concerned with what happens when a request makes it past the cachs [11:13:23] caches [11:13:23] that's what I will start with first [11:25:23] New patchset: VitaliyFilippov; "Give permission hooks a chance to override deny permissions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/32566 [11:25:56] New review: VitaliyFilippov; "Someone, please review!" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/32566 [11:32:30] New patchset: Njw; "Make all PHP follow mediawiki's code conventions" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65960 [11:34:37] New review: VitaliyFilippov; "Sorry for not answering..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/34338 [11:36:11] New review: Njw; "Nobody is going to want to review large code convention stuff, so I'll just force it through." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65960 [11:36:11] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65960 [11:42:42] New patchset: Matmarex; "Add limit report data on preview pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53802 [11:46:51] New review: Matmarex; "Rebased on top of https://gerrit.wikimedia.org/r/#/c/54089/ , as promised." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/53802 [11:49:50] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65666 [12:31:32] New patchset: Nikerabbit; "Show main page only for logged in users for now" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65966 [12:37:05] New patchset: Nikerabbit; "Fix ULS positioning" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65967 [12:38:13] New review: Nikerabbit; "Santhosh: let me know if you have better ideas." [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/65967 [13:06:20] New patchset: Netbrain; "changed json output ever so slightly" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/65971 [13:07:39] Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/65971 [13:53:12] New patchset: VitaliyFilippov; "Private access is pointless here. Change it to protected. Also remove deprecated newFromURL() usage." [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65976 [13:53:13] New patchset: VitaliyFilippov; "Allow to select whether to copy full page history." [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65977 [13:53:13] New patchset: VitaliyFilippov; "Do not fail when revision count exceeds , just copy recent revisions. Also report copied revision count and include last revision number in copied article summary." [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65978 [13:53:13] New patchset: VitaliyFilippov; "Allow to duplicate subpages" [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65979 [13:53:13] New patchset: VitaliyFilippov; "Add license (I assume GPLv2) and bump version" [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65980 [13:53:14] New patchset: VitaliyFilippov; "Add .gitreview" [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65981 [13:53:32] hi mooeypoo how are you? [13:54:22] Change merged: Demon; [mediawiki/extensions/Duplicator] (master) - https://gerrit.wikimedia.org/r/65976 [13:54:33] hey hoo. It was good to see you this weekend! [13:55:40] New patchset: Parent5446; "Add bot to createAndPromote.php groups" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65872 [13:56:12] Glad to hear... I also enjoyed it a lot :) [13:56:24] New patchset: Hashar; "overhaul maintenance/mwdocgen.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [13:57:12] New review: Hashar; "Sneak in a:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [13:58:25] Change abandoned: Hashar; "MultiTestRecorder is not really needed, so finally abandoning this change." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/35805 [13:58:30] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65579 [13:58:32] hoo: great! we welcome your feedback in the survey, and if you could, post to the https://www.mediawiki.org/wiki/Talk:Amsterdam_Hackathon_2013#What_I_did_in_the_hackathon_27993 thread [14:00:21] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65433 [14:01:07] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65941 [14:01:51] sumanah: Will do :) [14:02:41] thanks! [14:04:37] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [14:06:53] Change abandoned: Anomie; "We're going to go with Matmarex's version." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65579 [14:09:14] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65579 [14:11:39] anomie: ^ [14:12:13] MatmaRex: Oh, you didn't do a kill-it-in-Vector patch along with yours? [14:12:40] anomie: no, i assumed yours exists :) [14:13:05] and i didn't make one in thefirst place mostly since i was lazy [14:13:25] Ok, I'll submit mine in a few minutes. [14:13:39] and since i didn't copy over any modules, so there would probably be little trouble if it stayed [14:15:57] MatmaRex: BTW, re !g 54089 I'm not too sure about putting it into mediawiki.action.edit.js. That might make it hard to use it with Special:TemplateSandbox. [14:17:45] hmm [14:17:57] * MatmaRex has no idea how TemplateSandbox works [14:18:13] i haven't yet had the opportunity to use it for anything serious [14:18:49] Change abandoned: Siebrand; "Thanks for the patch. Now abandoned per Pau's comment. Can be revived if needed." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/49619 [14:19:43] MatmaRex: There's two pieces to it. The piece with the extra field on the edit page should just work. The piece accessed from Special:TemplateSandbox will need to load the footer-collapsing code manually. [14:20:29] is ^demon around this week? [14:20:55] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [14:21:13] anomie: hmm. makes sense [14:21:26] Nikerabbit: he said he's back but hiding behind walls of emails [14:21:46] just asking because https://bugzilla.wikimedia.org/show_bug.cgi?id=48884 [14:22:04] New patchset: Anomie; "Remove jquery.footerCollapsibleList and use of it to core" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/65987 [14:22:40] anomie: i'll split this to a separate module in a minute, then [14:22:48] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [14:22:48] New patchset: Aude; "Update Wikibase with patches for property parser function" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65988 [14:24:25] anomie: mediawiki.action.edit.collapsiblefooter? [14:25:30] MatmaRex: Maybe. Except it's really more "mediawiki.action.preview"; Special:TemplateSandbox sort of separates previewing from editing. [14:25:54] there is mediawiki.action.edit.preview already [14:25:56] New review: Hashar; "Cant we put that on HTMLFormField directly ? I guess the 'disabled' attributes could be supported t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62014 [14:26:02] mediawiki.action.edit.preview.collapsiblefooter? [14:26:08] it's starting tofeel java-ish [14:26:18] <^demon> Nikerabbit: Yes. [14:26:19] collapsibleFooter, even. [14:27:03] MatmaRex: Heh, mediawiki.action.edit.preview should probably have been mediawiki.action.edit.livePreview. Oh well. [14:27:21] anomie: i'd go with mediawiki.action.edit.collapsibleFooter still [14:27:30] anomie: the primary core features are active in both preview and edit mode [14:27:40] MatmaRex: I won't oppose it on the basis of the name. [14:27:51] yeah, i'm just trying to get it right the first time :) [14:28:19] MatmaRex: Re Java-ish-ness: ve.ui.MWLinkTargetInputWidget.prototype.onLookupMenuItemSelect ;) [14:28:32] <^demon> Nikerabbit: I saw the bug already. [14:29:31] MatmaRex: BTW, looking for the "

" isn't safe. What if someone edits [[MediaWiki:Templatesused]] to itself be a block-level element? [14:29:42] RoanKattouw: hah [14:30:21] anomie: yeah, i had this issue when working your patch into this, i'll have to change the styling somewhat to get rid of that [14:30:41] anomie: (i had to change a ->parse() to ->parseAsBlock(), but imo it's a good idea to do that anyway) [14:31:44] MatmaRex: You could just do what the Vector version did: kill the "Explanation" div completely and insert your own toggler with your own message in its place. [14:33:01] anomie: that felt completely unnecessary to me [14:33:50] anomie: if we did that, the show/hide text should change (it didn't in the vector version afaik) [14:34:02] MatmaRex: OTOH, your way things aren't right if [[MediaWiki:Templatesused]] itself contains a link. As it does on enwiki, for example. [14:34:11] anomie: and then there are plural-related l10n issues [14:34:17] New patchset: Njw; "Remove IE workarounds, as they're no longer needed. Also fix a couple of typos in previous commit." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65989 [14:34:28] since adding that little "View" at the beginning changes the grammar quite a bit [14:35:02] mediawiki.jqueryMsg has support for {{PLURAL:}} [14:35:04] and either you have to have plural variants, or use something awkward like "View the list of ..." [14:35:21] so at this point there are four variants for a single little bit of text [14:35:24] and we have three of those [14:35:31] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65989 [14:35:32] and it starts to smell fishy :) [14:36:43] anomie: i could enable the 'linksPassthru' option on $.makeCollapsible, and stop making those toggles links [14:36:48] i never liked this anyway [14:36:48] New patchset: Matthias Mullie; "Substitute $.ajax for mw.Api" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [14:36:54] i did it since the Vector version was that way [14:37:44] Yeah, I don't much care for the pseudo-links either. But I don't know whether it was tested and found that newbies find it clearer that way or something. [14:38:42] the same icon is used link-less all over the skin... [14:38:51] New patchset: Zfilipin; "Upgrade Ruby to version 2.0.0-p195" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65990 [14:39:05] New patchset: Matthias Mullie; "Cleanup JS" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/65565 [14:39:29] !g 24324 | MatmaRex [14:39:29] MatmaRex: https://gerrit.wikimedia.org/r/#q,24324,n,z [14:39:47] also, i stopped believing in stuff that was "tested" when people tried to convince me that choosing Helvetica over the default font matters because it was "tested" [14:40:18] anomie: "for accessibility" probably means "to make the focusable" [14:40:28] That would be my guess. [14:40:34] we could achieve the same by adding a tabindex to them, afaik [14:41:09] let me just figure out where does the new module have to be added and i'll upload that part for review [14:41:38] MatmaRex: You can probably crib that from my now-abandoned version [14:41:39] (looking at your changeset) [14:41:43] yeah, wsa going to [14:41:48] except that gerrit is sooo slow D: [14:42:33] New patchset: Njw; "Improve print stylesheet" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65992 [14:46:21] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65992 [14:47:24] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [14:47:38] New patchset: Hashar; "Renaming files to follow name conventions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65434 [14:47:49] anomie: ^^ i'll do something with the

and the now [14:47:55] New review: Hashar; "PS2 renames the class name as well." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65434 [14:51:00] Change abandoned: Matthias Mullie; "Abandoning in favor of the more thorough https://gerrit.wikimedia.org/r/#/c/65565/" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/47878 [14:54:46] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [14:55:09] anomie: ^ and that's a rough version of killing the [14:55:20] now i'm wondering if it needs some other indicator [14:56:42] do we have a sane way to add the tabindex, though? [14:56:54] because what i did really isn't one :/ [14:57:38] New review: Hashar; "Most probably fine. There is a tiny typo in defaultsettings, you might also add an entry in the rel..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65279 [15:00:08] MatmaRex: Doesn't tabindex="0" do what you probably want there? But still, someone who actually knows about accessibility should look at that. Also, BTW, now the link in the enwiki message becomes unusable even though it still looks like a link. [15:00:20] New patchset: Njw; "Make article heading h1, only uppercase h1, and make subheadings slightly smaller." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65995 [15:00:41] anomie: argh [15:00:51] i forgot about this... on it [15:02:24] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [15:03:24] anomie: and yeah, tabindex=0 should do the job. thanks [15:03:35] (http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#sequential-focus-navigation-and-the-tabindex-attribute) [15:04:14] New patchset: Matmarex; "Make the templates/category lists on edit page collapsible" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [15:04:39] greg-g: There should probably be an announcement about this: the collapsing of the "pages transcluded onto the current version of this page" and "This page is a member of 1 hidden category" lists on the edit page in Vector is probably going to make its way to all skins soon-ish. I.e. 1.22wmf6 soon-ish, if the patches don't take forever to get merged. [15:06:25] hrmmm [15:06:52] anomie: do we have screen shots available of the changes? [15:07:03] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65472 [15:07:07] greg-g: they ar elive on my testwiki, if you want to see [15:07:18] greg-g: http://users.v-lo.krakow.pl/~matmarex/testwiki/index.php?title=Strona_g%C5%82%C3%B3wna&action=edit [15:07:38] greg-g: feelfree to edit, just a note - always provide an edit summary, or you'll get an error [15:07:55] (this is a two-line hack that is a pretty effective spambot countermeasure ;) ) [15:08:29] greg-g: also, on an unrelated note, did you get my message about https://gerrit.wikimedia.org/r/#/c/64911/ ? [15:09:52] New patchset: Liangent; "Modules should be in English (while docs are not)" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/65998 [15:12:11] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65853 [15:14:55] New patchset: Njw; "Simplify hr image" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/66000 [15:17:56] New patchset: Andrew Bogott; "Fix a bug with trimming 'local-' from the requested service group name." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66001 [15:19:30] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65990 [15:19:30] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65990 [15:22:09] MatmaRex: hah re spambot prevention [15:23:12] MatmaRex: where would I have missed your note about the displayTitle change? :) [15:26:08] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [15:26:55] greg-g: via PM on IRC yesterday or the day before, i think [15:27:06] New review: Anomie; "(1 comment)" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/65998 [15:27:32] greg-g: they seem to be abusing this misfeature on en.wp right now a little, let me find you a link [15:27:49] people on other wikis might have thought about it as well [15:27:52] anomie: MatmaRex re those collapsable ui changes: once those are merged can I get a before/after screenshot(s) and 2 full sentences from one of you? Then I can do the rest.. [15:28:38] greg-g: http://toolserver.org/~tb/ODT (re displaytitle abuse on en.wp) [15:28:42] MatmaRex: ah, I see the ping now. Didn't know if I missed more context. [15:28:50] greg-g: ok [15:34:01] New patchset: Njw; "Correct footer margins so they always line up with content on left edge" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/66002 [15:34:04] https://gerrit.wikimedia.org/r/65958 This should be merged and backported before the deploy later today... :/ [15:34:34] New review: Liangent; "(1 comment)" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/65998 [15:35:02] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [15:35:25] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65995 [15:35:54] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/66000 [15:36:06] Reedy: ^ [15:36:14] hoo: make the bug a blocker to "next wmf deployment"? [15:36:20] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/66002 [15:36:22] !bug next wmf deployment [15:36:22] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=next+wmf+deployment [15:36:33] that one ^ [15:37:44] MatmaRex: I'm not sure how much of a blocker it is... we'll only know by the time people start to shout [15:38:00] Nemo_bis: ping [15:38:43] hoo: well, the point of the blocker bug is to get it merged before a deploy. If it "should be merged and backported before the deploy later today" then it is a blocker :) [15:38:55] hoo: pong [15:39:27] Nemo_bis: Do you consider your patrol bug to be annoying enough to make it a blocker one? [15:42:18] Nemo_bis: ^ [15:42:48] Nemo_bis: ie: does it need to go out now, or on June 6th with the new wmfXX? [15:44:09] I'm fine with it going out now if it will be a problem causer, just need to get it merged soon so Reedy can deploy it in 2 hours [15:45:40] hoo: I can imagine a few people being annoyed by it [15:46:16] but it takes some conditions: 1) small wiki where people use Special:RC for patrolling, 2) bot RC and NP patrolling enabled [15:46:40] Nemo_bis: These configurations are live on both Wikidata and commons AFAIR [15:46:59] the intersection of (1) and (2) is not huge, those could be checked [15:47:17] Don't you think people use Special:RC on commons or so? [15:47:24] nah [15:47:27] not for NPP [15:47:48] Ok [15:47:58] what's confusing about the bug is that You *think* you patrolled the page, but actually patrolled the revision [15:48:06] AFAICS [15:48:41] It's a bit weird (and has ever been) [15:49:04] :) [15:49:12] But the patch will tackle this [15:49:49] Nemo_bis: What about that other thing: Fallback to patrol the first revision in case the current one is already patrolled, important? (Or not even desired) [15:49:51] you all figure it out (whether to deploy today or not) and let me know ;-) [15:50:32] New patchset: Matthias Mullie; "api: Trim leading/trailing spaces from comments" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [15:50:43] I guess it would be safer to deploy today, but no big wiki is going to die without it [15:50:53] hoo: i can cherry pick it for you [15:51:07] aude: Has to be merged first [15:51:11] ok [15:51:11] (On master) [15:51:18] * aude preparing for wikidata deployment [15:52:25] New patchset: Parent5446; "Added NUMBEROFSUBPAGES core parser function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66003 [15:52:26] hoo: yes, that should be done; but I don't understand why the button at bottom of the page should ever do RC patrolling at all [15:52:47] Nemo_bis: Well, should it rather be at the top? [15:53:02] Or do you think rc patrolling should only happen on diffs [15:53:04] ? [15:53:06] it shouldn't be there at all; why can't revision patrolling be in diff as always [15:53:10] yes [15:53:20] or rather, I didn't see a reason to change [15:53:44] Well, if you see a revision of a page and it's fine, why not patrol it [15:53:49] maybe it was wrong before and it's just a change to communicate [15:54:09] because revision patrolling is about revision, not about page [15:54:30] maybe you see a page that is ok but last revision blanked half of its sections [15:55:03] ... [15:55:06] mh [15:55:43] Someone wanted that, maybe in the bug, AFAIR [15:56:12] that change was in gerrit for 5 months and no one complained about that [15:58:20] hoo: sorry, I hadn't understood this part [15:58:32] I'm not saying it's a catastrophe, mind you :) [15:58:46] Just that it's a non-obvious change [15:58:52] If we have it now and deploy and remove it next week [15:59:01] Someone will complain again [15:59:09] I don't think so [15:59:17] * hoo doesn't like unclear product designs [15:59:26] We could also measure if it increases RC patrolling :) [15:59:36] Let's use it as an experiment *sshhh* [16:00:03] MatmaRex: don't use tabIndex btw. [16:00:04] Anyway, the bug I filed has also a simpler solution, two alternatives [16:00:29] Nemo_bis: Simpler than these 3 lines of code? [16:01:37] Nemo_bis: Maybe we should have given those different link texts... like "Mark revision" and "Mark page creation" [16:04:28] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66006 [16:04:33] Nemo_bis: Made the bug a deployment blocker now... it's a real minor thing and you could consider it broken [16:04:54] But the rest of the functionality is IMO ok (maybe up for improvement, but ok) [16:09:51] * aude complains to hoo :) [16:11:00] hoo: a change being in gerrit without complaints for a long time doesn't mean much :) just fyi [16:11:22] Probably... people only care by the time it's on wiki (and broken) [16:11:38] well, and if people aren't poked to actualkly review it [16:13:47] hoo: yes, changing the message would be one requirement to make it clearer [16:14:46] hoo: why remove 39480 ? [16:15:08] Whooops [16:15:19] Wasn't on purpose [16:31:03] New patchset: Nikerabbit; "Remove list of message groups from api documentation" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66011 [16:36:40] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/Score] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61181 [16:36:40] Change merged: Aaron Schulz; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [16:42:10] hoo: on "Simpler than these 3 lines of code?", it took some reading but I understood the question at last, and replied on the two bugs :) sorry for not understanding before :/ [16:43:29] Nemo_bis: Yeah... the thing about "page patrolling" is weird... in reality it's not page patrolling but just patrolling the first revision ... [16:53:00] New review: Aaron Schulz; "Note that /64 for v6 is typically like "one person" unlike /24 for v4" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64021 [16:54:27] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [16:55:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64021 [16:56:12] hoo|away: not true, that's incorrect :) [16:56:21] you're thinking as a DB rather than as a user :p [16:56:43] that's the backend, but the meaning is not defined by how information is stored [16:57:37] patrolling the first revision patrols the page because they are the same thing; starting from second revision, the individual revision and the page as a whole (which is the history of it, the title etc.) start to diverge :) [17:01:53] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66011 [17:08:05] Hi Reedy ! First of all thanks for the Cadbury chocolate, although I misinterpreted its origin: https://twitter.com/quimgil/status/339775753522667520 [17:08:32] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/66014 [17:08:45] Reedy, also, are you the co-mentor of Incremental Data Dumps as suggested at https://www.mediawiki.org/wiki/Summer_of_Code_2013#Projects ? [17:09:24] ah sorry, Ariel just replied Reedy [17:11:03] New patchset: Yurik; "Updating to latest Zero extension" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66015 [17:11:42] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66015 [17:16:21] Nemo_bis: Whatever :P [17:22:05] New patchset: Kipcool; "Fixed: dm edit link disappeared when toggling." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66016 [17:22:52] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66016 [17:24:55] New review: Anomie; "Needs rebase. Will do that in a little bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63079 [17:35:48] New patchset: Anomie; "(bug 48294) API: Fix chunk upload async mode" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63079 [17:36:08] New review: PleaseStand; "I don't think there's much else I could object to. Please make sure you have a LocalSettings.php fil..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64866 [17:36:51] New patchset: Yurik; "Updating to latest Zero extension" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66019 [17:37:39] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/66019 [17:38:34] RoanKattouw_away: this is for you http://www.metafilter.com/128407/Time-flies-by-when-youre-the-driver-of-a-train [17:41:05] New patchset: Jeroen De Dauw; "Improvements to enrollment code [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63914 [17:41:55] New review: Hashar; "Ahhhh LocalSettings.php ... Good catch!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [17:42:14] New patchset: Yurik; "Updating to latest Zero extension" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66020 [17:42:40] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66020 [17:43:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63079 [17:53:53] New patchset: Kipcool; "Some i18n * Added 'Semantic annotations' and 'Lexical annotations' section titles to the i18n file * Removed 2 unused messages." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66022 [18:06:08] whym_away ping? [18:10:11] gwicke_away: gah, I forgot to add you as a reviewer [18:10:58] * AaronSchulz tries to make sense of https://integration.wikimedia.org/ci/job/parsoid-parsertests-run-harder/255/console [18:13:34] <^demon> AaronSchulz: https://integration.wikimedia.org/ci/job/parsoid-parsertests-run-harder/255/consoleFull is probably a little more enlightening. The truncation is arbitrary and usually not useful. [18:24:36] New review: Kipcool; "@Siebrand: can I rename Wikidata.i18n.php into WikiLexicalData.i18n.php , and it'll work without any..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/66022 [18:27:33] New patchset: Jeroen De Dauw; "Fix bad cp error in deprecated method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [18:28:35] New patchset: Reedy; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66006 [18:32:58] New patchset: Jeroen De Dauw; "Fix breakage due to changes in base class in core" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66025 [18:33:11] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/66006 [18:33:11] New patchset: Jeroen De Dauw; "Fix bad cp error in deprecated method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [18:33:57] New patchset: Reedy; "Update Wikibase with patches for property parser function" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65988 [18:39:14] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65988 [18:40:05] New review: Daniel Werner; "Looks good but I am not sure it should be done like this. Could imagine there are reasons why this h..." [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65816 [18:48:31] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54089 [18:55:34] New review: Kaldari; "This change breaks functionality in the PageTriage extension which is actively used by about half of..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [18:57:50] New review: Matmarex; "I think this was mentioned all over during the half a year it waited to be merged, including on wiki..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [19:02:42] thedj: Sigh. IE is always the problem. [19:08:21] New review: Kaldari; "I can't find anything about this in the Wikitech archives. I searched for 'patrol' in the subject, o..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [19:19:23] New patchset: Jeroen De Dauw; "Fixed phantom log entries for "course updates" that havent happened" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/66032 [19:20:02] has anyone used wikihadoop? [19:22:54] New patchset: Andrew Bogott; "Prompt user to agree to terms of use." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/66033 [19:23:47] New review: Andrew Bogott; "The terms of use page http://www.mediawiki.org/wiki/Wikimedia_Labs/Terms_of_use is marked as a draft..." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/66033 [19:23:55] New review: Matmarex; "I think I remembered http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064315.html , but..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [19:27:57] New patchset: Parent5446; "Fix bad cp error in deprecated method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [19:28:11] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66023 [19:29:56] New review: Matmarex; "Sorry – maybe I was CC'd on too many of those five or so bugs this fixed. I can't seem to actually..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [19:30:41] New review: Matmarex; "(This also fixes bug 43977, which wasn't mentioned in the commit message.)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [19:31:55] New patchset: Bsitu; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [19:33:51] New patchset: Bsitu; "New logic to determine whether to show curation toolbar" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66036 [19:35:04] New review: Bsitu; "This depends on https://gerrit.wikimedia.org/r/#/c/66035/" [mediawiki/extensions/PageTriage] (master) C: -2; - https://gerrit.wikimedia.org/r/66036 [19:36:42] New patchset: Bsitu; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [19:37:40] New review: Mwalker; "My argument would be that even if only used as a title we should support plural." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59060 [19:39:44] MatmaRex: if you don't know what https://bugzilla.wikimedia.org/show_bug.cgi?id=8697 has to do with the patch why did you mark its brother bug as fixed? :) [19:40:56] Nemo_bis: the other one had hoo saying that his patch fixes it? [19:41:01] unless i misread something badly [19:42:20] afaik that was a previous version of the patch [19:42:40] I'm now testing it on twn [19:46:49] New patchset: Bsitu; "New logic to determine whether to show curation toolbar" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66036 [19:50:08] New patchset: Hashar; "Oracle: DRCP and persistent connections support" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [19:50:35] New review: Hashar; "extended commit message, slightly tweaked release notes entry." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [19:50:54] Nemo_bis: thanks [19:50:59] is there any php programmers here that are better than me and ori-l? [19:51:48] AzaToth: that might not be the *best* way to ask :P [19:51:56] hehe [19:58:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [20:04:34] Reedy: were/will you be able to get the test FDC/board poll on test wiki done today? [20:06:44] New patchset: Hashar; "Fixed OracleUpdater::doPageRestrictionsPKUKFix prefix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65424 [20:09:20] New review: Hashar; "Ideally that large regex should be a public static method for which we could then write tests for :-]" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65490 [20:10:23] New patchset: Umherirrender; "Allow modification of flags on Recent Changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66038 [20:10:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65424 [20:11:30] ^demon: It looks like !g 65818 didn't fix things, now VE is just stuck at 5add8cc4. Also, I checked for other extensions with the same problem: EImage MagicNoCache MyVariables NamespaceRelations OpenStreetMapSlippyMap PHPExcel PerPageLicense TimelineTable VisualEditor [20:11:50] <^demon> Ugh. We had this problem before. [20:11:53] <^demon> I thought I fixed it. [20:15:14] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #63: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/63/ [20:15:25] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #83: FAILURE in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/83/ [20:23:50] New patchset: Matmarex; "Cologne Blue: add missing 'undeletethispage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66041 [20:25:39] MatmaRex: I don't see any group patrolling working on twn, not even 2 edits [20:30:22] New review: EBernhardson; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/66035 [20:30:29] New review: Kaldari; "That's OK. It should be easy enough to fix." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [20:42:54] Yippie, build fixed! [20:42:54] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #65: FIXED in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/65/ [20:50:38] New review: CSteipp; "VitaliyFilippov, can you point to a bug, or an explanation of what you are trying to accomplish with..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/32566 [20:54:48] Yippie, build fixed! [20:54:48] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #82: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/82/ [20:56:13] New patchset: Freakolowsky; "Fixed OracleUpdater::doPageRestrictionsPKUKFix prefix" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/66042 [20:56:48] Yippie, build fixed! [20:56:49] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #42: FIXED in 13 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/42/ [20:58:59] New review: Kaldari; "Now that we have tooltips, let's get rid of the temporary 'Learn more' link." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/61940 [21:09:13] New patchset: Hoo man; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:10:02] New review: Hoo man; "Fixed a typo + comment style" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:10:26] New patchset: Bsitu; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:10:32] New patchset: Hoo man; "Add new parameter $patrolFooterShown to hook ArticleViewFooter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:11:19] New review: Hoo man; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:14:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66035 [21:16:05] New review: CSteipp; "Not hearing any objections, and it seems sane and useful." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/52910 [21:18:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52910 [21:21:32] New review: Nemo bis; "Kaldari, Hoo was quite desperate about getting reviews for this change, so I'm sure he'll follow you..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [21:32:12] https://upload.wikimedia.org/wikipedia/commons/5/53/Wikimedia_Hackathon_2013_-_Day_3_-_Flickr_-_Sebastiaan_ter_Burg_%2833%29.jpg ... that was after I was gone ... [21:34:49] hoo: silly you. [21:38:24] Project browsertests-en.wikipedia.org-linux-chrome build #89: FAILURE in 4 min 11 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/89/ [21:38:48] New review: CSteipp; "I think it's useful to have the limit (and the ability to disable it) as a sanity check. At least un..." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/65704 [21:38:54] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65704 [21:40:20] Project browsertests-en.wikipedia.org-linux-firefox build #80: FAILURE in 4 min 15 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/80/ [21:40:56] New patchset: Nemo bis; "Link to mediawiki.org page in 'edithelppage' message" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [21:43:06] New review: Nemo bis; "Nikerabbit, I made it ignored as suggested by Siebrand and will commit a patch for mediawiki-defines..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62337 [21:46:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #55: FAILURE in 6 min 31 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/55/ [21:52:39] New patchset: Mattflaschen; "Make button text black for non-Vecotr buttons:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66044 [21:52:56] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #44: FAILURE in 6 min 5 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/44/ [21:53:34] New patchset: Mattflaschen; "Make button text black for non-Vector buttons:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66044 [21:55:45] New patchset: Aaron Schulz; "Respect $wgUsePrivateIPs for XFF headers." [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/66045 [21:56:35] Nikerabbit: any changes to that TTM job handling? [21:56:53] the jobs still just go in and sit there atm [21:57:09] maybe it could be fixed or more properly disabled [22:03:47] New review: Matmarex; "> Seems ok, though i think that this will make it impossible to reset your token in case you acciden..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [22:05:01] i need tofix my spacebar. [22:09:50] New patchset: Mattflaschen; "Show toolbar after post-edit is done, if applicable." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [22:10:15] New review: Mattflaschen; "This is ready for review." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [22:11:07] AaronSchulz: zzzzzzzzz [22:12:17] from what I remember it wasn't tested whether vanadium would be able to sustain the load with a more aggressive timeout? [22:12:46] the jobs went on for hours, but when things work are supposed to last max 30 s or so iirc [22:15:59] Change merged: jenkins-bot; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/66036 [22:16:16] New patchset: Mattflaschen; "Move cookie-related functionalty from Guiders.js to GuidedTour." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [22:17:57] New patchset: Cmcmahon; "Merge "Upgrade Ruby to version 2.0.0-p195"" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66046 [22:18:13] Nemo_bis: also, if we turn them on again, should I nuke the old ones? [22:18:22] otherwise people might get ancient notices all at once [22:18:45] Change abandoned: Cmcmahon; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66046 [22:19:54] AaronSchulz: notices? TTM != TranslationNotifications [22:20:13] ah, of course [22:20:22] translation memory will need to be updated at some point, I don't know if Niklas already plans a rebuild [22:20:28] * AaronSchulz was looking at those two so much he mixed them up [22:20:32] :) [22:20:55] if there's a huge backlog I guess vanadium might not like it? [22:21:41] I can run them serially first via a single threaded script [22:21:56] that would be nice I think; they'll need to be run anyway at some point [22:22:06] maybe I can try that now [22:22:09] translations are not updated *that* often, so there's not much duplication [22:23:17] New patchset: Spage; "Darker labels in new login and create acct forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66047 [22:31:30] New review: Kaldari; "question.svg and question-small.png look consistent with each other, but question.png seems to be a ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61939 [22:32:39] New patchset: Parent5446; "Added throttling framework." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34677 [22:32:48] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [22:34:16] New patchset: Cmcmahon; "Basic VE editing test for review and comment" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66050 [22:37:53] New patchset: Cmcmahon; "Basic VE editing test for review and comment" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66050 [22:38:53] New patchset: Parent5446; "Changed temporary password system to use tokens." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27472 [22:39:35] New patchset: Parent5446; "Notify user by email when password changed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48578 [22:45:59] possibly odd question to satisfy my curiosity: I noticed that some non-existant pages return 304, and others return 404. Why is that? [22:47:51] I remember we added exceptions for categories and user pages, right? [22:48:02] New review: Cmcmahon; "It is a little tricky to get access to the elements 'content', 'review_and_save' and 'looks_good'. ..." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/66050 [22:48:06] Or are you speaking of other cases [22:53:08] no, non-existent pages in mainspace sometimes give 304, and sometimes give 404. At first I thought it was only 304 for deleted pages, but I just saw another, which I promptly can't reproduce (though I can still reproduce 304 on &action=edit&redlink=1 i.e. http://en.wikipedia.org/w/index.php?title=Lime_Verbena&action=edit&redlink=1 is 304, http://en.wikipedia.org/w/index.php?title=Lime_Verbena [22:53:08] is 404 ) [22:53:35] though on a third reload the &action=edit&redlink=1 variety gives me 200 [22:59:09] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [23:00:39] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [23:01:15] New review: EBernhardson; "question.png has been removed. If a static version is needed in the future it can be rendered from ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [23:06:22] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [23:07:03] New review: EBernhardson; "I removed the learn more link. Couldn't decide if i should also remove echo-learn-more from i18n. ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [23:09:01] New patchset: Mwjames; "SMW\SQLStore\StatisticsCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [23:09:57] Yippie, build fixed! [23:09:57] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #64: FIXED in 8 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/64/ [23:10:24] Yippie, build fixed! [23:10:24] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #84: FIXED in 9 min 10 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/84/ [23:11:10] New patchset: Parent5446; "Moved account creation throttle to ping limiter" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65867 [23:12:34] New patchset: Mwjames; "SMW\SQLStore\WantedPropertiesCollector" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66052 [23:13:18] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [23:13:24] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [23:18:01] New review: VitaliyFilippov; "I don't think there is a bug in your Bugzilla..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/32566 [23:24:58] New patchset: Mwalker; "WIP: Allow MW and extensions to declare included components" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/66054 [23:35:09] New review: Nemo bis; "https://bugzilla.wikimedia.org/show_bug.cgi?id=48956" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [23:38:11] New patchset: Mwjames; "SMW\Settings enable nested settings" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66056 [23:39:48] New patchset: Yaron Koren; "Improved parsing of free text" [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/66057 [23:42:06] Change merged: Yaron Koren; [mediawiki/extensions/DataTransfer] (master) - https://gerrit.wikimedia.org/r/66057 [23:43:05] New patchset: Mwjames; "SMW\Settings enable nested settings" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/66056 [23:49:04] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #43: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/43/