[00:05:05] AzaToth: https://github.com/azatoth/twinkle/pull/157 it would be nice, if you could test it (as I've only tested it in the console) [00:06:18] Would be nice to have that change on the wikimedia wikis on Wednesday [00:40:00] Yippie, build fixed! [00:40:01] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #41: FIXED in 5 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/41/ [00:43:18] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #55: FAILURE in 9 min 6 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/55/ [01:21:46] hoo the rcid info is in the link, why can't it be available from mw.user? [01:21:52] or similar [01:22:49] eh? what? [03:04:43] New patchset: Bsitu; "(bug 47912) Visting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [03:14:10] New patchset: MZMcBride; "(bug 47912) Visiting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [03:34:49] Does anyone know of a database called "wiki"? :/ [03:40:46] inrelation to what? [03:43:52] p858snake|l: I'm going through InitialiseSettings.php and saw it, but I'll remove it. [03:45:51] Oh, heh. [03:45:56] It's a wiki family in that file. [03:46:01] wiki == wikipedia [03:46:05] OK [03:46:12] There are families of projects. [03:46:16] * Hazard-Away forgot that :P [03:46:18] And there are individual projects. [03:46:29] So private is a grouping. [03:46:33] As is fishbowl. [03:48:54] Susan, p858snake|l: Is it safe to assume that setting protocol relative URLs won't break anything once it's a valid URL? [03:49:12] Doesn't sound safe to me. [03:53:31] Susan: Is a list of all the groups available? [03:55:15] Read the file? [03:59:23] Hazard-Away: are you talking about your own wikifarm setup or the wmf one? [03:59:59] p858snake|l: WMF ... for some reason I can't find it so far [04:00:22] Where are you looking? [04:01:26] we have private, fishbowl and normal afaik [04:01:45] But where are they documented? [04:02:11] * Hazard-Away has to go, so I'll probably have to pick up later. [04:02:49] https://noc.wikimedia.org/conf/wgConf.php.txt [04:04:59] https://noc.wikimedia.org/conf/CommonSettings.php.txt [04:05:15] foreach ( array( 'private', 'fishbowl', 'special', 'closed', 'flaggedrevs', 'small', 'medium', 'large', 'wikimania', 'wikidata', 'wikidataclient' ) as $tag ) { [04:05:48] Susan: Thanks [04:18:31] New patchset: Santhosh; "Do not use "System" as a font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65708 [04:29:22] New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/65693 [04:36:26] New patchset: Mwjames; "SMW\CacheHandler" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64476 [04:43:43] New review: Mwjames; "I'm being bold here but I really need this for successive classes otherwise I have to re-revisit all..." [mediawiki/extensions/SemanticMediaWiki] (master) C: 2; - https://gerrit.wikimedia.org/r/64476 [04:45:01] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64476 [04:52:17] New review: Amire80; "Looks good. I tested it and it didn't break anything. I couldn't reproduce the original bug myself, ..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/65708 [04:56:04] New patchset: Pastakhov; "add global variables and predefined $GLOBALS (version 0.3.3)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65709 [04:57:13] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65709 [05:36:06] New patchset: Rfaulk; "rm. argv argument in parseargs obsolete." [sartoris] (master) - https://gerrit.wikimedia.org/r/65710 [05:36:07] New patchset: Rfaulk; "fix. parseargs test for presence of args." [sartoris] (master) - https://gerrit.wikimedia.org/r/65711 [05:36:44] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65710 [05:37:03] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65711 [05:38:08] New patchset: Siebrand; "Clarify labels for input methods" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65712 [05:50:02] New patchset: Siebrand; "Clarify labels for input methods" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65712 [05:54:35] New patchset: Siebrand; "Clarify labels for input methods" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65712 [05:57:26] New review: Siebrand; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65708 [06:00:49] yay I just patrolled my first new page without rcid :) [06:14:13] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [06:14:56] New patchset: Siebrand; "Don't show anonymous users tipsy with setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [06:31:16] New patchset: Mwjames; "Add SMW\StatisticsCollector class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/60092 [06:56:35] New review: Siebrand; "Demoed. Looks good." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 1 - https://gerrit.wikimedia.org/r/63848 [06:59:26] New review: Mwjames; "If you need an example in how to turn a non-testable method ( e.g SMWSQLStore3::getStatistics) into ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [07:02:24] New patchset: Wikinaut; "added newline character after the delete message." [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [07:02:35] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/UserMerge] (master) - https://gerrit.wikimedia.org/r/60675 [08:06:04] New review: Waldir; "Thanks for clarifying that, Demon. Indeed the script currently has "admin" as a required argument, b..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65613 [08:07:45] New review: Waldir; "Got it, will do. But I'm not sure what you mean by "an extra class or two for the special circumstan..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [08:49:33] New patchset: Physikerwelt; "Added new Feature for comparing Renderer Output" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65764 [08:51:13] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65764 [09:03:42] New patchset: Nischayn22; "Fix compatibility with SemanticForms versions > 2" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65765 [09:05:19] New review: Spage; "This change does too much. The new login form messages and Agora styles are now in core, and https:/..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/56058 [09:10:43] New review: Spage; "@Parent5446, This just adds a vform option to HTMLForm, without dependencies. An adaptation of https..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [09:13:38] New patchset: Nischayn22; "Removed inherited float:left so it aligns properly" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65766 [09:28:12] New patchset: Nischayn22; "Fix invalid URL to SemanticWatchlist in credits" [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/65767 [09:51:46] RoanKattouw: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:js-deprecations,n,z [10:06:52] New patchset: Mwjames; "Improve code coverage, add exception testing and codeCoverageIgnore" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65769 [10:13:40] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/65440/2//COMMIT_MSG [10:16:06] Reedy: Ping. [10:21:52] is gerrit flaky for anyone else too, or is it me? [10:22:10] New review: Krinkle; "Use classnames that relate to the module they're in. I'd recommend module "mediawiki.icon" or "media..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65414 [10:24:30] New patchset: Nikerabbit; "Cope with missing hover-in event in stats tables row highlightning" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [10:25:19] New patchset: Krinkle; "ResourceLoader: Prevent prefixless modules from overwriting others" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65678 [10:29:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65678 [10:29:54] New review: Daniel Kinzler; "fixed doc comment and rebased." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28199 [10:39:16] New patchset: Mwjames; "Improve code coverage, add exception testing and codeCoverageIgnore" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65769 [10:39:35] New patchset: Mwjames; "Use ResultPrinterTestCase" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/65771 [10:41:21] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [10:44:49] New review: Mwjames; "Tests are working again, not sure why SRF is not running unit tests on jenkins ..." [mediawiki/extensions/SemanticResultFormats] (master) C: 2; - https://gerrit.wikimedia.org/r/65771 [10:44:54] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/65771 [10:45:09] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65769 [10:46:51] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [10:49:56] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [10:51:40] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [10:58:39] Change abandoned: Ori.livneh; "(no reason)" [mediawiki/core] (wmf/1.21wmf12) - https://gerrit.wikimedia.org/r/56519 [11:20:13] New review: MarkAHershberger; "I have some commits ready to submit that handle this. I talked with Chris this past weekend about c..." [mediawiki/tools/release] (master) C: -2; - https://gerrit.wikimedia.org/r/65649 [11:22:52] New patchset: Ori.livneh; "Add Scribunto role" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/65775 [11:23:56] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/65775 [11:25:19] New review: Ori.livneh; "Yes, Matt is right." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [11:25:57] New patchset: Krinkle; "make-release: Resolve redirect to secure.wikimedia.org" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65776 [11:26:28] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65483 [11:37:57] New patchset: Alex Monk; "mediawiki.searchSuggest: Use mw.Api instead of jQuery.ajax" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65645 [11:42:19] Change merged: MarkAHershberger; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65776 [11:42:41] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65591 [11:47:27] >> ( function () { return this; }() ); [11:47:27] Krinkle: (object) {} [11:49:28] >> ( function () { function foo () { return this; } return foo(); }() ); [11:49:29] Krinkle: (object) {} [11:49:34] >> ( function () { "use strict"; function foo () { return this; } return foo(); }() ); [11:49:35] Krinkle: undefined [11:49:41] exactly [11:49:58] >> ( function () { "use strict"; return this; }() ); [11:49:58] Krinkle: undefined [12:02:16] New patchset: Lewis Cawte; "Add additional newer language codes." [mediawiki/extensions/ShoutWikiAds] (master) - https://gerrit.wikimedia.org/r/65783 [12:05:34] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65481 [12:10:11] New patchset: PleaseStand; "Check if API enabled before loading dependent JS modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [12:13:26] New patchset: Physikerwelt; "Fix: Remove file output from parserTest function" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65787 [12:14:28] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65787 [12:16:12] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65788 [12:17:35] New review: PleaseStand; "I'll note that I had sent in a change (I983bfc24) to just remove the settings in question, which was..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65785 [12:42:42] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65539 [12:43:26] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65700 [12:44:06] anybody got a moment to help me with gerrit? [12:44:40] i've signed up for an account, but am not sure whether there is some magical developer rune I need to get [12:45:18] i [12:45:20] I don't believe so [12:45:26] good oh. [12:45:58] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65701 [12:46:20] thanks. so i have some code to contribute to ConfirmEdit. Is there some way of submitting my code that connects it with the original project, or should I just create a new, stand alone project? [12:46:35] You can create a commit in ConfirmEdit and submit it for review [12:46:36] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65702 [12:46:56] It won't be a separate project, it'll just be submitted for review to (and hopefully merged in) the original project [12:49:30] RoanKattouw: okay. so it looks like there's no upload via gerrit's web interface, so I need to configure my pubkey, clone the repo, add my changes, commit and push [12:49:33] is that the way it works? [12:49:49] strixUK: You do need the shell userright, But generally that is given pretty quickly after your account creation (depending on the timezones when you created the account) but I would imagine you get a message on your talk page [12:49:57] strixUK: yes [12:50:00] Pretty much [12:50:06] strixUK: yes, though the push would be to a special path. you can install git-review, that makes things easier [12:50:10] Except that in the last step, instead of pushing with "git push" you use "git review" [12:50:14] (when it's not getting confused) [12:50:18] Yeah what DanielK_WMDE said [12:50:39] strixUK: https://www.mediawiki.org/wiki/Gerrit has our starting guides and such [12:50:40] strixUK: https://www.mediawiki.org/wiki/Git/Workflow [12:50:47] p858snake|l: ah, thanks for that. i only just created my account (within the last hour), so i imagine i'll have to wait [12:50:48] p858snake|l: You don't need shell to use git review, do you? [12:50:57] The Gerrit tutorial implies you don't [12:51:00] RoanKattouw: afaik you need it to access git [12:51:08] p858snake|l, DanielK_WMDE: much appreciated, thank you both [12:51:55] strixUK: the workflow looks a bit dounting at first, but it's pretty easy once you get into it. [12:53:16] DanielK_WMDE: i've used git a bit, but most of my experience is with SVN and CVS (back when). I had to get up to speed very quickly since none of my codevs had the slightest clue about branching and release management etc. i'm afraid i've forgotten a lot, but it won't take long to refresh memory [12:53:32] DanielK_WMDE: well when you point to the advanced document version, it might be [13:04:00] p858snake|l: either somebody has already granted me shell userright, or i don't need it (at least, to clone via git+ssh) [13:14:47] sigh, gerrit crashing my firefox [13:17:48] sigh, gerrit. [13:21:36] New patchset: Strix; "Add support for the AreYouAHuman/PlayThru CAPTCHA" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/65797 [13:24:36] okay, that was straight forward enough. [13:25:01] I spoke with brion about this yesterday, so presumably he'd be a good candidate for a reviewer. how do i find his user name? [13:25:14] typing [13:25:33] ah [13:25:47] should i add anybody else's? [13:27:17] for now probably not, ConfirmEdit doesn't have true maintainers [13:28:18] ack, thanks for your help [13:29:08] strixUK: if nobody reviews your comment in a while, check commit history [13:30:36] New review: Strix; "Where and when should I write installation instructions for using this new AyahCaptcha module?" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/65797 [13:30:58] Nemo_bis: okay, thanks [13:34:41] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65712 [13:39:26] New patchset: Matthias Mullie; "Add 'all but inappropriate' filter" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/65799 [13:43:38] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [13:53:48] ^demon: if i ask gerrit to "recheck" a patch, should it do the full tests again? [13:53:56] <^demon> I think so? [13:53:59] oh [13:54:07] it only did +1 unless maybe i am impatient [13:54:08] https://gerrit.wikimedia.org/r/#/c/65794/ [13:54:14] * aude can edit the commit message [13:54:20] <^demon> That'll do it ;-) [13:54:39] yep [13:57:01] New patchset: Santhosh; "Customise linktrail for Gujarati (gu)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65449 [13:57:55] New review: Santhosh; "Nemo, as clarified in the bug discussion, we need entire gu unicode block" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65449 [14:01:08] aude: comment with "recheck" iirc [14:06:26] Change merged: Jack Phoenix; [mediawiki/extensions/ShoutWikiAds] (master) - https://gerrit.wikimedia.org/r/65783 [14:07:11] recheck has always only ran the +1 tests for me. [14:07:48] p858snake|l: did that [14:07:55] updating the commit message worked [14:20:00] New review: Strix; "On advice, I've updated mw:Extension:ConfirmEdit with tentative installation instructions:" [mediawiki/extensions/ConfirmEdit] (master) - https://gerrit.wikimedia.org/r/65797 [14:22:46] New patchset: Matmarex; "Don't use a for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [14:23:21] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/65283 [14:31:34] RoanKattouw_away: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/1263/console [14:32:53] Change abandoned: Jeroen De Dauw; "oh, this is where I put the code..." [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/61581 [14:34:54] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [14:35:22] New review: Wikinaut; "! rebased but *NOT* yet tested !" [mediawiki/extensions/OpenID] (master) C: -2; - https://gerrit.wikimedia.org/r/55287 [14:37:07] New review: Nischayn22; "This needs more work. I tried the following:" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/65318 [14:38:56] New review: Nischayn22; "https://bugzilla.wikimedia.org/show_bug.cgi?id=40921 occurs again too" [mediawiki/extensions/UploadWizard] (master); V: -1 - https://gerrit.wikimedia.org/r/65318 [14:48:01] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [14:51:32] New patchset: Wikinaut; "(bug 44819) introduction of array of $wgOpenIDProviders" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/55287 [15:01:29] New patchset: Njw; "Remove redundant CSS, merge wiki-style.css into erudite.css, misc tidying, small style changes" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65813 [15:03:49] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64951 [15:09:30] New patchset: Njw; "Remove redundant CSS, merge wiki-style.css into erudite.css, misc tidying, small style changes" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65813 [15:10:53] New review: Njw; "This is too big for others to review, I'll just accept it :)" [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65813 [15:10:53] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65813 [15:11:28] TimStarling: I'm sitting here with James_F thinking about the tiny patrolling bit fields to be in revision. Just wondering if you could discuss this with Ashar as well, or are you confident that he will not veto it out? [15:11:50] I mean, nothing is sure until it has happened, but I just want to know if I can make reasonable assumptions on this for the long term. [15:12:27] New review: Njw; "OK, this seems to be reasonable now, I'll merge it." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64827 [15:12:27] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [15:12:55] New patchset: Jeroen De Dauw; "Revert "Remove obsolete test registration code"" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65815 [15:13:00] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65815 [15:15:29] New patchset: Jeroen De Dauw; "Get rid of manual test registration" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65816 [15:35:27] ^demon: Any idea why the VisualEditor submodule in mediawiki/extensions is stuck on revision a7030a5? [15:35:40] <^demon> Lemme look. [15:37:42] New patchset: Umherirrender; "ApiHelp: Avoid header for example, when there no examples" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65638 [15:40:53] Change abandoned: Umherirrender; "Too big commit and too many different files for a good review. Also this change is with less benefit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63896 [15:41:10] New patchset: Demon; "Force VisualEditor to master, weird" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/65818 [15:41:13] New patchset: Umherirrender; "Add list=allfileusages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [15:41:23] <^demon> anomie: Have a look at 65818. No clue why :\ [15:42:05] ^demon: Hoping that doing that will convince it to start being updated automatically again? [15:42:17] <^demon> Perhaps. [15:42:24] <^demon> At the very least, at least we'll get updated. [15:42:41] Change merged: Demon; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/65818 [15:42:55] New review: Anomie; "Well, here's hoping it starts working after this." [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/65818 [15:43:09] Heh. I just tried to +2 it too. [15:43:23] <^demon> Midair collisions! [15:44:42] !bug 48893 | ^demon [15:44:42] ^demon: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=48893+%7c+%5edemon [15:45:27] Huh? [15:45:28] !bug 48893 | anomie [15:45:28] anomie: https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=48893+%7c+anomie [15:45:31] !b 48893 | anomie [15:45:32] anomie: https://bugzilla.wikimedia.org/48893 [15:45:47] Oh, ok. "!bug" and "!b" are not the same. [15:46:10] New patchset: Santhosh; "Do not use "System" as a font" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65708 [16:02:06] New patchset: Wikinaut; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [16:02:28] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65788 [16:02:29] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65788 [16:06:55] hey chrismcmahon [16:07:03] got a chance to use the github stuff yet? [16:23:26] Change abandoned: Aaron Schulz; "Patch unmaintained" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/49990 [16:29:29] hi YuviPanda [16:29:41] ohai chrismcmahon [16:30:12] Yippie, build fixed! [16:30:12] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #78: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/78/ [16:33:15] YuviPanda: haven't tried out the github thing yet, but zeljkof and I both have it on the list. (We just got back from Amsterdam yesterday) [16:33:27] right :) [16:35:03] New review: Daniel Friesen; "I mean anonlogin is not simply logged out so a user-loggedout or user-anon won't work. We'll need so..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [16:38:35] Change abandoned: Aaron Schulz; "Patch is unmaintained" [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/53050 [16:39:00] Yippie, build fixed! [16:39:01] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #56: FIXED in 6 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/56/ [16:46:45] i'm looking for how to appropriately deliver either SVG or PNG icons, i see a few different methods grepping around MW including css rules that use linear-gradient so unsupported browsers ignore the rule, or only pulling in svg specific css if window.devicePixelRatio > 1, probably other methods as well. Is there a preferred method? [16:50:50] New patchset: Jdlrobson; "Give skin more control of OutputPage modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [16:55:03] New patchset: Aaron Schulz; "Add EraseDeletedFile.php script to purge deleted files from storage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [16:55:26] New patchset: Njw; "Switch all CSS to follow Mediawiki's coding conventions, and separate css reset" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65824 [16:57:36] does anyone have experience with wikihadoop? [16:59:25] New patchset: Kipcool; "Replaced deprecated wfMsg* with wfMessage also changed DM edit button from div to span" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65825 [17:00:34] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65826 [17:02:44] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65638 [17:05:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65638 [17:15:14] New patchset: Liangent; "(bug 22808) Don't count "expensive" calls for cached titles" [mediawiki/extensions/ParserFunctions] (master) - https://gerrit.wikimedia.org/r/65828 [17:19:48] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65826 [17:20:05] New review: Mdale; "I take it this means, the error string can be populated while the stream was successfully created?" [mediawiki/extensions/TimedMediaHandler] (master); V: 2 C: 1; - https://gerrit.wikimedia.org/r/64913 [17:24:24] New review: Njw; "This one is going to be too much work to review, and utterly uncontroversial, so I'll accept it. It ..." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65824 [17:24:25] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/65824 [17:24:41] Susan: ping [17:29:55] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [17:30:20] !b 48901 | Susan [17:30:21] Susan: https://bugzilla.wikimedia.org/48901 [17:34:31] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65317 [17:47:09] New patchset: Matthias Mullie; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65832 [17:50:06] New review: J; "it does not get set to empty string if a failed encode is run again, should also look into resetting..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64913 [17:51:38] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65832 [17:51:43] New review: Anomie; "Code looks ok. It might simplify things to force $wgEnableWriteAPI = false in Setup.php if $wgEnable..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65785 [17:56:57] New patchset: J; "only count failed transcodes as failed" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64913 [17:58:26] Change merged: Mdale; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64913 [18:07:15] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [18:08:00] j^: does https://bugzilla.wikimedia.org/show_bug.cgi?id=43331 seem interesting? [18:11:41] awjr, do you have a sec? I have a question about mobile account registration data in April [18:11:54] New patchset: Mwjames; "Fix global usage in SpecialPages and its pending tests" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65833 [18:12:23] DarTar: sre [18:12:25] what's up? [18:12:29] s/sre/sure [18:14:04] ok awjr check http://toolserver.org/~dartar/reg2/#mobile - we have a couple of days with an explosion of mobile registrations starting on 04/03 (which I remember Maryana told us about) followed by a week of missing data (because of an issue with the log) [18:14:35] do you remember around what date the change was made in mobile that reverted account registrations to the pre 04/03 daily rates? [18:15:07] New patchset: Kipcool; "Replaced deprecated wfMsg* with wfMessage also changed DM edit button from div to span" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65825 [18:15:18] context: I am working on some estimates to compare registrations according to the logging table and GettingStarted logs [18:16:02] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65825 [18:17:19] awjr: the date should be between 04/08 and 04/16 [18:23:27] DarTar: lemme poke around the logs [18:23:39] cool thx [18:25:15] New review: Anomie; "I'll add selectors with .mw-icon-* names to use directly, and rename as Krinkle suggested." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [18:25:25] New patchset: Anomie; "ResourceLoader: Move arrow icons to a separate module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [18:30:11] DarTar: it was 9 April [18:30:29] DarTar: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-04-09 [18:30:38] "Disable upload CTA when $wgMFEnablePhotoUploadCTA is false" [18:30:45] i am pretty certain that was the change [18:31:06] yes, excellent [18:31:31] DarTar: im just double checking if we made the config change that day too; im fairly sure we did [18:33:04] DarTar: yeah, that should be the correct day (though in UTC it might've actually be 4/10) [18:33:20] great, thanks a lot [18:33:33] np :) [18:52:10] New review: Bsitu; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/60008 [19:00:11] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [19:03:30] New review: Matthias Mullie; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/60008 [19:08:01] New patchset: EBernhardson; "Link to any heading not just a main heading" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64363 [19:23:52] New review: CSteipp; "Looks good for security. I'm looking forward to seeing this merged. I think it adequately addresses ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21986 [19:39:06] whym_away ping? [19:42:13] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: -1; - https://gerrit.wikimedia.org/r/65337 [19:43:52] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65337 [19:47:47] New review: Ori.livneh; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171 [19:49:06] AzaToth: fyi, https://github.com/azatoth/twinkle/pull/158 (had to submit a new one as I failed rather hard with the last one) [19:52:59] hoo: fyi, you can update pull requests (they are like gerrit changes) [19:53:23] unless you really phailed updateing it ツ [19:54:16] hoo: you don't need patroltoken? [19:54:29] oh, there it was [20:01:02] New review: Ori.livneh; "Two comments in-line. Neither is explicitly related to the removal of cookie-driven functionality, b..." [mediawiki/extensions/GuidedTour/guiders] (master) C: -1; - https://gerrit.wikimedia.org/r/65004 [20:03:41] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65844 [20:04:34] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65844 [20:05:14] hoo: done [20:06:02] AzaToth: Fine... would be nice to have in the WP tomorrow (but I don't really dare to push it) [20:06:32] I don't want to many people shout at me because I broken their favorite user script [20:06:46] New review: Ori.livneh; "I'd recommend adding a few more core committers as reviewers. My uninformed hunch is that checking w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [20:07:04] (The WP wont updated tomorrow, but many non-Wikipedias pull from it) [20:26:23] hoo: we will blame you anyway :-P [20:28:36] hoo: the new code should work now right? [20:29:56] hmm [20:31:20] well, I'll push it now [20:31:30] are some more changes that hasn't been pushed in a month [20:33:10] AzaToth: My code should work, yes [20:33:28] I've tested it and it sent the right API request [20:34:36] good [20:36:47] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65846 [20:37:03] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65846 [20:37:18] hoo: http://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle#Updates [20:37:19] :-P [20:37:37] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #79: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/79/ [20:37:46] Krinkle TrevorParscal : https://gerrit.wikimedia.org/r/#/c/63584/ really keen to get this merged it's blocking work on our end :( [20:38:07] hoo: "git shortlog 5a70cd5.. --no-merges" is a godsend ツ [20:38:28] dunno if there is a better way to accomplish it [20:38:37] AzaToth: Sounds good... I hope popups wont break to hard, so that there wont be much complaints tomorrow [20:39:07] I used popups like back in the dark ages, before I made tw... [20:39:21] dunno how well maintained it is nowadays [20:40:05] It hardly is... people patch it every once a while, but it's ugly... and I've never used it, so I don't know how it works. [20:40:26] I don't remember how it worked either [20:40:41] i remember there was a popup that ate all my CPU [20:40:47] And I don't want to get into it just to fix patrolling stuff... if someone cares, he can fix it [20:40:51] New patchset: MarkAHershberger; "bump ver to 1.21.1" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65847 [20:41:08] (I once hacked IPv6 support into that, but I didn't test it myself, you dry coded it) [20:41:28] * just dry [20:41:44] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65847 [20:41:44] you ry "dry" :-P [20:42:56] sadly with twinkle, a lot of the morebits code is based on reality before jquery was available [20:44:04] should give it some love [20:44:16] hoo: regarding nothing, [20:45:19] hoo: is there something simmilar to http://benalman.com/projects/jquery-throttle-debounce-plugin/ directly available in wp? [20:45:27] There's a lot of code out there which could need more love, I guess... we could have replaced that whole function with $( '.patrollinks a' ).trigger( 'click' ); as well :P [20:45:31] debounce specially [20:45:38] But that one is showing the user a notification [20:47:11] AzaToth: I don't think so... you'll have to pack it at your own [20:47:24] shouldn't mixin non-api calls with api calls [20:48:15] yes... and you ogt a lot of duplicate code... eg the IP detection stuff is already in mediawiki.util [20:48:39] yea, when I wrote that, there was no mediawiki.util [20:49:00] it's called morebits because it contains stuff that wasn't in wikibits [20:49:24] It took me some time to rewrite my user scripts as well... it's a single big mess :P [20:49:29] MW devs haven't sent any notices to us regarding updates ツ [20:50:06] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #40: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/40/ [20:55:32] * AzaToth wonder why it says "FAILURE in 12 min"... [20:56:43] AzaToth: maybe how long the tests took to run [20:56:49] poorly worded though [20:57:13] Yeah that's what it means [20:57:43] should be after then ツ [20:57:57] failure in 3... 2.... 1.... NOW! [20:58:03] lol [21:05:33] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65849 [21:05:36] New patchset: Aaron Schulz; "Allow setting the ID of the main table in HTMLForm" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61347 [21:05:55] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65849 [21:09:51] New patchset: J; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [21:15:32] New patchset: J; "Allow registered users to reset transcodes" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57286 [21:17:25] New patchset: MarkAHershberger; "update release notes" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65850 [21:19:14] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65850 [21:19:44] New patchset: Mattflaschen; "Only tag users without the autoconfirmed right." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65337 [21:20:01] Aaron|home: re bug 43331, is that TMH? trying to figure out what causes the lock [21:20:32] not TMH really [21:20:36] sorry, had to vacum my comp [21:21:06] RoanKattouw: I've tested and reviewed https://gerrit.wikimedia.org/r/#/c/63584/ about to merge but would like a quick scan from you as well. [21:21:06] downloading the video and rebuilding the metadata is too slow (it also happens to be wrappen in $file->lock() calls to avoid races) [21:21:20] RoanKattouw: jdlrobson is blocked by this [21:21:45] this should not happen on purge for large files [21:21:45] can I assume the mobile devs refuses to hang out in such a generic channel like this? [21:22:39] Krinkle: RoanKattouw thanks dudes :) [21:22:44] it could be fixed totally in core by checking the file size perhaps [21:22:50] Aaron|home: might be still good to have some way to update metadata parsing, but might not be needed for each purge, only if parser gets updated [21:23:04] it could use the job queue [21:23:08] New review: Krinkle; "Thx" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65645 [21:23:32] might also be possible to pass url to metadata parsing and do range requests instead of downloading the full file [21:23:45] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61347 [21:23:52] (not sure the current implementation would support that) [21:25:16] updating via job queue seams like a good way to address it in a generic way, supporting metadata parsing via url might need more changes for other media types [21:26:27] range requests might be tricky for svg/djvu files :) [21:26:29] jdlrobson, Krinkle: Merged [21:26:58] \o/ [21:27:13] Change merged: Aaron Schulz; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57286 [21:28:12] jdlrobson: replied [21:28:14] Aaron|home: had a look at current File_Ogg implementation and it would need quite some work to work with urls so job queue might be best. [21:28:31] right [21:28:41] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65645 [21:29:41] GabrielF: using server password removes the join-rejoin spam [21:30:08] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [21:30:11] puny comcaster! [21:30:20] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65337 [21:30:23] ok sorry [21:30:37] GabrielF: ツ [21:40:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65167 [21:41:40] New review: CSteipp; "I'd prefer to limit the calling domains to those in $wgCrossSiteAJAXdomains, but I'm not sure if tha..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [21:44:49] New patchset: Mattflaschen; "Remove all cookie-related functionality, including endTour." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65004 [21:45:47] New review: Mattflaschen; "I changed both of the inline items as suggested." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65004 [21:46:37] New review: Catrope; "There's a bunch of preference-based CSS, so you could read out the user's preferences at least, if y..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [21:49:46] New review: Hoo man; "AFAIK preference specific CSS is served inline, so this shouldn't be an issue." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [21:53:32] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65158 [21:56:48] New review: Catrope; "Yes, I stand corrected. Timo told me we don't allow private JS/CSS to be served from a URL at all an..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60200 [22:01:08] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [22:02:30] Aaron|home: I can't clear my throat in that typical manner right now as I'm still in Germany (and you probably not in the office), but imagine me turning over to you and asking you for.. a review [22:02:57] of the Parsoid php extension at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Parsoid.git;a=tree;f=php to be precise [22:03:36] * Aaron|home looks [22:04:31] Oh my eff, we're putting Parsoid in a sane place in the repo tree? [22:05:19] Aaron|home: it has only seen light local testing so far, but we would soon like to use it to start tracking at least some edit updates [22:07:22] James_F: https://en.wikipedia.org/w/index.php?title=Firefox&oldid=556731669&veaction=edit [22:12:09] Aaron|home: I will probably fade out at some point since it is already past midnight here [22:12:21] ok [22:12:44] would you prefer to do this on Gerrit? [22:12:53] could try to concoct some fake patch for that purpose [22:13:06] otherwise mail could be an option [22:15:37] I have a few small cleanups in mind thus far, I guess they will just be gerrit [22:16:00] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65337 [22:18:28] Aaron|home: I'm heading to bed soonish, can you send me a mail with your comments? Can then address them tomorrow on the train. [22:18:44] Aaron|home: and thanks for reviewing! [22:18:49] I assume tagging you in gerrit would sent an email [22:19:17] ah, didn't know that you could review existing merged code outside a patch set too [22:20:35] I mean if I make a patch to tweak things [22:20:52] though things I'm not sure about would be a custom email of course [22:21:25] Aaron|home: ah, ok- that would be great too of course! [22:21:31] though I suppose one could make a patch with @TODO/@FIXME comments in theory [22:22:03] if you prefer I can also do the work though [22:22:45] New patchset: Ori.livneh; "Consolidate event-handling tooling in 'eventlogger'" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65852 [22:34:06] New patchset: Cmcmahon; "add a check that the Cancel button works correctly" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65853 [22:43:56] Yippie, build fixed! [22:43:57] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #80: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/80/ [22:46:13] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [22:55:08] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [23:11:47] New patchset: Catrope; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [23:12:07] AzaToth: Thanks, looking into it now. [23:19:50] New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [23:19:51] New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [23:19:51] New patchset: Krinkle; "wikibits: Wrap UA and accesskey globals in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [23:19:51] New patchset: Krinkle; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [23:23:26] James_F: http://me.veekun.com/blog/2011/10/17/github-and-irc/ [23:34:38] Change merged: Ori.livneh; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65004 [23:38:45] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #81: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/81/ [23:38:57] Susan: ツ [23:40:58] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #64: FAILURE in 15 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/64/ [23:42:32] New patchset: Bsitu; "(bug 47912) Visiting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349