[00:03:42] New review: PleaseStand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65641 [00:28:42] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #50: FAILURE in 5 min 46 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/50/ [00:37:52] New review: Hiong3-eng5; "Hi, I think submit it first. I will make corrections to a new commit for review later this week if ..." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65166 [00:39:57] New review: Hiong3-eng5; "Sorry. I mean, yes, "merge" it first, I will make "improvements" later this week if I have time." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65166 [02:07:25] New review: Demon; "We should not default to WikiSysop, it should be a required parameter. This was a conscious design d..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65613 [02:13:40] New review: Spage; "(1 comment)" [mediawiki/extensions/PostEdit] (master) C: 2; - https://gerrit.wikimedia.org/r/62952 [02:13:53] Change merged: jenkins-bot; [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [03:04:35] New review: Daniel Friesen; "It is based purely on Skin::showIPinHeader. However Skin::showIPinHeader is `$wgShowIPinHeader && se..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65440 [04:54:24] New patchset: Liangent; "Never prefix table names with $wgSharedDB when used in foreign DB" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65489 [05:08:50] New patchset: Amire80; "Remove webfonts enabling checkbox and associated preference" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64976 [05:37:30] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [05:44:52] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [05:45:42] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [05:46:42] New patchset: Mwjames; "(Bug 44696) AskApi to support valid XML using the SMW\ApiQueryResultFormatter" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65646 [05:57:14] New review: Mwjames; "[1] replaces this change using the SMW\ApiQueryResultFormatter class." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64447 [05:57:48] New patchset: Santhosh; "Update linktrails for Hindi and Odia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [05:59:57] New patchset: Santhosh; "Update linktrails for Hindi and Odia" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65653 [06:00:08] New patchset: Pastakhov; "fix variable scope (version 0.3.1)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65654 [06:01:41] New review: Wikinaut; "Hi Chris, " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [06:02:00] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65654 [06:08:08] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65320 [06:12:04] New review: Daniel Friesen; "@Luis Felipe Schenone, by breakage from this and other changes I mean:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [06:30:32] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64976 [06:46:05] New patchset: Rfaulk; "rm. unneccessary test classes." [sartoris] (master) - https://gerrit.wikimedia.org/r/65655 [06:46:34] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65655 [07:27:58] Change merged: Jarry1250; [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65458 [07:42:35] New patchset: Amire80; "Clarify the README file about the version" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65656 [07:44:55] New review: Ronengi; "ok, thanks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65581 [08:15:32] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65166 [08:15:54] New patchset: Amire80; "Don't show anonymous users tipsy with setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [08:29:13] Change abandoned: Aude; "instead go with the approach described in https://bugzilla.wikimedia.org/17237" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [08:39:29] any lua folks here? [08:43:13] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [08:50:06] YuviPanda: what do you need ? [08:50:56] thedj[wo1k]: is there a way for me to check if a template exists in a given page, from lua? [08:51:21] (I am writing code for tawiki's main page transclusion, and they want to skip transclusion if the target page contains the {{underconstruction}} template [08:51:22] you mean like it is being transcluded on that page ? [08:51:28] yeah [08:52:13] k, no. you only know what is transcluded after parsing the page, of which Module execution is a subpart. [08:52:42] so it's not there, because likely it's almost impossible to reliably get that information for a page. [08:53:01] New review: Nikerabbit; "Krinkle: in practice this seems to only happen when mouse cursor is already over an element when the..." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65594 [08:54:37] thedj[wo1k]: yeah, so I'll probably have to detect it by doing string checks of the result of frame:expandTemplate for some classname or something? [08:56:50] YuviPanda: yeah, or you could get the entire contents I guess and just do str detection of direct inclusions [08:56:56] wikitext contents [08:57:13] oh, so expand {{underconstruction}} and the target page and do a full substring match? [09:02:50] New patchset: PleaseStand; "Remove $wgEnableAPI, $wgEnableWriteAPI, etc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63259 [09:04:33] New patchset: PleaseStand; "Remove $wgEnableAPI, $wgEnableWriteAPI, etc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63259 [09:04:39] New review: Luis Felipe Schenone; "Makes sense. I'd like to chat with you about your plans to improve the skinning system, see if I can..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [09:05:03] New patchset: PleaseStand; "Remove $wgEnableAPI, $wgEnableWriteAPI, etc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63259 [09:09:26] New review: Nikerabbit; "Please explain (in release notes at least) how private wikis (log in to use) can reliably disable wh..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63259 [09:11:52] New review: Nemo bis; "Not only private wikis but any wiki that doesn't bother breaking some functionality. As much as I ha..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63259 [09:14:21] New patchset: Santhosh; "Remove document from anon cover function" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65657 [09:14:22] New patchset: Santhosh; "Get the saved font using the fontSelector defined in mw.webfonts.setup" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65658 [09:54:11] New patchset: Amire80; "Access i18n json files from same domain for IE8 and IE9" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64918 [09:55:15] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64918 [09:59:04] @seenrx anomie [09:59:11] @seen-on [09:59:11] Seen is now enabled in the channel [09:59:12] @seenrx anomie [09:59:12] petan: Last time I saw anomie they were quitting the network with reason: Quit: Leaving at 5/26/2013 11:50:12 AM (22:09:00.4929660 ago) (multiple results were found: anomie_, anomie|work, anomie|brb, anomie|lunch, anomie|dinner and 1 more results) [10:39:11] New patchset: Amire80; "Show input methods for selected language correctly" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65666 [10:39:20] New patchset: Pastakhov; "add static variables (version 0.3.2)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65667 [10:40:17] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/65667 [11:02:35] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65657 [11:04:09] New review: Tobias Gritschacher; "(1 comment)" [mediawiki/extensions/Ask] (master) C: -1; - https://gerrit.wikimedia.org/r/65293 [11:05:46] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65658 [11:05:59] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65296 [11:07:17] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65297 [11:12:07] New patchset: Amire80; "Allow ULS language settings accessed from user preference screen." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [11:14:20] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65652 [12:29:06] New patchset: Jeroen De Dauw; "Added tests for PropertyValueSortExpression" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65293 [12:30:43] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65293 [12:36:04] New patchset: Amire80; "Refactor interface integration code" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [12:36:47] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [12:54:28] New patchset: Santhosh; "Fix cancel behaviour of display settings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65670 [13:09:48] New patchset: Amire80; "Don't show anonymous users tipsy with setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [13:27:40] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65670 [13:33:59] New patchset: Amire80; "Allow ULS language settings accessed from user preference screen." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [14:14:37] New patchset: IAlex; "Moved job queue aggregator classes to a subdirectory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64973 [14:18:44] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64973 [14:25:30] wq [14:54:46] New patchset: IAlex; "Fieldset legends is broken." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [14:54:51] New patchset: Addshore; "localise buttons for ky" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/65675 [14:58:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [14:59:38] New review: Demon; "The more I think about it, the more I disagree with this change and think it should be abandoned." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/63259 [15:15:47] New patchset: Henning Snater; "ResourceLoader: Prevent prefixless modules from overwriting other modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65678 [15:31:06] Change merged: jenkins-bot; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65293 [15:38:28] New patchset: Nischayn22; "Move fixedProperties to Settings" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [15:50:35] New review: Mwjames; "Can we please have a test for this!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [17:09:56] New patchset: Reedy; "Update wikidata related extensions to mw1.22-wmf5 branches" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65682 [17:10:06] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65682 [17:56:44] New patchset: Reedy; "Update wikidata branchpoints to 1.22wmf5 for next time" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65684 [17:59:50] Change merged: Reedy; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/65684 [18:12:12] New review: Nischayn22; "I really have no idea how to write tests for this. Do we have tests for table creation processes and..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [18:44:57] New review: Mwjames; "Well this the first sign that something is wrong with the class and its methods. The CRAP index for ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65681 [18:57:06] gerrit is very slow [18:57:38] not fun when loading my dashboard takes 15+ seconds [18:57:50] merge more! [18:59:01] O_O 940 open unrevied commits [19:00:11] Nemo_bis: For all projects? [19:00:17] no, only MediaWiki [19:00:24] gnah [19:00:31] actually it's all open, something wrong in query it seems [19:08:54] New patchset: Kipcool; "replaced deprecated wfMsg* with wfMessage also changed DM edit button from div to span" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65686 [19:09:44] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65686 [19:30:57] New patchset: Kipcool; "Revert "replaced deprecated wfMsg* with wfMessage also changed DM edit button from div to span"" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65687 [19:32:05] New review: Kipcool; "will fix later. revert for the moment." [mediawiki/extensions/WikiLexicalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65687 [19:32:06] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65687 [20:10:23] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #79: FAILURE in 8 min 57 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/79/ [20:11:16] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65136 [20:13:42] New review: Mormegil; "I wonder whether this change isn't the reason why I have the "system" font (i.e. an ugly bitmap font..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65658 [20:20:34] Change abandoned: PleaseStand; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63259 [20:26:23] New patchset: Reedy; "Revert ULS back to 1.22wmf4 version" [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65688 [20:27:43] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf5) - https://gerrit.wikimedia.org/r/65688 [20:30:36] update your queries https://www.mediawiki.org/w/index.php?title=Gerrit%2FNavigation&diff=696066&oldid=666775 [20:32:54] New review: Matmarex; "Mormegil: https://bugzilla.wikimedia.org/show_bug.cgi?id=48871" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65658 [20:37:06] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #61: FAILURE in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/61/ [20:37:34] hmm, can't that ULS thing use 2 step loading ? [20:38:44] Hello, does anyone know why specific special pages are excluded from Special:SpecialPages? [20:39:43] about 30kb of ULS code on every page view... [20:40:20] HSJ: 'specific' isn' a very specific description :D [20:40:36] thedj: if you think it is an issue and have ideas, please file a bug [20:41:12] Nikerabbit: perhaps i will... [20:41:46] we shouldn't just dump all JS we need into every page. it does count up at some point, even with caching. especially on commons and en.wp [20:42:19] thedj: Well ... I was just looking to see if I could do something about https://bugzilla.wikimedia.org/show_bug.cgi?id=45221 and found https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/SpecialPageFactory.php;h=4d635536a75f42074314abbb51a9b49634d255d8;hb=refs/heads/master#l155 [20:42:35] thedj: Commons and enwp... have you been on Wikidata.org recently [20:42:49] * hoo hides... we got a bit of JS... Firebug doesn't like that [20:43:13] no i haven't been there too much to be honest [20:43:57] :P We got like a lot of JS... even the client things I wrote are pretty heavy (lazy-loaded though) [20:44:18] uls seems to have 0 lazy loading [20:44:31] New patchset: Mattflaschen; "Add autocreate to addNewUserLogEntry docs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65690 [20:44:55] it does, for the displayed list of languages which is horrible slow atm [20:45:32] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #76: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/76/ [20:45:54] you need lazy loading + pre caching then :D [20:46:51] Nikerabbit: that's not lazy loading, that's lazy coding :P [20:47:02] (yeah, i've been meaning to dig into that code...) [20:47:16] HSJ: is there any of those spcial pages that you'd link? [20:47:38] they're mostly shortcuts linked from other places in the interface that wouldn't make sense alone, in theory [20:47:52] New patchset: Jeroen De Dauw; "Deprecate Site::newForType since it is so bad" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65691 [20:47:55] HSJ: the page needs to be in a group. though i'm not sure anymore where those groups are defined :D [20:48:09] Yippie, build fixed! [20:48:09] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #38: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/38/ [20:49:52] MatmaRex: yeah [20:50:17] Nemo_bis, thedj: So close as WONTFIX? [20:50:35] HSJ: is there a bug open? [20:50:47] I linked it above [20:50:56] ah [20:51:55] let me steal your findings [20:52:11] in my opinion, SpecialPages, isn't a documentation feature [20:53:03] also, it doesn't have interface http://www.mediawiki.org/wiki/Special:PermanentLink [20:53:27] so it's pointless to create links to when there is no context that it refers to. [20:53:45] before adding it, you would have to at least add interface to it first. [20:53:54] but i'd be good with wontfix [20:54:59] New review: Hoo man; "Looks fine. Documentation only change." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65690 [20:55:00] Change merged: Hoo man; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65690 [20:56:50] yep, there's no real way to do it [20:56:56] Nemo_bis: OK :) and now ... [20:57:02] * HSJ goes to write a bot :P [20:59:52] HSJ: btw. in order to add to the list, a specialpage needs to implement getGroupName() function returning the name of a section [21:00:00] just for future reference [21:01:01] OK [21:12:31] New patchset: Amire80; "Scroll secondary ULS into view" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65693 [21:34:42] New review: PleaseStand; "Per previous comments. I would -2 if I could because of the" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65641 [21:36:09] Yippie, build fixed! [21:36:09] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #51: FIXED in 5 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/51/ [21:39:54] New review: Alex Monk; "After hearing about some of the stuff that still uses sajax, we should probably wait a bit longer an..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/65641 [21:41:56] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #40: FAILURE in 5 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/40/ [22:02:21] New patchset: Jeroen De Dauw; "Added covers tags for DescriptionCollection covering tests" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65700 [22:12:34] New patchset: Jeroen De Dauw; "Added tests for DescriptionCollection::equals" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65701 [22:14:06] New patchset: Jeroen De Dauw; "Simplified FQNs and imported classes" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65702 [22:14:52] New review: Matmarex; "While this is slightly bikeshedding, I'd use a different set of class names:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65414 [22:19:44] New review: Matmarex; "Per our brief chat in AMS I'm going to rebase stuff around to replace this change with https://gerri..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65579 [22:31:31] anyone use wikihadoop? [22:44:46] New patchset: Hoo man; "Fix AbuseFilter::disableConditionLimit()" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65704 [22:49:00] New review: Hoo man; "I'm not entirely sure we even want this function... instead of an exception I know get "PHP Fatal er..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65704 [22:51:55] New patchset: Bsitu; "(bug 47912) Visting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [23:07:27] New patchset: Bsitu; "(bug 47912) Visting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [23:09:55] Yippie, build fixed! [23:09:56] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #80: FIXED in 8 min 45 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/80/ [23:15:32] popups.js will slightly blow up with the next deploy... and twinkle will slightly break as well :/ [23:17:38] oh? [23:17:48] how? [23:18:17] legoktm: These two gadgets rely on rcid URL parameters [23:18:31] but they're going to be removed with the next deploy [23:18:43] ah right. the whole patrolling overhaul [23:18:49] Jep [23:20:20] Made myself a note... maybe I can fix it by the time that change's coming to enwiki [23:20:39] Not critical, though [23:21:51] well we should at least let the twinkle devs know…. [23:22:15] do you know the specific bug/changeset that breaks it? [23:22:21] Probably... and maybe the Huggle ones [23:22:38] yeah [23:22:38] Sure, it's mine https://gerrit.wikimedia.org/r/41196 [23:25:04] filed https://github.com/azatoth/twinkle/issues/156 [23:25:31] hm no addshore [23:26:21] ill leave a note in #huggle [23:27:29] idk who maintains popups.... [23:27:39] legoktm: the rcid will not be needed anymore at all? [23:28:11] legoktm: Lupin? [23:28:11] AzaToth: oh hey! im not sure, hoo knows though [23:28:13] AzaToth: They're going to die, yes (from the user interface) [23:28:22] Staying in the API of course [23:28:26] Hazard-Away: lupin has been inactive for a loooong time. [23:28:56] :/ [23:30:19] what rcid thing? :D [23:30:37] hoo: so to be able to know if we can patrol the page we need to query the api first? [23:31:04] AzaToth: Well, if you're already on the page you can look for the link [23:31:11] if not you should do that, yes [23:31:26] (You can probably read an css class even then, but that's ugly) [23:31:54] but the patroltoken in the patrollink will still be there right? [23:32:10] AzaToth: Sure, the patrollink itself is unaltered [23:32:28] (although that one is in practice almost never used as we have an ajax module for that) [23:32:33] and I will still need patroltoken and rcid for markpatrolled? [23:32:51] there is an ajax module for that now? [23:33:00] AzaToth: to mark a page as patrolled you do, yes [23:33:18] AzaToth: Are you here for Twinkle? [23:33:22] Will patch that myself [23:33:43] technically I'm still twinkle :-P [23:33:57] noticed legoktm highlighting me [23:34:02] :P [23:34:43] * Jasper_Deng knows AzaToth mainly because of his/her contribs to Twinkle [23:35:19] hoo: where is this ajax module you are talking about [23:36:12] Yippie, build fixed! [23:36:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #62: FIXED in 14 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/62/ [23:36:32] I don't see anything on http://www.mediawiki.org/wiki/ResourceLoader/Default_modules [23:36:56] AzaToth: hang on [23:37:31] AzaToth: In MediaWiki core resources/mediawiki.page/mediawiki.page.patrol.ajax.js [23:38:12] AzaToth: Do you care about your own code style conventions a lot or can I use MW style? [23:39:20] hoo: we tried to have some kind of code convention, following jquery convetion [23:40:35] Those are very similar to the MW ones [23:40:46] possibly [23:44:11] I see that resources/mediawiki.page/mediawiki.page.patrol.ajax.js uses mw.util.getParamValue( 'rcid', href ); [23:44:25] legoktm: perhaps the change should fix that directly [23:49:48] hoo: dunno why twinkle is using markpatrolled [23:52:15] AzaToth: Probably because the tokens differ AFAIR