[00:10:00] New review: Daniel Friesen; "Setup.php would be a better location. Though it should be a little fancier than just a straight set ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [00:14:33] New patchset: Reedy; "Update to 23.1" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/65351 [00:15:54] New patchset: Reedy; "Update to 23.1" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/65351 [00:18:27] New review: Mattflaschen; "It seems you're working under the assumption that core skins should be like an extension, but I'm no..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [00:23:02] New review: Kaldari; "(1 comment)" [mediawiki/core] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/61939 [00:24:27] New patchset: Kaldari; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [00:49:14] New patchset: Mattflaschen; "Add tour to be used for first edit (other than GettingStarted)." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [00:50:46] New review: Mattflaschen; "Updated and rebased. This depends on some other changes pending review, though (which is also why J..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [01:28:15] New patchset: Mwjames; "Improve smw constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65352 [02:12:28] New patchset: Mwjames; "Improve smw constructor" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65352 [02:24:08] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65352 [02:53:30] New patchset: Mwjames; "Clean-up smw.util.tooltip constructor, improve jsduck, and add test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65353 [02:56:43] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65353 [02:56:49] Why does NOONE add useful optional params when they register a mime type. [02:57:22] Compression types don't say what they contain. [03:00:05] all the world's an octet-stream [03:00:40] video container don't say what encodings they use or what video resolution is used. [03:01:49] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [03:01:53] video/ogg; codecs="theora, vorbis"? [03:03:21] New review: Brian Wolff; "PS7: minor whitespace changes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [03:42:13] New patchset: Brian Wolff; "Allow listing old files in Special:ListFiles. Add Special:AllMyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [03:42:14] New patchset: Brian Wolff; "Do not allow sorting Special:Listfiles by img_name when filtering by username" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59974 [03:47:10] New review: Brian Wolff; "PS8: rebase, which i hopefully did right..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60088 [03:52:04] New patchset: Brian Wolff; "Add Special:[All]MyFiles as alias for Special:[All]MyUploads" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60089 [03:52:37] New patchset: PleaseStand; "Remove 'SkinTemplateTabs' from docs/hooks.txt" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65354 [04:11:45] *sigh* Flexbox adoption needs to pick up pace. [04:12:18] Fleshbot * [04:31:12] New patchset: Nischayn22; "Remove data on blanking category input." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65355 [05:38:22] New patchset: Nischayn22; "Pluginified so can be used by other extensions." [mediawiki/extensions/MsUpload] (master) - https://gerrit.wikimedia.org/r/65356 [05:43:35] New patchset: Nischayn22; "Pluginified so can be used by other extensions." [mediawiki/extensions/MsUpload] (master) - https://gerrit.wikimedia.org/r/65356 [07:57:24] New review: Anomie; "Seems sensible." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/65275 [07:58:49] New patchset: Siebrand; "Split date and time in running sentence" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65357 [07:59:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65275 [08:06:45] New review: Luis Felipe Schenone; "Moving the requires to Setup.php seems fine to me, and I could do a file_exists() check before requi..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [08:07:48] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65338 [08:09:31] Change merged: jenkins-bot; [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/65351 [08:16:04] New review: Zielmicha; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [08:21:00] New patchset: Siebrand; "Fix spelling of JavaScript" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65359 [08:21:34] New review: Parent5446; "@Hashar - the same difference between the Html and Xml classes in general: the former does HTML5 pro..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52645 [08:21:54] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65355 [08:24:44] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65357 [08:25:32] New patchset: Darkdadaah; "New file to "leave a trace"" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65370 [08:25:33] New patchset: Darkdadaah; "Punctuation" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65371 [08:27:36] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [08:27:42] New review: Parent5446; "If it is put into Setup.php, it would be significantly better. If I may ask, though, what problems e..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [08:27:57] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65359 [08:31:04] New review: Parent5446; "What's the difference between this and https://gerrit.wikimedia.org/r/56058" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [08:31:04] New review: Nikerabbit; "This hook is referenced in extensions SemanticForms, SemanticMediaWiki, Translate, LiquidThreads and..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65354 [08:33:17] New patchset: Parent5446; "Add associated namespace option to Special:NewPages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [08:33:30] New patchset: Deskana; "Added a test comment." [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65397 [08:33:38] New patchset: JackPotte; "TEST 1" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65398 [08:36:09] New review: Parent5446; "Minor code style stuff, but otherwise good." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/52676 [08:37:14] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [08:37:57] New review: Sumanah; "Yay! Hackathon in Amsterdam1" [test/mediawiki/extensions/examples] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65370 [08:37:57] Change merged: Sumanah; [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65370 [08:38:25] New patchset: Nikerabbit; "SkinTemplateTabs was remove in 1.18" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65399 [08:39:59] New patchset: Pginer; "SVG version for collapsible indicator in Vector" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400 [08:40:32] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65354 [08:41:16] Yippie, build fixed! [08:41:16] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #312: FIXED in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/312/ [08:42:35] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [08:43:49] New patchset: Nikerabbit; "Fix some incorrect hook annotations" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65401 [08:44:50] New patchset: CristianCantoro; "Increased version number. Test from wmhack 2013 in Amsterdam" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65402 [08:49:21] Change merged: Darkdadaah; [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65398 [08:50:32] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [08:54:54] New patchset: Nikerabbit; "SkinTemplateTabs was removed in 1.18" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65399 [08:58:10] New review: Anomie; "(1 comment)" [test/mediawiki/extensions/examples] (master) C: -1; - https://gerrit.wikimedia.org/r/65371 [09:02:32] New patchset: Mwjames; "(Bug 48586) ApiAsk add error output" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64447 [09:03:17] New review: Waldir; "@Parent5446, @Mattflaschen: I believe the ultimate goal is actually aligned with Daniel's plans: to ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [09:04:04] New patchset: Ruud Koot; "RecentChange: deprecate newFromCurRow and loadFromCurRow" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65295 [09:04:57] New review: Anomie; "Seems sane. Also, discussed it at the Hackathon just now." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/65331 [09:05:13] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65331 [09:06:50] New review: Krinkle; "Core and extensions can use the same classes. Like you asked me yesterday, SkinMonobook and SkinVect..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [09:07:53] New patchset: Mwjames; "(Bug 48586) ApiAsk add error output" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64447 [09:08:08] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [09:08:17] Ryan_Lane: ^ [09:08:45] New patchset: Mwjames; "(Bug 48586) ApiAsk add error output" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64447 [09:10:32] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [09:14:36] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [09:31:05] brion: i brough the Oculus today [09:31:11] awwwwesome [09:31:41] I also brought beer. But apparently we can't drink it in here :( [09:33:31] Yippie, build fixed! [09:33:32] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #54: FIXED in 7 min 25 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/54/ [09:33:51] New patchset: Krinkle; "Enable mwext-VisualEditor-whitespaces" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65407 [09:34:14] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65407 [09:43:14] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64570 [09:46:45] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #47: FAILURE in 4 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/47/ [09:55:55] New patchset: Krinkle; "Revert "Enable mwext-VisualEditor-whitespaces"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65410 [09:56:08] New patchset: Krinkle; "Revert "Enable mwext-VisualEditor-whitespaces"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65411 [09:56:15] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65411 [09:56:38] Change abandoned: Krinkle; "See I8c95150a6889738." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65410 [09:57:11] anomie: What are you using addModuleStyles for? You should probably avoid that and use a regular module add with position=top. [09:57:17] Because addModuleStyles uses a hardcoded link. [09:57:23] Which means no timestamp caching [09:57:31] Krinkle: I'm not. The existing code for mediawiki.special.changeslist does. [09:57:40] Or should I just change that? [09:57:46] and you can't do dependency resolution without hardcoding the dependency map in html output,which is bad due to startup being 5 minutes and the html being 30 days [09:57:56] anomie: Yes, I suppose so. [09:58:16] We weren't just lazy. Roan and I remembered a second after you left. [10:04:49] New patchset: Tim Starling; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [10:05:07] Krinkle: Oh, what was the second? Also, git blame revealed that it was me that (mis)used addModuleStyles. D'oh. [10:05:26] anomie: second? [10:05:34] "We weren't just lazy. Roan and I remembered a second after you left." [10:05:41] New review: Tim Starling; "PS22: !$revision instead of !$revision instanceof Revision" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/41196 [10:06:06] anomie: we remembered a [[second (time)]] after you left ... that we weren't just lazy but there is a good reason not to use it that way with dependenies [10:06:13] Oh, ok. [10:08:01] Yippie, build fixed! [10:08:08] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #31: FIXED in 6 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/31/ [10:08:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [10:11:52] New patchset: Anomie; "ResourceLoader: Move arrow icons to a separate module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:12:50] New patchset: Parent5446; "Automatically move category members when redirected" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65176 [10:13:57] New patchset: Nikerabbit; "Avoid suggesting current translation from translation memory" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65415 [10:16:43] New review: Matmarex; "I1e24733c was merged which claims to fix this." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/30358 [10:18:28] Nikerabbit: Was there a specific reason for the -1 (gerrit 21986)? [10:18:39] Because he felt like it? [10:18:49] :) [10:19:22] parent5446: forgot to mention, same as in ps1 (too many changes in one go, which will likely result revert if merged) [10:19:51] OK, I'll split it up. [10:20:44] Change abandoned: Hoo man; "No longer needed after https://gerrit.wikimedia.org/r/41196" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/30358 [10:22:05] New patchset: Pginer; "(bug 35340) Use SVG for Vector collapsible section arrow" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/65416 [10:24:43] New review: Matmarex; "This followsup https://gerrit.wikimedia.org/r/#/c/54136/, I guess. And would make https://gerrit.wik..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:26:23] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:27:52] New patchset: Parent5446; "Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [10:28:38] New patchset: Hoo man; "Add Release notes for I1e24733c" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65417 [10:29:04] New review: Matmarex; "See also https://gerrit.wikimedia.org/r/#/c/65414/1 - this should probably also be done for that patch." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65400 [10:29:12] Yippie, build fixed! [10:29:12] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #7: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/7/ [10:29:27] New review: Matmarex; "Also see https://gerrit.wikimedia.org/r/#/c/65400/ for hi-res SVG version of these." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [10:29:43] New patchset: Parent5446; "Add referer check to edit token checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65418 [10:30:21] New patchset: Zfilipin; "Do not run tests in parallel and enable verbose console output" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65419 [10:30:39] Das ist verbosen [10:32:39] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [10:32:52] Nikerabbit: Done. Split it into 3 different changes. [10:33:06] New patchset: Parent5446; "Changed edit token construction to SHA-256" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65420 [10:34:51] New review: Cmcmahon; "docs for Jenkins changes" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65419 [10:34:51] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65419 [10:39:30] parent5446: nice [10:46:19] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [10:47:15] Ryan_Lane: Look, I made you a thing [10:48:44] things are the bestestest [10:59:29] hexmode: thanks; it's a bit confusing however to update the milestones after the release, for the 6 major-to-blocker open bugs https://bugzilla.wikimedia.org/buglist.cgi?list_id=204113&resolution=---&query_format=advanced&target_milestone=1.21.0%20release&product=MediaWiki [11:00:01] if someone wanted to help submitting patches they could never know if someone is already doing it, if a patch would be accepted etc. [11:00:21] Nemo_bis: why not? [11:01:06] hexmode: because you decided it was not a blocker for release but didn't tell anyone :) [11:01:45] hrm... well, AFAICR, no one told me they were working on them [11:02:32] of course, that's what I just said [11:02:48] so, yes, I should make sure I communicate my decisions, but it would be nice if people would give me information that might affect my decision. [11:03:30] Nemo_bis: another thing: MaxSem just reminded me we need to branch all extensions [11:03:50] Need to use the same branch date as REL1_21 had [11:04:22] New patchset: Freakolowsky; "Fixed doPageRestrictionsPKUKFix which had prefix HCed into it" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65424 [11:06:36] hexmode: I don't think you missed any information [11:06:52] New patchset: Reedy; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65425 [11:06:56] ok, I'll just make it a point to communicate more [11:07:08] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65425 [11:07:11] * hexmode turns it up to 11 [11:15:36] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65424 [11:16:41] New patchset: Waldir; "Rename $usableSkins to $allowedSkins" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65426 [11:17:49] New patchset: Parent5446; "Fixed OracleUpdater::doPageRestrictionsPKUKFix prefix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65424 [11:19:26] New patchset: Luis Felipe Schenone; "Making the MonoBook skin more self-contained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [11:21:35] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [11:22:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65426 [11:25:33] New patchset: Orenhe; "Installer: page refresh should refresh list of supported DBs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65427 [11:28:41] New review: Parent5446; "Haven't tested, but code looks good." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65427 [11:32:03] New patchset: TheDJ; "Math: Enable MathJax's Safe mode" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [11:36:11] New patchset: TheDJ; "Math: Enable MathJax's Safe mode" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [11:36:24] New patchset: Cmcmahon; "Replaced and implemented uls_cog_sidebar_logged_user_steps.rb" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65428 [11:36:56] New patchset: TheDJ; "Math: Enable MathJax's Safe mode" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [11:41:20] Reedy: can you create 1.21.x milestone? [11:43:51] New patchset: Luis Felipe Schenone; "Making the MonoBook skin more self-contained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [11:45:02] marktraceur: \o/ [11:45:06] marktraceur, sorry, wasn't looking at the IRC [11:45:16] marktraceur: I'm in the ops room because it's way too hot in the main room [11:45:20] i'm in architecture meeting right now [11:45:22] come by [11:45:25] small room [11:46:44] Ryan_Lane: 's all right, I'm in the bar area for the same reason [11:46:55] yurik_: It's OK, I figured it out [11:47:36] Nemo_bis: Not just 1.21.0 release ? [11:47:47] New patchset: Dan-nl; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [11:48:00] marktraceur, seems that its faster to find me in person than here :) [11:48:02] New patchset: Cmcmahon; "Replaced and implemented uls_cog_sidebar_logged_user_steps.rb Added Background" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65428 [11:49:36] yurik_: Pish tosh, IRC is always better [11:49:40] No logs in real life [11:50:59] Reedy: that exists already [11:51:25] marktraceur: No logs? Wait until Google Glass.... [11:51:25] :P [11:51:48] YuviPanda: Not free, so I'll be waiting way longer sadly [11:52:25] Ryan_Lane: I've put that patchset on wikitech-test but it looks like there's some issue causing approximately infinite load time [11:53:37] marktraceur: it ships unlocked, and I think people have already put Ubuntu on it.... [11:53:50] Nemo_bis: Done [11:53:51] "ok glass, vandalize wikipedia" [11:53:52] is there something people haven't managed to put linux on? [11:54:02] YuviPanda: You're not convincing me [11:54:06] New review: Luis Felipe Schenone; "This patch would only be the first in an effort to improve the skinning system. If approved, I'd lik..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [11:54:11] YuviPanda: emacs [11:54:12] marktraceur: I know :) [11:54:33] brion: "ok glass, re invent the wheel" [11:54:53] "OK, glass, OK Go" [11:54:57] *music starts* [11:55:12] "ok glass, ok chess" [11:55:23] "OK glass, OK Cupid." [11:56:09] "Ok glass, call me an ambulance" [11:56:21] "okay, I will call you 'an ambulance' from now" [11:57:13] * brion wonders how many people will just stream their video feed to youtube live views [11:57:42] New patchset: Psychoslave; "Add a quantum function!" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65431 [11:58:01] brion: imagine the effect on protests [11:58:13] fuck the poliiiiice [11:58:17] I mean, they'll start confiscating all glasses [11:58:18] Ryan_Lane: If you get a chance to look at that patchset, I may or may not have caused the slowdown, but Special:NovaAddress won't load for me now. [11:58:20] and you can't see [11:58:32] marktraceur: won't load for you in production? [11:58:40] or on wikitech-test? [11:58:48] On wikitech-test [11:59:02] * Ryan_Lane tries [11:59:19] Production is fine [11:59:30] I think it's the nova-api [11:59:40] yep [11:59:48] Hrm? [12:00:07] rabbit died [12:00:23] working again [12:00:24] Oh, of course. [12:00:34] * marktraceur totally knows what's happening [12:00:50] :) [12:01:12] openstack talks between its services using a queue [12:01:16] Ah,. [12:01:31] its model is asynchronous by design [12:02:42] OK, cool, but now it looks like there are no IP addresses for any of my projects. [12:02:50] Ryan_Lane: Is there a test project with an IP allocated? [12:03:07] nope. let me up the quota on testing [12:03:10] KK [12:03:31] Actually, on wikitech-test I can't see the testing project [12:03:37] ok. should work now [12:03:39] oh. [12:03:42] what projects can you see? [12:04:14] bastion, etherpad, orgcharts, visualeditor [12:04:20] phabricator [12:04:59] ok [12:05:02] visualeditor [12:05:14] I upped the ip quota to 50 :) [12:06:01] Nice. [12:07:19] Ryan_Lane: It says it can't associate the IP with the instance...maybe because there's an error in the instance? [12:07:29] yep [12:07:34] oh. let me fix that [12:07:39] I think I know what needs to be done [12:07:53] * marktraceur likes that he doesn't have to fix these problems, just find them [12:07:54] yurik: yurik_ We really need to a shared config repo for the phpstorm config [12:07:54] New review: Darkdadaah; "There is an apostrophe in the string that needs to be escaped." [test/mediawiki/extensions/examples] (master) C: -1; - https://gerrit.wikimedia.org/r/65431 [12:08:13] siebrand did start something like that [12:10:15] anomie: [12:10:18] 8 Fatal error: Call to a member function pauseUsageTimer() on a non-object in /usr/local/apache/common-local/php-1.22wmf4/extensions/Scribunto/engines/LuaCommon/LuaCommon.php on line 405 [12:10:33] Will file as a bug and grabd a stack trace [12:11:04] New patchset: Mwalker; "Update Special:Version Licensing for Extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [12:11:04] New patchset: Hashar; "whitelist Tyler Romeo" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/65433 [12:11:37] Reedy: Yeah, I'll need to look at the trace. Later. [12:12:06] All one userpage it seems [12:12:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=48807 [12:14:14] New review: Nischayn22; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [12:14:51] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [12:15:52] Ryan_Lane: Is this the sort of thing that might take some time for you to fix? [12:16:04] should hopefully be done soon [12:16:45] marktraceur: new instance creations will work [12:17:13] weird [12:17:15] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [12:17:16] I got an error on delete [12:17:20] New patchset: Cmcmahon; "Replaced and implemented uls_cog_sidebar_logged_user_steps.rb Added Background" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65428 [12:18:05] it's working, though [12:18:34] New patchset: DMaggot; "Renaming files to follow name conventions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65434 [12:20:19] Yippie, build fixed! [12:20:20] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome build #70: FIXED in 7 min 26 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-chrome/70/ [12:20:21] New patchset: Wikinaut; "SpecialVersion: Add last local update timestamp for core and extensions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59373 [12:24:03] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [12:26:38] New patchset: Alex Monk; "Echo notification for new project membership" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65436 [12:28:00] New patchset: Hoo man; "Don't log autocreations twice" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65437 [12:28:28] Reedy: thanks [12:29:04] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65437 [12:30:56] New review: Wikinaut; "ok, no further objections or observations. Merging now." [mediawiki/extensions/OpenID] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45474 [12:30:59] Change merged: Wikinaut; [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [12:32:39] Ryan_Lane: Still cannot associate [12:34:20] hm [12:34:49] lemme take a look [12:34:51] Oh, that'd be nice [12:35:28] New patchset: Hoo man; "Only log creations done via the maintenance script once" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65438 [12:36:14] you're doing a ton of requests right now [12:36:23] New review: Umherirrender; "This produced double log entries for automatic account creations." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [12:36:40] marktraceur: why so many requests? [12:36:42] Uh, am I? [12:36:58] Oh hm. [12:37:16] Wait, no, I'm not making requests [12:37:24] hm. I wonder what is [12:37:34] Ryan_Lane: I am SSH'd in? [12:37:45] no [12:37:56] but it's a bunch of requests for servers in the visualeditor project [12:37:58] Oh, hey, javascript error. Gotta fix that. [12:38:36] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [12:39:04] 2013-05-25 12:38:27 INFO nova.api.openstack.wsgi [req-712b3017-4b02-46c0-a936-001022ac2342 laner testing] HTTP exception thrown: No nw_info cache associated with instance [12:39:05] hmmmm [12:39:06] New patchset: Reedy; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65439 [12:39:36] Weird. [12:40:06] o [12:40:08] oh [12:40:10] I know why [12:40:41] New review: Umherirrender; "Fixed with Ia84da784" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [12:40:45] delete and recreate the instance [12:41:04] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #8: FAILURE in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/8/ [12:41:15] I didn't have a fixed IP range [12:41:24] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [12:41:26] and you can't associate a public ip if a private ip doesn't exist [12:41:29] Ah. [12:41:48] yep. it's working now [12:42:30] You have an interesting definition of working [12:42:39] Do I need to allocate a new IP? [12:42:56] you have to allocate one [12:43:01] did you not have one allocated? [12:43:11] I did, but it still won't associate [12:43:19] heh [12:43:26] you needed to delete/recreate the insance :) [12:43:29] instance [12:43:33] Agh. [12:43:52] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65439 [12:45:25] New patchset: Waldir; "Remove the id "anonlogin"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [12:46:02] Cool, now it's my fault it's broken again [12:46:11] (i.e. I can actually fix what's broken now) [12:49:30] :) [12:50:47] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [12:52:38] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [12:54:48] New review: Hoo man; "@Umherirrender: I saw that as well and there's a patch in gerrit already ;)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [12:56:32] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [12:57:38] New patchset: Thaiphan; "Replace old SDK with new one by Microsoft" [mediawiki/extensions/WindowsAzureSDK] (master) - https://gerrit.wikimedia.org/r/56770 [12:58:20] Change abandoned: Psychoslave; "The cat state is undecidable" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/65431 [12:58:32] New review: Thaiphan; "I rebased it." [mediawiki/extensions/WindowsAzureSDK] (master) - https://gerrit.wikimedia.org/r/56770 [13:04:00] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [13:04:17] New review: Umherirrender; "Yay, thanks for I0237f175" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [13:06:30] Hi https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Wikinaut_for_extension_UserMerge_and_Delete is my older request for setting me again up as maintainer. [13:06:53] I think it has been forgotten to set me up as maintainer, when extension was moved from svn to gerrit/git [13:07:12] can someone pls comment, or grant this, thanks [13:08:06] e-greetings from Berlin to Amsterdam Hackathon [13:13:04] New patchset: Waldir; "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65446 [13:14:38] New patchset: Siebrand; "More degloblization" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65447 [13:17:24] New patchset: Waldir; "Rename Skin::getUsableSkins() to Skin::getAllowedSkins()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65446 [13:18:40] New patchset: MrBlueSky; "Add associated namespace option to Special:NewPages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [13:21:01] marktraceur: https://gerrit.wikimedia.org/r/#/c/65421/5/modules/ext.openstack.Address.js,unified [13:21:20] any reason that doesn't use descriptor like Instance? [13:24:51] New patchset: Ori.livneh; "Allow VirtualBox to manage permissions of shared files" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/65448 [13:24:59] Ryan_Lane: descriptor? [13:25:08] which room are you in? [13:25:18] we can talk in person :) [13:25:27] Oh, I see [13:25:34] Change merged: jenkins-bot; [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/65448 [13:25:38] Ryan_Lane: I decided that was a stupid way to construct an object [13:25:48] Ryan_Lane: Better to have meaningful constructor arguments [13:25:51] Ryan_Lane: I'm in the bar [13:26:02] heh [13:26:03] coming that way [13:26:18] * Reedy gives marktraceur some lego [13:27:38] New review: JanZerebecki; "Bug: 43679" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48743 [13:31:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=167 [13:32:39] New patchset: Nemo bis; "(bug 48798) Customise linktrail for Gujarati (gu)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65449 [13:34:20] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65450 [13:34:51] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [13:34:51] New patchset: MarkAHershberger; "Forgot to update release notes" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65451 [13:35:29] New review: MarkAHershberger; "self merge updated release notes" [mediawiki/core] (REL1_21); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65451 [13:35:30] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/65451 [13:51:44] New review: Siebrand; "Replies to comments. New PS coming up." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65447 [13:52:20] New patchset: Siebrand; "More degloblization" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65447 [13:52:50] Yippie, build fixed! [13:52:51] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9 build #27: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/27/ [13:53:02] New patchset: TMg; "Expanding preference label to what it actually does" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/65453 [13:54:54] New patchset: Ori.livneh; "Add coroutine-based, URI-configured generic event processor" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65456 [13:56:06] New review: JanZerebecki; "The class being tested in that file is UploadBase, so I think the file name was correct, but the cla..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65434 [13:59:16] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [14:02:13] JeroenDeDauw: ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config.git [14:03:29] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [14:03:37] New patchset: Hashar; "WIP WIP WIP WIP" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65457 [14:05:14] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [14:06:59] New review: Nikerabbit; "Let's humour you." [mediawiki/extensions/Translate] (master) C: 2; - https://gerrit.wikimedia.org/r/65447 [14:07:17] New patchset: Nemo bis; "(bug 48798) Customise linktrail for Gujarati (gu)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65449 [14:09:25] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65447 [14:10:16] zeljkof: Hey, judytuna is looking for you and Chris [14:10:52] zeljkof: judy is looking for you :D [14:11:10] Now Eloquence's turn [14:13:43] New patchset: Nikerabbit; "Update formatting" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65450 [14:13:54] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [14:16:19] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65450 [14:17:22] New patchset: TMg; "Expanding preference label to what it actually does" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/65453 [14:17:23] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [14:20:42] New review: DMaggot; "Correct me if I'm wrong, but from tests/phpunit/TODO" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65434 [14:21:04] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [14:23:38] New patchset: Jarry1250; "Tweak file handling code, particularly to improve performance" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65458 [14:29:51] New patchset: MarkTraceur; "Add Ajax-y interface for Special:NovaAddress" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65421 [14:32:19] New patchset: Jarry1250; "Support non-duplicative sublocales (pt_BR, en_GB, etc.)" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65460 [14:35:11] New patchset: Ryan Lane; "Don't add instance creator info into puppet" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65461 [14:36:14] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65461 [14:42:26] New patchset: Jarry1250; "Upgrade TranslateSvg for use with TUX" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65462 [14:44:03] New patchset: Nischayn22; "adds blacklisting feature for flickr in backend" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65109 [14:44:49] New patchset: Jarry1250; "Upgrade TranslateSvg for use with TUX" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65462 [14:45:30] New review: Nischayn22; "Works for me if https://gerrit.wikimedia.org/r/#q,Ia3daaeba1ce5e69e751ffc2ae5afd5e449cf4aa7,n,z is m..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65109 [14:46:20] New review: Anomie; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65414 [14:46:28] New review: JanZerebecki; "Sorry, mixed something up. You are right." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65434 [14:48:09] New patchset: Jarry1250; "Add loading spinner and tweak display time." [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65464 [14:48:13] New review: Nischayn22; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [14:52:20] New review: Matmarex; "I've traced it back to r3280 by Gabriel Wicke. I don't think it's really needed, but I cc'd him." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65440 [14:52:50] New review: Nischayn22; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [14:55:44] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [14:55:54] New patchset: Jarry1250; "Tidy and miscellaneous bugfix" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/65466 [14:58:30] New patchset: Parent5446; "Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [14:59:16] New review: Nischayn22; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [15:05:06] New patchset: Hashar; "standalone phpunit for Ask and Diff" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65467 [15:07:14] JeroenDeDauw: https://gerrit.wikimedia.org/r/65467 :D [15:09:19] New patchset: TMg; "Renaming the "Beta" label to "Editor"" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/65468 [15:09:58] New review: Hashar; "work in progress" [integration/jenkins-job-builder-config] (master) C: -2; - https://gerrit.wikimedia.org/r/65467 [15:20:08] New review: Wikinaut; "great. I need this urgently." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21986 [15:42:35] New patchset: J; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [15:46:55] New patchset: Catrope; "Changed edit token construction to SHA-256" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65420 [15:50:28] New patchset: Alex Monk; "Newlines should be converted to spaces for IRC feed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65472 [15:57:09] New patchset: Physikerwelt; "batch script for stresstest of the database" [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65473 [15:58:00] Change merged: Physikerwelt; [mediawiki/extensions/MathSearch] (master) - https://gerrit.wikimedia.org/r/65473 [16:03:24] New patchset: Zfilipin; "Replaced and implemented uls_cog_sidebar_logged_user_steps.rb Added Background" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65428 [16:06:46] New patchset: Nischayn22; "Stop uploading if maxLimit reached" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65474 [16:08:09] New review: Nischayn22; "Needs to be verified for 'add more files'" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65474 [16:28:20] New review: Zfilipin; "Comments are inline. We can pair on this tomorrow." [qa/browsertests] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/65428 [16:34:21] New patchset: Umherirrender; "Removed uiprop=preferencestoken from meta=userinfo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65476 [16:43:16] New review: Daniel Friesen; "Can someone tell me what the point of renaming a local variable like this is.... especially when the..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65426 [16:47:53] New review: Daniel Friesen; "Skin::getUsableSkins is a public method. Please don't just remove it without putting in an aliased m..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65446 [16:49:05] New review: Daniel Friesen; "Haven't we already WONTFIXed this? Shouldn't it just be abandoned." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/59373 [17:01:41] New review: Wikinaut; "I am using that." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/59373 [17:02:21] New review: Daniel Friesen; "I don't really oppose this idea. But I don't think we should just remove it without adding in an alt..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [17:15:06] New patchset: Ori.livneh; "Add coroutine-based, URI-configured generic event processor" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65456 [17:15:20] * Reedy wonders where ori-l is [17:15:32] fuck, it's 7:15 [17:15:54] and? [17:16:19] i pm'd [17:20:02] New patchset: Ori.livneh; "Add coroutine-based, URI-configured generic event processor" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65456 [17:21:13] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/65456 [17:47:00] Change merged: jenkins-bot; [mediawiki/extensions/Thanks] (master) - https://gerrit.wikimedia.org/r/63142 [18:20:23] New patchset: Liangent; "Support using alternative tables in $wgSharedTables" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65477 [18:25:19] New patchset: Liangent; "Support using alternative tables in $wgSharedTables" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65477 [18:26:08] New review: Liangent; "Not sure whether people feel interested..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65477 [18:28:40] New patchset: Liangent; "Support using alternative tables in $wgSharedTables" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65477 [20:10:04] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #55: FAILURE in 8 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/55/ [20:13:38] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #75: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/75/ [20:36:19] New review: Mattflaschen; "One of the keys is wrong." [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/65436 [20:37:49] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #57: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/57/ [20:40:06] New patchset: Alex Monk; "Echo notification for new project membership" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65436 [20:44:38] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #33: FAILURE in 6 min 48 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/33/ [20:45:35] New patchset: TMg; "Re-grouping and ordering the editing preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65478 [20:51:26] Change merged: Aaron Schulz; [mediawiki/extensions/WindowsAzureSDK] (master) - https://gerrit.wikimedia.org/r/56770 [20:59:25] Yippie, build fixed! [20:59:25] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #9: FIXED in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/9/ [21:02:54] Project browsertests-en.wikipedia.org-linux-chrome build #81: FAILURE in 3 min 28 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/81/ [21:11:14] Yippie, build fixed! [21:11:14] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #48: FIXED in 4 min 49 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/48/ [21:17:30] New patchset: Krinkle; "skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [21:21:13] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65440 [21:29:22] Project browsertests-test2.wikipedia.org-linux-firefox build #298: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/298/ [21:29:40] Project browsertests-test2.wikipedia.org-linux-chrome build #340: FAILURE in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/340/ [21:59:10] New patchset: RAN1; "Optimize JS, move JS ResLoad module, bump to 0.3.3" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65479 [23:09:46] Yippie, build fixed! [23:09:46] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #56: FIXED in 8 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/56/ [23:10:01] Yippie, build fixed! [23:10:01] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #76: FIXED in 8 min 47 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/76/ [23:13:59] New review: Anomie; "Actually, the token returned by uiprop=preferencestoken is currently the same as the token returned ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65476 [23:33:15] New patchset: PleaseStand; "Language::convertPlural: check if matching form exists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65480 [23:33:36] Yippie, build fixed! [23:33:36] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #58: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/58/ [23:37:53] Gerrit seems to give me a lot of "Working..." [23:40:31] Yippie, build fixed! [23:40:31] Project browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox build #34: FIXED in 6 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-linux-firefox/34/ [23:58:55] Project browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8 build #10: FAILURE in 9 min 54 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_8/10/