[00:02:48] New patchset: Kaldari; "Adding anchors to whitelisted HTML for mediawiki.jqueryMsg" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65165 [00:03:59] New review: Mattflaschen; "A bug. But are you sure you're including mediawiki.jqueryMsg when testing?" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [00:09:27] New review: Mattflaschen; "A quick test would be good." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65165 [00:22:17] New patchset: Hiong3-eng5; "API: Created Express; Modified Define" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65166 [00:34:07] New review: Kaldari; "Yep, definitely including mediawiki.jquerymsg. The behavior of .parse() still respects the whitelist..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [00:36:58] New patchset: RAN1; "JS/PHP changed to match conventions, whitespace/comments" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65119 [00:44:03] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [00:54:03] New patchset: Spage; "new Create account contributors icon" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65167 [00:57:49] New patchset: Kaldari; "Adding anchors to whitelisted HTML for mediawiki.jqueryMsg" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65165 [01:11:48] anyone know how to compress a PNG from 8-bit/color RGBA to 4-bit colormap ? pngcrush makes 'em small, but i think that's smaller still. [01:20:17] New review: Kaldari; "The more elegant solution Erik refers to was merged in later as change I4049b666 and change Ic8420b89." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [01:36:51] New patchset: Adamw; "WIP: pull all the declarative stuff together" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/65003 [01:54:26] New patchset: Spage; "Compress PNGs used in new forms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65168 [02:15:46] New review: Hiong3-eng5; "This is just the beginning." [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65166 [03:21:47] New review: Mattflaschen; "Kaldari, my mistake. I answered too quickly before." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [03:30:45] New review: Mattflaschen; "I'm a little hesitant about this, since is not allowed on the server (just checked this)." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65165 [03:35:16] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [03:42:48] New patchset: Mwjames; "SMWQuery toArray() add query sorting information" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/52422 [03:43:37] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [04:11:23] New patchset: Mwjames; "QueryData add test" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65169 [04:14:27] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65169 [04:19:40] New patchset: RAN1; "Minor edits, obsessing over whitespace" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65119 [04:21:03] New patchset: RAN1; "Minor edits, obsessing over whitespace" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65119 [04:44:18] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [04:48:08] New patchset: Mwalker; "Removing PGY as a valid currency" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/65170 [04:49:57] Blech, this mac gets shittier and shittier. [04:50:44] DanielFriesen: switch to a non-mac [04:51:22] Heh... would love to if I had the money and time [04:52:26] well, when the mac bites the dust, then [04:54:10] YuviPanda: Btw, the idea that GitHub supports PubSubHubbub is a little debatable. [04:54:18] why? [04:54:30] did you try it? [04:55:12] YuviPanda: They don't actually follow the PubSubHubbub standard. The actively violate some of it's rules. A conforming PubSubHubbub client very likely would not work with GitHub's supposed PubSubHubbub. [04:55:21] oh [04:55:28] PubSubHubbub [04:55:36] That's a fun word. [04:55:42] lol [04:55:43] but are there many compliant implementations of PubSubHubbub [04:56:00] Six Bs. [04:56:04] No, five. [04:56:17] And four Us. [04:57:07] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [05:00:08] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [05:00:36] New patchset: Mattflaschen; "Remove gt.initGuider, allow one guider per tour at a time:" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65171 [05:03:54] New patchset: Santhosh; "Refactor interface integration code" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [05:18:01] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [05:22:08] New patchset: Mattflaschen; "Scroll for all steps in tour; add dependency for consistency" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65173 [05:27:13] DanielFriesen: Are you aware of *anyone* else at all doing PubSubHubbub? [05:27:26] IIRC friendfeed started it, and flickr did it for a while.... [05:30:51] YuviPanda: OStatus (which Status.Net, etc... implement), WordPress etc... also have plugins for it. [05:32:35] WordPress http://wordpress.org/extend/plugins/pubsubhubbub/ by Josh Fraser [05:32:35] MovableType -- http://github.com/miyagawa/MT-PubSubHubbub/tree/master by Tatsuhiko Miyagawa [05:32:36] Drupal -- http://cupid-project.be/project/fastwebfeed-module by Jo Bollen [05:32:36] Melody -- http://openmelody.org/blog/2010/01/what-is-pubsubhubbub-and-why-make-it-core [05:32:45] hmmm [05:32:47] maybe we should too [05:32:58] but 'can' vs 'do' [05:33:03] does wordpress.com do it? [05:33:44] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [05:35:01] It's a shame Google is killing reader. [05:35:34] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [05:35:36] If they supported PubSubHubbub and hosted an open hub... Everyone would start adding hubs to their feeds. [05:36:45] Well, they sorta do... https://pubsubhubbub.appspot.com/ is google. [05:37:00] No... it's just hosted on google [05:37:11] oh. okay. [05:37:51] Best way to get google to re-implement seems to be if WMF adopts. [05:41:06] Amgine: indeed... [05:48:18] New review: FastLizard4; "*sigh*" [mediawiki/extensions/CommunityTwitter] (master) C: 2; - https://gerrit.wikimedia.org/r/65119 [05:49:52] New patchset: Mattflaschen; "Animate scrolling to guider." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65174 [05:52:11] fun fact: someone trying to get to Module:String of wikidata to actually edit the module is going to be a little annoyed [05:52:21] or any of the modules that exist locally there [05:54:07] Not sure what you mean. [05:54:10] https://www.wikidata.org/wiki/Module:String [05:54:14] Seems normal. [05:54:21] sure. but do this [05:54:23] go to the wiki [05:54:32] type it in the search bar and 'go' [05:54:52] Heh. [05:54:58] https://www.wikidata.org/wiki/Q7253814 [05:55:00] Interesting. [05:55:02] yep [05:55:02] New patchset: Mattflaschen; "Animate scrolling to guider." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65174 [05:55:03] :-D [06:07:26] New review: Mattflaschen; "Looks good. I saw your post to Wikitech. After that's resolved, this should be good to merge." [mediawiki/extensions/Math] (master) C: 1; - https://gerrit.wikimedia.org/r/61987 [06:14:05] New review: Parent5446; "Code is good, but haven't tested." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65162 [06:32:49] WFM [06:35:10] (Thanks to either monobook, or the search gadget, or both.) [06:38:04] * marktraceur wonders if there's a specific hackathon-type channel or if we should just chatter here [06:38:27] here, there, everywhere.... [06:38:45] YuviPanda: I mean, there should almost certainly be a channel for this. We have channels for everything. [06:39:05] there wasn't one for last time [06:39:07] IIRC [06:39:24] It says #wmhack on the wiki page, but that channel seems empty [06:39:28] New review: Santhosh; "@nikerabbit, that issue is https://github.com/wikimedia/jquery.ime/issues/182" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65101 [06:39:39] marktraceur: it is referring to a twitter hashtag :) [06:40:03] * YuviPanda waits for marktraceur's reaction [06:40:05] * marktraceur is puzzled by this [06:40:43] by promotion of twitter over IRC for casual conversation? [06:41:56] #wmhack is now a thing [06:45:20] marktraceur: that's not legit on freenode [06:45:26] should be ##wmhack [06:45:56] and #wikimedia-dev feels unloved [06:45:57] Nemo_bis: It's a free software project ish [06:46:10] not the point [06:46:28] Nemo_bis: What *is* the point? [06:46:49] after breakfast [06:47:19] freenode doesn't really enforce that rule. [06:49:14] Clearly not (I'm looking at you, #minecraft) [06:55:32] Nemo_bis: do you really care for a channel that will exist only for ~1-2weeks? [06:57:09] p858snake|l: I could see it being like #wm-office but less frequently used [06:57:37] p858snake|l: I don't care at all, nobody does as Susan says :) [06:57:44] it can always be fixed in the future [06:58:38] /msg chanserv mv #wmhack #wikimedia-hack [06:58:47] *that* would be a cool feature [06:58:47] "Primary channel names are reserved based on a formal or informal claim, external to IRC, to a specific project, group or trademark name" https://freenode.net/policy.shtml#primarychannels [06:59:27] how's connection at the venue, so far? [06:59:50] New review: Amire80; "To test, just create some links to a page, try to delete it and check that a warning appears. Also t..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65162 [07:00:06] Nemo_bis: Seems pretty OK [07:00:12] :) [07:03:31] marktraceur: what're your hackathon plans? [07:04:18] YuviPanda: I had something tentative with Ryan_Lane, but he not here [07:04:29] I might hack on lochner for a bit until that happens [07:04:32] ah, hmm [07:04:34] ah [07:04:34] right [07:05:20] YuviPanda: Do you know what that is? I didn't think I'd socialised it at all [07:05:31] your legal briefing parser [07:05:33] right? [07:05:36] Yeah [07:05:51] have you mistaken me for someone who does not spend half their awake time bantering on the staff channel? :P [07:06:03] Oh, right [07:07:45] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/65170 [07:15:30] New review: TheDJ; "It's already enabled in Nageh's en.wp version of MathJax. As far as consensus is concerned, I consid..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [07:22:31] New review: TheDJ; "For some reason I was under the assumption that the defaults were 'none'. I'll write up a config thi..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [07:35:29] Change merged: Mwalker; [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/65150 [07:38:57] New review: TheDJ; "The message is in the wrong section of messages.inc I think:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65162 [07:41:22] New patchset: Cmcmahon; "Tests for existence of Appearance and Datetime preferences" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [07:41:47] Change abandoned: Cmcmahon; "duplicate" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64830 [07:44:43] New patchset: Parent5446; "[DO NOT MERGE] Automatically move category members when redirected" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65176 [07:46:38] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65176 [07:49:38] New patchset: Parent5446; "[DO NOT MERGE] Automatically move category members when redirected" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65176 [07:57:41] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65145 [07:58:54] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [08:03:45] New review: Anomie; "Also, you would need to update doc/hooks.txt, and add an entry to RELEASE-NOTES-1.22." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65102 [08:13:21] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [08:14:29] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [08:15:13] New review: TheDJ; "not tested, but looks proper" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65136 [08:23:28] Change merged: jenkins-bot; [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [08:28:31] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64863 [08:28:37] chrismcmahon: zeljkof just a small poke about the fact that brwosertests now accepts Pull Requests too, in case you hadn't seen the email yet [08:28:45] (might be useful for the hackathon) [08:28:52] *browsertests [08:29:15] YuviPanda: thanks for letting me know, I have seen he e-mails, but I did not have the time to read them yet [08:29:19] hi YuviPanda I saw that, zeljkof and I are in Amsterdam right now and we're definitely going to be using that [08:29:28] cool :D [08:29:49] thanks for letting me use browsertests as a playground ;) [08:30:29] YuviPanda: we're getting a lot of community interest in browsertests, and having pull requests do something useful is really great for outsiders [08:30:34] :D [08:30:48] note that it's still experimental, so it'll get better with use [08:30:53] i'm implementing extensive logging later today [08:31:01] i'll keep you two informed :) [08:31:07] does the hackathon start today or tomorrow? [08:31:29] YuviPanda: it starts today, most people arrived yesterday [08:31:39] ah [08:31:40] nice :) [08:31:45] YuviPanda: I'm sitting across from zeljkof at a table right now :) [08:31:52] oh well, powercut for the day starting in 2 minutes :D [08:31:56] so i'll be off when it goes [08:32:06] chrismcmahon: do let me know if it doesn't seem to work [08:32:07] thanks YuviPanda [08:32:19] chrismcmahon: the bot should leave a comment in the pull request with link to the Gerrit changeset [08:32:54] chrismcmahon: also, just checking - is https://github.com/wikimedia/qa-browsertests up to date? [08:32:59] i see last commit was 10 day sago [08:33:01] *days ago [08:33:10] i'm hoping that me messing around with the repo didn't break replication [08:33:56] YuviPanda: it should be OK, zeljkof and I have been on different vacations recently, we have a really big backlog of gerrit review to get through for the hackathon [08:34:01] ah :) [08:34:04] nice [08:34:09] (about the vacation, that is) [08:34:22] do help test out the GitHub stuff, i'm super interested in making them super-stable :D [08:34:34] i'm off now [08:34:35] cya [08:35:24] New review: TheDJ; "I have:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57518 [08:44:32] guys, does anyone know where "sitedir-ltr" class (in the tag) comes from? is it familiar? I have it wrong (sitedir-ltr despite the fact my wiki is in hebrew/rtl) and i'm trying to figure out if it's a wiki issue, or an extension issue [08:44:42] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [08:44:43] can't find it in the docs [08:45:40] mooey: includes/OutputPage.php: $bodyClasses[] = "sitedir-$sitedir"; [08:45:46] git grep is your friend :) [08:45:54] hah I should get used to grepping [08:46:17] marktraceur: so... that's one of the symptoms in the bug I submitted in VE [08:46:31] so this is MW issue? I am confused now. the language seems to be all mixed up [08:46:46] I have it's as if it's confused about what it should be presenting [08:47:14] mooey: My thinking is that rtl overrides the sitedir, but the information has to be there anyway [08:47:38] mooey: The sitedir almost certainly has to be there to control the menus, but the content can be a different direction maybe? I'm speculating. [08:47:43] hm. it appers on all pages regardless of VE [08:47:53] hm, might be. [08:47:59] okay, so it's likely not the symptom of what I'm looking for [08:48:04] Probably not [08:48:07] VE's hooks php page readsd the language direction [08:48:29] but it seems to always get en/ltr even though the direction is he/rtl [08:49:07] I need to figure out why that happens. So weird. [08:51:09] I'm not sure if this is a VE issue or mediawiki issue. Weirdness. [08:52:10] hello Krinkle [08:53:16] YuviPanda: Hi [08:53:38] thanks for opening that issue and showing interest :) [08:56:40] New review: TheDJ; "ok, my mistake, it's MediaWiki:Key/en-gb, not MediaWiki:Key/en-GB" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [09:09:06] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/64854/ [09:09:34] New review: CSteipp; "Tests all look good, and seems like a sane way to do this in general. thanks!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/65123 [09:09:40] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [09:12:57] New review: Krinkle; "How does this make sense? Anchor tags are not allowed in wikitext, how can they occur in a msg with ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65165 [09:18:10] New patchset: Krinkle; "Gadget-definitions: Make comment matching non-greedy" [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/65010 [09:20:49] New patchset: Catrope; "jquery.byteLimit: Improve unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64854 [09:21:23] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/65129 [09:22:06] New patchset: Santhosh; "Refactor interface integration code" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [09:23:33] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63281 [09:24:56] New review: Krinkle; "See jenkins-bot comment. Especially "https://integration.wikimedia.org/ci/job/mediawiki-core-jslint/..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64556 [09:26:48] New patchset: Catrope; "jquery.byteLimit: Fix infinite loop if text is longer than max" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [09:28:11] New review: Faidon; "I don't have any comments -- let's just test this :-)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [09:29:35] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64854 [09:30:54] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [09:32:27] New patchset: Krinkle; "Add scrubDeletedFile.php script to purge deleted files from storage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [09:33:41] New review: Krinkle; "Make naming more consistent:" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62549 [09:34:16] New review: Krinkle; "Also be sure to document how this this different from maintenance/purgeDeletedFiles.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [09:34:25] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [09:39:24] New patchset: Pastakhov; "add reserved variables $argv and $argc (version 0.3.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/64833 [09:39:45] New patchset: ArielGlenn; "XML text dumps: skip rev length check for weird content models" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [09:44:19] New review: ArielGlenn; "We need this because otherwise on wikidata which has mostly wikibase-item or wikibase-property model..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65236 [09:49:50] New review: Physikerwelt; "see:" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [10:00:29] New patchset: Krinkle; "Drop support for old skins that don't use OutputPage::headElement" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [10:02:49] New review: Anomie; "I started receiving mysterious "failed to map segment from shared object: Cannot allocate memory" an..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59797 [10:04:53] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63378 [10:07:54] New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [10:09:37] New patchset: Hashar; "phplint builder now uses git-changed-in-head" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65239 [10:14:40] New patchset: Hashar; "phplint builder now uses git-changed-in-head" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65239 [10:16:34] New patchset: Matthias Mullie; "(bug 43167) list=articlefeedbackv5-view* accepts page titles as an option" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [10:31:19] MatmaRex: Are you in the hackathon venue? [10:31:32] Waldir and $someoneElse are looking for you [10:33:03] marktraceur: yep [10:33:17] i was late for the introduciton trhingy [10:33:25] MatmaRex: Where at? (I don't recognize you, so) [10:33:35] i'msitting at the back of the room [10:33:36] green t0shirt [10:33:41] (not the hakcathon one) [10:33:46] blah, sorry about the typos [10:34:33] MatmaRex: near the lunch area ? [10:35:23] thedj: yep [10:35:45] ,.mzDV.d,.x.,x,.c,.cxm,. [10:36:00] Danny walker over my fingers [10:38:24] * marktraceur successfully located MatmaRex and then lost waldir and $otherperson [10:43:42] New review: Faidon; "Purge usually means HTTP intermediate cache purging, so let's avoid this term in this if possible." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [11:09:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54114 [11:12:50] New patchset: Parent5446; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [11:29:53] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64842 [11:33:59] New review: Hashar; "All -lint jobs got updated." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/65239 [11:34:00] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65239 [11:35:45] and for the noob question, does anyone know how we deploy the mediawiki-config changes now ? I mean instead of using fenari :D [11:37:10] tin right? [11:37:48] Krinkle: did you just answer "yes" to A or B question? https://gerrit.wikimedia.org/r/#/c/63382/3/resources/mediawiki.api/mediawiki.api.login.js [11:37:55] apergos: ah yeah tin [11:38:17] hopefully that is what is in /a/common [11:38:35] Nikerabbit: see inline [11:38:45] Nikerabbit: oh [11:38:54] Nikerabbit: Yes to "?: unknown" [11:39:39] ;) [11:39:58] and of course the remote uses a ssh:// URL :( [11:41:19] New patchset: Zfilipin; "Run this on enwiki and beta but not test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [11:43:10] nnnnndd no more shared home :-( [11:45:49] apergos: sorry the addWiki script is now under the extension WikimediaMaintenance :-D [11:46:03] :-D [11:46:08] figures! [11:46:24] need to figure out how it works :D [11:46:29] curious to know if it works (also curious to know if the wb_terms table is already in there or not) [11:46:55] I guess it's not exactly going to steal the schema from some other wiki so that last q is irrelevant [11:47:19] ./refreshWikiversionsCDB [11:47:20] PHP Warning: file_get_contents(/a/common/wikiversions.dat): failed to open stream: No such file or directory in /data/project/apache/common-local/multiversion/MWWikiversions.php on line 13 [11:47:22] haha beta broken again [11:47:31] woops [11:51:22] "is now" [11:51:29] It's been there quite a while :p [11:52:31] yeah I have been lagging out Reedy :( [11:52:40] it is not like I have a weekly conf call with the team :) [11:52:44] so [11:52:53] /usr/local/lib/mw-deployment-vars.sh does not reference /a [11:53:23] but multiversion/defines.php does shah [11:53:30] git blame -> tim :D [11:55:06] New patchset: Nikerabbit; "mediawiki.api: Implement login method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [11:56:19] New patchset: Zfilipin; "Feature: Print/export section expand and collapse" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [11:56:50] New review: Cmcmahon; "make go for test2wiki" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63825 [11:56:51] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [11:59:23] New review: Tim Starling; "Looks good, just a few minor issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/41196 [12:02:36] TimStarling: how did you get /a/common created on tin please ? I can't find a file {} definition in puppet [12:03:31] mkdir [12:03:39] ;-] [12:04:21] will get it created I guess :-D [12:06:42] you want the whole of MW in puppet? [12:07:05] update it by checking in the .git directory to git? [12:07:54] TimStarling: the multiversion/defines.php uses /a/common which does not exist on beta [12:08:06] so I have to make it a symlink [12:08:57] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63427 [12:08:57] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63427 [12:17:12] New patchset: Santhosh; "Update jquery.uls from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65250 [12:18:41] New patchset: Santhosh; "Refactor interface integration code" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65172 [12:23:42] New review: Nikerabbit; "Okay you can ignore some of my previous commits, since I was under the assumption that we would also..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:30:17] TimStarling: Reedy: /a/common on beta by using a symlink :D https://gerrit.wikimedia.org/r/65254 [12:31:24] New review: Parent5446; "@Nikerabbit - Fair enough. It's a simple change. I'll make it that way in the next patch set." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:35:21] New patchset: Parent5446; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:37:33] New patchset: Zfilipin; "Fixed mysterious "Tests Failed" error when all tests pass" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65255 [12:38:04] New review: Cmcmahon; "glad to see this fix" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65255 [12:38:04] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65255 [12:42:39] parent5446: whii! [12:43:05] whii? [12:44:46] parent5446: I think we are getting there [12:45:51] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65262 [12:46:03] Oh, yeah. Every so slowly. :) [12:48:28] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65262 [12:48:29] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65262 [12:51:14] parent5446: should the comment for ::get be reflected that we dropped /en for now? [12:51:35] *facepalm* yeah I forgot that [12:52:49] New patchset: Jarry1250; "The language used to render SVGs should be definable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25838 [12:53:06] New patchset: Parent5446; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:56:28] New patchset: Jarry1250; "The language used to render SVGs should be definable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25838 [12:58:58] New patchset: Nikerabbit; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:59:37] New review: Nikerabbit; "Removed MediaWiki:A/en related tests now that we dropped it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [12:59:56] parent5446: ^^ [13:00:02] if that looks okay I'm ready to +2 [13:00:41] Should be good. [13:00:53] parent5446: or not [13:01:10] parent5446: https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/8018/console [13:01:18] :/ [13:02:46] Argh, I'll have to check it after this Scribunto presentation. [13:04:51] New review: Matmarex; "Replies inline." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [13:06:32] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [13:12:38] New patchset: Matmarex; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [13:12:39] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [13:12:39] New patchset: Matmarex; "Clean up the watchlist reset button HTML" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64557 [13:12:39] New patchset: Matmarex; "Don't reinvent the wheel in SpecialRecentchangeslinked::getExtraOptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [13:12:48] New review: Reedy; "The first parser test failure looks unrelated." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/25838 [13:21:09] Project _debug-browsertests-template build #147: FAILURE in 9 min 51 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/147/ [13:23:30] New review: Reedy; "13:00:46 [exec] 1) ParserTests::testParserTest with data set #329 ('Magic Word: {{NUMBEROFFILES..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25838 [13:23:59] Ryan_Lane: Did you push that change yet? [13:24:06] oh. I did not [13:25:05] marktraceur: one sec. [13:27:21] 's OK, I'm not in any rush [13:27:26] I'm just surveying my options [13:27:49] Ryan_Lane: It looks like there's not an easy way to test these things locally...or should I really install LDAP and openstack? :/ [13:28:02] Ryan_Lane: It looks like there's not an easy way to test these things locally...or should I really install LDAP and openstack? :/ [13:28:19] * marktraceur doubles message because Ryan had a network drop [13:31:23] marktraceur: set up a labs test enviroment inside of labs? *runs* [13:32:45] marktraceur: I have a labs instance for this [13:33:07] testing locally is… difficult [13:33:23] I used vagrant for it, but I also did a ton of stuff locally after vagrant [13:33:33] p858snake|l: that's what it is [13:33:54] Berk. [13:34:07] Ryan_Lane: I mean locally, as in, not needing to contact another server on this crap wifi [13:34:20] heh [13:34:21] But oh, reading is helpful, that's not trivial [13:34:45] hm. I wonder if I could just give you a copy of my vagrant instance [13:35:08] Yes! You could! Actually, we were just learning about how to do something like that. [13:35:47] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [13:37:17] marktraceur: where are you sitting? [13:37:21] New patchset: Ryan Lane; "Show more informative instance status" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65269 [13:37:33] now I've pushed in my uncommitted changes :) [13:37:48] I see that! I'm up on the balcony with csteipp [13:38:02] coming up there [13:39:31] New patchset: Nikerabbit; "WIP: Plural support for AndroidFFS" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65270 [13:51:57] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [13:52:36] re [13:53:32] Katharsis: Hey, what's up? [13:53:42] Which way would you recommend me to write a peace of code for finding the shortest path between two articles on en.wikipedia.org? [13:53:54] I wrote a simple script in Python language based on api.php. [13:54:29] But I'm not happy with time results [13:54:39] Katharsis: You could use the data dumps to do that work, and not need to get data from the API [13:54:40] New patchset: Ryan Lane; "Add api action for get console output" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/60783 [13:55:21] http://dumps.wikimedia.org/enwiki/ ? [13:55:27] Yup [13:56:22] New patchset: Ryan Lane; "Show more informative instance status" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65269 [13:56:52] marktraceur: cool idea, but I'll try with it later [13:57:05] right now I want to ask you [13:57:10] New patchset: Umherirrender; "Set context when using UserrightsPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65275 [13:57:59] is there any simple way to get all articles links (egz. /wiki/nane_of_article) on articule page using api.php? [13:58:18] right now I'm using sth like that: http://en.wikipedia.org/w/api.php?action=parse&prop=text&page=PyPy&format=json [13:58:33] and parse json format with regexp (or lxml for better resultst) [13:58:38] results* [13:59:27] New patchset: Umherirrender; "Set context when using UserrightsPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65275 [14:01:05] Katharsis: You could try parsing the page with Parsoid and looking for mw:WikiLink objects [14:05:53] New patchset: Hoo man; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:07:38] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [14:08:26] New review: Hoo man; "Addressed Tim's comments" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:10:37] thanks for advice [14:10:38] cu [14:12:48] New patchset: Hoo man; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:13:25] New patchset: TheDJ; "UploadWizard: Scroll to bottom when adding new uploads" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65283 [14:13:33] New review: Hoo man; "Fixed a negation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:13:36] marktraceur: update-rc.d opendj defaults [14:13:56] Grazie [14:15:30] New patchset: Hoo man; "Patrol overhaul phase 1: Remove rcid parameters" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:16:37] New review: Hoo man; "Rebased (to properly test it)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41196 [14:18:09] New patchset: Umherirrender; "Apply default robot policy for non-existing user pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65284 [14:18:23] New patchset: TheDJ; "Fixes for most JSHint warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/59064 [14:20:03] New patchset: Ruud Koot; "GeoCrumbs: add schema.org/data-vocabulary.org metadata" [mediawiki/extensions/GeoCrumbs] (master) - https://gerrit.wikimedia.org/r/65285 [14:21:49] New review: Tim Starling; "(1 comment)" [mediawiki/extensions/Score] (master) C: -1; - https://gerrit.wikimedia.org/r/61181 [14:22:06] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63382 [14:24:04] New review: Umherirrender; "See I527aa9d9c19c5cef7bebde78ef22f426bcbb3cd6 for HTTP 200" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65284 [14:35:13] New patchset: Hoo man; "Hide external changes in Special:AbuseFilter/examine" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65287 [14:41:10] marktraceur: https://wikitech-test.wmflabs.org/wiki/Main_Page [14:41:19] code is at: /srv/org/wikimedia/controller/wikis/w/extensions/OpenStackManager [14:41:24] on nova-precise2.pmtpa.wmflabs [14:47:22] New patchset: Hoo man; "Remove redundant class for syntax errors" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65290 [14:52:23] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [14:53:55] Yippie, build fixed! [14:53:55] Project browsertests-en.wikipedia.org-linux-firefox build #68: FIXED in 2 min 3 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/68/ [14:55:39] New patchset: Hashar; "beta: get wikidata database to self upgrade" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65292 [14:56:20] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [15:00:40] New patchset: Jeroen De Dauw; "Added tests for PropertyValueSortExpression" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65293 [15:01:31] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [15:01:35] Ryan_Lane: Happy christmas, easy CR ^ [15:03:24] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [15:03:24] New patchset: Ruud Koot; "RecentChange: remove newFromCurRow and loadFromCurRow" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65295 [15:05:58] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [15:08:15] New patchset: Jeroen De Dauw; "Improvements to QueryOptionsTest" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65296 [15:10:58] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/65292 [15:11:42] New patchset: Jeroen De Dauw; "Fix @covers tag in SortOptionsTest" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65297 [15:12:48] marktraceur: &action=reboot&instanceid=9bda773f-701d-4485-89e7-a6d355a77a63&project=testing®ion=pmtpa [15:16:28] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [15:21:37] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [15:27:27] New patchset: Mwalker; "WIP: Update Special:Version Licensing (Part 1)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65299 [15:30:50] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [15:31:56] New patchset: Zfilipin; "Do the PDF test without cookies" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63247 [15:32:04] New patchset: JanZerebecki; "Adapt test of StringUtils::isUtf8 to work with PHP 5.4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65300 [15:40:30] New patchset: JanZerebecki; "Adapt test of StringUtils::isUtf8 to work with PHP 5.4" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65300 [15:41:40] New patchset: Zfilipin; "Do the PDF test without cookies" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63247 [15:42:15] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63247 [15:43:30] New patchset: AlephNull; "(bug 43571) Fixing fatal error when duplicating VIEWs in MySQL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65301 [15:45:05] New patchset: Zfilipin; "Tests for existence of Appearance and Datetime preferences" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/61592 [15:49:13] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [15:52:29] Change merged: jenkins-bot; [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/65010 [16:04:43] yurik_: I'm trying to test a new error code in OpenStackManager but the API continually tells me it's an unknown error code. See https://gerrit.wikimedia.org/r/65294 [16:05:09] Er, rather I'm trying to make sure an existing code works, because it was clearly not tested before [16:06:37] getPossibleErrorCodes() seems to be the problem, but I can't tell how to fix it. [16:07:53] In particular it looks like https://doc.wikimedia.org/mediawiki-core/master/php/html/ApiBase_8php_source.html#l01444 is only going to check the static member list of error messages, not the per-class or per-instance config [16:07:57] Are you using $this->dieUsageMsg()? If so, that's way, because dieUsageMsg() only checks ApiBase::messageMap. [16:08:04] Right [16:08:08] parent5446: What's the more better way? [16:08:27] Unfortunately, just do dieUsage() manually. [16:08:33] That's how most modules do it. [16:10:46] New patchset: MarkTraceur; "Adding params to permissions errors" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/65294 [16:11:18] Yippie, build fixed! [16:11:19] Project browsertests-en.wikipedia.org-windows-internet_explorer_9 build #32: FIXED in 3 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_9/32/ [16:11:39] parent5446: Thanks, helpful if annoying [16:12:56] New patchset: Hoo man; "Apply default robot policy for non-existing user pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65284 [16:13:10] Yeah, I've run into the issue before. Not sure why getPossibleErrors isn't incorporated into the error list. [16:13:21] New review: Hoo man; "Minor comment style fixes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65284 [16:14:11] New review: Hoo man; "Looks good, works well and seems legit" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65284 [16:14:53] Yippie, build fixed! [16:14:53] Project browsertests-en.wikipedia.org-windows-internet_explorer_8 build #46: FIXED in 3 min 34 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_8/46/ [16:16:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65284 [16:17:51] Yippie, build fixed! [16:17:51] Project browsertests-en.wikipedia.org-windows-internet_explorer_7 build #43: FIXED in 2 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_7/43/ [16:20:42] Yippie, build fixed! [16:20:43] Project browsertests-en.wikipedia.org-windows-internet_explorer_6 build #44: FIXED in 2 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-windows-internet_explorer_6/44/ [16:21:52] New review: Kaldari; "Fair enough, I was just trying to provide a quick solution to bug 43747, by unblocking change Ie142d..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65165 [16:22:35] Yippie, build fixed! [16:22:36] Project browsertests-sandbox.translatewiki.net-linux-chrome build #55: FIXED in 1 min 52 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/55/ [16:37:33] New patchset: Cmcmahon; "Don't run on on test2wiki until we get cookies working" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65307 [16:38:34] Yippie, build fixed! [16:38:34] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #69: FIXED in 9 min 18 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/69/ [16:38:48] Change merged: Zfilipin; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65307 [16:39:40] Project browsertests-test2.wikipedia.org-linux-firefox build #294: ABORTED in 6 min 46 sec: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/294/ [16:51:00] Project browsertests-test2.wikipedia.org-linux-firefox build #295: STILL FAILING in 10 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/295/ [16:52:43] New patchset: Zfilipin; "Upgrade Ruby to 2.0.0-p195" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65308 [16:53:33] New review: Cmcmahon; "maintenance" [qa/browsertests] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65308 [16:53:34] Change merged: Cmcmahon; [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65308 [16:56:39] New patchset: Ruud Koot; "Add an option to show related changes to associated pages (1/2)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65309 [16:56:39] New patchset: Ruud Koot; "Add an option to show related changes to associated pages (2/2)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65310 [17:06:01] Yippie, build fixed! [17:06:01] Project browsertests-test2.wikipedia.org-linux-chrome build #336: FIXED in 26 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/336/ [17:08:49] Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/64833 [17:14:31] New review: Hoo man; "It works, but if you select anything in the form (like a namepsace) that is being submitted and appl..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64557 [17:17:50] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [17:25:04] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65290 [17:30:18] Reedy: https://gerrit.wikimedia.org/r/#/c/64993/ 1 line [17:32:43] i cant get any google services (gmail, search, docs) from the SF office today, just an ssl connection error. is it just me? [17:32:49] same via wifi or wired [17:33:01] Yippie, build fixed! [17:33:02] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #51: FIXED in 8 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/51/ [17:34:00] New review: CSteipp; "I agree. I think that makes sense." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/65287 [17:34:04] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65287 [17:34:59] New review: FastLizard4; "Actually, there don't appear to be any real code changes here, so going to ahead and verify and merge." [mediawiki/extensions/CommunityTwitter] (master); V: 2 - https://gerrit.wikimedia.org/r/65119 [17:34:59] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65119 [17:35:02] csteipp: https://gerrit.wikimedia.org/r/#/c/64993/ [17:36:50] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [17:37:30] marktraceur: I could use some help with regexes :) [17:38:05] Nischayn22: I knew it, my regex sense was tingling [17:39:11] Nischayn22: You should ask questions! [17:39:25] marktraceur: Heh, I am working again with flickr blacklisting [17:39:36] Ah, my old nemesis. [17:39:49] https://gerrit.wikimedia.org/r/#/c/65109/ needs some regex to find the photo id from the image url [17:40:23] marktraceur: Talking to you is definitely helping my vocabulary ;) [17:41:18] Nischayn22: I live only to serve [17:41:38] marktraceur: PM? [17:42:09] Uh, possibly. Is it really necessary? I'd prefer to chat here so that random people in the channel can also benefit from my regex jedi powers. [17:42:28] marktraceur: Not about regex :) [17:42:38] Oh, then yes! [17:43:13] New patchset: FastLizard4; "Add RAN1 to authors list, since he's been a big help :D" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65311 [17:43:15] regex-fu ftw. [17:44:06] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65311 [17:45:05] Project browsertests-test2.wikipedia.org-linux-chrome build #337: FAILURE in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/337/ [17:45:55] anomie: hi. Do you know if there's a "how to debug lua modules" doc somewhere? [17:46:08] guillom: I don' [17:46:11] t think so [17:46:19] ok. Thanks :) [17:46:57] anomie: my main problem is how to test stuff that relies on "frame", since if I understand correctly, that's only provided when the module is invoked? [17:47:17] guillom: Ask me again in 1/2 hour or so [17:47:25] sure [17:47:27] thanks [17:47:51] Yippie, build fixed! [17:47:51] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #308: FIXED in 20 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/308/ [17:48:22] That's quite a cheery bot. [17:55:48] New review: Kaldari; "OK, that makes sense, although it definitely changed at some point. If the behavior isn't a bug, I'm..." [mediawiki/extensions/TimedMediaHandler] (master) C: 2; - https://gerrit.wikimedia.org/r/59602 [17:56:10] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [17:56:20] Change abandoned: Kaldari; "Not wanted" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65165 [18:00:04] New review: Hoo man; "First of all, I don't think this is the right thing to do, you should use a joined query or make it ..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/65309 [18:05:05] marktraceur: A flickr URL is of this form http://farm{farm-id}.staticflickr.com/{server-id}/{id}_{secret}.jpg [18:05:26] marktraceur: Need to get the id from that [18:05:44] Also http://www.flickr.com/services/api/misc.urls.html [18:06:32] Nischayn22: What regex have you constructed to accomplish this? [18:07:15] marktraceur: I haven't tried actually. I have lost touch with regexes completely :( [18:09:46] New patchset: Reedy; "Actually update $lastTime in runJobs.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64993 [18:13:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64993 [18:14:14] New patchset: Reedy; "The language used to render SVGs should be definable" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25838 [18:29:19] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [18:33:14] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [18:36:23] hmm, think its intentional that DatabaseBase::update doesn't do anything with a LIMIT key in the query options? [18:36:42] perhaps not supported across enough supported db's or some such [18:37:57] it's not standard [18:38:18] it can be done with mysql, though it is not safe for statement-based replication without an ORDER BY [18:38:32] New review: Parent5446; "Minor docs and spacing issues." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65279 [18:38:51] AaronSchulz: hmm, ok fair enough. can certainly do it slightly different without the limit and support more things. thanks. [18:42:30] New patchset: TheDJ; "UploadWizard: Remove unused function addWarning" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65315 [18:42:38] New patchset: Parent5446; "Added Uri class and Uri Query classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/22167 [18:42:49] New patchset: Parent5446; "Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [18:43:07] New patchset: EBernhardson; "LIMIT is not a supported DatabaseBase::update option" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65316 [18:44:08] New review: EBernhardson; "11:36 < ebernhardson> hmm, think its intentional that DatabaseBase::update doesn't do anything with ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65316 [18:45:30] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [18:47:07] New patchset: Aaron Schulz; "De-duplicate refreshLinks2 base jobs." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65317 [18:47:58] New patchset: TheDJ; "UploadWizard: Re-enable the option to upload previously deleted files" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65318 [18:48:16] New patchset: Aaron Schulz; "De-duplicate refreshLinks2 base jobs on insert." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65317 [18:49:37] New patchset: Luis Felipe Schenone; "MonoBook module declarations moved from Resources.php to MonoBook.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [18:49:54] New review: TheDJ; "This might look a bit hacky to some, but that's really because the whole event model of the wizard m..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65318 [18:52:45] New patchset: Nikerabbit; "Remove unused resources" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65320 [18:55:18] New patchset: Parent5446; "Changed edit token construction and checking" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21986 [18:55:34] New patchset: Parent5446; "Added throttling framework." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/34677 [18:56:00] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [19:01:51] New patchset: Parent5446; "Re-implemented Special:Userlogin using FormSpecialPage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27022 [19:01:54] New patchset: Freakolowsky; "Added DRCP and persistent connections support for Oracle" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [19:03:04] New patchset: Luis Felipe Schenone; "MonoBook module declarations moved from Resources.php to MonoBook.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:04:04] New review: Freakolowsky; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65279 [19:05:20] New patchset: Parent5446; "Changed temporary password system to use tokens." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/27472 [19:05:59] New patchset: Parent5446; "Notify user by email when password changed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48578 [19:06:05] marktraceur: Hey, I tried this http://www.regex101.com/r/yP1dE4 [19:06:53] Change abandoned: Parent5446; "This is pretty pointless. An analytics extension could do all of this." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/33467 [19:08:07] New review: Parent5446; "Go for it." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [19:08:29] New patchset: Parent5446; "Added new MWTimestamp::getRelativeTimestamp for pure relative." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45677 [19:08:34] anomie: when you have a moment: I've managed to get my module partly working: https://meta.wikimedia.org/wiki/Module:Template_translation . It translates parameterless templates properly; however, it ignores parameters when there are some. [19:09:00] Any pointer will be helpful :) [19:09:40] New patchset: Zielmicha; "Preferences: Add link to user contributions on value of "Number of edits"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [19:12:00] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65321 [19:17:13] New review: Faidon; "To continue the bikeshed a bit, scrub also means something special to Ceph (periodic revalidation of..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62549 [19:19:40] New patchset: Zielmicha; "Preferences: Add link to user contributions on value of "Number of edits"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [19:19:52] New patchset: Parent5446; "Config for adding rel="noreferrer" to external links." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/46790 [19:20:18] New review: Daniel Friesen; "Would -2 if I could. Bypassing the autoloader and loading unused skin classed on every page load is ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [19:23:02] New review: Parent5446; "Two things:" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/65319 [19:23:23] New patchset: Nischayn22; "Properly center arrowheads text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64556 [19:29:58] New patchset: Parent5446; "Change secure login to use a user preference; add secure groups option." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47089 [19:30:10] New patchset: Matmarex; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [19:30:11] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:30:11] New patchset: Matmarex; "Don't reinvent the wheel in SpecialRecentchangeslinked::getExtraOptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [19:30:11] New patchset: Matmarex; "Reorder SpecialRecentChanges::webOutput" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65325 [19:33:12] New review: TheDJ; "The way to make this async, might be to use a jQuery deferred object+promise ?" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [19:34:05] New review: Matmarex; "Actually,the more I think about this, the more it seems that this should in fact have a separate for..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64557 [19:36:14] New patchset: Parent5446; "Make maintenance/userOptions.php subclass Maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48417 [19:36:43] New patchset: Parent5446; "Added useful headers in MediaHandler::getStreamHeaders." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/51894 [19:37:03] New patchset: Parent5446; "Add TitleQuickPermissions hook to Title::checkQuickPermissions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52910 [19:37:35] Change abandoned: Parent5446; "Not worth it for API 1.0." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55286 [19:37:48] Change abandoned: Parent5446; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/56709 [19:37:54] New patchset: Parent5446; "Added SSL verification to PHPHttpRequest." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54584 [19:38:02] New patchset: Parent5446; "Add cache versioning to InfoAction." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54207 [19:38:32] New patchset: Parent5446; "Fixed $wgCookieExpiration functionality when set to 0." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61593 [19:38:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65321 [19:40:52] New patchset: MrBlueSky; "Bug 45133 and some cleanup of namespace selection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [19:45:25] New patchset: Luis Felipe Schenone; "MonoBook module declarations moved from Resources.php to MonoBook.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:46:55] New review: Luis Felipe Schenone; "I added (one?) of the classes to the autoloader from the MonoBook.php file. Does that solve the firs..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:47:09] New patchset: MrBlueSky; "Bug 45133 and some cleanup of namespace selection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [19:48:47] New patchset: Parent5446; "Added Html::radio, Html::check, and Html::label." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52645 [19:55:30] New review: Luis Felipe Schenone; "As to Parent5446 second concern, the advantage of declaring the modules from within the skin is that..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:55:46] New review: Parent5446; "The main problem is that the skin file is require()d in from DefaultSettings.php. That means that th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:57:01] New review: Parent5446; "To your second comment, I agree, but this patch isn't achieving that because it's still loading the ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [19:58:21] Change merged: jenkins-bot; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [19:58:35] New review: Luis Felipe Schenone; "I understand the problem now, and I think I see a solution. I'll revise it a commit another patch. U..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [20:01:12] New patchset: Aaron Schulz; "Fixed misleading @since tag." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65328 [20:05:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65328 [20:06:17] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64530 [20:07:25] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #70: FAILURE in 6 min 11 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/70/ [20:07:58] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64531 [20:09:11] New patchset: Physikerwelt; "MathJax: Use \mathbf instead \boldsymbol for the \bold command" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61284 [20:09:53] New patchset: Siebrand; "Reduce usage of globals" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [20:11:50] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61284 [20:15:57] New review: Physikerwelt; "Has to be discussed with MathJaX staff." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/4060 [20:17:50] [20:18:00] That's from AbuseFilter blockng something [20:18:04] That is a useless message [20:19:18] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [20:24:42] New review: MrBlueSky; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [20:25:08] New patchset: Hoo man; "Hide external changes in Special:AbuseFilter/test" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/65331 [20:26:32] * Reedy blames the not so away hoo|away [20:27:29] Reedy: Yeah... but it's still better than *no* error message:P [20:27:48] hoo|away: I created a MediaWikiSaysNo exception in AWB for this case [20:28:21] Project browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9 build #52: FAILURE in 9 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-windows-internet_explorer_9/52/ [20:29:00] :D I think there's another hook which would actually allow us to give a reason and other fancy modern stuff... but well... it's not broken [20:29:50] TBH, I thought it would anyway [20:30:07] New review: Daniel Friesen; "We already have patterns for self-contained skins. Built-in skins simply don't use them since they'r..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [20:30:25] Other extensions give back spamdetected or spamblacklist [20:30:40] What's the betting we have a bug complaining aobut that error messsage [20:30:43] New patchset: Aaron Schulz; "De-duplicate refreshLinks2 base jobs on insert." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65333 [20:30:51] Reedy: https://gerrit.wikimedia.org/r/#/c/65317/2 [20:30:57] 1 line :) [20:36:37] New patchset: Luis Felipe Schenone; "Making the MonoBook skin more self-contained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [20:36:54] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65333 [20:38:54] New review: Luis Felipe Schenone; "I went a bit further with this last patch, please be patient." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [20:39:51] New patchset: FastLizard4; "Add twitteroauth library into the repository" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65334 [20:40:52] New review: Luis Felipe Schenone; "Daniel, in this last patch I went closer to the existing patterns for self-contained skins, I think." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [20:41:41] New review: EBernhardson; "Since the other patch was merged, this needs to be abandoned" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/62118 [20:42:33] New patchset: FastLizard4; "Add twitteroauth library into the repository" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65334 [20:45:05] is there a standard time limit to give to a bug reporter when asked for more info to reproduce a bug and no more info is given? e.g. is it reasonable to close the bug as unreproducable after 2 weeks of no extra info? [20:45:25] New patchset: FastLizard4; "Add twitteroauth library into the repository" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65334 [20:45:35] * AaronSchulz tends to wait like a month ;) [20:45:44] sounds reasonable [20:45:49] i'll wait :) [20:45:53] maybe 3 weeks, things can always be re-opened [20:46:07] but it's usually not a rush anyway [20:46:21] i'm just going down our buglist trying to clean things up :) [20:46:40] New review: Daniel Friesen; "Instead of swapping these directly for RequestContext::getMain how about creating a simple method li..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65330 [20:46:43] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65334 [20:47:01] its suprisingly hard to find a bug report thats not either solved, a style choice that needs to be decided on at a non-programming level, or unreproducable [20:47:26] Trust me, they exist [20:47:39] MediaWiki core is full of them :) [20:47:45] New patchset: MrBlueSky; "Bug 45133 and some cleanup of namespace selection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [20:47:51] hmm, i guess i could look through core. I'm just looking at the Echo extension [20:48:25] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/65097/ tiny fix [20:48:46] * RoanKattouw gives ebernhardson a rope so he can find his way back [20:48:56] in case you get lost in the maze that is MW core bugs :) [20:49:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65158 [20:49:00] :) [20:52:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65097 [20:54:49] New patchset: Luis Felipe Schenone; "Making the MonoBook skin more self-contained" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [21:03:15] New review: Daniel Friesen; "These shouldn't be required from DefaultSettings.php. That file is for settings, period, it's not th..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65319 [21:08:01] New review: Jdlrobson; "Is this ready to go?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [21:19:48] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [21:21:27] New patchset: MrBlueSky; "Bug 45133 and some cleanup of namespace selection" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [21:21:45] New review: Luis Felipe Schenone; "Ur the boss Daniel, but I would have expected this patch to make further changes easier, not harder." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [21:24:00] Yippie, build fixed! [21:24:01] Project browsertests-test2.wikipedia.org-linux-chrome build #338: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-chrome/338/ [21:24:29] Yippie, build fixed! [21:24:30] Project browsertests-test2.wikipedia.org-linux-firefox build #296: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-linux-firefox/296/ [21:24:41] New review: Hashar; "Why do we have to duplicate that stuff? I mean what is the difference going to be between Xml::chec..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/52645 [21:25:49] New review: MrBlueSky; "*Patch Set 5: Use $dbr->makeList()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [21:28:55] New review: MrBlueSky; "* Patch Set 5: Use $dbr->makeList() " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [21:30:55] hexmode disappeared! [21:32:26] New review: Hashar; "I agree with that change. Note than some third party users might well be using this functions and we..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65295 [21:36:43] New review: Hashar; "(1 comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/65136 [21:40:12] $hexmode->show(); [21:40:23] off to get more beer [21:46:27] New patchset: Mattflaschen; "Only tag users without the autoconfirmed right." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65337 [21:53:20] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [21:54:33] New review: Waldir; "> These shouldn't be required from DefaultSettings.php. That file is for settings, period, it's not ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65319 [21:57:25] Project browsertests-test2.wikipedia.org-windows-internet_explorer_9 build #309: FAILURE in 16 min: https://wmf.ci.cloudbees.com/job/browsertests-test2.wikipedia.org-windows-internet_explorer_9/309/ [22:00:05] New patchset: Jarry1250; "Move dependency on ext.translateHooks to base module" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65338 [22:00:05] New patchset: Jarry1250; "Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures hooks" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65339 [22:02:28] New patchset: Kaldari; "Adding hook handler for creating human-friendly relative timestamp" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/45499 [22:04:22] New patchset: Kaldari; "Adding hook handler for creating human-friendly relative timestamp" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/45499 [22:08:51] New patchset: Jarry1250; "Move dependency on ext.translateHooks to base module" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65338 [22:08:52] New patchset: Jarry1250; "Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures hooks" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65339 [22:09:03] New patchset: Mattflaschen; "Add afterRemoval hook that fires when notification disappears." [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [22:13:10] New patchset: Jarry1250; "Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures hooks" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65339 [22:15:55] New patchset: Kaldari; "Adding hook handler for creating human-friendly relative timestamp" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/45499 [22:42:36] New patchset: Mwjames; "Add jsduck.json/jsduck.categories.json" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65342 [22:46:03] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65342 [22:46:15] New patchset: Mwjames; "srf.formats.tagcloud(), add tests and update to tagcanvas 2.1.2" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/65343 [22:50:14] New patchset: Reedy; "Add 2001:4c28::/32" [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/65344 [22:52:07] Change merged: Reedy; [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/65344 [22:53:32] New patchset: Reedy; "Update TrustedXFF to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65345 [22:54:11] New patchset: Spage; "Implement Agora styles in HTMLForms" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65346 [22:55:47] Reedy: You checked the reverse whatever? [22:56:12] New review: Spage; "Do not merge, needs design review. See it on toro labs machine." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/65346 [22:57:49] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65345 [23:03:36] New patchset: Reedy; "Update to match current WMF usage" [mediawiki/extensions/TrustedXFF] (master) - https://gerrit.wikimedia.org/r/65348 [23:03:49] Change merged: jenkins-bot; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/65343 [23:04:12] New patchset: Bsitu; "(bug 47912) Visting talk page should mark talk notif as read" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65349 [23:10:01] ^_^ There's another lovely thing about the future were we require php 5.4 besides traits... ^_^ We get to kill the code related to supporting register_globals [23:10:52] dont forget $this in closures(with protected and private method/property access!) [23:11:31] Don't cry for me, Argentina. [23:12:49] Yippie, build fixed! [23:12:49] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox build #52: FIXED in 11 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-firefox/52/ [23:12:57] Don't go chasin' waterfalls. [23:13:43] Yippie, build fixed! [23:13:44] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #71: FIXED in 12 min: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/71/ [23:22:50] New patchset: Aaron Schulz; "Added a --profiler option to all maintenance scripts." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65350 [23:28:03] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65350 [23:37:06] New patchset: EBernhardson; "Better detection of multiple changes in a document" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64577