[00:00:07] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:02:12] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:03:59] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:05:01] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:07:05] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:09:05] New review: EBernhardson; "This commit is now no longer a hack, but i'm still not sure i like how it works." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [00:10:56] New review: Kaldari; "We don't want to use a full URL here since it creates an 'external link' icon in the archive view. T..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64823 [00:20:11] New patchset: Mattflaschen; "Add afterRemoval hook that fires when notification disappears." [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [00:20:49] New patchset: Aaron Schulz; "[Database] Tweaked LoadMonitor::getLagTimes() to further reduce stampedes" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64992 [00:21:11] New review: Mattflaschen; "mw.hook is in wmf4, which is now everywhere. I need to rebase this, though." [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [00:21:25] New patchset: Mattflaschen; "Show toolbar after post-edit is done, if applicable." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [00:22:11] New review: Mattflaschen; "mw.hook is in wmf4, which is now everywhere. The PostEdit one is still pending, though." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/62953 [00:23:15] New patchset: Aaron Schulz; "[Database] Improved DatabaseMysql::masterPosWait() performance by caching the position." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [00:42:47] New patchset: Adamw; "WIP: pull all the declarative stuff together" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/65003 [00:54:08] New review: Adamw; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [00:57:42] New review: Adamw; "sorry - last comment was wrong: the stack trace is at Notice level, not fatal" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [01:58:01] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [02:27:59] New patchset: Mattflaschen; "Remove all cookie-related functionality, including endTour." [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/65004 [02:30:34] New patchset: Mattflaschen; "Move cookie-related functionalty from Guiders.js to GuidedTour." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [02:34:08] New review: Mattflaschen; "Depends on https://gerrit.wikimedia.org/r/#/c/65004 ." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65005 [02:35:16] New patchset: Mwjames; "Move test registration (PHPUnit, QUnit) into separate files" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65006 [03:10:29] New patchset: RAN1; "CSS built-in, RM jQuery, use ResourceLoader" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64952 [03:20:30] New patchset: Mwjames; "Deprecate smwfIsSemanticsProcessed in favour of a SMW\NamespaceExaminer class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/65008 [03:26:36] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [03:27:02] New review: Mattflaschen; "See previous comments." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [03:46:56] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64911 [03:49:58] New patchset: Mwjames; "SMW\CacheHelper" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64476 [04:11:37] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64844 [04:12:52] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [04:31:50] New patchset: Mattflaschen; "Add wgIsProbablyEditable for editability based on quickUserCan." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [04:33:29] New patchset: Mattflaschen; "Add wgIsProbablyEditable for editability based on quickUserCan." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65009 [04:42:55] New review: Mattflaschen; "Looks good. Minor issues, mostly since I've added some helper methods since you pushed this." [mediawiki/extensions/GuidedTour] (master) C: -1; - https://gerrit.wikimedia.org/r/64981 [04:44:29] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [04:46:02] New review: Yuvipanda; "(PatchStalker Note: Steven can push to this on GitHub, and it'll auto update. However, if someone ma..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [04:46:38] santhosh: do you want to enable the GitHub PR workflow for any of the language engineering repos? [04:46:45] I could use the testing :D [05:18:37] New patchset: Liangent; "Comment matching should be non-greedy." [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/65010 [05:21:52] New review: FastLizard4; "Review of source code looks good, now testing and verifying." [mediawiki/extensions/CommunityTwitter] (master) C: 2; - https://gerrit.wikimedia.org/r/64952 [05:22:19] New patchset: Liangent; "Comment matching should be non-greedy." [mediawiki/extensions/Gadgets] (master) - https://gerrit.wikimedia.org/r/65010 [05:25:22] New review: FastLizard4; "Tests come out good, change approved for merging." [mediawiki/extensions/CommunityTwitter] (master); V: 2 - https://gerrit.wikimedia.org/r/64952 [05:25:23] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64952 [05:27:44] New review: Mattflaschen; "+2, looks fine." [mediawiki/extensions/Math] (master) C: 2; - https://gerrit.wikimedia.org/r/64522 [05:28:01] Change merged: jenkins-bot; [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64522 [05:30:52] New patchset: FastLizard4; "Bump to version 0.3.1, add "others" to the author credits." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65011 [05:31:41] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65011 [05:40:40] New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/65041 [05:42:03] New review: Siebrand; "This wasn't supposed to come from me. There were some problems with the repo on translatewiki.net, a..." [mediawiki/extensions/FundraisingEmailUnsubscribe] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/65041 [05:42:03] Change merged: Siebrand; [mediawiki/extensions/FundraisingEmailUnsubscribe] (master) - https://gerrit.wikimedia.org/r/65041 [06:09:04] New patchset: Aaron Schulz; "Allow server selection when running sql.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [06:36:45] Change abandoned: Yuvipanda; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64980 [06:37:01] New patchset: SuchABot; "Apologies for the spam" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65091 [06:37:18] New patchset: Santhosh; "Filter group from Special:LanguageStats when group is not a priority language" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65092 [06:38:09] Change abandoned: Yuvipanda; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65091 [06:38:47] New patchset: SuchABot; "Apologies for the spam" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65093 [06:39:03] Change abandoned: Yuvipanda; "(no reason)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/65093 [06:47:08] New patchset: Santhosh; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [06:49:29] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64914 [07:07:28] New review: Nischayn22; "Can someone have another look at this please :)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/45951 [07:13:25] New review: Santhosh; "we need to remove the messages related to this also." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64976 [07:17:12] New patchset: Rfaulk; "fix. Pass args.force to _sync in revert method." [sartoris] (master) - https://gerrit.wikimedia.org/r/65094 [07:17:12] New patchset: Rfaulk; "fix. Ensure lock file is created in revert.." [sartoris] (master) - https://gerrit.wikimedia.org/r/65095 [07:17:12] New patchset: Rfaulk; "fix. No need to remove lock in revert, done in _sync call." [sartoris] (master) - https://gerrit.wikimedia.org/r/65096 [07:17:39] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65094 [07:17:59] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65095 [07:18:16] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/65096 [07:28:25] New patchset: Aaron Schulz; "Reset the error string in LoadBalancer::getConnection() to avoid it crufting up." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65097 [07:35:39] New patchset: Aaron Schulz; "[Database] Improved DatabaseMysql::masterPosWait() performance by caching the position." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64996 [07:54:19] New patchset: Nischayn22; "fix regression from I84641dd92581de5bb546663ec60652d60f82cf65" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65098 [07:55:21] Change merged: Nischayn22; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65098 [08:03:48] New review: TheDJ; "I don't fully understand the question I think. This code isn't merged yet, so if you are meaning to ..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [08:11:07] New review: TheDJ; "I've also been thinking about submodules." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64522 [08:39:19] New review: Santhosh; "my understanding: It should be same as clicking on ULS trigger(cog or uls icon)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [09:03:14] New patchset: Nikerabbit; "Accepting and rejecting users by age" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65099 [09:35:13] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64926 [09:47:22] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [09:56:06] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [10:02:56] New patchset: Jiabao; "Show message when user successfully changed password. Made amendments according to code review from iAlex. Now uses returnToMain() when password changed. Removed not reused doReturnTo function and moved the statements to when canceled." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [10:08:07] New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [10:09:53] Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/54323 [10:10:08] New review: Siebrand; "CR+2, please?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [10:10:42] New patchset: Jiabao; "Show message when user successfully changed password. Made amendments according to code review from iAlex. Now uses returnToMain() when password changed. Removed not reused doReturnTo function and moved the statements to when canceled. fixed using spaces " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [10:11:11] New patchset: Santhosh; "Reset the dirty bit after preferences are saved." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65101 [10:13:02] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63449 [10:14:32] New patchset: Jiabao; "Show message when user successfully changed password. Made amendments according to code review from iAlex. Now uses returnToMain() when password changed. Removed not reused doReturnTo function and moved the statements to when canceled. fixed using spaces " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [10:15:25] New review: Siebrand; "L10n review and a bit of i18n based on changes in the i18n.php file. See inline comments for details." [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/59156 [10:19:45] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [10:30:22] Change abandoned: Nischayn22; "Abandoning in favor of https://gerrit.wikimedia.org/r/#/c/65102/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47854 [10:30:31] New patchset: Nischayn22; "hook to intercept upload_by_url" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [11:10:54] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [11:24:19] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [11:27:27] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [11:28:20] Change merged: jenkins-bot; [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [11:45:12] New patchset: Nischayn22; "adds blacklisting feature for flickr in backend" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/65109 [11:47:23] New review: Nischayn22; "https://gerrit.wikimedia.org/r/#/c/65109/ is the corresponding change in UploadWizard" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65102 [11:57:27] Change abandoned: Yurik; "(no reason)" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64966 [12:05:01] New patchset: Yurik; "Updated Zero ext to latest" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/65111 [12:06:25] New patchset: Yurik; "Updated Zero ext to latest" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65112 [12:14:27] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/65111 [12:14:36] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65112 [12:16:15] New review: Mormegil; "This is wrong. Short-date format (if really needed) should be implemented the same way as all others..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [12:20:08] New patchset: Santhosh; "Access i18n json files from same domain for IE8 and IE9" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64918 [13:02:29] New patchset: Orenhe; "Fix tab navigation issue on collapsible navigation menus" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/65115 [13:04:13] New patchset: Hoo man; "Fix the subtitle for the AbuseFilter history view" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/58042 [13:37:59] New patchset: Orenhe; "Fix tab navigation issue on collapsible navigation menus" [mediawiki/extensions/Vector] (master) - https://gerrit.wikimedia.org/r/65115 [14:00:48] New review: Hashar; "(1 comment)" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/64594 [14:02:10] New review: CSteipp; "That seems like a sane way to do this. There shouldn't be a way to slip xss through the 'valid' checks." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/58042 [14:02:16] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/58042 [14:04:59] New patchset: RAN1; "JS function syntax change to match conventions" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/65119 [14:07:19] New review: Hashar; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [14:19:09] New patchset: Hashar; "User::getDefaultOptions duplicate call" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65121 [14:19:19] ^^^^ dangerously easy micro patch [14:33:23] New patchset: Hoo man; "Log account autocreation on manual login" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [14:37:30] New patchset: Tobias Gritschacher; "Fixed @covers tags" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65126 [14:38:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/65126 [14:38:39] New patchset: Hoo man; "Log account autocreation on manual login" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [14:39:24] New review: Hoo man; "Fixed a typo in the comment" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/65123 [14:42:18] hashar: +2ed it, as it's not blowing up... on first sight :D [14:42:31] hoo: :-] [14:43:58] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65121 [14:44:49] hashar: I've got an equally easy one https://gerrit.wikimedia.org/r/63841 :P [14:46:15] ah TitleBlacklist [14:47:50] New review: CSteipp; "I think that works. Need to test, but looks good otherwise." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/65123 [14:47:56] We used to have a job in jenkins running those unit tests... but it seems to have disappeared into a blackhole [14:48:00] Change merged: jenkins-bot; [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/63841 [14:49:17] hoo: ah yeah [14:49:21] hoo: let me check that [14:49:34] hoo: the job is still there but they are not kicked for you [14:50:48] so you are whitelisted [14:50:49] hmm [14:57:44] New patchset: Hashar; "Jenkins job validation (DO NOT SUBMIT)" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/65129 [16:26:49] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [16:26:55] New patchset: EBernhardson; "Talk page links in notifications should not follow redirects" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [16:42:14] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64823 [16:54:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=48741 [16:55:14] This is really weird... There is no 'dif' function [16:55:28] 'must be an instance of @X@'? [16:55:45] there's an unprintable character in there (special meaning on irc I think) [16:56:07] php issue? [16:58:56] TimStarling, ^ [17:00:58] Also why was the exception shown to the user? [17:10:15] New patchset: Umherirrender; "Add ss_active_users in SiteStats::isSane" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65133 [17:31:27] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -2; - https://gerrit.wikimedia.org/r/64823 [17:32:45] New patchset: Umherirrender; "Avoid changing the global on special pages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65136 [17:35:03] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:35:41] Reedy, any idea what's going wrong with that flaggedrevs error? [17:36:18] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:42:47] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:50:05] New review: Alex Monk; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/65109 [17:50:08] New patchset: Clancer; "(bug 34496) Added line to watchlist tooltip displaying the difference in characters more/less. This makes the user interface more user friendly not everyone knows that a character is one byte." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65139 [17:51:24] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64983 [17:53:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64982 [17:56:13] Change abandoned: Kaldari; "no census" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61065 [17:56:27] New review: Kaldari; "or consensus even." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61065 [17:57:36] New patchset: Clancer; "(bug 34496) Added line to watchlist tooltip displaying the difference in characters more/less. This makes the user interface more user friendly not everyone knows that a character is one byte. - added temporary variable to reduce line length - removed whi" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65139 [17:57:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65133 [18:08:41] New patchset: Kipcool; "server-side table sorting, instead of client-side" [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65140 [18:08:48] New patchset: Bsitu; "Removing prefix exception for HTMLCheckMatrix" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65141 [18:09:03] Change merged: Kipcool; [mediawiki/extensions/WikiLexicalData] (master) - https://gerrit.wikimedia.org/r/65140 [18:13:17] New patchset: Bsitu; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65142 [18:14:04] New review: Kaldari; "Yeah, we need to add tag support to mediawiki.jqueryMsg.js. Should be easy to do however. Just n..." [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/59602 [18:16:53] New patchset: Foxtrott; "bugfix (TypeError: setting a property that has only a getter)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/65143 [18:18:31] New patchset: Foxtrott; "bugfix (TypeError: setting a property that has only a getter)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/65143 [18:18:52] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [18:19:06] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65141 [18:19:28] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/65143 [18:20:37] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65142 [18:22:22] Tomasz Finc [18:24:16] New review: Parent5446; "Haven't tested since I'm at the airport, but code looks good." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64844 [18:26:30] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [18:30:25] developers help me. how to configure m. subdomain with mobile frontend on apache. i am having an error [18:34:13] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [18:36:12] New review: Mattflaschen; "It's better to enable it just for allowedHtmlAttributesByElement. I.E:" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602 [18:38:46] New patchset: Umherirrender; "Avoid select/writes for anon user in WatchedItem" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65145 [18:55:47] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [18:57:27] New patchset: Pastakhov; "fix jenkins javascript errors (version 0.4.2)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/65144 [18:58:56] New patchset: Mattflaschen; "Remove split test (everyone is test) and bump version to 3." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65146 [19:00:04] New patchset: Kaldari; "Slightly reducing badge and alert sizes" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65147 [19:06:24] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/65147 [19:13:37] New patchset: Kaldari; "Update Echo to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65149 [19:13:52] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65149 [19:22:26] New review: Mattflaschen; "No, I'm asking if you have discussed this change with the community." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [19:28:06] New patchset: Adamw; "Trim whitespace from CSV cells" [wikimedia/fundraising/crm] (master) - https://gerrit.wikimedia.org/r/65150 [19:47:26] New review: Mattflaschen; "This is on piramido for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65146 [19:49:18] New review: Spage; "(1 comment)" [mediawiki/extensions/GettingStarted] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/65146 [19:49:25] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/65146 [19:49:30] Change abandoned: Mattflaschen; "Obsoleted by f9481040d5a229ccdbcda2c7f8cba87fe87501af" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63256 [20:05:33] New patchset: Mattflaschen; "Bump GettingStarted for E3 deployment." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65152 [20:07:15] New patchset: Mattflaschen; "Bump GuidedTour for E3 deployment" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65153 [20:08:27] Yippie, build fixed! [20:08:27] Project browsertests-en.wikipedia.org-linux-chrome build #76: FIXED in 3 min 24 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/76/ [20:12:46] New review: Spage; "OK, latest rev" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/65152 [20:15:20] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65152 [20:17:02] New review: Spage; "OK latest rev." [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/65153 [20:19:36] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/65153 [20:26:49] New patchset: TheDJ; "mediawiki.api: add postWithToken and getToken" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [20:39:47] New review: TheDJ; "Are you sure this is required ? I'm reading the bugreport and getting the feeling that simply removi..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64851 [20:42:59] who's the best person to talk to about jenkins-run phpunit tests? [20:43:09] Reedy: ^? [20:43:50] Antoine probably [20:43:55] im getting a merge failure due to a fatal error when MobileFrontend unit tests are run: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-testextensions-master/898/console [20:44:10] Reedy: any idea when he'll be on? [20:44:21] I'm guessing you're not in ams? [20:44:28] heh nope [20:44:35] and he probably is [20:44:45] and everyone's probably out partying right now [20:44:50] right. [20:45:38] I presume the class is in the autoloader lists? [20:45:53] Reedy: yeah, it's defined in a UnitTestList function [20:46:27] seems to work fine for me locally [20:46:41] New review: TheDJ; "Tested and confirmed" [mediawiki/extensions/UploadWizard] (master) C: 2; - https://gerrit.wikimedia.org/r/64855 [20:46:58] Change merged: jenkins-bot; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64855 [20:48:32] * thedj doing CR in the train to ams :D [20:49:52] thedj: on the phone? [20:50:12] paired [20:52:19] thedj: O my goodness you're coming!? [20:53:10] of course. home turf (-2,5 hours traveltime) [21:02:39] New patchset: Nikerabbit; "Accepting and rejecting users by age" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/65099 [21:06:56] New patchset: Mattflaschen; "Check for multiple arguments, tweak error message, add test." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/65154 [21:07:19] thedj[wo1k]: You gain 2.5 hours by coming to Amsterdam? [21:20:37] New patchset: Aaron Schulz; "Added a --profiler option to all maintenance scripts." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65158 [21:23:35] New review: Nikerabbit; "I'm not sure if it is caused by this patchset or if this is an existing problem:" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65101 [21:33:27] New review: Nemo bis; "@Nikerabbit, on mw.o those steps work as expected as of now" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/65101 [21:38:03] question regarding internal urls generated via wiki text containing a query string and a fragment: is it possible? Or do i need to generate an "external" url and wrap it with [/some/url?foo=bar#Baz link text] ? [21:39:12] the url itself comes from a Title object and one of the 42 getSomethingURL functions on it [21:40:16] that's the way we do it [21:41:08] ok, i suppose the documentation that keeps calling [ ] and plainlinks as being explicitly for external urls had me think there was a different wy for internal. Hacks upon hacks :) [21:41:33] Nikerabbit: thanks [21:49:35] Goddamnit [21:50:19] No wonder editing WikiText in our standard textarea feels so uncomfortable, unfriendly, and so different from the output. [21:50:52] We let the browser go and use a serif font and potentially different font size. [21:51:21] The text style of text inside our editor is absolutely nothing like the text it is outputted as. [21:52:32] Things become SO much more readable when I simply tell it to inherit font-family and font-size. [22:00:27] New patchset: Aaron Schulz; "Respect content model for viewing stable versions." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/65159 [22:06:27] New patchset: Aaron Schulz; "Respect content model for viewing stable versions." [mediawiki/extensions/FlaggedRevs] (master) - https://gerrit.wikimedia.org/r/65159 [22:07:55] does anyone have experience working with wikihadoop? [22:10:38] New patchset: EBernhardson; "Talk page links in notifications should not follow redirects" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [22:14:58] New review: EBernhardson; "Additionally after checking with -dev on IRC the agreement seems to be the proper way to link to a l..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [22:19:48] Heh PubSubHubbub supports sounds like an interesting alternative to using anything like UDP for IRC notifications. [22:20:09] ...well, I guess the bot would need a http server. [22:21:48] New review: Nischayn22; "Ah! I didn't clearly understand the problem having not worked much with Safari." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64851 [22:23:25] Although I suppose for that we might want to create an alternate Atom feed that does revisions instead of diffs. [22:37:07] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [22:38:03] is there a way of getting the number of page's sections either in PHP or JS, without using an API request? [22:38:07] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [22:41:17] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [22:43:22] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [22:45:38] New patchset: EBernhardson; "Talk page links in notifications should not follow redirects" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [23:08:28] Project browsertests-sandbox.translatewiki.net-linux-chrome build #54: FAILURE in 1 min 53 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/54/ [23:27:12] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [23:27:12] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [23:28:54] New review: Mattflaschen; "The inline comments are remaining issues from earlier patch sets." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [23:29:55] New patchset: Amire80; "Show a warning on page deletion if a page is linked to" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/65162 [23:38:35] New review: Mwjames; "I need this rather quickly reviewed as it blocks me from other stuff." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64938 [23:50:09] New review: Mattflaschen; "Good idea, however I think we should tweak the config. See http://docs.mathjax.org/en/latest/option..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/64523 [23:58:26] New review: Kaldari; "Actually, it looks like mw.message().text() (and thus mw.msg()) has gone back to allowing arbitrary ..." [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/59602