[00:01:49] New patchset: Mwalker; "Updating of AmazonAudit for PEP-8 and some refactoring" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/64861 [00:03:07] Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64868 [00:06:14] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64302 [00:07:52] New patchset: Adamw; "GatewayAdapter::isSupported" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64872 [00:11:52] Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64303 [00:13:11] New patchset: Adamw; "move getGatewayClass into GatewayAdapter" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64873 [00:13:42] !g 123 [00:13:42] https://gerrit.wikimedia.org/r/#q,123,n,z [00:14:06] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [00:14:15] New patchset: Adamw; "getGlobal can be called for multiple adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64874 [00:15:46] New patchset: Ryan Lane; "Up OpenStackManager version for sudo/secgroup fix" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64875 [00:16:04] http://bots.wmflabs.org/~wm-bot/dump/%23wikimedia-dev.htm [00:16:04] Krinkle: Invalid arguments [00:19:14] Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64875 [00:21:38] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [00:22:19] New patchset: Adamw; "DataValidator can use boss's methods" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64323 [00:22:56] New patchset: Kaldari; "Adding diff link to talk page notifications for archive and email" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [00:23:13] Krinkle, is the 'wg' prefix of many JS config variables an obsolete reference to "window globals" or a confused borrowing of "Wikipedia global" from PHP? [00:23:23] New review: Kaldari; "Need to get final implementation details and approval from Vibha" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64876 [00:23:55] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [00:24:11] spagewmf: PHP conf, because they used to be just a subset of php globals [00:24:32] spagewmf: Once mw.config is no longer legacy global we can drop the prefix of all mw.config values that aren't php globals. [00:25:01] (with back. compat of course) [00:25:26] Or rather, mw.config shouldn't contain non-config in the first place [00:25:34] they belong in mw.title or mw.page etc. [00:25:37] mw.user etc. [00:25:57] https://bugzilla.wikimedia.org/39813 [00:26:02] Krinkle thanks. I think extensions that set JS vars shouldn't use "wg" prefix as they're neither PHP globals nor JS globals. How about a 'wsv' for Wiki server variable, or just 'wv' ? [00:26:14] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [00:26:26] spagewmf: No, keep using wg for consistency. There's no reason to invent another pattern. [00:26:40] spagewmf: Also, "nor JS globals" ? [00:26:42] explain [00:26:47] mw.config are js globals [00:26:53] New review: Kaldari; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [00:27:06] Krinkle, not for me, I set wgLegacyJavaScript false. [00:27:35] sure, but they're global for some. Dropping the prefix will increase likely hood of colision with other code [00:27:56] Anyone wants to add me to the "Reviewer" or "Coder" user group on MW.org? [00:28:23] hoo|away: SVN is locked, or are you reviewing code for pywikipedia? [00:28:42] Krinkle: I just want to review revisions... and theses groups hold the rights to do taht [00:28:44] (and sysop) [00:28:57] Coder user group is for Special:Code review [00:29:00] But I'm already GS, so I don't need a local +sysop [00:30:08] Krinkle, yes it would have to be a new one. The downside of extensions using 'wg' for JS variables they set is someone naively does mw.config.get( 'wgUserId' ) or 'wgPostEdit and then it later fails on some page that doesn't load the extension that sends it. But I agree there's a cost to introducing a new naming pattern. [00:31:04] spagewmf: I don't see how that potential confusion would be solved by using a different prefix? [00:31:18] Krenair: Want to give me +reviewer on MW.org? [00:31:19] mw.config always contained some values conditionally, that's nothing new [00:31:29] hoo|away: Reviewer can't be granted by sysops [00:31:32] only by stewards it seems [00:31:35] I am unable to grant it [00:31:47] Krinkle: 'crats can grant it... [00:31:47] New patchset: Mwalker; "Allowing recovery of country from Amazon transactions" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/64877 [00:31:52] Yes [00:32:00] Sorry, that's what I meant, yes. [00:33:18] Krinkle, 'wgXxx' would mean OutputPage.php sent it, 'wsvXxx" wouldn't imply it. But you're right, you have to understand who's supplying every config variable you use. Proposal withdrawn :) [00:33:20] Most people active on MW.org are probably local sysops [00:33:50] New patchset: Bsitu; "Add EventLogging to capture Echo preference change" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [00:34:16] "Being a developer (someone with commit access who uses it to maintain code that runs on Wikimedia sites) automatically entitles you to at least administrator status" [00:34:21] spagewmf: Even before mw.config some extensions added wg vars to js. And afaik it always goes through OutputPage, even if an extension adds it, but I know what you mean, you mean not predefined in OutputPage [00:34:53] So... anyone who wants to give me that flag? :P [00:35:05] New patchset: Adamw; "Merge branch 'review/adamw/64348' into review/adamw/63932" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64431 [00:35:22] spagewmf: So yes I agree and I would love to clean up mw.config to only contain stuff that reflect php globals and are present on every page. The rest should go into mw.title,page,user and extension stuff in their own structures. [00:35:26] Susan: ^ [00:36:58] awight: Perhaps rebase one of those patch sets to simply depend on the other? The merge commit and conflict resolution seems redundant considering both changes are still pending and owned by you. [00:38:15] Krinkle: hehe thanks for noticing the mini purgatory I was preparing for myself ;) The issue is that I'd like to leave my coworkers the choice to merge one or the other first... [00:39:17] awight: interesting [00:39:44] ... and since I'm taking off for a few weeks, at an undetermined date... I thought I would do the nasty work of conflict resolution up-front [00:42:30] New patchset: Jqnatividad; "set SMWDIProperty show flag of subobjects to false to suppress display in factbox. Doesn't make sense to show subobjects in factbox since the display name is non-unique." [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64878 [00:46:55] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [00:49:49] New patchset: Adamw; "GatewayAdapter::isSupported" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64872 [00:50:01] New patchset: Adamw; "move getGatewayClass into GatewayAdapter" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64873 [00:50:11] New patchset: Adamw; "getGlobal can be called for multiple adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64874 [00:54:44] New review: Adamw; "Ugh, there is one more piece of the patch, so that the orphan script creates DonationData passing th..." [mediawiki/extensions/DonationInterface] (master) C: -2; - https://gerrit.wikimedia.org/r/64323 [00:55:43] New patchset: Adamw; "WIP: More DI core changes to support DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64440 [00:56:36] New patchset: Adamw; "DataValidator can use boss's methods" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64323 [00:56:48] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [00:56:56] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [00:59:59] New review: Adamw; "Just to be a prig, PEP-8 definitely doesn't recommend the underscore-prefixed global thing, but this..." [wikimedia/fundraising/tools] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64861 [00:59:59] Change merged: Adamw; [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/64861 [01:00:42] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [01:10:42] hoo|away: Sure, what's your username? [01:10:50] hoo|away: And what rights would you like? Just admin? [01:11:30] Susan: Jasper Deng already gave me the 'Reviewer' flag... that's basically enough, as I can use my global rights on MediaWiki.org ;) [01:11:45] Okay. [01:11:59] I'll give you adminship explicitly as well. [01:12:06] Unless you object. [01:13:30] Yeah, this is silly. I'm not even sure why we have a reviewer group. [01:15:40] Why doesn't the [[+2]] page have the list of people with +2? [01:15:41] Rage. [01:17:03] Where is that stored? [01:17:07] It's not the members list of mediawiki/core... [01:17:37] Susan: The list of +2er for core is in gerrit only AFAIK [01:18:04] Where is the +2 list? [01:18:07] Not to talk about extensions [01:18:18] https://gerrit.wikimedia.org/r/#/admin/groups/119,members [01:18:21] I'm lost there. [01:18:30] Susan: https://gerrit.wikimedia.org/r/#/admin/groups/11,members [01:18:45] Bless you. [01:18:46] Okay. [01:18:48] Sec. [01:18:52] I'm going to fix all of mediawiki.org. [01:19:04] \o/ [01:20:10] I don't object to adminship... do whatever you want as long as it's not less than I have know :P [01:21:42] https://www.mediawiki.org/wiki/Gerrit/%2B2#Membership [01:21:44] There, fixed that. [01:21:50] I thought you had +2. [01:21:56] You're certainly trusted. [01:23:56] There, fixed. [01:23:59] :-) [01:23:59] Susan: I have :P [01:24:13] I made you an admin and bureaucrat. [01:24:51] hoo|away: Why aren't you working for the Wikimedia Foundation? :-) [01:25:57] Well... I do, I just don't get paid :P [01:27:08] https://www.mediawiki.org/wiki/Developers/Maintainers could need love as well... it for example doesn't even know about Wikibase [01:27:45] Eep. [01:29:15] https://www.mediawiki.org/wiki/Talk:Developers/Maintainers#Out_of_date [01:48:31] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [01:55:23] New review: PleaseStand; "You might as well fix some of the stylistic issues. At least get this to pass PHPCS." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64866 [01:58:51] New review: PleaseStand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [02:16:32] New patchset: Ori.livneh; "Slight refactor" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63798 [03:07:14] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/64469 [03:10:44] New review: Ori.livneh; "138 days since patch submission" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/42089 [03:27:06] New review: MZMcBride; "Vibha isn't listed as a reviewer of this changeset currently." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64876 [03:46:49] New patchset: coren; "Fix the bugfix so that it isn't broken." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64880 [04:10:10] New patchset: Santhosh; "Better way to fix jslint warnings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64566 [04:11:36] New patchset: Andrew Bogott; "Fix the bugfix so that it isn't broken." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64880 [04:13:08] New patchset: Santhosh; "Better way to fix jslint warnings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64566 [04:13:50] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64566 [04:26:39] New patchset: Andrew Bogott; "Don't insert duplicate FQDNs for 'all' policies." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64880 [04:33:06] Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64880 [04:49:47] New patchset: Santhosh; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [04:52:17] New patchset: Santhosh; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [04:56:21] New patchset: Spage; "Log ?campaign=someName" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [05:33:42] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [05:36:17] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [05:46:33] New review: Mattflaschen; "Thanks for the improvements. I noted some follow-ups and one new issue. Namely, I don't see any re..." [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/63829 [06:00:20] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64882 [06:25:06] New patchset: Liangent; "(bug 48683) Use a correct way to create titles from given ns and text" [mediawiki/extensions/WikiLove] (master) - https://gerrit.wikimedia.org/r/64883 [06:26:52] marktraceur: Hey [06:43:22] New review: Matmarex; "Thank you, this looks great, just one more minor comment." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62005 [06:43:22] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64837 [06:44:35] New review: Nikerabbit; "Per comments on PS1" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/63848 [06:45:25] New review: Nikerabbit; "Use separate css file or do the opposite, hide by default and show with JavaScript." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64859 [06:51:28] New review: Matmarex; "Side-note: this could make use of the new mediaWiki.hook feature, firing a hook when a new page is l..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [07:24:18] New review: Foxtrott; "(1 comment)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64837 [07:27:51] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [07:45:52] New patchset: Nikerabbit; "Revert "Add a MediaWiki preference for enabling ULS IME"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [07:46:06] New patchset: Nikerabbit; "Revert "Add a MediaWiki preference for enabling ULS IME"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [07:46:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [07:50:50] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [07:52:07] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [07:53:54] New patchset: Nikerabbit; "mediawiki.api: add postWithToken and getToken" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [07:54:47] New review: Nikerabbit; "PS3 fixed commit message and documentation only." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [07:58:15] New review: Nikerabbit; "The css update doesn't seem to be included in this." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64882 [08:04:40] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64882 [08:05:26] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55273 [08:10:24] New patchset: Amire80; "Add fonts for Syriac Armaic languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [08:10:54] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [08:33:24] New patchset: Amire80; "Hide the ULS trigger for users who disabled JS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64859 [08:38:51] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64882 [08:49:48] New patchset: Amire80; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [08:50:16] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [08:50:35] New patchset: Amire80; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [08:52:11] New patchset: Amire80; "Provide disable input tools option in IME menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [08:59:42] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [09:01:21] New patchset: J; "code cleanup, remove tabs" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64912 [09:02:18] New review: J; "I would rather fix all tabs in a new commit:" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/64625 [09:06:56] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [09:08:13] New patchset: J; "add unique constraint on transcode name, key" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/57536 [09:11:08] New patchset: Hashar; "overhaul maintenance/mwdocgen.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [09:13:44] New patchset: J; "only count failed transcodes as failed" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64913 [09:13:48] New review: Hashar; "Congratulations !" [integration/zuul-config] (master) C: 2; - https://gerrit.wikimedia.org/r/64871 [09:13:48] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64871 [09:17:02] New patchset: Nikerabbit; "Optimize images" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64914 [09:19:31] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [09:28:59] New patchset: Nikerabbit; "Define a configuration variable" [mediawiki/extensions/InviteSignup] (master) - https://gerrit.wikimedia.org/r/64916 [09:31:42] New patchset: Hashar; "LinkCache singleton can now be altered" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64564 [09:31:42] New patchset: Hashar; "test: inject autoloader in Maintenance class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64568 [09:31:54] New patchset: Hashar; "test: LinkCache no more rely on a database access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [09:36:35] New patchset: Hashar; "LinkCache singleton can now be altered" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64564 [09:36:35] New patchset: Hashar; "test: inject autoloader in Maintenance class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64568 [09:36:36] New patchset: Hashar; "test: LinkCache no more rely on a database access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [09:44:30] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [09:49:27] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:04:14] New patchset: Njw; "Add localisation documentation and update the description." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [10:06:27] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:08:08] New review: Njw; "Apologies for the churn. This update removes the extracontent messages from qqq, as recommended by h..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [10:30:27] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:35:31] New review: Matmarex; "I really need to set up a testing environment locally..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:38:25] MatmaRex, try Vagrant: https://www.mediawiki.org/wiki/MediaWiki-Vagrant [10:38:40] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:39:56] New review: Mattflaschen; "You may want to update the description in DefaultSettings. Currently, that focuses on the database ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [10:40:04] superm401: i tried it and it filled my C: disk before i killed the installation process :) [10:40:20] MatmaRex, oh, are you using FAT32? [10:40:26] I haven't ried it on Windows. [10:40:37] superm401: although it is apparently possible to make it write its files somewhere else [10:41:05] i'm on windows, but no, my C: disk is just purposefully small, there's nothing there but Windows itself [10:41:51] and vagrant popped some 3 GB of files in there [10:42:07] I see, yeah, you're probably right it's configurable, but I don't know how off hand. [10:42:20] i've got it saved somewhere [10:42:40] ah, V+2, at last. [10:42:50] superm401: want to review this more thoroughly? :) [10:43:01] i'll fix the docs in a second [10:43:18] MatmaRex, it's on my list now. I'll try to later (didn't see anything terrible, though it is a bit wonky). [10:43:24] Then again everything involving the parser is. [10:44:17] i tried to keep all other HTML apart from the style attribute intact [10:44:28] maybe i tried too hard, it'd be much easier to just kill all attributes [10:44:42] as in, 30 lines of code changes less easier [10:44:53] Right, it looked correct, though it took me a second to get the callback (hand't seen that before). [10:45:09] i think anonymous functions are PHP 5.3+ [10:45:11] or 5.2+ [10:45:12] Also, it could lead to false positives (e.g. display just happens to appear in a URL). [10:45:15] Right, I know that. [10:45:21] Just handn't seen that usage. [10:45:27] I.E. removeHtmlTags [10:45:41] But there's no way to get around the false positive issue without a full CSS parser. [11:03:25] superm401: sorry, i had to leave for a while [11:03:37] superm401: we already reject all url() values in all inline CSS [11:04:08] Oh, okay. [11:04:11] superm401: so this could possibly appear in a string somewhere [11:04:20] There are probably still obscure cases it does wrong, but like I said it's probably good enough. [11:04:23] superm401: but you can't use content:'asd' inline anyway [11:04:36] and i see no other reason to use any funky text in CSS strings [11:05:00] I've got to go too. Will try to re-review later. [11:07:26] New patchset: J; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [11:07:38] superm401: okay, thanks [11:09:56] New patchset: J; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [11:10:13] New review: J; "(1 comment)" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [11:12:04] New review: Matmarex; "CSteipp, can you review the Sanitizer changes?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [11:12:16] csteipp: ^ (if you don't read gerritmail :) ) [11:13:42] New patchset: Matmarex; "displaytitle: reject some CSS if $wgRestrictDisplayTitle set" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [11:50:45] New patchset: Santhosh; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [11:52:23] New patchset: Santhosh; "Update webfonts test page" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64519 [11:58:19] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64519 [12:21:42] New patchset: Santhosh; "Revert "Remove redundant focus handler"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64922 [12:37:02] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64535 [12:37:42] New patchset: Santhosh; "Donot show ULS in weird positions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64923 [12:39:53] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64536 [12:40:12] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64537 [12:46:58] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64922 [12:48:57] New patchset: Santhosh; "Donot show ULS in weird positions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64923 [12:50:01] New patchset: Amire80; "Do not show ULS in weird positions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64923 [12:50:27] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64923 [12:53:18] New review: Santhosh; "That was Bug: 48704" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64922 [13:04:31] New patchset: Amire80; "Hide the ULS trigger for users who disabled JS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64859 [13:10:45] New patchset: Amire80; "Update formatting." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63386 [13:13:32] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63386 [13:19:58] New patchset: Yaron Koren; "Fixes for new logarithmic tag cloud display" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64925 [13:19:59] New patchset: Amire80; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [13:21:14] New patchset: Hashar; "deprecate autoloading a class with mismatching case." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64926 [13:21:15] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64925 [13:30:15] New patchset: Amire80; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [13:43:08] New review: PleaseStand; "See file comment (regarding overriding getDbType) and inline comments." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64866 [13:45:50] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64926 [13:49:22] New review: Jeroen De Dauw; "Does what it says it does. I'm however not sure this makes sense from a user perspective as I'm not ..." [mediawiki/extensions/SemanticMediaWiki] (1.8.x) C: 1; - https://gerrit.wikimedia.org/r/64878 [13:56:03] Change merged: Mdale; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64912 [13:56:24] New patchset: Yaron Koren; "More fixes for removal of '_str' datatype in SMW 1.9" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64928 [14:04:22] New patchset: Anomie; "Do not returning external title in ApiPageSet::getRedirectTargets" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63288 [14:05:07] New review: Anomie; "So all this does is prevent the local version of the page from being added to the pageset when there..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63288 [14:07:18] New review: Anomie; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64512 [14:08:24] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63288 [14:09:59] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64926 [14:11:34] New patchset: J; "update TimedMediaTransformOutput options" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/64931 [14:14:35] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [14:14:43] New patchset: J; "disablecontrols should only be set once not per source" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64932 [14:15:36] New review: Platonides; "What about old serialized classes, stored in the db?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64926 [14:26:35] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [14:27:40] New patchset: Mwjames; "Fix fatal when predefined properties are no longer exists" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64938 [14:40:42] New review: Daniel Kinzler; "I'm still worried about the inconsistency with RecentChange::doMarkPatrolled, see my earlier comment. " [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [14:42:57] well this is a fun discovry [14:43:16] two entries in the revision table can have the same rev_text_id [14:43:24] I wonder if that's correct or a bug [14:47:34] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [14:50:21] * apergos grumbles in irritation [14:52:52] New patchset: Hashar; "User::saveOptions() optimization" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [14:59:06] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64911 [15:11:55] New patchset: Umherirrender; "Add page language to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64512 [15:12:48] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64512 [15:17:08] lets see, who's awake.... [15:17:18] Reedy: you still driving? [15:17:38] uh oh [15:17:47] uh so whoever is deploying later today [15:17:50] greg-g: ? [15:17:57] apergos: well, right now, no one, we have a blocker [15:17:59] apparently thereis' an issue with gadgets [15:18:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=48693 [15:18:03] ah you saw it [15:18:04] yep [15:18:11] ok (I promised I'd pass it on) [15:18:19] thanks apergos :) [15:18:23] yw [15:18:54] RoanKattouw: do you have time right now to debug that bug you sent me? Are there logs someone should look at? [15:19:08] Not right now [15:19:12] Maybe in a bit [15:20:04] k [15:20:04] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [15:20:16] RoanKattouw: thanks for the heads up and such, though. [15:20:36] OK I just finished writing the commit summary for an epic series of commits [15:20:40] I can poke at it for a bit now [15:20:46] New patchset: Adamw; "Finish moving validation out of GatewayForm and into the adapter." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63823 [15:20:53] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [15:21:40] RoanKattouw: hah, you're quick (and that sounds fun) :) [15:22:13] OK I can reproduce on enwiki for sure [15:22:27] Now I wonder why the heck this happens [15:24:23] Pulling down wmf4 locally to debug [15:25:14] * greg-g nods [15:25:20] New patchset: Adamw; "GatewayAdapter::isSupported" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64872 [15:25:27] New patchset: Adamw; "move getGatewayClass into GatewayAdapter" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64873 [15:25:32] New patchset: Adamw; "getGlobal can be called for multiple adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64874 [15:26:47] New patchset: Adamw; "WIP: More DI core changes to support DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64440 [15:27:22] New patchset: Adamw; "WIP: More DI core changes to support DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64440 [15:27:39] New patchset: Adamw; "WIP: DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [15:30:30] greg-g: OK it's at least isolated to Gadgets. Toggling boolean prefs in other tabs works correctly [15:30:45] * greg-g nods [15:34:00] Hmm this is slightly WMF-y [15:34:08] Gadgets apparently wasn't updated *at all* between wmf3 and wmf4 [15:34:14] Even i18n-bot kept quiet the whole time [15:34:26] Either that or someone updated it retroactively, I guess [15:34:38] hrmmmm [15:35:29] Reverted MaxSem's chaneg which looked suspicious but no dice [15:35:56] what's up? [15:36:36] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=48693 [15:37:55] don't see how my chage could've affected saving the prefs [15:38:05] Confirmed it's core breakage that somehow only affects Gadgets [15:38:19] Will bisect in core [15:40:05] New patchset: Adamw; "move getGatewayClass into GatewayAdapter" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64873 [15:41:59] It's even worse: the version of core that wmf4 was cut from doesn't have the bug [15:42:03] So it was introduced by a cherry-pick later [15:42:26] mebbe, wmf-specific changes? [15:42:43] s/changes/config/ [15:42:54] No, I can reproduce locally with wmf/1.22mwf4 [15:42:58] But not with wmf4-base [15:43:05] (=commit where wmf4 was branched) [15:43:11] And that's with WMF-specific patches included [15:43:32] local repro is good though....at least it's not a ResourceLoader heisenbug [15:43:57] Yeah [15:44:02] I'm bisecting within wmf4 now [15:44:25] are you guys still in SF? [15:45:32] RoanKattouw is in Nederlands, robla and I are still in SF (flight around 2pm pacific time0 [15:46:46] Gotcha [15:46:48] commit fe15256643a0a5b52372fd865ad15108a0f22454 [15:46:49] Author: ebernhardson [15:46:51] Date: Fri Apr 26 18:49:02 2013 -0700 [15:46:53] HTMLCheckMatrix support for forcing options on/off [15:48:03] Confirmed, that commit is the culprit [15:48:10] sweet [15:48:19] "new guy" :P [15:48:38] Wondering why that commit was cherry-picked in [15:49:14] https://gerrit.wikimedia.org/r/#/c/61163/ is the original [15:49:25] Written by EBernhardson, merged and cherry-picked by Kaldari [15:49:39] Going to try to reproduce the bug in master [15:49:47] * greg-g nods [15:51:08] Yup [15:51:13] Well that warrants a revert in master at least [15:51:19] I'm just afraid some extension somewhere relies on this [15:51:28] Echo, apparently [15:51:39] greg-g: I'll prepare reverts, but you'll need to ask them before deploying them [15:51:48] * greg-g nods [15:51:49] thans [15:51:51] +k [15:52:20] New patchset: Catrope; "Revert "HTMLCheckMatrix support for forcing options on/off"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64945 [15:53:04] The change could not be rebased due to a path conflict during merge. [15:53:43] grumble [15:53:56] MaxSem: Yeah I'm working on it [15:54:20] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64941 [15:57:21] just fyi, I just emailed fabrice to have him get someone to take a look at this [15:57:35] no one was responding in -ee ('tis still a bit early ;) ) [15:59:02] New patchset: Catrope; "Revert "HTMLCheckMatrix support for forcing options on/off"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64945 [16:00:28] New patchset: Catrope; "Revert "HTMLCheckMatrix support for forcing options on/off"" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64946 [16:00:37] greg-g: There, reverts for master and wmf4 ---^^ [16:00:44] (They're slightly different because someone did whitespace cleanup in between) [16:00:55] RoanKattouw: gotcha, thanks man [16:01:27] The one in master can probably just be merged because master is broken [16:01:29] Hallo. Tomorrow we are having a Hackathon in Tel-Aviv. Somewhat surprisingly, a couple attendees emailed me asking whether there are any interesting DevOps bugs to resolve. Can I point them anywhere? [16:01:33] But I have to run for dinner now [16:02:00] RoanKattouw_away: thanks much! [16:03:18] greg-g, want these deployed? [16:03:22] New patchset: Umherirrender; "Use square brackets instead of curly braces for char of a string" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64947 [16:03:46] * robla looks for something for aharoni [16:03:50] thanks [16:03:50] MaxSem: I'd love for someone from E2 to review it first.... [16:04:56] grr grrr [16:05:07] aharoni: not sure if anything here is suitable: https://www.mediawiki.org/wiki/Site_performance_and_architecture#Mysterious_future [16:05:14] I know, I just don't want to break Echo behind their backs... with Echo being Echo and all [16:05:15] my hotel's WiFi decided to troll me [16:05:23] aharoni: those may be too complicated and tied up in our infrastructure [16:06:05] aharoni: you might point them to Tools Labs / Labs in general, perhaps? [16:06:14] I know that there are a few bots / tools migrating... [16:06:45] "interesting" "DevOps" [16:06:54] :P [16:07:09] right, it is higly possible that that's not 'DevOps' :) [16:08:05] tool migration might ot be that excitig if you haven't writtten them [16:08:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64947 [16:12:45] MaxSem: true. [16:12:54] well, only thing I could think o [16:13:27] interesting: port XVO to Varnish [16:18:57] brb [16:26:39] alright, bbiab, going to do last minute packing and such. Fabrice has emaile dhis time, hopefully will be addressed in time for the 11am pacific MW window [16:26:42] * greg-g goes [16:29:07] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64859 [16:33:33] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64926 [16:33:50] New patchset: Anomie; "Add page language to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64512 [16:34:29] New review: Matmarex; "Caused bug 48693." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [16:35:56] New review: Kaldari; "We will need to revert the dependent Echo changes simultaneously." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64946 [16:37:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64512 [16:47:14] New patchset: Njw; "Ensure edit form doesn't clear the right floated meta" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64951 [16:49:52] MaxSem: anyidea why ApiSandbox fails for action=translateuser? [16:53:28] Nikerabbit, because it has no parameters:P [16:54:20] Nikerabbit, why wasn't it posssible to add it to meta=userinfo? [16:59:09] greg-g, ebernhardson is here:) [16:59:26] New patchset: RAN1; "CSS built-in, RM jQuery, use ResourceLoader" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64952 [17:01:34] New patchset: EBernhardson; "Fix for wrong prefixing of multi checkbox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [17:03:19] New patchset: EBernhardson; "Fix for wrong prefixing of multi checkbox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [17:12:38] is gerrit restarting or why is it giving me internal server errors? [17:13:01] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64878 [17:13:51] New patchset: Yurik; "Updating to last zero ext" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64954 [17:17:21] i'm rather unfamiliar with quoting database queries, so quick question: With PDO and mysql typically you would specify a type like PDO::PARAM_STR, PDO::PARAM_INT, with MW do i DatabaseBase::addQuotes to all variables? will that cause the db to interpret integers as strings and do bad query planning? [17:19:12] ebernhardson: If you have to think about quoting there's a 80% chance you're using the db classes wrong. [17:19:13] ebernhardson: it shouldn't do that, since it knows the types of columns [17:19:30] * MatmaRex is not an expert, though [17:19:30] ebernhardson, use the existing high-level abstractions [17:19:41] also what they both said ^ [17:19:59] tbh i'm unfamiliar with what higher level abstractions you have, you have a QueryBuilder or some such? [17:20:06] MatmaRex, it doesn't. however, mysql understands '3' in an int column just fine [17:20:26] MaxSem: yeah, that's what I and i think ebernhardson too meant :) [17:20:31] we have select(), update(), insert(), delete() [17:20:40] New review: FastLizard4; "Source code review looks good, +2. Will test and verify functionality later." [mediawiki/extensions/CommunityTwitter] (master) C: 2; - https://gerrit.wikimedia.org/r/64952 [17:20:42] so how to tell select to do 'foo >= 42' ? [17:20:49] it seems i have to pass that as a literal string [17:20:59] yup [17:21:01] but i could be totally missing something :) [17:21:05] That one for now does usually need the quoting. [17:21:09] addQuotes() in such situation [17:21:16] 'foo >= ' . $db->addQuotes( 42 ) [17:21:31] ok, so i was right orrigionaly, addQuotes and the db wont have issues, thanks! [17:21:56] Someone talked about ideas like special syntaxes for these [17:22:18] like: array( 'foo >=' => 42 ) [17:22:26] ewww :P [17:22:33] howabout 'foo >= :boundParameter' [17:22:39] fail i feel, young padawan [17:23:01] We don't do any fancy parsing right now. [17:23:25] And there's a risk of breaking real already quoted sql that's passed through. [17:23:46] prepared statements are fine, but it's either they or our DAL [17:23:54] using both would be insane [17:24:12] i would have to agree, trying to mis-mash the two would just be a cluster**** [17:24:28] DanielFriesen, how about array( array( 'foo', '>=', 42 ), ) [17:25:27] Krenair: Would require careful research, there's a strong chance we may already have special semantics for nested arrays like those. [17:25:52] ebernhardson, you can swear on the internet, it's okay :) [17:26:02] but it has me real name attached :P [17:26:21] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64954 [17:26:30] eg: It's possible array( array( 'A', 'B' ), array( 'C', 'D' ) ) already maps to `( A OR B ) AND ( C OR D )` [17:28:26] Error: 1054 Unknown column 'Array' in 'where clause' (localhost) [17:28:30] Doesn't seem like it DanielFriesen [17:28:33] Krenair: Other discussions have proposed things like `array( $db->op( 'foo', '>=', 'bar' ) )` or `array( 'foo' => $db->op( '>=', 'bar' ) )` (though op probably had a slightly longer name. [17:28:40] (That was > wfGetDB( DB_SLAVE )->select( 'user', 'user_name', array( array( 'user_id', '>=', '1' ) ) ); ) [17:29:15] New patchset: Yurik; "Updating to last zero ext" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64956 [17:29:50] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64956 [17:31:05] Krenair: Ok but we probably don't want to use it for that. [17:31:40] Krenair: From the looks of it we don't have a way to do complex and/or and we wouldn't want to make trouble for that possibility. [17:32:55] Right now I'm kind of leaning towards `array( 'foo' => $db->op( '>=', 'bar' ) )` [17:33:24] whatever it is, it needs to be something that is 'very hard to get wrong' [17:33:59] We probably don't need anything fancier than a single op method for data. [17:34:51] The names were probably longer when we discussed this in the past cause we were thinking about the case of a ( 'foo', '>=', 'bar' ) where 'bar' is actually a column name. [17:36:19] But we actually don't need to worry about that since you can just do 'foo => bar' without needing to quote since column names aren't user data. [17:36:37] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [17:36:57] Of course back then we were also trying to discuss how to fix a bigger problem. [17:37:06] The fact that we use != in sql. [17:40:23] alright, MaxSem ebernhardson RoanKattouw and Reedy, I'm about to go to the airport (leaving in about 30ish minutes). Everything looks like it is being taken care of by the email thread, but, RoanKattouw and/or Reedy can take care of ok'ing the final fix [17:41:00] New review: Amire80; "Mostly OK, but;" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64279 [17:41:09] * MaxSem sees no threads in his box [17:41:18] greg-g: Reedy seems to be on the road so I'll take it [17:41:43] * greg-g nods [17:41:55] wasn't sure if he'd be back for the MW window or not, heh. [17:42:14] thanks much RoanKattouw, I owe you a drink for this one... maybe tonight! [17:42:31] er, tomorrow night, whatever it is... now -> plane -> that night :) [17:42:34] Yea [17:42:37] For me that's tomorrow [17:42:59] * greg-g nods, today/tonight don't really exist for me, just "tomorrow night" which gets turned into "tonight" [17:43:08] put a line break in there to make it make sense [17:43:44] nothing needed for wikidata [17:43:59] cool [17:45:03] New review: Jdlrobson; "is this ready to go now?" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/63584 [17:45:59] New patchset: EBernhardson; "Fix for wrong prefixing of multi checkbox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [17:46:31] * greg-g goes to say goodbye to wife/Rowan [17:52:42] New patchset: Aaron Schulz; "Allow server selection when running sql.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [17:53:48] New patchset: Yurik; "Updating to last zero ext" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64961 [17:54:29] New patchset: Yurik; "Updating to last zero ext" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64962 [17:55:38] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64961 [17:56:00] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64962 [17:58:05] TrevorP|Away, Krinkle|detached when you are no longer away or detached could we look at getting https://gerrit.wikimedia.org/r/63584 wrapped up today/tomorrow - it's blocking a patch in mobile that I'm keen to get merged [17:58:23] Change abandoned: Catrope; "Has been fixed properly now" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64945 [17:58:32] Change abandoned: Catrope; "Has been fixed properly now" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64946 [18:01:53] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [18:03:21] jdlrobson: TrevorP|Away is getting on a plane today [18:04:11] RoanKattouw: ok so maybe tomorrow :) would be cool if you could look at it though.... [18:04:28] Tomrorrow he'll be jetlagged [18:04:35] I'll look at it in a minute [18:04:46] well, 30 really, I have a meeting [18:04:52] New patchset: Kaldari; "Fix for wrong prefixing of multi checkbox" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64963 [18:06:31] New patchset: Foxtrott; "fix bug (method name mis-spelled)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64964 [18:08:15] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [18:08:42] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64963 [18:10:30] New review: Amire80; "Looks OK, though I'd like to be sure about something: Is it supposed to open Display settings and po..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/64802 [18:10:46] MaxSem: soo. should we fix both issues? ;) [18:11:13] we should [18:11:27] though AS needs a rewrite [18:11:40] MaxSem: and ApiQueryUserInfo is not extensible with hooks [18:11:49] New review: Krinkle; "Minor style / safety issue: Keep the core defaults out of the skin defaults. The 'default' key in th..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63584 [18:11:56] what kind of rewrite are you looking for? [18:12:30] O RLY? not even APIAfterExecute? [18:13:16] ApiSandbox needs a JS overhaul, too many issues piling up [18:13:40] Nikerabbit: i updated my tooltips patch to use svg's as requested, but i'm not sure if i'm using it in the correct cross-browser manner. If you have a chance today or tomorrow could you review https://gerrit.wikimedia.org/r/#/c/61939/ again ? [18:16:26] New patchset: Jdlrobson; "Give skin more control of OutputPage modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [18:16:55] New review: Jdlrobson; "Yep that makes complete sense Krinkle." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [18:17:05] New review: Krinkle; "Is that the correct bug id? That regression was already fixed by reverting a previous commit. The pr..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [18:19:00] New review: Krinkle; "Aha, the revert was abandoned." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [18:23:14] New review: EBernhardson; "Basically, What happened is i combined code that looked entirely the same between HTMLCheckMatrix an..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64953 [18:24:20] MaxSem: hmm dunno how that works [18:24:35] it works [18:24:49] see ApiParseExtender in MF [18:27:28] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [18:35:41] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [18:40:37] New patchset: Pastakhov; "fix some bugs (version 0.4.1)" [mediawiki/extensions/MultiMaps] (master) - https://gerrit.wikimedia.org/r/52218 [18:40:37] New patchset: Jqnatividad; "set SMWDIProperty show flag of subobjects to false to suppress display in factbox. Doesn't make sense to show subobjects in factbox since the display name is non-unique and is the name of the current page. If there are several subobjects in the current p" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64878 [18:41:39] New patchset: Jqnatividad; "set SMWDIProperty show flag of subobjects to false to suppress display in factbox. Doesn't make sense to show subobjects in factbox since the display name is non-unique and is the current page name. If there are several subobjects in the current page, i" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64878 [18:44:17] New patchset: Yurik; "Revert "Updating to last zero ext"" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64966 [18:47:46] New patchset: Mwjames; "SMW\ParserTextProcessor add test and improve CRAP index" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [18:53:46] New patchset: Yurik; "Reverting deployment" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64970 [18:53:57] New review: Krinkle; "@Denny: Replied on the bug" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62785 [18:55:33] New patchset: Yurik; "Reverting deployment" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64971 [18:55:47] New patchset: Krinkle; "Reverting deployment of ZeroRatedMobileAccess to before Ie930d96980a8bcf" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64970 [18:55:59] New patchset: Mwjames; "SMW\ParserTextProcessor add test and improve CRAP index" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [18:57:02] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64971 [18:57:57] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64970 [19:06:24] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [19:12:42] New patchset: Aaron Schulz; "Moved job queue aggregator classes to a subdirectory." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64973 [19:29:47] New review: Jeroen De Dauw; "How did you find the CRAP index? Ran PHPUnit coverage?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [19:37:44] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64009 [19:47:03] New patchset: Amire80; "Remove webfonts enabling checkbox and associated preference" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64976 [19:49:18] New review: Mwjames; "Yes exactly (PHP_CodeCoverage 1.2.7 using PHP 5.4.7 and PHPUnit 3.7.13) but unfortunately it takes a..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [19:51:45] New review: Hashar; "Thanks a lot for the nice review! Fix coming in next patchset." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [19:52:09] New patchset: Hashar; "User::saveOptions() optimization" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64941 [19:53:46] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61477 [19:54:01] New patchset: SuchABot; "Apologies for the spam" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64979 [19:54:52] Change abandoned: Yuvipanda; "I think this works now :)" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64979 [19:58:27] New patchset: Amire80; "Remove webfonts enabling checkbox and associated preference" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64976 [20:02:34] New patchset: SuchABot; "Testing Automatic Pull Request to Gerrit Patchset" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64980 [20:04:43] Yippie, build fixed! [20:04:44] Project _debug-browsertests-template build #143: FIXED in 3 min 31 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/143/ [20:07:33] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #65: FAILURE in 6 min 16 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/65/ [20:09:32] Yippie, build fixed! [20:09:33] Project browsertests-sandbox.translatewiki.net-linux-chrome build #51: FIXED in 1 min 59 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/51/ [20:15:34] New patchset: SuchABot; "Adding first edit tour" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64981 [20:16:20] New review: Hashar; "Thank for the test." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [20:16:54] New patchset: Hashar; "overhaul maintenance/mwdocgen.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [20:18:24] New patchset: Kaldari; "Removing prefix exception for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64982 [20:19:54] New patchset: Kaldari; "Adding explicit prefix so we don't have to have an exception in prefs" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64983 [20:20:56] New patchset: Kaldari; "Removing prefix exception for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64982 [20:21:43] New patchset: EBernhardson; "Make HTMLCheckMatrix work like HTMLMultiSelect" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64985 [20:21:43] New patchset: EBernhardson; "Remove temporary backwards compatability hack for Echo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64986 [20:25:51] New review: Balloonguy; "A hook 'multiimage.pageLoad' or some" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [20:29:37] Change abandoned: EBernhardson; "kaldari wrote same patch at same time" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64986 [20:30:20] Change abandoned: EBernhardson; "kaldari wrote same patch at same time" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64985 [20:37:59] Change abandoned: Adamw; "no longer needed, patches have been converted to linear dependencies" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64431 [20:40:25] New review: Balloonguy; "Sorry, submitted by mistake" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62005 [20:43:37] New patchset: EBernhardson; "Tooltips for echo notification settings" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61940 [20:47:05] New patchset: Aubhav iitr; "Decoding urls before regexp matching in SpamBlacklist Extension" [mediawiki/extensions/SpamBlacklist] (master) - https://gerrit.wikimedia.org/r/57935 [20:50:54] New review: Aaron Schulz; "Test changes don't seem needed" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62173 [20:57:05] New review: EBernhardson; "This probably needs a little bit more thought, my main concern is that the user somehow needs to be..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [20:58:29] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [20:58:30] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [21:03:37] New review: Platonides; "In the skin code of my TS tools, see any of http://toolserver.org/~platonides/" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [21:13:54] New review: Mattflaschen; "Have you brought this up on any of the WMF wikis using ?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61924 [21:27:27] New review: Jeroen De Dauw; "Why not just run the coverage for SMW?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64969 [21:29:16] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63798 [22:05:44] any VE folks around? https://en.wikipedia.org/w/index.php?title=Lymph_node_stromal_cell&diff=556179187&oldid=555482296 [22:06:34] one block seems to have a sentence repeated a couple of times for no apparent reason. [22:07:56] with ☃ chars :P [22:13:29] thedj: try #mediawiki-visualeditor? [22:13:39] Krinkl.e's online [22:32:23] thedj, that sounds like what happened to me in VE, https://bugzilla.wikimedia.org/show_bug.cgi?id=48592 It was entertaining :) [22:32:41] the chess peices thing? [22:33:11] jorm, snowman in VE , like the pawn [22:40:33] thedj , what happened in "=== Folicular dendritic cells (FDCs) ===" in that edit looks like my bug: repetition, two snowmen. My two snowmen replaced a link. Can you update bug 48592 with details? Thanks. [22:43:38] It's also interesting how VE/Parsoid remove the newline between each
and para, generating a spurious diff. [22:44:21] it strips whitespace? [22:45:07] in that diff thedj linked, yes. I'm seeing if I can reproduce [22:52:19] that would be bad. [22:52:37] i'm all for eliminating wikitext eventually, but until we can do so we have to provide human readable code. [22:59:06] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [23:07:47] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [23:09:00] Project browsertests-en.wikipedia.org-linux-chrome build #75: FAILURE in 4 min 7 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/75/ [23:14:19] Hmm... no yuvi [23:14:50] New patchset: Krinkle; "deleteEqualMessages: Include list of pages in dry run" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64990 [23:14:56] New patchset: Krinkle; "deleteEqualMessages: Refactor to support all langcode subpages" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64991 [23:15:22] New review: Krinkle; "Backporting from master to 1.21. Needed for I2680413c276365a44." [mediawiki/core] (REL1_21) C: 2; - https://gerrit.wikimedia.org/r/64990 [23:15:48] New review: Krinkle; "Backporting from master to 1.21. Fixes a regression in the script introduced in 1.21." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64991 [23:19:28] New patchset: Aaron Schulz; "Tweaked LoadMonitor::getLagTimes() to further reduce stampedes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64992 [23:24:20] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64990 [23:26:38] New patchset: Aaron Schulz; "Actually update $lastTime in runJobs.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64993 [23:27:14] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64991 [23:28:06] New patchset: Aaron Schulz; "Actually update $lastTime in runJobs.php" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64994 [23:36:29] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64994 [23:56:22] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [23:58:56] New patchset: EBernhardson; "Repairs necessary for echo to support Sqlite" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594