[07:27:59] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64561 [07:29:01] New review: Hashar; "Congratulations on passing JSHint!! I have deployed the change." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64561 [07:37:51] New review: Hashar; "Fixed https://bugzilla.wikimedia.org/show_bug.cgi?id=44954" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [07:44:26] Nikerabbit: why empty alt? to be filled when one configured images? [07:47:14] Nemo_bis: the images are just extra prettification, the project name is stated next to it [07:48:07] I see [07:55:18] New patchset: Rfaulk; "fix. default for count arg." [sartoris] (master) - https://gerrit.wikimedia.org/r/64779 [07:55:18] New patchset: Rfaulk; "fix. log_deploys, don't use logger to output. Select the latest deploys to log." [sartoris] (master) - https://gerrit.wikimedia.org/r/64780 [07:55:18] New patchset: Rfaulk; "fixes. To diff and _get_commit_sha_for_tag." [sartoris] (master) - https://gerrit.wikimedia.org/r/64781 [07:55:43] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/64779 [07:55:59] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/64780 [07:56:13] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/64781 [08:00:38] New patchset: Nischayn22; "Fieldset legends is broken." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [08:01:29] Now I have to find some reviewers for core [08:16:52] New patchset: Hashar; "create merge jobs for ops/puppet/* repos" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64783 [08:17:07] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64783 [08:18:38] New patchset: Hashar; "merge jobs for ops/puppet/* repos" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64784 [08:19:27] New patchset: Hashar; "merge jobs for ops/puppet/* repos" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64784 [08:19:51] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64784 [08:22:16] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64237 [08:23:47] New patchset: Hashar; "Revert "create merge jobs for ops/puppet/* repos"" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64785 [08:24:38] New patchset: Hashar; "Revert "merge jobs for ops/puppet/* repos"" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64786 [08:24:42] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64785 [08:25:39] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64786 [08:27:19] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [08:27:54] New review: Happy-melon; "Looks sensible to me. In what scenario would $context be null, though? Looks to me like the plan w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [08:44:16] New patchset: Pginer; "Provide disable input tools option in IME menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [08:44:18] New patchset: Siebrand; "Remove key not used in resource" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63466 [08:44:36] New review: Siebrand; "+2 per Niklas on PS1." [mediawiki/extensions/Translate] (master) C: 2; - https://gerrit.wikimedia.org/r/63466 [08:44:57] New review: Nischayn22; "The context is bug:48650 where UploadWizard creates an UploadForm instance without setting any conte..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64782 [08:47:11] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63466 [08:48:41] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [08:54:00] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [08:56:28] New review: Physikerwelt; "I'm still not convinced that the http libraries recognize timeout correctly. Therefore I'd like to a..." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [08:57:54] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [09:26:33] New patchset: Hashar; "check whether jenkins run TestsAutoLoader" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [09:29:44] New review: Reedy; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [09:30:01] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [09:37:31] New patchset: Hashar; "tests: group structures tests in their own directory" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [09:53:53] New patchset: Hashar; "missing autoloader + make sure tests run" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [09:54:27] New review: Reedy; "It would seem so. However, in precise it's packaged from Ubuntu, but for older machines we had to bu..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64776 [09:55:23] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64776 [09:59:51] New patchset: Hashar; "tests: group structures tests in their own directory" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [09:59:54] New patchset: Hashar; "autoloader missed some entries" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64791 [10:00:07] New review: Reedy; "Ignore part of that comment." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64776 [10:00:13] New review: Hashar; "I have moved the autoloading fix in https://gerrit.wikimedia.org/r/64791" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [10:05:59] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [10:07:26] New review: Happy-melon; "It's probably past time this *was* made compulsory (as in, the previous signature has been deprecate..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64782 [10:24:29] New patchset: Santhosh; "Revert "Add a MediaWiki preference for enabling ULS IME"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [10:26:03] New patchset: Santhosh; "Revert "Add a MediaWiki preference for enabling ULS IME"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [10:34:33] New patchset: Hashar; "tests: group structures tests in their own directory" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64788 [10:35:44] marktraceur: Hey, Do you have a mac to further investigate https://bugzilla.wikimedia.org/show_bug.cgi?id=44772 [10:40:48] Nischayn22|Away: I highly suspect he won't have a mac ;) [10:41:18] Reedy: why is that? [10:41:38] it isn't free software [10:42:08] Noting it's also 03:42 for him currently too [10:42:48] ah, I see [10:43:00] So what does he use Ubuntu, Fedora? [10:43:20] Very likely [10:44:20] Hmm, there's a bug in UW which is specific to mac and safari which I don't have myself [10:44:39] brion might be able to help [10:45:03] I will try pinging him :) [10:45:48] There's a few other people that I think use macs and are interested in UW [10:45:53] potentially thedj[work] [10:46:20] and multichill [10:47:12] thedj[work] have been very helpful in UW, I also remember talking to multichill about some other project last year for GSoC but not UW related [10:47:39] He's a commons-er [10:48:02] I could install Safari too but then it would overflow my Windows toolbar :p [10:55:13] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [11:01:36] Nemo_bis: Hey [11:04:42] New patchset: Santhosh; "Revert "Add a MediaWiki preference for enabling ULS IME"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [11:05:37] New review: Matthias Mullie; "Krinke: I'm confused about the -1 (the review message says so, can't see it in the "reviewer" sectio..." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [11:07:59] New patchset: Jeroen De Dauw; "Added Travis CI file" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64799 [11:29:18] Change merged: Tobias Gritschacher; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64799 [11:37:47] New review: Platonides; "Usage of QuickTemplate::translator allowed to translate the skin from a different domain (eg. for To..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62442 [11:43:55] hi Nischayn22 [11:44:28] Nemo_bis: Was actually pinging you for some help with chunked uploading but I was able to get over it :) [11:44:40] anyways how are you? [11:47:53] fine enough, how about you? [11:48:01] * Nemo_bis has not tested chunked uploading for a while [11:50:23] Nemo_bis: I am fine, I just tried it out today and I think UW isn't causing responsible for slow uploading [11:50:45] Nemo_bis: I have something new for you at #mw-i18n too :) [11:52:00] :) [12:13:52] New review: Tpt; "Thanks!" [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64622 [12:13:52] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64622 [12:19:41] New patchset: Santhosh; "Allow ULS language settings accessed from user preference screen." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [12:21:24] New patchset: Santhosh; "Allow ULS language settings accessed from user preference screen." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [12:22:09] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [12:28:01] New review: Platonides; "c64569 makes this test work, but other 10 parsertests to fail." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64562 [12:28:46] New review: Platonides; "Maybe the class should be parametrised with some page titles to fake?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [12:35:53] New patchset: Santhosh; "Add fonts for Syriac Armaic languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [12:38:46] New patchset: Santhosh; "Update webfonts test page" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64519 [12:41:13] New review: Daniel Friesen; "@MZMcBride, ;) then it looks like they can just dump the custom config once this is deployed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63406 [12:42:46] New review: Ori.livneh; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64201 [12:43:22] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64567 [12:45:05] New review: Santhosh; "These issues should disappear after I5c97838ed875364dc35b66a3d6c33d9975b5107e merged" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [12:47:46] New review: Santhosh; "Did not get that. can you elaborate?" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [13:01:59] New patchset: Anomie; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64807 [13:02:23] New patchset: Anomie; "Update CentralAuth to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64808 [13:02:37] Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64807 [13:02:55] Change merged: Anomie; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64808 [13:26:52] New patchset: Jeroen De Dauw; "Add data values requirement" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64809 [13:29:49] New patchset: Jeroen De Dauw; "Add DataValues as requirement in composer.json" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64809 [13:31:11] New review: Anomie; "(1 comment)" [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64593 [13:33:08] New patchset: Jeroen De Dauw; "Added Travis CI build status image to readme.md" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64811 [13:55:41] New patchset: Jeroen De Dauw; "Throw an exception when DataValues is not loaded rather then outputting HTML" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64812 [14:34:25] Published patchset: Dereckson; "Installer can now customize the logo in LocalSettings.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/25761 [14:35:26] New patchset: EBernhardson; "Better detection of multiple changes in a document" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64577 [14:47:44] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64812 [14:48:28] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64811 [14:48:45] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64809 [14:53:56] New patchset: Krinkle; "jquery.textSelection: Fix typos in documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64573 [14:56:56] New review: Cmcmahon; "It would be convenient to merge this soon, since it affects a number of automated browser tests and ..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/64793 [14:57:17] New review: Cmcmahon; "It would be convenient to merge this soon, since it affects a number of automated browser tests and ..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64793 [14:57:51] Is it me or is https://bugzilla.redhat.com/ slow as hell? [15:10:39] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64650 [15:22:43] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [15:24:33] New review: Aaron Schulz; "Looks like this has a path conflict and needs a rebase" [mediawiki/extensions/WindowsAzureSDK] (master) - https://gerrit.wikimedia.org/r/56770 [15:25:40] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [15:28:47] New review: Hoo man; "Trivial one" [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64573 [15:31:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64573 [15:53:26] can someone merge this backport before 1.19.6 is released in a few hours? https://gerrit.wikimedia.org/r/#/c/62608/ [15:55:07] New review: Nemo bis; "Any idea how to re-fix https://bugzilla.wikimedia.org/show_bug.cgi?id=37209 in 1.20 then?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55389 [16:10:53] New patchset: Andrew Bogott; "Edit existing status page rather than clobbering it." [openstack-wikistatus] (master) - https://gerrit.wikimedia.org/r/64819 [16:46:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64791 [16:46:16] New review: Nikerabbit; "Platonides: is that actually used in practice? Where?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [16:49:51] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64802 [16:54:49] Change merged: Andrew Bogott; [openstack-wikistatus] (master) - https://gerrit.wikimedia.org/r/64819 [16:58:45] New patchset: Santhosh; "Allow ULS language settings accessed from user preference screen." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64802 [17:04:02] New review: Umherirrender; "@Krinkle: Are there open issues here, which avoid a merge?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [17:11:47] New review: Umherirrender; "Any idea for a better module name?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61817 [17:12:57] New patchset: EBernhardson; "Talk page links in notifications should not follow redirects" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64823 [17:19:02] New patchset: EBernhardson; "Link to any heading not just a main heading" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64363 [17:19:48] New patchset: Yaron Koren; "Updated for latest version of #subobject implementation in SMW 1.9" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64826 [17:22:26] New review: TheDJ; "Some small code convention remarks. Also, is there an intended purpose for adding this ? Might be ha..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64582 [17:22:28] New review: Adamw; "Hmm, this doesn't affect the legacy uses, but I noticed a major shortcoming in the design going forw..." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [17:24:27] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63282 [17:25:41] New patchset: Cmcmahon; "If the test must wait, wait explicitly only once with variable time." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [17:25:45] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64826 [17:25:54] wow, new xbox controller can read your heartbeat... [17:26:44] too bad the console itself is ugly [17:28:01] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [17:28:20] New review: Nikerabbit; "The use case example is in the method documentation. Should I copy that to the commit message?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [17:28:57] thedj: I watched few minutes and "windows kernel" and "always on mic" didn't convince me [17:29:14] New review: Njw; "The comment about the i18n notes issue has been addressed here: http://lists.wikimedia.org/pipermail..." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62623 [17:29:14] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [17:29:47] Nikerabbit: ps, parent5446 has a question for you: https://gerrit.wikimedia.org/r/#/c/57518/ [17:31:10] thedj: yes I know [17:31:25] thedj: I need to test how it actually works before I can answer [17:31:28] you mean that situation, and then using the non-default language don't you ? [17:32:50] New review: Krinkle; "Don't use .then." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64582 [17:33:31] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [17:34:02] thedj: scenario (content language en, ui language fi), if somebody overrides MediaWiki:nstab-main/en (or some easier to test message), will I see the override or standard translation [17:35:35] Nikerabbit: we should have a list of all language setting combinations + expected output, this is hellish to keep track of. [17:36:41] New review: Umherirrender; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [17:37:36] thedj: yeah it's complex [17:38:37] New patchset: Njw; "Add localisation documentation and generalise use of jump links" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [17:38:41] Krinkle: is there some reason why not to use .then here (or at all)? [17:39:15] it seems to avoid the need to do add lots of request.done( deferred.done ) etc.. [17:39:54] Nikerabbit: then is a shortcut to call .done() and .fail() in sequence. Though I personally find that method completely useless and confusing (unnamed arguments are evil), if you're only attaching a fail callback, using .then(null, fn) to achieve is looks rather obnoxious [17:40:05] consididering .then is return done(a).fail(b) [17:40:44] hmm [17:41:31] New patchset: Aaron Schulz; "Fixed behavior of Title::invalidateCache." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62406 [17:41:46] I thought only .then supported returning a new deferred for the next attached function in the chain, maybe I was mistaken [17:41:54] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63894 [17:44:53] Krinkle: but only in documentation for deferred.then I find this information: " These filter functions can return a new value to be passed along to the promise's .done() or .fail() callbacks, or they can return another observable object (Deferred, Promise, etc) which will pass its resolved / rejected status and values to the promise's callbacks." [17:44:57] New review: TheDJ; "New core messages should be added to maintenance/language/messages.inc shouldn't they ?" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64437 [17:45:16] Nikerabbit: yes a lot of overhead feaures that you're not using [17:46:19] Krinkle: but I am using it... I'm returning the result of the api.post inside .then [17:46:27] New patchset: Foxtrott; "Introduce ResourceLoaderModule that allows registering LESS files in modules" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64828 [17:46:39] Nikerabbit: I'll check it out later [17:46:41] wow, Halo TV series is coming. by Spielberg [17:47:28] New patchset: Foxtrott; "Introducing separate modules for styles and scripts and an overall module" [mediawiki/extensions/Bootstrap] (master) - https://gerrit.wikimedia.org/r/64829 [17:47:49] thedj: if you feel like reviving dead channels with more, #mediawiki could be a candidate ^^ [17:47:50] Krinkle: thanks, it's not urgent, I just try to learn [17:47:52] *more talk [17:49:01] New patchset: Cmcmahon; "Tests for existence of Appearance and Datetime preferences" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64830 [17:50:24] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:53:01] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64614 [17:55:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62406 [17:55:50] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [17:56:21] New patchset: Kaldari; "Adding short date format i18n strings to Language message files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [17:58:48] New review: Kaldari; "maintenance/language/messages.inc could use some better documentation. Right now it just says:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [18:01:18] Nikerabbit: I haven't used .then in this way before, I prefer to wrap it in another deferred explicitly instead of implicitly. [18:01:35] Nikerabbit: Either way, in this case it probably won't work because it doesn't preserve .abort [18:01:58] Or maybe it does, but it just looks frafile [18:02:03] I'll check it out further later [18:02:29] Nikerabbit: Anyway, what's the reason you choose this pattern? It might work, but the other modules all use deferred nesting. [18:03:57] New patchset: Foxtrott; "Show language links only if available; make footerlinks smaller" [mediawiki/skins/chameleon] (master) - https://gerrit.wikimedia.org/r/64832 [18:04:16] New review: TheDJ; "Looks ok to me, if the comments are picked up." [mediawiki/core] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/63274 [18:04:23] Change merged: Foxtrott; [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64828 [18:04:31] Change merged: Foxtrott; [mediawiki/extensions/Bootstrap] (master) - https://gerrit.wikimedia.org/r/64829 [18:04:39] Change merged: Foxtrott; [mediawiki/skins/chameleon] (master) - https://gerrit.wikimedia.org/r/64832 [18:05:22] Krinkle: i didn't have a detailed look on modules other than edit, and the postWithEditToken was difficult to understand for me [18:07:39] New review: Amire80; "With this patch the following happens:" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [18:08:58] New patchset: Pastakhov; "add reserved variables $argv and $argc (version 0.3.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/64833 [18:11:21] New patchset: Njw; "Add localisation documentation and update the description." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [18:11:23] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64828 [18:11:52] New review: Njw; "Thanks for the review Daniel, I posted a new changeset in response." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [18:14:07] New review: TheDJ; "(1 comment)" [mediawiki/core] (master); V: 2 C: -1; - https://gerrit.wikimedia.org/r/53968 [18:14:34] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64828 [18:14:40] https://bugs.php.net/bug.php?id=42016 [18:14:58] thedj: Please don't use the Verified field. [18:16:16] Verified+2 is the condition to allow a merge. Unless you did (at least) everything jenkins-bot did or are intentionally bypassing Jenkins, using it is considered harmful. [18:16:24] ah ok. [18:16:34] Krinkle: We should take that right away ideally [18:16:37] like we do for VE [18:16:46] If you verified something, just say so in the comment :) [18:17:56] RoanKattouw: I agree, though it appears there's still a few users that override it often. And Jenkins hasn't been very reliable lately, so at least ops will likely want to keep V+2 ability in core's wmf branches [18:18:29] RoanKattouw: The problem is we need roots/blessèd ones to be able to V+2 to bypass Jenkins, but not make it generally available, and it seemed that that config was challenging. [18:19:00] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [18:19:13] Yeah we'll need it in the wmf/* branches [18:19:27] But I see no compelling reason to keep it for master [18:20:47] well last time I did a lot of mw stuff, we didn't even have jenkins yet, so i guess that's how it was confusing to me. [18:21:03] Yeah well that's exactly the thing [18:21:19] People do CR+2 and V+2 and click "Publish and submit" [18:21:29] Which instantly merges the change before Jenkins gets a chance to verify it [18:22:03] ... which then means master is broken. [18:22:14] Which is a Bad Thing(tm). [18:22:59] when a user posts a question to your talk page, whats the appropriate way to respond? I mean how will they know i responded: should i use [[User:Username]] to generate a mention notification, should i post to their talk page, should i just post a reply on my talk page and assume they will see it? [18:23:09] Specifically it causes all other commits to be downvoted :( [18:23:30] RoanKattouw: And someone to lose +2, ideally. [18:23:31] ebernhardson: on en.wp you can use {{replyto|username}} [18:23:54] thedj: he posted to mediawiki.org/User_talk:Ebernhardson, basically just asking about a feature i developed, same there? [18:24:29] hmm, probably not no Template:replyto :) [18:24:33] ebernhardson: in that case, post on his userpage. either as a note that you have answered on your page, or as a direct answer. [18:24:56] or just [[User:name]] mention him. [18:25:00] thedj: ok excellent, thanks [18:25:14] cause mediawiki.org has Notifications enabled. [18:26:06] New patchset: Kaldari; "HTMLCheckMatrix support for forcing options on/off" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64835 [18:26:06] New patchset: Kaldari; "update Echo and ArticleFeedback to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64836 [18:26:40] euh Submit Type: RULE_ERROR [18:30:11] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64835 [18:30:32] Change merged: Kaldari; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64836 [18:35:59] Can someone else reproduce this bug? If so, show support by starring it :) https://code.google.com/p/chromium/issues/detail?id=242601 [18:36:50] Ryan_Lane: Not sure if you know someone who should know about this: http://cl.ly/image/272j363P1t0I [18:37:01] The (not so very subtle) arrows overlap the content [18:37:56] Krinkle: leaverou would likely be the person to talk to [18:38:03] I reported it in the webplatform channel [18:38:09] i wonder what is needed to bruteforce the watchlist atom feed tokens... [18:38:10] OK [18:38:11] #webplatform channel, that is [18:38:13] New review: Daniel Friesen; "(1 comment)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [18:38:26] or rather how much time is needed. [18:42:35] Krinkle: http://project.webplatform.org/skin/issues/34 [18:42:47] 160bits, guess that should be enough. [18:42:48] Krinkle: you may want to provide additional info :) [18:42:58] Krinkle: oh. there was something I wanted to talk with you about [18:43:03] to quote bitcoin: it should be noted that finding a collision in a 160-bit keyspace is still incredibly difficult and time consuming. More importantly, it is more difficult and time consuming than actually mining the same number of coins would be. [18:43:37] Krinkle: mw.notify always places the notification at the top of the page [18:43:38] Ryan_Lane: shoot :) [18:43:53] rather than at the top of the browser window [18:43:56] Ryan_Lane: Yes, it shouldn't do that but instead be fixed regardless of scroll [18:44:02] yep [18:44:03] Known bug [18:44:06] ah. ok [18:44:14] it's problematic in my use :D [18:44:24] It's problematic in a lot of cases [18:44:40] I don't think it has been properly filed in bugzilla yet, could you do that? [18:44:40] * Ryan_Lane nods [18:44:44] yep [18:44:58] thebugenie, interesting choice [18:45:05] I'd try to fix it, but it'll likely take me a long time [18:45:16] I kind of like the buggenie's interface [18:45:20] New review: TheDJ; "Seems ok, though i think that this will make it impossible to reset your token in case you accidenta..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64565 [18:45:26] Yeah, I love what you've done to it. [18:45:35] not me :) lea [18:46:43] Krinkle: https://twitter.com/LeaVerou [18:47:12] she makes awesome js and css things [18:47:12] Yippie, build fixed! [18:47:12] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #62: FIXED in 4 min 58 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/62/ [18:48:07] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=48689 [18:50:28] New patchset: Foxtrott; "Properly re-enable getStyleURLsForDebug; do not compress generated CSS" [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64837 [18:51:43] New patchset: Mwjames; "Deprecate smwfGetStore() in favour of a SMW\StoreFactory class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64838 [18:55:21] New review: Krinkle; "Haven't tested it but looks good. Thanks :)" [mediawiki/extensions/Less] (master) C: 1; - https://gerrit.wikimedia.org/r/64837 [18:56:02] New review: Foxtrott; "Thanks for reviewing!" [mediawiki/extensions/Less] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64837 [18:56:02] Change merged: Foxtrott; [mediawiki/extensions/Less] (master) - https://gerrit.wikimedia.org/r/64837 [18:58:03] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [18:58:58] Krinkle: should i make a bugzilla about that +2V permission thing ? [19:00:09] thedj: Sure. Though afaik it is known that this is our goal for all projects (not negotiable, it is part of the design of our workflow, there is no usecase for it other than fixing a temporary problem with the system itself) [19:00:30] It is just a matter of time for each project to reach the point where it no longer needs to override jenkins frequently [19:02:02] Nikerabbit: Are you interested in having Verified/Submit disabled in l10n-related mwexst repos? (exceptions will be made for JenkinsBot and l10nbot) [19:02:23] Similar to how is already done in e.g. the VisualEditor repository. [19:02:58] qgil: I have to jump to get something to eat, so I can't talk right now [19:03:05] ok, same problem here :) [19:03:41] Krinkle: I see no problem with that [19:04:00] Krinkle: so what about +1V then ? [19:04:15] thedj: It makes no sense to add such score. [19:04:53] thedj: review is done with Code-Review field [19:05:02] What would V+1 by a human mean? [19:05:21] Nikerabbit: Alrighty :) To l10n-hamburgers with extra no-human-Verified and no-human-merge coming up. [19:05:30] New patchset: Amire80; "Don't show anonymous users tipsy with setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [19:05:41] New review: Njw; "(1 comment)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [19:05:59] hamburgers? can has healthier alternative? :D [19:07:19] Yippie, build fixed! [19:07:20] Project browsertests-sandbox.translatewiki.net-linux-chrome build #48: FIXED in 3 min 15 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/48/ [19:07:50] New patchset: Njw; "Add localisation documentation and update the description." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64827 [19:08:34] oh they are testing sandbox [19:14:20] New patchset: Mattflaschen; "Update referenced PHP version in 'normal' README." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64840 [19:15:56] Ryan_Lane: Not sure if this is a bug in TheBugGenie or elsewhere, but when I login with google Open ID my realname is set to a hash instead of an actual name [19:16:08] I'm being greeted as Ju61ufyj9S5DX everywhere [19:16:30] I cleared it for now [19:18:53] Ryan_Lane: How can I add myself to CC or somehow "watch" it? [19:19:26] Oh, there is a star. Didn't see it earlier [19:20:00] New review: Mattflaschen; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64237 [19:29:58] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [19:33:15] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/Translate] (refs/meta/config) - https://gerrit.wikimedia.org/r/64841 [19:33:21] New patchset: Cmcmahon; "Maintenance: text "Okay" changed to "Next"" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/64842 [19:34:25] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/TranslationNotifications] (refs/meta/config) - https://gerrit.wikimedia.org/r/64843 [19:37:01] New review: Mattflaschen; "Actually, Firefox 3.6 (although old) is grade A (https://www.mediawiki.org/wiki/Compatibility#Grade_..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63993 [19:39:00] superm401: Actually, https://www.mediawiki.org/wiki/Compatibility is hilariously out of date and shouldn't be taken as gospel. Browser support decisions are at a product-by-product level. [19:39:17] James_F, so we should update in then. [19:39:41] James_F, Firefox 3.6 is kind of ridiculous when you think about it. What do you think I should bump it to? [19:40:06] superm401: We (EMGT and me) published a new policy in October for discussion, but I didn't push it on-wiki yet. [19:40:37] superm401: The new policy was baseline + product decision; baseline was "current major version plus previous two" of Chrome, Safari, Firefox and IE. [19:40:55] And you got rid of the A/B distinction? [19:41:48] superm401: Amongst other things, yes. [19:42:02] superm401: I should write it up and publish it, shouldn't I? :-) [19:42:10] James_F, yes. :) [19:43:01] superm401: I've updated [[mw:Compatibility]] [19:43:15] Krinkle: Yes, but wrongly. [19:43:24] James_F: How so? [19:43:49] Krinkle: The entire document is aspirational on the part of volunteers; it doesn't describe what WMF funds, and doesn't tell people that that's the case. [19:44:06] James_F: I'm referring to my edit of 2 minutes ago [19:44:16] Krinkle: So people assume - entirely wrongly - that WMF will build full support for everything for Opera 11.6+. [19:44:21] I don't care about the state of the document in general right now. [19:44:50] Krinkle: It's certainly an improvement. [19:45:20] New review: Cmcmahon; "On test2wiki, print/export is expanded by default, but no cookie is set." [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [19:45:59] Will update my review. [19:46:16] James_F: I don't think the wmf funds argument is very significant in this context I mean... These major browsers are out there, anything created, regardless by whom or what for should not fail in that Grade A pool. [19:46:31] New patchset: GWicke; "Add parsoid-specific image testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [19:46:33] Individual projects (e.g. VisualEditor) have chosen to not support Opera, but that's an exception to the rule. [19:46:36] Krinkle: And yet reality differs with your opinion. [19:46:53] Krinkle: Yes, but the 'rule' your talking about is different from the 'rule' on that page. [19:47:00] * James_F adds {{historical}} with a note. [19:47:15] James_F: Please don't that isn't right either [19:47:22] The page is actively used and referred to [19:47:28] Update it? [19:47:29] Krinkle: And that's why it's a problem. [19:47:31] The page is a lie,. [19:47:36] "All current major web browsers are compatible with most versions of MediaWiki. "Grade A" functionality is maintained for the following browser requirements: [19:47:38] {{sofixit}} [19:47:39] This is a lie. [19:47:42] I'm doing so. [19:47:49] Agreed, the conventions should be attainable, or they're not really conventions. [19:47:51] By adding a note in advance of a proper page being written. [19:48:00] And you're saying not to fix it. [19:48:03] This is a problem. :-) [19:48:03] James_F, but definitely don't mark the whole page as historical, since there's other non-browser stuff on there. [19:48:10] Try not to rewrite the page from scratch to make it easier to review [19:48:13] superm401: Yeah, it's going to note as such. [19:48:23] Krinkle: The entire concept of that section is wrong by design. [19:48:25] Progressive updates :) [19:48:26] Krinkle: It's going. [19:48:36] New patchset: Dan-nl; "initial draft" [mediawiki/extensions/GWToolset] (master) - https://gerrit.wikimedia.org/r/59405 [19:48:42] James_F: There should be an equivelant of that table, regardless of the data in it. [19:49:00] Krinkle: Sure; see my e-mail from October for the new table. [19:49:07] e.g. when a bug is fixed or a feature written: what should it work in. [19:49:19] ... yes. [19:49:22] And the historical data for old versions is useful as well. [19:49:28] and differnation between grade a and b [19:49:35] We're not going to differentiate. [19:49:45] We do, we always have. [19:50:00] I don't know about the policies but I do know the current state in the software and *it* differtiates. [19:50:04] New review: Mattflaschen; "James Forrester pointed out on IRC that page is showing its age, and they're considering a new polic..." [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/63993 [19:50:06] Krinkle: No. /You/ want to, and often do. That is not the same as "the MW developer community do this". [19:51:05] James_F: You're saying progressive enhancement and graceful degradation are not policy and stuff is allowed to just throw uncaught exceptions in any non grade A browsers? [19:51:19] New patchset: Aaron Schulz; "Allow server selection when running sql.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [19:51:22] Krinkle: Yes, that's what Engineering Management decreed. [19:51:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [19:51:54] James_F: Is content allowed to be unreadable for non grade A browsers? [19:52:07] Krinkle: Yes. [19:52:16] There's a difference for what browsers we must support, and banning progressive enhancement. [19:52:27] No one says it has to fail horribly in non-supported browsers (even non-Grade B, currently). [19:52:59] Indeed. [19:53:30] But there's a huge difference between best-efforts and "we will always make XYZ work with browsers that don't even make 'grade A'". [19:54:15] There's an exception to every rule, this page doesn't list exceptions, it lists what the majority of features and newly developed features should support. [19:54:37] To put it differently, what code ought to be rejected by reviewers if not. [19:55:00] Krinkle: I understand your comment. [19:55:07] Krinkle: I'm just telling you that you're wrong. :-) [19:55:15] e.g. I'm pretty sure we should not be allowed to merge code that results in content being unreadable in IE8, I think that would be in direct contradiction with our mission statement. [19:55:45] Krinkle: Don't argue with me in IRC as if it'll change anything. :-) [19:56:01] Can you confirm or deny the above? that'll clarify the base line for me. [19:56:11] Krinkle: Yes, I can confirm that I am denying the above. [19:56:24] Krinkle: For example, "MediaWiki is accessible to user agents which do not process JavaScript. MediaWiki degrades gracefully and all essential functionality works without JavaScript, although some things might be less convenient. " <-- This is not going to be true RSN. [19:57:01] James_F, can you change the policy, so there's always some way to *read* with JS? [19:57:03] Krinkle: Notifications are relatively key, and require JS. Flow is going to be absolutely key, and require JS. [19:57:08] That doesn't seem like an unreasonable request. [19:57:16] Sorry, I mean *without* JS, of course. [19:57:20] superm401: I think that's totally reasonable. As I said, I should write down the policy. [19:57:23] Yeah. :-) [19:57:45] hmm, perhaps we should organize a review hour this weekend. not sure how much unreviewed code of attendees (non-reviewers) there is, but might be nice for them to do in-person reviews. [19:58:53] thedj: So people can shout at them in-person? :-) [19:58:57] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [19:59:07] thedj: (Hopefully none of our +2ers would do that, of course.) [19:59:26] New patchset: Krinkle; "Restrict Verified/Submit to JenkinsBot and l10n-bot" [mediawiki/extensions/TwnMainPage] (refs/meta/config) - https://gerrit.wikimedia.org/r/64845 [19:59:27] James_F: i'm bringing a fresh trout ! [19:59:39] James_F, actually, though Notifications does not require JS. [19:59:46] In fact, that's how this whole conversation got started. [19:59:53] thedj: Ha. [19:59:54] Change merged: Krinkle; [mediawiki/extensions/TwnMainPage] (refs/meta/config) - https://gerrit.wikimedia.org/r/64845 [20:00:11] superm401: Oh, that's good to know. [20:00:20] Change merged: Krinkle; [mediawiki/extensions/Translate] (refs/meta/config) - https://gerrit.wikimedia.org/r/64841 [20:00:29] It does add stuff of course, like the overlay and AJAX updates. [20:00:36] Change merged: Krinkle; [mediawiki/extensions/TranslationNotifications] (refs/meta/config) - https://gerrit.wikimedia.org/r/64843 [20:00:46] * James_F nods. [20:00:56] superm401: Of course, all of VE is completely JS, which sucks. [20:01:17] luckily, we still have forms for those ppl. [20:01:22] James_F, I mean it's kind of required. [20:01:34] If MW allowed raw HTML, maybe it would be possible (not sure). [20:01:45] But we all know what kind of crazy stuff VE is doing. [20:01:54] Yeah. [20:01:56] New patchset: Aaron Schulz; "TitleSquidURLs hook for changing the URLs to purge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64290 [20:02:18] If browsers were less buggy there could be a non-js editor for the html dom with relatively few effort. [20:02:31] However if and when such browser will exist, it will no doubt support javascript. [20:02:40] Krinkle: Indeed. [20:03:13] New patchset: Cmcmahon; "Run this on enwiki and beta but not test2" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [20:03:26] of course it wouldn't be able to do anything other than change text, remove alien blocks and italicise/bold text. but hey, that's basic contenteditable [20:04:42] Project _debug-browsertests-template build #141: FAILURE in 3 min 25 sec: https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/141/ [20:05:48] New patchset: awjrichards; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64846 [20:06:07] Krinkle: No references editing means no deployment. :-) [20:06:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64290 [20:06:12] New review: MaxSem; "I don't like the parameter name, index. It's an obscure internal terminology and should be confusing..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [20:07:09] James_F: Realistically a non-js editor would have to be raw text (wikitext or html), contenteditable doesn't make sense since it wouldn't be able to update anything not plain text. [20:07:40] Krinkle: Annotations would need CE, though, surely? [20:07:52] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #63: FAILURE in 6 min 32 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/63/ [20:08:23] James_F: it would need CE + javascript. [20:08:32] Yeah. :-( [20:08:43] James_F: So, no. A non-js editor can only be raw html or raw wikitext. [20:09:02] New review: Aaron Schulz; "I was a bit torn myself on this. It's useful to pick a server from the list, but it makes it more ob..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [20:09:05] which we'd then sanitise server-side (which we do already since client side can be manipulated) [20:09:15] Krinkle: Boo. [20:09:42] Krinkle: I think we should propose a non-JS VE for someone very keen. *After* VE is deployed everywhere and working. :-) [20:09:43] New review: Aaron Schulz; "Of course no argument should pick a random slave." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64844 [20:09:58] James_F: yes, about that. [20:10:00] :) [20:10:25] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64846 [20:10:55] On a related note, why does jQuery support IE6, but only the current version of everything else? [20:10:57] http://jquery.com/browser-support/ [20:11:22] Oh, it really means 2 including current. [20:13:50] superm401: Yeah, that table isn't very clear the notation "Current – 1 version" is ambiguous [20:14:22] it is elaborated below the table, but the fact that it is shows that it is unclear [20:15:46] Krenair: hi [20:15:53] Hi Wikinaut [20:16:32] in https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Wikinaut_for_extension_UserMerge_and_Delete I applied already for the project ownership - (I was already maintaining that during SVN times). Can you please set me up as maintainer for it in gerrit ? [20:16:43] then I can apply the patch in [20:16:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=44917#c3 [20:17:00] New review: GWicke; "Ping!" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55273 [20:17:05] s/apply/test and apply/ [20:17:24] Krenair: I think, this was simply forgotten [20:17:39] (this is my view) [20:19:45] Krenair: to clarify, I meant: "It was perhaps simply forgotten to set me up as maintainer for the gerrit-version of "UserMerge and Delete" [20:20:18] but this is my personal view^ [20:20:50] New patchset: CSteipp; "SECURITY: Do checks on all upload types" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64848 [20:20:56] Krinkle: you can go into your preferences and change your display/username [20:21:29] Ryan_Lane: I did that already. Just found it odd that it was auto-created with a hash as real name. [20:22:10] yeah. you'd think it would let you choose the name, or use the SREG data [20:24:41] New patchset: CSteipp; "SECURITY: Do checks on all upload types" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/64849 [20:24:41] New patchset: CSteipp; "Updated release notes and version number" [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/64850 [20:25:08] New patchset: Nischayn22; "disable multiple file upload on Safari" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64851 [20:25:14] New review: Mattflaschen; "Is this related to https://bugzilla.wikimedia.org/show_bug.cgi?id=39012 ?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64848 [20:25:43] New patchset: CSteipp; "SECURITY: Do checks on all upload types" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64852 [20:25:43] New patchset: CSteipp; "Updated release notes and version number" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64853 [20:26:31] New review: CSteipp; "Released as part of 1.20.6" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64848 [20:28:57] New review: Nischayn22; "Not tested but one problem is did come to picture. The flickr button appears even after uploading on..." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64851 [20:30:17] New review: CSteipp; "Released as part of 1.20.6" [mediawiki/core] (REL1_20) C: 2; - https://gerrit.wikimedia.org/r/64849 [20:31:11] New review: Aaron Schulz; "per storeMetaData using 'store'" [mediawiki/extensions/Score] (master) C: -1; - https://gerrit.wikimedia.org/r/61181 [20:31:43] New patchset: CSteipp; "SECURITY: Do checks on all upload types" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64852 [20:32:02] New review: CSteipp; "Released as part of 1.19.7" [mediawiki/core] (REL1_19) C: 2; - https://gerrit.wikimedia.org/r/64852 [20:33:38] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64848 [20:33:51] New patchset: Krinkle; "jquery.byteLimit: Improve unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64854 [20:34:04] New review: Nischayn22; "Broke Chrome for me, need better way to detect Safari" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/64851 [20:35:28] Change merged: jenkins-bot; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/64849 [20:36:15] New patchset: Krinkle; "jquery.byteLimit: Fix infinite loop if text is longer than max" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [20:37:08] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [20:37:19] New review: CSteipp; "1.20.6 release" [mediawiki/core] (REL1_20) C: 2; - https://gerrit.wikimedia.org/r/64850 [20:37:25] New patchset: Nischayn22; "hide flickr upload if multiple upload is disabled" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64855 [20:38:26] Change merged: jenkins-bot; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64852 [20:38:54] New patchset: Krinkle; "jquery.byteLimit: Improve unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64854 [20:39:06] New patchset: Krinkle; "jquery.byteLimit: Fix infinite loop if text is longer than max" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [20:40:00] csteipp: Ideally you'd use the same Change-Id for the same change in different branches. [20:40:44] So that backports can be found in both directions by just looking up the change id [20:41:35] https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Submitting_a_change_to_a_branch_for_review_.28.22backporting.22.29 [20:42:41] csteipp, also it would be good to use a Bug: footer (though you probably want to verify it won't leak to Bugzilla prematurely when marked as a draft). [20:43:05] https://gerrit.wikimedia.org/r/#/q/Ib27792b661666ac5f704eeaaadcdd9668dd81b56,n,z then shows both changes [20:43:31] Change merged: jenkins-bot; [mediawiki/core] (REL1_20) - https://gerrit.wikimedia.org/r/64850 [20:44:37] Krinkle: I agree it's nice to see that, but I keep getting into weird situations when I do that... and I keep forgetting to document the issue. But yeah, I probably should do it next time. [20:44:45] superm401: I normally do.. Just forgot this time [20:45:30] I'd be curious to see what issue. I've done without issues on many occasions, and others (hashar, demon, reedy, timstarling) as well [20:46:45] New patchset: CSteipp; "Updated release notes and version number" [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64853 [20:47:01] New review: CSteipp; "1.19.7 release" [mediawiki/core] (REL1_19) C: 2; - https://gerrit.wikimedia.org/r/64853 [20:47:36] New review: Krinkle; "(1 comment)" [mediawiki/core] (REL1_19) C: -1; - https://gerrit.wikimedia.org/r/64853 [20:47:49] csteipp: can you create a tiny follow-up merging those 2 spaces? [20:47:52] Or is it already bundled? [20:48:12] onchunked [20:48:54] Tarballs are already published. I'd rather not build a new one (distributors get mad when they change) [20:49:46] But I'll update REL1_19 so it's there for next time [20:50:27] Change merged: jenkins-bot; [mediawiki/core] (REL1_19) - https://gerrit.wikimedia.org/r/64853 [20:51:05] New patchset: awjrichards; "Updating MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64856 [20:51:16] So it has been fifteen years since I've done much with IRC but it looks like I'm going to be in here every day from now on. Can someone suggest a really nice client that I can maybe script a bit to keep my head from melting with all the text? [20:52:49] manybubbles: just /ignore the bots if they annoy you? [20:53:19] MatmaRex: I think I'm going to need gerrit-wm at some point. [20:53:39] Change merged: awjrichards; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64856 [20:54:13] manybubbles depends :) I wrote my own client - if you want to test it... it is not yet /scriptable/ but it is already extendable - the extensions needs to be written in c# though [20:54:26] manybubbles: I presume you're referring to the activity and different channels in general and not the bots in particular? [20:54:31] http://pidgeonclient.org/wiki/Download [20:54:32] manybubbles: What OS are you on? [20:54:40] this one is for any OS :P [20:55:29] manybubbles: yes, the question is, what do you want? :) [20:55:38] Krinkle: Linux. Currently KDE but I'll probably end up on Gnome eventually. [20:55:49] * MatmaRex is personally using Miranda for all his IM needs [20:56:37] petan: I'm afraid I might end up spending more time on a client like that working. It'd be fun though. [20:57:33] MatmaRex: I'm not really sure yet. I'm going to be paying attention to eight or so rooms with varying degrees of interest. [20:57:58] maybe something where I can declare that some rooms are less important then others [20:58:38] I think I'll need to filter garrit-wm based on pattern matches or something. [20:58:45] i am in seven rooms right now, i've just got them open in tabs, and i tab around when i get a notification about new messages [20:59:01] i am a simple man with simple needs. :P [20:59:04] manybubbles getting it working on linux is a matter of one command. but at this moment priorities for channels are really not available, so probably not for you... [20:59:36] I'm not really even sure what I need yet. Just, something.... [20:59:47] I've been watching for a few days now and trying to guess [21:00:06] New patchset: MarkAHershberger; "Chunked uploads allow arbitrary data to be dropped on the server" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64857 [21:05:08] New review: CSteipp; "(1 comment)" [mediawiki/core] (REL1_21) C: -1; - https://gerrit.wikimedia.org/r/64857 [21:06:52] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [21:10:09] New patchset: Amire80; "Hide the ULS trigger for users who disabled JS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64859 [21:12:12] Ryan: just for info : https://bugzilla.wikimedia.org/show_bug.cgi?id=45241#c6 [21:12:32] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [21:13:03] New patchset: EBernhardson; "Batch update job for unread user notifications" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64858 [21:13:25] Krinkle: your comment here is not correct: https://bugzilla.wikimedia.org/show_bug.cgi?id=45241#c6 [21:13:38] Krinkle: that behavior wasn't reverted [21:13:41] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [21:13:52] only user's subpages return 404 now. the user's page itself still returns 200, even if it doesn't exist [21:17:13] Ryan_Lane: I see, interesting [21:21:48] New review: Ryan Lane; "$wgCanonicalServer is likely the correct solution, so PROTO_CURRENT is likely broken behavior." [mediawiki/extensions/OpenID] (master) C: -1; - https://gerrit.wikimedia.org/r/45474 [21:24:26] New patchset: MarkAHershberger; "Disable chunked uploads by default." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64860 [21:24:39] New patchset: Mwalker; "Updating of AmazonAudit for PEP-8 and some refactoring" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/64861 [21:27:05] New patchset: Krinkle; "phpcs: More require/include is not a function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [21:27:24] New review: Krinkle; "Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [21:27:54] New patchset: MarkAHershberger; "Disable chunked uploads by default." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64863 [21:28:59] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [21:31:09] New patchset: Yaron Koren; "Fix for parsing (escaped) ampersands in XML" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64864 [21:34:40] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64864 [21:36:07] New review: Ryan Lane; "Use PROTO_CANONICAL rather than PROTO_CURRENT" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [21:39:36] Ryan_Lane: Yup PROTO_CANONICAL seems better there [21:40:12] yep [21:41:36] New patchset: Balloonguy; "Warn if page was edited while deletion was being confirmed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64533 [21:43:45] New review: Adamw; "(1 comment)" [wikimedia/fundraising/tools] (master) - https://gerrit.wikimedia.org/r/64861 [21:45:47] Change merged: jenkins-bot; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/61823 [21:46:18] New patchset: MarkAHershberger; "Chunked uploads allow arbitrary data to be dropped on the server" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64857 [21:48:45] New review: Balloonguy; "I addressed the missing case as noted in the comments of the page being edited before the delete lin..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64533 [21:52:20] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [21:52:21] New patchset: MarkAHershberger; "Disable chunked uploads by default." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64863 [21:52:40] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [21:55:17] New review: MarkAHershberger; "(1 comment)" [mediawiki/extensions/Sarcasm] (master) - https://gerrit.wikimedia.org/r/61518 [21:55:18] Change merged: MarkAHershberger; [mediawiki/extensions/Sarcasm] (master) - https://gerrit.wikimedia.org/r/61518 [21:58:26] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [22:00:17] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [22:01:21] New review: Mattflaschen; "I didn't re-examine patch set 2 in detail due to the rebase, but patch set 1 looked good other than ..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64237 [22:05:43] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [22:07:41] New patchset: Adamw; "WIP: DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [22:07:47] New review: Wikinaut; "New version with PROTO_CANONICAL works for me. " [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [22:08:18] New patchset: Hashar; "overhaul maintenance/mwdocgen.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [22:12:22] New patchset: Hashar; "overhaul maintenance/mwdocgen.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64866 [22:13:26] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [22:14:02] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [22:16:39] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [22:18:30] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [22:20:30] New patchset: Adamw; "WIP: More DI core changes to support DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64440 [22:24:52] Nikerabbit: ping [22:43:04] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [22:43:22] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64433 [22:46:48] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [22:46:54] So what is the status of SpecialActiveUsers? I see it is enabled on commons but disabled on nl.wikipedia [22:47:05] causing red links in some places [22:48:37] Krinkle: it was readded recently [22:48:45] Krinkle: maybe it's just not yet deployed there [22:48:51] or maybe it got disabled in WMF settings [22:53:20] New patchset: Spage; "Preserve exception when logging, as suggested by S." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [22:53:44] New patchset: EBernhardson; "Tooltips for HTMLCheckMatrix" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61939 [22:55:38] MatmaRex: it will be there tomorrow [23:00:07] New review: Spage; "whitespace fixes Matt pointed out. It works in Firefox and Chromium, I'm approving." [mediawiki/extensions/GuidedTour] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/63260 [23:00:16] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [23:01:30] New review: Spage; "Our reviews crossed, I'll address Krinkle's comments. Thanks!" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [23:02:36] spagewmf: only soft suggestions, It'd be OK if you take them in consideration next time. Nothing major :) [23:03:11] Krinkle, sorry our reviews crossed, thanks for the suggestions. [23:03:12] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64857 [23:07:21] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) C: 1; - https://gerrit.wikimedia.org/r/63993 [23:07:27] New review: Mattflaschen; "Looks generally good, small notes, some of which are follow-ups." [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/63829 [23:08:08] New review: CSteipp; "Should be fine, and probably a good idea." [mediawiki/core] (REL1_21) C: 1; - https://gerrit.wikimedia.org/r/64863 [23:08:35] Yippie, build fixed! [23:08:35] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #64: FIXED in 7 min 13 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/64/ [23:09:37] Project browsertests-sandbox.translatewiki.net-linux-chrome build #50: FAILURE in 1 min 43 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/50/ [23:10:52] New patchset: Krinkle; "jquery.byteLimit: Improve unit tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64854 [23:11:02] New patchset: Krinkle; "jquery.byteLimit: Fix infinite loop if text is longer than max" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63282 [23:14:31] New patchset: Ryan Lane; "Fix security group fetching from nova api" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64868 [23:15:27] New review: Mattflaschen; "Siebrand, can you reply to my comment?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52749 [23:18:24] New patchset: Kaldari; "Making bolding behavior consistant in page link notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64869 [23:19:00] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64869 [23:22:41] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [23:24:22] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [23:33:25] New patchset: Spage; "Minor tweaks to recent logging change" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64870 [23:35:24] New review: Spage; "Change I580ec98388f594d74034e80fad04c97e63f764df addresses PS4 feedback." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [23:36:51] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/64870 [23:38:45] New review: Aaron Schulz; "It would also be nice of the non event handler function went in some separate utility class." [mediawiki/extensions/CentralAuth] (master) C: 1; - https://gerrit.wikimedia.org/r/57662 [23:42:37] New patchset: Mattflaschen; "Make jshint voting for GuidedTour" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64871 [23:43:21] New patchset: Mattflaschen; "Make jshint voting for GuidedTour" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64871