[00:31:18] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [00:38:13] Hey TimStarling. Is there anything I really need to know about SecurePoll for setting up a test on testwiki as per https://bugzilla.wikimedia.org/show_bug.cgi?id=48330 ? [00:38:28] Last time around the xml file was provided and I just imported it [00:40:06] usually I just get a previous year's XML file and change the candidate names [00:40:56] do you still have a previous XML file? [00:48:22] Yup, there is http://bug-attachment.wikimedia.org/attachment.cgi?id=11425 [00:49:05] Does it cope with multiple questions? Or are they all seperate polls? [00:49:40] Board, FDC, FDC obmbudsperson [00:50:47] yes, you can have multiple questions [00:51:39] * TimStarling tries to remember which vote that feature was added for [00:51:49] Haha [00:52:01] I was just going to ask if you had an example for it [00:53:04] It feels like Matt F. tries to be intentionally disruptive on mediawiki.org. [00:53:11] He may end up blocked. [00:55:15] maybe it hasn't been used before [00:55:36] but obviously I have complete faith in my own code ;) [00:57:54] it's possible that it was never even tested on my own test wiki [00:58:10] I have a set of test files here, and none of them seem to have multiple questions [00:58:42] just as well you're testing it now, I guess [00:59:01] anyway, the input format is simple enough [01:00:14] you just have multiple sections, and use the "text" message associated with the question to introduce it on the ballot page [01:04:53] with one question, the "intro" message on the election is redundant with the "text" message on the question [01:05:24] so we have generally made the latter blank [01:05:48] although I did test it locally with the question text non-blank [01:09:27] you need to use the same ballot type and the same tallying method for each question [01:09:35] don't know if that is a problem for this case [01:11:44] https://meta.wikimedia.org/wiki/Wikimedia_Foundation_elections_2013 [01:12:23] The text suggests they all should be roughly the same [01:30:31] New review: Deyan; "Hi," [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [04:52:57] New patchset: Santhosh; "Simplify the language settings display" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [05:40:34] New review: Nikerabbit; "Tests would be nice." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64277 [05:55:40] New patchset: PleaseStand; "Change @since and @deprecated notes to 1.22" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64549 [06:56:01] New patchset: Rfaulk; "fix. deploy tag output." [sartoris] (master) - https://gerrit.wikimedia.org/r/64550 [06:56:32] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/64550 [07:01:15] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [07:06:15] New patchset: Nischayn22; "Add flickr templates to uploads from flickr." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [07:08:39] New patchset: Nischayn22; "Add flickr templates to uploads from flickr." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [07:21:25] New patchset: Nischayn22; "Add flickr templates to uploads from flickr." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [07:45:13] Nikerabbit: when you rewrote special:RC back in 2008... http://mediawiki.org/wiki/Special:Code/MediaWiki/36376 why didn't you do this for the watchlist as well? :( [07:46:38] MatmaRex: your question has a name in Italian, "benaltrismo" :) [07:47:45] heh [07:48:00] i should blame ialex, too [07:48:32] he rewrote special:recentchangeslinked to use special:RC in http://mediawiki.org/wiki/Special:Code/MediaWiki/36682 while not rewriting special:watchlist in the same way [07:48:35] ;) [07:48:43] and now the watchlist code is teh suck [07:48:56] some parts come straight from 2003 [07:49:20] It's probably a consequence of his CleanChanges commits of the time: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CleanChanges.git;a=shortlog;pg=2 [07:49:59] huh. [07:50:09] I guess nobody ever needed to study/hack Watchlist as RC [07:50:56] Nemo_bis: i mean, just look at the interface [07:51:04] it's almost the same, but coded entirely differently [07:51:40] and both watchlist and RC query the same table, they just add some slightly different conditions [07:51:53] i should blame brion, too [07:52:10] he allowed the two to be implemented separately back in 2003 :P [07:55:05] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [07:58:53] New review: Amire80; "The refactoring is good, but the scrolling must be restored." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 2; - https://gerrit.wikimedia.org/r/63840 [07:59:08] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [07:59:44] New patchset: Amire80; "Cog icon can be used to close the language settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64256 [08:00:30] MatmaRex: I needed it for my extensions [08:02:24] New patchset: Nischayn22; "Better error messages." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [08:03:09] Nikerabbit: do the same for watchlist? :P [08:03:31] MatmaRex: I don't need watchlist stuff for my extensions :( [08:04:02] :( [08:05:02] i wonder how hard would it be to get SpecialWatchlist to extend SpecialRecentChanges [08:06:56] MatmaRex: you should get CleanChanges etc. enabled on Wikidata and then get WMDE work on RC and watchlist for their stuff :p [08:07:18] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64256 [08:07:32] speaking of which, it's very silly to wait for that wikidata bug to be fixed before making RC/WL better for everyone [08:07:51] New patchset: Amire80; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64261 [08:08:02] I got quite tired of this perennial slowdown of MediaWiki development for WMF blockers [08:08:22] SQL lovers may also help with some stats at https://jira.toolserver.org/browse/DBQ-205 [08:08:32] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64261 [08:08:42] New patchset: Amire80; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [08:12:24] hey, it's siebrand. hi. [08:12:50] hello [08:13:01] siebrand: did you get a change to look at https://gerrit.wikimedia.org/r/#/c/64525/ yet? :) [08:13:19] siebrand: aka - how do i get mass message changes done [08:13:25] chance* [08:13:52] MatmaRex: It looks like you didn't read the documentation. [08:14:41] See https://www.mediawiki.org/wiki/I18n#Changing_existing_messages [08:14:41] i've learned not to expect documentation. is there any? where? [08:15:24] siebrand: that link provides no information related to my particular question. [08:15:29] i did update the message docs [08:15:48] and the translations are the same, only the format is slightly differnet, so changing the key would be destructive [08:16:10] and of course i can just ignore all languages but english [08:16:15] but i wanted to do it right [08:16:30] MatmaRex: Item #3 very explicitly addresses it. [08:16:58] so you're volunteering to do these for me? okay then [08:17:09] but i've done the work already. oh well, if that's the way [08:17:36] MatmaRex: It's mainly advised to prevent merge conflicts. [08:17:49] MatmaRex: And to make things easier on developers. [08:17:56] * MatmaRex wonders how long does it take for 300 fuzzied messages in 150 languages to get updated by translators [08:18:02] New patchset: Nischayn22; "Remove
as its not supported by jQueryMsg" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64551 [08:18:07] siebrand: the change will merge right now [08:18:21] siebrand: and if by developers you mean me, then i prefer doing things properly insteda of easily [08:19:16] siebrand: should i keep the patch as-is or remove the changes to all the message files? [08:19:56] MatmaRex: Once this is merged and processed, it would be nice if you checked on translatewiki.net if there are translations that had not yet been exported. [08:20:09] MatmaRex: Those are the ones you'll have missed here. [08:20:28] siebrand: how often are translations exported? [08:20:53] MatmaRex: Daily, but there are thresholds before adding new languages. [08:21:02] (or: mostly daily to be accurate) [08:21:37] siebrand: ah, you mean messages in other languages than these [08:21:39] sure, can do [08:23:10] MatmaRex: *nod* [08:26:25] siebrand: i assume that these languages simply don't have a MessagesXxx file? [08:26:42] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64525 [08:27:05] siebrand: because if that's the case, this only gives me language 'no', which seems a little weird [08:27:57] (unless that's mapped to some other code, i know there's some sort of a mess with norwegian in this regard) [08:28:09] (no = nb?) [08:30:18] MatmaRex: There are some 30-50 languages preparing support in MediaWiki that have a code in translatewiki.net, but not yet in MediaWiki. [08:30:58] MatmaRex: Before support for any of those languages is added, it first needs 100% localisation support on the most often used messages. About 500 messages of the 2800 or so in MediaWiki core. [08:31:11] siebrand: i just looked at https://translatewiki.net/w/i.php?title=Special%3APrefixIndex&prefix=wlheader-showupdated&namespace=8 and compared the list with the message files [08:31:25] (same for the other message, both only yield 'no') [08:31:34] MatmaRex: You can use Special:Translations/key. Much more usable. [08:32:01] MatmaRex: Make that: MediaWiki:Key. [08:32:43] siebrand: hmm, nice. but the prefixindex one is easier to copy and paste ;) [08:33:07] siebrand: so we're lucky and there's nothing else to do here? [08:33:32] New patchset: Santhosh; "Scroll the window to show language settings if necessary" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64553 [08:33:39] ah, no. [08:33:41] hm. [08:34:26] ah, yes. [08:34:39] i was comparing translations for one message with prefixindex for the other [08:35:29] siebrand: thank you :) [08:45:01] New patchset: Hashar; "enable unit tests for mw/ext/Echo" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64555 [08:45:53] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64555 [08:46:32] Change restored: Hashar; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [08:46:34] New patchset: Hashar; "validate jenkins job" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [08:47:29] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/36967 [09:02:51] New patchset: Nischayn22; "Properly center arrowheads text" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64556 [09:08:01] New patchset: Matmarex; "Clean up the watchlist reset button HTML" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64557 [09:23:23] New patchset: Santhosh; "Fix all jshint errors" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64558 [09:24:34] New patchset: Matmarex; "Clean up the watchlist reset button HTML" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64557 [09:27:00] New patchset: Platonides; "Move the global to the place it is needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64559 [09:39:09] New patchset: Santhosh; "Fix all jshint errors" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64558 [09:44:01] New patchset: Siebrand; "Make JSLint voting for UniversalLanguageSelector" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64561 [09:51:19] New patchset: Matmarex; "Remove the $wgHandheldForIPhone config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63343 [09:54:50] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64558 [09:57:08] New review: Nikerabbit; "The main issue with this change is that removes the ability for site admins to override the content ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/57518 [10:01:51] New patchset: Platonides; "SpecialPreferencesTest needs a db" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64562 [10:02:54] New patchset: Hashar; "doc: various updates" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64563 [10:04:28] New patchset: Amire80; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [10:17:12] New review: Matthias Mullie; "Alex Monk: Any chance you can post a screenshot of what's happening for you on Bugzilla? I've tested..." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61568 [10:25:06] New review: Amire80; "These lines were added in I5c3998b687fb92e3c90301edecb25b6a8306f423 . It breaks TUX behavior - the s..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64262 [10:32:53] New patchset: Amire80; "Provide disable input tools option in IME menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [10:33:14] New patchset: Amire80; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [10:34:21] New review: Hashar; "The databases queries are caused by the LinkCache object :/" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64562 [10:36:11] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64553 [10:38:37] New patchset: Hashar; "LinkCache singleton can now be altered" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64564 [10:40:46] New patchset: Matthias Mullie; "Substitute $.ajax for mw.Api" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [10:42:57] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [10:55:57] New patchset: Matmarex; "Set preference 'watchlisttoken' to type=api" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [10:57:15] New patchset: Nikerabbit; "Better way to fix jslint warnings" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64566 [10:58:58] New patchset: Matmarex; "Set preference 'watchlisttoken' to type=api" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [11:04:06] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64474 [11:04:24] Change abandoned: Nikerabbit; "Abandoning due I35c05e8" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64474 [11:10:22] New review: Njw; "Thanks for looking over this Matmarex. Yes, the margin changes are there for a reason, namely so tha..." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62797 [11:10:22] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62797 [11:10:39] New patchset: Amire80; "Remove a redundant CSS rule" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64567 [11:11:15] Nikerabbit: i think the 'SpecialRecentChangesPanel' hook is your doing - is it supposed to be fired only on RecentChanges, or could it be fired by subclasses like RecentChangesLinked as well? [11:15:37] New review: Njw; "I agree, this is sane and uncontroversial, I'll merge. Thanks for the review!" [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62604 [11:25:06] New patchset: Hashar; "test: inject autoloader in Maintenance class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64568 [11:25:07] New patchset: Hashar; "test: LinkCache no more rely on a database access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [11:26:58] New review: Hashar; "https://gerrit.wikimedia.org/r/#/c/64564/ LinkCache singleton can now be altered" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64562 [11:31:04] New review: Nikerabbit; "Png image is not optimized for size." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64270 [11:31:07] New patchset: Hashar; "test: LinkCache no more rely on a database access" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [11:31:26] New review: Hashar; "I forgot to git add the tests/phpunit/mocks/cache/MockLinkCache.php file :-D" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [11:31:35] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [11:38:14] New review: Nikerabbit; "Doesn't seem to fix the issue for me." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64567 [11:38:38] Change merged: Siebrand; [mediawiki/extensions/Configure] (master) - https://gerrit.wikimedia.org/r/63124 [11:39:00] New patchset: Nikerabbit; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [11:40:03] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/56903 [11:41:54] New review: Amire80; "(1 comment)" [mediawiki/extensions/TocTree] (master) C: -1; - https://gerrit.wikimedia.org/r/64295 [11:42:13] New patchset: Amire80; "Remove unused parameter." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63344 [11:42:31] New review: Nikerabbit; "It takes very long for the notifications to appear, and I get two of them." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/64279 [11:42:36] New patchset: Siebrand; "Change EXIF to Exif" [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/63125 [11:43:47] New patchset: Siebrand; "Change EXIF to Exif" [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/63125 [11:44:34] Change merged: jenkins-bot; [mediawiki/extensions/SemanticExtraSpecialProperties] (master) - https://gerrit.wikimedia.org/r/63125 [11:46:48] New patchset: Amire80; "Close unclosed element div" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63118 [11:47:10] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47837 [11:47:57] New patchset: Amire80; "Use correct casing for OutputPage::addHTML()" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63117 [11:48:34] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63117 [11:48:41] New patchset: Amire80; "Close unclosed element div" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63118 [11:49:10] New patchset: Santhosh; "Allow adding message documentation when translation is restricted" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64570 [11:49:25] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63118 [11:49:32] New patchset: Amire80; "Update code formatting and a few other nit picks" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63119 [11:51:14] Change merged: jenkins-bot; [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63119 [12:00:25] Change abandoned: Siebrand; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54326 [12:00:40] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/42261 [12:00:53] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/64295 [12:00:59] New patchset: TheDJ; "Better error messages." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [12:01:36] Change merged: TheDJ; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [12:03:28] New patchset: Matmarex; "Don't reinvent the wheel in SpecialRecentchangeslinked::getExtraOptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [12:04:05] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [12:04:30] Nikerabbit: https://gerrit.wikimedia.org/r/#/c/64571/ really could use your input, i'm poking some recentchanges things (small change, +- 20 lines) [12:04:42] New patchset: Amire80; "Remove a redundant CSS rule" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64567 [12:06:18] New review: Siebrand; "Ping?" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [12:07:13] New review: Matmarex; "Some implementation comments inline." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [12:07:58] New review: Nikerabbit; "Does QuickTemplate have access to context so that we could avoid calls to wfMessage directly?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [12:09:37] New patchset: Njw; "Allow custom banner image to be set using $wgEruditeBannerImg config option" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62604 [12:11:38] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [12:18:19] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/Translate] (master) C: -1; - https://gerrit.wikimedia.org/r/64570 [12:19:01] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63344 [12:19:52] New patchset: Santhosh; "Allow adding message documentation when translation is restricted" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64570 [12:20:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64572 [12:21:30] New review: Hashar; "That does not really work since the LinkCache actually does a lookup in the `page` table. I guess w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64569 [12:22:05] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63119 [12:27:22] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62604 [12:29:59] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [12:40:55] New review: Nikerabbit; "(1 comment)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [12:44:35] New review: Matmarex; "QuickTemplate has access to a Skin via getSkin(), and Skin extends ContextSource, so yes. I assumes ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [12:46:12] New patchset: Santhosh; "Add fonts for Syriac Armaic languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [12:56:43] New review: Njw; "Yeah, the read-only nature of the CSS is something I plan to address soon, to remove redundancy (the..." [mediawiki/skins/erudite] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62648 [12:56:44] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62648 [12:56:47] New patchset: XP1; "Fix typos in "jquery.textSelection.js"." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64573 [12:56:56] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [12:57:05] Nikerabbit: ^ [12:57:10] (thanks for the review) [13:05:11] Change abandoned: Siebrand; "(no reason)" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/63115 [13:09:42] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64571 [13:17:09] New patchset: Matmarex; "Don't reinvent the wheel in SpecialRecentchangeslinked::getExtraOptions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [13:17:43] New review: Matmarex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64571 [13:31:57] New patchset: Hashar; "test: rework interwiki lookup in parser tests" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64574 [13:32:08] New patchset: Andrew Bogott; "Add . to each sudoer host." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64303 [13:32:09] New patchset: Andrew Bogott; "Added getDisplayName and getFullyQualifiedDisplayName" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64302 [13:48:40] New patchset: Santhosh; "Add fonts for Syriac Armaic languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [14:13:15] New patchset: Matmarex; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [14:24:42] New patchset: Matmarex; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [14:25:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64559 [14:35:17] New patchset: EBernhardson; "Better detection of multiple changes in a document" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64577 [14:40:21] New patchset: EBernhardson; "Better detection of multiple changes in a document" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64577 [14:56:04] Yippie, build fixed! [14:56:05] Project browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome build #59: FIXED in 5 min 41 sec: https://wmf.ci.cloudbees.com/job/browsertests-commons.wikimedia.beta.wmflabs.org-linux-chrome/59/ [15:04:50] New review: Njw; "(replied to comments inline)" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [15:08:30] New review: Alex Monk; "http://i.imgur.com/Ur4JofN.png" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61568 [15:08:45] New patchset: Njw; "Various improvements to the footer columns" [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [15:19:13] New review: Njw; "Note that the msgWikiNoEdit() function is rationalised here: https://bugzilla.wikimedia.org/show_bug..." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/62623 [15:23:20] New patchset: Aude; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64581 [15:38:56] New patchset: Nikerabbit; "mediawiki.api: Implement login method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [15:38:57] New patchset: Nikerabbit; "mediawiki.api helpers: postWithToken and getToken" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64582 [15:59:25] New review: Reedy; "Messages need removing from messages.inc" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64565 [16:01:16] New patchset: Matmarex; "Set preference 'watchlisttoken' to type=api" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64565 [16:03:32] New patchset: Matmarex; "RecentChanges, RecentChangesLinked, Watchlist: message when no items" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64576 [16:04:09] New review: Reedy; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64243 [16:08:05] New review: CSteipp; "It looks right, and I really like the functionality. It would be good for Reedy to confirm that this..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/64450 [16:09:09] New review: Reedy; "Can we get an example?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:17:45] New patchset: Nikerabbit; "Allow comments by user when creating an account" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64588 [16:18:38] New review: Reedy; "I guess we need to build a list of $wgRedactedFunctionArguments additions for CentralAuth and add th..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:19:24] New patchset: Foxtrott; "fix bug (Mark-up does not reflect updated terminology)" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/64589 [16:22:00] New patchset: Alex Monk; "Redact certain function parameters from exception stack traces" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64590 [16:22:10] Change merged: Foxtrott; [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/64589 [16:22:52] New patchset: Nikerabbit; "Allow non-translators to sign up" [mediawiki/extensions/TwnMainPage] (master) - https://gerrit.wikimedia.org/r/64591 [16:25:35] New review: Reedy; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64450 [16:25:52] New review: Reedy; "And a RELEASE-NOTE entry, but that can be done before merging" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:31:59] csteipp: I know you're involved in new login work, could you read over https://bugzilla.wikimedia.org/show_bug.cgi?id=48642 and see if it needs escalation? [16:34:11] chrismcmahon: That shouldn't be related, but I'll check into it [16:35:31] chrismcmahon: It looks like something in the user login javascript-- can't create an account with an _ in the name either [16:36:02] i've no idea if that's supposd to work.. :/ [16:36:21] Though, we don't normalise usernames for the db ( " " -> "_") [16:36:36] Nope, we don't. _ is a valid username car [16:36:36] my bet is on ULS [16:36:50] New review: Parent5446; "> The main issue with this change is that removes the ability for site admins to override the conten..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [16:36:52] Reedy: csteipp our test user has had an underscore for a year now [16:36:54] chrismcmahon: why is the ULS popup showing that you're inputting in IPA? [16:37:30] chrismcmahon: it shouldn't even appear for English by default, afaik [16:38:18] chrismcmahon: Yep, it's something ULS or the acux team is doing. With noscript, I can create accounts with _ in the name :) [16:38:41] csteipp: yes, thanks [16:39:44] Nikerabbit: ^ Is that a uls thing? [16:40:23] csteipp: what? [16:40:46] Automatically translate _ to an underscored letter on the login box? [16:41:05] yep, sounds like uls [16:47:20] csteipp: we'll look into it [16:51:54] New review: Alex Monk; "I don't think we'll have issues with anything like "$request->getVal( 'wpPassword' );"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:53:39] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [16:57:14] New review: Nikerabbit; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [17:01:19] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [17:01:44] New patchset: Anomie; "Use CodeEditor for user css/js subpages" [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64593 [17:03:42] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:05:33] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [17:05:42] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [17:06:09] New patchset: Parent5446; "Enable fallback languages when retrieving messages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57518 [17:08:22] do we have a function to pretty-format time deltas? [17:08:30] like "3 days" or "12 hours" or "5 minutes"? [17:08:38] Reedy: ^ ? [17:09:15] hm, we have some messages for this [17:09:16] Language::formatTimePeriod9)? [17:09:18] Language::formatTimePeriod()? [17:09:19] look in Language.php [17:09:24] having a bit of a problem getting automated tests running within CI for the Echo extension, would like some pointers if anyone has any. Basically it creates the sqlite database then tries to apply the echo.sql which creates an index, and it fails because the index already exists: http://goo.gl/rxqVX [17:09:33] ah, time period [17:09:35] is it reasonable to change that to create index foo if not exists ? [17:09:41] english is my second language :P sorry and thanks [17:11:20] * ebernhardson now realizes thats not possible, because 'if not exists' is in sqlite, but not mysql :S [17:11:28] New patchset: Kaldari; "Adding short date format i18n strings to Language message files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [17:12:52] MatmaRex_, there was a discussion about pretty timestamps back in october on wikitech-l [17:13:23] Krenair: i know, but iirc as usually nothing came of it [17:13:28] New review: Matthias Mullie; "Oh, that empty space on the right is normal: a 300px width is preserved for the toolbox (for editors)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61568 [17:20:36] Ryan_Lane: You might be interested in https://gerrit.wikimedia.org/r/#/c/64450/ [17:23:58] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:24:36] Reedy: indeed. thanks [17:25:16] Hopefully just doing AuthPlugin in MW itself should fix it, at worst, you've a few config lines to add to the extension [17:28:50] since mediawiki database update scripts must be able to run on SqLite and MySql (and probably postgres and more) what is the apropriate way to write a cross-platform alter table statement? for example sqlite only supports limited alter table syntax [17:30:30] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64439 [17:33:14] New review: Kaldari; "If change Ie85d66af is merged, this will no longer be necessary." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63256 [17:36:35] hmm [17:36:42] would anybody cry if i killed $wgRCLinkLimits ? [17:36:45] !wg RCLinkLimits [17:36:45] https://www.mediawiki.org/wiki/Manual:$wgRCLinkLimits [17:39:11] hashar: ping. Hoping for some pointers regarding incompatibilities between sqlite and mysql preventing the echo extension from using jenkins for tests (basically update.php from mw fails before any tests are run) [17:41:01] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64529 [17:42:15] New patchset: Njw; "Fix header margin, that accidentally got botched in an earlier merge conflict." [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64597 [17:42:33] Change merged: Njw; [mediawiki/skins/erudite] (master) - https://gerrit.wikimedia.org/r/64597 [17:43:21] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61514 [17:45:16] New review: Spage; "greg-g OKd for backport." [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/64250 [17:45:26] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62442 [17:45:56] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:46:11] New review: Spage; "greg-g OKd for backport" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/64254 [17:47:27] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:48:11] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64250 [17:48:35] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:49:43] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64254 [17:51:50] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:56:45] New review: Kaldari; "@Lwelling: I'm not sure I understand your comment. Couldn't we have one i18n string for the plan tex..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/58312 [17:57:29] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [17:57:52] New patchset: Reedy; "Update Wikibase" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64581 [17:58:02] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64581 [17:59:55] New patchset: EBernhardson; "Rename user_timestamp index to prevent name clash" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [18:03:00] * AaronSchulz wonders if gwicke biked extra long to work today [18:06:40] New patchset: MarkTraceur; "Add UploadWizard role" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/64602 [18:07:01] Woo hoo vagrant [18:07:03] New review: EBernhardson; "I spent some time figuring out why echo wouldn't run its unit tests, the attached patch solves the ..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64594 [18:12:25] New review: Physikerwelt; "Why did you give -1" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64263 [18:16:40] New patchset: Siebrand; "Fix fatal, use Message::isDisabled()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64604 [18:17:13] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59720 [18:17:47] New patchset: MarkTraceur; "Add wipe-workspace to test jobs" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64605 [18:17:58] New review: Mdale; "looks good thanks." [mediawiki/extensions/TimedMediaHandler] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63417 [18:18:01] Change merged: Mdale; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/63417 [18:18:21] hashar: https://gerrit.wikimedia.org/r/64605 if you don't mind taking a look [18:19:15] Please review https://gerrit.wikimedia.org/r/#/c/64604/. It fixes a fatal. Ping AaronSchulz [18:27:44] ori-l: Question about vagrant; should site.pp be .gitignored with the default in site.default.pp or something? (lazy developer hates writing "git add") [18:28:24] New review: Parent5446; "Yep, seems when I rebased something happened." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64604 [18:29:36] * marktraceur looks at how to do that [18:30:15] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64606 [18:30:21] New patchset: Reedy; "Make checkUsernames.php use batches" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64243 [18:31:03] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64604 [18:33:11] we are aware that vector is broken? [18:34:02] jorm: define 'broken' [18:34:04] TypeError: 'undefined' is not a function (evaluating 'mw.hook('wikipage.content')') [18:34:08] jorm: i can point you to some 50 bugs i want fixed [18:34:12] http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Something.27s_wrong_again [18:34:14] did something got deployed today ? [18:34:26] blargh, there was some hook trouble last week [18:34:29] i just looked through the twitter feed and didn't see anything that would do anything. [18:34:39] Krinkle did something to solve it afaik [18:34:49] just a deployment issue [18:34:59] the code works, but old versions of files being served, or something like that [18:35:03] Reedy: ^ [18:35:12] Indeed, rscync took too long, mediawiki.util.js got cached together with an old mediawiki.js [18:35:17] thus the call was there but the method was not [18:35:36] (man, i'm on irc too much, explaining deployment fails to wmf employees. :P ) [18:35:45] It's a miracle it hasn't failed before, this has always been a fragile race condition with rsync and live apache nodes [18:36:07] It's not everybody's job to know operations :) [18:36:08] is it going to fix itself, or should we do something? [18:36:08] But that file hasn't changed since last week [18:36:08] Krinkle, to fix does someone touch a .js file and sync that? [18:36:48] spagewmf: touching it isn't a fix, but if done in the right order and patience it will be a "fix" for some scenarios. [18:36:52] 'cause I'll just say that it's a caching error froma deployment and it will resolve itself. [18:37:22] thedj: You are getting that mw.hook undefined error *now* ? [18:37:27] Krinkle: yes [18:37:35] thedj: which wiki? [18:37:39] en.wp [18:37:40] logged in or out? [18:37:43] logged in. [18:37:45] https? [18:37:48] yes [18:37:57] thedj: I see it too [18:38:04] Checking now [18:38:46] and i'm not getting it with ?debug=true it seems, makes debug rather difficult [18:39:20] thedj: debug is also cached, but that url was first requested a life time after a deployment [18:39:40] I mean, the cache is built on the fly. Someone initially hit bits while rsync was ran (not debug mode) [18:39:49] so that minified package got the old version of mediawiki.js [18:40:22] purging cache is not an option [18:40:26] Krinkle: Do you need me to do some touches to clean this up? [18:40:43] RoanKattouw: I did that last week. I don't understand how this could happen again [18:40:46] RoanKattouw: I'm syncing now [18:40:48] OK [18:41:01] It happened because our deployment "system" sucks [18:41:09] * RoanKattouw patiently awaits git-deploy [18:41:30] New patchset: MarkTraceur; "Move site.pp to e default, ignore site.pp" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/64609 [18:41:48] e default? The hell? [18:42:01] Past marktraceur, what were you smoking [18:42:12] New patchset: MarkTraceur; "Move site.pp to a default file, ignore site.pp" [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/64609 [18:42:24] New patchset: Mwjames; "SMW\HooksHandler create testable and separable hooks instantiation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64610 [18:43:10] guys, what can i say to the public? [18:43:48] RoanKattouw: Last week the deployment included a commit that changes 2 files where 1 file introduces a method that is called by the other [18:43:57] RoanKattouw: The emtime on the caller was higher [18:44:18] There are JS-related errors all over the site. Echo is broken as well. [18:44:24] RoanKattouw: Cache got created between the two files being synced (same sync command, but it isn't atomic so this can happen) [18:44:36] Yes [18:44:45] jorm: It's being fixed [18:44:51] It should be impossible to happen again, any sync since can't possibly un-define mw.hook again in mediawiki.js [18:44:57] I synced it [18:45:00] should be live within 5 minutes [18:45:03] Yeah [18:45:14] already fixed for me. [18:45:20] So fixed now, but there's a 5-10 minute delay between him fixing it and people actually perceiving it as fixed [18:45:25] mw.hook isn't just undefined at run time. Any en.wiki page shows mw.hook being undefined even after load time from console. [18:45:47] Reporter over in -tech also reports it's fixed [18:46:10] RoanKattouw: Any idea how a sync could re-introduce an old version of a file? It see en.wiki is still on wmf4, same branch as last week. [18:46:19] I touched and synced the exact same file. [18:46:25] Edokter also reporting it fixed. [18:46:45] Krinkle, en.wiki was on wmf3 last week wasn't it ? [18:46:48] Krinkle: Hmm that sounds like something that should not have happened [18:46:56] But yeah enwiki went wmf3->wmf4 today [18:46:59] thedj: True, the problem was on a different wiki past week [18:47:00] thedj: it was on commons last week afair [18:47:03] Should've just been a config file change though [18:47:04] Yes [18:47:16] commons was on wmf4 last week [18:47:23] Oh, wait a damn minute [18:47:29] I take it mw.hook is a new module? [18:47:33] RoanKattouw: no [18:47:38] RoanKattouw: It's in mediawiki.js [18:47:42] Hah [18:47:47] So mediawiki.js changed between wmf3 and wmf4? [18:47:54] RoanKattouw: Yes [18:48:06] That should /definitely/ have caused an invalidation [18:48:15] I don't see how it's even possible that that got mis-cached [18:48:16] RoanKattouw: There was a single commit in which mediawiki.js got mw.hook and mediawiki.util.js calls it [18:48:35] Somehow en.wiki bits built a wmf4 cache with the new version of mwutil and the old version of mw.js [18:48:50] Which is odd, because mw.js should have an updated mtime [18:49:01] There is a way in which this could have happened [18:49:02] If someone touched mw.js to fix a different issue in wmf3 [18:49:10] And in doing so made its mtime greater than wmf4's [18:49:28] Change merged: jenkins-bot; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63269 [18:49:29] RoanKattouw: I'm not sure I folllow [18:49:35] RoanKattouw: This is in a different branch [18:49:42] different directory [18:49:59] cache uses absolute paths, right? [18:50:20] RoanKattouw: Ah, I see [18:50:24] Nope, that cache doesn't [18:50:27] mw and mw.util are separate modules [18:50:48] so mw as a whole (single file) didn't raise in mtime from wmf3>wmf4 [18:51:24] RoanKattouw: I thought for a second the 2 files were in the same module, because in that case the older mtime shouldn't have been an issue [18:51:30] if one file is re-minified the entire module is. [18:51:34] But they're in separate modules. [18:51:48] Interesting, so it is the same problem as last week. Not a different cause. [18:52:23] Which means this wouldn't have been prevented even if rsync was atomic [18:52:58] Yeah [18:53:06] Well, like I said, your touch last week probably caused this week's problem [18:53:26] RoanKattouw: In that case we have yet another reason to change RL's cache-time-expire-invalidate logic [18:53:36] RoanKattouw: No, that was in wmf4 as well last week, not wmf3 [18:53:46] last week it happened when commons went 3 to 4 [18:54:01] Right [18:55:10] RoanKattouw: Remember the problem where cache goes wrong if an old file is removed, or new message keys are added with older mtimes etc. Our ideas to fix that bug were to also make a hash of the module params and cache those and invalidate at time(now) if the hash mis-match [18:55:23] (similar to how we invalidate wgConf values in rl language data module) [18:55:32] Yeah [18:55:33] Let's also include hashes of file contents in that. [18:55:41] Well, ideally we wouldn't [18:55:49] More expensive, right? [18:55:54] The whole point of timestamps is that we don't have to build the response just to decide whether to serve it [18:55:57] Because we don't have the contents in memory already [18:56:08] Right [18:57:08] Yeah, I can see how that gets too much. It wouldn't get to building the response just yet, this would "only" be reading the contents. [18:57:15] The calculation is done from the startup module [18:58:02] But still, reading *all* files every 5 minutes, is that too much? I don't know. startup is cached pretty good. It'd only be a few hits every 5 minutes. [18:58:15] New patchset: Hashar; "newlines in wfDebug() calls" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64614 [18:58:18] we already read mtime of every file in the registry. [18:58:25] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [18:58:31] Yeah we already stat them and that's quite a lot of FS activity [18:58:41] RoanKattouw: Anyhow, lets solve that other bug first (actually has the module params array), that'll already fix various bugs. [18:58:47] yeah [19:00:05] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [19:00:49] New review: Siebrand; "Can you please get some agreement about this change on the design list? This is an often used featur..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:02:16] New review: Matmarex; "This is a draft; the only reason it wasn't submitted as one is because gerrit drafts suck and I welc..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:02:56] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64615 [19:03:16] New review: Swalling; "I'm inclined to agree with Siebrand. I don't think this is a huge deal, but it would at least be goo..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:05:16] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:06:56] New patchset: Kaldari; "Copy tweaks to Echo Notification Emails per https://bugzilla.wikimedia.org/show_bug.cgi?id=47846" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61477 [19:06:57] wow, these are like the quickest reviews i've ever gotten ^ [19:07:44] MatmaRex_: your lucky day [19:07:57] MatmaRex_: that is the busy hour) [19:07:59] New review: Matmarex; "Swalling, chill out, there'll be screenshots once I finish this :) For now you can see some mockups ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:08:10] New patchset: Kaldari; "Copy tweaks to Echo Notification Emails" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/61477 [19:22:59] New review: CSteipp; "Looks right to me now" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64243 [19:23:08] New patchset: Reedy; "Clean-up: delete modifications for old Bugzilla versions" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62315 [19:25:04] New review: Reedy; "Yup, looks like it worked. some of the files can't have been changed in ages as it's pulling the old..." [wikimedia/bugzilla/modifications] (master) C: 1; - https://gerrit.wikimedia.org/r/62315 [19:25:22] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64243 [19:28:57] New patchset: Matthias Mullie; "Make it slightly easier for extensions to hook into page protection." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [19:29:34] New patchset: Matthias Mullie; "When changing AFT visibility in action=protect, add to log" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64621 [19:30:02] New review: Matthias Mullie; "This patch depends on https://gerrit.wikimedia.org/r/#/c/64620" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -2; - https://gerrit.wikimedia.org/r/64621 [19:30:12] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64606 [19:30:29] New review: Matthias Mullie; "Example on how these are used by an extension: https://gerrit.wikimedia.org/r/#/c/64621" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64620 [19:30:44] New patchset: Reedy; "Add tracking category in case of broken " [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63268 [19:31:50] Change merged: jenkins-bot; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63268 [19:33:27] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMaintenance] (master) - https://gerrit.wikimedia.org/r/63594 [19:35:12] New patchset: Reedy; "resourceloader: Consistently use 'resourceloader' log group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62189 [19:39:16] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62189 [19:39:29] New patchset: Reedy; "resourceloader: Write to debug log for all fatal errors" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62190 [19:41:31] New review: Krinkle; "(1 comment)" [mediawiki/extensions/CodeEditor] (master) C: -1; - https://gerrit.wikimedia.org/r/64593 [19:42:04] New patchset: Matmarex; "SpecialRecentChanges: Rewrite the options form" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64615 [19:44:17] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62190 [19:45:55] MatmaRex_: pig [19:45:57] ping* [19:46:06] https://gerrit.wikimedia.org/r/#/c/63287/ [19:46:23] Can you explain this "funkiness?" [19:46:37] I am experiencing the exact opposite and am about to revert that asap [19:47:00] Without the space, non-css context (copying pasting, screenreading, css load failure) will not have a space [19:47:09] e.g. "Biography[edit]" [19:47:16] instead of "Biography [edit]" [19:47:31] The space is collapsed by the graphical renderer [19:48:23] Krinkle: yes, i realize. i consider it a necessary evil and still good enough [19:48:28] and no, it's not collapsed [19:48:32] it's both visible and selectable [19:48:42] MatmaRex_: Yes, that's by design [19:48:51] i've had people complain about it, so i removed it [19:49:09] MatmaRex_: It isn't a necessary evil if the only effect is a bug. [19:49:11] MatmaRex_: What does it fix? [19:49:16] i mean, the space is selectable. the [edit] link shouldn't be (this is done via CSS) [19:49:33] So make the space unselectable? [19:49:48] Krinkle: it makes it less annoying to select header by triple-clicking them, and it removes the additional "padding" caused by the space's presence [19:49:55] s/header/headings/ [19:49:59] MatmaRex_: And no that is *not* done via CSS [19:50:08] [edit] is fully selectable [19:50:15] the [edit]'s selectability? yes, it is, i've done it [19:50:19] then your browser doesn't support this [19:50:25] user-select: none; [19:50:26] Well, then it is broken. [19:50:33] That isn't supported in *any* browser [19:50:44] it's supported by at least IE 10 apparently [19:50:50] and i think Firefox too [19:50:51] http://css-tricks.com/almanac/properties/u/user-select/ [19:50:57] Only prefixed [19:51:06] it is prefixed, of course. [19:51:09] i think. [19:51:49] It is prefixed [19:51:49] .mw-editsection, .editsection, .toctoggle { -moz-user-select: none; -webkit-user-select: none; -ms-user-select: none; user-select: none; } [19:52:03] Appears to be a bug in Chrome, if you select the entire block, it ignores user-select [19:52:31] Anyhow, the space should not've been removed. It wasn't an issue when the space was before the heading because it is collapsed in rendering [19:52:38] but now that it is after the heading, it became selectable [19:52:52] Krinkle: what did oyu mean by "exact opposite" earlier? does this really break something? [19:53:03] the space is *not* collapsed [19:53:12] because the [edit] links is just an inline-block [19:53:16] and the heading is text [19:53:18] so the space stays [19:53:30] MatmaRex_: Well, the bug you fixed isn't a real breakage either. They're both inconveniences. I just happen to care more about the one you introduced than the one you fixed. [19:53:31] ah, sorry, i misread. yes. [19:53:52] Krinkle: i still don't understand what does this change actually break [19:53:56] It is selectable now, it wasn't when [edit] was before heading in the DOM. [19:54:10] MatmaRex_: If you select the entire heading, there is no longer a space between text and [edit] [19:54:14] That's the bug [19:54:22] Krinkle: no, that's the fix. [19:54:41] (by which i mean, i believe the current way is right, and the older one was wrong.) [19:54:51] MatmaRex_: No, what you intended to fix is to not have a trailing space that is hard to unselect when dragging [19:55:03] not to mention thta this is apparently a browser bug [19:56:20] Krinkle: no. what i intended to fix was not to have a trailing space that is always selected when triple-clicking the heading and which becomes un-unselectable since you're not dragging anything. [19:56:31] Regardless of user-select support, I consider it a best practice to never join 2 separate elements without space in the DOM when that is not to be visualised like that [19:56:55] Krinkle: it is okay to be visualized like that. [19:57:11] or at least i believe it is. [19:57:21] No, you obviously don't want to visualise "Biography[edit]" instead of "Biography [edit]" [19:57:48] i clearly do [19:58:00] and none of the people i added as reviewers objected [19:58:03] That makes no sense, why would you intend to visualise lack of spacing? [19:58:12] so that makes seven people who don't mind it [19:58:14] I'm not talking about selectability. [19:58:35] No, that makes 7 people who didn't execute a certain use case and as such did not experience the regression they would no doubt object. [19:59:18] Krinkle: feel free to mail them then [19:59:29] we could wrap that space in a or something [19:59:35] but that seems a little excessive to me [20:00:07] That is a pointless excersise as I consider myself more than qualified to know this from basic usability. If you feel the need to ask anyone you are probably thinking of something else. [20:00:11] MatmaRex_: Dragging the cursor over the heading should stop the block at the end of the heading text. [20:00:13] Agreed? [20:01:08] Krinkle: i understand what you're saying. i just disagree. [20:01:55] The previous statement was intended to find common ground. [20:01:58] I just described the exact bug you claim to have fixed, you're current disagreement makes no sense. [20:02:28] Dragging previosly continued for an additional space. [20:02:38] That's bad for usability. [20:02:41] Krinkle: i just have no idea what you're interrogating me about right now. yes, that was the bug i fixed, we both know this. [20:02:56] New patchset: Reedy; "Few bits of documentation related cleanup" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64622 [20:03:59] MatmaRex_: Well then, we're done.