[00:24:25] New review: PleaseStand; "(1 comment)" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64480 [00:39:41] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53923 [00:42:06] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48417 [00:45:11] New review: Alex Monk; "* Why are we creating variables like this then only using them once?" [mediawiki/extensions/PageTriage] (master) C: -1; - https://gerrit.wikimedia.org/r/61351 [01:06:45] New patchset: MarkAHershberger; "Revert "Disable chunked uploads for the 1.21 release."" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64507 [01:07:38] New review: MarkAHershberger; "Reverting un-reviewed change that I self-committed." [mediawiki/core] (REL1_21); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64507 [01:07:39] Change merged: MarkAHershberger; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64507 [01:34:17] New review: Alex Monk; "Now it only takes up part of the width of my screen..." [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/61568 [04:43:02] New review: Nischayn22; "* I will try making a global api variable that can be used everywhere." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61351 [05:08:28] New patchset: Nischayn22; "Link to custom copyright tags were wrong." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/53041 [05:17:22] New patchset: Umherirrender; "Add page language to prop=info" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64512 [05:38:06] New patchset: Nischayn22; "licenseInput: Handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [05:38:10] thedj[work]: Hey, I could use your help in a couple of UW patches [05:38:47] New review: Nischayn22; "Still unable to test this :(" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [05:40:57] Nischayn22: The redirects patch? Why can't you test it? [05:41:51] marktraceur: I tried it out but the code never executes, I thought it had something to do with templates being present in the wiki? [05:43:17] Nischayn22: Yeah, but you can make a really simple template to test it [05:43:44] Nischayn22: See my comment on PS4 [05:49:27] marktraceur: I created the templates, but on entering "{{PD-Blah}}" in "Another reason not mentioned above" the dialog opens up without any text [05:49:56] Huh. [05:50:26] marktraceur: Something seems to be wrong with my config I guess, I put an alert but it never executes :( [06:18:48] New patchset: Nischayn22; "Code style improvements" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64513 [06:19:08] New patchset: Rfaulk; "add. usage details to readme." [sartoris] (master) - https://gerrit.wikimedia.org/r/64514 [06:19:08] marktraceur: ^ this one just needs a quick look :) [06:20:04] Change merged: Rfaulk; [sartoris] (master) - https://gerrit.wikimedia.org/r/64514 [06:51:32] New patchset: Nischayn22; "Code style improvements" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64513 [08:02:09] New review: Nischayn22; "I don't like this workflow but this works good." [mediawiki/extensions/UploadWizard] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/61289 [09:44:24] New patchset: Foxtrott; "bugfix (Exception: Serialization of 'Closure' is not allowed)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/64515 [09:52:34] New patchset: Foxtrott; "bugfix (Exception: Serialization of 'Closure' is not allowed)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/64515 [09:54:22] New patchset: Foxtrott; "bugfix (Exception: Serialization of 'Closure' is not allowed)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/64515 [09:58:08] New patchset: Foxtrott; "bugfix (Exception: Serialization of 'Closure' is not allowed)" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/64515 [09:59:26] Change merged: Foxtrott; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/64515 [11:32:31] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50755 [11:36:45] New review: TheDJ; "If I press "Add another file" which again is a duplicate, I get the same problem again. They share t..." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/50760 [11:51:22] New review: QChris; "Patch set 1 has meanwhile been accepted upstream." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64444 [11:52:06] New review: QChris; "Patch Set 1 has meanwhile been merged upstream" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64485 [12:03:44] New patchset: TheDJ; "Remove unnecessary clears" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [12:07:53] New review: TheDJ; "Looks good to me. I submitted a followup for the clears issue." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62439 [12:11:07] New patchset: TheDJ; "display: inline-block for .errorbox, .warningbox, .successbox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [12:12:57] marktraceur: Got it working now :) [12:19:20] New patchset: Matmarex; "display: inline-block for .errorbox, .warningbox, .successbox" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [12:20:29] uhh thedj [12:20:36] mid-air collision? i just rebased it myself, too :P [12:23:19] yup :D [12:23:29] and I made an error in the rebase [12:23:50] so thx :D [12:23:54] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [12:28:08] New review: TheDJ; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60259 [12:33:59] New review: TheDJ; "3 whitespace nitpicks." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60088 [12:43:42] thedj: http://meldmerge.org/ [12:44:01] New patchset: Nischayn22; "licenseInput: Handle redirects for license templates" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [12:44:04] it will change your life. [12:48:13] New review: Nischayn22; "Thanks TheDJ for the info, I am now able to test this." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50755 [12:48:21] New patchset: TheDJ; "Fixes for most JSHint warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/59064 [13:00:39] New patchset: Santhosh; "Add fonts for Syriac Armaic languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64518 [13:00:39] New patchset: Santhosh; "Update webfonts test page" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64519 [13:02:12] New patchset: TheDJ; "Remove unnecessary clears" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64517 [13:08:24] New review: Alex Monk; "I think you can keep creating Api objects, but not storing them as variables. You only need to use t..." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61351 [13:09:57] New patchset: Nischayn22; "Add a redlink to dead duplicate file links" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [13:20:17] New review: TheDJ; "Verified and approved." [mediawiki/core] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/47225 [13:20:19] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/47225 [13:30:54] New review: Matmarex; "Whoops." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/60259 [13:40:48] New patchset: Nischayn22; "use mw.Api() instead of ajax" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/61351 [13:41:26] New patchset: Matmarex; "Remove the $wgHandheldStyle config variable entirely" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60259 [13:42:09] thedj: ^ [14:08:58] New patchset: Nischayn22; "fixing opera bug" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64520 [14:29:28] New patchset: Alex Monk; "On submitted revdel form, prefill selected reason dropdown" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64521 [14:30:40] New review: Matmarex; "What Opera bug? Opera bugs usually just highlight real issues with the application." [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/64520 [14:47:50] ohhhh crap [14:47:59] i just accidentally opened all of the Messages files at once [15:12:00] New patchset: TheDJ; "Math: Upgrade MathJax to v2.2" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64522 [15:21:34] New review: Nischayn22; "https://bugzilla.wikimedia.org/show_bug.cgi?id=48091" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/64520 [15:26:25] New patchset: TheDJ; "Math: Enable MathJax's Safe mode" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [15:47:50] New patchset: QChris; "Sort voting columns alphabetically in the approval table" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64524 [15:55:33] New patchset: Matmarex; "SpecialWatchlist: Page header cleanup" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64525 [15:58:37] New review: QChris; "Upstream has a corresponding, non-working, and abandoned change at the same Change-Id:" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64524 [16:16:33] New patchset: Parent5446; "Removed Closure type hints where not needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53923 [16:19:07] New patchset: Parent5446; "Make maintenance/userOptions.php subclass Maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48417 [16:21:33] New patchset: Parent5446; "Removed Closure type hints where not needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53923 [16:23:34] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64243 [16:24:59] New patchset: TheDJ; "Math: Prefer the STIX font if available on the computer of the user" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64527 [16:28:24] New patchset: Parent5446; "Make maintenance/userOptions.php subclass Maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48417 [16:30:05] New patchset: Alex Monk; "Set title to Special:Revisiondelete on action=revisiondelete" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64528 [16:31:28] New patchset: Parent5446; "Make maintenance/userOptions.php subclass Maintenance" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/48417 [16:40:08] New review: MZMcBride; "Jack Phoenix pointed out that this is a very subtle code change with a large impact. It should have ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64277 [16:55:06] New review: Matmarex; "Screenshots:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64525 [17:09:54] New patchset: Alex Monk; "Removed Closure type hints where not needed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53923 [17:15:21] Change restored: TheDJ; "reviving" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/4060 [17:16:13] Shouldn't delete pages deliver a 404? [17:16:34] Which namespace? [17:16:43] Susan: All?! [17:17:58] $ curl -Is https://en.wikipedia.org/wiki/Squealing_pig | head -1 [17:17:58] HTTP/1.1 404 Not Found [17:18:11] The User namespace acts differently. [17:18:48] https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Jokakassel/W._%26_L._Jordan_GmbH -> 200 OK [17:18:53] The User namespace acts differently. [17:19:00] why? [17:19:04] Maybe User talk as well, dunno. [17:19:21] To flood google? [17:19:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=46491 [17:20:30] ... MediaWiki -.- [17:29:18] New patchset: Hoo man; "Non existent user subpages should return 404" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64529 [17:29:51] Writing that patch almost took me a minute... [17:30:12] hoo: getting it merged will take you a month ~ [17:30:31] hoo: also, up for some code review? :P [17:31:57] MatmaRex: Not atm... but feel free to add me to changes ;) [17:34:06] New review: Matmarex; "I submitted a bunch of changes to some extensions, to update them after this change and I6a6c12a9: h..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365 [17:34:08] New patchset: Parent5446; "Fix return type of MessageCache::getMsgFromNamespace for existing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64277 [17:45:08] New patchset: Hoo man; "Non existent user subpages should return 404" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64529 [17:46:17] New patchset: Hoo man; "Non existent user subpages should return 404" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64529 [18:01:48] New patchset: TheDJ; "Math: Adding archaic greek symbols from teubner set" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/4060 [18:03:08] New patchset: TheDJ; "Math: Adding archaic greek symbols from teubner set" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/4060 [18:06:55] New patchset: TheDJ; "Math: Add \Q, \H and \AA texvc commands to MathJax" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64530 [18:13:43] New patchset: TheDJ; "Math: Add texvc alias \image to MathJax" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64531 [18:24:09] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64529 [18:26:40] New patchset: Alex Monk; "Added SSL verification to PHPHttpRequest." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54584 [18:28:00] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53923 [19:12:25] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/64523 [19:32:57] New patchset: TheDJ; "Math: Enable MathJax's Safe mode" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64523 [19:36:29] MatmaRex: you have IE ? [19:37:13] thedj: IE8 [19:37:24] thedj: and a VM with IE6 inside, if you really really need it [19:37:25] did you test https://gerrit.wikimedia.org/r/#/c/60123/ with IE ? [19:37:55] i think i did [19:37:56] cause i'd +2, but i'm a bit uneasy about potential IE6/7 regressions. [19:37:59] does it break? it shouldn't [19:38:09] this just raises the value [19:38:25] put it on browsershots or something [19:38:27] ie6 had some z index issues if i remember. [19:39:02] thedj: i'd start up the VM, but my system is already swapping [19:39:21] or maybe i will anyway [19:39:48] hmm, ok. well my local network is not accesible from outside, so browsershots doesn't really work for me. [19:41:03] New patchset: Nischayn22; "updated ROADMAP with current issues." [mediawiki/extensions/SemanticSignup] (master) - https://gerrit.wikimedia.org/r/64532 [19:41:21] thedj: you know, it's funny, a full Windows XP VM takes less RAM than a browser [19:41:31] rofl [19:41:41] this never ceases to amaze me [19:42:34] i wouldn't be surprised if the average browser has more lines of code than a 15 year old OS. [19:44:09] thedj: so yeah, seems not to break, or IE is really good at caching [19:44:48] Change merged: TheDJ; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60123 [19:45:06] i have no idea how to check if it's caching it, to be honest [19:45:26] i've borked something and i cant copy-paste to or from the VM [19:45:45] ?debug=true bypasses cache [19:46:01] unless you have thefiles cached with debug=true as well [19:46:12] (i tried that and it looked good, too) [19:46:16] the VM has been hibernated [19:46:19] since, like, january [19:46:47] you should try not updating a mediawiki dev tree for 4 months. [19:47:12] um, how bad can it be? [19:47:46] php cache, memcache and language dbs + db upgrade... [19:48:02] heh, okay [19:48:25] == not working website for 30 minutes till i found all the maintenance script to trigger all the rebuilds :D [19:56:13] New patchset: Balloonguy; "Warn if page was edited while deletion was being confirmed" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64533 [20:23:24] New patchset: Aaron Schulz; "Made SwiftFileBackend::loadObjectListing() populate stat entries in reverse order." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64534 [20:42:48] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) C: -1; - https://gerrit.wikimedia.org/r/47837 [20:44:45] New patchset: Dan Bolser; "tidying up layout of SD 'filters'" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64535 [20:44:45] New patchset: Dan Bolser; "simplifying scale calculation" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64536 [20:44:45] New patchset: Dan Bolser; "adding log-scale option for tag-cloud" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/64537 [21:08:35] New review: TheDJ; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/47868 [21:22:22] New review: TheDJ; "@Rasel160" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [21:26:56] New review: Rasel160; "thanks!! :D" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/61339 [21:55:49] Change merged: TheDJ; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/55874