[00:00:18] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [00:00:47] New review: EBernhardson; "Updated the tests to use regexp instead of direct string comparison, should be more resilient to hos..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [00:02:01] New patchset: Mwjames; "Improve doxygen group definition generation" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64233 [00:04:19] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64233 [00:12:16] New patchset: Mwjames; "In test files use appropriate @ingroup" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64235 [00:12:34] New patchset: Adamw; "minor payment_submethod cleanup" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64236 [00:13:21] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [00:13:39] New patchset: Mwjames; "In test files use appropriate @ingroup" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64235 [00:15:54] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64235 [00:17:16] New patchset: Krinkle; "phpcs: More require/include is not a function" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64237 [00:19:12] New review: Mattflaschen; ""There should be no need to reinvent jquery.badge. The notif count and class are still added from ja..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63993 [00:20:06] jorm: "I thought you'd want to learn a bit about your culture..." wow :s [00:20:22] i know, right? [00:22:07] New patchset: Kaldari; "HTMLCheckMatrix support for forcing options on/off" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61163 [00:42:47] AaronSchulz: Want to review/merge https://gerrit.wikimedia.org/r/#/c/64243 so I can run it? :p [00:50:33] * mooey smirks [00:50:41] the lists have these hilarious moments. [00:51:55] mooey: The Flower thread? [00:53:11] marktraceur: among others, yeah [00:53:31] Holy gods netsplits [00:53:40] that and there was another thread not from the list, but from some talk page that was similarly interesting [00:54:32] * mooey is about to write to the list too [00:54:58] but my brain is mush. Maybe I should wait with it 'till after I fully recover from today's exam. [00:58:14] mooey: Maybe a good plan [00:58:33] Though we tend not to judge. If it's something super-important and not urgent, maybe sleep first :) [01:01:53] It's just an update about the extension [01:02:13] Ah, cool beans [01:04:16] New patchset: Mwjames; "SMW\MessageFormatter class" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [01:09:32] New review: Mwjames; "I'll left the renaming of the interface for now, if the general opinion is that naming an interface ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [01:15:50] * mooey hit send [01:16:06] marktraceur: if you get an email with RTL gibberish, then you were right, I should have slept first. [01:16:53] mooey: Or it means we should have learned to read RTL [01:17:22] marktraceur: I was just whining about RTL in the other channel :P [01:17:24] use a mirror [01:17:44] would that be gninihw? [01:18:14] mooey: Most useful search engine ever: https://duckduckgo.com/?q=reverse+proxy+apache [01:18:41] After I stopped being pissed off at it, I couldn't stop giggling [01:18:46] * Reedy guesses marktraceur has never heard of Google [01:18:59] I was... about to ask. [01:19:38] Reedy: Isn't that, like, a million millions? [01:19:55] Though I'm not sure you've spelled it right [01:20:27] Reedy: Actually I should switch back to seeks, it's back up now [01:20:34] hm.. did my email even pass the list? [01:20:45] Yup! [01:20:48] I got it [01:20:51] oh ok [01:21:05] thanks, I didn't get it yet. weird. [01:21:18] mooey: It might not send it to you necessarily [01:21:30] Though I thought that was how wt-l did it [01:22:54] I thought i set it up so it does [01:22:57] I think I got my previous ones [01:23:06] anyways, just wanted to make sure I didn't send to .. like.. somewhere else. [01:23:07] :P [01:24:57] I think there's an option in mailman for if you get your own emails [01:25:15] yeah I thought I set it up to send, but maybe not [01:30:35] btw, I am starting to think about cache options, but it seems that things like memcached are only good for big sites (and require memcached to be installed? I think?) ... do you think it's good practice if I create some temporary caching solution with database tables? [01:30:38] New patchset: Spage; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64250 [01:30:38] or is that discouraged? [01:31:15] mooey: Caching for your extension? [01:31:22] yeah [01:31:37] mooey: We already support that [01:31:38] instead of it querying gerritweb at every pageload [01:32:02] s/gerritweb/gitweb/ [01:32:15] If its really expensive use wfGetCache( CACHE_ANYTHING ); [01:32:34] gitweb, yes, sorry, i keep getting confused on those [01:32:55] Which will use memcache if available (technically whatever the main cache is set to), and if all else fails will fallback to the db [01:33:02] hmmm. [01:33:31] well the extension page shouldn't be getting loaded all that often should it? caching might be better worked on our end. [01:33:56] interesting. I'll check into that. [01:35:03] p858snake|l: it shouldn't, but there also shouldn't be a need for it to call update that often, I think. [01:35:43] hm. Well, it would be good if there's cache on the service side, too. I think half of it will also be solved if i switch to reading off of the GitHub mirrors [01:35:54] their json API should handle the load. [01:36:34] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [01:42:11] hm, license.. I didn't even think about that.... [01:45:31] yes, the upload form is broken and displaying the default message [01:45:46] normally there is a big "license your uploads message" [01:48:51] New patchset: Brian Wolff; "Shorten our in-comment urls to the whatwg HTML spec." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63407 [01:49:42] New review: Brian Wolff; "PS2 was rebase." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63407 [01:50:18] hmm. I'd love to put up a commons message.. copyleft... but I can't manage to do that in text [01:50:26] and the docs aren't clear about what template I'm supposed to use :\ [01:50:35] help? [01:50:51] http://commons.wikimedia.org/wiki/MediaWiki:Licenses <-- I see this [01:51:51] or do I need to add it manually in text? [02:00:09] COM:L [02:00:20] mooey: I'm not sure what you're asking [02:00:55] What license do you want to upload your file under. Is it a screenshot of GPL software (like MediaWiki)? [02:01:19] (in which case it would be {{free screenshot|license=GPLv2}} i think, or something like that) [02:04:02] New patchset: Brian Wolff; "Add fa to collation list." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64251 [02:06:07] mooey: Actually it would be either {{MediaWiki screenshot}} or {{free screenshot|license={{GPLv2+}}}} I believe [02:07:25] yeah I just didn't know what the actual wording for the template was [02:08:20] bawolff: http://www.mediawiki.org/wiki/File:Extstatus_screenshot.png <-- see, it doesn't render.. I tried the 'self|...' thing, didn't render either... I'm confused. [02:08:49] oh! {{free screenshot|license={{GPLv2+}}}} <-- that one works [02:09:15] mooey: This is a great advertisement for commons usability - even the programmers can't make it work ;) [02:09:24] hehe [02:09:40] and I'm not sure how I'm supposed to use the 'options' in this page either: http://commons.wikimedia.org/wiki/MediaWiki:Licenses [02:10:40] bawolff: well using templates across two differnt wikis tends to not work :p [02:11:09] oh, didn't even notice that [02:12:39] mooey: commons.wikimedia.org and mediawiki.org are separate - the license templates are different on each one [02:13:52] so http://commons.wikimedia.org/wiki/MediaWiki:Licenses which is shown on the upload page on commons.wikimedia.org only work at that wiki [02:14:41] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [02:15:27] oh [02:16:05] so where can I see the available commons template for mediawiki? IE, I was asked in the email to license the images (which is a good point!) but I can't figure out how :P [02:16:36] mooey: For mediawiki.org, better to just write things out [02:17:29] gotcha. Now I need to find out what I should write in license-legalese. [02:17:38] * mooey goes to creativecommons for helpage [02:17:39] as the license templates are a bit unorganized [02:17:45] yeah so it seems [02:17:51] mooey: but {{GPL}} should exist on mediawiki.org [02:18:11] mooey: https://www.mediawiki.org/wiki/Category:License_templates [02:18:24] http://www.mediawiki.org/wiki/File:Extstatus_screenshot.png <-- this looks ok? [02:18:31] * bawolff personally just reccomends uploading things to commons.wikimedia.org ;) [02:19:01] I'll know from now on [02:19:15] how do you link the files though, if you upload there? from the Extension:.. page? [02:19:29] I imagine [File:filname.png] won't work ? [02:19:57] Any file on commons.wikimedia.org can be included on any wikimedia wiki with syntax [[File:Filename.png]] [02:20:12] (assuming there's no conflict. If there's a conflict, then local wiki takes precedence) [02:20:25] ooo [02:20:32] good to know! I shall do that from now on, then. [02:21:12] well, the mockup is not a screenshot, but it does represent a sort-of-a-planned-screenshot of mediawiki extension... bah. Do I label it as art work or as a screenshot. Oh, legalese. legalese. [02:23:03] There's a song in there [02:25:56] * p858snake|l slaps bawolff with v [02:25:58] * https://www.mediawiki.org/wiki/Project:File_copyright_tags [02:26:16] Thereeeee they are! Thanks p858snake|l :) [02:26:39] * bawolff didn't even know we had that page [02:26:56] * bawolff still thinks we should just disable local uploads and host everything on commons [02:26:59] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [02:27:48] New patchset: Anomie; "Remove Special:AutoLogin" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64253 [02:27:52] bawolff: Once i get around to writing the email [02:28:05] btw, does this one: {{MW-screenshot| content=CONTENT |skin=SKIN |free=FREE_TEMPLATE}} hold for a screenshot of an extension to mediawiki? [02:28:11] it is technically a screenshot of mediawiki [02:28:47] or do I need to use the derivative [02:29:09] New review: Anomie; "Hold on this until it really is no longer used (i.e. after all wikis have Id47efec7 deployed)." [mediawiki/extensions/CentralAuth] (master) C: -2; - https://gerrit.wikimedia.org/r/64253 [02:31:46] I think its fine, just make sure to also note which extension is being shown [02:32:07] * bawolff is reading https://en.wikipedia.org/wiki/ISO/IEC_5218 - people had to come up with an international standard for that?! [02:35:08] New patchset: Spage; "Blank some new Create account messages by default" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64254 [02:35:22] and if it is already a standard, they're missing a couple of medical terms. [02:53:51] ...omg... there's LOGO for Android as an app... oh, that trusty little turtle FORWARD 50... [04:22:39] New patchset: Santhosh; "Simplify the language settings display" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [04:22:42] New patchset: Santhosh; "Cog icon can be used to close the language settings panel" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64256 [04:35:06] Change merged: Nischayn22; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/56371 [04:56:40] New patchset: Nischayn22; "Add a redlink to dead duplicate file links" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [04:58:30] New review: Nischayn22; "(1 comment)" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/50760 [04:58:33] New patchset: Yurik; "Updated Zero extension to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64257 [04:59:48] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64257 [05:06:00] New patchset: Yurik; "Updated Zero extension to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64258 [05:07:32] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64258 [05:08:25] New review: Daniel Friesen; "@Brian, I haven't looked. But if it's a multipage link my guess is that it's something that was adde..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63407 [05:33:46] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [05:37:26] New patchset: Tpt; "Add Thai namespaces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64199 [05:38:10] New review: Tpt; "Patch set 3: Typo in commit message." [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64199 [05:38:11] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64199 [05:43:44] New patchset: Daniel Friesen; "Move our meta charset so it's placed above the title." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [05:48:11] New review: Daniel Friesen; "PS: Rebased" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [05:58:14] New patchset: Daniel Friesen; "OutputPage: Move our New review: Daniel Friesen; "PS: Fixed comments." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [06:06:18] New patchset: Daniel Friesen; "Deprecate OutputPage::out." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64259 [06:07:33] WTF! [06:09:45] FTW. [06:15:02] New patchset: Daniel Friesen; "Drop support for old skins that don't use head element." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [06:16:12] New review: Daniel Friesen; "PS: Rebased and release notes tweaked." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63364 [06:30:55] Clearly someone is over-caffeinated. [06:32:22] New review: FastLizard4; "(1 comment)" [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63642 [06:32:23] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/63642 [06:33:55] New patchset: FastLizard4; "Fix minor syntax error introduced in last commit" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64260 [06:34:48] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64260 [06:48:48] api lab instance shows this in error logs: libgcc_s.so.1 must be installed for pthread_cancel to work [06:49:12] anything should be done with it? [06:51:48] New patchset: Santhosh; "Update jquery.ime from upstream" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64261 [06:51:48] New patchset: Santhosh; "Remove redundant focus handler" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64262 [07:05:24] yurik: when does it happen? [07:05:51] Aaron|home, on every access i think [07:05:54] it might be apache shelling out to php with too low of a memory limit (via ulimit) for the libraries to load [07:06:14] every? weird...might still be memory limits [07:06:20] * Aaron|home should sleep :) [07:06:29] Aaron|home, what setting is that? [07:06:47] i should too - 3am here [07:12:54] Heh, our Html class isn't coded to handle the element's download attribute. [07:13:07] ^_^ it can be both boolean and non-boolean [07:13:46] ... ... [07:27:27] New review: Nemo bis; "No objections on mailing list for a week." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58049 [07:31:31] New patchset: Mattflaschen; "Use i18n params for errors than appending raw string, with test" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64263 [07:54:08] Oh what a fun thing to think about... [07:54:35] I wonder what things like OpenGraph are going to be like when we allow RDFa in pages. [07:54:47] ie: How badly can a vandal use them. [07:55:39] Then again, given people can already replace the title and page content entirely with profanity they can't really do much. [08:07:22] Amgine: can you help me out with cache control headers? or can you tell me who can? [08:08:24] https://www.wikidata.org/wiki/Special:EntityData/Q66.rdf has Cache-Control: private, s-maxage=0, max-age=0, must-revalidate [08:08:41] but it's getting cached by squids... [08:13:00] TimStarling: hi. can you help me out with this? i'm a bit confused about how to control what gets cached by squids. [08:13:25] i thought s-maxage=0, max-age=0 would prevent the response from being cached, but apparently that isn't true [08:40:19] New review: Nischayn22; "I would be glad to test this but I don't know how." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/51326 [09:38:01] New review: Mattflaschen; "I investigated the tests some. I think part of it is that we're using the PHP HTTP locally (which m..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [09:55:53] New patchset: Santhosh; "Provide disable input tools option in IME menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64270 [10:03:46] New patchset: Physikerwelt; "Use i18n params for errors than appending raw string, with test" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64263 [10:04:48] New patchset: Physikerwelt; "Use i18n params for errors than appending raw string, with test" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64263 [10:05:33] New review: Physikerwelt; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/64263 [10:10:08] New review: Physikerwelt; "Can you explain what the i18 whitespace is about? Where does it come from?" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [12:08:57] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [12:12:46] New patchset: Parent5446; "Fix return type of MessageCache::getMsgFromNamespace for existing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64277 [12:15:11] New patchset: Matthias Mullie; "(bug 42837) AFT uses dangerously generic class names like 'buttons'" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64084 [12:24:56] New patchset: Santhosh; "Display notification when disabling input methods from keyboard icon menu" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64279 [12:51:13] New patchset: Reedy; "Update ProofreadPage to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64287 [12:51:41] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64287 [12:58:06] New patchset: Zfilipin; "Updated Ruby gems" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63427 [13:20:28] New patchset: Hashar; "use project templates" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [13:20:30] New patchset: Daniel Kinzler; "TitleSquidURLs hook for changing the URLs to purge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64290 [13:21:27] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [13:21:46] New patchset: Raimond Spekking; "Delete translatations. English message was set to ''" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64291 [13:27:23] New patchset: Hashar; "use project templates" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [13:29:20] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [13:30:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64291 [13:47:12] Change merged: jenkins-bot; [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/61054 [13:52:22] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/64295 [13:54:48] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/64295 [13:57:38] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/64295 [13:58:40] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/64032 [13:59:03] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/64033 [13:59:15] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/64034 [13:59:30] New patchset: Siebrand; "Update formatting" [mediawiki/extensions/TocTree] (master) - https://gerrit.wikimedia.org/r/64295 [14:05:51] New patchset: QChris; "Add renaming of projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [14:05:51] New patchset: QChris; "Add SSH command to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64298 [14:05:51] New patchset: QChris; "Add REST endpoint to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64299 [14:05:51] New patchset: QChris; "Add UI to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64300 [14:05:52] New patchset: QChris; "Add separate capability to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64301 [14:06:07] qchris: you rocks :-] [14:06:23] There is more to come like that :-/ [14:06:29] * qchris will spam around a bit [14:06:29] Change merged: Andrew Bogott; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64061 [14:06:50] New patchset: Andrew Bogott; "Added getDisplayName and getFullyQualifiedDisplayName" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64302 [14:06:50] New patchset: Andrew Bogott; "Add . to each sudoer host." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64303 [14:07:08] New patchset: QChris; "Change default comment visibility to expand all recent comments" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64304 [14:07:33] New patchset: QChris; "Harmonize color of first data row for tables" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64305 [14:07:33] New patchset: QChris; "Pretend to color change table rows by data row index" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64306 [14:07:45] New patchset: Hashar; "sartoris-pyflakes is now voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64307 [14:07:51] New patchset: QChris; "Respect draft visibility when determining visibility of all refs" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64308 [14:07:51] New patchset: QChris; "Allow adding patch sets only to visible changes" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64309 [14:07:51] New patchset: QChris; "Stop advertising non-visible changes when receiving commits" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64310 [14:07:51] New patchset: QChris; "Performance (& security?) fixes in AdvertiseRefsHookChain" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64311 [14:12:18] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64307 [14:13:25] New patchset: preilly; "change debug log message" [sartoris] (master) - https://gerrit.wikimedia.org/r/64312 [14:13:40] New review: QChris; "The rename-project branch has not been merged upstream, and will not" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [14:14:43] New review: preilly; "self merge due to trivial change to debug log message" [sartoris] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64312 [14:14:44] Change merged: preilly; [sartoris] (master) - https://gerrit.wikimedia.org/r/64312 [14:19:16] New review: QChris; "This change should fix bug #46774." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64304 [14:22:05] New patchset: Umherirrender; "Fixed spacing and removed unneeded parenthesis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [14:23:16] New review: QChris; "This topic branch should allow us to fix #38114." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64305 [14:24:52] New review: QChris; "This change from Gustaf will need some more polishing before it can go into master. However, it serv..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64311 [14:25:17] New review: Anomie; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [14:25:37] New patchset: Anomie; "(bug 46905) Add "centralauthtoken" to API" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [14:27:10] New review: QChris; "This change is waiting for inclusion in upstream's stable-2.6 branch (and only therefore, the corres..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64308 [14:27:23] New review: QChris; "This change is waiting for inclusion in upstream's stable-2.6 branch (and only therefore, the corres..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64309 [14:27:37] New review: QChris; "This change is waiting for inclusion in upstream's stable-2.6 branch (and only therefore, the corres..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64310 [14:33:48] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62980 [14:36:52] New patchset: Siebrand; "Update formatting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62980 [14:37:15] New review: Siebrand; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62980 [14:42:56] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64026 [14:43:31] DanielK_WMDE: Oy, no. Squids etc. is ops vs dev in my opinion. You might ask Reedy for direction on who to talk to about cache control headers. [14:43:57] Amgine: mark helped out. thanks! [14:44:29] Ah! the network deity! [14:47:50] New patchset: Umherirrender; "Fixed spacing and removed unneeded parenthesis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [14:49:47] New review: Umherirrender; "Fixed some more spacing in files, which changed the last days." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [14:53:19] New patchset: QChris; "Add REST endpoint to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64299 [14:53:20] New patchset: QChris; "Add SSH command to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64298 [14:53:20] New patchset: QChris; "Add renaming of projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [14:53:20] New patchset: QChris; "Add separate capability to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64301 [14:53:20] New patchset: QChris; "Add UI to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64300 [14:55:08] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [14:55:20] New review: QChris; "I accidentally dropped a fixup commit when rebasing for Patch Set 1." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [14:56:49] New patchset: Zfilipin; "Scenario: The cog icon is visible in the sidebar on an article" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [15:00:11] New patchset: Umherirrender; "Add RC_EXTERNAL to comment in tables.sql" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64317 [15:05:59] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64317 [15:08:55] New patchset: IAlex; "Deprecate OutputPage::out." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64259 [15:13:07] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64259 [15:13:56] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [15:31:09] GET https://toolserver.org/~brion/extensions/CodeEditor/modules/ace/ace.js?_=1368804494547 [15:31:24] ??? [15:32:12] Oh, looks like that's the code editor gadget.. [15:32:39] * brion looks innocent [15:36:20] Related to the CodeEditor extension I think? Confusing... [15:36:45] Krenair, yeah [15:36:57] if CodeEditor is installed we probably don't need the gadget anymore [15:37:18] I know there's a MediaWiki extension but there's also this gadget which is making requests to TS (which fail, obviously) [15:37:43] yeah, the gadget was a way to deploy it before we got the extension out [15:51:30] New patchset: Adamw; "DataValidator can use boss's methods" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64323 [16:08:37] brion, doesn't look like the mediawiki extension applies to js pages [16:08:41] but the gadget does [16:09:41] I think it only applies to lua pages on mediawikiwiki [16:10:29] hmm [16:10:34] well we should probably adjust that [16:12:09] New patchset: IAlex; "Fixed spacing and removed unneeded parenthesis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [16:16:29] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [16:22:41] i know a number of you have always on irc clients on a server somewhere, probably inside a screen/tmux session that can be resumed over ssh. Any particular suggestions for getting something similar setup? [16:24:01] I use a friend's ZNC setup (IRC bouncer) [16:33:17] New patchset: Rachel99; "Scenario: The cog icon is visible in the sidebar on an article" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [16:33:46] New patchset: Mwalker; "Changing gitreview branch" [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64328 [16:34:02] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64328 [16:34:53] New patchset: Mwalker; "Add dependency to mobile module" [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64329 [16:35:16] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64329 [16:36:05] New patchset: Mwalker; "Merge branch 'master' into mwalker_test" [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64330 [16:36:46] Change merged: Mwalker; [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64330 [16:37:26] New review: Jdlrobson; "I'm confused.. mobile.xdevice.detect.scripts doesn't exist..." [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64329 [16:37:49] ^ mwalker this confuses me [16:40:15] New patchset: Odder; "(bug 48308) Add Ukrainian namespaces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64331 [16:45:21] New patchset: Odder; "(bug 48308) Add Ukrainian namespaces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64331 [16:45:26] New patchset: Mwalker; "Making the .gitreview file point to the right spot" [mediawiki/extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/64332 [16:48:47] New patchset: Odder; "(bug 48308) Add Ukrainian namespaces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64331 [16:49:41] New patchset: Mwalker; "Changing up the git config a little bit" [mediawiki/core] (fundraising/1.22) - https://gerrit.wikimedia.org/r/64334 [16:50:21] New patchset: Krinkle; "deleteEqualMessages: Refactor to support all langcode subpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [16:52:20] New patchset: Krinkle; "deleteEqualMessages: Refactor to support all langcode subpages" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [16:52:34] New review: Krinkle; "Fixed duplicate array key" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [17:00:46] New review: Krinkle; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [17:06:29] New review: Tpt; "Thanks a lot for your change!" [mediawiki/extensions/ProofreadPage] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64331 [17:06:31] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64331 [17:09:21] New review: Demon; "Needs to implement renameRepository() in InMemoryRepositoryManager or tests fail." [gerrit] (wmf) C: -1; - https://gerrit.wikimedia.org/r/64297 [17:10:41] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [17:10:50] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [17:11:23] New patchset: Mwalker; "DonationInterface gitreview points to right branch" [mediawiki/extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/64337 [17:11:57] New patchset: EBernhardson; "Batch row update component" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [17:12:53] New review: EBernhardson; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [17:13:50] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [17:13:51] New review: EBernhardson; "Additionally the BatchRowUpdate component has been submitted to core as https://gerrit.wikimedia.org..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [17:15:08] * ebernhardson dohs at commenting on the wrong ticket ... [17:15:10] New review: EBernhardson; "Additionally the BatchRowUpdate component has been submitted to core as https://gerrit.wikimedia.org..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [17:21:28] New patchset: Raimond Spekking; "Consistency tweak: html5 -> HTML5" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64339 [17:22:34] Change abandoned: Aaron Schulz; "Too many merge conflicts" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64098 [17:23:37] rebooting kaulen (Bugzilla) in 5 minutes, please save your bugs and expect 5 minutes downtime [17:23:56] New review: Physikerwelt; "I spend the half day to figure out how I can mock up the static method calls." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [17:24:58] <^demon> Quick, close all the bugs! [17:29:03] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59720 [17:34:34] bugzilla is back [17:42:04] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62159 [17:44:19] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [17:45:15] New patchset: QChris; "Add REST endpoint to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64299 [17:45:15] New patchset: QChris; "Add SSH command to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64298 [17:45:15] New patchset: QChris; "Add renaming of projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [17:45:15] New patchset: QChris; "Add separate capability to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64301 [17:45:16] New patchset: QChris; "Add UI to rename projects" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64300 [17:46:18] New review: QChris; "Not sure why that did not fail for me as well ... Fixed in Patch Set 2 though." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64297 [17:47:00] New patchset: Matmarex; "Change how Vector's tabs behave on small resolutions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [17:47:08] New patchset: Nikerabbit; "mediawiki.api: Implement login method" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63382 [17:47:13] New review: Matmarex; "So what about this? Krinkle?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/45944 [17:55:53] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [17:56:02] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [17:57:39] New review: Aaron Schulz; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [18:01:29] Change merged: jenkins-bot; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64339 [18:01:55] Nikerabbit: there? [18:02:28] Nikerabbit: what do you think about killing and "hardcoding" https://www.mediawiki.org/wiki/MediaWiki:Editsection-brackets ? [18:02:40] Nikerabbit: these are the brackets for section edit links, the [edit] ones [18:02:58] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [18:03:07] Nikerabbit: and per https://bugzilla.wikimedia.org/show_bug.cgi?id=48256 i think the brackets should be killable via CSS, not via a message [18:04:22] doesn't sound the right way [18:04:48] the message certainly makes little sense to me :/ [18:05:12] and i don't want to stick HTML into that message, since that would be even dumber [18:09:25] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [18:09:25] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [18:10:35] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64206 [18:11:26] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64304 [18:13:34] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64308 [18:13:48] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64309 [18:14:35] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64310 [18:18:55] New review: Nikerabbit; "I am very sure there is RL regression somewhere." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [18:27:16] New patchset: Reedy; "Remove trailing '" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64353 [18:28:05] pgehres: ^ Really simple review there :p [18:31:15] reedy@terbium:~$ grep \: checkUsernames.log -c [18:31:15] 1193 [18:33:42] greg-g: may I deploy a settings change? I know it's Friday but we finally found what's causing a bug and it's been driving Megan up a wall and impeding her ability to run the tests she wants to run: https://gerrit.wikimedia.org/r/#/c/64347/ [18:33:54] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [18:33:54] New patchset: Adamw; "Adapter is not always initialized with data" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [18:35:35] New review: Adamw; "Looks like I did regress order_id handling" [mediawiki/extensions/DonationInterface] (master) C: -2; - https://gerrit.wikimedia.org/r/64345 [18:40:07] New patchset: Reedy; "Output on creating account" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64353 [18:40:33] Change merged: Pgehres; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64353 [18:42:33] mwalker: white space error? [18:42:48] but yeah, that looks low risk, don't tell anyone :) [18:43:11] whoo [18:43:34] New patchset: Reedy; "Output a newline too" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64357 [18:44:48] Ooh, fancy [18:45:48] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64357 [18:49:13] New review: Adamw; "ok, that bug is on master as well." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64345 [19:00:21] gallium being upgraded fyi [19:00:32] = jenkins. now. [19:02:26] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63799 [19:11:09] New review: Mattflaschen; "The whitespace, called a byte order mark, was added by your editor, possibly Notepad." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [19:20:37] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64216 [19:21:33] New patchset: EBernhardson; "Link to any heading not just a main heading" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64363 [19:27:37] New patchset: Matmarex; "Remove the EditSectionLink hook" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64364 [19:27:39] New patchset: Matmarex; "Make brackets in section edit links accessible to CSS." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64365 [19:31:28] New review: CSteipp; "Is there a bug or more references on the background of this? It seems right, but I want to make sure..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [19:41:53] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61074 [19:45:56] New review: Lwelling; "Queries on functionality and stong suggestion on test cases" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/64363 [19:47:58] New review: Jforrester; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61074 [19:52:19] New patchset: Matmarex; "Adjust doEditLink() after changes in core" [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [19:57:09] New patchset: Matmarex; "Adjust efDoDiscussionLink() after changes in core" [mediawiki/extensions/DiscussionThreading] (master) - https://gerrit.wikimedia.org/r/64369 [19:59:34] New patchset: Matmarex; "Adjust after changes in core" [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64371 [20:01:32] New review: Adamw; "(1 comment)" [mediawiki/extensions/CentralNotice] (mwalker_test) - https://gerrit.wikimedia.org/r/64329 [20:03:16] Project browsertests-sandbox.translatewiki.net-linux-chrome build #47: FAILURE in 1 min 56 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/47/ [20:03:40] New review: Reedy; "(1 comment)" [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [20:04:59] New patchset: Matmarex; "Adjust after changes in core" [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/64371 [20:10:07] New patchset: Matmarex; "Adjust doEditLink() after changes in core" [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [20:10:24] New review: Matmarex; "(1 comment)" [mediawiki/extensions/Wikilog] (master) - https://gerrit.wikimedia.org/r/64368 [20:12:45] New patchset: Adamw; "PaymentMethod utility class" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64348 [20:14:49] New review: Pgehres; "No idea. I found this looking through the code." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61907 [20:16:47] ^demon: https://gerrit.wikimedia.org/r/#/c/63881/ one line [20:21:10] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63881 [20:23:08] New patchset: Pgehres; "Adding the ability to confirm email address while sending users to Special:MergeAccount" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63799 [20:30:46] New patchset: Pgehres; "Adding a maintenance script to resend email confirmation emails." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64216 [20:38:54] New review: Adamw; "I think there is also a style hiding the "Preview" legend, that might have to be changed for this pa..." [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62204 [20:39:49] New review: Adamw; "ARgh and this probably needs to be duplicated in BannerRenderer" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/62204 [20:41:06] New patchset: FastLizard4; "Add myself to extension authors array, bump version to 0.3.0" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64378 [20:41:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64196 [20:42:45] New patchset: FastLizard4; "Add myself to extension authors array, bump version to 0.3.0" [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64378 [20:43:28] New review: FastLizard4; "And this is why I code review myself. :P" [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64378 [20:43:28] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64378 [20:52:11] testing client - 1 2 3 [20:55:49] James_F VE freak-out: I inserted a newline and now whenever I touch the window, VE repeats the line under my new paragraph about 20 times, changing a link in it to two honeybee symbols. [20:56:21] I took a screenshot, do you want me to do more? [20:56:54] spagewmf: In Firefox? Which version of the code? [20:57:14] New patchset: Hashar; "validate operations/puppet submodules" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64427 [20:57:59] James_F: on mediawiki.org, Firefox 21. [20:58:18] spagewmf: A bug report would be helpful anyway, yes. :-) [21:00:48] James_F That's what it's saying: "Make sure there is a bug registered in ☃☃ for the issue". prepended 100 times before the original text "Make sure there is a bug registered in [[mw:Bugzilla|Bugzilla]] for the issue." It's an Easter egg in VE :o) [21:01:21] spagewmf: BTW, they're snowmen, not bees. [21:01:50] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64428 [21:01:58] Change merged: Raimond Spekking; [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/64428 [21:03:28] James_F: Why they gotta be snow*men*? [21:03:43] marktraceur: Because that's what Unicode calls them. :-) [21:04:01] Unicode sexist, tech industry goes back to code pages [21:06:08] New patchset: Adamw; "Merge branch 'review/adamw/64348' into HEAD" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64431 [21:06:39] New patchset: Hashar; "triggers for ops/puppet/{cdh4,kafka}" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64432 [21:06:40] marktraceur: Should be 26C4 SNOWMAN WITHOUT SNOW in recognition of the poor winter sports season. Or why not 26C7 BLACK SNOWMAN (heavy snow) [21:16:18] New review: CSteipp; "Working as expected in test" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/63799 [21:16:31] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/63799 [21:17:21] New patchset: Bsitu; "Make return type consistent" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64433 [21:17:53] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64432 [21:18:56] New patchset: CSteipp; "Adding a maintenance script to resend email confirmation emails." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64216 [21:20:14] New review: CSteipp; "Thanks!" [mediawiki/extensions/CentralAuth] (master) C: 2; - https://gerrit.wikimedia.org/r/64216 [21:20:21] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64216 [21:20:49] New patchset: Adamw; "WIP: DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [21:20:56] New patchset: Reedy; "Add .gitreview and .gitignore" [mediawiki/extensions/ExternalArticles] (master) - https://gerrit.wikimedia.org/r/64435 [21:23:31] New review: Hashar; "Good enough for now. Zuul triggers got deployed." [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/64427 [21:23:31] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64427 [21:26:09] New patchset: Kaldari; "Adding short date format i18n strings to Language message files" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64437 [21:26:40] Yippie, build fixed! [21:26:40] Project browsertests-en.wikipedia.org-linux-chrome build #64: FIXED in 2 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/64/ [21:28:09] jdlrobson: re the patch for centralnotice you commented on -- apologies I was on a test branch figuring out how to do deploy branches and gerrit -- it's not like it was deployed or even merged somewhere important [21:30:37] New review: CSteipp; "(1 comment)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/61074 [21:32:52] New patchset: Bsitu; "Date comparison should include year" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64439 [21:32:53] New patchset: Hashar; "pplint-HEAD parsed erb files and xargs was wrong" [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64438 [21:33:07] New review: Hashar; "INFO:jenkins_jobs.builder:Reconfiguring jenkins job operations-puppet-cdh4-pplint-HEAD" [integration/jenkins-job-builder-config] (master) C: 2; - https://gerrit.wikimedia.org/r/64438 [21:33:07] Change merged: Hashar; [integration/jenkins-job-builder-config] (master) - https://gerrit.wikimedia.org/r/64438 [21:36:10] New patchset: Adamw; "WIP: More DI core changes to support DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64440 [21:38:02] New patchset: Adamw; "WIP: DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [21:39:25] New patchset: MarkTraceur; "Get the unit tests to run to completion" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64441 [21:39:25] New patchset: MarkTraceur; "WIP: Add tests for Gateway_Form" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64442 [21:46:23] New patchset: Pgehres; "Adding a maintenance script to confirm the validity of entries in centralauth.localnames." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64443 [21:53:22] New patchset: QChris; "Fix PatchScript's mapping of lines below the last edit" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64444 [21:56:20] New review: Katie Horn; "I haven't had time to be thorough with this review (as in: I have not tested anything), but I had to..." [mediawiki/extensions/DonationInterface] (master) C: 1; - https://gerrit.wikimedia.org/r/64348 [21:57:56] New patchset: FastLizard4; "Large standardization, primarily for i18n." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64445 [22:03:39] does anyone who is around know if it is possible to call a lua module in userspace? [22:04:12] New patchset: FastLizard4; "Large standardization, primarily for i18n." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64445 [22:05:02] New patchset: Mwjames; "(Bug 48586) ApiAsk add error output" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64447 [22:06:09] MartijnH: via #invoke? why not? [22:07:38] what would be the syntax? just #invoke|user:username/luacontent ? [22:07:56] uhh [22:08:06] you mean that the module would be in userspace? then no [22:08:13] all modules have to be in the Module: namespace [22:08:23] ah, that's a shame [22:08:34] thank you [22:08:38] although at least on Wikimedia wikis some policies were created [22:08:44] to give users "sandbox" space [22:09:02] en.wp has been forming some informal conventions [22:09:12] martijnHH: for example https://en.wikipedia.org/wiki/Module:Sandbox [22:09:14] New patchset: FastLizard4; "Large standardization, primarily for i18n." [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64445 [22:10:47] New review: FastLizard4; "Tested and verified on one of my experimental MediaWiki installs." [mediawiki/extensions/CommunityTwitter] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/64445 [22:10:47] Change merged: FastLizard4; [mediawiki/extensions/CommunityTwitter] (master) - https://gerrit.wikimedia.org/r/64445 [22:11:02] http://en.wikipedia.org/wiki/Wikipedia_talk:Lua#Sandbox_naming_pattern discusses some options too, it seemed like it wouldb be nicer to have somthing like a User Module: namespace for userspace modules. Even nicer would be to adopt the same convention as templates though. But it's not a large issue, there are workarounds enough [22:12:40] martijnHH: well, as you can see, the Module: pages are kind of special [22:12:58] such as having the /doc page transcluded by default, being formatted as code, etc [22:13:08] martijnHH: and this all is tied to the Module: namespace [22:16:13] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [22:18:45] it's just a minor nuicanse - the workaround is easy enough [22:21:51] New patchset: Mwjames; "Add doxygen grouping" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64451 [22:24:56] Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64451 [22:32:37] New review: CSteipp; "Looks sane, and will be a little more specific with that hook. Working with basic AF tests." [mediawiki/extensions/AbuseFilter] (master) C: 2; - https://gerrit.wikimedia.org/r/51326 [22:32:44] Change merged: jenkins-bot; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/51326 [22:34:35] New review: Ryan Lane; "(1 comment)" [mediawiki/extensions/OpenStackManager] (master) C: -1; - https://gerrit.wikimedia.org/r/64302 [22:43:34] New review: Cscott; "Note that Special:Redirect can be simplified somewhat now that this patch has landed." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59720 [22:45:48] New patchset: MarkTraceur; "WIP: Add tests for Gateway_Form" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64442 [22:48:11] New review: Alex Monk; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [22:51:51] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [22:54:47] New review: CSteipp; "A few query issues, otherwise should be fine" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/64443 [23:03:45] New patchset: Alex Monk; "Add a way to redact certain function parameters from exception stack traces" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64450 [23:05:04] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [23:06:59] New review: CSteipp; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64243 [23:14:30] New patchset: MarkTraceur; "Load the phpunit.xml we have sitting in tests/" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64458 [23:21:02] New patchset: MarkTraceur; "Fix the -nc option in unittest.sh" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64459 [23:26:49] New patchset: Pgehres; "Adding a maintenance script to confirm the validity of entries in centralauth.localnames." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64443 [23:27:24] New review: Pgehres; "For some reason I was avoiding mixing array element types. Fixed." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64443 [23:29:24] New patchset: MarkTraceur; "Sandbox cURL, generally make it possible to test" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [23:29:40] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64443 [23:32:09] New patchset: Alex Monk; "Fix undo edit summary when the user who made the old revision is hidden" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64461 [23:33:49] Change abandoned: MarkTraceur; "The other unittest.sh fix I have in the pipeline needs this change too, so I'm squashing them." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64459 [23:35:50] New patchset: MarkTraceur; "Load the phpunit.xml we have sitting in tests/" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64458 [23:48:58] New review: Mwalker; "Missing a couple critical files it seems." [mediawiki/extensions/DonationInterface] (master) C: -1; - https://gerrit.wikimedia.org/r/63688 [23:50:42] Anyone around firm with jshint? [23:58:25] I wouldn't say I am, but what is the problem exactly?