[00:02:09] Change merged: Adamw; [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63995 [00:05:20] TrevorParscal: do you know why the use of the ResourceLoaderRegisterModules hook is discouraged (as documented here https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules)? [00:05:57] or Krinkle ^ [00:08:33] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [00:12:13] upgrading wikimedia-task-appserver from 2.7 to 2.9. 2.9 fixes apache-graceful-all for API servers and 2.8 means that scap-1, scap-2 and sync-common scripts can now be managed directly in operations/puppet (Ori's change) [00:12:33] New patchset: Adamw; "Lock out PayPal MYR and BRL" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64006 [00:20:53] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63905 [00:27:09] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63911 [00:35:18] New patchset: Bsitu; "(bug 48521) Echo should not implicitly commit other transaction" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64009 [00:36:11] New patchset: Bsitu; "(bug 48521) Echo should not implicitly commit other transaction" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64009 [00:37:18] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [00:43:12] New patchset: MarkTraceur; "Sandbox cURL, generally make it possible to test" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [00:46:11] New review: Parent5446; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [00:49:32] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [00:55:32] New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63789 [01:05:10] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [01:05:24] awjr: As to why it is discouraged, TimStarling is partly involved in that, though Roan and I remember agreeing, I forgot what it was. [01:05:33] lol [01:05:52] TimStarling: Why is hook ResourceLoaderRegisterModules discouraged over setting the array from the global scope? [01:05:53] c'est la vie, it is enough for us to know for now that it is discouraged [01:06:03] slow [01:06:05] I understnad, why I want to know now :) [01:06:17] TimStarling: Right, that makes sense [01:06:29] multiple calls for registering instead of adding one big array at once. [01:06:34] I think it was calling that hook on every request [01:07:02] I benchmarked it each way, iirc, it wasn't just intuition [01:07:33] I heard you had a scap problem earlier [01:07:40] Yeah [01:07:40] robla was just telling me about it [01:08:09] TimStarling: sync-dir or scap synced files and then 'the internet' requested the startup module [01:08:24] which rebuild itself at that time because some of the files were touched since the last time startup was build [01:08:49] but the resulted minified packaged ended up containing some files of new versions and some of old versions [01:09:09] right [01:09:35] Though now that I think about it, I wonder why 5 minutes later it wasn't automatically fixed. I mean, seconds after that happened the remaining files would've been synced. [01:09:46] So within 5 minutes the next startup module build should've fixed it [01:09:49] ah, I remember. [01:10:03] the newer files were synced first in this case (random) [01:10:23] yeah, robla said you had to touch one of the files and sync it [01:10:34] not manually first, but first as in whatever order scap uses. [01:10:42] yeah [01:11:51] New patchset: Adamw; "refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [01:12:06] depooling a server in LVS is fairly disruptive, it causes existing connections to hang for a while and then reset [01:12:41] so I think the solutions are: [01:12:43] TimStarling: specifically, file A defined mw.hook and file B called mw.hook. file B presumably had a slightly higher lastmod time (even though they were in the same commit, It's likely my editor didn't save them at the same time). the rest is history [01:12:50] * Krinkle listening [01:12:50] 1. make scap atomic [01:13:14] 2. stall apache while scap is in progress, so no new requests are handled [01:13:25] maybe with a custom apache module or something [01:14:29] if you stall apache before or shortly after accept, then the connection count will rise and LVS will stop sending requests to it [01:14:35] hmmm [01:15:23] TimStarling: I haven't considered touching apache, I was thinking (though admitedly without knowing much of anything in this area) of "gracefully depooling" [01:15:26] not just depooling [01:15:50] e.g. like LVS does when an apache has reached capacity. existing connections are let finish, but no new ones. [01:15:51] maybe it is possible to reduce the weight to zero without depooling it, with ipvsadm -e [01:16:14] Krinkle: so i guess putting misc::deployment::common_scripts (back) on fenari doesnt make much sense anymore now [01:16:16] then once graceful depool has finished, initiate sync, and when finished repool. [01:16:28] mutante: hehe, I wouldn't know. [01:17:13] TimStarling: Then of course there is the matter of avoiding a situation where if anything in this process takes a while that all servers are doing it at the same time [01:17:15] "Quiescent servers are specified with a weight of zero. A quiescent server will receive no new jobs but still serve the existing jobs, for all scheduling algorithms distributed with the Linux Virtual Server." [01:17:29] says man 8 ipvsadm [01:17:32] you don't want to have all apaches depooled at the same time :D [01:17:48] what if you didn't depool it but just set no-cache headers on all its responses while its being scapped somehow? [01:17:53] it could be done [01:18:02] *it's [01:18:06] but it would probably be significantly more complex than making scap atomic [01:18:32] ori-l: Interesting, that's essentially how we're handling it right now for php-side corruption due to scap. http 500 has no-cache naturally. [01:18:44] though that doesnt' eliminate it, just prevents it from spreading. [01:18:55] I think making scap atomic is probably the easiest solution [01:19:38] that's just a few extra lines of shell script [01:20:01] TimStarling: Interesting, I figured it'd be much more complex. [01:20:14] TimStarling: Can you roughly sketch how that would be made atomic? [01:20:21] I'm thinking having 2 locations and swapping them. [01:20:26] yes [01:20:29] then it's reduced to only linux doing 'mv' [01:20:46] except I would set everything to point to a symlink and use ln -sf [01:20:49] perhaps use someting like nice to ensure this has a high priority [01:20:53] rather than mv [01:20:58] TimStarling: nice [01:21:01] (nice nice) [01:21:59] mmm, ln -sf is not atomic [01:22:28] http://stackoverflow.com/questions/307437/moving-a-directory-atomically [01:22:37] but you could create the new symlink and then rename() it into place, that would be atomic [01:22:41] lots of stackoverflow hits on google for "linux switch directories atomically" [01:23:27] yeah, like the +7 answer there [01:23:35] create the symlink then move it into place [01:25:40] the way I would do graceful depooling is as follows: [01:25:55] have pybal expose a TCP server rather like poolcounterd [01:26:14] TimStarling: aha, so the main point entry will always be a symlink. basically 4 sections, 2 dirs and 2 points, and using mv -T to only override the symlinks [01:26:17] that's pretty sweet [01:26:19] scap connects to this server and requests depooling [01:26:38] pybal checks if there are any depool slots free [01:26:49] if not, it delays its response and the scap client hangs [01:27:11] if there is a slot, it allocates it, sets the weight to zero with ipvsadm -e, then returns a success message to the client [01:27:35] then when scap is finished, the client would close the TCP connection, and pybal would respond to that by setting the weight back to what it was [01:27:56] Is "depool slots" an existing feature? [01:27:59] no [01:28:00] so maybe 200 lines of python compared to 10 lines of shell script [01:28:11] well, plus the client [01:28:33] kind of difficult to keep a TCP connection open while a shell script executes [01:28:37] would this include waiting for current requests to finish? (not sure if 'weight to zero' takes care of that) [01:28:42] so maybe also rewrite scap in a proper language [01:28:47] anyhow, you mentioned this would not be attractive. [01:29:08] and it's getting clear to me now why :) [01:30:06] The reason I figured it would be better than making scap atomic is because I didn't think the latter would be possible. [01:31:10] It does get slightly more complicated than that though since sync-* is also subject to it, not just full-on scap [01:31:29] so sync-dir would have to temporarily create this 2-location situation [01:31:42] for an arbitrary sub directory [01:32:12] sync-dir has no client-side script at the moment, it's just a dsh one-liner [01:32:51] but it's pretty easy to add more client-side scripts now that they are in puppet rather than wikimedia-task-appserver [01:33:37] We could get rid of sync-file and sync-dir and implement sync-all and use that separately to only sync file and use it within scap when needing rebuild of i18n etc. as well. [01:34:16] TimStarling: Is it possible to atomically get into this 2-location situation? I was assuming that this would only work with this pre-existing. [01:34:54] sync-file and sync-dir are already unified [01:35:09] the only difference is input validation, then they both call sync-common-file [01:35:24] TimStarling: I know, that's not what I meant. [01:35:35] but perhaps it makes my potential worry obsolete. [01:36:10] TimStarling: you envision that scap would not have the symlink pre-existing but create it on the fly and remove it when done? [01:37:46] yes, could do [01:37:49] the swapping of symlinks you showed can be done atomically but can setting up moving /a/common/foo/bar to something else and create symlink and restoring afterwards be done atomatically as well? [01:37:53] wow, that's great. [01:38:35] it's not ideal though... [01:38:52] I think the way to do it would be to have two full directory trees [01:39:09] if you ask for sync-file, it copies that one file into the inactive tree, then swaps the trees [01:39:25] ah, I see where you're heading. Yes. [01:39:34] have the full copies at all times [01:39:34] that way sync-dir never has to copy the whole directory locally [01:39:51] right, it's an optimisation to make sync-dir fast [01:40:03] and if you're syncing a subdirectory it can quickly set up the symlink from across within the 2 trees. [01:40:16] if you do sync-dir php-1.22wmf3, you don't want that to copy that whole directory, you want to just check timestamps and copy the relevant files [01:40:59] hm.. why wouldn't it be able to do that now (timestamp checking) [01:41:18] it does do it now [01:42:20] ok [02:08:25] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [02:26:33] New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [03:01:46] New review: Daniel Friesen; "All the notes have made so far been fixed. What's next?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [03:24:40] New patchset: Mattflaschen; "Add overlay hook for user scripts." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [03:25:11] New patchset: Mattflaschen; "Add overlay hook for user scripts." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [03:31:41] New review: Mattflaschen; "Should not be merged until mw.hook has rolled out across the WMF cluster (5/22)." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64015 [03:31:44] New review: Ori.livneh; "This is a really nice, thoughtful improvement, executed with care. Thanks very much." [mediawiki/extensions/EventLogging] (master) C: 2; - https://gerrit.wikimedia.org/r/63601 [03:32:01] Change merged: jenkins-bot; [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63601 [03:35:52] New patchset: Mattflaschen; "Add missing dependency on mediawiki.util." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64016 [03:40:54] New patchset: Spage; "Log ?campaign=someName" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [03:44:53] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63856 [03:46:26] New review: Spage; "PS2 works and I would be comfortable deploying it despite the TODOs, but there's no rush." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [04:02:22] Change merged: jenkins-bot; [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/63899 [04:03:32] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [04:03:37] New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [04:52:51] New review: Siebrand; "Tested okay." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 1; - https://gerrit.wikimedia.org/r/63843 [04:58:00] New review: Jakub Vrána; "Would it be possible to merge this chain of commits? Rebases are somewhat painful." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62130 [05:14:22] New patchset: Pginer; "Avoid setting a fixed height for font selectors" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64017 [05:16:07] New review: Pginer; "I applied the change I commented in https://gerrit.wikimedia.org/r/#/c/64017/" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/49619 [05:19:03] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [05:22:32] New review: Tim Starling; "Is it possible to use a longer token expiry, say 60s to match the squid timeout? I think 15s could b..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [05:23:35] New review: Tim Starling; "Is it possible to use a longer token expiry, say 60s to match the squid timeout? It seems like 10s c..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [05:30:32] New review: Wikinaut; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [05:31:01] New patchset: Siebrand; "More consistent terminology use for review" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64018 [05:44:46] New review: Tim Starling; "I don't think the UI on Special:CentralLogin/complete is as good as it could be. I think there shoul..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [05:57:37] New patchset: Wikinaut; "(bug 44293) Fix URL generation when $wgServer is protocol-relative." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [06:08:01] New patchset: Daniel Friesen; "Drop support for XHTML 1.0" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [06:13:38] New patchset: Daniel Friesen; "Drop support for XHTML 1.0" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [06:13:57] New patchset: Daniel Friesen; "Move our meta charset so it's placed above the title." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [06:16:22] New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [06:16:47] New review: Daniel Friesen; "PS: Fixed the use of setRef instead of set." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [06:16:58] New review: Daniel Friesen; "PS: Rebased." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [06:17:27] New review: Daniel Friesen; "PS: Rebased onto 2013/xhtml's changes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [06:28:24] New review: Ori.livneh; "I think this is a good idea -- the ability to model your analytic data records is the biggest sellin..." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [06:32:31] New patchset: IAlex; "Make 'subnet' feature of $wgRateLimits work with IPv6" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64021 [06:36:26] New patchset: Yurik; "temp patch for extensions/ZeroRatedMobileAccess" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64022 [06:37:11] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64022 [06:57:00] New patchset: Umherirrender; "Fix badcontinue in possible errors of paraminfo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64024 [07:09:07] New patchset: Umherirrender; "Add helpurls to some api modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64026 [07:15:18] New patchset: Yurik; "Revert "temp patch for extensions/ZeroRatedMobileAccess"" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64027 [07:15:44] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64027 [07:20:49] *sigh* I should put some focus back into that MW chapter page. [07:39:15] New patchset: MaxSem; "Update GeoData to master tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64028 [07:42:38] New patchset: MaxSem; "Update GeoData to master tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64029 [07:43:05] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64028 [07:43:36] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64029 [08:04:01] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [09:13:51] New patchset: Rfaulk; "fix. Popen call / ref to .deploy file / _sync call args." [sartoris] (master) - https://gerrit.wikimedia.org/r/64032 [09:13:51] New patchset: Rfaulk; "add. force action in args." [sartoris] (master) - https://gerrit.wikimedia.org/r/64033 [09:13:52] New patchset: Rfaulk; "fix. removal of deploy folder once sync completes." [sartoris] (master) - https://gerrit.wikimedia.org/r/64034 [09:41:55] Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/64018 [09:42:35] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/61770 [09:48:45] New patchset: Siebrand; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [09:48:46] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/64017 [09:49:12] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63828 [09:52:16] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [09:52:35] Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63843 [10:11:39] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [10:39:01] New review: Amire80; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/62980 [10:47:14] New patchset: Physikerwelt; "New rendering option LaTeXML" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [10:57:04] New review: Physikerwelt; "I have errors with vagrant." [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [11:27:59] Quick question: if Jenkins already gave +2 to a change, should the change just be submitted or should it still be sent through gate/submit jobs? [11:39:11] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64024 [11:47:28] New patchset: Matmarex; "Don't use a for the TOC" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/39792 [12:17:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63106 [12:39:51] New patchset: Santhosh; "Simplify the language settings display" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [12:40:55] New review: Santhosh; "I think I have addressed all scenario now. Amir, can you verify whether I missed any of your latest ..." [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [13:10:19] New patchset: Hashar; "document NullJob example usage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64046 [13:12:17] New patchset: Nischayn22; "Add a mandatory reason for the Disputed tag." [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/64048 [13:32:09] New patchset: Yaron Koren; "Fixes to comments, formatting and code for latest additions" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64052 [13:34:38] New patchset: Jeroen De Dauw; "SomeProperty->getDescription to ->getSubDescription" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64053 [13:35:21] Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/64052 [13:38:52] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64053 [13:47:32] New review: Jeroen De Dauw; "I cannot delete this branch as long as this commit is still made against it" [mediawiki/extensions/SemanticMediaWiki] (1.9.x) - https://gerrit.wikimedia.org/r/30426 [13:47:58] New patchset: Krinkle; "Enable mwext-TemplateData-phpcs-HEAD" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64056 [13:48:15] New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [13:48:16] New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [13:48:17] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64056 [13:55:49] New patchset: Anomie; "Fix memc usage" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64059 [13:56:49] New review: Mwjames; "In this case let me cherry pick this and then I'll abandon it." [mediawiki/extensions/SemanticMediaWiki] (1.9.x) - https://gerrit.wikimedia.org/r/30426 [13:59:58] New patchset: Andrew Bogott; "Clean up a couple of bad calls to printDebug()." [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/64061 [14:05:41] Change abandoned: Mwjames; "Bye bye" [mediawiki/extensions/SemanticMediaWiki] (1.9.x) - https://gerrit.wikimedia.org/r/30426 [14:36:42] New patchset: Matthias Mullie; "(bug 43381) ArticleFeedbackv5 query issue with SQLite" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64063 [14:42:13] New patchset: Jeroen De Dauw; "SomePropertyDescription now takes anything that is a DataValue as $propertyId argument" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64064 [14:44:32] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64064 [14:49:53] New patchset: Jeroen De Dauw; "Get rid of all PropertyValue usage, replace by DataValue type hinting" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64070 [15:01:21] Change merged: Denny Vrandecic; [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/64070 [15:02:18] <^demon> I'm thinking of deprecating wfDl(). [15:03:28] <^demon> No extensions in Git use it...and it's poor form considering it's mostly nerfed on 5.3+ [15:04:18] ^demon: do it [15:05:03] <^demon> core makes me sad :( http://p.defau.lt/?KCw4i2CnJgNF4NFXle_P1Q [15:17:26] New patchset: Krinkle; "Disable Generic.CodeAnalysis.UnusedFunctionParameter" [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/64074 [15:18:01] Change merged: Krinkle; [mediawiki/tools/codesniffer] (master) - https://gerrit.wikimedia.org/r/64074 [15:19:15] New patchset: Krinkle; "Update submodule tools/mwcodesniffer" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/64075 [15:19:42] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/64075 [15:20:06] hi diadara how are you? [15:26:28] New patchset: Krinkle; "Make mwext-TemplateData-phpcs-HEAD voting" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64076 [15:27:08] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64076 [15:35:08] New patchset: Krinkle; "gitignore: mw-skins, labs-" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/64077 [15:35:26] New patchset: Krinkle; "gitignore: mw-skins, labs-" [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/64077 [15:35:33] Change merged: Krinkle; [integration/jenkins] (master) - https://gerrit.wikimedia.org/r/64077 [15:36:02] hashar: behold, for we have the first extension that passes phpcs and is voting [15:36:12] https://gerrit.wikimedia.org/r/#/c/64072/ [15:37:08] ohh [15:42:42] Krinkle: it is unfortunate the submodule mwcodesniffer did not get updated :-] [15:42:56] hashar: ? [15:43:06] https://gerrit.wikimedia.org/r/#/c/64075/ [15:43:39] ? [15:43:44] hashar: You're noto making sense [15:43:49] it did get updated, that is the change that does it [15:43:53] ah sorry I thought about something else [15:43:59] that is just you deploying the last change sorry [15:44:15] ok :) [15:44:21] I am wondering whether we should remove the submodule [15:44:35] hashar: I proposed that to you last month [15:44:43] and use jenkins to deploy the codesniffer mw standard on post merge [15:44:50] hashar: We kept it separate to allow people to use it locally without having to clone all of jenkkns [15:44:54] yeah that must have kicked in right now sorry [15:44:57] my brain is lagged [15:45:15] (this was your argument, and I agreed) [15:45:17] yeah I definitely want to keep it in its own repo [15:45:23] that make sense [15:45:32] ah, yeah, we can make it update automatically [15:45:39] but then I am not sure we need to suffer the pain of having to update the submodule [15:45:47] so we could remove it from integration/jenkins [15:45:51] and craft an auto deploy job [15:46:01] remove the submodule, add to gitignore, clone locally, git-checkout from postmerge [15:46:07] yup [15:46:10] just like integration/doc [15:46:11] sounds good [15:46:12] yep [15:46:16] lets call that jenkins-deploy :-} [15:46:29] and one day gearman-deploy [15:56:03] New patchset: Krinkle; "Enabling phpcs-HEAD for various extensions (non-voting)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64079 [15:56:24] Change merged: Krinkle; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64079 [16:03:12] New review: Jeroen De Dauw; "I want Markus to have a look at this" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [16:16:11] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63267 [16:17:02] New review: Hashar; "yup that make sense :-]" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62228 [16:19:30] New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63267 [16:19:46] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62228 [16:24:58] New patchset: Matthias Mullie; "(bug 42837) AFT uses dangerously generic class names like 'buttons'" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64084 [16:25:07] New review: Demon; "I think this is fine actually. If an individual community is fine with removing autopatrol logs (as ..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/62785 [16:28:25] New patchset: Aude; "Update Wikibase, DataValues and Diff" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64085 [16:28:33] New patchset: Matthias Mullie; "(bug 42837) AFT uses dangerously generic class names like 'buttons'" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/64086 [16:29:01] New review: Matthias Mullie; "Not to be merged before https://gerrit.wikimedia.org/r/#/c/64084/ has been deployed for awhile" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -2; - https://gerrit.wikimedia.org/r/64086 [16:31:44] aude: *bonk* [16:32:09] aude: what's with the WIP patch you had for https://bugzilla.wikimedia.org/show_bug.cgi?id=44874 ? [16:32:17] aude: is it uploaded anywhere yet? [16:32:31] MatmaRex: not yet :( [16:32:53] i think it would be good to have something quite soon and then can work on it in amsterdam? [16:33:11] * aude busy squashing bugs :( [16:35:11] aude: okay [16:35:24] are you coming to the hackathon? [16:35:30] * aude thought i saw your name on the list [16:41:37] aude: yeah, i am [16:41:42] cool :) [16:41:58] aude: but i'm not sure if i'm going to have time for wikidata things [16:42:03] that's fine [16:45:15] New review: Alex Monk; "Instead of this commit, we should change the $.ajax calls to use mediawiki.api." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64016 [16:46:57] New review: Jiabao; "Thank you for the review IAlex. Sorry for the late reply, I will be returning to this next week :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61748 [16:50:42] New patchset: Mwjames; "SpecialStatistics::getOtherStats use standard language instead of inContentLanguage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [16:52:22] New review: Mwjames; "How is doing a review on this now?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [16:57:21] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64085 [16:58:13] New patchset: Mwjames; "SMW\Lua add framework to support Scribunto extension" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [16:59:55] New patchset: Krinkle; "(bug 43167) list=articlefeedbackv5-view* accepts page titles as an option" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63480 [17:00:05] New patchset: Krinkle; "Substitute $.ajax for mw.Api" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/63665 [17:03:38] New review: Mwjames; "It took me some headaches to circumvent the Scribunto_LuaEngineTestBase inheritance while using the ..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [17:10:01] New patchset: Brian Wolff; "SpecialStatistics::getOtherStats use standard language instead of inContentLanguage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [17:10:30] New review: Brian Wolff; "Change commit message since "standard" language is a bit ambigious. Looks good." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/64087 [17:12:16] ^demon: Per my comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=47415#c8 happy for you to +2 https://gerrit.wikimedia.org/r/#/c/62785/ (and make the related wiki config change). [17:12:19] New review: Mwjames; "That was quick, thanks." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [17:14:30] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [17:15:16] New review: Brian Wolff; "Well you know, things have the unfortunate tendency to either get reviewed immediately, or several m..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64087 [17:18:37] New review: Mwjames; "Now that we have SMW_EXPERIMENTAL_FEATURES, how does Jenkins run tests for SMW_EXPERIMENTAL_FEATURES..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [17:19:26] New patchset: Yurik; "(Bug 48528) Re-applying patch to track weird bug in Zero extension. Need more logging data." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64093 [17:21:38] Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64093 [17:35:34] Change merged: MarkTraceur; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63926 [17:48:51] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/62933 [17:54:31] New review: Adamw; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/62516 [17:55:09] New patchset: Mwalker; "Cleanup Adyen" [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63158 [17:56:01] New patchset: Adamw; "Amazon recurring gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/62516 [17:58:37] Change merged: jenkins-bot; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/63595 [17:59:24] Change merged: Mwalker; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/64006 [18:01:14] New review: Kaldari; "(1 comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) C: -1; - https://gerrit.wikimedia.org/r/64084 [18:02:11] New review: Kaldari; "Let's do both." [mediawiki/extensions/Echo] (master) C: 2; - https://gerrit.wikimedia.org/r/64016 [18:02:35] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64016 [18:05:05] Change merged: jenkins-bot; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63905 [18:05:36] New review: CSteipp; "60 seconds should be fine. It needs to be short enough that can't be brute forced while it's valid, ..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [18:20:46] New review: CSteipp; "* 60s (or even 5 min) timeout would be fine." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/59211 [18:21:30] New patchset: Aaron Schulz; "Bumped token expiry times a bit." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64098 [18:37:46] New review: Adamw; "That crazy unused $cid argument makes my hackles tingle, but carrying right on..." [wikimedia/fundraising/PaymentsListeners] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63154 [18:37:46] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63154 [18:39:37] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63157 [18:39:51] Change merged: Adamw; [wikimedia/fundraising/PaymentsListeners] (master) - https://gerrit.wikimedia.org/r/63158 [18:41:49] New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102 [18:43:18] New patchset: Alex Monk; "Use mediawiki.api instead of $.ajax" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102 [18:51:36] "If 'tables' is a string that starts with a space, treat it as user-enforced FROM definition. [18:51:38] Development sponsored by: Dirty Hacks Inc. " - domas [18:55:35] New review: Spage; "Looks right. If I change my test tour's Okay button to 'Xonclick', I see no output in regular mode (..." [mediawiki/extensions/GuidedTour] (master) C: 2; - https://gerrit.wikimedia.org/r/63255 [18:55:48] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63255 [18:59:23] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [19:01:17] New patchset: EBernhardson; "Respect revision suppression within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63572 [19:03:45] New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [19:14:32] New review: Swalling; "Tested on piramido." [mediawiki/extensions/GettingStarted] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/63832 [19:15:06] New review: Spage; "A step with no buttons gets an [Okay] unless I override." [mediawiki/extensions/GuidedTour] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/63831 [19:15:22] Change merged: jenkins-bot; [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63831 [19:22:38] New patchset: Mwjames; "SpecialStatistics::getOtherStats use user language instead of inContentLanguage" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64112 [19:23:30] New review: Mwjames; "Not sure this all you need." [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64112 [19:29:16] New review: Wikinaut; "Tyler, does it ***work*** for you ?" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [19:32:55] New patchset: Hashar; "*** WIP *** project templating" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [19:36:34] New review: Mwjames; "(1 comment)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [19:41:03] New review: Mwjames; "What happens with those templates when adding new tests such as QUnit, coverage analysis or doc publ..." [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [19:42:40] Does anyone know, is there anything in the MW i18n related code somewhere, that would tell me whether a language usually puts day or month first in dates? [19:42:49] Nikerabbit, do you know this perhaps?^^ [19:43:41] there are some optional messages for date/time, maybe something in CLDR too? [19:45:25] Danwe_WMDE: there's also https://meta.wikimedia.org/wiki/Date_formats_in_various_languages [19:48:05] New review: Spage; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) C: 2; - https://gerrit.wikimedia.org/r/63832 [19:48:14] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63832 [19:51:21] New review: MarkAHershberger; "Could you add a line in RELEASE-NOTES-1.21 ?" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64112 [19:51:36] Thank you two. So far I only found $defaultDateFormat in the messages file, perhaps that's sufficient, though, I am not quite sure what's happening with this in MW [19:52:29] Once upon a time there was an effort to display dates in locale-based formats. [19:53:22] Language::getDefaultDateFormat [19:53:47] Amgine: need it for date parsing actually. Displaying will be for later ;) [19:54:17] heh. Now acount for the solar-lunar calendars. [19:55:02] ah, there's even mw.config.get( 'wgDefaultDateFormat' ) already ;) [19:56:07] New patchset: Mwjames; "SpecialStatistics::getOtherStats use user language instead of inContentLanguage" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/64112 [19:57:24] Danwe_WMDE: $wgUseDynamicDates too [19:57:43] Oh, wait, that's gone in 1.22. [19:58:39] But #dateformat is not. [20:00:04] New patchset: Mwjames; "Fix flashy unstyled content in MW 1.22" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [20:03:01] New review: Mattflaschen; "Looks good (no jumping at all). I tested both the old and new forms, and there are no evident regre..." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/62542 [20:03:16] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [20:05:01] New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [20:05:52] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62542 [20:07:32] Project browsertests-en.wikipedia.org-linux-firefox build #64: FAILURE in 6 min 9 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/64/ [20:10:40] New review: Hashar; "(1 comment)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [20:11:10] New patchset: Hashar; "*** WIP *** project templating" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63674 [20:11:10] New patchset: Hashar; "resort some jobs entries" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64141 [20:15:12] Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/64141 [20:21:27] New review: Spage; "Generates the URL and skips it. I didn't test escaping with a page with special characters in it." [mediawiki/extensions/GettingStarted] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/63984 [20:21:33] Change merged: jenkins-bot; [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63984 [20:21:44] New patchset: Aude; "Update Wikibase with patch for SpecialEntityData" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64177 [20:23:22] New patchset: Aaron Schulz; "[Database] Simplified selectSQLText() and fix USE INDEX bug" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64182 [20:24:20] New review: Mwjames; "OK, this really itches me now!!" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [20:24:36] Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64177 [20:32:54] New patchset: Spage; "Update GettingStarted to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64191 [20:33:01] New patchset: Mattflaschen; "Blank some new Create account messages by default" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [20:33:29] New review: Mattflaschen; "Rebased and tested" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/61395 [20:40:51] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61395 [20:43:20] New review: Mattflaschen; ""If I change my test tour's Okay button to 'Xonclick'"" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63255 [20:45:18] New patchset: Spage; "Update GettingStarted to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64192 [20:45:29] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63832 [20:49:46] New patchset: Mattflaschen; "Bump GuidedTour for E3 deployment." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64193 [20:50:56] New patchset: Mattflaschen; "Bump GuidedTour for E3 deployment." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64195 [20:51:50] New patchset: Aaron Schulz; "Make sure job runner exceptions get logged." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64196 [20:55:10] wasn't there a setlang=en-us or am I totally off? [20:57:11] New review: Spage; "7c05d3b is the latest" [mediawiki/core] (wmf/1.22wmf3) C: 2; - https://gerrit.wikimedia.org/r/64193 [20:57:58] New review: Spage; "7c05d3b is the latest" [mediawiki/core] (wmf/1.22wmf4) C: 2; - https://gerrit.wikimedia.org/r/64195 [20:58:39] Danwe: en-us = en [20:58:54] don't know if there ever was an alias "en-us" for that [21:00:36] ^demon: I just wanted to start collecting and rebasing all the not-yet-upstream-accepted patches that should go into our new gerrit build. Have you decided on a branch point? [21:01:24] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64193 [21:03:06] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64195 [21:03:13] <^demon> No I hadn't. Hmmm, let's do that now [21:03:23] New review: EBernhardson; "Minor issue with badge loading red and being switched to gray by the JS, rather than loading in the ..." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63993 [21:03:48] <^demon> Building this going to be a pain in the rear. [21:04:02] maven still works :-) [21:04:26] (more or less ... eclipse integration is broken for me) [21:04:44] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64191 [21:05:07] aude: you know about mw.config.get( "wgDefaultDateFormat" ) (in JS) [21:05:16] <^demon> We're ~460 behind HEAD right now. [21:05:24] <^demon> I'm tempted to just grab HEAD, we've done it before. [21:05:34] I was just about to suggest the same thing [21:05:37] aude: it seems to be "dmy" always, though, I'd expecdt it to be "mdy" for English then [21:05:49] https://gerrit.wikimedia.org/r/58042 that one's inactive for a month now, despite being simple [21:05:57] New patchset: Reedy; "Add Thai namesapces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64199 [21:06:00] I did not know any dangerous things in between, and as there is no schema upgrade, downgrading gerrit should not be a problem [21:06:12] (in case problems arise) [21:07:07] New patchset: Demon; "Fix reviewer email notifications for new patch sets" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/62424 [21:07:08] Change merged: Demon; [gerrit] (wmf) - https://gerrit.wikimedia.org/r/62424 [21:07:11] New patchset: Rachel99; "Scenario: The cog icon is visible in the sidebar on an article" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [21:07:22] <^demon> Whoops. [21:07:25] <^demon> Wtf did I do? [21:07:33] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64192 [21:07:43] New patchset: Reedy; "Add Thai namesapces" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/64199 [21:08:03] <^demon> Oh yeah, that went in stable-2.6 and master so it merged on wmf branch [21:08:35] <^demon> Anyway, master & wmf on our "fork" are both 5c0d6b33ff3165bb14bdf3957bd1b1d764655171 now. [21:08:51] :-) [21:09:20] <^demon> I should setup a cron to sync our master with upstream daily or somesuch. [21:09:41] Danwe: not sure if dates are handled differently [21:09:59] srv193 testwiki Banner::getMixins 10.0.6.49 1054 Unknown column 'mixin_name' in 'field list' (10.0.6.49) SELECT mixin_name FROM `cn_template_mixins` WHERE tmp_id = '92' [21:10:30] awjr: know anything about that? [21:10:34] "dmy or mdy", which uses mdy if $wgAmericanDates is true [21:10:57] aude: yeah, just been there, really seems like its a global, non-user dependent thing [21:11:33] could be hmmmm [21:11:47] i'm not sure how or where it is set [21:12:06] aude: me too, $wgAmericanDates might be set somewhere dynamically [21:12:53] ^demon: Thanks. I see wmf is now at HEAD. I'll rebase the patches and do some more testing tomorrow. [21:13:04] ^demon: Do we run our own forks of plugins as well? [21:13:24] ^demon: (e.g.: replication to allow for the renaming during replication) [21:13:28] New patchset: Hoo man; "Use the UploadVerifyFile hook" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/51326 [21:13:37] <^demon> No, everything with plugins has gone upstream. [21:13:53] it is false in default settings [21:14:04] <^demon> I've just got one custom plugin I'll need to rebuild against the plugin-api once we've got it. [21:14:21] ^demon: hooks-its is still missing https://gerrit-review.googlesource.com/#/c/45201/ [21:14:23] New review: Hoo man; "Rebased... would be nice if someone could review this now..." [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/51326 [21:14:37] ^demon: replication needs your https://gerrit-review.googlesource.com/#/c/37711/ [21:14:53] <^demon> Eh, we've never relied on 37711. [21:15:02] <^demon> If it goes in, fine, if not we'll live. [21:15:06] New patchset: Bsitu; "Add EventLogging to capture Echo preference change" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64201 [21:15:27] <^demon> Merged the hooks-its one, forgot about that. [21:15:31] aude: searched the code, it's not dynamic. Anyhow, thanks. gonna be fun tomorrow... time to go home [21:15:35] Didn't we want to rebase my 'push single repository to different name' on top of 37711? [21:15:38] New patchset: MaxSem; "Rm all Sphinx support" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/64202 [21:16:21] <^demon> Oh yeah. And David pinged me about rebasing it. [21:16:26] <^demon> I'll do that now so it merges cleanly. [21:21:09] New patchset: Rachel99; "Scenario: The cog icon is visible in the sidebar on an article" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63137 [21:21:55] New patchset: Mattflaschen; "Reposition nested FancyCaptcha, conditional help." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64203 [21:23:04] New patchset: Mattflaschen; "Blank some new Create account messages by default" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64204 [21:23:41] New patchset: EBernhardson; "Database updates for respecting oversight within Echo" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [21:26:48] Change abandoned: Mattflaschen; "Not ready." [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64204 [21:27:16] Change abandoned: Mattflaschen; "Not ready" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64203 [21:34:43] New review: Asher; "(1 comment)" [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/57536 [21:37:08] heh, I thought there was no index on that [21:37:20] New review: Mwjames; "Set $smwgAutoSubobjectToSubjectReference = true will enable #subobject to behave like the SIO #set_i..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [21:38:37] New patchset: QChris; "Fix refreshing PatchScreen when fileList has not yet been loaded" [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64206 [21:39:30] New review: QChris; "Has been merged in upstream gerrit on the stable-2.6 branch, but that branch has not been merged bac..." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/64206 [21:43:54] https://bugzilla.wikimedia.org/48550 might be a wikimedia-specific bug [21:44:21] (Error deleting file: The file is in an inconsistent state within the internal storage backends) [21:46:55] Mhmm [22:09:08] Reedy: Thanks for doing and closing 43913. :-) [22:11:47] Change merged: Tim Starling; [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63817 [22:12:52] New patchset: EBernhardson; "Batch row update component" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [22:14:55] New patchset: EBernhardson; "Batch row update component" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [22:15:21] New review: Parent5446; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64182 [22:17:21] greg-g: BTW, why the 1 week wait after wmf5 before wmf6 starts? Just staff availability? [22:17:41] New patchset: Adamw; "WIP: DonationForm" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [22:17:44] greg-g: 'Cos that's the prime VE deployment period… [22:19:27] James_F: just because one of option B's design choices was starting on a Thursday [22:19:34] New patchset: Pgehres; "Changing "private" to "protected" on a few functions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64213 [22:19:59] New patchset: Pgehres; "Changing "private" to "protected" on a few functions in User.php" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64213 [22:20:08] greg-g: And you don't want to do wmf5 -> all other Wikipedias on 5 June and then wmf6 -> MWwiki on 6 June? [22:20:18] New patchset: Mwalker; "Updating CentralNotice to Master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64214 [22:20:22] I guess that's an option [22:20:32] New patchset: Jeroen De Dauw; "1.8.0.5" [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64215 [22:20:35] * greg-g ponders [22:21:00] greg-g: Otherwise we have a 3 week gap between new core code deployments [22:21:02] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (1.8.x) - https://gerrit.wikimedia.org/r/64215 [22:21:08] greg-g: Which is a bit sucky. [22:21:25] true.... [22:22:03] lemme draw that out.... [22:22:11] greg-g: Sorry! [22:22:17] * James_F is being difficult. [22:22:38] James_F: no no, useful! [22:22:47] just, work enducing [22:22:48] in? [22:22:48] whatever [22:23:05] greg-g: inducing, enduring. Yay, English. [22:23:16] New review: Parent5446; "Doc issues. Will review actual code later when I have time." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/64212 [22:24:10] New patchset: Tim Starling; "Fix memc usage" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64059 [22:24:56] New patchset: Aaron Schulz; "Bumped token expiry times a bit." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64098 [22:25:14] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64059 [22:25:23] New patchset: Aaron Schulz; "Bumped token expiry times a bit." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64098 [22:25:46] Change merged: jenkins-bot; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64214 [22:26:22] ugh, conflicts [22:26:52] New patchset: Pgehres; "Adding a maintenance script to resend email confirmation emails." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64216 [22:27:05] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64213 [22:27:37] New review: Bsitu; "UnitTest doesn't pass:" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63789 [22:28:33] New patchset: Aaron Schulz; "Bumped token expiry times a bit." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/64098 [22:31:04] thanks Aaron|home [22:32:21] I really wish we still had RESOLVED LATER [22:35:23] Reedy: what for? [22:35:23] these were never resolved, so they shouldn't be RESOLVED. lowest priority is more appropriate. [22:36:01] There's 3 requests for page curation to be enabled [22:36:08] But it's not in a state to be on those [22:36:13] so they're clogging the shell queue [22:36:30] WONTFIX them? [22:36:40] Well, WONTFIX is sort of a lie [22:36:42] !bug !shell curation [22:36:46] Removing shell will just get it re-added [22:36:46] blah, no bot here [22:36:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=42322 [22:36:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=43829 [22:37:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=44916 [22:37:15] pagecuration on wikivoyage [22:37:16] wat [22:37:37] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64046 [22:38:05] also, why is page curation even an extension, seriously guys. [22:38:36] also, those wikis are not exactly huge [22:38:58] Reedy: It's LATER. :-) [22:39:13] Hm? [22:39:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=40025 Why is that marked ops and shell? :/ [22:39:21] * greg-g finds the channel he was chatting with James_F in [22:39:24] Reedy: I'd create a new bug, saying "Refactor PageCuration so it isn't wiki-dependent", and make them all depend on that. [22:39:29] greg-g: Hey. :-) [22:39:34] greg-g: I'm in lots. :-) [22:40:00] They're still open and in the way though :/ [22:40:01] James_F: so, yeah, that would change the days for dev from the normal 14, to 17 (with the current "wait until the following thursday, the 13th" option) [22:40:11] Reedy: They're not +shell if they're not. [22:40:36] Reedy: just set the priority to lowest, duh [22:40:37] so, really, I don't see any major downfalls of going on the day after wmf5 goes out, if Reedy is ok with it, mostly [22:40:46] there's one such bug already [22:40:58] greg-g: Yeah, and we were hoping that the 6 June deadline would be the main VE beta finish. :-) [22:41:01] then you search for "P6 !shell" instead of juts "!shell" and presto. [22:41:15] blah [22:41:15] James_F: gotcha [22:41:16] -P6 [22:41:29] greg-g: We can always do a one-off deploy, but... [22:41:33] right [22:41:58] ... actually, that doesn't work [22:41:59] lol [22:42:05] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=-P6 is a 500 :D [22:42:27] Reedy: basically, looking at my current edit of https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap it has a week off, essentially, between wmf5 and 6, due to one-week transition. But it could "easily" rather be a no day off and have wmf6 start on June 6th (instead of 13th). [22:43:03] Reedy: the main issue being: June 6th is the day after wmf5 finishes going out. [22:43:23] Reedy: and, well, that affects you more than anyone, in a way. Thoughts? [22:45:52] Reedy: Bah, you and I duped. :-) [22:45:54] New review: Tim Starling; "(1 comment)" [mediawiki/extensions/Score] (master) C: 1; - https://gerrit.wikimedia.org/r/61181 [22:50:19] New review: Mattflaschen; "It would probably be useful to request (https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikimed..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [23:01:11] New patchset: Tim Starling; "DairikiDiff: Optimise method WordLevelDiff._split()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [23:02:26] say you have an iterator object that returns arrays from current(), if the iterator is invalid (self::valid() === false) is it more appropriate to return an empty array, or null? there is a partial consistency bonus for returning an empty array, but null feels like the 'correct' answer [23:04:39] PHP's each() returns false...being somewhat consistent with that by using false/null would be nice. [23:05:05] of course, it would also be required if array() could be a legitimate value [23:05:20] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61983 [23:06:04] New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/64102 [23:06:17] New review: Tim Starling; "Like you say, it's probably better to use a continuous integration style strategy on this, and make ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/61743 [23:07:50] Change merged: Tim Starling; [mediawiki/extensions/CodeEditor] (master) - https://gerrit.wikimedia.org/r/62612 [23:15:22] New patchset: Tim Starling; "In $wgConf, allow wgCanonicalServer to be false or absent" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64226 [23:18:47] New review: Asher; "schema change deployed in prod" [mediawiki/extensions/AccountAudit] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/61801 [23:18:47] Change merged: Asher; [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [23:20:08] New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [23:20:23] New patchset: Aaron Schulz; "[JobQueue] Allow using gzip on larger jobs in JobQueueRedis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/61743 [23:20:45] Aaron|home: hmm, that seems reasonable. I was leaning twords null because that seems somewhat consistent with the spl stuff, but the more i think about it the more i think that sincce it would be invalid to call current() in that case anyways, maybe should just leave it (also internal php iterators do anything from return null, to throwing a RuntimeException, or a BadMethodCallException) [23:21:02] New review: Krinkle; "Only 2 modules left for discussion. I'm still on the fence and open to either direction with better ..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63584 [23:21:04] by just leave it, i mean dont handle the edge case and let it return whatever it returns [23:23:16] TimStarling: A few weeks back when I tried to generate a list of all values for a certain config on wmf I ran into the problem what we often can't because not everything is in wgConf (several things are done later from CommonSettings). [23:23:29] TimStarling: Would it be feasible to have CommonSettings alter things in wgConf? [23:23:47] and then get it back out later? Not sure but feels like it should be possible. [23:23:55] (or move them to InitialiseSettings, ideally) [23:26:12] what things? [23:26:56] New patchset: EBernhardson; "Batch row update component" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/64212 [23:27:29] extension or core configuration? [23:32:48] TimStarling: Possibly both [23:33:02] TimStarling: Though one of the problems there is that some configuration relies on others. [23:33:21] And the only way to set it is to do it from CommonSettings right now, at least I guess that is the reason we do it that way now [23:35:02] I don't think CommonSettings.php would be the right place to modify $wgConf... [23:35:06] New review: Krinkle; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/64128 [23:35:13] just because it's usually not loaded in full when CommonSettings.php executes [23:35:22] so the array isn't there to modify [23:36:14] maybe a hook into SiteConfiguration::loadFullData() would be feasible? [23:36:18] New review: Krinkle; "I think something is wrong in how it is loaded then. Loading a js+css module with regular addModules..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [23:36:24] New patchset: Pgehres; "Update: Adding aa_method to AccountAudit" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64228 [23:37:56] all the conf cache stuff should probably be moved into the MW core, that would make it easier to maintain [23:38:48] New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [23:40:01] New review: Mwjames; "Nothing has changed in how we load modules since MW 1.20 and only recently (namely 1.22) unstyled co..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [23:40:24] New patchset: Pgehres; "Update: Adding aa_method to AccountAudit" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64230 [23:40:31] New review: Krinkle; "There should be no need to reinvent jquery.badge. The notif count and class are still added from jav..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [23:41:39] New review: Krinkle; "I'm not aware of such regression and haven't seen it myself. Bug report, steps to reproduce this and..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [23:42:25] Change merged: Pgehres; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/64230 [23:42:35] Change merged: Pgehres; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/64228 [23:51:47] New review: Mwjames; "I raised my voice in bug 46401 and was put down but noting that no such regression has been reported." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/64128 [23:52:05] New patchset: Tim Starling; "(bug 47216) API: indicate default and skipped skins in meta=siteinfo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59146 [23:53:38] New review: Tim Starling; "PS2: rebase." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/59146 [23:54:48] New patchset: Mattflaschen; "Preserve exception when logging, as suggested by S." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63260 [23:56:19] Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/59146 [23:56:55] New review: Mattflaschen; "S, I think I misunderstood what you mean. I thought you meant the text of the button, but now I thi..." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63255