[00:05:23] New review: Tim Starling; "Aaron and I discussed that question at length when I originally worked on OggHandler integration. It..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [00:09:04] New review: Krinkle; "Nice, having this as a template will save a bit of work. For comparison/inspiration, I use the follo..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [00:10:53] New review: Krinkle; "I stopped using ini_set('display_errors', 1); and moved it to httpd config instead because ini_set( ..." [mediawiki/vagrant] (master) - https://gerrit.wikimedia.org/r/63240 [00:12:23] TimStarling: can extension easily tag handlers return UNIQ ... QINO tags and then replace those out after parsing easily? [00:13:30] s/extension easily/extension [00:13:43] extension tag handlers can use $parser->insertStripItem [00:14:06] is that sufficient for your needs? [00:16:10] of course, normal tag hooks are already strip items, so there's no need to use it for them, normally [00:17:35] well the unstrip will return HTML that isn't fully known at the time insertStripItem is called [00:18:09] New patchset: Ryan Lane; "Use jquery.chosen for the project filter" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63807 [00:19:47] New review: Dzahn; "replacing the SVN reference makes sense, details per bug" [wikimedia/bugzilla/modifications] (master) C: 2; - https://gerrit.wikimedia.org/r/62218 [00:20:06] New review: Dzahn; "replacing the SVN reference makes sense, details per bug" [wikimedia/bugzilla/modifications] (master); V: 2 - https://gerrit.wikimedia.org/r/62218 [00:20:07] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62218 [00:20:23] TimStarling: I'm not thinking of cross-node dependencies though, just query batching [00:20:58] you can have the strip item expand to an HTML comment [00:21:13] and then replace the HTML comment in ParserAfterParse [00:21:17] New review: Dzahn; "deployed live" [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/62218 [00:21:22] no, too early [00:21:30] New patchset: Jdlrobson; "Give skin more control of OutputPage modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [00:21:38] ParserAfterTidy [00:22:11] query batching is a bit tricky to do with limited memory, have you seen how I did it for links? [00:23:20] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63808 [00:24:01] I suppose if you can impose hard limits on the user, then that part doesn't matter so much [00:24:10] and then ParserAfterTidy becomes easy enough [00:24:14] New patchset: Ryan Lane; "Use jquery.chosen for the project filter" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63807 [00:24:27] . [00:24:30] New review: Mattflaschen; "(1 comment)" [mediawiki/vagrant] (master) C: 1; - https://gerrit.wikimedia.org/r/63783 [00:24:51] New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63809 [00:25:10] TimStarling: hmm, I was thinking of score [00:25:15] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63809 [00:25:30] Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63808 [00:25:37] } elseif ( isset( $existingFiles[$multi1Path] ) ) { // @fixme: $multi1Path is undefined [00:25:42] TimStarling: btw, what is that about? [00:26:45] just Reedy adding fixme comments instead of fixing things [00:27:05] ^ Krinkle Trevor|afk attempt #1 https://gerrit.wikimedia.org/r/63584 commence bikeshedding :) [00:27:17] $multi1FileName perhaps [00:27:22] ;) [00:27:50] yes, $existingFiles does appear to have names as keys, not paths [00:28:00] maybe I realised that at some point and renamed the variable [00:29:16] lol [00:29:48] jdlrobson: inline comments go over the line, not after the line [00:30:44] jdlrobson: I wonder if you can array_values/flatten it instead of calling addModules() in a loop, might be more efficient [00:30:49] Ill leave gerit comments instead [00:31:14] Krinkle: thanks :) [00:42:51] New patchset: Dzahn; "Add support for Wikimedia Mingle URLs to Bugzilla's 'See Also' field." [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [00:43:03] New patchset: Tim Starling; "cleanup: variable referenced without initialization" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53131 [00:43:15] Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53131 [00:46:04] New patchset: Jdlrobson; "Give skin more control of OutputPage modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [00:48:11] New review: Dzahn; "rebased, resolved path conflict, enable links from BZ to Mingle" [wikimedia/bugzilla/modifications] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/59862 [00:48:16] Change merged: Dzahn; [wikimedia/bugzilla/modifications] (master) - https://gerrit.wikimedia.org/r/59862 [00:55:09] New patchset: Krinkle; "docs: Consistency use "since" phrasing in @deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63813 [00:56:35] New patchset: Krinkle; "docs: Consistency use "since" phrasing in @deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63813 [00:56:58] New patchset: Krinkle; "docs: Consistently use "since" phrasing in @deprecated" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63813 [01:12:18] New patchset: Krinkle; "docs: Remove odd colons after @todo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63816 [01:13:03] New patchset: Krinkle; "docs: Remove odd colons after @todo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63816 [01:17:34] TimStarling: Any idea what could be causing MediaWiki to output multiple pages in one response? [01:18:10] When did a purge on http://docs.jquery.com/Main_Page just now http://docs.jquery.com/purge/Main_Page I got the page multipe times. [01:18:10] is this WMF or jQuery? [01:18:17] right [01:18:22] jquery again, they're probably going to report a bug later [01:18:31] I can reproduce it locally sometimes. [01:18:49] the first output is teh regular page, teh seocnd output is a datal db error from teh job queue [01:18:56] fatal* [01:19:18] that's just a normal failure mode [01:19:33] you should make it so you don't get fatal DB errors from the job queue [01:20:11] New patchset: Tim Starling; "Add JavaScript login check against the central wiki" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [01:20:31] TimStarling: Easier said than done, but that's what I;m thinking too [01:20:33] Change merged: jenkins-bot; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/58924 [01:20:35] here's what it looks like, weird: http://cl.ly/image/1Q1n1p2v2G3F [01:21:06] 2x etc. [01:21:48] <TimStarling> yeah, see MWException::reportHTML() [01:22:43] <TimStarling> it calls $wgOut->output() whether or not it has been called already [01:23:11] <Krinkle> TimStarling: That's kinda weird though. I suppose it is quite rare that it fails after OutputPage is finished (pretty much only jobqueue runs after that) [01:23:27] <Aaron|home> and DeferredUpdates and profiling [01:23:37] <Krinkle> Right, good one [01:23:51] <Krinkle> At least it is "expected" so no bug there [01:24:01] <TimStarling> well, no new bug [01:24:11] <TimStarling> you could say that it was a bug introduced in 1.7 or something [01:24:22] <TimStarling> that nobody has bothered to look at until now [01:26:36] <Krinkle> deferred updates, job queue and profiling are all kind of "new" / "develop" / "small" scale things that aren't usually in production, or it wouldl've been addressed. [01:27:02] <Krinkle> deferred updates is new iirc, job queue in request is for smaller sites, profiling is develop. [01:27:22] <Krinkle> natural consequence, I'll poke the bug, but skip that part of the report for now [01:27:23] <TimStarling> no, deferred updates has always been there [01:27:30] <Krinkle> Cool, didn't know that. [01:28:41] <TimStarling> the DeferredUpdates class is new, but not the concept [01:29:02] <TimStarling> it was originally just a global variable and few lines of code in index.php [01:32:02] <gerrit-wm> New patchset: Aaron Schulz; "Fixed bogus variable reference." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63817 [01:38:51] <gerrit-wm> New patchset: Aaron Schulz; "Hide exceptions in MediaWiki::doJobs() as deferred updates do." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63818 [01:38:52] <Krinkle> TimStarling: Aaron|home: both profiling and wgShowSQLErrors tells me the curlpit is a very specific query [01:38:58] <Krinkle> Query: UPDATE `job` SET job_token = [01:39:34] <Krinkle> I have no idea why the job queue would throw on that though [01:39:51] <TimStarling> you should use maintenance/runJobs.php [01:39:57] <Krinkle> Probably mysql being the problem. [01:40:10] <TimStarling> web execution is just there for people who don't know how to set up a cron job [01:40:18] <Krinkle> TimStarling: yeah, I'll switch to jobqueue cron [01:40:40] <TimStarling> maybe we should have a cron.php, like drupal [01:40:51] <Aaron|home> I think that query is not happening in auto-commit mode either [01:41:03] <Krinkle> TimStarling: That isn't very well advertised though, I've not set it up once for a wiki. I suppose I could have, just didn't think about it. [01:41:24] <Krinkle> and wasn't an issue in regular usage on smaller wikis [01:41:35] <TimStarling> in drupal, the admin interface will complain if it has been more than some amount of time since cron.php was last invoked [01:41:44] <TimStarling> it's a web script which you invoke from a cron job with curl [01:45:44] <Krinkle> I implemented something similar in TestSwarm I recall now [01:46:26] <Krinkle> TimStarling: For what its worth, the same error is happening when I run it from cli. [01:46:36] <Krinkle> Query: UPDATE `job` SET job_token = 'X',job_token_timestamp = 'X',job_attempts = job_attempts+1 WHERE job_cmd = 'refreshLinks' AND job_id = 'X' AND job_token = '' Function: JobQueueDB::claimRandom Error: 1205 Lock wait timeout exceeded; try restarting transaction (localhost) [01:46:44] <Krinkle> MySQL is borked I guess [01:47:03] <TimStarling> probably all the web requests running that query simultaneously [01:49:41] <Krinkle> Ah, so its a cause, not an effect. That's possible, too. [01:50:10] <Krinkle> There are no more http requests pending from before I ran this though [01:50:47] <Krinkle> nope, spoke too soon. mysql takes a bit longer to recover [01:50:57] <Krinkle> the cli exec is working now [01:50:58] <Krinkle> Aweesome [01:53:21] <gerrit-wm> New patchset: Aaron Schulz; "[JobQueue] In addition to flushing any transaction, be sure to avoid new ones." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63819 [02:03:30] <Aaron|home> TimStarling: ^ [02:12:15] <Susan> Lawl at Echo + revision suppression. [02:13:57] <gerrit-wm> New review: Tim Starling; "I tried testing this with $wgCentralAuthLoginWiki left as the default of false, since it seemed like..." [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/62194 [02:15:54] <Susan> Risker is convinced that every new feature doesn't account for revision suppression or CheckUser or whatever else. [02:16:00] <Susan> And many times, she's right. [02:16:10] <Susan> Gotta make better use of existing APIs, I think. [02:16:23] <Susan> Or something. [02:17:13] <TimStarling> it took a long time for MediaWiki's core functionality to approach the level of complexity needed for a public wiki [02:17:56] <Susan> It's taking, rather. [02:18:07] <Susan> ;-) [02:19:42] <gerrit-wm> New review: Peachey88; "Please fix the commit message." [mediawiki/extensions/CommunityTwitter] (refs/meta/config) C: -1; - https://gerrit.wikimedia.org/r/63820 [02:24:33] <Susan> Yes, it seems like your view will ultimately win. [02:24:40] <Susan> MediaWiki will be a large software project. [02:25:18] <Susan> There's talk of user renaming going into core. It'd sure be nice to stop storing the username in so many places first... [02:29:37] <gerrit-wm> New patchset: Aaron Schulz; "[JobQueue] Added a function to delete all jobs from a queue." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63821 [02:33:03] <gerrit-wm> New review: Krinkle; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63819 [02:37:08] * Aaron|home reads http://wikimedia.7.x6.nabble.com/Wikimedia-l-Go-away-community-from-WMF-wiki-at-least-td5004597.html [02:37:58] <Susan> I was thinking whether individual configuration files for wikis made more sense than a single PHP file. [02:38:04] <Susan> Though I guess that's kind of a silly thought. [03:11:38] <p858snake|l> Susan: the R/Nuser ext is already bundled in the installer... no need for it to be core [03:12:28] <Susan> Apparently others disagree. [03:12:30] <Susan> Did you see the bug? [03:12:46] <Susan> https://bugzilla.wikimedia.org/show_bug.cgi?id=25482 [03:12:55] <p858snake|l> the one reedy filed before we could bundle in the installer and has since been closed? yes, i've seen that [03:13:51] <gerrit-wm> New review: Parent5446; "Unfortunately I'm busy tonight. I'll try and test this tomorrow." [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [03:21:08] <Susan> p858snake|l: I forgive you. [03:47:19] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63416 [04:05:24] <gerrit-wm> New patchset: Adamw; "Finish moving validation out of GatewayForm and into the adapter." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63823 [04:05:55] <gerrit-wm> New review: Adamw; "p.s. this is untested" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63823 [04:14:41] <gerrit-wm> New patchset: Aaron Schulz; "Made DatabaseBase::getSoftwareLink() dynamic." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63824 [04:15:38] <gerrit-wm> New patchset: Karim.rayani; "Feature: Print/export section expand and collapse" [qa/browsertests] (master) - https://gerrit.wikimedia.org/r/63825 [04:16:02] <gerrit-wm> New patchset: Aaron Schulz; "[JobQueue] In addition to flushing any transaction, be sure to avoid new ones" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63819 [04:19:13] <gerrit-wm> New patchset: Aaron Schulz; "Made DatabaseBase::getSoftwareLink() dynamic." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63824 [04:37:29] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63419 [05:04:42] * mooey|finals yawns and waves hello [05:05:35] <gerrit-wm> New patchset: Adamw; "WIP: banner DonationForm backend support" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/61929 [06:00:03] <gerrit-wm> New review: Aaron Schulz; "A few bits" [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/57662 [06:01:23] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63465 [06:02:27] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63813 [06:23:47] <gerrit-wm> New patchset: IAlex; "docs: Remove odd colons after @todo" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63816 [06:29:12] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63816 [06:31:20] <gerrit-wm> New review: Siebrand; "Marking -1 to indicate follow-up is needed." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/63658 [06:44:01] <gerrit-wm> New review: Siebrand; "Ping?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [07:01:50] <gerrit-wm> New review: Wikinaut; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [07:07:22] <gerrit-wm> New review: Wikinaut; "Results of my further tests are okay. " [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [07:11:38] <gerrit-wm> New patchset: FastLizard4; "Add the extension's group to the owners list" [mediawiki/extensions/CommunityTwitter] (refs/meta/config) - https://gerrit.wikimedia.org/r/63820 [07:12:08] <gerrit-wm> New review: FastLizard4; "There, got it to accept my modified commit message. Happy now?" [mediawiki/extensions/CommunityTwitter] (refs/meta/config) C: 1; - https://gerrit.wikimedia.org/r/63820 [07:13:29] <gerrit-wm> New patchset: IAlex; "(bug 41337) Fix fatal error occuring in Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31321 [07:34:55] <gerrit-wm> New patchset: IAlex; "Fix fatal error when $wgValidateAllHtml is enabled and apache_request_headers() does not exists" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [07:35:24] <gerrit-wm> New review: Mattflaschen; "Looks good, minor qqq note." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [07:35:26] <gerrit-wm> New review: IAlex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [07:41:46] <gerrit-wm> New patchset: Amire80; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [07:44:00] <gerrit-wm> New review: Mattflaschen; "I agree it shouldn't be styled twice, but it might be useful to do a fallback style if JavaScript is..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63256 [07:45:57] <gerrit-wm> New patchset: Amire80; "Replace id uls-more-languages with class" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63828 [08:22:49] <gerrit-wm> New patchset: Hashar; "Whitelist Daniel Friesen (Dantman, nadir-seen-fire)" [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63380 [08:24:08] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62975 [08:24:34] <gerrit-wm> Change merged: Hashar; [integration/zuul-config] (master) - https://gerrit.wikimedia.org/r/63380 [08:25:32] <gerrit-wm> New review: Mattflaschen; "Jenkins doesn't run here." [mediawiki/extensions/GuidedTour/guiders] (master); V: 2 - https://gerrit.wikimedia.org/r/63105 [08:25:32] <gerrit-wm> Change merged: Mattflaschen; [mediawiki/extensions/GuidedTour/guiders] (master) - https://gerrit.wikimedia.org/r/63105 [08:26:10] <gerrit-wm> New review: Mattflaschen; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [08:28:00] <gerrit-wm> New review: Hashar; "That looks nicer indeed https://doc.wikimedia.org/mediawiki-core/master/php/html/classLogPager.html#..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62975 [08:28:23] <gerrit-wm> New review: Hashar; "https://doc.wikimedia.org/mediawiki-core/master/php/html/classLogPager.html#ae2f6bba7ce0698786a00ea9..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62975 [08:28:45] <gerrit-wm> New review: Hashar; "Well sorry for the spam, get a look at https://doc.wikimedia.org/mediawiki-core/master/php/html/clas..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62975 [08:29:16] <gerrit-wm> New review: Mattflaschen; "This is ready for review." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/62778 [08:32:14] <gerrit-wm> New patchset: Spage; "First cut at general campaign support" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63829 [08:34:05] <gerrit-wm> New review: Daniel Friesen; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [08:35:31] <gerrit-wm> New review: IAlex; "Oh sorry. I would like to have solved, but would not oppose if somebody else finds this good." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/53411 [08:38:37] <gerrit-wm> New review: Spage; "This is for people who'd rather view code than read a spec, but it's not ready yet." [mediawiki/extensions/EventLogging] (master) C: -1; - https://gerrit.wikimedia.org/r/63829 [08:42:35] <gerrit-wm> New patchset: Amire80; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [08:43:28] <gerrit-wm> New review: IAlex; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [08:45:15] <gerrit-wm> New patchset: Amire80; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [08:48:00] <gerrit-wm> New patchset: Hashar; "(bug 41337) Fix fatal error in Special:Preferences" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31321 [08:49:31] <gerrit-wm> New review: Hashar; "rebased, wrapped commit message. That is fine now, thank you iAlex!" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/31321 [08:52:23] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/31321 [08:57:52] <gerrit-wm> New review: TheDJ; "These are most of them I think." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/62439 [09:04:16] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63454 [09:04:16] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63453 [09:14:43] <gerrit-wm> New patchset: J; "Pass length of ogg file to TimedMediaTransformOutput" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/61181 [09:19:55] <gerrit-wm> New patchset: Santhosh; "Avoid duplicate languagesettings dialog in page source" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63830 [09:28:13] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63830 [09:34:15] <gerrit-wm> New patchset: Mattflaschen; "Allow suppressing the automatic okay button." [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63831 [09:35:59] <gerrit-wm> New patchset: Mattflaschen; "Use Next/Okay conditionally depending on whether there are edit links." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63832 [09:36:39] <gerrit-wm> New review: Mattflaschen; "This doesn't have a hard dependency on https://gerrit.wikimedia.org/r/63831 , but that is required t..." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63832 [09:37:51] <gerrit-wm> New review: Mattflaschen; "recheck" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63255 [09:38:09] <gerrit-wm> New patchset: Mattflaschen; "Add check for missing onclick function, document, fix exception" [mediawiki/extensions/GuidedTour] (master) - https://gerrit.wikimedia.org/r/63255 [09:38:25] <gerrit-wm> New patchset: Aude; "Update Wikibase, Diff, DataValues" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63833 [09:39:26] <gerrit-wm> New review: Mattflaschen; "mw.hook change is Ic73a3efe53d6fb731e7f1e531d5f51530cd7e4fe" [mediawiki/extensions/PostEdit] (master) - https://gerrit.wikimedia.org/r/62952 [09:40:22] <gerrit-wm> New review: Aude; "not sure the procedure for doing this, but we also need git submodule init and update for the easyRd..." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63833 [10:00:02] <gerrit-wm> New patchset: Mattflaschen; "Add server-side logging to snippets, with i18n for header." [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63601 [10:00:49] <gerrit-wm> New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/EventLogging] (master) - https://gerrit.wikimedia.org/r/63601 [10:03:38] <gerrit-wm> New review: Santhosh; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/63658 [10:07:28] <gerrit-wm> New patchset: Pastakhov; "Refactoring of runtime and add array support (version 0.2.0)" [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [10:14:10] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/Foxway] (master) - https://gerrit.wikimedia.org/r/62217 [10:27:50] <gerrit-wm> New patchset: Amire80; "Set the position of display settings to match ULS" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [10:29:12] <gerrit-wm> New review: Amire80; "(1 comment)" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63658 [11:15:16] <gerrit-wm> New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [11:40:36] <Reedy> hashar: About? [11:40:46] <hashar> Reedy: ? :D [11:40:55] <Reedy> Does labs have parser cache setup? [11:41:14] <Reedy> I'm slightly confused about the conditional [11:41:15] <Reedy> 343 343 if ($wmfDatacenter == 'eqiad') { [11:41:15] <Reedy> 344 344 ยป # pc1001, pc1002, pc1003 [11:41:35] <Reedy> meaning it would fallback to foreach ( array( '10.0.0.221', '10.0.0.222', '10.0.0.223' ) as $host ) { on labs [11:42:24] <hashar> hmm [11:42:42] <hashar> maybe there is no parsercache [11:43:27] <hashar> Reedy: seems beta uses memcached [11:43:37] <Reedy> Yeah, looks slightly conditional [11:43:38] <Reedy> 0 => $wgObjectCaches['memcached-pecl'], [11:43:38] <Reedy> 1 => array( [11:43:38] <Reedy> 'class' => 'SqlBagOStuff', [11:43:40] <hashar> wmf-config/InitialiseSettings-labs.php [11:44:25] <hashar> hashar@deployment-bastion:~$ mwscript eval.php --wiki=enwiki [11:44:26] <hashar> > var_dump( $wgParserCacheType ); [11:44:26] <hashar> int(2) # CACHE_MEMCACHED [11:45:04] <Reedy> So yeah, it's that done on that. slightly confusing ;) [11:45:24] <Reedy> I'm trying to pull numerous of the conditionals [11:45:25] <Reedy> squid done [11:45:43] <Reedy> session is https://gerrit.wikimedia.org/r/#/c/63839/ [11:50:29] <gerrit-wm> New patchset: Matthias Mullie; "UI improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/59156 [11:52:36] <gerrit-wm> New patchset: Santhosh; "Simplify the language settings display" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63840 [11:53:21] <gerrit-wm> New review: Santhosh; "Yet to test all possible scenario for this dialog. So -1." [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/63840 [12:15:42] <gerrit-wm> New patchset: Hoo man; "Fix the use of globals in ApiQueryTitleBlacklistTest" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/63841 [12:29:58] <gerrit-wm> New patchset: Netbrain; "updated subproject" [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/63842 [12:30:14] <gerrit-wm> Change merged: Netbrain; [mediawiki/extensions/Spreadsheet] (master) - https://gerrit.wikimedia.org/r/63842 [12:34:16] <gerrit-wm> New patchset: Amire80; "Scroll language settings on all changes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63843 [13:20:48] <gerrit-wm> New patchset: Aude; "Update Wikibase, Diff, DataValues" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63833 [13:26:18] <gerrit-wm> New review: Brion VIBBER; "I can't repro this with ImageMagick 6.8.5 on Linux, so I'm chalking it up to my Mac being wonky. :)" [mediawiki/extensions/Score] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63725 [13:40:42] <gerrit-wm> New patchset: Jeroen De Dauw; "Add MediaWikiTitleValue related code which got moved from the DataValues repository" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/63847 [13:49:15] <gerrit-wm> New patchset: Amire80; "Don't show anonymous users tipsy with setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63848 [14:00:48] <gerrit-wm> New patchset: Jeroen De Dauw; "Add MediaWikiTitleValue related code which got moved from the DataValues repository" [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/63847 [14:06:16] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/Validator] (master) - https://gerrit.wikimedia.org/r/63847 [14:09:20] <gerrit-wm> New review: Jeroen De Dauw; "This seems to be going in the right direction :)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61769 [14:10:25] <gerrit-wm> New patchset: Jeroen De Dauw; "Jenkins phpunit test " [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [14:21:33] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63788 [14:23:17] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/63273 [14:29:17] <gerrit-wm> New review: Mdale; "MediaWiki includes some utilities for url encoding: " [mediawiki/extensions/TimedMediaHandler] (master) C: -1; - https://gerrit.wikimedia.org/r/63417 [14:34:58] <gerrit-wm> New review: Jeroen De Dauw; "Not done w/ review yet but gotta run" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61171 [14:39:41] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63824 [14:41:41] <gerrit-wm> New review: Nikerabbit; "What happens when anon users can change language?" [mediawiki/extensions/UniversalLanguageSelector] (master) C: -1; - https://gerrit.wikimedia.org/r/63848 [14:44:32] <gerrit-wm> New patchset: Amire80; "Remove custom search box clear icon" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/63856 [14:44:33] <gerrit-wm> New patchset: Anomie; "(bug 46905) Add "centralauthtoken" to API" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [14:52:13] <gerrit-wm> New patchset: J; "(bug 48300) escape title in edit url" [mediawiki/extensions/TimedMediaHandler] (master) - https://gerrit.wikimedia.org/r/63417 [15:07:49] <gerrit-wm> Change abandoned: Demon; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60394 [15:08:54] <gerrit-wm> New patchset: Jqnatividad; "Added extended handling of MongoDB results. If an answer column is an array, return as JSON. If an answer column is a GeoJSON geometry, return as a string Maps can understand, i.e. latlong pairs delimited by colons. Otherwise, return as usual - as a strin" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/63858 [15:09:55] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63591 [15:25:24] <gerrit-wm> New review: Umherirrender; "I am not sure, if a release note is needed for this, there is no bug, so nobody, except me, cares ab..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [15:39:11] <gerrit-wm> New patchset: J; "use shrink instead of im_shrink" [mediawiki/extensions/VipsScaler] (master) - https://gerrit.wikimedia.org/r/63862 [15:50:38] <gerrit-wm> New patchset: Matthias Mullie; "Feedback link on article pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/35168 [15:50:38] <gerrit-wm> New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [15:55:33] <gerrit-wm> New patchset: Anomie; "Do not bold all entries of an unvisited page on the Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [15:55:39] <gerrit-wm> New patchset: Anomie; "Do not bold all entries of an unvisited page on the Watchlist" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [15:55:45] <gerrit-wm> New review: Anomie; "I find your reasoning convincing." [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/41592 [15:56:30] <gerrit-wm> New patchset: Jqnatividad; "Added extended handling of MongoDB results. If an answer column is an array, return as JSON. If an answer column is a GeoJSON geometry, return as a string Maps can understand, i.e. latlong pairs delimited by colons. Otherwise, return as usual - as a st" [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/63858 [16:00:13] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/41592 [16:01:07] <gerrit-wm> New review: Yaron Koren; "Hi Joel," [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/63858 [16:09:23] <gerrit-wm> New review: Andrew Bogott; "This looks good!" [mediawiki/extensions/OpenStackManager] (master) C: 2; - https://gerrit.wikimedia.org/r/63807 [16:09:23] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61264 [16:09:39] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63807 [16:09:48] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61263 [16:11:01] <gerrit-wm> New review: Jeroen De Dauw; "I dislike having an "Auxiliary" namespace." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [16:13:08] <gerrit-wm> New review: Jeroen De Dauw; "I'd be more comfortable merging this if it was disabled by default for now, perhaps only do the regi..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [16:14:52] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/57757 [16:16:28] <gerrit-wm> New review: Jeroen De Dauw; "The + 4 is critical, if you remove it, the invalidation no longer works. The page needs to be invali..." [mediawiki/extensions/SemanticMediaWiki] (master) C: -2; - https://gerrit.wikimedia.org/r/57853 [16:20:14] <gerrit-wm> New patchset: Matthias Mullie; "Quickly enable/disable AFTv5" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/61797 [16:21:01] <gerrit-wm> New review: Jeroen De Dauw; "Needs rebase" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [16:26:07] <gerrit-wm> New review: Mwjames; "Any preference towards the namespace? Just SMW\Lua?" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/56393 [16:26:16] <gerrit-wm> New review: Jeroen De Dauw; "Methods are missing visibility and are all static. Plus there are some quite big ones. And no tests." [mediawiki/extensions/CentralAuth] (master) C: -1; - https://gerrit.wikimedia.org/r/57662 [16:27:35] <gerrit-wm> New review: Mwjames; "I'll do a rebase later since this will need manual intervention." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/58040 [16:28:31] <gerrit-wm> New review: Jeroen De Dauw; "Some huge methods here, all static, lots of OCP violations... not really introduced here I guess, so..." [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/62243 [16:29:05] <gerrit-wm> New review: Umherirrender; "See bug 45133 for the missing associated part in Special:NewPages. Maybe that can be done together w..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/52676 [16:29:38] <gerrit-wm> New review: Mwjames; "I'll have to revisit this." [mediawiki/extensions/SemanticMediaWiki] (master) C: -2; - https://gerrit.wikimedia.org/r/57853 [16:32:03] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63631 [16:33:03] <rickyb98> could anybody help me with abusefilter? [16:34:01] <gerrit-wm> New review: Jqnatividad; "Hi Yaron," [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/63858 [16:34:22] <gerrit-wm> New review: Anomie; "@Jeroen: Major refactoring should be done in its own patch, not bundled with substantive functionali..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [16:35:17] <gerrit-wm> New review: Umherirrender; "Needs rebasing and someone to review/merge" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/28908 [16:35:47] <gerrit-wm> New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [16:38:32] <gerrit-wm> New review: Yaron Koren; "Okay, cool. Looks good!" [mediawiki/extensions/ExternalData] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/63858 [16:38:32] <gerrit-wm> Change merged: Yaron Koren; [mediawiki/extensions/ExternalData] (master) - https://gerrit.wikimedia.org/r/63858 [16:38:55] <gerrit-wm> New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63868 [16:41:54] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [16:46:50] <gerrit-wm> New review: Wikinaut; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [16:48:37] <gerrit-wm> New review: Mwjames; "This is non critical as it only splits class responsibility and therefore put this on hold for now." [mediawiki/extensions/SemanticMediaWiki] (master) C: -1; - https://gerrit.wikimedia.org/r/57701 [16:54:29] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63868 [16:58:26] <AaronSchulz> ^demon: https://gerrit.wikimedia.org/r/#/c/63706/ [16:58:48] <gerrit-wm> New patchset: Anomie; "Replace image-based AutoLogin with iframes" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [17:03:37] <gerrit-wm> New review: Anomie; "PS8: Fixed the possibility of DDOS." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/62194 [17:08:11] <gerrit-wm> New patchset: Umherirrender; "Fixed spacing and removed unneeded parenthesis" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63874 [17:09:29] <gerrit-wm> New review: Jeroen De Dauw; "My remarks are about the code that you added. They might also apply to existing code (looks like it)..." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [17:14:03] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Score] (master) - https://gerrit.wikimedia.org/r/63817 [17:17:07] <gerrit-wm> New review: Jeroen De Dauw; "Looks like it does what it says it does..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63818 [17:18:53] <gerrit-wm> New review: Jeroen De Dauw; "Nothing obviously wrong to me, though having some tests for the new behaviour would be nice" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63821 [17:19:06] <gerrit-wm> New patchset: MarkTraceur; "Add parsoid-specific image testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [17:19:07] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63706 [17:21:44] <gerrit-wm> New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [17:21:58] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [17:23:21] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [17:25:10] <gerrit-wm> New patchset: Yurik; "Updated Zero extension to master" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63875 [17:26:46] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63688 [17:26:52] <gerrit-wm> Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63875 [17:27:29] <gerrit-wm> New review: Anomie; "IMO it's generally better to follow the style of the existing code." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [17:28:09] <AaronSchulz> anomie: I think someones going a little nuts :) [17:28:29] <anomie> AaronSchulz: Going? [17:28:51] * AaronSchulz was looking at 61801 [17:30:32] <gerrit-wm> Change abandoned: Demon; "Can be any relative or absolute URI. Working on getting this in upstream though -> Abandoned." [gerrit] (wmf) - https://gerrit.wikimedia.org/r/60662 [17:34:17] <gerrit-wm> New patchset: Demon; "Allow setting of connection timeouts for HTTP requests using cURL" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58247 [17:35:45] <gerrit-wm> New patchset: Aaron Schulz; "[FileBackend] Avoid concurrency for the 1 op case in doQuickOperationsInternal()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63881 [17:36:02] <gerrit-wm> New patchset: Ryan Lane; "Fix qqq for previously renamed echo messages" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63882 [17:37:00] <gerrit-wm> Change merged: Demon; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63882 [17:38:00] <gerrit-wm> New patchset: Ryan Lane; "Add a custom submit text for the project filter" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63884 [17:38:43] <gerrit-wm> New review: GWicke; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/58113 [17:42:34] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/63884 [17:43:01] <AaronSchulz> ^demon: can you check https://gerrit.wikimedia.org/r/#/c/63819/ ? [17:43:41] <AaronSchulz> ^demon: I'd like to have that in 1.21 too [17:45:02] <gerrit-wm> New patchset: Ryan Lane; "Up version of OpenStackManager to use new project filter" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63885 [17:46:08] <gerrit-wm> New patchset: Siebrand; "Localisation updates from http://translatewiki.net." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63886 [17:48:48] <gerrit-wm> Change merged: Ryan Lane; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63885 [17:48:58] <gerrit-wm> New patchset: Yurik; "Updated Zero extension to master" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63887 [17:49:23] <gerrit-wm> Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63887 [17:49:53] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63819 [17:52:54] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63886 [17:55:01] <gerrit-wm> New patchset: Pgehres; "Adding aa_method field to track login method." [mediawiki/extensions/AccountAudit] (master) - https://gerrit.wikimedia.org/r/61801 [17:55:39] <gerrit-wm> New review: Aaron Schulz; "wip" [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/63821 [17:58:51] <gerrit-wm> New review: Wikinaut; "(1 comment)" [mediawiki/extensions/OpenID] (master) - https://gerrit.wikimedia.org/r/45474 [17:59:12] <gerrit-wm> New patchset: Aaron Schulz; "[JobQueue] Added a function to delete all jobs from a queue." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63821 [17:59:44] <gerrit-wm> New review: Raimond Spekking; "Merge per Mark's CR+2" [mediawiki/extensions/GooglePlusOne] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/62523 [17:59:45] <gerrit-wm> Change merged: Raimond Spekking; [mediawiki/extensions/GooglePlusOne] (master) - https://gerrit.wikimedia.org/r/62523 [18:08:41] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63821 [18:23:33] <Krenair> gerrit having issues? [18:24:11] <Krenair> hm. seems okay now... [18:24:28] <gerrit-wm> New patchset: MarkTraceur; "Add parsoid-specific image testing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/58113 [18:24:36] <marktraceur> Oh my gods [18:24:42] <gerrit-wm> New patchset: Aaron Schulz; "Fixed total breakage of HashRing in 9d1cd9a." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63891 [18:24:43] <marktraceur> That took at least 10 minutes [18:26:17] <gerrit-wm> New review: Jeroen De Dauw; "You really think it is better to follow the style of obviously bad code?!" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [18:28:38] <gerrit-wm> New review: Jeroen De Dauw; "(1 comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/54111 [18:29:31] <gerrit-wm> New review: Anomie; "Not everyone thinks the existing code is as bad as you do, even if it's not as good as it could be." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/57662 [18:31:57] <gerrit-wm> New patchset: Kaldari; "For non-bundled page-link flyout notifications, link to article" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63894 [18:31:58] <gerrit-wm> New patchset: Mwjames; "Extend SMW\SpecialsTest" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [18:32:14] <gerrit-wm> New patchset: Krinkle; "wikibits: Wrap jsMsg in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60268 [18:32:15] <gerrit-wm> New patchset: Krinkle; "wikibits: Pass JSHint" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60269 [18:32:15] <gerrit-wm> New patchset: Krinkle; "wikibits: Wrap UA and accesskey globals in mw.log.deprecate" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60266 [18:32:16] <gerrit-wm> New patchset: Krinkle; "wikibits: Replace checkboxShiftClick globals with dummies" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60267 [18:32:17] <gerrit-wm> New review: Mwjames; "For now I can live without the content language setter but I'll keep the code here as reminder in ca..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [18:44:48] <gerrit-wm> New patchset: GWicke; "Add more tests for paragraphs and headings with extra spacing" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/55273 [18:45:11] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/61179 [18:50:47] <gerrit-wm> New patchset: Umherirrender; "Replaced some function calls with local vars" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63896 [18:57:09] <gerrit-wm> New patchset: EBernhardson; "Link directly to the edited section from edit-user-talk events" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [19:00:43] <gerrit-wm> New patchset: Reedy; "Update Wikibase, Diff, DataValues" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63833 [19:00:49] <gerrit-wm> Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63833 [19:02:35] <gerrit-wm> New patchset: Jeroen De Dauw; "Added PHPUnit test configuration file [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63897 [19:04:58] <gerrit-wm> New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63789 [19:05:42] <gerrit-wm> New patchset: Jeroen De Dauw; "Added PHPUnit test configuration file [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63897 [19:06:21] <gerrit-wm> New patchset: Aaron Schulz; "[JobQueue] In addition to flushing any transaction, be sure to avoid new ones" [mediawiki/core] (REL1_21) - https://gerrit.wikimedia.org/r/63899 [19:10:38] <gerrit-wm> New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63789 [19:22:23] <gerrit-wm> New review: TheDJ; "I'd rather not split it out, the dependency stuff is too much git voodoo mess that I don't want to d..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [19:25:57] <gerrit-wm> New patchset: TheDJ; "OutputPage: Use If-None-Match header to determine 304 Not Modified" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/60440 [19:34:59] <gerrit-wm> New patchset: Jeroen De Dauw; "fixed comments" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63903 [19:35:33] <gerrit-wm> New patchset: Jeroen De Dauw; "Increment version nr" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63904 [19:36:04] <gerrit-wm> New patchset: Bsitu; "(bug 48302) Broken link in plain text email notification" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63905 [19:36:17] <gerrit-wm> New review: Jeroen De Dauw; "self merge, for great justice" [mediawiki/extensions/EducationProgram] (master) C: 2; - https://gerrit.wikimedia.org/r/63903 [19:36:28] <gerrit-wm> New review: Jeroen De Dauw; "self merge, for great justice" [mediawiki/extensions/EducationProgram] (master) C: 2; - https://gerrit.wikimedia.org/r/63904 [19:36:41] <gerrit-wm> Change merged: Jeroen De Dauw; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63904 [19:36:54] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63903 [19:39:51] <gerrit-wm> New patchset: Amire80; "Revert "Avoid duplicate languagesettings dialog in page source"" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63906 [19:58:16] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/63906 [20:00:27] <gerrit-wm> New patchset: Aaron Schulz; "Fixed bug where FORCE INDEX did not make it to the SQL." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63911 [20:01:49] <gerrit-wm> New patchset: Aaron Schulz; "Fixed bug where FORCE INDEX did not make it to the SQL." [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63912 [20:03:08] <gerrit-wm> New review: TheDJ; "2 small documentation hiccups" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/63378 [20:05:20] <gerrit-wm> Change merged: Aaron Schulz; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63912 [20:05:37] <gerrit-wm> New review: Mattflaschen; "On piramido for testing." [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63832 [20:08:09] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63911 [20:10:35] <wmf-selenium-bot> Yippie, build fixed! [20:10:36] <wmf-selenium-bot> Project browsertests-en.wikipedia.org-linux-firefox build #62: FIXED in 2 min 50 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-firefox/62/ [20:12:10] <wmf-selenium-bot> Yippie, build fixed! [20:12:11] <wmf-selenium-bot> Project browsertests-sandbox.translatewiki.net-linux-chrome build #43: FIXED in 1 min 51 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-chrome/43/ [20:12:36] <wmf-selenium-bot> Yippie, build fixed! [20:12:36] <wmf-selenium-bot> Project browsertests-sandbox.translatewiki.net-linux-firefox build #68: FIXED in 2 min 0 sec: https://wmf.ci.cloudbees.com/job/browsertests-sandbox.translatewiki.net-linux-firefox/68/ [20:13:08] <gerrit-wm> New review: Bsitu; "(1 comment)" [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63789 [20:13:22] <wmf-selenium-bot> Project MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox build #23: FAILURE in 1 min 11 sec: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/23/ [20:13:45] <AaronSchulz> ^demon|lunch: https://gerrit.wikimedia.org/r/#/c/63891/ 1 line fix [20:17:24] <gerrit-wm> New patchset: Aaron Schulz; "Fixed total breakage of HashRing in 9d1cd9a." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63891 [20:17:46] <gerrit-wm> New review: Aaron Schulz; "Just fixed summary typo" [mediawiki/core] (master) C: 2; - https://gerrit.wikimedia.org/r/63891 [20:18:58] <gerrit-wm> New patchset: Jeroen De Dauw; "Improvements to enrollment code [DO NOT MERGE]" [mediawiki/extensions/EducationProgram] (master) - https://gerrit.wikimedia.org/r/63914 [20:21:43] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63891 [20:39:05] <gerrit-wm> New review: FastLizard4; "Looks good, though unfortunately I won't be able to verify or CR+2 this until the permissions on thi..." [mediawiki/extensions/CommunityTwitter] (master) C: 1; - https://gerrit.wikimedia.org/r/63642 [20:39:50] <gerrit-wm> New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63918 [20:40:16] <gerrit-wm> Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63918 [20:41:40] <Reedy> MaxSem: Are you scapping? [20:42:15] <MaxSem> Reedy, just deploying some MF fixes with greg-g's permission [20:42:17] <MaxSem> no scap [20:42:22] <Reedy> Hmm. Either way, I should clean up the wikidata deploy [20:42:51] * MaxSem can wait:) [20:43:04] <gerrit-wm> New patchset: Reedy; "Revert "Update Wikibase, Diff, DataValues"" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63920 [20:43:25] <gerrit-wm> New patchset: Reedy; "Revert "Update Wikibase, Diff, DataValues"" [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63920 [20:43:34] <gerrit-wm> Change merged: Reedy; [mediawiki/core] (wmf/1.22wmf4) - https://gerrit.wikimedia.org/r/63920 [20:44:59] <Reedy> Reverted, thanks [20:50:59] <gerrit-wm> Change abandoned: FastLizard4; "Reedy fixed this directly, this change therefore rendered unnecessary. Thanks, Reedy!" [mediawiki/extensions/CommunityTwitter] (refs/meta/config) - https://gerrit.wikimedia.org/r/63820 [20:51:34] <gerrit-wm> New patchset: MaxSem; "Update MobileFrontend to production tip" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63922 [20:51:54] <gerrit-wm> Change merged: MaxSem; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63922 [20:56:05] <MaxSem> Reedy & greg-g, I'm done. thanks! [20:56:12] <greg-g> wee [21:02:17] <gerrit-wm> New patchset: GWicke; "Add Parsoid-specific tests for link trail and -prefix escaping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63926 [21:04:43] <gerrit-wm> New patchset: GWicke; "Add Parsoid-specific tests for link trail and -prefix escaping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63926 [21:05:28] <gerrit-wm> New patchset: GWicke; "Add Parsoid-specific tests for link trail and -prefix escaping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63926 [21:06:56] <gerrit-wm> New patchset: Adamw; "WIP refactor controller logic into adapters" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/63932 [21:08:15] <gerrit-wm> New patchset: GWicke; "Add Parsoid-specific tests for link trail and -prefix escaping" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63926 [21:37:10] <gerrit-wm> Change abandoned: Spage; "Superseded by other work" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/60787 [21:38:14] <gerrit-wm> New patchset: MaxSem; "Bug 48488: More fractional tweaks" [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/63972 [21:45:33] <Krinkle> RoanKattouw: Why is MediaWiki adding horrible CDATA tags to the html output? I've never seen it do that until now [21:45:36] <Krinkle> <script>/*<![CDATA[*/window.jQuery && jQuery.ready();/*]]>*/</script><script>if(window.mw){ [21:45:36] <Krinkle> mw.loader.state({"site":"loading","user":"ready","user.groups":"loading"}); [21:45:49] <Krinkle> It happened when I added "window.jQuery &&" earlier this week. [21:45:53] <Krinkle> I suppose it has to do with XML compat [21:45:55] <Krinkle> ugh [21:47:09] <gerrit-wm> New patchset: Yurik; "Zero update" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63976 [21:47:34] <MatmaRex> Krinkle: i think you're supposed to escape every '&' in HTML as well [21:47:44] <MatmaRex> Krinkle: even in <script>s, or in <a href=...> [21:47:49] <Krinkle> MatmaRex: Browsers don't care really, not even in regular <a> tags [21:47:57] <Krinkle> But yeah, the W3 spec says so [21:47:58] <MatmaRex> oh, of course [21:48:08] <Krinkle> but then we should do that, and not use CDATA [21:48:22] <MatmaRex> CDATA might be simpler [21:48:24] <Krinkle> I guess something is inspecting the contents and adding CDATA if it contains special characgters [21:48:26] <MatmaRex> also, browsers don't care :P [21:48:37] <gerrit-wm> Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63976 [21:48:47] <Krinkle> because that sure as hell wasn't there last week [21:48:56] <MatmaRex> most likely [21:49:00] <Krinkle> if ( $wgWellFormedXml && preg_match( '/[<&]/', $contents ) ) { [21:49:03] <Krinkle> Html::inlineScript [21:49:44] <MatmaRex> Krinkle: honest question - why do you care? :P [21:50:36] <Krinkle> CDATA makes it look bad, in my eyes it is as wrong as using Windows 3.11 or outputting obsolete/deprecated/useless LANGUAGE="JavaScript" attributes. [21:50:44] <Krinkle> HTML 3.11 [21:50:55] <Krinkle> It's one of those things usually associated with old stuff from the 90s [21:51:16] <Krinkle> I suppose this particular part wasn't all that wrong, just something that usually came with the package of geocities/macromedia horror. [21:51:18] <MatmaRex> is it? i'd call it a useful underused feature [21:51:22] <RoanKattouw> Krinkle: $wgWellFormedXml is not set on most wikis I don't think [21:51:27] <RoanKattouw> I think it's disabled by default [21:51:57] <Krinkle> RoanKattouw: wmf yes, mw no [21:52:14] <Krinkle> anyhow, good to know it won't clobber productino. [21:53:38] <robla> marktraceur: bug 48515 looks pretty severe. I'm assuming it's 1.22wmf4 related due to timing. Do you think you'll have a quick fix, or should we revert? [21:53:43] <Krinkle> MatmaRex: I mean, CDATA itself isn't all that wrong, but "nobody" uses it, I've only ever seen it used in a context with lots of horrible things. Animating backgrounds and under construction images come to mind :) [21:54:14] <Krinkle> / [21:54:18] <Krinkle> * Because of compatibility with screen-scraping bots, and because it's [21:54:18] <Krinkle> * controversial, this is currently left to true by default. [21:54:43] <MatmaRex> Krinkle: well, you could make a similar "nobody uses it" argument for protocol-relative urls [21:54:53] <MatmaRex> also, we should totally kill wgWellFormedXml [21:55:14] <Krinkle> MatmaRex: I disagree, but it is all relative to what you personally have experienced. [21:55:27] <MatmaRex> probably. [21:55:37] <Krinkle> I've only ever seen protocol-relative urls in awesome environments :) quite rate but usually comes along lots of good practices. [21:55:55] <MatmaRex> Krinkle: yeah [21:56:02] <MatmaRex> also, screen-scraping bots? come on, we've made incompatible html changes before [21:56:13] <MatmaRex> let's kill it [21:56:22] <gerrit-wm> New review: GWicke; "(1 comment)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/58113 [21:56:36] <Krinkle> MatmaRex: It is diabled by default in wmf [21:56:58] <Krinkle> MatmaRex: The default itself is useful and cheap to keep. But I agree it should be disabled by default and the bots argument isn't valid for sure [21:57:05] <Krinkle> the feature itself* [21:57:23] <gerrit-wm> New patchset: Yurik; "Revert "Zero update"" [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63978 [21:57:37] <gerrit-wm> Change merged: Yurik; [mediawiki/core] (wmf/1.22wmf3) - https://gerrit.wikimedia.org/r/63978 [22:02:49] <marktraceur> robla: It looked like it was just a cache issue, but since it's affecting gadgets as well it looks like it might be a mw.hook problem [22:03:14] <marktraceur> !b 48515 | Krinkle, do you think mw.hook might be broken on commons? See [22:03:14] <wm-bot> Krinkle, do you think mw.hook might be broken on commons? See: https://bugzilla.wikimedia.org/48515 [22:03:16] <gerrit-wm> New review: Swalling; "Per my comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=47883 let's hold off on this until ..." [mediawiki/core] (master) C: -2; - https://gerrit.wikimedia.org/r/63263 [22:07:37] <marktraceur> I guess it could *still* be a cache issue, but almost certainly not [22:08:31] <greg-g> marktraceur: looks nasty [22:08:41] <marktraceur> greg-g: You're not kidding [22:08:51] <greg-g> unless we can get a fix in quickly (like, end of day today) we should revert [22:08:56] <marktraceur> greg-g: Reedy had reverted, but since it looked cache-y I had him unrevert [22:08:59] <greg-g> oh [22:09:02] <greg-g> ohoh [22:09:32] <greg-g> well, has it lost it's cache-y-ness? and shall we ununrevert (rerevert) [22:09:49] <marktraceur> I think rerevert is a good way to go for the time being [22:10:29] <robla> can we repro the problem on test2? [22:10:36] <aude> weird that it worked with debug=true [22:11:56] <marktraceur> robla: Neither testwiki has the same problem [22:12:11] <greg-g> ugh [22:12:47] <marktraceur> And there's no change, that I can see, that would cause this, at least not in UW [22:12:55] <marktraceur> It must be related to the mw.hook patch [22:13:11] <greg-g> marktraceur: which patch? [22:13:38] <aude> is it a problem logged out? [22:14:12] <aude> seems so [22:14:31] <marktraceur> greg-g: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=296f62db7405e7f079dd9f54630464d401ec3512 [22:14:43] <marktraceur> AKA https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=2e970257deedbea55987935146b5bc71af21525c [22:16:22] <Krinkle> marktraceur: Don't know, I'm busy right now [22:17:26] <marktraceur> *sigh* K, I'll look at mw.hook. [22:17:35] <robla> Krinkle: production is pretty broken right now, and it's plausible that your commit did [22:17:41] <robla> *did it [22:18:24] <robla> we can revert https://gerrit.wikimedia.org/r/#/c/56762/ as a stopgap, perhaps [22:18:27] <Krinkle> robla: What is broken exactly? I can navigate pages and see no javascript errors. [22:18:27] <aude> looks like it to me [22:18:35] <Krinkle> I'll look into it. [22:18:37] <Krinkle> bug report? [22:18:37] <Krinkle> info? [22:18:44] <marktraceur> !b 48515 [22:18:44] <wm-bot> https://bugzilla.wikimedia.org/48515 [22:18:44] <robla> !b 48515 [22:18:45] <wm-bot> https://bugzilla.wikimedia.org/48515 [22:18:51] <marktraceur> Jinx [22:19:11] * greg-g grumbles, he's been disconnected for a couple minutes due to WMF wifi [22:19:40] <Krinkle> robla: I don't think that change is causing this [22:19:50] <Krinkle> It can't [22:20:13] <Krinkle> robla: Hm... weird, on commons I see the error on every page [22:20:30] <Krinkle> But not in master, mediawiki.org and localhost [22:21:01] <marktraceur> Hrm. [22:21:09] <Krinkle> marktraceur: mw.hook is defined in mediawiki.js [22:21:27] <Krinkle> marktraceur: Why is Commons referencing mw.hook from mw.util when it isn't in that branch yet [22:21:40] <Krinkle> marktraceur: http://cl.ly/image/0W183p0V2J32 [22:22:02] <hoo> "// If the code is under test, don't call out to other sites, just normalize locally." -.- [22:22:07] <Krinkle> Looks like something was either half backported [22:22:32] <Reedy> half backported? [22:22:34] <Reedy> it's on wmf4 [22:22:40] <Krinkle> commons as well? [22:22:41] <Reedy> branched from master on monday... [22:22:43] <marktraceur> Krinkle: mw.hook was merged in 1.22wmf4, though. If you run with debug=true you'll see it working fine. [22:22:46] <greg-g> Krinkle: as of today yes [22:22:54] <Krinkle> marktraceur: In that case it can only be one thing [22:23:05] <marktraceur> What's that? [22:23:08] <greg-g> ... [22:23:16] <Krinkle> It got cached while scap was still running, the file calling it was there at the cache hit. the file defining it not yet. [22:23:34] <marktraceur> Hm. [22:23:37] <Krinkle> This is why I've been saying that our scap / sync process is fundementally broken and has been for years. [22:23:55] <Krinkle> We can just sync to a machine that is actively serving requests. [22:24:11] <Reedy> Which is what git-deploy was supposed to solve [22:24:15] <greg-g> right [22:24:21] <Krinkle> on the server side this can only cause magnificient failures for a short period of time, but for caching it is fatal for a long time. [22:24:23] <greg-g> but, so, for now, do we just invalidate some caches? [22:24:31] <Krinkle> I'm on it. [22:24:33] <greg-g> thanks [22:24:42] <greg-g> pontificate on solutions later ;) [22:25:26] <Krinkle> $ sync-file php-1.22wmf4/resources/mediawiki/mediawiki.js 'touch' [22:25:26] <Krinkle> scap is disabled on fenari, use tin instead [22:25:41] <greg-g> right [22:25:49] <Krinkle> reading engineering-l [22:26:06] <greg-g> https://wikitech.wikimedia.org/wiki/How_to_deploy_code is up to date [22:26:28] <Reedy> I'm suprised someone hasn't written a touch wrapper for sync file [22:26:30] <greg-g> Krinkle: ^ (to save you the long thread) [22:26:36] <Reedy> ssh -A tin [22:26:39] <Reedy> cd /a/common [22:26:43] <Krinkle> the documentation says to use sync-file [22:26:50] <Reedy> touch php-1.22wmf4/resources/mediawiki/mediawiki.js [22:26:51] <Krinkle> I assume that those sync-* wrappers have been updated [22:26:52] <Reedy> sync-file php-1.22wmf4/resources/mediawiki/mediawiki.js [22:27:05] <Krinkle> oh, tin is a machine, not a program [22:27:11] <Reedy> lol. [22:27:14] <greg-g> Krinkle: yes, to use sync on tin [22:27:16] <greg-g> :) [22:27:43] <Reedy> It's al element, so it's likely a machine [22:29:05] <Krinkle> the error is rather ambiguous [22:29:14] <Krinkle> " scap is disabled on fenari, use tin instead" [22:29:16] <Krinkle> scap -> tin :) [22:29:19] <Krinkle> synced [22:29:20] <greg-g> sure, but there were emails :) [22:29:22] <Reedy> fenari -> tin [22:29:23] <greg-g> thanks [22:29:26] <Reedy> either is plausible [22:29:48] <Reedy> morebots said nothing.. [22:29:54] <Krinkle> It does it when it finishes [22:29:55] <Reedy> uh, logmsgbot [22:29:57] <Krinkle> we should change that [22:30:03] <Krinkle> to log at the start [22:30:22] <Krinkle> not after 100s of connections and timeouts and stuff [22:30:24] <marktraceur> Still broked for me [22:30:48] <Krinkle> marktraceur: next time the startup module recalculates it will be incuded [22:30:49] <Krinkle> included* [22:30:51] <Krinkle> which is 5 minutes [22:30:56] <Krinkle> (max) [22:31:00] <marktraceur> KK [22:31:20] * greg-g sets timer [22:31:26] <Reedy> marktraceur: keep mashing f5 [22:31:37] <Krinkle> Note that it is merely a miracle that we haven't gotten fatal errors of persitent nature like these more often [22:31:42] <marktraceur> Reedy: I'm just doing my part to stress test the cluster [22:32:19] <gerrit-wm> New review: Mattflaschen; "Mostly minor, except that I looked into it, and you can ask the HTTP libraries whether it failed due..." [mediawiki/extensions/Math] (master) C: -1; - https://gerrit.wikimedia.org/r/61987 [22:33:26] <Krinkle> Any time you sync more than 1 file it is a possible that users will get fatal php errors or js errors. And whereas php is evaluated server-side and squid will not cache http 500, js errors are not known until later and varnish will cache it on first hit [22:33:35] <Krinkle> robla: greg-g: Reedy: marktraceur: ^ [22:34:04] <gerrit-wm> New review: Mattflaschen; "(1 comment)" [mediawiki/extensions/Math] (master) - https://gerrit.wikimedia.org/r/61987 [22:34:22] <Krinkle> Reedy: btw, git-deploy doesn't temporarily depool machines from LVS, right? So it'll only be less likely to happen [22:34:49] <Reedy> It updates and then switches to the branch AFTER all the files are updated [22:34:58] <greg-g> agree on principle/theory of what your saying, I'm still waiting for the module recalculations... [22:35:15] <Krinkle> I've been thinking about progressive roll out where machines are gracefully depooled and synced and re-poooled so that never more than X % is dopooled. [22:35:24] <greg-g> fixed [22:35:32] <greg-g> marktraceur: confirm? [22:35:39] <marktraceur> Confirm [22:35:57] <robla> thanks Krinkle, marktraceur, Reedy, and greg-g [22:35:59] <greg-g> thanks Krinkle [22:36:12] <greg-g> and thanks for debugging marktraceur and Reedy :) [22:37:32] <robla> are there any short-term workarounds to make this more robust? e.g. should we routinely touch the .js files after a deploy? [22:38:37] <marktraceur> Maybe the more widely-used ones like mediawiki.js, but I don't see any reason to touch mw.UploadWizardUploadInterface.js for example [22:38:39] <Krinkle> robla: That could be causing the problem in cases it didn't [22:38:46] <Krinkle> it's a race condition [22:38:55] <greg-g> :/ [22:40:05] <Krinkle> The only solution is to ensure that while syncing is in progress nothing is using the mediawiki install for anything [22:40:23] <gerrit-wm> New patchset: Jdlrobson; "Give skin more control of OutputPage modules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/63584 [22:40:30] <gerrit-wm> New patchset: Tim Starling; "Revert "(bug 46615) updateCollation.php: sanity check the collation before proceeding"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57500 [22:40:37] <robla> are weekly deploys going to exacerbate this problem? [22:40:41] <gerrit-wm> Change merged: Tim Starling; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/57500 [22:40:59] <Krinkle> race conditions are more likely to happen the more often we roll the dice, yes. [22:41:52] <Reedy> greg-g: ^ Less deployments needed! [22:42:07] <Krinkle> robla: Since our PHP files are less of a concern (since squid won't cache error responses from apache, it'd be limited to a very limited number of requests and only once) - I think for js it is pretty crucial [22:42:13] <greg-g> Proposal: Let's move to yearly deploys [22:42:20] <Krinkle> however most apaches don't serve bits.wikimedia.org [22:42:22] <Reedy> That's too frequent [22:42:30] <Krinkle> so it is relatively easy to mitigate it just for bits [22:43:02] <greg-g> Krinkle: by post scap touching? or something else you have in mind? [22:43:12] <Krinkle> we only have like 4 apaches running backend of bits right? We'd have to change deploy process to e.g. gracefully depool 2 of them, sync, repool and then the other 2. [22:43:25] * greg-g nods [22:43:47] <Reedy> 4 in each of eqiad and pmtpa [22:43:47] <Krinkle> greg-g: no, touching isn't a solution, it only works afterwards to fix the problem, and even then it only works if you touch them in the right order (order of dependencies) [22:43:54] <greg-g> gotcha [22:44:23] <Krinkle> anyhow, I'm going back to the VisualEditor sprint now [22:44:31] <greg-g> :) thanks [22:44:41] <robla> thanks Krinkle....sorry for taking you away from that [23:03:45] <gerrit-wm> New patchset: Mattflaschen; "Exclude current article when you choose "Try another"" [mediawiki/extensions/GettingStarted] (master) - https://gerrit.wikimedia.org/r/63984 [23:03:59] <wmf-selenium-bot> Project browsertests-en.wikipedia.org-linux-chrome build #61: FAILURE in 2 min 19 sec: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.org-linux-chrome/61/ [23:16:43] <gerrit-wm> New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [23:17:09] <gerrit-wm> New patchset: Mwalker; "Set LandingPages value on page load" [mediawiki/extensions/CentralNotice] (master) - https://gerrit.wikimedia.org/r/63995 [23:19:15] <gerrit-wm> New review: Kaldari; "This won't be necessary if we merge https://gerrit.wikimedia.org/r/#/c/63993/" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/62118 [23:23:18] <gerrit-wm> New patchset: Kaldari; "Switch to using our own badge instead of jQuery.badge" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63993 [23:24:55] <gerrit-wm> New review: EBernhardson; "(1 comment)" [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/63076 [23:38:18] <gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/GeoData] (master) - https://gerrit.wikimedia.org/r/63972 [23:50:29] <gerrit-wm> New review: Mattflaschen; "I would use addModuleStyles; the current version isn't portable. There's another possible suggestion." [mediawiki/extensions/Echo] (master) C: -1; - https://gerrit.wikimedia.org/r/63993